Page MenuHomePhabricator

danchr (Dan Villiom Podlaski Christiansen)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2019, 4:38 AM (108 w, 3 d)

Recent Activity

Sat, Sep 11

danchr added a comment to D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.

The two wrappers make sense, although it seems random to encode the query as {} in one case and None in other case

Sat, Sep 11, 12:12 PM
danchr added a comment to D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.

Thanks for bringing this up. Does that represent a large amount of work for you?

Well, my main challenge here is that I have absolutely no idea what's going on — I don't have much experience with the very low levels of networking in Mercurial, or the (relatively) new peer API. It seems to me that the point of that code is, essentially, to provide a minimal repository or peer that does nothing. Could something like that be moved to Mercurial core?

Sat, Sep 11, 9:31 AM

Tue, Sep 7

danchr added a comment to D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.

I don't think the backwards compatibility concerns are too bad, but I might be wrong.

Please note that this breaks hg-git, as it currently relies on the future for wrapping a repository. We'll probably have to come up with a wrapper regardless.
See e.g. https://foss.heptapod.net/mercurial/hg-git/-/blob/branch/default/hggit/gitrepo.py#L113

Thanks for bringing this up. Does that represent a large amount of work for you?

Tue, Sep 7, 10:27 AM

Fri, Aug 27

danchr added a comment to D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.

I don't think the backwards compatibility concerns are too bad, but I might be wrong.

Fri, Aug 27, 10:52 AM

Mar 11 2021

danchr added inline comments to D10161: push: allow to specify multiple destinations.
Mar 11 2021, 12:12 PM

Feb 9 2021

danchr added a comment to D9725: ci: generate and report XML test results.

This looks fine, but could you describe a bit what this is suppose to achieve and maybe provide a link to an example ?

Feb 9 2021, 12:35 PM

Jan 22 2021

danchr updated the diff for D9852: rust: lower compile error on non-linux platforms to a warning.
Jan 22 2021, 5:19 AM
danchr updated the summary of D9852: rust: lower compile error on non-linux platforms to a warning.
Jan 22 2021, 5:18 AM
danchr created D9852: rust: lower compile error on non-linux platforms to a warning.
Jan 22 2021, 5:15 AM

Jan 15 2021

danchr added a comment to D9640: setup: when possible, build and bundle man pages.

This breaks the build; could you please unapply it while I investigate?

Jan 15 2021, 7:48 AM

Jan 12 2021

danchr added a comment to D9670: rust: fix testing with $TMPDIR ≠ /tmp.

What is this patch doing ? Should we add some comment in the code to explain the rationnal around the skip thingy ?

Thinking about it some more, this should just use https://doc.rust-lang.org/std/path/struct.Path.html#method.strip_prefix

Jan 12 2021, 7:09 AM
danchr created D9727: ci: report status to phabricator on failures.
Jan 12 2021, 7:08 AM
danchr created D9726: ci: use parallel matrices.
Jan 12 2021, 7:08 AM
danchr created D9725: ci: generate and report XML test results.
Jan 12 2021, 7:07 AM
danchr created D9724: ci: build python wheels.
Jan 12 2021, 7:07 AM
danchr created D9722: setup: don't import distutils prior to checking FORCE_SETUPTOOLS.
Jan 12 2021, 7:07 AM
danchr created D9723: ci: avoid a global before_script definition.
Jan 12 2021, 7:07 AM
danchr updated the summary of D9640: setup: when possible, build and bundle man pages.
Jan 12 2021, 7:07 AM

Jan 9 2021

danchr added a comment to D9671: rust: fix file folding map.

I'm not a big fan of the idea of people using this version with incomplete normalization by lifting the compiler error since it may cause bugs, wrong repo states or even security issues.

Jan 9 2021, 10:39 PM
danchr added a comment to D9640: setup: when possible, build and bundle man pages.

This looks good.

Jan 9 2021, 10:29 PM
danchr updated the diff for D9640: setup: when possible, build and bundle man pages.
Jan 9 2021, 10:27 PM

Dec 30 2020

danchr added a comment to D9671: rust: fix file folding map.

As a minor addendum: With this change, the Rust dirstate code almost works with case folding, but has issues detecting folded directory names. This appears mostly unimplemented AFAICT.

Dec 30 2020, 7:38 AM
danchr updated the test plan for D9671: rust: fix file folding map.
Dec 30 2020, 7:05 AM
danchr added a comment to D8937: rust: enable on macOS.

Looks like we should take the change to dirstate_map.rs (in its own changesets) and delay the change to rust/hg-core/src/lib.rs, right? @danchr can you split this?

Dec 30 2020, 7:02 AM
danchr created D9671: rust: fix file folding map.
Dec 30 2020, 7:01 AM
danchr created D9670: rust: fix testing with $TMPDIR ≠ /tmp.
Dec 30 2020, 7:01 AM

Dec 22 2020

danchr updated the summary of D9639: tags: describe all abnormal tag types in `hg tags -v`.
Dec 22 2020, 7:30 AM
danchr updated the summary of D9638: clone: update to active bookmark, if set.
Dec 22 2020, 7:30 AM
danchr updated the summary of D9638: clone: update to active bookmark, if set.
Dec 22 2020, 7:29 AM

Dec 21 2020

danchr added a comment to D8937: rust: enable on macOS.

I actually hadn't noticed that you kept discussing this prior to abandoning it. I'm busy with other things, though, so I won't be able to follow up on this.

Dec 21 2020, 2:10 PM
danchr created D9640: setup: when possible, build and bundle man pages.
Dec 21 2020, 11:11 AM

Dec 20 2020

danchr abandoned D8937: rust: enable on macOS.
Dec 20 2020, 1:37 PM
danchr created D9639: tags: describe all abnormal tag types in `hg tags -v`.
Dec 20 2020, 1:35 PM
danchr created D9638: clone: update to active bookmark, if set.
Dec 20 2020, 1:34 PM

Oct 29 2020

danchr created D9261: push: add --all-bookmarks option.
Oct 29 2020, 9:17 AM
danchr retitled D9257: commit: warn the user when a commit already exists from commit, backout: warn the user when a commit already exists to commit: warn the user when a commit already exists.
Oct 29 2020, 8:57 AM
danchr created D9260: i18n: fix coding tag unsupported by xgettext.
Oct 29 2020, 8:56 AM
danchr created D9259: py3: hggettext.
Oct 29 2020, 8:56 AM
danchr updated the diff for D9257: commit: warn the user when a commit already exists.
Oct 29 2020, 3:11 AM
danchr updated the diff for D9253: commit: don't change phases for preexisting commits.
Oct 29 2020, 3:10 AM
danchr created D9257: commit: warn the user when a commit already exists.
Oct 29 2020, 3:05 AM
danchr added a comment to D9256: backout: don't assume that tip as what we just committed.

Does this fix a defect? The test makes it seem like it does?

Oct 29 2020, 3:04 AM
danchr updated the diff for D9256: backout: don't assume that tip as what we just committed.
Oct 29 2020, 3:04 AM
danchr updated the summary of D9253: commit: don't change phases for preexisting commits.
Oct 29 2020, 3:03 AM

Oct 28 2020

danchr updated the summary of D9253: commit: don't change phases for preexisting commits.
Oct 28 2020, 9:07 PM
danchr created D9256: backout: don't assume that tip as what we just committed.
Oct 28 2020, 9:07 PM
danchr updated the diff for D9253: commit: don't change phases for preexisting commits.
Oct 28 2020, 11:23 AM
danchr updated the diff for D9253: commit: don't change phases for preexisting commits.
Oct 28 2020, 11:22 AM
danchr created D9253: commit: don't change phases for preexisting commits.
Oct 28 2020, 11:19 AM

Aug 26 2020

danchr updated the summary of D8937: rust: enable on macOS.
Aug 26 2020, 1:32 PM

Aug 24 2020

danchr updated the summary of D8937: rust: enable on macOS.
Aug 24 2020, 3:52 PM

Aug 21 2020

danchr added a comment to D8937: rust: enable on macOS.

What do you mean by "mishandling removed files"? The fold map is there to give a mapping between the normalized (internal) representation of file paths and the actual ones on disk. As much as I hate the dirstate code, this is a useful part of the software that is triggered depending on your filesystem and paths used.

Aug 21 2020, 11:49 AM

Aug 19 2020

danchr created D8937: rust: enable on macOS.
Aug 19 2020, 11:52 AM