Page MenuHomePhabricator

dlax (Denis Laxalde)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2017, 6:32 AM (94 w, 1 d)

Recent Activity

Apr 8 2019

dlax committed rHG1721b92f2b5e: match: make arguments of _expandsets() optional.
match: make arguments of _expandsets() optional
Apr 8 2019, 2:50 PM
dlax committed rHG2e2699af5649: match: let regex match function return a boolean.
match: let regex match function return a boolean
Apr 8 2019, 2:50 PM
dlax committed rHG54e6d7ef5ca5: match: make _donormalize's auditor and warn arguments optional.
match: make _donormalize's auditor and warn arguments optional
Apr 8 2019, 2:50 PM
dlax committed rHGbee1647578b7: match: complete documentation of match() parameters.
match: complete documentation of match() parameters
Apr 8 2019, 2:50 PM
dlax committed rHG42537dfc7a7c: match: add doctest examples in match().
match: add doctest examples in match()
Apr 8 2019, 2:50 PM
dlax committed rHGbf777c1e78dd: match: add a docstring with doctest examples to patternmatcher.
match: add a docstring with doctest examples to patternmatcher
Apr 8 2019, 2:50 PM
dlax committed rHG413a75da98ce: match: add doctest examples for patkind().
match: add doctest examples for patkind()
Apr 8 2019, 2:50 PM
dlax committed rHGf3db5c805a67: match: add doctest examples for exactmatcher.
match: add doctest examples for exactmatcher
Apr 8 2019, 2:50 PM

Apr 5 2019

dlax committed rHGdb72f9f6580e: interactive: do not prompt about files given in command line.
interactive: do not prompt about files given in command line
Apr 5 2019, 7:57 AM

Jun 8 2018

dlax accepted rHG1e9c357d3ddf: phase: clarify the message about movement on command changeset.
Jun 8 2018, 3:54 PM

May 30 2018

dlax committed rHGeb9835014d20: transaction-summary: show phase changes statistics in pull/unbundle.
transaction-summary: show phase changes statistics in pull/unbundle
May 30 2018, 7:33 AM

Feb 16 2018

dlax added a comment to D2282: util: extract all date-related utils in utils/dateutil module.

lothiraldan (Boris Feld) wrote:

I have but I'm always very cautious when creating a new package with the
name of an old module. .pyc/.pycache files may still be there both for
Mercurial developers and for Mercurial users using their deb/rpm package.
I may be wrong, but if we could avoid weird bugs, I would prefer put in
the utils package.

Feb 16 2018, 4:41 AM
dlax added inline comments to D2280: remotenames: port partway to python3 by using collections.MutableMapping.
Feb 16 2018, 3:06 AM
dlax added a comment to D2282: util: extract all date-related utils in utils/dateutil module.

Having both a util module and a utils package looks weird.
Have you considered moving util.py into util/__init__.py and then adding new modules under util package?

Feb 16 2018, 2:59 AM

Feb 14 2018

dlax committed rHG39b3aab6231e: revert: use an exact matcher in interactive diff selection (issue5789).
revert: use an exact matcher in interactive diff selection (issue5789)
Feb 14 2018, 9:02 AM
dlax committed rHGa228b2f55ad6: tests: add a test demonstrate that 'revert -i' ignores nonexistent patterns.
tests: add a test demonstrate that 'revert -i' ignores nonexistent patterns
Feb 14 2018, 9:02 AM

Feb 11 2018

dlax committed rHGdae84ccebc57: tests: fix check for --graph option in test-log-linerange.t.
tests: fix check for --graph option in test-log-linerange.t
Feb 11 2018, 7:35 PM
dlax added a comment to D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.

sangeet259 (Sangeet Kumar Mishra) wrote:

@dlax https://phab.mercurial-scm.org/p/dlax/ Yes, but the short
summary didn't say what it does! It just says "include the specified
changeset".

Feb 11 2018, 1:29 PM

Feb 10 2018

dlax committed rHG24f05489377b: rebase: make "successors" a set in _computeobsoletenotrebased().
rebase: make "successors" a set in _computeobsoletenotrebased()
Feb 10 2018, 10:48 PM
dlax committed rHGb7e2cf114e85: rebase: do not consider extincts for divergence detection (issue5782).
rebase: do not consider extincts for divergence detection (issue5782)
Feb 10 2018, 7:38 AM
dlax committed rHGae0d25071fca: rebase: eliminate node from successors early in _computeobsoletenotrebased().
rebase: eliminate node from successors early in _computeobsoletenotrebased()
Feb 10 2018, 7:38 AM
dlax committed rHGa603a570cdbe: rebase: add a test case for issue5782.
rebase: add a test case for issue5782
Feb 10 2018, 7:38 AM

Feb 9 2018

dlax added a comment to D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.

As mentioned in the issue, there's already an explanation paragraph in help:

Feb 9 2018, 9:43 AM

Dec 8 2017

dlax added a comment to D1616: rebase: disable `inmemory` if the rebaseset contains the working copy.

@dlax I see a request changes here, but I don't see any commentary as to why?

Dec 8 2017, 2:33 PM
dlax added inline comments to D1249: rebase: rerun a rebase on-disk if IMM merge conflicts arise.
Dec 8 2017, 2:29 PM
dlax added a comment to D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase.

dlax (Denis Laxalde) wrote:

Also, would be nice to have some test coverage.
Dec 8 2017, 5:01 AM
dlax accepted D1617: rebase: extract _assignworkingcopy.
Dec 8 2017, 4:45 AM
dlax requested changes to D1616: rebase: disable `inmemory` if the rebaseset contains the working copy.
Dec 8 2017, 4:44 AM
dlax requested changes to D1249: rebase: rerun a rebase on-disk if IMM merge conflicts arise.
Dec 8 2017, 4:40 AM
dlax requested changes to D1245: rebase: pass wctx to rebasenode().
Dec 8 2017, 4:29 AM
dlax requested changes to D1246: rebase: do not update if IMM; instead, set the overlaywctx's parents.

Needs test.

Dec 8 2017, 4:29 AM
dlax requested changes to D1244: overlayworkingctx: invalidate the manifest cache when changing parents.
Dec 8 2017, 4:23 AM
dlax added inline comments to D1244: overlayworkingctx: invalidate the manifest cache when changing parents.
Dec 8 2017, 4:23 AM
dlax added inline comments to D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase.
Dec 8 2017, 3:43 AM

Dec 7 2017

dlax accepted D1610: ui: add diff.showfunc to tweakdefaults.
Dec 7 2017, 2:59 AM

Dec 6 2017

dlax accepted D1063: rebase: enable multidest by default.
Dec 6 2017, 3:16 AM

Dec 1 2017

dlax requested changes to D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase.

In the future, the --inmemory flag might be deprecated in favor of something more intelligent

Dec 1 2017, 4:01 AM
dlax accepted D1211: context: switch ctx() use to changectx().
Dec 1 2017, 3:56 AM

Nov 30 2017

dlax added a comment to D939: remotenames: add functionality to store remotenames under .hg/hgremotenames/.

pulkit (Pulkit Goyal) a écrit :

Updated the series with new differentials D1547
https://phab.mercurial-scm.org/D1547 to D1551
https://phab.mercurial-scm.org/D1551.

Nov 30 2017, 3:12 AM

Nov 28 2017

dlax accepted D1502: rewriteutil: add utility function to check if we can create new unstable cset.
Nov 28 2017, 2:25 PM
dlax requested changes to D1502: rewriteutil: add utility function to check if we can create new unstable cset.
Nov 28 2017, 4:18 AM
dlax accepted D1503: rewriteutil: add a precheck function to check if revs can be rewritten.
Nov 28 2017, 4:17 AM
dlax accepted D1526: rewriteutil: use precheck() in uncommit and amend commands.
Nov 28 2017, 4:16 AM

Nov 24 2017

dlax added a comment to D1502: rewriteutil: add utility function to check if we can create new unstable cset.

This rewriteutil.py introduced in this patch and the utility functions added in the upcoming patches exists in the evolve extension are being ported from there.

Nov 24 2017, 4:35 AM

Nov 21 2017

dlax added inline comments to D1483: globalopts: make special flags ineffective after '--' (BC).
Nov 21 2017, 3:01 PM

Nov 17 2017

dlax accepted D1444: tweakdefaults: turn on ui.statuscopies.
Nov 17 2017, 3:14 AM

Nov 14 2017

dlax committed rHGa68c3420be41: rebase: exclude descendants of obsoletes w/o a successor in dest (issue5300).
rebase: exclude descendants of obsoletes w/o a successor in dest (issue5300)
Nov 14 2017, 5:13 PM
dlax accepted D1381: crecord: fix revert -ir '.^' crash caused by 3649c3f2cd.
Nov 14 2017, 4:27 AM
dlax accepted D1384: bundlerepo: rename "bundlefilespos" variable and attribute.
Nov 14 2017, 4:20 AM
dlax accepted D1383: bundlerepo: rename "bundle" arguments to "cgunpacker".
Nov 14 2017, 4:18 AM
dlax accepted D1382: bundlerepo: use early return.
Nov 14 2017, 4:17 AM

Nov 13 2017

dlax committed rHG235d58aa723e: tests: conditionally display obsfate in test-rebase-obsolete log output.
tests: conditionally display obsfate in test-rebase-obsolete log output
Nov 13 2017, 6:16 PM
dlax committed rHG0564e7c7f4cd: tests: add a couple of 'hg log' calls in test-rebase-obsolete.t.
tests: add a couple of 'hg log' calls in test-rebase-obsolete.t
Nov 13 2017, 6:16 PM
dlax committed rHG852620fe4ca7: tests: clarify a comment in test-rebase-obsolete.t.
tests: clarify a comment in test-rebase-obsolete.t
Nov 13 2017, 6:16 PM
dlax added a comment to D1358: remotenames: store journal entry for bookmarks if journal is loaded.

The state of this stack is not quite clear: there are abandoned revisions and the first changeset (introducing "mercurial/remotenames.py" file) seems to be missing.

Nov 13 2017, 3:53 AM
dlax accepted D1370: bundle2: use os.SEEK_* constants.
Nov 13 2017, 3:26 AM
dlax added a comment to D1371: global: remove redundant parenthesis.

LGTM modulo a few nits. Nice cleanup.

Nov 13 2017, 3:20 AM
dlax added inline comments to D1378: bundlerepo: assign bundle attributes in bundle type blocks.
Nov 13 2017, 3:05 AM
dlax accepted D1379: bundlerepo: rename _bundle to _cgunpacker.
Nov 13 2017, 3:00 AM
dlax accepted D1378: bundlerepo: assign bundle attributes in bundle type blocks.
Nov 13 2017, 2:58 AM
dlax accepted D1377: bundlerepo: make bundle and bundlefile attributes private.
Nov 13 2017, 2:57 AM
dlax accepted D1376: bundlerepo: don't assume there are only two bundle classes.
Nov 13 2017, 2:57 AM
dlax accepted D1375: bundlerepo: add docstring for bundlerepository class.
Nov 13 2017, 2:53 AM
dlax accepted D1374: bundlerepo: rename arguments to bundlerepository.__init__.
Nov 13 2017, 2:52 AM
dlax accepted D1373: bundlerepo: use suffix variable.
Nov 13 2017, 2:52 AM

Nov 12 2017

dlax added a comment to D1372: bundlerepo: make methods agree with base class.

For methods that are implemented, we change arguments to match the base.

Nov 12 2017, 3:10 AM

Nov 11 2017

dlax accepted D1348: histedit: add support to output nodechanges using formatter.
Nov 11 2017, 12:56 PM

Nov 10 2017

dlax requested changes to D1348: histedit: add support to output nodechanges using formatter.
Nov 10 2017, 2:43 PM

Nov 3 2017

dlax committed rHG3649c3f2cd90: revert: do not reverse hunks in interactive when REV is not parent (issue5096).
revert: do not reverse hunks in interactive when REV is not parent (issue5096)
Nov 3 2017, 4:31 PM
dlax committed rHG546ab70f659e: revert: do not reverse hunks in interactive when REV is not parent (issue5096).
revert: do not reverse hunks in interactive when REV is not parent (issue5096)
Nov 3 2017, 3:41 PM

Oct 31 2017

dlax added inline comments to D1270: help: adding a topic on flags.
Oct 31 2017, 4:25 AM

Oct 19 2017

dlax committed rHG907ff34e1460: log: add an assertion about fctx not being None in patch.diff().
log: add an assertion about fctx not being None in patch.diff()
Oct 19 2017, 4:13 PM
dlax committed rHG0ccfc468423a: log: handle removed files with --line-range patterns.
log: handle removed files with --line-range patterns
Oct 19 2017, 4:13 PM
dlax committed rHG2e45bbd3db7b: log: disable bare file patterns with --line-range.
log: disable bare file patterns with --line-range
Oct 19 2017, 4:13 PM
dlax committed rHG5c7dbb730179: log: switch to FROMLINE:TOLINE syntax for -L/--line-range.
log: switch to FROMLINE:TOLINE syntax for -L/--line-range
Oct 19 2017, 4:13 PM
dlax committed rHG4554649a6ea4: log: handle binary files in --line-range patterns.
log: handle binary files in --line-range patterns
Oct 19 2017, 4:13 PM
dlax committed rHGeb24f1d1b50b: show: use labelcset() template alias for work (and stack) views.
show: use labelcset() template alias for work (and stack) views
Oct 19 2017, 1:00 PM

Oct 18 2017

dlax committed rHG7ed975e43914: show: use labelcset() template alias for work (and stack) views.
show: use labelcset() template alias for work (and stack) views
Oct 18 2017, 4:27 PM
dlax committed rHG84c6b9384d6a: log: add -L/--line-range option to follow file history by line range.
log: add -L/--line-range option to follow file history by line range
Oct 18 2017, 11:05 AM
dlax committed rHG890afefa7296: diff: pass a diff hunks filter function from changeset_printer to patch.diff().
diff: pass a diff hunks filter function from changeset_printer to patch.diff()
Oct 18 2017, 11:05 AM
dlax committed rHG35c6a54ec1ff: diff: also yield file context objects in patch.trydiff() (API).
diff: also yield file context objects in patch.trydiff() (API)
Oct 18 2017, 11:05 AM
dlax committed rHG39b094e4ae2c: revset: extract a parsefollowlinespattern helper function.
revset: extract a parsefollowlinespattern helper function
Oct 18 2017, 11:05 AM
dlax accepted D1173: rebase: add support to output nodechanges.

Looks good to me, much nicer than the previous version.

Oct 18 2017, 3:01 AM
dlax updated the summary of D1173: rebase: add support to output nodechanges.
Oct 18 2017, 3:00 AM

Oct 17 2017

dlax added a comment to D1063: rebase: enable multidest by default.

(Note that I'd still welcome feedback from non-BigCo contributors here - is this something we should make permanent? Have people been testing this? Etc.)

Oct 17 2017, 3:02 AM

Oct 16 2017

dlax committed rHG0c06875e7755: transaction-summary: use a revset to filter obsoletes in reportnewcs().
transaction-summary: use a revset to filter obsoletes in reportnewcs()
Oct 16 2017, 10:47 AM
dlax accepted D1074: branch: add a --rev flag to change branch name of given revisions.
Oct 16 2017, 8:36 AM
dlax accepted D1093: scmutil: add capability to cleanupnodes to take obsmarker metadata.
Oct 16 2017, 4:27 AM
dlax accepted D1094: cmdutil: pass metadata from amend() to cleanupnodes.
Oct 16 2017, 4:27 AM
dlax accepted D1095: amend: add a flag `-n/--note` to store note with amend.
Oct 16 2017, 4:27 AM
dlax requested changes to D1074: branch: add a --rev flag to change branch name of given revisions.

This looks correct to me overall.
I use this feature with topics a lot and find it pretty convenient so I guess it might make sense for named branches in some workflows.

Oct 16 2017, 3:59 AM

Oct 15 2017

dlax added inline comments to D1082: split: new extension to split changesets.
Oct 15 2017, 5:03 AM
dlax added inline comments to D1074: branch: add a --rev flag to change branch name of given revisions.
Oct 15 2017, 5:03 AM
dlax requested changes to D1073: commands: move a bunch of statements into if True for next patch.
Oct 15 2017, 4:40 AM

Oct 14 2017

dlax closed D1072: tersestatus: rework dirnode and tersedir docstrings.
Oct 14 2017, 4:46 PM
dlax committed rHG23eb03f46929: tersestatus: rework dirnode and tersedir docstrings.
tersestatus: rework dirnode and tersedir docstrings
Oct 14 2017, 4:46 PM
dlax added a reviewer for D1072: tersestatus: rework dirnode and tersedir docstrings: pulkit.
Oct 14 2017, 7:36 AM
dlax created D1072: tersestatus: rework dirnode and tersedir docstrings.
Oct 14 2017, 7:35 AM
dlax abandoned D1071: tersestatus: rework dirnode and tersedir docstrings.

Apparently the "herald" thing did not work, sending again.

Oct 14 2017, 7:34 AM
dlax added reviewers for D1071: tersestatus: rework dirnode and tersedir docstrings: hg-reviewers, pulkit.
Oct 14 2017, 7:28 AM