Page MenuHomePhabricator

dlax (Denis Laxalde)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2017, 6:32 AM (114 w, 6 d)

Recent Activity

Today

dlax added a comment to D7633: clone: extract helper for checking mutually exclusive args.

Useful refactoring!

Fri, Dec 13, 3:18 AM
dlax accepted D7621: pycompat: allow pycompat.sysbytes() even if input already is bytes.
Fri, Dec 13, 3:12 AM
D7620: merge: add commands.merge.require-rev to require an argument to hg merge now requires changes to proceed.

This should be documented in mercurial/helptext/config.txt I think.

Fri, Dec 13, 3:10 AM

Yesterday

dlax accepted D7608: phabricator: color the status in the "phabstatus" view.
Thu, Dec 12, 2:55 AM
dlax accepted D7607: phabricator: add the "Changes Planned" status name.
Thu, Dec 12, 2:52 AM
dlax added a comment to D7506: phabricator: add a "phabstatus" show view.

I don't think from . import show works generally.

Thu, Dec 12, 2:49 AM

Wed, Dec 11

dlax closed D7506: phabricator: add a "phabstatus" show view.
Wed, Dec 11, 6:55 AM
dlax closed D7507: phabricator: add a "phabstatus" template keyword.
Wed, Dec 11, 6:55 AM
dlax committed rHG79c0121220e3: phabricator: add a "phabstatus" template keyword.
phabricator: add a "phabstatus" template keyword
Wed, Dec 11, 6:54 AM
dlax committed rHG70060915c3f2: phabricator: add a "phabstatus" show view.
phabricator: add a "phabstatus" show view
Wed, Dec 11, 6:54 AM
dlax accepted D7598: py3: fix a bytes vs str issue in remotefilelog extension.
Wed, Dec 11, 4:42 AM

Tue, Dec 10

dlax updated the diff for D7507: phabricator: add a "phabstatus" template keyword.
Tue, Dec 10, 2:46 PM
dlax updated the diff for D7506: phabricator: add a "phabstatus" show view.
Tue, Dec 10, 2:46 PM
dlax closed D7505: logcmdutil: call _exthook() in changesettemplater.
Tue, Dec 10, 11:17 AM
dlax closed D7513: phabricator: fix processing of tags/desc in getoldnodedrevmap().
Tue, Dec 10, 11:17 AM
dlax committed rHG6331a6fc3304: logcmdutil: call _exthook() in changesettemplater.
logcmdutil: call _exthook() in changesettemplater
Tue, Dec 10, 11:17 AM
dlax committed rHG16b607e9f714: phabricator: fix processing of tags/desc in getoldnodedrevmap().
phabricator: fix processing of tags/desc in getoldnodedrevmap()
Tue, Dec 10, 11:17 AM

Sun, Dec 8

dlax accepted D7583: exchange: fix an attempt to format a list into bytes.
Sun, Dec 8, 5:37 AM

Wed, Dec 4

dlax accepted D7544: subrepo: use pycompat.open directly instead of importing open from pycompat.
Wed, Dec 4, 3:46 AM

Mon, Dec 2

dlax closed D7540: tests: cover revision conversion logic in githelp tests.
Mon, Dec 2, 4:56 PM
dlax committed rHG5470e63686ca: tests: cover revision conversion logic in githelp tests.
tests: cover revision conversion logic in githelp tests
Mon, Dec 2, 4:56 PM
dlax created D7540: tests: cover revision conversion logic in githelp tests.
Mon, Dec 2, 4:22 AM
dlax added a comment to D7537: githelp: fix a `str` type conditional for py3.

There is apparently no test coverage for this.

Mon, Dec 2, 4:17 AM
dlax accepted D7539: cleanup: fix docstring formatting.
Mon, Dec 2, 3:29 AM
dlax accepted D7465: filemerge: fix a missing attribute usage.
Mon, Dec 2, 3:23 AM

Sun, Dec 1

dlax accepted D7538: pvec: fix a `str` type conditional for py3.
Sun, Dec 1, 8:02 AM
dlax retitled D7536: histedit: fix an `isinstance(nodelist, str)` check for py3 from hitedit: fix an `isinstance(nodelist, str)` check for py3 to histedit: fix an `isinstance(nodelist, str)` check for py3.
Sun, Dec 1, 4:53 AM
dlax accepted D7536: histedit: fix an `isinstance(nodelist, str)` check for py3.
Sun, Dec 1, 4:53 AM
dlax accepted D7535: win32mbcs: fix a `str` type conditional for py3.
Sun, Dec 1, 4:52 AM
dlax accepted D7534: hgweb: fix a few `str` type conditional for py3.
Sun, Dec 1, 4:51 AM
dlax added a comment to D7533: repair: fix an `isinstance(nodelist, str)` check for py3.

All these API where one can pass either a list of "things" or just one "thing" is kind of ugly. We should only handle the list case, I think.

Sun, Dec 1, 4:49 AM

Sat, Nov 30

dlax committed rHGd1b9d2c6ec96: log: map None rev to wdirrev when filtering revisions with --line-range.
log: map None rev to wdirrev when filtering revisions with --line-range
Sat, Nov 30, 9:58 PM
dlax committed rHG66d5c8c3afed: tests: check that 'log --line-range' follows uncommitted changes.
tests: check that 'log --line-range' follows uncommitted changes
Sat, Nov 30, 9:58 PM

Sun, Nov 24

dlax added a comment to D7517: filemerge: byteify the open() mode.

This is actually pycompat.open(), so it need bytes.

Sun, Nov 24, 6:51 AM
dlax added a comment to D7516: webutil: add missing argument to join().

Looks like dead code

Sun, Nov 24, 3:50 AM

Sat, Nov 23

dlax added a comment to D7507: phabricator: add a "phabstatus" template keyword.
I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?
Sat, Nov 23, 11:45 AM
dlax created D7513: phabricator: fix processing of tags/desc in getoldnodedrevmap().
Sat, Nov 23, 5:47 AM
dlax updated the summary of D7506: phabricator: add a "phabstatus" show view.
Sat, Nov 23, 5:26 AM
dlax added a comment to D7506: phabricator: add a "phabstatus" show view.

I'm not sure why, but this version seems to also show obsolete revisions. I've got a bunch of x and * nodes in hg-committed right now. I didn't see that before, although that was on a different clone that I don't have access to now.

After further review, the obsolete revisions have unstable children going way back, so that's why they show. But I'm super confused by the output. This isn't the whole output, but the middle or so that corresponds to the latest(!) commits:

Sat, Nov 23, 5:15 AM
dlax accepted D7512: exchange: guard against method invocation on `b2caps=None` args.
Sat, Nov 23, 3:43 AM
dlax accepted D7511: exchange: eliminate some bytes.format() calls.
Sat, Nov 23, 3:40 AM
dlax accepted D7510: windows: suppress pytype warnings for Windows imports and functions.
Sat, Nov 23, 3:39 AM
dlax accepted D7508: relnotes: add note about changes to match.{explicit,reverse}dir.
Sat, Nov 23, 3:25 AM

Fri, Nov 22

dlax updated the diff for D7507: phabricator: add a "phabstatus" template keyword.
Fri, Nov 22, 4:13 PM
dlax updated the diff for D7506: phabricator: add a "phabstatus" show view.
Fri, Nov 22, 4:13 PM
dlax added a comment to D7506: phabricator: add a "phabstatus" show view.

I like it.

Fri, Nov 22, 4:09 PM
dlax added inline comments to D7508: relnotes: add note about changes to match.{explicit,reverse}dir.
Fri, Nov 22, 3:14 PM
dlax updated the diff for D7507: phabricator: add a "phabstatus" template keyword.
Fri, Nov 22, 11:03 AM
dlax updated the diff for D7506: phabricator: add a "phabstatus" show view.
Fri, Nov 22, 11:03 AM
dlax created D7507: phabricator: add a "phabstatus" template keyword.
Fri, Nov 22, 11:00 AM
dlax created D7506: phabricator: add a "phabstatus" show view.
Fri, Nov 22, 11:00 AM
dlax created D7505: logcmdutil: call _exthook() in changesettemplater.
Fri, Nov 22, 11:00 AM
D7504: py3: replace %s by %r on binary format string when needed now requires changes to proceed.

nit: the actual PEP is pep-0461 (https://www.python.org/dev/peps/pep-0461/)

Fri, Nov 22, 8:04 AM
dlax added a comment to D7051: phabricator: remove tests and all recordings.

The next commit is going to change the format of conduit API requests so none of the VCR recordings will match and all the tests will fail.

Fri, Nov 22, 5:09 AM

Thu, Nov 21

dlax closed D7460: tests: add more tests for "hg shelve --delete".
Thu, Nov 21, 8:35 AM
dlax committed rHG4330851947fb: tests: add more tests for "hg shelve --delete".
tests: add more tests for "hg shelve --delete"
Thu, Nov 21, 8:35 AM
dlax added inline comments to D7465: filemerge: fix a missing attribute usage.
Thu, Nov 21, 7:56 AM
dlax committed rHG71dbd6f6fcb8: import: add a --secret option.
import: add a --secret option
Thu, Nov 21, 7:55 AM
dlax added inline comments to D7465: filemerge: fix a missing attribute usage.
Thu, Nov 21, 3:13 AM
dlax added a comment to D7464: filemerge: drop a default argument to appease pytype.

Shouldn't this be also done for all similar functions? (i.e. _xmergeimm and functions registered as a merge tool with @internaltool)

Thu, Nov 21, 3:07 AM
dlax accepted D7463: wireprotov1server: capture Abort type before accessing the `hint` attribute.
Thu, Nov 21, 2:13 AM
dlax accepted D7462: py3: make doc strings containing the deprected '\.' escape sequence raw strings.
Thu, Nov 21, 2:08 AM

Wed, Nov 20

dlax accepted D7461: py3: wrap a __func__ in sysbytes() before logging as bytes.
Wed, Nov 20, 2:59 PM
dlax updated the diff for D7460: tests: add more tests for "hg shelve --delete".
Wed, Nov 20, 7:53 AM
dlax added a comment to D7458: shelve: add the missing `create` parameter to the bundlerepo constructor.

Good catch.

Wed, Nov 20, 3:02 AM
dlax accepted D7456: scmutil: add assertions to help pytype.
Wed, Nov 20, 2:59 AM
dlax added a comment to D7457: shelve: fix a missing variable in the exception handler for delete.

I don't see any test for hg shelve --delete NAME that's not a command error case; adding some in D7460.

Wed, Nov 20, 2:59 AM
dlax created D7460: tests: add more tests for "hg shelve --delete".
Wed, Nov 20, 2:58 AM
dlax accepted D7455: revset: add an assertion to help pytype.
Wed, Nov 20, 2:50 AM

Tue, Nov 19

dlax added a comment to D7296: pycompat: kludge around pytype being confused by __new__.
In D7296#109684, @dlax wrote:

Looking closer at the error above, it mentions bytestr.__init__, not __new__ (and there is in fact no type annotation for __new__ in typeshed).

Tue, Nov 19, 3:14 PM
dlax updated subscribers of D7296: pycompat: kludge around pytype being confused by __new__.
In D7296#109672, @dlax wrote:

Sorry, still not ok afaict :/

So, I tried fixing this and it actually made things worse? dagparser.py no longer typechecks if I correct the syntax? Try the pytype invocation from the test at the end of the series and you'll see what I mean.

Tue, Nov 19, 3:10 PM
D7296: pycompat: kludge around pytype being confused by __new__ now requires changes to proceed.

Sorry, still not ok afaict :/

Tue, Nov 19, 11:39 AM
dlax added a comment to D7408: extensions: hide two confusing import statements from pytype.

Where does hgext.__index__ come from?!

Tue, Nov 19, 2:55 AM

Sat, Nov 16

D7296: pycompat: kludge around pytype being confused by __new__ now requires changes to proceed.
Sat, Nov 16, 4:28 AM

Fri, Nov 15

dlax accepted D7297: cleanup: remove now-obsolete wrong-arg-type annotations.
Fri, Nov 15, 3:08 PM
dlax added a comment to D7410: extensions: suppress a pytype failure due to a typeshed bug.

meanwhile, https://github.com/python/typeshed/pull/3465

Fri, Nov 15, 12:49 PM
dlax added a comment to D7296: pycompat: kludge around pytype being confused by __new__.

black complains because inline comments have only one space before (esp. the first one produces a parse error).
LGTM otherwise.

Fri, Nov 15, 12:47 PM
dlax added inline comments to D7384: commands: necessary annotations and suppresssions to pass pytype.
Fri, Nov 15, 12:40 PM
dlax closed D7430: bisect: replace try:/finally: by a "restore_state" context manager.
Fri, Nov 15, 12:25 PM
dlax committed rHGf37da59a36d9: bisect: replace try:/finally: by a "restore_state" context manager.
bisect: replace try:/finally: by a "restore_state" context manager
Fri, Nov 15, 12:24 PM
dlax added inline comments to D7410: extensions: suppress a pytype failure due to a typeshed bug.
Fri, Nov 15, 9:46 AM
dlax accepted D7410: extensions: suppress a pytype failure due to a typeshed bug.
Fri, Nov 15, 9:02 AM
dlax added a comment to D7408: extensions: hide two confusing import statements from pytype.

Out of curiosity, where does this __index__ value come from?

Fri, Nov 15, 8:31 AM
dlax accepted D7409: dispatch: add some assertions to give pytype a helping hand.
Fri, Nov 15, 8:27 AM
dlax accepted D7407: debugcommands: add assertions to convince pytype peer is not None.
Fri, Nov 15, 6:11 AM
D7384: commands: necessary annotations and suppresssions to pass pytype now requires changes to proceed.

D7430 makes this changes unnecessary I think.

Fri, Nov 15, 6:08 AM
dlax accepted D7381: cmdutil: add a pytype annotation to help out some callsites.
Fri, Nov 15, 6:07 AM
D7296: pycompat: kludge around pytype being confused by __new__ now requires changes to proceed.

Rather class bytestr(bytes): # type: Callable[[Union[bytes, str], bytestr] as @yuya suggested in D7380.

Fri, Nov 15, 6:03 AM
dlax created D7430: bisect: replace try:/finally: by a "restore_state" context manager.
Fri, Nov 15, 5:14 AM
dlax accepted D7382: logcmdutil: add a type annotation.
Fri, Nov 15, 3:24 AM

Thu, Nov 14

dlax committed rHGd3c4368099ed: tests: test "hg log" with --line-range and --copies.
tests: test "hg log" with --line-range and --copies
Thu, Nov 14, 8:03 AM
dlax committed rHGaf9c73f26371: logcmdutil: let getlinerangerevs() return "revs" as a smartset.
logcmdutil: let getlinerangerevs() return "revs" as a smartset
Thu, Nov 14, 8:03 AM
dlax added a comment to D7296: pycompat: kludge around pytype being confused by __new__.
class bytestr(bytes):  # type: (Union[bytes,str]) -> bytestr
  [...]
Thu, Nov 14, 6:05 AM
dlax added a comment to D7380: encoding: define per-use identity functions only in typechecking mode.

Have you tried using variables annotations? Like:

strtolocal = pycompat.identity  # type: (str) -> bytes
strfromlocal = pycompat.identity  # type: (bytes) -> str
Thu, Nov 14, 5:50 AM
dlax added a comment to D7385: debugcommands: suppress import errors for pytype.

I wonder if using importlib.import_module() wouldn't help. Or is it something we avoid in Mercurial?

Thu, Nov 14, 5:02 AM
dlax added inline comments to D7384: commands: necessary annotations and suppresssions to pass pytype.
Thu, Nov 14, 4:45 AM
dlax added a comment to D7289: branchmap: correctly set()-ify list argument.

On second thought, it's not obvious why it'd be better than annotating __init__(). Is this because this would require many changes in callers?

Thu, Nov 14, 4:39 AM
dlax accepted D7381: cmdutil: add a pytype annotation to help out some callsites.
Thu, Nov 14, 4:12 AM
dlax added inline comments to D7381: cmdutil: add a pytype annotation to help out some callsites.
Thu, Nov 14, 4:12 AM
dlax accepted D7383: state: add a pytype annotation.
Thu, Nov 14, 4:04 AM