- User Since
- Jan 10 2018, 9:13 PM (135 w, 9 h)
Mon, Jul 20
Fri, Jul 17
Thu, Jul 16
Tue, Jul 14
Jul 13 2020
Er, well... I guess reordering the chain broke phabricator? Originally I had A -> B -> C, as suggested I reordered this to B -> A -> C with appropriate changes, and how hg phabsend crashes with:
Jul 10 2020
To give a concrete example, we have an internal command which does something similar to chainify. It generates N individual commits with different parents (based on input flags), then rebases then sequentially into a single chain in a specific order; it currently does some hacky wrapping of methods in this file to make it work. We have need of another command that does something similar with multiple evolve instructions; rather than repeat the hacks, I thought it would be good to make the support cleaner by implementing it upstream.
Can you add a test case? That would probably also help understanding the use case.
I added a test file with a simple-ish example extension that hopefully clarifies the intent. I revised the changes a bit to make the intended usage in extensions cleaner/more intuitive (I probably should have done this in the first place since there were also two minor bugs in the initial draft.)
Done. Added a temporary legacy hook which is removed in D8730; all the .t file updates are moved to that revision as well.
Of course, it feels stupid to change code that’s going to be replaced in the next patch. Still, I think it makes things easier to review (at least that’s my opinion, I don’t know if more experienced reviewers agree).
I suppose it's nice in this case because it confirms that it's only the rebase message that's changing (whereas otherwise, you'd need to check every .t file to see this).
Sorry for the noise. There was some conflict between our internal fix configuration and the black.toml setup in the hg repo; I thought I had sorted it out but I was mistaken (and black apparently leaves the opinionated quotation-style changes in place, it doesn't have its own opinion about them?)
Jul 8 2020
Nov 21 2019
Nov 20 2019
Nov 13 2019
Nov 12 2019
Jan 9 2019
Jan 8 2019
Mar 23 2018
Mar 22 2018
Mar 5 2018
Feb 22 2018
Feb 21 2018
Feb 20 2018
Friendly ping! This is my first commit so I'm not sure if more information or changes are expected; please let me know if there's anything I'm missing.