- User Since
- Jun 28 2017, 6:57 PM (58 w, 5 d)
Mar 19 2018
Feb 12 2018
There are things which I am not sure whether to keep or not:
- the --bundle-store flag to push command
Jan 24 2018
Jan 9 2018
Could this have a test? Is there a config knob to disable bundle2 or force bundle1?
Jan 5 2018
Jan 4 2018
Accepting, since it seems more correct than before.
Discussed this in person. My concerns were that this would allow large action lists to propagate up and cause excess remotefilelog actions. Phil's response was that A) this only applies to rebases for now, and any action in the rebase is going to require downloading anyway (when it the sparse profile gets temporarily expanded below), and B) any action on a in memory context should probably not be filtered by sparseness anyway. I think the invariant in B is reasonable, and if we see it causing problems like A we can reevaluate how to fix that problem to meet invariant B.
Jan 2 2018
Dec 15 2017
Let's default the behavior to on. Since the only reason the extension would be enabled is to disable the behavior. Then we can just use the config knob later if we need more flexibility.
Dec 14 2017
Dec 12 2017
Dec 7 2017
Back in your queue for tests and a commit message
Dec 6 2017
Dec 5 2017
Dec 4 2017
Couple questions inline, but I'll push it once they're answered.
Nice clean up
Dec 1 2017
Probably want Jeremy to look at this one. I'm not familiar with some of the unsafe bits.
Nov 30 2017
I assume the tests cover this code path?
Nov 29 2017
I've made it up to radix_insert_with_key. Will finish later this evening. Throwing back in your queue for now.
I'd follow up with Jeremey about his suggestion, but I don't think it's worth blocking getting this out for dogfooding.
I'm totally on board with getting rid of the message.