durham (Durham Goode)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 6:57 PM (58 w, 5 d)

Recent Activity

Mar 19 2018

durham accepted D2898: lz4wrapper: eagerly import lz4 extension modules.
Mar 19 2018, 5:47 PM

Feb 12 2018

durham added a comment to D2108: infinitepush: drop the `--to` flag to push and use `-B` instead.

There are things which I am not sure whether to keep or not:

  • the --bundle-store flag to push command
Feb 12 2018, 4:43 PM

Jan 24 2018

durham abandoned D1804: treemanifest: add a server side cache for tree entries.
Jan 24 2018, 1:20 PM

Jan 9 2018

durham requested changes to D1649: infinitepush: add logic to support old clients on the basis of pushkey part.

Could this have a test? Is there a config knob to disable bundle2 or force bundle1?

Jan 9 2018, 11:09 AM

Jan 5 2018

durham added inline comments to D1814: rebase: add experimental.inmemory.nomergedriver to turn off IMM.
Jan 5 2018, 1:14 PM

Jan 4 2018

durham added inline comments to D1805: sparse: don't materialize sparse files during IMM.
Jan 4 2018, 3:27 PM
durham accepted D1807: filemerge: only write in-memory backup during premerge.
Jan 4 2018, 3:19 PM
durham accepted D1806: filemerge: fix backing up an in-memory file to a custom location.

Accepting, since it seems more correct than before.

Jan 4 2018, 3:17 PM
durham accepted D1805: sparse: don't materialize sparse files during IMM.

Discussed this in person. My concerns were that this would allow large action lists to propagate up and cause excess remotefilelog actions. Phil's response was that A) this only applies to rebases for now, and any action in the rebase is going to require downloading anyway (when it the sparse profile gets temporarily expanded below), and B) any action on a in memory context should probably not be filtered by sparseness anyway. I think the invariant in B is reasonable, and if we see it causing problems like A we can reevaluate how to fix that problem to meet invariant B.

Jan 4 2018, 2:07 PM

Jan 2 2018

durham added inline comments to D1804: treemanifest: add a server side cache for tree entries.
Jan 2 2018, 7:42 PM
durham created D1804: treemanifest: add a server side cache for tree entries.
Jan 2 2018, 7:41 PM
durham created D1803: temp.
Jan 2 2018, 7:41 PM
durham abandoned D1803: temp.
Jan 2 2018, 7:41 PM

Dec 15 2017

durham closed D1688: datapack: add getdelta api.
Dec 15 2017, 2:34 PM
durham closed D1690: repack: reuse deltas when possible.
Dec 15 2017, 2:34 PM
durham committed rFBHGX8cb19938d4a7: repack: reuse deltas when possible.
repack: reuse deltas when possible
Dec 15 2017, 2:34 PM
durham committed rFBHGX38db46cc245c: datapack: add getdelta api.
datapack: add getdelta api
Dec 15 2017, 2:34 PM
durham closed D1686: cdatapack: move meta parsing to a function.
Dec 15 2017, 2:34 PM
durham committed rFBHGX29ad139b61cb: datapack: move delta chain entry reading to a seperate function.
datapack: move delta chain entry reading to a seperate function
Dec 15 2017, 2:34 PM
durham committed rFBHGX7818729065f0: cdatapack: move meta parsing to a function.
cdatapack: move meta parsing to a function
Dec 15 2017, 2:34 PM
durham closed D1687: datapack: move delta chain entry reading to a seperate function.
Dec 15 2017, 2:34 PM
durham added inline comments to D1690: repack: reuse deltas when possible.
Dec 15 2017, 2:09 PM
durham accepted D1493: pybuf: add a simple abstraction around Py_buffer interface.
Dec 15 2017, 1:01 PM
durham accepted D1614: noverify: add extension to skip repo verification.

Let's default the behavior to on. Since the only reason the extension would be enabled is to disable the behavior. Then we can just use the config knob later if we need more flexibility.

Dec 15 2017, 1:57 AM

Dec 14 2017

durham accepted D1472: clindex: integrate Rust nodemap.
Dec 14 2017, 7:38 PM
durham requested changes to D1493: pybuf: add a simple abstraction around Py_buffer interface.
Dec 14 2017, 7:32 PM
durham accepted D1469: nodemap: implement nodemap in rust.
Dec 14 2017, 7:21 PM
durham accepted D1291: radixbuf: implement the main radix tree.
Dec 14 2017, 7:16 PM
durham added inline comments to D1688: datapack: add getdelta api.
Dec 14 2017, 5:47 PM
durham updated the diff for D1688: datapack: add getdelta api.
Dec 14 2017, 5:46 PM
durham added a dependent revision for D1688: datapack: add getdelta api: D1690: repack: reuse deltas when possible.
Dec 14 2017, 5:40 PM
durham added a dependency for D1690: repack: reuse deltas when possible: D1688: datapack: add getdelta api.
Dec 14 2017, 5:40 PM
durham created D1690: repack: reuse deltas when possible.
Dec 14 2017, 5:39 PM
durham accepted D1614: noverify: add extension to skip repo verification.
Dec 14 2017, 5:24 PM
durham created D1688: datapack: add getdelta api.
Dec 14 2017, 2:24 PM
durham created D1687: datapack: move delta chain entry reading to a seperate function.
Dec 14 2017, 2:24 PM
durham added a dependent revision for D1687: datapack: move delta chain entry reading to a seperate function: D1688: datapack: add getdelta api.
Dec 14 2017, 2:24 PM
durham created D1686: cdatapack: move meta parsing to a function.
Dec 14 2017, 2:24 PM
durham added a dependent revision for D1686: cdatapack: move meta parsing to a function: D1687: datapack: move delta chain entry reading to a seperate function.
Dec 14 2017, 2:24 PM

Dec 12 2017

durham closed D1668: repack: exit 0 if a repack is in progress.
Dec 12 2017, 7:26 PM
durham committed rFBHGX2c1f0d55da3a: repack: exit 0 if a repack is in progress.
repack: exit 0 if a repack is in progress
Dec 12 2017, 7:26 PM
durham updated the diff for D1668: repack: exit 0 if a repack is in progress.
Dec 12 2017, 5:01 PM
durham updated the diff for D1668: repack: exit 0 if a repack is in progress.
Dec 12 2017, 5:01 PM
durham created D1668: repack: exit 0 if a repack is in progress.
Dec 12 2017, 4:59 PM

Dec 7 2017

durham added inline comments to D1593: infinitepush: remove duplicated logic for storing changegroups.
Dec 7 2017, 7:44 PM
durham requested changes to D1614: noverify: add extension to skip repo verification.

Back in your queue for tests and a commit message

Dec 7 2017, 7:42 PM
durham requested changes to D1593: infinitepush: remove duplicated logic for storing changegroups.
Dec 7 2017, 4:59 PM
durham added inline comments to D1585: infinitepush: add logic to add a stream level parameter to bundle2.
Dec 7 2017, 4:54 PM

Dec 6 2017

durham requested changes to D1472: clindex: integrate Rust nodemap.

Small comments

Dec 6 2017, 7:49 PM

Dec 5 2017

durham accepted D1600: prefetch: fix the hg executable location for background prefetch.
Dec 5 2017, 5:24 PM
durham accepted D1596: incremental-repack: do not repack largest 2 files if nothing else to do.
Dec 5 2017, 4:31 PM

Dec 4 2017

durham accepted D1516: perftweaks: disable accessing served repoview at repo.updatecaches.
Dec 4 2017, 11:36 PM
durham accepted D1514: perftweaks: avoid expensive branchmap calculation during commit.
Dec 4 2017, 11:35 PM
durham accepted D1501: perftweaks: further cleanup branchmap code paths.
Dec 4 2017, 11:34 PM
durham accepted D1582: treemanifest: wipe the shared cache if more than packs.maxpackfilecount in it.
Dec 4 2017, 11:29 PM
durham accepted D1585: infinitepush: add logic to add a stream level parameter to bundle2.

Couple questions inline, but I'll push it once they're answered.

Dec 4 2017, 11:25 PM
durham accepted D1588: incremental-repack: do not repack files over a configuration based size.
Dec 4 2017, 11:16 PM
durham accepted D1587: incremental-repack: refactor to facilitate easier options manipulation.

Nice clean up

Dec 4 2017, 11:03 PM
durham accepted D1586: incremental-repack: adding documentation for some repacking options.
Dec 4 2017, 11:00 PM
durham closed D1570: repack: support --packsonly --background.
Dec 4 2017, 9:00 PM
durham committed rFBHGXa47767bde762: repack: support --packsonly --background.
repack: support --packsonly --background
Dec 4 2017, 9:00 PM

Dec 1 2017

durham accepted D1471: setup: make rust nodemap buildable.
Dec 1 2017, 7:49 PM
durham accepted D1470: nodemap: implement Python interface.
Dec 1 2017, 7:49 PM
durham accepted D1572: infinitepush: be compatible with upstream change.
Dec 1 2017, 4:22 PM
durham added a comment to D1493: pybuf: add a simple abstraction around Py_buffer interface.

Probably want Jeremy to look at this one. I'm not familiar with some of the unsafe bits.

Dec 1 2017, 2:08 PM
durham created D1570: repack: support --packsonly --background.
Dec 1 2017, 2:06 PM
durham added inline comments to D1469: nodemap: implement nodemap in rust.
Dec 1 2017, 12:03 PM

Nov 30 2017

durham closed D1567: extutil: replace fcntllock with flock.
Nov 30 2017, 8:23 PM
durham closed D1566: extutil: move flock to extutil.
Nov 30 2017, 8:23 PM
durham committed rFBHGX3f89329bdb9b: extutil: replace fcntllock with flock.
extutil: replace fcntllock with flock
Nov 30 2017, 8:23 PM
durham committed rFBHGX0eb3df0e50c0: extutil: move flock to extutil.
extutil: move flock to extutil
Nov 30 2017, 8:23 PM
durham closed D1565: hiddenoverrides: support nonblocking flock.
Nov 30 2017, 8:23 PM
durham committed rFBHGX4bc90c1d6854: hiddenoverrides: support nonblocking flock.
hiddenoverrides: support nonblocking flock
Nov 30 2017, 8:23 PM
durham added a reverting commit for rFBHGXe64038f89490: treemanifest: use connection pool for hg pull: rFBHGX55da01d2c3b7: treemanifest: revert e64038f8 which used the connectionpool for pull.
Nov 30 2017, 8:22 PM
durham committed rFBHGX55da01d2c3b7: treemanifest: revert e64038f8 which used the connectionpool for pull.
treemanifest: revert e64038f8 which used the connectionpool for pull
Nov 30 2017, 8:22 PM
durham committed rFBHGXd05726cb3813: tweakdefaults: update wrapping to work with upstream.
tweakdefaults: update wrapping to work with upstream
Nov 30 2017, 8:22 PM
durham requested changes to D1469: nodemap: implement nodemap in rust.

Mostly questions.

Nov 30 2017, 7:41 PM
durham accepted D1445: hiddenerror: do not wrap changectx.

I assume the tests cover this code path?

Nov 30 2017, 7:08 PM
durham created D1567: extutil: replace fcntllock with flock.
Nov 30 2017, 6:32 PM
durham created D1566: extutil: move flock to extutil.
Nov 30 2017, 6:32 PM
durham added a dependent revision for D1566: extutil: move flock to extutil: D1567: extutil: replace fcntllock with flock.
Nov 30 2017, 6:32 PM
durham added a dependent revision for D1565: hiddenoverrides: support nonblocking flock: D1566: extutil: move flock to extutil.
Nov 30 2017, 6:32 PM
durham created D1565: hiddenoverrides: support nonblocking flock.
Nov 30 2017, 6:32 PM
durham added inline comments to D1564: worker: make windows workers daemons.
Nov 30 2017, 4:29 PM

Nov 29 2017

durham closed D1544: repack: move repack lock into shared cache.
Nov 29 2017, 10:10 PM
durham committed rFBHGX3d334a08c2c8: repack: move repack lock into shared cache.
repack: move repack lock into shared cache
Nov 29 2017, 10:09 PM
durham closed D1543: repack: move to flock based locking.
Nov 29 2017, 10:09 PM
durham committed rFBHGX1c05727c4087: repack: move to fcntllock based locking.
repack: move to fcntllock based locking
Nov 29 2017, 10:09 PM
durham added inline comments to D1291: radixbuf: implement the main radix tree.
Nov 29 2017, 9:16 PM
durham requested changes to D1291: radixbuf: implement the main radix tree.

I've made it up to radix_insert_with_key. Will finish later this evening. Throwing back in your queue for now.

Nov 29 2017, 8:41 PM
durham added inline comments to D1291: radixbuf: implement the main radix tree.
Nov 29 2017, 8:25 PM
durham accepted D1432: radixbuf: add read and write functions for keys.
Nov 29 2017, 6:28 PM
durham accepted D1290: radixbuf: add a base16 iterator.

I'd follow up with Jeremey about his suggestion, but I don't think it's worth blocking getting this out for dogfooding.

Nov 29 2017, 5:39 PM
durham accepted D1289: radixbuf: initial boilerplate.
Nov 29 2017, 4:43 PM
durham accepted D1541: treemanifest: fail gracefully in prefetch if no remote is configured.
Nov 29 2017, 2:45 PM
durham accepted D1421: treemanifest: expose prefetchtrees() publicly.
Nov 29 2017, 2:45 PM
durham added a comment to D1514: perftweaks: avoid expensive branchmap calculation during commit.

I'm totally on board with getting rid of the message.

Nov 29 2017, 2:43 PM
durham created D1544: repack: move repack lock into shared cache.
Nov 29 2017, 2:06 PM
durham added a dependent revision for D1543: repack: move to flock based locking: D1544: repack: move repack lock into shared cache.
Nov 29 2017, 2:06 PM
durham added a dependency for D1544: repack: move repack lock into shared cache: D1543: repack: move to flock based locking.
Nov 29 2017, 2:06 PM