Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (103 w, 1 d)

Recent Activity

Fri, Jun 14

durin42 closed D6526: tracing: add support for emitting counters.
Fri, Jun 14, 7:16 PM
durin42 committed rHGe658ac39fe41: tracing: add support for emitting counters.
tracing: add support for emitting counters
Fri, Jun 14, 7:16 PM
durin42 closed D6525: tracing: extract tracing-active logic to separate function.
Fri, Jun 14, 7:16 PM
durin42 committed rHGd0b8a3cfd732: tracing: extract tracing-active logic to separate function.
tracing: extract tracing-active logic to separate function
Fri, Jun 14, 7:16 PM
durin42 closed D6524: catapipe: add support for COUNTER events.
Fri, Jun 14, 7:16 PM
durin42 committed rHGff562d711919: catapipe: add support for COUNTER events.
catapipe: add support for COUNTER events
Fri, Jun 14, 7:16 PM
durin42 committed rHGadb636392b3f: demandimport: add tracing coverage for Python 3.
demandimport: add tracing coverage for Python 3
Fri, Jun 14, 7:16 PM
durin42 closed D6523: demandimport: add tracing coverage for Python 3.
Fri, Jun 14, 7:15 PM

Wed, Jun 12

durin42 created D6527: dirstate: add counter events for work queue depth.
Wed, Jun 12, 10:17 PM
durin42 created D6526: tracing: add support for emitting counters.
Wed, Jun 12, 10:17 PM
durin42 created D6525: tracing: extract tracing-active logic to separate function.
Wed, Jun 12, 10:17 PM
durin42 created D6524: catapipe: add support for COUNTER events.
Wed, Jun 12, 10:17 PM
durin42 created D6522: tracing: add many more timedcm() calls throughout the codebase.
Wed, Jun 12, 5:08 PM
durin42 created D6523: demandimport: add tracing coverage for Python 3.
Wed, Jun 12, 5:07 PM
durin42 added a comment to D6475: merge: fix race that could cause wrong size in dirstate.

Do you need to update the metadata in Phabricator to tell it that D6515 is its new parent?

Wed, Jun 12, 2:12 PM
D6514: phabricator: use parents.set to always set dependencies is now accepted and ready to land.

I think the existing changes are enough. I'm overjoyed at this feature: this has been the single biggest pain point I've experienced with phabricator both as an author and as a reviewer. Thank you!

Wed, Jun 12, 12:48 PM
durin42 added a comment to D6056: patch: stop aborting when add/rename/copy files on --interactive (issue5727).

This patch breaks test-split.t - could you take a look?

Wed, Jun 12, 12:40 PM
durin42 added a comment to D6483: help: remove repeated word in 'hg help rebase'.

I'm pretty sure you should not change it in the i18n/ directory; I think those are updated by the translators for each language. I'll take this patch and I'll remove all the i18n changes.

Wed, Jun 12, 12:21 PM
D6355: shelve: add `update --shelve` if shelve extension is loaded now requires changes to proceed.

I like where this is going, but agree we should add a dirty-subrepos check so this doesn't burn subrepo users.

Wed, Jun 12, 12:17 PM
durin42 added a comment to D6082: phabricator: add a `--branch` flag to `hg phabsend`.

FYI: I've updated our phabricator recently, so maybe it's worth revisiting the branch-name-in-phab functionality from this patch?

Wed, Jun 12, 12:11 PM
durin42 added a comment to D6475: merge: fix race that could cause wrong size in dirstate.

I'm broadly happy with this, but had one point where I need clarification and I'd appreciate splitting the worker.py bit into its own change.

Wed, Jun 12, 12:07 PM
durin42 added a comment to D6506: revlog: speed up isancestor.

Impressive work. Thanks!

Wed, Jun 12, 11:57 AM

Tue, Jun 11

durin42 added a comment to D6509: ignore me -testing phab email.

I'm basically convinced things are fine now.

Tue, Jun 11, 1:51 PM
durin42 added a comment to D6509: ignore me -testing phab email.

Test message please ignore

Tue, Jun 11, 1:26 PM
durin42 added a comment to D6509: ignore me -testing phab email.

testing inbound email

Tue, Jun 11, 12:19 PM
durin42 created D6509: ignore me -testing phab email.
Tue, Jun 11, 11:59 AM

Wed, Jun 5

durin42 committed rHGc77ab654415b: merge with stable.
merge with stable
Wed, Jun 5, 10:20 AM
durin42 committed rHG52966ddfe77b: Added signature for changeset c3484ddbdb96.
Added signature for changeset c3484ddbdb96
Wed, Jun 5, 10:20 AM
durin42 committed rHGcd296aee2f00: Added tag 5.0.1 for changeset c3484ddbdb96.
Added tag 5.0.1 for changeset c3484ddbdb96
Wed, Jun 5, 10:20 AM

Wed, May 29

durin42 closed D6457: perf: fix some missing b prefixes.
Wed, May 29, 10:33 AM
durin42 committed rHG4372d56112c9: perf: fix some missing b prefixes.
perf: fix some missing b prefixes
Wed, May 29, 10:32 AM
durin42 committed rHGc2deb2512823: testparseutil: fix doctest to use str instead of bytes.
testparseutil: fix doctest to use str instead of bytes
Wed, May 29, 10:32 AM
durin42 closed D6456: testparseutil: fix doctest to use str instead of bytes.
Wed, May 29, 10:32 AM
durin42 committed rHG37f38e1dea44: testparseutil: stop extracting using std* streams as bytes on py3.
testparseutil: stop extracting using std* streams as bytes on py3
Wed, May 29, 10:32 AM
durin42 closed D6455: testparseutil: stop extracting using std* streams as bytes on py3.
Wed, May 29, 10:32 AM
durin42 committed rHG04eb3c5607af: contrib: fix import-checker to operate on str instead of bytes.
contrib: fix import-checker to operate on str instead of bytes
Wed, May 29, 10:32 AM
durin42 closed D6454: tests: sort some imports that were previously missed.
Wed, May 29, 10:32 AM
durin42 committed rHG055687fe4c47: tests: sort some imports that were previously missed.
tests: sort some imports that were previously missed
Wed, May 29, 10:32 AM
durin42 closed D6453: contrib: fix import-checker to operate on str instead of bytes.
Wed, May 29, 10:32 AM
durin42 created D6457: perf: fix some missing b prefixes.
Wed, May 29, 10:15 AM
durin42 created D6456: testparseutil: fix doctest to use str instead of bytes.
Wed, May 29, 10:14 AM
durin42 created D6455: testparseutil: stop extracting using std* streams as bytes on py3.
Wed, May 29, 10:14 AM
durin42 created D6454: tests: sort some imports that were previously missed.
Wed, May 29, 10:14 AM
durin42 created D6453: contrib: fix import-checker to operate on str instead of bytes.
Wed, May 29, 10:14 AM

Tue, May 28

durin42 committed rHG12bd4e2d4d06: merge with stable.
merge with stable
Tue, May 28, 9:59 AM

Fri, May 24

durin42 added inline comments to D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
Fri, May 24, 9:15 AM

Thu, May 23

durin42 added inline comments to D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
Thu, May 23, 9:32 AM

Mon, May 20

durin42 closed D6411: absorb: fix interactive mode I didn't know existed.
Mon, May 20, 5:36 PM
durin42 closed D6410: tests: work around libressl being different about error strings (issue6122).
Mon, May 20, 5:36 PM
durin42 committed rHG86f17fc31aa8: absorb: fix interactive mode I didn't know existed.
absorb: fix interactive mode I didn't know existed
Mon, May 20, 5:36 PM
durin42 committed rHGe0ac310bd033: tests: work around libressl being different about error strings (issue6122).
tests: work around libressl being different about error strings (issue6122)
Mon, May 20, 5:36 PM
durin42 created D6411: absorb: fix interactive mode I didn't know existed.
Mon, May 20, 2:00 PM
durin42 committed rHGffab9eed3921: merge with stable.
merge with stable
Mon, May 20, 11:49 AM
durin42 created D6410: tests: work around libressl being different about error strings (issue6122).
Mon, May 20, 11:47 AM

Sat, May 18

durin42 closed D6399: tests: fix test-clonebundles on recent openbsd.
Sat, May 18, 10:31 AM
durin42 committed rHGda3861ef7959: tests: fix test-clonebundles on recent openbsd.
tests: fix test-clonebundles on recent openbsd
Sat, May 18, 10:31 AM

Fri, May 17

durin42 committed rHGd6c1dd936778: rust: sort dependencies entries in Cargo.toml.
rust: sort dependencies entries in Cargo.toml
Fri, May 17, 11:36 PM

May 17 2019

durin42 closed D6398: rust: sort dependencies entries in Cargo.toml.
May 17 2019, 2:17 PM
durin42 committed rHG0a6209c9fcf5: rust: sort dependencies entries in Cargo.toml.
rust: sort dependencies entries in Cargo.toml
May 17 2019, 2:16 PM
durin42 created D6399: tests: fix test-clonebundles on recent openbsd.
May 17 2019, 11:04 AM
durin42 created D6398: rust: sort dependencies entries in Cargo.toml.
May 17 2019, 9:42 AM

May 16 2019

durin42 committed rHGc07dcf7a0247: exthelper: add some semi-useful trace logs.
exthelper: add some semi-useful trace logs
May 16 2019, 11:39 AM
durin42 committed rHG7d4ca1ad6537: exthelper: add some semi-useful trace logs.
exthelper: add some semi-useful trace logs
May 16 2019, 7:58 AM
durin42 closed D6381: exthelper: add some semi-useful trace logs.
May 16 2019, 7:58 AM

May 15 2019

durin42 created D6381: exthelper: add some semi-useful trace logs.
May 15 2019, 8:57 PM
durin42 accepted D6273: rust-filepatterns: call new Rust implementations from Python.

Are there any performance implications of this yet?

May 15 2019, 2:13 PM
durin42 accepted D6272: rust-filepatterns: add `rust-cpython` bindings for `filepatterns`.
May 15 2019, 2:12 PM
durin42 requested changes to D6271: rust-filepatterns: add a Rust implementation of pattern-related utils.

(forgot to tag as needing changes)

May 15 2019, 2:11 PM
durin42 added a comment to D6271: rust-filepatterns: add a Rust implementation of pattern-related utils.

Ugh, but I got conflicts in Cargo.lock - could you rebase and let me know when you're ready?

May 15 2019, 2:11 PM
durin42 accepted D6271: rust-filepatterns: add a Rust implementation of pattern-related utils.

Meta-comment: we should extract an hgignore crate (with minimal other deps) and publish that, because that'd be a step towards automatic hgignore support in ripgrep (burntsushi has previously indicated that if there was a maintained hgignore crate that it'd be a doable feature).

May 15 2019, 2:11 PM
durin42 requested changes to D5299: phabricator: fallback reading arcanist config files.

I see at least one outstanding comment that points out a typo. I'm generally in favor of this though, so please let us know when it's time to take another look.

May 15 2019, 2:08 PM
durin42 added inline comments to D6365: context: move contents of committablectx.markcommitted() to workingctx.
May 15 2019, 1:55 PM

May 10 2019

durin42 committed rHGc8d55ff80da1: sslutil: add support for SSLKEYLOGFILE to wrapsocket.
sslutil: add support for SSLKEYLOGFILE to wrapsocket
May 10 2019, 12:01 PM
durin42 closed D6343: sslutil: add support for SSLKEYLOGFILE to wrapsocket.
May 10 2019, 12:01 PM

May 9 2019

durin42 committed rHG838f3a094b4f: merge with stable.
merge with stable
May 9 2019, 6:39 PM
durin42 committed rHG65f3a77223e0: remotefilelog: log when we're about to fetch files.
remotefilelog: log when we're about to fetch files
May 9 2019, 6:07 AM
durin42 closed D6353: remotefilelog: log when we're about to fetch files.
May 9 2019, 6:07 AM

May 8 2019

durin42 committed rHGce5f1232631f: sslutil: fsencode path returned by certifi (issue6132).
sslutil: fsencode path returned by certifi (issue6132)
May 8 2019, 7:12 PM
durin42 created D6353: remotefilelog: log when we're about to fetch files.
May 8 2019, 6:21 PM
durin42 updated the diff for D6342: style: run a patched black on a subset of mercurial.
May 8 2019, 3:34 PM
durin42 updated the diff for D6342: style: run a patched black on a subset of mercurial.
May 8 2019, 3:31 PM

May 6 2019

durin42 added a comment to D6342: style: run a patched black on a subset of mercurial.

Yes, the intent is to show what the result of the patch to black is,
and once that lands to try and get consensus that we've addressed the
major issue with black and can move on. I've tried adding b prefixes
everywhere without black, or by using a different formatter, and the
other formatters just aren't good enough at wrapping lines, so not
using black will probably imply some kind of pain. :(

May 6 2019, 2:44 PM

May 5 2019

durin42 closed D6339: repair: reword comments that I noticed while working on source formatting.
May 5 2019, 1:14 AM
durin42 committed rHGd811f17090a3: repair: reword comments that I noticed while working on source formatting.
repair: reword comments that I noticed while working on source formatting
May 5 2019, 1:14 AM

May 4 2019

durin42 created D6343: sslutil: add support for SSLKEYLOGFILE to wrapsocket.
May 4 2019, 11:42 PM
durin42 created D6342: style: run a patched black on a subset of mercurial.
May 4 2019, 11:19 PM
durin42 added a comment to D6339: repair: reword comments that I noticed while working on source formatting.

PTAL

May 4 2019, 11:03 PM
durin42 updated the diff for D6339: repair: reword comments that I noticed while working on source formatting.
May 4 2019, 11:03 PM
durin42 committed rHG970aaf38c3fc: contrib: have byteify-strings explode if run in Python 2.
contrib: have byteify-strings explode if run in Python 2
May 4 2019, 9:35 PM
durin42 committed rHGe10b8058da84: repair: reword comment about bookmarks logic.
repair: reword comment about bookmarks logic
May 4 2019, 9:35 PM
durin42 closed D6340: repair: reword comment about bookmarks logic.
May 4 2019, 9:35 PM
durin42 closed D6341: contrib: have byteify-strings explode if run in Python 2.
May 4 2019, 9:35 PM
durin42 committed rHGd26bfbf419f9: monotone: fix a bogus _() wrapper that was caught when formatting code.
monotone: fix a bogus _() wrapper that was caught when formatting code
May 4 2019, 9:35 PM
durin42 closed D6338: monotone: fix a bogus _() wrapper that was caught when formatting code.
May 4 2019, 9:35 PM
durin42 created D6341: contrib: have byteify-strings explode if run in Python 2.
May 4 2019, 10:37 AM
durin42 created D6340: repair: reword comment about bookmarks logic.
May 4 2019, 10:37 AM
durin42 created D6339: repair: reword comments that I noticed while working on source formatting.
May 4 2019, 10:37 AM
durin42 created D6338: monotone: fix a bogus _() wrapper that was caught when formatting code.
May 4 2019, 10:37 AM

May 1 2019

durin42 committed rHGe64d8d73a98d: merge with stable.
merge with stable
May 1 2019, 2:33 PM
durin42 committed rHG724dae82c4bd: Added signature for changeset 07e479ef7c96.
Added signature for changeset 07e479ef7c96
May 1 2019, 2:33 PM