durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (52 w, 15 h)

Recent Activity

Mon, Jun 18

durin42 committed rHGc1fca51c26f3: streamclone: update progress later to avoid passing None to util.bytecount.
streamclone: update progress later to avoid passing None to util.bytecount
Mon, Jun 18, 12:58 AM
durin42 closed D3773: streamclone: update progress later to avoid passing None to util.bytecount.
Mon, Jun 18, 12:58 AM
durin42 committed rHG876352ea831e: highlight: adjust to attribute being private.
highlight: adjust to attribute being private
Mon, Jun 18, 12:58 AM
durin42 closed D3772: highlight: adjust to attribute being private.
Mon, Jun 18, 12:58 AM

Sun, Jun 17

durin42 added a comment to D3756: rebase: delete the comment which was not following "do not eat my data".

I'm unsure about this change. On one hand, the comment (which appears to have been added to mpm several years ago) implies that we never should have generated backups in this case. On the other, one of the key rules of a VCS is "don't eat my data." Even though we are aborting the operation, I could see some scenarios where someone would want a backup of the aborted/partially-completed rebase.

@durin42: what do you think?

Sun, Jun 17, 11:20 PM
durin42 created D3773: streamclone: update progress later to avoid passing None to util.bytecount.
Sun, Jun 17, 11:14 PM
durin42 added a dependent revision for D3772: highlight: adjust to attribute being private: D3773: streamclone: update progress later to avoid passing None to util.bytecount.
Sun, Jun 17, 11:14 PM
durin42 created D3772: highlight: adjust to attribute being private.
Sun, Jun 17, 11:14 PM

Sat, Jun 16

durin42 committed rHG03aa222ca28e: py3: whitelist another 5 passing tests thanks to the ratchet.
py3: whitelist another 5 passing tests thanks to the ratchet
Sat, Jun 16, 5:17 PM
durin42 closed D3762: py3: whitelist another 5 passing tests thanks to the ratchet.
Sat, Jun 16, 5:17 PM
durin42 created D3762: py3: whitelist another 5 passing tests thanks to the ratchet.
Sat, Jun 16, 5:10 PM

Fri, Jun 15

durin42 closed D3683: obsshelve: adapt to introduction of cmdutil.exportfile in hg 678d760c71ff.
Fri, Jun 15, 11:42 PM
durin42 closed D3682: obsshelve: pass '.' rather than '' for node id of current node.
Fri, Jun 15, 11:42 PM
durin42 closed D3681: obsshelve: adapt to rename of util.makedate.
Fri, Jun 15, 11:42 PM
durin42 committed rFBHGX43d5e8867d20: obsshelve: adapt to introduction of cmdutil.exportfile in hg 678d760c71ff.
obsshelve: adapt to introduction of cmdutil.exportfile in hg 678d760c71ff
Fri, Jun 15, 11:42 PM
durin42 committed rFBHGX818336122829: obsshelve: pass '.' rather than '' for node id of current node.
obsshelve: pass '.' rather than '' for node id of current node
Fri, Jun 15, 11:42 PM
durin42 committed rFBHGX2672d85647ee: obsshelve: adapt to rename of util.makedate.
obsshelve: adapt to rename of util.makedate
Fri, Jun 15, 11:42 PM
durin42 closed D3680: obsshelve: accept new orphan changesets output from core.
Fri, Jun 15, 11:42 PM
durin42 committed rFBHGX49d3fd78d0a6: obsshelve: accept new orphan changesets output from core.
obsshelve: accept new orphan changesets output from core
Fri, Jun 15, 11:42 PM
durin42 closed D3749: tests: replace `echo -n` with `printf` per check-code.
Fri, Jun 15, 10:36 AM
durin42 committed rHG2baf79933b45: tests: replace `echo -n` with `printf` per check-code.
tests: replace `echo -n` with `printf` per check-code
Fri, Jun 15, 10:36 AM
durin42 added a comment to D3749: tests: replace `echo -n` with `printf` per check-code.

FYI, this is intended for the stable branch.

Fri, Jun 15, 10:15 AM
durin42 created D3749: tests: replace `echo -n` with `printf` per check-code.
Fri, Jun 15, 10:15 AM
durin42 closed D3733: tests: suppress read(-1) -> '' calls in fileobjectobserver.
Fri, Jun 15, 8:48 AM
durin42 closed D3732: debugcommands: work around logiofd being a pipe and unseekable.
Fri, Jun 15, 8:48 AM
durin42 committed rHG565074cc9ac6: tests: suppress read(-1) -> '' calls in fileobjectobserver.
tests: suppress read(-1) -> '' calls in fileobjectobserver
Fri, Jun 15, 8:48 AM
durin42 committed rHG275cc461b854: debugcommands: work around logiofd being a pipe and unseekable.
debugcommands: work around logiofd being a pipe and unseekable
Fri, Jun 15, 8:48 AM

Thu, Jun 14

durin42 committed rHG2049a21c8396: py3: two more passing tests from the ratchet in buildbot.
py3: two more passing tests from the ratchet in buildbot
Thu, Jun 14, 5:00 PM
durin42 closed D3736: py3: two more passing tests from the ratchet in buildbot.
Thu, Jun 14, 5:00 PM
durin42 created D3736: py3: two more passing tests from the ratchet in buildbot.
Thu, Jun 14, 4:51 PM
durin42 updated subscribers of D3733: tests: suppress read(-1) -> '' calls in fileobjectobserver.

@indygreg I'm not sure if this undermines your testing strategy at all, but if it does we can try and figure out another path forward...

Thu, Jun 14, 12:12 PM
durin42 created D3733: tests: suppress read(-1) -> '' calls in fileobjectobserver.
Thu, Jun 14, 12:11 PM
durin42 created D3732: debugcommands: work around logiofd being a pipe and unseekable.
Thu, Jun 14, 12:11 PM
durin42 added a dependent revision for D3732: debugcommands: work around logiofd being a pipe and unseekable: D3733: tests: suppress read(-1) -> '' calls in fileobjectobserver.
Thu, Jun 14, 12:11 PM

Wed, Jun 13

durin42 closed D3729: bitmanipulation: fix undefined behavior in bit shift in getbe32.
Wed, Jun 13, 1:31 PM
durin42 committed rHG1fb2510cf8c8: bitmanipulation: fix undefined behavior in bit shift in getbe32.
bitmanipulation: fix undefined behavior in bit shift in getbe32
Wed, Jun 13, 1:31 PM
durin42 created D3729: bitmanipulation: fix undefined behavior in bit shift in getbe32.
Wed, Jun 13, 10:25 AM
durin42 committed rHGaf0e88e64ede: hgweb: insist http_status value is a sysstr.
hgweb: insist http_status value is a sysstr
Wed, Jun 13, 8:37 AM
durin42 closed D3727: hgweb: insist http_status value is a sysstr.
Wed, Jun 13, 8:37 AM
durin42 committed rHG9f499d28efb4: hgweb: pass a sysstr to low-level _start_response method.
hgweb: pass a sysstr to low-level _start_response method
Wed, Jun 13, 8:37 AM
durin42 closed D3726: hgweb: pass a sysstr to low-level _start_response method.
Wed, Jun 13, 8:37 AM
durin42 closed D3724: cvsps: port changeset __repr__ to py3.
Wed, Jun 13, 8:37 AM
durin42 committed rHGbec815f991b0: cvsps: port changeset __repr__ to py3.
cvsps: port changeset __repr__ to py3
Wed, Jun 13, 8:37 AM
durin42 committed rHG42f3a277c8dc: tests: fix printenv script on Python 3.
tests: fix printenv script on Python 3
Wed, Jun 13, 8:37 AM
durin42 closed D3723: cvsps: avoid comparison between None and a tuple in date sorting.
Wed, Jun 13, 8:37 AM
durin42 closed D3725: tests: fix printenv script on Python 3.
Wed, Jun 13, 8:37 AM
durin42 committed rHG80f6e95fac2d: cvsps: avoid comparison between None and a tuple in date sorting.
cvsps: avoid comparison between None and a tuple in date sorting
Wed, Jun 13, 8:37 AM
durin42 committed rHG9f56ad50924d: py3: buildbot informs me we have two new passing tests.
py3: buildbot informs me we have two new passing tests
Wed, Jun 13, 8:37 AM
durin42 closed D3722: py3: buildbot informs me we have two new passing tests.
Wed, Jun 13, 8:37 AM
durin42 committed rHG6cc5d01a58a6: tests: fix test-patch.t on pickier /bin/sh implementations.
tests: fix test-patch.t on pickier /bin/sh implementations
Wed, Jun 13, 8:18 AM

Tue, Jun 12

durin42 accepted D3721: run-tests: restrict the test cases allowed characters.
Tue, Jun 12, 10:13 PM
durin42 created D3727: hgweb: insist http_status value is a sysstr.
Tue, Jun 12, 9:09 PM
durin42 added a dependent revision for D3726: hgweb: pass a sysstr to low-level _start_response method: D3727: hgweb: insist http_status value is a sysstr.
Tue, Jun 12, 9:09 PM
durin42 created D3726: hgweb: pass a sysstr to low-level _start_response method.
Tue, Jun 12, 9:09 PM
durin42 created D3725: tests: fix printenv script on Python 3.
Tue, Jun 12, 9:09 PM
durin42 created D3724: cvsps: port changeset __repr__ to py3.
Tue, Jun 12, 9:09 PM
durin42 created D3723: cvsps: avoid comparison between None and a tuple in date sorting.
Tue, Jun 12, 9:09 PM
durin42 added a dependent revision for D3723: cvsps: avoid comparison between None and a tuple in date sorting: D3724: cvsps: port changeset __repr__ to py3.
Tue, Jun 12, 9:09 PM
durin42 created D3722: py3: buildbot informs me we have two new passing tests.
Tue, Jun 12, 6:21 PM
durin42 added a comment to D3694: shelve: use more accurate description in conflict marker.

How much work is this, do you have any idea?

The first option (adding "reserved" phase) should be very quick to implement. It might need minor adjustment for performance but I don't expect many.

The second option (changing all algorithm to handle the gap) is more work since about all algorithm touching phases in Core and extensions assume they can be handled as a simple list.

So I would pick the first option.

Tue, Jun 12, 5:35 PM
durin42 added a comment to D3716: ui: add an unsafeoperation context manager that can block SIGINT.

Good suggestions, integrated them. :)

Tue, Jun 12, 5:32 PM
durin42 updated the diff for D3716: ui: add an unsafeoperation context manager that can block SIGINT.
Tue, Jun 12, 5:31 PM
durin42 added a comment to D3700: run-tests: add support for external test result.

I see some what, but not any why. Why is this useful?

I need this changeset to integrate the mercurial test runner with some external tools.

Tue, Jun 12, 5:12 PM
durin42 accepted D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API).

I'm in favor, but feel like I've got enough conflict of interest I shouldn't land the patches.

Tue, Jun 12, 1:41 PM
durin42 added a comment to D3700: run-tests: add support for external test result.

I see some what, but not any why. Why is this useful?

Tue, Jun 12, 12:58 PM
durin42 accepted D3703: serve: do not daemonize by default by --print-url.
Tue, Jun 12, 12:57 PM
durin42 added inline comments to D3702: mercurial: add .t files to .editorconfig.
Tue, Jun 12, 12:57 PM
durin42 created D3719: narrowbundle2: when we handle a widen, mark the operation as unsafe.
Tue, Jun 12, 11:31 AM
durin42 added a dependent revision for D3718: narrow: mark the critical chunks of narrowing/widening as unsafe: D3719: narrowbundle2: when we handle a widen, mark the operation as unsafe.
Tue, Jun 12, 11:31 AM
durin42 created D3718: narrow: mark the critical chunks of narrowing/widening as unsafe.
Tue, Jun 12, 11:31 AM
durin42 created D3716: ui: add an unsafeoperation context manager that can block SIGINT.
Tue, Jun 12, 11:31 AM
durin42 added a dependent revision for D3717: repair: mark the critical section of strip() as unsafe: D3718: narrow: mark the critical chunks of narrowing/widening as unsafe.
Tue, Jun 12, 11:31 AM
durin42 created D3717: repair: mark the critical section of strip() as unsafe.
Tue, Jun 12, 11:31 AM
durin42 added a dependent revision for D3716: ui: add an unsafeoperation context manager that can block SIGINT: D3717: repair: mark the critical section of strip() as unsafe.
Tue, Jun 12, 11:31 AM

Mon, Jun 11

durin42 added a comment to D3694: shelve: use more accurate description in conflict marker.

Interesting. I think I like this, it's a bummer that it requires a format bump in requires.

  • There are no format changes per-se, older client would preserve the phases for internal changesets, but have them visible,
Mon, Jun 11, 11:01 AM

Fri, Jun 8

durin42 closed D3697: fuzz: try and generate an interesting mpatch seed from a repo.
Fri, Jun 8, 10:29 AM
durin42 committed rHG99ab72b867b7: fuzz: try and generate an interesting mpatch seed from a repo.
fuzz: try and generate an interesting mpatch seed from a repo
Fri, Jun 8, 10:29 AM
durin42 closed D3696: fuzz: structured helpers for creating mpatch seed corpus entries.
Fri, Jun 8, 10:29 AM
durin42 committed rHG06e2fc08f6f0: fuzz: structured helpers for creating mpatch seed corpus entries.
fuzz: structured helpers for creating mpatch seed corpus entries
Fri, Jun 8, 10:29 AM
durin42 closed D3695: fuzz: new fuzzer for the mpatch code.
Fri, Jun 8, 10:29 AM
durin42 committed rHG46dcb9f14900: fuzz: new fuzzer for the mpatch code.
fuzz: new fuzzer for the mpatch code
Fri, Jun 8, 10:29 AM

Thu, Jun 7

durin42 added a comment to D3649: serve: add option print-url.
In D3649#57906, @yuja wrote:

(resend because I forgot to remove the Phab shit, sorry for the noise.)

> It's surprising that `hg serve --print-url` spawns a daemon process!

If it does not launch a daemon process, the procress caller (`xdg-open`, `midori`, `firefox`, etc.) waits the end of the stream to launch, so it waits that the `hg serve` procress ends!

You can just run hg serve -d --print-url.

The option could be named as --daemon-print-url if we needed such big
red switch, but I don't think that makes sense.

Thu, Jun 7, 11:20 AM · Restricted Project

Wed, Jun 6

durin42 added a comment to D3698: chg: fix an undefined behavior about memcpy.

Lovely. Queued for stable, many thanks.

Wed, Jun 6, 4:02 PM
durin42 added a comment to D3684: shelve: merge in obsshelve changes implemented at facebook.

We have an implementation of shelve without strip nor obsmarkers.

Wed, Jun 6, 3:57 PM
durin42 created D3697: fuzz: try and generate an interesting mpatch seed from a repo.
Wed, Jun 6, 1:33 PM
durin42 added a dependent revision for D3696: fuzz: structured helpers for creating mpatch seed corpus entries: D3697: fuzz: try and generate an interesting mpatch seed from a repo.
Wed, Jun 6, 1:33 PM
durin42 created D3696: fuzz: structured helpers for creating mpatch seed corpus entries.
Wed, Jun 6, 1:33 PM
durin42 added a dependent revision for D3695: fuzz: new fuzzer for the mpatch code: D3696: fuzz: structured helpers for creating mpatch seed corpus entries.
Wed, Jun 6, 1:33 PM
durin42 created D3695: fuzz: new fuzzer for the mpatch code.
Wed, Jun 6, 1:33 PM
durin42 committed rHGead71b15efd5: merge with stable.
merge with stable
Wed, Jun 6, 1:32 PM
durin42 committed rHG0a3ff7af24a9: Added signature for changeset 9c5ced5276d6.
Added signature for changeset 9c5ced5276d6
Wed, Jun 6, 1:32 PM
durin42 committed rHGfc0e23c76587: Added tag 4.6.1 for changeset 9c5ced5276d6.
Added tag 4.6.1 for changeset 9c5ced5276d6
Wed, Jun 6, 1:32 PM
durin42 committed rHG9c5ced5276d6: mpatch: avoid integer overflow in combine() (SEC).
mpatch: avoid integer overflow in combine() (SEC)
Wed, Jun 6, 1:25 PM
durin42 committed rHG59837a16896d: mpatch: avoid integer overflow in mpatch_decode (SEC).
mpatch: avoid integer overflow in mpatch_decode (SEC)
Wed, Jun 6, 1:25 PM
durin42 committed rHGb8b253aec953: mpatch: introduce a safesub() helper as well.
mpatch: introduce a safesub() helper as well
Wed, Jun 6, 1:24 PM
durin42 committed rHG0b208c13781c: mpatch: fix UB in int overflows in gather() (SEC).
mpatch: fix UB in int overflows in gather() (SEC)
Wed, Jun 6, 1:24 PM
durin42 committed rHG7f22ef3c0ee7: mpatch: fix UB integer overflows in discard() (SEC).
mpatch: fix UB integer overflows in discard() (SEC)
Wed, Jun 6, 1:24 PM
durin42 committed rHG1ec4cb8cbc87: mpatch: introduce a safeadd() helper to work around UB int overflow.
mpatch: introduce a safeadd() helper to work around UB int overflow
Wed, Jun 6, 1:24 PM
durin42 committed rHGfaa924469635: mpatch: ensure fragment start isn't past the end of orig (SEC).
mpatch: ensure fragment start isn't past the end of orig (SEC)
Wed, Jun 6, 1:24 PM
durin42 committed rHG1acfc35d478c: mpatch: protect against underflow in mpatch_apply (SEC).
mpatch: protect against underflow in mpatch_apply (SEC)
Wed, Jun 6, 1:24 PM