durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (76 w, 4 d)

Recent Activity

Mon, Dec 10

durin42 added inline comments to D5275: tests: update store narrowspec when narrowspec, not dirstate, is accessed.
Mon, Dec 10, 4:28 PM

Wed, Dec 5

durin42 closed D5387: tests: update `rm` invocation for new location of checklink.
Wed, Dec 5, 1:18 PM
durin42 committed rHGa444b7eb4633: tests: update `rm` invocation for new location of checklink.
tests: update `rm` invocation for new location of checklink
Wed, Dec 5, 1:18 PM
durin42 created D5387: tests: update `rm` invocation for new location of checklink.
Wed, Dec 5, 12:44 PM
durin42 closed D5371: tests: stabilize test-inherit-mode.t on FreeBSD and macOS again.
Wed, Dec 5, 6:57 AM
durin42 committed rHG59aed775610a: tests: stabilize test-inherit-mode.t on FreeBSD and macOS again.
tests: stabilize test-inherit-mode.t on FreeBSD and macOS again
Wed, Dec 5, 6:57 AM

Tue, Dec 4

durin42 created D5371: tests: stabilize test-inherit-mode.t on FreeBSD and macOS again.
Tue, Dec 4, 5:34 PM
durin42 committed rHGcb372d09d30a: merge with stable.
merge with stable
Tue, Dec 4, 5:20 PM
durin42 committed rHG47719d7c581f: Added signature for changeset 1c8c54cf9725.
Added signature for changeset 1c8c54cf9725
Tue, Dec 4, 5:20 PM
durin42 committed rHGee948f23bf2e: Added tag 4.8.1 for changeset 1c8c54cf9725.
Added tag 4.8.1 for changeset 1c8c54cf9725
Tue, Dec 4, 5:20 PM
durin42 committed rHG0fecf70fa8d4: fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness.
fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness
Tue, Dec 4, 9:54 AM
durin42 committed rHG177b47ce0375: fuzz: more correctly specify CFLAGS and LDFLAGS when building Python.
fuzz: more correctly specify CFLAGS and LDFLAGS when building Python
Tue, Dec 4, 9:54 AM
durin42 committed rHG4b83ae1e0387: fuzz: more correctly specify CFLAGS and LDFLAGS when building Python.
fuzz: more correctly specify CFLAGS and LDFLAGS when building Python
Tue, Dec 4, 7:47 AM
durin42 committed rHG54554ed8d9bb: fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness.
fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness
Tue, Dec 4, 7:47 AM
durin42 closed D5363: fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness.
Tue, Dec 4, 7:47 AM
durin42 closed D5362: fuzz: more correctly specify CFLAGS and LDFLAGS when building Python.
Tue, Dec 4, 7:47 AM

Mon, Dec 3

durin42 added a comment to D4312: New bookflow extension for bookmark-based branching.
In D4312#79573, @smf wrote:

There's been some good discussion on this. I'm sympathetic to both arguments here, namely: "we could improve bookmarks and make them less bad" and "bookmarks are a dead end and nobody should use them and we shouldn't improve them" (or thereabouts - I'm summarizing complicated positions to less than a sentence, so bear with me.) I think not following up on our plans to at least make plausible incremental improvements to bookmarks serves our users poorly, and this extension merits landing as an experimental extension. We can always spin it back out if we get unhappy with it.

Obviously, I can't say I'm too happy with this. Allowing users to shoot themselves in the foot even more is pretty bad.

Mon, Dec 3, 8:03 PM
durin42 added a dependent revision for D5362: fuzz: more correctly specify CFLAGS and LDFLAGS when building Python: D5363: fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness.
Mon, Dec 3, 6:19 PM
durin42 created D5363: fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness.
Mon, Dec 3, 6:19 PM
durin42 created D5362: fuzz: more correctly specify CFLAGS and LDFLAGS when building Python.
Mon, Dec 3, 6:19 PM
durin42 accepted D5345: sparse-revlog: enabled by default.

I'm +1, but would like someone else to before I push.

Mon, Dec 3, 3:08 PM
durin42 updated subscribers of D4312: New bookflow extension for bookmark-based branching.

There's been some good discussion on this. I'm sympathetic to both arguments here, namely: "we could improve bookmarks and make them less bad" and "bookmarks are a dead end and nobody should use them and we shouldn't improve them" (or thereabouts - I'm summarizing complicated positions to less than a sentence, so bear with me.) I think not following up on our plans to at least make plausible incremental improvements to bookmarks serves our users poorly, and this extension merits landing as an experimental extension. We can always spin it back out if we get unhappy with it.

Mon, Dec 3, 2:54 PM

Fri, Nov 30

durin42 closed D5347: manifest: reject lines shorter than 42 bytes, not 22.
Fri, Nov 30, 7:07 AM
durin42 committed rHG7e6834ade51d: manifest: reject lines shorter than 42 bytes, not 22.
manifest: reject lines shorter than 42 bytes, not 22
Fri, Nov 30, 7:07 AM
durin42 closed D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
Fri, Nov 30, 7:01 AM
durin42 closed D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.
Fri, Nov 30, 7:01 AM
durin42 committed rHGd9fc51f77cc5: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
tests: sniff for libfuzzer actually being available in test-fuzz-targets.t
Fri, Nov 30, 7:01 AM
durin42 committed rHG6c01fad8de32: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.
tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t
Fri, Nov 30, 7:00 AM
durin42 committed rHG90e26ef4cbb1: tests: stabilize test-inherit-mode.t on FreeBSD and macOS (issue6026).
tests: stabilize test-inherit-mode.t on FreeBSD and macOS (issue6026)
Fri, Nov 30, 7:00 AM

Thu, Nov 29

durin42 added a comment to D5064: style: run black on a subset of mercurial.

Does anyone strongly object, or do we want to embrace black and the formatting changes it implies?

Is there a fix extension configuration (and I guess precommit hook- I've never used it) for this? If so, maybe it should go on the ContributingChanges page.

Thu, Nov 29, 4:46 PM
durin42 created D5347: manifest: reject lines shorter than 42 bytes, not 22.
Thu, Nov 29, 4:44 PM
durin42 updated the diff for D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
Thu, Nov 29, 4:39 PM
durin42 updated the diff for D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.
Thu, Nov 29, 4:39 PM

Wed, Nov 28

durin42 updated the diff for D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
Wed, Nov 28, 12:54 PM
durin42 updated the diff for D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.
Wed, Nov 28, 12:54 PM

Tue, Nov 27

durin42 added a comment to D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.

Updated. Note that this and its child should go on *stable*, since otherwise the test is broken on FreeBSD 11.2 there.

Tue, Nov 27, 11:13 AM
durin42 updated the diff for D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
Tue, Nov 27, 11:13 AM
durin42 updated the diff for D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.
Tue, Nov 27, 11:13 AM
durin42 added a comment to D5064: style: run black on a subset of mercurial.
In D5064#78545, @av6 wrote:

I look at the changes and see nitpicks at best. On the one hand, black proved better than any linter that we can already write consistent code. On the other, if black were a linter... I'd switch to flake8, which at least is configurable.

The whole point of black is that it is not configurable. Configurable means you still have to argue about style and decide on a configuration.

Tue, Nov 27, 10:49 AM
durin42 closed D5306: remotefilelog: fix typo in docstring.
Tue, Nov 27, 5:17 AM
durin42 committed rHG32a23c3f56d4: remotefilelog: fix typo in docstring.
remotefilelog: fix typo in docstring
Tue, Nov 27, 5:17 AM

Mon, Nov 26

durin42 added inline comments to D5302: py3: use pycompat.xrange instead of xrange.
Mon, Nov 26, 5:41 PM
durin42 created D5306: remotefilelog: fix typo in docstring.
Mon, Nov 26, 3:53 PM

Thu, Nov 22

durin42 added a comment to D5294: tests: make test-check-module-imports more robust.

Very nice! I've been intermittently looking for this for a long time and never found it.

Thu, Nov 22, 11:09 PM

Thu, Nov 15

durin42 closed D5272: tests: allow for 100% of profiled time in sleep in test-profile.t.
Thu, Nov 15, 6:34 AM
durin42 committed rHG4790732559ad: tests: allow for 100% of profiled time in sleep in test-profile.t.
tests: allow for 100% of profiled time in sleep in test-profile.t
Thu, Nov 15, 6:34 AM

Wed, Nov 14

durin42 created D5272: tests: allow for 100% of profiled time in sleep in test-profile.t.
Wed, Nov 14, 11:52 AM
durin42 closed D5271: tests: fix bytes/str issue I introduced when adding this test.
Wed, Nov 14, 10:33 AM
durin42 committed rHGab59cc71f80c: tests: fix bytes/str issue I introduced when adding this test.
tests: fix bytes/str issue I introduced when adding this test
Wed, Nov 14, 10:33 AM
durin42 created D5271: tests: fix bytes/str issue I introduced when adding this test.
Wed, Nov 14, 10:15 AM
durin42 created D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
Wed, Nov 14, 10:13 AM
durin42 added a dependent revision for D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t: D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.
Wed, Nov 14, 10:13 AM
durin42 created D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.
Wed, Nov 14, 10:13 AM

Tue, Nov 13

durin42 committed rHG7589f2c9c3c7: tests: fix wireproto redirection test on systems without tls1.2.
tests: fix wireproto redirection test on systems without tls1.2
Tue, Nov 13, 7:59 PM
durin42 abandoned D4995: tests: disable one check on Python 3.
Tue, Nov 13, 2:03 PM
durin42 abandoned D5224: revlog: check if PyInt_AS_LONG failed before using result.
Tue, Nov 13, 2:02 PM
durin42 closed D5146: histedit: import chistedit curses UI from hg-experimental.
Tue, Nov 13, 7:15 AM
durin42 committed rHGc36175456350: histedit: import chistedit curses UI from hg-experimental.
histedit: import chistedit curses UI from hg-experimental
Tue, Nov 13, 7:14 AM
durin42 closed D5258: manifest: perform cheap checks before potentially allocating memory.
Tue, Nov 13, 6:42 AM
durin42 committed rHGda4478ca0e32: manifest: perform cheap checks before potentially allocating memory.
manifest: perform cheap checks before potentially allocating memory
Tue, Nov 13, 6:42 AM
durin42 closed D5257: manifest: also reject obviously-too-short lines when parsing lines.
Tue, Nov 13, 6:42 AM
durin42 closed D5235: revlog: replace PyInt_AS_LONG with a more portable helper function.
Tue, Nov 13, 6:42 AM
durin42 closed D5256: manifest: make sure there's a filename before bothering to look for newline.
Tue, Nov 13, 6:42 AM
durin42 committed rHGf27f8e9ef1e7: manifest: also reject obviously-too-short lines when parsing lines.
manifest: also reject obviously-too-short lines when parsing lines
Tue, Nov 13, 6:42 AM
durin42 committed rHG9eeda7199181: manifest: make sure there's a filename before bothering to look for newline.
manifest: make sure there's a filename before bothering to look for newline
Tue, Nov 13, 6:42 AM
durin42 committed rHGfa33196088c4: revlog: replace PyInt_AS_LONG with a more portable helper function.
revlog: replace PyInt_AS_LONG with a more portable helper function
Tue, Nov 13, 6:42 AM

Mon, Nov 12

durin42 updated the diff for D5256: manifest: make sure there's a filename before bothering to look for newline.
Mon, Nov 12, 9:01 PM
durin42 created D5258: manifest: perform cheap checks before potentially allocating memory.
Mon, Nov 12, 8:52 PM
durin42 created D5257: manifest: also reject obviously-too-short lines when parsing lines.
Mon, Nov 12, 8:52 PM
durin42 added a dependent revision for D5257: manifest: also reject obviously-too-short lines when parsing lines: D5258: manifest: perform cheap checks before potentially allocating memory.
Mon, Nov 12, 8:52 PM
durin42 created D5256: manifest: make sure there's a filename before bothering to look for newline.
Mon, Nov 12, 8:52 PM
durin42 added a dependent revision for D5256: manifest: make sure there's a filename before bothering to look for newline: D5257: manifest: also reject obviously-too-short lines when parsing lines.
Mon, Nov 12, 8:52 PM
durin42 committed rHGd0a6b2c8f8b6: packaging: add Fedora 29 target.
packaging: add Fedora 29 target
Mon, Nov 12, 2:04 PM
durin42 closed D5254: packaging: add Fedora 29 target.
Mon, Nov 12, 2:04 PM
durin42 created D5255: mergetools: adjust Beyond Compare config on Mac/Linux.
Mon, Nov 12, 1:53 PM
durin42 updated the diff for D5235: revlog: replace PyInt_AS_LONG with a more portable helper function.
Mon, Nov 12, 11:46 AM
durin42 created D5254: packaging: add Fedora 29 target.
Mon, Nov 12, 11:44 AM

Nov 11 2018

durin42 abandoned D3684: shelve: merge in obsshelve changes implemented at facebook.
Nov 11 2018, 2:26 PM

Nov 7 2018

durin42 closed D5240: tests: fix up some import statements caught by Python 3.
Nov 7 2018, 2:57 PM
durin42 committed rHG71b8ad0ef3e0: tests: fix up some import statements caught by Python 3.
tests: fix up some import statements caught by Python 3
Nov 7 2018, 2:57 PM
durin42 created D5240: tests: fix up some import statements caught by Python 3.
Nov 7 2018, 2:22 PM
durin42 added a comment to D5235: revlog: replace PyInt_AS_LONG with a more portable helper function.
In D5235#78172, @yuja wrote:

+/* Convert a PyInt or PyLong to a long. Returns false if there is an
+ error, in which case an exception will already have been set. */
+static inline bool pylong_to_long(PyObject *pylong, long *out)

Nit: I prefer 0/-1 return value instead of bool since that's the convention
of CPython API.

Nov 7 2018, 1:44 PM
durin42 updated the diff for D5235: revlog: replace PyInt_AS_LONG with a more portable helper function.
Nov 7 2018, 1:43 PM
durin42 closed D5238: tests: work around `tac` not being portable.
Nov 7 2018, 1:30 PM
durin42 committed rHG2ad56a9b983b: tests: work around `tac` not being portable.
tests: work around `tac` not being portable
Nov 7 2018, 1:30 PM
durin42 added inline comments to D5238: tests: work around `tac` not being portable.
Nov 7 2018, 1:17 PM
durin42 created D5238: tests: work around `tac` not being portable.
Nov 7 2018, 12:15 PM
durin42 closed D5234: revlog: give formatting to clang-format.
Nov 7 2018, 7:32 AM
durin42 closed D5233: revlog: add blank line in comment to help clang-format.
Nov 7 2018, 7:32 AM
durin42 closed D5232: revlog: add a comment to help clang-format produce less-awful results.
Nov 7 2018, 7:32 AM
durin42 committed rHG5c14bf0c5be3: revlog: add blank line in comment to help clang-format.
revlog: add blank line in comment to help clang-format
Nov 7 2018, 7:32 AM
durin42 committed rHGe5ad3ef90aa1: revlog: give formatting to clang-format.
revlog: give formatting to clang-format
Nov 7 2018, 7:31 AM
durin42 committed rHG26bab5c03e4c: py3: ratchet caught two more passing tests.
py3: ratchet caught two more passing tests
Nov 7 2018, 7:31 AM
durin42 committed rHG8c1f36bf2d3e: revlog: add a comment to help clang-format produce less-awful results.
revlog: add a comment to help clang-format produce less-awful results
Nov 7 2018, 7:31 AM
durin42 closed D5236: py3: ratchet caught two more passing tests.
Nov 7 2018, 7:31 AM

Nov 6 2018

durin42 created D5236: py3: ratchet caught two more passing tests.
Nov 6 2018, 11:59 AM
durin42 added a comment to D5224: revlog: check if PyInt_AS_LONG failed before using result.
In D5224#78093, @yuja wrote:
In this case, I suspect something really weird because `PyInt_AS_LONG()` doesn't exist on Python 3 and the docs for Python 2 say it performs no error checking. So the fact that it is setting an exception on Python 3 causes me to raise an eyebrow.

It's #define PyLong_AS_LONG(op) PyLong_AsLong(op), sigh. And the reason
of the lack of PyLong_AS_LONG(op) would be that Python 3 has no bounded
integer type.

+	if (PyInt_Check(value)) {
+		long arg = PyInt_AS_LONG(value);

In this case, we'll probably have to replace PyInt_Check() + PyInt_AS_LONG()
with PyInt_AsLong() + PyErr_Occurred().

Nov 6 2018, 11:45 AM
durin42 created D5235: revlog: replace PyInt_AS_LONG with a more portable helper function.
Nov 6 2018, 11:45 AM
durin42 created D5234: revlog: give formatting to clang-format.
Nov 6 2018, 11:45 AM
durin42 created D5233: revlog: add blank line in comment to help clang-format.
Nov 6 2018, 11:44 AM