- User Since
- Jun 23 2017, 4:23 PM (103 w, 1 d)
Fri, Jun 14
Wed, Jun 12
I think the existing changes are enough. I'm overjoyed at this feature: this has been the single biggest pain point I've experienced with phabricator both as an author and as a reviewer. Thank you!
This patch breaks test-split.t - could you take a look?
I like where this is going, but agree we should add a dirty-subrepos check so this doesn't burn subrepo users.
FYI: I've updated our phabricator recently, so maybe it's worth revisiting the branch-name-in-phab functionality from this patch?
I'm broadly happy with this, but had one point where I need clarification and I'd appreciate splitting the worker.py bit into its own change.
Impressive work. Thanks!
Tue, Jun 11
I'm basically convinced things are fine now.
Test message please ignore
testing inbound email
Wed, Jun 5
Wed, May 29
Tue, May 28
Fri, May 24
Thu, May 23
Mon, May 20
Sat, May 18
Fri, May 17
May 17 2019
May 16 2019
May 15 2019
Are there any performance implications of this yet?
(forgot to tag as needing changes)
Ugh, but I got conflicts in Cargo.lock - could you rebase and let me know when you're ready?
Meta-comment: we should extract an hgignore crate (with minimal other deps) and publish that, because that'd be a step towards automatic hgignore support in ripgrep (burntsushi has previously indicated that if there was a maintained hgignore crate that it'd be a doable feature).
I see at least one outstanding comment that points out a typo. I'm generally in favor of this though, so please let us know when it's time to take another look.
May 10 2019
May 9 2019
May 8 2019
May 6 2019
Yes, the intent is to show what the result of the patch to black is,
and once that lands to try and get consensus that we've addressed the
major issue with black and can move on. I've tried adding b prefixes
everywhere without black, or by using a different formatter, and the
other formatters just aren't good enough at wrapping lines, so not
using black will probably imply some kind of pain. :(
May 5 2019
May 4 2019