- User Since
- Jun 23 2017, 4:23 PM (121 w, 1 d)
Wed, Oct 16
OOC, have you compared this with the hashbrown crate for perf?
(or a config knob)
Yeah, the bookmark-name disclosure seems like something that should be optional? Maybe put this behind a flag?
The concern is basically that the fuzzer will figure out something dumb, like 'a/' * 40000 + 'b' which consumes around a gig of memory. I don't think this is a serious OOM vector, since any such manifest would also be inordinately large?
Tue, Oct 15
That sounds fine
Mon, Oct 14
Ugh, weird. I think this is an issue around setuptools versions, but I'll try and ask dstufft this week. :(
Wed, Oct 9
Tue, Oct 8
nit: add a # skip-blame: annotation to help us in the future (maybe check history to look for how it's been annotated in the past)
Mon, Oct 7
I'd actually rather not - safehasattr is not required on py3.