Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (192 w, 6 d)

Recent Activity

Sat, Feb 27

durin42 committed rHG25b1610f8534: fuzz: if the caller of our makefile sets CC and CXX, trust them.
fuzz: if the caller of our makefile sets CC and CXX, trust them
Sat, Feb 27, 1:31 PM
durin42 closed D10066: fuzz: if the caller of our makefile sets CC and CXX, trust them.
Sat, Feb 27, 1:31 PM

Wed, Feb 24

durin42 created D10066: fuzz: if the caller of our makefile sets CC and CXX, trust them.
Wed, Feb 24, 12:41 PM
D9843: revlog: introduce v2 format now requires changes to proceed.

(marking as request changes in that case)

Wed, Feb 24, 11:21 AM
durin42 added inline comments to D9843: revlog: introduce v2 format.
Wed, Feb 24, 11:17 AM
durin42 added a comment to D9950: ci: test real dependency installation for pip.

I suspect this test works without network if setuptools is already installed, but I don't care enough to block it on that pedantry.

Wed, Feb 24, 11:04 AM
durin42 added a comment to D10020: debian: support a "chg-first" installation mechanism (hg is actually chg).

AFAICT this should be fine, but I'll give Yuya a while to catch problems.

Wed, Feb 24, 11:01 AM

Thu, Feb 11

durin42 added a comment to D9918: config: test priority involving alias.

I'm still confused here.

Thu, Feb 11, 11:57 AM
D9918: config: test priority involving alias now requires changes to proceed.

This still requires changes to resolve my comments.

Thu, Feb 11, 11:25 AM
D9982: hooks: add a `auto` value for `hooks.*run-with-plain` is now accepted and ready to land.

I'm not happy about this footgun option, but see why we need it.

Thu, Feb 11, 11:08 AM

Feb 2 2021

durin42 committed rHGd6e73351533b: branching: merge with stable.
branching: merge with stable
Feb 2 2021, 1:33 PM
D9918: config: test priority involving alias now requires changes to proceed.
Feb 2 2021, 11:50 AM

Feb 1 2021

durin42 committed rHG6b847757dd8d: relnotes: add entry for `hg diff --merge -c`.
relnotes: add entry for `hg diff --merge -c`
Feb 1 2021, 5:52 PM
durin42 closed D9944: relnotes: add entry for `hg diff --merge -c`.
Feb 1 2021, 5:52 PM
durin42 created D9944: relnotes: add entry for `hg diff --merge -c`.
Feb 1 2021, 5:13 PM
durin42 closed D8504: diff: add experimental support for "merge diffs".
Feb 1 2021, 12:51 PM
durin42 closed D9939: diff: suppress `merging foo` output lines when performing a merge diff.
Feb 1 2021, 12:51 PM
durin42 committed rHG62a0b5daa15f: diff: suppress `merging foo` output lines when performing a merge diff.
diff: suppress `merging foo` output lines when performing a merge diff
Feb 1 2021, 12:50 PM
durin42 committed rHG1a7d12c82057: diff: add experimental support for "merge diffs".
diff: add experimental support for "merge diffs"
Feb 1 2021, 12:50 PM
durin42 updated the diff for D8504: diff: add experimental support for "merge diffs".
Feb 1 2021, 12:02 PM
durin42 created D9939: diff: suppress `merging foo` output lines when performing a merge diff.
Feb 1 2021, 12:02 PM

Jan 29 2021

durin42 closed D9908: context: add missing manifest invalidation after write in overlayworkingctx.
Jan 29 2021, 1:30 PM
durin42 committed rHGbc3f3b59d0a4: context: add missing manifest invalidation after write in overlayworkingctx.
context: add missing manifest invalidation after write in overlayworkingctx
Jan 29 2021, 1:30 PM
durin42 updated the summary of D8504: diff: add experimental support for "merge diffs".
Jan 29 2021, 1:07 PM
durin42 updated the diff for D8504: diff: add experimental support for "merge diffs".
Jan 29 2021, 12:58 PM
durin42 created D9908: context: add missing manifest invalidation after write in overlayworkingctx.
Jan 29 2021, 12:57 PM

Jan 28 2021

durin42 added a comment to D9833: pyproject: add config file.

I'm honestly baffled, and don't really have time to take a look. Probably back this and its child out, and we'll roll it forward again after we drop py2?

Jan 28 2021, 1:15 PM

Jan 27 2021

durin42 committed rHG11ce2977572f: histedit: rip out mysterious catch-all ignore curses.error handler.
histedit: rip out mysterious catch-all ignore curses.error handler
Jan 27 2021, 6:21 PM
durin42 committed rHGa936e570288d: histedit: notice when the main window underflows height and abort.
histedit: notice when the main window underflows height and abort
Jan 27 2021, 6:21 PM
durin42 committed rHG8477c91b5e8e: histedit: don't assign to _ for unused values.
histedit: don't assign to _ for unused values
Jan 27 2021, 6:21 PM
durin42 closed D9854: histedit: notice when the main window underflows height and abort.
Jan 27 2021, 8:14 AM
durin42 closed D9855: histedit: rip out mysterious catch-all ignore curses.error handler.
Jan 27 2021, 8:14 AM
durin42 closed D9853: histedit: don't assign to _ for unused values.
Jan 27 2021, 8:14 AM
durin42 committed rHG1f8aa372f430: histedit: rip out mysterious catch-all ignore curses.error handler.
histedit: rip out mysterious catch-all ignore curses.error handler
Jan 27 2021, 8:13 AM
durin42 committed rHG94247310d2e6: histedit: notice when the main window underflows height and abort.
histedit: notice when the main window underflows height and abort
Jan 27 2021, 8:13 AM
durin42 committed rHGfe14325ee0a2: histedit: don't assign to _ for unused values.
histedit: don't assign to _ for unused values
Jan 27 2021, 8:13 AM

Jan 26 2021

durin42 closed D9834: black: merge config into main pyproject.toml now that we have it.
Jan 26 2021, 1:17 AM
durin42 closed D9833: pyproject: add config file.
Jan 26 2021, 1:17 AM
durin42 committed rHGd4c8b4b90ecb: black: merge config into main pyproject.toml now that we have it.
black: merge config into main pyproject.toml now that we have it
Jan 26 2021, 1:17 AM
durin42 committed rHG45afff0f530a: pyproject: add config file.
pyproject: add config file
Jan 26 2021, 1:17 AM

Jan 22 2021

durin42 added a comment to D9825: cext: add Python 3.10 support.

Do you think we should go ahead and apply the local patch then until we can update the vendored copy?

Jan 22 2021, 9:08 PM
durin42 created D9855: histedit: rip out mysterious catch-all ignore curses.error handler.
Jan 22 2021, 3:46 PM
durin42 created D9854: histedit: notice when the main window underflows height and abort.
Jan 22 2021, 3:46 PM
durin42 created D9853: histedit: don't assign to _ for unused values.
Jan 22 2021, 3:46 PM
durin42 added a comment to D9848: fastexport: committer name should not be quoted.

Should we add a test that, if git-fast-import is available, actually tries the import and verifies that things look reasonable?

Jan 22 2021, 2:55 PM
D9825: cext: add Python 3.10 support now requires changes to proceed.

Yes, please remove the python-zstandard changes from here, and send them directly to @indygreg upstream for that.

Jan 22 2021, 2:54 PM

Jan 21 2021

durin42 closed D8566: cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved())).
Jan 21 2021, 7:26 AM
durin42 closed D8623: rebase: add a config knob for forcing in-memory rebasing.
Jan 21 2021, 7:25 AM
durin42 closed D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
Jan 21 2021, 7:24 AM
durin42 committed rHG63dfaca9087f: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
filemerge: add a hacktastic version of internal:merge3 for merge diffs
Jan 21 2021, 7:24 AM
durin42 committed rHG24a32dea6955: rebase: add a config knob for forcing in-memory rebasing.
rebase: add a config knob for forcing in-memory rebasing
Jan 21 2021, 7:24 AM
durin42 committed rHGdfca84970da8: cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved())).
cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved()))
Jan 21 2021, 7:24 AM

Jan 20 2021

durin42 added a comment to D9516: perf: use the `perf--` prefix for perf command.

I'm fine with this as-is, but I am sympathetic to the concern that the -- looks like a mistake. If we want to change it we can, since we've got a full release cycle ahead of us before this is binding.

Jan 20 2021, 1:14 PM

Jan 19 2021

durin42 added a comment to D9721: convert: option to set date and time for svn commits.

Ping someone else please - I'm busy with other things this week. :(

Jan 19 2021, 2:12 PM
durin42 updated the diff for D8504: diff: add experimental support for "merge diffs".
Jan 19 2021, 1:56 PM
durin42 planned changes to D8504: diff: add experimental support for "merge diffs".
Jan 19 2021, 1:55 PM
durin42 planned changes to D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
Jan 19 2021, 1:55 PM
durin42 updated the diff for D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
Jan 19 2021, 1:54 PM
D8566: cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved())) is now accepted and ready to land.
Jan 19 2021, 1:54 PM
durin42 updated the diff for D8623: rebase: add a config knob for forcing in-memory rebasing.
Jan 19 2021, 1:53 PM
durin42 abandoned D8564: fakemergerecord: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8563: localrepo: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8562: shelve: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8626: memctx: add mergestate method.
Jan 19 2021, 1:50 PM
durin42 abandoned D8561: hg: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8559: revset: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8558: fileset: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8557: debugcommands: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8556: commands: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8555: cmdutil: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8553: histedit: use context to load mergestate instead of loading it directly.
Jan 19 2021, 1:50 PM
durin42 abandoned D8552: fix: use context to fetch mergestate instead of loading it directly.
Jan 19 2021, 1:50 PM
durin42 created D9834: black: merge config into main pyproject.toml now that we have it.
Jan 19 2021, 1:03 PM
durin42 created D9833: pyproject: add config file.
Jan 19 2021, 1:03 PM
durin42 committed rHG3b1c0c367606: merge with stable.
merge with stable
Jan 19 2021, 12:24 PM

Jan 15 2021

durin42 closed D9791: revlog: migrate from PyEval_CallObject to PyObject_Call.
Jan 15 2021, 1:02 PM
durin42 committed rHGabba2d365373: revlog: migrate from PyEval_CallObject to PyObject_Call.
revlog: migrate from PyEval_CallObject to PyObject_Call
Jan 15 2021, 1:02 PM
durin42 committed rHG4e85439c1760: fuzz: fix Makefile default PYTHON_CONFIG_FLAGS to be modern.
fuzz: fix Makefile default PYTHON_CONFIG_FLAGS to be modern
Jan 15 2021, 1:01 PM
durin42 closed D9790: fuzz: fix Makefile default PYTHON_CONFIG_FLAGS to be modern.
Jan 15 2021, 1:01 PM
durin42 created D9791: revlog: migrate from PyEval_CallObject to PyObject_Call.
Jan 15 2021, 12:58 PM
durin42 created D9790: fuzz: fix Makefile default PYTHON_CONFIG_FLAGS to be modern.
Jan 15 2021, 12:53 PM
durin42 added a comment to D9752: fuzz: try and ensure fuzzer tests run against the right python-config.

That’s super surprising to me, because it hasn’t passed for me _for months_ and our work systems should be basically identical.

Jan 15 2021, 12:28 AM
durin42 committed rHGb918494198f7: fuzz: try and ensure fuzzer tests run against the right python-config.
fuzz: try and ensure fuzzer tests run against the right python-config
Jan 15 2021, 12:01 AM

Jan 14 2021

durin42 closed D9752: fuzz: try and ensure fuzzer tests run against the right python-config.
Jan 14 2021, 8:58 AM
durin42 committed rHG11735eaa5644: fuzz: try and ensure fuzzer tests run against the right python-config.
fuzz: try and ensure fuzzer tests run against the right python-config
Jan 14 2021, 8:58 AM

Jan 13 2021

durin42 updated the diff for D9752: fuzz: try and ensure fuzzer tests run against the right python-config.
Jan 13 2021, 6:41 PM
durin42 created D9752: fuzz: try and ensure fuzzer tests run against the right python-config.
Jan 13 2021, 3:44 PM
durin42 added a comment to D9750: node: introduce nodeconstants class.

So, I'm still not sold on the "only one hash function in a repo, ever" constraint of the design this seems to imply. Is there a plan page or anything or is this all in your head?

Jan 13 2021, 2:48 PM
durin42 added a comment to D9717: contrib: stop building rust for every job.

needs rebased

Jan 13 2021, 2:45 PM
durin42 added inline comments to D9516: perf: use the `perf--` prefix for perf command.
Jan 13 2021, 2:18 PM

Jan 12 2021

durin42 added inline comments to D9721: convert: option to set date and time for svn commits.
Jan 12 2021, 10:37 AM

Jan 11 2021

durin42 added inline comments to D9721: convert: option to set date and time for svn commits.
Jan 11 2021, 7:11 PM
D9587: test-copies: reinstall initial identical (empty) files for chained copied now requires changes to proceed.

I guess I don't really understand the position of "we should back this out" particularly. Given that it's a test-only change, could we just roll-forward with the new test discussed (that is, a variant of this test with the content the same for all the files)?

Jan 11 2021, 2:25 PM
durin42 committed rHG63f0e31af0e5: merge with stable.
merge with stable
Jan 11 2021, 2:12 PM
durin42 added a comment to D9715: convert: set date and time for svn commits.

This is wrong. Subversion does not, by default, allow you to propset things like the date unless you're the repo administrator, and even if it does, you shouldn't do that. LOTS of things in Subversion have hard dependencies on the commit timestamps monotonically increasing, so this isn't something we should ever attempt.

Jan 11 2021, 2:04 PM

Jan 1 2021

durin42 added a comment to D9135: doc: Generate separate commands/topics/extension web pages..

I'm fine with this as long as it still works on Python 3. Can you confirm this works under Python 3? Maybe rebase it to @ for completeness, since it's been a while.

Jan 1 2021, 10:06 PM

Dec 18 2020

durin42 added a comment to D9422: copies: iterate over children directly (instead of parents).

I'm fine with having them I suppose.

Dec 18 2020, 12:16 PM

Dec 10 2020

durin42 closed D9560: histedit: tweak `edit` message to try and guide users to our workflow.
Dec 10 2020, 1:59 PM
durin42 closed D9561: histedit: adjust comment describing `edit` action for clarity.
Dec 10 2020, 1:58 PM
durin42 committed rHG6f8a94bbfba1: histedit: adjust comment describing `edit` action for clarity.
histedit: adjust comment describing `edit` action for clarity
Dec 10 2020, 1:58 PM