Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (121 w, 1 d)

Recent Activity

Wed, Oct 16

durin42 committed rHG4353942be294: tracing: add a couple of trace points on obsolete and repoview.
tracing: add a couple of trace points on obsolete and repoview
Wed, Oct 16, 10:37 PM
durin42 committed rHG6fcdcea2b03a: dirstate: add some traces on listdir calls.
dirstate: add some traces on listdir calls
Wed, Oct 16, 10:37 PM
durin42 committed rHG101ae8bbfa02: cleanup: hgdemandimport.tracing accepts strings, not bytes.
cleanup: hgdemandimport.tracing accepts strings, not bytes
Wed, Oct 16, 10:37 PM
durin42 committed rHGb21e3a747501: tests: fix formatting test after move of black config.
tests: fix formatting test after move of black config
Wed, Oct 16, 10:37 PM
durin42 added a comment to D7116: rust-performance: introduce FastHashMap type alias for HashMap.

OOC, have you compared this with the hashbrown crate for perf?

Wed, Oct 16, 4:53 PM
durin42 added a comment to D7056: phabricator: include bookmark in diff metadata.

(or a config knob)

Wed, Oct 16, 4:44 PM
durin42 added a comment to D7056: phabricator: include bookmark in diff metadata.

Yeah, the bookmark-name disclosure seems like something that should be optional? Maybe put this behind a flag?

Wed, Oct 16, 4:43 PM
durin42 added inline comments to D7061: convert: don't pass bytes to, or expect bytes from, emailparser.
Wed, Oct 16, 4:43 PM
durin42 added inline comments to D7055: phabricator: update hgmatcher to cope with the new data format.
Wed, Oct 16, 4:41 PM
durin42 committed rHG74affe7bed81: tracing: add a couple of trace points on obsolete and repoview.
tracing: add a couple of trace points on obsolete and repoview
Wed, Oct 16, 12:20 PM
durin42 committed rHGad6fdb90e688: tests: fix formatting test after move of black config.
tests: fix formatting test after move of black config
Wed, Oct 16, 12:20 PM
durin42 committed rHGecd3832a6cfd: cleanup: hgdemandimport.tracing accepts strings, not bytes.
cleanup: hgdemandimport.tracing accepts strings, not bytes
Wed, Oct 16, 12:20 PM
durin42 committed rHGfbc1c6bb6c52: dirstate: add some traces on listdir calls.
dirstate: add some traces on listdir calls
Wed, Oct 16, 12:20 PM
durin42 closed D7108: cleanup: hgdemandimport.tracing accepts strings, not bytes.
Wed, Oct 16, 10:23 AM
durin42 committed rHG149d6ba20d9a: tracing: add a couple of trace points on obsolete and repoview.
tracing: add a couple of trace points on obsolete and repoview
Wed, Oct 16, 10:22 AM
durin42 closed D6550: tracing: add a couple of trace points on obsolete and repoview.
Wed, Oct 16, 10:22 AM
durin42 closed D7109: dirstate: add some traces on listdir calls.
Wed, Oct 16, 10:22 AM
durin42 committed rHGbc5c4919a1a0: dirstate: add some traces on listdir calls.
dirstate: add some traces on listdir calls
Wed, Oct 16, 10:22 AM
durin42 closed D7102: tests: fix formatting test after move of black config.
Wed, Oct 16, 10:21 AM
durin42 committed rHG707a4d56f05a: cleanup: hgdemandimport.tracing accepts strings, not bytes.
cleanup: hgdemandimport.tracing accepts strings, not bytes
Wed, Oct 16, 10:21 AM
durin42 committed rHG1a7d1f1aa0ac: tests: fix formatting test after move of black config.
tests: fix formatting test after move of black config
Wed, Oct 16, 10:21 AM
durin42 added a comment to D7106: fuzz: restrict dirs fuzzer to only 40k of input.

The concern is basically that the fuzzer will figure out something dumb, like 'a/' * 40000 + 'b' which consumes around a gig of memory. I don't think this is a serious OOM vector, since any such manifest would also be inordinately large?

Wed, Oct 16, 12:16 AM
durin42 closed D7105: dirs: reject consecutive slashes in paths.
Wed, Oct 16, 12:08 AM
durin42 closed D7104: dirs: give formatting oversight to clang-format.
Wed, Oct 16, 12:08 AM
durin42 committed rHG1f04c51d52ea: dirs: reject consecutive slashes in paths.
dirs: reject consecutive slashes in paths
Wed, Oct 16, 12:08 AM
durin42 committed rHGea62d7b06c12: dirs: give formatting oversight to clang-format.
dirs: give formatting oversight to clang-format
Wed, Oct 16, 12:08 AM
durin42 closed D7103: dirs: tag a struct as not being formattable.
Wed, Oct 16, 12:08 AM
durin42 committed rHGbe178b5d91c8: dirs: tag a struct as not being formattable.
dirs: tag a struct as not being formattable
Wed, Oct 16, 12:08 AM

Tue, Oct 15

durin42 added a comment to D7026: treemanifest: move out of experimental.

That sounds fine

Tue, Oct 15, 6:46 PM
durin42 created D7108: cleanup: hgdemandimport.tracing accepts strings, not bytes.
Tue, Oct 15, 11:23 AM
durin42 updated the diff for D6550: tracing: add a couple of trace points on obsolete and repoview.
Tue, Oct 15, 11:23 AM
durin42 created D7109: dirstate: add some traces on listdir calls.
Tue, Oct 15, 11:23 AM
durin42 abandoned D6527: dirstate: add counter events for work queue depth.
Tue, Oct 15, 10:59 AM
durin42 abandoned D6522: tracing: add many more timedcm() calls throughout the codebase.
Tue, Oct 15, 10:59 AM
durin42 created D7106: fuzz: restrict dirs fuzzer to only 40k of input.
Tue, Oct 15, 9:58 AM
durin42 created D7105: dirs: reject consecutive slashes in paths.
Tue, Oct 15, 9:55 AM
durin42 created D7104: dirs: give formatting oversight to clang-format.
Tue, Oct 15, 9:55 AM
durin42 created D7103: dirs: tag a struct as not being formattable.
Tue, Oct 15, 9:54 AM
durin42 created D7102: tests: fix formatting test after move of black config.
Tue, Oct 15, 9:48 AM

Mon, Oct 14

durin42 closed D7090: black: also ignore grey.py.
Mon, Oct 14, 11:01 PM
durin42 closed D7089: black: use multiline exclude definition.
Mon, Oct 14, 11:01 PM
durin42 closed D7088: black: move remaining config knobs into toml file.
Mon, Oct 14, 11:01 PM
durin42 committed rHG8343070ed758: black: also ignore grey.py.
black: also ignore grey.py
Mon, Oct 14, 11:01 PM
durin42 closed D7087: black: rename pyproject.toml to black.toml.
Mon, Oct 14, 11:01 PM
durin42 committed rHG2a201b366d5b: black: use multiline exclude definition.
black: use multiline exclude definition
Mon, Oct 14, 11:01 PM
durin42 committed rHG15c05732d177: black: move remaining config knobs into toml file.
black: move remaining config knobs into toml file
Mon, Oct 14, 11:01 PM
durin42 committed rHG8f89899a5446: black: rename pyproject.toml to black.toml.
black: rename pyproject.toml to black.toml
Mon, Oct 14, 11:01 PM
durin42 created D7090: black: also ignore grey.py.
Mon, Oct 14, 1:02 PM
durin42 created D7088: black: move remaining config knobs into toml file.
Mon, Oct 14, 1:02 PM
durin42 created D7089: black: use multiline exclude definition.
Mon, Oct 14, 1:02 PM
durin42 created D7087: black: rename pyproject.toml to black.toml.
Mon, Oct 14, 1:02 PM
durin42 added a comment to D6993: black: add a pyproject.toml that contains our black settings.

Ugh, weird. I think this is an issue around setuptools versions, but I'll try and ask dstufft this week. :(

Mon, Oct 14, 10:29 AM

Wed, Oct 9

durin42 committed rHGb37dd26935ee: fuzz: new fuzzer for fncache-related functions.
fuzz: new fuzzer for fncache-related functions
Wed, Oct 9, 11:51 PM
durin42 committed rHG741fb1a95da2: fuzz: new target to fuzz jsonescapeu8fast.
fuzz: new target to fuzz jsonescapeu8fast
Wed, Oct 9, 11:51 PM
durin42 committed rHG36e386dbbd30: fuzz: exercise a little more revlog code.
fuzz: exercise a little more revlog code
Wed, Oct 9, 11:50 PM
durin42 committed rHG7ff40418c6bf: fuzz: new fuzzer for dirs.c.
fuzz: new fuzzer for dirs.c
Wed, Oct 9, 11:50 PM
durin42 closed D7034: fuzz: new target to fuzz jsonescapeu8fast.
Wed, Oct 9, 11:23 PM
durin42 closed D7033: fuzz: new fuzzer for fncache-related functions.
Wed, Oct 9, 11:23 PM
durin42 closed D7032: fuzz: exercise a little more revlog code.
Wed, Oct 9, 11:23 PM
durin42 committed rHG2b11fe679a5d: fuzz: new target to fuzz jsonescapeu8fast.
fuzz: new target to fuzz jsonescapeu8fast
Wed, Oct 9, 11:23 PM
durin42 committed rHGca2ca7fbad44: fuzz: new fuzzer for fncache-related functions.
fuzz: new fuzzer for fncache-related functions
Wed, Oct 9, 11:23 PM
durin42 closed D7031: fuzz: new fuzzer for dirs.c.
Wed, Oct 9, 11:23 PM
durin42 committed rHGdc827f5aba93: fuzz: exercise a little more revlog code.
fuzz: exercise a little more revlog code
Wed, Oct 9, 11:23 PM
durin42 committed rHGbd503fdb878c: fuzz: new fuzzer for dirs.c.
fuzz: new fuzzer for dirs.c
Wed, Oct 9, 11:23 PM
durin42 closed D7030: dirs: fix trivial over-read of input data.
Wed, Oct 9, 11:23 PM
durin42 committed rHG2a0774e9d2a8: dirs: fix trivial over-read of input data.
dirs: fix trivial over-read of input data
Wed, Oct 9, 11:23 PM
durin42 updated the summary of D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Wed, Oct 9, 5:29 PM
durin42 created D7034: fuzz: new target to fuzz jsonescapeu8fast.
Wed, Oct 9, 12:19 PM
durin42 created D7033: fuzz: new fuzzer for fncache-related functions.
Wed, Oct 9, 12:19 PM
durin42 created D7032: fuzz: exercise a little more revlog code.
Wed, Oct 9, 11:00 AM
durin42 created D7031: fuzz: new fuzzer for dirs.c.
Wed, Oct 9, 11:00 AM
durin42 created D7030: dirs: fix trivial over-read of input data.
Wed, Oct 9, 11:00 AM

Tue, Oct 8

durin42 added a comment to D7028: cleanup: join string literals that are already on one line.

nit: add a # skip-blame: annotation to help us in the future (maybe check history to look for how it's been annotated in the past)

Tue, Oct 8, 6:51 PM
durin42 closed D7022: infinitepush: mark extension as likely to be deleted.
Tue, Oct 8, 3:52 PM
durin42 committed rHGe5d535621ee1: infinitepush: mark extension as likely to be deleted.
infinitepush: mark extension as likely to be deleted
Tue, Oct 8, 3:52 PM
durin42 created D7022: infinitepush: mark extension as likely to be deleted.
Tue, Oct 8, 1:39 PM

Mon, Oct 7

durin42 added a comment to D7005: py3: manually import pycompat.open into files that need it.

Can we import io.open regardless of Python version instead?

Mon, Oct 7, 10:17 AM
durin42 added a comment to D7008: py3: stop injecting pycompat.hasattr into modules.

I'd actually rather not - safehasattr is not required on py3.

Mon, Oct 7, 12:09 AM

Sun, Oct 6

durin42 committed rHG7054fd370430: contrib: add a fork of black (as "grey") that includes my changes.
contrib: add a fork of black (as "grey") that includes my changes
Sun, Oct 6, 5:13 PM
durin42 closed D7002: contrib: add a fork of black (as "grey") that includes my changes.
Sun, Oct 6, 4:15 PM
durin42 committed rHG4f2271fd403b: contrib: add a fork of black (as "grey") that includes my changes.
contrib: add a fork of black (as "grey") that includes my changes
Sun, Oct 6, 4:15 PM
durin42 updated the summary of D7002: contrib: add a fork of black (as "grey") that includes my changes.
Sun, Oct 6, 2:55 PM
durin42 created D7002: contrib: add a fork of black (as "grey") that includes my changes.
Sun, Oct 6, 1:32 PM
durin42 closed D6996: cleanup: mark some ui.(status|note|warn|write) calls as not needing i18n.
Sun, Oct 6, 12:08 PM
durin42 closed D6997: contrib: fix check-code to be able to detect missing _() with bytestrings.
Sun, Oct 6, 12:06 PM
durin42 committed rHGe65e7290041e: contrib: fix check-code to be able to detect missing _() with bytestrings.
contrib: fix check-code to be able to detect missing _() with bytestrings
Sun, Oct 6, 12:06 PM
durin42 closed D6972: formatting: byteify all mercurial/ and hgext/ string literals.
Sun, Oct 6, 12:06 PM
durin42 committed rHG86e4daa2d54c: cleanup: mark some ui.(status|note|warn|write) calls as not needing i18n.
cleanup: mark some ui.(status|note|warn|write) calls as not needing i18n
Sun, Oct 6, 12:06 PM
durin42 closed D6971: formatting: blacken the codebase.
Sun, Oct 6, 12:06 PM
durin42 committed rHG88eba7103660: mangler: stop rewriting string constants to be bytes literals.
mangler: stop rewriting string constants to be bytes literals
Sun, Oct 6, 12:06 PM
durin42 closed D6342: style: run a patched black on a subset of mercurial.
Sun, Oct 6, 12:05 PM
durin42 closed D6973: mangler: stop rewriting string constants to be bytes literals.
Sun, Oct 6, 12:05 PM
durin42 committed rHG687b865b95ad: formatting: byteify all mercurial/ and hgext/ string literals.
formatting: byteify all mercurial/ and hgext/ string literals
Sun, Oct 6, 12:05 PM
durin42 committed rHG2372284d9457: formatting: blacken the codebase.
formatting: blacken the codebase
Sun, Oct 6, 12:05 PM
durin42 committed rHG57875cf423c9: style: run a patched black on a subset of mercurial.
style: run a patched black on a subset of mercurial
Sun, Oct 6, 12:05 PM
durin42 updated the summary of D6996: cleanup: mark some ui.(status|note|warn|write) calls as not needing i18n.
Sun, Oct 6, 12:03 PM
durin42 updated the diff for D6972: formatting: byteify all mercurial/ and hgext/ string literals.
Sun, Oct 6, 12:01 PM
durin42 updated the diff for D6971: formatting: blacken the codebase.
Sun, Oct 6, 12:00 PM
D6994: ui: define (write|status|warn|note)noi18n aliases is now accepted and ready to land.
Sun, Oct 6, 11:50 AM
durin42 created D6996: cleanup: mark some ui.(status|note|warn|write) calls as not needing i18n.
Sun, Oct 6, 11:03 AM