Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (144 w, 5 d)

Recent Activity

Yesterday

D8243: copies: stop recording buggy file merge when new file overwrite an old one now requires changes to proceed.

Per irc checkin, we expect changes on this before review.

Wed, Apr 1, 3:01 PM
durin42 committed rHG4c6189d45d67: setup: work around old versions of distutils breaking setup.py.
setup: work around old versions of distutils breaking setup.py
Wed, Apr 1, 11:21 AM
durin42 updated the diff for D8353: debugcommands: create new debugantivirusrunning command.
Wed, Apr 1, 10:51 AM
durin42 created D8353: debugcommands: create new debugantivirusrunning command.
Wed, Apr 1, 10:47 AM

Tue, Mar 31

durin42 closed D8333: tests: handle new error string from FreeBSD for dns entry not resolving.
Tue, Mar 31, 6:23 AM
durin42 committed rHG4dacd0cef146: tests: handle new error string from FreeBSD for dns entry not resolving.
tests: handle new error string from FreeBSD for dns entry not resolving
Tue, Mar 31, 6:23 AM

Thu, Mar 26

durin42 created D8333: tests: handle new error string from FreeBSD for dns entry not resolving.
Thu, Mar 26, 11:13 AM
durin42 closed D8329: tests: update test-debugcommands.t stack trace checks for python3.9.
Thu, Mar 26, 6:51 AM
durin42 closed D8328: tests: update test-archive.t expectations for python3.9 changes.
Thu, Mar 26, 6:50 AM
durin42 committed rHGa7b7a67b79c1: tests: update test-debugcommands.t stack trace checks for python3.9.
tests: update test-debugcommands.t stack trace checks for python3.9
Thu, Mar 26, 6:50 AM
durin42 closed D8327: setup: relax -Werror for declaration-after-statement on Python 3.9.
Thu, Mar 26, 6:50 AM
durin42 committed rHG862025f108c7: tests: update test-archive.t expectations for python3.9 changes.
tests: update test-archive.t expectations for python3.9 changes
Thu, Mar 26, 6:50 AM
durin42 committed rHG960770add699: setup: relax -Werror for declaration-after-statement on Python 3.9.
setup: relax -Werror for declaration-after-statement on Python 3.9
Thu, Mar 26, 6:50 AM

Wed, Mar 25

durin42 created D8329: tests: update test-debugcommands.t stack trace checks for python3.9.
Wed, Mar 25, 12:12 PM
durin42 created D8328: tests: update test-archive.t expectations for python3.9 changes.
Wed, Mar 25, 12:12 PM
durin42 created D8327: setup: relax -Werror for declaration-after-statement on Python 3.9.
Wed, Mar 25, 12:12 PM

Tue, Mar 24

durin42 added a comment to D8190: nodemap: test that concurrent process don't see the pending transaction.

I think I'm coming around on this. I've poked a few reviewers in private to look at the first three patches in this series to see how they feel, but if I don't hear back in a day or two I think I'll just push the whole stack...

Tue, Mar 24, 6:16 PM

Fri, Mar 20

durin42 added a comment to D8190: nodemap: test that concurrent process don't see the pending transaction.

This new patch works, but I don't like the idea of not testing two fully independant process. Running a process through hooks is quite different and who know how that semantic could evolve.

Fri, Mar 20, 4:05 PM
durin42 added a comment to D8190: nodemap: test that concurrent process don't see the pending transaction.

@durin42, what do you think?

Fri, Mar 20, 1:58 PM
durin42 abandoned D8272: archive: fix crash when archiving to gzip file with Python 3.8.2+.
Fri, Mar 20, 12:32 PM
durin42 added a reviewer for D8272: archive: fix crash when archiving to gzip file with Python 3.8.2+: ludovicchabant.
Fri, Mar 20, 12:32 PM
durin42 added a comment to D7296: pycompat: kludge around pytype being confused by __new__.

I'd like to get back to pytyping all the things, but I can't justify spending more time on it. If someone else wants to push things forward I'll gladly provide some mentorship.

Fri, Mar 20, 11:59 AM
durin42 added a comment to D8281: narrow: escape includepats/excludepats when sending over the wire.

Since narrow is still experimental, I don't think we should try too hard for backward compatibility. We could introduce a new end-point for a new encoding and drop the old one in a couple of version.

Fri, Mar 20, 11:57 AM
durin42 abandoned D8115: rebase: show bug when rebasing merge with obsoleted revs on both sides.
Fri, Mar 20, 11:53 AM
durin42 added a comment to D8189: testlib: add a small scrip to help process to synchronise using file.

I'm still -0 on this: I'd rather we found an approach that didn't require sleeping for so long. Perhaps a Python script would be a better fit here?
(I won't block this landing, but I won't push it.)

What abotu replacing the sleep 1 by a `python -c "import time; time.sleep(0.1)" would that make you happy ?

Fri, Mar 20, 11:53 AM
durin42 added a comment to D8189: testlib: add a small scrip to help process to synchronise using file.

I'm still -0 on this: I'd rather we found an approach that didn't require sleeping for so long. Perhaps a Python script would be a better fit here?

Fri, Mar 20, 11:46 AM

Thu, Mar 19

durin42 closed D8302: hg: make _local() behave consistently on Python 3.8 (issue6287).
Thu, Mar 19, 4:45 AM
durin42 closed D8299: remotefilelog: add fake heads() method that allows viewing a file in hgweb.
Thu, Mar 19, 4:45 AM
durin42 closed D8301: phabricator: remove duplicated byteskwargs conversion.
Thu, Mar 19, 4:45 AM
durin42 committed rHG6a8738dc4a01: hg: make _local() behave consistently on Python 3.8 (issue6287).
hg: make _local() behave consistently on Python 3.8 (issue6287)
Thu, Mar 19, 4:45 AM
durin42 committed rHG9e63108123a4: remotefilelog: add fake heads() method that allows viewing a file in hgweb.
remotefilelog: add fake heads() method that allows viewing a file in hgweb
Thu, Mar 19, 4:45 AM
durin42 closed D8298: tests: add test for remotefilelog interactions with hgweb.
Thu, Mar 19, 4:45 AM
durin42 committed rHG5483e9c759e4: tests: add test for remotefilelog interactions with hgweb.
tests: add test for remotefilelog interactions with hgweb
Thu, Mar 19, 4:45 AM
durin42 committed rHG3aab524a8480: phabricator: remove duplicated byteskwargs conversion.
phabricator: remove duplicated byteskwargs conversion
Thu, Mar 19, 4:45 AM

Wed, Mar 18

durin42 updated the diff for D8302: hg: make _local() behave consistently on Python 3.8 (issue6287).
Wed, Mar 18, 3:27 PM
durin42 retitled D8302: hg: make _local() behave consistently on Python 3.8 (issue6287) from hg: make _local() behave consistently on Python 3.8 to hg: make _local() behave consistently on Python 3.8 (issue6287).
Wed, Mar 18, 3:26 PM
durin42 created D8302: hg: make _local() behave consistently on Python 3.8 (issue6287).
Wed, Mar 18, 3:20 PM
durin42 created D8301: phabricator: remove duplicated byteskwargs conversion.
Wed, Mar 18, 3:12 PM
D8288: fix: mark -r as advanced is now accepted and ready to land.

For the record, I always use hg fix with --rev.

Wed, Mar 18, 11:56 AM

Tue, Mar 17

durin42 created D8299: remotefilelog: add fake heads() method that allows viewing a file in hgweb.
Tue, Mar 17, 5:44 PM
durin42 created D8298: tests: add test for remotefilelog interactions with hgweb.
Tue, Mar 17, 5:44 PM

Mon, Mar 16

D8286: fix: move handling of --all into getrevstofix() for consistency now requires changes to proceed.

LGTM but needs rebased?

Mon, Mar 16, 11:01 PM

Wed, Mar 11

durin42 updated subscribers of D8172: notify: optional mail threading based on obsmarker.

@marmoute

Wed, Mar 11, 11:40 AM
durin42 added a comment to D8189: testlib: add a small scrip to help process to synchronise using file.

By using explicit wait on signal (through the fs) that each process reached the appropriate file. We avoid flackyness. There are already multiple use of this approach in the test suite, that does not suffer from flackyness (unlike the wheelbarrow of flaky test relying on sleep for sync).

Wed, Mar 11, 11:27 AM
durin42 added a comment to D8187: nodemap: make sure hooks have access to an up-to-date version.

No longer applies on top of @.

I don't understand this feedback. There are about 15 other changesets before it in this stack, so this is not meant to be directly applied on the head of default.

Wed, Mar 11, 11:20 AM

Tue, Mar 10

durin42 added a comment to D8189: testlib: add a small scrip to help process to synchronise using file.

This script feels extremely like a flaky test waiting to happen. Is there no alternative for this?

Tue, Mar 10, 4:44 PM
D8188: nodemap: make sure the nodemap docket is updated after the changelog is now accepted and ready to land.
Tue, Mar 10, 4:43 PM
D8187: nodemap: make sure hooks have access to an up-to-date version now requires changes to proceed.

No longer applies on top of @.

Tue, Mar 10, 4:42 PM
durin42 accepted D8270: run-tests: restrict Rust thread pool to 3 threads during tests.
Tue, Mar 10, 4:34 PM
durin42 closed D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 1:26 PM
durin42 committed rHG02c47b74366c: git: key off `git` in .hg/requires rather than separate file.
git: key off `git` in .hg/requires rather than separate file
Tue, Mar 10, 1:26 PM
durin42 committed rHGeb061d272af4: git: correctly handle p1() on dirstate when underlying git repo is empty.
git: correctly handle p1() on dirstate when underlying git repo is empty
Tue, Mar 10, 1:26 PM
durin42 closed D8271: git: correctly handle p1() on dirstate when underlying git repo is empty.
Tue, Mar 10, 1:26 PM
durin42 retitled D8265: git: key off `git` in .hg/requires rather than separate file from git: key off `git` in .hg/requirements rather than separate file to git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 1:15 PM
durin42 created D8271: git: correctly handle p1() on dirstate when underlying git repo is empty.
Tue, Mar 10, 1:15 PM
durin42 added inline comments to D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 1:14 PM
durin42 added inline comments to D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 1:04 PM
durin42 updated the diff for D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 12:59 PM
durin42 updated the diff for D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 12:46 PM
durin42 abandoned D8260: git: hide pygit2 imports from gendoc and other scripts not using demandimport.
Tue, Mar 10, 12:35 PM
durin42 added inline comments to D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 12:35 PM
durin42 updated the diff for D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 12:35 PM
durin42 updated the diff for D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 12:31 PM
durin42 abandoned D8261: git: hack around import checker being confused about the provenance of pygit2.
Tue, Mar 10, 12:27 PM

Mon, Mar 9

durin42 committed rHG21893ff382cd: localrepo: add git extension to autoextensions list.
localrepo: add git extension to autoextensions list
Mon, Mar 9, 1:31 PM
durin42 committed rHG8b5f5d8ad783: gitlog: implement __iter__ on changelog.
gitlog: implement __iter__ on changelog
Mon, Mar 9, 1:31 PM
durin42 committed rHGf19491aae641: gitlog: fix embarassing bug that prevented log from showing correct parents.
gitlog: fix embarassing bug that prevented log from showing correct parents
Mon, Mar 9, 1:31 PM
durin42 committed rHG7518ea76eff4: git: add readfast() method to manifest.
git: add readfast() method to manifest
Mon, Mar 9, 1:31 PM
durin42 committed rHGad718271a9eb: git: skeleton of a new extension to _directly_ operate on git repos.
git: skeleton of a new extension to _directly_ operate on git repos
Mon, Mar 9, 1:31 PM
durin42 committed rHG6aee0647e026: nodemap: fix missing r-prefix on regular expression.
nodemap: fix missing r-prefix on regular expression
Mon, Mar 9, 1:31 PM
durin42 committed rHG4d27d297af07: localrepo: add git extension to autoextensions list.
localrepo: add git extension to autoextensions list
Mon, Mar 9, 11:27 AM
durin42 committed rHG5db5cfa2cab3: gitlog: implement __iter__ on changelog.
gitlog: implement __iter__ on changelog
Mon, Mar 9, 11:27 AM
durin42 committed rHGce0cad6c069f: gitlog: fix embarassing bug that prevented log from showing correct parents.
gitlog: fix embarassing bug that prevented log from showing correct parents
Mon, Mar 9, 11:27 AM
durin42 committed rHG4f5b730365e7: git: add readfast() method to manifest.
git: add readfast() method to manifest
Mon, Mar 9, 11:27 AM
durin42 committed rHG6d4f6c2f7f18: nodemap: fix missing r-prefix on regular expression.
nodemap: fix missing r-prefix on regular expression
Mon, Mar 9, 11:27 AM
durin42 closed D8266: localrepo: add git extension to autoextensions list.
Mon, Mar 9, 6:04 AM
durin42 committed rHG8407f8678a77: localrepo: add git extension to autoextensions list.
localrepo: add git extension to autoextensions list
Mon, Mar 9, 6:03 AM
durin42 closed D8264: gitlog: implement __iter__ on changelog.
Mon, Mar 9, 6:03 AM
durin42 committed rHG3e5293769f22: gitlog: implement __iter__ on changelog.
gitlog: implement __iter__ on changelog
Mon, Mar 9, 6:03 AM
durin42 closed D8263: gitlog: fix embarassing bug that prevented log from showing correct parents.
Mon, Mar 9, 6:03 AM
durin42 committed rHG559e31eabc3d: gitlog: fix embarassing bug that prevented log from showing correct parents.
gitlog: fix embarassing bug that prevented log from showing correct parents
Mon, Mar 9, 6:03 AM
durin42 closed D8262: git: add readfast() method to manifest.
Mon, Mar 9, 6:03 AM
durin42 committed rHGff465d38cf45: git: add readfast() method to manifest.
git: add readfast() method to manifest
Mon, Mar 9, 6:03 AM
durin42 closed D8254: nodemap: fix missing r-prefix on regular expression.
Mon, Mar 9, 6:03 AM
durin42 committed rHG50b570f04abb: nodemap: fix missing r-prefix on regular expression.
nodemap: fix missing r-prefix on regular expression
Mon, Mar 9, 6:03 AM

Sat, Mar 7

durin42 created D8266: localrepo: add git extension to autoextensions list.
Sat, Mar 7, 6:01 PM
durin42 created D8265: git: key off `git` in .hg/requires rather than separate file.
Sat, Mar 7, 5:57 PM
durin42 created D8264: gitlog: implement __iter__ on changelog.
Sat, Mar 7, 5:45 PM
durin42 created D8263: gitlog: fix embarassing bug that prevented log from showing correct parents.
Sat, Mar 7, 5:45 PM
durin42 created D8262: git: add readfast() method to manifest.
Sat, Mar 7, 4:51 PM
durin42 created D8261: git: hack around import checker being confused about the provenance of pygit2.
Sat, Mar 7, 4:45 PM
durin42 created D8260: git: hide pygit2 imports from gendoc and other scripts not using demandimport.
Sat, Mar 7, 4:45 PM

Fri, Mar 6

durin42 committed rHG7e69ff5789c7: git: skeleton of a new extension to _directly_ operate on git repos.
git: skeleton of a new extension to _directly_ operate on git repos
Fri, Mar 6, 7:31 PM
durin42 closed D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Mar 6, 4:57 PM
durin42 committed rHG62165f6c5a1a: git: skeleton of a new extension to _directly_ operate on git repos.
git: skeleton of a new extension to _directly_ operate on git repos
Fri, Mar 6, 4:56 PM
durin42 updated the diff for D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Mar 6, 2:35 PM
durin42 closed D8255: cleanup: run pyupgrade on our source tree to clean up varying things.
Fri, Mar 6, 2:34 PM
durin42 updated the diff for D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Mar 6, 2:31 PM
durin42 added inline comments to D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Mar 6, 2:30 PM
durin42 committed rHG9d2b2df2c2ba: cleanup: run pyupgrade on our source tree to clean up varying things.
cleanup: run pyupgrade on our source tree to clean up varying things
Fri, Mar 6, 2:23 PM