durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (86 w, 3 d)

Recent Activity

Yesterday

durin42 added a comment to D5792: uncommit: added interactive mode(issue6062).

Anything recent. @ on https://mercurial-scm.org/hg is fine.

Sun, Feb 17, 3:23 PM
durin42 added a comment to D5792: uncommit: added interactive mode(issue6062).

Patch still fails to apply. Would you please rebase it as requested?

Sun, Feb 17, 1:20 PM

Fri, Feb 15

durin42 accepted D5959: templates: adding a config() function for template customization.

I like this, but can see it being vaguely controversial so I'll only give it a +1 here for now - if I don't see objections in a few days I'll go ahead and land it.

Fri, Feb 15, 11:03 PM
durin42 added a comment to D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output.

Huh. That's strictly a bug, as debugwaitonrepack should actually be waiting.

Fri, Feb 15, 11:02 PM
durin42 added inline comments to D5966: test: stabilize test-run-tests.t output.
Fri, Feb 15, 10:58 PM
durin42 requested changes to D5792: uncommit: added interactive mode(issue6062).

I'd fix this one style nit in flight (this actually looks good), but it no longer applies - could you rebase it for me?

Fri, Feb 15, 10:56 PM

Mon, Feb 11

durin42 resigned from D1937: p4fastimport: import purged files as empty files.

This is on Facebook's extensions repository, which I don't own. At this point, it probably makes sense to move p4fastimport to its own repository and maintain it there.

Mon, Feb 11, 1:00 PM
durin42 committed rHG91701785c2c5: merge with stable.
merge with stable
Mon, Feb 11, 11:21 AM

Mon, Feb 4

durin42 closed D5835: tests: fix test-match.py on Python3.
Mon, Feb 4, 6:35 PM
durin42 committed rHG4dd07bf84608: tests: fix test-match.py on Python3.
tests: fix test-match.py on Python3
Mon, Feb 4, 6:35 PM
durin42 added a comment to D5817: attr: make some docstrings raw strings.

This is vendored code. Can you send it upstream?

Mon, Feb 4, 6:25 PM
durin42 created D5835: tests: fix test-match.py on Python3.
Mon, Feb 4, 5:06 PM
durin42 committed rHG888e8b36b8d9: py3: record several more passes from the buildbot ratchet.
py3: record several more passes from the buildbot ratchet
Mon, Feb 4, 4:55 PM
durin42 committed rHG11c076786d56: histedit: add templating support to histedit's rule file generation.
histedit: add templating support to histedit's rule file generation
Mon, Feb 4, 4:55 PM
durin42 committed rHG2f7408b7d247: tests: give up and make setsockopt() calls optional in the output.
tests: give up and make setsockopt() calls optional in the output
Mon, Feb 4, 4:55 PM
durin42 committed rHG13dad5cb4b99: py3: fix test-remotefilelog-repack.t.
py3: fix test-remotefilelog-repack.t
Mon, Feb 4, 4:55 PM
durin42 committed rHG8c13f7b0ace6: tests: alter email `From` line to a value that's consistently parsed.
tests: alter email `From` line to a value that's consistently parsed
Mon, Feb 4, 4:55 PM
durin42 committed rHGfa7d4e6a0c98: subrepo: clean up lingering bytes/str issues in svn support.
subrepo: clean up lingering bytes/str issues in svn support
Mon, Feb 4, 4:55 PM
durin42 committed rHG46ab0c6b28dc: subrepo: bytes/str cleanups on Git support.
subrepo: bytes/str cleanups on Git support
Mon, Feb 4, 4:54 PM
durin42 committed rHGeb6700e6c5ea: tests: make and use a new `svnurlof.py` helper for constructing svn urls.
tests: make and use a new `svnurlof.py` helper for constructing svn urls
Mon, Feb 4, 4:54 PM
durin42 committed rHG8e0dd36f7a97: git: a little pycompat.bytestring() love to make this code work in py3.
git: a little pycompat.bytestring() love to make this code work in py3
Mon, Feb 4, 4:54 PM
durin42 committed rHG6bbb12cba5a8: server: skip logging of ECONNRESET.
server: skip logging of ECONNRESET
Mon, Feb 4, 4:54 PM
durin42 committed rHGfd2f1f0071b9: py3: fix up test-remotefilelog-cacheprocess.t to not depend on a repr.
py3: fix up test-remotefilelog-cacheprocess.t to not depend on a repr
Mon, Feb 4, 4:54 PM
durin42 committed rHG4caf56c33009: py3: have test-revset2.t write test scripts in a more portable way.
py3: have test-revset2.t write test scripts in a more portable way
Mon, Feb 4, 4:54 PM
durin42 added a comment to D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
In D5744#85051, @yuja wrote:

I agree with that we would never set the commands.commit.interactive.{...}
in hgrc, but the feature itself is useful if you have to work on unclean
codebase unlike in Google. For example, I sometimes need to commit changes
ignoring unrelated whitespace cleanups made by editor or code formatter,
because I can't control the development workflow.

That's why I thought there would be users relying on the current behavior.

I think I understand what you're saying. I was under the impression that what we cared about was that hg record -b should continue working. Since there are no diffopts available on hg commit -i, you're thinking that this could be written as hg commit -i --config commands.commit.interactive.ignorews=1.

While I'm sympathetic to that argument, it is so long and unwieldy that I think I'd recommend that users just do hg --config extensions.record= record -b (or, more likely, set [extensions] record= in their hgrc).

I'll send the other patch series, we can discuss this on the relevant patches instead of keeping most of the discussion in a (somewhat unrelated) patch. I've sent D5832-D5834 with the config option approach, and still have D5877-D5878 as the "only respect commandline args" approach.

Mon, Feb 4, 4:54 PM

Fri, Feb 1

durin42 committed rHG116dba99876b: py3: record several more passes from the buildbot ratchet.
py3: record several more passes from the buildbot ratchet
Fri, Feb 1, 11:16 PM
durin42 closed D5799: py3: record several more passes from the buildbot ratchet.
Fri, Feb 1, 11:16 PM
durin42 committed rHG8d0c14d3420f: histedit: add templating support to histedit's rule file generation.
histedit: add templating support to histedit's rule file generation
Fri, Feb 1, 10:53 PM
durin42 committed rHG3ab5593f9636: tests: give up and make setsockopt() calls optional in the output.
tests: give up and make setsockopt() calls optional in the output
Fri, Feb 1, 10:53 PM
durin42 committed rHG6b10c51b1b71: tests: alter email `From` line to a value that's consistently parsed.
tests: alter email `From` line to a value that's consistently parsed
Fri, Feb 1, 10:53 PM
durin42 committed rHGa09f90cb2543: py3: fix test-remotefilelog-repack.t.
py3: fix test-remotefilelog-repack.t
Fri, Feb 1, 10:53 PM
durin42 committed rHGcbdc4b3d76d3: subrepo: clean up lingering bytes/str issues in svn support.
subrepo: clean up lingering bytes/str issues in svn support
Fri, Feb 1, 10:53 PM
durin42 committed rHG2b11fb23a1fe: histedit: add templating support to histedit's rule file generation.
histedit: add templating support to histedit's rule file generation
Fri, Feb 1, 10:48 PM
durin42 closed D5742: histedit: add templating support to histedit's rule file generation.
Fri, Feb 1, 8:50 PM
durin42 committed rHG43a40d6fd56c: histedit: add templating support to histedit's rule file generation.
histedit: add templating support to histedit's rule file generation
Fri, Feb 1, 8:50 PM
durin42 created D5799: py3: record several more passes from the buildbot ratchet.
Fri, Feb 1, 8:21 PM
durin42 closed D5762: tests: give up and make setsockopt() calls optional in the output.
Fri, Feb 1, 3:55 PM
durin42 committed rHG24a87f5024b7: tests: give up and make setsockopt() calls optional in the output.
tests: give up and make setsockopt() calls optional in the output
Fri, Feb 1, 3:55 PM
durin42 added a comment to D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
In D5744#84938, @yuja wrote:

I did not add this to revert --interactive, since that does not currently have any way of getting args specified on the commandline that affect the whitespace settings (so I'm keeping revert --interactive *ignoring* the user's diff settings).

Well, hg revert --interactive does respect the user's diff settings. I don't
know why, but f37a69ec3f47 explicitly added whitespace=True.

If I had to guess, I think that was just a copy/paste from commit --interactive without realizing the consequences;

Fri, Feb 1, 2:24 PM
durin42 committed rHG8b2892d5a9f2: Added signature for changeset 83377b4b4ae0.
Added signature for changeset 83377b4b4ae0
Fri, Feb 1, 1:54 PM
durin42 committed rHG5a4d2ab7b55c: Added tag 4.9 for changeset 83377b4b4ae0.
Added tag 4.9 for changeset 83377b4b4ae0
Fri, Feb 1, 1:54 PM
durin42 closed D5769: tests: alter email `From` line to a value that's consistently parsed.
Fri, Feb 1, 1:30 PM
durin42 committed rHGac14362ced4b: py3: fix test-remotefilelog-repack.t.
py3: fix test-remotefilelog-repack.t
Fri, Feb 1, 1:30 PM
durin42 committed rHG56404e03f57e: tests: alter email `From` line to a value that's consistently parsed.
tests: alter email `From` line to a value that's consistently parsed
Fri, Feb 1, 1:30 PM
durin42 closed D5781: py3: fix test-remotefilelog-repack.t.
Fri, Feb 1, 1:30 PM

Thu, Jan 31

durin42 closed D5774: subrepo: clean up lingering bytes/str issues in svn support.
Thu, Jan 31, 4:32 PM
durin42 committed rHGfe2c826533a7: subrepo: clean up lingering bytes/str issues in svn support.
subrepo: clean up lingering bytes/str issues in svn support
Thu, Jan 31, 4:32 PM
durin42 added a comment to D5749: hgweb: log error before attempting I/O.

@durin42 and I were both able to produce intermittent failures with this change. Why, I'm not sure.

Does the Windows regression occur with this patch or with D5751? I ask because the behavior of socket.shutdown() is documented to vary by platform. I wouldn't at all be surprised if D5751 caused the regression seen here.

It was this patch.

Like I said, I’ve seen connection resets in the non-daemonized serve output (don’t recall if it was push, pull, or both). I thought it was weird, but there were no other signs of problems, so I wrote it off as some odd Windows thing. (Not sure that I’ve seen it on Linux or OS X too)

Thu, Jan 31, 1:12 PM
durin42 abandoned D5778: svnurlof: fix check-code errors I introduced.
Thu, Jan 31, 12:53 PM
durin42 requested changes to D5780: tags: avoid generating commit for an already deleted tag (issue5752).
Thu, Jan 31, 11:27 AM
durin42 created D5781: py3: fix test-remotefilelog-repack.t.
Thu, Jan 31, 11:20 AM
durin42 committed rHG1f0a176e41de: subrepo: bytes/str cleanups on Git support.
subrepo: bytes/str cleanups on Git support
Thu, Jan 31, 8:03 AM
durin42 committed rHGd6b76d62879a: tests: make and use a new `svnurlof.py` helper for constructing svn urls.
tests: make and use a new `svnurlof.py` helper for constructing svn urls
Thu, Jan 31, 8:03 AM

Wed, Jan 30

durin42 created D5778: svnurlof: fix check-code errors I introduced.
Wed, Jan 30, 8:56 PM
durin42 updated the diff for D5774: subrepo: clean up lingering bytes/str issues in svn support.
Wed, Jan 30, 8:39 PM
durin42 updated the diff for D5769: tests: alter email `From` line to a value that's consistently parsed.
Wed, Jan 30, 8:33 PM
durin42 created D5774: subrepo: clean up lingering bytes/str issues in svn support.
Wed, Jan 30, 8:33 PM
durin42 added a dependent revision for D5762: tests: give up and make setsockopt() calls optional in the output: D5774: subrepo: clean up lingering bytes/str issues in svn support.
Wed, Jan 30, 8:33 PM
durin42 committed rHGd4df6897e461: subrepo: bytes/str cleanups on Git support.
subrepo: bytes/str cleanups on Git support
Wed, Jan 30, 8:32 PM
durin42 closed D5768: subrepo: bytes/str cleanups on Git support.
Wed, Jan 30, 8:12 PM
durin42 closed D5767: subrepo: clean up lingering bytes/str issues in svn support.
Wed, Jan 30, 8:12 PM
durin42 committed rHG8b6a9ae832f1: subrepo: bytes/str cleanups on Git support.
subrepo: bytes/str cleanups on Git support
Wed, Jan 30, 8:12 PM
durin42 committed rHG0a322005f8a0: subrepo: clean up lingering bytes/str issues in svn support.
subrepo: clean up lingering bytes/str issues in svn support
Wed, Jan 30, 8:12 PM
durin42 updated the diff for D5768: subrepo: bytes/str cleanups on Git support.
Wed, Jan 30, 8:09 PM
durin42 updated the diff for D5769: tests: alter email `From` line to a value that's consistently parsed.
Wed, Jan 30, 8:09 PM
durin42 updated the diff for D5767: subrepo: clean up lingering bytes/str issues in svn support.
Wed, Jan 30, 8:09 PM
durin42 updated the diff for D5769: tests: alter email `From` line to a value that's consistently parsed.
Wed, Jan 30, 8:07 PM
durin42 planned changes to D5769: tests: alter email `From` line to a value that's consistently parsed.

Oops. I'll be back to this.

Wed, Jan 30, 7:48 PM
durin42 created D5769: tests: alter email `From` line to a value that's consistently parsed.
Wed, Jan 30, 7:44 PM
durin42 created D5768: subrepo: bytes/str cleanups on Git support.
Wed, Jan 30, 7:31 PM
durin42 created D5767: subrepo: clean up lingering bytes/str issues in svn support.
Wed, Jan 30, 7:30 PM
durin42 closed D5766: tests: make and use a new `svnurlof.py` helper for constructing svn urls.
Wed, Jan 30, 7:13 PM
durin42 committed rHG41bd254b6de4: tests: make and use a new `svnurlof.py` helper for constructing svn urls.
tests: make and use a new `svnurlof.py` helper for constructing svn urls
Wed, Jan 30, 7:13 PM
durin42 closed D5764: server: skip logging of ECONNRESET.
Wed, Jan 30, 7:12 PM
durin42 committed rHG39bac0bdcddf: server: skip logging of ECONNRESET.
server: skip logging of ECONNRESET
Wed, Jan 30, 7:11 PM
durin42 closed D5765: git: a little pycompat.bytestring() love to make this code work in py3.
Wed, Jan 30, 7:11 PM
durin42 committed rHG1c8943653458: git: a little pycompat.bytestring() love to make this code work in py3.
git: a little pycompat.bytestring() love to make this code work in py3
Wed, Jan 30, 7:11 PM
durin42 created D5766: tests: make and use a new `svnurlof.py` helper for constructing svn urls.
Wed, Jan 30, 6:54 PM
durin42 created D5765: git: a little pycompat.bytestring() love to make this code work in py3.
Wed, Jan 30, 6:32 PM
durin42 created D5764: server: skip logging of ECONNRESET.
Wed, Jan 30, 6:09 PM
durin42 closed D5763: py3: have test-revset2.t write test scripts in a more portable way.
Wed, Jan 30, 5:34 PM
durin42 closed D5761: py3: fix up test-remotefilelog-cacheprocess.t to not depend on a repr.
Wed, Jan 30, 5:34 PM
durin42 committed rHG1258db86e990: py3: have test-revset2.t write test scripts in a more portable way.
py3: have test-revset2.t write test scripts in a more portable way
Wed, Jan 30, 5:34 PM
durin42 committed rHGee51cde26714: py3: fix up test-remotefilelog-cacheprocess.t to not depend on a repr.
py3: fix up test-remotefilelog-cacheprocess.t to not depend on a repr
Wed, Jan 30, 5:34 PM
durin42 created D5763: py3: have test-revset2.t write test scripts in a more portable way.
Wed, Jan 30, 5:17 PM
durin42 abandoned D5690: py3: use regular expression to deal with ENOENT formatting change.
Wed, Jan 30, 5:16 PM
durin42 created D5762: tests: give up and make setsockopt() calls optional in the output.
Wed, Jan 30, 5:05 PM
durin42 created D5761: py3: fix up test-remotefilelog-cacheprocess.t to not depend on a repr.
Wed, Jan 30, 4:44 PM
durin42 added inline comments to D5751: tests: change how sockets are closed.
Wed, Jan 30, 4:07 PM
durin42 updated the diff for D5742: histedit: add templating support to histedit's rule file generation.
Wed, Jan 30, 8:19 AM

Tue, Jan 29

durin42 updated the diff for D5742: histedit: add templating support to histedit's rule file generation.
Tue, Jan 29, 7:53 PM
durin42 created D5742: histedit: add templating support to histedit's rule file generation.
Tue, Jan 29, 7:26 PM
durin42 closed D5736: tests: port test-hgweb-auth.py to Python 3.
Tue, Jan 29, 4:48 PM
durin42 committed rHG30dd20a56f3e: tests: port test-hgweb-auth.py to Python 3.
tests: port test-hgweb-auth.py to Python 3
Tue, Jan 29, 4:48 PM
durin42 closed D5735: url: convert some variables back to bytes.
Tue, Jan 29, 4:48 PM
durin42 committed rHGd437d1e2a711: url: convert some variables back to bytes.
url: convert some variables back to bytes
Tue, Jan 29, 4:48 PM
durin42 committed rHGbc776c31c093: url: add some defensive asserts on expected incoming types.
url: add some defensive asserts on expected incoming types
Tue, Jan 29, 4:48 PM
durin42 closed D5734: url: add some defensive asserts on expected incoming types.
Tue, Jan 29, 4:48 PM
durin42 added a comment to D5088: hghave: add pyXY features for Python version numbers.

I still don't love this, but I'm landing it to make forward progress on 3.7. :/

Tue, Jan 29, 3:13 PM
durin42 created D5736: tests: port test-hgweb-auth.py to Python 3.
Tue, Jan 29, 3:12 PM