Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (214 w, 5 d)

Recent Activity

Fri, Jul 30

durin42 closed D11232: rewriteutil: fix crash when a rewritten message references f{6,64}.
Fri, Jul 30, 2:11 PM
durin42 closed D11231: tests: add explicit coverage for update_hash_refs from rewriteutil.
Fri, Jul 30, 2:11 PM
durin42 committed rHG48da5c325750: rewriteutil: fix crash when a rewritten message references f{6,64}.
rewriteutil: fix crash when a rewritten message references f{6,64}
Fri, Jul 30, 2:11 PM
durin42 committed rHG324c8a299324: tests: add explicit coverage for update_hash_refs from rewriteutil.
tests: add explicit coverage for update_hash_refs from rewriteutil
Fri, Jul 30, 2:11 PM
durin42 added inline comments to D11232: rewriteutil: fix crash when a rewritten message references f{6,64}.
Fri, Jul 30, 11:02 AM

Thu, Jul 29

durin42 closed D11233: dirstate: fix typo in docstring.
Thu, Jul 29, 11:31 PM
durin42 committed rHG0bdcb5ef932c: git: restore basic functionality (issue6545).
git: restore basic functionality (issue6545)
Thu, Jul 29, 11:31 PM
durin42 closed D11234: git: restore basic functionality (issue6545).
Thu, Jul 29, 11:31 PM
durin42 committed rHG03089463c554: dirstate: fix typo in docstring.
dirstate: fix typo in docstring
Thu, Jul 29, 11:31 PM
durin42 created D11233: dirstate: fix typo in docstring.
Thu, Jul 29, 5:05 PM
durin42 created D11234: git: restore basic functionality (issue6545).
Thu, Jul 29, 5:05 PM
durin42 created D11232: rewriteutil: fix crash when a rewritten message references f{6,64}.
Thu, Jul 29, 4:40 PM
durin42 created D11231: tests: add explicit coverage for update_hash_refs from rewriteutil.
Thu, Jul 29, 4:39 PM

Sun, Jul 18

durin42 closed D11092: pyoxidizer: add hooks to inject extra python packages and install files.
Sun, Jul 18, 6:05 AM
durin42 closed D11093: packaging: add command line flag to add extra vars to pyoxidizer.
Sun, Jul 18, 6:05 AM
durin42 committed rHGbe37bb8d0c7c: packaging: add command line flag to add extra vars to pyoxidizer.
packaging: add command line flag to add extra vars to pyoxidizer
Sun, Jul 18, 6:05 AM
durin42 committed rHG11f834e7177d: pyoxidizer: add hooks to inject extra python packages and install files.
pyoxidizer: add hooks to inject extra python packages and install files
Sun, Jul 18, 6:05 AM

Wed, Jul 14

durin42 created D11093: packaging: add command line flag to add extra vars to pyoxidizer.
Wed, Jul 14, 3:26 PM
durin42 created D11092: pyoxidizer: add hooks to inject extra python packages and install files.
Wed, Jul 14, 3:26 PM

Fri, Jul 9

durin42 closed D11030: parsers: move DirstateItem to attr.s.
Fri, Jul 9, 12:31 PM
durin42 committed rHG3df817387ea3: parsers: move DirstateItem to attr.s.
parsers: move DirstateItem to attr.s
Fri, Jul 9, 12:31 PM
durin42 updated the diff for D11030: parsers: move DirstateItem to attr.s.
Fri, Jul 9, 10:51 AM

Thu, Jul 8

durin42 added a comment to D10949: dirstate-entry: turn dirstate tuple into a real object (like in C).

FYI: I did the followup as D11030 because I found myself with a few minutes.

Thu, Jul 8, 5:24 PM
durin42 updated the summary of D11030: parsers: move DirstateItem to attr.s.
Thu, Jul 8, 5:24 PM
durin42 created D11030: parsers: move DirstateItem to attr.s.
Thu, Jul 8, 5:23 PM
durin42 added a comment to D10949: dirstate-entry: turn dirstate tuple into a real object (like in C).

Could this be an attr.s instead of a bespoke class with slots?

Thu, Jul 8, 4:38 PM
durin42 committed rHGb7a706e7843a: shallowutil: dedent code after the previous change.
shallowutil: dedent code after the previous change
Thu, Jul 8, 7:53 AM
durin42 committed rHGdb31bafa4ae3: shallowutil: narrow scope of try/except block.
shallowutil: narrow scope of try/except block
Thu, Jul 8, 7:53 AM
durin42 committed rHGe972077600e5: remotefilelog: stop using RuntimeError for control flow.
remotefilelog: stop using RuntimeError for control flow
Thu, Jul 8, 7:53 AM
durin42 closed D11006: remotefilelog: stop using RuntimeError for control flow.
Thu, Jul 8, 5:02 AM
durin42 closed D11008: shallowutil: dedent code after the previous change.
Thu, Jul 8, 5:02 AM
durin42 committed rHGe2888ebbb63c: shallowutil: dedent code after the previous change.
shallowutil: dedent code after the previous change
Thu, Jul 8, 5:02 AM
durin42 committed rHGc0830cbfe674: shallowutil: narrow scope of try/except block.
shallowutil: narrow scope of try/except block
Thu, Jul 8, 5:02 AM
durin42 closed D11007: shallowutil: narrow scope of try/except block.
Thu, Jul 8, 5:02 AM
durin42 closed D11005: remotefilelog: tweak corrupt cache test to grep more flexibly.
Thu, Jul 8, 5:02 AM
durin42 committed rHGe68a15c304c2: remotefilelog: stop using RuntimeError for control flow.
remotefilelog: stop using RuntimeError for control flow
Thu, Jul 8, 5:02 AM
durin42 committed rHG5830539c46be: remotefilelog: tweak corrupt cache test to grep more flexibly.
remotefilelog: tweak corrupt cache test to grep more flexibly
Thu, Jul 8, 5:02 AM

Wed, Jul 7

durin42 created D11006: remotefilelog: stop using RuntimeError for control flow.
Wed, Jul 7, 2:12 PM
durin42 created D11008: shallowutil: dedent code after the previous change.
Wed, Jul 7, 2:12 PM
durin42 created D11007: shallowutil: narrow scope of try/except block.
Wed, Jul 7, 2:12 PM
durin42 created D11005: remotefilelog: tweak corrupt cache test to grep more flexibly.
Wed, Jul 7, 2:12 PM

Jun 7 2021

durin42 committed rHG8a6e6b62b9a3: merge: with stable.
merge: with stable
Jun 7 2021, 5:15 PM

Jun 1 2021

durin42 added a comment to D10770: docket: make compatible with py3.6, where Struct.format is bytes.

Looks like this is happening because of an inconsistency betwen the fact we passe a binary 'struct' for INDEX_HEADER and a sysstr for the extra once. I would rather fix this by making them consistent.

I'm not sure I understand. Can you show me how?

$ python3.6 -c 'import struct; print(type(struct.Struct(b"I").format))'
<class 'bytes'>
$ python3.6 -c 'import struct; print(type(struct.Struct("I").format))'
<class 'bytes'>
$ python3.7 -c 'import struct; print(type(struct.Struct(b"I").format))'
<class 'str'>
$ python3.7 -c 'import struct; print(type(struct.Struct("I").format))'
<class 'str'>

Okay, so my assertion is correct and Python behavior is… creative. Maybe we should build a pycompat wrapper for struct.format access ?

AFAICT your assertion was wrong: the struct module just isn't preserving the input type at all, and always emits str on 3.7+, but does bytes on 3.6. So we're not mixing bytes/str input types to struct, but instead struct on 3.6 is ninja-converting back to bytes "for" us.

Yep, this is a typo on my side (typing is hard) (is right because isn't right)

A pycompat wrapper would make sense for this if we see more than one case of this. Is that likely?

It feels wrong to me to have this kind of compatibility weirdness crawl into normal code. I though more about it and in this case I think the simplest would probably to have the format for INDEX_HEADER in a INDEX_HEADER _FMT constant and concatenate with that.

Jun 1 2021, 11:24 AM
durin42 added a comment to D10770: docket: make compatible with py3.6, where Struct.format is bytes.

Looks like this is happening because of an inconsistency betwen the fact we passe a binary 'struct' for INDEX_HEADER and a sysstr for the extra once. I would rather fix this by making them consistent.

I'm not sure I understand. Can you show me how?

$ python3.6 -c 'import struct; print(type(struct.Struct(b"I").format))'
<class 'bytes'>
$ python3.6 -c 'import struct; print(type(struct.Struct("I").format))'
<class 'bytes'>
$ python3.7 -c 'import struct; print(type(struct.Struct(b"I").format))'
<class 'str'>
$ python3.7 -c 'import struct; print(type(struct.Struct("I").format))'
<class 'str'>

Okay, so my assertion is correct and Python behavior is… creative. Maybe we should build a pycompat wrapper for struct.format access ?

Jun 1 2021, 10:01 AM

May 31 2021

durin42 committed rHG43f6a7bb4e12: fuzz: add hg to sys.path when constructing mpatch corpus.
fuzz: add hg to sys.path when constructing mpatch corpus
May 31 2021, 4:07 AM
durin42 closed D10777: fuzz: add hg to sys.path when constructing mpatch corpus.
May 31 2021, 4:07 AM

May 27 2021

durin42 added a comment to D10538: tests: allow trunk versions of clang-format to be used.

I think that the worst that can happen with this change is:
a. clang-format makes a backwards-incompatible change

May 27 2021, 5:17 PM
durin42 created D10777: fuzz: add hg to sys.path when constructing mpatch corpus.
May 27 2021, 12:11 PM

May 20 2021

durin42 closed D10733: hghave: make error output easier to diagnose.
May 20 2021, 9:23 AM
durin42 committed rHG338623a2ebf2: hghave: make error output easier to diagnose.
hghave: make error output easier to diagnose
May 20 2021, 9:23 AM
durin42 committed rHG97f04eaafa65: tests: add req on bash for test-transaction-rollback-on-sigpipe (issue6429).
tests: add req on bash for test-transaction-rollback-on-sigpipe (issue6429)
May 20 2021, 9:23 AM
durin42 closed D10732: tests: add req on bash for test-transaction-rollback-on-sigpipe (issue6429).
May 20 2021, 9:23 AM

May 19 2021

durin42 added a comment to D10692: run-tests: ignore PermissionError when checking available ports.

This looks good to me too, but needs rebased.

May 19 2021, 1:39 PM

May 18 2021

durin42 created D10732: tests: add req on bash for test-transaction-rollback-on-sigpipe (issue6429).
May 18 2021, 1:55 PM
durin42 created D10733: hghave: make error output easier to diagnose.
May 18 2021, 1:55 PM

May 12 2021

durin42 updated subscribers of D6594: [ABANDONED] RFC dirstatemap.

(+ infra list, some folks that I think volunteered in the past)

May 12 2021, 3:09 PM

May 6 2021

D10513: convert-bazaar: use breezy package instead of old bzr one now requires changes to proceed.

I'm getting conflicts in the hghave part, but otherwise LGTM

May 6 2021, 3:17 PM
durin42 added a comment to D10673: remotefilelog: use the correct capability when using getfilestype threaded.

Wait, I'm dumb. I just marked this as superceded by itself?

May 6 2021, 1:06 PM
durin42 abandoned D10673: remotefilelog: use the correct capability when using getfilestype threaded.
May 6 2021, 1:06 PM
durin42 added a reviewer for D10673: remotefilelog: use the correct capability when using getfilestype threaded: klevesque.

superceded by D10673

May 6 2021, 1:06 PM
durin42 closed D10669: debugcommands: fix some plural-agreements I noticed.
May 6 2021, 12:58 AM
durin42 committed rHGbd2ed1032b4e: debugcommands: fix some plural-agreements I noticed.
debugcommands: fix some plural-agreements I noticed
May 6 2021, 12:57 AM

May 5 2021

durin42 added a comment to D10672: remotefilelog: use the correct capability when using getfilestype threaded.

This looks good, but we need an email address in the username - can you add one and re-upload the change?

May 5 2021, 6:21 PM

May 4 2021

durin42 created D10669: debugcommands: fix some plural-agreements I noticed.
May 4 2021, 1:29 PM

May 3 2021

durin42 committed rHGfde5bb5d1acf: merge: with stable.
merge: with stable
May 3 2021, 3:15 PM

Apr 28 2021

durin42 committed rHG3c8e4c6ec9bc: merge: stable heads.
merge: stable heads
Apr 28 2021, 11:09 AM
durin42 committed rHG41f8f38d8377: Added signature for changeset 8d2b62d716b0.
Added signature for changeset 8d2b62d716b0
Apr 28 2021, 11:08 AM
durin42 committed rHG8fc2c867af54: Added tag 5.8rc1 for changeset 8d2b62d716b0.
Added tag 5.8rc1 for changeset 8d2b62d716b0
Apr 28 2021, 11:08 AM

Apr 20 2021

durin42 committed rHG01264552a1dc: Added signature for changeset f67b8946bb1b.
Added signature for changeset f67b8946bb1b
Apr 20 2021, 11:17 AM
durin42 committed rHGf67b8946bb1b: merge: default into stable for 5.8 rc.
merge: default into stable for 5.8 rc
Apr 20 2021, 11:17 AM
durin42 committed rHGe846261413d0: Added tag 5.8rc0 for changeset f67b8946bb1b.
Added tag 5.8rc0 for changeset f67b8946bb1b
Apr 20 2021, 11:17 AM

Apr 12 2021

D10357: Add narrow capabilities for local repos, not just remote peers is now accepted and ready to land.

Thanks! This needed some tweaking on the commit message to line up with our format (which is checked by the test suite, but I've edited in-flight and am pushing now.)

Apr 12 2021, 2:51 PM

Apr 2 2021

durin42 added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

It looks superficially correct - I didn't give it a detailed
inspection, but I trust you and Valentin on this.

Apr 2 2021, 1:21 AM

Mar 30 2021

D9465: node: replace nullid and friends with nodeconstants class now requires changes to proceed.

Fails tests, eg:

--- tests/test-push-checkheads-unpushed-D7.t
+++ tests/test-push-checkheads-unpushed-D7.t.err
@@ -65,27 +65,16 @@
   $ mkcommit C0
   created new head
   $ hg debugobsolete `getid "desc(A0)"` `getid "desc(A1)"`
-  1 new obsolescence markers
-  obsoleted 1 changesets
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
   $ hg debugobsolete `getid "desc(A1)"` `getid "desc(A2)"`
-  1 new obsolescence markers
-  obsoleted 1 changesets
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
   $ hg debugobsolete --record-parents `getid "desc(A2)"`
-  1 new obsolescence markers
-  obsoleted 1 changesets
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
   $ hg log -G --hidden
-  @  0f88766e02d6 (draft): C0
-  |
-  | x  c1f8d089020f (draft): A2
-  |/
-  | x  ba93660aff8d (draft): A1
-  | |
-  | o  74ff5441d343 (draft): B0
-  |/
-  | x  8aaa48160adc (draft): A0
-  |/
-  o  1e4be0697311 (public): root
-
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
+  [255]
Mar 30 2021, 4:22 PM

Mar 29 2021

durin42 added a comment to D10288: simplemerge: simplify.

I hate to be That Guy but can you replace "simplify" in all these with some boilerplate about "compare revs and not ids because $REASON"? otherwise some enthusiastic architecture astronaut (probably me) is going to come back in the not-too-distant future and make it more generic and phrase things in terms of nodes rather than IDs.

Mar 29 2021, 3:32 PM
durin42 added a comment to D10283: copies: simplify.

So, I've gone through several of these now, and I realize: why are we moving towards revs and away from nodes? That's the opposite of the refactor I'd expect...

Mar 29 2021, 3:29 PM

Mar 25 2021

durin42 added a comment to D10265: path: error out if the `path://` reference point to an unknown path.

Landing this chain, but it'd be good to see some documentation for it show up soon.

Mar 25 2021, 5:12 PM

Mar 17 2021

D10149: commit: get info from mergestate whether a file was merged or not now requires changes to proceed.

Needs rebased.

Mar 17 2021, 1:44 PM
durin42 closed D10185: black: merge config into main pyproject.toml now that we have it.
Mar 17 2021, 10:42 AM
durin42 closed D10184: pyproject: add config file.
Mar 17 2021, 10:42 AM
durin42 committed rHGdecc3bd3f20d: black: merge config into main pyproject.toml now that we have it.
black: merge config into main pyproject.toml now that we have it
Mar 17 2021, 10:42 AM
durin42 committed rHGd13afdd1f6e2: pyproject: add config file.
pyproject: add config file
Mar 17 2021, 10:42 AM

Mar 16 2021

D9750: node: introduce nodeconstants class now requires changes to proceed.

Fair enough. This is ready, but needs rebased.

Mar 16 2021, 5:52 PM
D10160: push: indent the some part of the command now requires changes to proceed.

I'm sorry to report this needs rebased

Mar 16 2021, 5:50 PM

Mar 12 2021

durin42 created D10185: black: merge config into main pyproject.toml now that we have it.
Mar 12 2021, 1:20 PM
durin42 created D10184: pyproject: add config file.
Mar 12 2021, 1:20 PM
durin42 committed rHG6f4a481f182a: merge: with stable.
merge: with stable
Mar 12 2021, 1:18 PM

Feb 27 2021

durin42 committed rHG25b1610f8534: fuzz: if the caller of our makefile sets CC and CXX, trust them.
fuzz: if the caller of our makefile sets CC and CXX, trust them
Feb 27 2021, 1:31 PM
durin42 closed D10066: fuzz: if the caller of our makefile sets CC and CXX, trust them.
Feb 27 2021, 1:31 PM

Feb 24 2021

durin42 created D10066: fuzz: if the caller of our makefile sets CC and CXX, trust them.
Feb 24 2021, 12:41 PM
D9843: revlog: introduce v2 format now requires changes to proceed.

(marking as request changes in that case)

Feb 24 2021, 11:21 AM
durin42 added inline comments to D9843: revlog: introduce v2 format.
Feb 24 2021, 11:17 AM
durin42 added a comment to D9950: ci: test real dependency installation for pip.

I suspect this test works without network if setuptools is already installed, but I don't care enough to block it on that pedantry.

Feb 24 2021, 11:04 AM
durin42 added a comment to D10020: debian: support a "chg-first" installation mechanism (hg is actually chg).

AFAICT this should be fine, but I'll give Yuya a while to catch problems.

Feb 24 2021, 11:01 AM

Feb 11 2021

durin42 added a comment to D9918: config: test priority involving alias.

I'm still confused here.

Feb 11 2021, 11:57 AM
D9918: config: test priority involving alias now requires changes to proceed.

This still requires changes to resolve my comments.

Feb 11 2021, 11:25 AM
D9982: hooks: add a `auto` value for `hooks.*run-with-plain` is now accepted and ready to land.

I'm not happy about this footgun option, but see why we need it.

Feb 11 2021, 11:08 AM

Feb 2 2021

durin42 committed rHGd6e73351533b: branching: merge with stable.
branching: merge with stable
Feb 2 2021, 1:33 PM
D9918: config: test priority involving alias now requires changes to proceed.
Feb 2 2021, 11:50 AM

Feb 1 2021

durin42 committed rHG6b847757dd8d: relnotes: add entry for `hg diff --merge -c`.
relnotes: add entry for `hg diff --merge -c`
Feb 1 2021, 5:52 PM