Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (112 w, 1 d)

Recent Activity

Yesterday

durin42 closed D6733: setup: fix a sorting issue I noticed in package names.
Sat, Aug 17, 5:05 PM
durin42 committed rHGf299555785c5: setup: fix a sorting issue I noticed in package names.
setup: fix a sorting issue I noticed in package names
Sat, Aug 17, 5:05 PM
durin42 committed rHG791791a1fd4e: tests: split joint repo/changelog fake into one for each type.
tests: split joint repo/changelog fake into one for each type
Sat, Aug 17, 2:50 AM

Fri, Aug 16

durin42 created D6734: git: RFC of a new extension to _directly_ operate on git repositories.
Fri, Aug 16, 4:54 PM
durin42 created D6732: localrepo: push manifestlog and changelog construction code into store.
Fri, Aug 16, 4:54 PM
durin42 created D6733: setup: fix a sorting issue I noticed in package names.
Fri, Aug 16, 4:54 PM
durin42 committed rHG302dbc9d52be: tests: use `tr -d` and not `tr --delete` as the latter is absent on BSD tr(1).
tests: use `tr -d` and not `tr --delete` as the latter is absent on BSD tr(1)
Fri, Aug 16, 8:44 AM
durin42 closed D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
Fri, Aug 16, 5:47 AM
durin42 committed rHG55f59a25c593: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1)
Fri, Aug 16, 5:47 AM

Thu, Aug 15

durin42 created D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
Thu, Aug 15, 11:23 AM
durin42 added a comment to D6709: config: add --registered flag to show all known configs.

Looks good to me, but I want someone else to put eyes on it before it gets pushed.

Thu, Aug 15, 11:13 AM
durin42 committed rHG034b2bf377f0: tests: split joint repo/changelog fake into one for each type.
tests: split joint repo/changelog fake into one for each type
Thu, Aug 15, 11:08 AM
durin42 closed D6725: tests: split joint repo/changelog fake into one for each type.
Thu, Aug 15, 11:08 AM
durin42 added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

The only thing I'm curious about really is why we have extrastorage and usualstorge. Can we get away with only one of those choices instead of having more options?

Thu, Aug 15, 11:05 AM

Wed, Aug 14

durin42 created D6725: tests: split joint repo/changelog fake into one for each type.
Wed, Aug 14, 4:14 PM
durin42 added a comment to D6430: rust-discovery: using from Python code.

I'm not thrilled with this - it's a lot of code, and I think there are some simpler options that haven't been explored. For example, clients could use the logexchange infrastructure to prime the sampling process and do a lot better.

Wed, Aug 14, 4:12 PM
durin42 added inline comments to D6517: rust-discovery: read the index from a repo passed at init.
Wed, Aug 14, 3:27 PM
durin42 added a comment to D6718: repository: suppress typing errors on functions without arguments.

Seems fine, but probably file a bug against mypy on this.

Wed, Aug 14, 3:23 PM
durin42 added a comment to D6717: mypy: add a mypy.ini config file.

Did you run tests on this patch? IIRC there's a test that'll fail ;)

Wed, Aug 14, 3:23 PM

Fri, Aug 9

durin42 committed rHG50c2c3eae64e: merge with stable.
merge with stable
Fri, Aug 9, 5:10 AM

Wed, Aug 7

durin42 added a comment to D6712: config: remove pycompat.bytestr() for defaultvalue.

I agree with marmoute on all points.

Wed, Aug 7, 8:09 AM

Thu, Aug 1

durin42 added a comment to D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.

Queued with updated log message. Thanks!

Thu, Aug 1, 2:40 PM
durin42 added a comment to D6704: config: add defaultvalue template keyword.

I like the feature, I'll go ahead and queue it with the str/bytestr thing fixed in flight. Thanks!

Thu, Aug 1, 2:38 PM
durin42 updated the diff for D6522: tracing: add many more timedcm() calls throughout the codebase.
Thu, Aug 1, 2:37 PM
D6659: graft: split graft code into seperate functions now requires changes to proceed.

I agree with Martin's request for changes here.

Thu, Aug 1, 2:36 PM
D6694: unshelve: delete shelvedstate after a successful unshelve --continue now requires changes to proceed.

needs rebased

Thu, Aug 1, 2:32 PM
durin42 committed rHGe77be7e2109f: merge with stable.
merge with stable
Thu, Aug 1, 12:24 PM
durin42 committed rHG39b98107773a: Added signature for changeset e91930d712e8.
Added signature for changeset e91930d712e8
Thu, Aug 1, 12:24 PM
durin42 committed rHGa218850cd52c: Added tag 5.1 for changeset e91930d712e8.
Added tag 5.1 for changeset e91930d712e8
Thu, Aug 1, 12:24 PM

Fri, Jul 26

durin42 committed rHG684b56ade431: fsmonitor: add support for extra `hg debuginstall` data.
fsmonitor: add support for extra `hg debuginstall` data
Fri, Jul 26, 11:03 AM
durin42 committed rHG7f1df7019497: debugcommands: add support for extensions adding their own debug info.
debugcommands: add support for extensions adding their own debug info
Fri, Jul 26, 11:03 AM
durin42 committed rHGab1900323b1d: fsmonitor: refactor watchmanclient.client to accept ui and repo path.
fsmonitor: refactor watchmanclient.client to accept ui and repo path
Fri, Jul 26, 11:03 AM

Wed, Jul 24

durin42 closed D6681: debugcommands: add support for extensions adding their own debug info.
Wed, Jul 24, 5:33 AM
durin42 closed D6682: fsmonitor: add support for extra `hg debuginstall` data.
Wed, Jul 24, 5:33 AM
durin42 closed D6680: fsmonitor: refactor watchmanclient.client to accept ui and repo path.
Wed, Jul 24, 5:32 AM
durin42 committed rHG3358dc6e7c04: fsmonitor: add support for extra `hg debuginstall` data.
fsmonitor: add support for extra `hg debuginstall` data
Wed, Jul 24, 5:32 AM
durin42 committed rHG0c0478b71595: debugcommands: add support for extensions adding their own debug info.
debugcommands: add support for extensions adding their own debug info
Wed, Jul 24, 5:32 AM
durin42 committed rHGf3c594ddecb7: fsmonitor: refactor watchmanclient.client to accept ui and repo path.
fsmonitor: refactor watchmanclient.client to accept ui and repo path
Wed, Jul 24, 5:32 AM

Tue, Jul 23

durin42 created D6681: debugcommands: add support for extensions adding their own debug info.
Tue, Jul 23, 3:40 PM
durin42 created D6682: fsmonitor: add support for extra `hg debuginstall` data.
Tue, Jul 23, 3:40 PM
durin42 created D6680: fsmonitor: refactor watchmanclient.client to accept ui and repo path.
Tue, Jul 23, 3:40 PM

Mon, Jul 22

durin42 committed rHGe386b5f4f836: merge default into stable for 5.1 release.
merge default into stable for 5.1 release
Mon, Jul 22, 2:28 PM
durin42 committed rHGa3117aeca25b: Added signature for changeset e386b5f4f836.
Added signature for changeset e386b5f4f836
Mon, Jul 22, 2:28 PM
durin42 committed rHG29403026458a: Added tag 5.1rc0 for changeset e386b5f4f836.
Added tag 5.1rc0 for changeset e386b5f4f836
Mon, Jul 22, 2:28 PM

Sun, Jul 21

durin42 committed rHGe19353715a64: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines.
py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines
Sun, Jul 21, 8:27 PM
durin42 closed D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines.
Sun, Jul 21, 10:34 AM
durin42 committed rHGeb27d9eee2cc: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines.
py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines
Sun, Jul 21, 10:34 AM
durin42 committed rHG01a503aacc51: py3: another passing test.
py3: another passing test
Sun, Jul 21, 10:34 AM
durin42 committed rHG811e502d646d: cleanup: remove redundant import.
cleanup: remove redundant import
Sun, Jul 21, 10:34 AM

Jul 19 2019

durin42 committed rHG513a97303bbc: py3: another passing test.
py3: another passing test
Jul 19 2019, 2:30 AM
durin42 closed D6656: py3: another passing test.
Jul 19 2019, 2:30 AM
durin42 closed D6657: cleanup: remove redundant import.
Jul 19 2019, 2:30 AM
durin42 committed rHG3acb3660a626: cleanup: remove redundant import.
cleanup: remove redundant import
Jul 19 2019, 2:30 AM

Jul 18 2019

durin42 created D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines.
Jul 18 2019, 2:24 PM
durin42 created D6657: cleanup: remove redundant import.
Jul 18 2019, 2:24 PM
durin42 created D6656: py3: another passing test.
Jul 18 2019, 2:18 PM
durin42 added a comment to D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.

I still think we should fix the cwd for fixers, but it seems Martin and I agree that repo-root is more consistent. Would you be willing to reroll with repo-root instead of cwd?

Jul 18 2019, 2:12 PM
durin42 added a comment to D6655: continue: added support for graft.

I'm landing this, but in the future I suspect we should make sure we just have a mix of hg graft --continue and hg graft rather than run the whole test twice, as it'll severely bloat the already-slow testsuite to do that for many tests.

Jul 18 2019, 1:58 PM

Jul 17 2019

durin42 added a comment to D6612: tests: show the files fields of changelogs for many merges.

(Martin, this looks fine to me, if you've got no objections let's include it in 5.1)

Jul 17 2019, 6:26 PM
durin42 accepted D6613: commit: improve the files field of changelog for merges.
Jul 17 2019, 6:25 PM
D6643: convert: add a config option to help doing identity hg->hg conversion is now accepted and ready to land.
Jul 17 2019, 6:23 PM
durin42 updated subscribers of D6612: tests: show the files fields of changelogs for many merges.

I know @martinvonz has been looking at files in changelogs recently. Do you have an opinion on this? It looks fine to me.

Jul 17 2019, 6:23 PM

Jul 16 2019

durin42 added a comment to D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition.

LGTM, but needs rebased (sorry for slow response)

@durin42 I've rebased it on hg-committed, but nothing's changed. Am I missing something?

Jul 16 2019, 2:28 PM

Jul 15 2019

durin42 added a comment to D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition.

LGTM, but needs rebased (sorry for slow response)

Jul 15 2019, 2:53 PM

Jul 10 2019

durin42 added inline comments to D6611: blackbox: disable extremely verbose logging (issue6110).
Jul 10 2019, 3:38 PM
durin42 added a comment to D6573: prompt: add develwarn about last line of prompt >45 chars (issue6158).

Per your note that this will probably make other localizations sad, let's just give up on this for now?

Jul 10 2019, 3:23 PM
durin42 added a comment to D6625: rust-cargo: reorder dependencies.

Why? Before it was sorted, and now it's not.

Jul 10 2019, 3:21 PM

Jul 9 2019

durin42 committed rHGeb7bd7d64a9d: merge with stable.
merge with stable
Jul 9 2019, 10:10 AM
durin42 committed rHG740a3f39e764: Added signature for changeset 97ada9b8d51b.
Added signature for changeset 97ada9b8d51b
Jul 9 2019, 10:10 AM
durin42 committed rHG4330c4e96dab: Added tag 5.0.2 for changeset 97ada9b8d51b.
Added tag 5.0.2 for changeset 97ada9b8d51b
Jul 9 2019, 10:10 AM

Jul 8 2019

durin42 committed rHG97ada9b8d51b: posix: always seek to EOF when opening a file in append mode.
posix: always seek to EOF when opening a file in append mode
Jul 8 2019, 7:27 PM
durin42 closed D6616: extdata: avoid crashing inside subprocess when we get a revset parse error.
Jul 8 2019, 6:05 PM
durin42 committed rHGea6558db1011: extdata: avoid crashing inside subprocess when we get a revset parse error.
extdata: avoid crashing inside subprocess when we get a revset parse error
Jul 8 2019, 6:05 PM
durin42 closed D6615: extdata: demonstrate bad behavior when a subprocess emits garbage.
Jul 8 2019, 6:05 PM
durin42 committed rHGeec65b706caf: extdata: demonstrate bad behavior when a subprocess emits garbage.
extdata: demonstrate bad behavior when a subprocess emits garbage
Jul 8 2019, 6:04 PM
durin42 closed D6556: cleanup: use named constants for second arg to .seek().
Jul 8 2019, 6:03 PM
durin42 committed rHG4eaf7197a740: cleanup: use named constants for second arg to .seek().
cleanup: use named constants for second arg to .seek()
Jul 8 2019, 6:03 PM
durin42 created D6616: extdata: avoid crashing inside subprocess when we get a revset parse error.
Jul 8 2019, 2:05 PM
durin42 created D6615: extdata: demonstrate bad behavior when a subprocess emits garbage.
Jul 8 2019, 2:05 PM
durin42 updated the diff for D6556: cleanup: use named constants for second arg to .seek().
Jul 8 2019, 1:28 PM
durin42 updated the diff for D6556: cleanup: use named constants for second arg to .seek().
Jul 8 2019, 1:15 PM
durin42 abandoned D6554: cleanup: always `seek(0, io.SEEK_END)` after open in append mode before tell().
Jul 8 2019, 1:15 PM
durin42 abandoned D6555: vfs: require use of .seek() or .write() before .tell() on append-mode files.
Jul 8 2019, 1:15 PM

Jun 28 2019

durin42 added a comment to D6562: filemerge: make last line of prompts <40 english chars (issue6158).

I like this, but could I get you to add a patch 3 that introduces a develwarn for this?

Done, and it found a couple other cases, but I'm not sure I like it (D6573) - non-English users might not be able to enable the devel warnings without getting a bunch of spam. I believe by the time we get to ui.prompt() we've already done the _() translation and it's in the target language? Do we have any idea if anyone enables developer warnings outside of tests (which would typically be written in English, at least for core).
Unfortunately, I don't think it's something we could put in check-style.py either... we won't know that these are going to a prompt. Anyway, we can continue discussion on this on D6573.

Jun 28 2019, 4:08 PM

Jun 24 2019

durin42 added a comment to D6562: filemerge: make last line of prompts <40 english chars (issue6158).

I like this, but could I get you to add a patch 3 that introduces a develwarn for this?

Jun 24 2019, 2:54 PM
durin42 committed rHGebbbf25ae266: merge with stable.
merge with stable
Jun 24 2019, 2:35 PM

Jun 20 2019

durin42 added a comment to D6554: cleanup: always `seek(0, io.SEEK_END)` after open in append mode before tell().

Note that I mailed a version to the list for stable. This doesn't quite cleanly apply there, so I made the change twice so I could write the next change without waiting for a merge.

Jun 20 2019, 2:42 PM
durin42 created D6556: cleanup: use named constants for second arg to .seek().
Jun 20 2019, 2:36 PM
durin42 created D6554: cleanup: always `seek(0, io.SEEK_END)` after open in append mode before tell().
Jun 20 2019, 2:29 PM
durin42 created D6555: vfs: require use of .seek() or .write() before .tell() on append-mode files.
Jun 20 2019, 2:29 PM

Jun 19 2019

durin42 created D6550: tracing: add a couple of trace points on obsolete and repoview.
Jun 19 2019, 6:23 PM
durin42 abandoned D6549: localrepo: split lookup of context from status call.
Jun 19 2019, 6:22 PM
durin42 updated the diff for D6522: tracing: add many more timedcm() calls throughout the codebase.
Jun 19 2019, 4:27 PM
durin42 created D6549: localrepo: split lookup of context from status call.
Jun 19 2019, 4:26 PM

Jun 18 2019

durin42 closed D6539: remotefilelog: tell runbgcommand to not block on child process startup.
Jun 18 2019, 11:40 AM
durin42 committed rHGdf1419c5756a: remotefilelog: tell runbgcommand to not block on child process startup.
remotefilelog: tell runbgcommand to not block on child process startup
Jun 18 2019, 11:40 AM
durin42 closed D6537: procutil: allow callers of runbgcommand to assume the process starts.
Jun 18 2019, 11:40 AM
durin42 committed rHGca1014ad3de4: procutil: allow callers of runbgcommand to assume the process starts.
procutil: allow callers of runbgcommand to assume the process starts
Jun 18 2019, 11:40 AM
durin42 committed rHG373aeede7352: shallowrepo: remove backwards compat code that predates in-tree remotefilelog.
shallowrepo: remove backwards compat code that predates in-tree remotefilelog
Jun 18 2019, 11:40 AM
durin42 closed D6538: shallowrepo: remove backwards compat code that predates in-tree remotefilelog.
Jun 18 2019, 11:40 AM