Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (128 w, 3 d)

Recent Activity

Today

D7584: procutil: add a option to not fully detach background process now requires changes to proceed.
Mon, Dec 9, 10:14 AM
durin42 added inline comments to D7585: remotefilelog: add a developer option to wait for background processes.
Mon, Dec 9, 10:14 AM
D7586: remotefilelog: have command wait for background task in the tests is now accepted and ready to land.
Mon, Dec 9, 10:14 AM
D7587: remotefilelog: remove most sleep in tests is now accepted and ready to land.
Mon, Dec 9, 10:14 AM
D7588: remotefilelog: use the correct redirection in tests is now accepted and ready to land.
Mon, Dec 9, 10:14 AM
D7589: remotefilelog: remove most of the debugwait* command in the tests is now accepted and ready to land.
Mon, Dec 9, 10:14 AM
D7590: remotefilelog: remove the `ensurestart` usage now requires changes to proceed.
Mon, Dec 9, 10:13 AM
durin42 added a comment to D7590: remotefilelog: remove the `ensurestart` usage.

This is wrong, because now remotefilelog will do ensurestart=True (the default) which is a significant performance hit for remotefilelog users.

Mon, Dec 9, 10:13 AM
durin42 added a comment to D7590: remotefilelog: remove the `ensurestart` usage.

Wait, I just saw the chain. Thanks for weird emails phabricator!

Mon, Dec 9, 9:56 AM
durin42 added a comment to D7590: remotefilelog: remove the `ensurestart` usage.

This doesn't apply to stable. I also checked default, and it doesn't apply there either.

Mon, Dec 9, 9:56 AM

Sat, Dec 7

durin42 committed rHGd9f85f61f0ed: fuzz: clean up some repetition on building parsers.so fuzzers.
fuzz: clean up some repetition on building parsers.so fuzzers
Sat, Dec 7, 12:54 PM
durin42 committed rHGd37658efbec2: fuzz: remove legacy setup for running fuzzers outside oss-fuzz.
fuzz: remove legacy setup for running fuzzers outside oss-fuzz
Sat, Dec 7, 12:54 PM
durin42 committed rHG19da643dc10c: tests: finally fix up test-fuzz-targets.t.
tests: finally fix up test-fuzz-targets.t
Sat, Dec 7, 12:54 PM
durin42 committed rHGe137338e926b: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize.
fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize
Sat, Dec 7, 12:54 PM
durin42 committed rHG5a9e2ae9899b: fuzz: use a more standard approach to allow local builds of fuzzers.
fuzz: use a more standard approach to allow local builds of fuzzers
Sat, Dec 7, 12:54 PM
durin42 committed rHGbf0453866c80: fuzz: use a variable to allow specifying python-config to use.
fuzz: use a variable to allow specifying python-config to use
Sat, Dec 7, 12:54 PM
durin42 committed rHGd1587fadff06: fuzz: suppress deprecated-register warnings in our compile.
fuzz: suppress deprecated-register warnings in our compile
Sat, Dec 7, 12:54 PM
durin42 committed rHG51a99e09c54b: fuzz: always define LLVMFuzzerInitialize() even if we don't need it.
fuzz: always define LLVMFuzzerInitialize() even if we don't need it
Sat, Dec 7, 12:54 PM
durin42 committed rHG53f582bee3d1: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE.
fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE
Sat, Dec 7, 12:54 PM
durin42 committed rHGc78f8f0720cc: fuzz: fix an unused result on getcwd() in pyutil.
fuzz: fix an unused result on getcwd() in pyutil
Sat, Dec 7, 12:54 PM
durin42 committed rHG54a6846ba96f: fuzz: remove debug prints from revlog_corpus.py.
fuzz: remove debug prints from revlog_corpus.py
Sat, Dec 7, 12:54 PM

Fri, Dec 6

durin42 closed D7564: fuzz: use a more standard approach to allow local builds of fuzzers.
Fri, Dec 6, 11:04 PM
durin42 closed D7567: fuzz: remove legacy setup for running fuzzers outside oss-fuzz.
Fri, Dec 6, 11:04 PM
durin42 closed D7568: fuzz: clean up some repetition on building parsers.so fuzzers.
Fri, Dec 6, 11:04 PM
durin42 committed rHGceeff2d99cc9: fuzz: clean up some repetition on building parsers.so fuzzers.
fuzz: clean up some repetition on building parsers.so fuzzers
Fri, Dec 6, 11:04 PM
durin42 closed D7566: tests: finally fix up test-fuzz-targets.t.
Fri, Dec 6, 11:04 PM
durin42 committed rHG7857bd9bb2b0: fuzz: remove legacy setup for running fuzzers outside oss-fuzz.
fuzz: remove legacy setup for running fuzzers outside oss-fuzz
Fri, Dec 6, 11:04 PM
durin42 closed D7565: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize.
Fri, Dec 6, 11:04 PM
durin42 committed rHGece907920139: tests: finally fix up test-fuzz-targets.t.
tests: finally fix up test-fuzz-targets.t
Fri, Dec 6, 11:04 PM
durin42 committed rHG01ec70a80a7b: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize.
fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize
Fri, Dec 6, 11:03 PM
durin42 committed rHG28a91a581fd9: fuzz: use a more standard approach to allow local builds of fuzzers.
fuzz: use a more standard approach to allow local builds of fuzzers
Fri, Dec 6, 11:03 PM
durin42 closed D7560: fuzz: always define LLVMFuzzerInitialize() even if we don't need it.
Fri, Dec 6, 10:59 PM
durin42 closed D7563: fuzz: use a variable to allow specifying python-config to use.
Fri, Dec 6, 10:59 PM
durin42 committed rHG4445e2775066: fuzz: use a variable to allow specifying python-config to use.
fuzz: use a variable to allow specifying python-config to use
Fri, Dec 6, 10:59 PM
durin42 closed D7562: fuzz: suppress deprecated-register warnings in our compile.
Fri, Dec 6, 10:59 PM
durin42 closed D7561: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE.
Fri, Dec 6, 10:59 PM
durin42 committed rHG28be1932f61f: fuzz: suppress deprecated-register warnings in our compile.
fuzz: suppress deprecated-register warnings in our compile
Fri, Dec 6, 10:59 PM
durin42 committed rHG7cb99887bcc3: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE.
fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE
Fri, Dec 6, 10:59 PM
durin42 committed rHG0a56e5f26a52: fuzz: always define LLVMFuzzerInitialize() even if we don't need it.
fuzz: always define LLVMFuzzerInitialize() even if we don't need it
Fri, Dec 6, 10:59 PM
durin42 closed D7559: fuzz: remove debug prints from revlog_corpus.py.
Fri, Dec 6, 10:59 PM
durin42 committed rHG98eb12eab5e5: fuzz: remove debug prints from revlog_corpus.py.
fuzz: remove debug prints from revlog_corpus.py
Fri, Dec 6, 10:59 PM
durin42 closed D7558: fuzz: fix an unused result on getcwd() in pyutil.
Fri, Dec 6, 10:59 PM
durin42 committed rHGf6c0b0510b49: fuzz: fix an unused result on getcwd() in pyutil.
fuzz: fix an unused result on getcwd() in pyutil
Fri, Dec 6, 10:59 PM
durin42 created D7568: fuzz: clean up some repetition on building parsers.so fuzzers.
Fri, Dec 6, 4:12 PM
durin42 created D7564: fuzz: use a more standard approach to allow local builds of fuzzers.
Fri, Dec 6, 3:52 PM
durin42 created D7567: fuzz: remove legacy setup for running fuzzers outside oss-fuzz.
Fri, Dec 6, 3:52 PM
durin42 created D7566: tests: finally fix up test-fuzz-targets.t.
Fri, Dec 6, 3:51 PM
durin42 created D7565: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize.
Fri, Dec 6, 3:51 PM
durin42 created D7560: fuzz: always define LLVMFuzzerInitialize() even if we don't need it.
Fri, Dec 6, 3:51 PM
durin42 created D7563: fuzz: use a variable to allow specifying python-config to use.
Fri, Dec 6, 3:51 PM
durin42 created D7562: fuzz: suppress deprecated-register warnings in our compile.
Fri, Dec 6, 3:51 PM
durin42 created D7561: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE.
Fri, Dec 6, 3:51 PM
durin42 created D7558: fuzz: fix an unused result on getcwd() in pyutil.
Fri, Dec 6, 3:50 PM
durin42 created D7559: fuzz: remove debug prints from revlog_corpus.py.
Fri, Dec 6, 3:50 PM
durin42 added a comment to D7557: annotate: describe --skip as taking a revset.

It said revision before, so at a minimum we should add an s...

Fri, Dec 6, 1:12 PM
durin42 created D7557: annotate: describe --skip as taking a revset.
Fri, Dec 6, 1:00 PM

Thu, Dec 5

durin42 committed rHG29adf0a087a1: merge with stable.
merge with stable
Thu, Dec 5, 11:15 AM
durin42 committed rHG743c69b39332: Added signature for changeset a50fecefa691.
Added signature for changeset a50fecefa691
Thu, Dec 5, 9:21 AM
durin42 committed rHG8849d06363f0: Added tag 5.2.1 for changeset a50fecefa691.
Added tag 5.2.1 for changeset a50fecefa691
Thu, Dec 5, 9:21 AM

Tue, Dec 3

durin42 committed rHGc7fc2d92067e: windows: further build fixes for the WiX installer.
windows: further build fixes for the WiX installer
Tue, Dec 3, 10:59 AM

Sat, Nov 23

durin42 added a comment to D7295: pytype: add a (very slow) test that executes pytype.

Since type checking is slow (but there are state files we can reuse to speed things up), we'll need to figure out how to make this work in CI. But I have no doubt we can figure something out. Out of curiosity, how long does pytype take to run in a clean source directory, without any state files?

It takes 15-20 minutes on a 2018 Mac mini. In addition to the disabled files here, I've disabled:

mercurial/httppeer.py
mercurial/repoview.py
mercurial/localrepo.py
mercurial/revlog.py
mercurial/merge.py
mercurial/testing/storage.py

But I've also added back these, and sprinkled various disable comments around:

mercurial/bundlerepo.py
mercurial/error.py
mercurial/exchange.py
mercurial/policy.py
mercurial/pycompat.py
mercurial/scmwindows.py
mercurial/windows.py
mercurial/wireprotoframing.py

Even with the state files, it seems to take 10-15 minutes or so.

Sat, Nov 23, 12:48 PM

Fri, Nov 22

durin42 closed D7509: windows: further build fixes for the WiX installer.
Fri, Nov 22, 6:13 PM
durin42 committed rHGe8373b215a67: windows: further build fixes for the WiX installer.
windows: further build fixes for the WiX installer
Fri, Nov 22, 6:13 PM
durin42 created D7509: windows: further build fixes for the WiX installer.
Fri, Nov 22, 6:04 PM
durin42 committed rHG640bae94f2f3: cleanup: update references to /help/ that should now be /helptext/.
cleanup: update references to /help/ that should now be /helptext/
Fri, Nov 22, 12:40 PM
durin42 closed D7472: cleanup: update references to /help/ that should now be /helptext/.
Fri, Nov 22, 12:40 PM

Thu, Nov 21

durin42 created D7472: cleanup: update references to /help/ that should now be /helptext/.
Thu, Nov 21, 11:40 PM

Tue, Nov 19

durin42 added a comment to D7296: pycompat: kludge around pytype being confused by __new__.
In D7296#109672, @dlax wrote:

Sorry, still not ok afaict :/

Tue, Nov 19, 1:21 PM
durin42 updated the diff for D7296: pycompat: kludge around pytype being confused by __new__.
Tue, Nov 19, 1:20 PM
durin42 abandoned D7297: cleanup: remove now-obsolete wrong-arg-type annotations.
Tue, Nov 19, 1:20 PM
durin42 updated the diff for D7295: pytype: add a (very slow) test that executes pytype.
Tue, Nov 19, 1:13 PM
durin42 updated the diff for D7297: cleanup: remove now-obsolete wrong-arg-type annotations.
Tue, Nov 19, 11:15 AM
durin42 updated the summary of D7296: pycompat: kludge around pytype being confused by __new__.
Tue, Nov 19, 11:14 AM
durin42 added a comment to D7252: dirs: reject consecutive slashes in paths.

Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this should be reverted.

Oh, you mean the Rust version doesn't do the same rejection?
Given that you're about to do a hash lookup, I'm a little skeptical that a endswith('/') check would show up meaningfully in a profiler, but I'm willing to be proven wrong?

IIUC, currently any new path passes through the pathauditor first for validation, so any further check would be completely redundant.

Plausible, but I'd like some sort of test coverage demonstrating that.

My intuition is that adding this check is purely here to satisfy the fuzzer, but would never happen in real life. Adding checks to this (very) internal data structure comes at a cost, both in performance and in code ergonomics.

Yes, this was largely added to make the fuzzer not get stuck on OOM conditions. That said, if the pathauditor can't catch this, we need to defend against this DoS vector at this layer, and it's such a small check at this layer I'm inclined to keep it unless it is measurably slowing down real uses...

Tue, Nov 19, 10:39 AM
durin42 added a comment to D7252: dirs: reject consecutive slashes in paths.

Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this should be reverted.

Tue, Nov 19, 10:38 AM

Mon, Nov 18

durin42 closed D7385: debugcommands: suppress import errors for pytype.
Mon, Nov 18, 10:51 PM
durin42 closed D7407: debugcommands: add assertions to convince pytype peer is not None.
Mon, Nov 18, 10:51 PM
durin42 committed rHGda5ccc591cff: extensions: suppress a pytype failure due to a typeshed bug.
extensions: suppress a pytype failure due to a typeshed bug
Mon, Nov 18, 10:51 PM
durin42 closed D7410: extensions: suppress a pytype failure due to a typeshed bug.
Mon, Nov 18, 10:51 PM
durin42 closed D7409: dispatch: add some assertions to give pytype a helping hand.
Mon, Nov 18, 10:51 PM
durin42 committed rHGac8fd215a776: dispatch: add some assertions to give pytype a helping hand.
dispatch: add some assertions to give pytype a helping hand
Mon, Nov 18, 10:51 PM
durin42 closed D7381: cmdutil: add a pytype annotation to help out some callsites.
Mon, Nov 18, 10:51 PM
durin42 committed rHG1ea33dff7841: extensions: hide two confusing import statements from pytype.
extensions: hide two confusing import statements from pytype
Mon, Nov 18, 10:51 PM
durin42 closed D7408: extensions: hide two confusing import statements from pytype.
Mon, Nov 18, 10:50 PM
durin42 committed rHG23ad4f0c1578: debugcommands: add assertions to convince pytype peer is not None.
debugcommands: add assertions to convince pytype peer is not None
Mon, Nov 18, 10:50 PM
durin42 committed rHGa9b14ef701d1: debugcommands: suppress import errors for pytype.
debugcommands: suppress import errors for pytype
Mon, Nov 18, 10:50 PM
durin42 committed rHG127d46468a45: state: add a pytype annotation.
state: add a pytype annotation
Mon, Nov 18, 10:50 PM
durin42 closed D7383: state: add a pytype annotation.
Mon, Nov 18, 10:50 PM
durin42 closed D7382: logcmdutil: add a type annotation.
Mon, Nov 18, 10:50 PM
durin42 committed rHGc9301ac73b95: logcmdutil: add a type annotation.
logcmdutil: add a type annotation
Mon, Nov 18, 10:50 PM
durin42 committed rHGa58d2361b231: cmdutil: add a pytype annotation to help out some callsites.
cmdutil: add a pytype annotation to help out some callsites
Mon, Nov 18, 10:49 PM

Fri, Nov 15

durin42 updated the diff for D7384: commands: necessary annotations and suppresssions to pass pytype.
Fri, Nov 15, 4:56 PM
durin42 updated the diff for D7296: pycompat: kludge around pytype being confused by __new__.
Fri, Nov 15, 4:55 PM
durin42 updated the diff for D7296: pycompat: kludge around pytype being confused by __new__.
Fri, Nov 15, 12:33 PM
durin42 updated the diff for D7384: commands: necessary annotations and suppresssions to pass pytype.
Fri, Nov 15, 12:33 PM
durin42 updated the summary of D7296: pycompat: kludge around pytype being confused by __new__.
Fri, Nov 15, 12:31 PM
durin42 added inline comments to D7406: scmutil: convert status data object from a tuple to an attrs (API).
Fri, Nov 15, 12:27 PM
durin42 added a comment to D7384: commands: necessary annotations and suppresssions to pass pytype.

I still want to keep the annotations I added. :)

Fri, Nov 15, 12:24 PM
durin42 updated the diff for D7407: debugcommands: add assertions to convince pytype peer is not None.
Fri, Nov 15, 11:33 AM
durin42 updated the diff for D7385: debugcommands: suppress import errors for pytype.
Fri, Nov 15, 11:32 AM