- User Since
- Jun 23 2017, 4:23 PM (139 w, 6 d)
Tue, Feb 25
Mon, Feb 24
I'm enthusiastic about this change, and in general a fan of declaring misfeatures in bookmarks exchange bugs. I think it's pretty clear the existing bookmarks exchange behavior isn't right to the point of being buggy.
Fri, Feb 14
This is now ready for review: I would be happy to see this land, and have others contribute towards it. I don't know that I have time to do all that needs doing, but would be delighted to mentor others that want to help!
Thu, Feb 13
Why can't we add templater support to debugmergestate instead?
Wed, Feb 12
Nevermind, I misread.
I think this is obsolete now? Maybe?
Oddly, this had some rejects (I didn't look why) but i"d be happy to see this earlier in the series.
I remain happy with this.
LGTM, would like @marmoute to chime in.
I think I'd prefer debugbackupbundle per marmoute's suggestion.
I like this, but I'm too chicken to queue it.
I'm just not comfortable with the unsafe block here, especially with the comments from @kevincox . That said, if the unsafe can't disappear, it probably needs a pretty thorough explanation of why it's correct for a novice rust reader to follow?
(Marking this as wanting changes per discussions about adding some headline numbers in the log message so I stop looking at it until that happens.)
Tue, Feb 11
Mon, Feb 10
I'm a huge fan.
Forgot to say: I'd be a big fan of unwinding pycompat.open() now that we're done with the module transformer.
Looks fine to me for default, queued.
Fri, Feb 7
Thu, Feb 6
Wed, Feb 5
Tue, Feb 4
Mon, Feb 3
I need to make some time to clean up the manifest implementation in this to land it, and then we'll need help improving it. It's not dead, just resting. :)
Fri, Jan 31
Wed, Jan 29
Breaks test-merge2.t but otherwise seems like a good series.