durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (29 w, 4 d)

Recent Activity

Yesterday

durin42 added a comment to D1856: wireproto: support for pullbundles.

My biggest concern with the architecture of this feature is the multiple roundtrips. I really wish we could stream multiple bundles off disk to the wire with no decompression/compression involved. That would mean storing compressed bundles on disk. But this would require some additional bundle2 magic. The existing solution is simple and elegant. I do like that. I'd very much like to get the opinion of someone like @durin42 (who also likes designing protocols).

Mon, Jan 15, 11:02 AM

Thu, Jan 11

durin42 added a comment to D1846: rust: avoid redundant 'static lifetime.
To my understanding, as long as we're only using the stable channel, we should be fine for the binaries we're building being packageable even on slower-moving distros like Debian.

Slow-moving distros like Debian don't update the rust compiler. Debian stable is stuck on rustc 1.14 until Debian buster (next year?).

Thu, Jan 11, 4:20 PM
durin42 accepted D1846: rust: avoid redundant 'static lifetime.
Thu, Jan 11, 1:15 PM
durin42 added a comment to D1846: rust: avoid redundant 'static lifetime.
In D1846#31265, @yuja wrote:

I think it's new feature. Which Rust version should we support?

https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1170-2017-04-27

Thu, Jan 11, 1:14 PM

Wed, Jan 10

durin42 accepted D1844: rust: move Cargo.lock.
Wed, Jan 10, 10:11 PM
durin42 accepted D1843: run-tests: fix regular expression for path test.
Wed, Jan 10, 10:05 PM
durin42 created D1842: tests: update test-rebase expected output.
Wed, Jan 10, 7:08 PM
durin42 added a comment to D1830: test-run-tests: stabilize the test (issue5735).

As a note (re your test plan): there's a --runs-per-test flag on run-tests for exactly this kind of "did I fix a flaky test" debugging. I often set it to 100. :)

Wed, Jan 10, 6:28 PM
durin42 added a comment to D1756: remotenames: introduce class to encapsulate remotenames info in an extension.
In D1756#29970, @pulkit wrote:

As per previous discussions, the storage part can only go to core directly (https://phab.mercurial-scm.org/D1358#22905). I am not sure about how out of core extension and in-core extension will interact. Also shall I change this extension name to prevent conflict with the out of core one?

Wed, Jan 10, 6:22 PM
durin42 requested changes to D1755: logexchange: introduce helper function to get remote path name.
Wed, Jan 10, 6:18 PM
durin42 accepted D1800: py3: add 8 new passing tests to the whitelist.
Wed, Jan 10, 5:57 PM
durin42 accepted D1799: py3: use list() to get a list of items using dict.items().
Wed, Jan 10, 5:56 PM
durin42 accepted D1798: py3: convert dict keys' to str before passing as kwargs.
Wed, Jan 10, 5:56 PM
durin42 accepted D1797: py3: make sure we open the file to write in bytes mode.
Wed, Jan 10, 5:56 PM
durin42 accepted D1796: py3: don't use dict.iterkeys().
Wed, Jan 10, 5:56 PM
durin42 accepted D1795: py3: use pycompat.bytestr() instead of str().
Wed, Jan 10, 5:56 PM
durin42 accepted D1794: py3: make regular expressions bytes by prepending b''.
Wed, Jan 10, 5:56 PM
durin42 accepted D1793: py3: slice on bytes instead of indexing.
Wed, Jan 10, 5:56 PM
durin42 accepted D1792: py3: use node.hex(h.digest()) instead of h.hexdigest().
Wed, Jan 10, 5:56 PM
durin42 accepted D1791: tests: make autodiff.py work on Python 3.
Wed, Jan 10, 5:56 PM
durin42 accepted D1790: py3: use pycompat.ziplist instead of inbuilt zip.
Wed, Jan 10, 5:56 PM
durin42 accepted D1789: py3: use bytes and open() instead of file() in test-diff-upgrade.t.
Wed, Jan 10, 5:56 PM
durin42 accepted D1779: unionrepo: use named attributes on revlog index entries.

Happy to see these land, but waiting for any objections from others.

Wed, Jan 10, 5:54 PM
durin42 accepted D1778: debugcommands: use named attributes on revlog index entries.
Wed, Jan 10, 5:54 PM
durin42 accepted D1777: upgrade: use named attributes on revlog index entries.
Wed, Jan 10, 5:54 PM
durin42 accepted D1776: bundlerepo: use named attributes on revlog index entries.
Wed, Jan 10, 5:54 PM
durin42 accepted D1775: dagutil: use named attributes on revlog index entries.
Wed, Jan 10, 5:54 PM
durin42 accepted D1774: repoview: use named attributes on revlog index entries.
Wed, Jan 10, 5:54 PM
durin42 accepted D1773: revlog: use named attributes on revlog index entries.
Wed, Jan 10, 5:54 PM
durin42 accepted D1772: tests: port revlog index code to modern API.
Wed, Jan 10, 5:54 PM
durin42 accepted D1771: revlog: pass index entry type into packentry() (API).
Wed, Jan 10, 5:54 PM
durin42 accepted D1769: cext: use dedicated type for index entries.
Wed, Jan 10, 5:54 PM
durin42 accepted D1770: revlog: use revlog index entry type for version 0 revlogs.
Wed, Jan 10, 5:54 PM
durin42 accepted D1768: cext: obtain reference to index entry type.
Wed, Jan 10, 5:54 PM
durin42 accepted D1767: cext: make nullentry a member of index types.
Wed, Jan 10, 5:54 PM
durin42 accepted D1765: parsers: use an attr-derived class for revlog index entries.
Wed, Jan 10, 5:54 PM
durin42 accepted D1766: cext: rename variable describing format for index entries.
Wed, Jan 10, 5:54 PM
durin42 added a comment to D1773: revlog: use named attributes on revlog index entries.
In D1773#30628, @yuja wrote:

However, it is quite large and I suspect it will take a bit more effort to finish it.

Isn't that something like dirstateTupleType? If we had a native type, we wouldn't
need D1767, D1768, and probably D1769. If it can get rid of refcounting business,
reviewing this series will be much fun.

Wed, Jan 10, 5:53 PM
durin42 accepted D1841: exchange: use context manager for locks and transaction in unbundle().
Wed, Jan 10, 5:45 PM
durin42 accepted D1840: bookmarks: use context managers for locks and transaction in pushbookmark().
Wed, Jan 10, 5:44 PM
durin42 accepted D1839: bookmarks: use context managers for lock and transaction in update().
Wed, Jan 10, 5:44 PM
durin42 accepted D1838: phase: use context managers for lock and transaction.
Wed, Jan 10, 5:44 PM
durin42 accepted D1837: obsolete: use context manager for transaction in pushmarker().
Wed, Jan 10, 5:44 PM
durin42 accepted D1836: obsolete: use context manager for lock in pushmarker().
Wed, Jan 10, 5:44 PM
durin42 accepted D1835: obsolete: use context manager for transaction in createmarkers().
Wed, Jan 10, 5:44 PM
durin42 added a comment to D1694: debugcommands: replace opts.get('foo') by opts['foo'].
In D1694#29072, @yuja wrote:

Queued the first three patches, but I'm not certain about this. Sometimes we
do the reverse change for ease of calling command function as a plain function.

Wed, Jan 10, 5:40 PM
durin42 accepted D1829: merge: add `--abort` flag which can abort the merge.

I'm fine with this.

Wed, Jan 10, 5:39 PM
durin42 accepted D1591: visibility: improve the message when accessing filtered obsolete rev.
Wed, Jan 10, 5:37 PM
durin42 accepted D1788: tests: add b'' to string literals where bytes are required.
Wed, Jan 10, 5:33 PM
durin42 accepted D1581: rust: implementation of `hg`.
Wed, Jan 10, 5:30 PM

Thu, Dec 28

durin42 added a comment to D1794: py3: make regular expressions bytes by prepending b''.

For patches like this that are just adding bytes prefixes, let's go ahead and do a '# skip-blame' as in d92dc725223bbde09963fc431e57d32a40c4167d (aka D1170) so that blame is cleaner in the future.

Thu, Dec 28, 8:52 PM
durin42 requested changes to D1788: tests: add b'' to string literals where bytes are required.

For patches like this that are just adding bytes prefixes, let's go ahead and do a '# skip-blame' as in d92dc725223bbde09963fc431e57d32a40c4167d (aka D1170) so that blame is cleaner in the future.

Thu, Dec 28, 8:51 PM
durin42 added a comment to D1791: tests: make autodiff.py work on Python 3.

For patches like this that are just adding bytes prefixes, let's go ahead and do a '# skip-blame' as in d92dc725223bbde09963fc431e57d32a40c4167d (aka D1170) so that blame is cleaner in the future.

Thu, Dec 28, 8:51 PM

Wed, Dec 20

durin42 accepted D1725: githelp: remove reference to tweakdefaults.
Wed, Dec 20, 8:41 PM
durin42 accepted D1722: githelp: vendor Facebook authored extension.
Wed, Dec 20, 8:41 PM
durin42 accepted D1728: githelp: improve help for "reset".
Wed, Dec 20, 8:41 PM
durin42 accepted D1726: githelp: replace suggestion of `hg record`.
Wed, Dec 20, 8:41 PM
durin42 accepted D1723: githelp: improve help for `git add`.
Wed, Dec 20, 8:41 PM
durin42 accepted D1727: githelp: clean up reflog help.
Wed, Dec 20, 8:41 PM
durin42 accepted D1729: githelp: don't reference 3rd party commands for `git show`.
Wed, Dec 20, 8:41 PM
durin42 added a comment to D1724: githelp: recommend `hg import` for `git am`.

what's wrong with hg import? Doesn't that correctly parses mbox files?

Wed, Dec 20, 8:38 PM
durin42 accepted D1739: filemerge: only raise InMemoryMergeConflictsError when running _xmerge.
Wed, Dec 20, 8:33 PM
durin42 accepted D1740: journal: use pager.
Wed, Dec 20, 8:33 PM

Tue, Dec 19

durin42 committed rHG786289423e97: merge with stable.
merge with stable
Tue, Dec 19, 4:41 PM

Mon, Dec 18

durin42 committed rHGd624c8558c61: tests: update expected output of svn encoding test.
tests: update expected output of svn encoding test
Mon, Dec 18, 11:21 PM
durin42 closed D1713: tests: update expected output of svn encoding test.
Mon, Dec 18, 11:21 PM
durin42 created D1713: tests: update expected output of svn encoding test.
Mon, Dec 18, 1:15 PM

Dec 17 2017

durin42 committed rHGcf532a62e337: tests: test-pathconflicts-merge.t requires symlinks.
tests: test-pathconflicts-merge.t requires symlinks
Dec 17 2017, 2:27 PM

Dec 15 2017

durin42 committed rHGf7de3353e59d: tests: test-pathconflicts-merge.t requires symlinks.
tests: test-pathconflicts-merge.t requires symlinks
Dec 15 2017, 6:06 PM
durin42 closed D1710: tests: test-pathconflicts-merge.t requires symlinks.
Dec 15 2017, 6:06 PM
durin42 created D1710: tests: test-pathconflicts-merge.t requires symlinks.
Dec 15 2017, 5:53 PM
durin42 accepted D1683: sshpeer: allow for additional environment passing to ssh exe.

Ugh. But clearly needed.

Dec 15 2017, 4:14 PM

Dec 14 2017

durin42 committed rHGa51541681b8d: merge with stable.
merge with stable
Dec 14 2017, 4:05 PM
durin42 accepted D1689: statprof: remove a line of deadcode.

deleted code is best code

Dec 14 2017, 3:53 PM

Dec 12 2017

durin42 edited dependencies for D1658: memfilectx: make changectx argument mandatory in constructor (API), added: 1; removed: 1.
Dec 12 2017, 5:53 PM
durin42 removed a dependent revision for D1657: debugbuilddag: create filectx instance in 'filectxfn' callback: D1658: memfilectx: make changectx argument mandatory in constructor (API).
Dec 12 2017, 5:53 PM
durin42 added a dependent revision for D1670: debugbuilddag: create filectx instance in 'filectxfn' callback: D1658: memfilectx: make changectx argument mandatory in constructor (API).
Dec 12 2017, 5:53 PM
durin42 added a comment to D1657: debugbuilddag: create filectx instance in 'filectxfn' callback.

arg, this was pushed in error by me - @martinvonz will need to re-phabsend.

Dec 12 2017, 5:18 PM
durin42 added a comment to D1656: synthrepo: create filectx instance in 'filectxfn' callback.

Crud. I had an old version of this queued, and failed to drop it. Fixing now...

Dec 12 2017, 5:16 PM
durin42 added a comment to D1667: tests_: fix test-lfs.t on OSX where find does not have quotes.

(and yes, I'm curious where that ' came from too, but here we are)

Dec 12 2017, 4:34 PM
durin42 added a comment to D1667: tests_: fix test-lfs.t on OSX where find does not have quotes.

Beat you to it: https://www.mercurial-scm.org/repo/hg-committed/rev/85f866bf9362

Dec 12 2017, 4:34 PM
durin42 committed rNRWHGe2d43877d7e8: tests: appease check-code on `grep -q`.
tests: appease check-code on `grep -q`
Dec 12 2017, 4:21 PM
durin42 closed D1662: tests: appease check-code on `grep -q`.
Dec 12 2017, 4:21 PM
durin42 committed rNRWHG2fee8b001b88: config: rename config item to experimental.narrowservebrokenellipses.
config: rename config item to experimental.narrowservebrokenellipses
Dec 12 2017, 4:19 PM
durin42 closed D1663: config: rename config item to experimental.narrowservebrokenellipses.
Dec 12 2017, 4:19 PM
durin42 committed rNRWHGffb8bb272492: setup: update maintainer field to point to me.
setup: update maintainer field to point to me
Dec 12 2017, 4:19 PM
durin42 closed D1661: setup: update maintainer field to point to me.
Dec 12 2017, 4:19 PM
durin42 committed rHGc0c6df81c9bb: tests: add some commentary and diagnostics to test-run-tests.t.
tests: add some commentary and diagnostics to test-run-tests.t
Dec 12 2017, 9:16 AM
durin42 closed D1653: tests: add some commentary and diagnostics to test-run-tests.t.
Dec 12 2017, 9:16 AM

Dec 11 2017

durin42 added a comment to D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase.

Phil is planning to follow up with the config knob, and I hope to test this aggressively at Google and make it default if we don't find any bugs.

Dec 11 2017, 7:14 PM
durin42 committed rNRWHG1228c91774fc: config: add configregistrar business for our one config item.
config: add configregistrar business for our one config item
Dec 11 2017, 4:22 PM
durin42 closed D1589: config: add configregistrar business for our one config item.
Dec 11 2017, 4:22 PM
durin42 committed rNRWHG60089e990fdf: setup: correct URL of repository.
setup: correct URL of repository
Dec 11 2017, 4:22 PM
durin42 closed D1533: setup: correct URL of repository.
Dec 11 2017, 4:22 PM
durin42 added reviewers for D1663: config: rename config item to experimental.narrowservebrokenellipses: spectral, martinvonz.
Dec 11 2017, 3:16 PM
durin42 added reviewers for D1662: tests: appease check-code on `grep -q`: spectral, martinvonz.
Dec 11 2017, 3:16 PM
durin42 created D1663: config: rename config item to experimental.narrowservebrokenellipses.
Dec 11 2017, 3:15 PM
durin42 created D1662: tests: appease check-code on `grep -q`.
Dec 11 2017, 3:14 PM
durin42 added inline comments to D1533: setup: correct URL of repository.
Dec 11 2017, 3:06 PM
durin42 created D1661: setup: update maintainer field to point to me.
Dec 11 2017, 3:06 PM