Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (139 w, 6 d)

Recent Activity

Tue, Feb 25

durin42 updated the diff for D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Tue, Feb 25, 1:52 PM

Mon, Feb 24

durin42 committed rHGf5c006621f07: merge with stable.
merge with stable
Mon, Feb 24, 1:53 PM
durin42 added a comment to D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote).

I'm enthusiastic about this change, and in general a fan of declaring misfeatures in bookmarks exchange bugs. I think it's pretty clear the existing bookmarks exchange behavior isn't right to the point of being buggy.

Mon, Feb 24, 11:50 AM

Fri, Feb 14

durin42 retitled D6734: git: skeleton of a new extension to _directly_ operate on git repos from git: RFC of a new extension to _directly_ operate on git repositories to git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Feb 14, 4:47 PM
durin42 added a comment to D6734: git: skeleton of a new extension to _directly_ operate on git repos.

This is now ready for review: I would be happy to see this land, and have others contribute towards it. I don't know that I have time to do all that needs doing, but would be delighted to mentor others that want to help!

Fri, Feb 14, 4:45 PM
durin42 updated the summary of D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Feb 14, 4:45 PM
durin42 updated the diff for D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Feb 14, 4:34 PM
durin42 updated the diff for D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Feb 14, 4:20 PM
durin42 updated the summary of D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Fri, Feb 14, 4:07 PM

Thu, Feb 13

durin42 created D8115: rebase: show bug when rebasing merge with obsoleted revs on both sides.
Thu, Feb 13, 4:00 PM
durin42 added a comment to D8113: debugmergestate: make templated.

Why can't we add templater support to debugmergestate instead?

Thu, Feb 13, 12:55 PM

Wed, Feb 12

D8035: copy: add experimental support for marking committed copies is now accepted and ready to land.

See my comment in D8030, the feature is interresting, but it seems to me that we should implement that through regular amend.

Wed, Feb 12, 2:45 PM
D8034: check-code: allow `hg cp -r`, by using a negative lookbehind is now accepted and ready to land.

Nevermind, I misread.

Wed, Feb 12, 2:45 PM
durin42 added a comment to D8034: check-code: allow `hg cp -r`, by using a negative lookbehind.

I think this is obsolete now? Maybe?

Wed, Feb 12, 2:44 PM
D8033: copy: move argument validation a little earlier is now accepted and ready to land.

Oddly, this had some rejects (I didn't look why) but i"d be happy to see this earlier in the series.

Wed, Feb 12, 2:44 PM
durin42 added a comment to D8030: copy: add experimetal support for unmarking committed copies.

I remain happy with this.

Wed, Feb 12, 2:43 PM
durin42 added a comment to D8029: copy: add option to unmark file as copied.

LGTM, would like @marmoute to chime in.

Wed, Feb 12, 2:41 PM
D7932: debugbackupbundle: introduce command to interact with strip backups now requires changes to proceed.

I think I'd prefer debugbackupbundle per marmoute's suggestion.

Wed, Feb 12, 2:29 PM
durin42 added a comment to D7258: makefile: use Python 3 by default outside of Windows (BC).

I like this, but I'm too chicken to queue it.

Wed, Feb 12, 2:27 PM
D7796: rust-nodemap: input/output primitives now requires changes to proceed.

I'm just not comfortable with the unsafe block here, especially with the comments from @kevincox . That said, if the unsafe can't disappear, it probably needs a pretty thorough explanation of why it's correct for a novice rust reader to follow?

Wed, Feb 12, 11:55 AM
durin42 added a comment to D7795: rust-nodemap: insert method.

The change seesm good to me. However kevincox proposal to use #[cfg(test)] for pad_node seems worth applying inflight.

Wed, Feb 12, 11:38 AM
D7972: recover: don't verify by default is now accepted and ready to land.

I _think_ it's just paranoia. As long as the bundle wasn't woefully corrupt, it shouldn't be a problem. I _think_ if we set some of the [server]-section bundle validation options (which should be cheap enough) we could ditch this completely safely.
As it stands, I'm fine with this patch if someone else has the confidence to push it.

How does the validity of an input bundle affect recover?

Wed, Feb 12, 11:35 AM
D7894: nodemap: introduce an option to use mmap to read the nodemap mapping now requires changes to proceed.

(Marking this as wanting changes per discussions about adding some headline numbers in the log message so I stop looking at it until that happens.)

Wed, Feb 12, 11:32 AM

Tue, Feb 11

durin42 closed D8109: context: use manifest.find() instead of two separate calls.
Tue, Feb 11, 12:43 AM
durin42 committed rHG2e2cfc3bea0b: context: use manifest.find() instead of two separate calls.
context: use manifest.find() instead of two separate calls
Tue, Feb 11, 12:43 AM
durin42 added a comment to D6734: git: skeleton of a new extension to _directly_ operate on git repos.

Planned changes:

Tue, Feb 11, 12:32 AM
durin42 updated the summary of D6734: git: skeleton of a new extension to _directly_ operate on git repos.
Tue, Feb 11, 12:29 AM
durin42 created D8109: context: use manifest.find() instead of two separate calls.
Tue, Feb 11, 12:08 AM

Mon, Feb 10

durin42 closed D8085: manifest: move matches method to be outside the interface.
Mon, Feb 10, 9:44 PM
durin42 committed rHG0bf3b5e80d30: manifest: move matches method to be outside the interface.
manifest: move matches method to be outside the interface
Mon, Feb 10, 9:43 PM
durin42 closed D8107: tags: fix some type confusion exposed in python 3.
Mon, Feb 10, 9:27 PM
durin42 closed D8108: tags: use modern // operator for division.
Mon, Feb 10, 9:27 PM
durin42 committed rHG8ec186c1ccfe: tags: use modern // operator for division.
tags: use modern // operator for division
Mon, Feb 10, 9:26 PM
durin42 committed rHGe80da7a63264: tags: fix some type confusion exposed in python 3.
tags: fix some type confusion exposed in python 3
Mon, Feb 10, 9:26 PM
D7829: rebase: remove some now-unused parent arguments is now accepted and ready to land.
Mon, Feb 10, 9:16 PM
D7828: rebase: remove some redundant setting of dirstate parents is now accepted and ready to land.
Mon, Feb 10, 9:16 PM
D7827: rebase: don't use rebased node as dirstate p2 (BC) is now accepted and ready to land.
Mon, Feb 10, 9:16 PM
D7826: rebase: stop relying on having two parents to resume rebase is now accepted and ready to land.
Mon, Feb 10, 9:16 PM
D8043: graphlog: use '%' for other context in merge conflict is now accepted and ready to land.
Mon, Feb 10, 9:16 PM
D8042: tests: add `hg log -G` output when there are merge conflicts is now accepted and ready to land.
Mon, Feb 10, 9:16 PM
D8041: revset: add a revset for parents in merge state is now accepted and ready to land.
Mon, Feb 10, 9:16 PM
D7824: tests: add test of rebase with conflict in merge commit is now accepted and ready to land.
Mon, Feb 10, 9:15 PM
durin42 created D8107: tags: fix some type confusion exposed in python 3.
Mon, Feb 10, 9:10 PM
durin42 created D8108: tags: use modern // operator for division.
Mon, Feb 10, 9:09 PM
D7894: nodemap: introduce an option to use mmap to read the nodemap mapping now requires changes to proceed.

More throughful benchmarking has arrived.
This is a large win all over the board. The win for the larger repository very significant.

+         3.9e-05          7.1e-05     1.82  internal.index.no_lookup.track_time('mercurial-2018-08-01', 'zlib', 'default', True, True, True, True, False) [citrea/virtualenv-py2.7-pyyaml-HGMODULEPOLICYrust+c-HGWITHRUSTEXTcpython]

[...]

Mon, Feb 10, 8:15 PM
durin42 added inline comments to D7842: nodemap: use an explicit "Block" object in the reference implementation.
Mon, Feb 10, 7:58 PM
durin42 updated the diff for D8085: manifest: move matches method to be outside the interface.
Mon, Feb 10, 7:49 PM
durin42 closed D8104: cleanup: re-run black on the codebase.
Mon, Feb 10, 7:29 PM
durin42 committed rHGa0ec05d93c8e: cleanup: re-run black on the codebase.
cleanup: re-run black on the codebase
Mon, Feb 10, 7:27 PM
durin42 added a comment to D7960: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar.

I forgot to reply to this last week- I was concerned when the subsequent part of the stack went in without suppressing the per file progress bars here, that the displayed progress bar would be bouncing around randomly. But it wasn't- it was ever increasing like only the main bar was being changed. Any ideas why that would be?

Mon, Feb 10, 7:25 PM
durin42 created D8104: cleanup: re-run black on the codebase.
Mon, Feb 10, 5:34 PM
D7966: remotefilelog: only prefetch history in linkrevfixup now requires changes to proceed.

Terrible damage:

Mon, Feb 10, 4:56 PM
durin42 added a comment to D7960: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar.

(also, the double sending is very sad, could we have a small wireprotocol command dedicated at testing authentication first instead ?)

Presumably, but IDK anything about the wire protocol, and the existing code would still be needed for the case where the server doesn't know about the command.

Mon, Feb 10, 4:49 PM
D8100: help: add a mechanism to change flags' help depending on config is now accepted and ready to land.

I'm a huge fan.

Mon, Feb 10, 4:43 PM
durin42 added a comment to D8099: lfs: use str for the open() mode when opening a blob for py3.

Forgot to say: I'd be a big fan of unwinding pycompat.open() now that we're done with the module transformer.

Mon, Feb 10, 4:39 PM
durin42 added a comment to D8099: lfs: use str for the open() mode when opening a blob for py3.

Looks fine to me for default, queued.

Mon, Feb 10, 4:39 PM
durin42 added a comment to D7972: recover: don't verify by default.

Sorry for late reply. By changing the default, I am afraid about the cases where a user has broken repository and we only recover the transaction and don't verify. I am not sure what those cases are. Also I don't know why recover performs verify in the first place. Maybe @durin42, @marmoute or someone else knows?

Mon, Feb 10, 4:37 PM

Fri, Feb 7

durin42 committed rHGe76d98546bd2: merge: use manifestdict.walk() instead of manifestdict.matches().
merge: use manifestdict.walk() instead of manifestdict.matches()
Fri, Feb 7, 5:50 PM
durin42 committed rHGbbecb6d80aa7: manifest: rewrite filesnotin to not make superfluous manifest copies.
manifest: rewrite filesnotin to not make superfluous manifest copies
Fri, Feb 7, 5:50 PM
durin42 committed rHGe786d69c665d: archival: use walk() instead of matches() on manifest.
archival: use walk() instead of matches() on manifest
Fri, Feb 7, 5:49 PM
durin42 committed rHG27787a43712f: resourceutil: blacken.
resourceutil: blacken
Fri, Feb 7, 5:16 PM
durin42 committed rHGca43ca89d9d4: merge: use manifestdict.walk() instead of manifestdict.matches().
merge: use manifestdict.walk() instead of manifestdict.matches()
Fri, Feb 7, 5:15 PM
durin42 committed rHG610efaf53d28: manifest: rewrite filesnotin to not make superfluous manifest copies.
manifest: rewrite filesnotin to not make superfluous manifest copies
Fri, Feb 7, 5:15 PM
durin42 committed rHGb0658341a861: archival: use walk() instead of matches() on manifest.
archival: use walk() instead of matches() on manifest
Fri, Feb 7, 5:15 PM
durin42 closed D8084: merge: use manifestdict.walk() instead of manifestdict.matches().
Fri, Feb 7, 5:11 PM
durin42 closed D8082: manifest: rewrite filesnotin to not make superfluous manifest copies.
Fri, Feb 7, 5:11 PM
durin42 committed rHG0e5f6c70aeb4: merge: use manifestdict.walk() instead of manifestdict.matches().
merge: use manifestdict.walk() instead of manifestdict.matches()
Fri, Feb 7, 5:11 PM
durin42 committed rHGa4e045740619: manifest: rewrite filesnotin to not make superfluous manifest copies.
manifest: rewrite filesnotin to not make superfluous manifest copies
Fri, Feb 7, 5:11 PM
durin42 updated the diff for D8084: merge: use manifestdict.walk() instead of manifestdict.matches().
Fri, Feb 7, 4:50 PM
durin42 committed rHG3e6ac7ce1e2c: archival: use walk() instead of matches() on manifest.
archival: use walk() instead of matches() on manifest
Fri, Feb 7, 4:38 PM
durin42 closed D8090: archival: use walk() instead of matches() on manifest.
Fri, Feb 7, 4:38 PM

Thu, Feb 6

durin42 closed D8081: manifest: fix _very_ subtle bug with exact matchers passed to walk().
Thu, Feb 6, 5:12 PM
durin42 committed rHG48a1a974a92c: manifest: fix _very_ subtle bug with exact matchers passed to walk().
manifest: fix _very_ subtle bug with exact matchers passed to walk()
Thu, Feb 6, 5:12 PM
durin42 created D8090: archival: use walk() instead of matches() on manifest.
Thu, Feb 6, 4:57 PM
durin42 updated the diff for D8083: archival: use walk() instead of matches() on manifest.
Thu, Feb 6, 4:56 PM
durin42 closed D8080: context: use manifest.walk() instead of manifest.match() to get file list.
Thu, Feb 6, 11:11 AM
durin42 closed D8079: manifest: remove `.new()` from the interface.
Thu, Feb 6, 11:11 AM
durin42 closed D8083: archival: use walk() instead of matches() on manifest.
Thu, Feb 6, 11:11 AM
durin42 committed rHG2d1b2ad3705b: archival: use walk() instead of matches() on manifest.
archival: use walk() instead of matches() on manifest
Thu, Feb 6, 11:11 AM
durin42 committed rHGbeea86e4d332: context: use manifest.walk() instead of manifest.match() to get file list.
context: use manifest.walk() instead of manifest.match() to get file list
Thu, Feb 6, 11:11 AM
durin42 committed rHGc86256bd4eb8: manifest: remove `.new()` from the interface.
manifest: remove `.new()` from the interface
Thu, Feb 6, 11:11 AM

Wed, Feb 5

durin42 created D8085: manifest: move matches method to be outside the interface.
Wed, Feb 5, 5:35 PM
durin42 created D8084: merge: use manifestdict.walk() instead of manifestdict.matches().
Wed, Feb 5, 5:35 PM
durin42 created D8082: manifest: rewrite filesnotin to not make superfluous manifest copies.
Wed, Feb 5, 5:34 PM
durin42 created D8081: manifest: fix _very_ subtle bug with exact matchers passed to walk().
Wed, Feb 5, 5:34 PM
durin42 created D8083: archival: use walk() instead of matches() on manifest.
Wed, Feb 5, 5:34 PM
durin42 created D8080: context: use manifest.walk() instead of manifest.match() to get file list.
Wed, Feb 5, 5:34 PM
durin42 created D8079: manifest: remove `.new()` from the interface.
Wed, Feb 5, 5:34 PM

Tue, Feb 4

durin42 closed D8069: manifest: remove optional default= argument on flags(path).
Tue, Feb 4, 1:12 AM
durin42 committed rHGdbbae122f5e4: manifest: remove optional default= argument on flags(path).
manifest: remove optional default= argument on flags(path)
Tue, Feb 4, 1:12 AM

Mon, Feb 3

durin42 created D8069: manifest: remove optional default= argument on flags(path).
Mon, Feb 3, 11:48 PM
durin42 committed rHGaea79f41ee55: resourceutil: blacken.
resourceutil: blacken
Mon, Feb 3, 11:57 AM
durin42 committed rHG15eb90965a00: merge with stable.
merge with stable
Mon, Feb 3, 11:57 AM
durin42 committed rHG3ef4b8114b35: Added tag 5.3 for changeset 7f5410dfc8a6.
Added tag 5.3 for changeset 7f5410dfc8a6
Mon, Feb 3, 11:16 AM
durin42 committed rHGc002d504ff11: Added signature for changeset 7f5410dfc8a6.
Added signature for changeset 7f5410dfc8a6
Mon, Feb 3, 11:16 AM
durin42 added a comment to D6734: git: skeleton of a new extension to _directly_ operate on git repos.

I need to make some time to clean up the manifest implementation in this to land it, and then we'll need help improving it. It's not dead, just resting. :)

Mon, Feb 3, 11:16 AM

Fri, Jan 31

durin42 added a comment to D7295: pytype: add a (very slow) test that executes pytype.
In D7295#118785, @quark wrote:

Have pyre been considered?

Fri, Jan 31, 10:19 AM

Wed, Jan 29

durin42 added a comment to D8030: copy: add experimetal support for unmarking committed copies.

I'm conflicted on rolling the uncopy && amend action into the uncopy command like this. Could users not (without this patch) do hg uncopy foo && hg amend?

I don't think so, because it's not marked as a copy in the working copy, right?

Wed, Jan 29, 6:22 PM
D8000: mq: don't tell user to commit merge that we already committed is now accepted and ready to land.
Wed, Jan 29, 6:09 PM
D7999: merge: make hg.merge() take a context instead of a node now requires changes to proceed.

Breaks test-merge2.t but otherwise seems like a good series.

Wed, Jan 29, 6:09 PM