Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (201 w, 5 d)

Recent Activity

Today

durin42 added a comment to D10672: remotefilelog: use the correct capability when using getfilestype threaded.

This looks good, but we need an email address in the username - can you add one and re-upload the change?

Wed, May 5, 6:21 PM

Yesterday

durin42 created D10669: debugcommands: fix some plural-agreements I noticed.
Tue, May 4, 1:29 PM

Mon, May 3

durin42 committed rHGfde5bb5d1acf: merge: with stable.
merge: with stable
Mon, May 3, 3:15 PM

Wed, Apr 28

durin42 committed rHG3c8e4c6ec9bc: merge: stable heads.
merge: stable heads
Wed, Apr 28, 11:09 AM
durin42 committed rHG41f8f38d8377: Added signature for changeset 8d2b62d716b0.
Added signature for changeset 8d2b62d716b0
Wed, Apr 28, 11:08 AM
durin42 committed rHG8fc2c867af54: Added tag 5.8rc1 for changeset 8d2b62d716b0.
Added tag 5.8rc1 for changeset 8d2b62d716b0
Wed, Apr 28, 11:08 AM

Tue, Apr 20

durin42 committed rHG01264552a1dc: Added signature for changeset f67b8946bb1b.
Added signature for changeset f67b8946bb1b
Tue, Apr 20, 11:17 AM
durin42 committed rHGf67b8946bb1b: merge: default into stable for 5.8 rc.
merge: default into stable for 5.8 rc
Tue, Apr 20, 11:17 AM
durin42 committed rHGe846261413d0: Added tag 5.8rc0 for changeset f67b8946bb1b.
Added tag 5.8rc0 for changeset f67b8946bb1b
Tue, Apr 20, 11:17 AM

Mon, Apr 12

D10357: Add narrow capabilities for local repos, not just remote peers is now accepted and ready to land.

Thanks! This needed some tweaking on the commit message to line up with our format (which is checked by the test suite, but I've edited in-flight and am pushing now.)

Mon, Apr 12, 2:51 PM

Apr 2 2021

durin42 added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

It looks superficially correct - I didn't give it a detailed
inspection, but I trust you and Valentin on this.

Apr 2 2021, 1:21 AM

Mar 30 2021

D9465: node: replace nullid and friends with nodeconstants class now requires changes to proceed.

Fails tests, eg:

--- tests/test-push-checkheads-unpushed-D7.t
+++ tests/test-push-checkheads-unpushed-D7.t.err
@@ -65,27 +65,16 @@
   $ mkcommit C0
   created new head
   $ hg debugobsolete `getid "desc(A0)"` `getid "desc(A1)"`
-  1 new obsolescence markers
-  obsoleted 1 changesets
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
   $ hg debugobsolete `getid "desc(A1)"` `getid "desc(A2)"`
-  1 new obsolescence markers
-  obsoleted 1 changesets
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
   $ hg debugobsolete --record-parents `getid "desc(A2)"`
-  1 new obsolescence markers
-  obsoleted 1 changesets
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
   $ hg log -G --hidden
-  @  0f88766e02d6 (draft): C0
-  |
-  | x  c1f8d089020f (draft): A2
-  |/
-  | x  ba93660aff8d (draft): A1
-  | |
-  | o  74ff5441d343 (draft): B0
-  |/
-  | x  8aaa48160adc (draft): A0
-  |/
-  o  1e4be0697311 (public): root
-
+  abort: cannot import name 'noderev' from 'mercurial.node' (/tmp/hgtests.5j0okzgk/install/lib/python/mercurial/node.py)
+  [255]
Mar 30 2021, 4:22 PM

Mar 29 2021

durin42 added a comment to D10288: simplemerge: simplify.

I hate to be That Guy but can you replace "simplify" in all these with some boilerplate about "compare revs and not ids because $REASON"? otherwise some enthusiastic architecture astronaut (probably me) is going to come back in the not-too-distant future and make it more generic and phrase things in terms of nodes rather than IDs.

Mar 29 2021, 3:32 PM
durin42 added a comment to D10283: copies: simplify.

So, I've gone through several of these now, and I realize: why are we moving towards revs and away from nodes? That's the opposite of the refactor I'd expect...

Mar 29 2021, 3:29 PM

Mar 25 2021

durin42 added a comment to D10265: path: error out if the `path://` reference point to an unknown path.

Landing this chain, but it'd be good to see some documentation for it show up soon.

Mar 25 2021, 5:12 PM

Mar 17 2021

D10149: commit: get info from mergestate whether a file was merged or not now requires changes to proceed.

Needs rebased.

Mar 17 2021, 1:44 PM
durin42 closed D10185: black: merge config into main pyproject.toml now that we have it.
Mar 17 2021, 10:42 AM
durin42 closed D10184: pyproject: add config file.
Mar 17 2021, 10:42 AM
durin42 committed rHGdecc3bd3f20d: black: merge config into main pyproject.toml now that we have it.
black: merge config into main pyproject.toml now that we have it
Mar 17 2021, 10:42 AM
durin42 committed rHGd13afdd1f6e2: pyproject: add config file.
pyproject: add config file
Mar 17 2021, 10:42 AM

Mar 16 2021

D9750: node: introduce nodeconstants class now requires changes to proceed.

Fair enough. This is ready, but needs rebased.

Mar 16 2021, 5:52 PM
D10160: push: indent the some part of the command now requires changes to proceed.

I'm sorry to report this needs rebased

Mar 16 2021, 5:50 PM

Mar 12 2021

durin42 created D10185: black: merge config into main pyproject.toml now that we have it.
Mar 12 2021, 1:20 PM
durin42 created D10184: pyproject: add config file.
Mar 12 2021, 1:20 PM
durin42 committed rHG6f4a481f182a: merge: with stable.
merge: with stable
Mar 12 2021, 1:18 PM

Feb 27 2021

durin42 committed rHG25b1610f8534: fuzz: if the caller of our makefile sets CC and CXX, trust them.
fuzz: if the caller of our makefile sets CC and CXX, trust them
Feb 27 2021, 1:31 PM
durin42 closed D10066: fuzz: if the caller of our makefile sets CC and CXX, trust them.
Feb 27 2021, 1:31 PM

Feb 24 2021

durin42 created D10066: fuzz: if the caller of our makefile sets CC and CXX, trust them.
Feb 24 2021, 12:41 PM
D9843: revlog: introduce v2 format now requires changes to proceed.

(marking as request changes in that case)

Feb 24 2021, 11:21 AM
durin42 added inline comments to D9843: revlog: introduce v2 format.
Feb 24 2021, 11:17 AM
durin42 added a comment to D9950: ci: test real dependency installation for pip.

I suspect this test works without network if setuptools is already installed, but I don't care enough to block it on that pedantry.

Feb 24 2021, 11:04 AM
durin42 added a comment to D10020: debian: support a "chg-first" installation mechanism (hg is actually chg).

AFAICT this should be fine, but I'll give Yuya a while to catch problems.

Feb 24 2021, 11:01 AM

Feb 11 2021

durin42 added a comment to D9918: config: test priority involving alias.

I'm still confused here.

Feb 11 2021, 11:57 AM
D9918: config: test priority involving alias now requires changes to proceed.

This still requires changes to resolve my comments.

Feb 11 2021, 11:25 AM
D9982: hooks: add a `auto` value for `hooks.*run-with-plain` is now accepted and ready to land.

I'm not happy about this footgun option, but see why we need it.

Feb 11 2021, 11:08 AM

Feb 2 2021

durin42 committed rHGd6e73351533b: branching: merge with stable.
branching: merge with stable
Feb 2 2021, 1:33 PM
D9918: config: test priority involving alias now requires changes to proceed.
Feb 2 2021, 11:50 AM

Feb 1 2021

durin42 committed rHG6b847757dd8d: relnotes: add entry for `hg diff --merge -c`.
relnotes: add entry for `hg diff --merge -c`
Feb 1 2021, 5:52 PM
durin42 closed D9944: relnotes: add entry for `hg diff --merge -c`.
Feb 1 2021, 5:52 PM
durin42 created D9944: relnotes: add entry for `hg diff --merge -c`.
Feb 1 2021, 5:13 PM
durin42 closed D8504: diff: add experimental support for "merge diffs".
Feb 1 2021, 12:51 PM
durin42 closed D9939: diff: suppress `merging foo` output lines when performing a merge diff.
Feb 1 2021, 12:51 PM
durin42 committed rHG62a0b5daa15f: diff: suppress `merging foo` output lines when performing a merge diff.
diff: suppress `merging foo` output lines when performing a merge diff
Feb 1 2021, 12:50 PM
durin42 committed rHG1a7d12c82057: diff: add experimental support for "merge diffs".
diff: add experimental support for "merge diffs"
Feb 1 2021, 12:50 PM
durin42 updated the diff for D8504: diff: add experimental support for "merge diffs".
Feb 1 2021, 12:02 PM
durin42 created D9939: diff: suppress `merging foo` output lines when performing a merge diff.
Feb 1 2021, 12:02 PM

Jan 29 2021

durin42 closed D9908: context: add missing manifest invalidation after write in overlayworkingctx.
Jan 29 2021, 1:30 PM
durin42 committed rHGbc3f3b59d0a4: context: add missing manifest invalidation after write in overlayworkingctx.
context: add missing manifest invalidation after write in overlayworkingctx
Jan 29 2021, 1:30 PM
durin42 updated the summary of D8504: diff: add experimental support for "merge diffs".
Jan 29 2021, 1:07 PM
durin42 updated the diff for D8504: diff: add experimental support for "merge diffs".
Jan 29 2021, 12:58 PM
durin42 created D9908: context: add missing manifest invalidation after write in overlayworkingctx.
Jan 29 2021, 12:57 PM

Jan 28 2021

durin42 added a comment to D9833: pyproject: add config file.

I'm honestly baffled, and don't really have time to take a look. Probably back this and its child out, and we'll roll it forward again after we drop py2?

Jan 28 2021, 1:15 PM

Jan 27 2021

durin42 committed rHG11ce2977572f: histedit: rip out mysterious catch-all ignore curses.error handler.
histedit: rip out mysterious catch-all ignore curses.error handler
Jan 27 2021, 6:21 PM
durin42 committed rHGa936e570288d: histedit: notice when the main window underflows height and abort.
histedit: notice when the main window underflows height and abort
Jan 27 2021, 6:21 PM
durin42 committed rHG8477c91b5e8e: histedit: don't assign to _ for unused values.
histedit: don't assign to _ for unused values
Jan 27 2021, 6:21 PM
durin42 closed D9854: histedit: notice when the main window underflows height and abort.
Jan 27 2021, 8:14 AM
durin42 closed D9855: histedit: rip out mysterious catch-all ignore curses.error handler.
Jan 27 2021, 8:14 AM
durin42 closed D9853: histedit: don't assign to _ for unused values.
Jan 27 2021, 8:14 AM
durin42 committed rHG1f8aa372f430: histedit: rip out mysterious catch-all ignore curses.error handler.
histedit: rip out mysterious catch-all ignore curses.error handler
Jan 27 2021, 8:13 AM
durin42 committed rHG94247310d2e6: histedit: notice when the main window underflows height and abort.
histedit: notice when the main window underflows height and abort
Jan 27 2021, 8:13 AM
durin42 committed rHGfe14325ee0a2: histedit: don't assign to _ for unused values.
histedit: don't assign to _ for unused values
Jan 27 2021, 8:13 AM

Jan 26 2021

durin42 closed D9834: black: merge config into main pyproject.toml now that we have it.
Jan 26 2021, 1:17 AM
durin42 closed D9833: pyproject: add config file.
Jan 26 2021, 1:17 AM
durin42 committed rHGd4c8b4b90ecb: black: merge config into main pyproject.toml now that we have it.
black: merge config into main pyproject.toml now that we have it
Jan 26 2021, 1:17 AM
durin42 committed rHG45afff0f530a: pyproject: add config file.
pyproject: add config file
Jan 26 2021, 1:17 AM

Jan 22 2021

durin42 added a comment to D9825: cext: add Python 3.10 support.

Do you think we should go ahead and apply the local patch then until we can update the vendored copy?

Jan 22 2021, 9:08 PM
durin42 created D9855: histedit: rip out mysterious catch-all ignore curses.error handler.
Jan 22 2021, 3:46 PM
durin42 created D9854: histedit: notice when the main window underflows height and abort.
Jan 22 2021, 3:46 PM
durin42 created D9853: histedit: don't assign to _ for unused values.
Jan 22 2021, 3:46 PM
durin42 added a comment to D9848: fastexport: committer name should not be quoted.

Should we add a test that, if git-fast-import is available, actually tries the import and verifies that things look reasonable?

Jan 22 2021, 2:55 PM
D9825: cext: add Python 3.10 support now requires changes to proceed.

Yes, please remove the python-zstandard changes from here, and send them directly to @indygreg upstream for that.

Jan 22 2021, 2:54 PM

Jan 21 2021

durin42 closed D8566: cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved())).
Jan 21 2021, 7:26 AM
durin42 closed D8623: rebase: add a config knob for forcing in-memory rebasing.
Jan 21 2021, 7:25 AM
durin42 closed D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
Jan 21 2021, 7:24 AM
durin42 committed rHG63dfaca9087f: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
filemerge: add a hacktastic version of internal:merge3 for merge diffs
Jan 21 2021, 7:24 AM
durin42 committed rHG24a32dea6955: rebase: add a config knob for forcing in-memory rebasing.
rebase: add a config knob for forcing in-memory rebasing
Jan 21 2021, 7:24 AM
durin42 committed rHGdfca84970da8: cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved())).
cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved()))
Jan 21 2021, 7:24 AM

Jan 20 2021

durin42 added a comment to D9516: perf: use the `perf--` prefix for perf command.

I'm fine with this as-is, but I am sympathetic to the concern that the -- looks like a mistake. If we want to change it we can, since we've got a full release cycle ahead of us before this is binding.

Jan 20 2021, 1:14 PM

Jan 19 2021

durin42 added a comment to D9721: convert: option to set date and time for svn commits.

Ping someone else please - I'm busy with other things this week. :(

Jan 19 2021, 2:12 PM
durin42 updated the diff for D8504: diff: add experimental support for "merge diffs".
Jan 19 2021, 1:56 PM
durin42 planned changes to D8504: diff: add experimental support for "merge diffs".
Jan 19 2021, 1:55 PM
durin42 planned changes to D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
Jan 19 2021, 1:55 PM
durin42 updated the diff for D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
Jan 19 2021, 1:54 PM
D8566: cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved())) is now accepted and ready to land.
Jan 19 2021, 1:54 PM
durin42 updated the diff for D8623: rebase: add a config knob for forcing in-memory rebasing.
Jan 19 2021, 1:53 PM
durin42 abandoned D8564: fakemergerecord: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8563: localrepo: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8562: shelve: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8626: memctx: add mergestate method.
Jan 19 2021, 1:50 PM
durin42 abandoned D8561: hg: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8559: revset: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8558: fileset: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8557: debugcommands: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8556: commands: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8555: cmdutil: get mergestate via context.
Jan 19 2021, 1:50 PM
durin42 abandoned D8553: histedit: use context to load mergestate instead of loading it directly.
Jan 19 2021, 1:50 PM
durin42 abandoned D8552: fix: use context to fetch mergestate instead of loading it directly.
Jan 19 2021, 1:50 PM
durin42 created D9834: black: merge config into main pyproject.toml now that we have it.
Jan 19 2021, 1:03 PM
durin42 created D9833: pyproject: add config file.
Jan 19 2021, 1:03 PM
durin42 committed rHG3b1c0c367606: merge with stable.
merge with stable
Jan 19 2021, 12:24 PM