Page MenuHomePhabricator

durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (170 w, 4 d)

Recent Activity

Tue, Sep 22

durin42 committed rHGe7587430ca23: git: also convert timezone to int (issue6359).
git: also convert timezone to int (issue6359)
Tue, Sep 22, 10:24 PM
durin42 closed D9062: git: also convert timezone to int (issue6359).
Tue, Sep 22, 10:24 PM
durin42 added a comment to D9068: git: pass `id` attribute of `pygit2.Tree` object.

All tests are passing for me under python3, including with this patch. Pushed, thanks!

Tue, Sep 22, 1:19 PM

Mon, Sep 21

durin42 committed rHG93a0f3ba36bb: merge with stable.
merge with stable
Mon, Sep 21, 3:13 PM
durin42 created D9062: git: also convert timezone to int (issue6359).
Mon, Sep 21, 10:23 AM

Fri, Sep 18

durin42 committed rHGe3df1f560d9a: merge with stable.
merge with stable
Fri, Sep 18, 10:49 AM

Fri, Sep 11

durin42 committed rHG81b4e7c866ec: hgdemandimport: bypass demandimport for _ast module (issue6407).
hgdemandimport: bypass demandimport for _ast module (issue6407)
Fri, Sep 11, 3:21 AM

Thu, Sep 10

durin42 committed rHG0d7ec06c1cde: hgdemandimport: bypass demandimport for _ast module (issue6407).
hgdemandimport: bypass demandimport for _ast module (issue6407)
Thu, Sep 10, 7:34 AM
durin42 closed D9004: hgdemandimport: bypass demandimport for _ast module (issue6407).
Thu, Sep 10, 7:34 AM

Wed, Sep 9

durin42 committed rHGd4cf80341589: git: fix index handling of removed files during commit (issue6398).
git: fix index handling of removed files during commit (issue6398)
Wed, Sep 9, 10:13 PM
durin42 committed rHG601e3658216d: git: make dirstate actually support listclean parameter.
git: make dirstate actually support listclean parameter
Wed, Sep 9, 10:13 PM
durin42 committed rHG0c6b2cc9a7bb: git: make dirstate status() respect matcher.
git: make dirstate status() respect matcher
Wed, Sep 9, 10:13 PM
durin42 committed rHGc67529569643: git: fix up dirstate use of index.
git: fix up dirstate use of index
Wed, Sep 9, 10:13 PM
durin42 committed rHG6739ef7c5fcf: git: correctly handle "nothing changed" commits.
git: correctly handle "nothing changed" commits
Wed, Sep 9, 10:13 PM
durin42 committed rHG4111954cf86d: localrepo: use functools.wraps() in unfilteredmethod decorator.
localrepo: use functools.wraps() in unfilteredmethod decorator
Wed, Sep 9, 10:13 PM
durin42 committed rHGc8695439d7e3: git: actually copy treemanifest instances in .copy() (issue6398).
git: actually copy treemanifest instances in .copy() (issue6398)
Wed, Sep 9, 10:13 PM
durin42 created D9004: hgdemandimport: bypass demandimport for _ast module (issue6407).
Wed, Sep 9, 2:49 PM

Tue, Sep 8

durin42 closed D8994: localrepo: use functools.wraps() in unfilteredmethod decorator.
Tue, Sep 8, 8:08 AM
durin42 closed D8999: git: fix index handling of removed files during commit (issue6398).
Tue, Sep 8, 8:08 AM
durin42 committed rHG8e997c5da2f3: git: fix index handling of removed files during commit (issue6398).
git: fix index handling of removed files during commit (issue6398)
Tue, Sep 8, 8:07 AM
durin42 closed D8998: git: make dirstate actually support listclean parameter.
Tue, Sep 8, 8:07 AM
durin42 committed rHGb30c182e7c07: git: make dirstate actually support listclean parameter.
git: make dirstate actually support listclean parameter
Tue, Sep 8, 8:07 AM
durin42 closed D8997: git: make dirstate status() respect matcher.
Tue, Sep 8, 8:07 AM
durin42 committed rHGabb6feb38447: git: make dirstate status() respect matcher.
git: make dirstate status() respect matcher
Tue, Sep 8, 8:07 AM
durin42 closed D8996: git: fix up dirstate use of index.
Tue, Sep 8, 8:07 AM
durin42 closed D8995: git: correctly handle "nothing changed" commits.
Tue, Sep 8, 8:07 AM
durin42 committed rHG40495fda2644: git: fix up dirstate use of index.
git: fix up dirstate use of index
Tue, Sep 8, 8:07 AM
durin42 committed rHG2ac71a12676e: git: correctly handle "nothing changed" commits.
git: correctly handle "nothing changed" commits
Tue, Sep 8, 8:07 AM
durin42 committed rHG98baadff2b1c: localrepo: use functools.wraps() in unfilteredmethod decorator.
localrepo: use functools.wraps() in unfilteredmethod decorator
Tue, Sep 8, 8:07 AM
durin42 closed D8993: git: actually copy treemanifest instances in .copy() (issue6398).
Tue, Sep 8, 8:07 AM
durin42 closed D8992: git: restore basic functionality after b3040b6739ce.
Tue, Sep 8, 8:07 AM
durin42 committed rHG7e0919a9bdb7: git: actually copy treemanifest instances in .copy() (issue6398).
git: actually copy treemanifest instances in .copy() (issue6398)
Tue, Sep 8, 8:07 AM
durin42 committed rHG66a10bd1b8db: git: restore basic functionality after b3040b6739ce.
git: restore basic functionality after b3040b6739ce
Tue, Sep 8, 8:07 AM
durin42 committed rHG8ddbb75bad09: git: convert tz offset to int (issue6359).
git: convert tz offset to int (issue6359)
Tue, Sep 8, 8:07 AM
durin42 closed D8991: git: convert tz offset to int (issue6359).
Tue, Sep 8, 8:07 AM

Mon, Sep 7

durin42 created D8999: git: fix index handling of removed files during commit (issue6398).
Mon, Sep 7, 5:31 PM
durin42 created D8998: git: make dirstate actually support listclean parameter.
Mon, Sep 7, 5:31 PM
durin42 created D8994: localrepo: use functools.wraps() in unfilteredmethod decorator.
Mon, Sep 7, 5:31 PM
durin42 created D8997: git: make dirstate status() respect matcher.
Mon, Sep 7, 5:31 PM
durin42 created D8996: git: fix up dirstate use of index.
Mon, Sep 7, 5:31 PM
durin42 created D8995: git: correctly handle "nothing changed" commits.
Mon, Sep 7, 5:31 PM
durin42 created D8993: git: actually copy treemanifest instances in .copy() (issue6398).
Mon, Sep 7, 5:30 PM
durin42 created D8992: git: restore basic functionality after b3040b6739ce.
Mon, Sep 7, 5:30 PM
durin42 created D8991: git: convert tz offset to int (issue6359).
Mon, Sep 7, 5:30 PM
durin42 committed rHGa42999f611ff: merge with stable.
merge with stable
Mon, Sep 7, 3:41 PM

Wed, Sep 2

durin42 committed rHG148d177a4f2d: genosxversion: don't give up if we can't find a path to hg libraries.
genosxversion: don't give up if we can't find a path to hg libraries
Wed, Sep 2, 12:01 PM
durin42 closed D8975: genosxversion: don't give up if we can't find a path to hg libraries.
Wed, Sep 2, 12:01 PM

Tue, Sep 1

durin42 created D8975: genosxversion: don't give up if we can't find a path to hg libraries.
Tue, Sep 1, 10:34 AM
durin42 committed rHGe666f601b3ea: merge with stable.
merge with stable
Tue, Sep 1, 9:57 AM

Aug 8 2020

durin42 added a comment to D8552: fix: use context to fetch mergestate instead of loading it directly.

This is stalled. I've got some bugs in the logic I can't track down and
this is second on my priority list at work. I do intend to come back to it,
but it'd be fair to mark it all as changes requested.

Aug 8 2020, 4:00 PM

Aug 5 2020

durin42 committed rHGfa18b02df8dd: merge with stable.
merge with stable
Aug 5 2020, 1:41 PM

Jul 22 2020

durin42 committed rHG4b923da0cb86: merge with stable.
merge with stable
Jul 22 2020, 10:14 PM

Jul 17 2020

D8700: commitctx: document a fast path in _filecommit now requires changes to proceed.
Jul 17 2020, 4:45 PM
durin42 closed D8353: debugcommands: create new debugantivirusrunning command.
Jul 17 2020, 2:07 PM
durin42 committed rHG87047efbc6a6: debugcommands: create new debugantivirusrunning command.
debugcommands: create new debugantivirusrunning command
Jul 17 2020, 2:04 PM

Jul 15 2020

durin42 committed rHGde1d3f4246e9: merge with stable.
merge with stable
Jul 15 2020, 12:11 PM
durin42 added a comment to D8680: rhg: fix test-rhg.t code style.

Seems to need rebased?

Jul 15 2020, 12:06 PM
durin42 added a comment to D8656: localrepo: load the share source .hg/hgrc also in share-safe mode (API).

Something in this stack (that I didn't push) breaks the phabricator extension. See phabricator.py line 170:

@eh.wrapfunction(localrepo, "loadhgrc")
def _loadhgrc(orig, ui, wdirvfs, hgvfs, requirements):

So you'll need to do....something there. Maybe look for other wrappers in extensions too while you're there...

Jul 15 2020, 11:44 AM
D8698: phases: sparsify phaseroots and phasesets is now accepted and ready to land.
Jul 15 2020, 11:28 AM
durin42 added a comment to D8745: config: add option to control creation of empty successors during rewrite.

I queued a mailing list version of this series. Should I drop it?

Jul 15 2020, 11:10 AM

Jul 13 2020

durin42 committed rHG3a6ec080b521: merge with stable.
merge with stable
Jul 13 2020, 1:08 PM

Jul 8 2020

durin42 added a comment to D8712: black: format some files in preparation for subsequent changes.

Yeah, if you’re seeing these changes I’m pretty sure you have a too-old black...

Jul 8 2020, 10:25 PM

Jul 7 2020

durin42 added a comment to D8691: hg: allow usage of XDG_CONFIG_HOME/hg/hgrc on OSX.

Thanks for the prompt review.

(If anything, ~/Library/Preferences/org.mercurial-scm.hgrc might make sense, but that seems silly to me.)

I agree that ~/Library/Preferences would be the default XDG analogy in macOS. However, the patch was more motivated by relocating the configuration file.
Am I to understand that setting HGRCPATH is the preferred approach for relocating hgrc on macOS?

Jul 7 2020, 5:39 PM
D8691: hg: allow usage of XDG_CONFIG_HOME/hg/hgrc on OSX now requires changes to proceed.

Yes: XDG isn't a thing on macOS, and we won't respect it there. Perhaps the help text should be improved instead.

Jul 7 2020, 2:22 PM

Jul 6 2020

durin42 committed rHGdd3050227a84: merge with stable.
merge with stable
Jul 6 2020, 10:04 PM

Jul 1 2020

durin42 committed rHGdf3660cc60f5: merge with stable.
merge with stable
Jul 1 2020, 2:31 PM
D8670: repoview: use the phasecache directly to determine mutable revisions now requires changes to proceed.

LGTM, but needs rebased.

Jul 1 2020, 2:29 PM

Jun 26 2020

durin42 committed rHG05277278f177: merge with stable.
merge with stable
Jun 26 2020, 11:25 AM

Jun 25 2020

durin42 added a comment to D8666: locks: expect repo lock, not wlock, when writing to .hg/strip-backup/.

My feelings on this are "obviously yes" but I thought that so quickly I lack confidence that I'm not missing something. :)

Jun 25 2020, 3:34 PM
durin42 added a comment to D8645: clonebundles: optional memory-requirement attribution.

I'm a fan of this, but for default, not stable. Is there a specific reason you need a new feature on the stable branch?

Jun 25 2020, 1:30 PM

Jun 22 2020

durin42 added inline comments to D8640: ui: add option to timestamp status and diagnostic messages.
Jun 22 2020, 9:25 AM
durin42 committed rHG0ff59434af72: fuzz: tell manifest fuzzer about longer node hashes.
fuzz: tell manifest fuzzer about longer node hashes
Jun 22 2020, 6:21 AM

Jun 17 2020

durin42 closed D8374: fuzz: tell manifest fuzzer about longer node hashes.
Jun 17 2020, 2:53 PM
durin42 committed rHG9bedcfb4bb0e: fuzz: tell manifest fuzzer about longer node hashes.
fuzz: tell manifest fuzzer about longer node hashes
Jun 17 2020, 2:53 PM
durin42 added a comment to D8374: fuzz: tell manifest fuzzer about longer node hashes.

This is still valid.

Jun 17 2020, 11:01 AM

Jun 16 2020

D8634: hg-core: commit forgotten Cargo.lock now requires changes to proceed.

Doesn't apply?

Jun 16 2020, 5:19 PM

Jun 15 2020

durin42 committed rHGef8dcee272ac: fuzz: add config knob for PYTHON_CONFIG_FLAGS.
fuzz: add config knob for PYTHON_CONFIG_FLAGS
Jun 15 2020, 4:07 PM
durin42 closed D8637: fuzz: add config knob for PYTHON_CONFIG_FLAGS.
Jun 15 2020, 4:07 PM
durin42 closed D8636: pyutil: this has taken so long to fix, I'm using 3.8 now.
Jun 15 2020, 4:07 PM
durin42 committed rHGee5f27d7b9fb: pyutil: this has taken so long to fix, I'm using 3.8 now.
pyutil: this has taken so long to fix, I'm using 3.8 now
Jun 15 2020, 4:07 PM
durin42 created D8636: pyutil: this has taken so long to fix, I'm using 3.8 now.
Jun 15 2020, 3:30 PM
durin42 created D8637: fuzz: add config knob for PYTHON_CONFIG_FLAGS.
Jun 15 2020, 3:30 PM
durin42 committed rHG78cafd48b9b2: merge with stable.
merge with stable
Jun 15 2020, 1:04 PM

Jun 11 2020

durin42 updated the diff for D8624: wip: this does not help but seems less wrong.
Jun 11 2020, 3:46 PM
durin42 updated the diff for D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
Jun 11 2020, 3:46 PM
durin42 updated the diff for D8567: mergestate: implement trivial in-memory mergestate.
Jun 11 2020, 3:46 PM
durin42 added a comment to D8563: localrepo: get mergestate via context.

Okay, now localrepo correctly uses the same context across whole operations. This almost certainly avoids some bugs, given that committing a memctx was (surprise!) reading the mergestate from disk.

Jun 11 2020, 1:06 PM
durin42 updated the diff for D8563: localrepo: get mergestate via context.
Jun 11 2020, 1:04 PM
durin42 updated the diff for D8624: wip: this does not help but seems less wrong.
Jun 11 2020, 1:04 PM
durin42 updated the diff for D8568: overlayworkingctx: implement mergestate() using in-memory mergestate.
Jun 11 2020, 1:04 PM
durin42 created D8626: memctx: add mergestate method.
Jun 11 2020, 1:04 PM
durin42 updated the diff for D8567: mergestate: implement trivial in-memory mergestate.
Jun 11 2020, 1:04 PM
durin42 updated the diff for D8566: cleanup: use mergestate.unresolvedcount() instead of bool(list(unresolved())).
Jun 11 2020, 12:09 PM
durin42 retitled D8623: rebase: add a config knob for forcing in-memory rebasing from rebase: add environment variable to allow forcing in-memory rebase to rebase: add a config knob for forcing in-memory rebasing.
Jun 11 2020, 12:08 PM
durin42 updated the diff for D8624: wip: this does not help but seems less wrong.
Jun 11 2020, 12:08 PM
durin42 updated the diff for D8572: merge: remove special case for in-memory merge.
Jun 11 2020, 12:08 PM
durin42 updated the diff for D8515: filemerge: add a hacktastic version of internal:merge3 for merge diffs.
Jun 11 2020, 12:08 PM
durin42 updated the diff for D8569: merge: get mergestate from context instead of directly.
Jun 11 2020, 12:08 PM
durin42 updated the diff for D8568: overlayworkingctx: implement mergestate() using in-memory mergestate.
Jun 11 2020, 12:08 PM
durin42 updated the diff for D8563: localrepo: get mergestate via context.
Jun 11 2020, 12:08 PM