durin42 (Augie Fackler)
User

Projects

User Details

User Since
Jun 23 2017, 4:23 PM (95 w, 5 d)

Recent Activity

Tue, Apr 23

durin42 committed rHG7c0ece3cd3ee: merge with stable.
merge with stable
Tue, Apr 23, 3:51 PM

Wed, Apr 17

durin42 added a comment to D6258: packaging: coerce paths to strings.

Argh. This change appears to be wrong (!) so I'm going to drop it.

Eh? I don't see anything wrong with this. Casting a pathlib.Path to str should just work! In fact, it is necessary for older Python 3, as there was a long tail of stdlib functions that didn't accept pathlib.* when those types were first introduced. I believe 3.7 was the first release that fixed them all.

Wed, Apr 17, 2:44 PM
durin42 committed rHG84b5ad5fc2aa: merge: forgot to pull before release.
merge: forgot to pull before release
Wed, Apr 17, 2:10 PM
durin42 committed rHG4a8d9ed86475: merge: default into stable for release candidate.
merge: default into stable for release candidate
Wed, Apr 17, 2:00 PM
durin42 committed rHGe76eb64d7f71: Added signature for changeset 4a8d9ed86475.
Added signature for changeset 4a8d9ed86475
Wed, Apr 17, 1:59 PM
durin42 committed rHG807a6ca6d096: Added tag 5.0rc0 for changeset 4a8d9ed86475.
Added tag 5.0rc0 for changeset 4a8d9ed86475
Wed, Apr 17, 1:59 PM

Tue, Apr 16

durin42 added a comment to D6258: packaging: coerce paths to strings.

Argh. This change appears to be wrong (!) so I'm going to drop it.

Tue, Apr 16, 7:44 PM
durin42 committed rHG69b4426d288b: packaging: coerce paths to strings.
packaging: coerce paths to strings
Tue, Apr 16, 6:46 PM
durin42 closed D6258: packaging: coerce paths to strings.
Tue, Apr 16, 6:46 PM
durin42 created D6258: packaging: coerce paths to strings.
Tue, Apr 16, 5:55 PM
durin42 added a comment to D6182: bundle2: handle compression in _forwardchunks.

Ugh I'm sorry - I evidently reviewed this and never pushed submit. :(

Tue, Apr 16, 1:17 PM

Fri, Apr 12

durin42 closed D6226: rebase: fix bug that prevented dry-run rebases from printing failures.
Fri, Apr 12, 1:28 PM
durin42 committed rHG1b5cec8b6a1e: rebase: fix bug that prevented dry-run rebases from printing failures.
rebase: fix bug that prevented dry-run rebases from printing failures
Fri, Apr 12, 1:28 PM
durin42 closed D6225: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported.
Fri, Apr 12, 1:28 PM
durin42 committed rHG8890fce7c13d: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported.
rebase: demonstrate bug in dry-run mode which causes cycles to not be reported
Fri, Apr 12, 1:28 PM
durin42 created D6226: rebase: fix bug that prevented dry-run rebases from printing failures.
Fri, Apr 12, 12:08 PM
durin42 added a dependent revision for D6225: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported: D6226: rebase: fix bug that prevented dry-run rebases from printing failures.
Fri, Apr 12, 12:07 PM
durin42 created D6225: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported.
Fri, Apr 12, 12:07 PM

Thu, Apr 11

durin42 updated subscribers of D6167: fix: allow fixer tools to return metadata in addition to the file content.

@lothiraldan do y'all have opinions on this? I'd love to see this get landed.

Thu, Apr 11, 1:35 PM

Mon, Apr 8

durin42 closed D6217: remotefilelog: correctly reject wdir filenodes.
Mon, Apr 8, 6:09 PM
durin42 closed D6216: remotefilelog: add tests of `hg grep -r 'wdir()'`.
Mon, Apr 8, 6:09 PM
durin42 committed rHG864f9f63d3ed: remotefilelog: correctly reject wdir filenodes.
remotefilelog: correctly reject wdir filenodes
Mon, Apr 8, 6:09 PM
durin42 committed rHGb1b216a241cc: remotefilelog: add tests of `hg grep -r 'wdir()'`.
remotefilelog: add tests of `hg grep -r 'wdir()'`
Mon, Apr 8, 6:09 PM
durin42 created D6217: remotefilelog: correctly reject wdir filenodes.
Mon, Apr 8, 11:00 AM
durin42 added a dependent revision for D6216: remotefilelog: add tests of `hg grep -r 'wdir()'`: D6217: remotefilelog: correctly reject wdir filenodes.
Mon, Apr 8, 10:59 AM
durin42 created D6216: remotefilelog: add tests of `hg grep -r 'wdir()'`.
Mon, Apr 8, 10:59 AM

Wed, Apr 3

durin42 closed D6189: py2exe: add workaround to allow bundling of hgext3rd.* extensions.
Wed, Apr 3, 7:08 PM
durin42 closed D6187: wix: fix the package build when not adding features.
Wed, Apr 3, 7:07 PM
durin42 committed rHG399ed3e86a49: py2exe: add workaround to allow bundling of hgext3rd.* extensions.
py2exe: add workaround to allow bundling of hgext3rd.* extensions
Wed, Apr 3, 7:07 PM
durin42 committed rHG429bed755ce1: wix: fix the package build when not adding features.
wix: fix the package build when not adding features
Wed, Apr 3, 7:07 PM
durin42 created D6189: py2exe: add workaround to allow bundling of hgext3rd.* extensions.
Wed, Apr 3, 11:53 AM
durin42 added a dependent revision for D6187: wix: fix the package build when not adding features: D6189: py2exe: add workaround to allow bundling of hgext3rd.* extensions.
Wed, Apr 3, 11:52 AM
durin42 created D6187: wix: fix the package build when not adding features.
Wed, Apr 3, 12:05 AM

Tue, Apr 2

durin42 closed D6180: wix: add functionality to inject additional Features into installer.
Tue, Apr 2, 4:30 PM
durin42 committed rHG1711f5813a63: wix: add functionality to inject additional Features into installer.
wix: add functionality to inject additional Features into installer
Tue, Apr 2, 4:30 PM
durin42 committed rHG978b03d5f66e: wix: add support for additional wxs files.
wix: add support for additional wxs files
Tue, Apr 2, 4:30 PM
durin42 closed D6179: wix: add support for additional wxs files.
Tue, Apr 2, 4:30 PM
durin42 closed D6164: wix: add a hook for a prebuild script to inject extra libraries.
Tue, Apr 2, 4:28 PM
durin42 committed rHG715d3220ac4f: wix: add a hook for a prebuild script to inject extra libraries.
wix: add a hook for a prebuild script to inject extra libraries
Tue, Apr 2, 4:28 PM
durin42 updated the diff for D6180: wix: add functionality to inject additional Features into installer.
Tue, Apr 2, 3:44 PM
durin42 updated the diff for D6179: wix: add support for additional wxs files.
Tue, Apr 2, 3:43 PM
durin42 updated the diff for D6164: wix: add a hook for a prebuild script to inject extra libraries.
Tue, Apr 2, 3:43 PM
durin42 added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

I would prefer you fix them :)

Tue, Apr 2, 3:14 PM
durin42 added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

Was a newer version of this patch with the requested changes going to be uploaded? It's weird to see additional patches in the series without this one updated...

Tue, Apr 2, 1:59 PM
durin42 created D6180: wix: add functionality to inject additional Features into installer.
Tue, Apr 2, 10:33 AM
durin42 created D6179: wix: add support for additional wxs files.
Tue, Apr 2, 10:33 AM
durin42 added a dependent revision for D6179: wix: add support for additional wxs files: D6180: wix: add functionality to inject additional Features into installer.
Tue, Apr 2, 10:33 AM
durin42 added a dependent revision for D6164: wix: add a hook for a prebuild script to inject extra libraries: D6179: wix: add support for additional wxs files.
Tue, Apr 2, 10:32 AM

Wed, Mar 27

durin42 accepted D6167: fix: allow fixer tools to return metadata in addition to the file content.

I'm what I'll call an unenthusiastic fan of this: it feels a little gross, but I have no better ideas (in fact, at least part of this interface was my idea...) so I'd like to see this land as it'll open us up to carry fewer painful patches at Google.

Wed, Mar 27, 2:13 PM
durin42 closed D6170: perf: copyedit a few documentation strings.
Wed, Mar 27, 9:33 AM
durin42 committed rHG4c700c847aa2: perf: copyedit a few documentation strings.
perf: copyedit a few documentation strings
Wed, Mar 27, 9:32 AM

Mar 26 2019

durin42 created D6170: perf: copyedit a few documentation strings.
Mar 26 2019, 10:21 AM

Mar 25 2019

durin42 added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

How about we add an argument to define the path(s) to the pip requirements file(s) to use? By default, it can use the requirements.txt in the repo. Would that solve your use case?

No, because I have some stuff which (out of tragic necessity at the moment) isn't pip installable, and I have to install it into the virtualenv by banging some rocks together. :(

Bleh. So you do need the power of a full script here.

Mar 25 2019, 2:58 PM
durin42 added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

How about we add an argument to define the path(s) to the pip requirements file(s) to use? By default, it can use the requirements.txt in the repo. Would that solve your use case?

Mar 25 2019, 12:37 PM
durin42 added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

I like the flexibility. But I'm not super keen about the interface here. Using a script to inject custom options seems like it could be useful. But as it is currently implemented, the script simply prints out \0 delimited package names. So one UI wart is --extra-prebuild-script being a somewhat generic name but that script only emits package names. --extra-packages-script would be a better name.

Mar 25 2019, 12:09 PM

Mar 22 2019

durin42 updated subscribers of D6168: readline: provide styled prompt to readline (issue6070).

FYI @spectral I uploaded this.

Mar 22 2019, 11:07 AM
durin42 added a comment to D6168: readline: provide styled prompt to readline (issue6070).

This is Kyle's patch from https://bz.mercurial-scm.org/show_bug.cgi?id=6070 - it feels regrettable but necessary, and anecdotally it seems to work. I'd give it an LGTM stamp here, but I can't since I uploaded it.

Mar 22 2019, 11:07 AM
durin42 created D6168: readline: provide styled prompt to readline (issue6070).
Mar 22 2019, 11:06 AM

Mar 21 2019

durin42 created D6164: wix: add a hook for a prebuild script to inject extra libraries.
Mar 21 2019, 8:55 AM

Mar 19 2019

durin42 committed rHGd1c33b2442a7: Added signature for changeset 4ea21df312ec.
Added signature for changeset 4ea21df312ec
Mar 19 2019, 9:33 AM
durin42 committed rHG55834ace6f2d: Added tag 4.9.1 for changeset 4ea21df312ec.
Added tag 4.9.1 for changeset 4ea21df312ec
Mar 19 2019, 9:33 AM

Mar 6 2019

durin42 committed rHGe0384d4c51ae: cleanup: remove two bogus test names from python3 list.
cleanup: remove two bogus test names from python3 list
Mar 6 2019, 8:39 AM
durin42 closed D6076: cleanup: remove two bogus test names from python3 list.
Mar 6 2019, 8:39 AM

Mar 5 2019

durin42 created D6076: cleanup: remove two bogus test names from python3 list.
Mar 5 2019, 9:52 AM
durin42 committed rHG28842adf8ed5: hghave: skip emacs tests on 24.3 and earlier.
hghave: skip emacs tests on 24.3 and earlier
Mar 5 2019, 8:46 AM
durin42 closed D6074: hghave: skip emacs tests on 24.3 and earlier.
Mar 5 2019, 8:46 AM

Mar 4 2019

durin42 created D6074: hghave: skip emacs tests on 24.3 and earlier.
Mar 4 2019, 6:12 PM

Feb 24 2019

durin42 closed D6003: tests: add test for hg-test-mode emacs code.
Feb 24 2019, 8:38 PM
durin42 committed rHG19979b8b87e2: tests: add test for hg-test-mode emacs code.
tests: add test for hg-test-mode emacs code
Feb 24 2019, 8:38 PM
durin42 closed D6002: hghave: add check for GNU emacs.
Feb 24 2019, 8:38 PM
durin42 committed rHG2a6ca0d94b70: hghave: add check for GNU emacs.
hghave: add check for GNU emacs
Feb 24 2019, 8:38 PM
durin42 closed D6000: contrib: add compilation-mode linking for our test output.
Feb 24 2019, 8:38 PM
durin42 closed D6001: contrib: also linkify tracebacks in compilation output when using hg-test-mode.
Feb 24 2019, 8:38 PM
durin42 committed rHGb6c062bb4be3: contrib: also linkify tracebacks in compilation output when using hg-test-mode.
contrib: also linkify tracebacks in compilation output when using hg-test-mode
Feb 24 2019, 8:38 PM
durin42 committed rHGb6a757de2fff: contrib: add compilation-mode linking for our test output.
contrib: add compilation-mode linking for our test output
Feb 24 2019, 8:38 PM

Feb 21 2019

durin42 created D6003: tests: add test for hg-test-mode emacs code.
Feb 21 2019, 11:40 PM
durin42 added a dependent revision for D6002: hghave: add check for GNU emacs: D6003: tests: add test for hg-test-mode emacs code.
Feb 21 2019, 11:40 PM
durin42 created D6002: hghave: add check for GNU emacs.
Feb 21 2019, 11:40 PM
durin42 added a dependent revision for D6001: contrib: also linkify tracebacks in compilation output when using hg-test-mode: D6002: hghave: add check for GNU emacs.
Feb 21 2019, 11:40 PM
durin42 created D6001: contrib: also linkify tracebacks in compilation output when using hg-test-mode.
Feb 21 2019, 11:40 PM
durin42 added a dependent revision for D6000: contrib: add compilation-mode linking for our test output: D6001: contrib: also linkify tracebacks in compilation output when using hg-test-mode.
Feb 21 2019, 11:40 PM
durin42 created D6000: contrib: add compilation-mode linking for our test output.
Feb 21 2019, 11:40 PM
durin42 closed D5993: cleanup: use () to wrap long lines instead of \.
Feb 21 2019, 4:33 PM
durin42 closed D5994: cleanup: prefer nested context managers to \-continuations.
Feb 21 2019, 4:29 PM
durin42 committed rHGe2472b12c842: contrib: enforce wrapping too-long lines with () instead of \.
contrib: enforce wrapping too-long lines with () instead of \
Feb 21 2019, 4:29 PM
durin42 closed D5995: contrib: enforce wrapping too-long lines with () instead of \.
Feb 21 2019, 4:29 PM
durin42 closed D5992: tests: use () instead of \ to wrap lines.
Feb 21 2019, 4:29 PM
durin42 committed rHG1eb2fc21da12: cleanup: prefer nested context managers to \-continuations.
cleanup: prefer nested context managers to \-continuations
Feb 21 2019, 4:28 PM
durin42 committed rHGaaad36b88298: cleanup: use () to wrap long lines instead of \.
cleanup: use () to wrap long lines instead of \
Feb 21 2019, 4:28 PM
durin42 committed rHG15d3facfa40a: tests: use () instead of \ to wrap lines.
tests: use () instead of \ to wrap lines
Feb 21 2019, 4:28 PM
durin42 updated the diff for D5993: cleanup: use () to wrap long lines instead of \.
Feb 21 2019, 12:53 PM

Feb 20 2019

durin42 added a comment to D5994: cleanup: prefer nested context managers to \-continuations.

I'd prefer Python accept a tuple of context managers

I think I'd also prefer if our context managers didn't acquire the resource in __init__. That would let us write it with less indentation as:

wlock = wlock or util.nullcontextmanager()
lock = lock or util.nullcontextmanager()
trmanager = pushop.trmanager or util.nullcontextmanager()
with wlock, lock, trmanager:

(In this case we probably could do that anyway since we don't seem to worry about the risk of exceptions from the time we take the lock until we enter the context manager.)

I don't care much either way about the patch itself. I'll wait a little to see if someone else cares more, but otherwise I'll take.

Feb 20 2019, 7:46 PM
durin42 created D5993: cleanup: use () to wrap long lines instead of \.
Feb 20 2019, 7:38 PM
durin42 created D5994: cleanup: prefer nested context managers to \-continuations.
Feb 20 2019, 7:34 PM
durin42 created D5995: contrib: enforce wrapping too-long lines with () instead of \.
Feb 20 2019, 7:34 PM
durin42 added a dependent revision for D5994: cleanup: prefer nested context managers to \-continuations: D5995: contrib: enforce wrapping too-long lines with () instead of \.
Feb 20 2019, 7:34 PM
durin42 added a dependent revision for D5993: cleanup: use () to wrap long lines instead of \: D5994: cleanup: prefer nested context managers to \-continuations.
Feb 20 2019, 7:34 PM
durin42 created D5992: tests: use () instead of \ to wrap lines.
Feb 20 2019, 7:33 PM
durin42 added a dependent revision for D5992: tests: use () instead of \ to wrap lines: D5993: cleanup: use () to wrap long lines instead of \.
Feb 20 2019, 7:33 PM
durin42 requested changes to D5514: test: change test's diff generation to use mdiff for nicer output.

(moving this off the dashboard until it gets updated)

Feb 20 2019, 3:21 PM