Page MenuHomePhabricator

felixmerk (Felix Merk)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2017, 5:54 PM (253 w, 3 d)

Recent Activity

Aug 24 2017

felixmerk closed D502: undo: better error messaging and hiding hg serve commands by committing rFBHGXf332427aef2b: undo: better error messaging and hiding hg serve commands.
Aug 24 2017, 6:08 PM
felixmerk closed D504: undo: work better with chg by committing rFBHGXd8dc2f229646: undo: work better with chg.
Aug 24 2017, 6:08 PM
felixmerk committed rFBHGXd8dc2f229646: undo: work better with chg.
undo: work better with chg
Aug 24 2017, 6:08 PM
felixmerk committed rFBHGX244fb4fb3e70: interactiveui: disable line wrapping.
interactiveui: disable line wrapping
Aug 24 2017, 6:08 PM
felixmerk closed D503: interactiveui: disable line wrapping by committing rFBHGX244fb4fb3e70: interactiveui: disable line wrapping.
Aug 24 2017, 6:08 PM
felixmerk committed rFBHGXf332427aef2b: undo: better error messaging and hiding hg serve commands.
undo: better error messaging and hiding hg serve commands
Aug 24 2017, 6:07 PM
felixmerk created D504: undo: work better with chg.
Aug 24 2017, 4:14 PM
felixmerk updated the diff for D503: interactiveui: disable line wrapping.
Aug 24 2017, 3:58 PM
felixmerk created D503: interactiveui: disable line wrapping.
Aug 24 2017, 3:46 PM
felixmerk updated the diff for D502: undo: better error messaging and hiding hg serve commands.
Aug 24 2017, 3:26 PM
felixmerk created D502: undo: better error messaging and hiding hg serve commands.
Aug 24 2017, 2:35 PM
felixmerk committed rFBHGX2e9d42243608: undo: include ancestor in preview.
undo: include ancestor in preview
Aug 24 2017, 12:45 PM

Aug 22 2017

felixmerk closed D467: undo: preview change - just show delta by committing rFBHGXec24da696482: undo: preview change - just show delta.
Aug 22 2017, 10:21 PM
felixmerk committed rFBHGXec24da696482: undo: preview change - just show delta.
undo: preview change - just show delta
Aug 22 2017, 10:20 PM

Aug 21 2017

felixmerk updated the diff for D467: undo: preview change - just show delta.
Aug 21 2017, 9:45 PM
felixmerk added a comment to D467: undo: preview change - just show delta.

Aug 21 2017, 9:28 PM
felixmerk closed D465: interactivui: get rid of flashing by committing rFBHGX5a0f3c3c83b0: interactivui: get rid of flashing.
Aug 21 2017, 8:18 PM
felixmerk closed D463: undo: draft obsolete commits by committing rFBHGXa9cd7384aa69: undo: draft obsolete commits.
Aug 21 2017, 8:18 PM
felixmerk committed rFBHGX5a0f3c3c83b0: interactivui: get rid of flashing.
interactivui: get rid of flashing
Aug 21 2017, 8:18 PM
felixmerk closed D462: undo: preview perf improvements by committing rFBHGX2ed26f4a0c71: undo: preview perf improvements.
Aug 21 2017, 8:18 PM
felixmerk closed D448: undo: preview shows command and time output by committing rFBHGX5d49a9e813ae: undo: preview shows command and time output.
Aug 21 2017, 8:18 PM
felixmerk committed rFBHGXa9cd7384aa69: undo: draft obsolete commits.
undo: draft obsolete commits
Aug 21 2017, 8:18 PM
felixmerk closed D412: undo: informative output by committing rFBHGXfb0eda1a7127: undo: informative output.
Aug 21 2017, 8:18 PM
felixmerk committed rFBHGX2ed26f4a0c71: undo: preview perf improvements.
undo: preview perf improvements
Aug 21 2017, 8:18 PM
felixmerk committed rFBHGX5d49a9e813ae: undo: preview shows command and time output.
undo: preview shows command and time output
Aug 21 2017, 8:18 PM
felixmerk closed D438: undo: draft obsolete handling by committing rFBHGX4e9fbcd45642: undo: draft obsolete handling.
Aug 21 2017, 8:18 PM
felixmerk closed D410: undo: unfinished command handling by committing rFBHGXa6e1cbdde822: undo: unfinished command handling.
Aug 21 2017, 8:17 PM
felixmerk committed rFBHGX4e9fbcd45642: undo: draft obsolete handling.
undo: draft obsolete handling
Aug 21 2017, 8:17 PM
felixmerk committed rFBHGXfb0eda1a7127: undo: informative output.
undo: informative output
Aug 21 2017, 8:17 PM
felixmerk committed rFBHGXa6e1cbdde822: undo: unfinished command handling.
undo: unfinished command handling
Aug 21 2017, 8:17 PM
felixmerk created D467: undo: preview change - just show delta.
Aug 21 2017, 8:13 PM
felixmerk updated the diff for D462: undo: preview perf improvements.
Aug 21 2017, 4:28 PM
felixmerk created D465: interactivui: get rid of flashing.
Aug 21 2017, 4:07 PM
felixmerk created D463: undo: draft obsolete commits.
Aug 21 2017, 2:42 PM
felixmerk added inline comments to D448: undo: preview shows command and time output.
Aug 21 2017, 2:38 PM
felixmerk created D462: undo: preview perf improvements.
Aug 21 2017, 2:32 PM
felixmerk updated the diff for D448: undo: preview shows command and time output.
Aug 21 2017, 2:22 PM

Aug 18 2017

felixmerk updated the diff for D448: undo: preview shows command and time output.
Aug 18 2017, 7:19 PM
felixmerk created D448: undo: preview shows command and time output.
Aug 18 2017, 7:18 PM
felixmerk closed D439: undo: performance improvement attempt by committing rFBHGXf547c4194f2e: undo: performance improvement attempt.
Aug 18 2017, 6:18 AM
felixmerk committed rFBHGXf547c4194f2e: undo: performance improvement attempt.
undo: performance improvement attempt
Aug 18 2017, 6:18 AM

Aug 17 2017

felixmerk created D439: undo: performance improvement attempt.
Aug 17 2017, 6:42 PM
felixmerk created D438: undo: draft obsolete handling.
Aug 17 2017, 4:15 PM

Aug 16 2017

felixmerk added a comment to D412: undo: informative output.

With this change I'm leaving in the -b as it now makes sense. The command that is posted as output is the (first) one of the commands that affected that branch and were undone.

Aug 16 2017, 8:22 PM
felixmerk updated the diff for D410: undo: unfinished command handling.
Aug 16 2017, 8:20 PM
felixmerk added inline comments to D410: undo: unfinished command handling.
Aug 16 2017, 4:43 PM
felixmerk updated the diff for D412: undo: informative output.
Aug 16 2017, 4:39 PM
felixmerk closed D396: undo: don't break when undo isn't first argument by committing rFBHGX6908f308daeb: undo: don't break when undo isn't first argument.
Aug 16 2017, 11:18 AM
felixmerk closed D395: undo: invalidate false cache by committing rFBHGX8143cb50d4e7: undo: invalidate false cache.
Aug 16 2017, 11:18 AM
felixmerk committed rFBHGX6908f308daeb: undo: don't break when undo isn't first argument.
undo: don't break when undo isn't first argument
Aug 16 2017, 11:18 AM
felixmerk closed D357: undo: add Scuba logging by committing rFBHGX433ee7863fa7: undo: add Scuba logging.
Aug 16 2017, 11:18 AM
felixmerk committed rFBHGX8143cb50d4e7: undo: invalidate false cache.
undo: invalidate false cache
Aug 16 2017, 11:18 AM
felixmerk committed rFBHGX433ee7863fa7: undo: add Scuba logging.
undo: add Scuba logging
Aug 16 2017, 11:18 AM

Aug 15 2017

felixmerk created D412: undo: informative output.
Aug 15 2017, 9:06 PM
felixmerk updated the diff for D396: undo: don't break when undo isn't first argument.
Aug 15 2017, 7:54 PM
felixmerk created D410: undo: unfinished command handling.
Aug 15 2017, 7:46 PM

Aug 14 2017

felixmerk created D396: undo: don't break when undo isn't first argument.
Aug 14 2017, 10:30 PM
felixmerk created D395: undo: invalidate false cache.
Aug 14 2017, 9:51 PM
felixmerk abandoned D394: fold: invalidate false cache.

This solution doesn't handle the general case.

Aug 14 2017, 9:49 PM
felixmerk created D394: fold: invalidate false cache.
Aug 14 2017, 8:11 PM
felixmerk closed D324: undo: improved --branch handling by committing rFBHGX418171f302d0: undo: improved --branch handling.
Aug 14 2017, 5:19 PM
felixmerk closed D287: undo: better docs by committing rFBHGXc28c2ff754c4: undo: better docs.
Aug 14 2017, 5:19 PM
felixmerk closed D286: undo: no argument redo by committing rFBHGX916de186acdc: undo: no argument redo.
Aug 14 2017, 5:19 PM
felixmerk committed rFBHGX418171f302d0: undo: improved --branch handling.
undo: improved --branch handling
Aug 14 2017, 5:19 PM
felixmerk closed D207: undo: add --index and redo support to preview by committing rFBHGXfc0806ff0c3d: undo: add --index and redo support to preview.
Aug 14 2017, 5:19 PM
felixmerk committed rFBHGXc28c2ff754c4: undo: better docs.
undo: better docs
Aug 14 2017, 5:19 PM
felixmerk closed D263: undo: preview interactive ui by committing rFBHGXfc85e73e3882: undo: preview interactive ui.
Aug 14 2017, 5:19 PM
felixmerk committed rFBHGX916de186acdc: undo: no argument redo.
undo: no argument redo
Aug 14 2017, 5:19 PM
felixmerk closed D206: undo: basic --preview by committing rFBHGX883372ac2468: undo: basic --preview.
Aug 14 2017, 5:19 PM
felixmerk committed rFBHGXfc85e73e3882: undo: preview interactive ui.
undo: preview interactive ui
Aug 14 2017, 5:19 PM
felixmerk committed rFBHGXfc0806ff0c3d: undo: add --index and redo support to preview.
undo: add --index and redo support to preview
Aug 14 2017, 5:19 PM
felixmerk committed rFBHGX883372ac2468: undo: basic --preview.
undo: basic --preview
Aug 14 2017, 5:19 PM

Aug 11 2017

felixmerk created D357: undo: add Scuba logging.
Aug 11 2017, 7:19 PM
felixmerk updated the diff for D286: undo: no argument redo.
Aug 11 2017, 5:39 PM

Aug 10 2017

felixmerk created D324: undo: improved --branch handling.
Aug 10 2017, 6:39 PM
felixmerk updated the diff for D287: undo: better docs.
Aug 10 2017, 1:56 PM
felixmerk updated the diff for D286: undo: no argument redo.
Aug 10 2017, 1:56 PM
felixmerk updated the diff for D207: undo: add --index and redo support to preview.
Aug 10 2017, 1:55 PM
felixmerk updated the diff for D263: undo: preview interactive ui.
Aug 10 2017, 1:55 PM

Aug 9 2017

felixmerk updated the diff for D207: undo: add --index and redo support to preview.
Aug 9 2017, 7:52 PM
felixmerk requested review of D207: undo: add --index and redo support to preview.
Aug 9 2017, 7:52 PM
felixmerk updated the diff for D206: undo: basic --preview.
Aug 9 2017, 7:52 PM
felixmerk updated the diff for D263: undo: preview interactive ui.
Aug 9 2017, 2:21 PM
felixmerk added inline comments to D263: undo: preview interactive ui.
Aug 9 2017, 2:21 PM
felixmerk updated the diff for D286: undo: no argument redo.
Aug 9 2017, 2:11 PM
felixmerk added inline comments to D286: undo: no argument redo.
Aug 9 2017, 1:50 PM

Aug 8 2017

felixmerk updated the diff for D263: undo: preview interactive ui.
Aug 8 2017, 7:56 PM
felixmerk created D287: undo: better docs.
Aug 8 2017, 7:43 PM
felixmerk updated the diff for D263: undo: preview interactive ui.
Aug 8 2017, 6:55 PM
felixmerk added a comment to D263: undo: preview interactive ui.

Current test plan involves doing the following:

  1. Running a bash script that sets up an interesting repo
  2. hitting hg undo -p and trying every key combination Specifically: control-C still works, q quits, left goes forward, right goes backwards, return brings you to a state
  3. running redo after preview and return
  4. running undo a few times and then using undo -p to go back forward
  5. going out of bounds both up and down
  6. hitting other random keys during hg undo -p
  7. running hg undo -p with other flags. Note that --branch doesn't give you the correct preview
Aug 8 2017, 6:30 PM
felixmerk created D286: undo: no argument redo.
Aug 8 2017, 6:15 PM
felixmerk added inline comments to D206: undo: basic --preview.
Aug 8 2017, 1:26 PM
felixmerk added inline comments to D207: undo: add --index and redo support to preview.
Aug 8 2017, 1:20 PM
felixmerk added a comment to D206: undo: basic --preview.

{if(revset("{rev} and UNDODEL"), "-")} type stuff is on the facebook.rc side, so there isn't much to address about it here. The revsets/templates to do it exist and I've tested it.

Aug 8 2017, 1:01 PM

Aug 7 2017

felixmerk updated the diff for D207: undo: add --index and redo support to preview.
Aug 7 2017, 3:33 PM
felixmerk created D263: undo: preview interactive ui.
Aug 7 2017, 3:33 PM
felixmerk updated the diff for D206: undo: basic --preview.
Aug 7 2017, 3:33 PM

Aug 4 2017

felixmerk closed D186: undo: localbrach fancy indexes by committing rFBHGX3a71483bbf1d: undo: localbrach fancy indexes.
Aug 4 2017, 9:20 AM
felixmerk closed D160: undo: basic single repo undo by committing rFBHGX0ad0bc61a332: undo: basic single repo undo.
Aug 4 2017, 9:20 AM
felixmerk committed rFBHGX3a71483bbf1d: undo: localbrach fancy indexes.
undo: localbrach fancy indexes
Aug 4 2017, 9:20 AM