Page MenuHomePhabricator

gracinet (Georges Racinet)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2018, 3:58 AM (76 w, 4 h)

Recent Activity

Wed, Mar 11

gracinet closed D8161: rust-nodemap: also clear Rust data in `clearcaches`.
Wed, Mar 11, 11:43 AM
gracinet closed D8160: rust-nodemap: add binding to `nodemap_update_data`.
Wed, Mar 11, 11:43 AM
gracinet closed D8159: rust-nodemap: add binding for `nodemap_data_incremental`.
Wed, Mar 11, 11:43 AM
gracinet committed rHGcadcc8c20860: rust-nodemap: also clear Rust data in `clearcaches`.
rust-nodemap: also clear Rust data in `clearcaches`
Wed, Mar 11, 11:42 AM
gracinet committed rHG15febf99a9c6: rust-nodemap: add binding to `nodemap_update_data`.
rust-nodemap: add binding to `nodemap_update_data`
Wed, Mar 11, 11:42 AM
gracinet closed D8158: rust-nodemap: add binding for `nodemap_data_all`.
Wed, Mar 11, 11:42 AM
gracinet committed rHG5bbf887275b0: rust-nodemap: add binding for `nodemap_data_incremental`.
rust-nodemap: add binding for `nodemap_data_incremental`
Wed, Mar 11, 11:42 AM
gracinet committed rHGb581231ae9d1: rust-nodemap: add binding for `nodemap_data_all`.
rust-nodemap: add binding for `nodemap_data_all`
Wed, Mar 11, 11:42 AM
gracinet closed D8152: revlog: using two new functions in C capsule from Rust code.
Wed, Mar 11, 11:42 AM
gracinet closed D8156: rust-nodemap: add utils for propagating errors.
Wed, Mar 11, 11:42 AM
gracinet closed D8155: rust-nodemap: add utils to create `Node`s from Python objects.
Wed, Mar 11, 11:42 AM
gracinet committed rHG26dd35ac59b8: rust-nodemap: add utils for propagating errors.
rust-nodemap: add utils for propagating errors
Wed, Mar 11, 11:42 AM
gracinet committed rHGd738b7a18438: rust-nodemap: add utils to create `Node`s from Python objects.
rust-nodemap: add utils to create `Node`s from Python objects
Wed, Mar 11, 11:42 AM
gracinet closed D8154: rust-index: add `append` method to cindex/Index.
Wed, Mar 11, 11:42 AM
gracinet committed rHGcefd130c98be: rust-index: add `append` method to cindex/Index.
rust-index: add `append` method to cindex/Index
Wed, Mar 11, 11:42 AM
gracinet closed D8153: rust-index: moved constructor in separate impl block.
Wed, Mar 11, 11:42 AM
gracinet committed rHG887d0f921b34: rust-index: moved constructor in separate impl block.
rust-index: moved constructor in separate impl block
Wed, Mar 11, 11:42 AM
gracinet committed rHG166349510398: revlog: using two new functions in C capsule from Rust code.
revlog: using two new functions in C capsule from Rust code
Wed, Mar 11, 11:42 AM

Feb 26 2020

gracinet committed rHGd518994384a4: rust-nodemap: a method for full invalidation.
rust-nodemap: a method for full invalidation
Feb 26 2020, 11:52 AM
gracinet committed rHG5ac1eecc9c64: rust-nodemap: core implementation for shortest.
rust-nodemap: core implementation for shortest
Feb 26 2020, 11:52 AM
gracinet committed rHG6329ce04c69f: rust-nodemap: accounting for dead blocks.
rust-nodemap: accounting for dead blocks
Feb 26 2020, 11:52 AM
gracinet committed rHG8f7c6656ac79: rust-nodemap: pure Rust example.
rust-nodemap: pure Rust example
Feb 26 2020, 11:52 AM
gracinet committed rHG00d251d32007: rust-nodemap: special case for prefixes of NULL_NODE.
rust-nodemap: special case for prefixes of NULL_NODE
Feb 26 2020, 11:52 AM
gracinet committed rHGa98ba6983a63: rust-nodemap: input/output primitives.
rust-nodemap: input/output primitives
Feb 26 2020, 11:52 AM
gracinet committed rHG706c1bd7f71c: rust-nodemap: accounting for dead blocks.
rust-nodemap: accounting for dead blocks
Feb 26 2020, 10:34 AM
gracinet committed rHGbbc61f36733c: rust-nodemap: a method for full invalidation.
rust-nodemap: a method for full invalidation
Feb 26 2020, 10:34 AM
gracinet closed D7819: rust-nodemap: core implementation for shortest.
Feb 26 2020, 10:34 AM
gracinet closed D8097: rust-nodemap: accounting for dead blocks.
Feb 26 2020, 10:34 AM
gracinet closed D8098: rust-nodemap: a method for full invalidation.
Feb 26 2020, 10:34 AM
gracinet closed D7797: rust-nodemap: pure Rust example.
Feb 26 2020, 10:33 AM
gracinet committed rHG0e8a9c0fbc8c: rust-nodemap: core implementation for shortest.
rust-nodemap: core implementation for shortest
Feb 26 2020, 10:33 AM
gracinet closed D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Feb 26 2020, 10:33 AM
gracinet committed rHG895934342631: rust-nodemap: special case for prefixes of NULL_NODE.
rust-nodemap: special case for prefixes of NULL_NODE
Feb 26 2020, 10:33 AM
gracinet committed rHG57d5b0fb9740: rust-nodemap: pure Rust example.
rust-nodemap: pure Rust example
Feb 26 2020, 10:33 AM
gracinet closed D7796: rust-nodemap: input/output primitives.
Feb 26 2020, 10:33 AM
gracinet committed rHGc3cc881aaa17: rust-nodemap: input/output primitives.
rust-nodemap: input/output primitives
Feb 26 2020, 10:32 AM

Feb 12 2020

gracinet closed D7795: rust-nodemap: insert method.
Feb 12 2020, 2:25 PM
gracinet committed rHGd2da8667125b: rust-nodemap: insert method.
rust-nodemap: insert method
Feb 12 2020, 2:25 PM

Jan 28 2020

gracinet closed D8019: rust-node: avoid meaningless read at the end of odd prefix.
Jan 28 2020, 6:31 PM
gracinet committed rHGbe52b7372ec2: rust-node: avoid meaningless read at the end of odd prefix.
rust-node: avoid meaningless read at the end of odd prefix
Jan 28 2020, 6:31 PM

Jan 27 2020

gracinet created D8019: rust-node: avoid meaningless read at the end of odd prefix.
Jan 27 2020, 2:35 PM
gracinet closed D7794: rust-nodemap: generic NodeTreeVisitor.
Jan 27 2020, 2:14 PM
gracinet closed D7791: rust-nodemap: NodeMap trait with simplest implementation.
Jan 27 2020, 2:14 PM
gracinet closed D7793: rust-nodemap: mutable NodeTree data structure.
Jan 27 2020, 2:13 PM
gracinet committed rHG796d05f3fa84: rust-nodemap: generic NodeTreeVisitor.
rust-nodemap: generic NodeTreeVisitor
Jan 27 2020, 2:13 PM
gracinet committed rHGa19331456d48: rust-nodemap: mutable NodeTree data structure.
rust-nodemap: mutable NodeTree data structure
Jan 27 2020, 2:13 PM
gracinet closed D7792: rust-nodemap: abstracting the indexing.
Jan 27 2020, 2:13 PM
gracinet committed rHG220d4d2e3185: rust-nodemap: abstracting the indexing.
rust-nodemap: abstracting the indexing
Jan 27 2020, 2:13 PM
gracinet committed rHGe52401a95b94: rust-nodemap: NodeMap trait with simplest implementation.
rust-nodemap: NodeMap trait with simplest implementation
Jan 27 2020, 2:13 PM
gracinet added inline comments to D7794: rust-nodemap: generic NodeTreeVisitor.
Jan 27 2020, 2:09 PM
gracinet added inline comments to D7790: rust-node: handling binary Node prefix.
Jan 27 2020, 2:04 PM
gracinet closed D7790: rust-node: handling binary Node prefix.
Jan 27 2020, 1:36 PM
gracinet committed rHG9896a8d0d3d2: rust-node: handling binary Node prefix.
rust-node: handling binary Node prefix
Jan 27 2020, 1:36 PM
gracinet closed D7789: rust-revlog: a trait for the revlog index.
Jan 27 2020, 1:36 PM
gracinet committed rHG3fb39dc2e356: rust-revlog: a trait for the revlog index.
rust-revlog: a trait for the revlog index
Jan 27 2020, 1:36 PM
gracinet updated the diff for D7819: rust-nodemap: core implementation for shortest.
Jan 27 2020, 11:55 AM
gracinet added inline comments to D7819: rust-nodemap: core implementation for shortest.
Jan 27 2020, 11:08 AM
gracinet added inline comments to D7796: rust-nodemap: input/output primitives.
Jan 27 2020, 11:07 AM
gracinet added inline comments to D7794: rust-nodemap: generic NodeTreeVisitor.
Jan 27 2020, 10:54 AM
gracinet added inline comments to D7793: rust-nodemap: mutable NodeTree data structure.
Jan 27 2020, 10:54 AM
gracinet added inline comments to D7792: rust-nodemap: abstracting the indexing.
Jan 27 2020, 10:53 AM
gracinet added inline comments to D7791: rust-nodemap: NodeMap trait with simplest implementation.
Jan 27 2020, 10:53 AM
gracinet added a comment to D7790: rust-node: handling binary Node prefix.

Depends on the definition of NodePrefixRef. I don't think there would be any extra allocation if you define it like this:

Jan 27 2020, 10:51 AM
gracinet updated the diff for D7819: rust-nodemap: core implementation for shortest.
Jan 27 2020, 10:50 AM
gracinet updated the summary of D7797: rust-nodemap: pure Rust example.
Jan 27 2020, 10:50 AM
gracinet updated the diff for D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Jan 27 2020, 10:50 AM
gracinet updated the summary of D7796: rust-nodemap: input/output primitives.
Jan 27 2020, 10:50 AM
gracinet updated the diff for D7795: rust-nodemap: insert method.
Jan 27 2020, 10:50 AM
gracinet updated the summary of D7794: rust-nodemap: generic NodeTreeVisitor.
Jan 27 2020, 10:50 AM
gracinet updated the diff for D7793: rust-nodemap: mutable NodeTree data structure.
Jan 27 2020, 10:50 AM
gracinet retitled D7791: rust-nodemap: NodeMap trait with simplest implementation from rust-nodemap: NodeMap trait with simplest implementor to rust-nodemap: NodeMap trait with simplest implementation.
Jan 27 2020, 10:49 AM
gracinet updated the diff for D7792: rust-nodemap: abstracting the indexing.
Jan 27 2020, 10:49 AM
gracinet updated the summary of D7790: rust-node: handling binary Node prefix.
Jan 27 2020, 10:49 AM
gracinet updated the diff for D7789: rust-revlog: a trait for the revlog index.
Jan 27 2020, 10:49 AM

Jan 23 2020

gracinet added a comment to D7789: rust-revlog: a trait for the revlog index.

@martinvonz yeah, probably wrote the doc-comment too fast

Jan 23 2020, 3:41 PM

Jan 22 2020

gracinet closed D7788: rust-node: binary Node ID and conversion utilities.
Jan 22 2020, 3:53 PM
gracinet closed D7787: rust-nodemap: building blocks for nodetree structures.
Jan 22 2020, 3:52 PM
gracinet committed rHG7f86426fdd2c: rust-node: binary Node ID and conversion utilities.
rust-node: binary Node ID and conversion utilities
Jan 22 2020, 3:52 PM
gracinet committed rHG63db6657d280: rust-nodemap: building blocks for nodetree structures.
rust-nodemap: building blocks for nodetree structures
Jan 22 2020, 3:52 PM
gracinet added a comment to D7788: rust-node: binary Node ID and conversion utilities.

As the new commit description explains, I've done all I could to make the change of hash format easier

Jan 22 2020, 3:27 PM
gracinet retitled D7788: rust-node: binary Node ID and conversion utilities from rust-node: binary Node and conversion utilities to rust-node: binary Node ID and conversion utilities.
Jan 22 2020, 3:11 PM
gracinet added inline comments to D7819: rust-nodemap: core implementation for shortest.
Jan 22 2020, 1:28 PM
gracinet updated the diff for D7787: rust-nodemap: building blocks for nodetree structures.
Jan 22 2020, 10:42 AM
gracinet added a comment to D7787: rust-nodemap: building blocks for nodetree structures.

These are done, thanks for the remarks.

Jan 22 2020, 10:34 AM
gracinet updated the diff for D7787: rust-nodemap: building blocks for nodetree structures.
Jan 22 2020, 10:34 AM
gracinet added inline comments to D7791: rust-nodemap: NodeMap trait with simplest implementation.
Jan 22 2020, 10:10 AM
gracinet added inline comments to D7787: rust-nodemap: building blocks for nodetree structures.
Jan 22 2020, 9:53 AM
gracinet added a comment to D7787: rust-nodemap: building blocks for nodetree structures.

Just a few nits here, but it looks like we're expecting an update on this series anyway, so maybe you can address them.

Jan 22 2020, 9:52 AM

Jan 21 2020

gracinet added inline comments to D7952: rust: add a README.
Jan 21 2020, 10:10 AM
gracinet added a comment to D7952: rust: add a README.

"deprecate" was a bit too strong. Actually I'd like to downgrade HGWITHRUSTEXT to be something that'll be useful to play with alternative ways of building the Rust extension(s). Example: if someone wants to experiment with PyO3.

Jan 21 2020, 7:44 AM
gracinet added a comment to D7952: rust: add a README.

My general feeling is that I'd like to deprecate HGWITHRUSTEXT.

Jan 21 2020, 7:36 AM

Jan 20 2020

gracinet added a comment to D7790: rust-node: handling binary Node prefix.

@martinvonz in this code, we're in competition with the C implementation, which does something similar.

Jan 20 2020, 8:25 AM
gracinet added a comment to D7788: rust-node: binary Node ID and conversion utilities.

@durin42 @martinvonz we might have a nice path forward with this, with the suggestion of @kevincox to make Node a truly defined type, not just an alias, with a private member for the bytes.

Jan 20 2020, 8:17 AM

Jan 16 2020

gracinet added a comment to D7796: rust-nodemap: input/output primitives.

@kevincox (replying hastily because I'm also finishing something unrelated today).
Doesn't mem::size_of guarantee to take any padding into account? At least that's what the doc seems to say: https://doc.rust-lang.org/std/mem/fn.size_of.html

Jan 16 2020, 7:54 AM

Jan 15 2020

gracinet added inline comments to D7787: rust-nodemap: building blocks for nodetree structures.
Jan 15 2020, 6:56 PM
gracinet updated the diff for D7819: rust-nodemap: core implementation for shortest.
Jan 15 2020, 6:48 PM
gracinet updated the diff for D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Jan 15 2020, 6:48 PM
gracinet updated the diff for D7796: rust-nodemap: input/output primitives.
Jan 15 2020, 6:48 PM
gracinet updated the diff for D7788: rust-node: binary Node ID and conversion utilities.
Jan 15 2020, 6:48 PM
gracinet updated the diff for D7795: rust-nodemap: insert method.
Jan 15 2020, 6:48 PM