gracinet (Georges Racinet)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2018, 3:58 AM (17 w, 5 d)

Recent Activity

Fri, Feb 15

gracinet closed D5945: rust: itering less on MissingAncestors.bases for max().
Fri, Feb 15, 10:35 PM
gracinet closed D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases.
Fri, Feb 15, 10:35 PM
gracinet closed D5943: rust: less set lookups in MissingAncestors.
Fri, Feb 15, 10:35 PM
gracinet committed rHG9060af281be7: rust: itering less on MissingAncestors.bases for max().
rust: itering less on MissingAncestors.bases for max()
Fri, Feb 15, 10:34 PM
gracinet committed rHG977432970080: rust: stop putting NULL_REVISION in MissingAncestors.bases.
rust: stop putting NULL_REVISION in MissingAncestors.bases
Fri, Feb 15, 10:34 PM
gracinet committed rHGfccb61a1777b: rust: less set lookups in MissingAncestors.
rust: less set lookups in MissingAncestors
Fri, Feb 15, 10:34 PM
gracinet closed D5942: rust: less set lookups in AncestorsIterator.
Fri, Feb 15, 10:34 PM
gracinet committed rHG70827ebba453: rust: less set lookups in AncestorsIterator.
rust: less set lookups in AncestorsIterator
Fri, Feb 15, 10:34 PM

Wed, Feb 13

gracinet committed rHG0c7b353ce100: rust-cpython: binding for headrevs().
rust-cpython: binding for headrevs()
Wed, Feb 13, 2:22 PM
gracinet committed rHGee7b7bd432a1: rust: translated random test of missingancestors.
rust: translated random test of missingancestors
Wed, Feb 13, 2:22 PM
gracinet committed rHG060c030c9993: rust-cpython: moved py_set() utility to conversion module.
rust-cpython: moved py_set() utility to conversion module
Wed, Feb 13, 2:22 PM
gracinet committed rHGe37751bd1666: rust-cpython: binding for headrevs().
rust-cpython: binding for headrevs()
Wed, Feb 13, 8:19 AM
gracinet committed rHGa38c0662e9f4: rust-cpython: moved py_set() utility to conversion module.
rust-cpython: moved py_set() utility to conversion module
Wed, Feb 13, 8:19 AM
gracinet closed D5417: rust: translated random test of missingancestors.
Wed, Feb 13, 7:51 AM
gracinet committed rHG9370f4843084: rust: translated random test of missingancestors.
rust: translated random test of missingancestors
Wed, Feb 13, 7:51 AM
gracinet updated the diff for D5945: rust: itering less on MissingAncestors.bases for max().
Wed, Feb 13, 6:55 AM
gracinet updated the diff for D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases.
Wed, Feb 13, 6:55 AM
gracinet added inline comments to D5945: rust: itering less on MissingAncestors.bases for max().
Wed, Feb 13, 5:18 AM

Tue, Feb 12

gracinet added inline comments to D5945: rust: itering less on MissingAncestors.bases for max().
Tue, Feb 12, 11:32 AM
gracinet updated the diff for D5945: rust: itering less on MissingAncestors.bases for max().
Tue, Feb 12, 11:27 AM
gracinet added a comment to D5417: rust: translated random test of missingancestors.

@yuja I'm trying to find a compromise between our points of view : I'd like very much it to be run automatically (hence an integration test), and you want to be parametrizable. So, I'm pushing a version that has these two properties, working with env variables, since command-line arguments are already used by the testing framework. Hope it'll suit you, if it doesn't, I'll put it in examples and find a way to run it anyway

Tue, Feb 12, 9:07 AM
gracinet updated the diff for D5417: rust: translated random test of missingancestors.
Tue, Feb 12, 9:05 AM
gracinet created D5945: rust: itering less on MissingAncestors.bases for max().
Tue, Feb 12, 7:02 AM
gracinet created D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases.
Tue, Feb 12, 7:02 AM
gracinet added a dependent revision for D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases: D5945: rust: itering less on MissingAncestors.bases for max().
Tue, Feb 12, 7:02 AM
gracinet created D5943: rust: less set lookups in MissingAncestors.
Tue, Feb 12, 7:02 AM
gracinet added a dependent revision for D5943: rust: less set lookups in MissingAncestors: D5944: rust: stop putting NULL_REVISION in MissingAncestors.bases.
Tue, Feb 12, 7:02 AM
gracinet created D5942: rust: less set lookups in AncestorsIterator.
Tue, Feb 12, 7:02 AM
gracinet added a dependent revision for D5942: rust: less set lookups in AncestorsIterator: D5943: rust: less set lookups in MissingAncestors.
Tue, Feb 12, 7:02 AM

Tue, Feb 5

gracinet added a comment to D5417: rust: translated random test of missingancestors.

@yuja we don't need a seed to reproduce: failed examples contain all the information (that's a difference with the Python version)

Tue, Feb 5, 9:21 AM

Mon, Feb 4

gracinet added a comment to D5417: rust: translated random test of missingancestors.

@yuja now that 4.9 is out, I'm getting back to this.

Mon, Feb 4, 7:30 AM

Fri, Jan 25

gracinet committed rHGab0d762d89ef: rust-cpython: raising error.WdirUnsupported.
rust-cpython: raising error.WdirUnsupported
Fri, Jan 25, 3:55 AM
gracinet committed rHGee943a920606: rust: error for WdirUnsupported with cpython conversion as exception.
rust: error for WdirUnsupported with cpython conversion as exception
Fri, Jan 25, 3:55 AM
gracinet committed rHG2f54f31c41aa: rust: working directory revision number constant.
rust: working directory revision number constant
Fri, Jan 25, 3:55 AM

Jan 16 2019

gracinet added a comment to D5579: rust: factorized testing Graphs.

@yuja the doc you're linking is about integration tests, so it wouldn't apply to these tests which are really unitary in my mind. Usually the main difference would be the access to the private constructs that the integration tests can't perform, but it's true that most of these implementations are public anyway.

Jan 16 2019, 9:50 AM
gracinet closed D5551: rust-cpython: using MissingAncestors from Python code.
Jan 16 2019, 7:45 AM
gracinet closed D5584: rust: MissingAncestors.basesheads().
Jan 16 2019, 7:45 AM
gracinet committed rHGa89b20a49c13: rust-cpython: using MissingAncestors from Python code.
rust-cpython: using MissingAncestors from Python code
Jan 16 2019, 7:44 AM
gracinet committed rHG619ee4039bd4: rust: MissingAncestors.basesheads().
rust: MissingAncestors.basesheads()
Jan 16 2019, 7:44 AM
gracinet committed rHG4856c9b8cbaf: ancestor: incrementalmissingancestors.basesheads().
ancestor: incrementalmissingancestors.basesheads()
Jan 16 2019, 7:44 AM
gracinet closed D5579: rust: factorized testing Graphs.
Jan 16 2019, 7:44 AM
gracinet closed D5582: ancestor: incrementalmissingancestors.basesheads().
Jan 16 2019, 7:44 AM
gracinet committed rHG2a8782cc2e16: discovery: using the new basesheads().
discovery: using the new basesheads()
Jan 16 2019, 7:44 AM
gracinet closed D5583: discovery: using the new basesheads().
Jan 16 2019, 7:44 AM
gracinet closed D5578: rust-cpython: moved generic conversion fn out of ancestors module.
Jan 16 2019, 7:44 AM
gracinet committed rHG5257e6299d4c: rust-cpython: set conversion for MissingAncestors.bases().
rust-cpython: set conversion for MissingAncestors.bases()
Jan 16 2019, 7:44 AM
gracinet closed D5581: rust-cpython: set conversion for MissingAncestors.bases().
Jan 16 2019, 7:44 AM
gracinet committed rHG168041fa6d5f: rust: factorized testing Graphs.
rust: factorized testing Graphs
Jan 16 2019, 7:44 AM
gracinet committed rHGff333620a4cc: rust-cpython: moved generic conversion fn out of ancestors module.
rust-cpython: moved generic conversion fn out of ancestors module
Jan 16 2019, 7:44 AM

Jan 14 2019

gracinet updated the diff for D5551: rust-cpython: using MissingAncestors from Python code.
Jan 14 2019, 9:15 PM
gracinet created D5584: rust: MissingAncestors.basesheads().
Jan 14 2019, 9:15 PM
gracinet created D5579: rust: factorized testing Graphs.
Jan 14 2019, 9:14 PM
gracinet created D5583: discovery: using the new basesheads().
Jan 14 2019, 9:14 PM
gracinet added a dependent revision for D5583: discovery: using the new basesheads(): D5584: rust: MissingAncestors.basesheads().
Jan 14 2019, 9:14 PM
gracinet created D5580: rust: dagop.headrevs() Rust counterparts.
Jan 14 2019, 9:14 PM
gracinet created D5581: rust-cpython: set conversion for MissingAncestors.bases().
Jan 14 2019, 9:14 PM
gracinet added a dependent revision for D5582: ancestor: incrementalmissingancestors.basesheads(): D5583: discovery: using the new basesheads().
Jan 14 2019, 9:14 PM
gracinet created D5582: ancestor: incrementalmissingancestors.basesheads().
Jan 14 2019, 9:14 PM
gracinet added a dependent revision for D5581: rust-cpython: set conversion for MissingAncestors.bases(): D5582: ancestor: incrementalmissingancestors.basesheads().
Jan 14 2019, 9:14 PM
gracinet created D5578: rust-cpython: moved generic conversion fn out of ancestors module.
Jan 14 2019, 9:14 PM
gracinet added a dependent revision for D5580: rust: dagop.headrevs() Rust counterparts: D5581: rust-cpython: set conversion for MissingAncestors.bases().
Jan 14 2019, 9:14 PM
gracinet added a dependent revision for D5579: rust: factorized testing Graphs: D5580: rust: dagop.headrevs() Rust counterparts.
Jan 14 2019, 9:13 PM
gracinet added a dependent revision for D5578: rust-cpython: moved generic conversion fn out of ancestors module: D5579: rust: factorized testing Graphs.
Jan 14 2019, 9:13 PM
gracinet added inline comments to D5550: rust-cpython: bindings for MissingAncestors.
Jan 14 2019, 8:57 PM
gracinet added inline comments to D5550: rust-cpython: bindings for MissingAncestors.
Jan 14 2019, 7:45 PM
gracinet added inline comments to D5550: rust-cpython: bindings for MissingAncestors.
Jan 14 2019, 1:16 PM
gracinet added a comment to D5551: rust-cpython: using MissingAncestors from Python code.

@yuja I talked with @lothiraldan about this today. It turns out that it'd be better to provide a basesheads returning a set directly from the MissingAncestors object (I do have a Rust implementation for heads).

Jan 14 2019, 11:27 AM

Jan 11 2019

gracinet closed D5550: rust-cpython: bindings for MissingAncestors.
Jan 11 2019, 9:16 AM
gracinet closed D5546: rust-cpython: rustdoc improvements.
Jan 11 2019, 9:16 AM
gracinet committed rHG006c9ce486fa: rust-cpython: bindings for MissingAncestors.
rust-cpython: bindings for MissingAncestors
Jan 11 2019, 9:16 AM
gracinet closed D5549: rust-cpython: generalised conversion function.
Jan 11 2019, 9:16 AM
gracinet closed D5548: rust-cpython: style consistency leftovers.
Jan 11 2019, 9:16 AM
gracinet committed rHG3bf6979a1785: rust-cpython: generalised conversion function.
rust-cpython: generalised conversion function
Jan 11 2019, 9:16 AM
gracinet committed rHG1b4b94bac8a0: rust-cpython: style consistency leftovers.
rust-cpython: style consistency leftovers
Jan 11 2019, 9:16 AM
gracinet closed D5547: rust-cpython: consistency in use of hg-core constructs.
Jan 11 2019, 9:16 AM
gracinet committed rHG5ac61ca58c3f: rust-cpython: consistency in use of hg-core constructs.
rust-cpython: consistency in use of hg-core constructs
Jan 11 2019, 9:15 AM
gracinet committed rHGdcf818267bc1: rust-cpython: rustdoc improvements.
rust-cpython: rustdoc improvements
Jan 11 2019, 9:15 AM

Jan 10 2019

gracinet created D5551: rust-cpython: using MissingAncestors from Python code.
Jan 10 2019, 4:56 AM
gracinet added a dependent revision for D5550: rust-cpython: bindings for MissingAncestors: D5551: rust-cpython: using MissingAncestors from Python code.
Jan 10 2019, 4:56 AM
gracinet created D5550: rust-cpython: bindings for MissingAncestors.
Jan 10 2019, 4:56 AM
gracinet created D5549: rust-cpython: generalised conversion function.
Jan 10 2019, 4:56 AM
gracinet added a dependent revision for D5548: rust-cpython: style consistency leftovers: D5549: rust-cpython: generalised conversion function.
Jan 10 2019, 4:56 AM
gracinet created D5548: rust-cpython: style consistency leftovers.
Jan 10 2019, 4:56 AM
gracinet created D5546: rust-cpython: rustdoc improvements.
Jan 10 2019, 4:56 AM
gracinet created D5547: rust-cpython: consistency in use of hg-core constructs.
Jan 10 2019, 4:55 AM
gracinet added a dependent revision for D5547: rust-cpython: consistency in use of hg-core constructs: D5548: rust-cpython: style consistency leftovers.
Jan 10 2019, 4:55 AM
gracinet added a dependent revision for D5546: rust-cpython: rustdoc improvements: D5547: rust-cpython: consistency in use of hg-core constructs.
Jan 10 2019, 4:55 AM

Jan 5 2019

gracinet closed D5442: rust-cpython: using the new bindings from Python.
Jan 5 2019, 8:55 PM
gracinet closed D5441: rust-cpython: binding for LazyAncestors.
Jan 5 2019, 8:55 PM
gracinet committed rHG536c83535cbd: rust-cpython: using the new bindings from Python.
rust-cpython: using the new bindings from Python
Jan 5 2019, 8:55 PM
gracinet committed rHGb31a41f24864: rust-cpython: binding for LazyAncestors.
rust-cpython: binding for LazyAncestors
Jan 5 2019, 8:55 PM
gracinet abandoned D5443: ancestor: uniformity of calling lazyancestors classes.

Given this conversation, and its outcome as materialised with latest versions of D5441 and D5442, we can now simply abandon this one.

Jan 5 2019, 6:46 AM

Jan 4 2019

gracinet updated the diff for D5442: rust-cpython: using the new bindings from Python.
Jan 4 2019, 1:31 PM
gracinet added a comment to D5441: rust-cpython: binding for LazyAncestors.

@yuja this new version exports the LazyAncestors name to Python, expecting revlog.ancestors to do the right thing (as a factory then). I agree that the destiny of the older rustlazyancestors is to disappear, but I'd prefer to wait a bit before doing that
@kevincox I'd agree in principle, but since we only have one caller, whose role is precisely to abstract those differencies, we decided that we actually don't need to maintain that convention (and rustext can ne considered a foreign module, so that this is not really a breaking of the naming convention for new classes within hg)

Jan 4 2019, 1:30 PM
gracinet updated the diff for D5441: rust-cpython: binding for LazyAncestors.
Jan 4 2019, 1:30 PM

Dec 27 2018

gracinet added a comment to D5442: rust-cpython: using the new bindings from Python.

@yuja about the lazy importer, and just to clarify: so you're saying it's not worth it to delay until rustext is actually used. I'm fine with that, will do it.
I didn't amend that patch yet, but you might have received notifications due to evolve of the whole stack.

Dec 27 2018, 2:49 PM
gracinet added a comment to D5441: rust-cpython: binding for LazyAncestors.

Does the class name actually matter? Personally I don't care if
lazyancestors() function returns a LazyAncestors object. We'll anyway
need a wrapper function to make pure ancestors and rustext ancestors
compatible.

Dec 27 2018, 2:04 PM
gracinet added a comment to D5438: rust-cpython: implementing Graph using C parents function.

@yuja, thanks for the queueing !

Dec 27 2018, 1:45 PM

Dec 24 2018

gracinet closed D5438: rust-cpython: implementing Graph using C parents function.
Dec 24 2018, 12:01 AM
gracinet closed D5440: rust: core implementation for lazyancestors.
Dec 24 2018, 12:01 AM