- User Since
- Oct 17 2018, 3:58 AM (67 w, 1 h)
Mon, Jan 27
Depends on the definition of NodePrefixRef. I don't think there would be any extra allocation if you define it like this:
Thu, Jan 23
@martinvonz yeah, probably wrote the doc-comment too fast
Wed, Jan 22
As the new commit description explains, I've done all I could to make the change of hash format easier
These are done, thanks for the remarks.
Just a few nits here, but it looks like we're expecting an update on this series anyway, so maybe you can address them.
Tue, Jan 21
"deprecate" was a bit too strong. Actually I'd like to downgrade HGWITHRUSTEXT to be something that'll be useful to play with alternative ways of building the Rust extension(s). Example: if someone wants to experiment with PyO3.
My general feeling is that I'd like to deprecate HGWITHRUSTEXT.
Mon, Jan 20
@martinvonz in this code, we're in competition with the C implementation, which does something similar.
Thu, Jan 16
@kevincox (replying hastily because I'm also finishing something unrelated today).
Doesn't mem::size_of guarantee to take any padding into account? At least that's what the doc seems to say: https://doc.rust-lang.org/std/mem/fn.size_of.html
Wed, Jan 15
Ah yes, thanks
@kevincox thanks for the review!
Tue, Jan 14
Mon, Jan 13
@pulkit yes, after toolchain reinstall, this rustup which works for me
Fri, Jan 10
Ok, so yes I had an old version of rustfmt-nightly, dating back to the days it wasn't managed by rustup (crate rustfmt-nightly).
Thanks for the heads up, guys.
For the record, I have the exact same changes with this:
Thu, Jan 9
Wed, Jan 8
thanks for the tip. Fun fact: rustup which doesn't have a --toolchain option on my system, so perhaps it needs to be itself upgraded, (and that might explain a few things.
I've been using rustmt nightly since forever, but maybe I'm stuck on an old version of it.