Page MenuHomePhabricator

gracinet (Georges Racinet)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2018, 3:58 AM (43 w, 4 d)

Recent Activity

Wed, Aug 14

gracinet closed D6427: discovery: new devel.discovery.randomize option.
Wed, Aug 14, 4:17 PM
gracinet closed D6430: rust-discovery: using from Python code.
Wed, Aug 14, 4:17 PM
gracinet committed rHG4d20b1fe8a72: rust-discovery: using from Python code.
rust-discovery: using from Python code
Wed, Aug 14, 4:17 PM
gracinet closed D6426: rust-discovery: optionally don't randomize at all, for tests.
Wed, Aug 14, 4:17 PM
gracinet closed D6428: rust-discovery: using the children cache in add_missing.
Wed, Aug 14, 4:17 PM
gracinet committed rHG334c1ea57136: discovery: new devel.discovery.randomize option.
discovery: new devel.discovery.randomize option
Wed, Aug 14, 4:16 PM
gracinet committed rHG8c9a6adec67a: rust-discovery: using the children cache in add_missing.
rust-discovery: using the children cache in add_missing
Wed, Aug 14, 4:16 PM
gracinet closed D6424: rust-discovery: takefullsample() core implementation.
Wed, Aug 14, 4:16 PM
gracinet closed D6423: rust-discovery: core implementation for take_quick_sample().
Wed, Aug 14, 4:16 PM
gracinet committed rHG4e7bd6180b53: rust-discovery: optionally don't randomize at all, for tests.
rust-discovery: optionally don't randomize at all, for tests
Wed, Aug 14, 4:16 PM
gracinet closed D6425: rust-discovery: exposing sampling to python.
Wed, Aug 14, 4:16 PM
gracinet committed rHG1c4b5689bef5: rust-discovery: exposing sampling to python.
rust-discovery: exposing sampling to python
Wed, Aug 14, 4:16 PM
gracinet closed D6517: rust-discovery: read the index from a repo passed at init.
Wed, Aug 14, 4:16 PM
gracinet committed rHG8041a1b45163: rust-discovery: takefullsample() core implementation.
rust-discovery: takefullsample() core implementation
Wed, Aug 14, 4:16 PM
gracinet closed D6516: rust-discovery: accept the new 'respectsize' init arg.
Wed, Aug 14, 4:16 PM
gracinet committed rHG388622cbc911: rust-discovery: core implementation for take_quick_sample().
rust-discovery: core implementation for take_quick_sample()
Wed, Aug 14, 4:15 PM
gracinet committed rHGb6f3f704a561: rust-discovery: read the index from a repo passed at init.
rust-discovery: read the index from a repo passed at init
Wed, Aug 14, 4:15 PM
gracinet committed rHG5154701a5413: rust-discovery: accept the new 'respectsize' init arg.
rust-discovery: accept the new 'respectsize' init arg
Wed, Aug 14, 4:15 PM

Mon, Aug 12

gracinet added a comment to D6631: rust-cpython: add macro for sharing references.

it still feels like we are kinda implementing a second RefCell anyways

Mon, Aug 12, 12:54 PM

Jul 16 2019

gracinet added inline comments to D6631: rust-cpython: add macro for sharing references.
Jul 16 2019, 8:51 AM

Jun 30 2019

gracinet added a comment to D6430: rust-discovery: using from Python code.

Nobody has reacted yet to @martinvonz call for other opinions, can someone look at it?

Jun 30 2019, 7:45 AM

Jun 14 2019

gracinet committed rHG85041e2b69c7: rust: switched to 'cargo rustc' in setup.py.
rust: switched to 'cargo rustc' in setup.py
Jun 14 2019, 10:55 AM
gracinet committed rHG8ee0fdf3b087: rust-cpython: fix build for MacOSX.
rust-cpython: fix build for MacOSX
Jun 14 2019, 10:55 AM
gracinet committed rHGf4a65077e949: rust-cpython: management of shared libray suffix.
rust-cpython: management of shared libray suffix
Jun 14 2019, 10:55 AM

Jun 13 2019

gracinet committed rHG94167e701e12: rust: new rust options in setup.py.
rust: new rust options in setup.py
Jun 13 2019, 4:39 PM
gracinet committed rHGa3a8887e4426: rust: using policy.importrust from Python callers.
rust: using policy.importrust from Python callers
Jun 13 2019, 4:39 PM
gracinet committed rHG810f66b468cd: rust: module policy with importrust.
rust: module policy with importrust
Jun 13 2019, 4:39 PM
gracinet added a comment to D6429: rust-discovery: optimization of add commons/missings for empty arguments.

@kevincox, thanks for the review of this and its predecessors. I think I've addressed all your remarks and improvement suggestions.

Jun 13 2019, 9:41 AM
gracinet added inline comments to D6428: rust-discovery: using the children cache in add_missing.
Jun 13 2019, 9:38 AM
gracinet added a comment to D6430: rust-discovery: using from Python code.

Instability fixed, and I took the opportunity to rebase again to leverage policy.importrust, that's been queued yesterday (rHGf7385ed775a8)

Jun 13 2019, 9:37 AM
gracinet added a comment to D6429: rust-discovery: optimization of add commons/missings for empty arguments.

Wouldn't it be better to make add_missing_revisions work properly on empty inputs? It seems like it is too error prone to try and catch every caller. If possible I would like to push this check down as far as possible.
It seems easy enough to do in https://www.mercurial-scm.org/repo/hg/file/tip/rust/hg-core/src/discovery.rs#l56 by checking if common grew. This has the added benefit that attempting to re-add bases will also skill the work.

Jun 13 2019, 9:33 AM
gracinet updated the diff for D6429: rust-discovery: optimization of add commons/missings for empty arguments.
Jun 13 2019, 9:33 AM
gracinet updated the diff for D6428: rust-discovery: using the children cache in add_missing.
Jun 13 2019, 9:33 AM
gracinet updated the summary of D6430: rust-discovery: using from Python code.
Jun 13 2019, 9:33 AM
gracinet updated the diff for D6426: rust-discovery: optionally don't randomize at all, for tests.
Jun 13 2019, 9:33 AM
gracinet updated the diff for D6425: rust-discovery: exposing sampling to python.
Jun 13 2019, 9:32 AM
gracinet updated the diff for D6424: rust-discovery: takefullsample() core implementation.
Jun 13 2019, 9:32 AM

Jun 12 2019

gracinet committed rHG302acc78cc87: rust: new rust options in setup.py.
rust: new rust options in setup.py
Jun 12 2019, 7:41 PM
gracinet committed rHGf834ee285752: rust: using policy.importrust from Python callers.
rust: using policy.importrust from Python callers
Jun 12 2019, 7:41 PM
gracinet committed rHGf7385ed775a8: rust: module policy with importrust.
rust: module policy with importrust
Jun 12 2019, 7:41 PM
gracinet added a comment to D6521: rust-discovery: optionally don't randomize at all, for tests.

Bad phabsend usage, sorry.

Jun 12 2019, 2:43 PM
gracinet added a comment to D6520: rust-discovery: exposing sampling to python.

Bad phabsend usage, sorry.

Jun 12 2019, 2:42 PM
gracinet added a comment to D6520: rust-discovery: exposing sampling to python.

Bad phabsend usage, sorry.

Jun 12 2019, 2:42 PM
gracinet added a comment to D6519: rust-discovery: takefullsample() core implementation.

Bad phabsend usage, sorry.

Jun 12 2019, 2:42 PM
gracinet added a comment to D6518: rust-discovery: core implementation for take_quick_sample().

Bad phabsend usage, sorry.

Jun 12 2019, 2:42 PM
gracinet added a comment to D6430: rust-discovery: using from Python code.

Update of the whole series done but, ended up in an inconsistent state, and I have to go. Please don't act on it until I give the signal it's ready (sorry for inconvenience)

Jun 12 2019, 2:40 PM
gracinet updated the diff for D6427: discovery: new devel.discovery.randomize option.
Jun 12 2019, 2:17 PM
gracinet created D6521: rust-discovery: optionally don't randomize at all, for tests.
Jun 12 2019, 2:17 PM
gracinet updated the summary of D6430: rust-discovery: using from Python code.
Jun 12 2019, 2:17 PM
gracinet retitled D6429: rust-discovery: optimization of add commons/missings for empty arguments from rust-discovery: avoid useless calls to addcommons/addmissings to rust-discovery: optimization of add commons/missings for empty arguments.
Jun 12 2019, 2:17 PM
gracinet updated the diff for D6428: rust-discovery: using the children cache in add_missing.
Jun 12 2019, 2:17 PM
gracinet created D6519: rust-discovery: takefullsample() core implementation.
Jun 12 2019, 2:17 PM
gracinet created D6520: rust-discovery: exposing sampling to python.
Jun 12 2019, 2:17 PM
gracinet created D6518: rust-discovery: core implementation for take_quick_sample().
Jun 12 2019, 2:17 PM
gracinet created D6517: rust-discovery: read the index from a repo passed at init.
Jun 12 2019, 2:13 PM
gracinet created D6516: rust-discovery: accept the new 'respectsize' init arg.
Jun 12 2019, 2:13 PM

Jun 3 2019

gracinet committed rHG4e4fa3a95406: rust-dirstate: architecture independence fix.
rust-dirstate: architecture independence fix
Jun 3 2019, 9:32 AM
gracinet created D6473: rust-dirstate: architecture independence fix.
Jun 3 2019, 8:49 AM

May 22 2019

gracinet added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

Also I'd like to mention that I have changesets that add more precise timing info, both for the Python variant (this one) and the Rust variant. These are the ones I used to put timing info in D6430 and D6428. I can share them, but I wouldn't submit them.

May 22 2019, 2:15 PM
gracinet added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

We could maybe make it a function of both the number of heads and roots. That is not strictly the number of connected set, but that would provide a more conservative approach. That could over-sample for hour-glass shape, but they are probably less common.

The current way (only consider roots) should not over-sample, right? It still seems very effective in practice.

May 22 2019, 2:13 PM
gracinet added a comment to D6428: rust-discovery: using the children cache in add_missing.

This revision is new. At the time I submitted the previous series, it was almost always the case that the advantage of the C reachableroots2() over the Rust `dagop::range() was more than compensated by sampling been done in Rust instead of Python.
I originally planned to finish that one and submit it as a follow-up optimization, but now it's necessary to prevent being slower in the fastest cases where there's no sampling.

May 22 2019, 1:17 PM
gracinet created D6430: rust-discovery: using from Python code.
May 22 2019, 1:00 PM
gracinet created D6429: rust-discovery: optimization of add commons/missings for empty arguments.
May 22 2019, 1:00 PM
gracinet created D6428: rust-discovery: using the children cache in add_missing.
May 22 2019, 1:00 PM
gracinet updated subscribers of D6427: discovery: new devel.discovery.randomize option.

@kevincox this used to be D6346
I had to fix conflict and adapt the test due to growing sample size having landed since then

May 22 2019, 12:56 PM
gracinet added a comment to D6426: rust-discovery: optionally don't randomize at all, for tests.

@kevincox this used to be D6345

May 22 2019, 12:55 PM
gracinet added a comment to D6425: rust-discovery: exposing sampling to python.

@kevincox this used to be D6261

May 22 2019, 12:54 PM
gracinet added a comment to D6424: rust-discovery: takefullsample() core implementation.

@kevincox this used to be D6260 (I don't think I changed anything besides rebasing)

May 22 2019, 12:53 PM
gracinet added a comment to D6423: rust-discovery: core implementation for take_quick_sample().

@kevincox this used to be D6257 (I don't think I changed anything besides rebasing)

May 22 2019, 12:50 PM
gracinet created D6427: discovery: new devel.discovery.randomize option.
May 22 2019, 12:50 PM
gracinet created D6426: rust-discovery: optionally don't randomize at all, for tests.
May 22 2019, 12:50 PM
gracinet created D6425: rust-discovery: exposing sampling to python.
May 22 2019, 12:50 PM
gracinet created D6424: rust-discovery: takefullsample() core implementation.
May 22 2019, 12:50 PM
gracinet created D6423: rust-discovery: core implementation for take_quick_sample().
May 22 2019, 12:50 PM
gracinet abandoned D6346: discovery: new devel.discovery.randomize option.

I'm abandoning this revision because I have to resubmit the whole series after partial incorrect application last week and subsequent droping from the actual repo.

May 22 2019, 12:40 PM
gracinet abandoned D6262: rust-discovery: using from Python code.
May 22 2019, 12:39 PM
gracinet added a comment to D6262: rust-discovery: using from Python code.

I'm abandoning this revision because I have to resubmit the whole series after partial incorrect application last week and subsequent droping from the actual repo.

May 22 2019, 12:38 PM
gracinet abandoned D6345: rust-discovery: optionally don't randomize at all, for tests.

I'm abandoning this revision because I have to resubmit the whole series after partial incorrect application last week and subsequent droping from the actual repo.

May 22 2019, 12:38 PM
gracinet added a comment to D6345: rust-discovery: optionally don't randomize at all, for tests.

@kevincox I don't think the potential masking in tests due to this strategy is a big problem. That test is pretty recent, compared to setdiscovery, at least, and doesn't really test that sampling is very relevant. We could do better though by introducing several non random selecting strategies if we need it in the future, but this was good enough for me for the time being.

May 22 2019, 12:36 PM

May 21 2019

gracinet closed D6415: rust-python3: useless python2 specific import.
May 21 2019, 7:32 PM
gracinet committed rHG5b795108dd17: rust-python3: useless python2 specific import.
rust-python3: useless python2 specific import
May 21 2019, 7:32 PM
gracinet closed D6397: rust-python3: compatibility fix for incoming PyLong.
May 21 2019, 7:32 PM
gracinet committed rHG48df8a06c8bb: rust-python3: compatibility fix for incoming PyLong.
rust-python3: compatibility fix for incoming PyLong
May 21 2019, 7:32 PM
gracinet added a comment to D6397: rust-python3: compatibility fix for incoming PyLong.

D6415 is also necessary to actually build with python3

May 21 2019, 2:09 PM
gracinet created D6415: rust-python3: useless python2 specific import.
May 21 2019, 2:09 PM
gracinet added a comment to D6397: rust-python3: compatibility fix for incoming PyLong.

@yuja yes indeed, just resubmitted with as_object(), thanks

May 21 2019, 2:01 PM
gracinet updated the diff for D6397: rust-python3: compatibility fix for incoming PyLong.
May 21 2019, 1:58 PM

May 17 2019

gracinet committed rHG163b8fd7bb72: rust-python3: compatibility fix for integer conversion.
rust-python3: compatibility fix for integer conversion
May 17 2019, 11:36 PM
gracinet closed D6396: rust-python3: compatibility fix for integer conversion.
May 17 2019, 11:31 PM
gracinet committed rHGf887a8c1abde: rust-python3: compatibility fix for integer conversion.
rust-python3: compatibility fix for integer conversion
May 17 2019, 11:31 PM
gracinet created D6397: rust-python3: compatibility fix for incoming PyLong.
May 17 2019, 7:42 AM
gracinet created D6396: rust-python3: compatibility fix for integer conversion.
May 17 2019, 7:42 AM
gracinet closed D6392: rust-cpython: build for py3, Windows and MacOSX.
May 17 2019, 1:58 AM
gracinet committed rHGa5fa9140ce4c: rust-cpython: build for py3, Windows and MacOSX.
rust-cpython: build for py3, Windows and MacOSX
May 17 2019, 1:58 AM

May 16 2019

gracinet updated the diff for D6392: rust-cpython: build for py3, Windows and MacOSX.
May 16 2019, 4:19 PM
gracinet updated the diff for D6392: rust-cpython: build for py3, Windows and MacOSX.
May 16 2019, 4:10 PM
gracinet created D6392: rust-cpython: build for py3, Windows and MacOSX.
May 16 2019, 3:15 PM
gracinet closed D6257: rust-discovery: core implementation for take_quick_sample().
May 16 2019, 12:43 PM
gracinet committed rHGedbd8530fa4d: rust-discovery: exposing sampling to python.
rust-discovery: exposing sampling to python
May 16 2019, 12:43 PM
gracinet closed D6260: rust-discovery: takefullsample() core implementation.
May 16 2019, 12:43 PM