Page MenuHomePhabricator

gracinet (Georges Racinet)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2018, 3:58 AM (67 w, 1 h)

Recent Activity

Yesterday

gracinet closed D8019: rust-node: avoid meaningless read at the end of odd prefix.
Tue, Jan 28, 6:31 PM
gracinet committed rHGbe52b7372ec2: rust-node: avoid meaningless read at the end of odd prefix.
rust-node: avoid meaningless read at the end of odd prefix
Tue, Jan 28, 6:31 PM

Mon, Jan 27

gracinet created D8019: rust-node: avoid meaningless read at the end of odd prefix.
Mon, Jan 27, 2:35 PM
gracinet closed D7794: rust-nodemap: generic NodeTreeVisitor.
Mon, Jan 27, 2:14 PM
gracinet closed D7791: rust-nodemap: NodeMap trait with simplest implementation.
Mon, Jan 27, 2:14 PM
gracinet closed D7793: rust-nodemap: mutable NodeTree data structure.
Mon, Jan 27, 2:13 PM
gracinet committed rHG796d05f3fa84: rust-nodemap: generic NodeTreeVisitor.
rust-nodemap: generic NodeTreeVisitor
Mon, Jan 27, 2:13 PM
gracinet committed rHGa19331456d48: rust-nodemap: mutable NodeTree data structure.
rust-nodemap: mutable NodeTree data structure
Mon, Jan 27, 2:13 PM
gracinet closed D7792: rust-nodemap: abstracting the indexing.
Mon, Jan 27, 2:13 PM
gracinet committed rHG220d4d2e3185: rust-nodemap: abstracting the indexing.
rust-nodemap: abstracting the indexing
Mon, Jan 27, 2:13 PM
gracinet committed rHGe52401a95b94: rust-nodemap: NodeMap trait with simplest implementation.
rust-nodemap: NodeMap trait with simplest implementation
Mon, Jan 27, 2:13 PM
gracinet added inline comments to D7794: rust-nodemap: generic NodeTreeVisitor.
Mon, Jan 27, 2:09 PM
gracinet added inline comments to D7790: rust-node: handling binary Node prefix.
Mon, Jan 27, 2:04 PM
gracinet closed D7790: rust-node: handling binary Node prefix.
Mon, Jan 27, 1:36 PM
gracinet committed rHG9896a8d0d3d2: rust-node: handling binary Node prefix.
rust-node: handling binary Node prefix
Mon, Jan 27, 1:36 PM
gracinet closed D7789: rust-revlog: a trait for the revlog index.
Mon, Jan 27, 1:36 PM
gracinet committed rHG3fb39dc2e356: rust-revlog: a trait for the revlog index.
rust-revlog: a trait for the revlog index
Mon, Jan 27, 1:36 PM
gracinet updated the diff for D7819: rust-nodemap: core implementation for shortest.
Mon, Jan 27, 11:55 AM
gracinet added inline comments to D7819: rust-nodemap: core implementation for shortest.
Mon, Jan 27, 11:08 AM
gracinet added inline comments to D7796: rust-nodemap: input/output primitives.
Mon, Jan 27, 11:07 AM
gracinet added inline comments to D7794: rust-nodemap: generic NodeTreeVisitor.
Mon, Jan 27, 10:54 AM
gracinet added inline comments to D7793: rust-nodemap: mutable NodeTree data structure.
Mon, Jan 27, 10:54 AM
gracinet added inline comments to D7792: rust-nodemap: abstracting the indexing.
Mon, Jan 27, 10:53 AM
gracinet added inline comments to D7791: rust-nodemap: NodeMap trait with simplest implementation.
Mon, Jan 27, 10:53 AM
gracinet added a comment to D7790: rust-node: handling binary Node prefix.

Depends on the definition of NodePrefixRef. I don't think there would be any extra allocation if you define it like this:

Mon, Jan 27, 10:51 AM
gracinet updated the diff for D7819: rust-nodemap: core implementation for shortest.
Mon, Jan 27, 10:50 AM
gracinet updated the summary of D7797: rust-nodemap: pure Rust example.
Mon, Jan 27, 10:50 AM
gracinet updated the diff for D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Mon, Jan 27, 10:50 AM
gracinet updated the summary of D7796: rust-nodemap: input/output primitives.
Mon, Jan 27, 10:50 AM
gracinet updated the diff for D7795: rust-nodemap: insert method.
Mon, Jan 27, 10:50 AM
gracinet updated the summary of D7794: rust-nodemap: generic NodeTreeVisitor.
Mon, Jan 27, 10:50 AM
gracinet updated the diff for D7793: rust-nodemap: mutable NodeTree data structure.
Mon, Jan 27, 10:50 AM
gracinet retitled D7791: rust-nodemap: NodeMap trait with simplest implementation from rust-nodemap: NodeMap trait with simplest implementor to rust-nodemap: NodeMap trait with simplest implementation.
Mon, Jan 27, 10:49 AM
gracinet updated the diff for D7792: rust-nodemap: abstracting the indexing.
Mon, Jan 27, 10:49 AM
gracinet updated the summary of D7790: rust-node: handling binary Node prefix.
Mon, Jan 27, 10:49 AM
gracinet updated the diff for D7789: rust-revlog: a trait for the revlog index.
Mon, Jan 27, 10:49 AM

Thu, Jan 23

gracinet added a comment to D7789: rust-revlog: a trait for the revlog index.

@martinvonz yeah, probably wrote the doc-comment too fast

Thu, Jan 23, 3:41 PM

Wed, Jan 22

gracinet closed D7788: rust-node: binary Node ID and conversion utilities.
Wed, Jan 22, 3:53 PM
gracinet closed D7787: rust-nodemap: building blocks for nodetree structures.
Wed, Jan 22, 3:52 PM
gracinet committed rHG7f86426fdd2c: rust-node: binary Node ID and conversion utilities.
rust-node: binary Node ID and conversion utilities
Wed, Jan 22, 3:52 PM
gracinet committed rHG63db6657d280: rust-nodemap: building blocks for nodetree structures.
rust-nodemap: building blocks for nodetree structures
Wed, Jan 22, 3:52 PM
gracinet added a comment to D7788: rust-node: binary Node ID and conversion utilities.

As the new commit description explains, I've done all I could to make the change of hash format easier

Wed, Jan 22, 3:27 PM
gracinet retitled D7788: rust-node: binary Node ID and conversion utilities from rust-node: binary Node and conversion utilities to rust-node: binary Node ID and conversion utilities.
Wed, Jan 22, 3:11 PM
gracinet added inline comments to D7819: rust-nodemap: core implementation for shortest.
Wed, Jan 22, 1:28 PM
gracinet updated the diff for D7787: rust-nodemap: building blocks for nodetree structures.
Wed, Jan 22, 10:42 AM
gracinet added a comment to D7787: rust-nodemap: building blocks for nodetree structures.

These are done, thanks for the remarks.

Wed, Jan 22, 10:34 AM
gracinet updated the diff for D7787: rust-nodemap: building blocks for nodetree structures.
Wed, Jan 22, 10:34 AM
gracinet added inline comments to D7791: rust-nodemap: NodeMap trait with simplest implementation.
Wed, Jan 22, 10:10 AM
gracinet added inline comments to D7787: rust-nodemap: building blocks for nodetree structures.
Wed, Jan 22, 9:53 AM
gracinet added a comment to D7787: rust-nodemap: building blocks for nodetree structures.

Just a few nits here, but it looks like we're expecting an update on this series anyway, so maybe you can address them.

Wed, Jan 22, 9:52 AM

Tue, Jan 21

gracinet added inline comments to D7952: rust: add a README.
Tue, Jan 21, 10:10 AM
gracinet added a comment to D7952: rust: add a README.

"deprecate" was a bit too strong. Actually I'd like to downgrade HGWITHRUSTEXT to be something that'll be useful to play with alternative ways of building the Rust extension(s). Example: if someone wants to experiment with PyO3.

Tue, Jan 21, 7:44 AM
gracinet added a comment to D7952: rust: add a README.

My general feeling is that I'd like to deprecate HGWITHRUSTEXT.

Tue, Jan 21, 7:36 AM

Mon, Jan 20

gracinet added a comment to D7790: rust-node: handling binary Node prefix.

@martinvonz in this code, we're in competition with the C implementation, which does something similar.

Mon, Jan 20, 8:25 AM
gracinet added a comment to D7788: rust-node: binary Node ID and conversion utilities.

@durin42 @martinvonz we might have a nice path forward with this, with the suggestion of @kevincox to make Node a truly defined type, not just an alias, with a private member for the bytes.

Mon, Jan 20, 8:17 AM

Thu, Jan 16

gracinet added a comment to D7796: rust-nodemap: input/output primitives.

@kevincox (replying hastily because I'm also finishing something unrelated today).
Doesn't mem::size_of guarantee to take any padding into account? At least that's what the doc seems to say: https://doc.rust-lang.org/std/mem/fn.size_of.html

Thu, Jan 16, 7:54 AM

Wed, Jan 15

gracinet added inline comments to D7787: rust-nodemap: building blocks for nodetree structures.
Wed, Jan 15, 6:56 PM
gracinet updated the diff for D7819: rust-nodemap: core implementation for shortest.
Wed, Jan 15, 6:48 PM
gracinet updated the diff for D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Wed, Jan 15, 6:48 PM
gracinet updated the diff for D7796: rust-nodemap: input/output primitives.
Wed, Jan 15, 6:48 PM
gracinet updated the diff for D7788: rust-node: binary Node ID and conversion utilities.
Wed, Jan 15, 6:48 PM
gracinet updated the diff for D7795: rust-nodemap: insert method.
Wed, Jan 15, 6:48 PM
gracinet updated the diff for D7794: rust-nodemap: generic NodeTreeVisitor.
Wed, Jan 15, 6:48 PM
gracinet updated the diff for D7793: rust-nodemap: mutable NodeTree data structure.
Wed, Jan 15, 6:48 PM
gracinet updated the diff for D7792: rust-nodemap: abstracting the indexing.
Wed, Jan 15, 6:47 PM
gracinet updated the diff for D7791: rust-nodemap: NodeMap trait with simplest implementation.
Wed, Jan 15, 6:47 PM
gracinet updated the diff for D7787: rust-nodemap: building blocks for nodetree structures.
Wed, Jan 15, 6:47 PM
gracinet added a comment to D7895: rust-core: fix typo in comment.

Ah yes, thanks

Wed, Jan 15, 3:17 PM
gracinet added a comment to D7787: rust-nodemap: building blocks for nodetree structures.

@kevincox thanks for the review!

Wed, Jan 15, 9:19 AM

Tue, Jan 14

gracinet committed rHGf5d2720f3bea: revlog-native: introduced ABI version in capsule.
revlog-native: introduced ABI version in capsule
Tue, Jan 14, 11:39 AM
gracinet committed rHG90af0a4023c3: revlog-native: introduced ABI version in capsule.
revlog-native: introduced ABI version in capsule
Tue, Jan 14, 11:37 AM
gracinet closed D7856: revlog-native: introduced ABI version in capsule.
Tue, Jan 14, 9:22 AM
gracinet committed rHGe300421d67f5: revlog-native: introduced ABI version in capsule.
revlog-native: introduced ABI version in capsule
Tue, Jan 14, 9:22 AM
gracinet updated subscribers of D7856: revlog-native: introduced ABI version in capsule.

@yuja I believe this could address the concerns you expressed on D7543

Tue, Jan 14, 6:10 AM
gracinet created D7856: revlog-native: introduced ABI version in capsule.
Tue, Jan 14, 6:05 AM

Mon, Jan 13

gracinet added a comment to D7812: examples: specify rustfmt nightly using a $() construct.

@pulkit yes, after toolchain reinstall, this rustup which works for me

Mon, Jan 13, 2:57 PM

Fri, Jan 10

gracinet created D7819: rust-nodemap: core implementation for shortest.
Fri, Jan 10, 10:04 AM
gracinet updated the diff for D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Fri, Jan 10, 10:04 AM
gracinet updated the diff for D7796: rust-nodemap: input/output primitives.
Fri, Jan 10, 10:04 AM
gracinet updated the diff for D7793: rust-nodemap: mutable NodeTree data structure.
Fri, Jan 10, 10:03 AM
gracinet updated the diff for D7792: rust-nodemap: abstracting the indexing.
Fri, Jan 10, 10:03 AM
gracinet updated the diff for D7791: rust-nodemap: NodeMap trait with simplest implementation.
Fri, Jan 10, 10:03 AM
gracinet updated the diff for D7787: rust-nodemap: building blocks for nodetree structures.
Fri, Jan 10, 10:03 AM
gracinet added a comment to D7812: examples: specify rustfmt nightly using a $() construct.

Ok, so yes I had an old version of rustfmt-nightly, dating back to the days it wasn't managed by rustup (crate rustfmt-nightly).
Thanks for the heads up, guys.

Fri, Jan 10, 8:46 AM
gracinet added a comment to D7813: revlog: run rustfmt nightly.

For the record, I have the exact same changes with this:

Fri, Jan 10, 8:41 AM

Thu, Jan 9

gracinet closed D7715: rust-discovery: type alias for random generator seed.
Thu, Jan 9, 9:57 AM
gracinet committed rHG2abffea40700: rust-discovery: type alias for random generator seed.
rust-discovery: type alias for random generator seed
Thu, Jan 9, 9:57 AM

Wed, Jan 8

gracinet added a comment to D7812: examples: specify rustfmt nightly using a $() construct.

thanks for the tip. Fun fact: rustup which doesn't have a --toolchain option on my system, so perhaps it needs to be itself upgraded, (and that might explain a few things.
I've been using rustmt nightly since forever, but maybe I'm stuck on an old version of it.

Wed, Jan 8, 3:06 PM
gracinet closed D7660: rust-index: add a `experimental.rust.index` option to use the wrapper.
Wed, Jan 8, 1:12 PM
gracinet closed D7659: rust-index: use the new method in shortesthexnodeidprefix.
Wed, Jan 8, 1:11 PM
gracinet closed D7656: rust-index: make it possible to clone the struct referencing the C index.
Wed, Jan 8, 1:11 PM
gracinet committed rHG8042856c90b6: rust-index: add a `experimental.rust.index` option to use the wrapper.
rust-index: add a `experimental.rust.index` option to use the wrapper
Wed, Jan 8, 1:11 PM
gracinet committed rHG992f0d6e7f33: rust-index: use the new method in shortesthexnodeidprefix.
rust-index: use the new method in shortesthexnodeidprefix
Wed, Jan 8, 1:11 PM
gracinet closed D7658: rust-index: expose a method to retrieve the C index.
Wed, Jan 8, 1:11 PM
gracinet committed rHG443dc1655923: rust-index: expose a method to retrieve the C index.
rust-index: expose a method to retrieve the C index
Wed, Jan 8, 1:10 PM
gracinet committed rHG2728fcb8127c: rust-index: make it possible to clone the struct referencing the C index.
rust-index: make it possible to clone the struct referencing the C index
Wed, Jan 8, 1:10 PM
gracinet committed rHG6b332c1fc7fe: rust-core: extracted a revlog submodule.
rust-core: extracted a revlog submodule
Wed, Jan 8, 1:10 PM
gracinet committed rHG72bced4f2936: rust-matchers: fixing cargo doc.
rust-matchers: fixing cargo doc
Wed, Jan 8, 1:10 PM
gracinet closed D7783: rust-matchers: fixing cargo doc.
Wed, Jan 8, 11:50 AM
gracinet closed D7782: rust-core: extracted a revlog submodule.
Wed, Jan 8, 11:50 AM