Page MenuHomePhabricator

hooper (Danny Hooper)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2017, 7:50 PM (219 w, 17 h)

Recent Activity

Tue, Oct 12

hooper closed D11280: fix: reduce number of tool executions.
Tue, Oct 12, 1:19 PM
hooper closed D11279: fix: add test to demonstrate how many times tools are executed.
Tue, Oct 12, 1:19 PM
hooper committed rHGf12a19d03d2c: fix: reduce number of tool executions.
fix: reduce number of tool executions
Tue, Oct 12, 1:19 PM
hooper committed rHG066cdec8f74f: fix: add test to demonstrate how many times tools are executed.
fix: add test to demonstrate how many times tools are executed
Tue, Oct 12, 1:19 PM

Mon, Oct 11

hooper added a comment to D11280: fix: reduce number of tool executions.

It looks like this somehow makes the Python 2 output flaky : https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/247264

Mon, Oct 11, 10:03 PM
hooper updated the diff for D11280: fix: reduce number of tool executions.
Mon, Oct 11, 10:03 PM

Sep 20 2021

hooper updated the diff for D11280: fix: reduce number of tool executions.
Sep 20 2021, 4:29 PM
hooper updated the diff for D11279: fix: add test to demonstrate how many times tools are executed.
Sep 20 2021, 4:29 PM

Sep 2 2021

hooper updated the summary of D11280: fix: reduce number of tool executions.
Sep 2 2021, 6:07 PM
hooper updated the summary of D11279: fix: add test to demonstrate how many times tools are executed.
Sep 2 2021, 6:07 PM

Aug 11 2021

hooper created D11280: fix: reduce number of tool executions.
Aug 11 2021, 10:16 PM
hooper created D11279: fix: add test to demonstrate how many times tools are executed.
Aug 11 2021, 10:16 PM

Jan 13 2021

hooper added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

The patch looks fine now.

Jan 13 2021, 3:20 PM

Oct 23 2020

hooper added inline comments to D9056: fix: include adjacent blank lines in ranges to be fixed.
Oct 23 2020, 6:37 PM

Oct 21 2020

hooper added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

The config changes are a big improvement, but I'm still not sure if it's worth supporting. One thing to note is that this feature doesn't help users who have multiple formatters behind a wrapper script configured as a single fixer tool. Configuring it as multiple fixer tools is possible, but not always practical, since it may duplicate some logic between the hg config and something else (sorry to be vague about that).

Oct 21 2020, 8:53 PM

Oct 16 2020

hooper added a comment to D9226: fix: don't include obsolete descendants with -s.

Looks good.

Oct 16 2020, 9:19 PM

Oct 13 2020

hooper added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

Consider this C++ example:

Oct 13 2020, 4:59 PM

Sep 25 2020

hooper added inline comments to D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 25 2020, 7:09 PM

Sep 22 2020

hooper added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

Your ":deletion" suggestion is related to the possibility of supporting "zero-length byte offset ranges" or "zero-length line ranges" in addition to "line ranges." In general, I would recommend avoiding the temptation to complicate the interface between fix.py and formatter tools. Most of the formatters I've had to integrate with did not support "formatting a deletion" anyway. There are some important counter examples like clang-format.

Sep 22 2020, 7:12 PM
hooper added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

I'm not sure how general the "blank lines" heuristic actually is. I think this should be an opt-in feature based on a per-formatter config variable. You can start with an entry in "FIXER_ATTRS" and a check around line 685. Whatever we end up with, it needs to be documented in the module docstring (which is the source for hg help -e fix)

Sep 22 2020, 12:52 PM

Mar 13 2020

hooper added a comment to D8287: fix: add a -s option to format a revision and its descendants.

D8283:D8288 all looks good to me.

Mar 13 2020, 5:02 PM

Dec 12 2019

hooper added inline comments to D7570: match: resolve filesets against the passed `cwd`, not the current one.
Dec 12 2019, 4:29 PM

Oct 14 2019

hooper added a comment to D7086: fix: remove a never-true check for unset pattern in Fixer.affects().

Looks good.

Oct 14 2019, 12:32 PM

Oct 5 2019

hooper closed D6975: fix: add :enabled sub-config for fixer tools.
Oct 5 2019, 2:29 PM
hooper committed rHG808a57a08470: fix: add :enabled sub-config for fixer tools.
fix: add :enabled sub-config for fixer tools
Oct 5 2019, 2:29 PM
hooper created D6975: fix: add :enabled sub-config for fixer tools.
Oct 5 2019, 10:42 AM

Aug 17 2019

hooper committed rHGe9f503074044: fix: pass line ranges as value instead of callback.
fix: pass line ranges as value instead of callback
Aug 17 2019, 2:50 AM
hooper committed rHG2d70b1118af2: fix: correctly parse the :metadata subconfig.
fix: correctly parse the :metadata subconfig
Aug 17 2019, 2:50 AM
hooper committed rHGed0da6e0d6ee: fix: allow tools to use :linerange, but also run if a file is unchanged.
fix: allow tools to use :linerange, but also run if a file is unchanged
Aug 17 2019, 2:50 AM

Aug 14 2019

hooper closed D6726: fix: correctly parse the :metadata subconfig.
Aug 14 2019, 4:43 PM
hooper closed D6727: fix: pass line ranges as value instead of callback.
Aug 14 2019, 4:43 PM
hooper closed D6723: fix: allow tools to use :linerange, but also run if a file is unchanged.
Aug 14 2019, 4:43 PM
hooper committed rHG64a0cb2d4692: fix: pass line ranges as value instead of callback.
fix: pass line ranges as value instead of callback
Aug 14 2019, 4:43 PM
hooper committed rHGd82e9f7e7440: fix: correctly parse the :metadata subconfig.
fix: correctly parse the :metadata subconfig
Aug 14 2019, 4:42 PM
hooper committed rHG69b37b7227f2: fix: allow tools to use :linerange, but also run if a file is unchanged.
fix: allow tools to use :linerange, but also run if a file is unchanged
Aug 14 2019, 4:42 PM
hooper created D6727: fix: pass line ranges as value instead of callback.
Aug 14 2019, 4:29 PM
hooper created D6726: fix: correctly parse the :metadata subconfig.
Aug 14 2019, 4:17 PM

Aug 13 2019

hooper updated the diff for D6723: fix: allow tools to use :linerange, but also run if a file is unchanged.
Aug 13 2019, 6:21 PM

Aug 12 2019

hooper created D6723: fix: allow tools to use :linerange, but also run if a file is unchanged.
Aug 12 2019, 7:40 PM

Aug 1 2019

hooper closed D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
Aug 1 2019, 2:46 PM
hooper committed rHG74b4cd091e0d: fix: run fixer tools in the repo root as cwd so they can use the working copy.
fix: run fixer tools in the repo root as cwd so they can use the working copy
Aug 1 2019, 2:46 PM

Jul 29 2019

hooper closed D6698: fix: add some new test cases.
Jul 29 2019, 6:31 AM
hooper committed rHG4b04244f2d5f: fix: add some new test cases.
fix: add some new test cases
Jul 29 2019, 6:31 AM

Jul 26 2019

hooper added a comment to D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.

I still think we should fix the cwd for fixers, but it seems Martin and I agree that repo-root is more consistent. Would you be willing to reroll with repo-root instead of cwd?

Jul 26 2019, 1:59 PM
hooper updated the diff for D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
Jul 26 2019, 1:58 PM
hooper created D6698: fix: add some new test cases.
Jul 26 2019, 1:48 PM
hooper closed D6693: fix: ignore fixer tool configurations that are missing patterns.
Jul 26 2019, 12:05 PM
hooper closed D6692: fix: add a test case around the effect of cwd on pattern matching.
Jul 26 2019, 12:05 PM
hooper closed D6691: fix: remove support for :fileset sub-config in favor of :pattern.
Jul 26 2019, 12:05 PM
hooper committed rHG2987d015aba4: fix: ignore fixer tool configurations that are missing patterns.
fix: ignore fixer tool configurations that are missing patterns
Jul 26 2019, 12:05 PM
hooper committed rHG22c4bd7d1cbf: fix: add a test case around the effect of cwd on pattern matching.
fix: add a test case around the effect of cwd on pattern matching
Jul 26 2019, 12:05 PM
hooper committed rHG9ed63cd0026c: fix: remove support for :fileset sub-config in favor of :pattern.
fix: remove support for :fileset sub-config in favor of :pattern
Jul 26 2019, 12:05 PM

Jul 25 2019

hooper added inline comments to D6693: fix: ignore fixer tool configurations that are missing patterns.
Jul 25 2019, 9:01 PM

Jul 24 2019

hooper created D6693: fix: ignore fixer tool configurations that are missing patterns.
Jul 24 2019, 7:39 PM
hooper created D6692: fix: add a test case around the effect of cwd on pattern matching.
Jul 24 2019, 7:39 PM
hooper created D6691: fix: remove support for :fileset sub-config in favor of :pattern.
Jul 24 2019, 7:39 PM

May 23 2019

hooper added inline comments to D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
May 23 2019, 9:02 PM
hooper closed D6439: test: add missing 'cd ..' to test case.
May 23 2019, 7:49 AM
hooper committed rHGb02f3aa2fab5: test: add missing 'cd ..' to test case.
test: add missing 'cd ..' to test case
May 23 2019, 7:49 AM

May 22 2019

hooper created D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
May 22 2019, 8:00 PM
hooper created D6439: test: add missing 'cd ..' to test case.
May 22 2019, 8:00 PM
hooper closed D6414: narrow: consider empty commits to be "inside the narrow spec" for templates.
May 22 2019, 12:27 PM
hooper committed rHG45c18f7345c1: narrow: consider empty commits to be "inside the narrow spec" for templates.
narrow: consider empty commits to be "inside the narrow spec" for templates
May 22 2019, 12:27 PM

May 20 2019

hooper created D6414: narrow: consider empty commits to be "inside the narrow spec" for templates.
May 20 2019, 9:19 PM

Apr 27 2019

hooper closed D6313: remotefilelog: add missing argument to hg.verify wrapper.
Apr 27 2019, 6:28 AM
hooper committed rHGbed4c308fc56: remotefilelog: add missing argument to hg.verify wrapper.
remotefilelog: add missing argument to hg.verify wrapper
Apr 27 2019, 6:28 AM

Apr 26 2019

hooper created D6313: remotefilelog: add missing argument to hg.verify wrapper.
Apr 26 2019, 8:43 PM

Apr 23 2019

hooper closed D6167: fix: allow fixer tools to return metadata in addition to the file content.
Apr 23 2019, 5:19 PM
hooper committed rHG0da689a60163: fix: allow fixer tools to return metadata in addition to the file content.
fix: allow fixer tools to return metadata in addition to the file content
Apr 23 2019, 5:18 PM
hooper added inline comments to D6167: fix: allow fixer tools to return metadata in addition to the file content.
Apr 23 2019, 4:51 PM
hooper updated the diff for D6167: fix: allow fixer tools to return metadata in addition to the file content.
Apr 23 2019, 4:51 PM

Mar 23 2019

hooper closed D6165: fix: allow fixing untracked files when given as arguments.
Mar 23 2019, 11:46 AM
hooper committed rHG8f427f7c1f71: fix: make the order of the work queue deterministic.
fix: make the order of the work queue deterministic
Mar 23 2019, 11:46 AM
hooper committed rHG7f6b375a8903: fix: allow fixing untracked files when given as arguments.
fix: allow fixing untracked files when given as arguments
Mar 23 2019, 11:46 AM
hooper closed D6166: fix: make the order of the work queue deterministic.
Mar 23 2019, 11:46 AM

Mar 21 2019

hooper abandoned D5516: fix: add some arguments to facilitate extensions.

See D6167 for a newer approach.

Mar 21 2019, 10:58 PM
hooper created D6167: fix: allow fixer tools to return metadata in addition to the file content.
Mar 21 2019, 10:57 PM
hooper created D6165: fix: allow fixing untracked files when given as arguments.
Mar 21 2019, 10:57 PM
hooper created D6166: fix: make the order of the work queue deterministic.
Mar 21 2019, 10:57 PM

Jan 9 2019

hooper added a comment to D5516: fix: add some arguments to facilitate extensions.
In D5516#81683, @hooper wrote:

I'm -0 on this: what's special about this functionality that it needs to be an extension of an extension instead of something that can be done in core?

Google's internal use of this extension makes some customizations that I doubt would be appealing in core. This patch makes some of it simpler to implement. Making all of it possible through configs/templates might be unduly complex.

What kinds of customizations?

Jan 9 2019, 3:15 PM

Jan 7 2019

hooper added a comment to D5516: fix: add some arguments to facilitate extensions.

I'm -0 on this: what's special about this functionality that it needs to be an extension of an extension instead of something that can be done in core?

Jan 7 2019, 7:12 PM
hooper closed D5517: tests: use more portable flags in test-fix.t.
Jan 7 2019, 6:59 PM
hooper committed rHGd8f5c615e811: tests: use more portable flags in test-fix.t.
tests: use more portable flags in test-fix.t
Jan 7 2019, 6:58 PM
hooper created D5517: tests: use more portable flags in test-fix.t.
Jan 7 2019, 6:26 PM
hooper created D5516: fix: add some arguments to facilitate extensions.
Jan 7 2019, 6:04 PM

Dec 16 2018

hooper committed rHGe993a86cfcb8: absorb: don't prompt to apply changes when there are none to apply.
absorb: don't prompt to apply changes when there are none to apply
Dec 16 2018, 3:27 AM

Dec 14 2018

hooper closed D5428: absorb: don't prompt to apply changes when there are none to apply.
Dec 14 2018, 8:36 PM
hooper committed rHGa08e12149bcb: absorb: don't prompt to apply changes when there are none to apply.
absorb: don't prompt to apply changes when there are none to apply
Dec 14 2018, 8:36 PM
hooper created D5428: absorb: don't prompt to apply changes when there are none to apply.
Dec 14 2018, 3:58 PM

Nov 9 2018

hooper closed D5245: fix: add extra field to fixed revisions to avoid creating obsolescence cycles.
Nov 9 2018, 7:18 AM
hooper closed D5244: cleanup: use revision numbers instead of hashes in test output.
Nov 9 2018, 7:18 AM
hooper committed rHGad71c792a8d8: fix: add extra field to fixed revisions to avoid creating obsolescence cycles.
fix: add extra field to fixed revisions to avoid creating obsolescence cycles
Nov 9 2018, 7:18 AM
hooper committed rHG19e1c26213f1: cleanup: use revision numbers instead of hashes in test output.
cleanup: use revision numbers instead of hashes in test output
Nov 9 2018, 7:18 AM

Nov 8 2018

hooper created D5245: fix: add extra field to fixed revisions to avoid creating obsolescence cycles.
Nov 8 2018, 4:32 PM
hooper created D5244: cleanup: use revision numbers instead of hashes in test output.
Nov 8 2018, 4:32 PM
hooper closed D5237: fix: add suboption for configuring execution order of tools.
Nov 8 2018, 6:54 AM
hooper committed rHGb9557567cc3f: fix: add suboption for configuring execution order of tools.
fix: add suboption for configuring execution order of tools
Nov 8 2018, 6:53 AM

Nov 7 2018

hooper updated the diff for D5237: fix: add suboption for configuring execution order of tools.
Nov 7 2018, 5:05 PM

Nov 6 2018

hooper updated the diff for D5237: fix: add suboption for configuring execution order of tools.
Nov 6 2018, 9:03 PM
hooper created D5237: fix: add suboption for configuring execution order of tools.
Nov 6 2018, 9:02 PM