Page MenuHomePhabricator

hooper (Danny Hooper)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2017, 7:50 PM (105 w, 1 d)

Recent Activity

Yesterday

hooper committed rHGe9f503074044: fix: pass line ranges as value instead of callback.
fix: pass line ranges as value instead of callback
Sat, Aug 17, 2:50 AM
hooper committed rHG2d70b1118af2: fix: correctly parse the :metadata subconfig.
fix: correctly parse the :metadata subconfig
Sat, Aug 17, 2:50 AM
hooper committed rHGed0da6e0d6ee: fix: allow tools to use :linerange, but also run if a file is unchanged.
fix: allow tools to use :linerange, but also run if a file is unchanged
Sat, Aug 17, 2:50 AM

Wed, Aug 14

hooper closed D6726: fix: correctly parse the :metadata subconfig.
Wed, Aug 14, 4:43 PM
hooper closed D6727: fix: pass line ranges as value instead of callback.
Wed, Aug 14, 4:43 PM
hooper closed D6723: fix: allow tools to use :linerange, but also run if a file is unchanged.
Wed, Aug 14, 4:43 PM
hooper committed rHG64a0cb2d4692: fix: pass line ranges as value instead of callback.
fix: pass line ranges as value instead of callback
Wed, Aug 14, 4:43 PM
hooper committed rHGd82e9f7e7440: fix: correctly parse the :metadata subconfig.
fix: correctly parse the :metadata subconfig
Wed, Aug 14, 4:42 PM
hooper committed rHG69b37b7227f2: fix: allow tools to use :linerange, but also run if a file is unchanged.
fix: allow tools to use :linerange, but also run if a file is unchanged
Wed, Aug 14, 4:42 PM
hooper created D6727: fix: pass line ranges as value instead of callback.
Wed, Aug 14, 4:29 PM
hooper created D6726: fix: correctly parse the :metadata subconfig.
Wed, Aug 14, 4:17 PM

Tue, Aug 13

hooper updated the diff for D6723: fix: allow tools to use :linerange, but also run if a file is unchanged.
Tue, Aug 13, 6:21 PM

Mon, Aug 12

hooper created D6723: fix: allow tools to use :linerange, but also run if a file is unchanged.
Mon, Aug 12, 7:40 PM

Thu, Aug 1

hooper closed D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
Thu, Aug 1, 2:46 PM
hooper committed rHG74b4cd091e0d: fix: run fixer tools in the repo root as cwd so they can use the working copy.
fix: run fixer tools in the repo root as cwd so they can use the working copy
Thu, Aug 1, 2:46 PM

Mon, Jul 29

hooper closed D6698: fix: add some new test cases.
Mon, Jul 29, 6:31 AM
hooper committed rHG4b04244f2d5f: fix: add some new test cases.
fix: add some new test cases
Mon, Jul 29, 6:31 AM

Fri, Jul 26

hooper added a comment to D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.

I still think we should fix the cwd for fixers, but it seems Martin and I agree that repo-root is more consistent. Would you be willing to reroll with repo-root instead of cwd?

Fri, Jul 26, 1:59 PM
hooper updated the diff for D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
Fri, Jul 26, 1:58 PM
hooper created D6698: fix: add some new test cases.
Fri, Jul 26, 1:48 PM
hooper closed D6693: fix: ignore fixer tool configurations that are missing patterns.
Fri, Jul 26, 12:05 PM
hooper closed D6692: fix: add a test case around the effect of cwd on pattern matching.
Fri, Jul 26, 12:05 PM
hooper closed D6691: fix: remove support for :fileset sub-config in favor of :pattern.
Fri, Jul 26, 12:05 PM
hooper committed rHG2987d015aba4: fix: ignore fixer tool configurations that are missing patterns.
fix: ignore fixer tool configurations that are missing patterns
Fri, Jul 26, 12:05 PM
hooper committed rHG22c4bd7d1cbf: fix: add a test case around the effect of cwd on pattern matching.
fix: add a test case around the effect of cwd on pattern matching
Fri, Jul 26, 12:05 PM
hooper committed rHG9ed63cd0026c: fix: remove support for :fileset sub-config in favor of :pattern.
fix: remove support for :fileset sub-config in favor of :pattern
Fri, Jul 26, 12:05 PM

Thu, Jul 25

hooper added inline comments to D6693: fix: ignore fixer tool configurations that are missing patterns.
Thu, Jul 25, 9:01 PM

Wed, Jul 24

hooper created D6693: fix: ignore fixer tool configurations that are missing patterns.
Wed, Jul 24, 7:39 PM
hooper created D6692: fix: add a test case around the effect of cwd on pattern matching.
Wed, Jul 24, 7:39 PM
hooper created D6691: fix: remove support for :fileset sub-config in favor of :pattern.
Wed, Jul 24, 7:39 PM

May 23 2019

hooper added inline comments to D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
May 23 2019, 9:02 PM
hooper closed D6439: test: add missing 'cd ..' to test case.
May 23 2019, 7:49 AM
hooper committed rHGb02f3aa2fab5: test: add missing 'cd ..' to test case.
test: add missing 'cd ..' to test case
May 23 2019, 7:49 AM

May 22 2019

hooper created D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy.
May 22 2019, 8:00 PM
hooper created D6439: test: add missing 'cd ..' to test case.
May 22 2019, 8:00 PM
hooper closed D6414: narrow: consider empty commits to be "inside the narrow spec" for templates.
May 22 2019, 12:27 PM
hooper committed rHG45c18f7345c1: narrow: consider empty commits to be "inside the narrow spec" for templates.
narrow: consider empty commits to be "inside the narrow spec" for templates
May 22 2019, 12:27 PM

May 20 2019

hooper created D6414: narrow: consider empty commits to be "inside the narrow spec" for templates.
May 20 2019, 9:19 PM

Apr 27 2019

hooper closed D6313: remotefilelog: add missing argument to hg.verify wrapper.
Apr 27 2019, 6:28 AM
hooper committed rHGbed4c308fc56: remotefilelog: add missing argument to hg.verify wrapper.
remotefilelog: add missing argument to hg.verify wrapper
Apr 27 2019, 6:28 AM

Apr 26 2019

hooper created D6313: remotefilelog: add missing argument to hg.verify wrapper.
Apr 26 2019, 8:43 PM

Apr 23 2019

hooper closed D6167: fix: allow fixer tools to return metadata in addition to the file content.
Apr 23 2019, 5:19 PM
hooper committed rHG0da689a60163: fix: allow fixer tools to return metadata in addition to the file content.
fix: allow fixer tools to return metadata in addition to the file content
Apr 23 2019, 5:18 PM
hooper added inline comments to D6167: fix: allow fixer tools to return metadata in addition to the file content.
Apr 23 2019, 4:51 PM
hooper updated the diff for D6167: fix: allow fixer tools to return metadata in addition to the file content.
Apr 23 2019, 4:51 PM

Mar 23 2019

hooper closed D6165: fix: allow fixing untracked files when given as arguments.
Mar 23 2019, 11:46 AM
hooper committed rHG8f427f7c1f71: fix: make the order of the work queue deterministic.
fix: make the order of the work queue deterministic
Mar 23 2019, 11:46 AM
hooper committed rHG7f6b375a8903: fix: allow fixing untracked files when given as arguments.
fix: allow fixing untracked files when given as arguments
Mar 23 2019, 11:46 AM
hooper closed D6166: fix: make the order of the work queue deterministic.
Mar 23 2019, 11:46 AM

Mar 21 2019

hooper abandoned D5516: fix: add some arguments to facilitate extensions.

See D6167 for a newer approach.

Mar 21 2019, 10:58 PM
hooper created D6167: fix: allow fixer tools to return metadata in addition to the file content.
Mar 21 2019, 10:57 PM
hooper created D6165: fix: allow fixing untracked files when given as arguments.
Mar 21 2019, 10:57 PM
hooper created D6166: fix: make the order of the work queue deterministic.
Mar 21 2019, 10:57 PM

Jan 9 2019

hooper added a comment to D5516: fix: add some arguments to facilitate extensions.
In D5516#81683, @hooper wrote:

I'm -0 on this: what's special about this functionality that it needs to be an extension of an extension instead of something that can be done in core?

Google's internal use of this extension makes some customizations that I doubt would be appealing in core. This patch makes some of it simpler to implement. Making all of it possible through configs/templates might be unduly complex.

What kinds of customizations?

Jan 9 2019, 3:15 PM

Jan 7 2019

hooper added a comment to D5516: fix: add some arguments to facilitate extensions.

I'm -0 on this: what's special about this functionality that it needs to be an extension of an extension instead of something that can be done in core?

Jan 7 2019, 7:12 PM
hooper closed D5517: tests: use more portable flags in test-fix.t.
Jan 7 2019, 6:59 PM
hooper committed rHGd8f5c615e811: tests: use more portable flags in test-fix.t.
tests: use more portable flags in test-fix.t
Jan 7 2019, 6:58 PM
hooper created D5517: tests: use more portable flags in test-fix.t.
Jan 7 2019, 6:26 PM
hooper created D5516: fix: add some arguments to facilitate extensions.
Jan 7 2019, 6:04 PM

Dec 16 2018

hooper committed rHGe993a86cfcb8: absorb: don't prompt to apply changes when there are none to apply.
absorb: don't prompt to apply changes when there are none to apply
Dec 16 2018, 3:27 AM

Dec 14 2018

hooper closed D5428: absorb: don't prompt to apply changes when there are none to apply.
Dec 14 2018, 8:36 PM
hooper committed rHGa08e12149bcb: absorb: don't prompt to apply changes when there are none to apply.
absorb: don't prompt to apply changes when there are none to apply
Dec 14 2018, 8:36 PM
hooper created D5428: absorb: don't prompt to apply changes when there are none to apply.
Dec 14 2018, 3:58 PM

Nov 9 2018

hooper closed D5245: fix: add extra field to fixed revisions to avoid creating obsolescence cycles.
Nov 9 2018, 7:18 AM
hooper closed D5244: cleanup: use revision numbers instead of hashes in test output.
Nov 9 2018, 7:18 AM
hooper committed rHGad71c792a8d8: fix: add extra field to fixed revisions to avoid creating obsolescence cycles.
fix: add extra field to fixed revisions to avoid creating obsolescence cycles
Nov 9 2018, 7:18 AM
hooper committed rHG19e1c26213f1: cleanup: use revision numbers instead of hashes in test output.
cleanup: use revision numbers instead of hashes in test output
Nov 9 2018, 7:18 AM

Nov 8 2018

hooper created D5245: fix: add extra field to fixed revisions to avoid creating obsolescence cycles.
Nov 8 2018, 4:32 PM
hooper created D5244: cleanup: use revision numbers instead of hashes in test output.
Nov 8 2018, 4:32 PM
hooper closed D5237: fix: add suboption for configuring execution order of tools.
Nov 8 2018, 6:54 AM
hooper committed rHGb9557567cc3f: fix: add suboption for configuring execution order of tools.
fix: add suboption for configuring execution order of tools
Nov 8 2018, 6:53 AM

Nov 7 2018

hooper updated the diff for D5237: fix: add suboption for configuring execution order of tools.
Nov 7 2018, 5:05 PM

Nov 6 2018

hooper updated the diff for D5237: fix: add suboption for configuring execution order of tools.
Nov 6 2018, 9:03 PM
hooper created D5237: fix: add suboption for configuring execution order of tools.
Nov 6 2018, 9:02 PM
hooper closed D5226: fix: rename :fileset subconfig to :pattern.
Nov 6 2018, 6:53 AM
hooper closed D5200: fix: add a config to abort when a fixer tool fails.
Nov 6 2018, 6:53 AM
hooper committed rHG2ecf5c24d0cd: fix: rename :fileset subconfig to :pattern.
fix: rename :fileset subconfig to :pattern
Nov 6 2018, 6:53 AM
hooper committed rHG93bab80993f4: fix: add a config to abort when a fixer tool fails.
fix: add a config to abort when a fixer tool fails
Nov 6 2018, 6:53 AM

Nov 5 2018

hooper updated the diff for D5226: fix: rename :fileset subconfig to :pattern.
Nov 5 2018, 7:46 PM
hooper created D5226: fix: rename :fileset subconfig to :pattern.
Nov 5 2018, 7:21 PM
hooper added a comment to D5200: fix: add a config to abort when a fixer tool fails.
In D5200#77865, @yuja wrote:

Looks good, but test-check-config.t failed probably because the doc couldn't
be found by the checker.

Nov 5 2018, 6:50 PM
hooper updated the diff for D5200: fix: add a config to abort when a fixer tool fails.
Nov 5 2018, 6:49 PM

Oct 31 2018

hooper created D5200: fix: add a config to abort when a fixer tool fails.
Oct 31 2018, 4:16 PM
hooper committed rHGc2a0bc6412db: beautifygraph: don't substitute anything for 'X' in rendered graphs.
beautifygraph: don't substitute anything for 'X' in rendered graphs
Oct 31 2018, 2:02 PM
hooper closed D5103: beautifygraph: don't substitute anything for 'X' in rendered graphs.
Oct 31 2018, 2:02 PM

Oct 30 2018

hooper added a comment to D5102: beautifygraph: add configs for customizing the characters.

I'll elaborate a bit. I think the idea of using unicode to make the graph good looking is flawed. There are no characters that properly serve common cases like this:

Oct 30 2018, 5:29 PM

Oct 14 2018

hooper updated the diff for D5102: beautifygraph: add configs for customizing the characters.
Oct 14 2018, 10:18 AM
hooper created D5102: beautifygraph: add configs for customizing the characters.
Oct 14 2018, 8:22 AM
hooper created D5103: beautifygraph: don't substitute anything for 'X' in rendered graphs.
Oct 14 2018, 8:22 AM

Aug 9 2018

hooper closed D4158: fix: determine fixer tool failure by exit code instead of stderr.
Aug 9 2018, 2:06 PM
hooper committed rHGa009589cd32a: fix: determine fixer tool failure by exit code instead of stderr.
fix: determine fixer tool failure by exit code instead of stderr
Aug 9 2018, 2:06 PM

Aug 8 2018

hooper created D4158: fix: determine fixer tool failure by exit code instead of stderr.
Aug 8 2018, 4:09 PM
hooper committed rHG35bc4b6e132d: fix: correctly set wdirwritten given that the dict item is deleted.
fix: correctly set wdirwritten given that the dict item is deleted
Aug 8 2018, 8:10 AM
hooper closed D4146: fix: correctly set wdirwritten given that the dict item is deleted.
Aug 8 2018, 8:10 AM
hooper committed rHGb0c591950e51: fix: pull out flag definitions to make them re-usable from extensions.
fix: pull out flag definitions to make them re-usable from extensions
Aug 8 2018, 8:10 AM
hooper closed D4145: fix: pull out flag definitions to make them re-usable from extensions.
Aug 8 2018, 8:10 AM

Aug 6 2018

hooper created D4146: fix: correctly set wdirwritten given that the dict item is deleted.
Aug 6 2018, 7:52 PM
hooper created D4145: fix: pull out flag definitions to make them re-usable from extensions.
Aug 6 2018, 7:52 PM

Aug 4 2018

hooper committed rHG257c9846b532: fix: compute changed lines lazily to make whole-file fixer tools faster.
fix: compute changed lines lazily to make whole-file fixer tools faster
Aug 4 2018, 1:38 PM
hooper closed D4100: fix: compute changed lines lazily to make whole-file fixer tools faster.
Aug 4 2018, 1:38 PM