Page MenuHomePhabricator

idlsoft (Sandu Turcan)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 8 2018, 1:15 PM (80 w, 3 d)

Recent Activity

Apr 25 2019

idlsoft added inline comments to D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).
Apr 25 2019, 2:12 PM
idlsoft added inline comments to D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).
Apr 25 2019, 2:10 PM

Apr 24 2019

idlsoft added inline comments to D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).
Apr 24 2019, 2:49 PM

Apr 18 2019

idlsoft added a comment to D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).

This is nitpicking, but there is a duplicate _NARROWACL_SECTION definition in narrowbundle2.py,
I think only the one in exchange.py should remain.
Btw it's still 'narrowhgacl' from the old days.

Apr 18 2019, 10:43 AM

Apr 17 2019

idlsoft added a comment to D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).

If ACL is enabled, processing this part is mandatory, yes.
On clone, or pull the user doesn't specify includes, so reading this part is the only way the client can get them.

Apr 17 2019, 1:09 PM
idlsoft added a comment to D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).

Because the current client ignores the data completely, the only way to force it to fail I think is to change the name of the part.
This would make things cleaner probably, but I'll deal with whatever solution you guys settle on.

Apr 17 2019, 12:37 PM

Dec 6 2018

idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.
In D4312#79938, @smf wrote:

This will not help the *average* user and sends a mixed (and dangerous) message that bookmarks should be used.

Bookmarks have been in core for some time now, and there is not one mention anywhere that they are not to be used.
They may not be trivial to use but it's certainly not officially discouraged anywhere.
Bookmarks is the first thing that comes up when you search for "mercurial light branching", although it's from a blog post, not the official wiki.
Meanwhile the official wiki plainly states that light branching is a different abstraction, and branches should not be used for for that.

Dec 6 2018, 7:27 PM

Dec 5 2018

idlsoft committed rHG9cec7a36bab8: bookflow: new extension for bookmark-based branching.
bookflow: new extension for bookmark-based branching
Dec 5 2018, 6:57 AM

Dec 4 2018

idlsoft committed rHGc8efcddcdeee: bookflow: new extension for bookmark-based branching.
bookflow: new extension for bookmark-based branching
Dec 4 2018, 5:20 PM
idlsoft committed rHGff8bca5670b6: bookflow: new extension for bookmark-based branching.
bookflow: new extension for bookmark-based branching
Dec 4 2018, 10:41 AM
idlsoft committed rHGd5581f32d199: bookflow: new extension for bookmark-based branching.
bookflow: new extension for bookmark-based branching
Dec 4 2018, 9:54 AM

Dec 3 2018

idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.

Obviously, I can't say I'm too happy with this. Allowing users to shoot themselves in the foot even more is pretty bad.

I don't think that's fair.
Everyone's experience is different, but it did precisely the opposite for us.

Dec 3 2018, 10:11 PM
idlsoft closed D4312: New bookflow extension for bookmark-based branching.
Dec 3 2018, 2:56 PM
idlsoft committed rHGe44e6b37b6af: bookflow: new extension for bookmark-based branching.
bookflow: new extension for bookmark-based branching
Dec 3 2018, 2:56 PM

Oct 25 2018

idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.

@smf I just noticed your name on https://www.mercurial-scm.org/wiki/BookmarkUpdatePlan, which puts your comments into a larger context.
This would definitely be an improvement, and reduce the scope of what this extension does.
Would you consider also addressing the hg bookmark NAME doing two very different things depending on the bookmark already existing?

Oct 25 2018, 11:03 AM

Oct 20 2018

idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.

Were there particular pain points before? The list of things to polish isn't short, but I don't mind reprioritizing things if it helps.

Oct 20 2018, 10:12 PM

Oct 18 2018

idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.
In D4312#77084, @pulkit wrote:

Unrelated, do you use narrow with ellipses or without ellipses? Also I am sorry to say but in this cycle, narrow extension has under gone a lot of perf and correctness improvements and it won't be backward compatible in upcoming release. I will be writing some text about this in the releasenotes too, and you can contact me personally and I will be glad to help you with the BC changes.

Oct 18 2018, 3:49 PM
idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.

First of all, thank you for reviewing the patch.

Oct 18 2018, 1:25 PM

Oct 15 2018

idlsoft updated the diff for D4312: New bookflow extension for bookmark-based branching.
Oct 15 2018, 9:48 AM
idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.

If this is accepted we might want to look into changing the behavior of hg pull -u.
It should update the working directory only if the active bookmark was moved remotely.
I didn't find an easy way to do this without changes to core.

Oct 15 2018, 8:04 AM
idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.

At some point RhodeCode was checking if the destination bookmark was a descendant of the source, and not allowing such pull requests to be created.
That would have to be handled as a fast-forward, in other words just moving the destination bookmark.

Oct 15 2018, 8:01 AM

Sep 5 2018

idlsoft updated the diff for D4312: New bookflow extension for bookmark-based branching.
Sep 5 2018, 10:04 AM

Sep 4 2018

idlsoft updated the diff for D4312: New bookflow extension for bookmark-based branching.
Sep 4 2018, 1:34 PM
idlsoft added inline comments to D4312: New bookflow extension for bookmark-based branching.
Sep 4 2018, 11:36 AM

Sep 2 2018

idlsoft added a comment to D4312: New bookflow extension for bookmark-based branching.

I added some inline comments.
A test for hg book EXISTING is indeed missing, there is, however, one for not moving the bookmark on update, it's line 52: (leaving bookmark X).
Hopefully, I'll be able to make some changes later in the week.
Was not aware about the wiki page, this indeed seems to be addressing the same problem. At least that's how it started., and later evolved into something that helps you follow the workflow.

Sep 2 2018, 1:00 AM

Aug 22 2018

idlsoft updated the diff for D4312: New bookflow extension for bookmark-based branching.
Aug 22 2018, 11:57 AM
idlsoft updated the diff for D4312: New bookflow extension for bookmark-based branching.
Aug 22 2018, 10:16 AM
idlsoft updated the diff for D4312: New bookflow extension for bookmark-based branching.
Aug 22 2018, 10:12 AM
idlsoft abandoned D4353: bookflow: support shelve and enforce working directory pointing to the active bookmark.

Created a new one instead of updating D4312

Aug 22 2018, 10:03 AM
idlsoft created D4353: bookflow: support shelve and enforce working directory pointing to the active bookmark.
Aug 22 2018, 10:02 AM

Aug 18 2018

idlsoft abandoned D4311: New bookflow extension for bookmark-based branching.
Aug 18 2018, 11:13 AM

Aug 17 2018

idlsoft updated the summary of D4312: New bookflow extension for bookmark-based branching.
Aug 17 2018, 12:40 AM

Aug 16 2018

idlsoft created D4312: New bookflow extension for bookmark-based branching.
Aug 16 2018, 7:16 PM
idlsoft added a comment to D4311: New bookflow extension for bookmark-based branching.

This was submitted in error, not sure how to delete it.

Aug 16 2018, 7:10 PM
idlsoft created D4311: New bookflow extension for bookmark-based branching.
Aug 16 2018, 7:06 PM

Jul 3 2018

idlsoft closed D3750: ACL: added bookmarks support (from https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-March/080650.html).
Jul 3 2018, 2:12 PM
idlsoft committed rHG6beb8347b709: acl: add bookmarks support.
acl: add bookmarks support
Jul 3 2018, 2:11 PM

Jun 15 2018

idlsoft created D3750: ACL: added bookmarks support (from https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-March/080650.html).
Jun 15 2018, 2:50 PM

Feb 15 2018

idlsoft added inline comments to D2231: narrow: fix for getting the username when running http server.
Feb 15 2018, 7:01 PM

Feb 13 2018

idlsoft committed rHG4224f26c0d35: narrow: fix for getting the username when running http server.
narrow: fix for getting the username when running http server
Feb 13 2018, 4:07 PM
idlsoft closed D2231: narrow: fix for getting the username when running http server.
Feb 13 2018, 4:07 PM
idlsoft created D2231: narrow: fix for getting the username when running http server.
Feb 13 2018, 2:40 PM

Feb 8 2018

idlsoft added inline comments to D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5.
Feb 8 2018, 1:52 PM