Page MenuHomePhabricator

ikostia (Kostia Balytskyi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2017, 5:14 PM (125 w, 5 d)

Recent Activity

Dec 18 2017

ikostia accepted D1712: indexes: add comment indication location of python27-sys.

I just want people to know that this is not good.

Dec 18 2017, 6:53 AM

Dec 17 2017

ikostia committed rHG31d21309635b: sshpeer: allow for additional environment passing to ssh exe.
sshpeer: allow for additional environment passing to ssh exe
Dec 17 2017, 2:27 PM

Dec 15 2017

ikostia closed D1683: sshpeer: allow for additional environment passing to ssh exe.
Dec 15 2017, 4:15 PM
ikostia committed rHG47921dafb44b: sshpeer: allow for additional environment passing to ssh exe.
sshpeer: allow for additional environment passing to ssh exe
Dec 15 2017, 4:15 PM
ikostia closed D1684: hgext3rd: make compatible with core change 8a0cac20a1ad.
Dec 15 2017, 2:34 PM
ikostia committed rFBHGX8531cbf59d5f: hgext3rd: make compatible with core change 8a0cac20a1ad.
hgext3rd: make compatible with core change 8a0cac20a1ad
Dec 15 2017, 2:33 PM
ikostia closed D1685: sshaskpass: support sshenv configs as core does.
Dec 15 2017, 2:33 PM
ikostia committed rFBHGXe1b854ebc226: sshaskpass: support sshenv configs as core does.
sshaskpass: support sshenv configs as core does
Dec 15 2017, 2:33 PM

Dec 14 2017

ikostia created D1685: sshaskpass: support sshenv configs as core does.
Dec 14 2017, 1:38 PM
ikostia created D1684: hgext3rd: make compatible with core change 8a0cac20a1ad.
Dec 14 2017, 1:36 PM
ikostia created D1683: sshpeer: allow for additional environment passing to ssh exe.
Dec 14 2017, 9:39 AM

Dec 13 2017

ikostia abandoned D1667: tests_: fix test-lfs.t on OSX where find does not have quotes.

@quark: thanks for the tests note.

Dec 13 2017, 5:24 AM

Dec 12 2017

ikostia closed D1664: pushrebase: address missed phab comment.
Dec 12 2017, 7:26 PM
ikostia closed D1660: pushrebase: set legacy.exchange config when pushrebase is used.
Dec 12 2017, 7:26 PM
ikostia closed D1659: tests_: make tests aware of the new capability.
Dec 12 2017, 7:26 PM
ikostia committed rFBHGX9c0f972be4ce: pushrebase: address missed phab comment.
pushrebase: address missed phab comment
Dec 12 2017, 7:26 PM
ikostia closed D1655: pushrebase: remove check-bookmarks parts generator.
Dec 12 2017, 7:26 PM
ikostia committed rFBHGXef4822445810: pushrebase: set legacy.exchange config when pushrebase is used.
pushrebase: set legacy.exchange config when pushrebase is used
Dec 12 2017, 7:25 PM
ikostia committed rFBHGX48b05e27c878: tests_: make tests aware of the new capability.
tests_: make tests aware of the new capability
Dec 12 2017, 7:25 PM
ikostia committed rFBHGX473dc7b7661a: pushrebase: remove check-bookmarks parts generator.
pushrebase: remove check-bookmarks parts generator
Dec 12 2017, 7:25 PM
ikostia committed rFBHGXccb7df352f67: distutils_rust: teach distutils to look for windows libs.
distutils_rust: teach distutils to look for windows libs
Dec 12 2017, 7:25 PM
ikostia closed D1590: distutils_rust: teach distutils to look for windows libs.
Dec 12 2017, 7:25 PM
ikostia created D1667: tests_: fix test-lfs.t on OSX where find does not have quotes.
Dec 12 2017, 2:42 PM

Dec 11 2017

ikostia created D1664: pushrebase: address missed phab comment.
Dec 11 2017, 5:07 PM
ikostia created D1660: pushrebase: set legacy.exchange config when pushrebase is used.
Dec 11 2017, 2:17 PM
ikostia created D1659: tests_: make tests aware of the new capability.
Dec 11 2017, 1:21 PM
ikostia requested review of D1655: pushrebase: remove check-bookmarks parts generator.

This is needed, but only fixes tests together with the other fixes, so the description is slightly incorrect.

Dec 11 2017, 1:15 PM
ikostia planned changes to D1655: pushrebase: remove check-bookmarks parts generator.
Dec 11 2017, 12:55 PM
ikostia created D1655: pushrebase: remove check-bookmarks parts generator.
Dec 11 2017, 12:37 PM
ikostia accepted D1654: treedirstate: ensure appended data is flushed to disk.
Dec 11 2017, 11:29 AM

Dec 6 2017

ikostia accepted D1602: distutils_rust: support windows python extension filenames.
Dec 6 2017, 6:54 AM

Dec 5 2017

ikostia updated the diff for D1590: distutils_rust: teach distutils to look for windows libs.

address Jun's comment

Dec 5 2017, 3:57 PM
ikostia created D1590: distutils_rust: teach distutils to look for windows libs.
Dec 5 2017, 7:10 AM

Dec 1 2017

ikostia accepted D1460: workers: add config to enable/diable workers.
Dec 1 2017, 11:12 AM
ikostia accepted D1564: worker: make windows workers daemons.
Dec 1 2017, 11:11 AM

Nov 30 2017

ikostia accepted D1564: worker: make windows workers daemons.

This *looks* reasonable to me, but I am afraid I could be missing something important. Anyway, since we can turn it off via a config, I'd say it's good to be in the hotfixes.

Nov 30 2017, 4:10 PM
ikostia added inline comments to D1543: repack: move to flock based locking.
Nov 30 2017, 6:31 AM

Nov 28 2017

ikostia accepted D1529: tests: update githelp test.
Nov 28 2017, 7:49 AM

Nov 27 2017

ikostia closed D1467: remotefilelog: implement threaded _getfiles.
Nov 27 2017, 7:02 AM
ikostia closed D1491: phabricator: fix lint warning.
Nov 27 2017, 7:02 AM
ikostia committed rFBHGX28b19ae1f16c: phabricator: fix lint warning.
phabricator: fix lint warning
Nov 27 2017, 7:02 AM
ikostia committed rFBHGXbdfae9b06013: remotefilelog: implement threaded _getfiles.
remotefilelog: implement threaded _getfiles
Nov 27 2017, 7:02 AM

Nov 26 2017

ikostia accepted D1513: remotefilelog: keep metacache per thread.
Nov 26 2017, 3:02 AM

Nov 22 2017

ikostia created D1491: phabricator: fix lint warning.
Nov 22 2017, 6:14 PM
ikostia updated the diff for D1467: remotefilelog: implement threaded _getfiles.

make optimistic by default

Nov 22 2017, 5:09 PM

Nov 21 2017

ikostia closed D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
Nov 21 2017, 5:12 PM
ikostia committed rFBHGX865278d80ace: tweakdefaults: make util.popen4 input buffer size configurable on Windows.
tweakdefaults: make util.popen4 input buffer size configurable on Windows
Nov 21 2017, 5:12 PM
ikostia accepted D1448: revset: optimize "head() & draft()" to "heads(draft())".
Nov 21 2017, 1:26 AM

Nov 20 2017

ikostia updated the diff for D1467: remotefilelog: implement threaded _getfiles.

hiding behind a config

Nov 20 2017, 6:26 PM
ikostia created D1467: remotefilelog: implement threaded _getfiles.
Nov 20 2017, 5:47 PM
ikostia updated the diff for D1453: remotefilelog: never deadlock on writing to a pipe.

remove unnecessary condition

Nov 20 2017, 12:27 PM

Nov 19 2017

ikostia retitled D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows from remotefilelog: set subprocess pipei buffer size to 65536 on Windows to remotefilelog: make subprocess pipei buffer size configurable on Windows.
Nov 19 2017, 4:03 PM
ikostia created D1453: remotefilelog: never deadlock on writing to a pipe.
Nov 19 2017, 4:00 PM
ikostia updated the diff for D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.

rewrite

Nov 19 2017, 2:58 PM

Nov 17 2017

ikostia abandoned D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.

This is entirely wrong.

Nov 17 2017, 2:06 PM
ikostia planned changes to D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
Nov 17 2017, 2:02 PM
ikostia requested review of D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.

Tested.

Nov 17 2017, 12:14 PM
ikostia updated the test plan for D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
Nov 17 2017, 12:14 PM

Nov 16 2017

ikostia planned changes to D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
Nov 16 2017, 1:49 PM
ikostia updated the diff for D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.

hide behind a config knob

Nov 16 2017, 1:49 PM
ikostia planned changes to D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
Nov 16 2017, 1:01 PM
ikostia created D1436: remotefilelog: make subprocess pipei buffer size configurable on Windows.
Nov 16 2017, 12:58 PM

Nov 2 2017

ikostia accepted D1279: tests: handle case in test-remotefilelog-clone.t where output is out of order.
Nov 2 2017, 10:22 AM

Oct 30 2017

ikostia committed rHG5caae380ff90: filemerge: pass a default value to _toolstr (issue5718).
filemerge: pass a default value to _toolstr (issue5718)
Oct 30 2017, 10:42 PM

Oct 25 2017

ikostia committed rFBHGX5145f78427e3: test-merge-conflictinfo: include expected failures according to sid's hotfix.
test-merge-conflictinfo: include expected failures according to sid's hotfix
Oct 25 2017, 8:29 PM

Oct 20 2017

ikostia accepted D1202: phabricator: if no cert file has been specified, suppress the urllib3 warning.
Oct 20 2017, 12:19 PM

Oct 19 2017

ikostia accepted D1194: phabricator: pass in the cacerts file if configured.
Oct 19 2017, 9:02 AM
ikostia accepted D1193: phabricator: use the timeout parameter when connecting.
Oct 19 2017, 8:59 AM
ikostia accepted D1192: phabricator: handle exceptions better.
Oct 19 2017, 8:58 AM

Oct 18 2017

ikostia accepted D1026: phabricator: use urllib3 to handle conduit HTTP.
Oct 18 2017, 6:40 AM
ikostia added a comment to D1175: phabricator: drop incorrect content type header.

Why not update this one: D1026?

Oct 18 2017, 6:16 AM
ikostia added a comment to D1026: phabricator: use urllib3 to handle conduit HTTP.

It is failing to decode JSON, since the response.data seems to be an HTML piece.

Oct 18 2017, 6:00 AM

Oct 17 2017

ikostia added a comment to D1026: phabricator: use urllib3 to handle conduit HTTP.

Also, just applying this patch and building a Windows version does not work: the build is successful, but ssl output shows "Error" in place of a phabricator status.

Oct 17 2017, 10:28 AM
ikostia requested changes to D1026: phabricator: use urllib3 to handle conduit HTTP.
Oct 17 2017, 10:26 AM

Oct 12 2017

ikostia accepted D1026: phabricator: use urllib3 to handle conduit HTTP.

Awesome, thanks!

Oct 12 2017, 10:46 AM
ikostia requested changes to D1026: phabricator: use urllib3 to handle conduit HTTP.

I would suggest separating these concerns:

  • making conduit API dependent on urllib3
  • adding urllib3 to the repo
Oct 12 2017, 10:27 AM

Oct 11 2017

ikostia accepted D1010: test: add #no-check-commit support to test-check-commit-hg.t.

Looks good.

Oct 11 2017, 12:36 PM

Oct 9 2017

ikostia committed rHGed5acd3fd7e1: windows: add an experimental option for long paths support.
windows: add an experimental option for long paths support
Oct 9 2017, 9:10 PM
ikostia added a comment to D799: phabricator: switch to urlgrabber for phabricator communications.

This breaks hg ssl on Windows. We can't just install dependencies there, we need to bundle them.

Oct 9 2017, 12:05 PM

Oct 1 2017

ikostia accepted D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681).

LGTM

Oct 1 2017, 7:53 AM
ikostia added a comment to D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681).

That is why we raise ProgrammingError, not some sort of UserError. If your extension writes metadata longer than 255 chars, it is a bad extension. Your proposal is weird, because it is quietly modifying things, IMO this is much worse. I'd rather be forced to change my name to something shorter than having it truncated at some arbitrary position.

Oct 1 2017, 7:09 AM
ikostia requested changes to D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681).

I would rather see this thing do raise error.ProrgrammingError('metadata cannot be longer than 255 bytes') (or some other message).

Oct 1 2017, 6:42 AM
ikostia added a comment to D680: scmutil: handle conflicting files and dirs in origbackuppath.

Just as an FYI: I revoke my previous comments, as stuff started working for non-prefixed paths and I no longer intend to land anything related to this.

Oct 1 2017, 5:39 AM

Sep 21 2017

ikostia accepted D765: Linting fixes, remove usused import and safehasattr.
Sep 21 2017, 11:05 AM

Sep 19 2017

ikostia added a comment to D680: scmutil: handle conflicting files and dirs in origbackuppath.

Here's a patch: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-September/104837.html

Sep 19 2017, 12:58 PM
ikostia requested changes to D680: scmutil: handle conflicting files and dirs in origbackuppath.

Please wait until the util.finddirs() is tweaked and remove normpath call.

Sep 19 2017, 11:36 AM

Sep 13 2017

ikostia closed D697: remotefilelog: make style-checker happy.
Sep 13 2017, 12:35 PM
ikostia committed rFBHGX3c18346a2784: remotefilelog: make style-checker happy.
remotefilelog: make style-checker happy
Sep 13 2017, 12:35 PM
ikostia created D697: remotefilelog: make style-checker happy.
Sep 13 2017, 11:40 AM

Sep 12 2017

ikostia committed rFBHGXbf097bb3369f: rage: remove unused variable.
rage: remove unused variable
Sep 12 2017, 11:08 AM
ikostia closed D675: rage: remove unused variable by committing rFBHGXbf097bb3369f: rage: remove unused variable.
Sep 12 2017, 11:08 AM

Sep 11 2017

ikostia created D675: rage: remove unused variable.
Sep 11 2017, 6:25 AM

Sep 6 2017

ikostia added a comment to D620: remotefilelog: using fastlog as a fast path to fix linkrev.

This looks good to me, but I'd like @durham to take a final look.
One of the things that is missing in this diff however is the timeout. Were you going to publish another diff for that?

Sep 6 2017, 5:21 AM

Sep 5 2017

ikostia added a reviewer for D620: remotefilelog: using fastlog as a fast path to fix linkrev: ryanmce.
Sep 5 2017, 11:58 AM

Aug 31 2017

ikostia committed rFBHGX2c1350fdcba5: gitrevset: add a missing import keyword.
gitrevset: add a missing import keyword
Aug 31 2017, 2:31 PM
ikostia closed D580: gitrevset: add a missing import keyword by committing rFBHGX2c1350fdcba5: gitrevset: add a missing import keyword.
Aug 31 2017, 2:30 PM
ikostia updated the test plan for D580: gitrevset: add a missing import keyword.
Aug 31 2017, 11:20 AM
ikostia created D580: gitrevset: add a missing import keyword.
Aug 31 2017, 10:05 AM
ikostia added inline comments to D543: revset: accept additional arguments for stringset.
Aug 31 2017, 9:45 AM

Aug 5 2017

ikostia committed rHGc2c6a0f7408b: ui: make sure buffer is flushed before waiting for user input (issue5587).
ui: make sure buffer is flushed before waiting for user input (issue5587)
Aug 5 2017, 11:13 PM