Page MenuHomePhabricator

indygreg (Gregory Szorc)
User

Projects

User Details

User Since
Jul 1 2017, 5:02 PM (115 w, 6 d)

Recent Activity

Mon, Sep 16

indygreg committed rHG69de49c4e39c: zstandard: vendor python-zstandard 0.12.
zstandard: vendor python-zstandard 0.12
Mon, Sep 16, 1:56 PM
indygreg closed D6858: zstandard: vendor python-zstandard 0.12.
Mon, Sep 16, 1:56 PM

Sun, Sep 15

indygreg retitled D6858: zstandard: vendor python-zstandard 0.12 from zstandard: vendor python-zstandard 0.11 to zstandard: vendor python-zstandard 0.12.
Sun, Sep 15, 11:04 PM
indygreg created D6858: zstandard: vendor python-zstandard 0.12.
Sun, Sep 15, 11:01 PM

Wed, Sep 11

D6839: idirstate: group private methods and attrs that are in the interface is now accepted and ready to land.
Wed, Sep 11, 10:48 PM
D6838: idirstate: remove now non-public _map attribute is now accepted and ready to land.
Wed, Sep 11, 10:47 PM
D6837: cleanup: fix leakage of dirstate._map to client code is now accepted and ready to land.
Wed, Sep 11, 10:47 PM
D6836: interfaces: introduce an interface for dirstate implementations is now accepted and ready to land.
Wed, Sep 11, 10:47 PM

Mon, Sep 9

indygreg added a comment to D6825: contrib: start building a library for simple hooks.

I like where this is going, but I wonder if these specific hooks can be written without being in-process Python hooks. Reason being that Python hooks use the unstable internals of hg and are semi-discouraged if they're avoidable.

Mon, Sep 9, 9:54 PM
D6788: hgweb: fix websub regex flag syntax on Python 3 is now accepted and ready to land.
Mon, Sep 9, 9:51 PM
indygreg closed D6786: automation: implement "publish-windows-artifacts" command.
Mon, Sep 9, 12:09 PM
indygreg closed D6785: automation: upgrade to latest packages in requirements.txt.
Mon, Sep 9, 12:08 PM
indygreg committed rHG92593d72e10b: automation: implement "publish-windows-artifacts" command.
automation: implement "publish-windows-artifacts" command
Mon, Sep 9, 12:08 PM
indygreg committed rHG6bf88befa027: automation: upgrade to latest packages in requirements.txt.
automation: upgrade to latest packages in requirements.txt
Mon, Sep 9, 12:08 PM

Sat, Sep 7

indygreg added a comment to D6825: contrib: start building a library for simple hooks.

I think we should go a step further and have some built-in hooks in Mercurial itself, like we do extensions. A good first implementation would be to define those hooks somewhere where they can be imported, add tests like they are standalone hooks. As a follow-up (read: slightly more work), we can define a new config syntax for using these hooks. e.g. builtin:reject_new_heads.

Sat, Sep 7, 1:27 PM
D6826: py3: drop incorrect fsencode(findexe(...)) in procutil is now accepted and ready to land.
Sat, Sep 7, 1:21 PM
indygreg added a comment to D6808: revlog: introduce a `sidedata` method.

I think I see where you are going with this and it seems potentially very useful.

Sat, Sep 7, 1:20 PM
indygreg added inline comments to D6814: revlog: add a `sidedata` parameters to addrevision.
Sat, Sep 7, 1:12 PM
D6807: flagprocessors: small code update to clarify parameters is now accepted and ready to land.
Sat, Sep 7, 1:08 PM
D6806: flagprocessors: _processflags is now accepted and ready to land.
Sat, Sep 7, 1:06 PM
D6805: simplestorerepo: stop using `_processflags` directly is now accepted and ready to land.
Sat, Sep 7, 1:06 PM
D6804: revlog: stop using `_processflags` directly is now accepted and ready to land.
Sat, Sep 7, 1:05 PM
indygreg added inline comments to D6800: flagprocessors: introduce specialized functions.
Sat, Sep 7, 1:05 PM
D6803: flagprocessors: use _processflagsraw in easy cases is now accepted and ready to land.
Sat, Sep 7, 1:02 PM
D6802: flagprocessors: use _processflagsread in simple cases is now accepted and ready to land.
Sat, Sep 7, 1:01 PM
D6801: flagprocessors: use _processflagswrite for write operation is now accepted and ready to land.
Sat, Sep 7, 1:01 PM
D6800: flagprocessors: introduce specialized functions is now accepted and ready to land.
Sat, Sep 7, 1:01 PM
D6799: flagutil: use it in simplestorerepo is now accepted and ready to land.
Sat, Sep 7, 12:58 PM
D6798: flagutil: make the error class used by the mixin configurable is now accepted and ready to land.
Sat, Sep 7, 12:57 PM
D6797: flagutil: use the new mixin use in remotefilelog is now accepted and ready to land.
Sat, Sep 7, 12:57 PM
D6796: flagutil: introduce a flagprocessorsmixin class is now accepted and ready to land.
Sat, Sep 7, 12:55 PM
indygreg added a comment to D6796: flagutil: introduce a flagprocessorsmixin class.

I'm going to attempt to look at this series...

Sat, Sep 7, 12:52 PM
D6789: check-code: allow command substitution with $(command) is now accepted and ready to land.
Sat, Sep 7, 12:51 PM
D6788: hgweb: fix websub regex flag syntax on Python 3 now requires changes to proceed.

Nice catch!

Sat, Sep 7, 12:50 PM
D6787: test: allow different result for zstd compression (issue6188) is now accepted and ready to land.
Sat, Sep 7, 12:44 PM

Fri, Sep 6

indygreg created D6786: automation: implement "publish-windows-artifacts" command.
Fri, Sep 6, 12:12 AM
indygreg created D6785: automation: upgrade to latest packages in requirements.txt.
Fri, Sep 6, 12:12 AM

Mon, Aug 26

indygreg committed rHGa4e32fd539ab: python-zstandard: apply big-endian fix (issue6188).
python-zstandard: apply big-endian fix (issue6188)
Mon, Aug 26, 8:25 AM

Sun, Aug 25

indygreg added a comment to D6754: contrib: proof of concept script to build Mac packages without system python.

This looks promising.

Sun, Aug 25, 12:18 PM
D6753: contrib: simplify the genosxversion.py command to find the hg libraries is now accepted and ready to land.
Sun, Aug 25, 12:08 PM
D6742: interfaceutil: move to interfaces/ is now accepted and ready to land.
Sun, Aug 25, 12:07 PM
D6741: interfaces: create a new folder for interfaces and move repository.py in it is now accepted and ready to land.

It sounds like we're in agreement that interfaces need to be split. Moving everything to a sub-package seems like a logical first step.

Sun, Aug 25, 12:06 PM
D6762: packaging: add Bullseye, remove Jessie is now accepted and ready to land.
Sun, Aug 25, 12:04 PM
D6761: packaging: add Cosmic and Disco, remove Trusty and Artful is now accepted and ready to land.
Sun, Aug 25, 12:04 PM

Aug 21 2019

D6732: localrepo: push manifestlog and changelog construction code into store is now accepted and ready to land.

The boundary between localrepository and store is a bit murky and definitely needs some work. When I last had things paged into my brain last year, I think I was trending towards breaking up the store into discrete classes and making the code that dynamically resolves repository types cherry pick the classes depending on the opener options. But we could easily have the store handle this logic as well. This is all very complicated and I don't prescribe to have a single correct answer.

Aug 21 2019, 11:46 AM

Aug 6 2019

indygreg closed D6714: automation: update packages in requirements files.
Aug 6 2019, 9:02 AM
indygreg closed D6716: automation: increase root volume size on Linux.
Aug 6 2019, 9:02 AM
indygreg committed rHG3e3fb15bfeea: automation: increase root volume size on Linux.
automation: increase root volume size on Linux
Aug 6 2019, 9:02 AM
indygreg committed rHG89ba81771fc9: automation: install Rust in Linux environment.
automation: install Rust in Linux environment
Aug 6 2019, 9:02 AM
indygreg closed D6715: automation: install Rust in Linux environment.
Aug 6 2019, 9:02 AM
indygreg committed rHG3495edddc78d: automation: update packages in requirements files.
automation: update packages in requirements files
Aug 6 2019, 9:02 AM
indygreg committed rHG6f7262fe671c: automation: install latest Python versions.
automation: install latest Python versions
Aug 6 2019, 9:02 AM
indygreg closed D6713: automation: install latest Python versions.
Aug 6 2019, 9:02 AM

Aug 4 2019

indygreg created D6718: repository: suppress typing errors on functions without arguments.
Aug 4 2019, 3:53 PM
indygreg created D6717: mypy: add a mypy.ini config file.
Aug 4 2019, 3:53 PM
indygreg created D6716: automation: increase root volume size on Linux.
Aug 4 2019, 12:52 PM
indygreg created D6714: automation: update packages in requirements files.
Aug 4 2019, 12:52 PM
indygreg created D6715: automation: install Rust in Linux environment.
Aug 4 2019, 12:52 PM
indygreg created D6713: automation: install latest Python versions.
Aug 4 2019, 12:52 PM
indygreg committed rHG9e0f1c80cddb: automation: push changes affecting .hgtags.
automation: push changes affecting .hgtags
Aug 4 2019, 8:21 AM

Aug 3 2019

indygreg added a comment to D6664: transaction: leave unfinished without crashing when not properly released.

The presence of __del__ is a bit dangerous and I've debugged a handful of issues related to having __del__ on transaction. We still leak repo objects in places due to circular references. It's super annoying.

Aug 3 2019, 4:41 PM

Jul 29 2019

indygreg committed rHGe91930d712e8: automation: execute powershell when connecting.
automation: execute powershell when connecting
Jul 29 2019, 6:30 AM
indygreg committed rHG24cd5b0ba5b3: automation: allow exit code of 1 for `hg push`.
automation: allow exit code of 1 for `hg push`
Jul 29 2019, 6:30 AM

Jul 24 2019

indygreg closed D6673: automation: make Windows base image name configurable.
Jul 24 2019, 5:27 AM
indygreg closed D6674: contrib: install Python 3.8b2 instead of 3.8a2.
Jul 24 2019, 5:27 AM
indygreg committed rHG7fae3b0bd893: contrib: install Python 3.8b2 instead of 3.8a2.
contrib: install Python 3.8b2 instead of 3.8a2
Jul 24 2019, 5:27 AM
indygreg committed rHGd80edcb0b30c: automation: make Windows base image name configurable.
automation: make Windows base image name configurable
Jul 24 2019, 5:27 AM
indygreg closed D6672: automation: extract strings to constants.
Jul 24 2019, 5:27 AM
indygreg committed rHG8804aa6c07a0: automation: extract strings to constants.
automation: extract strings to constants
Jul 24 2019, 5:27 AM
indygreg closed D6671: automation: use newer Windows base image.
Jul 24 2019, 5:27 AM
indygreg committed rHG92a99822e731: automation: use newer Windows base image.
automation: use newer Windows base image
Jul 24 2019, 5:27 AM

Jul 22 2019

indygreg added a comment to D6671: automation: use newer Windows base image.

This series is for stable. (I forgot Phabricator didn't handle branch names well.)

Jul 22 2019, 10:22 PM
indygreg created D6674: contrib: install Python 3.8b2 instead of 3.8a2.
Jul 22 2019, 10:21 PM
indygreg created D6673: automation: make Windows base image name configurable.
Jul 22 2019, 10:21 PM
indygreg created D6672: automation: extract strings to constants.
Jul 22 2019, 10:21 PM
indygreg created D6671: automation: use newer Windows base image.
Jul 22 2019, 10:21 PM

Jun 30 2019

indygreg closed D5805: zeroconf: port to Python 3.
Jun 30 2019, 6:57 AM
indygreg committed rHGfa2071753dc2: zeroconf: port to Python 3.
zeroconf: port to Python 3
Jun 30 2019, 6:57 AM

May 28 2019

indygreg added a comment to D6417: context: get filesadded() and filesremoved() from changeset if configured.

I'm also not super crazy about abusing extras for this. But it is the best compromise considering the "better" solutions require a lot more effort and thought. At some point, I would like Mercurial's storage and wire protocol to grow official APIs for storing and exchanging arbitrary data outside the current storage primitives. Maybe we can shoehorn storage into revlogs in .hg/store/meta. I dunno. Feels like sprint material to me.

May 28 2019, 9:59 PM

May 24 2019

indygreg accepted D6443: py3: use range() instead of xrange().
May 24 2019, 11:19 PM

May 17 2019

indygreg added a comment to D6387: bookmarks: keep bookmarks in .hg/store if new config set.

I still need to look at this commit in detail, but any commit that alters the on-disk or on-network behavior of Mercurial should ideally be accompanied by a docs change to mercurial/help/internals. I say ideally because some things still aren't documented. But repo requirements are. Please follow up with a patch to document the new requirement in mercurial/help/internals/requirements.txt.

May 17 2019, 11:43 PM

May 15 2019

indygreg closed D6319: automation: initial support for running Linux tests.
May 15 2019, 11:47 AM
indygreg committed rHG65b3ef162b39: automation: initial support for running Linux tests.
automation: initial support for running Linux tests
May 15 2019, 11:46 AM
indygreg closed D6318: automation: move image operations to own functions.
May 15 2019, 11:46 AM
indygreg committed rHG195dcc10b3d7: automation: move image operations to own functions.
automation: move image operations to own functions
May 15 2019, 11:46 AM
indygreg committed rHG5c242c427897: automation: do a force push to synchronize.
automation: do a force push to synchronize
May 15 2019, 11:46 AM
indygreg committed rHG4274b1369b75: automation: add check that hg source directory is a repo.
automation: add check that hg source directory is a repo
May 15 2019, 11:46 AM
indygreg committed rHGd137a3d5ad41: automation: add --version argument to build-all-windows-packages.
automation: add --version argument to build-all-windows-packages
May 15 2019, 11:46 AM
indygreg closed D6317: automation: add --version argument to build-all-windows-packages.
May 15 2019, 11:46 AM
indygreg closed D6286: automation: wait for instance profiles and roles.
May 15 2019, 11:46 AM
indygreg closed D6316: automation: do a force push to synchronize.
May 15 2019, 11:46 AM
indygreg closed D6315: automation: add check that hg source directory is a repo.
May 15 2019, 11:46 AM
indygreg closed D6288: automation: shore up rebooting behavior.
May 15 2019, 11:46 AM
indygreg committed rHGe570106beda1: automation: shore up rebooting behavior.
automation: shore up rebooting behavior
May 15 2019, 11:46 AM
indygreg committed rHG8dc22a209420: automation: wait for instance profiles and roles.
automation: wait for instance profiles and roles
May 15 2019, 11:46 AM
indygreg committed rHGf30184484dd1: automation: wait longer for WinRM connection.
automation: wait longer for WinRM connection
May 15 2019, 11:46 AM
indygreg closed D6285: automation: don't create resources when deleting things.
May 15 2019, 11:46 AM
indygreg closed D6287: automation: wait longer for WinRM connection.
May 15 2019, 11:46 AM
indygreg committed rHGdd6a9723ae2b: automation: don't create resources when deleting things.
automation: don't create resources when deleting things
May 15 2019, 11:46 AM
indygreg committed rHG730edbd836d8: automation: only iterate over our AMIs.
automation: only iterate over our AMIs
May 15 2019, 11:46 AM