indygreg (Gregory Szorc)
User

Projects

User Details

User Since
Jul 1 2017, 5:02 PM (90 w, 2 d)

Recent Activity

Yesterday

indygreg added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

How about we add an argument to define the path(s) to the pip requirements file(s) to use? By default, it can use the requirements.txt in the repo. Would that solve your use case?

No, because I have some stuff which (out of tragic necessity at the moment) isn't pip installable, and I have to install it into the virtualenv by banging some rocks together. :(

Mon, Mar 25, 1:14 PM
indygreg added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.
Mon, Mar 25, 12:25 PM

Sat, Mar 23

indygreg added a comment to D6142: automation: perform tasks on remote machines.

I don't know anything about PowerShell or AWS, but this series looks nice for making Windows easier to deal with.

What was the problem with python3 tests? I've been able to run them locally (though a bunch fail with py3 issues).

Sat, Mar 23, 12:03 PM
indygreg added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

I like the flexibility. But I'm not super keen about the interface here. Using a script to inject custom options seems like it could be useful. But as it is currently implemented, the script simply prints out \0 delimited package names. So one UI wart is --extra-prebuild-script being a somewhat generic name but that script only emits package names. --extra-packages-script would be a better name.

Sat, Mar 23, 11:04 AM

Sun, Mar 17

indygreg committed rHG51685c6dcca3: wix: restore COPYING.rtf.
wix: restore COPYING.rtf
Sun, Mar 17, 6:35 PM
indygreg closed D6098: wix: restore COPYING.rtf.
Sun, Mar 17, 6:35 PM

Sat, Mar 16

indygreg added a comment to D6135: packaging: don't bundle DLLs in py2exe library.zip for x86 builds.

According to a private email, things were inconsistent because py2exe didn't (doesn't?) support bundling DLLs in the zip several years ago, so things *had* to be a certain way.

Sat, Mar 16, 1:39 PM

Fri, Mar 15

indygreg closed D6139: wix: autogenerate wxs file for library files.
Fri, Mar 15, 11:12 PM
indygreg closed D6135: packaging: don't bundle DLLs in py2exe library.zip for x86 builds.
Fri, Mar 15, 11:12 PM
indygreg committed rHG131d0b7c3940: wix: autogenerate wxs file for library files.
wix: autogenerate wxs file for library files
Fri, Mar 15, 11:11 PM
indygreg committed rHG39f65c506899: wix: introduce variable to hold path to wix packaging directory.
wix: introduce variable to hold path to wix packaging directory
Fri, Mar 15, 11:11 PM
indygreg closed D6136: setup: exclude crypt32.dll in py2exe builds.
Fri, Mar 15, 11:11 PM
indygreg closed D6137: wix: package missing .dll and .pyd files.
Fri, Mar 15, 11:11 PM
indygreg closed D6138: wix: introduce variable to hold path to wix packaging directory.
Fri, Mar 15, 11:11 PM
indygreg committed rHG9661a9c0695e: wix: package missing .dll and .pyd files.
wix: package missing .dll and .pyd files
Fri, Mar 15, 11:11 PM
indygreg committed rHGd6e3c16d48ab: packaging: don't bundle DLLs in py2exe library.zip for x86 builds.
packaging: don't bundle DLLs in py2exe library.zip for x86 builds
Fri, Mar 15, 11:11 PM
indygreg committed rHGe5ac701e5b7c: setup: exclude crypt32.dll in py2exe builds.
setup: exclude crypt32.dll in py2exe builds
Fri, Mar 15, 11:11 PM
indygreg committed rHGb83de9150c1c: packaging: convert files to LF.
packaging: convert files to LF
Fri, Mar 15, 11:11 PM
indygreg closed D6134: packaging: convert files to LF.
Fri, Mar 15, 11:11 PM
indygreg created D6142: automation: perform tasks on remote machines.
Fri, Mar 15, 2:26 PM
indygreg added a dependent revision for D6141: contrib: PowerShell script to install development dependencies: D6142: automation: perform tasks on remote machines.
Fri, Mar 15, 2:25 PM
indygreg created D6141: contrib: PowerShell script to install development dependencies.
Fri, Mar 15, 2:25 PM
indygreg added a comment to D6098: wix: restore COPYING.rtf.
In D6098#89413, @pulkit wrote:

I applied this locally and did hg diff -c . --git --binary locally and the output is empty. Not sure what's broken here.

Fri, Mar 15, 12:33 PM
indygreg added a comment to D2010: check-commit: allow foo_bar naming in functions.

If we loosen the naming requirement, I think a good convention would be to have new files use the *modern* convention and for existing code/files to generally stick to the old convention.

Fri, Mar 15, 12:31 PM

Thu, Mar 14

indygreg created D6139: wix: autogenerate wxs file for library files.
Thu, Mar 14, 9:39 PM
indygreg created D6135: packaging: don't bundle DLLs in py2exe library.zip for x86 builds.
Thu, Mar 14, 9:39 PM
indygreg created D6137: wix: package missing .dll and .pyd files.
Thu, Mar 14, 9:39 PM
indygreg created D6138: wix: introduce variable to hold path to wix packaging directory.
Thu, Mar 14, 9:39 PM
indygreg added a dependent revision for D6138: wix: introduce variable to hold path to wix packaging directory: D6139: wix: autogenerate wxs file for library files.
Thu, Mar 14, 9:39 PM
indygreg added a dependent revision for D6137: wix: package missing .dll and .pyd files: D6138: wix: introduce variable to hold path to wix packaging directory.
Thu, Mar 14, 9:39 PM
indygreg created D6136: setup: exclude crypt32.dll in py2exe builds.
Thu, Mar 14, 9:39 PM
indygreg added a dependent revision for D6136: setup: exclude crypt32.dll in py2exe builds: D6137: wix: package missing .dll and .pyd files.
Thu, Mar 14, 9:39 PM
indygreg added a dependent revision for D6135: packaging: don't bundle DLLs in py2exe library.zip for x86 builds: D6136: setup: exclude crypt32.dll in py2exe builds.
Thu, Mar 14, 9:39 PM
indygreg created D6134: packaging: convert files to LF.
Thu, Mar 14, 9:39 PM
indygreg added a dependent revision for D6134: packaging: convert files to LF: D6135: packaging: don't bundle DLLs in py2exe library.zip for x86 builds.
Thu, Mar 14, 9:39 PM
indygreg added a comment to D2010: check-commit: allow foo_bar naming in functions.

Should we queue this patch or abandon it?

Thu, Mar 14, 9:37 PM
indygreg added a comment to D6098: wix: restore COPYING.rtf.

Looks like this one forgot to be queued?

Thu, Mar 14, 4:40 PM

Wed, Mar 13

indygreg added a comment to D6082: phabricator: add a `--branch` flag to `hg phabsend`.

While there may be a need for an explicit --branch argument, should we start by having hg phabsend automatically pick up the branch from the changeset? i.e. wouldn't we want branch selection to be automatic?

Wed, Mar 13, 2:37 PM

Sat, Mar 9

indygreg closed D6097: wix: functionality to automate building WiX installers.
Sat, Mar 9, 8:52 PM
indygreg closed D6101: wix: remove enum and future packages.
Sat, Mar 9, 8:52 PM
indygreg committed rHG9d4ae5044b4c: wix: remove enum and future packages.
wix: remove enum and future packages
Sat, Mar 9, 8:52 PM
indygreg committed rHGc7c7edd46849: wix: remove pywin32.
wix: remove pywin32
Sat, Mar 9, 8:52 PM
indygreg closed D6100: wix: remove pywin32.
Sat, Mar 9, 8:52 PM
indygreg closed D6099: wix: remove sphinx and dependencies.
Sat, Mar 9, 8:52 PM
indygreg closed D6096: wix: move contrib/wix to contrib/packaging/wix.
Sat, Mar 9, 8:52 PM
indygreg committed rHGc569f769c41d: wix: remove sphinx and dependencies.
wix: remove sphinx and dependencies
Sat, Mar 9, 8:52 PM
indygreg committed rHG4371f543efda: wix: functionality to automate building WiX installers.
wix: functionality to automate building WiX installers
Sat, Mar 9, 8:52 PM
indygreg committed rHGc68a1df5c79a: wix: move contrib/wix to contrib/packaging/wix.
wix: move contrib/wix to contrib/packaging/wix
Sat, Mar 9, 8:52 PM
indygreg closed D6094: setup: include hgext3rd package in py2exe builds.
Sat, Mar 9, 8:52 PM
indygreg committed rHG3dbd3cdfe0d6: wix: remove hg.cmd.
wix: remove hg.cmd
Sat, Mar 9, 8:52 PM
indygreg closed D6095: wix: remove hg.cmd.
Sat, Mar 9, 8:51 PM
indygreg committed rHG5d9fdc9b0178: setup: include hgext3rd package in py2exe builds.
setup: include hgext3rd package in py2exe builds
Sat, Mar 9, 8:51 PM
indygreg closed D6092: setup: configure py2exe config via environment variables.
Sat, Mar 9, 8:51 PM
indygreg closed D6093: setup: properly install build_hgextindex for py2exe builds.
Sat, Mar 9, 8:51 PM
indygreg closed D6091: packaging: extract py2exe functionality to own module.
Sat, Mar 9, 8:51 PM
indygreg committed rHGac32e04e887f: setup: properly install build_hgextindex for py2exe builds.
setup: properly install build_hgextindex for py2exe builds
Sat, Mar 9, 8:51 PM
indygreg committed rHG260305e8ddbd: setup: configure py2exe config via environment variables.
setup: configure py2exe config via environment variables
Sat, Mar 9, 8:51 PM
indygreg committed rHGa2e191a937a9: packaging: extract py2exe functionality to own module.
packaging: extract py2exe functionality to own module
Sat, Mar 9, 8:51 PM
indygreg closed D6090: packaging: extract python exe info to own function.
Sat, Mar 9, 8:51 PM
indygreg committed rHG7d1211168863: packaging: extract python exe info to own function.
packaging: extract python exe info to own function
Sat, Mar 9, 8:51 PM
indygreg closed D6083: packaging: establish hgpackaging package.
Sat, Mar 9, 8:51 PM
indygreg committed rHGd4bf73ea06de: packaging: extract virtualenv and py2exe to build directory.
packaging: extract virtualenv and py2exe to build directory
Sat, Mar 9, 8:51 PM
indygreg committed rHG5e923355c595: packaging: don't use temporary directory.
packaging: don't use temporary directory
Sat, Mar 9, 8:51 PM
indygreg closed D6089: packaging: don't use temporary directory.
Sat, Mar 9, 8:51 PM
indygreg closed D6088: packaging: extract virtualenv and py2exe to build directory.
Sat, Mar 9, 8:51 PM
indygreg closed D6087: packaging: move Inno Setup core logic into a module.
Sat, Mar 9, 8:51 PM
indygreg committed rHG1440dd6164f2: packaging: move find_vc_runtime_files() into hgpackaging.util.
packaging: move find_vc_runtime_files() into hgpackaging.util
Sat, Mar 9, 8:51 PM
indygreg committed rHGdc7827a9ba64: packaging: move Inno Setup core logic into a module.
packaging: move Inno Setup core logic into a module
Sat, Mar 9, 8:51 PM
indygreg closed D6084: packaging: split downloading code into own module.
Sat, Mar 9, 8:51 PM
indygreg closed D6086: packaging: move find_vc_runtime_files() into hgpackaging.util.
Sat, Mar 9, 8:51 PM
indygreg committed rHG1e8fb6522fee: packaging: move DOWNLOADS dict to hgpackaging.downloads.
packaging: move DOWNLOADS dict to hgpackaging.downloads
Sat, Mar 9, 8:51 PM
indygreg committed rHGc2237fe1359e: packaging: split downloading code into own module.
packaging: split downloading code into own module
Sat, Mar 9, 8:51 PM
indygreg closed D6085: packaging: move DOWNLOADS dict to hgpackaging.downloads.
Sat, Mar 9, 8:51 PM
indygreg committed rHG9da97f49d4f4: packaging: establish hgpackaging package.
packaging: establish hgpackaging package
Sat, Mar 9, 8:51 PM

Fri, Mar 8

indygreg created D6097: wix: functionality to automate building WiX installers.
Fri, Mar 8, 1:50 PM
indygreg created D6101: wix: remove enum and future packages.
Fri, Mar 8, 1:50 PM
indygreg added a dependent revision for D6100: wix: remove pywin32: D6101: wix: remove enum and future packages.
Fri, Mar 8, 1:50 PM
indygreg created D6100: wix: remove pywin32.
Fri, Mar 8, 1:50 PM
indygreg created D6096: wix: move contrib/wix to contrib/packaging/wix.
Fri, Mar 8, 1:50 PM
indygreg created D6099: wix: remove sphinx and dependencies.
Fri, Mar 8, 1:50 PM
indygreg added a dependent revision for D6099: wix: remove sphinx and dependencies: D6100: wix: remove pywin32.
Fri, Mar 8, 1:50 PM
indygreg added a dependent revision for D6098: wix: restore COPYING.rtf: D6099: wix: remove sphinx and dependencies.
Fri, Mar 8, 1:50 PM
indygreg created D6094: setup: include hgext3rd package in py2exe builds.
Fri, Mar 8, 1:49 PM
indygreg created D6098: wix: restore COPYING.rtf.
Fri, Mar 8, 1:49 PM
indygreg added a dependent revision for D6097: wix: functionality to automate building WiX installers: D6098: wix: restore COPYING.rtf.
Fri, Mar 8, 1:49 PM
indygreg added a dependent revision for D6096: wix: move contrib/wix to contrib/packaging/wix: D6097: wix: functionality to automate building WiX installers.
Fri, Mar 8, 1:49 PM
indygreg created D6093: setup: properly install build_hgextindex for py2exe builds.
Fri, Mar 8, 1:49 PM
indygreg added a dependent revision for D6095: wix: remove hg.cmd: D6096: wix: move contrib/wix to contrib/packaging/wix.
Fri, Mar 8, 1:49 PM
indygreg created D6095: wix: remove hg.cmd.
Fri, Mar 8, 1:49 PM
indygreg added a dependent revision for D6094: setup: include hgext3rd package in py2exe builds: D6095: wix: remove hg.cmd.
Fri, Mar 8, 1:49 PM
indygreg added a dependent revision for D6093: setup: properly install build_hgextindex for py2exe builds: D6094: setup: include hgext3rd package in py2exe builds.
Fri, Mar 8, 1:49 PM
indygreg created D6092: setup: configure py2exe config via environment variables.
Fri, Mar 8, 1:49 PM
indygreg added a dependent revision for D6092: setup: configure py2exe config via environment variables: D6093: setup: properly install build_hgextindex for py2exe builds.
Fri, Mar 8, 1:49 PM
indygreg added a dependent revision for D6091: packaging: extract py2exe functionality to own module: D6092: setup: configure py2exe config via environment variables.
Fri, Mar 8, 1:49 PM

Thu, Mar 7

indygreg created D6091: packaging: extract py2exe functionality to own module.
Thu, Mar 7, 7:50 PM
indygreg created D6087: packaging: move Inno Setup core logic into a module.
Thu, Mar 7, 7:50 PM
indygreg created D6090: packaging: extract python exe info to own function.
Thu, Mar 7, 7:50 PM
indygreg added a dependent revision for D6090: packaging: extract python exe info to own function: D6091: packaging: extract py2exe functionality to own module.
Thu, Mar 7, 7:50 PM
indygreg created D6089: packaging: don't use temporary directory.
Thu, Mar 7, 7:50 PM
indygreg added a dependent revision for D6089: packaging: don't use temporary directory: D6090: packaging: extract python exe info to own function.
Thu, Mar 7, 7:50 PM