indygreg (Gregory Szorc)
User

Projects

User Details

User Since
Jul 1 2017, 5:02 PM (46 w, 3 d)

Recent Activity

Mon, May 21

indygreg accepted D3618: pathencode: remove unused variable.
Mon, May 21, 2:37 PM
indygreg accepted D3635: py3: add support for NoneType in stringutil.pprint().
Mon, May 21, 2:30 PM
indygreg accepted D3634: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py.
Mon, May 21, 2:29 PM
indygreg accepted D3633: py3: use bytes in tests/printenv.py.

This one worries me a bit because environment variable values can contain non-ASCII. However, the changed code only operates on HG_ variables and I think those variables are well-sanitized and should be ASCII safe.

Mon, May 21, 2:29 PM
indygreg accepted D3632: py3: use stringutil.pprint() to prevent b'' prefixes in output.
Mon, May 21, 2:25 PM
indygreg accepted D3631: py3: use pycompat.fsencode to convert path to bytes.
Mon, May 21, 2:24 PM
indygreg accepted D3630: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t.
Mon, May 21, 2:24 PM
indygreg accepted D3629: py3: add b'' prefixes in contrib/hg-ssh.
Mon, May 21, 2:24 PM

Fri, May 18

indygreg closed D3573: hgweb: extract code for emitting multiple changelist records.
Fri, May 18, 10:24 AM
indygreg committed rHG5989261a8356: hgweb: extract code for emitting multiple changelist records.
hgweb: extract code for emitting multiple changelist records
Fri, May 18, 10:24 AM

Thu, May 17

indygreg created D3573: hgweb: extract code for emitting multiple changelist records.
Thu, May 17, 3:27 PM

Tue, May 15

indygreg closed D3550: packaging: move contrib/macosx to contrib/packaging/.
Tue, May 15, 8:52 AM
indygreg closed D3551: packaging: make packaging scripts less reliant on pwd.
Tue, May 15, 8:52 AM
indygreg committed rHG768bd75835d7: packaging: move most packaging targets to own Makefile.
packaging: move most packaging targets to own Makefile
Tue, May 15, 8:52 AM
indygreg committed rHG917f635b5c6a: packaging: make packaging scripts less reliant on pwd.
packaging: make packaging scripts less reliant on pwd
Tue, May 15, 8:52 AM
indygreg committed rHGe5d2248dcc39: packaging: move contrib/macosx to contrib/packaging/.
packaging: move contrib/macosx to contrib/packaging/
Tue, May 15, 8:52 AM
indygreg closed D3552: packaging: move most packaging targets to own Makefile.
Tue, May 15, 8:52 AM
indygreg closed D3547: packaging: move contrib/debian to contrib/packaging/.
Tue, May 15, 8:52 AM
indygreg committed rHG142998a45056: packaging: move build-linux-wheels.sh to contrib/packaging/.
packaging: move build-linux-wheels.sh to contrib/packaging/
Tue, May 15, 8:52 AM
indygreg committed rHG6f5b4ceea95b: packaging: move linux-wheel-centos5-blacklist to contrib/packaging/.
packaging: move linux-wheel-centos5-blacklist to contrib/packaging/
Tue, May 15, 8:52 AM
indygreg closed D3549: packaging: move linux-wheel-centos5-blacklist to contrib/packaging/.
Tue, May 15, 8:52 AM
indygreg committed rHGe51c91c14a07: packaging: move contrib/debian to contrib/packaging/.
packaging: move contrib/debian to contrib/packaging/
Tue, May 15, 8:52 AM
indygreg closed D3548: packaging: move build-linux-wheels.sh to contrib/packaging/.
Tue, May 15, 8:52 AM
indygreg closed D3546: packaging: move buildrpm to contrib/packaging/.
Tue, May 15, 8:52 AM
indygreg committed rHGb7cd9e94c259: packaging: move buildrpm to contrib/packaging/.
packaging: move buildrpm to contrib/packaging/
Tue, May 15, 8:52 AM
indygreg committed rHGc1a028d15005: packaging: move mercurial.spec to contrib/packaging/.
packaging: move mercurial.spec to contrib/packaging/
Tue, May 15, 8:52 AM
indygreg closed D3543: packaging: move packagelib.sh into contrib/packaging/.
Tue, May 15, 8:52 AM
indygreg closed D3545: packaging: move mercurial.spec to contrib/packaging/.
Tue, May 15, 8:52 AM
indygreg closed D3544: packaging: move builddeb into contrib/packaging/.
Tue, May 15, 8:52 AM
indygreg committed rHG64b086f0ebb5: packaging: move builddeb into contrib/packaging/.
packaging: move builddeb into contrib/packaging/
Tue, May 15, 8:52 AM
indygreg committed rHGea70512b1ad6: packaging: move packagelib.sh into contrib/packaging/.
packaging: move packagelib.sh into contrib/packaging/
Tue, May 15, 8:52 AM
indygreg closed D3542: packaging: move some docker scripts into contrib/packaging/.
Tue, May 15, 8:51 AM
indygreg closed D3541: packaging: move most of contrib/docker to contrib/packaging/docker.
Tue, May 15, 8:51 AM
indygreg committed rHG1868db0d1515: packaging: move some docker scripts into contrib/packaging/.
packaging: move some docker scripts into contrib/packaging/
Tue, May 15, 8:51 AM
indygreg committed rHG1335bbfb066f: packaging: move most of contrib/docker to contrib/packaging/docker.
packaging: move most of contrib/docker to contrib/packaging/docker
Tue, May 15, 8:51 AM
indygreg closed D3540: setup: reformat options argument.
Tue, May 15, 8:51 AM
indygreg committed rHGcd4959c33d1a: setup: reformat options argument.
setup: reformat options argument
Tue, May 15, 8:51 AM
indygreg committed rHGd9185fa1e868: contrib: remove fixpax.py.
contrib: remove fixpax.py
Tue, May 15, 8:51 AM
indygreg closed D3539: contrib: remove fixpax.py.
Tue, May 15, 8:51 AM

Mon, May 14

indygreg added a comment to D3532: wireprotov2: define and implement "rawstorefile" command.

I'm not yet sure what will be done with stream clones. There's a good chance the existing approach more or less gets carried forward. I do concede that it is pretty optimal and we'll have a hard time reproducing its performance.

Mon, May 14, 12:01 PM

Sat, May 12

indygreg updated the diff for D3552: packaging: move most packaging targets to own Makefile.
Sat, May 12, 9:06 PM
indygreg updated the diff for D3547: packaging: move contrib/debian to contrib/packaging/.
Sat, May 12, 8:18 PM
indygreg created D3551: packaging: make packaging scripts less reliant on pwd.
Sat, May 12, 5:19 PM
indygreg created D3550: packaging: move contrib/macosx to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3552: packaging: move most packaging targets to own Makefile.
Sat, May 12, 5:19 PM
indygreg created D3547: packaging: move contrib/debian to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3551: packaging: make packaging scripts less reliant on pwd: D3552: packaging: move most packaging targets to own Makefile.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3550: packaging: move contrib/macosx to contrib/packaging/: D3551: packaging: make packaging scripts less reliant on pwd.
Sat, May 12, 5:19 PM
indygreg created D3549: packaging: move linux-wheel-centos5-blacklist to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3546: packaging: move buildrpm to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3549: packaging: move linux-wheel-centos5-blacklist to contrib/packaging/: D3550: packaging: move contrib/macosx to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3548: packaging: move build-linux-wheels.sh to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3548: packaging: move build-linux-wheels.sh to contrib/packaging/: D3549: packaging: move linux-wheel-centos5-blacklist to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3547: packaging: move contrib/debian to contrib/packaging/: D3548: packaging: move build-linux-wheels.sh to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3546: packaging: move buildrpm to contrib/packaging/: D3547: packaging: move contrib/debian to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3543: packaging: move packagelib.sh into contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3545: packaging: move mercurial.spec to contrib/packaging/: D3546: packaging: move buildrpm to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3544: packaging: move builddeb into contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3545: packaging: move mercurial.spec to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3544: packaging: move builddeb into contrib/packaging/: D3545: packaging: move mercurial.spec to contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3543: packaging: move packagelib.sh into contrib/packaging/: D3544: packaging: move builddeb into contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3542: packaging: move some docker scripts into contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3542: packaging: move some docker scripts into contrib/packaging/: D3543: packaging: move packagelib.sh into contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3541: packaging: move most of contrib/docker to contrib/packaging/docker.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3541: packaging: move most of contrib/docker to contrib/packaging/docker: D3542: packaging: move some docker scripts into contrib/packaging/.
Sat, May 12, 5:19 PM
indygreg created D3540: setup: reformat options argument.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3540: setup: reformat options argument: D3541: packaging: move most of contrib/docker to contrib/packaging/docker.
Sat, May 12, 5:19 PM
indygreg added a dependent revision for D3539: contrib: remove fixpax.py: D3540: setup: reformat options argument.
Sat, May 12, 5:19 PM
indygreg created D3539: contrib: remove fixpax.py.
Sat, May 12, 5:19 PM
indygreg added a comment to D3532: wireprotov2: define and implement "rawstorefile" command.

In order to support streaming clone without any locks *and* for the result of that clone to pass hg verify with no warnings about unreferenced revisions (assuming the server was clean to begin with), I believe we would need to scan the changelog for all referenced manifest nodes and then find the end offset of the last node in the manifest. We would then send the manifest up to that offset.

Sat, May 12, 2:13 PM
indygreg closed D3537: dispatch: minor code refactor.
Sat, May 12, 2:01 AM
indygreg committed rHGe9c588802529: dispatch: minor code refactor.
dispatch: minor code refactor
Sat, May 12, 2:01 AM
indygreg removed a dependency for D3445: dispatch: validate return type from dispatch() return value: D3444: tests: comprehensively test exit handling.
Sat, May 12, 12:49 AM
indygreg removed a dependent revision for D3444: tests: comprehensively test exit handling: D3445: dispatch: validate return type from dispatch() return value.
Sat, May 12, 12:49 AM
indygreg added a dependency for D3445: dispatch: validate return type from dispatch() return value: D3537: dispatch: minor code refactor.
Sat, May 12, 12:48 AM
indygreg added a dependent revision for D3537: dispatch: minor code refactor: D3445: dispatch: validate return type from dispatch() return value.
Sat, May 12, 12:48 AM
indygreg updated the diff for D3446: dispatch: move sys.exit() to caller (API).
Sat, May 12, 12:48 AM
indygreg updated the diff for D3445: dispatch: validate return type from dispatch() return value.
Sat, May 12, 12:48 AM
indygreg created D3537: dispatch: minor code refactor.
Sat, May 12, 12:48 AM
indygreg added a dependent revision for D3444: tests: comprehensively test exit handling: D3537: dispatch: minor code refactor.
Sat, May 12, 12:48 AM
indygreg requested changes to D3536: json: reject unicode on py2 as well.

unicode is not a type on Python 3. I think this should be changed to (str, pycompat.unicode). That will evaluate to (str, unicode) on Python 2 and (str, str) on Python 3. If you go this route, please rephrase the comment to denote the Python 2 behavior only triggering on unicode because of str == bytes.

Sat, May 12, 12:43 AM

Fri, May 11

indygreg added a comment to D3444: tests: comprehensively test exit handling.
In D3444#54922, @yuja wrote:

I generally like the direction of this series, but I think there's no point
to extend Mercurial's exit code handling to support all weird Python types.

Only ints and (None for 0) are ever valid.

Fri, May 11, 11:55 PM
indygreg accepted D3454: Assign to result from block..

It looks like this is based on top of D3447. So I'll just hook up the dependency and we'll land it as soon as my series is landed.

Fri, May 11, 11:51 PM
indygreg added a dependent revision for D3447: rust: make exit handling consistent with `hg`: D3454: Assign to result from block..
Fri, May 11, 11:50 PM
indygreg added a dependency for D3454: Assign to result from block.: D3447: rust: make exit handling consistent with `hg`.
Fri, May 11, 11:50 PM
indygreg created D3535: wireprotov2: define and implement "filerevisionsslice" command.
Fri, May 11, 6:35 PM
indygreg created D3534: wireprotov2: define and implement "filerevision" command.
Fri, May 11, 6:35 PM
indygreg created D3533: wireprotov2: define and implement "filehistory" command.
Fri, May 11, 6:35 PM
indygreg created D3532: wireprotov2: define and implement "rawstorefile" command.
Fri, May 11, 6:35 PM
indygreg added a dependent revision for D3534: wireprotov2: define and implement "filerevision" command: D3535: wireprotov2: define and implement "filerevisionsslice" command.
Fri, May 11, 6:35 PM
indygreg added a dependent revision for D3533: wireprotov2: define and implement "filehistory" command: D3534: wireprotov2: define and implement "filerevision" command.
Fri, May 11, 6:35 PM
indygreg added a dependent revision for D3532: wireprotov2: define and implement "rawstorefile" command: D3533: wireprotov2: define and implement "filehistory" command.
Fri, May 11, 6:35 PM

Tue, May 8

indygreg accepted D3481: rev-branch-cache: mark the bundle2 part as advisory (issue5872).

I'm going to queue this one on stable. Thanks for fixing this regression! And for making the debug command output more helpful so we can detect this easier in the future.

Tue, May 8, 5:17 PM
indygreg accepted D3480: debugbundle: also display if a part is mandatory or advisory.
Tue, May 8, 5:15 PM
indygreg accepted D3507: tests: fix test-status-inprocess.py on Python 3.
Tue, May 8, 4:20 PM
indygreg accepted D3506: tests: port test-filecache.py to Python 3.
Tue, May 8, 4:19 PM
indygreg accepted D3505: tests: port test-cbor.py to Python 3.
Tue, May 8, 4:18 PM
indygreg accepted D3504: cborutil: port to Python 3.

Ugh.

Tue, May 8, 4:18 PM
indygreg accepted D3503: lock: pass sysstr to warnings module.
Tue, May 8, 4:17 PM
indygreg accepted D3496: tests: port test-revlog-raw.py to Python 3.
Tue, May 8, 2:27 PM