indygreg (Gregory Szorc)
User

Projects

User Details

User Since
Jul 1 2017, 5:02 PM (28 w, 3 d)

Recent Activity

Yesterday

indygreg created D1861: wireproto: drop support for reader interface from streamres (API).
Mon, Jan 15, 6:20 PM
indygreg added a comment to D1856: wireproto: support for pullbundles.

I'm too rusty on bundle2 at the moment to grok what magic would be required to pre-compress payloads.

The ideal solution would be a way to reset the context for the byte stream. Essentially we'd add a marker telling consumers they've reached EOF of either a bundle2 stream or a compression context. The next byte should be interpreted as a new bundle2 stream or a new compression context.

Mon, Jan 15, 5:39 PM
indygreg added a comment to D1856: wireproto: support for pullbundles.

I'm too rusty on bundle2 at the moment to grok what magic would be required to pre-compress payloads.

Mon, Jan 15, 5:33 PM
indygreg closed D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 8:25 AM
indygreg committed rHG48fe4f56a3b4: dispatch: handle IOError when writing to stderr.
dispatch: handle IOError when writing to stderr
Mon, Jan 15, 8:25 AM
indygreg committed rHG40da2d7b4871: commandserver: restore cwd in case of exception.
commandserver: restore cwd in case of exception
Mon, Jan 15, 8:25 AM
indygreg closed D1859: commandserver: restore cwd in case of exception.
Mon, Jan 15, 8:25 AM
indygreg closed D1858: tests: make hg frame optional.
Mon, Jan 15, 8:25 AM
indygreg committed rHG15cfd343d3a9: tests: make hg frame optional.
tests: make hg frame optional
Mon, Jan 15, 8:25 AM
indygreg created D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 12:00 AM
indygreg created D1859: commandserver: restore cwd in case of exception.
Mon, Jan 15, 12:00 AM
indygreg added a dependent revision for D1859: commandserver: restore cwd in case of exception: D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 12:00 AM

Sun, Jan 14

indygreg created D1858: tests: make hg frame optional.
Sun, Jan 14, 6:04 PM
indygreg added a comment to D1856: wireproto: support for pullbundles.

Another idea to consider is storing changegroup data or bundle2 parts on disk instead of full bundles. Then, we could stream multiple changegroup parts into a larger bundle2 payload.

Sun, Jan 14, 5:55 PM
indygreg requested changes to D1856: wireproto: support for pullbundles.

This patch needs a lot of work. But I'm very supportive of the feature and the preliminary implementation!

Sun, Jan 14, 5:43 PM
indygreg requested changes to D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads.

I'm generally in favor of this functionality. It enables some interesting server features (such as pullbundles).

Sun, Jan 14, 5:04 PM
indygreg added a comment to D1850: hgweb: when no agreement on compression can be found, fail for v2.

Which status code shall we use then, just plain 400?

Sun, Jan 14, 4:35 PM
indygreg updated the diff for D1478: py3: cast error message to localstr in blackbox.py.
Sun, Jan 14, 3:13 PM
indygreg abandoned D1479: py3: use byteskwargs in templatekw.showobsfate().

This was addressed by D1536.

Sun, Jan 14, 3:09 PM
indygreg abandoned D1481: py3: ensure hashes are bytes in sparse.py.

This was addressed in D1792.

Sun, Jan 14, 2:41 PM
indygreg accepted D1834: pylint: add a check for multiple statement on a single line.

Nice cleanup. Always happy to turn on more lint checks.

Sun, Jan 14, 2:34 PM
indygreg accepted D1833: style: remove multiple statement on a single line in zeroconf.
Sun, Jan 14, 2:34 PM
indygreg accepted D1832: style: remove multiple statement on a single line.
Sun, Jan 14, 2:34 PM
indygreg accepted D1831: pylint: split command line argument on multiple lines.
Sun, Jan 14, 2:33 PM
indygreg requested changes to D1802: phabricator: add a template item for linking to a differential review.

Please also remove the double newlines and fix the commit message to abide by our message standards.

Sun, Jan 14, 2:31 PM
indygreg accepted D1801: Use named group for parsing differential reviews lines..

Thanks for the improvement.

Sun, Jan 14, 2:26 PM
indygreg updated the diff for D1729: githelp: don't reference 3rd party commands for `git show`.
Sun, Jan 14, 2:20 PM

Fri, Jan 12

indygreg requested changes to D1850: hgweb: when no agreement on compression can be found, fail for v2.

We're not using the Accept* HTTP headers, so the use of HTTP 406 is not appropriate. See https://tools.ietf.org/html/rfc7231#section-6.5.6. I believe if you scour the mailing list or even the commit messages, you'll find text explaining why we explicitly chose to not use the Accept headers for protocol negotiation.

Fri, Jan 12, 8:20 PM
indygreg accepted D1855: explicitly kill server processes.
Fri, Jan 12, 8:12 PM

Thu, Jan 11

indygreg committed rHG24b5106e3e1e: rust: avoid redundant 'static lifetime.
rust: avoid redundant 'static lifetime
Thu, Jan 11, 1:21 PM
indygreg closed D1846: rust: avoid redundant 'static lifetime.
Thu, Jan 11, 1:21 PM
indygreg closed D1847: rust: add TODO about lifetime of program_name variable.
Thu, Jan 11, 8:40 AM
indygreg committed rHG74bec9e74831: rust: add TODO about lifetime of program_name variable.
rust: add TODO about lifetime of program_name variable
Thu, Jan 11, 8:40 AM
indygreg committed rHG11c86ab69e67: rust: move import of PathBuf.
rust: move import of PathBuf
Thu, Jan 11, 8:40 AM
indygreg closed D1845: rust: move import of PathBuf.
Thu, Jan 11, 8:40 AM

Wed, Jan 10

indygreg created D1847: rust: add TODO about lifetime of program_name variable.
Wed, Jan 10, 10:42 PM
indygreg added a dependent revision for D1846: rust: avoid redundant 'static lifetime: D1847: rust: add TODO about lifetime of program_name variable.
Wed, Jan 10, 10:42 PM
indygreg created D1846: rust: avoid redundant 'static lifetime.
Wed, Jan 10, 10:42 PM
indygreg created D1845: rust: move import of PathBuf.
Wed, Jan 10, 10:42 PM
indygreg added a dependent revision for D1845: rust: move import of PathBuf: D1846: rust: avoid redundant 'static lifetime.
Wed, Jan 10, 10:42 PM
indygreg added a comment to D1581: rust: implementation of `hg`.

I'll address this and other review feedback in follow-up patches.

Wed, Jan 10, 10:41 PM
indygreg added a comment to D1779: unionrepo: use named attributes on revlog index entries.

I think we should hold off landing until the native C type is ready. I don't like shipping a performance regression on such low-level code without any other user benefit to offset it. The assumption here is that I'm the only one who will absorb pain from this series lingering. I'm willing to take that hit.

Wed, Jan 10, 10:13 PM
indygreg committed rHG98b87b8307e0: rust: move Cargo.lock.
rust: move Cargo.lock
Wed, Jan 10, 10:12 PM
indygreg closed D1844: rust: move Cargo.lock.
Wed, Jan 10, 10:12 PM
indygreg closed D1843: run-tests: fix regular expression for path test.
Wed, Jan 10, 10:09 PM
indygreg committed rHG31acf6619f08: run-tests: fix regular expression for path test.
run-tests: fix regular expression for path test
Wed, Jan 10, 10:09 PM
indygreg created D1844: rust: move Cargo.lock.
Wed, Jan 10, 10:09 PM
indygreg created D1843: run-tests: fix regular expression for path test.
Wed, Jan 10, 10:05 PM
indygreg closed D1581: rust: implementation of `hg`.
Wed, Jan 10, 6:03 PM
indygreg committed rHG964212780daf: rust: implementation of `hg`.
rust: implementation of `hg`
Wed, Jan 10, 6:02 PM
indygreg added a comment to D1581: rust: implementation of `hg`.

There are a lot of uses of unwrap, expect, and panic that can (and probably should) be replaced with proper error handling using Result (and the failure crate).

Wed, Jan 10, 4:46 PM
indygreg updated the diff for D1581: rust: implementation of `hg`.
Wed, Jan 10, 11:54 AM

Tue, Jan 9

indygreg updated the diff for D1581: rust: implementation of `hg`.
Tue, Jan 9, 9:10 PM
indygreg updated the diff for D1581: rust: implementation of `hg`.
Tue, Jan 9, 9:07 PM
indygreg added inline comments to D1581: rust: implementation of `hg`.
Tue, Jan 9, 9:07 PM

Sat, Jan 6

indygreg updated the diff for D1778: debugcommands: use named attributes on revlog index entries.
Sat, Jan 6, 3:26 AM
indygreg updated the diff for D1769: cext: use dedicated type for index entries.
Sat, Jan 6, 3:26 AM
indygreg updated the diff for D1768: cext: obtain reference to index entry type.
Sat, Jan 6, 3:26 AM
indygreg updated the diff for D1774: repoview: use named attributes on revlog index entries.
Sat, Jan 6, 3:26 AM
indygreg updated the summary of D1773: revlog: use named attributes on revlog index entries.
Sat, Jan 6, 3:26 AM
indygreg updated the diff for D1772: tests: port revlog index code to modern API.
Sat, Jan 6, 3:26 AM
indygreg updated the diff for D1767: cext: make nullentry a member of index types.
Sat, Jan 6, 3:26 AM
indygreg updated the diff for D1765: parsers: use an attr-derived class for revlog index entries.
Sat, Jan 6, 3:26 AM
indygreg added inline comments to D1768: cext: obtain reference to index entry type.
Sat, Jan 6, 2:11 AM

Fri, Jan 5

indygreg closed D1764: revlog: don't use slicing to return parents.
Fri, Jan 5, 1:17 AM
indygreg committed rHGa0fab647a8f1: revlog: don't use slicing to return parents.
revlog: don't use slicing to return parents
Fri, Jan 5, 1:17 AM

Fri, Dec 29

indygreg added a comment to D1729: githelp: don't reference 3rd party commands for `git show`.
In D1729#30292, @pulkit wrote:

I really like the extension added by the series. It will be nice one to have to help people who wanted to consider hg.

Added some inline comments which can be follow-ups if sounds good. There is also some inconsistency in output format which needs to be fixed.

How about having something like hg githelp concepts which can describe the basic difference between git and hg?

Fri, Dec 29, 1:45 PM

Thu, Dec 28

indygreg added a comment to D1773: revlog: use named attributes on revlog index entries.
In D1773#30283, @yuja wrote:

Not reviewed the series yet, but can't we just start with a custom type
backed by C so we don't have to import back IndexV1Entry from Python?

Thu, Dec 28, 1:56 PM
indygreg closed D1780: smartset: split generatorset classes to avoid cycle.
Thu, Dec 28, 8:19 AM
indygreg committed rHG12a46ad67a3c: smartset: split generatorset classes to avoid cycle.
smartset: split generatorset classes to avoid cycle
Thu, Dec 28, 8:19 AM

Wed, Dec 27

indygreg accepted D1781: merge: raise before running mergedriver if using IMM.
Wed, Dec 27, 6:34 PM
indygreg added inline comments to D1753: streamclone: preserve remote phases (issue5648).
Wed, Dec 27, 1:34 PM
indygreg created D1780: smartset: split generatorset classes to avoid cycle.
Wed, Dec 27, 1:25 PM

Tue, Dec 26

indygreg created D1778: debugcommands: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1777: upgrade: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1779: unionrepo: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1778: debugcommands: use named attributes on revlog index entries: D1779: unionrepo: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1776: bundlerepo: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1773: revlog: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1777: upgrade: use named attributes on revlog index entries: D1778: debugcommands: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1771: revlog: pass index entry type into packentry() (API).
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1776: bundlerepo: use named attributes on revlog index entries: D1777: upgrade: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1775: dagutil: use named attributes on revlog index entries: D1776: bundlerepo: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1775: dagutil: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1774: repoview: use named attributes on revlog index entries: D1775: dagutil: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1774: repoview: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1773: revlog: use named attributes on revlog index entries: D1774: repoview: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1770: revlog: use revlog index entry type for version 0 revlogs.
Tue, Dec 26, 7:36 PM
indygreg created D1769: cext: use dedicated type for index entries.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1772: tests: port revlog index code to modern API: D1773: revlog: use named attributes on revlog index entries.
Tue, Dec 26, 7:36 PM
indygreg created D1772: tests: port revlog index code to modern API.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1771: revlog: pass index entry type into packentry() (API): D1772: tests: port revlog index code to modern API.
Tue, Dec 26, 7:36 PM
indygreg created D1768: cext: obtain reference to index entry type.
Tue, Dec 26, 7:36 PM
indygreg created D1767: cext: make nullentry a member of index types.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1770: revlog: use revlog index entry type for version 0 revlogs: D1771: revlog: pass index entry type into packentry() (API).
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1769: cext: use dedicated type for index entries: D1770: revlog: use revlog index entry type for version 0 revlogs.
Tue, Dec 26, 7:36 PM
indygreg added a dependent revision for D1768: cext: obtain reference to index entry type: D1769: cext: use dedicated type for index entries.
Tue, Dec 26, 7:35 PM
indygreg created D1766: cext: rename variable describing format for index entries.
Tue, Dec 26, 7:35 PM
indygreg added a dependent revision for D1767: cext: make nullentry a member of index types: D1768: cext: obtain reference to index entry type.
Tue, Dec 26, 7:35 PM
indygreg added a dependent revision for D1766: cext: rename variable describing format for index entries: D1767: cext: make nullentry a member of index types.
Tue, Dec 26, 7:35 PM