- User Since
- Jul 1 2017, 5:02 PM (46 w, 3 d)
Mon, May 21
This one worries me a bit because environment variable values can contain non-ASCII. However, the changed code only operates on HG_ variables and I think those variables are well-sanitized and should be ASCII safe.
Fri, May 18
Thu, May 17
Tue, May 15
Mon, May 14
I'm not yet sure what will be done with stream clones. There's a good chance the existing approach more or less gets carried forward. I do concede that it is pretty optimal and we'll have a hard time reproducing its performance.
Sat, May 12
In order to support streaming clone without any locks *and* for the result of that clone to pass hg verify with no warnings about unreferenced revisions (assuming the server was clean to begin with), I believe we would need to scan the changelog for all referenced manifest nodes and then find the end offset of the last node in the manifest. We would then send the manifest up to that offset.
unicode is not a type on Python 3. I think this should be changed to (str, pycompat.unicode). That will evaluate to (str, unicode) on Python 2 and (str, str) on Python 3. If you go this route, please rephrase the comment to denote the Python 2 behavior only triggering on unicode because of str == bytes.
Fri, May 11
It looks like this is based on top of D3447. So I'll just hook up the dependency and we'll land it as soon as my series is landed.
Tue, May 8
I'm going to queue this one on stable. Thanks for fixing this regression! And for making the debug command output more helpful so we can detect this easier in the future.