indygreg (Gregory Szorc)
User

Projects

User Details

User Since
Jul 1 2017, 5:02 PM (54 w, 5 d)

Recent Activity

Yesterday

indygreg closed D3966: configitems: restore alias for format.aggressivemergedeltas.
Thu, Jul 19, 2:13 PM
indygreg committed rHGe90130af47ce: configitems: restore alias for format.aggressivemergedeltas.
configitems: restore alias for format.aggressivemergedeltas
Thu, Jul 19, 2:13 PM
indygreg created D3966: configitems: restore alias for format.aggressivemergedeltas.
Thu, Jul 19, 2:11 PM
indygreg closed D3963: merge: mark file gets as not thread safe.
Thu, Jul 19, 8:19 AM
indygreg committed rHGbe4984261611: merge: mark file gets as not thread safe (issue5933).
merge: mark file gets as not thread safe (issue5933)
Thu, Jul 19, 8:18 AM
indygreg closed D3962: worker: ability to disable thread unsafe tasks.
Thu, Jul 19, 8:18 AM
indygreg committed rHGef3838a47503: worker: ability to disable thread unsafe tasks.
worker: ability to disable thread unsafe tasks
Thu, Jul 19, 8:18 AM
indygreg committed rHG69ed2cff4277: worker: rename variable to reflect constant.
worker: rename variable to reflect constant
Thu, Jul 19, 8:18 AM
indygreg closed D3961: worker: rename variable to reflect constant.
Thu, Jul 19, 8:18 AM

Wed, Jul 18

indygreg updated the diff for D3963: merge: mark file gets as not thread safe.
Wed, Jul 18, 12:55 PM
indygreg updated the diff for D3962: worker: ability to disable thread unsafe tasks.
Wed, Jul 18, 12:55 PM

Tue, Jul 17

indygreg updated subscribers of D3963: merge: mark file gets as not thread safe.

CC @wlis since this change will impact Facebook. I'd also appreciate validation of my assertions in the commit message about the behavior of remotefilelog and working directory updates being more I/O than CPU/GIL bound.

Tue, Jul 17, 8:45 PM
indygreg created D3963: merge: mark file gets as not thread safe.
Tue, Jul 17, 8:43 PM
indygreg created D3962: worker: ability to disable thread unsafe tasks.
Tue, Jul 17, 8:43 PM
indygreg added a dependent revision for D3962: worker: ability to disable thread unsafe tasks: D3963: merge: mark file gets as not thread safe.
Tue, Jul 17, 8:43 PM
indygreg added a dependent revision for D3961: worker: rename variable to reflect constant: D3962: worker: ability to disable thread unsafe tasks.
Tue, Jul 17, 8:43 PM
indygreg created D3961: worker: rename variable to reflect constant.
Tue, Jul 17, 8:43 PM

Mon, Jul 16

indygreg closed D3958: Allow to run setup.py with python 3 without a mercurial checkout.
Mon, Jul 16, 8:48 PM
indygreg committed rHGd5b31ae9cc0a: Allow to run setup.py with python 3 without a mercurial checkout.
Allow to run setup.py with python 3 without a mercurial checkout
Mon, Jul 16, 8:48 PM
indygreg accepted D3958: Allow to run setup.py with python 3 without a mercurial checkout.

I'm OK with this undocumented hack. And there are cases where we may want to test setup.py outside the context of a checkout as well. The important thing is end-users not running Mercurial with Python 3 unknowingly.

Mon, Jul 16, 8:47 PM

Fri, Jul 13

indygreg closed D3932: tests: add test demonstrating phase loss when cloning (issue5939).
Fri, Jul 13, 9:42 PM
indygreg closed D3943: scmutil: rewrite docstring for filecache.
Fri, Jul 13, 9:42 PM
indygreg committed rHG2a227782e754: tests: add test demonstrating phase loss when cloning (issue5939).
tests: add test demonstrating phase loss when cloning (issue5939)
Fri, Jul 13, 9:42 PM
indygreg committed rHG3b072388ca78: scmutil: rewrite docstring for filecache.
scmutil: rewrite docstring for filecache
Fri, Jul 13, 9:42 PM
indygreg created D3943: scmutil: rewrite docstring for filecache.
Fri, Jul 13, 5:26 PM

Wed, Jul 11

indygreg updated subscribers of D3932: tests: add test demonstrating phase loss when cloning (issue5939).

I don't understand phases code that well and am not sure if I'll be able to contribute a fix for the underlying issue in the next few days. If someone wants to take a shot at it, I could use the help.

Wed, Jul 11, 8:17 PM
indygreg created D3932: tests: add test demonstrating phase loss when cloning (issue5939).
Wed, Jul 11, 8:15 PM

Thu, Jul 5

indygreg closed D3882: manifest: define and implement rev() on manifestlog.
Thu, Jul 5, 8:10 AM
indygreg closed D3883: manifest: define and implement addgroup() on manifestlog.
Thu, Jul 5, 8:10 AM
indygreg committed rHG0db41eb0a3ac: manifest: define and implement addgroup() on manifestlog.
manifest: define and implement addgroup() on manifestlog
Thu, Jul 5, 8:10 AM
indygreg committed rHGf2f9bacf0587: manifest: define and implement rev() on manifestlog.
manifest: define and implement rev() on manifestlog
Thu, Jul 5, 8:10 AM

Wed, Jul 4

indygreg committed rHG404eab7ff33f: tests: use interfaceutil in simplestorerepo.
tests: use interfaceutil in simplestorerepo
Wed, Jul 4, 3:43 PM
indygreg closed D3884: tests: use interfaceutil in simplestorerepo.
Wed, Jul 4, 3:43 PM
indygreg created D3883: manifest: define and implement addgroup() on manifestlog.
Wed, Jul 4, 3:16 PM
indygreg created D3882: manifest: define and implement rev() on manifestlog.
Wed, Jul 4, 3:16 PM
indygreg created D3884: tests: use interfaceutil in simplestorerepo.
Wed, Jul 4, 3:16 PM
indygreg added a dependent revision for D3883: manifest: define and implement addgroup() on manifestlog: D3884: tests: use interfaceutil in simplestorerepo.
Wed, Jul 4, 3:16 PM
indygreg added a dependent revision for D3882: manifest: define and implement rev() on manifestlog: D3883: manifest: define and implement addgroup() on manifestlog.
Wed, Jul 4, 3:16 PM
indygreg added a comment to D3845: worker: support more return types in posix worker.

It's been recommended to me that we avoid the streaming flavor of
cbor, so we'd probably just do one-shot messages.

Wed, Jul 4, 2:16 PM

Tue, Jul 3

indygreg closed D3869: repository: define manifest interfaces.
Tue, Jul 3, 1:56 PM
indygreg committed rHGc82ea938efbb: repository: define manifest interfaces.
repository: define manifest interfaces
Tue, Jul 3, 1:56 PM

Sun, Jul 1

indygreg closed D3868: manifest: make cachesize a private attribute.
Sun, Jul 1, 2:07 PM
indygreg committed rHG561a450c7b64: manifest: make cachesize a private attribute.
manifest: make cachesize a private attribute
Sun, Jul 1, 2:07 PM
indygreg committed rHG5cfb01d5ff26: repository: document that file() return value conforms to interface.
repository: document that file() return value conforms to interface
Sun, Jul 1, 2:07 PM
indygreg closed D3867: repository: document that file() return value conforms to interface.
Sun, Jul 1, 2:07 PM

Sat, Jun 30

indygreg created D3869: repository: define manifest interfaces.
Sat, Jun 30, 9:35 PM
indygreg created D3868: manifest: make cachesize a private attribute.
Sat, Jun 30, 9:35 PM
indygreg added a dependent revision for D3868: manifest: make cachesize a private attribute: D3869: repository: define manifest interfaces.
Sat, Jun 30, 9:35 PM
indygreg created D3867: repository: document that file() return value conforms to interface.
Sat, Jun 30, 9:35 PM
indygreg added a dependent revision for D3867: repository: document that file() return value conforms to interface: D3868: manifest: make cachesize a private attribute.
Sat, Jun 30, 9:35 PM

Mon, Jun 25

indygreg closed D3760: packaging: don't write files for templatized Dockerfiles.
Mon, Jun 25, 11:21 AM
indygreg closed D3759: packaging: replace dockerlib.sh with a Python script.
Mon, Jun 25, 11:21 AM
indygreg committed rHG7f738edc4a27: packaging: dynamically define make targets.
packaging: dynamically define make targets
Mon, Jun 25, 11:20 AM
indygreg closed D3761: packaging: dynamically define make targets.
Mon, Jun 25, 11:20 AM
indygreg closed D3758: packaging: consistently create build user in Dockerfiles.
Mon, Jun 25, 11:20 AM
indygreg committed rHGc8ef9d897e14: packaging: don't write files for templatized Dockerfiles.
packaging: don't write files for templatized Dockerfiles
Mon, Jun 25, 11:20 AM
indygreg committed rHGe5916f1236f3: packaging: replace dockerlib.sh with a Python script.
packaging: replace dockerlib.sh with a Python script
Mon, Jun 25, 11:20 AM
indygreg committed rHG11eda1f1b6e7: packaging: consistently create build user in Dockerfiles.
packaging: consistently create build user in Dockerfiles
Mon, Jun 25, 11:20 AM

Jun 18 2018

indygreg added a comment to D3764: rebase: improve output of --dry-run.
In D3764#59425, @pulkit wrote:

Thinking out loud here: I see that --dry-run for rebase will be very useful for automation. How about returning 1 when there are conflicts and returning 0 when there are no conflicts? Also maybe we should add formatter support to the dry-run output for each command so that automation can read the JSON output and tell user what can happen.

Jun 18 2018, 7:03 PM

Jun 17 2018

indygreg added a comment to D3765: progress: create helper class for incrementing progress.

Also, it's worth keeping in mind Python function call overhead when working on this code. I'm optimistic that things that need progress bars won't be concerned about this. But it might be worth measuring and keeping in the back of your head.

Jun 17 2018, 2:12 PM
indygreg accepted D3765: progress: create helper class for incrementing progress.

The low-level progress API has always bothered me as well.

Jun 17 2018, 2:01 PM

Jun 16 2018

indygreg requested changes to D3665: graph: improve graph output by using Unicode characters.

I'm getting a few test errors applying this against the latest revision of hg repo:

Jun 16 2018, 5:26 PM
indygreg accepted D3665: graph: improve graph output by using Unicode characters.
Jun 16 2018, 5:17 PM
indygreg requested changes to D3757: rebase: add dry-run functionality.

Overall I think this is a great feature! The patch as is needs a bit of UI work.

Jun 16 2018, 4:57 PM
indygreg requested changes to D3665: graph: improve graph output by using Unicode characters.

I think having better display of graph symbols is a compelling end-user feature and should be part of Mercurial.

Jun 16 2018, 4:42 PM
indygreg updated subscribers of D3756: rebase: delete the comment which was not following "do not eat my data".

I'm unsure about this change. On one hand, the comment (which appears to have been added to mpm several years ago) implies that we never should have generated backups in this case. On the other, one of the key rules of a VCS is "don't eat my data." Even though we are aborting the operation, I could see some scenarios where someone would want a backup of the aborted/partially-completed rebase.

Jun 16 2018, 4:15 PM
indygreg requested changes to D3716: ui: add an uninterruptable context manager that can block SIGINT.

I agree with @yuja that we should move this to util.py or one of its siblings and rename it to uninterruptable or some such.

Jun 16 2018, 4:07 PM
indygreg created D3760: packaging: don't write files for templatized Dockerfiles.
Jun 16 2018, 2:19 PM
indygreg created D3759: packaging: replace dockerlib.sh with a Python script.
Jun 16 2018, 2:19 PM
indygreg created D3761: packaging: dynamically define make targets.
Jun 16 2018, 2:19 PM
indygreg added a dependent revision for D3760: packaging: don't write files for templatized Dockerfiles: D3761: packaging: dynamically define make targets.
Jun 16 2018, 2:19 PM
indygreg added a dependent revision for D3759: packaging: replace dockerlib.sh with a Python script: D3760: packaging: don't write files for templatized Dockerfiles.
Jun 16 2018, 2:19 PM
indygreg created D3758: packaging: consistently create build user in Dockerfiles.
Jun 16 2018, 2:19 PM
indygreg added a dependent revision for D3758: packaging: consistently create build user in Dockerfiles: D3759: packaging: replace dockerlib.sh with a Python script.
Jun 16 2018, 2:19 PM
indygreg added a comment to D3733: tests: suppress read(-1) -> '' calls in fileobjectobserver.

So Python 3 is performing a lot more read(-1) calls than Python 2? That, uh, seems weird and might be worth investigating.

Jun 16 2018, 1:35 PM

Jun 12 2018

indygreg committed rHG1d6066336d7b: mercurial: add .t files to .editorconfig.
mercurial: add .t files to .editorconfig
Jun 12 2018, 12:57 PM
indygreg closed D3702: mercurial: add .t files to .editorconfig.
Jun 12 2018, 12:57 PM

Jun 7 2018

indygreg accepted D3699: run-tests: follow-up on the test-case format.
Jun 7 2018, 7:44 PM
indygreg created D3702: mercurial: add .t files to .editorconfig.
Jun 7 2018, 7:19 PM

Jun 6 2018

indygreg committed rHGc0081d3e1598: zstandard: pull in bug fixes from upstream 0.9.1 release (issue5884).
zstandard: pull in bug fixes from upstream 0.9.1 release (issue5884)
Jun 6 2018, 12:33 PM

May 30 2018

indygreg added a comment to D3665: graph: improve graph output by using Unicode characters.

I think this is a cool idea! I could nitpick some of the glyph choices (e.g. U+233E ⌾ is really small and harder to read than @ and U+25CC ◌ looks like a circle and therefore the standard node type). But overall I like it!

May 30 2018, 9:10 PM
indygreg added a comment to D3557: extensions: new closehead module for closing arbitrary heads.

I'm -0.25 on this.

May 30 2018, 9:03 PM
indygreg added a comment to D3676: fuzzutil: make it possible to use absl when C++17 isn't supported.

I'm assuming https://abseil.io/ is part of the standard environment in oss-fuzz. Otherwise, we may want to vendor it or provide a script to download it or something.

May 30 2018, 8:54 PM
indygreg added a comment to D3665: graph: improve graph output by using Unicode characters.

I installed Dejavu Sans Mono from https://dejavu-fonts.github.io/ and it works great!

May 30 2018, 5:02 PM
indygreg added a comment to D3665: graph: improve graph output by using Unicode characters.

FWIW, this isn't rendering nicely with PuTTY on Windows 10. The U+25EF ◯ glyph is being truncated on the right side. I'm also seeing empty squares for U+233E ⌾ and other code points. Using Courier New as the terminal font. LANG=en_US.UTF-8 and TERM=xterm-256color, so Mercurial detects the encoding as UTF-8.

May 30 2018, 3:33 PM

May 25 2018

indygreg accepted D3660: graft: drop --user and --date values info from hint in case of conflicts.
May 25 2018, 5:10 PM
indygreg accepted D3659: graft: reuse --user and --date values in `hg graft --continue` (BC).
May 25 2018, 5:09 PM
indygreg accepted D3658: tests: add test showing --continue not preserving --date and --user flags.
May 25 2018, 5:09 PM
indygreg accepted D3657: graft: store user passed date and user information in graftstate.

I'm assuming we don't need to bump the state version since the new state file format is still relatively new. But if we had shipped the new state file in a release, I would insist on bumping the state version any time new data is added to state.

May 25 2018, 5:08 PM

May 21 2018

indygreg accepted D3618: pathencode: remove unused variable.
May 21 2018, 2:37 PM
indygreg accepted D3635: py3: add support for NoneType in stringutil.pprint().
May 21 2018, 2:30 PM
indygreg accepted D3634: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py.
May 21 2018, 2:29 PM
indygreg accepted D3633: py3: use bytes in tests/printenv.py.

This one worries me a bit because environment variable values can contain non-ASCII. However, the changed code only operates on HG_ variables and I think those variables are well-sanitized and should be ASCII safe.

May 21 2018, 2:29 PM
indygreg accepted D3632: py3: use stringutil.pprint() to prevent b'' prefixes in output.
May 21 2018, 2:25 PM
indygreg accepted D3631: py3: use pycompat.fsencode to convert path to bytes.
May 21 2018, 2:24 PM
indygreg accepted D3630: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t.
May 21 2018, 2:24 PM
indygreg accepted D3629: py3: add b'' prefixes in contrib/hg-ssh.
May 21 2018, 2:24 PM

May 18 2018

indygreg closed D3573: hgweb: extract code for emitting multiple changelist records.
May 18 2018, 10:24 AM
indygreg committed rHG5989261a8356: hgweb: extract code for emitting multiple changelist records.
hgweb: extract code for emitting multiple changelist records
May 18 2018, 10:24 AM

May 17 2018

indygreg created D3573: hgweb: extract code for emitting multiple changelist records.
May 17 2018, 3:27 PM