Page MenuHomePhabricator

indygreg (Gregory Szorc)
User

Projects

User Details

User Since
Jul 1 2017, 5:02 PM (106 w, 5 d)

Recent Activity

Sun, Jun 30

indygreg closed D5805: zeroconf: port to Python 3.
Sun, Jun 30, 6:57 AM
indygreg committed rHGfa2071753dc2: zeroconf: port to Python 3.
zeroconf: port to Python 3
Sun, Jun 30, 6:57 AM

May 28 2019

indygreg added a comment to D6417: context: get filesadded() and filesremoved() from changeset if configured.

I'm also not super crazy about abusing extras for this. But it is the best compromise considering the "better" solutions require a lot more effort and thought. At some point, I would like Mercurial's storage and wire protocol to grow official APIs for storing and exchanging arbitrary data outside the current storage primitives. Maybe we can shoehorn storage into revlogs in .hg/store/meta. I dunno. Feels like sprint material to me.

May 28 2019, 9:59 PM

May 24 2019

indygreg accepted D6443: py3: use range() instead of xrange().
May 24 2019, 11:19 PM

May 17 2019

indygreg added a comment to D6387: bookmarks: keep bookmarks in .hg/store if new config set.

I still need to look at this commit in detail, but any commit that alters the on-disk or on-network behavior of Mercurial should ideally be accompanied by a docs change to mercurial/help/internals. I say ideally because some things still aren't documented. But repo requirements are. Please follow up with a patch to document the new requirement in mercurial/help/internals/requirements.txt.

May 17 2019, 11:43 PM

May 15 2019

indygreg closed D6319: automation: initial support for running Linux tests.
May 15 2019, 11:47 AM
indygreg committed rHG65b3ef162b39: automation: initial support for running Linux tests.
automation: initial support for running Linux tests
May 15 2019, 11:46 AM
indygreg closed D6318: automation: move image operations to own functions.
May 15 2019, 11:46 AM
indygreg committed rHG195dcc10b3d7: automation: move image operations to own functions.
automation: move image operations to own functions
May 15 2019, 11:46 AM
indygreg committed rHG5c242c427897: automation: do a force push to synchronize.
automation: do a force push to synchronize
May 15 2019, 11:46 AM
indygreg committed rHG4274b1369b75: automation: add check that hg source directory is a repo.
automation: add check that hg source directory is a repo
May 15 2019, 11:46 AM
indygreg committed rHGd137a3d5ad41: automation: add --version argument to build-all-windows-packages.
automation: add --version argument to build-all-windows-packages
May 15 2019, 11:46 AM
indygreg closed D6317: automation: add --version argument to build-all-windows-packages.
May 15 2019, 11:46 AM
indygreg closed D6286: automation: wait for instance profiles and roles.
May 15 2019, 11:46 AM
indygreg closed D6316: automation: do a force push to synchronize.
May 15 2019, 11:46 AM
indygreg closed D6315: automation: add check that hg source directory is a repo.
May 15 2019, 11:46 AM
indygreg closed D6288: automation: shore up rebooting behavior.
May 15 2019, 11:46 AM
indygreg committed rHGe570106beda1: automation: shore up rebooting behavior.
automation: shore up rebooting behavior
May 15 2019, 11:46 AM
indygreg committed rHG8dc22a209420: automation: wait for instance profiles and roles.
automation: wait for instance profiles and roles
May 15 2019, 11:46 AM
indygreg committed rHGf30184484dd1: automation: wait longer for WinRM connection.
automation: wait longer for WinRM connection
May 15 2019, 11:46 AM
indygreg closed D6285: automation: don't create resources when deleting things.
May 15 2019, 11:46 AM
indygreg closed D6287: automation: wait longer for WinRM connection.
May 15 2019, 11:46 AM
indygreg committed rHGdd6a9723ae2b: automation: don't create resources when deleting things.
automation: don't create resources when deleting things
May 15 2019, 11:46 AM
indygreg committed rHG730edbd836d8: automation: only iterate over our AMIs.
automation: only iterate over our AMIs
May 15 2019, 11:46 AM
indygreg committed rHGfcb97cb91ff8: automation: detach policies before deleting role.
automation: detach policies before deleting role
May 15 2019, 11:46 AM
indygreg closed D6284: automation: detach policies before deleting role.
May 15 2019, 11:46 AM
indygreg closed D6283: automation: only iterate over our AMIs.
May 15 2019, 11:46 AM

Apr 27 2019

indygreg created D6319: automation: initial support for running Linux tests.
Apr 27 2019, 2:52 PM
indygreg created D6318: automation: move image operations to own functions.
Apr 27 2019, 2:51 PM
indygreg created D6317: automation: add --version argument to build-all-windows-packages.
Apr 27 2019, 2:51 PM
indygreg created D6316: automation: do a force push to synchronize.
Apr 27 2019, 2:51 PM
indygreg updated the diff for D6286: automation: wait for instance profiles and roles.
Apr 27 2019, 2:51 PM
indygreg created D6315: automation: add check that hg source directory is a repo.
Apr 27 2019, 2:51 PM

Apr 24 2019

indygreg accepted D6306: copies: write empty entries in changeset when also writing to filelog.
Apr 24 2019, 10:21 PM
indygreg added a comment to D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).

Ideally the new part would be documented in internals.bundle2. But other narrow parts aren't documented, so maybe we can hold off...

Apr 24 2019, 10:17 PM
indygreg accepted D6300: phabricator: read more metadata from local:commits.
Apr 24 2019, 10:13 PM
indygreg accepted D6299: phabricator: don't assume the existence of properties of local:commits.
Apr 24 2019, 10:13 PM
indygreg added inline comments to D6298: phabricator: include commit (node) and parent in the local:commits metadata.
Apr 24 2019, 10:12 PM
indygreg accepted D6297: phabricator: include branch in the diffproperty metadata.
Apr 24 2019, 10:12 PM

Apr 22 2019

indygreg closed D6294: commands: use byteskwargs() in verify().
Apr 22 2019, 9:03 AM
indygreg closed D6293: match: use raw strings to avoid illegal baskslash escape.
Apr 22 2019, 9:03 AM
indygreg committed rHG90d48c1c6224: commands: use byteskwargs() in verify().
commands: use byteskwargs() in verify()
Apr 22 2019, 9:03 AM
indygreg committed rHGfd384911f51b: match: use raw strings to avoid illegal baskslash escape.
match: use raw strings to avoid illegal baskslash escape
Apr 22 2019, 9:03 AM

Apr 21 2019

indygreg committed rHGcd1bede340b0: setup: tweak error message for Python 3.
setup: tweak error message for Python 3
Apr 21 2019, 6:18 PM
indygreg committed rHGbd92dd3eff42: setup: remove set and dict comprehensions.
setup: remove set and dict comprehensions
Apr 21 2019, 6:18 PM
indygreg created D6294: commands: use byteskwargs() in verify().
Apr 21 2019, 12:37 PM
indygreg created D6293: match: use raw strings to avoid illegal baskslash escape.
Apr 21 2019, 12:37 PM

Apr 20 2019

indygreg committed rHG71d8b4d91616: setup: properly package distutils in py2exe virtualenv builds.
setup: properly package distutils in py2exe virtualenv builds
Apr 20 2019, 8:54 PM

Apr 19 2019

indygreg requested changes to D6267: incoming: detect if server send partial replies.
Apr 19 2019, 11:07 AM
indygreg created D6288: automation: shore up rebooting behavior.
Apr 19 2019, 10:41 AM
indygreg created D6286: automation: wait for instance profiles and roles.
Apr 19 2019, 10:41 AM
indygreg created D6287: automation: wait longer for WinRM connection.
Apr 19 2019, 10:41 AM
indygreg updated the summary of D6285: automation: don't create resources when deleting things.
Apr 19 2019, 10:41 AM
indygreg created D6285: automation: don't create resources when deleting things.
Apr 19 2019, 8:20 AM
indygreg created D6284: automation: detach policies before deleting role.
Apr 19 2019, 8:20 AM
indygreg created D6283: automation: only iterate over our AMIs.
Apr 19 2019, 8:20 AM

Apr 17 2019

indygreg requested changes to D6267: incoming: detect if server send partial replies.

+1 for feature. Needs some minor work to get review.

Apr 17 2019, 5:56 PM
indygreg added a comment to D6259: [POC] revset: on-disk cache for children queries.

Do you have performance numbers to share? Substantial wins would definitely pique my interest :)

Apr 17 2019, 6:54 AM
indygreg added a comment to D6183: copies: add config option for writing copy metadata to file and/or changset.

An idea to consider (which may have been proposed already) is to write a *no copy metadata* entry into extras when writing copy metadata to the changelog. If we did things this way, a new client could know definitively that no copy metadata is available and to not fall back to reading from the filelogs. I haven't fully thought this through, but that should provide better compatibility between older and newer clients. Obviously the tradeoff is you could have a mixed repo (some changesets wouldn't have copy metadata in changelog) and you would need to duplicate copy metadata across changelog and filelogs to maintain compatibility. Something to contemplate...

Apr 17 2019, 6:43 AM
indygreg added a comment to D6183: copies: add config option for writing copy metadata to file and/or changset.

I support experimenting with putting copy metadata in the changelog. And the patches before this one did a lot of work to allow copy metadata to be read from alternate sources, which is great, since it can allow flexibility in the future (think copy caches, copy modifications outside of a commit, etc).

Apr 17 2019, 6:38 AM
indygreg added a comment to D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019).

This patch is backwards incompatible over the wire protocol.

Apr 17 2019, 6:04 AM
indygreg added a comment to D6258: packaging: coerce paths to strings.

Argh. This change appears to be wrong (!) so I'm going to drop it.

Apr 17 2019, 5:49 AM

Apr 5 2019

indygreg committed rHG675775c33ab6: zstandard: vendor python-zstandard 0.11.
zstandard: vendor python-zstandard 0.11
Apr 5 2019, 7:57 AM
indygreg closed D6200: perf: make perf.run-limits code work with Python 3.
Apr 5 2019, 7:57 AM
indygreg closed D6199: zstandard: vendor python-zstandard 0.11.
Apr 5 2019, 7:57 AM
indygreg committed rHG668eff08387f: cext: make osutil.c PY_SSIZE_T_CLEAN.
cext: make osutil.c PY_SSIZE_T_CLEAN
Apr 5 2019, 7:57 AM
indygreg committed rHG896b19d12c08: cext: make parsers.c PY_SSIZE_T_CLEAN.
cext: make parsers.c PY_SSIZE_T_CLEAN
Apr 5 2019, 7:57 AM
indygreg closed D6198: cext: make osutil.c PY_SSIZE_T_CLEAN.
Apr 5 2019, 7:57 AM
indygreg closed D6197: cext: make parsers.c PY_SSIZE_T_CLEAN.
Apr 5 2019, 7:57 AM
indygreg closed D6196: cext: make revlog.c PY_SSIZE_T_CLEAN.
Apr 5 2019, 7:57 AM
indygreg committed rHGb01bbb8ff1f2: cext: make revlog.c PY_SSIZE_T_CLEAN.
cext: make revlog.c PY_SSIZE_T_CLEAN
Apr 5 2019, 7:57 AM
indygreg closed D6202: setup: use raw string for regular expression.
Apr 5 2019, 7:57 AM
indygreg closed D6203: tests: add optional output for Python 2.7 deprecation.
Apr 5 2019, 7:57 AM
indygreg committed rHG65ed223619ec: tests: add optional output for Python 2.7 deprecation.
tests: add optional output for Python 2.7 deprecation
Apr 5 2019, 7:57 AM
indygreg committed rHGfecbd93a5f08: setup: use raw string for regular expression.
setup: use raw string for regular expression
Apr 5 2019, 7:57 AM
indygreg closed D6201: automation: use raw strings when there are backslashes.
Apr 5 2019, 7:57 AM
indygreg committed rHG0e9066db5e44: automation: use raw strings when there are backslashes.
automation: use raw strings when there are backslashes
Apr 5 2019, 7:57 AM
indygreg committed rHG912d82daeda3: perf: make perf.run-limits code work with Python 3.
perf: make perf.run-limits code work with Python 3
Apr 5 2019, 7:57 AM

Apr 4 2019

indygreg created D6200: perf: make perf.run-limits code work with Python 3.
Apr 4 2019, 9:22 PM
indygreg created D6203: tests: add optional output for Python 2.7 deprecation.
Apr 4 2019, 9:21 PM
indygreg created D6202: setup: use raw string for regular expression.
Apr 4 2019, 9:21 PM
indygreg created D6201: automation: use raw strings when there are backslashes.
Apr 4 2019, 9:21 PM
indygreg created D6199: zstandard: vendor python-zstandard 0.11.
Apr 4 2019, 9:21 PM
indygreg created D6198: cext: make osutil.c PY_SSIZE_T_CLEAN.
Apr 4 2019, 6:31 PM
indygreg created D6197: cext: make parsers.c PY_SSIZE_T_CLEAN.
Apr 4 2019, 6:31 PM
indygreg created D6196: cext: make revlog.c PY_SSIZE_T_CLEAN.
Apr 4 2019, 6:31 PM

Apr 2 2019

indygreg added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

I would prefer you fix them :)

Okay, then what should we call it? --extra-packages-script since that's what it's for?

Apr 2 2019, 3:25 PM
indygreg added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

I would prefer you fix them :)

Apr 2 2019, 2:05 PM
indygreg requested changes to D6164: wix: add a hook for a prebuild script to inject extra libraries.

Was a newer version of this patch with the requested changes going to be uploaded? It's weird to see additional patches in the series without this one updated...

Apr 2 2019, 1:41 PM

Mar 27 2019

indygreg closed D6142: automation: perform tasks on remote machines.
Mar 27 2019, 3:37 PM
indygreg committed rHGb05a3e28cf24: automation: perform tasks on remote machines.
automation: perform tasks on remote machines
Mar 27 2019, 3:36 PM
indygreg closed D6141: contrib: PowerShell script to install development dependencies.
Mar 27 2019, 3:36 PM
indygreg committed rHGbf87d34a675c: contrib: PowerShell script to install development dependencies.
contrib: PowerShell script to install development dependencies
Mar 27 2019, 3:36 PM

Mar 25 2019

indygreg added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

How about we add an argument to define the path(s) to the pip requirements file(s) to use? By default, it can use the requirements.txt in the repo. Would that solve your use case?

No, because I have some stuff which (out of tragic necessity at the moment) isn't pip installable, and I have to install it into the virtualenv by banging some rocks together. :(

Mar 25 2019, 1:14 PM
indygreg added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.
Mar 25 2019, 12:25 PM

Mar 23 2019

indygreg added a comment to D6142: automation: perform tasks on remote machines.

I don't know anything about PowerShell or AWS, but this series looks nice for making Windows easier to deal with.
What was the problem with python3 tests? I've been able to run them locally (though a bunch fail with py3 issues).

Mar 23 2019, 12:03 PM
indygreg added a comment to D6164: wix: add a hook for a prebuild script to inject extra libraries.

I like the flexibility. But I'm not super keen about the interface here. Using a script to inject custom options seems like it could be useful. But as it is currently implemented, the script simply prints out \0 delimited package names. So one UI wart is --extra-prebuild-script being a somewhat generic name but that script only emits package names. --extra-packages-script would be a better name.

Mar 23 2019, 11:04 AM

Mar 17 2019

indygreg committed rHG51685c6dcca3: wix: restore COPYING.rtf.
wix: restore COPYING.rtf
Mar 17 2019, 6:35 PM
indygreg closed D6098: wix: restore COPYING.rtf.
Mar 17 2019, 6:35 PM

Mar 16 2019

indygreg added a comment to D6135: packaging: don't bundle DLLs in py2exe library.zip for x86 builds.

According to a private email, things were inconsistent because py2exe didn't (doesn't?) support bundling DLLs in the zip several years ago, so things *had* to be a certain way.

Mar 16 2019, 1:39 PM