indygreg (Gregory Szorc)
User

Projects

User Details

User Since
Jul 1 2017, 5:02 PM (72 w, 1 d)

Recent Activity

Wed, Nov 14

indygreg closed D5267: revlog: automatically read from opened file handles.
Wed, Nov 14, 7:29 AM
indygreg closed D5266: revlog: detect incomplete revlog reads.
Wed, Nov 14, 7:29 AM
indygreg closed D5265: revlog: use single file handle when de-inlining revlog.
Wed, Nov 14, 7:29 AM
indygreg committed rHGe9293c5f8bb9: revlog: automatically read from opened file handles.
revlog: automatically read from opened file handles
Wed, Nov 14, 7:29 AM
indygreg committed rHG87a872555e90: revlog: detect incomplete revlog reads.
revlog: detect incomplete revlog reads
Wed, Nov 14, 7:29 AM
indygreg committed rHG39369475445c: revlog: use single file handle when de-inlining revlog.
revlog: use single file handle when de-inlining revlog
Wed, Nov 14, 7:29 AM

Tue, Nov 13

indygreg added a comment to D5064: style: run black on a subset of mercurial.

Where do we stand on the intent to mass reformat the code base?

Tue, Nov 13, 8:20 PM
indygreg added a comment to D5170: branchmap: pass changelog into revbranchcache.branchinfo().

I think this patch can be abandoned because of other work late in the 4.8 cycle?

Tue, Nov 13, 8:15 PM
indygreg created D5267: revlog: automatically read from opened file handles.
Tue, Nov 13, 3:41 PM
indygreg created D5266: revlog: detect incomplete revlog reads.
Tue, Nov 13, 3:41 PM
indygreg created D5265: revlog: use single file handle when de-inlining revlog.
Tue, Nov 13, 3:41 PM
indygreg added a dependent revision for D5266: revlog: detect incomplete revlog reads: D5267: revlog: automatically read from opened file handles.
Tue, Nov 13, 3:41 PM
indygreg added a dependent revision for D5265: revlog: use single file handle when de-inlining revlog: D5266: revlog: detect incomplete revlog reads.
Tue, Nov 13, 3:41 PM
indygreg added a comment to D5263: py3: add b suffix to make sure file is opened in bytes mode.

Ideally we'd be using the vfs layer for I/O. But that is scope bloat and I'm not going to make you rewrite RFL to do things more correctly.

Tue, Nov 13, 1:48 PM
indygreg added inline comments to D5262: py3: don't use dict.iterkeys().
Tue, Nov 13, 1:46 PM

Fri, Nov 9

indygreg committed rHG6107d4549fcc: hgweb: cast bytearray to bytes.
hgweb: cast bytearray to bytes
Fri, Nov 9, 10:23 PM

Tue, Nov 6

indygreg closed D5221: localrepo: extract loading of hgrc files to standalone function.
Tue, Nov 6, 7:27 AM
indygreg committed rHG473510bf0575: localrepo: extract loading of hgrc files to standalone function.
localrepo: extract loading of hgrc files to standalone function
Tue, Nov 6, 7:27 AM

Mon, Nov 5

indygreg requested changes to D5224: revlog: check if PyInt_AS_LONG failed before using result.

IIRC we #define PyInt and PyLong in the source for Python 3 compatibility. I remember doing something really hacky to unblock getting the C extensions to compile on Python 3 at the Paris sprint. It would definitely be a good idea to audit everything with PyInt and PyLong in it for sanity.

Mon, Nov 5, 11:16 PM
indygreg created D5221: localrepo: extract loading of hgrc files to standalone function.
Mon, Nov 5, 5:16 PM

Wed, Oct 31

indygreg added inline comments to D5163: filelog: add a hasnode() method (API).
Wed, Oct 31, 4:11 PM
indygreg updated subscribers of D4750: filelog: stop proxying rawsize() (API).

Apparently thg uses this to avoid loading the data into memory just to figure out the length like fctx.rawsize(). Any suggestions?

https://groups.google.com/d/msg/thg-dev/6ekYID7ho_o/fbdd6rVDAwAJ

Wed, Oct 31, 3:19 PM
indygreg accepted D5196: changegroup: restore default node ordering (issue6001).

db5501d93bcf6ada3426a45e901094fd877e370f changed a test. I'm surprised this patch doesn't include that revert as well. I'll verify the test as part of landing and amend as necessary.

Wed, Oct 31, 3:06 PM
indygreg accepted D5195: changegroup: introduce an explicit linear sorting.

Yeah, I'm OK with this. There is tons of room to experiment with different ordering techniques - including making it end-user configurable. Having this code in place is a step in the right direction.

Wed, Oct 31, 2:59 PM
indygreg added a comment to D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3.

Is this useful enough to others that it should live in the hg core repo? It doesn't seem like it to me, but maybe I'm wrong.

Wed, Oct 31, 11:30 AM

Mon, Oct 22

indygreg closed D5167: wireprotov2: support exposing linknode of file revisions.
Mon, Oct 22, 11:50 AM
indygreg closed D5169: exchangev2: support fetching shallow files history.
Mon, Oct 22, 11:49 AM
indygreg closed D5166: localrepo: support marking repos as having shallow file storage.
Mon, Oct 22, 11:49 AM
indygreg committed rHG229d23cdb203: exchangev2: support fetching shallow files history.
exchangev2: support fetching shallow files history
Mon, Oct 22, 11:49 AM
indygreg closed D5164: commands: support passing depth to hg.clone().
Mon, Oct 22, 11:49 AM
indygreg committed rHG595641bd8404: sqlitestore: support for storing revisions without their parents.
sqlitestore: support for storing revisions without their parents
Mon, Oct 22, 11:49 AM
indygreg committed rHGabbd077965c0: wireprotov2: support exposing linknode of file revisions.
wireprotov2: support exposing linknode of file revisions
Mon, Oct 22, 11:49 AM
indygreg closed D5168: sqlitestore: support for storing revisions without their parents.
Mon, Oct 22, 11:49 AM
indygreg closed D5165: repository: teach addgroup() to receive data with missing parents.
Mon, Oct 22, 11:48 AM
indygreg committed rHG7e3b6c4f01a2: localrepo: support marking repos as having shallow file storage.
localrepo: support marking repos as having shallow file storage
Mon, Oct 22, 11:48 AM
indygreg closed D5163: filelog: add a hasnode() method (API).
Mon, Oct 22, 11:48 AM
indygreg committed rHG1b183edbb68e: repository: teach addgroup() to receive data with missing parents.
repository: teach addgroup() to receive data with missing parents
Mon, Oct 22, 11:48 AM
indygreg committed rHG5cb72229f0e9: commands: support passing depth to hg.clone().
commands: support passing depth to hg.clone()
Mon, Oct 22, 11:48 AM
indygreg committed rHGf1a39128da95: filelog: add a hasnode() method (API).
filelog: add a hasnode() method (API)
Mon, Oct 22, 11:48 AM

Oct 19 2018

indygreg committed rHG76d4272bd57b: branchmap: avoid changelog and attribute lookups in replacecache().
branchmap: avoid changelog and attribute lookups in replacecache()
Oct 19 2018, 1:20 PM
indygreg committed rHG47c03042cd1d: branchmap: pass changelog into branchmap functions.
branchmap: pass changelog into branchmap functions
Oct 19 2018, 1:20 PM
indygreg closed D5162: branchmap: avoid changelog and attribute lookups in replacecache().
Oct 19 2018, 1:20 PM
indygreg closed D5161: branchmap: pass changelog into branchmap functions.
Oct 19 2018, 1:20 PM
indygreg created D5169: exchangev2: support fetching shallow files history.
Oct 19 2018, 1:02 PM
indygreg added a dependent revision for D5168: sqlitestore: support for storing revisions without their parents: D5169: exchangev2: support fetching shallow files history.
Oct 19 2018, 1:02 PM
indygreg created D5168: sqlitestore: support for storing revisions without their parents.
Oct 19 2018, 1:02 PM
indygreg added a dependent revision for D5167: wireprotov2: support exposing linknode of file revisions: D5168: sqlitestore: support for storing revisions without their parents.
Oct 19 2018, 1:02 PM
indygreg created D5167: wireprotov2: support exposing linknode of file revisions.
Oct 19 2018, 1:02 PM
indygreg created D5166: localrepo: support marking repos as having shallow file storage.
Oct 19 2018, 1:01 PM
indygreg added a dependent revision for D5166: localrepo: support marking repos as having shallow file storage: D5167: wireprotov2: support exposing linknode of file revisions.
Oct 19 2018, 1:01 PM
indygreg added a dependent revision for D5165: repository: teach addgroup() to receive data with missing parents: D5166: localrepo: support marking repos as having shallow file storage.
Oct 19 2018, 1:01 PM
indygreg created D5165: repository: teach addgroup() to receive data with missing parents.
Oct 19 2018, 1:01 PM
indygreg added a dependent revision for D5164: commands: support passing depth to hg.clone(): D5165: repository: teach addgroup() to receive data with missing parents.
Oct 19 2018, 1:01 PM
indygreg created D5164: commands: support passing depth to hg.clone().
Oct 19 2018, 1:01 PM
indygreg added a dependent revision for D5163: filelog: add a hasnode() method (API): D5164: commands: support passing depth to hg.clone().
Oct 19 2018, 1:00 PM
indygreg created D5163: filelog: add a hasnode() method (API).
Oct 19 2018, 1:00 PM
indygreg created D5162: branchmap: avoid changelog and attribute lookups in replacecache().
Oct 19 2018, 12:56 PM
indygreg added a dependent revision for D5161: branchmap: pass changelog into branchmap functions: D5162: branchmap: avoid changelog and attribute lookups in replacecache().
Oct 19 2018, 12:56 PM
indygreg created D5161: branchmap: pass changelog into branchmap functions.
Oct 19 2018, 12:56 PM

Oct 17 2018

indygreg added a comment to D5137: streamclone: new server config and some API changes for narrow stream clones.

There are no children reviews of this one. Could you please set the parent-child relationships so the entire stack renders in the web UI?

Oct 17 2018, 11:26 AM
indygreg added a comment to D5137: streamclone: new server config and some API changes for narrow stream clones.

I'll hold off formally accepting until the whole series is up. But this looks pretty good.

Oct 17 2018, 11:19 AM
indygreg accepted D5119: exchange: pass includepats and excludepats as arguments to getbundle().
Oct 17 2018, 11:15 AM
indygreg closed D5134: wireprotov2: implement command for retrieving raw store files.
Oct 17 2018, 9:46 AM
indygreg closed D5136: exchange: support declaring pull depth.
Oct 17 2018, 9:46 AM
indygreg committed rHGac59de55c8b4: exchange: support declaring pull depth.
exchange: support declaring pull depth
Oct 17 2018, 9:46 AM
indygreg closed D5135: exchangev2: support for calling rawstorefiledata to retrieve raw files.
Oct 17 2018, 9:46 AM
indygreg committed rHGed55a0077490: wireprotov2: implement command for retrieving raw store files.
wireprotov2: implement command for retrieving raw store files
Oct 17 2018, 9:46 AM
indygreg closed D5133: wireprotov2: add response type that serializes to indefinite length bytestring.
Oct 17 2018, 9:46 AM
indygreg committed rHG00a4cd368e3f: exchangev2: support for calling rawstorefiledata to retrieve raw files.
exchangev2: support for calling rawstorefiledata to retrieve raw files
Oct 17 2018, 9:46 AM
indygreg committed rHG2c55716f8a1c: wireprotov2: add response type that serializes to indefinite length bytestring.
wireprotov2: add response type that serializes to indefinite length bytestring
Oct 17 2018, 9:45 AM
indygreg closed D5132: exchangev2: recognize narrow patterns when pulling.
Oct 17 2018, 9:45 AM
indygreg committed rHG55836a34f41b: exchangev2: recognize narrow patterns when pulling.
exchangev2: recognize narrow patterns when pulling
Oct 17 2018, 9:45 AM
indygreg closed D4928: sqlitestore: file storage backend using SQLite.
Oct 17 2018, 9:22 AM
indygreg closed D5118: storageutil: extract most of peek_censored from revlog.
Oct 17 2018, 9:22 AM
indygreg committed rHGfed697fa1734: sqlitestore: file storage backend using SQLite.
sqlitestore: file storage backend using SQLite
Oct 17 2018, 9:22 AM
indygreg committed rHGb0fbd1792e2d: storageutil: extract most of peek_censored from revlog.
storageutil: extract most of peek_censored from revlog
Oct 17 2018, 9:22 AM
indygreg accepted D5131: remotefilelog: add some docstring.
Oct 17 2018, 9:18 AM
indygreg created D5136: exchange: support declaring pull depth.
Oct 17 2018, 9:18 AM
indygreg created D5134: wireprotov2: implement command for retrieving raw store files.
Oct 17 2018, 9:18 AM
indygreg created D5135: exchangev2: support for calling rawstorefiledata to retrieve raw files.
Oct 17 2018, 9:17 AM
indygreg added a dependent revision for D5135: exchangev2: support for calling rawstorefiledata to retrieve raw files: D5136: exchange: support declaring pull depth.
Oct 17 2018, 9:17 AM
indygreg added a dependent revision for D5133: wireprotov2: add response type that serializes to indefinite length bytestring: D5134: wireprotov2: implement command for retrieving raw store files.
Oct 17 2018, 9:17 AM
indygreg created D5133: wireprotov2: add response type that serializes to indefinite length bytestring.
Oct 17 2018, 9:17 AM
indygreg added a dependent revision for D5132: exchangev2: recognize narrow patterns when pulling: D5133: wireprotov2: add response type that serializes to indefinite length bytestring.
Oct 17 2018, 9:17 AM
indygreg created D5132: exchangev2: recognize narrow patterns when pulling.
Oct 17 2018, 9:17 AM
indygreg added a dependent revision for D4928: sqlitestore: file storage backend using SQLite: D5132: exchangev2: recognize narrow patterns when pulling.
Oct 17 2018, 9:17 AM
indygreg added a comment to D5130: lfs: autoload the extension when cloning from repo with lfs enabled.

! In D5130#76736, @mharbison72 wrote:
Will do. How hard do you think it will be to do the same thing for pull?

Oct 17 2018, 8:09 AM
indygreg updated the diff for D4928: sqlitestore: file storage backend using SQLite.
Oct 17 2018, 4:28 AM
indygreg abandoned D4767: exchangev2: recognize narrow patterns when pulling.

I'll resubmit this as part of another series.

Oct 17 2018, 4:11 AM
indygreg abandoned D4766: fastcheckout: arguments to make checkout narrow.

Per discussions at 4.8 sprint, we're going to hold off on this.

Oct 17 2018, 4:11 AM
indygreg abandoned D4765: fastcheckout: extension for obtaining a checkout quickly.

Per discussions at 4.8 sprint, we're going to hold off on this.

Oct 17 2018, 4:11 AM
indygreg added a comment to D5130: lfs: autoload the extension when cloning from repo with lfs enabled.

Thank you for finishing what I started and implementing this properly (by adding a separate server-side capability to distinguish between LFS states).

Oct 17 2018, 3:31 AM
indygreg added a comment to D4782: remotefilelog: import pruned-down remotefilelog extension from hg-experimental.

I need to give the final state of the code a final one-over. I will do that after breakfast.

Oct 17 2018, 3:06 AM
indygreg accepted D5124: remotefilelog: remove now-unused wirepack code.
Oct 17 2018, 3:00 AM
indygreg accepted D5123: remotefilelogserver: remove pack-serving functionality.

The optics to removing this are a bit bad because efficient pack transfer can lead to significant performance gains. While I think the use of packs in Mercurial for exchange will occur at some time, the path to stabilization in core is not clear and will almost certainly see a BC break from this code. I'm fine removing this functionality from RFL for now. We can always add something similar later.

Oct 17 2018, 3:00 AM
indygreg accepted D5121: procutil: port over windows encoding fixes from logtoprocess.
Oct 17 2018, 2:57 AM
indygreg accepted D5129: remotefilelog: rename wireproto methods and remaining capabilities.

Yuck. But the names don't matter much for an experimental feature. And the wireproto v1 peer batching code dictates certain things with regards to naming. So our hands are a bit tied here :/

Oct 17 2018, 2:56 AM
indygreg accepted D5128: remotefilelog: consolidate and rename on-disk store requirement.

\o/

Oct 17 2018, 2:54 AM
indygreg accepted D5127: remotefilelog: consolidate and rename bundle2 capability.

Nice catch on the overloaded capability name! Constants are better for expressing intent.

Oct 17 2018, 2:53 AM
indygreg accepted D5126: remotefilelog: rename capability for legacy ssh file fetching method.
Oct 17 2018, 2:51 AM