joerg.sonnenberger (Joerg Sonnenberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 9:25 AM (24 w, 35 m)

Recent Activity

Mon, May 21

joerg.sonnenberger added a comment to D3557: commit: add new close-branch command.

It doesn't seem to fit the argument schema for hg branch at all. I'm open for better places, but I couldn't think of a consistent place.

Mon, May 21, 5:03 PM

Thu, May 17

joerg.sonnenberger closed D3553: notify: add option to include function names in the diff output.
Thu, May 17, 8:12 AM
joerg.sonnenberger committed rHGd1134ca5b1a3: notify: add option to include function names in the diff output.
notify: add option to include function names in the diff output
Thu, May 17, 8:12 AM

Wed, May 16

joerg.sonnenberger updated the diff for D3553: notify: add option to include function names in the diff output.
Wed, May 16, 9:19 AM

Sun, May 13

joerg.sonnenberger created D3557: commit: add new close-branch command.
Sun, May 13, 7:42 PM

Sat, May 12

joerg.sonnenberger created D3553: notify: add option to include function names in the diff output.
Sat, May 12, 5:44 PM
joerg.sonnenberger added a comment to D3532: wireprotov2: define and implement "rawstorefile" command.

Similar to Martin's question, I would like to allow streaming clones without any locks. For that to work, one party needs to know how to truncate additional undesired data. That can be fully done by the client or the client could send a size or revision hint to the server.

Sat, May 12, 1:35 PM

Thu, May 10

joerg.sonnenberger updated the diff for D3439: templatefilters: add commonprefix.
Thu, May 10, 10:52 AM

Wed, May 9

joerg.sonnenberger updated the diff for D3439: templatefilters: add commonprefix.
Wed, May 9, 6:53 PM
joerg.sonnenberger added a comment to D3439: templatefilters: add commonprefix.

{str|commonprefix} is not really interesting since it is naturally an iterable of text. The others are covered, the routine tries to optimize a couple of common cases as well now.

Wed, May 9, 1:51 PM
joerg.sonnenberger updated the diff for D3439: templatefilters: add commonprefix.
Wed, May 9, 1:06 PM

Tue, May 8

joerg.sonnenberger updated the diff for D3439: templatefilters: add commonprefix.
Tue, May 8, 5:14 PM
joerg.sonnenberger updated the diff for D3439: templatefilters: add commonprefix.
Tue, May 8, 11:18 AM

Sat, May 5

joerg.sonnenberger created D3439: templatefilters: add commonprefix.
Sat, May 5, 9:13 PM

Apr 18 2018

joerg.sonnenberger closed D3402: notify: add maxdiffstat option to truncate long file lists.
Apr 18 2018, 2:16 PM
joerg.sonnenberger committed rHGa4cac7b0ea4f: notify: add maxdiffstat option to truncate long file lists.
notify: add maxdiffstat option to truncate long file lists
Apr 18 2018, 2:16 PM

Apr 17 2018

joerg.sonnenberger closed D3393: bundle: introduce per-engine compression level.
Apr 17 2018, 4:46 PM
joerg.sonnenberger committed rHG6a7ff5816c5f: bundle: introduce per-engine compression level.
bundle: introduce per-engine compression level
Apr 17 2018, 4:46 PM
joerg.sonnenberger closed D3392: bundlespec: drop externalnames flag.
Apr 17 2018, 4:45 PM
joerg.sonnenberger committed rHG5527aa808dea: bundlespec: drop externalnames flag.
bundlespec: drop externalnames flag
Apr 17 2018, 4:44 PM
joerg.sonnenberger added a comment to D3393: bundle: introduce per-engine compression level.

I don't really disagree that the existing option naming is a bit stupid. There are useful points for including the compression level as part of the bundle spec, but I don't think that replaces the need for a config option for sane defaults.
As I said on IRC, a consistent approach for the three places where compression is used would be useful:

  • standalone "hg bundle" operations
  • wire compression
  • reflog compression
Apr 17 2018, 10:54 AM
joerg.sonnenberger created D3402: notify: add maxdiffstat option to truncate long file lists.
Apr 17 2018, 7:47 AM

Apr 16 2018

joerg.sonnenberger created D3393: bundle: introduce per-engine compression level.
Apr 16 2018, 9:09 PM
joerg.sonnenberger created D3392: bundlespec: drop externalnames flag.
Apr 16 2018, 9:09 PM
joerg.sonnenberger added a dependent revision for D3392: bundlespec: drop externalnames flag: D3393: bundle: introduce per-engine compression level.
Apr 16 2018, 9:08 PM

Apr 9 2018

joerg.sonnenberger closed D1856: wireproto: support for pullbundles.
Apr 9 2018, 6:49 PM
joerg.sonnenberger committed rHGaacfca6f9767: wireproto: support for pullbundles.
wireproto: support for pullbundles
Apr 9 2018, 6:47 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Apr 9 2018, 6:44 PM
joerg.sonnenberger closed D3188: revlog: reset _nodepos after strip.
Apr 9 2018, 4:13 PM
joerg.sonnenberger committed rHG1ce7a55b09d1: revlog: reset _nodepos after strip.
revlog: reset _nodepos after strip
Apr 9 2018, 4:13 PM

Apr 7 2018

joerg.sonnenberger added a comment to D1856: wireproto: support for pullbundles.

Updated to the current tree. One open question is an interaction with the narrow extension. Running the narrow tests will show an additional round trip.

Apr 7 2018, 7:18 PM
joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Apr 7 2018, 7:17 PM
joerg.sonnenberger created D3188: revlog: reset _nodepos after strip.
Apr 7 2018, 7:10 PM

Apr 6 2018

joerg.sonnenberger closed D2470: wireproto: allow direct stream processing for unbundle.
Apr 6 2018, 7:09 PM
joerg.sonnenberger committed rHG2d965bfeb8f6: wireproto: allow direct stream processing for unbundle.
wireproto: allow direct stream processing for unbundle
Apr 6 2018, 7:08 PM
joerg.sonnenberger updated the diff for D2470: wireproto: allow direct stream processing for unbundle.
Apr 6 2018, 6:43 PM
joerg.sonnenberger closed D3171: wireproto: send server capabilities in canonical order.
Apr 6 2018, 6:08 PM
joerg.sonnenberger closed D3170: wireproto: don't special case bundlecaps, but sort all scsv arguments.
Apr 6 2018, 6:07 PM
joerg.sonnenberger committed rHG33af46d639b4: wireproto: send server capabilities in canonical order.
wireproto: send server capabilities in canonical order
Apr 6 2018, 6:07 PM
joerg.sonnenberger committed rHG1d459f61b42a: wireproto: don't special case bundlecaps, but sort all scsv arguments.
wireproto: don't special case bundlecaps, but sort all scsv arguments
Apr 6 2018, 6:07 PM
joerg.sonnenberger closed D3169: wireproto: turn client capabilities into sets, sorted on the wire.
Apr 6 2018, 6:07 PM
joerg.sonnenberger committed rHG3e1688711efd: wireproto: turn client capabilities into sets, sorted on the wire.
wireproto: turn client capabilities into sets, sorted on the wire
Apr 6 2018, 6:07 PM
joerg.sonnenberger created D3171: wireproto: send server capabilities in canonical order.
Apr 6 2018, 5:39 PM
joerg.sonnenberger added a dependent revision for D3170: wireproto: don't special case bundlecaps, but sort all scsv arguments: D3171: wireproto: send server capabilities in canonical order.
Apr 6 2018, 5:39 PM
joerg.sonnenberger created D3170: wireproto: don't special case bundlecaps, but sort all scsv arguments.
Apr 6 2018, 5:39 PM
joerg.sonnenberger added a dependent revision for D3169: wireproto: turn client capabilities into sets, sorted on the wire: D3170: wireproto: don't special case bundlecaps, but sort all scsv arguments.
Apr 6 2018, 5:39 PM
joerg.sonnenberger created D3169: wireproto: turn client capabilities into sets, sorted on the wire.
Apr 6 2018, 5:39 PM
joerg.sonnenberger closed D1944: wireproto: provide accessors for client capabilities.
Apr 6 2018, 1:28 PM
joerg.sonnenberger committed rHGafcfdf53e4b5: wireproto: provide accessors for client capabilities.
wireproto: provide accessors for client capabilities
Apr 6 2018, 1:27 PM

Apr 5 2018

joerg.sonnenberger updated the diff for D1944: wireproto: provide accessors for client capabilities.
Apr 5 2018, 7:18 AM

Apr 1 2018

joerg.sonnenberger updated the diff for D1944: wireproto: provide accessors for client capabilities.
Apr 1 2018, 4:53 PM
joerg.sonnenberger abandoned D3014: rust-hglib: silence unused import of AsciiExt.

Pilot error

Apr 1 2018, 4:51 PM
joerg.sonnenberger created D3014: rust-hglib: silence unused import of AsciiExt.
Apr 1 2018, 4:42 PM

Mar 24 2018

joerg.sonnenberger updated the diff for D1944: wireproto: provide accessors for client capabilities.
Mar 24 2018, 12:59 PM

Mar 11 2018

joerg.sonnenberger closed D2753: graft: check for missing revision first before scanning working copy.
Mar 11 2018, 5:58 AM
joerg.sonnenberger committed rHGff541b8cdee0: graft: check for missing revision first before scanning working copy.
graft: check for missing revision first before scanning working copy
Mar 11 2018, 5:58 AM

Mar 10 2018

joerg.sonnenberger committed rHGf8b65ff02e3e: phabricator: update doc string for deprecated token argument.
phabricator: update doc string for deprecated token argument
Mar 10 2018, 1:21 PM
joerg.sonnenberger committed rHG98cbfbbe33bb: phabricator: print deprecation warning only once.
phabricator: print deprecation warning only once
Mar 10 2018, 1:21 PM

Mar 9 2018

joerg.sonnenberger closed D2755: phabricator: update doc string for deprecated token argument.
Mar 9 2018, 5:29 PM
joerg.sonnenberger closed D2754: phabricator: print deprecation warning only once.
Mar 9 2018, 5:29 PM
joerg.sonnenberger committed rHG0bebd4608ce3: phabricator: update doc string for deprecated token argument.
phabricator: update doc string for deprecated token argument
Mar 9 2018, 5:29 PM
joerg.sonnenberger committed rHG6490b0915881: phabricator: print deprecation warning only once.
phabricator: print deprecation warning only once
Mar 9 2018, 5:29 PM
joerg.sonnenberger created D2755: phabricator: update doc string for deprecated token argument.
Mar 9 2018, 10:12 AM
joerg.sonnenberger created D2754: phabricator: print deprecation warning only once.
Mar 9 2018, 10:10 AM
joerg.sonnenberger created D2753: graft: check for missing revision first before scanning working copy.
Mar 9 2018, 9:58 AM

Feb 27 2018

joerg.sonnenberger updated the diff for D2470: wireproto: allow direct stream processing for unbundle.
Feb 27 2018, 5:26 PM
joerg.sonnenberger updated the diff for D2470: wireproto: allow direct stream processing for unbundle.
Feb 27 2018, 5:25 PM

Feb 26 2018

joerg.sonnenberger created D2470: wireproto: allow direct stream processing for unbundle.
Feb 26 2018, 8:39 PM

Feb 11 2018

joerg.sonnenberger added a comment to D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.

There was a longish discussion on IRC about this. The problem is that the flags by themselves do not document the interaction of -r and -b or multiple instances of either at all. The change was a compromise trying to address that.

Feb 11 2018, 3:15 PM

Feb 7 2018

joerg.sonnenberger added inline comments to D2061: sshpeer: initial definition and implementation of new SSH protocol.
Feb 7 2018, 9:52 AM
joerg.sonnenberger closed D2022: ui: improve ui.write performance when not coloring on Windows.
Feb 7 2018, 8:38 AM
joerg.sonnenberger committed rHG0ff41ced4c12: diff: improve ui.write performance when not coloring on Windows.
diff: improve ui.write performance when not coloring on Windows
Feb 7 2018, 8:38 AM
joerg.sonnenberger updated the diff for D2022: ui: improve ui.write performance when not coloring on Windows.
Feb 7 2018, 7:59 AM

Feb 4 2018

joerg.sonnenberger updated the diff for D2022: ui: improve ui.write performance when not coloring on Windows.
Feb 4 2018, 8:00 AM

Feb 3 2018

joerg.sonnenberger created D2022: ui: improve ui.write performance when not coloring on Windows.
Feb 3 2018, 6:32 PM
joerg.sonnenberger abandoned D1938: ui: Improve ui.write performance when not coloring on Windows.
Feb 3 2018, 6:32 PM
joerg.sonnenberger closed D1939: ui: Improve performance for multi-component writes.
Feb 3 2018, 3:35 AM
joerg.sonnenberger committed rHGe49c39ffeac2: ui: improve performance for multi-component writes.
ui: improve performance for multi-component writes
Feb 3 2018, 3:35 AM

Feb 1 2018

joerg.sonnenberger closed D1940: patch: avoid repeated binary checks if all files in a patch are text.
Feb 1 2018, 4:47 PM
joerg.sonnenberger closed D1942: mdiff: remove rewindhunk by yielding a bool first to indicate data.
Feb 1 2018, 4:47 PM
joerg.sonnenberger committed rHG6a33e81e4c5e: mdiff: remove rewindhunk by yielding a bool first to indicate data.
mdiff: remove rewindhunk by yielding a bool first to indicate data
Feb 1 2018, 4:47 PM
joerg.sonnenberger committed rHGa9d07bd8f758: mdiff: explicitly compute places for the newline marker.
mdiff: explicitly compute places for the newline marker
Feb 1 2018, 4:47 PM
joerg.sonnenberger closed D1941: mdiff: explicitly compute places for the newline marker.
Feb 1 2018, 4:47 PM
joerg.sonnenberger committed rHG079b27b5a869: patch: avoid repeated binary checks if all files in a patch are text.
patch: avoid repeated binary checks if all files in a patch are text
Feb 1 2018, 4:47 PM

Jan 28 2018

joerg.sonnenberger updated the diff for D1856: wireproto: support for pullbundles.
Jan 28 2018, 1:38 PM
joerg.sonnenberger created D1945: tests: refactor common bundle2 capabilities.
Jan 28 2018, 7:21 AM
joerg.sonnenberger added inline comments to D1944: wireproto: provide accessors for client capabilities.
Jan 28 2018, 6:49 AM

Jan 27 2018

joerg.sonnenberger added inline comments to D1944: wireproto: provide accessors for client capabilities.
Jan 27 2018, 9:01 PM
joerg.sonnenberger created D1944: wireproto: provide accessors for client capabilities.
Jan 27 2018, 8:17 PM

Jan 26 2018

joerg.sonnenberger added a dependent revision for D1940: patch: avoid repeated binary checks if all files in a patch are text: D1941: mdiff: explicitly compute places for the newline marker.
Jan 26 2018, 11:34 AM
joerg.sonnenberger added a dependency for D1941: mdiff: explicitly compute places for the newline marker: D1940: patch: avoid repeated binary checks if all files in a patch are text.
Jan 26 2018, 11:34 AM
joerg.sonnenberger added a dependency for D1942: mdiff: remove rewindhunk by yielding a bool first to indicate data: D1941: mdiff: explicitly compute places for the newline marker.
Jan 26 2018, 11:33 AM
joerg.sonnenberger added a dependent revision for D1941: mdiff: explicitly compute places for the newline marker: D1942: mdiff: remove rewindhunk by yielding a bool first to indicate data.
Jan 26 2018, 11:33 AM
joerg.sonnenberger created D1942: mdiff: remove rewindhunk by yielding a bool first to indicate data.
Jan 26 2018, 11:33 AM
joerg.sonnenberger updated the diff for D1941: mdiff: explicitly compute places for the newline marker.
Jan 26 2018, 11:30 AM
joerg.sonnenberger added a comment to D1940: patch: avoid repeated binary checks if all files in a patch are text.

I haven't seen a performance difference for regular runs, but it does show up in profiles, so eliminating it avoids wasting mental power by developers down the line.

Jan 26 2018, 7:20 AM
joerg.sonnenberger added a comment to D1941: mdiff: explicitly compute places for the newline marker.

No, the change to yield a bool first is not strictly necessary for the rest of the logic. But it cheaply kills the need for the rewindhunk generator, i.e. it cuts a layer of indirection cheaply.

Jan 26 2018, 5:53 AM

Jan 25 2018

joerg.sonnenberger added a comment to D1941: mdiff: explicitly compute places for the newline marker.

I don't completely trust my numbers here, but it seems to give at least 3-4% for diffing netbsd-7 and netbsd-8.

Jan 25 2018, 8:36 PM
joerg.sonnenberger created D1941: mdiff: explicitly compute places for the newline marker.
Jan 25 2018, 8:35 PM
joerg.sonnenberger created D1940: patch: avoid repeated binary checks if all files in a patch are text.
Jan 25 2018, 5:36 PM