Page MenuHomePhabricator

joerg.sonnenberger (Joerg Sonnenberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 9:25 AM (191 w, 7 h)

Recent Activity

Today

joerg.sonnenberger created D11252: debugupgraderepo: add fix-metaencoding-flag pass for issue6528.
Wed, Aug 4, 4:42 PM

Tue, Jul 20

joerg.sonnenberger added a comment to D11203: revlog: recommit 49fd21f32695 with a fix for issue6528.

I would have to reaudit the parents use, but it wasn't just new code that misbehaves on misordered parents. E.g. memctx.parents for a trivial example. So yes, just backing it out introduces regressions as well.

Tue, Jul 20, 3:36 PM
joerg.sonnenberger created D11203: revlog: recommit 49fd21f32695 with a fix for issue6528.
Tue, Jul 20, 9:58 AM

Tue, Jul 6

joerg.sonnenberger added a comment to D10995: corruption: backout changeset 49fd21f32695 (issue6528).

Just the revert as is introduces other regressions. At the very least, we should preserve the sorting for changelog and keep the original order for filelog. The other part is that the filelog logic here is actively broken even before, so this doesn't fix the logic, just makes it less visibly broken.

Tue, Jul 6, 3:09 PM

Jun 21 2021

joerg.sonnenberger added a comment to D10888: copies: Keep changelog sidedata file open during copy tracing.

Can you comment on how many of them we keep open at a time?

Jun 21 2021, 5:49 AM

May 27 2021

joerg.sonnenberger added a comment to D10538: tests: allow trunk versions of clang-format to be used.

Consider it more a -0, not a very strong objection.

May 27 2021, 6:27 PM

May 20 2021

joerg.sonnenberger added a comment to D10712: tests: show that hg fails to rollback transaction on revlog split.

Correct, this stack should have beeen superseded by those.

May 20 2021, 9:23 AM
joerg.sonnenberger committed rHG46b828b85eb7: revlog: update data file record before index rename.
revlog: update data file record before index rename
May 20 2021, 4:36 AM
joerg.sonnenberger committed rHG18415fc918a1: recover: only apply last journal record per file (issue6423).
recover: only apply last journal record per file (issue6423)
May 20 2021, 4:36 AM
joerg.sonnenberger committed rHG21ed126bab53: revlog: fix index computation during inline->non-inline transition.
revlog: fix index computation during inline->non-inline transition
May 20 2021, 4:36 AM
joerg.sonnenberger committed rHG25f42db82ac8: revlog: update data file record before index rename.
revlog: update data file record before index rename
May 20 2021, 3:52 AM
joerg.sonnenberger committed rHGbca9faa0aafc: recover: only apply last journal record per file (issue6423).
recover: only apply last journal record per file (issue6423)
May 20 2021, 3:52 AM
joerg.sonnenberger committed rHGf4117223239b: revlog: fix index computation during inline->non-inline transition.
revlog: fix index computation during inline->non-inline transition
May 20 2021, 3:51 AM

May 19 2021

joerg.sonnenberger closed D10725: revlog: update data file record before index rename.
May 19 2021, 1:58 PM
joerg.sonnenberger closed D10724: revlog: fix index computation during inline->non-inline transition.
May 19 2021, 1:58 PM
joerg.sonnenberger closed D10726: recover: only apply last journal record per file (issue6423).
May 19 2021, 1:58 PM
joerg.sonnenberger committed rHG672f48cf1d03: recover: only apply last journal record per file (issue6423).
recover: only apply last journal record per file (issue6423)
May 19 2021, 1:58 PM
joerg.sonnenberger committed rHGd92310d45ecb: revlog: update data file record before index rename.
revlog: update data file record before index rename
May 19 2021, 1:58 PM
joerg.sonnenberger committed rHG762afde8c3a0: revlog: fix index computation during inline->non-inline transition.
revlog: fix index computation during inline->non-inline transition
May 19 2021, 1:57 PM
joerg.sonnenberger retitled D10726: recover: only apply last journal record per file (issue6423) from recover: only apply last journal record per file to recover: only apply last journal record per file (issue6423).
May 19 2021, 9:54 AM
joerg.sonnenberger updated the diff for D10726: recover: only apply last journal record per file (issue6423).
May 19 2021, 9:51 AM
joerg.sonnenberger updated the diff for D10725: revlog: update data file record before index rename.
May 19 2021, 7:48 AM

May 18 2021

joerg.sonnenberger updated the summary of D10725: revlog: update data file record before index rename.
May 18 2021, 2:48 PM
joerg.sonnenberger updated the summary of D10724: revlog: fix index computation during inline->non-inline transition.
May 18 2021, 2:48 PM
joerg.sonnenberger updated the diff for D10726: recover: only apply last journal record per file (issue6423).
May 18 2021, 2:48 PM

May 17 2021

joerg.sonnenberger created D10726: recover: only apply last journal record per file (issue6423).
May 17 2021, 10:51 PM
joerg.sonnenberger created D10725: revlog: update data file record before index rename.
May 17 2021, 10:27 PM
joerg.sonnenberger updated the diff for D10724: revlog: fix index computation during inline->non-inline transition.
May 17 2021, 9:09 PM
joerg.sonnenberger created D10724: revlog: fix index computation during inline->non-inline transition.
May 17 2021, 8:42 PM

May 16 2021

joerg.sonnenberger added a comment to D10712: tests: show that hg fails to rollback transaction on revlog split.

There are three stages for the revlog and I think we need to teach the transaction playback code at least a bit about this to handle it correctly:

May 16 2021, 9:55 PM
D10712: tests: show that hg fails to rollback transaction on revlog split now requires changes to proceed.

This whole stack exposes a real problem and one quite a bit older, but it is not correct in a number of ways as is.

May 16 2021, 9:03 PM

May 15 2021

joerg.sonnenberger accepted D10711: hgweb: Fix deprecation warning in Python 3.10 (issue6520).
May 15 2021, 5:41 PM

May 14 2021

joerg.sonnenberger added a comment to D10710: vfs: Fix deprecation warning in Python 3.10 (issue6520).

Silly Python, but this should be fine for all versions we care about. Ironically, it used to be defined the other way around as alias...

May 14 2021, 7:14 AM

May 11 2021

joerg.sonnenberger accepted D10707: templates: fix `revset('parents()') % ...` in amend message template.
May 11 2021, 3:55 PM
D10707: templates: fix `revset('parents()') % ...` in amend message template now requires changes to proceed.
May 11 2021, 3:41 PM

May 4 2021

joerg.sonnenberger added a comment to D10624: revlogv2: introduce a very basic docket file.

Adding more files to the revlog layer sounds like a move in the wrong direction and the motivation here seems quite weak too. Please discuss this with an actual plan on the mailing list.

May 4 2021, 1:06 PM
joerg.sonnenberger added a comment to D10646: revlog: add a "data compression mode" entry in the index tuple.

I don't understand the motivation for this change.

May 4 2021, 1:03 PM
joerg.sonnenberger added a comment to D10650: revlog: introduce a plain compression mode.

I don't understand this change. We already support none as compression method.

May 4 2021, 1:02 PM

May 3 2021

joerg.sonnenberger closed D10535: core: don't hard-code hex node lengths.
May 3 2021, 9:36 AM
joerg.sonnenberger closed D10536: core: don't hard-code node length.
May 3 2021, 9:35 AM
joerg.sonnenberger closed D10533: manifests: push down expected node length into the parser.
May 3 2021, 9:35 AM
joerg.sonnenberger committed rHG12450fbea288: manifests: push down expected node length into the parser.
manifests: push down expected node length into the parser
May 3 2021, 9:34 AM
joerg.sonnenberger committed rHGc5e1cc0b4c77: core: don't hard-code node length.
core: don't hard-code node length
May 3 2021, 9:34 AM
joerg.sonnenberger committed rHGa407fe56d6e8: core: don't hard-code hex node lengths.
core: don't hard-code hex node lengths
May 3 2021, 9:33 AM
joerg.sonnenberger added a comment to D10593: revlog: simplify a conditionnal in _enforceinlinesize.

This adds a penalty for the non-inline case?

May 3 2021, 9:20 AM
joerg.sonnenberger closed D10534: tests: bump default timeout to 360s.
May 3 2021, 8:49 AM
joerg.sonnenberger committed rHGc853bc60c5d6: tests: bump default timeout to 360s.
tests: bump default timeout to 360s
May 3 2021, 8:49 AM

Apr 30 2021

joerg.sonnenberger added a comment to D10538: tests: allow trunk versions of clang-format to be used.

I'm not sure that this is an improvement. We discussed whether we want to hard-wire the version even stricter ("exactly version 11"), especially because it is hard to predict when the output is going to change again.

Apr 30 2021, 8:17 PM

Apr 29 2021

joerg.sonnenberger created D10536: core: don't hard-code node length.
Apr 29 2021, 9:21 PM
joerg.sonnenberger created D10535: core: don't hard-code hex node lengths.
Apr 29 2021, 9:11 PM
joerg.sonnenberger created D10534: tests: bump default timeout to 360s.
Apr 29 2021, 8:26 PM
joerg.sonnenberger created D10533: manifests: push down expected node length into the parser.
Apr 29 2021, 8:14 PM
joerg.sonnenberger added a comment to D10529: node: replace nullid and friends with nodeconstants class.

Already merged as d55b71393907

Apr 29 2021, 9:29 AM

Apr 28 2021

joerg.sonnenberger committed rHG77e73827a02d: tests: don't hard-code /bin/bash.
tests: don't hard-code /bin/bash
Apr 28 2021, 11:09 AM
joerg.sonnenberger committed rHG8d2b62d716b0: packaging: extract pre-computed version when running from plain tarball.
packaging: extract pre-computed version when running from plain tarball
Apr 28 2021, 11:08 AM
joerg.sonnenberger committed rHGd55b71393907: node: replace nullid and friends with nodeconstants class.
node: replace nullid and friends with nodeconstants class
Apr 28 2021, 11:08 AM
joerg.sonnenberger added a comment to D10502: packaging: extract pre-computed version when running from plain tarball.

Merged as 8d2b62d716b0

Apr 28 2021, 11:07 AM
joerg.sonnenberger added a comment to D10507: tests: don't hard-code /bin/bash.

Merged as 77e73827a02d

Apr 28 2021, 11:07 AM
joerg.sonnenberger created D10529: node: replace nullid and friends with nodeconstants class.
Apr 28 2021, 11:07 AM
joerg.sonnenberger updated the diff for D9465: node: replace nullid and friends with nodeconstants class.
Apr 28 2021, 11:06 AM
joerg.sonnenberger created D10507: tests: don't hard-code /bin/bash.
Apr 28 2021, 10:59 AM

Apr 20 2021

joerg.sonnenberger added inline comments to D10502: packaging: extract pre-computed version when running from plain tarball.
Apr 20 2021, 8:09 PM
joerg.sonnenberger updated the summary of D10502: packaging: extract pre-computed version when running from plain tarball.
Apr 20 2021, 5:18 PM
joerg.sonnenberger created D10502: packaging: extract pre-computed version when running from plain tarball.
Apr 20 2021, 2:36 PM
joerg.sonnenberger retitled D9465: node: replace nullid and friends with nodeconstants class from node: replace nullid and friends with nodeconstants class [WIP] to node: replace nullid and friends with nodeconstants class.
Apr 20 2021, 1:49 PM
joerg.sonnenberger closed D9465: node: replace nullid and friends with nodeconstants class.
Apr 20 2021, 12:44 PM
joerg.sonnenberger committed rHG07b9ebea3ce8: node: replace nullid and friends with nodeconstants class [WIP].
node: replace nullid and friends with nodeconstants class [WIP]
Apr 20 2021, 12:44 PM
joerg.sonnenberger updated the diff for D9465: node: replace nullid and friends with nodeconstants class.
Apr 20 2021, 11:35 AM
joerg.sonnenberger added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

Delayed for now as it doesn't work with the broken changelog.files and needs more efficient manifest logic first.

Apr 20 2021, 7:45 AM

Apr 9 2021

joerg.sonnenberger added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

Do you have any performance number for that update ? for example the time we need to do that full some known large repositories, and the impact on a clone ?

Apr 9 2021, 7:40 AM
joerg.sonnenberger added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

What happens in the stream clone case ? Or during the transition from older to newer client ? streaming content from an older clone will not contains a fully up to date cache, and existing repository neither. How are we dealing with this ?
You mention the need to update the cache after stripping, but I don't see such change in the code. am I missing something ?

Apr 9 2021, 6:14 AM

Apr 8 2021

joerg.sonnenberger updated the diff for D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Apr 8 2021, 9:40 PM
joerg.sonnenberger added inline comments to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Apr 8 2021, 7:03 AM

Apr 1 2021

joerg.sonnenberger updated the diff for D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Apr 1 2021, 4:49 PM
joerg.sonnenberger added inline comments to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Apr 1 2021, 4:43 PM

Mar 31 2021

joerg.sonnenberger closed D10291: mergestate: remove unused import.
Mar 31 2021, 1:50 PM
joerg.sonnenberger committed rHG94ea945190f3: mergestate: remove unused import.
mergestate: remove unused import
Mar 31 2021, 1:50 PM

Mar 30 2021

joerg.sonnenberger created D10291: mergestate: remove unused import.
Mar 30 2021, 6:20 PM
joerg.sonnenberger closed D10290: refactor: prefer checks against nullrev over nullid.
Mar 30 2021, 4:23 PM
joerg.sonnenberger closed D10280: refactor: prefer lookup by revision, even for null.
Mar 30 2021, 4:23 PM
joerg.sonnenberger committed rHG728d89f6f9b1: refactor: prefer checks against nullrev over nullid.
refactor: prefer checks against nullrev over nullid
Mar 30 2021, 4:23 PM
joerg.sonnenberger committed rHGad878e3f282b: refactor: prefer lookup by revision, even for null.
refactor: prefer lookup by revision, even for null
Mar 30 2021, 4:23 PM
joerg.sonnenberger committed rHGe7b4607d52e3: setdiscovery: simplify by using tiprev directly.
setdiscovery: simplify by using tiprev directly
Mar 30 2021, 4:23 PM
joerg.sonnenberger closed D10289: setdiscovery: simplify by using tiprev directly.
Mar 30 2021, 4:23 PM

Mar 29 2021

joerg.sonnenberger added a comment to D10278: extdiff: avoid nullid.

Superseded by D10280 and D10290

Mar 29 2021, 9:12 PM
joerg.sonnenberger added a comment to D10279: split: simplify.

Superseded by D10290

Mar 29 2021, 9:12 PM
joerg.sonnenberger added a comment to D10283: copies: simplify.

Superseded by D10290

Mar 29 2021, 9:11 PM
joerg.sonnenberger added a comment to D10285: logcmdutil: simplify.

Superseded by D10290

Mar 29 2021, 9:11 PM
joerg.sonnenberger added a comment to D10286: mergestate: simplify.

Superseded by D10290

Mar 29 2021, 9:11 PM
joerg.sonnenberger added a comment to D10287: shelve: simplify.

Superseded by D10290

Mar 29 2021, 9:11 PM
joerg.sonnenberger added a comment to D10288: simplemerge: simplify.

Superseded by D10290

Mar 29 2021, 9:10 PM
joerg.sonnenberger created D10290: refactor: prefer checks against nullrev over nullid.
Mar 29 2021, 8:42 PM
joerg.sonnenberger updated the diff for D9465: node: replace nullid and friends with nodeconstants class.
Mar 29 2021, 8:42 PM
joerg.sonnenberger retitled D10280: refactor: prefer lookup by revision, even for null from cmdutil: prefer lookup by revision, even for null to refactor: prefer lookup by revision, even for null.
Mar 29 2021, 8:34 PM
joerg.sonnenberger retitled D10280: refactor: prefer lookup by revision, even for null from cmdutil: simplify to cmdutil: prefer lookup by revision, even for null.
Mar 29 2021, 8:25 PM
joerg.sonnenberger created D10289: setdiscovery: simplify by using tiprev directly.
Mar 29 2021, 8:16 PM
joerg.sonnenberger closed D10277: fix: merge imports.
Mar 29 2021, 3:51 PM
joerg.sonnenberger committed rHGeb2a6f66c463: fix: merge imports.
fix: merge imports
Mar 29 2021, 3:50 PM

Mar 28 2021

joerg.sonnenberger retitled D9465: node: replace nullid and friends with nodeconstants class from [POC] node: replace nullid and friends with nodeconstants class to node: replace nullid and friends with nodeconstants class [WIP].
Mar 28 2021, 8:55 PM
joerg.sonnenberger created D10288: simplemerge: simplify.
Mar 28 2021, 8:06 PM