Page MenuHomePhabricator

joerg.sonnenberger (Joerg Sonnenberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 9:25 AM (168 w, 3 d)

Recent Activity

Thu, Feb 25

joerg.sonnenberger created D10075: ci: hook network-io tests into the pipeline.
Thu, Feb 25, 3:32 PM

Wed, Feb 24

joerg.sonnenberger committed rHGad107ed7a4aa: ci: test real dependency installation for pip.
ci: test real dependency installation for pip
Wed, Feb 24, 12:12 PM
joerg.sonnenberger closed D9950: ci: test real dependency installation for pip.
Wed, Feb 24, 11:11 AM
joerg.sonnenberger committed rHG9666392418e8: ci: test real dependency installation for pip.
ci: test real dependency installation for pip
Wed, Feb 24, 11:11 AM

Wed, Feb 17

joerg.sonnenberger added a comment to D9928: tests: drop pip test on the client.

Superseded by D9950

Wed, Feb 17, 9:03 AM

Fri, Feb 12

joerg.sonnenberger committed rHG866eb4d6bd9f: build: fake PEP440 versions.
build: fake PEP440 versions
Fri, Feb 12, 11:29 AM
joerg.sonnenberger closed D9955: build: fake PEP440 versions.
Fri, Feb 12, 9:37 AM
joerg.sonnenberger committed rHG45cabe0d9286: build: fake PEP440 versions.
build: fake PEP440 versions
Fri, Feb 12, 9:37 AM
joerg.sonnenberger updated the summary of D9955: build: fake PEP440 versions.
Fri, Feb 12, 9:22 AM
joerg.sonnenberger retitled D9950: ci: test real dependency installation for pip from ci: test real dependency installation for pip [WIP] to ci: test real dependency installation for pip.
Fri, Feb 12, 9:12 AM
joerg.sonnenberger committed rHGfa7ae7aa0efd: changegroup: don't convert revisions to node for duplicate handling.
changegroup: don't convert revisions to node for duplicate handling
Fri, Feb 12, 12:04 AM
joerg.sonnenberger committed rHG7a93b7b3dc2d: revlog: change addgroup callbacks to take revision numbers.
revlog: change addgroup callbacks to take revision numbers
Fri, Feb 12, 12:04 AM
joerg.sonnenberger committed rHGf7b61ad3c64a: revlog: change addrevision to return the new revision, not node.
revlog: change addrevision to return the new revision, not node
Fri, Feb 12, 12:04 AM
joerg.sonnenberger committed rHG9ee4e988e2be: revlog: change addrawrevision to return the revision.
revlog: change addrawrevision to return the revision
Fri, Feb 12, 12:04 AM
joerg.sonnenberger committed rHG07984507d553: revlog: change _addrevision to return the new revision.
revlog: change _addrevision to return the new revision
Fri, Feb 12, 12:04 AM

Thu, Feb 11

joerg.sonnenberger closed D9883: revlog: change addgroup callbacks to take revision numbers.
Thu, Feb 11, 11:39 AM
joerg.sonnenberger closed D9882: revlog: change addrevision to return the new revision, not node.
Thu, Feb 11, 11:39 AM
joerg.sonnenberger closed D9884: changegroup: don't convert revisions to node for duplicate handling.
Thu, Feb 11, 11:39 AM
joerg.sonnenberger committed rHGf7fd34afd1cc: changegroup: don't convert revisions to node for duplicate handling.
changegroup: don't convert revisions to node for duplicate handling
Thu, Feb 11, 11:38 AM
joerg.sonnenberger committed rHG8ce2d7d993a5: revlog: change addgroup callbacks to take revision numbers.
revlog: change addgroup callbacks to take revision numbers
Thu, Feb 11, 11:38 AM
joerg.sonnenberger closed D9881: revlog: change addrawrevision to return the revision.
Thu, Feb 11, 11:38 AM
joerg.sonnenberger committed rHGb38ac14306ae: revlog: change addrevision to return the new revision, not node.
revlog: change addrevision to return the new revision, not node
Thu, Feb 11, 11:38 AM
joerg.sonnenberger committed rHG0a2112f0109b: revlog: change addrawrevision to return the revision.
revlog: change addrawrevision to return the revision
Thu, Feb 11, 11:38 AM
joerg.sonnenberger closed D9880: revlog: change _addrevision to return the new revision.
Thu, Feb 11, 11:38 AM
joerg.sonnenberger committed rHG9f8f0df391c7: revlog: change _addrevision to return the new revision.
revlog: change _addrevision to return the new revision
Thu, Feb 11, 11:38 AM

Fri, Feb 5

joerg.sonnenberger updated the diff for D9283: bundle: optional multithreaded compression, ATM zstd-only.
Fri, Feb 5, 6:22 AM

Thu, Feb 4

joerg.sonnenberger updated the diff for D9950: ci: test real dependency installation for pip.
Thu, Feb 4, 5:24 PM
joerg.sonnenberger created D9955: build: fake PEP440 versions.
Thu, Feb 4, 5:19 PM
joerg.sonnenberger added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

This still adds all of the function call overhead even when the feature is not used. I also don't like that this check is done repeatedly e.g. during an unbundle. I don't think I would mind checking the size once per revlog on the first write, but not repeatedly.

Thu, Feb 4, 7:23 AM

Tue, Feb 2

joerg.sonnenberger created D9950: ci: test real dependency installation for pip.
Tue, Feb 2, 1:45 PM

Mon, Feb 1

joerg.sonnenberger added a comment to D9881: revlog: change addrawrevision to return the revision.

This should be marked as an API change or a entry should be added in releasenotes.

Mon, Feb 1, 11:26 AM
joerg.sonnenberger updated the diff for D9883: revlog: change addgroup callbacks to take revision numbers.
Mon, Feb 1, 11:17 AM
joerg.sonnenberger updated the diff for D9882: revlog: change addrevision to return the new revision, not node.
Mon, Feb 1, 11:03 AM

Sun, Jan 31

joerg.sonnenberger added a comment to D9928: tests: drop pip test on the client.

The strange thing is that I see the Python 2 failures on the Heptapod CI and the Python 3 failures on OpenSuSE. Both with the system Python and the pkgsrc one in the later case. IMO if we want to do testing for PIP, it should be on the CI only.

Sun, Jan 31, 6:17 PM

Sat, Jan 30

joerg.sonnenberger created D9928: tests: drop pip test on the client.
Sat, Jan 30, 8:05 AM
joerg.sonnenberger added a comment to D9882: revlog: change addrevision to return the new revision, not node.

I didn't measure it, but I don't expect it to make a difference. rev->node is the cheap mapping in all cases, it is the reverse that can be expensive.

Sat, Jan 30, 7:36 AM

Jan 27 2021

joerg.sonnenberger committed rHGf25c770c217b: debugshell: add a simple command for starting an interactive shell.
debugshell: add a simple command for starting an interactive shell
Jan 27 2021, 6:21 PM
joerg.sonnenberger added a comment to D9890: clang-format: show required version in skip message.

I like the change.

Jan 27 2021, 10:22 AM
joerg.sonnenberger added a comment to D9888: black: show required version in skip message.

I like the change.

Jan 27 2021, 10:21 AM
joerg.sonnenberger added a comment to D9889: heptapod-ci: indicate which version of clang-format is used for the run.

LGTM

Jan 27 2021, 10:09 AM
joerg.sonnenberger closed D9866: debugshell: add a simple command for starting an interactive shell.
Jan 27 2021, 12:33 AM
joerg.sonnenberger committed rHGbe0cdcd8b9f9: debugshell: add a simple command for starting an interactive shell.
debugshell: add a simple command for starting an interactive shell
Jan 27 2021, 12:33 AM

Jan 26 2021

joerg.sonnenberger created D9883: revlog: change addgroup callbacks to take revision numbers.
Jan 26 2021, 9:12 PM
joerg.sonnenberger created D9882: revlog: change addrevision to return the new revision, not node.
Jan 26 2021, 9:11 PM
joerg.sonnenberger created D9884: changegroup: don't convert revisions to node for duplicate handling.
Jan 26 2021, 9:11 PM
joerg.sonnenberger created D9881: revlog: change addrawrevision to return the revision.
Jan 26 2021, 9:10 PM
joerg.sonnenberger created D9880: revlog: change _addrevision to return the new revision.
Jan 26 2021, 9:10 PM
joerg.sonnenberger created D9878: revlog: initial version of phash index [POC].
Jan 26 2021, 4:02 PM
joerg.sonnenberger added a comment to D9866: debugshell: add a simple command for starting an interactive shell.

Actually, I believe this really belongs into a/the debug namespace, not admin. It's a much lower level than all other tools and not a user interface in any form.

Jan 26 2021, 11:05 AM
joerg.sonnenberger updated the diff for D9866: debugshell: add a simple command for starting an interactive shell.
Jan 26 2021, 11:04 AM
joerg.sonnenberger updated the diff for D9866: debugshell: add a simple command for starting an interactive shell.
Jan 26 2021, 10:26 AM

Jan 25 2021

joerg.sonnenberger created D9866: debugshell: add a simple command for starting an interactive shell.
Jan 25 2021, 6:20 PM

Jan 24 2021

joerg.sonnenberger added a comment to D9848: fastexport: committer name should not be quoted.

Horrible parsing code, but not relevant for here. I gave the reasons why the original code used "", but I don't care either way if git doesn't fall apart anymore than already does when an address is not pretending to be a mail.

Jan 24 2021, 6:02 PM

Jan 22 2021

joerg.sonnenberger closed D9781: branchmap: update rev-branch-cache incrementally.
Jan 22 2021, 3:40 PM
joerg.sonnenberger closed D9847: revlog: decouple caching from addrevision callback for addgroup.
Jan 22 2021, 3:40 PM
joerg.sonnenberger committed rHG711ba0f1057e: revlog: decouple caching from addrevision callback for addgroup.
revlog: decouple caching from addrevision callback for addgroup
Jan 22 2021, 3:40 PM
joerg.sonnenberger closed D9780: repository: introduce register_changeset callback.
Jan 22 2021, 3:40 PM
joerg.sonnenberger committed rHG3e91d9978bec: branchmap: update rev-branch-cache incrementally.
branchmap: update rev-branch-cache incrementally
Jan 22 2021, 3:39 PM
joerg.sonnenberger committed rHG0903d6b9b1df: repository: introduce register_changeset callback.
repository: introduce register_changeset callback
Jan 22 2021, 3:39 PM
joerg.sonnenberger closed D9779: changelog: move branchinfo to changelogrevision.
Jan 22 2021, 3:39 PM
joerg.sonnenberger committed rHGcad17d50736c: changelog: move branchinfo to changelogrevision.
changelog: move branchinfo to changelogrevision
Jan 22 2021, 3:39 PM
joerg.sonnenberger added a comment to D9848: fastexport: committer name should not be quoted.

The basic concern I have here is that I have stepped on git's toes here before and the field is nowhere near as free text as it is supposed to be according to the specification. So any change should at least double check what the git code is actually doing, because it doesn't do the same as the documentation from what I have seen. Case in point is the data handling, where git does distingiush between +0 and -0.

Jan 22 2021, 3:20 PM
joerg.sonnenberger added a comment to D9848: fastexport: committer name should not be quoted.

The output is entirely valid according to the git format specification. It is also entirely valid under the formatting rules for email addresses, which was supposed to be the origin of this identifiers. As such, I see no reason to change anything.

Jan 22 2021, 9:26 AM

Jan 21 2021

joerg.sonnenberger updated the diff for D9780: repository: introduce register_changeset callback.
Jan 21 2021, 5:29 PM
joerg.sonnenberger created D9847: revlog: decouple caching from addrevision callback for addgroup.
Jan 21 2021, 12:59 PM
joerg.sonnenberger updated the diff for D9781: branchmap: update rev-branch-cache incrementally.
Jan 21 2021, 12:57 PM
joerg.sonnenberger updated the diff for D9780: repository: introduce register_changeset callback.
Jan 21 2021, 12:56 PM
joerg.sonnenberger added a comment to D9780: repository: introduce register_changeset callback.

I like the fact we now take a rev as argument. However two discussion remains:

  • could/should we stop passing the changelogrevision as argument ?
Jan 21 2021, 9:04 AM
joerg.sonnenberger closed D9778: reverse-branch-cache: switch to doubling allocating scheme.
Jan 21 2021, 7:24 AM
joerg.sonnenberger committed rHG1726a53a8494: reverse-branch-cache: switch to doubling allocating scheme.
reverse-branch-cache: switch to doubling allocating scheme
Jan 21 2021, 7:24 AM
joerg.sonnenberger closed D9831: exchangev2: avoid second look-up by node.
Jan 21 2021, 7:24 AM
joerg.sonnenberger committed rHG009130064813: exchangev2: avoid second look-up by node.
exchangev2: avoid second look-up by node
Jan 21 2021, 7:24 AM

Jan 20 2021

joerg.sonnenberger closed D9830: commit: look-up new revision once.
Jan 20 2021, 3:24 PM
joerg.sonnenberger committed rHG72f5280e33b6: commit: look-up new revision once.
commit: look-up new revision once
Jan 20 2021, 3:24 PM
joerg.sonnenberger committed rHGc4787ea85cc7: tests: deal with more timing differences in output.
tests: deal with more timing differences in output
Jan 20 2021, 11:06 AM
joerg.sonnenberger closed D9842: tests: deal with more timing differences in output.
Jan 20 2021, 11:00 AM
joerg.sonnenberger committed rHG3ee914b387d6: tests: deal with more timing differences in output.
tests: deal with more timing differences in output
Jan 20 2021, 11:00 AM
joerg.sonnenberger created D9842: tests: deal with more timing differences in output.
Jan 20 2021, 8:58 AM

Jan 19 2021

joerg.sonnenberger updated the diff for D9780: repository: introduce register_changeset callback.
Jan 19 2021, 9:56 PM

Jan 18 2021

joerg.sonnenberger added a comment to D9780: repository: introduce register_changeset callback.

As discussed, move to using revision for the new function. Most of the prep work is factored out into smaller changesets, except changegroup.py, since that would create a small penalty by itself for no good reason. The goal for follow-up changes is to provide the revision from _addrevision directly (either instead or in addition to the node).

Jan 18 2021, 7:25 PM
joerg.sonnenberger updated the diff for D9780: repository: introduce register_changeset callback.
Jan 18 2021, 6:52 PM
joerg.sonnenberger created D9831: exchangev2: avoid second look-up by node.
Jan 18 2021, 6:51 PM
joerg.sonnenberger created D9830: commit: look-up new revision once.
Jan 18 2021, 6:51 PM
joerg.sonnenberger added a comment to D9780: repository: introduce register_changeset callback.
  • it pass around quite high level object where I think rev would be more appropriate,
Jan 18 2021, 2:56 PM
joerg.sonnenberger closed D9821: sqlitestore: disable test with chg.
Jan 18 2021, 9:38 AM
joerg.sonnenberger committed rHG9c35267f01e0: sqlitestore: disable test with chg.
sqlitestore: disable test with chg
Jan 18 2021, 9:38 AM
joerg.sonnenberger updated the diff for D9821: sqlitestore: disable test with chg.
Jan 18 2021, 8:30 AM
joerg.sonnenberger created D9821: sqlitestore: disable test with chg.
Jan 18 2021, 8:00 AM

Jan 16 2021

joerg.sonnenberger closed D9782: localrepo: fix comment typo.
Jan 16 2021, 3:54 AM
joerg.sonnenberger committed rHGd46646ce3158: localrepo: fix comment typo.
localrepo: fix comment typo
Jan 16 2021, 3:53 AM

Jan 15 2021

joerg.sonnenberger added a comment to D9789: clone: make sure we warm the cache after a clone.

Passes now

Jan 15 2021, 2:31 PM
joerg.sonnenberger added a comment to D9787: hghave: clarify `sqlite` requirements.

LGTM

Jan 15 2021, 10:44 AM
joerg.sonnenberger committed rHGc4b792fa109e: branchmap: avoid ancestor computations in absence of non-continous branches.
branchmap: avoid ancestor computations in absence of non-continous branches
Jan 15 2021, 12:01 AM

Jan 14 2021

joerg.sonnenberger created D9782: localrepo: fix comment typo.
Jan 14 2021, 8:21 PM
joerg.sonnenberger created D9781: branchmap: update rev-branch-cache incrementally.
Jan 14 2021, 8:21 PM
joerg.sonnenberger created D9780: repository: introduce register_changeset callback.
Jan 14 2021, 8:20 PM
joerg.sonnenberger added a comment to D9573: branchmap: update rev-branch-cache incrementally.

Superseded by D9778, D9779, D9780 and D9781.

Jan 14 2021, 8:20 PM
joerg.sonnenberger created D9779: changelog: move branchinfo to changelogrevision.
Jan 14 2021, 8:19 PM
joerg.sonnenberger created D9778: reverse-branch-cache: switch to doubling allocating scheme.
Jan 14 2021, 8:19 PM
joerg.sonnenberger added inline comments to D9573: branchmap: update rev-branch-cache incrementally.
Jan 14 2021, 5:40 PM