Page MenuHomePhabricator

joerg.sonnenberger (Joerg Sonnenberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 9:25 AM (146 w, 1 d)

Recent Activity

Yesterday

joerg.sonnenberger committed rHG497271da24c9: phases: fix performance regression with Python 2.
phases: fix performance regression with Python 2
Thu, Sep 24, 3:35 AM
joerg.sonnenberger closed D9072: phases: fix performance regression with Python 2..
Thu, Sep 24, 3:35 AM

Wed, Sep 23

joerg.sonnenberger created D9072: phases: fix performance regression with Python 2..
Wed, Sep 23, 8:44 AM

Wed, Sep 16

joerg.sonnenberger closed D8801: obsstore: refactor v1 logic to fix 32 byte hash support.
Wed, Sep 16, 4:50 AM
joerg.sonnenberger committed rHG145cfe84d3e4: obsstore: refactor v1 logic to fix 32 byte hash support.
obsstore: refactor v1 logic to fix 32 byte hash support
Wed, Sep 16, 4:50 AM

Wed, Sep 2

joerg.sonnenberger closed D8783: storageutil: allow modern hash sizes for fileids.
Wed, Sep 2, 12:03 PM
joerg.sonnenberger committed rHGc4a4a49589bf: storageutil: allow modern hash sizes for fileids.
storageutil: allow modern hash sizes for fileids
Wed, Sep 2, 12:03 PM

Wed, Aug 26

joerg.sonnenberger added a comment to D8784: tags: adjust file node cache to have space for 32 bytes node ids.

I think it is a one time issue per repository, even when mixing old and new clients they will update incrementally?

Wed, Aug 26, 4:04 PM
joerg.sonnenberger added a comment to D8783: storageutil: allow modern hash sizes for fileids.

The tuples result in bytecode constants, so it's a one time overhead.

Wed, Aug 26, 4:02 PM

Aug 22 2020

joerg.sonnenberger added a comment to D8784: tags: adjust file node cache to have space for 32 bytes node ids.

Ping?

Aug 22 2020, 8:50 PM
joerg.sonnenberger added a comment to D8783: storageutil: allow modern hash sizes for fileids.

Ping?

Aug 22 2020, 8:49 PM
joerg.sonnenberger added a comment to D8801: obsstore: refactor v1 logic to fix 32 byte hash support.

Ping?

Aug 22 2020, 8:48 PM

Aug 8 2020

joerg.sonnenberger closed D8782: tests: make flag parsing test more future safe.
Aug 8 2020, 5:01 PM
joerg.sonnenberger committed rHG15d35f2ba474: tests: make flag parsing test more future safe.
tests: make flag parsing test more future safe
Aug 8 2020, 5:01 PM

Jul 31 2020

joerg.sonnenberger closed D8850: dirstate: restore original estimation and update comment.
Jul 31 2020, 9:14 AM
joerg.sonnenberger committed rHGad7006830106: dirstate: restore original estimation and update comment.
dirstate: restore original estimation and update comment
Jul 31 2020, 9:14 AM

Jul 30 2020

joerg.sonnenberger closed D8849: dirstate: revert change to Rust binding.
Jul 30 2020, 10:53 AM
joerg.sonnenberger committed rHGe0bfde04f957: dirstate: revert change to Rust binding.
dirstate: revert change to Rust binding
Jul 30 2020, 10:53 AM
joerg.sonnenberger created D8850: dirstate: restore original estimation and update comment.
Jul 30 2020, 10:13 AM
joerg.sonnenberger updated the summary of D8849: dirstate: revert change to Rust binding.
Jul 30 2020, 7:30 AM

Jul 29 2020

joerg.sonnenberger added inline comments to D8815: dirstate: isolate node len dependency for the pure version.
Jul 29 2020, 7:14 PM
joerg.sonnenberger created D8849: dirstate: revert change to Rust binding.
Jul 29 2020, 7:10 PM

Jul 26 2020

joerg.sonnenberger added a comment to D8838: clonebundles: document REQUIREDRAM key.

LGTM

Jul 26 2020, 4:13 PM

Jul 25 2020

joerg.sonnenberger closed D8766: manifest: kill one more instance of the old merge hash hack.
Jul 25 2020, 6:04 AM
joerg.sonnenberger committed rHGff59af8395a5: manifest: kill one more instance of the old merge hash hack.
manifest: kill one more instance of the old merge hash hack
Jul 25 2020, 6:03 AM
joerg.sonnenberger closed D8815: dirstate: isolate node len dependency for the pure version.
Jul 25 2020, 6:03 AM
joerg.sonnenberger committed rHG4f0e03d980f3: dirstate: isolate node len dependency for the pure version.
dirstate: isolate node len dependency for the pure version
Jul 25 2020, 6:03 AM

Jul 24 2020

joerg.sonnenberger created D8815: dirstate: isolate node len dependency for the pure version.
Jul 24 2020, 10:29 PM

Jul 23 2020

joerg.sonnenberger created D8801: obsstore: refactor v1 logic to fix 32 byte hash support.
Jul 23 2020, 2:35 PM

Jul 21 2020

joerg.sonnenberger created D8784: tags: adjust file node cache to have space for 32 bytes node ids.
Jul 21 2020, 6:27 PM
joerg.sonnenberger created D8783: storageutil: allow modern hash sizes for fileids.
Jul 21 2020, 4:42 PM
joerg.sonnenberger created D8782: tests: make flag parsing test more future safe.
Jul 21 2020, 4:14 PM

Jul 20 2020

joerg.sonnenberger added a comment to D6259: [POC] revset: on-disk cache for children queries.

Yes, it's still a POC. I wanted to make sure that it works in the modern world, but I am still considering the idea in the context of larger changes for transactional caches.

Jul 20 2020, 9:46 AM
joerg.sonnenberger committed rHG3496b5f24371: relnotes: extend.
relnotes: extend
Jul 20 2020, 9:34 AM
joerg.sonnenberger closed D8767: relnotes: extend.
Jul 20 2020, 9:34 AM

Jul 18 2020

joerg.sonnenberger updated the diff for D8767: relnotes: extend.
Jul 18 2020, 6:31 PM
joerg.sonnenberger created D8767: relnotes: extend.
Jul 18 2020, 5:20 PM
joerg.sonnenberger created D8766: manifest: kill one more instance of the old merge hash hack.
Jul 18 2020, 5:13 PM

Jul 16 2020

joerg.sonnenberger closed D8760: cext: remove unused variables.
Jul 16 2020, 1:59 PM
joerg.sonnenberger committed rHG9719e118e4af: cext: remove unused variables.
cext: remove unused variables
Jul 16 2020, 1:59 PM
joerg.sonnenberger created D8760: cext: remove unused variables.
Jul 16 2020, 1:49 PM
joerg.sonnenberger closed D8759: status: match category text in the option description.
Jul 16 2020, 12:53 PM
joerg.sonnenberger closed D8698: phases: sparsify phaseroots and phasesets.
Jul 16 2020, 12:52 PM
joerg.sonnenberger committed rHG487df3676d2c: status: match category text in the option description.
status: match category text in the option description
Jul 16 2020, 12:51 PM
joerg.sonnenberger committed rHG61e7464477ac: phases: sparsify phaseroots and phasesets.
phases: sparsify phaseroots and phasesets
Jul 16 2020, 12:51 PM
joerg.sonnenberger created D8759: status: match category text in the option description.
Jul 16 2020, 9:57 AM

Jul 15 2020

joerg.sonnenberger updated the diff for D8698: phases: sparsify phaseroots and phasesets.
Jul 15 2020, 3:57 PM
joerg.sonnenberger closed D8697: phases: sparsify phase lists.
Jul 15 2020, 12:16 PM
joerg.sonnenberger closed D8679: manifest: tigher manifest parsing and flag use.
Jul 15 2020, 12:16 PM
joerg.sonnenberger committed rHG19748c73c208: manifest: use the same logic for handling flags in _parse as elsewhere.
manifest: use the same logic for handling flags in _parse as elsewhere
Jul 15 2020, 12:15 PM
joerg.sonnenberger closed D8684: manifest: use the same logic for handling flags in _parse as elsewhere.
Jul 15 2020, 12:15 PM
joerg.sonnenberger committed rHGd0ef8c1dddd4: manifest: tigher manifest parsing and flag use.
manifest: tigher manifest parsing and flag use
Jul 15 2020, 12:14 PM
joerg.sonnenberger committed rHGb1e51ef4e536: phases: sparsify phase lists.
phases: sparsify phase lists
Jul 15 2020, 12:14 PM
joerg.sonnenberger closed D8696: phases: updatephases should not skip internal phase.
Jul 15 2020, 12:14 PM
joerg.sonnenberger committed rHG361a7444bc41: phases: updatephases should not skip internal phase.
phases: updatephases should not skip internal phase
Jul 15 2020, 12:14 PM
joerg.sonnenberger committed rHG672ad1f6eeb8: repoview: use the phasecache directly to determine mutable revisions.
repoview: use the phasecache directly to determine mutable revisions
Jul 15 2020, 12:14 PM
joerg.sonnenberger closed D8670: repoview: use the phasecache directly to determine mutable revisions.
Jul 15 2020, 12:14 PM
joerg.sonnenberger closed D8694: phases: provide a test and accessor for non-public phase roots.
Jul 15 2020, 12:14 PM
joerg.sonnenberger committed rHGe2d17974a869: phases: provide a test and accessor for non-public phase roots.
phases: provide a test and accessor for non-public phase roots
Jul 15 2020, 12:14 PM

Jul 13 2020

joerg.sonnenberger added inline comments to D8697: phases: sparsify phase lists.
Jul 13 2020, 11:02 AM

Jul 12 2020

joerg.sonnenberger retitled D6259: [POC] revset: on-disk cache for children queries from revset: on-disk cache for children queries to [POC] revset: on-disk cache for children queries.
Jul 12 2020, 10:07 PM
joerg.sonnenberger retitled D6259: [POC] revset: on-disk cache for children queries from [POC] revset: on-disk cache for children queries to revset: on-disk cache for children queries.
Jul 12 2020, 9:54 PM
joerg.sonnenberger added a comment to D8670: repoview: use the phasecache directly to determine mutable revisions.

Rebased on top of the changeset that introduced hasnonpublicphases

Jul 12 2020, 4:51 PM
joerg.sonnenberger updated the diff for D8694: phases: provide a test and accessor for non-public phase roots.
Jul 12 2020, 4:41 PM

Jul 11 2020

joerg.sonnenberger closed D8575: hooklib: fix detection of successors for changeset_obsoleted.
Jul 11 2020, 4:48 AM
joerg.sonnenberger committed rHG04ef381000a8: hooklib: fix detection of successors for changeset_obsoleted.
hooklib: fix detection of successors for changeset_obsoleted
Jul 11 2020, 4:48 AM
joerg.sonnenberger committed rHG6232d732658c: phases: replace magic number by constant.
phases: replace magic number by constant
Jul 11 2020, 4:47 AM
joerg.sonnenberger committed rHG72feaeb510b3: clonebundles: optional memory-requirement attribution.
clonebundles: optional memory-requirement attribution
Jul 11 2020, 4:47 AM
joerg.sonnenberger committed rHG02b17231f6c3: util: provide a helper function to estimate RAM size.
util: provide a helper function to estimate RAM size
Jul 11 2020, 4:47 AM
joerg.sonnenberger committed rHGbaffdfa5bd1a: tests: allow timing difference in output.
tests: allow timing difference in output
Jul 11 2020, 4:47 AM

Jul 10 2020

joerg.sonnenberger updated the diff for D8575: hooklib: fix detection of successors for changeset_obsoleted.
Jul 10 2020, 7:51 AM
joerg.sonnenberger closed D8644: util: provide a helper function to estimate RAM size.
Jul 10 2020, 6:47 AM
joerg.sonnenberger closed D8645: clonebundles: optional memory-requirement attribution.
Jul 10 2020, 6:46 AM
joerg.sonnenberger committed rHG31f111d4bf61: phases: replace magic number by constant.
phases: replace magic number by constant
Jul 10 2020, 6:46 AM
joerg.sonnenberger closed D8695: phases: replace magic number by constant.
Jul 10 2020, 6:46 AM
joerg.sonnenberger committed rHG9c7ff8877592: clonebundles: optional memory-requirement attribution.
clonebundles: optional memory-requirement attribution
Jul 10 2020, 6:45 AM
joerg.sonnenberger committed rHGcfe0f4915793: util: provide a helper function to estimate RAM size.
util: provide a helper function to estimate RAM size
Jul 10 2020, 6:45 AM
joerg.sonnenberger closed D8676: tests: allow timing difference in output.
Jul 10 2020, 6:45 AM
joerg.sonnenberger committed rHG3990a56491fd: tests: allow timing difference in output.
tests: allow timing difference in output
Jul 10 2020, 6:45 AM

Jul 7 2020

joerg.sonnenberger created D8697: phases: sparsify phase lists.
Jul 7 2020, 6:39 PM
joerg.sonnenberger created D8698: phases: sparsify phaseroots and phasesets.
Jul 7 2020, 6:39 PM
joerg.sonnenberger added a comment to D8654: phases: make phase list dense or dictionaries.

Superseded by D8694, D8695, D8697 and D8698.

Jul 7 2020, 6:39 PM
joerg.sonnenberger created D8696: phases: updatephases should not skip internal phase.
Jul 7 2020, 6:38 PM
joerg.sonnenberger created D8695: phases: replace magic number by constant.
Jul 7 2020, 6:38 PM
joerg.sonnenberger created D8694: phases: provide a test and accessor for non-public phase roots.
Jul 7 2020, 6:38 PM
joerg.sonnenberger closed D8683: revlog: avoid hard-coded hash sizes.
Jul 7 2020, 4:45 PM
joerg.sonnenberger committed rHGcc2572923ea3: revlog: avoid hard-coded hash sizes.
revlog: avoid hard-coded hash sizes
Jul 7 2020, 4:45 PM
joerg.sonnenberger added a comment to D8676: tests: allow timing difference in output.

I don't have a good explanation for why we see it, just that it is a coin flip under load for me. Otherwise I would have gone into more details.

Jul 7 2020, 3:35 PM
joerg.sonnenberger added inline comments to D8575: hooklib: fix detection of successors for changeset_obsoleted.
Jul 7 2020, 3:21 PM
joerg.sonnenberger updated the diff for D8644: util: provide a helper function to estimate RAM size.
Jul 7 2020, 3:07 PM
joerg.sonnenberger added a comment to D8654: phases: make phase list dense or dictionaries.

I can split the patch in some smaller parts. Is the API change itself as goal reasonable?

Jul 7 2020, 2:48 PM
joerg.sonnenberger added inline comments to D8645: clonebundles: optional memory-requirement attribution.
Jul 7 2020, 2:35 PM
joerg.sonnenberger created D8693: sidedata: test changes for incoming and local changes [POC].
Jul 7 2020, 9:55 AM

Jul 6 2020

joerg.sonnenberger created D8684: manifest: use the same logic for handling flags in _parse as elsewhere.
Jul 6 2020, 8:50 AM
joerg.sonnenberger created D8683: revlog: avoid hard-coded hash sizes.
Jul 6 2020, 8:44 AM
joerg.sonnenberger updated the summary of D8679: manifest: tigher manifest parsing and flag use.
Jul 6 2020, 7:38 AM
joerg.sonnenberger committed rHGb4b6ff83ed9c: ui: fix Python 2.7 support for ui.timestamp-output.
ui: fix Python 2.7 support for ui.timestamp-output
Jul 6 2020, 7:37 AM

Jul 5 2020

joerg.sonnenberger added a comment to D8679: manifest: tigher manifest parsing and flag use.

I'm still working on this changeset to assert the "extra bytes in node" nonsense documented in some places, if someone has a case to actually trigger that it would be very helpful.

Jul 5 2020, 10:05 PM
joerg.sonnenberger created D8679: manifest: tigher manifest parsing and flag use.
Jul 5 2020, 9:46 PM

Jul 3 2020

joerg.sonnenberger closed D8675: ui: fix Python 2.7 support for ui.timestamp-output.
Jul 3 2020, 4:46 AM