Page MenuHomePhabricator

joerg.sonnenberger (Joerg Sonnenberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 9:25 AM (135 w, 3 d)

Recent Activity

Today

joerg.sonnenberger closed D8575: hooklib: fix detection of successors for changeset_obsoleted.
Sat, Jul 11, 4:48 AM
joerg.sonnenberger committed rHG04ef381000a8: hooklib: fix detection of successors for changeset_obsoleted.
hooklib: fix detection of successors for changeset_obsoleted
Sat, Jul 11, 4:48 AM
joerg.sonnenberger committed rHG6232d732658c: phases: replace magic number by constant.
phases: replace magic number by constant
Sat, Jul 11, 4:47 AM
joerg.sonnenberger committed rHG72feaeb510b3: clonebundles: optional memory-requirement attribution.
clonebundles: optional memory-requirement attribution
Sat, Jul 11, 4:47 AM
joerg.sonnenberger committed rHG02b17231f6c3: util: provide a helper function to estimate RAM size.
util: provide a helper function to estimate RAM size
Sat, Jul 11, 4:47 AM
joerg.sonnenberger committed rHGbaffdfa5bd1a: tests: allow timing difference in output.
tests: allow timing difference in output
Sat, Jul 11, 4:47 AM

Yesterday

joerg.sonnenberger updated the diff for D8575: hooklib: fix detection of successors for changeset_obsoleted.
Fri, Jul 10, 7:51 AM
joerg.sonnenberger closed D8644: util: provide a helper function to estimate RAM size.
Fri, Jul 10, 6:47 AM
joerg.sonnenberger closed D8645: clonebundles: optional memory-requirement attribution.
Fri, Jul 10, 6:46 AM
joerg.sonnenberger committed rHG31f111d4bf61: phases: replace magic number by constant.
phases: replace magic number by constant
Fri, Jul 10, 6:46 AM
joerg.sonnenberger closed D8695: phases: replace magic number by constant.
Fri, Jul 10, 6:46 AM
joerg.sonnenberger committed rHG9c7ff8877592: clonebundles: optional memory-requirement attribution.
clonebundles: optional memory-requirement attribution
Fri, Jul 10, 6:45 AM
joerg.sonnenberger committed rHGcfe0f4915793: util: provide a helper function to estimate RAM size.
util: provide a helper function to estimate RAM size
Fri, Jul 10, 6:45 AM
joerg.sonnenberger closed D8676: tests: allow timing difference in output.
Fri, Jul 10, 6:45 AM
joerg.sonnenberger committed rHG3990a56491fd: tests: allow timing difference in output.
tests: allow timing difference in output
Fri, Jul 10, 6:45 AM

Tue, Jul 7

joerg.sonnenberger created D8697: phases: sparsify phase lists.
Tue, Jul 7, 6:39 PM
joerg.sonnenberger created D8698: phases: sparsify phaseroots and phasesets.
Tue, Jul 7, 6:39 PM
joerg.sonnenberger added a comment to D8654: phases: make phase list dense or dictionaries.

Superseded by D8694, D8695, D8697 and D8698.

Tue, Jul 7, 6:39 PM
joerg.sonnenberger created D8696: phases: updatephases should not skip internal phase.
Tue, Jul 7, 6:38 PM
joerg.sonnenberger created D8695: phases: replace magic number by constant.
Tue, Jul 7, 6:38 PM
joerg.sonnenberger created D8694: phases: provide a test and accessor for non-public phase roots.
Tue, Jul 7, 6:38 PM
joerg.sonnenberger closed D8683: revlog: avoid hard-coded hash sizes.
Tue, Jul 7, 4:45 PM
joerg.sonnenberger committed rHGcc2572923ea3: revlog: avoid hard-coded hash sizes.
revlog: avoid hard-coded hash sizes
Tue, Jul 7, 4:45 PM
joerg.sonnenberger added a comment to D8676: tests: allow timing difference in output.

I don't have a good explanation for why we see it, just that it is a coin flip under load for me. Otherwise I would have gone into more details.

Tue, Jul 7, 3:35 PM
joerg.sonnenberger added inline comments to D8575: hooklib: fix detection of successors for changeset_obsoleted.
Tue, Jul 7, 3:21 PM
joerg.sonnenberger updated the diff for D8644: util: provide a helper function to estimate RAM size.
Tue, Jul 7, 3:07 PM
joerg.sonnenberger added a comment to D8654: phases: make phase list dense or dictionaries.

I can split the patch in some smaller parts. Is the API change itself as goal reasonable?

Tue, Jul 7, 2:48 PM
joerg.sonnenberger added inline comments to D8645: clonebundles: optional memory-requirement attribution.
Tue, Jul 7, 2:35 PM
joerg.sonnenberger created D8693: sidedata: test changes for incoming and local changes [POC].
Tue, Jul 7, 9:55 AM

Mon, Jul 6

joerg.sonnenberger created D8684: manifest: use the same logic for handling flags in _parse as elsewhere.
Mon, Jul 6, 8:50 AM
joerg.sonnenberger created D8683: revlog: avoid hard-coded hash sizes.
Mon, Jul 6, 8:44 AM
joerg.sonnenberger updated the summary of D8679: manifest: tigher manifest parsing and flag use.
Mon, Jul 6, 7:38 AM
joerg.sonnenberger committed rHGb4b6ff83ed9c: ui: fix Python 2.7 support for ui.timestamp-output.
ui: fix Python 2.7 support for ui.timestamp-output
Mon, Jul 6, 7:37 AM

Sun, Jul 5

joerg.sonnenberger added a comment to D8679: manifest: tigher manifest parsing and flag use.

I'm still working on this changeset to assert the "extra bytes in node" nonsense documented in some places, if someone has a case to actually trigger that it would be very helpful.

Sun, Jul 5, 10:05 PM
joerg.sonnenberger created D8679: manifest: tigher manifest parsing and flag use.
Sun, Jul 5, 9:46 PM

Fri, Jul 3

joerg.sonnenberger closed D8675: ui: fix Python 2.7 support for ui.timestamp-output.
Fri, Jul 3, 4:46 AM
joerg.sonnenberger committed rHG36ea1442b7bc: ui: fix Python 2.7 support for ui.timestamp-output.
ui: fix Python 2.7 support for ui.timestamp-output
Fri, Jul 3, 4:46 AM

Thu, Jul 2

joerg.sonnenberger added a comment to D8654: phases: make phase list dense or dictionaries.

Addressed most of the issues raised, some of them were considered and rejected (re items()).

Thu, Jul 2, 2:19 PM
joerg.sonnenberger updated the diff for D8675: ui: fix Python 2.7 support for ui.timestamp-output.
Thu, Jul 2, 2:13 PM
joerg.sonnenberger updated the diff for D8675: ui: fix Python 2.7 support for ui.timestamp-output.
Thu, Jul 2, 2:03 PM
joerg.sonnenberger created D8676: tests: allow timing difference in output.
Thu, Jul 2, 2:00 PM
joerg.sonnenberger created D8675: ui: fix Python 2.7 support for ui.timestamp-output.
Thu, Jul 2, 1:55 PM
joerg.sonnenberger added a comment to D8670: repoview: use the phasecache directly to determine mutable revisions.

phabsend didn't properly create a stack here, which is why it doesn't apply by itself.

Thu, Jul 2, 1:51 PM

Wed, Jul 1

joerg.sonnenberger closed D8672: tests: ignore possible diagnostics from gpg 2.2.
Wed, Jul 1, 6:35 PM
joerg.sonnenberger committed rHGf58928715d0c: tests: ignore possible diagnostics from gpg 2.2.
tests: ignore possible diagnostics from gpg 2.2
Wed, Jul 1, 6:35 PM
joerg.sonnenberger closed D8640: ui: add option to timestamp status and diagnostic messages.
Wed, Jul 1, 6:03 AM
joerg.sonnenberger committed rHG24b1a8eb73aa: ui: add option to timestamp status and diagnostic messages.
ui: add option to timestamp status and diagnostic messages
Wed, Jul 1, 6:02 AM

Tue, Jun 30

joerg.sonnenberger added a comment to D8658: commands: use any() instead of `if a or b or c`.

Please use a tulpe for editopts so that it is a constant by itself.

Tue, Jun 30, 8:26 PM
joerg.sonnenberger created D8672: tests: ignore possible diagnostics from gpg 2.2.
Tue, Jun 30, 7:10 PM
joerg.sonnenberger updated the diff for D8645: clonebundles: optional memory-requirement attribution.
Tue, Jun 30, 5:27 PM
joerg.sonnenberger updated the diff for D8644: util: provide a helper function to estimate RAM size.
Tue, Jun 30, 5:26 PM

Mon, Jun 29

joerg.sonnenberger updated the diff for D8640: ui: add option to timestamp status and diagnostic messages.
Mon, Jun 29, 7:57 AM

Sat, Jun 27

joerg.sonnenberger added a comment to D8654: phases: make phase list dense or dictionaries.

Further analysis shows that the main issue here is that the topic exchange triggers a rebuild of the "served-topic" branchmap without a real reason. That doesn't mean the change isn't useful in general.

Sat, Jun 27, 7:34 PM
joerg.sonnenberger added a comment to D8670: repoview: use the phasecache directly to determine mutable revisions.

Further analysis shows that the main issue here is that the topic exchange triggers a rebuild of the "served-topic" branchmap without a real reason. That doesn't mean the change isn't useful in general.

Sat, Jun 27, 7:34 PM
joerg.sonnenberger created D8670: repoview: use the phasecache directly to determine mutable revisions.
Sat, Jun 27, 7:08 PM
joerg.sonnenberger retitled D8654: phases: make phase list dense or dictionaries from phases: make phase list dense or dictionaries [PoC] to phases: make phase list dense or dictionaries.
Sat, Jun 27, 6:03 PM

Thu, Jun 25

joerg.sonnenberger added a comment to D8645: clonebundles: optional memory-requirement attribution.

No strong reason, it just was easier to start as base line.

Thu, Jun 25, 2:56 PM
joerg.sonnenberger added inline comments to D8640: ui: add option to timestamp status and diagnostic messages.
Thu, Jun 25, 2:54 PM
joerg.sonnenberger closed D8651: share: provide a more useful text for hg help.
Thu, Jun 25, 11:43 AM
joerg.sonnenberger committed rHG2fd8a8c11273: share: provide a more useful text for hg help.
share: provide a more useful text for hg help
Thu, Jun 25, 11:43 AM

Wed, Jun 24

joerg.sonnenberger updated the diff for D8654: phases: make phase list dense or dictionaries.
Wed, Jun 24, 3:05 PM
joerg.sonnenberger added inline comments to D8654: phases: make phase list dense or dictionaries.
Wed, Jun 24, 6:38 AM

Tue, Jun 23

joerg.sonnenberger created D8654: phases: make phase list dense or dictionaries.
Tue, Jun 23, 8:27 PM
joerg.sonnenberger created D8651: share: provide a more useful text for hg help.
Tue, Jun 23, 10:07 AM

Mon, Jun 22

joerg.sonnenberger updated the diff for D8640: ui: add option to timestamp status and diagnostic messages.
Mon, Jun 22, 7:16 PM
joerg.sonnenberger updated the diff for D8645: clonebundles: optional memory-requirement attribution.
Mon, Jun 22, 7:02 PM
joerg.sonnenberger committed rHGfa151f7af275: phases: improve performance of _retractboundary.
phases: improve performance of _retractboundary
Mon, Jun 22, 6:21 AM

Sun, Jun 21

joerg.sonnenberger added a comment to D8644: util: provide a helper function to estimate RAM size.

This currently triggers a warning about using ui in util, so consider this a RFC for dealing with that.

Sun, Jun 21, 6:41 PM
joerg.sonnenberger created D8645: clonebundles: optional memory-requirement attribution.
Sun, Jun 21, 6:41 PM
joerg.sonnenberger created D8644: util: provide a helper function to estimate RAM size.
Sun, Jun 21, 6:40 PM

Fri, Jun 19

joerg.sonnenberger committed rHGa54ee130210a: phases: improve performance of _retractboundary.
phases: improve performance of _retractboundary
Fri, Jun 19, 10:31 PM
joerg.sonnenberger closed D8641: phases: improve performance of _retractboundary.
Fri, Jun 19, 7:55 AM
joerg.sonnenberger committed rHGae6890f108f2: phases: improve performance of _retractboundary.
phases: improve performance of _retractboundary
Fri, Jun 19, 7:55 AM

Thu, Jun 18

joerg.sonnenberger updated the diff for D8640: ui: add option to timestamp status and diagnostic messages.
Thu, Jun 18, 5:45 PM
joerg.sonnenberger created D8641: phases: improve performance of _retractboundary.
Thu, Jun 18, 4:23 PM
joerg.sonnenberger created D8640: ui: add option to timestamp status and diagnostic messages.
Thu, Jun 18, 9:14 AM

May 26 2020

joerg.sonnenberger added a comment to D8585: scmutil: speed up relativization of paths when it's a no-op.

Yes, that version is better.

May 26 2020, 3:35 PM
joerg.sonnenberger added a comment to D8585: scmutil: speed up relativization of paths when it's a no-op.

At the very least, there is missing a word like "also" or "still", but it doesn't really tell the *why*. That's what would make a comment here useful, IMO. I.e. the important point is that a repo path is a relative path from the repo root, so if the cwd is empty, no additional work is necessary.

May 26 2020, 10:10 AM
joerg.sonnenberger added inline comments to D8586: files: speed up `hg files` when no flags change display.
May 26 2020, 8:57 AM
joerg.sonnenberger added a comment to D8585: scmutil: speed up relativization of paths when it's a no-op.

I find the comment confusing. Maybe something like Relative paths below the top-level of the repository need more processing.?

May 26 2020, 7:39 AM

May 21 2020

joerg.sonnenberger created D8575: hooklib: fix detection of successors for changeset_obsoleted.
May 21 2020, 1:07 PM
joerg.sonnenberger created D8574: hooks: teach reject_new_heads about phase transitions.
May 21 2020, 11:53 AM

May 15 2020

joerg.sonnenberger added a comment to D8480: bundle: make obsolescence parts optional.

While I don't really agree with the design interpretation of why the server should send mandatory, I don't care enough in this case. With the update, bundle and pull/push are getting different flags.

May 15 2020, 9:35 AM
joerg.sonnenberger retitled D8480: bundle: make obsolescence parts optional from bundle2: make obsolescence parts optional to bundle: make obsolescence parts optional.
May 15 2020, 9:34 AM

May 14 2020

joerg.sonnenberger closed D8490: hooks: provide access to transaction changes for internal hooks.
May 14 2020, 4:31 PM
joerg.sonnenberger committed rHG09da5cf44772: hooks: provide access to transaction changes for internal hooks.
hooks: provide access to transaction changes for internal hooks
May 14 2020, 4:30 PM

May 13 2020

joerg.sonnenberger closed D8522: fastexport: adjust output to be more canonical.
May 13 2020, 12:09 AM
joerg.sonnenberger committed rHGedffab2cf0ea: fastexport: adjust output to be more canonical.
fastexport: adjust output to be more canonical
May 13 2020, 12:09 AM

May 12 2020

joerg.sonnenberger created D8522: fastexport: adjust output to be more canonical.
May 12 2020, 4:30 PM
joerg.sonnenberger committed rHG9d7d53771e5f: tests: fix timer scaling in wait-on-file.
tests: fix timer scaling in wait-on-file
May 12 2020, 4:05 PM
joerg.sonnenberger committed rHG5d309906ed0e: fastexport: downgrade message about already exported changesets to debug.
fastexport: downgrade message about already exported changesets to debug
May 12 2020, 4:05 PM

May 11 2020

joerg.sonnenberger closed D8505: tests: fix timer scaling in wait-on-file.
May 11 2020, 7:37 PM
joerg.sonnenberger committed rHGef65676bf2d4: tests: fix timer scaling in wait-on-file.
tests: fix timer scaling in wait-on-file
May 11 2020, 7:37 PM

May 7 2020

joerg.sonnenberger created D8505: tests: fix timer scaling in wait-on-file.
May 7 2020, 5:40 PM
joerg.sonnenberger added a comment to D8501: tests: increase internal timeouts.

Will fix the real problem.

May 7 2020, 5:20 PM
joerg.sonnenberger committed rHG60b79f927f0c: fastexport: downgrade message about already exported changesets to debug.
fastexport: downgrade message about already exported changesets to debug
May 7 2020, 11:43 AM
joerg.sonnenberger committed rHG711df97dbc0f: fastexport: adjust output to be more canonical.
fastexport: adjust output to be more canonical
May 7 2020, 11:43 AM
joerg.sonnenberger committed rHG3d5fb6cab832: pullbundles: use unfiltered repo for head/base matching.
pullbundles: use unfiltered repo for head/base matching
May 7 2020, 11:43 AM
joerg.sonnenberger closed D8486: fastexport: adjust output to be more canonical.
May 7 2020, 11:02 AM
joerg.sonnenberger committed rHGb1804c62b2c0: fastexport: downgrade message about already exported changesets to debug.
fastexport: downgrade message about already exported changesets to debug
May 7 2020, 11:02 AM