Page MenuHomePhabricator

joerg.sonnenberger (Joerg Sonnenberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2017, 9:25 AM (178 w, 3 d)

Recent Activity

Tue, May 4

joerg.sonnenberger added a comment to D10624: revlogv2: introduce a very basic docket file.

Adding more files to the revlog layer sounds like a move in the wrong direction and the motivation here seems quite weak too. Please discuss this with an actual plan on the mailing list.

Tue, May 4, 1:06 PM
joerg.sonnenberger added a comment to D10646: revlog: add a "data compression mode" entry in the index tuple.

I don't understand the motivation for this change.

Tue, May 4, 1:03 PM
joerg.sonnenberger added a comment to D10650: revlog: introduce a plain compression mode.

I don't understand this change. We already support none as compression method.

Tue, May 4, 1:02 PM

Mon, May 3

joerg.sonnenberger closed D10535: core: don't hard-code hex node lengths.
Mon, May 3, 9:36 AM
joerg.sonnenberger closed D10536: core: don't hard-code node length.
Mon, May 3, 9:35 AM
joerg.sonnenberger closed D10533: manifests: push down expected node length into the parser.
Mon, May 3, 9:35 AM
joerg.sonnenberger committed rHG12450fbea288: manifests: push down expected node length into the parser.
manifests: push down expected node length into the parser
Mon, May 3, 9:34 AM
joerg.sonnenberger committed rHGc5e1cc0b4c77: core: don't hard-code node length.
core: don't hard-code node length
Mon, May 3, 9:34 AM
joerg.sonnenberger committed rHGa407fe56d6e8: core: don't hard-code hex node lengths.
core: don't hard-code hex node lengths
Mon, May 3, 9:33 AM
joerg.sonnenberger added a comment to D10593: revlog: simplify a conditionnal in _enforceinlinesize.

This adds a penalty for the non-inline case?

Mon, May 3, 9:20 AM
joerg.sonnenberger closed D10534: tests: bump default timeout to 360s.
Mon, May 3, 8:49 AM
joerg.sonnenberger committed rHGc853bc60c5d6: tests: bump default timeout to 360s.
tests: bump default timeout to 360s
Mon, May 3, 8:49 AM

Fri, Apr 30

joerg.sonnenberger added a comment to D10538: tests: allow trunk versions of clang-format to be used.

I'm not sure that this is an improvement. We discussed whether we want to hard-wire the version even stricter ("exactly version 11"), especially because it is hard to predict when the output is going to change again.

Fri, Apr 30, 8:17 PM

Thu, Apr 29

joerg.sonnenberger created D10536: core: don't hard-code node length.
Thu, Apr 29, 9:21 PM
joerg.sonnenberger created D10535: core: don't hard-code hex node lengths.
Thu, Apr 29, 9:11 PM
joerg.sonnenberger created D10534: tests: bump default timeout to 360s.
Thu, Apr 29, 8:26 PM
joerg.sonnenberger created D10533: manifests: push down expected node length into the parser.
Thu, Apr 29, 8:14 PM
joerg.sonnenberger added a comment to D10529: node: replace nullid and friends with nodeconstants class.

Already merged as d55b71393907

Thu, Apr 29, 9:29 AM

Wed, Apr 28

joerg.sonnenberger committed rHG77e73827a02d: tests: don't hard-code /bin/bash.
tests: don't hard-code /bin/bash
Wed, Apr 28, 11:09 AM
joerg.sonnenberger committed rHG8d2b62d716b0: packaging: extract pre-computed version when running from plain tarball.
packaging: extract pre-computed version when running from plain tarball
Wed, Apr 28, 11:08 AM
joerg.sonnenberger committed rHGd55b71393907: node: replace nullid and friends with nodeconstants class.
node: replace nullid and friends with nodeconstants class
Wed, Apr 28, 11:08 AM
joerg.sonnenberger added a comment to D10502: packaging: extract pre-computed version when running from plain tarball.

Merged as 8d2b62d716b0

Wed, Apr 28, 11:07 AM
joerg.sonnenberger added a comment to D10507: tests: don't hard-code /bin/bash.

Merged as 77e73827a02d

Wed, Apr 28, 11:07 AM
joerg.sonnenberger created D10529: node: replace nullid and friends with nodeconstants class.
Wed, Apr 28, 11:07 AM
joerg.sonnenberger updated the diff for D9465: node: replace nullid and friends with nodeconstants class.
Wed, Apr 28, 11:06 AM
joerg.sonnenberger created D10507: tests: don't hard-code /bin/bash.
Wed, Apr 28, 10:59 AM

Tue, Apr 20

joerg.sonnenberger added inline comments to D10502: packaging: extract pre-computed version when running from plain tarball.
Tue, Apr 20, 8:09 PM
joerg.sonnenberger updated the summary of D10502: packaging: extract pre-computed version when running from plain tarball.
Tue, Apr 20, 5:18 PM
joerg.sonnenberger created D10502: packaging: extract pre-computed version when running from plain tarball.
Tue, Apr 20, 2:36 PM
joerg.sonnenberger retitled D9465: node: replace nullid and friends with nodeconstants class from node: replace nullid and friends with nodeconstants class [WIP] to node: replace nullid and friends with nodeconstants class.
Tue, Apr 20, 1:49 PM
joerg.sonnenberger closed D9465: node: replace nullid and friends with nodeconstants class.
Tue, Apr 20, 12:44 PM
joerg.sonnenberger committed rHG07b9ebea3ce8: node: replace nullid and friends with nodeconstants class [WIP].
node: replace nullid and friends with nodeconstants class [WIP]
Tue, Apr 20, 12:44 PM
joerg.sonnenberger updated the diff for D9465: node: replace nullid and friends with nodeconstants class.
Tue, Apr 20, 11:35 AM
joerg.sonnenberger added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

Delayed for now as it doesn't work with the broken changelog.files and needs more efficient manifest logic first.

Tue, Apr 20, 7:45 AM

Fri, Apr 9

joerg.sonnenberger added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

Do you have any performance number for that update ? for example the time we need to do that full some known large repositories, and the impact on a clone ?

Fri, Apr 9, 7:40 AM
joerg.sonnenberger added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

What happens in the stream clone case ? Or during the transition from older to newer client ? streaming content from an older clone will not contains a fully up to date cache, and existing repository neither. How are we dealing with this ?
You mention the need to update the cache after stripping, but I don't see such change in the code. am I missing something ?

Fri, Apr 9, 6:14 AM

Thu, Apr 8

joerg.sonnenberger updated the diff for D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Thu, Apr 8, 9:40 PM

Apr 8 2021

joerg.sonnenberger added inline comments to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Apr 8 2021, 7:03 AM

Apr 1 2021

joerg.sonnenberger updated the diff for D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Apr 1 2021, 4:49 PM
joerg.sonnenberger added inline comments to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Apr 1 2021, 4:43 PM

Mar 31 2021

joerg.sonnenberger closed D10291: mergestate: remove unused import.
Mar 31 2021, 1:50 PM
joerg.sonnenberger committed rHG94ea945190f3: mergestate: remove unused import.
mergestate: remove unused import
Mar 31 2021, 1:50 PM

Mar 30 2021

joerg.sonnenberger created D10291: mergestate: remove unused import.
Mar 30 2021, 6:20 PM
joerg.sonnenberger closed D10290: refactor: prefer checks against nullrev over nullid.
Mar 30 2021, 4:23 PM
joerg.sonnenberger closed D10280: refactor: prefer lookup by revision, even for null.
Mar 30 2021, 4:23 PM
joerg.sonnenberger committed rHG728d89f6f9b1: refactor: prefer checks against nullrev over nullid.
refactor: prefer checks against nullrev over nullid
Mar 30 2021, 4:23 PM
joerg.sonnenberger committed rHGad878e3f282b: refactor: prefer lookup by revision, even for null.
refactor: prefer lookup by revision, even for null
Mar 30 2021, 4:23 PM
joerg.sonnenberger committed rHGe7b4607d52e3: setdiscovery: simplify by using tiprev directly.
setdiscovery: simplify by using tiprev directly
Mar 30 2021, 4:23 PM
joerg.sonnenberger closed D10289: setdiscovery: simplify by using tiprev directly.
Mar 30 2021, 4:23 PM

Mar 29 2021

joerg.sonnenberger added a comment to D10278: extdiff: avoid nullid.

Superseded by D10280 and D10290

Mar 29 2021, 9:12 PM
joerg.sonnenberger added a comment to D10279: split: simplify.

Superseded by D10290

Mar 29 2021, 9:12 PM
joerg.sonnenberger added a comment to D10283: copies: simplify.

Superseded by D10290

Mar 29 2021, 9:11 PM
joerg.sonnenberger added a comment to D10285: logcmdutil: simplify.

Superseded by D10290

Mar 29 2021, 9:11 PM
joerg.sonnenberger added a comment to D10286: mergestate: simplify.

Superseded by D10290

Mar 29 2021, 9:11 PM
joerg.sonnenberger added a comment to D10287: shelve: simplify.

Superseded by D10290

Mar 29 2021, 9:11 PM
joerg.sonnenberger added a comment to D10288: simplemerge: simplify.

Superseded by D10290

Mar 29 2021, 9:10 PM
joerg.sonnenberger created D10290: refactor: prefer checks against nullrev over nullid.
Mar 29 2021, 8:42 PM
joerg.sonnenberger updated the diff for D9465: node: replace nullid and friends with nodeconstants class.
Mar 29 2021, 8:42 PM
joerg.sonnenberger retitled D10280: refactor: prefer lookup by revision, even for null from cmdutil: prefer lookup by revision, even for null to refactor: prefer lookup by revision, even for null.
Mar 29 2021, 8:34 PM
joerg.sonnenberger retitled D10280: refactor: prefer lookup by revision, even for null from cmdutil: simplify to cmdutil: prefer lookup by revision, even for null.
Mar 29 2021, 8:25 PM
joerg.sonnenberger created D10289: setdiscovery: simplify by using tiprev directly.
Mar 29 2021, 8:16 PM
joerg.sonnenberger closed D10277: fix: merge imports.
Mar 29 2021, 3:51 PM
joerg.sonnenberger committed rHGeb2a6f66c463: fix: merge imports.
fix: merge imports
Mar 29 2021, 3:50 PM

Mar 28 2021

joerg.sonnenberger retitled D9465: node: replace nullid and friends with nodeconstants class from [POC] node: replace nullid and friends with nodeconstants class to node: replace nullid and friends with nodeconstants class [WIP].
Mar 28 2021, 8:55 PM
joerg.sonnenberger created D10288: simplemerge: simplify.
Mar 28 2021, 8:06 PM
joerg.sonnenberger created D10287: shelve: simplify.
Mar 28 2021, 8:06 PM
joerg.sonnenberger created D10286: mergestate: simplify.
Mar 28 2021, 7:32 PM
joerg.sonnenberger created D10285: logcmdutil: simplify.
Mar 28 2021, 7:10 PM
joerg.sonnenberger created D10283: copies: simplify.
Mar 28 2021, 6:38 PM
joerg.sonnenberger updated the diff for D10280: refactor: prefer lookup by revision, even for null.
Mar 28 2021, 5:50 PM
joerg.sonnenberger created D10280: refactor: prefer lookup by revision, even for null.
Mar 28 2021, 5:11 PM
joerg.sonnenberger created D10279: split: simplify.
Mar 28 2021, 4:48 PM
joerg.sonnenberger created D10278: extdiff: avoid nullid.
Mar 28 2021, 4:00 PM
joerg.sonnenberger created D10277: fix: merge imports.
Mar 28 2021, 4:00 PM

Mar 22 2021

joerg.sonnenberger closed D10244: tests: ask any chg instance to terminate before looking at sqlite dbs.
Mar 22 2021, 2:28 PM
joerg.sonnenberger committed rHG186c0f6fbc16: tests: ask any chg instance to terminate before looking at sqlite dbs.
tests: ask any chg instance to terminate before looking at sqlite dbs
Mar 22 2021, 2:28 PM
joerg.sonnenberger closed D10243: chg: kill trailing comma in SEE ALSO.
Mar 22 2021, 2:28 PM
joerg.sonnenberger committed rHG283828850c56: chg: kill trailing comma in SEE ALSO.
chg: kill trailing comma in SEE ALSO
Mar 22 2021, 2:28 PM

Mar 19 2021

joerg.sonnenberger created D10244: tests: ask any chg instance to terminate before looking at sqlite dbs.
Mar 19 2021, 10:10 PM
joerg.sonnenberger created D10243: chg: kill trailing comma in SEE ALSO.
Mar 19 2021, 10:09 PM
joerg.sonnenberger closed D10242: tests: resort to fix test with newer git versions.
Mar 19 2021, 6:59 PM
joerg.sonnenberger committed rHG38f55ef058fb: tests: resort to fix test with newer git versions.
tests: resort to fix test with newer git versions
Mar 19 2021, 6:59 PM
joerg.sonnenberger created D10242: tests: resort to fix test with newer git versions.
Mar 19 2021, 6:52 PM
joerg.sonnenberger committed rHG048beb0167a7: git: fix missing case from 6266d19556ad (introduction of nodeconstants).
git: fix missing case from 6266d19556ad (introduction of nodeconstants)
Mar 19 2021, 6:38 PM
joerg.sonnenberger closed D10241: git: fix missing case from 6266d19556ad (introduction of nodeconstants).
Mar 19 2021, 6:38 PM
joerg.sonnenberger created D10241: git: fix missing case from 6266d19556ad (introduction of nodeconstants).
Mar 19 2021, 6:34 PM

Mar 17 2021

joerg.sonnenberger updated the diff for D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Mar 17 2021, 6:55 PM
joerg.sonnenberger updated the diff for D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.
Mar 17 2021, 4:17 PM
joerg.sonnenberger closed D9750: node: introduce nodeconstants class.
Mar 17 2021, 1:55 PM
joerg.sonnenberger committed rHG6266d19556ad: node: introduce nodeconstants class.
node: introduce nodeconstants class
Mar 17 2021, 1:51 PM
joerg.sonnenberger closed D10150: revlog: guarantee that p1 != null if a non-null parent exists.
Mar 17 2021, 1:51 PM
joerg.sonnenberger committed rHG49fd21f32695: revlog: guarantee that p1 != null if a non-null parent exists.
revlog: guarantee that p1 != null if a non-null parent exists
Mar 17 2021, 1:50 PM
joerg.sonnenberger closed D9283: bundle: optional multithreaded compression, ATM zstd-only.
Mar 17 2021, 10:43 AM
joerg.sonnenberger committed rHG471cd86c8eb4: bundle: optional multithreaded compression, ATM zstd-only.
bundle: optional multithreaded compression, ATM zstd-only
Mar 17 2021, 10:42 AM

Mar 16 2021

joerg.sonnenberger updated the diff for D9750: node: introduce nodeconstants class.
Mar 16 2021, 8:05 PM
joerg.sonnenberger closed D10226: README: document requirement for builtin zstd.
Mar 16 2021, 5:50 PM
joerg.sonnenberger committed rHGc5912e35d06d: README: document requirement for builtin zstd.
README: document requirement for builtin zstd
Mar 16 2021, 5:49 PM
joerg.sonnenberger added a comment to D9283: bundle: optional multithreaded compression, ATM zstd-only.

D10226 adds a separate packaging note about zstd.

Mar 16 2021, 8:03 AM

Mar 15 2021

joerg.sonnenberger created D10226: README: document requirement for builtin zstd.
Mar 15 2021, 7:07 PM

Mar 12 2021

joerg.sonnenberger closed D10075: ci: hook network-io tests into the pipeline.
Mar 12 2021, 1:18 PM