- User Since
- Dec 6 2017, 9:25 AM (202 w, 2 d)
Sep 18 2021
Sep 17 2021
From the VC call today: The use case can be addressed by marking parents as to-be-preserved, so that for merge commits rebase can decide on the parent link is should operate on. It covers a general DAG and is somewhat easier to use in terms of UX than the parentmap, but can provide the same functionality with a multi-step rebase.
Aug 4 2021
Jul 20 2021
I would have to reaudit the parents use, but it wasn't just new code that misbehaves on misordered parents. E.g. memctx.parents for a trivial example. So yes, just backing it out introduces regressions as well.
Jul 6 2021
Just the revert as is introduces other regressions. At the very least, we should preserve the sorting for changelog and keep the original order for filelog. The other part is that the filelog logic here is actively broken even before, so this doesn't fix the logic, just makes it less visibly broken.
Jun 21 2021
Can you comment on how many of them we keep open at a time?
May 27 2021
Consider it more a -0, not a very strong objection.
May 20 2021
Correct, this stack should have beeen superseded by those.
May 19 2021
May 18 2021
May 17 2021
May 16 2021
There are three stages for the revlog and I think we need to teach the transaction playback code at least a bit about this to handle it correctly:
This whole stack exposes a real problem and one quite a bit older, but it is not correct in a number of ways as is.
May 15 2021
May 14 2021
Silly Python, but this should be fine for all versions we care about. Ironically, it used to be defined the other way around as alias...
May 11 2021
May 4 2021
Adding more files to the revlog layer sounds like a move in the wrong direction and the motivation here seems quite weak too. Please discuss this with an actual plan on the mailing list.
I don't understand the motivation for this change.
I don't understand this change. We already support none as compression method.
May 3 2021
This adds a penalty for the non-inline case?
Apr 30 2021
I'm not sure that this is an improvement. We discussed whether we want to hard-wire the version even stricter ("exactly version 11"), especially because it is hard to predict when the output is going to change again.
Apr 29 2021
Already merged as d55b71393907
Apr 28 2021
Merged as 8d2b62d716b0
Merged as 77e73827a02d
Apr 20 2021
Delayed for now as it doesn't work with the broken changelog.files and needs more efficient manifest logic first.