Page MenuHomePhabricator

jsgf (Jeremy Fitzhardinge)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 6:02 PM (157 w, 2 d)

Recent Activity

Dec 15 2017

jsgf added inline comments to D1654: treedirstate: ensure appended data is flushed to disk.
Dec 15 2017, 2:18 PM

Dec 7 2017

jsgf requested changes to D1518: nodemap: move some methods to changelog utils.
Dec 7 2017, 12:25 PM
jsgf requested changes to D1517: radixbuf: make key reader function more flexible.
Dec 7 2017, 12:20 PM
jsgf requested changes to D1493: pybuf: add a simple abstraction around Py_buffer interface.
Dec 7 2017, 11:55 AM

Dec 6 2017

jsgf added inline comments to D1408: treedirstate: use vlqencoding for numbers.
Dec 6 2017, 6:01 PM
jsgf added inline comments to D1406: treedirstate: implement efficient case collision detection.
Dec 6 2017, 5:26 PM

Nov 22 2017

jsgf accepted D1403: treedirstate: better iteration using visitor pattern.
Nov 22 2017, 6:52 PM
jsgf added a comment to D1402: treedirstate: cache dirstate data when iterating all files.

Hm, on second thoughts, does BufReader<BufWriter<File>> actually work? Suspect not.

Nov 22 2017, 6:48 PM
jsgf requested changes to D1402: treedirstate: cache dirstate data when iterating all files.
Nov 22 2017, 6:45 PM
jsgf accepted D1399: treedirstate: add Tree.

I think the encode/decode should be factored out more, but I'll leave that up to you.

Nov 22 2017, 6:33 PM
jsgf accepted D1398: treedirstate: add FileStore.
Nov 22 2017, 6:05 PM
jsgf accepted D1397: treedirstate: add Store and StoreView traits.
Nov 22 2017, 5:51 PM
jsgf accepted D1396: treedirstate: add vecmap implementation.
Nov 22 2017, 5:47 PM
jsgf requested changes to D1401: treedirstate: add Python linkage.
Nov 22 2017, 5:46 PM
jsgf requested changes to D1400: treedirstate: add Dirstate.

z

Nov 22 2017, 4:50 PM
jsgf added inline comments to D1400: treedirstate: add Dirstate.
Nov 22 2017, 4:50 PM

Nov 17 2017

jsgf added a comment to D1399: treedirstate: add Tree.

I stopped following the code around PathRecurse handling - I assume its implementing a chunk of Mercurial-defined logic.

Nov 17 2017, 2:33 PM
jsgf added inline comments to D1399: treedirstate: add Tree.
Nov 17 2017, 2:33 PM
jsgf requested changes to D1399: treedirstate: add Tree.
Nov 17 2017, 2:32 PM
jsgf added inline comments to D1398: treedirstate: add FileStore.
Nov 17 2017, 1:59 PM
jsgf requested changes to D1398: treedirstate: add FileStore.
Nov 17 2017, 1:16 PM
jsgf added inline comments to D1397: treedirstate: add Store and StoreView traits.
Nov 17 2017, 12:45 PM
jsgf requested changes to D1397: treedirstate: add Store and StoreView traits.
Nov 17 2017, 12:38 PM
jsgf requested changes to D1396: treedirstate: add vecmap implementation.

Nits mostly.

Nov 17 2017, 12:31 PM

Nov 16 2017

jsgf committed rFBHGXdf4f177c3ac6: checkmessagehook: print more detail on what bad chars were found.
checkmessagehook: print more detail on what bad chars were found
Nov 16 2017, 2:06 PM

Nov 15 2017

jsgf closed D1419: checkmessagehook: print more detail on what bad chars were found.
Nov 15 2017, 7:05 PM

Nov 14 2017

jsgf updated the diff for D1419: checkmessagehook: print more detail on what bad chars were found.
Nov 14 2017, 7:48 PM
jsgf added inline comments to D1419: checkmessagehook: print more detail on what bad chars were found.
Nov 14 2017, 7:43 PM
jsgf updated the diff for D1419: checkmessagehook: print more detail on what bad chars were found.
Nov 14 2017, 7:42 PM
jsgf updated the diff for D1419: checkmessagehook: print more detail on what bad chars were found.
Nov 14 2017, 7:35 PM
jsgf added a comment to D1419: checkmessagehook: print more detail on what bad chars were found.

I couldn't find any existing unit tests to update.

Nov 14 2017, 7:20 PM
jsgf created D1419: checkmessagehook: print more detail on what bad chars were found.
Nov 14 2017, 7:16 PM

Nov 2 2017

jsgf added inline comments to D1290: radixbuf: add a base16 iterator.
Nov 2 2017, 4:06 PM
jsgf requested changes to D1289: radixbuf: initial boilerplate.
Nov 2 2017, 3:54 PM

Oct 13 2017

jsgf requested changes to D929: vlqencoding: encodes integers to variable-length byte arrays.
Oct 13 2017, 6:22 PM

Oct 10 2017

jsgf added a comment to D929: vlqencoding: encodes integers to variable-length byte arrays.

Getting more fancy, you could define VLQEncode/VLQDecode traits, then implement them for u64 and i64 (with zigzag), and perhaps other integer types if it makes sense/is useful.

Oct 10 2017, 5:55 PM
jsgf requested changes to D929: vlqencoding: encodes integers to variable-length byte arrays.
Oct 10 2017, 5:48 PM

Sep 22 2017

jsgf added a comment to D698: examplerust: add an example extension written in Rust.
In D698#12222, @durin42 wrote:

I can't see that keeping Debian releases possible. In my view if "no more than 2 or 3 stable releases" is a hard requirement for rust, we may as well stop having the discussion now.
(Alternatively: convince me with documented success cases that binaries built by a newer Rust than is in a given Debian release are somehow plausible and acceptable.)

Sep 22 2017, 3:55 PM

Sep 18 2017

jsgf added a comment to D698: examplerust: add an example extension written in Rust.

I don't have any particular opinion about which Python binding to use - they all seem a bit rough. I think there's some interesting scope for doing things like using custom derive to automate converting between Rust and Python representations, and iterators/futures/generators to do the conversions of large structures lazily.

Sep 18 2017, 6:36 PM