kevincox@kevincox.ca
User Details
- User Since
- Jan 11 2018, 4:59 AM (99 w, 2 d)
Mon, Dec 2
Nov 7 2019
Nov 6 2019
Oct 30 2019
I see a lot of the functions are here to give optimization hints. In order to make someone non-familiar with the code able to understand it each method should state the contracts that it is making. I am having a really hard time reconciling how the different functions interact and which methods have precedence over each other.
Oct 19 2019
Oct 16 2019
I've seen very good results with https://github.com/servo/rust-fnv in the past so it is probably worth including that in the comparison and possibly using it. It is especially good for small keys which seems like a common case in hg.
Oct 15 2019
Thanks, looks good.
Sep 13 2019
Sep 12 2019
Aug 30 2019
It looks good overall. I just would like to have a bit more strict definition of what an HgPath can contain and preferably some init-time validation.
Aug 28 2019
Aug 12 2019
Jul 22 2019
It seems weird to add this argument without using it. I would much rather it was added as the implementation was added.
Jul 17 2019
Jul 16 2019
Is there any reason this can't be done using Rc<RefCell<DirsMultiset>>? I have an example here: https://rust.godbolt.org/z/MNNR_F
Jul 15 2019
Jul 12 2019
Jul 10 2019
Is the SliceExt change related to the 2018 change? If not could you split the two?
Jul 4 2019
Jun 28 2019
Jun 24 2019
Sorry. I was busy. In general don't worry about blocking on me, I can't promise any sort of reasonable response time. Worst case I can review the changes after submission and changes can be made afterwards.
Jun 14 2019
Jun 13 2019
Thanks, looks good.
Jun 10 2019
Wouldn't it be better to make add_missing_revisions work properly on empty inputs? It seems like it is too error prone to try and catch every caller. If possible I would like to push this check down as far as possible.
May 24 2019
May 23 2019
May 17 2019
May 10 2019
The code and rust style looks fine. I'm not sure that taking the N smallest elements is the best approach for testing though. I can imagine it hiding some issues with larger values.
Apr 24 2019
Thanks for the changes.
Apr 20 2019
Apr 17 2019
Apr 15 2019
Apr 14 2019
I'm not a huge fan of the design of this class because it has a strong protocol to use correctly. It would probably be better to have 3 classes and when you apply new information each class transitions into the next one. This allows the type system to ensure that you are using the class correctly. However it appears that this is just re-implementing an API so improving that API is probably out of scope for the time being.