Page MenuHomePhabricator

khanchi97 (Sushil khanchi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 29 2018, 11:31 AM (76 w, 4 d)

Recent Activity

Thu, Jul 4

khanchi97 committed rHG4cafbd3b50c6: relnotes: document the new --force-close-branch flag.
relnotes: document the new --force-close-branch flag
Thu, Jul 4, 11:01 AM
khanchi97 closed D6590: relnotes: document the new --force-close-branch flag.
Thu, Jul 4, 11:00 AM

Sun, Jun 30

khanchi97 created D6590: relnotes: document the new --force-close-branch flag.
Sun, Jun 30, 3:18 PM
khanchi97 committed rHG2e1d9414ff71: commit: add --force-close-branch flag to close a non-head changeset.
commit: add --force-close-branch flag to close a non-head changeset
Sun, Jun 30, 12:14 AM

Sat, Jun 29

khanchi97 closed D6490: commit: add --force-close-branch flag to close a non-head changeset.
Sat, Jun 29, 7:05 PM
khanchi97 committed rHG171a367b7cf1: commit: add --force-close-branch flag to close a non-head changeset.
commit: add --force-close-branch flag to close a non-head changeset
Sat, Jun 29, 7:04 PM

Sun, Jun 23

khanchi97 retitled D6490: commit: add --force-close-branch flag to close a non-head changeset from commit: add --force flag to close branch from a non-head changeset to commit: add --force-close-branch flag to close a non-head changeset.
Sun, Jun 23, 3:25 AM

Sat, Jun 22

khanchi97 added a comment to D6490: commit: add --force-close-branch flag to close a non-head changeset.
In D6490#95305, @pulkit wrote:

I think adding a --force flag to hg commit is not a nice option. force can mean a lot of things and here except in closing the non-head changeset, it is no-op.
For example, I am in middle of a rebase, tried to commit, it says rebase in progress. I see there is a --force flag, I try to use that to force the commit.
We can do one of the following:

  1. maybe a more specific flag name like --allow-close-branch or something like that
  2. a config option instead of a flag name

Fair point. Specific is better.
I'd suggest --force-close-branch as a standalone flag (i.e. you don't need to also use --close-branch; it wasn't clear to me if that's what you meant). --allow-close-branch and --close-branch don't seem different enough to remember the difference.

Just my $0.02.
I think that hg commit already has many options that do not even belong to committing (such as -A, --close-branch). Let's not add an option that is not related to commit. To my opinion closing a branch should be done with hg branch not commit (unfortunately this was never the case). Anyway if you really want to do it with commit, I would suggest that --close-branch takes an optional argument rather than adding a new option. This makes UX a bit more convenient
e.g.

hg commit --close-branch --force-close-branch (not that)
hg commit --close-branch forced (or force or something like that)

I think it's a little hard to make user understand (by providing a hint like "use force arg with --close-branch") that you need to provide an argument as compared to just providing a standalone flag --force-close-branch as @mharbison72 suggested. I do agree with you that it would make +1 in the no. of flags which don't make sense with hg commit. What do you say?

What if you mark it (ADVANCED) so that it doesn't show in the help without a -v? Then the hint informs the user when it might be needed, otherwise they don't need to see it all the time.

Sat, Jun 22, 1:38 PM

Fri, Jun 21

khanchi97 added a comment to D6490: commit: add --force-close-branch flag to close a non-head changeset.

Could you also update relnotes/next (documenting either the new flag or config option, whatever this patch ends up doing)?

Fri, Jun 21, 9:54 AM
khanchi97 added a comment to D6490: commit: add --force-close-branch flag to close a non-head changeset.
In D6490#95305, @pulkit wrote:

I think adding a --force flag to hg commit is not a nice option. force can mean a lot of things and here except in closing the non-head changeset, it is no-op.
For example, I am in middle of a rebase, tried to commit, it says rebase in progress. I see there is a --force flag, I try to use that to force the commit.
We can do one of the following:

  1. maybe a more specific flag name like --allow-close-branch or something like that
  2. a config option instead of a flag name

Fair point. Specific is better.
I'd suggest --force-close-branch as a standalone flag (i.e. you don't need to also use --close-branch; it wasn't clear to me if that's what you meant). --allow-close-branch and --close-branch don't seem different enough to remember the difference.

Just my $0.02.
I think that hg commit already has many options that do not even belong to committing (such as -A, --close-branch). Let's not add an option that is not related to commit. To my opinion closing a branch should be done with hg branch not commit (unfortunately this was never the case). Anyway if you really want to do it with commit, I would suggest that --close-branch takes an optional argument rather than adding a new option. This makes UX a bit more convenient
e.g.

hg commit --close-branch --force-close-branch (not that)
hg commit --close-branch forced (or force or something like that)
Fri, Jun 21, 9:54 AM

Jun 18 2019

khanchi97 closed D6493: commit: make the error message more specific while aborting branch closing.
Jun 18 2019, 7:41 AM
khanchi97 closed D6491: commit: add a check if it is trying to close an already closed branch head.
Jun 18 2019, 7:41 AM
khanchi97 committed rHGabd4783db5a7: commit: make the error message more specific while aborting branch closing.
commit: make the error message more specific while aborting branch closing
Jun 18 2019, 7:41 AM
khanchi97 committed rHG9f7cb777b654: commit: add a check if it is trying to close an already closed branch head.
commit: add a check if it is trying to close an already closed branch head
Jun 18 2019, 7:41 AM

Jun 15 2019

khanchi97 retitled D6490: commit: add --force-close-branch flag to close a non-head changeset from branch: add --force flag to close branch from a not-head changeset to commit: add --force flag to close branch from a non-head changeset.
Jun 15 2019, 8:02 AM
khanchi97 retitled D6493: commit: make the error message more specific while aborting branch closing from branch: make the error message more specific while aborting branch closing to commit: make the error message more specific while aborting branch closing.
Jun 15 2019, 8:02 AM
khanchi97 retitled D6491: commit: add a check if it is trying to close an already closed branch head from branch: add a check if it is trying to close an already closed branch head to commit: add a check if it is trying to close an already closed branch head.
Jun 15 2019, 8:01 AM

Jun 11 2019

khanchi97 added a comment to D6490: commit: add --force-close-branch flag to close a non-head changeset.

LGTM, thanks.
Minor nit that I don't care too much about, but I'm wondering what others think of not-head changeset vs non-head changeset. The latter sounds more natural to me, but I'm not sure if there's another example of this phrasing.

Jun 11 2019, 1:49 AM

Jun 10 2019

khanchi97 added inline comments to D6490: commit: add --force-close-branch flag to close a non-head changeset.
Jun 10 2019, 9:02 AM

Jun 8 2019

khanchi97 updated the diff for D6490: commit: add --force-close-branch flag to close a non-head changeset.
Jun 8 2019, 6:23 AM
khanchi97 updated the diff for D6493: commit: make the error message more specific while aborting branch closing.
Jun 8 2019, 6:23 AM
khanchi97 updated the diff for D6491: commit: add a check if it is trying to close an already closed branch head.
Jun 8 2019, 6:23 AM

Jun 7 2019

khanchi97 added a comment to D6492: branch: add test covering the case when we have no branchheads to close.

Abandoned.. because I assumed this revision won't be pushed by phabsend as it's in secret phase. Is it right behavior?

Jun 7 2019, 10:11 AM
khanchi97 abandoned D6492: branch: add test covering the case when we have no branchheads to close.
Jun 7 2019, 10:06 AM
khanchi97 created D6493: commit: make the error message more specific while aborting branch closing.
Jun 7 2019, 9:57 AM
khanchi97 created D6490: commit: add --force-close-branch flag to close a non-head changeset.
Jun 7 2019, 9:57 AM
khanchi97 created D6491: commit: add a check if it is trying to close an already closed branch head.
Jun 7 2019, 9:56 AM
khanchi97 created D6492: branch: add test covering the case when we have no branchheads to close.
Jun 7 2019, 9:56 AM

Apr 25 2019

khanchi97 closed D6282: branch: abort if closing branch from a non-branchhead cset.
Apr 25 2019, 2:08 PM
khanchi97 committed rHG8d14d91584f1: branch: abort if closing branch from a non-branchhead cset.
branch: abort if closing branch from a non-branchhead cset
Apr 25 2019, 2:07 PM
khanchi97 closed D6281: branch: add tests which shows branch can be closed from a non-branchhead cset.
Apr 25 2019, 2:07 PM
khanchi97 committed rHG258821f2d465: branch: add tests which shows branch can be closed from a non-branchhead cset.
branch: add tests which shows branch can be closed from a non-branchhead cset
Apr 25 2019, 2:07 PM
khanchi97 added inline comments to D6281: branch: add tests which shows branch can be closed from a non-branchhead cset.
Apr 25 2019, 1:47 PM

Apr 19 2019

khanchi97 created D6282: branch: abort if closing branch from a non-branchhead cset.
Apr 19 2019, 3:49 AM
khanchi97 created D6281: branch: add tests which shows branch can be closed from a non-branchhead cset.
Apr 19 2019, 3:48 AM

Mar 19 2019

khanchi97 committed rHGf8c5225b9054: patch: include flag-only file changes in "special" when filtering (issue5864).
patch: include flag-only file changes in "special" when filtering (issue5864)
Mar 19 2019, 2:28 AM

Mar 18 2019

khanchi97 closed D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 18 2019, 7:36 PM
khanchi97 committed rHG6308aa828cf4: patch: include flag-only file changes in "special" while filtering patch….
patch: include flag-only file changes in "special" while filtering patch…
Mar 18 2019, 7:35 PM

Mar 16 2019

khanchi97 added a comment to D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).

Thanks, it is more clear now.

Mar 16 2019, 11:22 PM
khanchi97 added inline comments to D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 16 2019, 10:45 AM
khanchi97 updated the diff for D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 16 2019, 10:35 AM

Mar 13 2019

khanchi97 added inline comments to D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 13 2019, 3:27 PM
khanchi97 updated the diff for D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 13 2019, 3:22 PM

Mar 11 2019

khanchi97 added inline comments to D5963: copies: handle a case when both merging csets are not descendant of merge base.
Mar 11 2019, 12:32 PM
khanchi97 closed D5963: copies: handle a case when both merging csets are not descendant of merge base.
Mar 11 2019, 11:45 AM
khanchi97 committed rHG7694b685bb10: copies: handle a case when both merging csets are not descendant of merge base.
copies: handle a case when both merging csets are not descendant of merge base
Mar 11 2019, 11:44 AM
khanchi97 closed D5962: copies: add test that makes both the merging csets dirty and fails.
Mar 11 2019, 11:44 AM
khanchi97 committed rHGcbdd2b56d4c3: copies: add test that makes both the merging csets dirty and run w/o error.
copies: add test that makes both the merging csets dirty and run w/o error
Mar 11 2019, 11:44 AM
khanchi97 committed rHGfc4b7a46fda1: copies: add test that makes both the merging csets dirty and fails.
copies: add test that makes both the merging csets dirty and fails
Mar 11 2019, 11:44 AM
khanchi97 closed D5961: copies: add test that makes both the merging csets dirty and run w/o error.
Mar 11 2019, 11:44 AM
khanchi97 added a comment to D5962: copies: add test that makes both the merging csets dirty and fails.

Thanks, I have updated the patch.

Mar 11 2019, 5:51 AM
khanchi97 updated the diff for D5963: copies: handle a case when both merging csets are not descendant of merge base.
Mar 11 2019, 5:49 AM
khanchi97 updated the diff for D5962: copies: add test that makes both the merging csets dirty and fails.
Mar 11 2019, 5:49 AM

Mar 9 2019

khanchi97 added a comment to D5961: copies: add test that makes both the merging csets dirty and run w/o error.

Thanks

Mar 9 2019, 3:27 PM
khanchi97 added a comment to D5963: copies: handle a case when both merging csets are not descendant of merge base.

Gentle ping for review.

Mar 9 2019, 12:00 AM

Mar 8 2019

khanchi97 added a comment to D5962: copies: add test that makes both the merging csets dirty and fails.

Ping for review.

Mar 8 2019, 11:58 PM
khanchi97 added a comment to D5961: copies: add test that makes both the merging csets dirty and run w/o error.

Ping for review.

Mar 8 2019, 11:57 PM
khanchi97 added a comment to D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).

Ping for review.

Mar 8 2019, 11:52 PM
khanchi97 closed D6057: split: add tests which demonstrate the issue5864.
Mar 8 2019, 2:47 PM
khanchi97 committed rHG7da6307cc07a: split: add tests which demonstrate the issue5864.
split: add tests which demonstrate the issue5864
Mar 8 2019, 2:47 PM
khanchi97 added a comment to D6057: split: add tests which demonstrate the issue5864.

Ping for review!

Mar 8 2019, 1:36 PM

Mar 4 2019

khanchi97 added a comment to D5961: copies: add test that makes both the merging csets dirty and run w/o error.

I have updated the commit message too.

Mar 4 2019, 3:03 PM
khanchi97 updated the diff for D5963: copies: handle a case when both merging csets are not descendant of merge base.
Mar 4 2019, 2:52 PM
khanchi97 updated the diff for D5962: copies: add test that makes both the merging csets dirty and fails.
Mar 4 2019, 2:52 PM
khanchi97 updated the diff for D5961: copies: add test that makes both the merging csets dirty and run w/o error.
Mar 4 2019, 2:52 PM
khanchi97 added a comment to D5961: copies: add test that makes both the merging csets dirty and run w/o error.

Updating it acc to your suggestions.

Mar 4 2019, 2:50 PM

Mar 3 2019

khanchi97 created D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 3 2019, 5:38 PM
khanchi97 created D6057: split: add tests which demonstrate the issue5864.
Mar 3 2019, 5:37 PM
khanchi97 added a comment to D5961: copies: add test that makes both the merging csets dirty and run w/o error.

From test-check-code.t:

@@ -15,6 +15,13 @@
   Skipping i18n/polib.py it has no-che?k-code (glob)
   Skipping mercurial/statprof.py it has no-che?k-code (glob)
   Skipping tests/badserverext.py it has no-che?k-code (glob)
+  tests/test-copies.t:515:
+   >
+   trailing whitespace on non-output
+  tests/test-copies.t:516:
+   >   $ hg up .^
+   warning: ^ must be quoted
+  [1]
 @commands in debugcommands.py should be in alphabetical order.
Mar 3 2019, 1:55 AM
khanchi97 updated the diff for D5963: copies: handle a case when both merging csets are not descendant of merge base.
Mar 3 2019, 1:50 AM
khanchi97 updated the diff for D5962: copies: add test that makes both the merging csets dirty and fails.
Mar 3 2019, 1:50 AM
khanchi97 updated the diff for D5961: copies: add test that makes both the merging csets dirty and run w/o error.
Mar 3 2019, 1:50 AM

Feb 27 2019

khanchi97 added a comment to D5961: copies: add test that makes both the merging csets dirty and run w/o error.

That's totally fine, reviews it when you have time. Thanks :)

Feb 27 2019, 11:55 PM
khanchi97 added a comment to D5962: copies: add test that makes both the merging csets dirty and fails.

@martinvonz updated this one too.

Feb 27 2019, 9:21 AM
khanchi97 added a comment to D5961: copies: add test that makes both the merging csets dirty and run w/o error.

@martinvonz I have moved the tests in test-copies.t

Feb 27 2019, 9:14 AM

Feb 25 2019

khanchi97 updated the diff for D5963: copies: handle a case when both merging csets are not descendant of merge base.
Feb 25 2019, 2:33 PM
khanchi97 updated the diff for D5962: copies: add test that makes both the merging csets dirty and fails.
Feb 25 2019, 2:32 PM
khanchi97 updated the diff for D5961: copies: add test that makes both the merging csets dirty and run w/o error.
Feb 25 2019, 2:32 PM

Feb 24 2019

khanchi97 added a comment to D5963: copies: handle a case when both merging csets are not descendant of merge base.

Ping for review.

Feb 24 2019, 11:44 PM
khanchi97 added a comment to D5962: copies: add test that makes both the merging csets dirty and fails.

Ping for review.

Feb 24 2019, 11:43 PM
khanchi97 added a comment to D5961: copies: add test that makes both the merging csets dirty and run w/o error.

Ping for review.

Feb 24 2019, 11:42 PM

Feb 20 2019

khanchi97 updated the summary of D5963: copies: handle a case when both merging csets are not descendant of merge base.
Feb 20 2019, 12:43 PM
khanchi97 updated the summary of D5962: copies: add test that makes both the merging csets dirty and fails.
Feb 20 2019, 12:42 PM
khanchi97 updated the summary of D5961: copies: add test that makes both the merging csets dirty and run w/o error.
Feb 20 2019, 12:42 PM

Feb 19 2019

khanchi97 committed rHG35158796f52f: copies: return True instead of filename as it is expected to return boolean.
copies: return True instead of filename as it is expected to return boolean
Feb 19 2019, 1:13 AM
khanchi97 closed D5964: copies: return True instead of filename as it is expected to return boolean.
Feb 19 2019, 1:13 AM

Feb 14 2019

khanchi97 added inline comments to D5963: copies: handle a case when both merging csets are not descendant of merge base.
Feb 14 2019, 9:29 AM
khanchi97 created D5964: copies: return True instead of filename as it is expected to return boolean.
Feb 14 2019, 9:16 AM
khanchi97 created D5963: copies: handle a case when both merging csets are not descendant of merge base.
Feb 14 2019, 9:15 AM
khanchi97 created D5962: copies: add test that makes both the merging csets dirty and fails.
Feb 14 2019, 9:15 AM
khanchi97 created D5961: copies: add test that makes both the merging csets dirty and run w/o error.
Feb 14 2019, 9:15 AM

Jan 9 2019

khanchi97 closed D5474: obsutil: fix the issue5686.
Jan 9 2019, 3:06 PM
khanchi97 committed rHG191fac9ff9d3: obsutil: fix the issue5686.
obsutil: fix the issue5686
Jan 9 2019, 3:05 PM

Dec 25 2018

khanchi97 added a comment to D5474: obsutil: fix the issue5686.

Ready for review.

Dec 25 2018, 11:28 AM

Dec 23 2018

khanchi97 abandoned D5473: config: register evolution.stackaliases as a config option.
Dec 23 2018, 11:02 PM
khanchi97 added a comment to D5473: config: register evolution.stackaliases as a config option.

Oh, yes. It is extension specific configuration.
Abandoning this one.

Dec 23 2018, 11:01 PM
khanchi97 closed D5476: merge: modify the logical statement.
Dec 23 2018, 10:10 PM
khanchi97 committed rHG6faaf3a1c6ec: merge: modify the logical statement.
merge: modify the logical statement
Dec 23 2018, 10:10 PM
khanchi97 created D5476: merge: modify the logical statement.
Dec 23 2018, 7:48 AM
khanchi97 updated the diff for D5474: obsutil: fix the issue5686.
Dec 23 2018, 7:47 AM