- User Since
- Jan 29 2018, 11:31 AM (38 w, 1 d)
Sun, Oct 21
Sep 3 2018
Ready to review.
Aug 30 2018
Made changes. Ready to review.
Aug 27 2018
Aug 26 2018
Aug 16 2018
Aug 15 2018
Aug 14 2018
Aug 10 2018
Aug 7 2018
@yuja Is there any command left which we can consider to add
'history-editing-backup' config option?
Aug 6 2018
Aug 5 2018
Aug 4 2018
Aug 3 2018
Aug 2 2018
Aug 1 2018
Jul 31 2018
Jul 27 2018
Jul 24 2018
@pulkit I will send a follow up which will take care of bookmarks movement. Thanks for review!
Jul 22 2018
Jul 21 2018
right, will change it.
+ # either mark obsolete or keep rebased revisions
+ repo, ui, opts = self.repo, self.ui, self.opts
+ fm = ui.formatter('rebase', opts)
+ clearrebased(ui, repo, self.destmap, self.state, self.skipped,
+ collapsedas=None, keepf=self.keepf, fm=fm)
+ return 0
I doubt if this would work with --collapse. Can you try writing some tests?
What is the expected behaviour in case of --collapse? Should it collapse only those revisions which are rebased, then we may have to ask user to change commit message accordingly.
I'm not pretty sure, but it might be possible to utilize _finishrebase()
to implement --stop, roughly by:
- restore status
- drop revisions that aren't rebased yet
- finish it
yeah, trying to do it in _finishrebase()
+ elif stop:
+ #todo: raise error for conflicting options
Jul 20 2018
Jul 19 2018
Jul 18 2018
And, should we drop the --no-backup option? @pulkit what do you think?
Yep, we should either have this option everywhere or not have it anywhere. I too think that config option is better suited here. Let's drop it and comment on the bug which needed the flag about the config option.
How do we drop a feature? Do I need to remove all the code related to --no-backup option?
Because this option has not been part of a release yet. There is no point of releasing a deprecated feature.
Got it. Thanks!
And, should we drop the --no-backup option?
dropped -> user won't be able to use that option
deprecated -> can use, but this is not preferred option to use
Am I right above?
If yes, why not deprecate then?