krbullock (Kevin Bullock)
User

Projects

User Details

User Since
Jun 23 2017, 5:46 PM (94 w, 5 d)

Recent Activity

May 5 2018

krbullock committed rHG1f65d7d46545: Added signature for changeset 6614cac550ae.
Added signature for changeset 6614cac550ae
May 5 2018, 7:08 PM
krbullock committed rHGed6808cfb116: Added tag 4.6 for changeset 6614cac550ae.
Added tag 4.6 for changeset 6614cac550ae
May 5 2018, 7:08 PM

May 2 2018

krbullock accepted D3437: paper: don't register click handlers with inline javascript (issue5812).

Queued, thanks.

May 2 2018, 10:21 PM
krbullock accepted D3436: hgweb: allow Content-Security-Policy header on 304 responses (issue5844).

Queued, thanks.

May 2 2018, 10:10 PM
krbullock accepted D3435: hgweb: discard Content-Type header for 304 responses (issue5844).
May 2 2018, 10:10 PM
krbullock accepted D3434: tests: add tests demonstrating ISE for HTTP 304 responses with hgwebdir.
May 2 2018, 10:10 PM

Apr 18 2018

krbullock accepted D2668: rebase: introduce support for automatically rebasing orphan changes.
Apr 18 2018, 3:00 PM
krbullock requested changes to D2668: rebase: introduce support for automatically rebasing orphan changes.

Looks like a couple unresolved comments on _possibledestination, plus one nitpick. I think we can clean those things up easily and then land this though.

Apr 18 2018, 2:40 PM

Apr 1 2018

krbullock committed rHG58cf99cd2bab: rust-hglib: import the latest version and update URLs.
rust-hglib: import the latest version and update URLs
Apr 1 2018, 2:45 PM

Mar 6 2018

krbullock committed rHG9639c433be54: Added signature for changeset 8bba684efde7.
Added signature for changeset 8bba684efde7
Mar 6 2018, 2:22 PM
krbullock committed rHG8bba684efde7: merge with security patches.
merge with security patches
Mar 6 2018, 2:22 PM
krbullock committed rHG2034cf3bfc70: Added tag 4.5.2 for changeset 8bba684efde7.
Added tag 4.5.2 for changeset 8bba684efde7
Mar 6 2018, 2:22 PM
krbullock committed rHG2c49b2e7da86: Added signature for changeset 369aadf7a326.
Added signature for changeset 369aadf7a326
Mar 6 2018, 2:09 PM
krbullock committed rHG9648b954e394: Added tag 4.5.1 for changeset 369aadf7a326.
Added tag 4.5.1 for changeset 369aadf7a326
Mar 6 2018, 2:09 PM

Mar 4 2018

krbullock committed rHG68328202f270: dispatch: don't clamp the range of the exit code twice.
dispatch: don't clamp the range of the exit code twice
Mar 4 2018, 7:55 AM

Mar 2 2018

krbullock committed rHG3790610c2793: py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1.
py3: bail on ratcheting tests forward on 3.6.0 and 3.6.1
Mar 2 2018, 3:45 PM

Feb 24 2018

krbullock committed rHGeb73f8a6177e: merge with stable.
merge with stable
Feb 24 2018, 6:51 PM

Feb 23 2018

krbullock added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

Oh sorry, I see you're already on the case. Carry on!

Feb 23 2018, 12:44 PM
krbullock added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

Can we get some test coverage on this?

Feb 23 2018, 12:44 PM

Feb 14 2018

krbullock added a comment to D1808: debugcommands: print out the editor that was searched for (post shlexsplit).

@durin42 Go for it

Feb 14 2018, 10:26 PM

Feb 7 2018

krbullock added a comment to D2057: rust implementation of hg status.

What would be the advantage of taking this? Since we already have the C implementation, it's not likely to gain us any performance. On the other hand, it might make a good test case for integrating Rust and Python, finding the right API boundaries and experimenting with different approaches, precisely because we already have a C implementation. @indygreg @durin42 what are your thoughts about it?

Feb 7 2018, 10:59 PM

Feb 6 2018

krbullock accepted D1808: debugcommands: print out the editor that was searched for (post shlexsplit).

This LGTM now. I think the executable as interpreted by shlex, but without the added flags, gives enough signal for the user to figure out what might be wrong without confusing things.

Feb 6 2018, 2:00 PM

Jan 4 2018

krbullock requested changes to D1591: visibility: improve the message when accessing filtered obsolete rev.

This has new failures in test-obshistory.t and test-directaccess.t, can you rebase?

Jan 4 2018, 10:26 PM
krbullock accepted D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo.

Queued, thanks

Jan 4 2018, 10:24 PM
krbullock requested changes to D1808: debugcommands: print out the editor that was searched for (post shlexsplit).
Jan 4 2018, 10:23 PM
krbullock requested changes to D1729: githelp: don't reference 3rd party commands for `git show`.
Jan 4 2018, 10:10 PM
krbullock accepted D1591: visibility: improve the message when accessing filtered obsolete rev.

Queued, thanks

Jan 4 2018, 10:02 PM

Dec 22 2017

krbullock accepted D1745: rebase: don't take out a dirstate guard for in-memory rebase.

Sure, queued.

Dec 22 2017, 11:00 AM

Dec 21 2017

krbullock accepted D1720: debug: add newlines at the end of three locations that appear to need it.

Sure, queued.

Dec 21 2017, 6:01 PM
krbullock accepted D1719: debug: remove an 'if ui.debug()' that is not doing anything.

Seems reasonable.

Dec 21 2017, 5:50 PM
krbullock requested changes to D1591: visibility: improve the message when accessing filtered obsolete rev.

One nit, otherwise looks nice!

Dec 21 2017, 5:48 PM

Dec 18 2017

krbullock accepted D1718: worker: handle interrupt on windows.

Whoops, queued, thanks.

Dec 18 2017, 10:55 PM
krbullock accepted D1717: lfs: fix committing deleted files caused by e0a1b9ee93cd.

Queued per Matt's review, thanks.

Dec 18 2017, 10:52 PM
krbullock accepted D1713: tests: update expected output of svn encoding test.

LGTM, thanks.

Dec 18 2017, 10:51 PM

Dec 15 2017

krbullock accepted D1710: tests: test-pathconflicts-merge.t requires symlinks.

LGTM, thanks.

Dec 15 2017, 6:05 PM
krbullock added inline comments to D1698: copies: group wdir-handling in one place.
Dec 15 2017, 11:26 AM
krbullock added inline comments to D1691: debugdiscovery: drop reference to invalid --branch option.
Dec 15 2017, 11:18 AM

Dec 9 2017

krbullock accepted D1623: tests: glob away ' that doesn't occur on all platforms in lfs test.
Dec 9 2017, 12:00 AM

Dec 8 2017

krbullock added inline comments to D1617: rebase: extract _assignworkingcopy.
Dec 8 2017, 11:42 PM
krbullock requested changes to D1607: remotenames: rename related file and storage dir to logexchange.

This doesn't apply cleanly. Can you rebase?

Dec 8 2017, 11:33 PM
krbullock accepted D1601: clone: add support for storing remotenames while cloning.
Dec 8 2017, 11:26 PM
krbullock requested changes to D1457: workers: don't use backgroundfilecloser in threads.

Looks okay to me except for Augie's nit. @indygreg ?

Dec 8 2017, 11:16 PM

Dec 6 2017

krbullock accepted D1605: tests: remove {a..h} bashism from remotenames.

LGTM.

Dec 6 2017, 2:43 PM

Dec 1 2017

krbullock committed rHGaef2b98d9352: merge with stable.
merge with stable
Dec 1 2017, 4:21 PM
krbullock committed rHGfff9ffa2ea05: Added signature for changeset a92b9f8e11ba.
Added signature for changeset a92b9f8e11ba
Dec 1 2017, 2:55 PM
krbullock committed rHGb9a0d9aa7a37: Added tag 4.4.2 for changeset a92b9f8e11ba.
Added tag 4.4.2 for changeset a92b9f8e11ba
Dec 1 2017, 2:55 PM
krbullock accepted D1226: merge: check created file dirs for path conflicts only once (issue5716).
Dec 1 2017, 12:57 PM
krbullock accepted D1224: merge: cache unknown dir checks (issue5716).
Dec 1 2017, 12:57 PM

Nov 22 2017

krbullock added a comment to D1063: rebase: enable multidest by default.

@quark @martinvonz Ping

Nov 22 2017, 12:08 PM

Nov 3 2017

krbullock committed rHG19ecd39223dc: merge with stable.
merge with stable
Nov 3 2017, 11:33 AM

Nov 1 2017

krbullock committed rHG3ce0e4b51f78: merge stable into default.
merge stable into default
Nov 1 2017, 6:21 PM
krbullock committed rHG95f54cec0025: Added signature for changeset 0ccb43d4cf01.
Added signature for changeset 0ccb43d4cf01
Nov 1 2017, 5:59 PM
krbullock committed rHG43d8e2fc1457: Added tag 4.4 for changeset 0ccb43d4cf01.
Added tag 4.4 for changeset 0ccb43d4cf01
Nov 1 2017, 5:59 PM
krbullock committed rHG05ebb553bd03: internals: update test-help.t for config registrar copy-edit.
internals: update test-help.t for config registrar copy-edit
Nov 1 2017, 4:36 PM
krbullock committed rHGfb7f58daca48: internals: copy-edit "register" -> "registrar" in configitem docs.
internals: copy-edit "register" -> "registrar" in configitem docs
Nov 1 2017, 4:12 PM

Oct 24 2017

krbullock added a comment to D1224: merge: cache unknown dir checks (issue5716).

Code LGTM, but I haven't done any performance testing on this.

Oct 24 2017, 12:10 PM
krbullock added a comment to D1224: merge: cache unknown dir checks (issue5716).

If this mitigates or fixes issue5716, please mention it in the summary line.

Oct 24 2017, 12:08 PM
krbullock committed rHGa6a322193a02: setup: filter out devel-warn messages from system hg.
setup: filter out devel-warn messages from system hg
Oct 24 2017, 12:03 AM
krbullock committed rHGd643848635de: setup: remove duplicate assignment of HGRCPATH.
setup: remove duplicate assignment of HGRCPATH
Oct 24 2017, 12:03 AM
krbullock committed rHG76ba5b5a53f0: packaging: update book URL in Mac and Windows READMEs.
packaging: update book URL in Mac and Windows READMEs
Oct 24 2017, 12:03 AM

Oct 20 2017

krbullock committed rHG5539a6acfd77: Added signature for changeset 1e2454b60e59.
Added signature for changeset 1e2454b60e59
Oct 20 2017, 2:47 PM
krbullock committed rHG8d9ba492e807: Added tag 4.4-rc for changeset 1e2454b60e59.
Added tag 4.4-rc for changeset 1e2454b60e59
Oct 20 2017, 2:47 PM
krbullock accepted D1201: dirstate: clean up when restoring identical backups.

LGTM but I'd like someone with more familiarity with dirstate to have a look too. Maybe @durham ?

Oct 20 2017, 11:20 AM
krbullock accepted D1200: tests: add a test demonstrating failure to clean up dirstate backups.
Oct 20 2017, 11:18 AM

Oct 19 2017

krbullock committed rHGa52e5604d864: merge default into stable for code freeze.
merge default into stable for code freeze
Oct 19 2017, 5:53 PM
krbullock added a comment to D1191: obsfate: makes successorsetverb takes the markers as argument.

Deferring this until after 4.4, because the added markers argument isn't used yet.

Oct 19 2017, 5:23 PM
krbullock updated subscribers of D932: filemerge: introduce functions to halt merge flow.
Oct 19 2017, 5:22 PM
krbullock committed rHG8ac568e96170: merge default into stable for code freeze.
merge default into stable for code freeze
Oct 19 2017, 4:18 PM
krbullock accepted D1197: config: also gather effect-flags on experimental.evolution.
Oct 19 2017, 3:40 PM
krbullock accepted D1190: obsfate: rename obsfate into obsolete in default mapfile.
Oct 19 2017, 3:32 PM
krbullock accepted D1189: obsfate: rename obsfate into obsolete in changeset_printer.
Oct 19 2017, 3:32 PM
krbullock requested changes to D1191: obsfate: makes successorsetverb takes the markers as argument.
Oct 19 2017, 3:23 PM
krbullock added a comment to D1140: localrepo: add a pinnedrevs attribute.

We're dropping this stack from 4.4 because it caused unexpected behavior changes in python-hglib (https://buildbot.mercurial-scm.org/builders/python-hglib/builds/654) and elsewhere. Seems to stem from recomputing from the same set on repeated calls to repoview.pinnedrevs().

Oct 19 2017, 1:01 PM
krbullock committed rHGeb1b964b354b: phases: pass phase names to hooks instead of internal values.
phases: pass phase names to hooks instead of internal values
Oct 19 2017, 1:00 PM
krbullock accepted D1196: tests: add some (?) output lines to catch "helpful" output from Solaris diff.

LGTM

Oct 19 2017, 11:37 AM

Oct 18 2017

krbullock committed rHGc7f1c079aa26: phases: pass phase names to hooks instead of internal values.
phases: pass phase names to hooks instead of internal values
Oct 18 2017, 3:01 PM

Oct 11 2017

krbullock committed rHG6ce2d81968aa: status: copy-edit and improve --terse and --verbose help.
status: copy-edit and improve --terse and --verbose help
Oct 11 2017, 2:17 PM

Oct 5 2017

krbullock accepted D956: test-annotate: fix up expected output for pure.
Oct 5 2017, 3:26 PM
krbullock added a comment to D956: test-annotate: fix up expected output for pure.

Sure, queued.

Oct 5 2017, 3:26 PM

Oct 4 2017

krbullock accepted D935: urllibcompat: move some adapters from pycompat to urllibcompat.
Oct 4 2017, 3:48 PM
krbullock accepted D891: cleanup: use urllibcompat for renamed methods on urllib request objects.
Oct 4 2017, 3:48 PM
krbullock accepted D890: urllibcompat: new library to help abstract out some python3 urllib2 stuff.
Oct 4 2017, 3:48 PM
krbullock added inline comments to D930: merge: add tests to show current behavior on failed filemerges.
Oct 4 2017, 3:08 PM
krbullock requested changes to D932: filemerge: introduce functions to halt merge flow.

I was initially confused by the description of this change, because the user can already halt (by configuration) after the first failed file merge. But this introduces a way for them to be prompted whether to halt or continue, right? Also:

Oct 4 2017, 3:08 PM
krbullock accepted D915: test-devel-warnings: make the test compatible with chg.

Queued, thanks.

Oct 4 2017, 2:56 PM
krbullock accepted D893: fsmonitor: use configitem.
Oct 4 2017, 10:53 AM
krbullock accepted D892: fsmonitor: access copymap in new location.
Oct 4 2017, 10:53 AM
krbullock requested changes to D894: fsmonitor: warn when fsmonitor could be used.
Oct 4 2017, 10:52 AM

Oct 1 2017

krbullock accepted D860: treediscovery: update test expectation.

Queued these, thanks.

Oct 1 2017, 5:57 AM
krbullock committed rHGcac3f51bf3d5: merge with stable.
merge with stable
Oct 1 2017, 5:42 AM

Sep 30 2017

krbullock accepted D833: exchange: perform stream clone with clone bundle with --uncompressed.

Queued these, thanks.

Sep 30 2017, 9:56 AM
krbullock accepted D832: tests: add tests for clone bundles with --uncompressed.
Sep 30 2017, 9:49 AM
krbullock added a comment to D743: ui: check for progress singleton when clearing progress bar (issue5684).

Queued for stable, thanks.

Sep 30 2017, 8:00 AM
krbullock accepted D743: ui: check for progress singleton when clearing progress bar (issue5684).
Sep 30 2017, 8:00 AM

Sep 18 2017

krbullock accepted D709: bundle2: move part processing to a separate function.
Sep 18 2017, 4:39 PM
krbullock accepted D708: bundle2: remove unnecessary try finally.
Sep 18 2017, 4:39 PM
krbullock accepted D726: uncommit: rename the flag 'empty' to 'keep' which retains empty changeset.

LGTM, but leaving it for others to review because I know this was a subject of IRC discussion recently.

Sep 18 2017, 4:36 PM
krbullock requested changes to D657: revset: move weight information to predicate.

I think either expanding the docs or using constants would be fine, but the default weight looks like it's 1, not 10.

Sep 18 2017, 4:13 PM
krbullock requested changes to D614: registrar: make cmdtype an attribute of the function in registar.command.

Flagging for revision per Augie's open question.

Sep 18 2017, 3:53 PM
krbullock requested changes to D544: releasenotes: update docstrings with information on additional flags.
Sep 18 2017, 3:50 PM