lothiraldan (Boris Feld)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2017, 12:05 PM (27 w, 5 h)

Recent Activity

Today

lothiraldan committed rHGc9eb92fb87b7: showstack: add an extension docstring.
showstack: add an extension docstring
Tue, Jan 16, 3:16 PM
lothiraldan committed rHG2f54a3e228ff: bookmark: run 'pushkey' hooks after bookmark move, not 'prepushkey'.
bookmark: run 'pushkey' hooks after bookmark move, not 'prepushkey'
Tue, Jan 16, 3:16 PM
lothiraldan added a comment to D1074: branch: add a --rev flag to change branch name of given revisions.

Apart from my review, it looks good to me.

Tue, Jan 16, 3:15 PM
lothiraldan added a comment to D1867: evolution: report new unstable changesets.

LGTM on a first quick review

Tue, Jan 16, 3:14 PM

Sun, Jan 14

lothiraldan closed D1833: style: remove multiple statement on a single line in zeroconf.
Sun, Jan 14, 2:36 PM
lothiraldan closed D1834: pylint: add a check for multiple statement on a single line.
Sun, Jan 14, 2:36 PM
lothiraldan committed rHG6061e54ff81d: pylint: add a check for multiple statement on a single line.
pylint: add a check for multiple statement on a single line
Sun, Jan 14, 2:36 PM
lothiraldan committed rHG31451f3f4b56: style: remove multiple statement on a single line in zeroconf.
style: remove multiple statement on a single line in zeroconf
Sun, Jan 14, 2:36 PM
lothiraldan committed rHGab11af15a149: style: remove multiple statement on a single line.
style: remove multiple statement on a single line
Sun, Jan 14, 2:36 PM
lothiraldan closed D1832: style: remove multiple statement on a single line.
Sun, Jan 14, 2:36 PM
lothiraldan committed rHG882998f08c3c: pylint: split command line argument on multiple lines.
pylint: split command line argument on multiple lines
Sun, Jan 14, 2:36 PM
lothiraldan closed D1831: pylint: split command line argument on multiple lines.
Sun, Jan 14, 2:36 PM

Fri, Jan 12

lothiraldan committed rHG22c42bfbe7ab: visibility: pass a normal repo to _getfilteredreason.
visibility: pass a normal repo to _getfilteredreason
Fri, Jan 12, 8:14 PM
lothiraldan committed rHGc026547454dd: visibility: make the filtered message translatable.
visibility: make the filtered message translatable
Fri, Jan 12, 8:14 PM
lothiraldan committed rHGfe4e1352c035: visibility: fix a comment introduced before which is not up-to-date.
visibility: fix a comment introduced before which is not up-to-date
Fri, Jan 12, 8:14 PM
lothiraldan closed D1853: visiblity: pass a normal repo to _getfilteredreason.
Fri, Jan 12, 7:48 AM
lothiraldan closed D1852: visibility: make the filtered message translatable.
Fri, Jan 12, 7:48 AM
lothiraldan closed D1851: visibilty: fix a comment introduced before which is not up-to-date.
Fri, Jan 12, 7:48 AM
lothiraldan committed rHGea9bd35529f2: visiblity: pass a normal repo to _getfilteredreason.
visiblity: pass a normal repo to _getfilteredreason
Fri, Jan 12, 7:48 AM
lothiraldan committed rHG0e0daf46a30c: visibility: make the filtered message translatable.
visibility: make the filtered message translatable
Fri, Jan 12, 7:48 AM
lothiraldan committed rHG49e073ea09d6: visibilty: fix a comment introduced before which is not up-to-date.
visibilty: fix a comment introduced before which is not up-to-date
Fri, Jan 12, 7:48 AM
lothiraldan created D1853: visiblity: pass a normal repo to _getfilteredreason.
Fri, Jan 12, 6:33 AM
lothiraldan created D1852: visibility: make the filtered message translatable.
Fri, Jan 12, 6:33 AM
lothiraldan created D1851: visibilty: fix a comment introduced before which is not up-to-date.
Fri, Jan 12, 6:33 AM
lothiraldan added a dependent revision for D1852: visibility: make the filtered message translatable: D1853: visiblity: pass a normal repo to _getfilteredreason.
Fri, Jan 12, 6:33 AM
lothiraldan added a dependent revision for D1851: visibilty: fix a comment introduced before which is not up-to-date: D1852: visibility: make the filtered message translatable.
Fri, Jan 12, 6:33 AM

Thu, Jan 11

lothiraldan committed rHG4b68ca118d8d: pull: hold wlock for the full operation when --update is used.
pull: hold wlock for the full operation when --update is used
Thu, Jan 11, 8:40 AM

Wed, Jan 10

lothiraldan committed rHGaf25237be091: perf: add threading capability to perfbdiff.
perf: add threading capability to perfbdiff
Wed, Jan 10, 6:13 PM
lothiraldan closed D1591: visibility: improve the message when accessing filtered obsolete rev.
Wed, Jan 10, 6:03 PM
lothiraldan committed rHG265cd9e19d26: visibility: improve the message when accessing filtered obsolete rev.
visibility: improve the message when accessing filtered obsolete rev
Wed, Jan 10, 6:02 PM
lothiraldan created D1834: pylint: add a check for multiple statement on a single line.
Wed, Jan 10, 3:23 AM
lothiraldan created D1833: style: remove multiple statement on a single line in zeroconf.
Wed, Jan 10, 3:23 AM
lothiraldan added a dependent revision for D1833: style: remove multiple statement on a single line in zeroconf: D1834: pylint: add a check for multiple statement on a single line.
Wed, Jan 10, 3:23 AM
lothiraldan added a dependent revision for D1832: style: remove multiple statement on a single line: D1833: style: remove multiple statement on a single line in zeroconf.
Wed, Jan 10, 3:22 AM
lothiraldan created D1832: style: remove multiple statement on a single line.
Wed, Jan 10, 3:22 AM
lothiraldan added a dependent revision for D1831: pylint: split command line argument on multiple lines: D1832: style: remove multiple statement on a single line.
Wed, Jan 10, 3:22 AM
lothiraldan created D1831: pylint: split command line argument on multiple lines.
Wed, Jan 10, 3:22 AM
lothiraldan updated the diff for D1591: visibility: improve the message when accessing filtered obsolete rev.
Wed, Jan 10, 2:33 AM

Tue, Jan 9

lothiraldan committed rHGbdae51a83dfb: clonebundle: make it possible to retrieve the initial bundle through largefile.
clonebundle: make it possible to retrieve the initial bundle through largefile
Tue, Jan 9, 7:40 AM
lothiraldan committed rHGcf841f2b5a72: largefiles: add support for 'largefiles://' url scheme.
largefiles: add support for 'largefiles://' url scheme
Tue, Jan 9, 7:40 AM
lothiraldan committed rHG4aa6ed598323: largefiles: add a 'debuglfput' command to put largefile into the store.
largefiles: add a 'debuglfput' command to put largefile into the store
Tue, Jan 9, 7:40 AM
lothiraldan committed rHG6580cf751418: debug: add a 'debugdownload' command.
debug: add a 'debugdownload' command
Tue, Jan 9, 7:40 AM

Fri, Jan 5

lothiraldan added a comment to D1591: visibility: improve the message when accessing filtered obsolete rev.

@krbullock Done

Fri, Jan 5, 3:45 AM
lothiraldan updated the diff for D1591: visibility: improve the message when accessing filtered obsolete rev.
Fri, Jan 5, 3:42 AM

Tue, Jan 2

lothiraldan added inline comments to D1591: visibility: improve the message when accessing filtered obsolete rev.
Tue, Jan 2, 5:17 AM
lothiraldan updated the diff for D1591: visibility: improve the message when accessing filtered obsolete rev.
Tue, Jan 2, 5:17 AM

Thu, Dec 21

lothiraldan updated the summary of D1591: visibility: improve the message when accessing filtered obsolete rev.
Thu, Dec 21, 3:15 AM

Mon, Dec 18

lothiraldan committed rHG8251c4c4abdc: debuginstall: add a line about re2 availability.
debuginstall: add a line about re2 availability
Mon, Dec 18, 8:17 AM
lothiraldan added inline comments to D1591: visibility: improve the message when accessing filtered obsolete rev.
Mon, Dec 18, 7:19 AM
lothiraldan updated the diff for D1591: visibility: improve the message when accessing filtered obsolete rev.
Mon, Dec 18, 7:18 AM

Dec 15 2017

lothiraldan added inline comments to D1427: logtoprocess: add a test to show pager and ltp bad interaction.
Dec 15 2017, 6:01 AM
lothiraldan added a comment to D1426: logtoprocess: add the possibility to not start a shell.

I've resent as https://phab.mercurial-scm.org/D1700 because I couldn't get phabsend to reproduce my linear updated stack on phabricator :(

Dec 15 2017, 5:17 AM
lothiraldan created D1703: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager.
Dec 15 2017, 5:15 AM
lothiraldan added a dependent revision for D1702: logtoprocess: add a test to show pager and ltp bad interaction: D1703: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager.
Dec 15 2017, 5:15 AM
lothiraldan created D1702: logtoprocess: add a test to show pager and ltp bad interaction.
Dec 15 2017, 5:15 AM
lothiraldan added a dependent revision for D1701: logtoprocess: add the possibility to not popup a console: D1702: logtoprocess: add a test to show pager and ltp bad interaction.
Dec 15 2017, 5:15 AM
lothiraldan updated the diff for D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager.
Dec 15 2017, 5:11 AM
lothiraldan created D1701: logtoprocess: add the possibility to not popup a console.
Dec 15 2017, 5:11 AM
lothiraldan added a dependent revision for D1700: logtoprocess: pass ui in runshellcommand: D1701: logtoprocess: add the possibility to not popup a console.
Dec 15 2017, 5:11 AM
lothiraldan created D1700: logtoprocess: pass ui in runshellcommand.
Dec 15 2017, 5:10 AM

Dec 14 2017

lothiraldan added a comment to D1426: logtoprocess: add the possibility to not start a shell.

It works when passing CREATE_NEW_CONSOLE instead of DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP.

Dec 14 2017, 12:03 PM

Dec 13 2017

lothiraldan added a comment to D1426: logtoprocess: add the possibility to not start a shell.

Without DETACHED_PROCESS, no console is spawned either with shell=False or shell=True but Mercurial will wait for the log-to-process script to finish before ending.

Dec 13 2017, 4:03 AM

Dec 12 2017

lothiraldan committed rHG7b73bf1a48d4: histedit: preserve active branch while histediting.
histedit: preserve active branch while histediting
Dec 12 2017, 5:48 PM
lothiraldan added a comment to D1426: logtoprocess: add the possibility to not start a shell.

I've access to a Windows machine this week, so you can expect a comment or new version before the end of the week.

Dec 12 2017, 3:43 AM

Dec 9 2017

lothiraldan committed rHG6226668a7169: upgrade: add a 'redeltafullall' mode.
upgrade: add a 'redeltafullall' mode
Dec 9 2017, 12:37 AM
lothiraldan committed rHG9eb19b13e92a: lfs: allow to run 'debugupgraderepo' on repo with largefiles.
lfs: allow to run 'debugupgraderepo' on repo with largefiles
Dec 9 2017, 12:37 AM
lothiraldan committed rHG8f3f8b8dbab7: upgrade: use actual filelog to convert filelog.
upgrade: use actual filelog to convert filelog
Dec 9 2017, 12:37 AM
lothiraldan committed rHG06987c6971be: upgrade: more standard creation of the temporary repository.
upgrade: more standard creation of the temporary repository
Dec 9 2017, 12:37 AM
lothiraldan committed rHG75520786ad2f: upgrade: use the repository 'ui' as the base for the new repository.
upgrade: use the repository 'ui' as the base for the new repository
Dec 9 2017, 12:37 AM
lothiraldan committed rHGcb7a0ae053c6: upgrade: add a test to show the repository config being ignored.
upgrade: add a test to show the repository config being ignored
Dec 9 2017, 12:37 AM
lothiraldan committed rHGead01b74be04: upgrade: register compression as a format variants.
upgrade: register compression as a format variants
Dec 9 2017, 12:28 AM
lothiraldan committed rHG740d40ec15c3: debugformat: handle non-boolean value for variant.
debugformat: handle non-boolean value for variant
Dec 9 2017, 12:28 AM
lothiraldan committed rHGcfb403b92f43: debugformat: add data about the config when verbose.
debugformat: add data about the config when verbose
Dec 9 2017, 12:28 AM
lothiraldan committed rHGbd326f3e0e14: debugformat: update label depending on value difference.
debugformat: update label depending on value difference
Dec 9 2017, 12:28 AM
lothiraldan committed rHGc3e4f196b6e0: debugformat: add a 'debugformat' command.
debugformat: add a 'debugformat' command
Dec 9 2017, 12:28 AM
lothiraldan committed rHG0181f99819d2: upgrade: rename 'removecldeltachain' to 'plain-cl-delta'.
upgrade: rename 'removecldeltachain' to 'plain-cl-delta'
Dec 9 2017, 12:28 AM

Dec 8 2017

lothiraldan updated the diff for D1591: visibility: improve the message when accessing filtered obsolete rev.
Dec 8 2017, 5:14 AM

Dec 7 2017

lothiraldan committed rHG483b5dd0f1aa: push: restrict common discovery to the pushed set.
push: restrict common discovery to the pushed set
Dec 7 2017, 5:43 PM
lothiraldan committed rHGf77121b6bf1b: setdiscover: allow to ignore part of the local graph.
setdiscover: allow to ignore part of the local graph
Dec 7 2017, 5:43 PM
lothiraldan committed rHG67b7e39b441b: largefiles: allow to run 'debugupgraderepo' on repo with largefiles.
largefiles: allow to run 'debugupgraderepo' on repo with largefiles
Dec 7 2017, 5:43 PM
lothiraldan committed rHGad2b35ebf670: upgraderepo: allow extension to register preserved requirements.
upgraderepo: allow extension to register preserved requirements
Dec 7 2017, 5:43 PM

Dec 6 2017

lothiraldan committed rHG44b8b5ad30eb: pull: retrieve bookmarks through the binary part when possible.
pull: retrieve bookmarks through the binary part when possible
Dec 6 2017, 5:27 PM
lothiraldan committed rHGcb4dcd7fabe7: getbundle: add support for 'bookmarks' boolean argument.
getbundle: add support for 'bookmarks' boolean argument
Dec 6 2017, 5:27 PM
lothiraldan committed rHG496154e41968: bundle2: support a 'records' mode for the 'bookmarks' part.
bundle2: support a 'records' mode for the 'bookmarks' part
Dec 6 2017, 5:27 PM
lothiraldan committed rHG1f30cbac34b6: bundle2: add a 'modes' dictionary to the bundle operation.
bundle2: add a 'modes' dictionary to the bundle operation
Dec 6 2017, 5:27 PM
lothiraldan committed rHGa1e70c1dbec0: bookmark: use the 'bookmarks' bundle2 part to push bookmark update (issue5165).
bookmark: use the 'bookmarks' bundle2 part to push bookmark update (issue5165)
Dec 6 2017, 5:27 PM
lothiraldan committed rHGae79d878702b: bookmark: introduce in advance a variant of the exchange test.
bookmark: introduce in advance a variant of the exchange test
Dec 6 2017, 5:27 PM
lothiraldan committed rHGf392066d127c: bookmark: add pushkey hook compatiblity to the bundle2 part.
bookmark: add pushkey hook compatiblity to the bundle2 part
Dec 6 2017, 5:27 PM
lothiraldan committed rHG3fd5f05a5b87: push: move bundle2-pushkey based bookmarks exchange in its own function.
push: move bundle2-pushkey based bookmarks exchange in its own function
Dec 6 2017, 5:27 PM
lothiraldan committed rHGaf5507203d01: bookmark: introduce a 'bookmarks' part.
bookmark: introduce a 'bookmarks' part
Dec 6 2017, 5:27 PM
lothiraldan committed rHGad5f2b923b0d: push: include a 'check:bookmarks' part when possible.
push: include a 'check:bookmarks' part when possible
Dec 6 2017, 5:27 PM
lothiraldan committed rHGdbf868623daf: bookmark: add a 'check:bookmarks' bundle2 part.
bookmark: add a 'check:bookmarks' bundle2 part
Dec 6 2017, 5:27 PM
lothiraldan committed rHG3340d46a5c3f: bookmark: add methods to binary encode and decode bookmark values.
bookmark: add methods to binary encode and decode bookmark values
Dec 6 2017, 5:27 PM
lothiraldan updated the diff for D1591: visibility: improve the message when accessing filtered obsolete rev.
Dec 6 2017, 12:48 PM
lothiraldan added a comment to D1591: visibility: improve the message when accessing filtered obsolete rev.

After thinking more about your proposition, I also think that would be a nice improvement. This way we won't pollute the line helping people to access it anyway.

Dec 6 2017, 11:03 AM
lothiraldan added inline comments to D1285: repoview: add a new attribute _visibilityexceptions and related API.
Dec 6 2017, 4:49 AM
lothiraldan added inline comments to D1591: visibility: improve the message when accessing filtered obsolete rev.
Dec 6 2017, 4:32 AM

Dec 5 2017

lothiraldan closed D1592: test: fix bad replace for fixing pure-only build.
Dec 5 2017, 3:32 PM
lothiraldan committed rHG4a6c51f5ae4d: test: fix bad replace for fixing pure-only build.
test: fix bad replace for fixing pure-only build
Dec 5 2017, 3:32 PM
lothiraldan committed rHGf0445eea9b93: test: fix common-pattern for pure variant.
test: fix common-pattern for pure variant
Dec 5 2017, 3:32 PM