lothiraldan (Boris Feld)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2017, 12:05 PM (49 w, 3 d)

Recent Activity

Thu, Jun 21

lothiraldan committed rHG35b50237908b: configitem: reorder items in the 'server' section.
configitem: reorder items in the 'server' section
Thu, Jun 21, 7:55 AM

Sat, Jun 16

lothiraldan committed rHG2313a3599e41: shelve: wider check for successful abort in test.
shelve: wider check for successful abort in test
Sat, Jun 16, 4:24 PM
lothiraldan closed D3686: shelve: wider check for successful abort in test.
Sat, Jun 16, 4:24 PM
lothiraldan committed rHG756a7682837f: shelve: use full hash in tests.
shelve: use full hash in tests
Sat, Jun 16, 4:24 PM
lothiraldan closed D3685: shelve: use full hash in tests.
Sat, Jun 16, 4:24 PM

Fri, Jun 15

lothiraldan accepted D3734: scmutil: move construction of instability count message to separate fn.
Fri, Jun 15, 3:54 AM

Wed, Jun 13

lothiraldan added a comment to D3694: shelve: use more accurate description in conflict marker.

How much work is this, do you have any idea?

The first option (adding "reserved" phase) should be very quick to implement. It might need minor adjustment for performance but I don't expect many.

The second option (changing all algorithm to handle the gap) is more work since about all algorithm touching phases in Core and extensions assume they can be handled as a simple list.

So I would pick the first option.

When I was discussing this with spectral the idea of an archived phase came up. The fact that we've got two new phases at top of mind in the space of a week convinces me we should reserve *much* more than just one or two slots in the phase numbering space. I'd really like to get this work landed, so I'd be happy to help.

(I'm off work next week, but could probably offer some time the following week.)

Wed, Jun 13, 12:05 PM
lothiraldan added a comment to D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API).

I'm in favor, but feel like I've got enough conflict of interest I shouldn't land the patches.

@smf @lothiraldan this might be of interest to both of you?

Wed, Jun 13, 11:59 AM

Tue, Jun 12

lothiraldan closed D3721: run-tests: restrict the test cases allowed characters.
Tue, Jun 12, 11:42 PM
lothiraldan committed rHGb5651ae53127: run-tests: restrict the test cases allowed characters.
run-tests: restrict the test cases allowed characters
Tue, Jun 12, 11:42 PM
lothiraldan added a comment to D3700: run-tests: add support for external test result.

I see some what, but not any why. Why is this useful?

Tue, Jun 12, 5:11 PM
lothiraldan updated the diff for D3701: run-tests: extract onStart and onEnd into the test result.
Tue, Jun 12, 5:05 PM
lothiraldan updated the diff for D3700: run-tests: add support for external test result.
Tue, Jun 12, 5:05 PM
lothiraldan created D3721: run-tests: restrict the test cases allowed characters.
Tue, Jun 12, 5:05 PM
lothiraldan added a comment to D3699: run-tests: follow-up on the test-case format.
In D3699#58174, @yuja wrote:

> test-run-tests.t:1669
> + --- $TESTTMP/anothertests/cases/test-cases-advanced-cases.t
> + +++ $TESTTMP/anothertests/cases/test-cases-advanced-cases.t.casewith!@#$%^&*()chars.err
> + @@ -1,3 +1,3 @@

Windows can't create the test directory with all of the reserved characters here. Are these necessary?

Maybe no? I think alphanumerics + '-' should be enough, and allowing shell
meta characters is potentially unsafe.

Tue, Jun 12, 4:45 PM
lothiraldan added a comment to D3694: shelve: use more accurate description in conflict marker.

Interesting. I think I like this, it's a bummer that it requires a format bump in requires.

  • There are no format changes per-se, older client would preserve the phases for internal changesets, but have them visible,

We didn't do a format bump when we introduced draft/secret phases, so maybe we should punt here too.

Tue, Jun 12, 12:16 PM
lothiraldan committed rHG99188a7c8717: statprof: fix save and load.
statprof: fix save and load
Tue, Jun 12, 8:26 AM
lothiraldan committed rHG9df777d7f061: perftemplating: abort on incompatible version.
perftemplating: abort on incompatible version
Tue, Jun 12, 8:26 AM

Mon, Jun 11

lothiraldan added a comment to D3694: shelve: use more accurate description in conflict marker.

Interesting. I think I like this, it's a bummer that it requires a format bump in requires.

Mon, Jun 11, 10:41 AM
lothiraldan committed rHG15a1e37f80bd: profiling: introduce a "profiling.time-track" option.
profiling: introduce a "profiling.time-track" option
Mon, Jun 11, 8:30 AM
lothiraldan committed rHGae6e02fcee24: perftemplating: allow to specify the template to test.
perftemplating: allow to specify the template to test
Mon, Jun 11, 8:30 AM
lothiraldan committed rHGaf402c6b90db: statprof: also gather wall time.
statprof: also gather wall time
Mon, Jun 11, 8:30 AM
lothiraldan committed rHGa577a199983c: perftemplating: stop going through the log command.
perftemplating: stop going through the log command
Mon, Jun 11, 8:30 AM
lothiraldan committed rHGb8f75bc9f623: perftemplating: move revision argument to flag only.
perftemplating: move revision argument to flag only
Mon, Jun 11, 8:30 AM
lothiraldan committed rHG71d59b487d0c: perftemplating: drop usage of buffer.
perftemplating: drop usage of buffer
Mon, Jun 11, 8:30 AM
lothiraldan committed rHG6b91815fcdce: perftemplating: move template formating into its own function.
perftemplating: move template formating into its own function
Mon, Jun 11, 8:30 AM
lothiraldan committed rHG1b121cc680f2: perftemplating: fix the revisions argument.
perftemplating: fix the revisions argument
Mon, Jun 11, 8:30 AM

Fri, Jun 8

lothiraldan committed rHGd0abd7949ea3: phases: use "published" in the phase movement message.
phases: use "published" in the phase movement message
Fri, Jun 8, 2:19 PM
lothiraldan committed rHG1e9c357d3ddf: phase: clarify the message about movement on command changeset.
phase: clarify the message about movement on command changeset
Fri, Jun 8, 2:19 PM

Thu, Jun 7

lothiraldan closed D3699: run-tests: follow-up on the test-case format.
Thu, Jun 7, 7:48 PM
lothiraldan committed rHGf2e3196a34f9: run-tests: follow-up on the test-case format.
run-tests: follow-up on the test-case format
Thu, Jun 7, 7:48 PM
lothiraldan created D3701: run-tests: extract onStart and onEnd into the test result.
Thu, Jun 7, 3:19 PM
lothiraldan added a dependent revision for D3700: run-tests: add support for external test result: D3701: run-tests: extract onStart and onEnd into the test result.
Thu, Jun 7, 3:19 PM
lothiraldan created D3700: run-tests: add support for external test result.
Thu, Jun 7, 3:19 PM
lothiraldan created D3699: run-tests: follow-up on the test-case format.
Thu, Jun 7, 3:19 PM
lothiraldan added a dependent revision for D3699: run-tests: follow-up on the test-case format: D3700: run-tests: add support for external test result.
Thu, Jun 7, 3:19 PM
lothiraldan added a comment to D3684: shelve: merge in obsshelve changes implemented at facebook.

We have an implementation of shelve without strip nor obsmarkers.

Can we see that now? Otherwise I'm going to lobby to land this in the name of having something done.

Thu, Jun 7, 10:18 AM

Tue, Jun 5

lothiraldan added a comment to D3684: shelve: merge in obsshelve changes implemented at facebook.

After reading your obsshelve series, it seems that we have some overlap.

Tue, Jun 5, 3:21 PM
lothiraldan added a comment to D3684: shelve: merge in obsshelve changes implemented at facebook.

We just sent https://phab.mercurial-scm.org/D3685 that update shelve to not use rebase anymore.

Tue, Jun 5, 6:59 AM
lothiraldan created D3694: shelve: use more accurate description in conflict marker.
Tue, Jun 5, 6:58 AM
lothiraldan created D3693: shelve: directly handle the initial parent alignment.
Tue, Jun 5, 6:58 AM
lothiraldan created D3692: merge: add a 'keepconflictparent' argument to graft.
Tue, Jun 5, 6:58 AM
lothiraldan added a dependent revision for D3692: merge: add a 'keepconflictparent' argument to graft: D3693: shelve: directly handle the initial parent alignment.
Tue, Jun 5, 6:58 AM
lothiraldan added a dependent revision for D3691: shelve: stop testing missing rebase state file: D3692: merge: add a 'keepconflictparent' argument to graft.
Tue, Jun 5, 6:58 AM
lothiraldan created D3691: shelve: stop testing missing rebase state file.
Tue, Jun 5, 6:58 AM
lothiraldan added a dependent revision for D3690: shelve: actually test corrupted shelve state: D3691: shelve: stop testing missing rebase state file.
Tue, Jun 5, 6:57 AM
lothiraldan created D3690: shelve: actually test corrupted shelve state.
Tue, Jun 5, 6:57 AM
lothiraldan created D3689: shelve: directly handle `--continue`.
Tue, Jun 5, 6:57 AM
lothiraldan added a dependent revision for D3689: shelve: directly handle `--continue`: D3690: shelve: actually test corrupted shelve state.
Tue, Jun 5, 6:57 AM
lothiraldan added a dependent revision for D3688: shelve: directly handle the abort process: D3689: shelve: directly handle `--continue`.
Tue, Jun 5, 6:57 AM
lothiraldan created D3687: shelve: check the actual shelvestate in morestatus.
Tue, Jun 5, 6:56 AM
lothiraldan created D3688: shelve: directly handle the abort process.
Tue, Jun 5, 6:56 AM
lothiraldan added a dependent revision for D3687: shelve: check the actual shelvestate in morestatus: D3688: shelve: directly handle the abort process.
Tue, Jun 5, 6:56 AM
lothiraldan added a dependent revision for D3686: shelve: wider check for successful abort in test: D3687: shelve: check the actual shelvestate in morestatus.
Tue, Jun 5, 6:56 AM
lothiraldan created D3686: shelve: wider check for successful abort in test.
Tue, Jun 5, 6:56 AM
lothiraldan added a dependent revision for D3685: shelve: use full hash in tests: D3686: shelve: wider check for successful abort in test.
Tue, Jun 5, 6:56 AM
lothiraldan created D3685: shelve: use full hash in tests.
Tue, Jun 5, 6:56 AM

Mon, Jun 4

lothiraldan closed D3556: run-tests: update the test case name format.
Mon, Jun 4, 6:34 PM
lothiraldan closed D3555: run-tests: add support for running specific test cases.
Mon, Jun 4, 6:34 PM
lothiraldan committed rHGb865bba56db1: run-tests: update the test case name format.
run-tests: update the test case name format
Mon, Jun 4, 6:33 PM
lothiraldan committed rHG507bdc40bb17: run-tests: add support for running specific test cases.
run-tests: add support for running specific test cases
Mon, Jun 4, 6:33 PM

Sat, May 26

lothiraldan committed rHG4e790f0966fc: phases: define an official tuple of phases we do not share.
phases: define an official tuple of phases we do not share
Sat, May 26, 12:28 AM
lothiraldan committed rHG02f992ac26e9: phases: define an official tuple of mutable phases.
phases: define an official tuple of mutable phases
Sat, May 26, 12:28 AM
lothiraldan committed rHG5b592ac502ef: repoview: use 'phasecache.getrevset' when computing 'unserved' filter.
repoview: use 'phasecache.getrevset' when computing 'unserved' filter
Sat, May 26, 12:28 AM

Fri, May 25

lothiraldan committed rHG93ec01ba39bd: phases: define an official tuple of phases we do not share.
phases: define an official tuple of phases we do not share
Fri, May 25, 9:26 PM
lothiraldan committed rHG797064fef9e6: phases: define an official tuple of mutable phases.
phases: define an official tuple of mutable phases
Fri, May 25, 9:26 PM
lothiraldan committed rHG5ce27b00c7cc: repoview: use 'phasecache.getrevset' when computing 'unserved' filter.
repoview: use 'phasecache.getrevset' when computing 'unserved' filter
Fri, May 25, 9:26 PM

May 22 2018

lothiraldan committed rHG13b2812cff2b: httppeer: declare 'dbg' at the function level.
httppeer: declare 'dbg' at the function level
May 22 2018, 8:06 AM
lothiraldan committed rHG307c770da188: httppeer: declare 'dgb' at the function level.
httppeer: declare 'dgb' at the function level
May 22 2018, 7:55 AM
lothiraldan committed rHGf9dc1d5b676b: httppeer: properly gate debug usage behind debug flag check.
httppeer: properly gate debug usage behind debug flag check
May 22 2018, 7:55 AM
lothiraldan added a comment to D3556: run-tests: update the test case name format.

I fixed the issue, it was a last minute style fix that turns out to not be equivalent to the previous code.

May 22 2018, 7:51 AM
lothiraldan updated the diff for D3556: run-tests: update the test case name format.
May 22 2018, 7:48 AM
lothiraldan updated the diff for D3555: run-tests: add support for running specific test cases.
May 22 2018, 7:48 AM

May 14 2018

lothiraldan added a comment to D3532: wireprotov2: define and implement "rawstorefile" command.

First, thank you for your work on the new wire protocol.

May 14 2018, 4:56 AM

May 13 2018

lothiraldan created D3556: run-tests: update the test case name format.
May 13 2018, 5:28 PM
lothiraldan created D3555: run-tests: add support for running specific test cases.
May 13 2018, 5:28 PM
lothiraldan added a dependent revision for D3555: run-tests: add support for running specific test cases: D3556: run-tests: update the test case name format.
May 13 2018, 5:28 PM

May 8 2018

lothiraldan closed D3481: rev-branch-cache: mark the bundle2 part as advisory (issue5872).
May 8 2018, 5:21 PM
lothiraldan closed D3480: debugbundle: also display if a part is mandatory or advisory.
May 8 2018, 5:21 PM
lothiraldan committed rHG326b174c6a47: bundle2: mark the bundle2 part as advisory (issue5872).
bundle2: mark the bundle2 part as advisory (issue5872)
May 8 2018, 5:20 PM
lothiraldan committed rHGd618558e4e8b: debugbundle: also display if a part is mandatory or advisory.
debugbundle: also display if a part is mandatory or advisory
May 8 2018, 5:20 PM
lothiraldan created D3481: rev-branch-cache: mark the bundle2 part as advisory (issue5872).
May 8 2018, 6:50 AM
lothiraldan created D3480: debugbundle: also display if a part is mandatory or advisory.
May 8 2018, 6:50 AM
lothiraldan added a dependent revision for D3480: debugbundle: also display if a part is mandatory or advisory: D3481: rev-branch-cache: mark the bundle2 part as advisory (issue5872).
May 8 2018, 6:49 AM
lothiraldan added a comment to D3479: update: print warning about hidden changeset after update.

Does it means that someone that try to update to a hidden changeset with a dirty conflicting workdir will first need to solve the conflict before seeing that the changeset is hidden and that it could be potentially the source of the conflict?

May 8 2018, 5:04 AM

May 7 2018

lothiraldan accepted D3446: dispatch: move sys.exit() to caller (API).
May 7 2018, 3:11 AM

May 2 2018

lothiraldan added a comment to D3419: interfaceutil: module to stub out zope.interface.

We saw a ~15ms regression hit on our performance benchmark for the incoming test between 4.5.3 and 4.6rc0. This regression is ~30ms when the test is over ssh.

May 2 2018, 9:53 AM

Apr 30 2018

lothiraldan added a comment to D3419: interfaceutil: module to stub out zope.interface.

We also detected the regression in 4.6rc0 (http://perf.octobus.net/#basic_commands.DiscoveryTimeSuite.time_debugdiscovery?branch=stable) and can confirm locally that half the regression is fixed on stable (e82b137a8b4e).

Apr 30 2018, 11:52 AM

Apr 24 2018

lothiraldan committed rHG58bbd14b0c62: sshpeer: reflect actual command activity one handshake.
sshpeer: reflect actual command activity one handshake
Apr 24 2018, 7:07 AM

Apr 19 2018

lothiraldan committed rHG68748c2c761b: notify: only notify for non-filtered revision.
notify: only notify for non-filtered revision
Apr 19 2018, 7:24 AM
lothiraldan committed rHG04d648b53e3e: notify: access the initial revision on an unfiltered repository (issue5821).
notify: access the initial revision on an unfiltered repository (issue5821)
Apr 19 2018, 7:24 AM
lothiraldan committed rHGa07fab68621f: notify: use changelog API to iterate over revision number (issue5821).
notify: use changelog API to iterate over revision number (issue5821)
Apr 19 2018, 7:24 AM

Apr 17 2018

lothiraldan accepted D3392: bundlespec: drop externalnames flag.

LGTM, thanks for the much needed cleanup

Apr 17 2018, 9:57 AM
lothiraldan added a comment to D3212: patch: implement a new worddiff algorithm.
In D3212#52767, @quark wrote:

Apr 17 2018, 8:57 AM
lothiraldan committed rHG29eb4cafeeb8: revset: skip legacy lookup for revspec wrapped in 'revset(...)'.
revset: skip legacy lookup for revspec wrapped in 'revset(...)'
Apr 17 2018, 8:00 AM
lothiraldan committed rHGaa3f63e02c3c: revset: add more test to show current behaviors with label looking like revset.
revset: add more test to show current behaviors with label looking like revset
Apr 17 2018, 8:00 AM
lothiraldan added inline comments to D2880: bundle: add the possibility to bundle bookmarks (issue5792).
Apr 17 2018, 3:41 AM

Apr 14 2018

lothiraldan added inline comments to D2880: bundle: add the possibility to bundle bookmarks (issue5792).
Apr 14 2018, 5:40 AM
lothiraldan updated the diff for D2880: bundle: add the possibility to bundle bookmarks (issue5792).
Apr 14 2018, 5:39 AM

Apr 12 2018

lothiraldan added a comment to D2880: bundle: add the possibility to bundle bookmarks (issue5792).

What's the status of this patch? Is it still reviewable? If so, let's get a rebased version submitted, just in case things have changed.

Apr 12 2018, 1:47 PM