Page MenuHomePhabricator

lothiraldan (Boris Feld)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2017, 12:05 PM (100 w, 4 d)

Recent Activity

Wed, Jun 12

lothiraldan added a comment to D6122: tests: add a file listing all the flaky tests.
In D6122#89819, @av6 wrote:

@av6 is a --no-flaky-tests flag what you had in mind?

Something like that, yes. I suggested that flag seeing how this change introduces a quite specific file with just one line. And I thought "if it's important, let's integrate it deeper into the test runner".
But a flag for run-tests.py is not the only alternative. Now that I think about #require, can ​test-remotefilelog-bgprefetch.t be marked with #require not-an-exotic-fs-inside-docker (or whatever the actual thing that causes flakiness if it's known)? hghave.py already checks various filesystem features, why not make it check for the cause of issue6083?

For this specific test, we are not sure that it's the exact issue, it's our best lead. I'm afraid that identifying the underlying cause will be 90% of the work fixing it.
My goal is to allow people running tests outside our buildbot and gcc build farm to being able to quickly identify which test error are expected or not. And for CI setups, we want the flaky test to not impact the return code as it would makes the build fails in most of CI setups.
Identifying the root cause of the issue is a problem that takes time and expertise, the docker exotic fs lead is actually from @durin42, I would have not guessed it. I would like to find a way for people to report that a test is flaky on their setup without requiring them to dig too deep in the issue.
I would be ok with the --no-flaky-tests flag, even if I found the #require flaky a bit confusing.

Wed, Jun 12, 5:38 AM

Apr 27 2019

lothiraldan committed rHG3267aca2ec7e: revsetbenchmark: track some simple use of "only".
revsetbenchmark: track some simple use of "only"
Apr 27 2019, 6:28 AM

Mar 22 2019

lothiraldan updated subscribers of D6122: tests: add a file listing all the flaky tests.
In D6122#89819, @av6 wrote:

@av6 is a --no-flaky-tests flag what you had in mind?

Something like that, yes. I suggested that flag seeing how this change introduces a quite specific file with just one line. And I thought "if it's important, let's integrate it deeper into the test runner".
But a flag for run-tests.py is not the only alternative. Now that I think about #require, can ​test-remotefilelog-bgprefetch.t be marked with #require not-an-exotic-fs-inside-docker (or whatever the actual thing that causes flakiness if it's known)? hghave.py already checks various filesystem features, why not make it check for the cause of issue6083?

Mar 22 2019, 5:22 AM

Mar 21 2019

lothiraldan added a comment to D6122: tests: add a file listing all the flaky tests.

The big difference between #require slow and #require flaky is that we don't want to run the slow tests by default but we want to run the flaky test by default if not specified otherwise. I don't know enough about the test runner to evaluate the amount of work need to support a --no-flaky-tests flag,

Mar 21 2019, 7:52 AM

Mar 18 2019

lothiraldan added a comment to D6147: discovery: move cl.hasnode outside of the for-loop.

The series looks good to me after a very quick review. I think a more in-deep review will be necessary.

Mar 18 2019, 5:28 AM

Mar 16 2019

lothiraldan closed D5955: watchman: ignore some of watchman errors.
Mar 16 2019, 7:57 PM
lothiraldan closed D5954: watchman: add the possibility to set the exact watchman binary location.
Mar 16 2019, 7:57 PM
lothiraldan committed rHG76361969662a: watchman: ignore some of watchman errors.
watchman: ignore some of watchman errors
Mar 16 2019, 7:57 PM
lothiraldan committed rHG57264906a996: watchman: add the possibility to set the exact watchman binary location.
watchman: add the possibility to set the exact watchman binary location
Mar 16 2019, 7:57 PM

Mar 12 2019

lothiraldan added a comment to D6122: tests: add a file listing all the flaky tests.
In D6122#89169, @av6 wrote:

Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can #require flaky or even mark a specific block with #if flaky. Obviously fixing ​test-remotefilelog-bgprefetch.t is a better idea altogether, but I'm not going to claim that it's easy.

Mar 12 2019, 2:11 PM
lothiraldan created D6122: tests: add a file listing all the flaky tests.
Mar 12 2019, 5:58 AM

Feb 27 2019

lothiraldan committed rHG00c909de1143: test: follow-up on 1c4d6ab2ecb8, stabilize test-remotefilelog-bgprefetch.t.
test: follow-up on 1c4d6ab2ecb8, stabilize test-remotefilelog-bgprefetch.t
Feb 27 2019, 7:50 PM
lothiraldan accepted D6028: branchmap: prevent reading the file twice through different iterators.

Queued thanks, the test now pass both locally and on gcc112. @yuja nice catch!

Feb 27 2019, 4:52 AM
lothiraldan added a comment to D5955: watchman: ignore some of watchman errors.

Gentle ping on this series

Feb 27 2019, 4:47 AM

Feb 25 2019

lothiraldan committed rHG64de5f44eec3: rewriting: add an option for rewrite commands to use the archived phase.
rewriting: add an option for rewrite commands to use the archived phase
Feb 25 2019, 9:29 PM
lothiraldan committed rHG8c42b4a3d447: strip: introduce a soft strip option.
strip: introduce a soft strip option
Feb 25 2019, 9:29 PM
lothiraldan accepted D6023: branchcache: move loading of branch names and nodes into it's own function.

LGTM, queued thanks

Feb 25 2019, 1:20 PM

Feb 21 2019

lothiraldan committed rHG0ae89ab3f025: test: stabilize test-run-tests.t output.
test: stabilize test-run-tests.t output
Feb 21 2019, 12:24 PM
lothiraldan committed rHG1c4d6ab2ecb8: test: stabilize test-remotefilelog-bgprefetch.t flaky output.
test: stabilize test-remotefilelog-bgprefetch.t flaky output
Feb 21 2019, 12:24 PM

Feb 20 2019

lothiraldan committed rHGd8ac04c3c74d: test: stabilize test-run-tests.t output.
test: stabilize test-run-tests.t output
Feb 20 2019, 3:31 PM
lothiraldan committed rHG4cb2ac16d9af: test: stabilize test-remotefilelog-bgprefetch.t flaky output.
test: stabilize test-remotefilelog-bgprefetch.t flaky output
Feb 20 2019, 3:31 PM
lothiraldan closed D5966: test: stabilize test-run-tests.t output.
Feb 20 2019, 3:16 PM
lothiraldan committed rHG4618bdf75d8a: test: stabilize test-run-tests.t output.
test: stabilize test-run-tests.t output
Feb 20 2019, 3:16 PM
lothiraldan committed rHG5b6ee1b16f9a: test: stabilize test-remotefilelog-bgprefetch.t flaky output.
test: stabilize test-remotefilelog-bgprefetch.t flaky output
Feb 20 2019, 3:16 PM
lothiraldan closed D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output.
Feb 20 2019, 3:16 PM
lothiraldan updated subscribers of D5955: watchman: ignore some of watchman errors.

@indygreg I've update the patchs with your reviews.

Feb 20 2019, 4:38 AM

Feb 19 2019

lothiraldan added inline comments to D5966: test: stabilize test-run-tests.t output.
Feb 19 2019, 1:29 PM
lothiraldan added a comment to D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output.

Huh. That's strictly a bug, as debugwaitonrepack should actually be waiting.

I've created a ticket to track it: https://phab.mercurial-scm.org/D5960
Do you have any idea what could be happening?

I've never seen this failure, so I'm suspicious of your test environment. Is there anything exotic, perhaps at the filesystem level?

Feb 19 2019, 1:27 PM

Feb 18 2019

lothiraldan added a comment to D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output.

Huh. That's strictly a bug, as debugwaitonrepack should actually be waiting.

Feb 18 2019, 5:03 AM
lothiraldan added inline comments to D5966: test: stabilize test-run-tests.t output.
Feb 18 2019, 4:29 AM

Feb 15 2019

lothiraldan accepted D5968: obsutil: don't assume leftctx and rightctx repo as same.

LGTM, nice catch! Could you add a comment to clarify it?

Feb 15 2019, 11:18 AM

Feb 14 2019

lothiraldan abandoned D5965: test: stabilize test-run-tests.t output.

Replaced by https://phab.mercurial-scm.org/D5966

Feb 14 2019, 10:54 AM
lothiraldan created D5966: test: stabilize test-run-tests.t output.
Feb 14 2019, 9:40 AM
lothiraldan created D5965: test: stabilize test-run-tests.t output.
Feb 14 2019, 9:38 AM
lothiraldan created D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output.
Feb 14 2019, 9:07 AM

Feb 13 2019

lothiraldan abandoned D5590: watchman: ignore some of watchman errors.

Resent as D5955

Feb 13 2019, 11:23 AM
lothiraldan abandoned D5589: watchman: add the possibility to set the exact watchman binary location.

Resent as D5954

Feb 13 2019, 11:23 AM
lothiraldan abandoned D5588: watchman: disable fsmonitor when running non-interactively.
Feb 13 2019, 11:22 AM
lothiraldan created D5955: watchman: ignore some of watchman errors.
Feb 13 2019, 11:22 AM
lothiraldan created D5954: watchman: add the possibility to set the exact watchman binary location.
Feb 13 2019, 11:22 AM
lothiraldan updated the diff for D5587: watchman: detect nested mercurial repositories and abort.
Feb 13 2019, 11:20 AM
lothiraldan updated the diff for D5590: watchman: ignore some of watchman errors.
Feb 13 2019, 11:18 AM
lothiraldan updated the diff for D5589: watchman: add the possibility to set the exact watchman binary location.
Feb 13 2019, 11:18 AM
lothiraldan updated the diff for D5589: watchman: add the possibility to set the exact watchman binary location.
Feb 13 2019, 10:03 AM
lothiraldan updated the diff for D5590: watchman: ignore some of watchman errors.
Feb 13 2019, 10:03 AM
lothiraldan updated the diff for D5588: watchman: disable fsmonitor when running non-interactively.
Feb 13 2019, 10:03 AM

Feb 12 2019

lothiraldan closed D5897: test: stabilize test-wireproto-exchangev2.t flaky output.
Feb 12 2019, 2:06 PM
lothiraldan committed rHG1ab6f5df263e: test: stabilize test-wireproto-exchangev2.t flaky output.
test: stabilize test-wireproto-exchangev2.t flaky output
Feb 12 2019, 2:06 PM

Feb 9 2019

lothiraldan committed rHG2306158314e9: test: use `printenv.py --line` in `test-static-http.t`.
test: use `printenv.py --line` in `test-static-http.t`
Feb 9 2019, 6:19 PM
lothiraldan committed rHG616ef3db5a90: test: use `printenv.py --line` in `test-ssh-bundle1.t`.
test: use `printenv.py --line` in `test-ssh-bundle1.t`
Feb 9 2019, 6:19 PM
lothiraldan committed rHG9a8d41fa919e: test: use `printenv.py --line` in `test-ssh.t`.
test: use `printenv.py --line` in `test-ssh.t`
Feb 9 2019, 6:19 PM
lothiraldan committed rHG7839249e7834: test: use `printenv.py --line` in `test-push-http.t`.
test: use `printenv.py --line` in `test-push-http.t`
Feb 9 2019, 6:19 PM
lothiraldan committed rHGe857dbb02dc3: test: use `printenv.py --line` in `test-https.t`.
test: use `printenv.py --line` in `test-https.t`
Feb 9 2019, 6:19 PM
lothiraldan committed rHGe06d91bc504b: test: use `printenv.py --line` in `test-http-bundle1.t`.
test: use `printenv.py --line` in `test-http-bundle1.t`
Feb 9 2019, 6:19 PM
lothiraldan committed rHGf8443db3032e: test: use `printenv.py --line` in `test-hook.t`.
test: use `printenv.py --line` in `test-hook.t`
Feb 9 2019, 6:19 PM
lothiraldan committed rHGe8a71ed9c373: test: use `printenv.py --line` in `test-bundle2-multiple-changegroups.t`.
test: use `printenv.py --line` in `test-bundle2-multiple-changegroups.t`
Feb 9 2019, 6:19 PM
lothiraldan committed rHG252cc56c9ff6: test: use `printenv.py --line` in `test-bundle.t`.
test: use `printenv.py --line` in `test-bundle.t`
Feb 9 2019, 6:19 PM

Feb 8 2019

lothiraldan created D5897: test: stabilize test-wireproto-exchangev2.t flaky output.
Feb 8 2019, 12:36 PM

Feb 7 2019

lothiraldan closed D5880: fsmonitor: rename new verbose config knob.
Feb 7 2019, 1:07 PM
lothiraldan committed rHG286eeed14893: fsmonitor: rename new verbose config knob.
fsmonitor: rename new verbose config knob
Feb 7 2019, 1:07 PM
lothiraldan added a comment to D5880: fsmonitor: rename new verbose config knob.

Nice catch, sorry for the hasty phabsend

Feb 7 2019, 12:09 PM
lothiraldan updated the diff for D5880: fsmonitor: rename new verbose config knob.
Feb 7 2019, 12:08 PM
lothiraldan created D5880: fsmonitor: rename new verbose config knob.
Feb 7 2019, 11:06 AM

Feb 4 2019

lothiraldan committed rHGeb37d95cc486: py3: use integer division instead of `int(...)` call.
py3: use integer division instead of `int(...)` call
Feb 4 2019, 4:55 PM
lothiraldan committed rHG5125f0a9728b: watchman: detect nested mercurial repositories and abort.
watchman: detect nested mercurial repositories and abort
Feb 4 2019, 4:54 PM
lothiraldan committed rHG18adb747a332: watchman: add verbose config knob.
watchman: add verbose config knob
Feb 4 2019, 4:54 PM
lothiraldan committed rHGd1a273074f62: perf: add a --[no-]clear-caches option to `perfnodemap`.
perf: add a --[no-]clear-caches option to `perfnodemap`
Feb 4 2019, 4:54 PM
lothiraldan committed rHGc9ff93889550: perf: add a perfnodemap command.
perf: add a perfnodemap command
Feb 4 2019, 4:54 PM
lothiraldan committed rHG5718a7dec736: py3: use integer division instead of `int(...)` call.
py3: use integer division instead of `int(...)` call
Feb 4 2019, 6:51 AM

Jan 31 2019

lothiraldan closed D5587: watchman: detect nested mercurial repositories and abort.
Jan 31 2019, 11:34 AM
lothiraldan committed rHG6a7b2d2de124: watchman: detect nested mercurial repositories and abort.
watchman: detect nested mercurial repositories and abort
Jan 31 2019, 11:34 AM
lothiraldan closed D5586: watchman: add verbose config knob.
Jan 31 2019, 11:34 AM
lothiraldan committed rHG158962bf4a52: watchman: add verbose config knob.
watchman: add verbose config knob
Jan 31 2019, 11:34 AM
lothiraldan committed rHG189e06b2d719: revlog: make sure we never use sparserevlog without general delta (issue6056).
revlog: make sure we never use sparserevlog without general delta (issue6056)
Jan 31 2019, 7:12 AM
lothiraldan committed rHG261d37b94d31: sparserevlog: document the config option.
sparserevlog: document the config option
Jan 31 2019, 7:12 AM

Jan 30 2019

lothiraldan committed rHG4a2c8ec90a28: perf: add a --[no-]clear-caches option to `perfnodemap`.
perf: add a --[no-]clear-caches option to `perfnodemap`
Jan 30 2019, 4:27 PM
lothiraldan committed rHG22919858e84c: perf: add a perfnodemap command.
perf: add a perfnodemap command
Jan 30 2019, 4:27 PM

Jan 28 2019

lothiraldan committed rHG7eb7637e34bf: perf: support looking up multiple revisions.
perf: support looking up multiple revisions
Jan 28 2019, 5:20 PM
lothiraldan committed rHGe9891c734bf8: perf: add a no-lookup variant to perfindex.
perf: add a no-lookup variant to perfindex
Jan 28 2019, 5:20 PM
lothiraldan committed rHGd65ba1ff4559: perf: add some documentation to perfindex.
perf: add some documentation to perfindex
Jan 28 2019, 5:20 PM
lothiraldan committed rHGab6d1f82be32: perf: move cache clearing in the `setup` step of `perfheads`.
perf: move cache clearing in the `setup` step of `perfheads`
Jan 28 2019, 5:20 PM
lothiraldan committed rHGe2e815e3c4ae: revlog: document cext oddities in terms of object/caches.
revlog: document cext oddities in terms of object/caches
Jan 28 2019, 5:20 PM
lothiraldan committed rHG48394923fbdc: perf: document perfheads.
perf: document perfheads
Jan 28 2019, 5:20 PM

Jan 24 2019

lothiraldan updated the diff for D5590: watchman: ignore some of watchman errors.
Jan 24 2019, 12:40 PM
lothiraldan updated the diff for D5589: watchman: add the possibility to set the exact watchman binary location.
Jan 24 2019, 12:40 PM
lothiraldan updated the diff for D5588: watchman: disable fsmonitor when running non-interactively.
Jan 24 2019, 12:40 PM
lothiraldan updated the diff for D5587: watchman: detect nested mercurial repositories and abort.
Jan 24 2019, 12:40 PM
lothiraldan updated the diff for D5586: watchman: add verbose config knob.
Jan 24 2019, 12:40 PM
lothiraldan committed rHG76873548b051: partialdiscovery: avoid `undecided` related computation sooner than necessary.
partialdiscovery: avoid `undecided` related computation sooner than necessary
Jan 24 2019, 12:23 PM

Jan 23 2019

lothiraldan added a comment to D5633: grep: use set instead of dict with dummy value.

I get a message stating that one of the hunk of patch failed to apply and couldn't understand what is going on, could you try rebase it to see if you have the issue locally?

Jan 23 2019, 1:16 PM

Jan 19 2019

lothiraldan committed rHGb1ea90613af3: revset: introduce an internal `_rev` predicate for '%d' usage.
revset: introduce an internal `_rev` predicate for '%d' usage
Jan 19 2019, 6:30 AM
lothiraldan added a reverting change for rHG74a9f428227e: mmapindex: set default to 1MB: rHGbf4a078b3f88: mmap: backed out changeset 74a9f428227e.
Jan 19 2019, 6:30 AM
lothiraldan committed rHGbf4a078b3f88: mmap: backed out changeset 74a9f428227e.
mmap: backed out changeset 74a9f428227e
Jan 19 2019, 6:30 AM
lothiraldan committed rHGd82dd55024e7: mmap: backed out changeset 875d2af8cb4e.
mmap: backed out changeset 875d2af8cb4e
Jan 19 2019, 6:30 AM
lothiraldan added a reverting change for rHG875d2af8cb4e: mmapindex: move the 'mmapindexthreshold' option out of experimental: rHGd82dd55024e7: mmap: backed out changeset 875d2af8cb4e.
Jan 19 2019, 6:30 AM

Jan 18 2019

lothiraldan added a comment to D5594: copies: consider nullrev a common ancestor.
In D5594#83078, @yuja wrote:
I've seen many bugs in the git codebase that were caused by it not
having a null revision and being forced to treat root commits
differently. Mercurial has a null revision and I think it's generally
a bug to treat it differently from other commits in graph algorithms.

I agree with that, but I don't think every non-merge revision (p2 = null)
should be considered a direct child of null revision.

@@ -65,8 +63,6 @@

else:
    parents = cl.parentrevs(r)

Here parents[1] may be nullrev. Is that expected?

for p in parents:
  • if p < 0:
  • continue
Jan 18 2019, 8:25 AM
lothiraldan committed rHG593f6359681d: update: fix edge-case with update.atomic-file and read-only files.
update: fix edge-case with update.atomic-file and read-only files
Jan 18 2019, 7:36 AM
lothiraldan accepted D5622: localrepo: use context manager for transaction in commit().

I have the impression that the test changes are due to the previous patch in the stack.

I don't think so. See commit message for why I think they changed.

Jan 18 2019, 1:59 AM

Jan 17 2019

lothiraldan added a comment to D5590: watchman: ignore some of watchman errors.

I don't suppose there's a way to easily test this? I'm guessing not...
The change seems reasonable though.

Jan 17 2019, 11:47 AM
lothiraldan added inline comments to D5589: watchman: add the possibility to set the exact watchman binary location.
Jan 17 2019, 11:46 AM