lothiraldan (Boris Feld)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2017, 12:05 PM (83 w, 6 d)

Recent Activity

Today

lothiraldan added a comment to D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output.

Huh. That's strictly a bug, as debugwaitonrepack should actually be waiting.

Mon, Feb 18, 5:03 AM
lothiraldan added inline comments to D5966: test: stabilize test-run-tests.t output.
Mon, Feb 18, 4:29 AM

Fri, Feb 15

lothiraldan accepted D5968: obsutil: don't assume leftctx and rightctx repo as same.

LGTM, nice catch! Could you add a comment to clarify it?

Fri, Feb 15, 11:18 AM

Thu, Feb 14

lothiraldan abandoned D5965: test: stabilize test-run-tests.t output.

Replaced by https://phab.mercurial-scm.org/D5966

Thu, Feb 14, 10:54 AM
lothiraldan created D5966: test: stabilize test-run-tests.t output.
Thu, Feb 14, 9:40 AM
lothiraldan created D5965: test: stabilize test-run-tests.t output.
Thu, Feb 14, 9:38 AM
lothiraldan created D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output.
Thu, Feb 14, 9:07 AM

Wed, Feb 13

lothiraldan abandoned D5590: watchman: ignore some of watchman errors.

Resent as D5955

Wed, Feb 13, 11:23 AM
lothiraldan abandoned D5589: watchman: add the possibility to set the exact watchman binary location.

Resent as D5954

Wed, Feb 13, 11:23 AM
lothiraldan abandoned D5588: watchman: disable fsmonitor when running non-interactively.
Wed, Feb 13, 11:22 AM
lothiraldan created D5955: watchman: ignore some of watchman errors.
Wed, Feb 13, 11:22 AM
lothiraldan created D5954: watchman: add the possibility to set the exact watchman binary location.
Wed, Feb 13, 11:22 AM
lothiraldan added a dependent revision for D5954: watchman: add the possibility to set the exact watchman binary location: D5955: watchman: ignore some of watchman errors.
Wed, Feb 13, 11:22 AM
lothiraldan updated the diff for D5587: watchman: detect nested mercurial repositories and abort.
Wed, Feb 13, 11:20 AM
lothiraldan updated the diff for D5590: watchman: ignore some of watchman errors.
Wed, Feb 13, 11:18 AM
lothiraldan updated the diff for D5589: watchman: add the possibility to set the exact watchman binary location.
Wed, Feb 13, 11:18 AM
lothiraldan updated the diff for D5589: watchman: add the possibility to set the exact watchman binary location.
Wed, Feb 13, 10:03 AM
lothiraldan updated the diff for D5590: watchman: ignore some of watchman errors.
Wed, Feb 13, 10:03 AM
lothiraldan updated the diff for D5588: watchman: disable fsmonitor when running non-interactively.
Wed, Feb 13, 10:03 AM

Tue, Feb 12

lothiraldan closed D5897: test: stabilize test-wireproto-exchangev2.t flaky output.
Tue, Feb 12, 2:06 PM
lothiraldan committed rHG1ab6f5df263e: test: stabilize test-wireproto-exchangev2.t flaky output.
test: stabilize test-wireproto-exchangev2.t flaky output
Tue, Feb 12, 2:06 PM

Sat, Feb 9

lothiraldan committed rHG2306158314e9: test: use `printenv.py --line` in `test-static-http.t`.
test: use `printenv.py --line` in `test-static-http.t`
Sat, Feb 9, 6:19 PM
lothiraldan committed rHG616ef3db5a90: test: use `printenv.py --line` in `test-ssh-bundle1.t`.
test: use `printenv.py --line` in `test-ssh-bundle1.t`
Sat, Feb 9, 6:19 PM
lothiraldan committed rHG9a8d41fa919e: test: use `printenv.py --line` in `test-ssh.t`.
test: use `printenv.py --line` in `test-ssh.t`
Sat, Feb 9, 6:19 PM
lothiraldan committed rHG7839249e7834: test: use `printenv.py --line` in `test-push-http.t`.
test: use `printenv.py --line` in `test-push-http.t`
Sat, Feb 9, 6:19 PM
lothiraldan committed rHGe857dbb02dc3: test: use `printenv.py --line` in `test-https.t`.
test: use `printenv.py --line` in `test-https.t`
Sat, Feb 9, 6:19 PM
lothiraldan committed rHGe06d91bc504b: test: use `printenv.py --line` in `test-http-bundle1.t`.
test: use `printenv.py --line` in `test-http-bundle1.t`
Sat, Feb 9, 6:19 PM
lothiraldan committed rHGf8443db3032e: test: use `printenv.py --line` in `test-hook.t`.
test: use `printenv.py --line` in `test-hook.t`
Sat, Feb 9, 6:19 PM
lothiraldan committed rHGe8a71ed9c373: test: use `printenv.py --line` in `test-bundle2-multiple-changegroups.t`.
test: use `printenv.py --line` in `test-bundle2-multiple-changegroups.t`
Sat, Feb 9, 6:19 PM
lothiraldan committed rHG252cc56c9ff6: test: use `printenv.py --line` in `test-bundle.t`.
test: use `printenv.py --line` in `test-bundle.t`
Sat, Feb 9, 6:19 PM

Fri, Feb 8

lothiraldan created D5897: test: stabilize test-wireproto-exchangev2.t flaky output.
Fri, Feb 8, 12:36 PM

Thu, Feb 7

lothiraldan closed D5880: fsmonitor: rename new verbose config knob.
Thu, Feb 7, 1:07 PM
lothiraldan committed rHG286eeed14893: fsmonitor: rename new verbose config knob.
fsmonitor: rename new verbose config knob
Thu, Feb 7, 1:07 PM
lothiraldan added a comment to D5880: fsmonitor: rename new verbose config knob.

Nice catch, sorry for the hasty phabsend

Thu, Feb 7, 12:09 PM
lothiraldan updated the diff for D5880: fsmonitor: rename new verbose config knob.
Thu, Feb 7, 12:08 PM
lothiraldan created D5880: fsmonitor: rename new verbose config knob.
Thu, Feb 7, 11:06 AM

Mon, Feb 4

lothiraldan committed rHGeb37d95cc486: py3: use integer division instead of `int(...)` call.
py3: use integer division instead of `int(...)` call
Mon, Feb 4, 4:55 PM
lothiraldan committed rHG5125f0a9728b: watchman: detect nested mercurial repositories and abort.
watchman: detect nested mercurial repositories and abort
Mon, Feb 4, 4:54 PM
lothiraldan committed rHG18adb747a332: watchman: add verbose config knob.
watchman: add verbose config knob
Mon, Feb 4, 4:54 PM
lothiraldan committed rHGd1a273074f62: perf: add a --[no-]clear-caches option to `perfnodemap`.
perf: add a --[no-]clear-caches option to `perfnodemap`
Mon, Feb 4, 4:54 PM
lothiraldan committed rHGc9ff93889550: perf: add a perfnodemap command.
perf: add a perfnodemap command
Mon, Feb 4, 4:54 PM
lothiraldan committed rHG5718a7dec736: py3: use integer division instead of `int(...)` call.
py3: use integer division instead of `int(...)` call
Mon, Feb 4, 6:51 AM

Thu, Jan 31

lothiraldan closed D5587: watchman: detect nested mercurial repositories and abort.
Thu, Jan 31, 11:34 AM
lothiraldan committed rHG6a7b2d2de124: watchman: detect nested mercurial repositories and abort.
watchman: detect nested mercurial repositories and abort
Thu, Jan 31, 11:34 AM
lothiraldan closed D5586: watchman: add verbose config knob.
Thu, Jan 31, 11:34 AM
lothiraldan committed rHG158962bf4a52: watchman: add verbose config knob.
watchman: add verbose config knob
Thu, Jan 31, 11:34 AM
lothiraldan committed rHG189e06b2d719: revlog: make sure we never use sparserevlog without general delta (issue6056).
revlog: make sure we never use sparserevlog without general delta (issue6056)
Thu, Jan 31, 7:12 AM
lothiraldan committed rHG261d37b94d31: sparserevlog: document the config option.
sparserevlog: document the config option
Thu, Jan 31, 7:12 AM

Wed, Jan 30

lothiraldan committed rHG4a2c8ec90a28: perf: add a --[no-]clear-caches option to `perfnodemap`.
perf: add a --[no-]clear-caches option to `perfnodemap`
Wed, Jan 30, 4:27 PM
lothiraldan committed rHG22919858e84c: perf: add a perfnodemap command.
perf: add a perfnodemap command
Wed, Jan 30, 4:27 PM

Mon, Jan 28

lothiraldan committed rHG7eb7637e34bf: perf: support looking up multiple revisions.
perf: support looking up multiple revisions
Mon, Jan 28, 5:20 PM
lothiraldan committed rHGe9891c734bf8: perf: add a no-lookup variant to perfindex.
perf: add a no-lookup variant to perfindex
Mon, Jan 28, 5:20 PM
lothiraldan committed rHGd65ba1ff4559: perf: add some documentation to perfindex.
perf: add some documentation to perfindex
Mon, Jan 28, 5:20 PM
lothiraldan committed rHGab6d1f82be32: perf: move cache clearing in the `setup` step of `perfheads`.
perf: move cache clearing in the `setup` step of `perfheads`
Mon, Jan 28, 5:20 PM
lothiraldan committed rHGe2e815e3c4ae: revlog: document cext oddities in terms of object/caches.
revlog: document cext oddities in terms of object/caches
Mon, Jan 28, 5:20 PM
lothiraldan committed rHG48394923fbdc: perf: document perfheads.
perf: document perfheads
Mon, Jan 28, 5:20 PM

Thu, Jan 24

lothiraldan updated the diff for D5590: watchman: ignore some of watchman errors.
Thu, Jan 24, 12:40 PM
lothiraldan updated the diff for D5589: watchman: add the possibility to set the exact watchman binary location.
Thu, Jan 24, 12:40 PM
lothiraldan updated the diff for D5588: watchman: disable fsmonitor when running non-interactively.
Thu, Jan 24, 12:40 PM
lothiraldan updated the diff for D5587: watchman: detect nested mercurial repositories and abort.
Thu, Jan 24, 12:40 PM
lothiraldan updated the diff for D5586: watchman: add verbose config knob.
Thu, Jan 24, 12:40 PM
lothiraldan committed rHG76873548b051: partialdiscovery: avoid `undecided` related computation sooner than necessary.
partialdiscovery: avoid `undecided` related computation sooner than necessary
Thu, Jan 24, 12:23 PM

Wed, Jan 23

lothiraldan added a comment to D5633: grep: use set instead of dict with dummy value.

I get a message stating that one of the hunk of patch failed to apply and couldn't understand what is going on, could you try rebase it to see if you have the issue locally?

Wed, Jan 23, 1:16 PM

Jan 19 2019

lothiraldan committed rHGb1ea90613af3: revset: introduce an internal `_rev` predicate for '%d' usage.
revset: introduce an internal `_rev` predicate for '%d' usage
Jan 19 2019, 6:30 AM
lothiraldan added a reverting commit for rHG74a9f428227e: mmapindex: set default to 1MB: rHGbf4a078b3f88: mmap: backed out changeset 74a9f428227e.
Jan 19 2019, 6:30 AM
lothiraldan committed rHGbf4a078b3f88: mmap: backed out changeset 74a9f428227e.
mmap: backed out changeset 74a9f428227e
Jan 19 2019, 6:30 AM
lothiraldan committed rHGd82dd55024e7: mmap: backed out changeset 875d2af8cb4e.
mmap: backed out changeset 875d2af8cb4e
Jan 19 2019, 6:30 AM
lothiraldan added a reverting commit for rHG875d2af8cb4e: mmapindex: move the 'mmapindexthreshold' option out of experimental: rHGd82dd55024e7: mmap: backed out changeset 875d2af8cb4e.
Jan 19 2019, 6:30 AM

Jan 18 2019

lothiraldan added a comment to D5594: copies: consider nullrev a common ancestor.
In D5594#83078, @yuja wrote:
I've seen many bugs in the git codebase that were caused by it not
having a null revision and being forced to treat root commits
differently. Mercurial has a null revision and I think it's generally
a bug to treat it differently from other commits in graph algorithms.

I agree with that, but I don't think every non-merge revision (p2 = null)
should be considered a direct child of null revision.

@@ -65,8 +63,6 @@

else:
    parents = cl.parentrevs(r)

Here parents[1] may be nullrev. Is that expected?

for p in parents:
  • if p < 0:
  • continue
Jan 18 2019, 8:25 AM
lothiraldan committed rHG593f6359681d: update: fix edge-case with update.atomic-file and read-only files.
update: fix edge-case with update.atomic-file and read-only files
Jan 18 2019, 7:36 AM
lothiraldan accepted D5622: localrepo: use context manager for transaction in commit().

I have the impression that the test changes are due to the previous patch in the stack.

I don't think so. See commit message for why I think they changed.

Jan 18 2019, 1:59 AM

Jan 17 2019

lothiraldan added a comment to D5590: watchman: ignore some of watchman errors.

I don't suppose there's a way to easily test this? I'm guessing not...

The change seems reasonable though.

Jan 17 2019, 11:47 AM
lothiraldan added inline comments to D5589: watchman: add the possibility to set the exact watchman binary location.
Jan 17 2019, 11:46 AM
lothiraldan added a comment to D5588: watchman: disable fsmonitor when running non-interactively.

Why wouldn't we want automated, non-interactive tools to have the benefits of watchman? There are plenty of use cases where complex Mercurial operations are scripted and would benefit from watchman.

Your commit message details an issue that I assume you encountered in the wild. Are there other ways we can work around this? Perhaps we can set the idle timeout/shutdown interval of watchman to be much smaller when Mercurial is non-interactive?

Jan 17 2019, 11:36 AM
lothiraldan added a comment to D5586: watchman: add verbose config knob.
In D5586#83031, @pulkit wrote:

This new config knob defaults to off and we're therefore changing the behavior to not warn when watchman is unavailable. This is a bit concerning to me because someone could have fsmonitor enabled and I don't think they'd ever get an error if watchman isn't working correctly.

I support introducing the config knob. But I don't like silently suppressing watchman errors that could lead to false user expectations.

I on +1 with what @indygreg said. These warning messages have proved much helpful for us internally.

Jan 17 2019, 11:29 AM
lothiraldan committed rHGf4277a35c42c: discovery: compute newly discovered missing in a more efficient way.
discovery: compute newly discovered missing in a more efficient way
Jan 17 2019, 7:10 AM
lothiraldan committed rHG61f9ef23a12f: dagop: minor python optimization to `headrevs`.
dagop: minor python optimization to `headrevs`
Jan 17 2019, 6:39 AM
lothiraldan committed rHG41f14e8f335f: revsetbenchmark: add more example for roots usages.
revsetbenchmark: add more example for roots usages
Jan 17 2019, 6:39 AM
lothiraldan committed rHG5affe1583e1d: revset: use changelog's `headrevs` method to compute heads.
revset: use changelog's `headrevs` method to compute heads
Jan 17 2019, 6:39 AM
lothiraldan committed rHG1421d0487a61: revlog: accept a revs argument in `headrevs`.
revlog: accept a revs argument in `headrevs`
Jan 17 2019, 6:39 AM
lothiraldan committed rHG4c6fdc7e2e7d: revset: inline parents computation to reuse the input argument.
revset: inline parents computation to reuse the input argument
Jan 17 2019, 6:39 AM
lothiraldan committed rHG71ef4e923886: revsetbenchmarks: support revset starting with a "-".
revsetbenchmarks: support revset starting with a "-"
Jan 17 2019, 6:39 AM
lothiraldan committed rHG5409f7ec7850: revsetbenchmarks: add various examples around the 'heads()' revset.
revsetbenchmarks: add various examples around the 'heads()' revset
Jan 17 2019, 6:39 AM
lothiraldan added a comment to D5622: localrepo: use context manager for transaction in commit().

I have the impression that the test changes are due to the previous patch in the stack.

Jan 17 2019, 3:41 AM

Jan 16 2019

lothiraldan committed rHG26b0a7514f01: revset: transparently forward _intlist argument in all case.
revset: transparently forward _intlist argument in all case
Jan 16 2019, 7:43 AM
lothiraldan committed rHGc9fd08893247: revset: transparently forward _intlist argument in all case.
revset: transparently forward _intlist argument in all case
Jan 16 2019, 4:34 AM

Jan 15 2019

lothiraldan added a comment to D5590: watchman: ignore some of watchman errors.

This series is non-urgent and it's fine if not included in the RC. I would like to gather feedback from fsmonitor experts on it but phabricator doesn't allow to set a RFC flag

Jan 15 2019, 12:51 PM
lothiraldan created D5590: watchman: ignore some of watchman errors.
Jan 15 2019, 11:57 AM
lothiraldan created D5589: watchman: add the possibility to set the exact watchman binary location.
Jan 15 2019, 11:57 AM
lothiraldan added a dependent revision for D5589: watchman: add the possibility to set the exact watchman binary location: D5590: watchman: ignore some of watchman errors.
Jan 15 2019, 11:57 AM
lothiraldan added a dependent revision for D5588: watchman: disable fsmonitor when running non-interactively: D5589: watchman: add the possibility to set the exact watchman binary location.
Jan 15 2019, 11:57 AM
lothiraldan created D5588: watchman: disable fsmonitor when running non-interactively.
Jan 15 2019, 11:57 AM
lothiraldan added a dependent revision for D5587: watchman: detect nested mercurial repositories and abort: D5588: watchman: disable fsmonitor when running non-interactively.
Jan 15 2019, 11:57 AM
lothiraldan created D5587: watchman: detect nested mercurial repositories and abort.
Jan 15 2019, 11:57 AM
lothiraldan added a dependent revision for D5586: watchman: add verbose config knob: D5587: watchman: detect nested mercurial repositories and abort.
Jan 15 2019, 11:57 AM
lothiraldan created D5586: watchman: add verbose config knob.
Jan 15 2019, 11:57 AM
lothiraldan committed rHG73203cdfe3fe: revset: detect integer list on parsing.
revset: detect integer list on parsing
Jan 15 2019, 8:08 AM
lothiraldan committed rHG8aca89a694d4: revset: introduce an API that avoids `formatspec` input serialization.
revset: introduce an API that avoids `formatspec` input serialization
Jan 15 2019, 8:08 AM
lothiraldan committed rHG8d26026b3335: revert: extract "%ld" formatting in a _formatintlist function.
revert: extract "%ld" formatting in a _formatintlist function
Jan 15 2019, 8:08 AM
lothiraldan committed rHG24a1f67bb75a: revset: enforce "%d" to be interpreted as literal revision number (API) (BC).
revset: enforce "%d" to be interpreted as literal revision number (API) (BC)
Jan 15 2019, 8:08 AM