Page MenuHomePhabricator

marmoute (Pierre-Yves David)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:56 PM (153 w, 2 h)

Recent Activity

Tue, Jun 2

marmoute added a comment to D8480: bundle: make obsolescence parts optional.

This patch is contentious, but I'm a little unclear why. Summarizing so everyone at least parses my thoughts roughly the way I mean: mandatory parts mean "fail if you can't process this part." It seems basically reasonable to me that a client can choose to ignore (perhaps through ignorance) obsolete markers and it'll be potentially confusing, but not /wrong/ in that they'll have the changesets they expected, but also didn't lose some the server thought they would. It feels like a bug if a client requests obsmarkers and then discards them?

Tue, Jun 2, 7:22 AM
marmoute updated the diff for D8587: metadata: move computation related to files touched in a dedicated module.
Tue, Jun 2, 6:49 AM
marmoute updated the diff for D8588: files: extract code for extra filtering of the `removed` entry into copies.
Tue, Jun 2, 6:48 AM
marmoute updated the diff for D8589: metadata: filter the `removed` set to only contains relevant data.
Tue, Jun 2, 6:48 AM

Thu, May 28

marmoute closed D8534: flags: read flag from dirstate/disk for workingcopyctx (issue5743).
Thu, May 28, 12:40 PM
marmoute closed D8536: flags: also test merge with executable bit removed.
Thu, May 28, 12:40 PM
marmoute committed rHG6d968cd40961: flags: also test merge with executable bit removed.
flags: also test merge with executable bit removed
Thu, May 28, 12:40 PM
marmoute closed D8535: flags: also test the removal of the exec flag.
Thu, May 28, 12:40 PM
marmoute committed rHG9afee647a9f0: flags: also test the removal of the exec flag.
flags: also test the removal of the exec flag
Thu, May 28, 12:39 PM
marmoute closed D8533: flags: actually merge flags in simplemerge.
Thu, May 28, 12:39 PM
marmoute committed rHG4234c9af515d: flags: read flag from dirstate/disk for workingcopyctx (issue5743).
flags: read flag from dirstate/disk for workingcopyctx (issue5743)
Thu, May 28, 12:39 PM
marmoute committed rHG84614212ae39: flags: actually merge flags in simplemerge.
flags: actually merge flags in simplemerge
Thu, May 28, 12:39 PM
marmoute closed D8532: flags: add a test for merging exec flag change with rename and file change.
Thu, May 28, 12:39 PM
marmoute committed rHG783f059509e4: flags: add a test for merging exec flag change with rename and file change.
flags: add a test for merging exec flag change with rename and file change
Thu, May 28, 12:39 PM
marmoute closed D8531: flags: account for flag change when tracking rename relevant to merge.
Thu, May 28, 12:39 PM
marmoute closed D8530: flags: also test merging a rename with and exec flag change.
Thu, May 28, 12:39 PM
marmoute committed rHGd452acc8cce8: flags: account for flag change when tracking rename relevant to merge.
flags: account for flag change when tracking rename relevant to merge
Thu, May 28, 12:39 PM
marmoute committed rHG9438c84d1dce: flags: also test merging a rename with and exec flag change.
flags: also test merging a rename with and exec flag change
Thu, May 28, 12:39 PM
marmoute closed D8529: flags: introduce explicit testing for merging change to exec flag.
Thu, May 28, 12:39 PM
marmoute committed rHGbf5ed664f467: flags: introduce explicit testing for merging change to exec flag.
flags: introduce explicit testing for merging change to exec flag
Thu, May 28, 12:38 PM

Wed, May 27

marmoute created D8587: metadata: move computation related to files touched in a dedicated module.
Wed, May 27, 9:17 AM
marmoute created D8588: files: extract code for extra filtering of the `removed` entry into copies.
Wed, May 27, 9:17 AM
marmoute created D8589: metadata: filter the `removed` set to only contains relevant data.
Wed, May 27, 9:17 AM

Tue, May 26

marmoute accepted D8586: files: speed up `hg files` when no flags change display.
Tue, May 26, 12:37 PM
marmoute added a comment to D8577: graft-state: add test to document problem with graft --continue, after --base.

Awesome I did the fold and D8578 now contains all the changes. Should this diff be closed now?

Tue, May 26, 11:49 AM
marmoute added a comment to D8582: grep: reduce the cost of pathauditor checks when grepping working copy.

I don't understand. Do you mean have numbers in the code in addition to the commit description? Seems like too much details.

Tue, May 26, 11:49 AM
marmoute accepted D8583: sshpeer: add test showing that -q silences remote errors.
Tue, May 26, 10:05 AM
marmoute accepted D8577: graft-state: add test to document problem with graft --continue, after --base.
Tue, May 26, 10:05 AM
D8586: files: speed up `hg files` when no flags change display now requires changes to proceed.

The overall idea seems good, but @joerg.sonnenberger feedback sound probably be taken in account.

Tue, May 26, 10:04 AM
marmoute added a comment to D8585: scmutil: speed up relativization of paths when it's a no-op.

I don't find the comment confusing, (but I am not agains clarification if @joerg.sonnenberger and @valentin.gatienbaron reach a consensus.

Tue, May 26, 10:01 AM
D8584: sshpeer: make client print (likely) server errors on stderr now requires changes to proceed.

This should be flagged as (BC) in the changeset summary.

Tue, May 26, 9:58 AM
D8581: grep: test that paths get audited now requires changes to proceed.

It would be nice to have some comments in the test to explain what is exactly test here, it is a bit obscure from just reading the test.

Tue, May 26, 9:54 AM
D8580: grep: add test coverage of behavior on symlinks now requires changes to proceed.

It would be nice to have some comments in the test to explain what is exactly test here, it is a bit obscure from just reading the test.

Tue, May 26, 9:53 AM
marmoute added a comment to D8582: grep: reduce the cost of pathauditor checks when grepping working copy.

It would be nice to have performance number in addition to the percentage. However the change looks good as is.

Tue, May 26, 9:53 AM
marmoute added a comment to D8579: context: avoid computing status twice when comparing among revisions.

This looks fine.

Tue, May 26, 9:45 AM
marmoute added a comment to D8577: graft-state: add test to document problem with graft --continue, after --base.

I think you can simply fold them and run phab send again.

Tue, May 26, 9:44 AM
marmoute accepted D8578: graft-state: save --base in graft's state, fixing bug with graft --continue.
Tue, May 26, 9:43 AM
marmoute added a comment to D8576: help: fix description of revlog version 2.

LGTM

Tue, May 26, 9:42 AM

Fri, May 22

marmoute added a comment to D8529: flags: introduce explicit testing for merging change to exec flag.

I'm okay with the series, but I'm a little hesitant to put something this big on stable. Can you sway me one way or the other?

Fri, May 22, 4:59 AM

Sun, May 17

marmoute added a comment to D8480: bundle: make obsolescence parts optional.

While I don't really agree with the design interpretation of why the server should send mandatory, I don't care enough in this case.

Sun, May 17, 7:51 AM

Sat, May 16

marmoute created D8534: flags: read flag from dirstate/disk for workingcopyctx (issue5743).
Sat, May 16, 4:12 PM
marmoute created D8536: flags: also test merge with executable bit removed.
Sat, May 16, 4:12 PM
marmoute created D8535: flags: also test the removal of the exec flag.
Sat, May 16, 4:12 PM
marmoute created D8533: flags: actually merge flags in simplemerge.
Sat, May 16, 4:12 PM
marmoute created D8531: flags: account for flag change when tracking rename relevant to merge.
Sat, May 16, 4:11 PM
marmoute created D8532: flags: add a test for merging exec flag change with rename and file change.
Sat, May 16, 4:11 PM
marmoute created D8530: flags: also test merging a rename with and exec flag change.
Sat, May 16, 4:11 PM
marmoute created D8529: flags: introduce explicit testing for merging change to exec flag.
Sat, May 16, 4:11 PM

Fri, May 15

marmoute closed D8528: dirstate: make sure the dirstate is loaded before the changelog (issue6303).
Fri, May 15, 3:30 PM
marmoute committed rHG35b255e474d9: dirstate: make sure the dirstate is loaded before the changelog (issue6303).
dirstate: make sure the dirstate is loaded before the changelog (issue6303)
Fri, May 15, 3:29 PM
marmoute created D8528: dirstate: make sure the dirstate is loaded before the changelog (issue6303).
Fri, May 15, 6:23 AM

Thu, May 14

marmoute closed D8431: upgrade: support upgrade and downgrade from persistent nodemap.
Thu, May 14, 4:32 PM
marmoute committed rHG526d69eeea31: upgrade: support upgrade and downgrade from persistent nodemap.
upgrade: support upgrade and downgrade from persistent nodemap
Thu, May 14, 4:31 PM

Wed, May 13

marmoute added a comment to D8513: rust-dirstatemap: don't read the dirstate when requesting parents.

This looks good to me.

Wed, May 13, 11:30 AM

Tue, May 12

marmoute committed rHG35bb67427f63: manifest-cache: ignore IOError while writing.
manifest-cache: ignore IOError while writing
Tue, May 12, 4:05 PM
marmoute updated the diff for D8431: upgrade: support upgrade and downgrade from persistent nodemap.
Tue, May 12, 4:37 AM

Mon, May 11

marmoute closed D8512: manifest-cache: ignore IOError while writing.
Mon, May 11, 7:37 PM
marmoute committed rHG92054972f035: manifest-cache: ignore IOError while writing.
manifest-cache: ignore IOError while writing
Mon, May 11, 7:37 PM
marmoute created D8512: manifest-cache: ignore IOError while writing.
Mon, May 11, 3:27 AM

Sat, May 9

marmoute added a comment to D8509: formatting: add missing newline.

Thanks for fixinf this, all our CI is on fire :-/

Sat, May 9, 3:13 PM

Thu, May 7

marmoute added a comment to D8431: upgrade: support upgrade and downgrade from persistent nodemap.

Good catch. I updated the internal doc and https://www.mercurial-scm.org/wiki/MissingRequirement

Thu, May 7, 5:59 PM
marmoute added a comment to D8505: tests: fix timer scaling in wait-on-file.

woops

Thu, May 7, 5:46 PM
marmoute updated the diff for D8431: upgrade: support upgrade and downgrade from persistent nodemap.
Thu, May 7, 5:01 PM
marmoute closed D8430: nodemap: teach `hg debugformat` about the persistent nodemap option.
Thu, May 7, 11:38 AM
marmoute closed D8429: upgrade: support the --quiet flag.
Thu, May 7, 11:37 AM
marmoute committed rHGea9563e9e65a: nodemap: teach `hg debugformat` about the persistent nodemap option.
nodemap: teach `hg debugformat` about the persistent nodemap option
Thu, May 7, 11:37 AM
marmoute committed rHGe295ba238bd8: upgrade: support the --quiet flag.
upgrade: support the --quiet flag
Thu, May 7, 11:37 AM
marmoute closed D8422: nodemap: move the mode option to storage.revlog.nodemap.mode.
Thu, May 7, 11:37 AM
marmoute closed D8421: nodemap: move the option for mmap usage to storage.revlog.nodemap.mmap.
Thu, May 7, 11:37 AM
marmoute closed D8428: upgrade: clearly list optimisation.
Thu, May 7, 11:37 AM
marmoute committed rHG5ee4b2119af9: upgrade: clearly list optimisations.
upgrade: clearly list optimisations
Thu, May 7, 11:36 AM
marmoute closed D8419: nodemap: move the main switch to the `format` section.
Thu, May 7, 11:36 AM
marmoute committed rHGd36283e20833: nodemap: move the mode option to storage.revlog.nodemap.mode.
nodemap: move the mode option to storage.revlog.nodemap.mode
Thu, May 7, 11:36 AM
marmoute closed D8418: nodemap: drop the 'exp-' prefix for internal opener option.
Thu, May 7, 11:36 AM
marmoute committed rHG059c99af141d: nodemap: move the option for mmap usage to storage.revlog.nodemap.mmap.
nodemap: move the option for mmap usage to storage.revlog.nodemap.mmap
Thu, May 7, 11:35 AM
marmoute committed rHG3cfcbb219496: nodemap: move and update the commend about persistence being experimental.
nodemap: move and update the commend about persistence being experimental
Thu, May 7, 11:35 AM
marmoute closed D8420: nodemap: move and update the commend about persistence being experimental.
Thu, May 7, 11:35 AM
marmoute closed D8417: nodemap: gate the feature behind a new requirement.
Thu, May 7, 11:35 AM
marmoute committed rHGd688a8d537b9: nodemap: move the main switch to the `format` section.
nodemap: move the main switch to the `format` section
Thu, May 7, 11:35 AM
marmoute closed D8414: nodemap: add a new mode option, with an optional "warn" value.
Thu, May 7, 11:35 AM
marmoute committed rHG5e3c718692bb: nodemap: drop the 'exp-' prefix for internal opener option.
nodemap: drop the 'exp-' prefix for internal opener option
Thu, May 7, 11:34 AM
marmoute closed D8411: nodemap: also warm manifest nodemap with other caches.
Thu, May 7, 11:34 AM
marmoute committed rHGb81486b609a3: nodemap: gate the feature behind a new requirement.
nodemap: gate the feature behind a new requirement
Thu, May 7, 11:34 AM
marmoute closed D8416: nodemap: move on disk file to version 1.
Thu, May 7, 11:34 AM
marmoute committed rHG261e71752d1f: nodemap: move on disk file to version 1.
nodemap: move on disk file to version 1
Thu, May 7, 11:34 AM
marmoute closed D8415: nodemap: add a new mode value, "strict".
Thu, May 7, 11:34 AM
marmoute committed rHG6b01799e9db0: nodemap: add a new mode value, "strict".
nodemap: add a new mode value, "strict"
Thu, May 7, 11:34 AM
marmoute closed D8410: nodemap: also use persistent nodemap for manifest.
Thu, May 7, 11:34 AM
marmoute committed rHG6493f0a567c2: nodemap: add a new mode option, with an optional "warn" value.
nodemap: add a new mode option, with an optional "warn" value
Thu, May 7, 11:33 AM
marmoute closed D8409: nodemap: create files in the repository used in the test.
Thu, May 7, 11:33 AM
marmoute committed rHG97ebdb192b00: nodemap: also warm manifest nodemap with other caches.
nodemap: also warm manifest nodemap with other caches
Thu, May 7, 11:33 AM
marmoute committed rHG640d5b3bd060: nodemap: also use persistent nodemap for manifest.
nodemap: also use persistent nodemap for manifest
Thu, May 7, 11:33 AM
marmoute committed rHG2c073d82fbfa: nodemap: create files in the repository used in the test.
nodemap: create files in the repository used in the test
Thu, May 7, 11:33 AM
marmoute added a comment to D8500: tests: use regular POSIX shell.

Moving to /bin/sh seems fine. Did you run tests for this patch on debian/dash ? (pushing to heptapod should do it)

Thu, May 7, 10:19 AM
marmoute added a comment to D8501: tests: increase internal timeouts.

Can you double check that 20 second are actually spend to timeout? Previously we had a bug were the time waited was actually 0.2 seconds (and not 20 seconds) and the test was only "flacky". So spending more than 20 seconds in there seems pretty suspicious and I suspect another misbehaving. ?

Thu, May 7, 10:17 AM
marmoute added a comment to D8431: upgrade: support upgrade and downgrade from persistent nodemap.

s/requirements is not/requirement is now/ in the summary, but otherwise LGTM

Thu, May 7, 10:13 AM
marmoute updated the summary of D8431: upgrade: support upgrade and downgrade from persistent nodemap.
Thu, May 7, 10:13 AM
marmoute added a comment to D8480: bundle: make obsolescence parts optional.

TL;DR; We should add a third value to the bundlespec argument: hg bundle -t v2;obsolescence=optional

Thu, May 7, 5:10 AM

May 2 2020

marmoute added a comment to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.

Now that I see it, I think we shoul dinclude all heads because the mssage might be confusing "multiple heads: one-hash"

Heh, I didn't think of that. So are you saying that one of the previous diffs is OK, or don't filter out min/max head/root?

May 2 2020, 5:37 PM
marmoute added a comment to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.

Gentle ping on this. I think I addressed the concerns raised, and didn't want it overlooked for the release if it's still in the changes requested state.

Did not we want to update the message ?

I did: https://phab.mercurial-scm.org/D8454?vs=21150&id=21216#toc

May 2 2020, 12:37 PM