Page MenuHomePhabricator

marmoute (Pierre-Yves David)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:56 PM (186 w, 4 d)

Recent Activity

Today

marmoute created D9865: store: use `endswith` to detect revlog extension.
Mon, Jan 25, 4:32 PM
marmoute added inline comments to D9810: persistent-nodemap: also exchange the nodemap data over the wire.
Mon, Jan 25, 10:34 AM
marmoute added a comment to D9789: clone: make sure we warm the cache after a clone.

I'm -0 on this change. Caches are caches and IMO should only be populated on demand.

Mon, Jan 25, 10:24 AM
marmoute added inline comments to D9760: persistent-node: check the value of the slow-path config.
Mon, Jan 25, 10:19 AM

Sat, Jan 23

marmoute added a comment to D9516: perf: use the `perf--` prefix for perf command.

Big picture, why do we need to be able to tell namespace parts from command parts?

To make sure the user understand they are stepping in an entire different realm with different rules.
In the standard namespace (no prefix) we garantee (or aims at) the lack of footgun and excellent backward compatibility.
The debug namespace should not be somewhere any normal user ever have to go (at least without a responsible staff member)
The admin namespace will have its own rules and its own "be careful, this is not a "normal" situation to be there.
So we want something more distincting than just a simple - that we could have for "command group" or readability like phab-send, phab-read, etc.

So it sounds like more of a convention for these behavior properties than say, commands in the admin group requiring --yes-i-know-this-may-eat-my-data. We'll have to have to figure out how to convey that somehow. I see admin, for example, and think "I'm in charge of making this work for my group, and it sounds like it does what I want, so it's for me and just some extra characters to type". I don't have any suggestions on how to highlight these behaviors ATM.

Sat, Jan 23, 5:32 AM

Fri, Jan 22

marmoute closed D9819: purge: also deal with directory with --confirm.
Fri, Jan 22, 3:39 PM
marmoute closed D9818: purge: add a --confirm option.
Fri, Jan 22, 3:39 PM
marmoute committed rHG57370e7deb7b: purge: also deal with directory with --confirm.
purge: also deal with directory with --confirm
Fri, Jan 22, 3:38 PM
marmoute committed rHG135056e8b5a8: purge: add a --confirm option.
purge: add a --confirm option
Fri, Jan 22, 3:38 PM
marmoute added inline comments to D9819: purge: also deal with directory with --confirm.
Fri, Jan 22, 9:35 AM

Thu, Jan 21

marmoute closed D9841: share-share: have the hint issue more consistently and point to the right doc.
Thu, Jan 21, 11:18 PM
marmoute closed D9840: doc: point to the main share-safe doc in the "mismatch" config.
Thu, Jan 21, 11:18 PM
marmoute committed rHG4a58561ace0f: share-share: have the hint issue more consistently and point to the right doc.
share-share: have the hint issue more consistently and point to the right doc
Thu, Jan 21, 11:18 PM
marmoute committed rHG5249ac2bc7a4: doc: point to the main share-safe doc in the "mismatch" config.
doc: point to the main share-safe doc in the "mismatch" config
Thu, Jan 21, 11:18 PM
marmoute closed D9839: doc: improves the share-safe documentation.
Thu, Jan 21, 11:18 PM
marmoute closed D9838: doc: remove the section about share-safe from its verbose gating.
Thu, Jan 21, 11:18 PM
marmoute committed rHG60e6bf3bf681: doc: improves the share-safe documentation.
doc: improves the share-safe documentation
Thu, Jan 21, 11:18 PM
marmoute committed rHG043781c0ffd6: doc: remove the section about share-safe from its verbose gating.
doc: remove the section about share-safe from its verbose gating
Thu, Jan 21, 11:17 PM
marmoute committed rHG6bb52cc08855: doc: relocate doc for `share.safe-mismatch.source-safe.warn`.
doc: relocate doc for `share.safe-mismatch.source-safe.warn`
Thu, Jan 21, 11:17 PM
marmoute closed D9837: doc: relocate doc for `share.safe-mismatch.source-safe.warn`.
Thu, Jan 21, 11:17 PM
marmoute added a comment to D9780: repository: introduce register_changeset callback.

I like the fact we now take a rev as argument. However two discussion remains:

  • could/should we stop passing the changelogrevision as argument ?

The performance critical path is IMO in during changegroup application (unbundle) and that one is already doing most of the work.
There are some good chances that consumers of the API will look at older revisions in at least some use cases, so the simple
last-use-cache won't work as well in that case. As such I think it is both simpler and more predictable to do the work once.

Thu, Jan 21, 5:00 PM
marmoute added inline comments to D9839: doc: improves the share-safe documentation.
Thu, Jan 21, 9:23 AM
marmoute added inline comments to D9841: share-share: have the hint issue more consistently and point to the right doc.
Thu, Jan 21, 9:23 AM
marmoute added a comment to D9780: repository: introduce register_changeset callback.

I like the fact we now take a rev as argument. However two discussion remains:

Thu, Jan 21, 8:04 AM
marmoute closed D9813: discovery: add config options to control sample size.
Thu, Jan 21, 7:24 AM
marmoute committed rHG0600e8467101: discovery: add config options to control sample size.
discovery: add config options to control sample size
Thu, Jan 21, 7:24 AM

Wed, Jan 20

marmoute added a comment to D9843: revlog: introduce v2 format.

Can we get space for extra flags for things not supported by the filesystem? I'm thinking specifically +x and symlink support on Windows.
https://www.mercurial-scm.org/wiki/DirState#Proposed_extensions

Wed, Jan 20, 6:04 PM
marmoute closed D9516: perf: use the `perf--` prefix for perf command.
Wed, Jan 20, 3:25 PM
marmoute committed rHGb8d8fd2fe75f: perf: use the `perf--` prefix for perf command.
perf: use the `perf--` prefix for perf command
Wed, Jan 20, 3:24 PM
marmoute added inline comments to D9516: perf: use the `perf--` prefix for perf command.
Wed, Jan 20, 2:29 PM
marmoute added a comment to D9842: tests: deal with more timing differences in output.

Sad but useful.

Wed, Jan 20, 9:00 AM
marmoute added a comment to D9836: tests: skip a detailed exit status in test-lfs-test-server.

Should this go on stable instead to make the test fixed on stable too?

Wed, Jan 20, 7:09 AM
marmoute created D9841: share-share: have the hint issue more consistently and point to the right doc.
Wed, Jan 20, 6:53 AM
marmoute created D9840: doc: point to the main share-safe doc in the "mismatch" config.
Wed, Jan 20, 6:53 AM
marmoute created D9839: doc: improves the share-safe documentation.
Wed, Jan 20, 6:53 AM
marmoute created D9838: doc: remove the section about share-safe from its verbose gating.
Wed, Jan 20, 6:53 AM
marmoute created D9837: doc: relocate doc for `share.safe-mismatch.source-safe.warn`.
Wed, Jan 20, 6:53 AM

Mon, Jan 18

marmoute added a comment to D9780: repository: introduce register_changeset callback.

@joerg.sonnenberger and I had a discussion on IRC about this API and the result is that Joerg prefers the higher level API for reason I now understand better without necessarly finding them decisive while I still prefer the lower level API for reason that (hopefully) Joerg understand better without finding them more decisive. So we are doing to need a bit more time to thing about that (and probably about the broader picture of the full API of the involved object) with probably more people.

Mon, Jan 18, 4:41 PM
marmoute added a comment to D9780: repository: introduce register_changeset callback.
  • it pass around quite high level object where I think rev would be more appropriate,

I don't disagree, but that's a more general change IMO. I really dislike D9826 as it introduces new hidden assumptions about how a revlog backend works.

Mon, Jan 18, 3:22 PM
marmoute closed D9829: clang-format: reorder includes to appease the formatter.
Mon, Jan 18, 1:31 PM
marmoute committed rHG0216abfb2d3e: clang-format: reorder includes to appease the formatter.
clang-format: reorder includes to appease the formatter
Mon, Jan 18, 1:31 PM
marmoute created D9829: clang-format: reorder includes to appease the formatter.
Mon, Jan 18, 1:21 PM
D9780: repository: introduce register_changeset callback now requires changes to proceed.

So I am still not fan of this API:

Mon, Jan 18, 1:15 PM
marmoute created D9826: callback: add a new_cl_rev_callback.
Mon, Jan 18, 1:11 PM
marmoute created D9828: changelog: use revision number as the cache key internally.
Mon, Jan 18, 1:11 PM
marmoute created D9827: changelog: cache the latest `changelogrevision` access.
Mon, Jan 18, 1:11 PM
marmoute added a comment to D9825: cext: add Python 3.10 support.

I phabsent this in behalf of Victor to avoid him premature exposure to phabricator crapiness.

Mon, Jan 18, 12:33 PM
marmoute created D9825: cext: add Python 3.10 support.
Mon, Jan 18, 12:32 PM
marmoute added a comment to D9779: changelog: move branchinfo to changelogrevision.

(this is otherwise great), and we can probably turn this in a property cache as a follow up.

Mon, Jan 18, 12:08 PM
marmoute accepted D9823: share: move share safe functionality out of experimental.
Mon, Jan 18, 11:55 AM
marmoute added a comment to D9786: share: rename share-safe warning config.

This looks good, thanks.

Mon, Jan 18, 11:49 AM
marmoute accepted D9785: share: rework config options to be much clearer and easier.
Mon, Jan 18, 11:47 AM
marmoute accepted D9822: upgrade: re-read current requirements after taking lock.
Mon, Jan 18, 11:45 AM
marmoute accepted D9781: branchmap: update rev-branch-cache incrementally.
Mon, Jan 18, 11:41 AM
marmoute added a comment to D9780: repository: introduce register_changeset callback.

Still not convinced with the API, so poking at what else would be possible.
I nothing obvious emerge we should move forward with that series before the freeze, the change final change is quite valuable.

Mon, Jan 18, 11:40 AM
marmoute added a comment to D9778: reverse-branch-cache: switch to doubling allocating scheme.

This is clearer. For extra clarity I would probably use something like:

Mon, Jan 18, 11:08 AM
marmoute accepted D9785: share: rework config options to be much clearer and easier.
Mon, Jan 18, 10:59 AM
marmoute added a comment to D9823: share: move share safe functionality out of experimental.

This looks good. The documentation could be a bit better. However this can be dealt with during the freeze. So lets focus on the implementation/behavior side for now.

Mon, Jan 18, 10:54 AM
marmoute added a comment to D9785: share: rework config options to be much clearer and easier.

The requested distinction happen as a follow up in D9824. It seems fine to me.

Mon, Jan 18, 10:52 AM
marmoute accepted D9824: share: make different options for upgrade and downgrade share-safe.
Mon, Jan 18, 10:52 AM
D9783: upgrade: take lock only for part where it's required now requires review to proceed.

Am I fine with the required fix being a follow up and such follow up now exist. So I think we are good to go.

Mon, Jan 18, 10:50 AM
marmoute added a comment to D9822: upgrade: re-read current requirements after taking lock.

This looks "fine" as it fix the previous race window. However do not hesitate to follow up with another patch to reduce the code duplication.

Mon, Jan 18, 10:49 AM
marmoute accepted D9784: localrepo: disallow share if there is a version mismatch by default.
Mon, Jan 18, 10:47 AM
marmoute added a comment to D9821: sqlitestore: disable test with chg.

Great, thanks.

Mon, Jan 18, 8:35 AM
D9821: sqlitestore: disable test with chg now requires changes to proceed.

Can you add a small in place comment to explain the requirements ?

Mon, Jan 18, 8:25 AM
D9786: share: rename share-safe warning config now requires changes to proceed.

Same as before, we will have two different option as one case (probably upgrade) migh be expected within an organization but not the other.

Mon, Jan 18, 4:57 AM
D9785: share: rework config options to be much clearer and easier now requires changes to proceed.

We need a distinct option for upgrading and downgrading. The "risk" associated with each operation is quite different and should be dealt with differently.

Mon, Jan 18, 4:56 AM
marmoute added a comment to D9284: purge: move extension into core mercurial.

I gave a shot at a --confirm option. An alternative series to this one can be found in D9818 D9819 and D98120

Mon, Jan 18, 4:30 AM
marmoute created D9820: purge: move extension into core mercurial.
Mon, Jan 18, 4:28 AM
marmoute created D9819: purge: also deal with directory with --confirm.
Mon, Jan 18, 4:26 AM
marmoute created D9818: purge: add a --confirm option.
Mon, Jan 18, 4:26 AM
marmoute created D9817: relnote: remove the reference to `debugstrip`.
Mon, Jan 18, 4:25 AM

Sun, Jan 17

marmoute created D9813: discovery: add config options to control sample size.
Sun, Jan 17, 5:26 PM
marmoute added a comment to D9784: localrepo: disallow share if there is a version mismatch by default.

note: I am fine with D9783 being taken in its current forms and the locking being fixed as a follow up. Overall the series is still an improvement.

Sun, Jan 17, 5:25 PM
marmoute committed rHG723d241543b0: heptapod-ci: allow testing with docker image other than :latest.
heptapod-ci: allow testing with docker image other than :latest
Sun, Jan 17, 5:23 PM
marmoute closed D9792: heptapod-ci: allow testing with docker image other than :latest.
Sun, Jan 17, 5:23 PM
marmoute closed D9810: persistent-nodemap: also exchange the nodemap data over the wire.
Sun, Jan 17, 5:09 PM
marmoute committed rHG7c1367c0b5bc: persistent-nodemap: also exchange the nodemap data over the wire.
persistent-nodemap: also exchange the nodemap data over the wire
Sun, Jan 17, 5:09 PM
marmoute closed D9809: persistent-nodemap: catch the right exception on python.
Sun, Jan 17, 5:09 PM
marmoute committed rHGd32e7ed81f4f: persistent-nodemap: catch the right exception on python.
persistent-nodemap: catch the right exception on python
Sun, Jan 17, 5:09 PM
marmoute created D9810: persistent-nodemap: also exchange the nodemap data over the wire.
Sun, Jan 17, 2:29 PM
marmoute created D9809: persistent-nodemap: catch the right exception on python.
Sun, Jan 17, 2:29 PM
marmoute closed D9801: discovery: add a devel.discovery.exchange-heads.
Sun, Jan 17, 1:45 PM
marmoute committed rHG6ee9bd69ff7f: discovery: add a devel.discovery.exchange-heads.
discovery: add a devel.discovery.exchange-heads
Sun, Jan 17, 1:44 PM
marmoute committed rHG95a615dd77bf: clone: make sure we warm the cache after a clone.
clone: make sure we warm the cache after a clone
Sun, Jan 17, 2:21 AM
marmoute added a reverting change for D9640: setup: when possible, build and bundle man pages: rHG2ef575c62f10: test-regression: backing out D9640 (63c923fd7fa8).
Sun, Jan 17, 2:21 AM
marmoute added a reverting change for rHG63c923fd7fa8: setup: when possible, build and bundle man pages: rHG2ef575c62f10: test-regression: backing out D9640 (63c923fd7fa8).
Sun, Jan 17, 2:21 AM
marmoute added reverted changes for rHG2ef575c62f10: test-regression: backing out D9640 (63c923fd7fa8): rHG63c923fd7fa8: setup: when possible, build and bundle man pages, D9640: setup: when possible, build and bundle man pages.
test-regression: backing out D9640 (63c923fd7fa8)
Sun, Jan 17, 2:21 AM
marmoute committed rHG4cde46f62ebf: persistent-nodemap: remove the "experimental" tag to the feature.
persistent-nodemap: remove the "experimental" tag to the feature
Sun, Jan 17, 2:21 AM
marmoute committed rHG28899b6f4480: persistent-nodemap: drop the storage.revlog.nodemap.mode config.
persistent-nodemap: drop the storage.revlog.nodemap.mode config
Sun, Jan 17, 2:21 AM
marmoute committed rHG014ac7a32048: persistent-nodemap: add a "abort" option to the slow-path config.
persistent-nodemap: add a "abort" option to the slow-path config
Sun, Jan 17, 2:21 AM
marmoute committed rHGfc2d5c0aed7f: persistent-nodemap: add a "warn" option to the slow-path config.
persistent-nodemap: add a "warn" option to the slow-path config
Sun, Jan 17, 2:21 AM
marmoute committed rHG2c9c88879ab7: persistent-node: check the value of the slow-path config.
persistent-node: check the value of the slow-path config
Sun, Jan 17, 2:21 AM
marmoute committed rHG05a1e44b2224: persistent-nodemap: add a revlog.storage.persistent-nodemap.slow-path option.
persistent-nodemap: add a revlog.storage.persistent-nodemap.slow-path option
Sun, Jan 17, 2:21 AM
marmoute committed rHG51da7c8ef357: persistent-nodemap: document storage.revlog.persistent-nodemap.mmap=no.
persistent-nodemap: document storage.revlog.persistent-nodemap.mmap=no
Sun, Jan 17, 2:21 AM
marmoute committed rHG8b94f05ab069: persistent-nodemap: document the feature in `hg help config.format`.
persistent-nodemap: document the feature in `hg help config.format`
Sun, Jan 17, 2:21 AM
marmoute committed rHG7d096e5a5b90: persistent-nodemap: rename the storage.revlog.nodemap.mmap option.
persistent-nodemap: rename the storage.revlog.nodemap.mmap option
Sun, Jan 17, 2:21 AM
marmoute committed rHG04da2ef8b106: persistent-nodemap: write down the sprint conclusion.
persistent-nodemap: write down the sprint conclusion
Sun, Jan 17, 2:21 AM
marmoute committed rHGa18e256c4d3b: persistent-nodemap: document the `devel.persistent-nodemap` option.
persistent-nodemap: document the `devel.persistent-nodemap` option
Sun, Jan 17, 2:21 AM
marmoute committed rHG599d247af600: copies: fix some comment in _filter.
copies: fix some comment in _filter
Sun, Jan 17, 2:21 AM