Page MenuHomePhabricator

marmoute (Pierre-Yves David)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:56 PM (197 w, 4 d)

Recent Activity

Today

marmoute created D10378: urlutil: add a `get_pull_paths` to perform the pull destination logic.
Tue, Apr 13, 8:19 AM
marmoute created D10379: infinitepush: use the new function to determine push destination.
Tue, Apr 13, 8:19 AM
marmoute created D10377: urlutil: add a `get_push_paths` to perform the push destination logic.
Tue, Apr 13, 8:19 AM

Yesterday

marmoute created D10374: urlutil: extract `url` related code from `util` into the new module.
Mon, Apr 12, 11:37 AM
marmoute created D10375: urlutil: extract `parseurl` from `hg` into the new module.
Mon, Apr 12, 11:32 AM
marmoute created D10373: urlutil: extract `path` related code into a new module.
Mon, Apr 12, 11:30 AM
marmoute created D10372: help: document the `path://` url scheme.
Mon, Apr 12, 11:30 AM
marmoute created D10371: help: point to `hg help urls` in `hg help config.paths`.
Mon, Apr 12, 11:30 AM

Sun, Apr 11

marmoute closed D9765: persistent-nodemap: enable the feature by default when using Rust.
Sun, Apr 11, 7:27 PM
marmoute closed D10315: store: also return some information about the type of file `walk` found.
Sun, Apr 11, 7:25 PM
marmoute committed rHG1c52d77d7861: upgrade: do not hardcore file extension of revlogs.
upgrade: do not hardcore file extension of revlogs
Sun, Apr 11, 7:24 PM
marmoute closed D10317: upgrade: do not hardcore file extension of revlogs.
Sun, Apr 11, 7:24 PM
marmoute committed rHGcf49e54ef965: upgrade: take advantage of the new information returned by `store.walk`.
upgrade: take advantage of the new information returned by `store.walk`
Sun, Apr 11, 7:24 PM
marmoute closed D10316: upgrade: take advantage of the new information returned by `store.walk`.
Sun, Apr 11, 7:24 PM
marmoute committed rHG6085b7f1536d: store: also return some information about the type of file `walk` found.
store: also return some information about the type of file `walk` found
Sun, Apr 11, 7:24 PM
marmoute closed D10338: persistent-nodemap: disable it for test-wireproto-content-redirects.t.
Sun, Apr 11, 7:22 PM
marmoute closed D10337: persistent-nodemap: disable it for test-wireproto-command-capabilities.t.
Sun, Apr 11, 7:22 PM
marmoute committed rHGcc3ad5c3af3b: persistent-nodemap: enable the feature by default when using Rust.
persistent-nodemap: enable the feature by default when using Rust
Sun, Apr 11, 7:22 PM
marmoute committed rHGdf76da69f5b1: persistent-nodemap: disable it for test-wireproto-content-redirects.t.
persistent-nodemap: disable it for test-wireproto-content-redirects.t
Sun, Apr 11, 7:22 PM
marmoute closed D10336: persistent-nodemap: disable it unconditionally for test-wireproto-caching.t.
Sun, Apr 11, 7:22 PM
marmoute closed D10335: persistent-nodemap: disable it unconditionally for test-ssh-proto-unbundle.t.
Sun, Apr 11, 7:22 PM
marmoute committed rHG1b98c9572052: persistent-nodemap: disable it for test-wireproto-command-capabilities.t.
persistent-nodemap: disable it for test-wireproto-command-capabilities.t
Sun, Apr 11, 7:22 PM
marmoute closed D10334: persistent-nodemap: disable it unconditionally for test-ssh-proto.t.
Sun, Apr 11, 7:22 PM
marmoute committed rHG06ebf0cc4f70: persistent-nodemap: disable it unconditionally for test-wireproto-caching.t.
persistent-nodemap: disable it unconditionally for test-wireproto-caching.t
Sun, Apr 11, 7:22 PM
marmoute closed D10333: persistent-nodemap: disable it unconditionally for test-share-safe.t.
Sun, Apr 11, 7:22 PM
marmoute committed rHG8bf21b3869cd: persistent-nodemap: disable it unconditionally for test-ssh-proto-unbundle.t.
persistent-nodemap: disable it unconditionally for test-ssh-proto-unbundle.t
Sun, Apr 11, 7:22 PM
marmoute closed D10332: persistent-nodemap: disable it unconditionally for test-http-protocol.t.
Sun, Apr 11, 7:21 PM
marmoute committed rHGa0d152e5ac17: persistent-nodemap: disable it unconditionally for test-ssh-proto.t.
persistent-nodemap: disable it unconditionally for test-ssh-proto.t
Sun, Apr 11, 7:21 PM
marmoute committed rHGf8f738c24d2f: persistent-nodemap: disable it unconditionally for test-share-safe.t.
persistent-nodemap: disable it unconditionally for test-share-safe.t
Sun, Apr 11, 7:21 PM
marmoute closed D10331: persistent-nodemap: disable it unconditionally for test-http-bad-server.t.
Sun, Apr 11, 7:21 PM
marmoute committed rHG1a85c5d75d53: persistent-nodemap: disable it unconditionally for test-http-protocol.t.
persistent-nodemap: disable it unconditionally for test-http-protocol.t
Sun, Apr 11, 7:21 PM
marmoute committed rHGa8fa270a0e86: persistent-nodemap: disable it unconditionally for test-http-bad-server.t.
persistent-nodemap: disable it unconditionally for test-http-bad-server.t
Sun, Apr 11, 7:21 PM

Fri, Apr 9

marmoute added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

What if we use a different file ? This would allow us to use a different semantic an adjusted plan for a smoother transition.

Fri, Apr 9, 2:54 PM
marmoute added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

What happens in the stream clone case ? Or during the transition from older to newer client ? streaming content from an older clone will not contains a fully up to date cache, and existing repository neither. How are we dealing with this ?
You mention the need to update the cache after stripping, but I don't see such change in the code. am I missing something ?

The cache will fix up itself when it detects missing entries.

Fri, Apr 9, 2:46 PM
marmoute created D10356: config: add an experimental option to list all known config.
Fri, Apr 9, 2:07 PM
marmoute added inline comments to D10332: persistent-nodemap: disable it unconditionally for test-http-protocol.t.
Fri, Apr 9, 6:38 AM
marmoute added a comment to D10346: test-copies: simplify some conditional output.

(I am stopping my review here since I am the actual author of those)

Fri, Apr 9, 6:23 AM
marmoute accepted D10345: bundle2: remove restriction around sidedata.
Fri, Apr 9, 6:11 AM
marmoute accepted D10344: sidedata: enable sidedata computers to optionally rewrite flags.
Fri, Apr 9, 6:11 AM
D10343: cg4: introduce protocol flag to signify the presence of sidedata now requires changes to proceed.
Fri, Apr 9, 6:09 AM
marmoute added inline comments to D10342: changegroup: don't limit cgv4 to revlogv2 repos.
Fri, Apr 9, 6:02 AM
D10341: sidedata: gate sidedata functionality to revlogv2 in more places now requires changes to proceed.

why ?

Fri, Apr 9, 6:00 AM
marmoute added a comment to D10340: sidedata: register copies sidedata computer regardless of the revlog version.

(maybe explain why in your description, the behavior is already "encoded" in the patch)

Fri, Apr 9, 5:59 AM
marmoute accepted D10339: changegroup: update comment.
Fri, Apr 9, 5:58 AM
marmoute accepted D10330: share: store relative share paths with '/' separators.
Fri, Apr 9, 5:54 AM
marmoute added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

Do you have any performance number for that update ? for example the time we need to do that full some known large repositories, and the impact on a clone ?

Fri, Apr 9, 5:24 AM

Thu, Apr 8

Herald added a reviewer for D9765: persistent-nodemap: enable the feature by default when using Rust: durin42.
Thu, Apr 8, 11:38 PM
marmoute added a comment to D10329: rust: Remove the compile-time 'dirstate-tree' feature flag.

This is all true.

Thu, Apr 8, 11:36 PM
marmoute added a comment to D10328: rust: Remove use of `py.eval()`.

+1 (the set binding was not available at the time of writing, but they are not need to keep doing this now.)

Thu, Apr 8, 11:36 PM
marmoute added a comment to D9765: persistent-nodemap: enable the feature by default when using Rust.

Ping on this, let's get this ready and pushed for upcoming release.

Thu, Apr 8, 11:35 PM
marmoute created D10338: persistent-nodemap: disable it for test-wireproto-content-redirects.t.
Thu, Apr 8, 11:35 PM
marmoute created D10337: persistent-nodemap: disable it for test-wireproto-command-capabilities.t.
Thu, Apr 8, 11:34 PM
marmoute created D10336: persistent-nodemap: disable it unconditionally for test-wireproto-caching.t.
Thu, Apr 8, 11:34 PM
marmoute created D10335: persistent-nodemap: disable it unconditionally for test-ssh-proto-unbundle.t.
Thu, Apr 8, 11:34 PM
marmoute created D10334: persistent-nodemap: disable it unconditionally for test-ssh-proto.t.
Thu, Apr 8, 11:34 PM
marmoute created D10333: persistent-nodemap: disable it unconditionally for test-share-safe.t.
Thu, Apr 8, 11:34 PM
marmoute created D10332: persistent-nodemap: disable it unconditionally for test-http-protocol.t.
Thu, Apr 8, 11:34 PM
marmoute created D10331: persistent-nodemap: disable it unconditionally for test-http-bad-server.t.
Thu, Apr 8, 11:34 PM
marmoute added a comment to D10082: tags: redo .hgtags file node cache to work more like the revbranchcache.

What happens in the stream clone case ? Or during the transition from older to newer client ? streaming content from an older clone will not contains a fully up to date cache, and existing repository neither. How are we dealing with this ?

Thu, Apr 8, 11:22 PM
marmoute committed rHG651e6df2b0a4: clang-format: run the formatter on mercurial/cext/revlog.c.
clang-format: run the formatter on mercurial/cext/revlog.c
Thu, Apr 8, 7:01 PM
marmoute committed rHG84a93fa7ecfd: revlog-compression: use zstd by default (if available).
revlog-compression: use zstd by default (if available)
Thu, Apr 8, 7:01 PM
marmoute committed rHG0abf5eba0042: rhg: make rhg recognise it supports zstd compression for revlogs.
rhg: make rhg recognise it supports zstd compression for revlogs
Thu, Apr 8, 7:01 PM
marmoute updated the diff for D10315: store: also return some information about the type of file `walk` found.
Thu, Apr 8, 6:58 PM
marmoute closed D10327: clang-format: run the formatter on mercurial/cext/revlog.c.
Thu, Apr 8, 4:29 PM
marmoute committed rHG15ef92d1c24f: clang-format: run the formatter on mercurial/cext/revlog.c.
clang-format: run the formatter on mercurial/cext/revlog.c
Thu, Apr 8, 4:29 PM
marmoute closed D10326: revlog-compression: use zstd by default (if available).
Thu, Apr 8, 2:21 PM
marmoute committed rHG0c6427951f8c: revlog-compression: use zstd by default (if available).
revlog-compression: use zstd by default (if available)
Thu, Apr 8, 2:17 PM
marmoute closed D10324: rhg: make rhg recognise it supports zstd compression for revlogs.
Thu, Apr 8, 2:17 PM
marmoute committed rHG3c4707065a62: rhg: make rhg recognise it supports zstd compression for revlogs.
rhg: make rhg recognise it supports zstd compression for revlogs
Thu, Apr 8, 2:17 PM
marmoute created D10327: clang-format: run the formatter on mercurial/cext/revlog.c.
Thu, Apr 8, 2:07 PM
D10272: rebase: drop support for rebaseskipobsolete config now requires changes to proceed.

I am +1 on this. I remember there was a discussion on IRC around it but not sure what the end result of that was. @marmoute does having experimental.rebaseskipobsolete serves any purpose?

Thu, Apr 8, 1:16 PM
marmoute added a comment to D10297: tests: update the detailed exit codes in test-phabricator.t.

@marmoute we should add pytest-vcr to heptapod.

Thu, Apr 8, 1:12 PM
marmoute closed D10308: rust: bump rust-cpython version to 0.5.2.
Thu, Apr 8, 6:57 AM
marmoute closed D10306: revlog: move the "index header" struct inside revlog.utils.constants.
Thu, Apr 8, 6:57 AM
marmoute committed rHGc7c6c11fe1e4: rust: bump rust-cpython version to 0.5.2.
rust: bump rust-cpython version to 0.5.2
Thu, Apr 8, 6:57 AM
marmoute committed rHG1dc86c2a43ce: revlog: directly use the Struct object for related operation.
revlog: directly use the Struct object for related operation
Thu, Apr 8, 6:57 AM
marmoute closed D10305: revlog: move the details of revlog "v2" index inside revlog.utils.constants.
Thu, Apr 8, 6:57 AM
marmoute closed D10307: revlog: directly use the Struct object for related operation.
Thu, Apr 8, 6:57 AM
marmoute closed D10304: revlog: move the details of revlog "v1" index inside revlog.utils.constants.
Thu, Apr 8, 6:57 AM
marmoute committed rHGc6e23fb4bfb4: revlog: move the "index header" struct inside revlog.utils.constants.
revlog: move the "index header" struct inside revlog.utils.constants
Thu, Apr 8, 6:56 AM
marmoute closed D10303: revlog: move the details of revlog "v0" index inside revlog.utils.constants.
Thu, Apr 8, 6:56 AM
marmoute committed rHG85e3a630cad9: revlog: move the details of revlog "v2" index inside revlog.utils.constants.
revlog: move the details of revlog "v2" index inside revlog.utils.constants
Thu, Apr 8, 6:56 AM
marmoute committed rHGcc65cea90edb: revlog: move the details of revlog "v1" index inside revlog.utils.constants.
revlog: move the details of revlog "v1" index inside revlog.utils.constants
Thu, Apr 8, 6:56 AM
marmoute closed D10325: revlog-compression: fix computation of engine availability.
Thu, Apr 8, 6:56 AM
marmoute committed rHG34e1fa4b548a: revlog: move the details of revlog "v0" index inside revlog.utils.constants.
revlog: move the details of revlog "v0" index inside revlog.utils.constants
Thu, Apr 8, 6:56 AM
marmoute committed rHGaba724bf550e: revlog: add some comment in the header sections.
revlog: add some comment in the header sections
Thu, Apr 8, 6:56 AM
marmoute closed D10302: revlog: add some comment in the header sections.
Thu, Apr 8, 6:56 AM
marmoute committed rHG6afb5ef1e776: store: drop the `filefilter` argument to `_walk`.
store: drop the `filefilter` argument to `_walk`
Thu, Apr 8, 6:56 AM
marmoute closed D10314: store: drop the `filefilter` argument to `_walk`.
Thu, Apr 8, 6:56 AM
marmoute committed rHGeed3e2b79b48: store: document the `walk` method.
store: document the `walk` method
Thu, Apr 8, 6:56 AM
marmoute closed D10313: store: document the `walk` method.
Thu, Apr 8, 6:56 AM
marmoute committed rHG3aa78f2aea48: revlog-compression: fix computation of engine availability.
revlog-compression: fix computation of engine availability
Thu, Apr 8, 6:55 AM
marmoute closed D10323: test: explicitly use zlib compression in tests/test-share-safe.t.
Thu, Apr 8, 6:55 AM
marmoute closed D10322: test: explicitly use zlib compression in tests/test-upgrade-repo.t.
Thu, Apr 8, 6:55 AM
marmoute committed rHG9dfcadc2cabb: test: explicitly use zlib compression in tests/test-share-safe.t.
test: explicitly use zlib compression in tests/test-share-safe.t
Thu, Apr 8, 6:55 AM
marmoute committed rHG1a17c35fb9fd: test: explicitly use zlib compression in tests/test-upgrade-repo.t.
test: explicitly use zlib compression in tests/test-upgrade-repo.t
Thu, Apr 8, 6:55 AM
marmoute closed D10321: test: explicitly use zlib compression in tests/test-repo-compengines.t.
Thu, Apr 8, 6:55 AM
marmoute committed rHG19747c07ed3f: test: explicitly use zlib compression in tests/test-repo-compengines.t.
test: explicitly use zlib compression in tests/test-repo-compengines.t
Thu, Apr 8, 6:55 AM
marmoute planned changes to D10315: store: also return some information about the type of file `walk` found.
Thu, Apr 8, 6:03 AM

Wed, Apr 7

marmoute created D10326: revlog-compression: use zstd by default (if available).
Wed, Apr 7, 7:59 AM