♟ marmoute

As stated yesterday, I'll have limited screen exposure time available for the next couple of day. I am going to ignore any minor nits during that time. (Am I happy to look at them afterward and follow up).

In D7894#116540, @martinvonz wrote:

In D7894#116407, @marmoute wrote:

In D7894#116397, @martinvonz wrote:

How much does this patch help performance?
I would also like to see performance numbers (even just rough ones) for the Rust version. Sorry about a possibly stupid question, but why will this on-disk nodemap be faster than building it from the index? Is it that the file is smaller and thus faster to read? Or is it more the building of the tree than the reading that's slow? You mentioned you use some private repo for testing this. How large is the 00changelog.n file in that repo and how large is 00changelog.i?

This save hundreds of milli second at initialization of large repositories. The repositories we are looking at are about 2 millions revisions. (but this will help smaller repository too). Mozilla try is a public repository in that range. It 00changelog.i is 103MB

And 00changelog.n?

Can you clarify which change you are actually requesting (I see mostly nits).

changectx: mark parent of changesets as non filtered

changectx: use unfiltered changelog to walk ancestors in annotate

localrepo: also fast past the parents of working copies parents

localrepo: recognize trivial request for '.'

localrepo: fastpath access to "."

localrepo: also fastpath access to working copy parents when possible

Thank you, much appreciated.

In D7894#116397, @martinvonz wrote:

How much does this patch help performance?
I would also like to see performance numbers (even just rough ones) for the Rust version. Sorry about a possibly stupid question, but why will this on-disk nodemap be faster than building it from the index? Is it that the file is smaller and thus faster to read? Or is it more the building of the tree than the reading that's slow? You mentioned you use some private repo for testing this. How large is the 00changelog.n file in that repo and how large is 00changelog.i?

transaction: allow finalizer to add finalizer

Here is raw perf comparison for status, diff and export. We don't have a benchmark for annottate yet. (not too long to write, but I did not had the time to do that yet)

transaction: add a `hasfinalize` method

changelog: fix the diverted opener to accept more kwargs

revlog: reorder a conditionnal about revlogio

utils is older than revlogutils, revlogutils focus on revlog related changes and his worth keeping at this.

mmap: add a size argument to mmapread

revlogutils: move the NodeMap class in a dedicated nodemap module

rust-index: handle `MixedIndex` in `pyindex_to_graph`

marmoute (Pierre-Yves David)
User

Projects

User Details

Recent Activity
View All

Fri, Jan 17

Thu, Jan 16

Wed, Jan 15

Mon, Jan 13

Sat, Jan 11

Thu, Jan 9

Wed, Jan 8

Tue, Jan 7

marmoute (Pierre-Yves David)User