Page MenuHomePhabricator

marmoute (Pierre-Yves David)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:56 PM (111 w, 2 d)

Recent Activity

Today

marmoute committed rHG2119647f127e: rawdata: update callers in storageutils.
rawdata: update callers in storageutils
Sun, Aug 18, 12:08 AM
marmoute committed rHG581a658e3fc8: rawdata: update callers in shallowbundle.
rawdata: update callers in shallowbundle
Sun, Aug 18, 12:08 AM
marmoute committed rHGe11e03190dc0: rawdata: update callers in delta utils.
rawdata: update callers in delta utils
Sun, Aug 18, 12:08 AM
marmoute committed rHGe6c55ad8216e: rawdata: update callers in test-revlog-raw.
rawdata: update callers in test-revlog-raw
Sun, Aug 18, 12:08 AM
marmoute committed rHGa6ad5f477ea1: rawdata: update callers in testing/storage.py.
rawdata: update callers in testing/storage.py
Sun, Aug 18, 12:08 AM
marmoute committed rHG7aac7f009f7c: rawdata: update callers in repository.
rawdata: update callers in repository
Sun, Aug 18, 12:08 AM
marmoute committed rHG0f2069f91bf2: rawdata: update callers in lfs' tests.
rawdata: update callers in lfs' tests
Sun, Aug 18, 12:08 AM
marmoute committed rHGe44d25456503: rawdata: update callers in lfs' wrapper.
rawdata: update callers in lfs' wrapper
Sun, Aug 18, 12:08 AM
marmoute committed rHGa6808d41d0ad: rawdata: update callers in debugcommands.
rawdata: update callers in debugcommands
Sun, Aug 18, 12:08 AM
marmoute committed rHG2d2e35c79ba1: rawdata: update caller in wireprotov2server.
rawdata: update caller in wireprotov2server
Sun, Aug 18, 12:08 AM
marmoute committed rHGac9fed512035: rawdata: update callers in sqlitestore.
rawdata: update callers in sqlitestore
Sun, Aug 18, 12:08 AM
marmoute committed rHGd53975bb429f: rawdata: update caller in remotefilelog.
rawdata: update caller in remotefilelog
Sun, Aug 18, 12:08 AM
marmoute committed rHGe6d5ac170906: rawdata: update callers in bundlerepo.
rawdata: update callers in bundlerepo
Sun, Aug 18, 12:08 AM
marmoute committed rHG1928f7bbe469: rawdata: update callers in context.
rawdata: update callers in context
Sun, Aug 18, 12:08 AM
marmoute committed rHG8890d68b8f8f: rawdata: update caller in revlog.
rawdata: update caller in revlog
Sun, Aug 18, 12:08 AM

Thu, Aug 15

marmoute added a comment to D6709: config: add --registered flag to show all known configs.

I get 28 of them.

Thu, Aug 15, 6:10 AM
marmoute added a comment to D6709: config: add --registered flag to show all known configs.

We will need more than just matching the categoie name to detect experimental/deprecated config. There are such option outside of the experimental section, and we still need to hide them by default. You can grep for # experimental config: to see some example.

Thu, Aug 15, 5:46 AM

Sun, Aug 11

marmoute added inline comments to D6709: config: add --registered flag to show all known configs.
Sun, Aug 11, 7:04 AM

Sat, Aug 10

marmoute committed rHG6d61be152c55: flagutil: move addflagprocessor to the new module (API).
flagutil: move addflagprocessor to the new module (API)
Sat, Aug 10, 7:34 PM
marmoute committed rHG5109217a9ab6: flagutil: move insertflagprocessor to the new module (API).
flagutil: move insertflagprocessor to the new module (API)
Sat, Aug 10, 7:34 PM
marmoute committed rHG92ac6b1697a7: flagutil: move REVIDX_KNOWN_FLAGS source of truth in flagutil (API).
flagutil: move REVIDX_KNOWN_FLAGS source of truth in flagutil (API)
Sat, Aug 10, 7:34 PM
marmoute committed rHG05c80f9ef100: flagutil: move the `flagprocessors` mapping in the new module.
flagutil: move the `flagprocessors` mapping in the new module
Sat, Aug 10, 7:34 PM
marmoute committed rHGca5ca3badd3c: flagutil: create a `mercurial.revlogutils.flagutil` module.
flagutil: create a `mercurial.revlogutils.flagutil` module
Sat, Aug 10, 7:34 PM
marmoute committed rHG64387cd2bf4d: rawdata: implement the method for `unionrepo` too.
rawdata: implement the method for `unionrepo` too
Sat, Aug 10, 4:34 PM
marmoute committed rHGbbe71b5afd02: rawdata: register the method for `ifiledata`.
rawdata: register the method for `ifiledata`
Sat, Aug 10, 4:34 PM
marmoute committed rHG2177133724ab: rawdata: implement `rawdata` for `simplestore` too.
rawdata: implement `rawdata` for `simplestore` too
Sat, Aug 10, 4:34 PM
marmoute committed rHG7492899c6fc6: rawdata: implement the method for `remotefilelog` too.
rawdata: implement the method for `remotefilelog` too
Sat, Aug 10, 4:34 PM
marmoute committed rHG2128c76c8970: rawdata: forward `rawdata` call on `manifestlog`.
rawdata: forward `rawdata` call on `manifestlog`
Sat, Aug 10, 4:34 PM
marmoute committed rHGc9f3f4c8999a: rawdata: implement `rawdata` for `sqlitestore` too.
rawdata: implement `rawdata` for `sqlitestore` too
Sat, Aug 10, 4:34 PM
marmoute committed rHGbf1e8d2ab900: rawdata: forward the method call on `filelog` object.
rawdata: forward the method call on `filelog` object
Sat, Aug 10, 4:34 PM
marmoute committed rHG161d39e9be4b: rawdata: add the method to bundlerevlog.
rawdata: add the method to bundlerevlog
Sat, Aug 10, 4:34 PM
marmoute committed rHG415e4136d326: rawdata: introduce a `rawdata` method on revlog.
rawdata: introduce a `rawdata` method on revlog
Sat, Aug 10, 4:34 PM
marmoute committed rHG389233789952: revlog: split a `_revisiondata` method to file `revision` job.
revlog: split a `_revisiondata` method to file `revision` job
Sat, Aug 10, 4:34 PM
marmoute added inline comments to D6709: config: add --registered flag to show all known configs.
Sat, Aug 10, 2:56 PM

Fri, Aug 9

marmoute committed rHG2c1a484ce4d4: test: further fixes to matching for run-tests.py bug.
test: further fixes to matching for run-tests.py bug
Fri, Aug 9, 8:46 AM

Thu, Aug 8

marmoute added a comment to D6711: branchheads: store wdir-dependent caches in wcache (issue6181).

The change looks good to me, However we probably want to introduce a new filter level 'wdir-independent-visible' to ensure we a good branchcache cache in .hg/cache that most share can use and that will be kept up to date. This also means we need to make sure it is warmed after transaction.

I agree such a thing would be useful, and pretty easy to add (just needs to not remove items considered "pinned" during computehidden, but I'm a little concerned about the proliferation of these things. I think ideally we'd end up with:
visible-hidden > visible > wdir-independent-visible > wdir-independent-served > wdir-independent-served.hidden > immutable > base
and
served > wdir-independent-served > wdir-independent-served.hidden > immutable > base
and
served.hidden > wdir-independent-served.hidden > immutable > base
I think?

Thu, Aug 8, 1:01 PM
marmoute added a comment to D6710: branchmap: explicitly warm+write all subsets of the branchmap caches.

We could warm them in increasing order to improve efficiency. However this is for the full cache warming so this looks good enough. (consider doing them in order in a follow up)

Thu, Aug 8, 12:50 PM
D6719: branchmap: refresh all "heads" of the branchmap subsets now requires changes to proceed.

It seems like we are not warming enought cache with the new scheme.

Thu, Aug 8, 12:47 PM
marmoute added a comment to D6709: config: add --registered flag to show all known configs.

@pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for the following
items in configitems.py. IIUC, it should be visible when we are trying to read a config item which is
not in the registered items. But, we are iterating over registered items only.

Thu, Aug 8, 12:25 PM
marmoute committed rHG978c9a0c5974: demandimport: explicitly declare `_session` at the module level.
demandimport: explicitly declare `_session` at the module level
Thu, Aug 8, 8:48 AM
marmoute committed rHGbac24a8a095a: tests: give more room for slowness in test-run-tests.t.
tests: give more room for slowness in test-run-tests.t
Thu, Aug 8, 8:48 AM

Wed, Aug 7

marmoute committed rHG53c07f08fea1: changectx: extract explicit computechangesetfilesremoved method from context.
changectx: extract explicit computechangesetfilesremoved method from context
Wed, Aug 7, 7:46 PM
marmoute committed rHG87c4cd89b539: changectx: extract explicit computechangesetfilesadded method from context.
changectx: extract explicit computechangesetfilesadded method from context
Wed, Aug 7, 7:46 PM
marmoute committed rHG3cffc7bbec26: copies: extract an explicit `computechangesetcopie` method from context.
copies: extract an explicit `computechangesetcopie` method from context
Wed, Aug 7, 7:46 PM
D6709: config: add --registered flag to show all known configs now requires changes to proceed.
Wed, Aug 7, 10:23 AM
marmoute added a comment to D6712: config: remove pycompat.bytestr() for defaultvalue.

For some reasons, my previous comment seems to have never made it to phabricator:

Wed, Aug 7, 4:20 AM

Tue, Aug 6

marmoute committed rHG0812d9fb63fe: upgrade: introduce the internal code for revlog cloning selection.
upgrade: introduce the internal code for revlog cloning selection
Tue, Aug 6, 8:57 AM
marmoute added a comment to D6710: branchmap: explicitly warm+write all subsets of the branchmap caches.

Forcing this write seems like a good idea. Having it in its own
changeset seems like a good idea (and please add a comment about forcing
the write).

Tue, Aug 6, 6:03 AM

Mon, Aug 5

marmoute committed rHG2c32f0d1ae62: upgrade: introduce the internal code for revlog cloning selection.
upgrade: introduce the internal code for revlog cloning selection
Mon, Aug 5, 10:41 PM
marmoute committed rHG5535a2201ff1: upgrade: introduce a _copyrevlog method.
upgrade: introduce a _copyrevlog method
Mon, Aug 5, 10:41 PM
marmoute committed rHG095dcdd0d55c: upgrade: rename `_copyrevlogs` to `_clonerevlogs`.
upgrade: rename `_copyrevlogs` to `_clonerevlogs`
Mon, Aug 5, 10:32 PM
marmoute committed rHG896fb9deeaf8: upgrade: walk the source store file only once.
upgrade: walk the source store file only once
Mon, Aug 5, 10:32 PM
marmoute committed rHG716d575df275: upgrade: always use full text if "full-add" mode is enable.
upgrade: always use full text if "full-add" mode is enable
Mon, Aug 5, 10:32 PM

Sat, Aug 3

marmoute added a comment to D6711: branchheads: store wdir-dependent caches in wcache (issue6181).

The change looks good to me, However we probably want to introduce a new filter level 'wdir-independent-visible' to ensure we a good branchcache cache in .hg/cache that most share can use and that will be kept up to date. This also means we need to make sure it is warmed after transaction.

Sat, Aug 3, 7:49 AM
marmoute added a comment to D6710: branchmap: explicitly warm+write all subsets of the branchmap caches.

Overall principle seems good. I made couple of inline comment.

Sat, Aug 3, 7:45 AM
marmoute added a comment to D6709: config: add --registered flag to show all known configs.

Interesting feature for sure. Thanks for looking into it.

Sat, Aug 3, 7:42 AM

Fri, Aug 2

marmoute committed rHGe0cf09bc35ef: bookmarks: actual fix for race condition deleting bookmark.
bookmarks: actual fix for race condition deleting bookmark
Fri, Aug 2, 9:09 AM
marmoute committed rHGa1f10edcf6a6: strip: access bookmark before getting a reference to changelog.
strip: access bookmark before getting a reference to changelog
Fri, Aug 2, 9:09 AM
marmoute committed rHG90d8a2a42d5c: test: use a more verbose output in the test.
test: use a more verbose output in the test
Fri, Aug 2, 9:09 AM

Jul 4 2019

marmoute added a comment to D6430: rust-discovery: using from Python code.

In the couple of last version, we already saved minutes in real life use case simply by improving pure CPU processing time client side. Can you elaborate on what other types of evidences you need to convince you there exist CPU bound case for discovery?

Jul 4 2019, 11:06 AM
marmoute committed rHG30033d56758f: debugrevlog: fix average size computation for empty data (issue6167).
debugrevlog: fix average size computation for empty data (issue6167)
Jul 4 2019, 11:01 AM
marmoute added a comment to D6430: rust-discovery: using from Python code.

The ×2.5 speedup is the kind of things that motivate this series. Even if the mozilla-unified/mozilla-try is just and example it triggers the kind of pathological case we encounter in real life: large undecided set. We keep finding such pathological case from time to time, and will keep finding them. In addition there are case with legitimate large undedicated set (the mozilla example for one).
Having this faster code significantly reduce the impact of these pathological cases.

Jul 4 2019, 10:51 AM

Jun 21 2019

marmoute committed rHG3472a3f9d785: localrepo: introduce a `_refreshchangelog` method.
localrepo: introduce a `_refreshchangelog` method
Jun 21 2019, 3:13 PM
marmoute committed rHG044045dce23a: bookmarks: actual fix for race condition deleting bookmark.
bookmarks: actual fix for race condition deleting bookmark
Jun 21 2019, 3:13 PM
marmoute committed rHG95c2f951e502: bookmarks: actually trigger the race deleting bookmark in the test.
bookmarks: actually trigger the race deleting bookmark in the test
Jun 21 2019, 3:13 PM
marmoute committed rHGc4d1807b165f: test: add some assert in the bookrace extension.
test: add some assert in the bookrace extension
Jun 21 2019, 3:13 PM
marmoute committed rHGfebf5c8215c1: test: factor out the "wait" logic in bookrace.
test: factor out the "wait" logic in bookrace
Jun 21 2019, 3:13 PM
marmoute committed rHGcd73e51a1f8a: test: remove dead code in the bookrace extension.
test: remove dead code in the bookrace extension
Jun 21 2019, 3:13 PM
marmoute committed rHGc1850798f995: run-tests: stop matching line for missing feature.
run-tests: stop matching line for missing feature
Jun 21 2019, 3:13 PM

Jun 17 2019

marmoute added a comment to D6419: copies: do full filtering at end of _changesetforwardcopies().

For the record. I am planning to make an extra path on that this week (in case nobody else got there first).

Jun 17 2019, 6:11 PM

Jun 14 2019

marmoute committed rHG4a3abb33380a: deltas: set estimated compression upper bound to "3x" instead of "10x".
deltas: set estimated compression upper bound to "3x" instead of "10x"
Jun 14 2019, 10:56 AM
marmoute committed rHGbc4373babd04: revlog: add the option to track the expected compression upper bound.
revlog: add the option to track the expected compression upper bound
Jun 14 2019, 10:56 AM
marmoute committed rHGa0b26fc8fbba: deltas: skip if projected delta size does not match text size constraint.
deltas: skip if projected delta size does not match text size constraint
Jun 14 2019, 10:56 AM
marmoute committed rHGe4c85e23c9ff: perf: fix perfrevlogwrite --count documentation.
perf: fix perfrevlogwrite --count documentation
Jun 14 2019, 10:55 AM
marmoute committed rHG74e2f4b609f6: perf: clarify some of the custom behavior of `perfrevlogwrite`.
perf: clarify some of the custom behavior of `perfrevlogwrite`
Jun 14 2019, 10:55 AM

Jun 7 2019

marmoute committed rHGb9ff059fd194: discovery: be more conservative when adjusting the sample size.
discovery: be more conservative when adjusting the sample size
Jun 7 2019, 9:48 PM

Jun 5 2019

marmoute added a comment to D6469: bookmarks: use correct store for "ambiguity check".

Ah, I see. The move from ('plain', '') to ('', 'plain') is matching the key used for the vfsmap?
If so, go ahead with this patch on stable.

Jun 5 2019, 3:04 PM
marmoute requested changes to D6469: bookmarks: use correct store for "ambiguity check".

Can we go fully explicit ? Having both plain and store as the possible value?

Jun 5 2019, 7:17 AM

May 28 2019

marmoute committed rHG21c436a3a4e8: perf: add a `perfhelper-mergecopies` command.
perf: add a `perfhelper-mergecopies` command
May 28 2019, 9:59 AM
marmoute committed rHGf5f0a9490c05: perf: add a new `perfmergecopies` command.
perf: add a new `perfmergecopies` command
May 28 2019, 9:59 AM
marmoute committed rHGf0bcbbb6541c: perf: allow to specify the base of the merge in perfmergecalculate.
perf: allow to specify the base of the merge in perfmergecalculate
May 28 2019, 9:59 AM
marmoute committed rHG3a3592b40a95: perf: factor selection of revisions involved in the merge out.
perf: factor selection of revisions involved in the merge out
May 28 2019, 9:59 AM
marmoute committed rHGe3ee707d42ad: perf: add a --from flag to perfmergecalculate.
perf: add a --from flag to perfmergecalculate
May 28 2019, 9:59 AM

May 24 2019

marmoute committed rHG96fc696a9cb2: match: stabilize _rootsdirsandparents doctest.
match: stabilize _rootsdirsandparents doctest
May 24 2019, 8:02 AM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().

(I did some experiment, here seems a good spot to report them)

May 24 2019, 7:17 AM

May 23 2019

marmoute committed rHGa09829e14fc0: perf: make sure to explicitly disable any profiler after the first iteration.
perf: make sure to explicitly disable any profiler after the first iteration
May 23 2019, 7:37 PM

May 22 2019

marmoute committed rHG563cd9a72682: perf: add a `pre-run` option.
perf: add a `pre-run` option
May 22 2019, 7:41 PM
marmoute committed rHG3293086ff663: perf: add an option to profile the benchmark section.
perf: add an option to profile the benchmark section
May 22 2019, 7:41 PM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().

The nodes in the above example have been selected by a script because they had interresting property. They are not based on a tag so I can't give you one. How did you converted the repo ? I think hg convert keeps a map somewhere, otherwise, using the commit message could work.

May 22 2019, 6:29 PM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().

Can you indicate a summary of the total speedup of the series ? (from base to last changesets?). Also I am not sure for which case these number apply ? Is this the compatibility mode or after repository conversion ? Can we have number for both ?

May 22 2019, 2:34 PM
marmoute added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

Something only based on the number of root can also over sample. For a "simple" example, imagine a undecideded set with many roots that eventually all merge into a few heads.
If most of that set is common between local and remote, few question about the part of the history at the heads will quickly "decide" many changesets. Numberous questions at the roots part of the history won't.

May 22 2019, 2:14 PM
marmoute added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

We could maybe make it a function of both the number of heads and roots. That is not strictly the number of connected set, but that would provide a more conservative approach. That could over-sample for hour-glass shape, but they are probably less common.

May 22 2019, 1:41 PM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().
May 22 2019, 6:59 AM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().
May 22 2019, 4:19 AM

May 21 2019

marmoute committed rHGdbd0fcca6dfc: discovery: slowly increase sampling size.
discovery: slowly increase sampling size
May 21 2019, 4:43 PM
marmoute added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

I feel like I am missing something. Your commit message seems to be talking using at least as many item in the sameple than there is independant connected set. However your code seems to use "heads(undecided)" that is a quite different. Using independant connected set seems like a good trade off (but might be expensive to compute). Using all heads can significantly bloat the discovery without giving it a significant edge in many cases.

May 21 2019, 4:17 PM

May 20 2019

marmoute committed rHG2338bdea4474: bookmark: also make bookmark cache depends of the changelog.
bookmark: also make bookmark cache depends of the changelog
May 20 2019, 11:46 AM
marmoute committed rHGc2b83c957621: localrepo: grab mixedrepostorecache class from 526750cdd02d.
localrepo: grab mixedrepostorecache class from 526750cdd02d
May 20 2019, 11:46 AM
marmoute committed rHGd2c871b78c36: bookmark: add a test for a race condition on push.
bookmark: add a test for a race condition on push
May 20 2019, 11:46 AM
marmoute committed rHG624080e8bd9f: test: properly gate a zstd section.
test: properly gate a zstd section
May 20 2019, 11:46 AM