Page MenuHomePhabricator

marmoute (Pierre-Yves David)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:56 PM (178 w, 6 d)

Recent Activity

Today

marmoute created D9513: phab-refresh: do not error out when the stack is empty.
Thu, Dec 3, 2:11 AM

Yesterday

marmoute created D9507: run-tests: allow some slack about 'waiting on lock' message.
Wed, Dec 2, 5:20 PM
marmoute created D9506: pull: flush stdin after the `pull from` message.
Wed, Dec 2, 5:20 PM
marmoute created D9504: tests: use the right python when running dummyssh for narrow.
Wed, Dec 2, 5:19 PM
marmoute created D9505: tests: explicitly skip the lock warning in some remotefilelog tests.
Wed, Dec 2, 5:19 PM
marmoute added inline comments to D9469: upgrade: display the list of processed revlog before proceeding.
Wed, Dec 2, 1:18 PM
marmoute added inline comments to D9493: copies-rust: tokenize all paths into integer.
Wed, Dec 2, 12:08 PM
marmoute created D9499: copies-rust: record overwrite when merging.
Wed, Dec 2, 11:03 AM
marmoute created D9498: copies-rust: make the comparison aware of the revision being current merged.
Wed, Dec 2, 11:03 AM
marmoute created D9497: copies-rust: start recording overwrite as they happens.
Wed, Dec 2, 11:03 AM
marmoute created D9496: copies-rust: rename Oracle.is_ancestor to Oracle.is_overwrite.
Wed, Dec 2, 11:02 AM
marmoute created D9495: copies-rust: use the `entry` API for copy information too.
Wed, Dec 2, 11:02 AM
marmoute created D9494: copies-rust: use the entry API to overwrite deleted entry.
Wed, Dec 2, 11:02 AM
marmoute created D9493: copies-rust: tokenize all paths into integer.
Wed, Dec 2, 11:02 AM
marmoute created D9492: copies-rust: pre-introduce a PathToken type and use it where applicable.
Wed, Dec 2, 11:02 AM
marmoute created D9491: copies-rust: add smarter approach for merging small mapping with large mapping.
Wed, Dec 2, 11:02 AM
marmoute accepted D9462: chgserver: catch RepoError while loading configuration.
Wed, Dec 2, 3:05 AM
marmoute closed D9468: upgrade: add an explicite --filelogs arguments.
Wed, Dec 2, 3:05 AM
marmoute committed rHG7c539f0febbe: upgrade: add an explicite --filelogs arguments.
upgrade: add an explicite --filelogs arguments
Wed, Dec 2, 3:04 AM
marmoute updated the diff for D9468: upgrade: add an explicite --filelogs arguments.
Wed, Dec 2, 3:00 AM
marmoute updated the diff for D9469: upgrade: display the list of processed revlog before proceeding.
Wed, Dec 2, 3:00 AM

Tue, Dec 1

marmoute closed D9475: upgrade: move optimisation to something more declarative.
Tue, Dec 1, 11:42 PM
marmoute closed D9474: upgrade: capitalize the `deficiency` constant.
Tue, Dec 1, 11:42 PM
marmoute committed rHG32dcd783a985: upgrade: move optimisation to something more declarative.
upgrade: move optimisation to something more declarative
Tue, Dec 1, 11:42 PM
marmoute closed D9473: upgrade: capitalize the `deficiency` constant.
Tue, Dec 1, 11:42 PM
marmoute committed rHGcfae98c4e1f1: upgrade: capitalize the `deficiency` constant.
upgrade: capitalize the `deficiency` constant
Tue, Dec 1, 11:42 PM
marmoute committed rHG8037d0641146: upgrade: capitalize the `deficiency` constant.
upgrade: capitalize the `deficiency` constant
Tue, Dec 1, 11:42 PM
marmoute closed D9451: heptapod-ci: automatically refresh existing phabricator Diff on push.
Tue, Dec 1, 11:03 PM
marmoute committed rHGc7f40562389f: heptapod-ci: automatically refresh existing phabricator Diff on push.
heptapod-ci: automatically refresh existing phabricator Diff on push
Tue, Dec 1, 11:03 PM
marmoute closed D9460: contrib: add a small script to refresh all diff in the current stack.
Tue, Dec 1, 11:03 PM
marmoute committed rHG5de27798d2af: contrib: add a small script to refresh all diff in the current stack.
contrib: add a small script to refresh all diff in the current stack
Tue, Dec 1, 11:03 PM
marmoute created D9487: upgrade: start moving the "to be happening" data in a dedicated object.
Tue, Dec 1, 5:12 PM
marmoute created D9486: upgrade: gather code about requirement checking together.
Tue, Dec 1, 5:12 PM
marmoute created D9485: upgrade: extract the checking of target requirements change.
Tue, Dec 1, 5:12 PM
marmoute created D9484: upgrade: drop an outdated comment.
Tue, Dec 1, 5:12 PM
marmoute created D9483: upgrade: gather code about source checking together.
Tue, Dec 1, 5:12 PM
marmoute created D9482: upgrade: move requirements checking in a dedicated function.
Tue, Dec 1, 5:11 PM
marmoute created D9477: upgrade: split definition and management of the actions from the main code.
Tue, Dec 1, 9:28 AM
marmoute created D9476: upgrade: split actual upgrade code away from the main module.
Tue, Dec 1, 9:28 AM
marmoute added a comment to D9468: upgrade: add an explicite --filelogs arguments.

This make it possible to select no revlog for upgrade, which is useful for some
upgrade target or in some specific cases.

Can you mention the cases you are talking about in commit message? I guess these are related to copy-info ones but not sure.

No they are related to case where do don't need to touch the revlogs diff at all, like persistent-nodemap or share-safe

In that case, we can better have --no-revlogs or something similar. It won't be obvious that --filelog can be or is meant to be used for such purposes.

Tue, Dec 1, 7:37 AM
marmoute created D9475: upgrade: move optimisation to something more declarative.
Tue, Dec 1, 4:55 AM
marmoute created D9474: upgrade: capitalize the `deficiency` constant.
Tue, Dec 1, 4:54 AM
marmoute created D9473: upgrade: capitalize the `deficiency` constant.
Tue, Dec 1, 4:54 AM
marmoute updated the summary of D9468: upgrade: add an explicite --filelogs arguments.
Tue, Dec 1, 4:54 AM
marmoute added a comment to D9468: upgrade: add an explicite --filelogs arguments.

This make it possible to select no revlog for upgrade, which is useful for some
upgrade target or in some specific cases.

Can you mention the cases you are talking about in commit message? I guess these are related to copy-info ones but not sure.

Tue, Dec 1, 3:16 AM
marmoute updated the diff for D9307: copies-rust: parse the changed-file sidedata directly in rust.
Tue, Dec 1, 3:14 AM

Mon, Nov 30

marmoute committed rHGf9f8d8aa9a92: copies: clarify the return of _merge_copies_dict.
copies: clarify the return of _merge_copies_dict
Mon, Nov 30, 4:14 PM
marmoute committed rHGd42809b6b10f: rust-format: pin the formatted to a specific nightly version.
rust-format: pin the formatted to a specific nightly version
Mon, Nov 30, 4:14 PM
marmoute committed rHGb6b7626d3e06: copies: avoid unwanted side effect from one branch to another.
copies: avoid unwanted side effect from one branch to another
Mon, Nov 30, 4:14 PM
marmoute closed D9418: copies: clarify the return of _merge_copies_dict.
Mon, Nov 30, 12:24 PM
marmoute committed rHGd0dbd6a41074: rust-format: pin the formatted to a specific nightly version.
rust-format: pin the formatted to a specific nightly version
Mon, Nov 30, 12:24 PM
marmoute committed rHG2f3516a0d942: copies: clarify the return of _merge_copies_dict.
copies: clarify the return of _merge_copies_dict
Mon, Nov 30, 12:24 PM
marmoute closed D9416: copies: avoid unwanted side effect from one branch to another.
Mon, Nov 30, 12:24 PM
marmoute committed rHGf1cb44527819: copies: avoid unwanted side effect from one branch to another.
copies: avoid unwanted side effect from one branch to another
Mon, Nov 30, 12:24 PM
marmoute closed D9467: upgrade: directly use the upgrade action constant.
Mon, Nov 30, 12:24 PM
marmoute closed D9466: upgrade: rename UPGRADE_FILELOG to UPGRADE_FILELOGS.
Mon, Nov 30, 12:24 PM
marmoute committed rHG53bde3ad0270: upgrade: directly use the upgrade action constant.
upgrade: directly use the upgrade action constant
Mon, Nov 30, 12:24 PM
marmoute committed rHGfe7d7917ceb5: upgrade: rename UPGRADE_FILELOG to UPGRADE_FILELOGS.
upgrade: rename UPGRADE_FILELOG to UPGRADE_FILELOGS
Mon, Nov 30, 12:24 PM
marmoute created D9468: upgrade: add an explicite --filelogs arguments.
Mon, Nov 30, 10:44 AM
marmoute created D9469: upgrade: display the list of processed revlog before proceeding.
Mon, Nov 30, 10:44 AM
marmoute created D9467: upgrade: directly use the upgrade action constant.
Mon, Nov 30, 10:43 AM
marmoute created D9466: upgrade: rename UPGRADE_FILELOG to UPGRADE_FILELOGS.
Mon, Nov 30, 10:43 AM
marmoute added a comment to D9463: tests: conditionalize return code on chg in test-config.t.

Why do we have a different return code than the non-chg code ?

Mon, Nov 30, 4:48 AM
marmoute added a comment to D9462: chgserver: catch RepoError while loading configuration.

Looks okay. Alternatively, you could have a try: except Exception: with a re-raise. But the current code is "good enough" and we need these tests green.

Mon, Nov 30, 4:48 AM
marmoute added a comment to D9414: tests: update test-chg.t with output change.

This looks good.

Mon, Nov 30, 4:46 AM
marmoute added inline comments to D9418: copies: clarify the return of _merge_copies_dict.
Mon, Nov 30, 4:27 AM
marmoute added a comment to D9416: copies: avoid unwanted side effect from one branch to another.

I started writing more test in that regards, but I a submitting this changes earlier because I want to get more code landed to allow other optimisation work to happens.

Shall we expect tests for this future in series?

Mon, Nov 30, 4:24 AM

Sun, Nov 29

marmoute updated the diff for D9426: copies-rust: hide most of the comparison details inside a closure.
Sun, Nov 29, 3:29 PM
marmoute updated the diff for D9425: copies-rust: move the mapping merging into a else clause.
Sun, Nov 29, 3:29 PM
marmoute updated the diff for D9422: copies: iterate over children directly (instead of parents).
Sun, Nov 29, 3:29 PM
marmoute updated the diff for D9424: copies-rust: extract conflicting value comparison in its own function.
Sun, Nov 29, 3:29 PM
marmoute updated the diff for D9421: copies-rust: extract the processing of a ChangedFiles in its own function.
Sun, Nov 29, 3:29 PM
marmoute updated the diff for D9420: copies-rust: move the parent token to an enum.
Sun, Nov 29, 3:29 PM
marmoute updated the diff for D9307: copies-rust: parse the changed-file sidedata directly in rust.
Sun, Nov 29, 3:29 PM
marmoute updated the diff for D9416: copies: avoid unwanted side effect from one branch to another.
Sun, Nov 29, 3:29 PM
marmoute closed D9417: copies: simplify the call to _merge_copies_dict.
Sun, Nov 29, 2:56 PM
marmoute closed D9415: copies: fast path no-op merge.
Sun, Nov 29, 2:56 PM
marmoute closed D9306: copies-rust: encapsulate internal sets on `changes`.
Sun, Nov 29, 2:56 PM
marmoute committed rHG7d3c51c728c9: copies: simplify the call to _merge_copies_dict.
copies: simplify the call to _merge_copies_dict
Sun, Nov 29, 2:56 PM
marmoute committed rHGcf04af3a5ef1: copies: fast path no-op merge.
copies: fast path no-op merge
Sun, Nov 29, 2:56 PM
marmoute closed D9305: copies-rust: pre-indent some code to clarify the next patch.
Sun, Nov 29, 2:56 PM
marmoute closed D9303: copies-rust: move is_ancestor caching within the rust code.
Sun, Nov 29, 2:56 PM
marmoute committed rHG2367937982ba: copies-rust: encapsulate internal sets on `changes`.
copies-rust: encapsulate internal sets on `changes`
Sun, Nov 29, 2:56 PM
marmoute closed D9304: copies-rust: combine the iteration over remove and copies into one.
Sun, Nov 29, 2:55 PM
marmoute committed rHG10bb0856bb9f: copies-rust: pre-indent some code to clarify the next patch.
copies-rust: pre-indent some code to clarify the next patch
Sun, Nov 29, 2:55 PM
marmoute closed D9453: phabricator: use the `http.timeout` config for conduit call.
Sun, Nov 29, 2:55 PM
marmoute committed rHGed0e1339e4a8: copies-rust: combine the iteration over remove and copies into one.
copies-rust: combine the iteration over remove and copies into one
Sun, Nov 29, 2:55 PM
marmoute committed rHG8b99c473aae2: copies-rust: move is_ancestor caching within the rust code.
copies-rust: move is_ancestor caching within the rust code
Sun, Nov 29, 2:55 PM
marmoute closed D9449: phabricator: introduce a `phabricator.retry` option.
Sun, Nov 29, 2:55 PM
marmoute closed D9302: copies-rust: leverage the immutability for efficient update.
Sun, Nov 29, 2:55 PM
marmoute committed rHGcc759d3db1e8: copies-rust: leverage the immutability for efficient update.
copies-rust: leverage the immutability for efficient update
Sun, Nov 29, 2:55 PM
marmoute committed rHG4d70444c3ea9: phabricator: use the `http.timeout` config for conduit call.
phabricator: use the `http.timeout` config for conduit call
Sun, Nov 29, 2:55 PM
marmoute committed rHG57183111a463: phabricator: introduce a `phabricator.retry` option.
phabricator: introduce a `phabricator.retry` option
Sun, Nov 29, 2:55 PM
marmoute closed D9300: copies-rust: use immutable "OrdMap" to store copies information.
Sun, Nov 29, 1:40 PM
marmoute committed rHG3302584ac0c7: heptapod-ci: do not publish changeset when doing the local clone.
heptapod-ci: do not publish changeset when doing the local clone
Sun, Nov 29, 1:40 PM
marmoute closed D9461: heptapod-ci: do not publish changeset when doing the local clone.
Sun, Nov 29, 1:40 PM
marmoute closed D9301: copies-rust: pre-indent some code to clarify the next changeset.
Sun, Nov 29, 1:40 PM
marmoute committed rHG0d99778af68a: copies-rust: use immutable "OrdMap" to store copies information.
copies-rust: use immutable "OrdMap" to store copies information
Sun, Nov 29, 1:40 PM
marmoute committed rHG46a16b2c082d: copies-rust: pre-indent some code to clarify the next changeset.
copies-rust: pre-indent some code to clarify the next changeset
Sun, Nov 29, 1:40 PM
marmoute closed D9299: copies: use the rust code for `combine_changeset_copies`.
Sun, Nov 29, 1:40 PM