♟ marmoute

upgrade: add an explicite --filelogs arguments

upgrade: move optimisation to something more declarative

upgrade: capitalize the `deficiency` constant

heptapod-ci: automatically refresh existing phabricator Diff on push

contrib: add a small script to refresh all diff in the current stack

In D9468#142463, @pulkit wrote:

In D9468#142432, @marmoute wrote:

In D9468#142362, @pulkit wrote:

This make it possible to select no revlog for upgrade, which is useful for some
upgrade target or in some specific cases.

Can you mention the cases you are talking about in commit message? I guess these are related to copy-info ones but not sure.

No they are related to case where do don't need to touch the revlogs diff at all, like persistent-nodemap or share-safe

In that case, we can better have --no-revlogs or something similar. It won't be obvious that --filelog can be or is meant to be used for such purposes.

In D9468#142362, @pulkit wrote:

This make it possible to select no revlog for upgrade, which is useful for some
upgrade target or in some specific cases.

Can you mention the cases you are talking about in commit message? I guess these are related to copy-info ones but not sure.

copies: clarify the return of _merge_copies_dict

rust-format: pin the formatted to a specific nightly version

copies: avoid unwanted side effect from one branch to another

rust-format: pin the formatted to a specific nightly version

copies: clarify the return of _merge_copies_dict

copies: avoid unwanted side effect from one branch to another

upgrade: directly use the upgrade action constant

upgrade: rename UPGRADE_FILELOG to UPGRADE_FILELOGS

Why do we have a different return code than the non-chg code ?

Looks okay. Alternatively, you could have a try: except Exception: with a re-raise. But the current code is "good enough" and we need these tests green.

In D9416#142205, @pulkit wrote:

I started writing more test in that regards, but I a submitting this changes earlier because I want to get more code landed to allow other optimisation work to happens.

Shall we expect tests for this future in series?

copies: simplify the call to _merge_copies_dict

copies: fast path no-op merge

copies-rust: encapsulate internal sets on `changes`

copies-rust: pre-indent some code to clarify the next patch

copies-rust: combine the iteration over remove and copies into one

copies-rust: move is_ancestor caching within the rust code

copies-rust: leverage the immutability for efficient update

phabricator: use the `http.timeout` config for conduit call

phabricator: introduce a `phabricator.retry` option

heptapod-ci: do not publish changeset when doing the local clone

copies-rust: use immutable "OrdMap" to store copies information

copies-rust: pre-indent some code to clarify the next changeset

marmoute (Pierre-Yves David)
User

Projects

User Details

Recent Activity
View All

Today

Yesterday

Tue, Dec 1

Mon, Nov 30

Sun, Nov 29

marmoute (Pierre-Yves David)User