Page MenuHomePhabricator

marmoute (Pierre-Yves David)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:56 PM (128 w, 8 h)

Recent Activity

Today

marmoute added a comment to D7492: localrepo: also fastpath access to working copy parents when possible.

Hmm, I thought this entire series had been queued. I'd like to queue it. Can you include perf numbers?

Thu, Dec 12, 7:42 AM

Yesterday

marmoute closed D7590: remotefilelog: remove the `ensurestart` usage.
Wed, Dec 11, 12:29 PM
marmoute closed D7589: remotefilelog: remove most of the debugwait* command in the tests.
Wed, Dec 11, 12:29 PM
marmoute closed D7587: remotefilelog: remove most sleep in tests.
Wed, Dec 11, 12:29 PM
marmoute added a reverting change for D6772: remotefilelog: reduce probability of race-condition in remotefilelog tests: rHG612b4b63fb22: remotefilelog: remove the `ensurestart` usage.
Wed, Dec 11, 12:29 PM
marmoute added a reverting change for rHG2c74337e6483: remotefilelog: reduce probability of race-condition in remotefilelog tests: rHG612b4b63fb22: remotefilelog: remove the `ensurestart` usage.
Wed, Dec 11, 12:29 PM
marmoute added reverted changes for rHG612b4b63fb22: remotefilelog: remove the `ensurestart` usage: rHG2c74337e6483: remotefilelog: reduce probability of race-condition in remotefilelog tests, D6772: remotefilelog: reduce probability of race-condition in remotefilelog tests.
remotefilelog: remove the `ensurestart` usage
Wed, Dec 11, 12:29 PM
marmoute closed D7586: remotefilelog: have command wait for background task in the tests.
Wed, Dec 11, 12:29 PM
marmoute committed rHG4f40dc190f63: remotefilelog: remove most of the debugwait* command in the tests.
remotefilelog: remove most of the debugwait* command in the tests
Wed, Dec 11, 12:28 PM
marmoute committed rHGb6c7475595db: remotefilelog: use the correct redirection in tests.
remotefilelog: use the correct redirection in tests
Wed, Dec 11, 12:28 PM
marmoute closed D7585: remotefilelog: add a developer option to wait for background processes.
Wed, Dec 11, 12:28 PM
marmoute closed D7588: remotefilelog: use the correct redirection in tests.
Wed, Dec 11, 12:28 PM
marmoute committed rHGfac25de8cbec: remotefilelog: remove most sleep in tests.
remotefilelog: remove most sleep in tests
Wed, Dec 11, 12:28 PM
marmoute committed rHG88ab1295db4c: remotefilelog: have command wait for background task in the tests.
remotefilelog: have command wait for background task in the tests
Wed, Dec 11, 12:28 PM
marmoute committed rHG63bb6dc62f24: remotefilelog: add a developer option to wait for background processes.
remotefilelog: add a developer option to wait for background processes
Wed, Dec 11, 12:28 PM
marmoute committed rHG15a6c6783060: procutil: add a option to not fully detach background process.
procutil: add a option to not fully detach background process
Wed, Dec 11, 12:28 PM
marmoute closed D7584: procutil: add a option to not fully detach background process.
Wed, Dec 11, 12:28 PM
marmoute closed D7602: manifestcache: add some test involving shares.
Wed, Dec 11, 6:54 AM
marmoute committed rHG8377570a36a9: manifestcache: add some test involving shares.
manifestcache: add some test involving shares
Wed, Dec 11, 6:54 AM
marmoute added a comment to D7586: remotefilelog: have command wait for background task in the tests.

For those who wants to see the test misbehaving, your just need to run it in a loop on heavy load:
python run-tests.py --runs-per-test 10000 --loop -j 90 test-remotefilelog-bgprefetch.t

Wed, Dec 11, 5:26 AM
marmoute created D7602: manifestcache: add some test involving shares.
Wed, Dec 11, 5:16 AM

Mon, Dec 9

marmoute updated the diff for D7590: remotefilelog: remove the `ensurestart` usage.
Mon, Dec 9, 10:52 AM
marmoute updated the summary of D7585: remotefilelog: add a developer option to wait for background processes.
Mon, Dec 9, 10:51 AM
marmoute updated the diff for D7584: procutil: add a option to not fully detach background process.
Mon, Dec 9, 10:51 AM
marmoute added a comment to D7590: remotefilelog: remove the `ensurestart` usage.

good spot. I'll update that last patch.

Mon, Dec 9, 10:18 AM
marmoute created D7590: remotefilelog: remove the `ensurestart` usage.

target is the stable-branch

Mon, Dec 9, 8:03 AM
marmoute created D7589: remotefilelog: remove most of the debugwait* command in the tests.

target is the stable-branch

Mon, Dec 9, 8:03 AM
marmoute created D7587: remotefilelog: remove most sleep in tests.

target is the stable-branch

Mon, Dec 9, 8:03 AM
marmoute added a reverting change for D6772: remotefilelog: reduce probability of race-condition in remotefilelog tests: D7590: remotefilelog: remove the `ensurestart` usage.
Mon, Dec 9, 8:03 AM
marmoute added a reverting change for rHG2c74337e6483: remotefilelog: reduce probability of race-condition in remotefilelog tests: D7590: remotefilelog: remove the `ensurestart` usage.
Mon, Dec 9, 8:02 AM
marmoute created D7588: remotefilelog: use the correct redirection in tests.

target is the stable-branch

Mon, Dec 9, 8:02 AM
marmoute created D7586: remotefilelog: have command wait for background task in the tests.

target is the stable-branch

Mon, Dec 9, 8:02 AM
marmoute created D7585: remotefilelog: add a developer option to wait for background processes.

target is the stable-branch

Mon, Dec 9, 8:02 AM
marmoute created D7584: procutil: add a option to not fully detach background process.

target is the stable-branch

Mon, Dec 9, 8:02 AM

Sat, Dec 7

marmoute committed rHGacbb55b8e9dc: upgraderepo: add a config option for parallel computation.
upgraderepo: add a config option for parallel computation
Sat, Dec 7, 12:54 PM
marmoute committed rHGad84fc97d120: upgrade-repo: colorize some of the output.
upgrade-repo: colorize some of the output
Sat, Dec 7, 12:54 PM

Fri, Dec 6

marmoute committed rHG982a91c23849: upgraderepo: add a config option for parallel computation.
upgraderepo: add a config option for parallel computation
Fri, Dec 6, 3:50 PM
marmoute committed rHG91007890d366: upgrade-repo: colorize some of the output.
upgrade-repo: colorize some of the output
Fri, Dec 6, 3:50 PM

Wed, Dec 4

marmoute added a comment to D7116: rust-performance: introduce FastHashMap type alias for HashMap.

Any update on this ? I'll need it for my work on copy tracing. Reading the review thread, there is no remaining blocker to land this.

Wed, Dec 4, 9:19 AM

Tue, Dec 3

marmoute committed rHG421ea5772039: copies: split the combination of the copies mapping in its own function.
copies: split the combination of the copies mapping in its own function
Tue, Dec 3, 10:59 AM
marmoute committed rHG995066c41bb2: copies: expand `_chain` variable name to make the function easier to read.
copies: expand `_chain` variable name to make the function easier to read
Tue, Dec 3, 10:59 AM
marmoute committed rHG3b039e43a1e6: copies: do not initialize the dictionary with root in changeset copies.
copies: do not initialize the dictionary with root in changeset copies
Tue, Dec 3, 10:59 AM
marmoute committed rHGbbd7172bc3df: copies: show we can read data from the "first" mapping.
copies: show we can read data from the "first" mapping
Tue, Dec 3, 10:59 AM
marmoute committed rHG79750d781928: copies: return consistent type from revinfo.
copies: return consistent type from revinfo
Tue, Dec 3, 10:59 AM
marmoute committed rHGd4c2221240a6: repoview: add an explicit set of all filter that show the wc parents.
repoview: add an explicit set of all filter that show the wc parents
Tue, Dec 3, 10:59 AM
marmoute committed rHGf3b23d5c15fd: changectx: mark the parents of the working copy as non filtered.
changectx: mark the parents of the working copy as non filtered
Tue, Dec 3, 10:59 AM
marmoute committed rHGe89e3275f658: localrepo: introduce a `_quick_access_changeid` property.
localrepo: introduce a `_quick_access_changeid` property
Tue, Dec 3, 10:59 AM
marmoute committed rHGf9068413bd0c: changectx: use unfiltered changelog to access parents of unfiltered revs.
changectx: use unfiltered changelog to access parents of unfiltered revs
Tue, Dec 3, 10:59 AM
marmoute committed rHGf1c49bc79b4d: repoview: add more tests to track operation not supposed to trigger filtering.
repoview: add more tests to track operation not supposed to trigger filtering
Tue, Dec 3, 10:59 AM
marmoute committed rHG3fd6ec54704c: locarepo: also fastpath `nullid` lookup in __getitem__.
locarepo: also fastpath `nullid` lookup in __getitem__
Tue, Dec 3, 10:59 AM
marmoute committed rHGb38cd2e6e12d: localrepo: mark nullrev has never filtered.
localrepo: mark nullrev has never filtered
Tue, Dec 3, 10:59 AM
marmoute committed rHG1e87851dba63: changectx: add a "maybe filtered" filtered attribute.
changectx: add a "maybe filtered" filtered attribute
Tue, Dec 3, 10:59 AM
marmoute committed rHG1a415548794a: repoview: add a test that access actual changeset data of `null`.
repoview: add a test that access actual changeset data of `null`
Tue, Dec 3, 10:59 AM
marmoute committed rHG09409a3fc3cc: localrepo: recognize trivial "null" queries in `anyrev`.
localrepo: recognize trivial "null" queries in `anyrev`
Tue, Dec 3, 10:59 AM
marmoute committed rHG998dd6a8fd98: localrepo: also fastpath `nullrev` in __getitem__.
localrepo: also fastpath `nullrev` in __getitem__
Tue, Dec 3, 10:59 AM
marmoute committed rHG3082ef682bc2: repoview: add a test to track operation not supposed to trigger filtering.
repoview: add a test to track operation not supposed to trigger filtering
Tue, Dec 3, 10:59 AM
marmoute committed rHGd2a7f0aab540: repoview: display stack trace along side the debug message.
repoview: display stack trace along side the debug message
Tue, Dec 3, 10:59 AM
marmoute committed rHG02ededbef627: util: add an optional `prefix` argument to debugstacktrace.
util: add an optional `prefix` argument to debugstacktrace
Tue, Dec 3, 10:59 AM
marmoute committed rHG2276a9a1c037: repoview: add a 'devel.debug.repo-filter' option.
repoview: add a 'devel.debug.repo-filter' option
Tue, Dec 3, 10:59 AM
marmoute committed rHG657bdb724b47: localrepo: extract handling of some special value in __getitem__.
localrepo: extract handling of some special value in __getitem__
Tue, Dec 3, 10:59 AM
marmoute committed rHG6237cb11753e: localrepo: extract handling of some special value in __getitem__.
localrepo: extract handling of some special value in __getitem__
Tue, Dec 3, 10:59 AM
marmoute committed rHG9c83d28776af: localrepo: add some basic comment for block in __getitem__.
localrepo: add some basic comment for block in __getitem__
Tue, Dec 3, 10:59 AM

Mon, Dec 2

marmoute committed rHG0cc916004f22: copies: split the combination of the copies mapping in its own function.
copies: split the combination of the copies mapping in its own function
Mon, Dec 2, 8:22 AM
marmoute committed rHGfb8f10c0fe88: copies: do not initialize the dictionary with root in changeset copies.
copies: do not initialize the dictionary with root in changeset copies
Mon, Dec 2, 8:22 AM
marmoute committed rHGb0f5d8eb703b: copies: expand `_chain` variable name to make the function easier to read.
copies: expand `_chain` variable name to make the function easier to read
Mon, Dec 2, 8:22 AM
marmoute committed rHGbfaa4a046c1f: copies: show we can read data from the "first" mapping.
copies: show we can read data from the "first" mapping
Mon, Dec 2, 8:22 AM
marmoute committed rHG7655276a4441: copies: return consistent type from revinfo.
copies: return consistent type from revinfo
Mon, Dec 2, 8:22 AM

Fri, Nov 29

marmoute added a comment to D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix.

I am fine with not having all test passing from the start. However here we have a test that used to pass that is now failing, so we regressed here. I would rather not regress in test coverage here. Without this, all mercurial test pass with the Rust code, I would like to keep it that way.

Fri, Nov 29, 10:01 AM
marmoute added a comment to D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix.
In D7503#110631, @yuja wrote:
> Okay, then using non-debug `assert!()` seems more appropriate. If we prefer
> being stricter, "checked" HgPath type can be introduced.
> ...
> Actually I tried to suppress these warnings by propagating Result upwards,
> and I got a feeling that we're doing wrong.
I sent a followup as D7522 <https://phab.mercurial-scm.org/D7522> because that gets rid of the warnings. As explained in the commit message, I am unhappy about this change, as you seem to be.

Thanks. Given Rust impl is still unstable, I think it's better to back out
the changes in Rust and leave the test failure until we find a right solution.

Fri, Nov 29, 6:00 AM

Tue, Nov 26

marmoute added a comment to D7512: exchange: guard against method invocation on `b2caps=None` args.
Tue, Nov 26, 10:06 AM

Sun, Nov 24

marmoute updated the diff for D7502: changectx: mark parent of changesets as non filtered.
Sun, Nov 24, 6:27 AM
marmoute updated the diff for D7492: localrepo: also fastpath access to working copy parents when possible.
Sun, Nov 24, 6:27 AM
marmoute updated the diff for D7501: changectx: use unfiltered changelog to walk ancestors in annotate.
Sun, Nov 24, 6:27 AM
marmoute updated the diff for D7498: localrepo: also fast past the parents of working copies parents.
Sun, Nov 24, 6:27 AM
marmoute updated the diff for D7495: localrepo: recognize trivial request for '.'.
Sun, Nov 24, 6:27 AM
marmoute updated the diff for D7494: localrepo: fastpath access to ".".
Sun, Nov 24, 6:26 AM
marmoute added a comment to D7481: localrepo: recognize trivial "null" queries in `anyrev`.
In D7481#110524, @yuja wrote:

+ if specs == [b'null']:
+ return revset.baseset([nullrev])

This breaks --config revsetalias.null=<whatever>. Nobody would care, but
I don't know why we're so hard to optimize -r null query.

Sun, Nov 24, 6:24 AM

Sat, Nov 23

marmoute closed D7491: changectx: mark the parents of the working copy as non filtered.
Sat, Nov 23, 8:00 PM
marmoute closed D7488: localrepo: introduce a `_quick_access_changeid` property.
Sat, Nov 23, 7:59 PM
marmoute closed D7487: changectx: use unfiltered changelog to access parents of unfiltered revs.
Sat, Nov 23, 7:59 PM
marmoute committed rHG0e72b2518f0e: changectx: mark the parents of the working copy as non filtered.
changectx: mark the parents of the working copy as non filtered
Sat, Nov 23, 7:59 PM
marmoute closed D7490: repoview: add an explicit set of all filter that show the wc parents.
Sat, Nov 23, 7:59 PM
marmoute committed rHGa1cd36171ea1: repoview: add an explicit set of all filter that show the wc parents.
repoview: add an explicit set of all filter that show the wc parents
Sat, Nov 23, 7:59 PM
marmoute committed rHG82ffb92092de: localrepo: introduce a `_quick_access_changeid` property.
localrepo: introduce a `_quick_access_changeid` property
Sat, Nov 23, 7:59 PM
marmoute closed D7484: localrepo: mark nullrev has never filtered.
Sat, Nov 23, 7:59 PM
marmoute closed D7486: locarepo: also fastpath `nullid` lookup in __getitem__.
Sat, Nov 23, 7:59 PM
marmoute committed rHG5ef259b09475: changectx: use unfiltered changelog to access parents of unfiltered revs.
changectx: use unfiltered changelog to access parents of unfiltered revs
Sat, Nov 23, 7:59 PM
marmoute closed D7483: changectx: add a "maybe filtered" filtered attribute.
Sat, Nov 23, 7:59 PM
marmoute committed rHGc9d1e2ec1e2e: locarepo: also fastpath `nullid` lookup in __getitem__.
locarepo: also fastpath `nullid` lookup in __getitem__
Sat, Nov 23, 7:59 PM
marmoute closed D7514: repoview: add more tests to track operation not supposed to trigger filtering.
Sat, Nov 23, 7:59 PM
marmoute committed rHGe3c0f9c2c376: repoview: add more tests to track operation not supposed to trigger filtering.
repoview: add more tests to track operation not supposed to trigger filtering
Sat, Nov 23, 7:58 PM
marmoute committed rHGc25885cc6849: localrepo: mark nullrev has never filtered.
localrepo: mark nullrev has never filtered
Sat, Nov 23, 7:58 PM
marmoute committed rHG8a37203ab1d5: changectx: add a "maybe filtered" filtered attribute.
changectx: add a "maybe filtered" filtered attribute
Sat, Nov 23, 7:58 PM
marmoute updated the diff for D7492: localrepo: also fastpath access to working copy parents when possible.
Sat, Nov 23, 7:22 PM
marmoute updated the diff for D7502: changectx: mark parent of changesets as non filtered.
Sat, Nov 23, 7:22 PM
marmoute updated the diff for D7501: changectx: use unfiltered changelog to walk ancestors in annotate.
Sat, Nov 23, 7:22 PM
marmoute updated the diff for D7491: changectx: mark the parents of the working copy as non filtered.
Sat, Nov 23, 7:21 PM
marmoute updated the diff for D7487: changectx: use unfiltered changelog to access parents of unfiltered revs.
Sat, Nov 23, 7:21 PM
marmoute updated the diff for D7483: changectx: add a "maybe filtered" filtered attribute.
Sat, Nov 23, 7:21 PM
marmoute added inline comments to D7483: changectx: add a "maybe filtered" filtered attribute.
Sat, Nov 23, 12:01 PM