marmoute (Pierre-Yves David)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:56 PM (94 w, 2 d)

Recent Activity

Wed, Apr 17

marmoute committed rHG69921d02daaf: peer: introduce a limitedarguments attributes.
peer: introduce a limitedarguments attributes
Wed, Apr 17, 6:39 PM
marmoute committed rHG4f9a89837f07: setdiscovery: stop limiting the number of local head we initially send.
setdiscovery: stop limiting the number of local head we initially send
Wed, Apr 17, 6:39 PM
marmoute committed rHG7755b89cadaf: verify: also check full manifest validity during verify runs.
verify: also check full manifest validity during verify runs
Wed, Apr 17, 6:39 PM
marmoute committed rHG57539e5ea2e0: verify: introduce a notion of "level".
verify: introduce a notion of "level"
Wed, Apr 17, 6:39 PM
marmoute committed rHG496ac8a02380: verify: introduce an experimental --full flag.
verify: introduce an experimental --full flag
Wed, Apr 17, 6:39 PM
marmoute accepted D6253: tests: delete unused function in test-rename-merge2.t.
Wed, Apr 17, 4:37 PM
marmoute accepted D6254: tests: avoid a rename/delete conflict when updating in test-narrow-update.t.

This one seems simple and sensible.

Wed, Apr 17, 4:37 PM
marmoute added a comment to D6253: tests: delete unused function in test-rename-merge2.t.

That one seems simple and sensible too.

Wed, Apr 17, 4:37 PM
marmoute accepted D6252: tests: make merge conflicts explicit in `hg annotate` tests.

This one seems simple and sensible.

Wed, Apr 17, 4:36 PM
marmoute committed rHG607a0de9bae3: debugdiscovery: include the number of heads in all sets.
debugdiscovery: include the number of heads in all sets
Wed, Apr 17, 12:59 PM
marmoute committed rHG013de80bf90e: recover: add a --[no-]verify flag.
recover: add a --[no-]verify flag
Wed, Apr 17, 12:18 PM
marmoute committed rHGa4483e380c3e: revsetbenchmark: add some simpler revset for heads and roots.
revsetbenchmark: add some simpler revset for heads and roots
Wed, Apr 17, 8:06 AM
marmoute committed rHG08481e11462e: repoview: flag `server.view` as experimental.
repoview: flag `server.view` as experimental
Wed, Apr 17, 8:06 AM
marmoute committed rHGcaebe5e7f4bd: repoview: move subsettable in a dedicated module.
repoview: move subsettable in a dedicated module
Wed, Apr 17, 8:06 AM

Tue, Apr 16

marmoute committed rHG9d5692d64e18: revsetbenchmark: add some simpler revset for heads and roots.
revsetbenchmark: add some simpler revset for heads and roots
Tue, Apr 16, 6:46 PM
marmoute committed rHG890f450f848f: repoview: move subsettable in a dedicated module.
repoview: move subsettable in a dedicated module
Tue, Apr 16, 6:15 PM
marmoute committed rHGeebf78724d94: repoview: flag `server.view` as experimental.
repoview: flag `server.view` as experimental
Tue, Apr 16, 6:15 PM
marmoute added a comment to D6255: copies: calculate mergecopies() based on pathcopies().

I did a first path through it, the new code seems reasonable and easier
to read than the previous one. Some comments and questions below.

Tue, Apr 16, 3:02 PM
marmoute committed rHG10a6725dca6e: compression: introduce an official `zstd-revlog` requirement.
compression: introduce an official `zstd-revlog` requirement
Tue, Apr 16, 11:51 AM
marmoute committed rHGd086ba387ae8: upgrade: support upgrade to/from zstd storage (issue6088).
upgrade: support upgrade to/from zstd storage (issue6088)
Tue, Apr 16, 11:51 AM
marmoute committed rHGb970fece153d: compression: only declare revlog support for available engine.
compression: only declare revlog support for available engine
Tue, Apr 16, 11:51 AM
marmoute committed rHGa362b0b95e42: pull: improved message issued in case of failed update.
pull: improved message issued in case of failed update
Tue, Apr 16, 8:44 AM
marmoute committed rHG232a33a11ce0: pull: deal with locally filtered changeset passed into --rev.
pull: deal with locally filtered changeset passed into --rev
Tue, Apr 16, 8:44 AM
marmoute committed rHG70b71421fd33: repoview: keep the branchmap cache for the `served.hidden` view warm.
repoview: keep the branchmap cache for the `served.hidden` view warm
Tue, Apr 16, 6:44 AM
marmoute committed rHGef0e3cc684b3: repoview: introduce a filter for serving hidden changesets.
repoview: introduce a filter for serving hidden changesets
Tue, Apr 16, 6:44 AM
marmoute committed rHGbc15e37ecc16: repoview: fix conditional around unserved changesets.
repoview: fix conditional around unserved changesets
Tue, Apr 16, 6:33 AM

Fri, Apr 12

marmoute committed rHGbcf59ddc6173: test: minor cleanup to test-server-view.t.
test: minor cleanup to test-server-view.t
Fri, Apr 12, 11:48 AM
marmoute committed rHGe0357a46c39d: repoview: improve documentation for `repo.filtered` method.
repoview: improve documentation for `repo.filtered` method
Fri, Apr 12, 11:48 AM

Thu, Apr 11

marmoute committed rHGbccb322f1496: match: fix re2 compability broken in 2e2699af5649.
match: fix re2 compability broken in 2e2699af5649
Thu, Apr 11, 1:53 PM

Fri, Apr 5

marmoute added a comment to D6183: copies: add config option for writing copy metadata to file and/or changset.

I am quite enthousiastic for a non-filelog based copy tracing using commit level information. However, I am very unenthousiastic at the idea of storing more copy data in the changeset itself. The "files" field in the changelog is already quite problematic (about 95% for changelog.d file, taking possibily hundred of megabytes). In addition, stoing copy in the changeset is kind of a "schema breakage" making its adoption slower.

Fri, Apr 5, 4:36 AM

Wed, Apr 3

marmoute added a comment to D6190: tests: better document the graft copy case.

Thanks looks good to me. Thanks for clarifying the table.

Wed, Apr 3, 2:26 PM

Tue, Apr 2

marmoute committed rHG4ee906aa7b60: compression: introduce an official `format.revlog-compression` option.
compression: introduce an official `format.revlog-compression` option
Tue, Apr 2, 2:07 PM
marmoute committed rHGd7e751ec679e: compression: display compression level in debugformat.
compression: display compression level in debugformat
Tue, Apr 2, 2:07 PM
marmoute committed rHGbb271ec2fbfb: compression: introduce a `storage.revlog.zstd.level` configuration.
compression: introduce a `storage.revlog.zstd.level` configuration
Tue, Apr 2, 2:07 PM
marmoute committed rHG1fac9b931d46: compression: introduce a `storage.revlog.zlib.level` configuration.
compression: introduce a `storage.revlog.zlib.level` configuration
Tue, Apr 2, 2:07 PM
marmoute committed rHG3e47d1ec9da5: util: extract compression code in `mercurial.utils.compression`.
util: extract compression code in `mercurial.utils.compression`
Tue, Apr 2, 2:07 PM
marmoute committed rHGaaececb4b066: compression: accept level management for zlib compression.
compression: accept level management for zlib compression
Tue, Apr 2, 2:07 PM

Sun, Mar 31

marmoute added a comment to D6176: revset: remove comment about linkrev workaround from user-facing docs.

+1

Sun, Mar 31, 1:02 PM

Wed, Mar 27

marmoute committed rHGeec20025ada3: debugdiscovery: display time elapsed during the discovery step.
debugdiscovery: display time elapsed during the discovery step
Wed, Mar 27, 3:37 PM
marmoute committed rHGfd8d13ea1bcc: debugdiscovery: only list common heads on verbose.
debugdiscovery: only list common heads on verbose
Wed, Mar 27, 3:37 PM
marmoute committed rHGc3a16c282dd8: debugdiscovery: drop duplicated information.
debugdiscovery: drop duplicated information
Wed, Mar 27, 3:37 PM
marmoute committed rHG63165e4a76da: debugdiscovery: display more statistic about the common set.
debugdiscovery: display more statistic about the common set
Wed, Mar 27, 3:37 PM
marmoute committed rHG6ae1a776dd1a: debugdiscovery: allow to select random seed during debugdiscovery run.
debugdiscovery: allow to select random seed during debugdiscovery run
Wed, Mar 27, 3:37 PM
marmoute committed rHGd31d8c5279c6: debugdiscovery: small internal refactoring.
debugdiscovery: small internal refactoring
Wed, Mar 27, 3:37 PM

Mon, Mar 25

marmoute committed rHG5a1e621b8186: perf: introduce a `perf.run-limits` options.
perf: introduce a `perf.run-limits` options
Mon, Mar 25, 11:48 AM
marmoute committed rHG87066cf5ec0f: perf: more flexible implementation for checking stop conditions.
perf: more flexible implementation for checking stop conditions
Mon, Mar 25, 11:48 AM
marmoute committed rHG0e6422942c84: perf: pass limits as a function argument.
perf: pass limits as a function argument
Mon, Mar 25, 11:48 AM
marmoute committed rHGb900b392c1cc: perf: document perfparents.
perf: document perfparents
Mon, Mar 25, 11:48 AM
marmoute committed rHGd93436e2ca6b: tests: use "perf" as a the extension name in test-contrib-perf.t.
tests: use "perf" as a the extension name in test-contrib-perf.t
Mon, Mar 25, 11:48 AM
marmoute committed rHGdbca2e5563c3: perf: document config options.
perf: document config options
Mon, Mar 25, 11:48 AM

Mar 19 2019

marmoute added a comment to D6140: revset: add new contiguous(x) function for "x::x".

[…]
What Martin is trying to achieve here is a simple function to express
X::X. So maybe it could be a special case of a function expression X::Y.
However, we don't have this function right now. Maybe we jut need to
introduce it, with a clear name eg revbetween or connected or
dagrange, with an optionnal second arguments:

  • X::Y → dagrange(X, Y)
  • X::X → dagrange(X)

And ::X and X::? Maybe dagrange(heads=X) and dagrange(roots=X), respectively? That implies that roots and heads default to null and heads(), but it seems weird that dagrange(X) is equivalent to dagrange(roots=X, heads=X).

Mar 19 2019, 2:06 PM
marmoute added a comment to D6140: revset: add new contiguous(x) function for "x::x".

I spend some more time thinking about it, especially about the semantic
I would expect from a contiguous function. My conclusion is that I'm
seeing something call contiguous more as a filter than something
adding element to the set.

Mar 19 2019, 10:48 AM

Mar 18 2019

marmoute committed rHG0d467e4de4ae: discovery: fix embarrassing typo in slice definition.
discovery: fix embarrassing typo in slice definition
Mar 18 2019, 6:54 PM

Mar 16 2019

marmoute committed rHGe4ac7e63c213: manifestcache: use `wcache` directory for manifest cache.
manifestcache: use `wcache` directory for manifest cache
Mar 16 2019, 7:57 PM
marmoute committed rHG6386f9a421d2: manifestcache: clear the cache before testing the debug command.
manifestcache: clear the cache before testing the debug command
Mar 16 2019, 7:57 PM
marmoute committed rHGd121823072b8: manifestcache: protect write with `wlock` instead of `lock`.
manifestcache: protect write with `wlock` instead of `lock`
Mar 16 2019, 7:57 PM
marmoute committed rHG07c80298b5a1: manifestcache: abstract the filename in a class attribute.
manifestcache: abstract the filename in a class attribute
Mar 16 2019, 7:57 PM
marmoute committed rHGc3522b015f81: manifestcache: skip setup earlier if we don't have the lock.
manifestcache: skip setup earlier if we don't have the lock
Mar 16 2019, 7:57 PM
marmoute committed rHG7d417ab1eda9: manifestcache: test the cache is warm after a commit.
manifestcache: test the cache is warm after a commit
Mar 16 2019, 7:57 PM
marmoute committed rHG1fe278aa4ad5: manifestcache: support multiple cache addition in one debug command run.
manifestcache: support multiple cache addition in one debug command run
Mar 16 2019, 7:57 PM
marmoute committed rHGe3307243d188: manifestcache: stop altering the lru cache order while displaying it.
manifestcache: stop altering the lru cache order while displaying it
Mar 16 2019, 7:57 PM

Mar 15 2019

marmoute updated subscribers of D6140: revset: add new contiguous(x) function for "x::x".

I chatted a bit with Georges about this. He suggested something along
the line of fill or complete.

Mar 15 2019, 2:12 PM
marmoute committed rHGb74ef67573e5: manifestcache: actually honor --clear.
manifestcache: actually honor --clear
Mar 15 2019, 9:46 AM
marmoute committed rHG5b77847bdf09: manifestcache: make sure the entry are ordered by access time.
manifestcache: make sure the entry are ordered by access time
Mar 15 2019, 9:46 AM
marmoute committed rHG7436653d8542: manifestcache: adding a second distinct entry.
manifestcache: adding a second distinct entry
Mar 15 2019, 9:46 AM
marmoute committed rHG1e75311d78f7: manifestcache: do not display data when using --add.
manifestcache: do not display data when using --add
Mar 15 2019, 9:46 AM
marmoute committed rHG99eb9f269a5a: manifestcache: test that adding the same entry twice do not duplicates it.
manifestcache: test that adding the same entry twice do not duplicates it
Mar 15 2019, 9:46 AM
marmoute committed rHGfbee66c90cef: manifestcache: only lock the repository if the debug command touch the cache.
manifestcache: only lock the repository if the debug command touch the cache
Mar 15 2019, 9:46 AM
marmoute committed rHG08fad2ca4eb6: manifestcache: further fix to debug command output.
manifestcache: further fix to debug command output
Mar 15 2019, 9:46 AM
marmoute committed rHG70d2d47314e5: manifestcache: test and fix some output of the debug command.
manifestcache: test and fix some output of the debug command
Mar 15 2019, 9:46 AM
marmoute added a comment to D6140: revset: add new contiguous(x) function for "x::x".

I am a fan of this function, I need this on a regular basis. Having an
explicit function for this also open the way to various optimization.
For example we know that a set already has this property we could skip
all computation.

Mar 15 2019, 6:52 AM

Mar 11 2019

marmoute committed rHG481259af4bdf: updatecaches: also warm the tags caches.
updatecaches: also warm the tags caches
Mar 11 2019, 7:17 PM
marmoute committed rHG2eee280a1354: updatecaches: also warm revbranchcache for filtered revisions.
updatecaches: also warm revbranchcache for filtered revisions
Mar 11 2019, 7:17 PM

Mar 10 2019

marmoute committed rHGa60e9f163595: discovery-helper: bail out if destination already exists.
discovery-helper: bail out if destination already exists
Mar 10 2019, 6:28 PM
marmoute committed rHGcae3f7e37623: discovery-helper: use reflink copy if available.
discovery-helper: use reflink copy if available
Mar 10 2019, 6:28 PM
marmoute committed rHGcb6c9d41a23e: discovery-helper: move repository creation in a function.
discovery-helper: move repository creation in a function
Mar 10 2019, 6:28 PM
marmoute committed rHG4f283b7dac44: discovery-helper: add an extra argument to generate only one repo.
discovery-helper: add an extra argument to generate only one repo
Mar 10 2019, 6:28 PM

Mar 9 2019

marmoute committed rHG94faa2e84094: transaction: include txnname in the hookargs dictionary.
transaction: include txnname in the hookargs dictionary
Mar 9 2019, 8:50 PM
marmoute committed rHGc1017bceb6ec: discovery-helper: reflect argument value in the name of the results.
discovery-helper: reflect argument value in the name of the results
Mar 9 2019, 8:50 PM
marmoute committed rHG39020ff59b37: contrib: move the `discovery-helper.sh` script in`perf-utils` directory.
contrib: move the `discovery-helper.sh` script in`perf-utils` directory
Mar 9 2019, 8:50 PM
marmoute committed rHGaea6bc63884d: discovery-helper: echo the stripped revsets early.
discovery-helper: echo the stripped revsets early
Mar 9 2019, 8:50 PM

Mar 7 2019

marmoute committed rHG3ba9ca537f57: discovery: clarify why the caching of children is valid.
discovery: clarify why the caching of children is valid
Mar 7 2019, 5:57 PM

Mar 6 2019

marmoute committed rHGa05f0bbefdd9: discovery: explicitly use `undecided` for the children mapping.
discovery: explicitly use `undecided` for the children mapping
Mar 6 2019, 4:02 PM
marmoute committed rHG5baf06d2bb41: discovery: cache the children mapping used during each discovery.
discovery: cache the children mapping used during each discovery
Mar 6 2019, 4:02 PM
marmoute committed rHGd5e6ae6e8012: discovery: move children computation in its own method.
discovery: move children computation in its own method
Mar 6 2019, 4:02 PM
marmoute committed rHG1f069f37e601: discovery: simplify the building of the children mapping.
discovery: simplify the building of the children mapping
Mar 6 2019, 4:02 PM
marmoute committed rHGc98420914c10: discovery: simply walk the undecided revs when building the children mapping.
discovery: simply walk the undecided revs when building the children mapping
Mar 6 2019, 4:02 PM
marmoute committed rHGe514799e4e07: discovery: use a lower level but faster way to retrieve parents.
discovery: use a lower level but faster way to retrieve parents
Mar 6 2019, 4:02 PM
marmoute committed rHG55919b96c02a: discovery: avoid computing identical sets of heads twice.
discovery: avoid computing identical sets of heads twice
Mar 6 2019, 4:02 PM
marmoute committed rHG9c5a6af74afa: verify: small refactoring and documentation in `_verifymanifest`.
verify: small refactoring and documentation in `_verifymanifest`
Mar 6 2019, 2:49 PM
marmoute committed rHG2f1f475e9646: verify: document `_verifychangelog`.
verify: document `_verifychangelog`
Mar 6 2019, 2:49 PM
marmoute committed rHG5ad5a70df2f7: verify: document the `_verifymanifest` method.
verify: document the `_verifymanifest` method
Mar 6 2019, 2:49 PM
marmoute committed rHG1f412223f5bb: verify: rename the `checklog` to `_checkrevlog`.
verify: rename the `checklog` to `_checkrevlog`
Mar 6 2019, 2:49 PM
marmoute committed rHG3f3f962457b2: revlog: add some documentation to the `checksize` method.
revlog: add some documentation to the `checksize` method
Mar 6 2019, 2:49 PM
marmoute committed rHG08d977451f26: verify: document the `checklog` method.
verify: document the `checklog` method
Mar 6 2019, 2:49 PM
marmoute committed rHG00c9fde75c1a: verify: document the `checkentry` method.
verify: document the `checkentry` method
Mar 6 2019, 2:49 PM
marmoute committed rHG9e737ca539f6: verify: make `checkentry` a private method.
verify: make `checkentry` a private method
Mar 6 2019, 2:49 PM
marmoute committed rHG567892b4306c: verify: explicitly return 0 if no error are encountered.
verify: explicitly return 0 if no error are encountered
Mar 6 2019, 2:49 PM
marmoute committed rHGe8c4a9f5b986: verify: minimal documentation for `verifier.verify`.
verify: minimal documentation for `verifier.verify`
Mar 6 2019, 2:49 PM
marmoute committed rHG4da2261e949b: verify: add some inline documentation to the top level `verify` method.
verify: add some inline documentation to the top level `verify` method
Mar 6 2019, 2:49 PM