Page MenuHomePhabricator

marmoute (Pierre-Yves David)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:56 PM (102 w, 3 d)

Recent Activity

Fri, Jun 14

marmoute committed rHG4a3abb33380a: deltas: set estimated compression upper bound to "3x" instead of "10x".
deltas: set estimated compression upper bound to "3x" instead of "10x"
Fri, Jun 14, 10:56 AM
marmoute committed rHGbc4373babd04: revlog: add the option to track the expected compression upper bound.
revlog: add the option to track the expected compression upper bound
Fri, Jun 14, 10:56 AM
marmoute committed rHGa0b26fc8fbba: deltas: skip if projected delta size does not match text size constraint.
deltas: skip if projected delta size does not match text size constraint
Fri, Jun 14, 10:56 AM
marmoute committed rHGe4c85e23c9ff: perf: fix perfrevlogwrite --count documentation.
perf: fix perfrevlogwrite --count documentation
Fri, Jun 14, 10:55 AM
marmoute committed rHG74e2f4b609f6: perf: clarify some of the custom behavior of `perfrevlogwrite`.
perf: clarify some of the custom behavior of `perfrevlogwrite`
Fri, Jun 14, 10:55 AM

Fri, Jun 7

marmoute committed rHGb9ff059fd194: discovery: be more conservative when adjusting the sample size.
discovery: be more conservative when adjusting the sample size
Fri, Jun 7, 9:48 PM

Wed, Jun 5

marmoute added a comment to D6469: bookmarks: use correct store for "ambiguity check".

Ah, I see. The move from ('plain', '') to ('', 'plain') is matching the key used for the vfsmap?
If so, go ahead with this patch on stable.

Wed, Jun 5, 3:04 PM
marmoute requested changes to D6469: bookmarks: use correct store for "ambiguity check".

Can we go fully explicit ? Having both plain and store as the possible value?

Wed, Jun 5, 7:17 AM

Tue, May 28

marmoute committed rHG21c436a3a4e8: perf: add a `perfhelper-mergecopies` command.
perf: add a `perfhelper-mergecopies` command
Tue, May 28, 9:59 AM
marmoute committed rHGf5f0a9490c05: perf: add a new `perfmergecopies` command.
perf: add a new `perfmergecopies` command
Tue, May 28, 9:59 AM
marmoute committed rHGf0bcbbb6541c: perf: allow to specify the base of the merge in perfmergecalculate.
perf: allow to specify the base of the merge in perfmergecalculate
Tue, May 28, 9:59 AM
marmoute committed rHG3a3592b40a95: perf: factor selection of revisions involved in the merge out.
perf: factor selection of revisions involved in the merge out
Tue, May 28, 9:59 AM
marmoute committed rHGe3ee707d42ad: perf: add a --from flag to perfmergecalculate.
perf: add a --from flag to perfmergecalculate
Tue, May 28, 9:59 AM

Fri, May 24

marmoute committed rHG96fc696a9cb2: match: stabilize _rootsdirsandparents doctest.
match: stabilize _rootsdirsandparents doctest
Fri, May 24, 8:02 AM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().

(I did some experiment, here seems a good spot to report them)

Fri, May 24, 7:17 AM

Thu, May 23

marmoute committed rHGa09829e14fc0: perf: make sure to explicitly disable any profiler after the first iteration.
perf: make sure to explicitly disable any profiler after the first iteration
Thu, May 23, 7:37 PM

Wed, May 22

marmoute committed rHG563cd9a72682: perf: add a `pre-run` option.
perf: add a `pre-run` option
Wed, May 22, 7:41 PM
marmoute committed rHG3293086ff663: perf: add an option to profile the benchmark section.
perf: add an option to profile the benchmark section
Wed, May 22, 7:41 PM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().

The nodes in the above example have been selected by a script because they had interresting property. They are not based on a tag so I can't give you one. How did you converted the repo ? I think hg convert keeps a map somewhere, otherwise, using the commit message could work.

Wed, May 22, 6:29 PM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().

Can you indicate a summary of the total speedup of the series ? (from base to last changesets?). Also I am not sure for which case these number apply ? Is this the compatibility mode or after repository conversion ? Can we have number for both ?

Wed, May 22, 2:34 PM
marmoute added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

Something only based on the number of root can also over sample. For a "simple" example, imagine a undecideded set with many roots that eventually all merge into a few heads.
If most of that set is common between local and remote, few question about the part of the history at the heads will quickly "decide" many changesets. Numberous questions at the roots part of the history won't.

Wed, May 22, 2:14 PM
marmoute added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

We could maybe make it a function of both the number of heads and roots. That is not strictly the number of connected set, but that would provide a more conservative approach. That could over-sample for hour-glass shape, but they are probably less common.

Wed, May 22, 1:41 PM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().
Wed, May 22, 6:59 AM
marmoute added a comment to D6422: copies: avoid calling matcher if matcher.always().
Wed, May 22, 4:19 AM

Tue, May 21

marmoute committed rHGdbd0fcca6dfc: discovery: slowly increase sampling size.
discovery: slowly increase sampling size
Tue, May 21, 4:43 PM
marmoute added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

I feel like I am missing something. Your commit message seems to be talking using at least as many item in the sameple than there is independant connected set. However your code seems to use "heads(undecided)" that is a quite different. Using independant connected set seems like a good trade off (but might be expensive to compute). Using all heads can significantly bloat the discovery without giving it a significant edge in many cases.

Tue, May 21, 4:17 PM

Mon, May 20

marmoute committed rHG2338bdea4474: bookmark: also make bookmark cache depends of the changelog.
bookmark: also make bookmark cache depends of the changelog
Mon, May 20, 11:46 AM
marmoute committed rHGc2b83c957621: localrepo: grab mixedrepostorecache class from 526750cdd02d.
localrepo: grab mixedrepostorecache class from 526750cdd02d
Mon, May 20, 11:46 AM
marmoute committed rHGd2c871b78c36: bookmark: add a test for a race condition on push.
bookmark: add a test for a race condition on push
Mon, May 20, 11:46 AM
marmoute committed rHG624080e8bd9f: test: properly gate a zstd section.
test: properly gate a zstd section
Mon, May 20, 11:46 AM
marmoute committed rHGf352ed7dfab7: test: update test for expected test output.
test: update test for expected test output
Mon, May 20, 11:46 AM

May 14 2019

marmoute added a comment to D6331: log: add config for making `hg log -G` always topo-sorted.

There used to be a experimental.graph-group-branches (that tortoise-hg
still use) that got removed at some point. Did you check the rational
behind the removal ?

May 14 2019, 10:00 AM

May 3 2019

marmoute committed rHG32338e27bb9d: updatecaches: also warm hgtagsfnodescache.
updatecaches: also warm hgtagsfnodescache
May 3 2019, 3:34 PM
marmoute committed rHG9f45d3d526f9: hgtagsfnodescache: inherit fnode from parent when possible.
hgtagsfnodescache: inherit fnode from parent when possible
May 3 2019, 3:34 PM
marmoute committed rHG2930b31383af: hgtagsfnodescache: handle nullid lookup.
hgtagsfnodescache: handle nullid lookup
May 3 2019, 3:34 PM

May 2 2019

marmoute committed rHGd345627d104b: repoview: introduce a `experimental.extra-filter-revs` config.
repoview: introduce a `experimental.extra-filter-revs` config
May 2 2019, 7:13 PM
marmoute added a comment to D6332: releasenotes: add a file in which to record release notes.

+1 on the idea of an explcit editable file instead of immutable static entry in the changelog. I would use it.

May 2 2019, 4:57 AM

Apr 28 2019

marmoute committed rHG07e479ef7c96: hghave: deal with "rc" release.
hghave: deal with "rc" release
Apr 28 2019, 5:02 AM

Apr 24 2019

marmoute committed rHG5b9cf3002ff5: httppeer: make sure we limit argument for older server not supporting batch.
httppeer: make sure we limit argument for older server not supporting batch
Apr 24 2019, 10:25 PM

Apr 17 2019

marmoute committed rHG69921d02daaf: peer: introduce a limitedarguments attributes.
peer: introduce a limitedarguments attributes
Apr 17 2019, 6:39 PM
marmoute committed rHG4f9a89837f07: setdiscovery: stop limiting the number of local head we initially send.
setdiscovery: stop limiting the number of local head we initially send
Apr 17 2019, 6:39 PM
marmoute committed rHG7755b89cadaf: verify: also check full manifest validity during verify runs.
verify: also check full manifest validity during verify runs
Apr 17 2019, 6:39 PM
marmoute committed rHG57539e5ea2e0: verify: introduce a notion of "level".
verify: introduce a notion of "level"
Apr 17 2019, 6:39 PM
marmoute committed rHG496ac8a02380: verify: introduce an experimental --full flag.
verify: introduce an experimental --full flag
Apr 17 2019, 6:39 PM
marmoute accepted D6253: tests: delete unused function in test-rename-merge2.t.
Apr 17 2019, 4:37 PM
marmoute accepted D6254: tests: avoid a rename/delete conflict when updating in test-narrow-update.t.

This one seems simple and sensible.

Apr 17 2019, 4:37 PM
marmoute added a comment to D6253: tests: delete unused function in test-rename-merge2.t.

That one seems simple and sensible too.

Apr 17 2019, 4:37 PM
marmoute accepted D6252: tests: make merge conflicts explicit in `hg annotate` tests.

This one seems simple and sensible.

Apr 17 2019, 4:36 PM
marmoute committed rHG607a0de9bae3: debugdiscovery: include the number of heads in all sets.
debugdiscovery: include the number of heads in all sets
Apr 17 2019, 12:59 PM
marmoute committed rHG013de80bf90e: recover: add a --[no-]verify flag.
recover: add a --[no-]verify flag
Apr 17 2019, 12:18 PM
marmoute committed rHGa4483e380c3e: revsetbenchmark: add some simpler revset for heads and roots.
revsetbenchmark: add some simpler revset for heads and roots
Apr 17 2019, 8:06 AM
marmoute committed rHG08481e11462e: repoview: flag `server.view` as experimental.
repoview: flag `server.view` as experimental
Apr 17 2019, 8:06 AM
marmoute committed rHGcaebe5e7f4bd: repoview: move subsettable in a dedicated module.
repoview: move subsettable in a dedicated module
Apr 17 2019, 8:06 AM

Apr 16 2019

marmoute committed rHG9d5692d64e18: revsetbenchmark: add some simpler revset for heads and roots.
revsetbenchmark: add some simpler revset for heads and roots
Apr 16 2019, 6:46 PM
marmoute committed rHG890f450f848f: repoview: move subsettable in a dedicated module.
repoview: move subsettable in a dedicated module
Apr 16 2019, 6:15 PM
marmoute committed rHGeebf78724d94: repoview: flag `server.view` as experimental.
repoview: flag `server.view` as experimental
Apr 16 2019, 6:15 PM
marmoute added a comment to D6255: copies: calculate mergecopies() based on pathcopies().

I did a first path through it, the new code seems reasonable and easier
to read than the previous one. Some comments and questions below.

Apr 16 2019, 3:02 PM
marmoute committed rHG10a6725dca6e: compression: introduce an official `zstd-revlog` requirement.
compression: introduce an official `zstd-revlog` requirement
Apr 16 2019, 11:51 AM
marmoute committed rHGd086ba387ae8: upgrade: support upgrade to/from zstd storage (issue6088).
upgrade: support upgrade to/from zstd storage (issue6088)
Apr 16 2019, 11:51 AM
marmoute committed rHGb970fece153d: compression: only declare revlog support for available engine.
compression: only declare revlog support for available engine
Apr 16 2019, 11:51 AM
marmoute committed rHGa362b0b95e42: pull: improved message issued in case of failed update.
pull: improved message issued in case of failed update
Apr 16 2019, 8:44 AM
marmoute committed rHG232a33a11ce0: pull: deal with locally filtered changeset passed into --rev.
pull: deal with locally filtered changeset passed into --rev
Apr 16 2019, 8:44 AM
marmoute committed rHG70b71421fd33: repoview: keep the branchmap cache for the `served.hidden` view warm.
repoview: keep the branchmap cache for the `served.hidden` view warm
Apr 16 2019, 6:44 AM
marmoute committed rHGef0e3cc684b3: repoview: introduce a filter for serving hidden changesets.
repoview: introduce a filter for serving hidden changesets
Apr 16 2019, 6:44 AM
marmoute committed rHGbc15e37ecc16: repoview: fix conditional around unserved changesets.
repoview: fix conditional around unserved changesets
Apr 16 2019, 6:33 AM

Apr 12 2019

marmoute committed rHGbcf59ddc6173: test: minor cleanup to test-server-view.t.
test: minor cleanup to test-server-view.t
Apr 12 2019, 11:48 AM
marmoute committed rHGe0357a46c39d: repoview: improve documentation for `repo.filtered` method.
repoview: improve documentation for `repo.filtered` method
Apr 12 2019, 11:48 AM

Apr 11 2019

marmoute committed rHGbccb322f1496: match: fix re2 compability broken in 2e2699af5649.
match: fix re2 compability broken in 2e2699af5649
Apr 11 2019, 1:53 PM

Apr 5 2019

marmoute added a comment to D6183: copies: add config option for writing copy metadata to file and/or changset.

I am quite enthousiastic for a non-filelog based copy tracing using commit level information. However, I am very unenthousiastic at the idea of storing more copy data in the changeset itself. The "files" field in the changelog is already quite problematic (about 95% for changelog.d file, taking possibily hundred of megabytes). In addition, stoing copy in the changeset is kind of a "schema breakage" making its adoption slower.

Apr 5 2019, 4:36 AM

Apr 3 2019

marmoute added a comment to D6190: tests: better document the graft copy case.

Thanks looks good to me. Thanks for clarifying the table.

Apr 3 2019, 2:26 PM

Apr 2 2019

marmoute committed rHG4ee906aa7b60: compression: introduce an official `format.revlog-compression` option.
compression: introduce an official `format.revlog-compression` option
Apr 2 2019, 2:07 PM
marmoute committed rHGd7e751ec679e: compression: display compression level in debugformat.
compression: display compression level in debugformat
Apr 2 2019, 2:07 PM
marmoute committed rHGbb271ec2fbfb: compression: introduce a `storage.revlog.zstd.level` configuration.
compression: introduce a `storage.revlog.zstd.level` configuration
Apr 2 2019, 2:07 PM
marmoute committed rHG1fac9b931d46: compression: introduce a `storage.revlog.zlib.level` configuration.
compression: introduce a `storage.revlog.zlib.level` configuration
Apr 2 2019, 2:07 PM
marmoute committed rHG3e47d1ec9da5: util: extract compression code in `mercurial.utils.compression`.
util: extract compression code in `mercurial.utils.compression`
Apr 2 2019, 2:07 PM
marmoute committed rHGaaececb4b066: compression: accept level management for zlib compression.
compression: accept level management for zlib compression
Apr 2 2019, 2:07 PM

Mar 31 2019

marmoute added a comment to D6176: revset: remove comment about linkrev workaround from user-facing docs.

+1

Mar 31 2019, 1:02 PM

Mar 27 2019

marmoute committed rHGeec20025ada3: debugdiscovery: display time elapsed during the discovery step.
debugdiscovery: display time elapsed during the discovery step
Mar 27 2019, 3:37 PM
marmoute committed rHGfd8d13ea1bcc: debugdiscovery: only list common heads on verbose.
debugdiscovery: only list common heads on verbose
Mar 27 2019, 3:37 PM
marmoute committed rHGc3a16c282dd8: debugdiscovery: drop duplicated information.
debugdiscovery: drop duplicated information
Mar 27 2019, 3:37 PM
marmoute committed rHG63165e4a76da: debugdiscovery: display more statistic about the common set.
debugdiscovery: display more statistic about the common set
Mar 27 2019, 3:37 PM
marmoute committed rHG6ae1a776dd1a: debugdiscovery: allow to select random seed during debugdiscovery run.
debugdiscovery: allow to select random seed during debugdiscovery run
Mar 27 2019, 3:37 PM
marmoute committed rHGd31d8c5279c6: debugdiscovery: small internal refactoring.
debugdiscovery: small internal refactoring
Mar 27 2019, 3:37 PM

Mar 25 2019

marmoute committed rHG5a1e621b8186: perf: introduce a `perf.run-limits` options.
perf: introduce a `perf.run-limits` options
Mar 25 2019, 11:48 AM
marmoute committed rHG87066cf5ec0f: perf: more flexible implementation for checking stop conditions.
perf: more flexible implementation for checking stop conditions
Mar 25 2019, 11:48 AM
marmoute committed rHG0e6422942c84: perf: pass limits as a function argument.
perf: pass limits as a function argument
Mar 25 2019, 11:48 AM
marmoute committed rHGb900b392c1cc: perf: document perfparents.
perf: document perfparents
Mar 25 2019, 11:48 AM
marmoute committed rHGd93436e2ca6b: tests: use "perf" as a the extension name in test-contrib-perf.t.
tests: use "perf" as a the extension name in test-contrib-perf.t
Mar 25 2019, 11:48 AM
marmoute committed rHGdbca2e5563c3: perf: document config options.
perf: document config options
Mar 25 2019, 11:48 AM

Mar 19 2019

marmoute added a comment to D6140: revset: add new contiguous(x) function for "x::x".

[…]
What Martin is trying to achieve here is a simple function to express
X::X. So maybe it could be a special case of a function expression X::Y.
However, we don't have this function right now. Maybe we jut need to
introduce it, with a clear name eg revbetween or connected or
dagrange, with an optionnal second arguments:

  • X::Y → dagrange(X, Y)
  • X::X → dagrange(X)

And ::X and X::? Maybe dagrange(heads=X) and dagrange(roots=X), respectively? That implies that roots and heads default to null and heads(), but it seems weird that dagrange(X) is equivalent to dagrange(roots=X, heads=X).

Mar 19 2019, 2:06 PM
marmoute added a comment to D6140: revset: add new contiguous(x) function for "x::x".

I spend some more time thinking about it, especially about the semantic
I would expect from a contiguous function. My conclusion is that I'm
seeing something call contiguous more as a filter than something
adding element to the set.

Mar 19 2019, 10:48 AM

Mar 18 2019

marmoute committed rHG0d467e4de4ae: discovery: fix embarrassing typo in slice definition.
discovery: fix embarrassing typo in slice definition
Mar 18 2019, 6:54 PM

Mar 16 2019

marmoute committed rHGe4ac7e63c213: manifestcache: use `wcache` directory for manifest cache.
manifestcache: use `wcache` directory for manifest cache
Mar 16 2019, 7:57 PM
marmoute committed rHG6386f9a421d2: manifestcache: clear the cache before testing the debug command.
manifestcache: clear the cache before testing the debug command
Mar 16 2019, 7:57 PM
marmoute committed rHGd121823072b8: manifestcache: protect write with `wlock` instead of `lock`.
manifestcache: protect write with `wlock` instead of `lock`
Mar 16 2019, 7:57 PM
marmoute committed rHG07c80298b5a1: manifestcache: abstract the filename in a class attribute.
manifestcache: abstract the filename in a class attribute
Mar 16 2019, 7:57 PM
marmoute committed rHGc3522b015f81: manifestcache: skip setup earlier if we don't have the lock.
manifestcache: skip setup earlier if we don't have the lock
Mar 16 2019, 7:57 PM
marmoute committed rHG7d417ab1eda9: manifestcache: test the cache is warm after a commit.
manifestcache: test the cache is warm after a commit
Mar 16 2019, 7:57 PM
marmoute committed rHG1fe278aa4ad5: manifestcache: support multiple cache addition in one debug command run.
manifestcache: support multiple cache addition in one debug command run
Mar 16 2019, 7:57 PM
marmoute committed rHGe3307243d188: manifestcache: stop altering the lru cache order while displaying it.
manifestcache: stop altering the lru cache order while displaying it
Mar 16 2019, 7:57 PM