Page MenuHomePhabricator

martinvonz (Martin von Zweigbergk)
User

Projects

User Details

User Since
Jun 28 2017, 5:28 PM (116 w, 2 d)

Recent Activity

Thu, Sep 19

martinvonz committed rHG9668744c9122: wireprototypes: clarify documentation of getbundle argument types.
wireprototypes: clarify documentation of getbundle argument types
Thu, Sep 19, 7:57 AM
martinvonz closed D6871: wireprototypes: clarify documentation of getbundle argument types.
Thu, Sep 19, 7:57 AM

Wed, Sep 18

martinvonz created D6871: wireprototypes: clarify documentation of getbundle argument types.
Wed, Sep 18, 4:58 PM
martinvonz committed rHG44be33cf7a57: py3: don't double-convert "opts" to bytes.
py3: don't double-convert "opts" to bytes
Wed, Sep 18, 9:24 AM
martinvonz closed D6864: py3: don't double-convert "opts" to bytes.
Wed, Sep 18, 9:24 AM

Tue, Sep 17

martinvonz created D6864: py3: don't double-convert "opts" to bytes.
Tue, Sep 17, 6:38 PM
martinvonz closed D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 3:58 PM
martinvonz committed rHG40f78072fda9: narrow: add option for automatically removing unused includes.
narrow: add option for automatically removing unused includes
Tue, Sep 17, 3:57 PM
martinvonz closed D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).
Tue, Sep 17, 3:57 PM
martinvonz committed rHGc2676b5a9f59: narrow: don't hexify paths and double-hexify known nodes on wire (BC).
narrow: don't hexify paths and double-hexify known nodes on wire (BC)
Tue, Sep 17, 3:57 PM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 2:19 PM
martinvonz updated the diff for D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 2:19 PM
martinvonz updated the summary of D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:58 PM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:58 PM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:45 PM

Mon, Sep 16

martinvonz added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

Just tracked --add-include. A workaround to simplify the upgrade would be to change wireprototypes.SUPPORTED_ELLIPSESCAP to be (ELLIPSESCAP1, ) on the server from now until all clients have upgraded. But that may still be annoying and error-prone for you to deal with. @pulkit, I suppose we should just add a exp-narrow-2 capability to deal with this? It doesn't seem fair to make @idlsoft deal with it.

Sounds like a good idea!

If it's just tracked --add-include then it's not a big deal, it won't disrupt regular flow.
If backward compatibility doesn't complicate the code - great, if not - don't worry about it.

Mon, Sep 16, 2:14 PM
martinvonz added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

@idlsoft and their company does use narrow extension. @idlsoft can you upgrade server and client at the same time?

I did that a little while ago to move to 5.0. It was not fun. It's server, teamcity, clients, docker images.
What operations does this affect? Regular push/pull/clone or only tracked --add-include?

Mon, Sep 16, 1:39 PM
martinvonz updated the summary of D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).
Mon, Sep 16, 12:49 AM
martinvonz added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

Hmm, I just noticed that we separate these paths by commas (not nulls) in other places, so I'll make this consistent with that. I guess that means we don't support paths containing commas for includes or excludes, but fixing that is a separate problem.

Mon, Sep 16, 12:49 AM

Sun, Sep 15

martinvonz closed D6850: bundle2: fix an off-by-one in debug message of number of parts.
Sun, Sep 15, 1:48 PM
martinvonz committed rHG181ee2118a96: bundle2: fix an off-by-one in debug message of number of parts.
bundle2: fix an off-by-one in debug message of number of parts
Sun, Sep 15, 1:47 PM

Sat, Sep 14

martinvonz updated the diff for D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).
Sat, Sep 14, 1:14 PM
martinvonz created D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).
Sat, Sep 14, 1:11 PM
martinvonz updated the diff for D6850: bundle2: fix an off-by-one in debug message of number of parts.
Sat, Sep 14, 12:59 PM
martinvonz added inline comments to D6850: bundle2: fix an off-by-one in debug message of number of parts.
Sat, Sep 14, 12:54 PM
martinvonz created D6850: bundle2: fix an off-by-one in debug message of number of parts.
Sat, Sep 14, 12:38 PM
martinvonz closed D6849: tests: move a config write to top of file since it applies to all tests.
Sat, Sep 14, 11:34 AM
martinvonz committed rHG0b81fd0aa2a1: tests: move a config write to top of file since it applies to all tests.
tests: move a config write to top of file since it applies to all tests
Sat, Sep 14, 11:34 AM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Sat, Sep 14, 1:45 AM
martinvonz updated the diff for D6848: narrow: add option for automatically removing unused includes.
Sat, Sep 14, 1:43 AM
martinvonz created D6849: tests: move a config write to top of file since it applies to all tests.
Sat, Sep 14, 1:43 AM

Fri, Sep 13

martinvonz updated the diff for D6848: narrow: add option for automatically removing unused includes.
Fri, Sep 13, 8:54 PM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Fri, Sep 13, 8:54 PM
martinvonz added inline comments to D6848: narrow: add option for automatically removing unused includes.
Fri, Sep 13, 5:16 PM
martinvonz created D6848: narrow: add option for automatically removing unused includes.
Fri, Sep 13, 1:42 AM

Mon, Sep 9

martinvonz committed rHG96b22e58dc67: relnotes: we now require `sh` to support $(command) syntax to run test suite.
relnotes: we now require `sh` to support $(command) syntax to run test suite
Mon, Sep 9, 5:02 PM
martinvonz committed rHG0b0dfdfabeaa: relnotes: we now require `sh` to support $(command) syntax to run test suite.
relnotes: we now require `sh` to support $(command) syntax to run test suite
Mon, Sep 9, 4:30 PM
martinvonz closed D6833: relnotes: we now require `sh` to support $(command) syntax to run test suite.
Mon, Sep 9, 4:30 PM
martinvonz created D6833: relnotes: we now require `sh` to support $(command) syntax to run test suite.
Mon, Sep 9, 3:58 PM
martinvonz added a comment to D6789: check-code: allow command substitution with $(command).

The only information about it that I could find is that Bourne Shell doesn't support $() syntax. I'll still send a patch to mention it in the release notes.

Mon, Sep 9, 2:07 PM
martinvonz added a comment to D6789: check-code: allow command substitution with $(command).

The only information about it that I could find is that Bourne Shell doesn't support $() syntax. I'll still send a patch to mention it in the release notes.

Mon, Sep 9, 2:02 PM
martinvonz closed D6795: strip: fix bug with treemanifests and unordered linkrevs.
Mon, Sep 9, 12:09 PM
martinvonz closed D6794: repair: extract a helper for generating all manifest revlogs.
Mon, Sep 9, 12:09 PM
martinvonz committed rHGa8b249b2f8cc: strip: fix bug with treemanifests and unordered linkrevs.
strip: fix bug with treemanifests and unordered linkrevs
Mon, Sep 9, 12:09 PM
martinvonz committed rHG6d0fdba635e5: repair: extract a helper for generating all manifest revlogs.
repair: extract a helper for generating all manifest revlogs
Mon, Sep 9, 12:09 PM
martinvonz closed D6793: tests: show broken strip with treemanifests and unordered linkrevs.
Mon, Sep 9, 12:09 PM
martinvonz committed rHG31dcd9b8ef40: tests: show broken strip with treemanifests and unordered linkrevs.
tests: show broken strip with treemanifests and unordered linkrevs
Mon, Sep 9, 12:09 PM
martinvonz closed D6792: tests: split out manifest case from test-strip-cross.t.
Mon, Sep 9, 12:09 PM
martinvonz committed rHG5e0b1ce2f4a2: tests: split out manifest case from test-strip-cross.t.
tests: split out manifest case from test-strip-cross.t
Mon, Sep 9, 12:09 PM
martinvonz closed D6791: tests: don't log manifest-file in test-strip-cross.t.
Mon, Sep 9, 12:09 PM
martinvonz committed rHG32fdbc952bdd: tests: don't log manifest-file in test-strip-cross.t.
tests: don't log manifest-file in test-strip-cross.t
Mon, Sep 9, 12:09 PM
martinvonz closed D6790: tests: use positive revision numbers in test-strip-cross.t.
Mon, Sep 9, 12:09 PM
martinvonz committed rHGf78f7448a969: tests: use positive revision numbers in test-strip-cross.t.
tests: use positive revision numbers in test-strip-cross.t
Mon, Sep 9, 12:09 PM

Sat, Sep 7

martinvonz committed rHGacf80f9edc85: py3: drop incorrect fsencode(findexe(...)) in procutil.
py3: drop incorrect fsencode(findexe(...)) in procutil
Sat, Sep 7, 1:22 PM
martinvonz closed D6826: py3: drop incorrect fsencode(findexe(...)) in procutil.
Sat, Sep 7, 1:22 PM
martinvonz created D6826: py3: drop incorrect fsencode(findexe(...)) in procutil.
Sat, Sep 7, 1:05 PM
martinvonz closed D6789: check-code: allow command substitution with $(command).
Sat, Sep 7, 12:54 PM
martinvonz committed rHG4257c33e24b7: check-code: allow command substitution with $(command).
check-code: allow command substitution with $(command)
Sat, Sep 7, 12:54 PM
martinvonz created D6795: strip: fix bug with treemanifests and unordered linkrevs.
Sat, Sep 7, 2:37 AM
martinvonz created D6793: tests: show broken strip with treemanifests and unordered linkrevs.
Sat, Sep 7, 2:37 AM
martinvonz created D6794: repair: extract a helper for generating all manifest revlogs.
Sat, Sep 7, 2:37 AM
martinvonz created D6792: tests: split out manifest case from test-strip-cross.t.
Sat, Sep 7, 2:37 AM
martinvonz created D6791: tests: don't log manifest-file in test-strip-cross.t.
Sat, Sep 7, 2:37 AM
martinvonz created D6790: tests: use positive revision numbers in test-strip-cross.t.
Sat, Sep 7, 2:37 AM
martinvonz created D6789: check-code: allow command substitution with $(command).
Sat, Sep 7, 2:32 AM

Thu, Sep 5

martinvonz added a comment to D6782: py3: use pycompat.sysargv[0] for instead of fsencode(sys.argv[0]).
In D6782#99619, @yuja wrote:

@@ -245,8 +245,11 @@

    pycompat.fsencode(getattr(mainmod, '__file__', ''))) == 'hg'):
    _sethgexecutable(pycompat.fsencode(mainmod.__file__))
else:
  • exe = findexe('hg') or os.path.basename(sys.argv[0])
  • _sethgexecutable(pycompat.fsencode(exe))

+ exe = findexe('hg')
+ if exe:
+ _sethgexecutable(pycompat.fsencode(exe))
+ else:
+ _sethgexecutable(os.path.basename(pycompat.sysargv[0]))

findexe() is supposed to return bytes. If not always, it's the bug
of findexe().

Thu, Sep 5, 7:26 PM
martinvonz closed D6750: context: filter out invalid copies from workingctx.p[12]copies().
Thu, Sep 5, 3:16 PM
martinvonz closed D6752: copies: remove existing copy info from the changeset on amend (BC).
Thu, Sep 5, 3:15 PM
martinvonz closed D6751: tests: show invalid copies when turning off copies-in-changeset.
Thu, Sep 5, 3:15 PM
martinvonz committed rHG57ea0a81a65c: copies: remove existing copy info from the changeset on amend (BC).
copies: remove existing copy info from the changeset on amend (BC)
Thu, Sep 5, 3:15 PM
martinvonz committed rHG6f0273558c4b: tests: show invalid copies when turning off copies-in-changeset.
tests: show invalid copies when turning off copies-in-changeset
Thu, Sep 5, 3:15 PM
martinvonz committed rHG2b869a515ba6: context: filter out invalid copies from workingctx.p[12]copies().
context: filter out invalid copies from workingctx.p[12]copies()
Thu, Sep 5, 3:15 PM
martinvonz closed D6749: tests: demonstrate crash when committing subset of copies to changeset.
Thu, Sep 5, 3:15 PM
martinvonz committed rHG170b070ec6a5: tests: demonstrate crash when committing subset of copies to changeset.
tests: demonstrate crash when committing subset of copies to changeset
Thu, Sep 5, 3:15 PM
martinvonz closed D6782: py3: use pycompat.sysargv[0] for instead of fsencode(sys.argv[0]).
Thu, Sep 5, 2:57 PM
martinvonz closed D6784: httppeer: use context manager when reading temporary bundle to send.
Thu, Sep 5, 2:57 PM
martinvonz committed rHGdb51a4ac85ac: py3: use pycompat.sysargv[0] for instead of fsencode(sys.argv[0]).
py3: use pycompat.sysargv[0] for instead of fsencode(sys.argv[0])
Thu, Sep 5, 2:57 PM
martinvonz closed D6783: httppeer: use context manager when writing temporary bundle to send.
Thu, Sep 5, 2:57 PM
martinvonz committed rHG37debb6771f5: httppeer: use context manager when reading temporary bundle to send.
httppeer: use context manager when reading temporary bundle to send
Thu, Sep 5, 2:57 PM
martinvonz committed rHG58f73e9ccfff: httppeer: use context manager when writing temporary bundle to send.
httppeer: use context manager when writing temporary bundle to send
Thu, Sep 5, 2:57 PM
martinvonz created D6784: httppeer: use context manager when reading temporary bundle to send.
Thu, Sep 5, 12:36 AM
martinvonz created D6783: httppeer: use context manager when writing temporary bundle to send.
Thu, Sep 5, 12:36 AM

Tue, Sep 3

martinvonz added a comment to D6522: tracing: add many more timedcm() calls throughout the codebase.

test-check-*.t were unhappy with some of the changes in this stack (including in this patch). Can you fix those and update?

Tue, Sep 3, 2:17 PM
martinvonz added a comment to D6522: tracing: add many more timedcm() calls throughout the codebase.

I've been trying to understand where time goes in hg status and this helped
me get a sense of things.

Tue, Sep 3, 2:00 PM

Mon, Sep 2

martinvonz updated the diff for D6782: py3: use pycompat.sysargv[0] for instead of fsencode(sys.argv[0]).
Mon, Sep 2, 2:52 AM
martinvonz created D6782: py3: use pycompat.sysargv[0] for instead of fsencode(sys.argv[0]).
Mon, Sep 2, 2:48 AM
martinvonz added a comment to D6775: py3: convert hg executable path to bytes in missing case in procutil.
In D6775#99509, @yuja wrote:
  • a/mercurial/utils/procutil.py

+++ b/mercurial/utils/procutil.py
@@ -246,7 +246,7 @@

    _sethgexecutable(pycompat.fsencode(mainmod.__file__))
else:
    exe = findexe('hg') or os.path.basename(sys.argv[0])
  • _sethgexecutable(exe)

+ _sethgexecutable(pycompat.fsencode(exe))

Perhaps, pycompat.sysargv has to be used instead. Applying fsencode()
on sys.argv might be incorrect on Windows.

Mon, Sep 2, 2:44 AM

Sat, Aug 31

martinvonz committed rHGf1f9ad5ae4f8: py3: convert hg executable path to bytes in missing case in procutil.
py3: convert hg executable path to bytes in missing case in procutil
Sat, Aug 31, 11:10 PM
martinvonz committed rHGcde1c101ab8a: py3: make statprof's chrome output work.
py3: make statprof's chrome output work
Sat, Aug 31, 11:10 PM
martinvonz committed rHGcd3b5be5515d: py3: for statprof's Chrome output, write json to string, then encode to bytes.
py3: for statprof's Chrome output, write json to string, then encode to bytes
Sat, Aug 31, 11:10 PM
martinvonz committed rHGdb6d7cbda80b: statprof: use context manager for file when writing flame graph.
statprof: use context manager for file when writing flame graph
Sat, Aug 31, 11:10 PM
martinvonz closed D6775: py3: convert hg executable path to bytes in missing case in procutil.
Sat, Aug 31, 6:59 PM
martinvonz closed D6777: py3: make statprof's chrome output work.
Sat, Aug 31, 6:59 PM
martinvonz committed rHG5e784b7fcd3a: py3: convert hg executable path to bytes in missing case in procutil.
py3: convert hg executable path to bytes in missing case in procutil
Sat, Aug 31, 6:59 PM
martinvonz closed D6781: py3: for statprof's Chrome output, write json to string, then encode to bytes.
Sat, Aug 31, 6:59 PM
martinvonz committed rHG4187ecc19ff5: py3: make statprof's chrome output work.
py3: make statprof's chrome output work
Sat, Aug 31, 6:59 PM
martinvonz closed D6780: statprof: use context manager for file when writing flame graph.
Sat, Aug 31, 6:59 PM
martinvonz committed rHG06e2467ff27a: py3: for statprof's Chrome output, write json to string, then encode to bytes.
py3: for statprof's Chrome output, write json to string, then encode to bytes
Sat, Aug 31, 6:59 PM
martinvonz closed D6779: statprof: use context manager when reading source from file.
Sat, Aug 31, 6:59 PM
martinvonz committed rHGdac4a3b6f86e: statprof: use context manager for file when writing flame graph.
statprof: use context manager for file when writing flame graph
Sat, Aug 31, 6:59 PM