This commit temporarily drops support for extra .wxs files. We
raise an exception instead of silently not using them, which I think
is appropriate. We should be able to add support back in by injecting
state into pyoxidizer.bzl via --var.

In D10770#164629, @marmoute wrote:

In D10770#164628, @martinvonz wrote:

In D10770#164626, @marmoute wrote:

Looks like this is happening because of an inconsistency betwen the fact we passe a binary 'struct' for INDEX_HEADER and a sysstr for the extra once. I would rather fix this by making them consistent.

I'm not sure I understand. Can you show me how?

$ python3.6 -c 'import struct; print(type(struct.Struct(b"I").format))'
<class 'bytes'>
$ python3.6 -c 'import struct; print(type(struct.Struct("I").format))'
<class 'bytes'>
$ python3.7 -c 'import struct; print(type(struct.Struct(b"I").format))'
<class 'str'>
$ python3.7 -c 'import struct; print(type(struct.Struct("I").format))'
<class 'str'>

Okay, so my assertion is correct and Python behavior is… creative. Maybe we should build a pycompat wrapper for struct.format access ?

In D10770#164626, @marmoute wrote:

Looks like this is happening because of an inconsistency betwen the fact we passe a binary 'struct' for INDEX_HEADER and a sysstr for the extra once. I would rather fix this by making them consistent.

In D10741#164343, @Alphare wrote:

Thanks! I always use the CI before queuing patches. It's kind of cumbersome, but it's the only real solution.

In D10741#164340, @Alphare wrote:

This triggered an issue with the Rust version of the index (which broke our CI), I have send a fix for it as D10764

Looks like D10673 was queued instead, so this can be abandoned, I think.

@joerg.sonnenberger, are you happy with @spectral's answer?