martinvonz (Martin von Zweigbergk)
User

Projects

User Details

User Since
Jun 28 2017, 5:28 PM (99 w, 1 d)

Recent Activity

Yesterday

martinvonz added a comment to D6436: narrow: use narrow_widen wireproto command to widen in case of ellipses.

This is going to break our server. Can you make it work with existing servers for a while (behave differently depending on capability, I suppose), so we can get a chance to transition? I would think it's not going to be terribly hard, but let me know if it would take more time than you have and I'll try to help.

Thu, May 23, 12:45 PM
martinvonz added inline comments to D6435: narrow: factor out logic to build ellipses related b2parts in separate fn.
Thu, May 23, 12:42 PM
martinvonz added a comment to D6432: match: de-flake test-doctest.py by not depending on util.dirs() order.
In D6432#93545, @yuja wrote:

@@ -1384,26 +1384,26 @@

>>> _rootsdirsandparents(
...     [(b'glob', b'g/h/*', b''), (b'glob', b'g/h', b''),
...      (b'glob', b'g*', b'')])
  • (['g/h', 'g/h', ''], [], ['', 'g']) + (['g/h', 'g/h', ''], [], set(['', 'g']))

Perhaps, this would break py3 doctests. The repr syntax changed.

Thu, May 23, 12:28 PM
martinvonz added inline comments to D6408: convert: demonstrate broken {files} list in merge commits with file flags.
Thu, May 23, 9:06 AM

Wed, May 22

martinvonz closed D6433: match: remove an obsolete comment about util.finddirs().
Wed, May 22, 7:41 PM
martinvonz closed D6432: match: de-flake test-doctest.py by not depending on util.dirs() order.
Wed, May 22, 7:41 PM
martinvonz committed rHGc4b8f8637d7a: match: de-flake test-doctest.py by not depending on util.dirs() order.
match: de-flake test-doctest.py by not depending on util.dirs() order
Wed, May 22, 7:41 PM
martinvonz committed rHG52beb1b8a649: match: remove an obsolete comment about util.finddirs().
match: remove an obsolete comment about util.finddirs()
Wed, May 22, 7:41 PM
martinvonz added a comment to D6422: copies: avoid calling matcher if matcher.always().

The nodes in the above example have been selected by a script because they had interresting property. They are not based on a tag so I can't give you one. How did you converted the repo ? I think hg convert keeps a map somewhere, otherwise, using the commit message could work.

Wed, May 22, 7:09 PM
martinvonz created D6433: match: remove an obsolete comment about util.finddirs().
Wed, May 22, 5:26 PM
martinvonz created D6432: match: de-flake test-doctest.py by not depending on util.dirs() order.
Wed, May 22, 5:26 PM
martinvonz added a dependent revision for D6432: match: de-flake test-doctest.py by not depending on util.dirs() order: D6433: match: remove an obsolete comment about util.finddirs().
Wed, May 22, 5:26 PM
martinvonz added a comment to D6422: copies: avoid calling matcher if matcher.always().

Can you indicate a summary of the total speedup of the series ? (from base to last changesets?).

Wed, May 22, 3:17 PM
martinvonz updated the summary of D6422: copies: avoid calling matcher if matcher.always().
Wed, May 22, 3:15 PM
martinvonz added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

We could maybe make it a function of both the number of heads and roots. That is not strictly the number of connected set, but that would provide a more conservative approach. That could over-sample for hour-glass shape, but they are probably less common.

The current way (only consider roots) should not over-sample, right? It still seems very effective in practice.

I suppose it will if you have thousands of roots converging to one point, then that point diverging again towards thousands of heads, all of that actually missing from the remote, but anyway, the current random wouldn't catch that either.

Wed, May 22, 2:29 PM
martinvonz added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

We could maybe make it a function of both the number of heads and roots. That is not strictly the number of connected set, but that would provide a more conservative approach. That could over-sample for hour-glass shape, but they are probably less common.

Wed, May 22, 1:42 PM
martinvonz updated the summary of D6431: copies: also encode p[12]copies destination as index into "files" list.
Wed, May 22, 1:03 PM
martinvonz updated the diff for D6416: changelog: optionally store added and removed files in changeset extras.
Wed, May 22, 1:02 PM
martinvonz created D6431: copies: also encode p[12]copies destination as index into "files" list.
Wed, May 22, 1:02 PM
martinvonz updated the diff for D6417: context: get filesadded() and filesremoved() from changeset if configured.
Wed, May 22, 1:02 PM
martinvonz added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

I feel like I am missing something. Your commit message seems to be talking using at least as many item in the sameple than there is independant connected set. However your code seems to use "heads(undecided)" that is a quite different. Using independant connected set seems like a good trade off (but might be expensive to compute). Using all heads can significantly bloat the discovery without giving it a significant edge in many cases.

Good point. The case I can think of is when you have a tree of commits on the local side. Something like this:

o
| o
| | o
| | | o
| | |/
| |/
| o
| |
| o
| |
| o
|/
o
~

If we have a long sequence of commits there and many heads, we would increase the sampling of the (mostly-)linear part unnecessarily. I'll see if there's an easy way to improve that.

Wed, May 22, 12:07 PM

Tue, May 21

martinvonz created D6416: changelog: optionally store added and removed files in changeset extras.
Tue, May 21, 8:33 PM
martinvonz added a dependency for D6416: changelog: optionally store added and removed files in changeset extras: D6369: templatekw: make {file_*} compare to both merge parents (issue4292).
Tue, May 21, 8:33 PM
martinvonz added a dependent revision for D6369: templatekw: make {file_*} compare to both merge parents (issue4292): D6416: changelog: optionally store added and removed files in changeset extras.
Tue, May 21, 8:33 PM
martinvonz created D6422: copies: avoid calling matcher if matcher.always().
Tue, May 21, 8:32 PM
martinvonz created D6420: copies: don't filter out copy targets created on other side of merge commit.
Tue, May 21, 8:32 PM
martinvonz added a dependent revision for D6421: copies: avoid unnecessary copying of copy dict: D6422: copies: avoid calling matcher if matcher.always().
Tue, May 21, 8:32 PM
martinvonz created D6421: copies: avoid unnecessary copying of copy dict.
Tue, May 21, 8:32 PM
martinvonz created D6417: context: get filesadded() and filesremoved() from changeset if configured.
Tue, May 21, 8:32 PM
martinvonz added a dependent revision for D6420: copies: don't filter out copy targets created on other side of merge commit: D6421: copies: avoid unnecessary copying of copy dict.
Tue, May 21, 8:32 PM
martinvonz created D6419: copies: do full filtering at end of _changesetforwardcopies().
Tue, May 21, 8:32 PM
martinvonz added a dependent revision for D6419: copies: do full filtering at end of _changesetforwardcopies(): D6420: copies: don't filter out copy targets created on other side of merge commit.
Tue, May 21, 8:32 PM
martinvonz added a dependent revision for D6418: copies: split up _chain() in naive chaining and filtering steps: D6419: copies: do full filtering at end of _changesetforwardcopies().
Tue, May 21, 8:32 PM
martinvonz created D6418: copies: split up _chain() in naive chaining and filtering steps.
Tue, May 21, 8:32 PM
martinvonz added a dependent revision for D6417: context: get filesadded() and filesremoved() from changeset if configured: D6418: copies: split up _chain() in naive chaining and filtering steps.
Tue, May 21, 8:32 PM
martinvonz added a dependent revision for D6416: changelog: optionally store added and removed files in changeset extras: D6417: context: get filesadded() and filesremoved() from changeset if configured.
Tue, May 21, 8:32 PM
martinvonz updated the diff for D2647: setdiscovery: make progress on most connected groups each roundtrip.
Tue, May 21, 6:01 PM
martinvonz added a comment to D2647: setdiscovery: make progress on most connected groups each roundtrip.

I feel like I am missing something. Your commit message seems to be talking using at least as many item in the sameple than there is independant connected set. However your code seems to use "heads(undecided)" that is a quite different. Using independant connected set seems like a good trade off (but might be expensive to compute). Using all heads can significantly bloat the discovery without giving it a significant edge in many cases.

Tue, May 21, 5:05 PM
martinvonz added a reviewer for D2647: setdiscovery: make progress on most connected groups each roundtrip: marmoute.
Tue, May 21, 3:54 PM
martinvonz updated the summary of D2647: setdiscovery: make progress on most connected groups each roundtrip.
Tue, May 21, 3:51 PM
martinvonz retitled D2647: setdiscovery: make progress on most connected groups each roundtrip from setdiscovery: make progress on each connected group each roundtrip to setdiscovery: make progress on most connected groups each roundtrip.
Tue, May 21, 3:49 PM
martinvonz updated the diff for D2647: setdiscovery: make progress on most connected groups each roundtrip.
Tue, May 21, 2:09 PM
martinvonz reclaimed D2647: setdiscovery: make progress on most connected groups each roundtrip.
Tue, May 21, 2:08 PM

Mon, May 20

martinvonz committed rHG1bc7d4cb4182: help: document new "bookmarksinstore" requirement in internals.requirements.
help: document new "bookmarksinstore" requirement in internals.requirements
Mon, May 20, 8:30 PM
martinvonz closed D6413: help: document new "bookmarksinstore" requirement in internals.requirements.
Mon, May 20, 8:30 PM
martinvonz added a reviewer for D6413: help: document new "bookmarksinstore" requirement in internals.requirements: indygreg.
Mon, May 20, 7:20 PM
martinvonz created D6413: help: document new "bookmarksinstore" requirement in internals.requirements.
Mon, May 20, 7:16 PM
martinvonz closed D6390: commit: move sorting of added and removed files list to lower level.
Mon, May 20, 11:49 AM
martinvonz closed D6401: match: use '' instead of '.' for root directory (API).
Mon, May 20, 11:49 AM
martinvonz closed D6403: util: make util.dirs() and util.finddirs() include root directory (API).
Mon, May 20, 11:48 AM
martinvonz committed rHG6310180662f5: commit: move sorting of added and removed files list to lower level.
commit: move sorting of added and removed files list to lower level
Mon, May 20, 11:48 AM
martinvonz committed rHG38d85ec06552: match: drop unnecessary adding of '' to set of dirs.
match: drop unnecessary adding of '' to set of dirs
Mon, May 20, 11:48 AM
martinvonz closed D6406: match: drop unnecessary adding of '' to set of dirs.
Mon, May 20, 11:48 AM
martinvonz committed rHGc361db7a5f14: copies: remove hack for adding root dir to util.dirs object.
copies: remove hack for adding root dir to util.dirs object
Mon, May 20, 11:47 AM
martinvonz committed rHG7d4ee14ff92d: narrowcommands: drop unnecessary adding of '' for root directory.
narrowcommands: drop unnecessary adding of '' for root directory
Mon, May 20, 11:47 AM
martinvonz closed D6404: copies: remove hack for adding root dir to util.dirs object.
Mon, May 20, 11:47 AM
martinvonz closed D6405: narrowcommands: drop unnecessary adding of '' for root directory.
Mon, May 20, 11:47 AM
martinvonz committed rHGd8e55c0c642c: util: make util.dirs() and util.finddirs() include root directory (API).
util: make util.dirs() and util.finddirs() include root directory (API)
Mon, May 20, 11:47 AM
martinvonz committed rHG448486e12c13: dirstate: drop workaround for '.' matching root directory.
dirstate: drop workaround for '.' matching root directory
Mon, May 20, 11:47 AM
martinvonz closed D6402: dirstate: drop workaround for '.' matching root directory.
Mon, May 20, 11:47 AM
martinvonz closed D6409: convert: don't include file in "files" list if it's added in p2.
Mon, May 20, 11:47 AM
martinvonz committed rHG27d6956d386b: match: use '' instead of '.' for root directory (API).
match: use '' instead of '.' for root directory (API)
Mon, May 20, 11:47 AM
martinvonz committed rHG7ada598941d2: dirstate: move special handling of files==['.'] together.
dirstate: move special handling of files==['.'] together
Mon, May 20, 11:47 AM
martinvonz closed D6400: dirstate: move special handling of files==['.'] together.
Mon, May 20, 11:47 AM
martinvonz closed D6408: convert: demonstrate broken {files} list in merge commits with file flags.
Mon, May 20, 11:46 AM
martinvonz committed rHG78530404d00b: convert: demonstrate broken {files} list in merge commits with file flags.
convert: demonstrate broken {files} list in merge commits with file flags
Mon, May 20, 11:46 AM
martinvonz committed rHGc0e1ea0c4cee: convert: don't include file in "files" list if it's added in p2.
convert: don't include file in "files" list if it's added in p2
Mon, May 20, 11:46 AM

Sat, May 18

martinvonz committed rHGbcb1a2b6cd00: relnotes: mention removed support for mixed log graph lines.
relnotes: mention removed support for mixed log graph lines
Sat, May 18, 10:31 AM
martinvonz closed D6407: relnotes: mention removed support for mixed log graph lines.
Sat, May 18, 10:31 AM

Fri, May 17

martinvonz updated the diff for D6407: relnotes: mention removed support for mixed log graph lines.
Fri, May 17, 3:41 PM
martinvonz created D6409: convert: don't include file in "files" list if it's added in p2.
Fri, May 17, 2:49 PM
martinvonz added a dependent revision for D6408: convert: demonstrate broken {files} list in merge commits with file flags: D6409: convert: don't include file in "files" list if it's added in p2.
Fri, May 17, 2:49 PM
martinvonz created D6408: convert: demonstrate broken {files} list in merge commits with file flags.
Fri, May 17, 2:49 PM
martinvonz added a reviewer for D6407: relnotes: mention removed support for mixed log graph lines: spectral.
Fri, May 17, 2:12 PM
martinvonz created D6407: relnotes: mention removed support for mixed log graph lines.
Fri, May 17, 2:12 PM
martinvonz updated the diff for D6401: match: use '' instead of '.' for root directory (API).
Fri, May 17, 2:06 PM
martinvonz updated the diff for D6403: util: make util.dirs() and util.finddirs() include root directory (API).
Fri, May 17, 2:05 PM
martinvonz created D6401: match: use '' instead of '.' for root directory (API).
Fri, May 17, 1:58 PM
martinvonz created D6403: util: make util.dirs() and util.finddirs() include root directory (API).
Fri, May 17, 1:58 PM
martinvonz created D6406: match: drop unnecessary adding of '' to set of dirs.
Fri, May 17, 1:57 PM
martinvonz created D6405: narrowcommands: drop unnecessary adding of '' for root directory.
Fri, May 17, 1:57 PM
martinvonz added a dependent revision for D6405: narrowcommands: drop unnecessary adding of '' for root directory: D6406: match: drop unnecessary adding of '' to set of dirs.
Fri, May 17, 1:57 PM
martinvonz created D6404: copies: remove hack for adding root dir to util.dirs object.
Fri, May 17, 1:57 PM
martinvonz added a dependent revision for D6404: copies: remove hack for adding root dir to util.dirs object: D6405: narrowcommands: drop unnecessary adding of '' for root directory.
Fri, May 17, 1:57 PM
martinvonz created D6402: dirstate: drop workaround for '.' matching root directory.
Fri, May 17, 1:57 PM
martinvonz added a dependent revision for D6403: util: make util.dirs() and util.finddirs() include root directory (API): D6404: copies: remove hack for adding root dir to util.dirs object.
Fri, May 17, 1:57 PM
martinvonz added a dependent revision for D6402: dirstate: drop workaround for '.' matching root directory: D6403: util: make util.dirs() and util.finddirs() include root directory (API).
Fri, May 17, 1:57 PM
martinvonz added a dependent revision for D6401: match: use '' instead of '.' for root directory (API): D6402: dirstate: drop workaround for '.' matching root directory.
Fri, May 17, 1:57 PM
martinvonz created D6400: dirstate: move special handling of files==['.'] together.
Fri, May 17, 1:57 PM
martinvonz added a dependent revision for D6400: dirstate: move special handling of files==['.'] together: D6401: match: use '' instead of '.' for root directory (API).
Fri, May 17, 1:57 PM
martinvonz closed D6387: bookmarks: keep bookmarks in .hg/store if new config set.
Fri, May 17, 9:45 AM
martinvonz closed D6388: exchange: don't take wlock if bookmarks are stored in .hg/store/.
Fri, May 17, 9:44 AM
martinvonz committed rHG526750cdd02d: bookmarks: keep bookmarks in .hg/store if new config set.
bookmarks: keep bookmarks in .hg/store if new config set
Fri, May 17, 9:44 AM
martinvonz committed rHG5d4ec64a6fcb: exchange: don't take wlock if bookmarks are stored in .hg/store/.
exchange: don't take wlock if bookmarks are stored in .hg/store/
Fri, May 17, 9:44 AM
martinvonz added inline comments to D6271: rust-filepatterns: add a Rust implementation of pattern-related utils.
Fri, May 17, 9:14 AM
martinvonz added inline comments to D6271: rust-filepatterns: add a Rust implementation of pattern-related utils.
Fri, May 17, 9:11 AM
martinvonz added inline comments to D6271: rust-filepatterns: add a Rust implementation of pattern-related utils.
Fri, May 17, 1:51 AM
martinvonz added inline comments to D6271: rust-filepatterns: add a Rust implementation of pattern-related utils.
Fri, May 17, 1:47 AM

Thu, May 16

martinvonz retitled D6369: templatekw: make {file_*} compare to both merge parents (issue4292) from templatekw: get file_{adds,mods,dels} directly from context (issue4292) to templatekw: make {file_*} compare to both merge parents (issue4292).
Thu, May 16, 4:53 PM
martinvonz updated the summary of D6390: commit: move sorting of added and removed files list to lower level.
Thu, May 16, 1:45 PM