Page MenuHomePhabricator

martinvonz (Martin von Zweigbergk)
User

Projects

User Details

User Since
Jun 28 2017, 5:28 PM (207 w, 3 d)

Recent Activity

Fri, Jun 18

martinvonz created D10884: ui: add a context manager for silencing the ui (pushbuffer+popbuffer).
Fri, Jun 18, 8:00 PM
martinvonz created D10885: debugbackupbundle: use new context manager for silencing the ui.
Fri, Jun 18, 7:58 PM
martinvonz created D10886: narrowbundle: use new context manager for silencing the ui.
Fri, Jun 18, 7:58 PM
martinvonz created D10883: shelve: don't swallow errors that happen when reverting the working copy.
Fri, Jun 18, 5:56 PM
martinvonz created D10882: histedit: don't swallow errors that happen when updating the working copy.
Fri, Jun 18, 5:56 PM
martinvonz created D10881: histedit: don't record labels for output that we will discard.
Fri, Jun 18, 5:56 PM
martinvonz updated the diff for D10863: cmdutil: make resolvecommitoptions() work on str-keyed opts.
Fri, Jun 18, 5:55 PM
martinvonz updated the diff for D10864: dog-raft: work with str-keyed opts throughout.
Fri, Jun 18, 5:55 PM
martinvonz updated the diff for D10862: cmdutil: make amend() take str-keyed opts.
Fri, Jun 18, 5:55 PM
martinvonz updated the diff for D10861: commit: keep opts dict str-keyed a bit longer.
Fri, Jun 18, 5:54 PM
martinvonz updated the diff for D10860: dog-raft: keep opts dict str-keyed a bit longer.
Fri, Jun 18, 5:53 PM
martinvonz created D10880: amend: work mostly with str-type **opts for simplicity.
Fri, Jun 18, 5:52 PM

Thu, Jun 17

martinvonz added a comment to D10688: packaging: use PyOxidizer for producing WiX MSI installer.

This commit temporarily drops support for extra .wxs files. We
raise an exception instead of silently not using them, which I think
is appropriate. We should be able to add support back in by injecting
state into pyoxidizer.bzl via --var.

Thu, Jun 17, 7:19 PM

Thu, Jun 10

martinvonz updated the summary of D10863: cmdutil: make resolvecommitoptions() work on str-keyed opts.
Thu, Jun 10, 7:24 PM
martinvonz created D10863: cmdutil: make resolvecommitoptions() work on str-keyed opts.
Thu, Jun 10, 7:23 PM
martinvonz created D10862: cmdutil: make amend() take str-keyed opts.
Thu, Jun 10, 7:22 PM
martinvonz created D10864: dog-raft: work with str-keyed opts throughout.
Thu, Jun 10, 7:22 PM
martinvonz created D10859: cmdutil: make checknotesize() work on str-keyed opts.
Thu, Jun 10, 7:22 PM
martinvonz created D10861: commit: keep opts dict str-keyed a bit longer.
Thu, Jun 10, 7:22 PM
martinvonz created D10860: dog-raft: keep opts dict str-keyed a bit longer.
Thu, Jun 10, 7:21 PM

Mon, Jun 7

martinvonz closed D10832: rewriteutil: add pointer to help text when rewrite would cause divergence.
Mon, Jun 7, 3:44 AM
martinvonz closed D10830: merge: make applyupdates() not mutate mresult argument.
Mon, Jun 7, 3:44 AM
martinvonz committed rHG8125bcd28a5c: rewriteutil: add pointer to help text when rewrite would cause divergence.
rewriteutil: add pointer to help text when rewrite would cause divergence
Mon, Jun 7, 3:44 AM
martinvonz committed rHG9e6e12e1a87e: merge: make applyupdates() not mutate mresult argument.
merge: make applyupdates() not mutate mresult argument
Mon, Jun 7, 3:44 AM

Thu, Jun 3

martinvonz created D10832: rewriteutil: add pointer to help text when rewrite would cause divergence.
Thu, Jun 3, 1:50 PM

Tue, Jun 1

martinvonz created D10830: merge: make applyupdates() not mutate mresult argument.
Tue, Jun 1, 6:46 PM
martinvonz committed rHG710435a5c469: docket: make compatible with py3.6, where Struct.format is bytes.
docket: make compatible with py3.6, where Struct.format is bytes
Tue, Jun 1, 10:07 AM

Fri, May 28

martinvonz added a comment to D10770: docket: make compatible with py3.6, where Struct.format is bytes.

Looks like this is happening because of an inconsistency betwen the fact we passe a binary 'struct' for INDEX_HEADER and a sysstr for the extra once. I would rather fix this by making them consistent.

I'm not sure I understand. Can you show me how?

$ python3.6 -c 'import struct; print(type(struct.Struct(b"I").format))'
<class 'bytes'>
$ python3.6 -c 'import struct; print(type(struct.Struct("I").format))'
<class 'bytes'>
$ python3.7 -c 'import struct; print(type(struct.Struct(b"I").format))'
<class 'str'>
$ python3.7 -c 'import struct; print(type(struct.Struct("I").format))'
<class 'str'>

Okay, so my assertion is correct and Python behavior is… creative. Maybe we should build a pycompat wrapper for struct.format access ?

Fri, May 28, 9:34 AM
martinvonz added a comment to D10770: docket: make compatible with py3.6, where Struct.format is bytes.

Looks like this is happening because of an inconsistency betwen the fact we passe a binary 'struct' for INDEX_HEADER and a sysstr for the extra once. I would rather fix this by making them consistent.

Fri, May 28, 9:28 AM

Tue, May 25

martinvonz created D10770: docket: make compatible with py3.6, where Struct.format is bytes.
Tue, May 25, 7:55 PM

Fri, May 21

martinvonz added a comment to D10741: errors: make StorageError subclass Error, attaching an exit code to it.

Thanks! I always use the CI before queuing patches. It's kind of cumbersome, but it's the only real solution.

Fri, May 21, 1:08 PM
martinvonz committed rHG73f52278a158: errors: make exit codes class variables instead.
errors: make exit codes class variables instead
Fri, May 21, 12:35 PM
martinvonz closed D10758: errors: make exit codes class variables instead.
Fri, May 21, 12:35 PM
martinvonz added a comment to D10741: errors: make StorageError subclass Error, attaching an exit code to it.

This triggered an issue with the Rust version of the index (which broke our CI), I have send a fix for it as D10764

Fri, May 21, 12:28 PM

May 20 2021

D10734: narrow: widen when files are excluded by sparse and not included by narrow is now accepted and ready to land.
May 20 2021, 1:25 PM
martinvonz created D10758: errors: make exit codes class variables instead.
May 20 2021, 11:21 AM
martinvonz closed D10741: errors: make StorageError subclass Error, attaching an exit code to it.
May 20 2021, 9:22 AM
martinvonz closed D10740: revlog: avoid raising no-arg RevlogError for internal flow control.
May 20 2021, 9:22 AM
martinvonz closed D10739: errors: catch the new Error class in scmutil and chgserver.
May 20 2021, 9:21 AM
martinvonz committed rHGdd339191f2dc: errors: make StorageError subclass Error, attaching an exit code to it.
errors: make StorageError subclass Error, attaching an exit code to it
May 20 2021, 9:21 AM
martinvonz closed D10737: errors: make InterventionRequired subclass Abort.
May 20 2021, 9:21 AM
martinvonz committed rHG93a0abe098e7: revlog: avoid raising no-arg RevlogError for internal flow control.
revlog: avoid raising no-arg RevlogError for internal flow control
May 20 2021, 9:21 AM
martinvonz closed D10735: errors: let each Abort subclass define its error code.
May 20 2021, 9:21 AM
martinvonz committed rHG7a769ac49637: errors: catch the new Error class in scmutil and chgserver.
errors: catch the new Error class in scmutil and chgserver
May 20 2021, 9:21 AM
martinvonz closed D10738: errors: create superclass for Abort exception.
May 20 2021, 9:21 AM
martinvonz committed rHG5a75be916316: errors: create superclass for Abort exception.
errors: create superclass for Abort exception
May 20 2021, 9:21 AM
martinvonz committed rHGd9c71bbe20f7: errors: make InterventionRequired subclass Abort.
errors: make InterventionRequired subclass Abort
May 20 2021, 9:21 AM
martinvonz closed D10736: errors: move Abort earlier, so more exceptions can subclass it.
May 20 2021, 9:21 AM
martinvonz committed rHG5e736d2e9703: errors: move Abort earlier, so more exceptions can subclass it.
errors: move Abort earlier, so more exceptions can subclass it
May 20 2021, 9:21 AM
martinvonz committed rHG33c0c25d0b0f: errors: let each Abort subclass define its error code.
errors: let each Abort subclass define its error code
May 20 2021, 9:21 AM

May 19 2021

martinvonz added inline comments to D10734: narrow: widen when files are excluded by sparse and not included by narrow.
May 19 2021, 2:33 PM
martinvonz added inline comments to D10734: narrow: widen when files are excluded by sparse and not included by narrow.
May 19 2021, 1:45 PM
martinvonz created D10740: revlog: avoid raising no-arg RevlogError for internal flow control.
May 19 2021, 1:48 AM
martinvonz created D10741: errors: make StorageError subclass Error, attaching an exit code to it.
May 19 2021, 1:48 AM
martinvonz created D10739: errors: catch the new Error class in scmutil and chgserver.
May 19 2021, 1:48 AM
martinvonz created D10737: errors: make InterventionRequired subclass Abort.
May 19 2021, 1:48 AM
martinvonz created D10738: errors: create superclass for Abort exception.
May 19 2021, 1:48 AM
martinvonz created D10736: errors: move Abort earlier, so more exceptions can subclass it.
May 19 2021, 1:47 AM

May 18 2021

martinvonz created D10735: errors: let each Abort subclass define its error code.
May 18 2021, 8:30 PM
martinvonz closed D10723: rewriteutil: add pointer to help text when rewrite would cause divergence.
May 18 2021, 4:54 AM
martinvonz committed rHG055f7b9f2307: rewriteutil: add pointer to help text when rewrite would cause divergence.
rewriteutil: add pointer to help text when rewrite would cause divergence
May 18 2021, 4:54 AM

May 17 2021

martinvonz created D10723: rewriteutil: add pointer to help text when rewrite would cause divergence.
May 17 2021, 6:16 PM

May 15 2021

martinvonz closed D10707: templates: fix `revset('parents()') % ...` in amend message template.
May 15 2021, 7:23 PM
martinvonz committed rHGb338d831d18c: templates: fix `revset('parents()') % ...` in amend message template.
templates: fix `revset('parents()') % ...` in amend message template
May 15 2021, 7:22 PM

May 14 2021

martinvonz added a comment to D10672: remotefilelog: use the correct capability when using getfilestype threaded.

Looks like D10673 was queued instead, so this can be abandoned, I think.

May 14 2021, 5:02 PM
martinvonz added a comment to D10538: tests: allow trunk versions of clang-format to be used.

@joerg.sonnenberger, are you happy with @spectral's answer?

May 14 2021, 3:03 PM

May 11 2021

martinvonz updated the diff for D10707: templates: fix `revset('parents()') % ...` in amend message template.
May 11 2021, 3:43 PM
martinvonz created D10707: templates: fix `revset('parents()') % ...` in amend message template.
May 11 2021, 3:27 PM

May 7 2021

martinvonz closed D10697: rename: add hint about --at-rev if source file doesn't exist.
May 7 2021, 10:12 PM
martinvonz committed rHG5ffc6c18fb96: rename: add hint about --at-rev if source file doesn't exist.
rename: add hint about --at-rev if source file doesn't exist
May 7 2021, 10:11 PM
martinvonz created D10697: rename: add hint about --at-rev if source file doesn't exist.
May 7 2021, 11:47 AM

May 5 2021

martinvonz closed D10670: rewriteutil: give examples of public changesets that can't be rewritten.
May 5 2021, 6:38 PM
martinvonz closed D10668: config: add --source option to include source of value.
May 5 2021, 6:38 PM
martinvonz closed D10671: rewriteutil: say how many commits would become orphan if commit is rewritten.
May 5 2021, 6:38 PM
martinvonz committed rHGd90f6237b3aa: rewriteutil: say how many commits would become orphan if commit is rewritten.
rewriteutil: say how many commits would become orphan if commit is rewritten
May 5 2021, 6:36 PM
martinvonz committed rHG3e381eb557f3: config: add --source option to include source of value.
config: add --source option to include source of value
May 5 2021, 6:36 PM
martinvonz committed rHG5b6dd0d9171b: rewriteutil: give examples of public changesets that can't be rewritten.
rewriteutil: give examples of public changesets that can't be rewritten
May 5 2021, 6:36 PM

May 4 2021

martinvonz created D10670: rewriteutil: give examples of public changesets that can't be rewritten.
May 4 2021, 1:59 PM
martinvonz created D10671: rewriteutil: say how many commits would become orphan if commit is rewritten.
May 4 2021, 1:58 PM
martinvonz created D10668: config: add --source option to include source of value.
May 4 2021, 12:23 PM

May 2 2021

martinvonz committed rHG20eba5cef2e0: narrow: add more status messages when narrowing.
narrow: add more status messages when narrowing
May 2 2021, 10:14 PM
martinvonz committed rHG124fe94016c0: narrow: add progress-reporting when looking for local changes in `hg tracked`.
narrow: add progress-reporting when looking for local changes in `hg tracked`
May 2 2021, 10:14 PM

Apr 30 2021

martinvonz closed D10503: narrow: add more status messages when narrowing.
Apr 30 2021, 10:09 AM
martinvonz committed rHGf851c833f273: narrow: add more status messages when narrowing.
narrow: add more status messages when narrowing
Apr 30 2021, 10:08 AM
martinvonz closed D10518: rewriteutil: check for divergence.
Apr 30 2021, 10:08 AM
martinvonz committed rHG1e761c1c7411: narrow: add progress-reporting when looking for local changes in `hg tracked`.
narrow: add progress-reporting when looking for local changes in `hg tracked`
Apr 30 2021, 10:08 AM
martinvonz closed D10501: narrow: add progress-reporting when looking for local changes in `hg tracked`.
Apr 30 2021, 10:08 AM
martinvonz closed D10519: branch: delete obsolete message about changing branch of obsolete commit.
Apr 30 2021, 10:07 AM
martinvonz closed D10517: rewriteutil: point to help about instability when rewriting creates orphan.
Apr 30 2021, 10:07 AM
martinvonz committed rHG45dcb63f8ead: branch: delete obsolete message about changing branch of obsolete commit.
branch: delete obsolete message about changing branch of obsolete commit
Apr 30 2021, 10:07 AM
martinvonz closed D10516: help: add topic about evolution, based on text from evolve extension.
Apr 30 2021, 10:07 AM
martinvonz committed rHGba6881c6a178: rewriteutil: check for divergence.
rewriteutil: check for divergence
Apr 30 2021, 10:07 AM
martinvonz closed D10530: rewriteutil: adapt "cannot %s while merging" to work with "change branch of".
Apr 30 2021, 10:07 AM
martinvonz committed rHGc4dbbaecaad3: rewriteutil: adapt "cannot %s while merging" to work with "change branch of".
rewriteutil: adapt "cannot %s while merging" to work with "change branch of"
Apr 30 2021, 10:06 AM
martinvonz committed rHG7a90fddb13b0: rewriteutil: point to help about instability when rewriting creates orphan.
rewriteutil: point to help about instability when rewriting creates orphan
Apr 30 2021, 10:06 AM
martinvonz committed rHGda4e6d7a8fdd: help: add topic about evolution, based on text from evolve extension.
help: add topic about evolution, based on text from evolve extension
Apr 30 2021, 10:06 AM
martinvonz closed D10514: rewriteutil: replace "null changeset" by "the null revision" in error message.
Apr 30 2021, 10:06 AM
martinvonz committed rHG8ad2f43fe37b: rewriteutil: add devel warning if precheck is called with contexts.
rewriteutil: add devel warning if precheck is called with contexts
Apr 30 2021, 10:06 AM
martinvonz closed D10515: rewriteutil: add devel warning if precheck is called with contexts.
Apr 30 2021, 10:06 AM
martinvonz committed rHG7001f92e0ee9: rewriteutil: replace "null changeset" by "the null revision" in error message.
rewriteutil: replace "null changeset" by "the null revision" in error message
Apr 30 2021, 10:06 AM