Page MenuHomePhabricator

martinvonz (Martin von Zweigbergk)
User

Projects

User Details

User Since
Jun 28 2017, 5:28 PM (162 w, 3 d)

Recent Activity

Today

martinvonz closed D8840: rename: add support for --at-rev, which marks as copy and removes the source.
Sat, Aug 8, 5:02 PM
martinvonz committed rHG5178dd2233d0: rename: add support for --at-rev, which marks as copy and removes the source.
rename: add support for --at-rev, which marks as copy and removes the source
Sat, Aug 8, 5:01 PM
martinvonz committed rHG1c8e3c17c702: makefile: stop setting unused HGEXTDIR variable during osx build.
makefile: stop setting unused HGEXTDIR variable during osx build
Sat, Aug 8, 1:29 PM
martinvonz closed D8915: makefile: stop setting unused HGEXTDIR variable during osx build.
Sat, Aug 8, 1:29 PM
martinvonz created D8915: makefile: stop setting unused HGEXTDIR variable during osx build.
Sat, Aug 8, 1:01 AM

Thu, Aug 6

martinvonz closed D8905: templater: add exception-raising version of open_template().
Thu, Aug 6, 8:35 PM
martinvonz closed D8907: templater: teach template loader to use open_template() function.
Thu, Aug 6, 8:34 PM
martinvonz closed D8906: templater: restructure open_template() a little to prepare for relative paths.
Thu, Aug 6, 8:34 PM
martinvonz committed rHGc3376a724e32: templater: teach template loader to use open_template() function.
templater: teach template loader to use open_template() function
Thu, Aug 6, 8:34 PM
martinvonz committed rHG735756ecda8c: templater: restructure open_template() a little to prepare for relative paths.
templater: restructure open_template() a little to prepare for relative paths
Thu, Aug 6, 8:34 PM
martinvonz closed D8902: templater: replace Py3-only exception types by super-types available in Py2.
Thu, Aug 6, 8:34 PM
martinvonz committed rHG4aa484efc926: templater: add exception-raising version of open_template().
templater: add exception-raising version of open_template()
Thu, Aug 6, 8:34 PM
martinvonz updated subscribers of rHG6e6fe826ba69: templater: replace Py3-only exception types by super-types available in Py2.
templater: replace Py3-only exception types by super-types available in Py2
Thu, Aug 6, 8:34 PM
martinvonz created D8905: templater: add exception-raising version of open_template().
Thu, Aug 6, 2:30 PM
martinvonz created D8907: templater: teach template loader to use open_template() function.
Thu, Aug 6, 2:29 PM
martinvonz created D8906: templater: restructure open_template() a little to prepare for relative paths.
Thu, Aug 6, 2:29 PM
martinvonz added a comment to D8840: rename: add support for --at-rev, which marks as copy and removes the source.

This now includes release notes. I also fixed a bug: I realized only now that I had previously made it remove the source file, but that shouldn't happen since it only supports the -A/--after mode.

Thu, Aug 6, 12:07 PM
martinvonz updated the summary of D8840: rename: add support for --at-rev, which marks as copy and removes the source.
Thu, Aug 6, 12:05 PM
martinvonz updated the diff for D8840: rename: add support for --at-rev, which marks as copy and removes the source.
Thu, Aug 6, 11:37 AM
martinvonz abandoned D8809: templater: reuse check for both "map-cmdline.<name>" and "<name>".
Thu, Aug 6, 11:09 AM
martinvonz created D8902: templater: replace Py3-only exception types by super-types available in Py2.
Thu, Aug 6, 1:27 AM
martinvonz added inline comments to D8894: templater: make open_template() read from resources if in frozen binary.
Thu, Aug 6, 1:11 AM

Wed, Aug 5

martinvonz closed D8892: templater: replace templatepath() with function that also opens the file.
Wed, Aug 5, 8:50 PM
martinvonz closed D8901: hgweb: enable reading styles from resources in frozen binaries.
Wed, Aug 5, 8:50 PM
martinvonz closed D8899: hgweb: open mapfile using templater.open_template().
Wed, Aug 5, 8:49 PM
martinvonz committed rHG1a4f925f72c3: hgweb: enable reading styles from resources in frozen binaries.
hgweb: enable reading styles from resources in frozen binaries
Wed, Aug 5, 8:49 PM
martinvonz committed rHG1b983985edd9: hgweb: open mapfile using templater.open_template().
hgweb: open mapfile using templater.open_template()
Wed, Aug 5, 8:49 PM
martinvonz closed D8900: hgweb: rely on open_template()'s fallback to using templatedir().
Wed, Aug 5, 8:49 PM
martinvonz committed rHGc37ab438ff31: hgweb: rely on open_template()'s fallback to using templatedir().
hgweb: rely on open_template()'s fallback to using templatedir()
Wed, Aug 5, 8:49 PM
martinvonz closed D8898: hgweb: simplify a constant-length list by converting to literal tuple.
Wed, Aug 5, 8:49 PM
martinvonz committed rHG2901133ec982: hgweb: simplify a constant-length list by converting to literal tuple.
hgweb: simplify a constant-length list by converting to literal tuple
Wed, Aug 5, 8:49 PM
martinvonz closed D8897: hgweb: remove some accesses to private member uimod._unset.
Wed, Aug 5, 8:49 PM
martinvonz committed rHGd12fba074cc6: hgweb: remove some accesses to private member uimod._unset.
hgweb: remove some accesses to private member uimod._unset
Wed, Aug 5, 8:49 PM
martinvonz closed D8896: templater: try to read %include in mapfiles from resources.
Wed, Aug 5, 8:49 PM
martinvonz closed D8893: templater: pass opened file-like object to templatespec.
Wed, Aug 5, 8:49 PM
martinvonz committed rHGfef64d7a4a84: templater: try to read %include in mapfiles from resources.
templater: try to read %include in mapfiles from resources
Wed, Aug 5, 8:49 PM
martinvonz closed D8895: templater: unroll loop over mapfile directories.
Wed, Aug 5, 8:49 PM
martinvonz committed rHGd9a502a0a9ca: templater: unroll loop over mapfile directories.
templater: unroll loop over mapfile directories
Wed, Aug 5, 8:49 PM
martinvonz closed D8894: templater: make open_template() read from resources if in frozen binary.
Wed, Aug 5, 8:48 PM
martinvonz committed rHG3b27ed8e324e: templater: make open_template() read from resources if in frozen binary.
templater: make open_template() read from resources if in frozen binary
Wed, Aug 5, 8:48 PM
martinvonz committed rHGf3481e4fcc3a: templater: pass opened file-like object to templatespec.
templater: pass opened file-like object to templatespec
Wed, Aug 5, 8:48 PM
martinvonz committed rHG65a812ed9e9f: templater: replace templatepath() with function that also opens the file.
templater: replace templatepath() with function that also opens the file
Wed, Aug 5, 8:48 PM
martinvonz closed D8874: hgweb: simplify staticfile() now that we always pass it a single directory.
Wed, Aug 5, 8:48 PM
martinvonz closed D8891: templater: start passing resource to read from into _readmapfile().
Wed, Aug 5, 8:48 PM
martinvonz closed D8890: templater: move stylemap() to hgweb_mod, since that's its only user.
Wed, Aug 5, 8:48 PM
martinvonz committed rHGdc10bcd5c08d: templater: start passing resource to read from into _readmapfile().
templater: start passing resource to read from into _readmapfile()
Wed, Aug 5, 8:48 PM
martinvonz closed D8858: packaging: include templates with their package as key in package_data.
Wed, Aug 5, 8:48 PM
martinvonz committed rHGba50c8a95e2b: templater: move stylemap() to hgweb_mod, since that's its only user.
templater: move stylemap() to hgweb_mod, since that's its only user
Wed, Aug 5, 8:48 PM
martinvonz closed D8855: packaging: mark mercurial.templates and subdirs as packages.
Wed, Aug 5, 8:48 PM
martinvonz committed rHG9a5c4875a88c: hgweb: simplify staticfile() now that we always pass it a single directory.
hgweb: simplify staticfile() now that we always pass it a single directory
Wed, Aug 5, 8:47 PM
martinvonz committed rHGe2320bb7a99f: packaging: include templates with their package as key in package_data.
packaging: include templates with their package as key in package_data
Wed, Aug 5, 8:47 PM
martinvonz committed rHG41ff8a463e10: packaging: mark mercurial.templates and subdirs as packages.
packaging: mark mercurial.templates and subdirs as packages
Wed, Aug 5, 8:47 PM
martinvonz committed rHGf55c47f41b8e: templates: add __init__.py files to templates/ dirs.
templates: add __init__.py files to templates/ dirs
Wed, Aug 5, 8:47 PM
martinvonz closed D8854: templates: add __init__.py files to templates/ dirs.
Wed, Aug 5, 8:47 PM
martinvonz created D8899: hgweb: open mapfile using templater.open_template().
Wed, Aug 5, 6:05 PM
martinvonz created D8901: hgweb: enable reading styles from resources in frozen binaries.
Wed, Aug 5, 6:05 PM
martinvonz created D8900: hgweb: rely on open_template()'s fallback to using templatedir().
Wed, Aug 5, 6:05 PM
martinvonz created D8898: hgweb: simplify a constant-length list by converting to literal tuple.
Wed, Aug 5, 6:05 PM
martinvonz created D8897: hgweb: remove some accesses to private member uimod._unset.
Wed, Aug 5, 6:05 PM
martinvonz created D8896: templater: try to read %include in mapfiles from resources.
Wed, Aug 5, 1:10 PM
martinvonz created D8895: templater: unroll loop over mapfile directories.
Wed, Aug 5, 1:10 PM
martinvonz created D8892: templater: replace templatepath() with function that also opens the file.
Wed, Aug 5, 12:27 PM
martinvonz created D8893: templater: pass opened file-like object to templatespec.
Wed, Aug 5, 12:26 PM
martinvonz created D8894: templater: make open_template() read from resources if in frozen binary.
Wed, Aug 5, 12:26 PM
martinvonz created D8891: templater: start passing resource to read from into _readmapfile().
Wed, Aug 5, 12:26 PM
martinvonz created D8890: templater: move stylemap() to hgweb_mod, since that's its only user.
Wed, Aug 5, 12:26 PM

Tue, Aug 4

martinvonz created D8874: hgweb: simplify staticfile() now that we always pass it a single directory.
Tue, Aug 4, 3:00 AM
martinvonz updated the diff for D8858: packaging: include templates with their package as key in package_data.
Tue, Aug 4, 3:00 AM
martinvonz updated the diff for D8855: packaging: mark mercurial.templates and subdirs as packages.
Tue, Aug 4, 2:59 AM

Mon, Aug 3

martinvonz updated the diff for D8858: packaging: include templates with their package as key in package_data.
Mon, Aug 3, 10:18 PM
martinvonz added a comment to D8854: templates: add __init__.py files to templates/ dirs.

OMG. When I reviewed this, I thought your assertion that resources.open_binary('mercurial.templates', 'coal/map') is not valid was wrong because the low-level resource reader on the meta path importer does allow relative paths! However, it appears that the open_binary() helper functions limit this! This is yet another example of wonky behavior in these resources APIs. FWIW I've brought many of these to the attention of the core Python people at https://bugs.python.org/issue36128 and https://gitlab.com/python-devs/importlib_resources/-/issues/58 (and a few other places that I can't find the links to).

Mon, Aug 3, 11:12 AM

Sun, Aug 2

martinvonz committed rHGc8655782ef19: packaging: delete unnecessary updating of `dirs` list.
packaging: delete unnecessary updating of `dirs` list
Sun, Aug 2, 1:42 PM
martinvonz committed rHG8bc9d045005a: packaging: make "mercurial.defaultrc" a key in package_data.
packaging: make "mercurial.defaultrc" a key in package_data
Sun, Aug 2, 1:42 PM
martinvonz closed D8845: templatespec: create a factory function for each type there is.
Sun, Aug 2, 12:35 PM
martinvonz closed D8857: packaging: delete unnecessary updating of `dirs` list.
Sun, Aug 2, 12:34 PM
martinvonz closed D8856: packaging: make "mercurial.defaultrc" a key in package_data.
Sun, Aug 2, 12:34 PM
martinvonz committed rHGa102f61a917e: packaging: delete unnecessary updating of `dirs` list.
packaging: delete unnecessary updating of `dirs` list
Sun, Aug 2, 12:34 PM
martinvonz committed rHG967c81d1b465: packaging: make "mercurial.defaultrc" a key in package_data.
packaging: make "mercurial.defaultrc" a key in package_data
Sun, Aug 2, 12:34 PM
martinvonz closed D8847: templatespec: move check for non-unicode to lower-level function.
Sun, Aug 2, 12:34 PM
martinvonz closed D8848: templatespec: use new factory functions in logcmdutil.
Sun, Aug 2, 12:34 PM
martinvonz committed rHG3c2fae87bd5a: templatespec: use new factory functions in hooklib.
templatespec: use new factory functions in hooklib
Sun, Aug 2, 12:34 PM
martinvonz closed D8853: templatespec: use new factory functions in hooklib.
Sun, Aug 2, 12:34 PM
martinvonz committed rHGc1915cfa8080: templatespec: use new factory functions in logcmdutil.
templatespec: use new factory functions in logcmdutil
Sun, Aug 2, 12:34 PM
martinvonz closed D8846: templatespec: logcmdutil.templatespec() gets either template or mapfile.
Sun, Aug 2, 12:34 PM
martinvonz committed rHG215f08c8006c: templatespec: move check for non-unicode to lower-level function.
templatespec: move check for non-unicode to lower-level function
Sun, Aug 2, 12:34 PM
martinvonz committed rHGdfb67cd1da7f: templatespec: logcmdutil.templatespec() gets either template or mapfile.
templatespec: logcmdutil.templatespec() gets either template or mapfile
Sun, Aug 2, 12:34 PM
martinvonz committed rHG8cce9f77ca73: templatespec: create a factory function for each type there is.
templatespec: create a factory function for each type there is
Sun, Aug 2, 12:34 PM
martinvonz closed D8844: templater: stop accepting a single style to stylemap().
Sun, Aug 2, 12:08 PM
martinvonz closed D8806: templater: don't normalize path separators to '/' when interacting with OS.
Sun, Aug 2, 12:08 PM
martinvonz closed D8807: formatter: inline a variable assigned from `templater.templater.frommapfile`.
Sun, Aug 2, 12:08 PM
martinvonz committed rHGb7444cfc2c05: templater: stop accepting a single style to stylemap().
templater: stop accepting a single style to stylemap()
Sun, Aug 2, 12:08 PM
martinvonz closed D8804: templater: make templatepath() not return directory paths.
Sun, Aug 2, 12:08 PM
martinvonz committed rHG22eafb16f1c5: formatter: inline a variable assigned from `templater.templater.frommapfile`.
formatter: inline a variable assigned from `templater.templater.frommapfile`
Sun, Aug 2, 12:08 PM
martinvonz committed rHG28840ef52f71: templater: don't normalize path separators to '/' when interacting with OS.
templater: don't normalize path separators to '/' when interacting with OS
Sun, Aug 2, 12:07 PM
martinvonz closed D8796: config: remove now-unused `abs` argument from `include` callback.
Sun, Aug 2, 12:07 PM
martinvonz committed rHG653b2a439412: formatter: remove now-unnecessary check for file-ness.
formatter: remove now-unnecessary check for file-ness
Sun, Aug 2, 12:07 PM
martinvonz closed D8805: formatter: remove now-unnecessary check for file-ness.
Sun, Aug 2, 12:07 PM
martinvonz closed D8803: tests: show unusual error message for `hg log --style coal`.
Sun, Aug 2, 12:07 PM
martinvonz committed rHG9a308336fe41: templater: make templatepath() not return directory paths.
templater: make templatepath() not return directory paths
Sun, Aug 2, 12:07 PM
martinvonz committed rHG46c8db8d4e03: tests: show unusual error message for `hg log --style coal`.
tests: show unusual error message for `hg log --style coal`
Sun, Aug 2, 12:07 PM