Page MenuHomePhabricator

martinvonz (Martin von Zweigbergk)
User

Projects

User Details

User Since
Jun 28 2017, 5:28 PM (225 w, 2 d)

Recent Activity

Thu, Oct 21

martinvonz updated the diff for D11680: push: add option to abort on dirty working copy if parent is pushed.
Thu, Oct 21, 1:20 PM
martinvonz added a comment to D11680: push: add option to abort on dirty working copy if parent is pushed.

With a commands.push.check-dirty (or something similar) that control the default value/behavior of this flag.

Thu, Oct 21, 1:19 PM

Tue, Oct 19

martinvonz added a comment to D11693: backout: backed out changeset 6edc8800dbc3.

Queued, thanks!

Tue, Oct 19, 2:00 PM
martinvonz added inline comments to rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 11:18 AM
martinvonz added inline comments to rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 11:10 AM
martinvonz added inline comments to rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 11:04 AM
martinvonz added inline comments to rHG8fb71d1ab953: Backed out changeset 2f2107c01dee.
Tue, Oct 19, 10:59 AM

Mon, Oct 18

martinvonz closed D11667: copy: recommend `--at-rev .` if target was added in parent commit.
Mon, Oct 18, 3:35 PM
martinvonz committed rHGc62e4397eb28: copy: recommend `--at-rev .` if target was added in parent commit.
copy: recommend `--at-rev .` if target was added in parent commit
Mon, Oct 18, 3:34 PM
martinvonz added a comment to D11669: chistedit: add option to show order of commits in opposite order.

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

The user will have to figure it out (hopefully they remembered if they set the config option). Internally at Google, I was going to override helplines() (and some other function which I've forgotten now) to make it print a red banner saying if the direction has changed.

Could I get a follow-up of some kind that prints some advice for users about this in all cases? It seems like even if we don't change the default, we should just tell people. Maybe in plain-text histedit too, but I worry less about that since curses gets more mindshare.

Mon, Oct 18, 2:12 PM
martinvonz added a comment to D11669: chistedit: add option to show order of commits in opposite order.

Doing cross review: is there any indication of the direction of history when the UI pops up, or does the user just have to figure it out?

Mon, Oct 18, 12:48 PM
martinvonz added a comment to D11627: dispatch: ignore failure to flush ui.

This breaks CI on Python 2: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/254041
We unfortunately have to support Python 2 until the release in a few days, so this should get fixed.

It doesn't reproduce for me. Does it for you? I wonder what I need to do to make it reproduce. I have /dev/full.

It does, I'm on Linux if somehow this is OS specific.

$ HGMODULEPOLICY=py python2 ./tests/run-tests.py -j6 tests/test-basic.t
running 1 tests using 1 parallel processes
--- /home/alphare/workspace/octobus/mercurial-devel/tests/test-basic.t
+++ /home/alphare/workspace/octobus/mercurial-devel/tests/test-basic.t.err
@@ -40,13 +40,10 @@
   A a
   $ hg status >/dev/full
-  abort: No space left on device
-  [255]
 #endif
 #if devfull
   $ hg status >/dev/full 2>&1
-  [255]
   $ hg status ENOENT 2>/dev/full
   [255]
ERROR: test-basic.t output changed
!
Failed test-basic.t: output changed
# Ran 1 tests, 0 skipped, 1 failed.
python hash seed: 454035856
Mon, Oct 18, 12:18 PM
martinvonz updated the diff for D11667: copy: recommend `--at-rev .` if target was added in parent commit.
Mon, Oct 18, 12:11 PM
martinvonz added inline comments to D11667: copy: recommend `--at-rev .` if target was added in parent commit.
Mon, Oct 18, 12:10 PM
martinvonz added a comment to D11627: dispatch: ignore failure to flush ui.

This breaks CI on Python 2: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/254041
We unfortunately have to support Python 2 until the release in a few days, so this should get fixed.

Mon, Oct 18, 12:02 PM

Fri, Oct 15

martinvonz created D11680: push: add option to abort on dirty working copy if parent is pushed.
Fri, Oct 15, 7:53 PM
martinvonz closed D11669: chistedit: add option to show order of commits in opposite order.
Fri, Oct 15, 1:04 PM
martinvonz closed D11670: rhg: fix formatting error reported by test-check-format-rust.t.
Fri, Oct 15, 1:04 PM
martinvonz committed rHG1837663ac216: rhg: fix formatting error reported by test-check-format-rust.t.
rhg: fix formatting error reported by test-check-format-rust.t
Fri, Oct 15, 1:04 PM
martinvonz committed rHGc820866c52f9: chistedit: add option to show order of commits in opposite order.
chistedit: add option to show order of commits in opposite order
Fri, Oct 15, 1:04 PM
martinvonz abandoned D11665: formatting: format with newer black version.
Fri, Oct 15, 10:38 AM
martinvonz added a comment to D11670: rhg: fix formatting error reported by test-check-format-rust.t.

@martinvonz, indeed, thanks. Sorry.

Fri, Oct 15, 10:35 AM
martinvonz updated subscribers of D11670: rhg: fix formatting error reported by test-check-format-rust.t.

@aalekseyev, I think you'll want to run rustup install nightly-2020-10-04 to make sure that test-check-format-test.t runs.

Fri, Oct 15, 1:38 AM
martinvonz created D11670: rhg: fix formatting error reported by test-check-format-rust.t.
Fri, Oct 15, 1:36 AM
martinvonz added a comment to D11341: rust: update the minimum version of Rust.

Do you want to also update the rustfmt version used by test-check-format-rust.t?

Fri, Oct 15, 1:28 AM
martinvonz created D11669: chistedit: add option to show order of commits in opposite order.
Fri, Oct 15, 1:15 AM

Thu, Oct 14

martinvonz added a comment to D11666: dirstate-v2: delete unused variable (to make test-check-pyflakes.t happy).

This was already sent in D11658

Thu, Oct 14, 8:27 PM
martinvonz closed D11663: narrow: raise StateError when working copy is stale (for detailed exit code).
Thu, Oct 14, 6:36 PM
martinvonz committed rHG7ed0fc687220: narrow: raise StateError when working copy is stale (for detailed exit code).
narrow: raise StateError when working copy is stale (for detailed exit code)
Thu, Oct 14, 6:36 PM
martinvonz created D11667: copy: recommend `--at-rev .` if target was added in parent commit.
Thu, Oct 14, 4:12 PM
martinvonz created D11665: formatting: format with newer black version.
Thu, Oct 14, 4:12 PM
martinvonz created D11666: dirstate-v2: delete unused variable (to make test-check-pyflakes.t happy).
Thu, Oct 14, 4:11 PM
martinvonz created D11663: narrow: raise StateError when working copy is stale (for detailed exit code).
Thu, Oct 14, 11:58 AM
D11616: rhg: stop manifest traversal when no more files are needed is now accepted and ready to land.

I'm getting ~630ms on **/moz.build when I run the original version (1b0f8aafedea), by the way. Could it be that your ~650ms measurement corresponds to that?

Yeah, it's very possible I messed up my measurements somehow. I'll check again tomorrow, then I'll probably queue your version.

Thu, Oct 14, 11:08 AM
martinvonz abandoned D11622: dirstate: simplify cat operation.
Thu, Oct 14, 11:04 AM

Wed, Oct 13

martinvonz closed D11653: chistedit: rename a confusingly named variable.
Wed, Oct 13, 6:29 PM
martinvonz closed D11652: chistedit: remove some local variable and access state on self instead.
Wed, Oct 13, 6:29 PM
martinvonz closed D11649: chistedit: move changeview() onto state class.
Wed, Oct 13, 6:29 PM
martinvonz committed rHGd8cff8564f5a: chistedit: rename a confusingly named variable.
chistedit: rename a confusingly named variable
Wed, Oct 13, 6:28 PM
martinvonz closed D11648: chistedit: move cycleaction() onto state class.
Wed, Oct 13, 6:28 PM
martinvonz committed rHG1895027c5051: chistedit: remove some local variable and access state on self instead.
chistedit: remove some local variable and access state on self instead
Wed, Oct 13, 6:28 PM
martinvonz closed D11647: chistedit: move changeaction() onto state class.
Wed, Oct 13, 6:28 PM
martinvonz committed rHG1302905b2d49: chistedit: move changeview() onto state class.
chistedit: move changeview() onto state class
Wed, Oct 13, 6:28 PM
martinvonz closed D11646: chistedit: move swap() onto state class.
Wed, Oct 13, 6:28 PM
martinvonz committed rHG7913f533592d: chistedit: move cycleaction() onto state class.
chistedit: move cycleaction() onto state class
Wed, Oct 13, 6:28 PM
martinvonz closed D11645: chistedit: move makeselection() onto state class.
Wed, Oct 13, 6:28 PM
martinvonz committed rHG141aafac446c: chistedit: move changeaction() onto state class.
chistedit: move changeaction() onto state class
Wed, Oct 13, 6:28 PM
martinvonz closed D11644: chistedit: move changemode() onto state class.
Wed, Oct 13, 6:28 PM
martinvonz committed rHG0444956ecbcf: chistedit: move swap() onto state class.
chistedit: move swap() onto state class
Wed, Oct 13, 6:27 PM
martinvonz closed D11643: chistedit: move movecursor() onto state class.
Wed, Oct 13, 6:27 PM
martinvonz committed rHG0f498e03b016: chistedit: move makeselection() onto state class.
chistedit: move makeselection() onto state class
Wed, Oct 13, 6:27 PM
martinvonz closed D11642: chistedit: move patchcontents() onto state class.
Wed, Oct 13, 6:27 PM
martinvonz committed rHG7d2464b6e30b: chistedit: move changemode() onto state class.
chistedit: move changemode() onto state class
Wed, Oct 13, 6:27 PM
martinvonz closed D11641: chistedit: move event() onto state class.
Wed, Oct 13, 6:27 PM
martinvonz committed rHGfb30ad66a572: chistedit: move movecursor() onto state class.
chistedit: move movecursor() onto state class
Wed, Oct 13, 6:27 PM
martinvonz closed D11640: chistedit: move renderpatch() and dependencies onto state class.
Wed, Oct 13, 6:27 PM
martinvonz committed rHGc7690fabce5f: chistedit: move patchcontents() onto state class.
chistedit: move patchcontents() onto state class
Wed, Oct 13, 6:27 PM
martinvonz closed D11639: chistedit: move renderrules() onto state class.
Wed, Oct 13, 6:27 PM
martinvonz committed rHG3fdeb657602f: chistedit: move event() onto state class.
chistedit: move event() onto state class
Wed, Oct 13, 6:26 PM
martinvonz closed D11638: chistedit: move layout() and dependencies onto state class.
Wed, Oct 13, 6:26 PM
martinvonz committed rHG33ece8857efa: chistedit: move renderpatch() and dependencies onto state class.
chistedit: move renderpatch() and dependencies onto state class
Wed, Oct 13, 6:26 PM
martinvonz closed D11637: chistedit: move rendercommit() onto state class.
Wed, Oct 13, 6:26 PM
martinvonz committed rHG8dd2422b0109: chistedit: move renderrules() onto state class.
chistedit: move renderrules() onto state class
Wed, Oct 13, 6:26 PM
martinvonz closed D11636: chistedit: move view state from a dict to a custom class.
Wed, Oct 13, 6:26 PM
martinvonz committed rHG9006eafa0942: chistedit: move layout() and dependencies onto state class.
chistedit: move layout() and dependencies onto state class
Wed, Oct 13, 6:26 PM
martinvonz committed rHG8ac61257c807: chistedit: move rendercommit() onto state class.
chistedit: move rendercommit() onto state class
Wed, Oct 13, 6:26 PM
martinvonz committed rHGb6fc7d188f68: chistedit: move view state from a dict to a custom class.
chistedit: move view state from a dict to a custom class
Wed, Oct 13, 6:26 PM
martinvonz added a comment to D11616: rhg: stop manifest traversal when no more files are needed.

I'm getting ~630ms on **/moz.build when I run the original version (1b0f8aafedea), by the way. Could it be that your ~650ms measurement corresponds to that?

Wed, Oct 13, 1:43 PM
martinvonz added a comment to D11650: rhg: handle null changelog and manifest revisions.

I'll do that.

Submitted: https://phab.mercurial-scm.org/D11656
Is that alright, or do you prefer me amend the original commit? (will I be able to phabsend it though?)

Wed, Oct 13, 1:16 PM

Tue, Oct 12

martinvonz created D11653: chistedit: rename a confusingly named variable.
Tue, Oct 12, 5:31 PM
martinvonz created D11652: chistedit: remove some local variable and access state on self instead.
Tue, Oct 12, 5:31 PM
D11650: rhg: handle null changelog and manifest revisions is now accepted and ready to land.
Tue, Oct 12, 3:53 PM
martinvonz added inline comments to D11650: rhg: handle null changelog and manifest revisions.
Tue, Oct 12, 2:54 PM
martinvonz closed D11628: dispatch: use detailed exit code 250 for keyboard interrupt.
Tue, Oct 12, 1:21 PM
martinvonz closed D11627: dispatch: ignore failure to flush ui.
Tue, Oct 12, 1:20 PM
martinvonz committed rHG6edc8800dbc3: dispatch: use detailed exit code 250 for keyboard interrupt.
dispatch: use detailed exit code 250 for keyboard interrupt
Tue, Oct 12, 1:20 PM
martinvonz closed D11626: dispatch: don't change error status if flushing stdio fails.
Tue, Oct 12, 1:20 PM
martinvonz committed rHG2f2107c01dee: dispatch: ignore failure to flush ui.
dispatch: ignore failure to flush ui
Tue, Oct 12, 1:20 PM
martinvonz committed rHG8fae2cc6ee86: dispatch: don't change error status if flushing stdio fails.
dispatch: don't change error status if flushing stdio fails
Tue, Oct 12, 1:20 PM
martinvonz added a comment to D11625: dirstate-v2: Document flags/mode/size/mtime fields of tree nodes.

I changed this one's parent to be D11623 since D11624 was abandoned. I hope that's how you meant it to be.

Tue, Oct 12, 1:10 PM
martinvonz created D11649: chistedit: move changeview() onto state class.
Tue, Oct 12, 1:07 PM
martinvonz created D11648: chistedit: move cycleaction() onto state class.
Tue, Oct 12, 1:07 PM
martinvonz created D11646: chistedit: move swap() onto state class.
Tue, Oct 12, 1:07 PM
martinvonz created D11647: chistedit: move changeaction() onto state class.
Tue, Oct 12, 1:07 PM
martinvonz created D11645: chistedit: move makeselection() onto state class.
Tue, Oct 12, 1:07 PM
martinvonz created D11644: chistedit: move changemode() onto state class.
Tue, Oct 12, 1:06 PM
martinvonz created D11642: chistedit: move patchcontents() onto state class.
Tue, Oct 12, 1:06 PM
martinvonz created D11643: chistedit: move movecursor() onto state class.
Tue, Oct 12, 1:06 PM
martinvonz created D11641: chistedit: move event() onto state class.
Tue, Oct 12, 1:06 PM
martinvonz created D11640: chistedit: move renderpatch() and dependencies onto state class.
Tue, Oct 12, 1:06 PM
martinvonz created D11639: chistedit: move renderrules() onto state class.
Tue, Oct 12, 1:05 PM
martinvonz created D11638: chistedit: move layout() and dependencies onto state class.
Tue, Oct 12, 1:05 PM
martinvonz created D11637: chistedit: move rendercommit() onto state class.
Tue, Oct 12, 1:05 PM
martinvonz created D11636: chistedit: move view state from a dict to a custom class.
Tue, Oct 12, 1:05 PM
martinvonz added a comment to D11624: dirstate-v2: Change the representation of negative directory mtime.

Resubmitted as D11629 because phabsend errors with abort: Conduit Error (ERR-CONDUIT-CORE): Graph cycle detected when swapping the order of two existing patches.

Tue, Oct 12, 11:54 AM

Mon, Oct 11

martinvonz created D11628: dispatch: use detailed exit code 250 for keyboard interrupt.
Mon, Oct 11, 7:31 PM
martinvonz created D11627: dispatch: ignore failure to flush ui.
Mon, Oct 11, 7:31 PM
martinvonz created D11626: dispatch: don't change error status if flushing stdio fails.
Mon, Oct 11, 7:30 PM
D10912: rhg: add ui.plain() and check it before showing relative paths in status is now accepted and ready to land.
Mon, Oct 11, 1:55 PM
D11614: rhg: add relative paths support in `rhg status` is now accepted and ready to land.
Mon, Oct 11, 1:54 PM