Page MenuHomePhabricator

martinvonz (Martin von Zweigbergk)
User

Projects

User Details

User Since
Jun 28 2017, 5:28 PM (178 w, 6 d)

Recent Activity

Yesterday

martinvonz closed D9470: tests: set old git default branch name for compatibility.
Tue, Dec 1, 11:41 PM
martinvonz committed rHG9dd5b129ff28: tests: set old git default branch name for compatibility.
tests: set old git default branch name for compatibility
Tue, Dec 1, 11:41 PM
martinvonz created D9472: testing phabricator encoding.
Tue, Dec 1, 2:34 AM
martinvonz added inline comments to D9471: procutil: use rapply(tonativestr, ...) to preserve lists when they come in.
Tue, Dec 1, 1:34 AM

Mon, Nov 30

martinvonz added a comment to D9470: tests: set old git default branch name for compatibility.

It still fails like this for me:

Mon, Nov 30, 1:06 PM
martinvonz created D9470: tests: set old git default branch name for compatibility.
Mon, Nov 30, 1:05 PM
martinvonz added a comment to D9403: git: update test for hg and git output changes.

Clearly nobody is running this in their CI. :(

Mon, Nov 30, 12:41 PM
martinvonz added inline comments to D9398: requirements: move loading to hg-core and add parsing.
Mon, Nov 30, 12:28 PM

Wed, Nov 25

martinvonz added a comment to D9387: errors: raise ConfigError on early parse error in dispatch.

If this is purely from --config instead of a file and you're collecting metrics, would you want this to be an InputError? (I'm happy to queue this as-is, I just wanted to double check)

Wed, Nov 25, 8:54 PM
martinvonz closed D9388: errors: raise InputError on bad top-level flags.
Wed, Nov 25, 5:06 PM
martinvonz committed rHGac565222b9f8: errors: raise InputError on bad top-level flags.
errors: raise InputError on bad top-level flags
Wed, Nov 25, 5:05 PM
martinvonz closed D9392: errors: raise StateError when there are unresolves merge conflicts.
Wed, Nov 25, 4:58 PM
martinvonz closed D9390: errors: introduce SecurityError and use it in a few places.
Wed, Nov 25, 4:58 PM
martinvonz closed D9393: errors: raise StateError on uncommitted changes when merge starts.
Wed, Nov 25, 4:58 PM
martinvonz committed rHG721f765a34ac: errors: raise StateError on uncommitted changes when merge starts.
errors: raise StateError on uncommitted changes when merge starts
Wed, Nov 25, 4:58 PM
martinvonz closed D9389: errors: raise InputError when too few arguments given to alias.
Wed, Nov 25, 4:58 PM
martinvonz committed rHGfa87536d3d70: errors: raise StateError when there are unresolves merge conflicts.
errors: raise StateError when there are unresolves merge conflicts
Wed, Nov 25, 4:58 PM
martinvonz committed rHG8f50dc096cf4: errors: introduce SecurityError and use it in a few places.
errors: introduce SecurityError and use it in a few places
Wed, Nov 25, 4:58 PM
martinvonz committed rHGbe25b66f86ab: errors: raise InputError when too few arguments given to alias.
errors: raise InputError when too few arguments given to alias
Wed, Nov 25, 4:57 PM
martinvonz closed D9378: errors: remove trailing "!" from some error messages for consistency.
Wed, Nov 25, 1:48 AM
martinvonz closed D9380: errors: remove trailing "!" in messages about creating new heads on push.
Wed, Nov 25, 1:40 AM
martinvonz closed D9385: errors: raise InputError on bad bookmark argument.
Wed, Nov 25, 1:39 AM
martinvonz committed rHG9acbe30953e8: errors: raise InputError on bad bookmark argument.
errors: raise InputError on bad bookmark argument
Wed, Nov 25, 1:39 AM
martinvonz closed D9383: errors: raise InputError on bad repo arguments.
Wed, Nov 25, 1:39 AM
martinvonz committed rHG35ab6e39f482: errors: raise ConfigError on bad alias definition.
errors: raise ConfigError on bad alias definition
Wed, Nov 25, 1:39 AM
martinvonz closed D9384: errors: raise ConfigError on bad alias definition.
Wed, Nov 25, 1:39 AM
martinvonz committed rHG8939062597f0: errors: raise InputError on bad repo arguments.
errors: raise InputError on bad repo arguments
Wed, Nov 25, 1:38 AM
martinvonz closed D9379: errors: consistently don't use trailing "!" in "not found in manifest" message.
Wed, Nov 25, 1:38 AM
martinvonz committed rHGf0626acf007d: errors: drop trailing "!" for some errors about bookmarks.
errors: drop trailing "!" for some errors about bookmarks
Wed, Nov 25, 1:38 AM
martinvonz closed D9382: errors: drop trailing "!" for some errors about bookmarks.
Wed, Nov 25, 1:38 AM
martinvonz committed rHGca39c45014fa: errors: remove trailing "!" in messages about bad top-level args.
errors: remove trailing "!" in messages about bad top-level args
Wed, Nov 25, 1:37 AM
martinvonz closed D9381: errors: remove trailing "!" in messages about bad top-level args.
Wed, Nov 25, 1:37 AM
martinvonz committed rHG122f0b59f5f0: errors: remove trailing "!" in messages about creating new heads on push.
errors: remove trailing "!" in messages about creating new heads on push
Wed, Nov 25, 1:37 AM
martinvonz committed rHG50afeeeb7b79: errors: consistently don't use trailing "!" in "not found in manifest" message.
errors: consistently don't use trailing "!" in "not found in manifest" message
Wed, Nov 25, 1:36 AM
martinvonz committed rHG95c4cca641f6: errors: remove trailing "!" from some error messages for consistency.
errors: remove trailing "!" from some error messages for consistency
Wed, Nov 25, 1:36 AM

Tue, Nov 24

martinvonz closed D9377: tests: make test-worker.t pass on py2.
Tue, Nov 24, 4:39 PM
martinvonz closed D9376: tests: update test-https.t's #no-defaultcacertsloaded block with new exit code.
Tue, Nov 24, 4:39 PM
martinvonz committed rHG64faa55716f4: tests: make test-worker.t pass on py2.
tests: make test-worker.t pass on py2
Tue, Nov 24, 4:38 PM
martinvonz committed rHG6da22a068281: tests: update test-https.t's #no-defaultcacertsloaded block with new exit code.
tests: update test-https.t's #no-defaultcacertsloaded block with new exit code
Tue, Nov 24, 4:38 PM
martinvonz created D9391: errors: raise InputError when push fails because it creates new heads.
Tue, Nov 24, 1:09 PM
martinvonz created D9392: errors: raise StateError when there are unresolves merge conflicts.
Tue, Nov 24, 1:07 PM
martinvonz created D9393: errors: raise StateError on uncommitted changes when merge starts.
Tue, Nov 24, 1:07 PM
martinvonz created D9390: errors: introduce SecurityError and use it in a few places.
Tue, Nov 24, 1:07 PM
martinvonz created D9389: errors: raise InputError when too few arguments given to alias.
Tue, Nov 24, 1:07 PM
martinvonz created D9388: errors: raise InputError on bad top-level flags.
Tue, Nov 24, 1:07 PM
martinvonz created D9387: errors: raise ConfigError on early parse error in dispatch.
Tue, Nov 24, 1:06 PM
martinvonz created D9386: errors: raise more specifc errors from narrowcommands.
Tue, Nov 24, 1:06 PM
martinvonz created D9383: errors: raise InputError on bad repo arguments.
Tue, Nov 24, 1:06 PM
martinvonz created D9385: errors: raise InputError on bad bookmark argument.
Tue, Nov 24, 1:06 PM
martinvonz created D9384: errors: raise ConfigError on bad alias definition.
Tue, Nov 24, 1:06 PM

Mon, Nov 23

martinvonz added a comment to D9341: log: add bookmark option to "hg log".

Do test-lfs-serve.t and test-transaction-rollback-on-sigpipe.t consistently fail with this patch? If they do, you should fix them :) If they don't (i.e. it was some flakiness you were experiencing), just don't mention that in the commit message and instead ask on #mercurial or send an email to mercurial-devel to see if others have seen the flakiness and ask how to fix it.

I think that the problem is that the 2 failing tests of Mercurial are not portable on FreeBSD 12.2.

Mon, Nov 23, 7:24 PM
D9341: log: add bookmark option to "hg log" is now accepted and ready to land.

The test failure has a diff. I still think that's just noise that will confuse much more than it helps. Okay if I drop the test plan from the commit message in flight?

Sure. In my opinion, the test plan is not part of my commit message.
I am currently running the tests in a VM-BHYVE running Debian Linux 10. I except all tests to pass.
I will keep you posted.

Mon, Nov 23, 6:47 PM
martinvonz created D9378: errors: remove trailing "!" from some error messages for consistency.
Mon, Nov 23, 6:41 PM
martinvonz created D9380: errors: remove trailing "!" in messages about creating new heads on push.
Mon, Nov 23, 6:34 PM
martinvonz created D9379: errors: consistently don't use trailing "!" in "not found in manifest" message.
Mon, Nov 23, 6:32 PM
martinvonz created D9382: errors: drop trailing "!" for some errors about bookmarks.
Mon, Nov 23, 6:32 PM
martinvonz created D9381: errors: remove trailing "!" in messages about bad top-level args.
Mon, Nov 23, 6:31 PM
martinvonz added a comment to D9341: log: add bookmark option to "hg log".

That's what I meant: you need to indent diffs that you include in the commit message, otherwise tools can't figure out where the commit message ends and the diff starts. But I still think you can just remove that whole thing from the commit message; it's implied that the test plan is to run the test suite, so you only need to describe your test plan if you did some other testing and/or did not run the test suite.

I did not include any diff in my commit message, as far as I know.
Given what you recommended, I added the prefix OUTPUT: in my test results in my test plan.

Mon, Nov 23, 6:16 PM
martinvonz created D9377: tests: make test-worker.t pass on py2.
Mon, Nov 23, 3:18 PM
martinvonz created D9376: tests: update test-https.t's #no-defaultcacertsloaded block with new exit code.
Mon, Nov 23, 3:18 PM
martinvonz added a comment to D9341: log: add bookmark option to "hg log".

Also, including diff output (such as from failing tests) without indentation makes the patch fail to apply:
unable to find 'tank/home/sebhtml/projects/mercurial/sebhtml-hg-log-bookmark/hg-committed/tests/test-lfs-serve.t' for patching

I think that the problem is that "hg phabimport" is fetching what I wrote in the test plan. I did not commit anything to tests/test-lfs-serve.t
This is weird.

Mon, Nov 23, 12:44 PM
martinvonz added a comment to D9341: log: add bookmark option to "hg log".

Do test-lfs-serve.t and test-transaction-rollback-on-sigpipe.t consistently fail with this patch? If they do, you should fix them :) If they don't (i.e. it was some flakiness you were experiencing), just don't mention that in the commit message and instead ask on #mercurial or send an email to mercurial-devel to see if others have seen the flakiness and ask how to fix it.

Mon, Nov 23, 12:07 PM
martinvonz added a comment to D9341: log: add bookmark option to "hg log".

Do test-lfs-serve.t and test-transaction-rollback-on-sigpipe.t consistently fail with this patch? If they do, you should fix them :) If they don't (i.e. it was some flakiness you were experiencing), just don't mention that in the commit message and instead ask on #mercurial or send an email to mercurial-devel to see if others have seen the flakiness and ask how to fix it.

Mon, Nov 23, 12:00 PM

Sat, Nov 21

martinvonz closed D9332: errors: use exit code 10 for parse errors.
Sat, Nov 21, 3:18 PM
martinvonz closed D9355: errors: raise ConfigError on failure to parse config file.
Sat, Nov 21, 3:16 PM
martinvonz committed rHGfc4fb2f17dd4: errors: use exit code 10 for parse errors.
errors: use exit code 10 for parse errors
Sat, Nov 21, 3:13 PM
martinvonz committed rHG9dc1351d0b5f: errors: raise ConfigError on failure to parse config file.
errors: raise ConfigError on failure to parse config file
Sat, Nov 21, 3:13 PM
martinvonz closed D9325: histedit: don't crash if commit message is empty.
Sat, Nov 21, 3:26 AM
martinvonz committed rHGf4065c3f09b8: histedit: don't crash if commit message is empty.
histedit: don't crash if commit message is empty
Sat, Nov 21, 3:26 AM
martinvonz updated the summary of D9332: errors: use exit code 10 for parse errors.
Sat, Nov 21, 1:35 AM
martinvonz updated the summary of D9355: errors: raise ConfigError on failure to parse config file.
Sat, Nov 21, 1:35 AM
martinvonz added inline comments to D9355: errors: raise ConfigError on failure to parse config file.
Sat, Nov 21, 12:56 AM

Fri, Nov 20

martinvonz closed D9352: config: clean up message about ignored untrusted config.
Fri, Nov 20, 9:52 PM
martinvonz closed D9354: errors: remove ParseError.args.
Fri, Nov 20, 9:52 PM
martinvonz closed D9348: errors: format "abort: " text in a new Abort.format() method.
Fri, Nov 20, 9:52 PM
martinvonz committed rHGda178b816812: errors: remove ParseError.args.
errors: remove ParseError.args
Fri, Nov 20, 9:52 PM
martinvonz committed rHG68260c444fd3: errors: let ParseError use Abort.__bytes__.
errors: let ParseError use Abort.__bytes__
Fri, Nov 20, 9:52 PM
martinvonz closed D9353: errors: let ParseError use Abort.__bytes__.
Fri, Nov 20, 9:52 PM
martinvonz closed D9351: tests: use new ParseError.format() in test-trusted.py.
Fri, Nov 20, 9:52 PM
martinvonz committed rHGe5a0efd26f7a: config: clean up message about ignored untrusted config.
config: clean up message about ignored untrusted config
Fri, Nov 20, 9:52 PM
martinvonz committed rHGc9b14c56fc2b: tests: use new ParseError.format() in test-trusted.py.
tests: use new ParseError.format() in test-trusted.py
Fri, Nov 20, 9:52 PM
martinvonz closed D9350: errors: make ParseError a subtype of Abort.
Fri, Nov 20, 9:52 PM
martinvonz committed rHG7eb221b9af6c: errors: make ParseError a subtype of Abort.
errors: make ParseError a subtype of Abort
Fri, Nov 20, 9:51 PM
martinvonz closed D9347: errors: make formatparse() an instance method on ParseError.
Fri, Nov 20, 9:51 PM
martinvonz closed D9349: tests: make doctests not depend on str(ParseError()) format.
Fri, Nov 20, 9:51 PM
martinvonz committed rHG18489e26d9a0: tests: make doctests not depend on str(ParseError()) format.
tests: make doctests not depend on str(ParseError()) format
Fri, Nov 20, 9:51 PM
martinvonz closed D9345: errors: move similarity_hint() to error module.
Fri, Nov 20, 9:51 PM
martinvonz committed rHG600aec73f309: errors: format "abort: " text in a new Abort.format() method.
errors: format "abort: " text in a new Abort.format() method
Fri, Nov 20, 9:51 PM
martinvonz closed D9346: errors: create "similarity hint" for UnknownIdentifier eagerly in constructor.
Fri, Nov 20, 9:51 PM
martinvonz committed rHG98399dd1b96c: errors: make formatparse() an instance method on ParseError.
errors: make formatparse() an instance method on ParseError
Fri, Nov 20, 9:51 PM
martinvonz closed D9344: errors: morph reportsimilar() into similarity_hint().
Fri, Nov 20, 9:51 PM
martinvonz committed rHG1817b66897ad: errors: create "similarity hint" for UnknownIdentifier eagerly in constructor.
errors: create "similarity hint" for UnknownIdentifier eagerly in constructor
Fri, Nov 20, 9:51 PM
martinvonz closed D9343: errors: restructure formatparse() to clarify conditions a bit.
Fri, Nov 20, 9:51 PM
martinvonz committed rHG8cc9e7f762d6: errors: move similarity_hint() to error module.
errors: move similarity_hint() to error module
Fri, Nov 20, 9:51 PM
martinvonz committed rHGbb1b7a5bc96b: errors: morph reportsimilar() into similarity_hint().
errors: morph reportsimilar() into similarity_hint()
Fri, Nov 20, 9:50 PM
martinvonz committed rHG7a273336d3d3: errors: restructure formatparse() to clarify conditions a bit.
errors: restructure formatparse() to clarify conditions a bit
Fri, Nov 20, 9:50 PM
martinvonz updated the diff for D9332: errors: use exit code 10 for parse errors.
Fri, Nov 20, 7:30 PM
martinvonz added inline comments to D9332: errors: use exit code 10 for parse errors.
Fri, Nov 20, 7:29 PM
martinvonz created D9355: errors: raise ConfigError on failure to parse config file.
Fri, Nov 20, 7:29 PM
martinvonz created D9352: config: clean up message about ignored untrusted config.
Fri, Nov 20, 7:26 PM