- User Since
- Jun 28 2017, 5:28 PM (90 w, 5 d)
Sat, Mar 23
Fri, Mar 22
Thu, Mar 21
Wed, Mar 20
Josef 'Jeff' Sipek <firstname.lastname@example.org> sent this to mercurial-devel. I'm adding it here for reference.
When the test suite is run with --extra-config-opt to use the new copy
tracing, all tests pass, besides test-copies.t (which fails in the
same way as you can see in this patch).
Tue, Mar 19
Mon, Mar 18
Good point. Isn't there a debug command for rebuilding it? We can add a
hint about that.
Sat, Mar 16
Fri, Mar 15
Can you wrap the commit message to 80 columns? I didn't find anything on https://www.mercurial-scm.org/wiki/ContributingChanges about it, but that's how almost everyone else does it.
I understand that it's not at all clear if we want to make this change by default, but I'd appreciate if we can queue this patch as is so I and others can easily start testing it (it's pretty deep inside _performrevert(), so it's hard to do it cleanly in an extension). I don't believe I'm changing the behavior for anyone who has not set the new config.
Thu, Mar 14
Wed, Mar 13
Tue, Mar 12
Does hg unamend accept patterns as arguments?
Could you choose the "Abandon Revision" action on this patch so it's clear that it's not meant to be queued?
Can you update the commit message to explain how this works? I think I saw somewhere else that it first uncommits everything and then does an interactive amend. Is that correct?
Mon, Mar 11
Sorry, I forgot (again) to manually add the parent revision. That's done now.
Sorry, I was actually about to send a different patch for updating its documentation. I'll send it in a few minutes and you can let me know what you think.
unamend: made match optional in firdirstate()
Sun, Mar 10
Sat, Mar 9
Fri, Mar 8
Thu, Mar 7
Here are some little comments to start with. I haven't even started reviewing the three new functions, but I need to take a break and work on other things a bit now.
As I said a while ago on IRC, it feels like _fixdirstate() should not need an interactive flag, and it should not even need to be specifically for uncommit. It feels like it should work the same for any case where we move to a different commit without changing the working copy, such as uncommit, unamend, amend, fix (though we may want optimized code paths for some of them). So I took this patch and tried the most naive attempt at unifying the interactive version with the non-interactive version, namely to just drop the code for the interactive path (see patch below). Surprisingly, all tests pass :) So maybe you can just apply the below patch and clean it up (drop the if True), or maybe you need to add tests.