Page MenuHomePhabricator

martinvonz (Martin von Zweigbergk)
User

Projects

User Details

User Since
Jun 28 2017, 5:28 PM (255 w, 1 d)

Recent Activity

Yesterday

martinvonz added a comment to D12627: worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444).

I *think* you're supposed to open a "merge request" on https://foss.heptapod.net/mercurial/mercurial-devel these days. Right, @Alphare?

I didn't think we made the switch yet, but I'm fine doing that as a pilot. (I ended up amending a commit comment typo since the last push, so it will need to run CI again.)

Wed, May 18, 4:01 PM
martinvonz updated subscribers of D12627: worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444).

I *think* you're supposed to open a "merge request" on https://foss.heptapod.net/mercurial/mercurial-devel these days. Right, @Alphare?

Wed, May 18, 11:32 AM

Thu, May 12

martinvonz committed rHGc577d394ed6b: branching: merge with stable.
branching: merge with stable
Thu, May 12, 1:46 PM
martinvonz added a comment to D12625: amend: stop specifying matcher, get all copies in wctx.

Thanks for fixing! I'll apply this on stable.

Thu, May 12, 12:33 AM
martinvonz added a comment to D12624: amend: add test showing poor behavior when copies are involved.

For the record, this has been broken since 877d7e1

Thu, May 12, 12:11 AM

Mon, May 9

martinvonz updated the diff for D12424: rust: upgrade zstd from 0.5.3 to 0.11.1.
Mon, May 9, 3:13 PM
martinvonz updated the diff for D12494: [RFC] rust-revlog: create nodemap on the fly if it's not persisted.
Mon, May 9, 3:13 PM
martinvonz committed rHG90a15199cbc6: rust-repo: make `Send` by not storing functions in `LazyCell`.
rust-repo: make `Send` by not storing functions in `LazyCell`
Mon, May 9, 12:39 PM
martinvonz closed D12582: rust-repo: make `Send` by not storing functions in `LazyCell`.
Mon, May 9, 11:53 AM
martinvonz committed rHG5376efe0314a: rust-repo: make `Send` by not storing functions in `LazyCell`.
rust-repo: make `Send` by not storing functions in `LazyCell`
Mon, May 9, 11:53 AM
martinvonz closed D12588: filemerge: add configs to disable some or all partial merge tools.
Mon, May 9, 11:52 AM
martinvonz committed rHG7af798e497f5: filemerge: add configs to disable some or all partial merge tools.
filemerge: add configs to disable some or all partial merge tools
Mon, May 9, 11:52 AM
martinvonz added a comment to D12582: rust-repo: make `Send` by not storing functions in `LazyCell`.

Unfortunately, this does not apply anymore. Sorry for the delay in review, it's been really packed lately.

Mon, May 9, 11:42 AM
martinvonz updated the diff for D12424: rust: upgrade zstd from 0.5.3 to 0.11.1.
Mon, May 9, 11:42 AM
martinvonz updated the diff for D12582: rust-repo: make `Send` by not storing functions in `LazyCell`.
Mon, May 9, 11:42 AM

Thu, May 5

martinvonz added a comment to D12603: diff: graduate merge diffs from experimental and add to tweakdefaults.

I agree, except that I've seen it crash sometimes. I wrote a little script to find such cases now. Here's an example: hg diff --change 7c2921a6. So we need to fix that first. Sorry I never bothered to report a bug for it.

That doesn't crash for me! Even HGRCPATH=/dev/null hg diff --change 7c2921a6 --config diff.merge=1 works...can you try and figure out why you're seeing a crash?

Thu, May 5, 12:08 AM

Wed, May 4

D12603: diff: graduate merge diffs from experimental and add to tweakdefaults now requires changes to proceed.

I agree, except that I've seen it crash sometimes. I wrote a little script to find such cases now. Here's an example: hg diff --change 7c2921a6. So we need to fix that first. Sorry I never bothered to report a bug for it.

Wed, May 4, 12:37 PM

Tue, May 3

martinvonz updated the diff for D12582: rust-repo: make `Send` by not storing functions in `LazyCell`.
Tue, May 3, 11:55 AM
martinvonz updated the diff for D12582: rust-repo: make `Send` by not storing functions in `LazyCell`.
Tue, May 3, 2:06 AM

Wed, Apr 27

martinvonz committed rHGdb3f8e5cc965: commit: don't use hard-coded `.hg/last-message.txt` path in error message.
commit: don't use hard-coded `.hg/last-message.txt` path in error message
Wed, Apr 27, 9:50 AM

Tue, Apr 26

martinvonz created D12588: filemerge: add configs to disable some or all partial merge tools.
Tue, Apr 26, 12:13 PM

Mon, Apr 25

martinvonz closed D12585: commit: don't use hard-coded `.hg/last-message.txt` path in error message.
Mon, Apr 25, 4:12 PM
martinvonz committed rHG9b2fa18e0b28: commit: don't use hard-coded `.hg/last-message.txt` path in error message.
commit: don't use hard-coded `.hg/last-message.txt` path in error message
Mon, Apr 25, 4:12 PM
D12578: rhg: use `Command::exec` instead of `Command::status` is now accepted and ready to land.
Mon, Apr 25, 12:06 PM

Fri, Apr 22

martinvonz created D12585: commit: don't use hard-coded `.hg/last-message.txt` path in error message.
Fri, Apr 22, 7:51 PM
martinvonz added a comment to D12580: rust-dirstate-v2: save proper data size if no new data on append.

It looks like the tests from your other long series need to be updated in this patch (they don't compile with this patch applied).

You may have missed my first comment here then. This patch is destined for stable where it should apply cleanly, only the merge will need to be adapted .

Fri, Apr 22, 11:46 AM

Thu, Apr 21

D12580: rust-dirstate-v2: save proper data size if no new data on append now requires changes to proceed.

It looks like the tests from your other long series need to be updated in this patch (they don't compile with this patch applied).

Thu, Apr 21, 3:50 PM
D12578: rhg: use `Command::exec` instead of `Command::status` now requires changes to proceed.
Thu, Apr 21, 3:42 PM
martinvonz created D12582: rust-repo: make `Send` by not storing functions in `LazyCell`.
Thu, Apr 21, 2:12 PM

Apr 19 2022

martinvonz added a comment to D12541: rust-dirstatemap: remove unused helper from the old API.

It is, thank you!

Apr 19 2022, 5:47 PM
martinvonz closed D12548: changelog: avoid copying changeset data into `ChangesetRevisionData`.
Apr 19 2022, 5:42 PM
martinvonz closed D12486: rust-nodemap: remove unnecessary explicit lifetime.
Apr 19 2022, 5:42 PM
martinvonz committed rHG07ec9f4f24bf: changelog: avoid copying changeset data into `ChangesetRevisionData`.
changelog: avoid copying changeset data into `ChangesetRevisionData`
Apr 19 2022, 5:42 PM
martinvonz closed D12565: rust-revlog: add tests for p1/p2 getters, as promised in D12442.
Apr 19 2022, 5:42 PM
martinvonz committed rHGb97835b2e2d4: rust-nodemap: remove unnecessary explicit lifetime.
rust-nodemap: remove unnecessary explicit lifetime
Apr 19 2022, 5:42 PM
martinvonz closed D12564: rust-revlog: make `IndexEntryBuilder` build a whole entry.
Apr 19 2022, 5:42 PM
martinvonz closed D12547: rust-revlog: make unaware of `Repo`.
Apr 19 2022, 5:42 PM
martinvonz committed rHGa9ece9796a97: rust-revlog: add tests for p1/p2 getters, as promised in D12442.
rust-revlog: add tests for p1/p2 getters, as promised in D12442
Apr 19 2022, 5:42 PM
martinvonz committed rHG2a9a55ffe24f: rust-revlog: make `IndexEntryBuilder` build a whole entry.
rust-revlog: make `IndexEntryBuilder` build a whole entry
Apr 19 2022, 5:42 PM
martinvonz closed D12563: rust-revlog: change default version from 2 to 1 in test builder.
Apr 19 2022, 5:42 PM
martinvonz closed D12546: rust-revlog: move check for nodemap requirement to caller.
Apr 19 2022, 5:42 PM
martinvonz committed rHGd200ecb76c72: rust-revlog: change default version from 2 to 1 in test builder.
rust-revlog: change default version from 2 to 1 in test builder
Apr 19 2022, 5:42 PM
martinvonz closed D12561: rust-revlog: make `Changelog` and `ManifestLog` unaware of `Repo`.
Apr 19 2022, 5:42 PM
martinvonz committed rHG9b5334c1e499: rust-repo: extract a function for checking nodemap requirement.
rust-repo: extract a function for checking nodemap requirement
Apr 19 2022, 5:42 PM
martinvonz closed D12562: rust-repo: extract a function for checking nodemap requirement.
Apr 19 2022, 5:42 PM
martinvonz committed rHG399439c12223: rust-revlog: make unaware of `Repo`.
rust-revlog: make unaware of `Repo`
Apr 19 2022, 5:42 PM
martinvonz committed rHGa5ef50becea8: rust-revlog: make `Changelog` and `ManifestLog` unaware of `Repo`.
rust-revlog: make `Changelog` and `ManifestLog` unaware of `Repo`
Apr 19 2022, 5:42 PM
martinvonz closed D12558: rust-filelog: don't use persistent nodemap (to match Python).
Apr 19 2022, 5:42 PM
martinvonz closed D12545: rust-nodemap-docket: make unaware of `Repo`.
Apr 19 2022, 5:42 PM
martinvonz committed rHGb5e226015a14: rust-filelog: don't use persistent nodemap (to match Python).
rust-filelog: don't use persistent nodemap (to match Python)
Apr 19 2022, 5:42 PM
martinvonz committed rHGbfc117647c71: rust-revlog: move check for nodemap requirement to caller.
rust-revlog: move check for nodemap requirement to caller
Apr 19 2022, 5:42 PM
martinvonz committed rHG704e993e8ee9: rust-nodemap-docket: make unaware of `Repo`.
rust-nodemap-docket: make unaware of `Repo`
Apr 19 2022, 5:42 PM
martinvonz closed D12544: rust-nodemap-docket: move check of nodemap requirement to caller.
Apr 19 2022, 5:42 PM
martinvonz committed rHG07d8d144c222: rust-nodemap-docket: move check of nodemap requirement to caller.
rust-nodemap-docket: move check of nodemap requirement to caller
Apr 19 2022, 5:42 PM
martinvonz added a comment to D12541: rust-dirstatemap: remove unused helper from the old API.

Is this series ready to be queued now?

Apr 19 2022, 12:47 PM
martinvonz committed rHG3cd57e2be49b: absorb: make `--edit-lines` imply `--apply-changes`.
absorb: make `--edit-lines` imply `--apply-changes`
Apr 19 2022, 10:48 AM
martinvonz added a comment to D12548: changelog: avoid copying changeset data into `ChangesetRevisionData`.

The stack needs rebase apparently

Apr 19 2022, 9:27 AM
martinvonz closed D12573: amend: don't remove unselected removals from memctx.
Apr 19 2022, 5:19 AM
martinvonz closed D12572: tests: demonstrate crash on partial amend with copies in changesets.
Apr 19 2022, 5:19 AM
martinvonz committed rHG770e1352e9f9: amend: don't remove unselected removals from memctx.
amend: don't remove unselected removals from memctx
Apr 19 2022, 5:19 AM
martinvonz committed rHG65eda809b943: tests: demonstrate crash on partial amend with copies in changesets.
tests: demonstrate crash on partial amend with copies in changesets
Apr 19 2022, 5:19 AM
martinvonz closed D12550: absorb: make `--edit-lines` imply `--apply-changes`.
Apr 19 2022, 5:19 AM
martinvonz committed rHG0effaf9d96c1: absorb: make `--edit-lines` imply `--apply-changes`.
absorb: make `--edit-lines` imply `--apply-changes`
Apr 19 2022, 5:19 AM
martinvonz created D12573: amend: don't remove unselected removals from memctx.
Apr 19 2022, 12:27 AM
martinvonz created D12572: tests: demonstrate crash on partial amend with copies in changesets.
Apr 19 2022, 12:27 AM

Apr 16 2022

martinvonz updated the diff for D12424: rust: upgrade zstd from 0.5.3 to 0.11.1.
Apr 16 2022, 1:47 AM
martinvonz updated the diff for D12494: [RFC] rust-revlog: create nodemap on the fly if it's not persisted.
Apr 16 2022, 1:47 AM
martinvonz created D12564: rust-revlog: make `IndexEntryBuilder` build a whole entry.
Apr 16 2022, 1:47 AM
martinvonz created D12565: rust-revlog: add tests for p1/p2 getters, as promised in D12442.
Apr 16 2022, 1:47 AM
martinvonz created D12563: rust-revlog: change default version from 2 to 1 in test builder.
Apr 16 2022, 1:47 AM

Apr 15 2022

martinvonz retitled D12562: rust-repo: extract a function for checking nodemap requirement from repo: extract a function for checking nodemap requirement to rust-repo: extract a function for checking nodemap requirement.
Apr 15 2022, 8:09 PM
martinvonz added inline comments to D12562: rust-repo: extract a function for checking nodemap requirement.
Apr 15 2022, 12:58 PM
martinvonz added a comment to D12546: rust-revlog: move check for nodemap requirement to caller.
  • I was thinking of moving the conditions further up the stack, to the repo level. If we do that, then the repo might be a natural place to extract a function. Or maybe I'll put it in nodemap.rs as you said. I'll update this patch a bit later.

Either seem fine to me.

Apr 15 2022, 12:53 PM
martinvonz created D12561: rust-revlog: make `Changelog` and `ManifestLog` unaware of `Repo`.
Apr 15 2022, 12:53 PM
martinvonz updated the diff for D12548: changelog: avoid copying changeset data into `ChangesetRevisionData`.
Apr 15 2022, 12:53 PM
martinvonz created D12562: rust-repo: extract a function for checking nodemap requirement.
Apr 15 2022, 12:53 PM
martinvonz updated the diff for D12545: rust-nodemap-docket: make unaware of `Repo`.
Apr 15 2022, 12:53 PM
martinvonz updated the diff for D12544: rust-nodemap-docket: move check of nodemap requirement to caller.
Apr 15 2022, 12:52 PM

Apr 14 2022

martinvonz updated the diff for D12547: rust-revlog: make unaware of `Repo`.
Apr 14 2022, 12:13 PM
martinvonz updated the diff for D12546: rust-revlog: move check for nodemap requirement to caller.
Apr 14 2022, 12:13 PM
martinvonz updated the diff for D12548: changelog: avoid copying changeset data into `ChangesetRevisionData`.
Apr 14 2022, 12:13 PM
martinvonz created D12558: rust-filelog: don't use persistent nodemap (to match Python).
Apr 14 2022, 12:13 PM
martinvonz added a comment to D12546: rust-revlog: move check for nodemap requirement to caller.

While I think you're right about separating the revlogs from the repo, the repeated logic should probably be factored into a function somewhere. Why not in nodemap.rs?

Apr 14 2022, 12:10 PM

Apr 13 2022

martinvonz created D12550: absorb: make `--edit-lines` imply `--apply-changes`.
Apr 13 2022, 11:11 AM
martinvonz added a comment to D12442: rust-revlog: add methods for getting parent revs and entries.

That's actually related to another series I had not sent yet, which is about removing the &Repo input to Revlog::open(). It would be much easier to write tests if we didn't have to create a Repo instance.

I see no issue for doing this, it's probably a good idea.

I've inserted those patches in this series.

Apr 13 2022, 9:24 AM
martinvonz updated the diff for D12548: changelog: avoid copying changeset data into `ChangesetRevisionData`.
Apr 13 2022, 9:23 AM
martinvonz added a comment to D12442: rust-revlog: add methods for getting parent revs and entries.

That's actually related to another series I had not sent yet, which is about removing the &Repo input to Revlog::open(). It would be much easier to write tests if we didn't have to create a Repo instance.

I see no issue for doing this, it's probably a good idea.

Apr 13 2022, 9:19 AM
martinvonz created D12548: changelog: avoid copying changeset data into `ChangesetRevisionData`.
Apr 13 2022, 9:11 AM
martinvonz created D12547: rust-revlog: make unaware of `Repo`.
Apr 13 2022, 9:11 AM
martinvonz created D12546: rust-revlog: move check for nodemap requirement to caller.
Apr 13 2022, 9:11 AM
martinvonz updated the diff for D12494: [RFC] rust-revlog: create nodemap on the fly if it's not persisted.
Apr 13 2022, 9:11 AM
martinvonz updated the diff for D12424: rust: upgrade zstd from 0.5.3 to 0.11.1.
Apr 13 2022, 9:11 AM
martinvonz updated the diff for D12442: rust-revlog: add methods for getting parent revs and entries.
Apr 13 2022, 9:11 AM
martinvonz created D12544: rust-nodemap-docket: move check of nodemap requirement to caller.
Apr 13 2022, 9:10 AM
martinvonz created D12545: rust-nodemap-docket: make unaware of `Repo`.
Apr 13 2022, 9:10 AM
martinvonz updated the diff for D12439: rust-changelog: start parsing changeset data.
Apr 13 2022, 9:10 AM
martinvonz updated the diff for D12438: rust-changelog: remove special parsing of empty changelog data for null rev.
Apr 13 2022, 9:10 AM
martinvonz updated the diff for D12426: rust-changelog: don't skip empty lines when iterating over changeset lines.
Apr 13 2022, 9:10 AM
martinvonz updated the diff for D12425: rust-requirements: allow loading repos with `bookmarksinstore` requirement.
Apr 13 2022, 9:10 AM
martinvonz closed D12442: rust-revlog: add methods for getting parent revs and entries.
Apr 13 2022, 5:18 AM