Page MenuHomePhabricator

martinvonz (Martin von Zweigbergk)
User

Projects

User Details

User Since
Jun 28 2017, 5:28 PM (128 w, 1 d)

Recent Activity

Today

martinvonz added inline comments to D7633: clone: extract helper for checking mutually exclusive args.
Fri, Dec 13, 3:24 AM
martinvonz added a comment to D7627: config: drop debug messages saying where config was read from.

On Windows, you can set a registry key to one or more *.ini files or directories that get read in, so it seems slightly handy to know the order in which files are processed. I know I've used that mechanism on various systems to find directories in which to stash things too.
That said, I don't think I feel strongly about keeping it if it makes the next patch messy. (I did a quick skim of it, but didn't see why that would be.)

It means that every line in merge-tools.rc would get two lines in this output (one line saying "set value from ..." or something like that).

Fri, Dec 13, 3:02 AM
martinvonz added inline comments to D7622: help: get helptext/ data from `resources` module if available.
Fri, Dec 13, 3:01 AM
martinvonz updated the diff for D7629: config: read defaultrc/ using `resources` module if available.
Fri, Dec 13, 3:01 AM
martinvonz updated the diff for D7622: help: get helptext/ data from `resources` module if available.
Fri, Dec 13, 3:01 AM
martinvonz created D7648: bookmarks: use cmdutil.check_unique_argument() for action+rev.
Fri, Dec 13, 2:57 AM
martinvonz created D7647: bookmarks: use cmdutil.check_unique_argument() for action.
Fri, Dec 13, 2:57 AM
martinvonz created D7646: rebase: inline single-use variables passed to _definedestmap().
Fri, Dec 13, 2:56 AM
martinvonz created D7645: rebase: use cmdutil.check_unique_argument() for action+revision.
Fri, Dec 13, 2:56 AM
martinvonz created D7644: rebase: use cmdutil.check_unique_argument() for --auto-orphans.
Fri, Dec 13, 2:56 AM
martinvonz created D7643: rebase: use cmdutil.check_unique_argument() for -b/-s/-r.
Fri, Dec 13, 2:56 AM
martinvonz created D7640: rebase: use cmdutil.check_unique_argument() for action.
Fri, Dec 13, 2:56 AM
martinvonz created D7641: rebase: use cmdutil.check_unique_argument() for --confirm/--dry-run.
Fri, Dec 13, 2:55 AM
martinvonz created D7642: rebase: inline single-use `dryrun` and `confirm` variables.
Fri, Dec 13, 2:55 AM
martinvonz created D7636: export: use cmdutil.check_unique_argument().
Fri, Dec 13, 2:55 AM
martinvonz created D7633: clone: extract helper for checking mutually exclusive args.
Fri, Dec 13, 2:55 AM
martinvonz created D7639: releasenotes: use cmdutil.check_unique_argument().
Fri, Dec 13, 2:55 AM
martinvonz created D7638: fix: use cmdutil.check_unique_argument().
Fri, Dec 13, 2:54 AM
martinvonz created D7637: pathbomb: use cmdutil.check_unique_argument().
Fri, Dec 13, 2:54 AM
martinvonz created D7634: commit: use cmdutil.check_unique_argument().
Fri, Dec 13, 2:54 AM
martinvonz created D7632: graft: reuse cmdutl.resolvecommitoptions().
Fri, Dec 13, 2:54 AM
martinvonz created D7635: amend: use cmdutil.check_unique_argument().
Fri, Dec 13, 2:54 AM
martinvonz added a comment to D7630: RFC: absorb: make the absorbed changeset be automatically "evolved".

(on mobile) I think it was hg phabsend -r .+.^

Fri, Dec 13, 1:57 AM
martinvonz added inline comments to D7630: RFC: absorb: make the absorbed changeset be automatically "evolved".
Fri, Dec 13, 1:47 AM
martinvonz added inline comments to D7630: RFC: absorb: make the absorbed changeset be automatically "evolved".
Fri, Dec 13, 1:11 AM
martinvonz added a comment to D7627: config: drop debug messages saying where config was read from.

On Windows, you can set a registry key to one or more *.ini files or directories that get read in, so it seems slightly handy to know the order in which files are processed. I know I've used that mechanism on various systems to find directories in which to stash things too.
That said, I don't think I feel strongly about keeping it if it makes the next patch messy. (I did a quick skim of it, but didn't see why that would be.)

Fri, Dec 13, 12:28 AM

Yesterday

martinvonz added a reviewer for D7629: config: read defaultrc/ using `resources` module if available: indygreg.
Thu, Dec 12, 6:46 PM
martinvonz added a reviewer for D7622: help: get helptext/ data from `resources` module if available: indygreg.
Thu, Dec 12, 6:46 PM
martinvonz updated the summary of D7622: help: get helptext/ data from `resources` module if available.
Thu, Dec 12, 6:46 PM
martinvonz created D7627: config: drop debug messages saying where config was read from.
Thu, Dec 12, 6:45 PM
martinvonz created D7625: config: catch intended exception when failing to parse config.
Thu, Dec 12, 6:44 PM
martinvonz created D7626: config: close file even if we fail to read it.
Thu, Dec 12, 6:44 PM
martinvonz created D7629: config: read defaultrc/ using `resources` module if available.
Thu, Dec 12, 6:44 PM
martinvonz created D7628: config: move reading of defaultrc/ files from ui to rcutil.
Thu, Dec 12, 6:44 PM
martinvonz created D7622: help: get helptext/ data from `resources` module if available.
Thu, Dec 12, 6:44 PM
martinvonz created D7624: rcutil: don't check if defaultrc/ is a directory -- we know it is.
Thu, Dec 12, 6:44 PM
martinvonz created D7623: tests: make test-config-env.py a little less hacky.
Thu, Dec 12, 6:44 PM
martinvonz created D7621: pycompat: allow pycompat.sysbytes() even if input already is bytes.
Thu, Dec 12, 6:44 PM
martinvonz added a comment to D7603: cext-revlog: fixed __delitem__ for uninitialized nodetree.

Here's a quickfix that works for me for both pure and C

-- a/tests/test-parseindex2.py Thu Dec 05 20:41:23 2019 +0100
+++ b/tests/test-parseindex2.py Thu Dec 12 18:34:28 2019 +0100
@@ -18,6 +18,7 @@
     node as nodemod,
     policy,
     pycompat,
+    util,
 )
 parsers = policy.importmod('parsers')
@@ -267,11 +268,12 @@
         appendrev(6)
         self.assertEqual(len(index), 7)
-        del index[1:7]
+        del index[1:-1]
         # assertions that failed before correction
         self.assertEqual(len(index), 1)  # was 4
-        self.assertEqual(index.headrevs(), [0])  # gave ValueError
+        if util.safehasattr(index, 'headrevs'):  # not implemented in pure
+            self.assertEqual(index.headrevs(), [0])  # gave ValueError

Explanation: the C version would allow either -1 or actual length, the pure version just allows -1. The pure version does not have algorithms such as headrevs, they are implemented in revlog.py
I can redo that cleanly, just tell me the expected way.

Thu, Dec 12, 1:14 PM
martinvonz added a comment to D7595: status: outputting structured unfinished-operation information.

Applying this on top of D7605 failed. So unfortunately you have to rebase again and resend. Also, I think you are pip install black away from preventing such conflicts.

Thu, Dec 12, 12:33 PM
martinvonz added a comment to D7603: cext-revlog: fixed __delitem__ for uninitialized nodetree.

This broke ./run-tests.py --pure test-parseindex2.py

Thu, Dec 12, 11:49 AM
martinvonz added a comment to D7118: rust-dirstatemap: remove additional lookups in traverse.

What's the state of this patch? The description makes it sound like it's a Rust patch, but it only modifies Python code.

It only impacts the rust module policy, I figured the name was not a bad idea. Maybe I'm wrong?
I also did not find Yuya's suggestion to work, but I may have understood it wrong.

Thu, Dec 12, 11:46 AM
martinvonz added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.

I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path).

I *think* they're addressed, but we there's no rush to get this in so let's give Yuya a chance to comment, because I'm not sure if the issue with subrepos is an existing or new issue.

Thu, Dec 12, 11:37 AM
martinvonz added a comment to D7492: localrepo: also fastpath access to working copy parents when possible.

Hmm, I thought this entire series had been queued. I'd like to queue it. Can you include perf numbers?

Now that we have a reference filtered repository, I am planning to use the benchmark suite to gather timing (probably next week). We already track status and diff. addign hg export is easy. However I am not sure what's your criteria for annotate ? Can you clarify them and offer a file to test for each for the reference repositories ?

Thu, Dec 12, 9:31 AM
martinvonz added a comment to D7522: rust-dirs: handle forgotten `Result`s.

@martinvonz I was scratching my head trying to find this changeset to update/rebase it, here's hg obslog -r 5a1ff3d75f35 --hidden:

x  5a1ff3d75f35 (46379) rust-dirs: handle forgotten `Result`s
|    rewritten as 80c3e3d4ddea by Martin von Zweigbergk <martinvonz@google.com> (Wed Dec 11 10:51:38 2019 -0800)
|
x  2c62ed1a015a (46378) rust-dirs: handle forgotten `Result`s
     rewritten(description) as 5a1ff3d75f35 using phabsend by Raphaël Gomès <rgomes@octobus.net> (Wed Nov 27 14:30:10 2019 +0100)

I don't have 80c3e3d4ddea in my local repository. I could just revive 2c62ed1a015a and edit from here, but I'm worried that might complicate things further.

Thu, Dec 12, 9:25 AM
martinvonz closed D7605: formatting: fix some recent formatting regressions.
Thu, Dec 12, 7:52 AM
martinvonz committed rHG612951e08278: formatting: fix some recent formatting regressions.
formatting: fix some recent formatting regressions
Thu, Dec 12, 7:52 AM

Wed, Dec 11

martinvonz added inline comments to D7522: rust-dirs: handle forgotten `Result`s.
Wed, Dec 11, 1:57 PM
martinvonz added inline comments to D7604: rust-hg-path: implement more readable custom Debug for HgPath{,Buf}.
Wed, Dec 11, 1:05 PM
martinvonz updated the diff for D7604: rust-hg-path: implement more readable custom Debug for HgPath{,Buf}.
Wed, Dec 11, 1:05 PM
martinvonz created D7605: formatting: fix some recent formatting regressions.
Wed, Dec 11, 1:02 PM
martinvonz created D7604: rust-hg-path: implement more readable custom Debug for HgPath{,Buf}.
Wed, Dec 11, 12:51 PM
martinvonz added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.

I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path).

Wed, Dec 11, 12:50 PM
martinvonz added a comment to D7529: rust-dirstate-status: add `walk_explicit` implementation, use `Matcher` trait.

This no longer applies cleanly (and doesn't build when applied with fuzz)

Wed, Dec 11, 12:25 PM
martinvonz added inline comments to D7594: status: add template/json data about whether a file has unresolved conflicts.
Wed, Dec 11, 12:02 PM
martinvonz closed D7597: dirs: fix out-of-bounds access in Py3.
Wed, Dec 11, 6:54 AM
martinvonz committed rHGa47ccdcce4f9: dirs: fix out-of-bounds access in Py3.
dirs: fix out-of-bounds access in Py3
Wed, Dec 11, 6:54 AM
martinvonz added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#111295, @yuja wrote:
if listsubrepos:
    for subpath in ctx.substate:
  • sm = ctx.sub(subpath).matchfileset(pat, badfn=badfn)

+ sm = ctx.sub(subpath).matchfileset(
+ pat, badfn=badfn, cwd=cwd
+ )

Might have to adjust cwd since it may be relative to the parent's repo.root.

Wed, Dec 11, 1:46 AM
martinvonz updated the diff for D7570: match: resolve filesets against the passed `cwd`, not the current one.
Wed, Dec 11, 1:38 AM
martinvonz updated subscribers of D7570: match: resolve filesets against the passed `cwd`, not the current one.
Wed, Dec 11, 12:24 AM

Tue, Dec 10

martinvonz updated the summary of D7597: dirs: fix out-of-bounds access in Py3.
Tue, Dec 10, 6:11 PM
martinvonz created D7597: dirs: fix out-of-bounds access in Py3.
Tue, Dec 10, 5:44 PM
martinvonz added inline comments to D7528: rust-matchers: add `FileMatcher` implementation.
Tue, Dec 10, 4:34 PM
martinvonz added a comment to D7531: rust-matchers: add support for `exactmatcher` in `dirstate.status`.

Did you mean s/explicitmatcher/exactmatcher/ in the description? Also, I thought you called it FileMatcher instead. What's the difference?

Tue, Dec 10, 2:15 PM
martinvonz added a comment to D7118: rust-dirstatemap: remove additional lookups in traverse.

What's the state of this patch? The description makes it sound like it's a Rust patch, but it only modifies Python code.

Tue, Dec 10, 1:30 PM
martinvonz added a comment to D7593: status: split morestatus data loading from display.

I pushed @martinvonz D7591, so these need to be rebased. Thanks!

Are you asking me to do something, or are you going to?
This supersedes his change completely.

Tue, Dec 10, 1:17 PM
martinvonz added inline comments to D7526: rust-hg-path: add method to get part of a path relative to a prefix.
Tue, Dec 10, 1:04 PM
martinvonz closed D7591: status: remove pointless filtering by alwaysmatcher in morestatus.
Tue, Dec 10, 10:45 AM
martinvonz committed rHG072b745936f1: status: remove pointless filtering by alwaysmatcher in morestatus.
status: remove pointless filtering by alwaysmatcher in morestatus
Tue, Dec 10, 10:45 AM
martinvonz added a comment to D7147: diff: use unfiltered repo if we're diffing the working copy.

Abandoning in favor of D7492

Tue, Dec 10, 2:41 AM
martinvonz added a comment to D7144: status: use unfiltered repo if we're getting status of working copy.

I'll abandon this in favor of D7492

Tue, Dec 10, 2:41 AM
martinvonz added a comment to D7492: localrepo: also fastpath access to working copy parents when possible.

Hmm, I thought this entire series had been queued. I'd like to queue it. Can you include perf numbers?

Tue, Dec 10, 2:38 AM
martinvonz added a comment to D7591: status: remove pointless filtering by alwaysmatcher in morestatus.

FYI I'm going to send a chain that rewrites a lot of this

To be clear, are you telling reviewers not to queue this one because you will be rewriting the *patch* or you're saying that you will later be sending patches on top of this one?

I'm writing a larger change which includes this change, I don't mind merging the conflict if you want to go ahead and queue this.

Tue, Dec 10, 12:59 AM
martinvonz added a comment to D7591: status: remove pointless filtering by alwaysmatcher in morestatus.

FYI I'm going to send a chain that rewrites a lot of this

Tue, Dec 10, 12:40 AM

Mon, Dec 9

martinvonz created D7591: status: remove pointless filtering by alwaysmatcher in morestatus.
Mon, Dec 9, 12:51 PM

Fri, Dec 6

martinvonz closed D7549: graft: never set both parents equal in the dirstate (issue6098).
Fri, Dec 6, 10:37 AM
martinvonz closed D7548: graft: extract `repo['.']` to local variable.
Fri, Dec 6, 10:37 AM
martinvonz committed rHG32d11a23c9cf: graft: never set both parents equal in the dirstate (issue6098).
graft: never set both parents equal in the dirstate (issue6098)
Fri, Dec 6, 10:37 AM
martinvonz closed D7547: graft: rename `pctx` argument to `base` since that's what it is.
Fri, Dec 6, 10:37 AM
martinvonz closed D7546: exchange: replace a "not x in ys" by more Pythonic "x not in ys".
Fri, Dec 6, 10:37 AM
martinvonz committed rHGfb07126dadbe: graft: extract `repo['.']` to local variable.
graft: extract `repo['.']` to local variable
Fri, Dec 6, 10:37 AM
martinvonz committed rHGebfd349eac46: graft: rename `pctx` argument to `base` since that's what it is.
graft: rename `pctx` argument to `base` since that's what it is
Fri, Dec 6, 10:37 AM
martinvonz committed rHG0f6782df1100: exchange: replace a "not x in ys" by more Pythonic "x not in ys".
exchange: replace a "not x in ys" by more Pythonic "x not in ys"
Fri, Dec 6, 10:37 AM

Thu, Dec 5

martinvonz created D7549: graft: never set both parents equal in the dirstate (issue6098).
Thu, Dec 5, 1:03 PM
martinvonz created D7548: graft: extract `repo['.']` to local variable.
Thu, Dec 5, 1:03 PM
martinvonz created D7547: graft: rename `pctx` argument to `base` since that's what it is.
Thu, Dec 5, 1:03 PM
martinvonz created D7546: exchange: replace a "not x in ys" by more Pythonic "x not in ys".
Thu, Dec 5, 12:03 PM

Tue, Dec 3

martinvonz committed rHGc8e9a3636abe: relnotes: add note about changes to match.{explicit,reverse}dir.
relnotes: add note about changes to match.{explicit,reverse}dir
Tue, Dec 3, 10:59 AM

Mon, Nov 25

martinvonz committed rHG32aa6cefb8f3: relnotes: add note about changes to match.{explicit,reverse}dir.
relnotes: add note about changes to match.{explicit,reverse}dir
Mon, Nov 25, 10:32 AM
martinvonz closed D7508: relnotes: add note about changes to match.{explicit,reverse}dir.
Mon, Nov 25, 10:32 AM

Sat, Nov 23

martinvonz added inline comments to D7483: changectx: add a "maybe filtered" filtered attribute.
Sat, Nov 23, 11:21 AM

Fri, Nov 22

martinvonz added a comment to D7500: repoview: add a test for changelog filtering trigger for `hg annotate`.

Yes we could.

Fri, Nov 22, 7:00 PM
martinvonz updated the diff for D7508: relnotes: add note about changes to match.{explicit,reverse}dir.
Fri, Nov 22, 6:01 PM
martinvonz added a comment to D7500: repoview: add a test for changelog filtering trigger for `hg annotate`.

Could we just add all these tests from the beginning? It seems they would look almost the same if added early in the series, just with some extra "getting filtered repo" lines (or whatever they say). If the tests were added earlier, it would be clearer which changes affected which tests.

Fri, Nov 22, 2:59 PM
martinvonz created D7508: relnotes: add note about changes to match.{explicit,reverse}dir.
Fri, Nov 22, 2:09 PM

Thu, Nov 21

martinvonz closed D7461: py3: wrap a __func__ in sysbytes() before logging as bytes.
Thu, Nov 21, 8:41 AM
martinvonz committed rHGaff3f6e407a1: py3: wrap a __func__ in sysbytes() before logging as bytes.
py3: wrap a __func__ in sysbytes() before logging as bytes
Thu, Nov 21, 8:40 AM

Wed, Nov 20

martinvonz created D7461: py3: wrap a __func__ in sysbytes() before logging as bytes.
Wed, Nov 20, 11:51 AM

Tue, Nov 19

martinvonz closed D7438: commit: drop unused "vdirs" argument from repo.checkcommitpatterns().
Tue, Nov 19, 8:14 AM
martinvonz closed D7439: dirstate: include explicit matches in match.traversedir calls.
Tue, Nov 19, 8:14 AM