Page MenuHomePhabricator

mbolin (Michael Bolin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2017, 2:56 PM (103 w, 5 d)

Recent Activity

Dec 11 2017

mbolin added a comment to D1354: dirstate: change all writes to dirstatemap._map to go through one method.

@durin42 Here's the implementation of this method we are using in Eden:

Dec 11 2017, 2:06 PM

Dec 7 2017

mbolin abandoned D1354: dirstate: change all writes to dirstatemap._map to go through one method.

D1347 did not address the issue because we still want to subclass it in Eden. If you're curious, you can see exactly what we're doing in https://github.com/facebookexperimental/eden-hg/blob/master/eden/hg/eden/eden_dirstate_map.py.

Dec 7 2017, 4:16 PM

Nov 13 2017

mbolin added a comment to D1354: dirstate: change all writes to dirstatemap._map to go through one method.

@durin42 The issue is that dirstatemap is doing so much "stuff" beyond just storage that Eden prefers to subclass it rather than copy/paste all of the business logic.

Nov 13 2017, 6:43 PM

Nov 9 2017

mbolin retitled D1354: dirstate: change all writes to dirstatemap._map to go through one method from dirstate: change all writes to dirstatemap._map to go through one method. to dirstate: change all writes to dirstatemap._map to go through one method.
Nov 9 2017, 8:48 PM
mbolin created D1354: dirstate: change all writes to dirstatemap._map to go through one method.
Nov 9 2017, 8:33 PM
mbolin added inline comments to D1345: dirstate: add explicit methods for querying directories (API).
Nov 9 2017, 8:24 PM
mbolin added inline comments to D1341: dirstate: move management of nonnormal sets into dirstate map.
Nov 9 2017, 8:10 PM
mbolin added inline comments to D1340: dirstate: add explicit methods for modifying dirstate.
Nov 9 2017, 8:01 PM

Nov 3 2017

mbolin updated subscribers of D1313: dirstate: gate access to self._map.dirs.
Nov 3 2017, 7:01 PM
mbolin created D1313: dirstate: gate access to self._map.dirs.
Nov 3 2017, 6:59 PM

Oct 31 2017

mbolin added a comment to D776: merge: add merge action 'p' to record path conflicts during update.

What test verifies this behavior? Do we need a new one?

Oct 31 2017, 12:56 PM

Oct 7 2017

mbolin added inline comments to D759: dirstate: move parents source of truth to dirstatemap.
Oct 7 2017, 8:10 PM

Sep 15 2017

mbolin committed rHG1246acdad653: dirstate: perform transactions with _map using single call, where possible.
dirstate: perform transactions with _map using single call, where possible
Sep 15 2017, 5:01 PM
mbolin closed D663: dirstate: perform transactions with _map using single call, where possible.
Sep 15 2017, 9:54 AM
mbolin committed rHG6d734a3a76e2: dirstate: perform transactions with _map using single call, where possible.
dirstate: perform transactions with _map using single call, where possible
Sep 15 2017, 9:54 AM

Sep 14 2017

mbolin added inline comments to D663: dirstate: perform transactions with _map using single call, where possible.
Sep 14 2017, 12:42 PM
mbolin updated the diff for D663: dirstate: perform transactions with _map using single call, where possible.
Sep 14 2017, 12:41 PM

Sep 9 2017

mbolin created D663: dirstate: perform transactions with _map using single call, where possible.
Sep 9 2017, 12:30 AM

Sep 2 2017

mbolin closed D607: editor: file created for diff action should have .diff suffix by committing rHG3c82b14d2838: editor: file created for diff action should have .diff suffix.
Sep 2 2017, 8:51 AM
mbolin committed rHG3c82b14d2838: editor: file created for diff action should have .diff suffix.
editor: file created for diff action should have .diff suffix
Sep 2 2017, 8:51 AM

Sep 1 2017

mbolin updated the diff for D607: editor: file created for diff action should have .diff suffix.

Remove bin/bash shebang as @quark says this should fix the FreeBSD issue and should generally be banned from integration tests.

Sep 1 2017, 4:29 PM
mbolin added inline comments to D464: editor: use an unambiguous path suffix for editor files.
Sep 1 2017, 4:18 PM
mbolin added a reviewer for D607: editor: file created for diff action should have .diff suffix: yuja.
Sep 1 2017, 4:17 PM
mbolin updated the diff for D607: editor: file created for diff action should have .diff suffix.

Added integration test.

Sep 1 2017, 4:16 PM
mbolin created D607: editor: file created for diff action should have .diff suffix.
Sep 1 2017, 4:03 PM
mbolin added inline comments to D464: editor: use an unambiguous path suffix for editor files.
Sep 1 2017, 3:47 PM
mbolin added a comment to D464: editor: use an unambiguous path suffix for editor files.

@durin42 looking

Sep 1 2017, 3:26 PM

Aug 31 2017

mbolin closed D464: editor: use an unambiguous path suffix for editor files by committing rHG6e6452bc441d: editor: use an unambiguous path suffix for editor files.
Aug 31 2017, 3:06 PM
mbolin committed rHG6e6452bc441d: editor: use an unambiguous path suffix for editor files.
editor: use an unambiguous path suffix for editor files
Aug 31 2017, 3:05 PM
mbolin added a comment to D464: editor: use an unambiguous path suffix for editor files.

Anything else I can do for this?

Aug 31 2017, 1:53 PM

Aug 30 2017

mbolin updated the diff for D464: editor: use an unambiguous path suffix for editor files.

Removed realpath in favor of $TESTTMP/editor.sh. Now hg init in the current directory instead of a subdirectory.

Aug 30 2017, 4:28 PM
mbolin added inline comments to D464: editor: use an unambiguous path suffix for editor files.
Aug 30 2017, 4:27 PM
mbolin updated the diff for D464: editor: use an unambiguous path suffix for editor files.

Address "don't export and assign at once" issue.

Aug 30 2017, 3:38 PM
mbolin updated the diff for D464: editor: use an unambiguous path suffix for editor files.

Added an integration test to verify editor filenames.

Aug 30 2017, 3:30 PM
mbolin updated the test plan for D464: editor: use an unambiguous path suffix for editor files.
Aug 30 2017, 3:30 PM

Aug 29 2017

mbolin added a comment to D464: editor: use an unambiguous path suffix for editor files.

Also, it looks like I would have to refactor ui.edit() quite a bit to create a unit test since the file name never escapes the method and that's what you would like me to verify, right?

Aug 29 2017, 12:48 PM
mbolin added a comment to D464: editor: use an unambiguous path suffix for editor files.

@ryanmce I'm happy to write a test, but what do you want me to target: ui.edit() itself?

Aug 29 2017, 12:38 PM
mbolin updated the diff for D464: editor: use an unambiguous path suffix for editor files.

Remove extra dot in action for diff as caught by @ryanmce.

Aug 29 2017, 12:20 PM
mbolin closed D468: util: use ~ as a suffix for a temp file in the same directory as a source file by committing rHG2ad028635ccd: util: use ~ as a suffix for a temp file in the same directory as a source file.
Aug 29 2017, 11:43 AM
mbolin committed rHG2ad028635ccd: util: use ~ as a suffix for a temp file in the same directory as a source file.
util: use ~ as a suffix for a temp file in the same directory as a source file
Aug 29 2017, 11:43 AM
mbolin updated the test plan for D464: editor: use an unambiguous path suffix for editor files.
Aug 29 2017, 12:19 AM
mbolin added a comment to D464: editor: use an unambiguous path suffix for editor files.

@durin42 Note that I substantially revised the commit message and test plan to reflect the changes.

Aug 29 2017, 12:18 AM
mbolin retitled D464: editor: use an unambiguous path suffix for editor files from commit: use an unambiguous path suffix for editor files to editor: use an unambiguous path suffix for editor files.
Aug 29 2017, 12:18 AM
mbolin retitled D464: editor: use an unambiguous path suffix for editor files from commit: use an unambiguous path suffix for the commit editor file to commit: use an unambiguous path suffix for editor files.
Aug 29 2017, 12:17 AM

Aug 28 2017

mbolin updated the diff for D464: editor: use an unambiguous path suffix for editor files.

Changed format string to .%s.hg.txt.

Aug 28 2017, 11:06 PM
mbolin updated the diff for D464: editor: use an unambiguous path suffix for editor files.

Created optional action param as suggested by @durin42

Aug 28 2017, 11:05 PM
mbolin added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.

@durin42 I believe we've come to a resolution on this thread that this is fine as-is, so are you OK to take this now?

Aug 28 2017, 5:51 PM
mbolin added a comment to D464: editor: use an unambiguous path suffix for editor files.

@durin42 Sounds good: I'll work on cleaning this up.

Aug 28 2017, 5:50 PM
mbolin closed D493: dirstate: perform transactions with _copymap using single call, where possible by committing rHG5cb0a8fe096e: dirstate: perform transactions with _copymap using single call, where possible.
Aug 28 2017, 3:06 PM
mbolin committed rHG5cb0a8fe096e: dirstate: perform transactions with _copymap using single call, where possible.
dirstate: perform transactions with _copymap using single call, where possible
Aug 28 2017, 3:06 PM

Aug 24 2017

mbolin committed rFBHGXc29e61682661: spelling: change commited -> committed.
spelling: change commited -> committed
Aug 24 2017, 6:08 PM

Aug 23 2017

mbolin added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.

@smf so are you OK with this patch as-is?

Aug 23 2017, 4:56 PM
mbolin added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.

@smf Personally, I think that D464 is a better place to have that discussion.

Aug 23 2017, 4:51 PM
mbolin added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.

@smf As I put in the summary, I think this use of tempfile.mkstemp() is different than the others in the codebase because it uses the dir= argument to create a file in the working copy. As such, I'd argue that it's reasonable to consider it separately from the others.

Aug 23 2017, 4:47 PM
mbolin requested review of D468: util: use ~ as a suffix for a temp file in the same directory as a source file.

@quark Rather than exposing the additional keyword argument now, why don't we wait until there is a compelling use-case to use something other than ~? As it stands, creating an API for this would just open things up to misuse.

Aug 23 2017, 3:26 PM
mbolin updated the diff for D493: dirstate: perform transactions with _copymap using single call, where possible.

Minor fix.

Aug 23 2017, 2:25 PM
mbolin created D493: dirstate: perform transactions with _copymap using single call, where possible.
Aug 23 2017, 2:23 PM
mbolin updated the test plan for D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
Aug 23 2017, 1:36 PM
mbolin retitled D468: util: use ~ as a suffix for a temp file in the same directory as a source file from util: use ~ as a suffix for temp file in the same directory as a source file to util: use ~ as a suffix for a temp file in the same directory as a source file.
Aug 23 2017, 12:49 AM
mbolin retitled D468: util: use ~ as a suffix for a temp file in the same directory as a source file from util: use ~ as a suffix when creating a temp file in the same directory as a source file to util: use ~ as a suffix for temp file in the same directory as a source file.
Aug 23 2017, 12:48 AM

Aug 21 2017

mbolin created D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
Aug 21 2017, 8:39 PM
mbolin created D464: editor: use an unambiguous path suffix for editor files.
Aug 21 2017, 3:47 PM