Page MenuHomePhabricator

mbthomas (Mark Thomas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2017, 6:17 AM (175 w, 4 d)

Recent Activity

Oct 17 2018

mbthomas closed D5096: py3: fix test-hardlinks.t.
Oct 17 2018, 9:46 AM
mbthomas committed rHGe0dea186ab6e: py3: fix test-hardlinks.t.
py3: fix test-hardlinks.t
Oct 17 2018, 9:46 AM

Oct 14 2018

mbthomas closed D5106: py3: fix test-dirstate-race.t.
Oct 14 2018, 11:27 AM
mbthomas committed rHGd33611280add: py3: fix test-propertycache.py.
py3: fix test-propertycache.py
Oct 14 2018, 11:27 AM
mbthomas committed rHGe787d97e90ad: py3: fix test-dirstate-race.t.
py3: fix test-dirstate-race.t
Oct 14 2018, 11:27 AM
mbthomas closed D5101: py3: fix test-propertycache.py.
Oct 14 2018, 11:27 AM
mbthomas updated the diff for D5101: py3: fix test-propertycache.py.

Use pycompat.fsencode

Oct 14 2018, 10:12 AM
mbthomas added inline comments to D5101: py3: fix test-propertycache.py.
Oct 14 2018, 10:12 AM
mbthomas created D5106: py3: fix test-dirstate-race.t.
Oct 14 2018, 10:03 AM
mbthomas created D5101: py3: fix test-propertycache.py.
Oct 14 2018, 7:50 AM
mbthomas closed D5095: py3: fix test-diff-color.t.
Oct 14 2018, 5:38 AM
mbthomas committed rHGe4f82db071a4: py3: fix test-diff-color.t.
py3: fix test-diff-color.t
Oct 14 2018, 5:38 AM
mbthomas created D5096: py3: fix test-hardlinks.t.
Oct 14 2018, 5:35 AM
mbthomas closed D5093: py3: fix test-revlog.t.
Oct 14 2018, 5:28 AM
mbthomas committed rHG29b0e9cd02f4: py3: fix test-revlog.t.
py3: fix test-revlog.t
Oct 14 2018, 5:28 AM
mbthomas created D5095: py3: fix test-diff-color.t.
Oct 14 2018, 5:25 AM
mbthomas updated the summary of D5093: py3: fix test-revlog.t.
Oct 14 2018, 5:09 AM
mbthomas created D5093: py3: fix test-revlog.t.
Oct 14 2018, 5:08 AM
mbthomas closed D5089: py3: fix test-status.t.
Oct 14 2018, 4:07 AM
mbthomas committed rHG125fc478719f: py3: fix test-status.t.
py3: fix test-status.t
Oct 14 2018, 4:07 AM
mbthomas added a comment to D5089: py3: fix test-status.t.

Just saw yuya's comment, I will do that.

Oct 14 2018, 3:42 AM
mbthomas added inline comments to D5089: py3: fix test-status.t.
Oct 14 2018, 3:42 AM

Oct 13 2018

mbthomas updated the diff for D5089: py3: fix test-status.t.

Add to whitelist

Oct 13 2018, 11:33 AM
mbthomas created D5089: py3: fix test-status.t.
Oct 13 2018, 11:32 AM
mbthomas closed D5084: py3: fix test-parse-date.t.
Oct 13 2018, 9:45 AM
mbthomas committed rHGd4d2c567bb72: py3: fix test-parse-date.t.
py3: fix test-parse-date.t
Oct 13 2018, 9:45 AM
mbthomas updated the diff for D5084: py3: fix test-parse-date.t.

Add to whilelist

Oct 13 2018, 9:39 AM
mbthomas created D5084: py3: fix test-parse-date.t.
Oct 13 2018, 9:26 AM
mbthomas closed D5078: py3: fix infinitepush extension tests.
Oct 13 2018, 9:16 AM
mbthomas committed rHG090e5f3900b7: py3: fix infinitepush extension tests.
py3: fix infinitepush extension tests
Oct 13 2018, 9:16 AM
mbthomas updated the diff for D5078: py3: fix infinitepush extension tests.

Use a different function for getting hexdigest as bytes

Oct 13 2018, 9:04 AM
mbthomas created D5078: py3: fix infinitepush extension tests.
Oct 13 2018, 8:46 AM
mbthomas closed D5057: test-bookmarks-pushpull: use correct tmp dir for no-bm-move.sh.
Oct 13 2018, 5:23 AM
mbthomas committed rHG58d785679e15: test-bookmarks-pushpull: use correct tmp dir for no-bm-move.sh.
test-bookmarks-pushpull: use correct tmp dir for no-bm-move.sh
Oct 13 2018, 5:23 AM
mbthomas abandoned D5056: closehead: use correct format string for rev numbers.
In D5056#75750, @pulkit wrote:

I took care of this in https://phab.mercurial-scm.org/D5040 ;)

Oct 13 2018, 5:08 AM
mbthomas created D5057: test-bookmarks-pushpull: use correct tmp dir for no-bm-move.sh.
Oct 13 2018, 4:50 AM
mbthomas updated the diff for D5056: closehead: use correct format string for rev numbers.

Add whitelist for test this fixes.

Oct 13 2018, 4:41 AM
mbthomas created D5056: closehead: use correct format string for rev numbers.
Oct 13 2018, 4:38 AM

Oct 12 2018

mbthomas closed D5022: absorb: update help text.
Oct 12 2018, 5:27 PM
mbthomas committed rHG8f192f2c4a1e: absorb: update help text.
absorb: update help text
Oct 12 2018, 5:27 PM
mbthomas created D5022: absorb: update help text.
Oct 12 2018, 4:04 PM
mbthomas closed D4999: absorb: prompt user to accept absorb changes by default.
Oct 12 2018, 2:13 PM
mbthomas committed rHG31dfa7dac4c9: absorb: prompt user to accept absorb changes by default.
absorb: prompt user to accept absorb changes by default
Oct 12 2018, 2:12 PM
mbthomas closed D5000: templatefuncs: add truncate parameter to pad.
Oct 12 2018, 1:57 PM
mbthomas committed rHG9458dbfa7f33: templatefuncs: add truncate parameter to pad.
templatefuncs: add truncate parameter to pad
Oct 12 2018, 1:57 PM
mbthomas updated the diff for D4999: absorb: prompt user to accept absorb changes by default.

Rebase and fix conflicts

Oct 12 2018, 1:55 PM
mbthomas abandoned D5021: absorb: prompt user to accept absorb changes by default.
Oct 12 2018, 1:52 PM
mbthomas created D5021: absorb: prompt user to accept absorb changes by default.
Oct 12 2018, 1:50 PM
mbthomas closed D4998: absorb: print summary of changesets affected.
Oct 12 2018, 1:42 PM
mbthomas closed D4997: absorb: use a formatter to generate output.
Oct 12 2018, 1:42 PM
mbthomas committed rHG2c5316796f45: absorb: print summary of changesets affected.
absorb: print summary of changesets affected
Oct 12 2018, 1:42 PM
mbthomas committed rHGdcda50856843: absorb: use a formatter to generate output.
absorb: use a formatter to generate output
Oct 12 2018, 1:42 PM
mbthomas added a comment to D5000: templatefuncs: add truncate parameter to pad.

This is necessary to recreate something like the original output for hg absorb using the template language. It also allows inclusion of the commit message in the rows of the absorb output, using a template spec like:

hg absorb -pn -T '{ifeq(linetype,"summary","\n{count} changesets affected",ifeq(linetype,"path","showing changes for {label("absorb.path",path)}","{label("absorb.node", pad(node, 7, truncate=true))} {label("yellow", pad(desc, 30, truncate=true))} {label("diff.{linetype}", "{diffchar}{inserted}{deleted}{hunk}")}"))}\n'
Oct 12 2018, 11:55 AM
mbthomas created D5000: templatefuncs: add truncate parameter to pad.
Oct 12 2018, 11:53 AM
mbthomas created D4999: absorb: prompt user to accept absorb changes by default.
Oct 12 2018, 11:52 AM
mbthomas created D4998: absorb: print summary of changesets affected.
Oct 12 2018, 11:51 AM
mbthomas created D4997: absorb: use a formatter to generate output.
Oct 12 2018, 11:49 AM

Jan 8 2018

mbthomas accepted D1714: distutils_rust: use atomic replace to install the .so file.
Jan 8 2018, 2:36 PM

Dec 20 2017

mbthomas closed D1712: indexes: add comment indication location of python27-sys.
Dec 20 2017, 6:12 PM
mbthomas committed rFBHGX580520efb8e5: indexes: add comment indication location of python27-sys.
indexes: add comment indication location of python27-sys
Dec 20 2017, 6:12 PM

Dec 18 2017

mbthomas added a comment to D1712: indexes: add comment indication location of python27-sys.

I'm willing to entertain better suggestions, but until Cargo has proper support for vendoring git repositories, we're stuck with an ugly hack.

Dec 18 2017, 6:59 AM
mbthomas added a reviewer for D1712: indexes: add comment indication location of python27-sys: ikostia.
Dec 18 2017, 6:43 AM
mbthomas created D1712: indexes: add comment indication location of python27-sys.
Dec 18 2017, 6:43 AM

Dec 15 2017

mbthomas closed D1704: infinitepush: add backingup templatekeyword.
Dec 15 2017, 2:35 PM
mbthomas closed D1705: infinitepush: don't show backup summary if a backup is in progress.
Dec 15 2017, 2:34 PM
mbthomas committed rFBHGXb61e79aec430: infinitepush: don't show backup summary if a backup is in progress.
infinitepush: don't show backup summary if a backup is in progress
Dec 15 2017, 2:34 PM
mbthomas closed D1680: treedirstate: dirstatemap.identity should be a property.
Dec 15 2017, 2:34 PM
mbthomas committed rFBHGXdf07a778ff29: infinitepush: add backingup templatekeyword.
infinitepush: add backingup templatekeyword
Dec 15 2017, 2:34 PM
mbthomas committed rFBHGX886a701c9350: treedirstate: dirstatemap.identity should be a property.
treedirstate: dirstatemap.identity should be a property
Dec 15 2017, 2:34 PM
mbthomas closed D1604: rage: look in srcrepo for infinitepushbackupstate.
Dec 15 2017, 2:34 PM
mbthomas closed D1603: infinitepush: extract getsrcrepo to a utility module.
Dec 15 2017, 2:34 PM
mbthomas committed rFBHGX5b83d2245166: rage: look in srcrepo for infinitepushbackupstate.
rage: look in srcrepo for infinitepushbackupstate
Dec 15 2017, 2:34 PM
mbthomas committed rFBHGXb7768822f769: infinitepush: extract getsrcrepo to a utility module.
infinitepush: extract getsrcrepo to a utility module
Dec 15 2017, 2:34 PM
mbthomas closed D1613: infinitepush: consider hidden revisions when computing backedup state.
Dec 15 2017, 2:33 PM
mbthomas committed rFBHGXeb10e9f4e867: infinitepush: consider hidden revisions when computing backedup state.
infinitepush: consider hidden revisions when computing backedup state
Dec 15 2017, 2:33 PM
mbthomas requested review of D1680: treedirstate: dirstatemap.identity should be a property.
Dec 15 2017, 11:44 AM
mbthomas added a reviewer for D1705: infinitepush: don't show backup summary if a backup is in progress: stash.
Dec 15 2017, 11:21 AM
mbthomas created D1705: infinitepush: don't show backup summary if a backup is in progress.
Dec 15 2017, 11:20 AM
mbthomas added a reviewer for D1704: infinitepush: add backingup templatekeyword: stash.
Dec 15 2017, 11:00 AM
mbthomas created D1704: infinitepush: add backingup templatekeyword.
Dec 15 2017, 10:53 AM

Dec 14 2017

mbthomas accepted D1683: sshpeer: allow for additional environment passing to ssh exe.

Looks reasonable to me. This could also be achieved by making SSH a script which sets the environment up and invokes the real SSH, but that's clumsy, whereas this allows use of config to set the env vars.

Dec 14 2017, 11:21 AM
mbthomas added a comment to D1680: treedirstate: dirstatemap.identity should be a property.

I don't think it's possible to reliably provoke the bad behaviour. What's happening here is we are using the bound identity method of the dirstatemap instance as the identity of the dirstate. This nearly always changes when the dirstate is recreated (which happens when the dirstate file changes on disk by virtue of dirstate being a filecache property and by localrepo.invalidatedirstate. The only time this will actually cause problems is if the new dirstatemap object ends up with the same address as the old one. In that case we will think the dirstate hasn't changed (as bound methods are compared using the combination of object address and method address), and potentially update using an old dirstate instance.

Dec 14 2017, 8:41 AM

Dec 13 2017

mbthomas added a comment to D1680: treedirstate: dirstatemap.identity should be a property.

I'm not actually sure what problem it would cause, I just know it's wrong. I think the only place we actually use identity is in deciding when to update the dirstate after a status call that discovers the dirstate isn't right (e.g. normallookup files can now be marked normal). Normally status doesn't have the lock, so it optimistically grabs the lock, but only does the update if the identity matches. I don't really have a good idea what the function would do when it's using the bound method rather than the real identity. Suggestions for a test for this race?

Dec 13 2017, 1:12 PM
mbthomas created D1680: treedirstate: dirstatemap.identity should be a property.
Dec 13 2017, 12:25 PM

Dec 12 2017

mbthomas closed D1654: treedirstate: ensure appended data is flushed to disk.
Dec 12 2017, 7:25 PM
mbthomas committed rFBHGX37bccca1426f: treedirstate: ensure appended data is flushed to disk.
treedirstate: ensure appended data is flushed to disk
Dec 12 2017, 7:25 PM
mbthomas closed D1602: distutils_rust: support windows python extension filenames.
Dec 12 2017, 7:25 PM
mbthomas committed rFBHGXc0a41e35fdc8: distutils_rust: support windows python extension filenames.
distutils_rust: support windows python extension filenames
Dec 12 2017, 7:25 PM

Dec 11 2017

mbthomas created D1654: treedirstate: ensure appended data is flushed to disk.
Dec 11 2017, 10:13 AM

Dec 7 2017

mbthomas added a reviewer for D1613: infinitepush: consider hidden revisions when computing backedup state: stash.
Dec 7 2017, 5:53 AM
mbthomas created D1613: infinitepush: consider hidden revisions when computing backedup state.
Dec 7 2017, 5:53 AM

Dec 6 2017

mbthomas added a reviewer for D1603: infinitepush: extract getsrcrepo to a utility module: stash.
Dec 6 2017, 6:53 AM
mbthomas added a reviewer for D1604: rage: look in srcrepo for infinitepushbackupstate: stash.
Dec 6 2017, 6:53 AM
mbthomas added a reviewer for D1602: distutils_rust: support windows python extension filenames: ikostia.
Dec 6 2017, 6:52 AM
mbthomas created D1604: rage: look in srcrepo for infinitepushbackupstate.
Dec 6 2017, 6:52 AM
mbthomas created D1603: infinitepush: extract getsrcrepo to a utility module.
Dec 6 2017, 6:52 AM
mbthomas created D1602: distutils_rust: support windows python extension filenames.
Dec 6 2017, 6:51 AM

Dec 1 2017

mbthomas closed D1226: merge: check created file dirs for path conflicts only once (issue5716).
Dec 1 2017, 12:58 PM
mbthomas closed D1224: merge: cache unknown dir checks (issue5716).
Dec 1 2017, 12:58 PM
mbthomas committed rHGa92b9f8e11ba: merge: check created file dirs for path conflicts only once (issue5716).
merge: check created file dirs for path conflicts only once (issue5716)
Dec 1 2017, 12:58 PM