Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User Details

User Since
Jul 16 2017, 3:10 PM (236 w, 2 d)

Recent Activity

Mon, Jan 17

mharbison72 committed rHGf98d4d0a299a: subrepo: make -S work again on Windows for incoming/outgoing to remote repos.
subrepo: make -S work again on Windows for incoming/outgoing to remote repos
Mon, Jan 17, 10:59 AM
mharbison72 closed D11971: subrepo: make -S work again on Windows for incoming/outgoing to remote repos.
Mon, Jan 17, 5:54 AM
mharbison72 committed rHG21bb97351ef9: subrepo: make -S work again on Windows for incoming/outgoing to remote repos.
subrepo: make -S work again on Windows for incoming/outgoing to remote repos
Mon, Jan 17, 5:53 AM

Sun, Jan 16

mharbison72 added a comment to D12002: precheck: fix false warning about content-divergence creation.

Is there an easy test you can make for this?

Sun, Jan 16, 1:20 PM

Mon, Jan 10

mharbison72 created D11971: subrepo: make -S work again on Windows for incoming/outgoing to remote repos.
Mon, Jan 10, 11:51 PM

Wed, Jan 5

mharbison72 added inline comments to D11956: exchange: add fast path for subrepo check on push.
Wed, Jan 5, 10:46 AM

Dec 18 2021

mharbison72 closed D11944: setup.py: fix some documentation typos.
Dec 18 2021, 9:47 PM
mharbison72 committed rHG23ce9e7bf1e5: setup.py: fix some documentation typos.
setup.py: fix some documentation typos
Dec 18 2021, 9:47 PM
mharbison72 created D11944: setup.py: fix some documentation typos.
Dec 18 2021, 8:57 PM

Dec 17 2021

mharbison72 closed D11931: pytype: stop excluding ssutil.py.
Dec 17 2021, 6:12 AM
mharbison72 closed D11930: pytype: stop excluding wireprotoserver.py.
Dec 17 2021, 6:12 AM
mharbison72 committed rHG08af0adc235c: pytype: stop excluding ssutil.py.
pytype: stop excluding ssutil.py
Dec 17 2021, 6:12 AM
mharbison72 closed D11929: pytype: stop excluding pycompat.py.
Dec 17 2021, 6:12 AM
mharbison72 closed D11928: procutil: avoid an uninitialized variable usage on tempfile exception.
Dec 17 2021, 6:12 AM
mharbison72 committed rHG81805bba11f9: pytype: stop excluding wireprotoserver.py.
pytype: stop excluding wireprotoserver.py
Dec 17 2021, 6:12 AM
mharbison72 committed rHG12a43f857a11: pytype: stop excluding pycompat.py.
pytype: stop excluding pycompat.py
Dec 17 2021, 6:12 AM
mharbison72 closed D11922: pytype: stop excluding patch.py.
Dec 17 2021, 6:12 AM
mharbison72 committed rHGf8540fe4be0f: procutil: avoid an uninitialized variable usage on tempfile exception.
procutil: avoid an uninitialized variable usage on tempfile exception
Dec 17 2021, 6:12 AM
mharbison72 closed D11927: pytype: stop excluding procutil.py.
Dec 17 2021, 6:12 AM
mharbison72 committed rHG333a2656e981: pytype: stop excluding procutil.py.
pytype: stop excluding procutil.py
Dec 17 2021, 6:11 AM
mharbison72 closed D11926: pytype: stop excluding chgserver.py.
Dec 17 2021, 6:11 AM
mharbison72 closed D11924: pytype: stop excluding webcommands.py.
Dec 17 2021, 6:11 AM
mharbison72 committed rHG7caaefa48794: pytype: stop excluding chgserver.py.
pytype: stop excluding chgserver.py
Dec 17 2021, 6:11 AM
mharbison72 committed rHGea13dabbe168: pytype: stop excluding webcommands.py.
pytype: stop excluding webcommands.py
Dec 17 2021, 6:11 AM
mharbison72 closed D11923: tests: drop an obsolete comment about a pytype failure.
Dec 17 2021, 6:11 AM
mharbison72 closed D11921: pytype: stop excluding statprof.py.
Dec 17 2021, 6:11 AM
mharbison72 committed rHG8a075b679918: tests: drop an obsolete comment about a pytype failure.
tests: drop an obsolete comment about a pytype failure
Dec 17 2021, 6:11 AM
mharbison72 closed D11919: pytype: stop excluding wireprotov2server.py.
Dec 17 2021, 6:11 AM
mharbison72 committed rHGd2fff292c265: pytype: stop excluding statprof.py.
pytype: stop excluding statprof.py
Dec 17 2021, 6:11 AM
mharbison72 committed rHG290f9c150f70: pytype: stop excluding patch.py.
pytype: stop excluding patch.py
Dec 17 2021, 6:11 AM
mharbison72 closed D11920: statprof: convert a few exception byte strings to str.
Dec 17 2021, 6:11 AM
mharbison72 committed rHGc1fe758c1530: statprof: convert a few exception byte strings to str.
statprof: convert a few exception byte strings to str
Dec 17 2021, 6:10 AM
mharbison72 closed D11918: pytype: stop excluding stringutil.py.
Dec 17 2021, 6:10 AM
mharbison72 closed D11916: pytype: stop excluding copies.py.
Dec 17 2021, 6:10 AM
mharbison72 committed rHGcfb4f1dee978: pytype: stop excluding wireprotov2server.py.
pytype: stop excluding wireprotov2server.py
Dec 17 2021, 6:10 AM
mharbison72 closed D11917: pytype: stop excluding cmdutil.py.
Dec 17 2021, 6:10 AM
mharbison72 committed rHGdcdecec401ca: pytype: stop excluding stringutil.py.
pytype: stop excluding stringutil.py
Dec 17 2021, 6:10 AM
mharbison72 committed rHG3444e0b39c30: pytype: stop excluding cmdutil.py.
pytype: stop excluding cmdutil.py
Dec 17 2021, 6:10 AM
mharbison72 closed D11912: pytype: stop excluding changegroup.py.
Dec 17 2021, 6:10 AM
mharbison72 committed rHG79b904313357: pytype: stop excluding copies.py.
pytype: stop excluding copies.py
Dec 17 2021, 6:10 AM
mharbison72 closed D11915: copies: fix some documentation typos.
Dec 17 2021, 6:10 AM
mharbison72 closed D11914: copies: drop an unused variable.
Dec 17 2021, 6:10 AM
mharbison72 committed rHG19e6446cea11: copies: fix some documentation typos.
copies: fix some documentation typos
Dec 17 2021, 6:10 AM
mharbison72 closed D11913: pytype: stop excluding lsprof.py.
Dec 17 2021, 6:10 AM
mharbison72 committed rHG74b41e8b3d9c: copies: drop an unused variable.
copies: drop an unused variable
Dec 17 2021, 6:09 AM
mharbison72 committed rHGabac7983d28e: pytype: stop excluding lsprof.py.
pytype: stop excluding lsprof.py
Dec 17 2021, 6:09 AM
mharbison72 closed D11911: pytype: stop excluding upgrade.py.
Dec 17 2021, 6:09 AM
mharbison72 committed rHG8843c9a8771b: pytype: stop excluding changegroup.py.
pytype: stop excluding changegroup.py
Dec 17 2021, 6:09 AM
mharbison72 committed rHGa4d8de93023c: pytype: stop excluding upgrade.py.
pytype: stop excluding upgrade.py
Dec 17 2021, 6:09 AM

Dec 15 2021

mharbison72 updated the diff for D11912: pytype: stop excluding changegroup.py.
Dec 15 2021, 4:19 PM
mharbison72 created D11931: pytype: stop excluding ssutil.py.
Dec 15 2021, 3:48 PM
mharbison72 created D11930: pytype: stop excluding wireprotoserver.py.
Dec 15 2021, 3:47 PM
mharbison72 created D11929: pytype: stop excluding pycompat.py.
Dec 15 2021, 3:47 PM
mharbison72 created D11927: pytype: stop excluding procutil.py.
Dec 15 2021, 3:47 PM
mharbison72 created D11928: procutil: avoid an uninitialized variable usage on tempfile exception.
Dec 15 2021, 3:47 PM
mharbison72 created D11926: pytype: stop excluding chgserver.py.
Dec 15 2021, 3:47 PM
mharbison72 added inline comments to D11912: pytype: stop excluding changegroup.py.
Dec 15 2021, 2:45 PM

Dec 14 2021

mharbison72 created D11922: pytype: stop excluding patch.py.
Dec 14 2021, 4:12 PM
mharbison72 created D11924: pytype: stop excluding webcommands.py.
Dec 14 2021, 4:12 PM
mharbison72 created D11921: pytype: stop excluding statprof.py.
Dec 14 2021, 4:12 PM
mharbison72 created D11923: tests: drop an obsolete comment about a pytype failure.
Dec 14 2021, 4:11 PM
mharbison72 created D11919: pytype: stop excluding wireprotov2server.py.
Dec 14 2021, 4:11 PM
mharbison72 created D11920: statprof: convert a few exception byte strings to str.
Dec 14 2021, 4:11 PM
mharbison72 created D11918: pytype: stop excluding stringutil.py.
Dec 14 2021, 4:11 PM
mharbison72 created D11916: pytype: stop excluding copies.py.
Dec 14 2021, 4:11 PM
mharbison72 created D11917: pytype: stop excluding cmdutil.py.
Dec 14 2021, 4:11 PM
mharbison72 created D11912: pytype: stop excluding changegroup.py.
Dec 14 2021, 4:11 PM
mharbison72 created D11915: copies: fix some documentation typos.
Dec 14 2021, 4:11 PM
mharbison72 created D11914: copies: drop an unused variable.
Dec 14 2021, 4:10 PM
mharbison72 created D11913: pytype: stop excluding lsprof.py.
Dec 14 2021, 4:10 PM
mharbison72 created D11911: pytype: stop excluding upgrade.py.
Dec 14 2021, 4:10 PM

Dec 13 2021

mharbison72 committed rHG9dd151a39950: merge with stable.
merge with stable
Dec 13 2021, 7:38 PM
mharbison72 closed D11906: hghave: fix the check for suid on platforms lacking support.
Dec 13 2021, 6:17 AM
mharbison72 committed rHGf21e7748c257: hghave: fix the check for suid on platforms lacking support.
hghave: fix the check for suid on platforms lacking support
Dec 13 2021, 6:17 AM
mharbison72 committed rHGcb477edeca79: upgrade: byteify a few error messages.
upgrade: byteify a few error messages
Dec 13 2021, 6:17 AM
mharbison72 closed D11905: upgrade: byteify a few error messages.
Dec 13 2021, 6:17 AM
mharbison72 added a comment to D11905: upgrade: byteify a few error messages.

These should probably go on stable.

Dec 13 2021, 1:13 AM
mharbison72 created D11906: hghave: fix the check for suid on platforms lacking support.
Dec 13 2021, 1:11 AM
mharbison72 created D11905: upgrade: byteify a few error messages.
Dec 13 2021, 1:11 AM

Nov 30 2021

mharbison72 added inline comments to D11822: extension: add a `required` suboption to enforce the use of an extensions.
Nov 30 2021, 12:24 AM
mharbison72 added a comment to D11820: extensions: refactor handling of loading error make it reusable.

Do we care that this breaks the current translations?

Nov 30 2021, 12:22 AM
mharbison72 added a comment to D11820: extensions: refactor handling of loading error make it reusable.

Do we care that this breaks the current translations?

Nov 30 2021, 12:14 AM
mharbison72 added a comment to D11776: automation: support Python 3.10 on Windows.

We should probably sit on this for a bit because windows_curses hasn't been updated to support py3.10 yet: https://github.com/zephyrproject-rtos/windows-curses/pull/28

I'm assuming this is good now that I queued your D11804?

Nov 30 2021, 12:05 AM

Nov 29 2021

mharbison72 closed D11805: packaging: bump pygit2 to 1.7.1.
Nov 29 2021, 7:45 AM
mharbison72 committed rHGa71a2f72f5d8: packaging: bump pygit2 to 1.7.1.
packaging: bump pygit2 to 1.7.1
Nov 29 2021, 7:45 AM
mharbison72 committed rHG981509bb10ac: packaging: bump windows_curses to 2.3.0.
packaging: bump windows_curses to 2.3.0
Nov 29 2021, 7:45 AM
mharbison72 closed D11804: packaging: bump windows_curses to 2.3.0.
Nov 29 2021, 7:45 AM
mharbison72 committed rHGcbbbbbef800d: packaging: regenerate the requirements files with pip-tools 6.4.0.
packaging: regenerate the requirements files with pip-tools 6.4.0
Nov 29 2021, 7:45 AM
mharbison72 closed D11803: packaging: regenerate the requirements files with pip-tools 6.4.0.
Nov 29 2021, 7:45 AM

Nov 24 2021

mharbison72 created D11805: packaging: bump pygit2 to 1.7.1.
Nov 24 2021, 8:54 PM
mharbison72 created D11804: packaging: bump windows_curses to 2.3.0.
Nov 24 2021, 8:54 PM
mharbison72 created D11803: packaging: regenerate the requirements files with pip-tools 6.4.0.
Nov 24 2021, 8:54 PM

Nov 23 2021

mharbison72 added a comment to D11776: automation: support Python 3.10 on Windows.

We should probably sit on this for a bit because windows_curses hasn't been updated to support py3.10 yet: https://github.com/zephyrproject-rtos/windows-curses/pull/28

Nov 23 2021, 10:19 PM

Oct 26 2021

mharbison72 closed D11718: typing: add a few assertions to revlog.py to help pytype.
Oct 26 2021, 5:02 AM
mharbison72 closed D11719: typing: add more type hints to the errors module.
Oct 26 2021, 5:02 AM
mharbison72 committed rHG9de0823705b4: typing: add more type hints to the errors module.
typing: add more type hints to the errors module
Oct 26 2021, 5:02 AM
mharbison72 committed rHGebac18733142: typing: add a few assertions to revlog.py to help pytype.
typing: add a few assertions to revlog.py to help pytype
Oct 26 2021, 5:02 AM

Oct 24 2021

mharbison72 added a comment to D11715: dirstate: group return logic and clarify each function in flagfunc.

Now that the fallback function is always being built

I don't think this is the case? It should be gated on the same conditions it was before.

Oct 24 2021, 7:14 PM
mharbison72 added a comment to D11715: dirstate: group return logic and clarify each function in flagfunc.

Now that the fallback function is always being built- do the context.manifest(), dirstate.copies(), etc that get run in context._buildflagfunc() always have an acceptably low overhead?

Oct 24 2021, 12:29 AM

Oct 23 2021

mharbison72 created D11719: typing: add more type hints to the errors module.
Oct 23 2021, 6:41 PM