In D7920#116596, @mharbison72 wrote:

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

In D7920#116596, @mharbison72 wrote:

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

--- d:/mercurial/tests/test-phabricator.t
+++ d:/mercurial/tests/test-phabricator.t.err
@@ -56,7 +56,10 @@
   $ echo alpha > alpha
   $ hg ci --addremove -m 'create alpha for phabricator test Ç'
   adding alpha
-
+  transaction abort!
+  rollback completed
+  abort: decoding near 'ator test \x80': 'utf8' codec can't decode byte 0x80 in position 34: invalid start byte! (esc)
+  [255]
 A bad .arcconfig doesn't error out
   $ echo 'garbage' > .arcconfig
   $ hg config phabricator --debug
ERROR: test-phabricator.t output changed

So I'm not sure if there is a phabsend or phabread issue.

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

LGTM

Noise from regenerating the phabricator recordings.

Noise from regenerating the phabricator recordings.

Noise from regenerating the phabricator recordings.

Noise from regenerating the phabricator recordings.

Noise from regenerating the phabricator recordings.

Address review comments

For default branch

I don't see any guardrails that prevent mixing unrelated local stuff into the revset and erroneously assigning the last revision processed as a parent, but that's less trivial and can probably wait until someone stumbles on it.

Setting this back to wanting a review because I suspect my response questions were overlooked with vacations, and it won't show up in anybody's dashboard otherwise.