mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (56 w, 3 d)

Recent Activity

Yesterday

mharbison72 committed rHG7e023ce26c7f: convert: don't drop missing or corrupt tag entries.
convert: don't drop missing or corrupt tag entries
Wed, Aug 15, 12:34 AM

Sun, Aug 12

mharbison72 committed rHGacd23830bcd6: cext: fix most truncation warnings in revlog on Windows.
cext: fix most truncation warnings in revlog on Windows
Sun, Aug 12, 12:46 AM
mharbison72 committed rHGb935adb4b041: cext: fix a warning about differing const qualifiers on Windows.
cext: fix a warning about differing const qualifiers on Windows
Sun, Aug 12, 12:46 AM
mharbison72 committed rHGbeab6690f202: cext: fix Windows warning about implicit conversion of 32-bit shift to 64 bit.
cext: fix Windows warning about implicit conversion of 32-bit shift to 64 bit
Sun, Aug 12, 12:46 AM

Fri, Aug 3

mharbison72 added a comment to D4049: testrunner: allow multiple #testcases.
In D4049#63027, @quark wrote:

Sorry, I was just misremembering that D4052 had been queued. I don't know why phabricator doesn't understand that this patch is on top of D4052. Anyway, try applying D4052 first, then this one.

There is no formal API to set dependency. So you need to click "Edit Related Revisions... -> Edit Parent Revisions" on the right sidebar manually.

Fri, Aug 3, 2:07 AM
mharbison72 accepted D4049: testrunner: allow multiple #testcases.

I'm getting an import error, and I'm not sure how to figure out the parent revision from phab.

Make sure you're applying it onto @ from https://www.mercurial-scm.org/repo/hg-committed/. If not, you'll probably have to import D4052 before this patch (D4052 is in @ on hg-committed).

Maybe needs a push? I'm seeing @ on D4048 on hg-committed.

Sorry, I was just misremembering that D4052 had been queued. I don't know why phabricator doesn't understand that this patch is on top of D4052. Anyway, try applying D4052 first, then this one.

Fri, Aug 3, 2:01 AM
mharbison72 added a comment to D4049: testrunner: allow multiple #testcases.

I'm getting an import error, and I'm not sure how to figure out the parent revision from phab.

Make sure you're applying it onto @ from https://www.mercurial-scm.org/repo/hg-committed/. If not, you'll probably have to import D4052 before this patch (D4052 is in @ on hg-committed).

Fri, Aug 3, 1:18 AM
mharbison72 added a comment to D4049: testrunner: allow multiple #testcases.

I manually fixed it up, and got the following diffs. I see the last parent is listed as D4067, which hasn't been accepted yet, so I'm assuming that's the issue (I'm way behind on the ML). And I guess --stack doesn't pick up parent dependencies, just what was submitted together?

Fri, Aug 3, 1:15 AM
mharbison72 added a comment to D4049: testrunner: allow multiple #testcases.

I'm getting an import error, and I'm not sure how to figure out the parent revision from phab.

Fri, Aug 3, 1:00 AM

Thu, Aug 2

mharbison72 added a comment to D4049: testrunner: allow multiple #testcases.

Not sure. If we can’t reuse ‘#’, maybe ‘_’ would be ok as a distinct visual identifier? I don’t think either are reserved characters.

Thu, Aug 2, 1:13 AM
mharbison72 requested changes to D4049: testrunner: allow multiple #testcases.

I think Windows will choke on ‘:’ in the file name.

Thu, Aug 2, 1:08 AM

Sat, Jul 28

mharbison72 added a comment to D3716: ui: add an uninterruptable context manager that can block SIGINT.
Do we need a different strategy for Windows, or just eat the error?  (See the unsupported signal message)
 
https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/808/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio

I'm not sure. We could probably just not support this on windows for now, or at least disable the test on Windows?

Sat, Jul 28, 3:05 PM

Fri, Jul 27

mharbison72 added a comment to D3716: ui: add an uninterruptable context manager that can block SIGINT.

Do we need a different strategy for Windows, or just eat the error? (See the unsupported signal message)

Fri, Jul 27, 2:23 PM

Jul 17 2018

mharbison72 committed rHG02b5b5c1bba8: windows: replace single quote with double quote when translating to cmd.exe.
windows: replace single quote with double quote when translating to cmd.exe
Jul 17 2018, 8:32 AM
mharbison72 committed rHGc382c19ce9bd: windows: expand '~/' and '~\' to %USERPROFILE% when translating to cmd.exe.
windows: expand '~/' and '~\' to %USERPROFILE% when translating to cmd.exe
Jul 17 2018, 8:32 AM
mharbison72 committed rHG2009d84f245a: hook: disable the shell to native command translation by default.
hook: disable the shell to native command translation by default
Jul 17 2018, 8:32 AM
mharbison72 committed rHGf9b2d996ffa5: hook: only print the note about native cmd translation if it actually changes.
hook: only print the note about native cmd translation if it actually changes
Jul 17 2018, 8:32 AM

Jul 10 2018

mharbison72 committed rHG38dfd308fe9d: hook: add support for disabling the shell to native command translation.
hook: add support for disabling the shell to native command translation
Jul 10 2018, 9:07 AM
mharbison72 committed rHG539f9708b980: hook: narrow the 'priority' prefix check to align with the documentation.
hook: narrow the 'priority' prefix check to align with the documentation
Jul 10 2018, 9:07 AM
mharbison72 committed rHG93ed193bc03e: windows: don't consider '$$' to be an escaped '$' when translating to cmd.exe.
windows: don't consider '$$' to be an escaped '$' when translating to cmd.exe
Jul 10 2018, 9:07 AM
mharbison72 committed rHG4548cec9e48b: hook: add support for disabling the shell to native command translation.
hook: add support for disabling the shell to native command translation
Jul 10 2018, 8:42 AM
mharbison72 committed rHGa2e2bd28fdab: hook: narrow the 'priority' prefix check to align with the documentation.
hook: narrow the 'priority' prefix check to align with the documentation
Jul 10 2018, 8:42 AM
mharbison72 committed rHG6f46bf99d64e: windows: don't consider '$$' to be an escaped '$' when translating to cmd.exe.
windows: don't consider '$$' to be an escaped '$' when translating to cmd.exe
Jul 10 2018, 8:42 AM

Jul 6 2018

mharbison72 committed rHG050fbd9d103a: test-convert: demonstrate an unstable hash issue for bzr -> hg -> hg.
test-convert: demonstrate an unstable hash issue for bzr -> hg -> hg
Jul 6 2018, 8:24 AM
mharbison72 committed rHG85da230c316a: convert: add a config knob for not saving the bzr revision.
convert: add a config knob for not saving the bzr revision
Jul 6 2018, 8:24 AM
mharbison72 committed rHG30a027c0e327: test-bzr: use a fixed commit time.
test-bzr: use a fixed commit time
Jul 6 2018, 8:24 AM

Jun 29 2018

mharbison72 committed rHG72286f9e324f: procutil: add a shim for translating shell commands to native commands.
procutil: add a shim for translating shell commands to native commands
Jun 29 2018, 8:31 AM

Jun 28 2018

mharbison72 committed rHGe9e61fbac787: hooks: allow Unix style environment variables on external Windows hooks.
hooks: allow Unix style environment variables on external Windows hooks
Jun 28 2018, 8:17 AM
mharbison72 committed rHG3efadf2317c7: windows: add a method to convert Unix style command lines to Windows style.
windows: add a method to convert Unix style command lines to Windows style
Jun 28 2018, 8:17 AM

Jun 23 2018

mharbison72 committed rHG36edfbac7281: relink: use context manager for lock management.
relink: use context manager for lock management
Jun 23 2018, 3:58 AM
mharbison72 committed rHGe219e355e088: censor: use context manager for lock management.
censor: use context manager for lock management
Jun 23 2018, 3:58 AM

Jun 21 2018

mharbison72 committed rHG6fcbab5c1e6e: test-lfs: add coverage for the binary() fileset.
test-lfs: add coverage for the binary() fileset
Jun 21 2018, 7:55 AM
mharbison72 committed rHG235d0bc11e1d: fileset: use filectx.isbinary() to filter out binaries in eol().
fileset: use filectx.isbinary() to filter out binaries in eol()
Jun 21 2018, 7:55 AM

Jun 20 2018

mharbison72 added a comment to D3818: scmutil: make cleanupnodes optionally also fix the phase.

Anyway, I like the idea of being able to use cleanupnodes() for amend as well. Perhaps something like this:

fixphase=False, targetphase=None => leave phases alone (used by rebase and histedit)
fixphase=True, targetphase=None => set phases based just on the precursors' phase (used by most other commands)
fixphase=True, targetphase=<phase> => set phase to targetphase unless parent has higher phase (used by hg amend --secret)
fixphase=False, targetphase=<phase> => assertion error

Jun 20 2018, 10:31 PM
mharbison72 added a comment to D3818: scmutil: make cleanupnodes optionally also fix the phase.

I assume this was inspired at least in part by https://bz.mercurial-scm.org/show_bug.cgi?id=5918?

Jun 20 2018, 12:29 PM

Jun 16 2018

mharbison72 committed rHGbb7e3c6ef592: phabricator: preserve the phase when amending in the Differential fields.
phabricator: preserve the phase when amending in the Differential fields
Jun 16 2018, 9:46 AM

Jun 14 2018

mharbison72 added a comment to D3728: grep: adds allfiles mode.
In D3728#58540, @yuja wrote:

> commands.py:2411
> _('only search files changed within revision range'), _('REV')),
> + ('', 'unmodified', False,
> + _('include all files in the changeset while grepping')),

I wonder if --allfiles is a better name. --unmodified makes me think unmodified files exclusively.

It's too bad --all is already used, because that would be consistent with the all files meaning in status and revert. (Maybe others?) The plan page mentions BCing plain grep into oblivion, and deprecating --all. Is it worth a BC on this too, for consistency going forward?

Maybe we can keep all new flags hidden as "(EXPERIMENTAL)" until we make
the final BC? I don't think it's time for bikeshedding yet.

Jun 14 2018, 6:40 PM

Jun 13 2018

mharbison72 added inline comments to D3728: grep: adds allfiles mode.
Jun 13 2018, 9:11 PM

Jun 12 2018

mharbison72 accepted D3721: run-tests: restrict the test cases allowed characters.

The second hunk in run-test.py doesn't apply for me (it looks like adding b to a string has landed, but wasn't applied near the first hunk). But manually applying it, Windows is happy again. Thanks.

Jun 12 2018, 7:54 PM
mharbison72 added a comment to D3699: run-tests: follow-up on the test-case format.

@mharbison72 I was not aware that this patch had been merged, is it breaking the windows build right now?

Jun 12 2018, 7:47 PM

Jun 8 2018

mharbison72 added inline comments to D3699: run-tests: follow-up on the test-case format.
Jun 8 2018, 9:51 PM

Jun 6 2018

mharbison72 committed rHG69d1cafe75f2: rebase: avoid RevlogError when computing obsoletenotrebased (issue5907).
rebase: avoid RevlogError when computing obsoletenotrebased (issue5907)
Jun 6 2018, 9:33 AM

Jun 4 2018

mharbison72 committed rHG51e420a7a41a: cmdutil: use internal separators when building the terse list.
cmdutil: use internal separators when building the terse list
Jun 4 2018, 8:03 AM
mharbison72 committed rHG79c54e7c0c52: rebase: prioritize indicating an interrupted rebase over update (issue5838).
rebase: prioritize indicating an interrupted rebase over update (issue5838)
Jun 4 2018, 7:54 AM
mharbison72 committed rHG712d6f535fc9: tests: demonstrate inconsistent messaging around interrupted rebases.
tests: demonstrate inconsistent messaging around interrupted rebases
Jun 4 2018, 7:54 AM

Jun 2 2018

mharbison72 committed rHG22edd5321489: outgoing: drop an extraneous URL parse.
outgoing: drop an extraneous URL parse
Jun 2 2018, 11:11 PM

Jun 1 2018

mharbison72 committed rHG6ae62d62c3f6: tests: adapt test-check-pylint to run on Windows.
tests: adapt test-check-pylint to run on Windows
Jun 1 2018, 10:46 AM
mharbison72 committed rHG6fb76897e066: hghave: avoid a deadlock reading the child process's output.
hghave: avoid a deadlock reading the child process's output
Jun 1 2018, 10:46 AM
mharbison72 committed rHG3790efb388ca: lfs: bypass wrapped functions when reposetup() hasn't been called (issue5902).
lfs: bypass wrapped functions when reposetup() hasn't been called (issue5902)
Jun 1 2018, 10:25 AM

May 30 2018

mharbison72 committed rHGdfb888aae17a: outgoing: pay attention to `default:pushurl` for bookmarks and subrepos.
outgoing: pay attention to `default:pushurl` for bookmarks and subrepos
May 30 2018, 7:33 AM
mharbison72 committed rHG2fedcc30f256: outgoing: pay attention to `default:pushurl` for bookmarks and subrepos.
outgoing: pay attention to `default:pushurl` for bookmarks and subrepos
May 30 2018, 7:17 AM

May 26 2018

mharbison72 committed rHGaa10675c5dd6: lfs: clarify pointer validation error messages.
lfs: clarify pointer validation error messages
May 26 2018, 12:28 AM
mharbison72 committed rHGc974320d20b9: terse: pconvert() entries added to the temporary terse dict for Windows.
terse: pconvert() entries added to the temporary terse dict for Windows
May 26 2018, 12:28 AM

May 25 2018

mharbison72 committed rHGafaf4fa9205e: terse: pconvert() entries added to the temporary terse dict for Windows.
terse: pconvert() entries added to the temporary terse dict for Windows
May 25 2018, 9:26 PM

May 24 2018

mharbison72 added a comment to rHGc3960c7e66fa: py3: replace str.format(x) with `str % x` in githelp.

Why is it better?

May 24 2018, 9:36 PM
mharbison72 committed rHGc3960c7e66fa: py3: replace str.format(x) with `str % x` in githelp.
py3: replace str.format(x) with `str % x` in githelp
May 24 2018, 6:42 AM
mharbison72 committed rHGcfa93fbbe9b4: githelp: drop the trailing period from single sentence output for consistency.
githelp: drop the trailing period from single sentence output for consistency
May 24 2018, 6:42 AM

May 23 2018

mharbison72 committed rHGa40cc6d7d8c3: githelp: cleanup one more abort message.
githelp: cleanup one more abort message
May 23 2018, 8:34 AM

May 22 2018

mharbison72 committed rHGf44306940c94: tests: stabilize test-patch.t on Windows.
tests: stabilize test-patch.t on Windows
May 22 2018, 7:41 AM
mharbison72 committed rHG10befe8e8b59: githelp: rewrite a Yoda conditional.
githelp: rewrite a Yoda conditional
May 22 2018, 7:41 AM
mharbison72 committed rHG26b73fad45d9: githelp: lowercase the start of output messages for consistency.
githelp: lowercase the start of output messages for consistency
May 22 2018, 7:41 AM
mharbison72 committed rHGee96458afdb6: githelp: cleanly abort if the `svn` command is unknown.
githelp: cleanly abort if the `svn` command is unknown
May 22 2018, 7:41 AM
mharbison72 committed rHG16463278e7f4: githelp: make several strings localizable.
githelp: make several strings localizable
May 22 2018, 7:41 AM
mharbison72 committed rHGd8bd6a9c64a5: githelp: fail gracefully in a couple cases where arguments are missing.
githelp: fail gracefully in a couple cases where arguments are missing
May 22 2018, 7:41 AM
mharbison72 committed rHG1721a2ef74b8: tests: stabilize test-patch.t on Windows.
tests: stabilize test-patch.t on Windows
May 22 2018, 7:14 AM
mharbison72 committed rHGed103895d9a2: githelp: lowercase the start of output messages for consistency.
githelp: lowercase the start of output messages for consistency
May 22 2018, 5:21 AM
mharbison72 committed rHG8e4cdc86c55f: githelp: rewrite a Yoda conditional.
githelp: rewrite a Yoda conditional
May 22 2018, 5:21 AM
mharbison72 committed rHGd00bfbf24df0: githelp: make several strings localizable.
githelp: make several strings localizable
May 22 2018, 5:21 AM
mharbison72 committed rHGc137053c30e3: githelp: cleanly abort if the `svn` command is unknown.
githelp: cleanly abort if the `svn` command is unknown
May 22 2018, 5:21 AM
mharbison72 committed rHGa34bed7475cc: githelp: fail gracefully in a couple cases where arguments are missing.
githelp: fail gracefully in a couple cases where arguments are missing
May 22 2018, 5:21 AM

May 18 2018

mharbison72 committed rHG5a7cf42ba6ef: phabricator: register config settings.
phabricator: register config settings
May 18 2018, 7:26 AM

May 15 2018

mharbison72 committed rHG71cf20d47f25: phabricator: split auth.url into the standard auth.schemes and auth.prefix.
phabricator: split auth.url into the standard auth.schemes and auth.prefix
May 15 2018, 8:51 AM

May 14 2018

mharbison72 committed rHG0fa050bc68cb: phabricator: migrate [phabricator.auth] to [auth].
phabricator: migrate [phabricator.auth] to [auth]
May 14 2018, 8:21 AM

May 11 2018

mharbison72 committed rHG8ba0344f9fb1: debugextensions: process extensions loaded from the local repository too.
debugextensions: process extensions loaded from the local repository too
May 11 2018, 10:54 PM
mharbison72 committed rHG20a4543e9a2b: phabricator: drop support for the deprecated `phabricator.token` config.
phabricator: drop support for the deprecated `phabricator.token` config
May 11 2018, 10:54 PM
mharbison72 committed rHGf81a51d8fedf: util: drop _deprecatedfunc().
util: drop _deprecatedfunc()
May 11 2018, 3:32 PM
mharbison72 committed rHG70f45f28c04e: util: drop deprecated forwarding to procutil (API).
util: drop deprecated forwarding to procutil (API)
May 11 2018, 3:32 PM
mharbison72 committed rHG009b424c9cb6: templatekw: drop deprecated showlist() and showdict() (API).
templatekw: drop deprecated showlist() and showdict() (API)
May 11 2018, 3:32 PM
mharbison72 committed rHG1d0610fdd63b: tests: migrate demandimport.py away from deprecated `util` module symbols.
tests: migrate demandimport.py away from deprecated `util` module symbols
May 11 2018, 3:32 PM
mharbison72 committed rHG88c4257ae465: util: drop deprecated forwarding to dateutil (API).
util: drop deprecated forwarding to dateutil (API)
May 11 2018, 3:32 PM
mharbison72 committed rHG8298e55fc9a4: util: drop deprecated forwarding to stringutil (API).
util: drop deprecated forwarding to stringutil (API)
May 11 2018, 3:32 PM
mharbison72 committed rHGfb0de0bcd297: cmdutil: drop deprecated precursor of registrar.command (API).
cmdutil: drop deprecated precursor of registrar.command (API)
May 11 2018, 3:32 PM

May 4 2018

mharbison72 added inline comments to D3433: httppeer: detect redirect to URL without query string (issue5860).
May 4 2018, 11:33 PM

May 3 2018

mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

Just to confirm that phabimport brought this in correctly, the only thing you changed is advertisedurl to baseurl? If that's the case, the LFS change will have to be punted.

May 3 2018, 5:43 PM
mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

I'll probably be at work for another ~2 hours if you need me to test with SCM Manager, but I can stay later if needed.

May 3 2018, 3:51 PM

May 2 2018

mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

With these fixes, it works on Windows. I'm not sure if the advertisedbaseurl a couple lines above needs to be adjusted too.

May 2 2018, 11:10 PM
mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

It looks like the redirect is subtly changing the host. I printed req.get_full_url() in keepalive.do_open(), and got:

May 2 2018, 10:44 PM
mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

I have no clue how this test would be failing on Windows but not on other platforms :/

May 2 2018, 1:28 PM

May 1 2018

mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

This fixes the issue, thanks again. The only thing I noticed in practice is that the "real URL is xxx" notice is printed twice. The trace looks sane, (and the test captures this too), so I think it's purely cosmetic. The *.t test fails on Windows though:

May 1 2018, 10:07 AM

Apr 27 2018

mharbison72 added a comment to D3432: hgweb: guard against empty Content-Length header.

LGTM. Here's the PEP reference allowing that:

Apr 27 2018, 11:26 PM

Apr 24 2018

mharbison72 added a comment to D3427: hgweb: reuse body file object when hgwebdir calls hgweb (issue5851).

A test demonstrating hg clone and hg push via hgwebdir has been
added. Without this patch, the test hangs when doing hg clone.
Surprisingly, this must mean that we have effectively no test coverage
of the wire protocol when run via hgwebdir.

Apr 24 2018, 9:13 PM
mharbison72 committed rHG91b717e2cafa: tests: drop a useless glob in test-infinite-bundlestore.t.
tests: drop a useless glob in test-infinite-bundlestore.t
Apr 24 2018, 5:44 AM
mharbison72 committed rHG51dee6fad783: infinitepush: ensure fileindex bookmarks use '/' separators (issue5840).
infinitepush: ensure fileindex bookmarks use '/' separators (issue5840)
Apr 24 2018, 5:44 AM

Apr 19 2018

mharbison72 committed rHG33d26f7bd6ca: infinitepush: open files in binary mode.
infinitepush: open files in binary mode
Apr 19 2018, 7:24 AM
mharbison72 committed rHG72ccb0716302: tests: stabilize test-fix.t for Windows.
tests: stabilize test-fix.t for Windows
Apr 19 2018, 7:24 AM

Apr 17 2018

mharbison72 committed rHGab04972a33ef: lfs: enable the final download count status message.
lfs: enable the final download count status message
Apr 17 2018, 8:00 AM
mharbison72 committed rHG925707ac2855: lfs: add the 'Authorization' property to the Batch API response, if present.
lfs: add the 'Authorization' property to the Batch API response, if present
Apr 17 2018, 8:00 AM
mharbison72 committed rHG7269b87f817c: scmutil: teach the file prefetch hook to handle multiple commits.
scmutil: teach the file prefetch hook to handle multiple commits
Apr 17 2018, 8:00 AM
mharbison72 committed rHGb54404d66f7e: export: invoke the file prefetch hook.
export: invoke the file prefetch hook
Apr 17 2018, 8:00 AM
mharbison72 committed rHG5e67c20915a7: diff: invoke the file prefetch hook.
diff: invoke the file prefetch hook
Apr 17 2018, 8:00 AM