Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User Details

User Since
Jul 16 2017, 3:10 PM (222 w, 5 d)

Recent Activity

Mon, Oct 18

mharbison72 added a comment to D11688: dirstate-v2: preserve the fallback values on disk.

LGTM

Mon, Oct 18, 11:52 PM
mharbison72 added a comment to D11687: dirstate: make DirstateItem constructor accept fallback value.

LGTM, but I need someone to look at the rust code here too

Mon, Oct 18, 11:40 PM
mharbison72 added a comment to D11686: dirstate: add a concept of "fallback" flags to dirstate item.

Nice! I'd love an experimental UI for this if this is the last py2 release, but even if it's just used in the background so that rebasing/amending added files stops dropping these bits, it would be a major benefit.

Mon, Oct 18, 10:30 PM

Wed, Oct 13

mharbison72 closed D11452: pyoxidizer: add the user site to `sys.path` on macOS.
Wed, Oct 13, 6:29 PM
mharbison72 committed rHGe10f5dc7f5bf: pyoxidizer: add the user site to `sys.path` on macOS.
pyoxidizer: add the user site to `sys.path` on macOS
Wed, Oct 13, 6:29 PM
mharbison72 closed D11451: pyoxidizer: don't use in-memory for resources on macOS.
Wed, Oct 13, 6:29 PM
mharbison72 committed rHG7bc1beedd718: pyoxidizer: don't use in-memory for resources on macOS.
pyoxidizer: don't use in-memory for resources on macOS
Wed, Oct 13, 6:29 PM

Tue, Oct 12

mharbison72 committed rHGc95f6c2d1f4e: packaging: update the certifi dependency.
packaging: update the certifi dependency
Tue, Oct 12, 1:19 PM
mharbison72 closed D11455: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Tue, Oct 12, 1:19 PM
mharbison72 closed D11609: packaging: update the certifi dependency.
Tue, Oct 12, 1:19 PM
mharbison72 closed D11454: exewrapper: find the proper python3X.dll in the registry.
Tue, Oct 12, 1:19 PM
mharbison72 added a reverting change for D9362: setup: copy pythonXY.dll next to the hg.exe wrapper when building: rHGf78d8b8c46d7: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Tue, Oct 12, 1:19 PM
mharbison72 added a reverting change for D10301: setup: copy python3.dll next to hg.exe when building on Windows for hgext.git: rHGf78d8b8c46d7: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Tue, Oct 12, 1:19 PM
mharbison72 added a reverting change for rHGed286d150aa8: setup: copy python3.dll next to hg.exe when building on Windows for hgext.git: rHGf78d8b8c46d7: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Tue, Oct 12, 1:19 PM
mharbison72 added a reverting change for rHG2960b7fac966: setup: copy pythonXY.dll next to the hg.exe wrapper when building: rHGf78d8b8c46d7: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Tue, Oct 12, 1:19 PM
mharbison72 added reverted changes for rHGf78d8b8c46d7: setup: stop packaging python3.dll and python3X.dll in the wheel distribution: rHGed286d150aa8: setup: copy python3.dll next to hg.exe when building on Windows for hgext.git, rHG2960b7fac966: setup: copy pythonXY.dll next to the hg.exe wrapper when building, D10301: setup: copy python3.dll next to hg.exe when building on Windows for hgext.git, D9362: setup: copy pythonXY.dll next to the hg.exe wrapper when building.
setup: stop packaging python3.dll and python3X.dll in the wheel distribution
Tue, Oct 12, 1:19 PM
mharbison72 committed rHG67d14d4e036c: exewrapper: find the proper python3X.dll in the registry.
exewrapper: find the proper python3X.dll in the registry
Tue, Oct 12, 1:19 PM
D11625: dirstate-v2: Document flags/mode/size/mtime fields of tree nodes is now accepted and ready to land.

LGTM, but I still get an import error for this. Since there are a bunch of accepted things not pushed yet, maybe this has a dependency on one of those things.

Tue, Oct 12, 12:18 PM
mharbison72 added a comment to D11625: dirstate-v2: Document flags/mode/size/mtime fields of tree nodes.

This seems fine, but I couldn't import it without the previous commit, and I'd like someone who knows Rust to handle that.

Tue, Oct 12, 12:39 AM

Mon, Oct 4

mharbison72 created D11609: packaging: update the certifi dependency.
Mon, Oct 4, 12:03 AM

Fri, Oct 1

mharbison72 committed rHGb4d7b04e3c88: merge with stable.
merge with stable
Fri, Oct 1, 9:21 AM

Sep 22 2021

mharbison72 closed D11476: extensions: prevent a crash on py3 with a `minimumhgversion` str value.
Sep 22 2021, 3:57 AM
mharbison72 committed rHG5caec48d9a01: extensions: prevent a crash on py3 with a `minimumhgversion` str value.
extensions: prevent a crash on py3 with a `minimumhgversion` str value
Sep 22 2021, 3:57 AM
mharbison72 closed D11473: util: eliminate the possibility of returning None from `versiontuple()`.
Sep 22 2021, 3:57 AM
mharbison72 closed D11475: extensions: prevent a crash on py3 when testing a bad extension minimum.
Sep 22 2021, 3:57 AM
mharbison72 committed rHGa9bedc56f025: extensions: prevent a crash on py3 when testing a bad extension minimum.
extensions: prevent a crash on py3 when testing a bad extension minimum
Sep 22 2021, 3:57 AM
mharbison72 committed rHG0dc4cc654d96: typing: drop annotations on `mercurial/logcmdutil.walkopts` attributes.
typing: drop annotations on `mercurial/logcmdutil.walkopts` attributes
Sep 22 2021, 3:57 AM
mharbison72 closed D11470: util: avoid a name-error warning in the `mmapread` exception handler.
Sep 22 2021, 3:57 AM
mharbison72 closed D11474: typing: drop annotations on `mercurial/logcmdutil.walkopts` attributes.
Sep 22 2021, 3:57 AM
mharbison72 committed rHG376d08ae904f: util: eliminate the possibility of returning None from `versiontuple()`.
util: eliminate the possibility of returning None from `versiontuple()`
Sep 22 2021, 3:56 AM
mharbison72 closed D11472: archival: force a `CompressionError` to bytes before passing to `error.Abort`.
Sep 22 2021, 3:56 AM
mharbison72 closed D11471: parser: force a `ValueError` to bytes before passing to `error.ParseError`.
Sep 22 2021, 3:56 AM
mharbison72 committed rHG406a7e629946: archival: force a `CompressionError` to bytes before passing to `error.Abort`.
archival: force a `CompressionError` to bytes before passing to `error.Abort`
Sep 22 2021, 3:56 AM
mharbison72 closed D11469: typing: suppress an name-error warning in `mercurial/windows.py`.
Sep 22 2021, 3:56 AM
mharbison72 committed rHG8655a77dce94: parser: force a `ValueError` to bytes before passing to `error.ParseError`.
parser: force a `ValueError` to bytes before passing to `error.ParseError`
Sep 22 2021, 3:56 AM
mharbison72 committed rHGae79611e3115: util: avoid a name-error warning in the `mmapread` exception handler.
util: avoid a name-error warning in the `mmapread` exception handler
Sep 22 2021, 3:56 AM
mharbison72 committed rHGc0588d389c5f: typing: suppress an import-error warning in `mercurial/utils/resourceutil.py`.
typing: suppress an import-error warning in `mercurial/utils/resourceutil.py`
Sep 22 2021, 3:56 AM
mharbison72 committed rHG94d4a3f78e99: typing: suppress an name-error warning in `mercurial/windows.py`.
typing: suppress an name-error warning in `mercurial/windows.py`
Sep 22 2021, 3:56 AM
mharbison72 closed D11467: encoding: force a few Errors to bytes before passing to `error.Abort`.
Sep 22 2021, 3:56 AM
mharbison72 closed D11468: typing: suppress an import-error warning in `mercurial/utils/resourceutil.py`.
Sep 22 2021, 3:56 AM
mharbison72 committed rHG28c62f83b652: encoding: force a few Errors to bytes before passing to `error.Abort`.
encoding: force a few Errors to bytes before passing to `error.Abort`
Sep 22 2021, 3:56 AM
mharbison72 committed rHG1fda8c9358ce: typing: add a fake `__init__()` to bytestr to distract pytype.
typing: add a fake `__init__()` to bytestr to distract pytype
Sep 22 2021, 3:56 AM
mharbison72 closed D11466: typing: add a fake `__init__()` to bytestr to distract pytype.
Sep 22 2021, 3:56 AM

Sep 21 2021

mharbison72 created D11476: extensions: prevent a crash on py3 with a `minimumhgversion` str value.
Sep 21 2021, 11:39 AM
mharbison72 created D11473: util: eliminate the possibility of returning None from `versiontuple()`.
Sep 21 2021, 11:39 AM
mharbison72 created D11475: extensions: prevent a crash on py3 when testing a bad extension minimum.
Sep 21 2021, 11:39 AM
mharbison72 created D11474: typing: drop annotations on `mercurial/logcmdutil.walkopts` attributes.
Sep 21 2021, 11:39 AM
mharbison72 created D11470: util: avoid a name-error warning in the `mmapread` exception handler.
Sep 21 2021, 11:39 AM
mharbison72 created D11472: archival: force a `CompressionError` to bytes before passing to `error.Abort`.
Sep 21 2021, 11:38 AM
mharbison72 created D11471: parser: force a `ValueError` to bytes before passing to `error.ParseError`.
Sep 21 2021, 11:38 AM
mharbison72 created D11469: typing: suppress an name-error warning in `mercurial/windows.py`.
Sep 21 2021, 11:38 AM
mharbison72 created D11468: typing: suppress an import-error warning in `mercurial/utils/resourceutil.py`.
Sep 21 2021, 11:38 AM
mharbison72 created D11467: encoding: force a few Errors to bytes before passing to `error.Abort`.
Sep 21 2021, 11:38 AM
mharbison72 created D11466: typing: add a fake `__init__()` to bytestr to distract pytype.
Sep 21 2021, 11:38 AM

Sep 19 2021

mharbison72 added a comment to D11449: tests: make removeemptydirs more portable.

If someone on centos can test this, it would be great.

Sep 19 2021, 3:08 PM
mharbison72 added inline comments to D11447: relnotes: add release notes for 5.9.
Sep 19 2021, 2:53 PM
mharbison72 created D11455: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Sep 19 2021, 2:28 PM
mharbison72 added a reverting change for D10301: setup: copy python3.dll next to hg.exe when building on Windows for hgext.git: D11455: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Sep 19 2021, 2:28 PM
mharbison72 added a reverting change for D9362: setup: copy pythonXY.dll next to the hg.exe wrapper when building: D11455: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Sep 19 2021, 2:28 PM
mharbison72 added a reverting change for rHG2960b7fac966: setup: copy pythonXY.dll next to the hg.exe wrapper when building: D11455: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Sep 19 2021, 2:28 PM
mharbison72 added a reverting change for rHGed286d150aa8: setup: copy python3.dll next to hg.exe when building on Windows for hgext.git: D11455: setup: stop packaging python3.dll and python3X.dll in the wheel distribution.
Sep 19 2021, 2:28 PM
mharbison72 created D11454: exewrapper: find the proper python3X.dll in the registry.
Sep 19 2021, 2:28 PM

Sep 17 2021

mharbison72 created D11452: pyoxidizer: add the user site to `sys.path` on macOS.
Sep 17 2021, 5:01 PM
mharbison72 created D11451: pyoxidizer: don't use in-memory for resources on macOS.
Sep 17 2021, 5:01 PM

Aug 27 2021

mharbison72 closed D11354: hg: don't attempt to extend `sys.path` with the user site without `APPDATA`.
Aug 27 2021, 5:26 AM
mharbison72 committed rHG769cd5703b2c: hg: don't attempt to extend `sys.path` with the user site without `APPDATA`.
hg: don't attempt to extend `sys.path` with the user site without `APPDATA`
Aug 27 2021, 5:26 AM

Aug 26 2021

mharbison72 created D11354: hg: don't attempt to extend `sys.path` with the user site without `APPDATA`.
Aug 26 2021, 11:19 AM

Aug 25 2021

mharbison72 committed rHG4162f6b40f2c: windows: degrade to py2 behavior when reading a non-symlink as a symlink.
windows: degrade to py2 behavior when reading a non-symlink as a symlink
Aug 25 2021, 9:15 AM
mharbison72 committed rHG95af358fcdfe: pyoxidizer: add user-site to `sys.path` on Windows.
pyoxidizer: add user-site to `sys.path` on Windows
Aug 25 2021, 9:15 AM
mharbison72 committed rHGad2c37075f46: zeroconf: fix an issue concatenating bytes and str.
zeroconf: fix an issue concatenating bytes and str
Aug 25 2021, 9:15 AM
mharbison72 closed D11308: pyoxidizer: add user-site to `sys.path` on Windows.
Aug 25 2021, 6:08 AM
mharbison72 closed D11333: windows: degrade to py2 behavior when reading a non-symlink as a symlink.
Aug 25 2021, 6:08 AM
mharbison72 closed D11303: zeroconf: fix an issue concatenating bytes and str.
Aug 25 2021, 6:08 AM
mharbison72 committed rHG9c67faf2e28e: windows: degrade to py2 behavior when reading a non-symlink as a symlink.
windows: degrade to py2 behavior when reading a non-symlink as a symlink
Aug 25 2021, 6:08 AM
mharbison72 committed rHGc18210649334: pyoxidizer: add user-site to `sys.path` on Windows.
pyoxidizer: add user-site to `sys.path` on Windows
Aug 25 2021, 6:08 AM
mharbison72 committed rHG66f720b3dd98: zeroconf: fix an issue concatenating bytes and str.
zeroconf: fix an issue concatenating bytes and str
Aug 25 2021, 6:08 AM

Aug 23 2021

mharbison72 added a comment to D11308: pyoxidizer: add user-site to `sys.path` on Windows.

This looks good (i.e. similar to what is done in the ./hg script).
Do you think we could get a test for that in test-extensions ? (using a fake APPDATA for that part of the test) ?

I haven't quite got the test working yet (should foo.py in site-packages be loadable, or does it need a directory with __init__.py?). But I see that site.getuserpackages() is available on py3, and it would be easier to write a test against that with support for all platforms. But that should (probably?) go on default, especially since the non pyoxidizer path needs to be updated to stay in sync. So how about this for stable, and a rework on default that supports py3 everywhere.

You mean getting this specific patch for stable, without a test, and a more complete version for default, with a test ?

Aug 23 2021, 10:12 AM

Aug 22 2021

mharbison72 added a comment to D11308: pyoxidizer: add user-site to `sys.path` on Windows.

This looks good (i.e. similar to what is done in the ./hg script).
Do you think we could get a test for that in test-extensions ? (using a fake APPDATA for that part of the test) ?

Aug 22 2021, 9:45 PM
mharbison72 created D11333: windows: degrade to py2 behavior when reading a non-symlink as a symlink.
Aug 22 2021, 7:39 PM
mharbison72 committed rHG155a2ec8a9dc: merge with stable.
merge with stable
Aug 22 2021, 4:55 PM

Aug 18 2021

mharbison72 created D11308: pyoxidizer: add user-site to `sys.path` on Windows.
Aug 18 2021, 10:47 PM
D11298: pyoxidized: install fuzzywuzzy too is now accepted and ready to land.
Aug 18 2021, 9:14 PM
mharbison72 added a comment to D11307: run-tests: avoid silently switching the hg executable used.

I seems a bit weird to be that we try to manually put self._bindir and self._hgcommand together while if I am not mistaken, they both originate from the splitting of some absolute path somewhere. So keeping that absolute path around would seems safer/cleaner to me. However I might be missing something.

Aug 18 2021, 7:29 PM
mharbison72 added a comment to D11307: run-tests: avoid silently switching the hg executable used.

Not sure that we want to take this as-is (even though it does avoid a bad problem outside of the internal tests). I'm hoping someone has some insight and saves me some time trial and erroring through this.

Aug 18 2021, 5:08 PM
mharbison72 created D11307: run-tests: avoid silently switching the hg executable used.
Aug 18 2021, 5:00 PM
mharbison72 created D11303: zeroconf: fix an issue concatenating bytes and str.
Aug 18 2021, 3:00 PM
mharbison72 added inline comments to D11286: pyoxidized: add a dedicated target in the tests.
Aug 18 2021, 12:07 AM
mharbison72 added inline comments to D11284: pyoxidized: adapt test-devel-warnings.t.
Aug 18 2021, 12:06 AM

Aug 10 2021

mharbison72 closed D11278: ci: run --pyoxidized tests on Windows.
Aug 10 2021, 10:08 AM
mharbison72 committed rHG9261326dd032: ci: run --pyoxidized tests on Windows.
ci: run --pyoxidized tests on Windows
Aug 10 2021, 10:08 AM
mharbison72 closed D11275: contrib: switch the Windows bootstrap environment to py3.9.
Aug 10 2021, 9:32 AM
mharbison72 committed rHG3b04e4746020: contrib: switch the Windows bootstrap environment to py3.9.
contrib: switch the Windows bootstrap environment to py3.9
Aug 10 2021, 9:32 AM
mharbison72 closed D11274: contrib: comment out the 64-bit py38 dependency installation on Windows.
Aug 10 2021, 9:32 AM
mharbison72 closed D11273: contrib: drop python2.7 from the Windows dependency install script.
Aug 10 2021, 9:32 AM
mharbison72 committed rHG7f220c6f3c81: contrib: drop python2.7 from the Windows dependency install script.
contrib: drop python2.7 from the Windows dependency install script
Aug 10 2021, 9:32 AM
mharbison72 committed rHG7a0d7c34e0ab: contrib: comment out the 64-bit py38 dependency installation on Windows.
contrib: comment out the 64-bit py38 dependency installation on Windows
Aug 10 2021, 9:32 AM
mharbison72 closed D11272: contrib: log the command and args for every process installing windows deps.
Aug 10 2021, 9:32 AM
mharbison72 committed rHGfb7d17496aca: contrib: log the command and args for every process installing windows deps.
contrib: log the command and args for every process installing windows deps
Aug 10 2021, 9:31 AM

Aug 9 2021

mharbison72 created D11275: contrib: switch the Windows bootstrap environment to py3.9.
Aug 9 2021, 8:46 PM
mharbison72 created D11274: contrib: comment out the 64-bit py38 dependency installation on Windows.
Aug 9 2021, 8:46 PM