Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User Details

User Since
Jul 16 2017, 3:10 PM (183 w, 3 d)

Recent Activity

Yesterday

mharbison72 added a comment to D9843: revlog: introduce v2 format.

Can we get space for extra flags for things not supported by the filesystem? I'm thinking specifically +x and symlink support on Windows.
https://www.mercurial-scm.org/wiki/DirState#Proposed_extensions

That would be a dirstate thing, not a revlog thing, right ?

Wed, Jan 20, 6:36 PM
mharbison72 added a comment to D9843: revlog: introduce v2 format.

Can we get space for extra flags for things not supported by the filesystem? I'm thinking specifically +x and symlink support on Windows.

Wed, Jan 20, 5:39 PM
mharbison72 added a comment to D9516: perf: use the `perf--` prefix for perf command.

Big picture, why do we need to be able to tell namespace parts from command parts?

To make sure the user understand they are stepping in an entire different realm with different rules.
In the standard namespace (no prefix) we garantee (or aims at) the lack of footgun and excellent backward compatibility.
The debug namespace should not be somewhere any normal user ever have to go (at least without a responsible staff member)
The admin namespace will have its own rules and its own "be careful, this is not a "normal" situation to be there.
So we want something more distincting than just a simple - that we could have for "command group" or readability like phab-send, phab-read, etc.

Wed, Jan 20, 5:32 PM
mharbison72 committed rHG47b11629a0f2: tests: skip a detailed exit status in test-lfs-test-server.
tests: skip a detailed exit status in test-lfs-test-server
Wed, Jan 20, 12:05 PM
D9842: tests: deal with more timing differences in output is now accepted and ready to land.
Wed, Jan 20, 10:57 AM
mharbison72 added a comment to D9836: tests: skip a detailed exit status in test-lfs-test-server.

Should this go on stable instead to make the test fixed on stable too?

Wed, Jan 20, 8:47 AM
mharbison72 closed D9836: tests: skip a detailed exit status in test-lfs-test-server.
Wed, Jan 20, 1:30 AM
mharbison72 committed rHG969554e2cfc7: tests: skip a detailed exit status in test-lfs-test-server.
tests: skip a detailed exit status in test-lfs-test-server
Wed, Jan 20, 1:30 AM
mharbison72 created D9836: tests: skip a detailed exit status in test-lfs-test-server.
Wed, Jan 20, 12:42 AM

Tue, Jan 19

mharbison72 added a comment to D9832: simplemerge: delete unused find_unconflicted().

Was its purpose to be used in the tests? (It probably should have been put there in that case, but maybe importing mdiff there is more complicated?)

I'm not sure I follow. Do you mean that the test conditions that I removed in this patch might be worth keeping the function for? I had assumed that the function existed because it was used somewhere in Bazaar, but I didn't check if it actually was.

Tue, Jan 19, 11:58 AM
mharbison72 added a comment to D9832: simplemerge: delete unused find_unconflicted().

Was its purpose to be used in the tests? (It probably should have been put there in that case, but maybe importing mdiff there is more complicated?)

Tue, Jan 19, 10:01 AM

Mon, Jan 18

mharbison72 added inline comments to D9516: perf: use the `perf--` prefix for perf command.
Mon, Jan 18, 11:49 PM
D9775: upgrade: update only requirements if we can is now accepted and ready to land.
Mon, Jan 18, 9:23 PM
D9774: engine: add `if True` to prepare for next patch is now accepted and ready to land.
Mon, Jan 18, 9:22 PM
D9773: test: unquiet few tests to demonstrate changes in upcoming patches now requires changes to proceed.
Mon, Jan 18, 9:22 PM
D9772: upgrade: mark sharesafe improvement as only touching requirements is now accepted and ready to land.
Mon, Jan 18, 9:19 PM
D9771: actions: calculate what all parts does the operation touches is now accepted and ready to land.
Mon, Jan 18, 9:19 PM
D9770: upgrade: don't create store backup if `--no-backup` is passed is now accepted and ready to land.
Mon, Jan 18, 9:16 PM
mharbison72 added a comment to D9769: share: add documentation about various configs introduced recently.

Is this one obsoleted by D9785, D9786 (and friends)?

Mon, Jan 18, 9:12 PM
D9823: share: move share safe functionality out of experimental is now accepted and ready to land.

Queued with some minor copyediting, thanks

Mon, Jan 18, 9:08 PM
D9786: share: rename share-safe warning config is now accepted and ready to land.
Mon, Jan 18, 9:08 PM
D9785: share: rework config options to be much clearer and easier is now accepted and ready to land.
Mon, Jan 18, 9:08 PM
D9784: localrepo: disallow share if there is a version mismatch by default is now accepted and ready to land.
Mon, Jan 18, 9:08 PM
D9822: upgrade: re-read current requirements after taking lock is now accepted and ready to land.
Mon, Jan 18, 9:08 PM
D9783: upgrade: take lock only for part where it's required is now accepted and ready to land.
Mon, Jan 18, 9:08 PM
mharbison72 added inline comments to D9785: share: rework config options to be much clearer and easier.
Mon, Jan 18, 8:43 PM
D9829: clang-format: reorder includes to appease the formatter is now accepted and ready to land.
Mon, Jan 18, 1:28 PM
mharbison72 closed D9815: run-tests: work around the Windows firewall popup for server processes.
Mon, Jan 18, 9:38 AM
mharbison72 closed D9816: run-tests: catch a Windows specific error when testing for a free socket.
Mon, Jan 18, 9:38 AM
mharbison72 closed D9814: hghave: split apart testing for the curses module and `tic` executable.
Mon, Jan 18, 9:38 AM
mharbison72 committed rHG85c0c7145f8e: run-tests: catch a Windows specific error when testing for a free socket.
run-tests: catch a Windows specific error when testing for a free socket
Mon, Jan 18, 9:38 AM
mharbison72 committed rHG3e23794b9e1c: run-tests: work around the Windows firewall popup for server processes.
run-tests: work around the Windows firewall popup for server processes
Mon, Jan 18, 9:38 AM
mharbison72 committed rHGe5e6282fa66a: hghave: split apart testing for the curses module and `tic` executable.
hghave: split apart testing for the curses module and `tic` executable
Mon, Jan 18, 9:38 AM
mharbison72 created D9815: run-tests: work around the Windows firewall popup for server processes.
Mon, Jan 18, 1:45 AM
mharbison72 created D9816: run-tests: catch a Windows specific error when testing for a free socket.
Mon, Jan 18, 1:45 AM
mharbison72 created D9814: hghave: split apart testing for the curses module and `tic` executable.
Mon, Jan 18, 1:45 AM

Sun, Jan 17

D9792: heptapod-ci: allow testing with docker image other than :latest is now accepted and ready to land.
Sun, Jan 17, 5:20 PM
D9784: localrepo: disallow share if there is a version mismatch by default now requires changes to proceed.
Sun, Jan 17, 5:19 PM
D9809: persistent-nodemap: catch the right exception on python is now accepted and ready to land.
Sun, Jan 17, 5:05 PM
D9810: persistent-nodemap: also exchange the nodemap data over the wire is now accepted and ready to land.
Sun, Jan 17, 5:05 PM
mharbison72 created D9811: tagcache: distinguish between invalid and missing entries.
Sun, Jan 17, 4:55 PM
mharbison72 created D9812: tests: demonstrate a case where a corrupt tag cache causes an abort.
Sun, Jan 17, 4:54 PM
mharbison72 closed D9808: hghave: adjust the definition of `tic` to allow curses tests on Windows.
Sun, Jan 17, 1:45 PM
mharbison72 committed rHGef771d329961: hghave: adjust the definition of `tic` to allow curses tests on Windows.
hghave: adjust the definition of `tic` to allow curses tests on Windows
Sun, Jan 17, 1:45 PM
mharbison72 committed rHG3dfebba99ef6: windows: wrap `os.getcwd()` in `os.path.realpath()` on py3.
windows: wrap `os.getcwd()` in `os.path.realpath()` on py3
Sun, Jan 17, 1:45 PM
mharbison72 closed D9806: windows: wrap `os.getcwd()` in `os.path.realpath()` on py3.
Sun, Jan 17, 1:45 PM
mharbison72 closed D9805: packaging: include `windows-curses` on Windows.
Sun, Jan 17, 1:45 PM
mharbison72 closed D9804: cext: fix compiler error in revlog.c on Windows with py2.
Sun, Jan 17, 1:45 PM
mharbison72 committed rHGe74274fc1b35: packaging: include `windows-curses` on Windows.
packaging: include `windows-curses` on Windows
Sun, Jan 17, 1:45 PM
mharbison72 committed rHGd0225a22040c: cext: fix compiler error in revlog.c on Windows with py2.
cext: fix compiler error in revlog.c on Windows with py2
Sun, Jan 17, 1:44 PM
mharbison72 created D9808: hghave: adjust the definition of `tic` to allow curses tests on Windows.
Sun, Jan 17, 2:52 AM
mharbison72 added a comment to D9807: tests: stabilize the output of test-shelve2.t.

The source of the failure was amended in place.

Sun, Jan 17, 2:29 AM
mharbison72 created D9807: tests: stabilize the output of test-shelve2.t.
Sun, Jan 17, 2:19 AM
mharbison72 created D9806: windows: wrap `os.getcwd()` in `os.path.realpath()` on py3.
Sun, Jan 17, 2:18 AM
mharbison72 created D9805: packaging: include `windows-curses` on Windows.
Sun, Jan 17, 2:18 AM

Sat, Jan 16

mharbison72 created D9804: cext: fix compiler error in revlog.c on Windows with py2.
Sat, Jan 16, 9:38 PM
D9789: clone: make sure we warm the cache after a clone is now accepted and ready to land.
Sat, Jan 16, 9:26 PM
D9803: test-regression: backing out D9640 (63c923fd7fa8) is now accepted and ready to land.
Sat, Jan 16, 9:26 PM
mharbison72 added inline comments to D9601: errors: use detailed exit code 50 for StorageError.
Sat, Jan 16, 8:30 PM

Wed, Jan 13

D9722: setup: don't import distutils prior to checking FORCE_SETUPTOOLS is now accepted and ready to land.

make -C .. local PYTHON="py -3.9" on Windows was enough to trigger if for me all the time.

Wed, Jan 13, 12:21 PM
D9747: largefiles: remove unused imports is now accepted and ready to land.
Wed, Jan 13, 12:18 PM
D9695: upgrade: don't perform anything if nothing to do is now accepted and ready to land.
Wed, Jan 13, 12:11 PM
D9693: downgrade: if a compression is removed, consider that too is now accepted and ready to land.
Wed, Jan 13, 12:11 PM
D9673: engine: prevent a function call for each store file is now accepted and ready to land.
Wed, Jan 13, 12:11 PM

Tue, Jan 12

mharbison72 added a comment to D9472: testing phabricator encoding.

I'm honored to be the mojibake test. ;)

:)
@mharbison72: I'm not doing anything more with this test. Are you or should I drop this patch? I'll at least mark it "Plan Changes" for now.

Tue, Jan 12, 11:33 PM
D9676: upgrade: migrated -> upgraded in ui messages is now accepted and ready to land.
Tue, Jan 12, 8:51 PM
D9675: upgrade: remove unnecessary `is None` check is now accepted and ready to land.
Tue, Jan 12, 8:51 PM
D9694: upgrade: demonstrate that a no-op upgrade still performs everything is now accepted and ready to land.
Tue, Jan 12, 8:51 PM
mharbison72 added inline comments to D9694: upgrade: demonstrate that a no-op upgrade still performs everything.
Tue, Jan 12, 8:50 PM
D9695: upgrade: don't perform anything if nothing to do now requires changes to proceed.

I get test failures with this:

Tue, Jan 12, 8:48 PM
mharbison72 added a comment to D9677: upgrade: use copy+delete instead of rename while creating backup.

As pointed in a pa previous comment, this is problematic, because this does not preserve the same consistency as the previous code

While the copy consistency can be maintained here, future changes (WIP) will break the consistency more. In upcoming work, we want to only touch parts of repository which needs to be updated. This will lead us to do selectively moving data from the upgraded repository to the current one.

Tue, Jan 12, 8:20 PM
D9693: downgrade: if a compression is removed, consider that too now requires changes to proceed.
Tue, Jan 12, 8:11 PM
D9673: engine: prevent a function call for each store file now requires changes to proceed.

Oops, typo on my end with phabupdate. I still wanted to flag the new return statement.

Tue, Jan 12, 6:47 PM
D9666: actions: store deltareuse mode of whole operation in UpgradeOperation is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9665: engine: refactor how total dstsize is calculated is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9619: upgrade: introduce post upgrade and downgrade message for improvements is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9618: actions: introduce function to calculate downgrades is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9617: debugupgraderepo: minor documentation fix is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9672: engine: make hook point for extension a public function is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9616: upgrade: rename actions to upgrade_actions is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9669: engine: prevent multiple checking of re-delta-multibase is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9673: engine: prevent a function call for each store file is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9668: engine: pass upgrade operation inside `_perform_clone()` is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9615: upgrade: move optimization addition to determineactions() is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9614: upgrade: drop support for old style optimization names is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9583: upgrade: add a missing space in status message is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9664: actions: rename DEFICIENCY constant to FORMAT_VARIANT is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9582: upgrade: rename finddeficiences() to find_format_upgrades() is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9667: engine: pass upgrade operation inside _clonerevlogs() is now accepted and ready to land.
Tue, Jan 12, 6:45 PM
D9673: engine: prevent a function call for each store file now requires changes to proceed.
Tue, Jan 12, 6:39 PM

Tue, Jan 5

mharbison72 accepted D9579: engine: refactor actual cloning code into separate function.
Tue, Jan 5, 10:34 AM
D9580: engine: unwrap a hard to understand for loop is now accepted and ready to land.
Tue, Jan 5, 10:34 AM
D9578: upgrade: move printing of unused optimizations to UpgradeOperation class is now accepted and ready to land.
Tue, Jan 5, 10:34 AM
D9577: upgrade: move `printrequirements()` to UpgradeOperation class is now accepted and ready to land.
Tue, Jan 5, 10:34 AM
D9575: upgrade: move `printupgradeactions()` to UpgradeOperation class is now accepted and ready to land.
Tue, Jan 5, 10:34 AM
D9576: upgrade: move `printoptimisations() to UpgradeOperation class is now accepted and ready to land.
Tue, Jan 5, 10:34 AM
D9574: upgrade: move `print_affected_revlogs()` to UpgradeOperation class is now accepted and ready to land.
Tue, Jan 5, 10:34 AM

Dec 21 2020

mharbison72 closed D9635: mergetools: add BeyondCompare 4 for Windows.
Dec 21 2020, 1:36 PM
mharbison72 committed rHGdbc462e34e92: mergetools: add BeyondCompare 4 for Windows.
mergetools: add BeyondCompare 4 for Windows
Dec 21 2020, 1:36 PM
mharbison72 committed rHG968766c1a324: mergetools: add support for 32-bit BeyondCompare 3 on 64-bit Windows.
mergetools: add support for 32-bit BeyondCompare 3 on 64-bit Windows
Dec 21 2020, 1:36 PM