Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (136 w, 3 d)

Recent Activity

Today

mharbison72 added a comment to D7967: exchange: recognize changegroup3 bundles in `getbundlespec()`.

I can confirm the spec version number are different to the changegroup version number. For the rest. I'll try to have a look soon.

Wed, Feb 26, 2:53 PM
mharbison72 created D8170: phabricator: update the protocol documentation.
Wed, Feb 26, 2:51 PM
mharbison72 closed D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Wed, Feb 26, 5:51 AM
mharbison72 committed rHGca82929e433d: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
lfutil: provide a hint if the largefiles/lfs cache path cannot be determined
Wed, Feb 26, 5:51 AM

Yesterday

mharbison72 added a comment to D8148: revlog-compression: update the config to be a list.

LGTM, thanks for the update.

Tue, Feb 25, 6:58 PM
D8148: revlog-compression: update the config to be a list now requires changes to proceed.
Tue, Feb 25, 12:45 PM
mharbison72 closed D8142: setup: exclude the __index__ module from itself when generating.
Tue, Feb 25, 10:10 AM
mharbison72 committed rHGbb58931d0c4f: setup: exclude the __index__ module from itself when generating.
setup: exclude the __index__ module from itself when generating
Tue, Feb 25, 10:09 AM
mharbison72 closed D8144: tests: stabilize test-amend.t on Windows.
Tue, Feb 25, 10:09 AM
mharbison72 committed rHG1813f79017ac: tests: stabilize test-amend.t on Windows.
tests: stabilize test-amend.t on Windows
Tue, Feb 25, 10:09 AM
mharbison72 closed D8147: tests: replace truncate(1) with inline python.
Tue, Feb 25, 9:53 AM
mharbison72 committed rHG56f089e40c5a: tests: replace truncate(1) with inline python.
tests: replace truncate(1) with inline python
Tue, Feb 25, 9:53 AM
mharbison72 closed D8146: tests: stabilize test-rename-merge2.t on Windows.
Tue, Feb 25, 9:53 AM
mharbison72 committed rHG35d2afc6966a: tests: stabilize test-rename-merge2.t on Windows.
tests: stabilize test-rename-merge2.t on Windows
Tue, Feb 25, 9:53 AM
mharbison72 updated the diff for D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Tue, Feb 25, 9:37 AM
mharbison72 added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Makes sense for why it was missed, but I bisected it back to the referenced commit. I know @martinvonz made some other related changes prior to that commit that had similar test fallout on Windows, but it isn't obvious to me why the referenced commit would change the order of when the background thread spins up.

Perhaps the line doesn't actually happen before that commit? You can try removing the (?) in the commit before my commit and see if that line is actually printed. I'm thinking that that commit pushed the number of files to close above some threshold that made it get printed. In that case, it was probably some of my earlier commits that made it no longer get printed and we just didn't notice since (?) means optional (no error if it doesn't get printed).

Tue, Feb 25, 1:01 AM

Mon, Feb 24

mharbison72 updated the summary of D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Mon, Feb 24, 8:20 PM
mharbison72 updated subscribers of D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Mon, Feb 24, 6:55 PM
mharbison72 added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Could we get a test for this? To make sure the hint looks fine and that the error code does not crash ?

Mon, Feb 24, 6:52 PM
mharbison72 created D8147: tests: replace truncate(1) with inline python.
Mon, Feb 24, 5:47 PM
mharbison72 created D8146: tests: stabilize test-rename-merge2.t on Windows.
Mon, Feb 24, 5:47 PM
mharbison72 created D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Mon, Feb 24, 5:47 PM
mharbison72 added a comment to D8144: tests: stabilize test-amend.t on Windows.

This is meant for stable. The other test fixes I'll submit shortly are for default.

Mon, Feb 24, 4:54 PM
mharbison72 created D8144: tests: stabilize test-amend.t on Windows.
Mon, Feb 24, 4:39 PM
mharbison72 created D8142: setup: exclude the __index__ module from itself when generating.
Mon, Feb 24, 12:35 AM

Fri, Feb 21

mharbison72 closed D8126: import: don't ignore `--secret` when `--bypass` is specified.
Fri, Feb 21, 4:56 AM
mharbison72 closed D8133: phabricator: fix a phabsend crash when processing a renamed binary.
Fri, Feb 21, 4:55 AM
mharbison72 committed rHGb339faf3f843: import: don't ignore `--secret` when `--bypass` is specified.
import: don't ignore `--secret` when `--bypass` is specified
Fri, Feb 21, 4:55 AM
mharbison72 committed rHGd1177d39012e: phabricator: fix a phabsend crash when processing a renamed binary.
phabricator: fix a phabsend crash when processing a renamed binary
Fri, Feb 21, 4:55 AM
mharbison72 added a comment to D8137: phabricator: add a config knob to import in the secret phase.

This needs D8126 (which I assume is going to end up on stable) to pass.

Fri, Feb 21, 12:00 AM

Thu, Feb 20

mharbison72 created D8136: phabricator: add a `phabimport` command.
Thu, Feb 20, 8:10 PM
mharbison72 created D8137: phabricator: add a config knob to import in the secret phase.
Thu, Feb 20, 8:10 PM
mharbison72 created D8138: phabricator: add a config knob to create obsolete markers when importing.
Thu, Feb 20, 8:10 PM
mharbison72 created D8135: phabricator: refactor `phabread` to write all patches at once.
Thu, Feb 20, 8:10 PM

Tue, Feb 18

mharbison72 created D8133: phabricator: fix a phabsend crash when processing a renamed binary.
Tue, Feb 18, 3:59 PM
mharbison72 added a comment to D8132: copy+mod moved binary.

Generating test recordings

Tue, Feb 18, 1:48 PM
mharbison72 added a comment to D8131: move+mod copied binary.

Generating test recordings

Tue, Feb 18, 1:48 PM
mharbison72 added a comment to D8130: copied binary.

Generating test recodings

Tue, Feb 18, 1:47 PM
mharbison72 added a comment to D8129: moved binary.

Generating test recodings

Tue, Feb 18, 1:47 PM
mharbison72 added a comment to D8128: add another binary.

Generating test recodings

Tue, Feb 18, 1:47 PM
mharbison72 created D8132: copy+mod moved binary.
Tue, Feb 18, 1:43 PM
mharbison72 created D8131: move+mod copied binary.
Tue, Feb 18, 1:43 PM
mharbison72 created D8130: copied binary.
Tue, Feb 18, 1:43 PM
mharbison72 created D8129: moved binary.
Tue, Feb 18, 1:43 PM
mharbison72 created D8128: add another binary.
Tue, Feb 18, 1:43 PM

Sun, Feb 16

mharbison72 created D8126: import: don't ignore `--secret` when `--bypass` is specified.
Sun, Feb 16, 5:26 PM

Sat, Feb 15

mharbison72 added a comment to D8122: pyoxidizer: allow extensions to be loaded from the file system.

Does this also allow extensions to be bundled in the exe, or are you thinking we need to leave the extensions outside the binary?

Sat, Feb 15, 1:00 AM

Wed, Feb 12

mharbison72 added a comment to D6846: packaging: script the building of a MacOS installer using a custom python.

macOS supports a @loader_path and related magic tokens in rpath to load libraries relative to the current binary. See e.g. https://blogs.oracle.com/dipol/dynamic-libraries,-rpath,-and-mac-os and https://medium.com/@donblas/fun-with-rpath-otool-and-install-name-tool-e3e41ae86172 for examples.

Wed, Feb 12, 11:59 AM

Mon, Feb 10

mharbison72 added a comment to D7960: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar.

I forgot to reply to this last week- I was concerned when the subsequent part of the stack went in without suppressing the per file progress bars here, that the displayed progress bar would be bouncing around randomly. But it wasn't- it was ever increasing like only the main bar was being changed. Any ideas why that would be?

Mon, Feb 10, 6:55 PM
mharbison72 committed rHG0e8b28fb751b: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar.
httpconnection: allow `httpsendfile` subclasses to suppress the progressbar
Mon, Feb 10, 5:01 PM
mharbison72 closed D7960: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar.
Mon, Feb 10, 5:01 PM
mharbison72 closed D8099: lfs: use str for the open() mode when opening a blob for py3.
Mon, Feb 10, 5:01 PM
mharbison72 committed rHG234001d22ba6: lfs: use str for the open() mode when opening a blob for py3.
lfs: use str for the open() mode when opening a blob for py3
Mon, Feb 10, 5:01 PM
mharbison72 added a comment to D8099: lfs: use str for the open() mode when opening a blob for py3.

This one fails to apply on tip of stable branch. Can you rebase and resend?

Mon, Feb 10, 1:57 PM
mharbison72 closed D8053: pyoxidizer: use `legacy_windows_stdio` on Windows.
Mon, Feb 10, 1:01 PM
mharbison72 committed rHGcd8f248fead4: pyoxidizer: use `legacy_windows_stdio` on Windows.
pyoxidizer: use `legacy_windows_stdio` on Windows
Mon, Feb 10, 1:01 PM

Sat, Feb 8

mharbison72 added a comment to D7517: filemerge: byteify the open() mode.

The py3 breakage fixed by D8099 convinced me that this is going in the wrong direction.

Sat, Feb 8, 11:49 PM
mharbison72 created D8099: lfs: use str for the open() mode when opening a blob for py3.
Sat, Feb 8, 11:48 PM

Fri, Feb 7

mharbison72 committed rHG877805928f85: exchange: check the `ui.clonebundleprefers` form while processing (issue6257).
exchange: check the `ui.clonebundleprefers` form while processing (issue6257)
Fri, Feb 7, 5:15 PM
mharbison72 closed D7969: exchange: check the `ui.clonebundleprefers` form while processing (issue6257).
Fri, Feb 7, 4:38 PM
mharbison72 committed rHG5fb0592f90e7: exchange: check the `ui.clonebundleprefers` form while processing (issue6257).
exchange: check the `ui.clonebundleprefers` form while processing (issue6257)
Fri, Feb 7, 4:38 PM
mharbison72 updated the diff for D7969: exchange: check the `ui.clonebundleprefers` form while processing (issue6257).
Fri, Feb 7, 9:59 AM

Thu, Feb 6

mharbison72 closed D7963: lfs: enable workers by default.
Thu, Feb 6, 5:21 PM
mharbison72 committed rHG87167caa2989: lfs: enable workers by default.
lfs: enable workers by default
Thu, Feb 6, 5:21 PM
mharbison72 committed rHG43eea17ae7b3: lfs: fix the stall and corruption issue when concurrently uploading blobs.
lfs: fix the stall and corruption issue when concurrently uploading blobs
Thu, Feb 6, 5:20 PM
mharbison72 closed D7962: lfs: fix the stall and corruption issue when concurrently uploading blobs.
Thu, Feb 6, 5:20 PM
mharbison72 committed rHG06de4a673f48: lfs: add a method to the local blobstore to convert OIDs to file paths.
lfs: add a method to the local blobstore to convert OIDs to file paths
Thu, Feb 6, 5:20 PM
mharbison72 closed D7961: lfs: add a method to the local blobstore to convert OIDs to file paths.
Thu, Feb 6, 5:20 PM
mharbison72 added inline comments to D8089: py3: __repr__ needs to return str, not bytes.
Thu, Feb 6, 3:34 PM

Wed, Feb 5

mharbison72 added a comment to D6846: packaging: script the building of a MacOS installer using a custom python.

are we talking about python library or compiled library ? Go you have any "empty" item in the various PATH used for the build ?

Wed, Feb 5, 9:28 PM
mharbison72 requested review of D7969: exchange: check the `ui.clonebundleprefers` form while processing (issue6257).
Wed, Feb 5, 9:21 PM
mharbison72 added a comment to D7960: httpconnection: allow `httpsendfile` subclasses to suppress the progressbar.

This is very unappealling ☹ could we update the total value in case authentication is needed instead ?

Wed, Feb 5, 9:12 PM

Mon, Feb 3

mharbison72 committed rHG847e582f3cc9: packaging: make the path to Win32 requirements absolute when building WiX.
packaging: make the path to Win32 requirements absolute when building WiX
Mon, Feb 3, 10:10 PM
mharbison72 closed D8068: packaging: make the path to Win32 requirements absolute when building WiX.
Mon, Feb 3, 10:10 PM
mharbison72 created D8068: packaging: make the path to Win32 requirements absolute when building WiX.
Mon, Feb 3, 8:21 PM
mharbison72 added a comment to D8044: packaging: include __init__.py in `defaultrc` and `helptext` on Windows.

Obsoleted by D8058, which stops treating these as resources with py2exe.

Mon, Feb 3, 1:34 AM

Sun, Feb 2

mharbison72 closed D8063: packaging: lowercase the `contrib` and `templates` directories with Inno.
Sun, Feb 2, 12:24 PM
mharbison72 committed rHG4aedef6d51ad: packaging: lowercase the `contrib` and `templates` directories with Inno.
packaging: lowercase the `contrib` and `templates` directories with Inno
Sun, Feb 2, 12:24 PM
mharbison72 closed D8066: packaging: merge the requirements.txt files for WiX and Inno.
Sun, Feb 2, 12:24 PM
mharbison72 committed rHGe2589b9e4562: packaging: merge the requirements.txt files for WiX and Inno.
packaging: merge the requirements.txt files for WiX and Inno
Sun, Feb 2, 12:24 PM
mharbison72 created D8066: packaging: merge the requirements.txt files for WiX and Inno.
Sun, Feb 2, 12:58 AM
mharbison72 added a comment to D8063: packaging: lowercase the `contrib` and `templates` directories with Inno.

I just did Inno 5.0.2 -> current Inno without uninstalling, and I didn't see any errors. In this case, it preserves the existing capitalized names. But since we renamed help -> helptext, hgrc.d -> defaultrc, and since the previous installer cleanup this cycle did some things like rename Docs -> doc, it's probably a good idea to uninstall before upgrading. That said, it seemed like a functional installation (version and debuginstall worked). A subsequent uninstall removed the entire mess, not just the newly dropped files.

Sun, Feb 2, 12:19 AM

Sat, Feb 1

mharbison72 closed D8062: packaging: bundle dulwich, keyring, and pywin32-ctypes with WiX too.
Sat, Feb 1, 7:00 PM
mharbison72 closed D8060: packaging: set the FileVersion field in the Inno installer executable.
Sat, Feb 1, 7:00 PM
mharbison72 closed D8061: packaging: bundle the default mercurial.ini template with Inno also.
Sat, Feb 1, 7:00 PM
mharbison72 committed rHG481caa4a2244: packaging: bundle dulwich, keyring, and pywin32-ctypes with WiX too.
packaging: bundle dulwich, keyring, and pywin32-ctypes with WiX too
Sat, Feb 1, 7:00 PM
mharbison72 committed rHGa8786727e478: packaging: bundle the default mercurial.ini template with Inno also.
packaging: bundle the default mercurial.ini template with Inno also
Sat, Feb 1, 7:00 PM
mharbison72 closed D8059: packaging: move the version normalization function to the util module.
Sat, Feb 1, 7:00 PM
mharbison72 committed rHGf37971c31067: packaging: set the FileVersion field in the Inno installer executable.
packaging: set the FileVersion field in the Inno installer executable
Sat, Feb 1, 7:00 PM
mharbison72 committed rHGa70108a3d7cc: packaging: move the version normalization function to the util module.
packaging: move the version normalization function to the util module
Sat, Feb 1, 7:00 PM
mharbison72 committed rHGaab70b540d3d: resourceutil: account for the non-resource-like file hierarchy under py2exe.
resourceutil: account for the non-resource-like file hierarchy under py2exe
Sat, Feb 1, 7:00 PM
mharbison72 closed D8058: resourceutil: account for the non-resource-like file hierarchy under py2exe.
Sat, Feb 1, 7:00 PM
mharbison72 committed rHGf010a80ec967: wix: restore COPYING.rtf.
wix: restore COPYING.rtf
Sat, Feb 1, 7:00 PM
mharbison72 closed D8052: wix: restore COPYING.rtf.
Sat, Feb 1, 7:00 PM
mharbison72 created D8062: packaging: bundle dulwich, keyring, and pywin32-ctypes with WiX too.
Sat, Feb 1, 1:48 AM
mharbison72 created D8063: packaging: lowercase the `contrib` and `templates` directories with Inno.
Sat, Feb 1, 1:48 AM
mharbison72 created D8061: packaging: bundle the default mercurial.ini template with Inno also.
Sat, Feb 1, 1:48 AM
mharbison72 created D8060: packaging: set the FileVersion field in the Inno installer executable.
Sat, Feb 1, 1:48 AM
mharbison72 created D8059: packaging: move the version normalization function to the util module.
Sat, Feb 1, 1:48 AM

Fri, Jan 31

mharbison72 added a comment to D7173: packaging: stage files and dynamically generate WiX installer.

This change also means that Inno and WiX are now using very similar code for managing the install layout. This means that on disk both packages are nearly identical. The differences in install layout are as follows:
...

Fri, Jan 31, 11:38 PM