Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (125 w, 4 d)

Recent Activity

Yesterday

mharbison72 added inline comments to D7622: help: get helptext/ data from `resources` module if available.
Thu, Dec 12, 11:35 PM
mharbison72 added a comment to D7627: config: drop debug messages saying where config was read from.

On Windows, you can set a registry key to one or more *.ini files or directories that get read in, so it seems slightly handy to know the order in which files are processed. I know I've used that mechanism on various systems to find directories in which to stash things too.

Thu, Dec 12, 11:29 PM
mharbison72 added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#112206, @yuja wrote:
@yuja, what do you think?

I'm okay with this, but I would add "# TODO:" comment to subrepo handling
so future readers can see the problem. And one more nit: since cwd=b'' is
a valid path, we have to test cwd is None explicitly.

Thu, Dec 12, 9:13 PM
mharbison72 updated the diff for D7570: match: resolve filesets against the passed `cwd`, not the current one.
Thu, Dec 12, 9:01 PM
mharbison72 added a comment to D7617: fix: make example fix hgrc work in subdirs.

See D7065 and D7570. I didn't realize you could stack set: and the other patterns like this.

Thu, Dec 12, 5:54 PM
mharbison72 created D7616: exchange: ensure all outgoing subrepo references are present before pushing.
Thu, Dec 12, 1:54 PM
mharbison72 closed D7608: phabricator: color the status in the "phabstatus" view.
Thu, Dec 12, 7:52 AM
mharbison72 closed D7607: phabricator: add the "Changes Planned" status name.
Thu, Dec 12, 7:52 AM
mharbison72 committed rHGb0867b7751ba: phabricator: color the status in the "phabstatus" view.
phabricator: color the status in the "phabstatus" view
Thu, Dec 12, 7:52 AM
mharbison72 committed rHG74ec6ca0eb75: phabricator: add the "Changes Planned" status name.
phabricator: add the "Changes Planned" status name
Thu, Dec 12, 7:52 AM

Wed, Dec 11

mharbison72 created D7608: phabricator: color the status in the "phabstatus" view.
Wed, Dec 11, 11:24 PM
mharbison72 created D7607: phabricator: add the "Changes Planned" status name.
Wed, Dec 11, 11:24 PM
mharbison72 added a comment to D7517: filemerge: byteify the open() mode.

I'm a little fuzzy on this: should I see some test failures? or...?

Wed, Dec 11, 5:58 PM
mharbison72 closed D7465: filemerge: fix a missing attribute usage.
Wed, Dec 11, 1:30 PM
mharbison72 closed D7464: filemerge: drop a default argument to appease pytype.
Wed, Dec 11, 1:30 PM
mharbison72 committed rHGd5ce99a6db52: filemerge: fix a missing attribute usage.
filemerge: fix a missing attribute usage
Wed, Dec 11, 1:30 PM
mharbison72 committed rHG1ffbd03c8d75: filemerge: drop a default argument to appease pytype.
filemerge: drop a default argument to appease pytype
Wed, Dec 11, 1:30 PM
mharbison72 added inline comments to D7601: fuzz: fix test-fuzz-targets.t to run with python3.
Wed, Dec 11, 10:20 AM
mharbison72 added a comment to D7570: match: resolve filesets against the passed `cwd`, not the current one.
In D7570#111295, @yuja wrote:
if listsubrepos:
    for subpath in ctx.substate:
  • sm = ctx.sub(subpath).matchfileset(pat, badfn=badfn)

+ sm = ctx.sub(subpath).matchfileset(
+ pat, badfn=badfn, cwd=cwd
+ )

Might have to adjust cwd since it may be relative to the parent's repo.root.

Wed, Dec 11, 9:48 AM

Tue, Dec 10

mharbison72 closed D7572: tests: stabilize test-extdiff.t on Windows.
Tue, Dec 10, 10:45 AM
mharbison72 committed rHGfb03cd716f50: tests: stabilize test-extdiff.t on Windows.
tests: stabilize test-extdiff.t on Windows
Tue, Dec 10, 10:45 AM
mharbison72 committed rHGea97cd64c500: exchange: fix an attempt to format a list into bytes.
exchange: fix an attempt to format a list into bytes
Tue, Dec 10, 10:45 AM
mharbison72 closed D7583: exchange: fix an attempt to format a list into bytes.
Tue, Dec 10, 10:45 AM

Sat, Dec 7

mharbison72 created D7583: exchange: fix an attempt to format a list into bytes.
Sat, Dec 7, 10:12 PM

Fri, Dec 6

mharbison72 created D7572: tests: stabilize test-extdiff.t on Windows.
Fri, Dec 6, 11:49 PM
mharbison72 updated subscribers of D7570: match: resolve filesets against the passed `cwd`, not the current one.

CC: @martinvonz

Fri, Dec 6, 10:44 PM
mharbison72 created D7570: match: resolve filesets against the passed `cwd`, not the current one.
Fri, Dec 6, 10:16 PM
mharbison72 created D7569: tests: show that fileset patterns don't work with `fix` when not in repo root.
Fri, Dec 6, 10:15 PM

Wed, Dec 4

mharbison72 accepted D7544: subrepo: use pycompat.open directly instead of importing open from pycompat.
Wed, Dec 4, 7:32 AM

Tue, Dec 3

mharbison72 added a comment to D7545: py3: make a pycompat.osdevnull, use it in extdiff.

LGTM

Tue, Dec 3, 11:56 PM
mharbison72 added a comment to D7544: subrepo: use pycompat.open directly instead of importing open from pycompat.

I don't think this is correct, because open is imported from pycompat at the top of the file, and that will sysstr() the mode. But this does seem confusing- see D7517.

Tue, Dec 3, 11:51 PM
mharbison72 committed rHGbe8552f25cab: cleanup: fix docstring formatting.
cleanup: fix docstring formatting
Tue, Dec 3, 10:59 AM
mharbison72 committed rHG44b605638918: exchange: guard against method invocation on `b2caps=None` args.
exchange: guard against method invocation on `b2caps=None` args
Tue, Dec 3, 10:59 AM
mharbison72 committed rHGfe73ec69350e: windows: suppress pytype warnings for Windows imports and functions.
windows: suppress pytype warnings for Windows imports and functions
Tue, Dec 3, 10:59 AM
mharbison72 committed rHG27c6d6f53d46: exchange: eliminate some bytes.format() calls.
exchange: eliminate some bytes.format() calls
Tue, Dec 3, 10:59 AM

Mon, Dec 2

mharbison72 added a comment to D7521: amend: check for file modifications when updating dirstate (issue6233).

Windows is happy with this test

Mon, Dec 2, 6:51 PM
mharbison72 closed D7539: cleanup: fix docstring formatting.
Mon, Dec 2, 5:04 PM
mharbison72 committed rHGc190f2715277: cleanup: fix docstring formatting.
cleanup: fix docstring formatting
Mon, Dec 2, 5:00 PM
mharbison72 committed rHGa50fecefa691: windows: fix an issue causing registry config paths to be ignored on py3.
windows: fix an issue causing registry config paths to be ignored on py3
Mon, Dec 2, 5:00 PM
mharbison72 closed D7532: windows: fix an issue causing registry config paths to be ignored on py3.
Mon, Dec 2, 5:00 PM
mharbison72 closed D7536: histedit: fix an `isinstance(nodelist, str)` check for py3.
Mon, Dec 2, 4:56 PM
mharbison72 closed D7537: githelp: fix a `str` type conditional for py3.
Mon, Dec 2, 4:56 PM
mharbison72 closed D7534: hgweb: fix a few `str` type conditional for py3.
Mon, Dec 2, 4:56 PM
mharbison72 committed rHG10662ac7849e: pvec: fix a `str` type conditional for py3.
pvec: fix a `str` type conditional for py3
Mon, Dec 2, 4:55 PM
mharbison72 closed D7538: pvec: fix a `str` type conditional for py3.
Mon, Dec 2, 4:55 PM
mharbison72 committed rHG24d0189238f1: githelp: fix a `str` type conditional for py3.
githelp: fix a `str` type conditional for py3
Mon, Dec 2, 4:55 PM
mharbison72 committed rHG40db695040eb: histedit: fix an `isinstance(nodelist, str)` check for py3.
histedit: fix an `isinstance(nodelist, str)` check for py3
Mon, Dec 2, 4:55 PM
mharbison72 closed D7535: win32mbcs: fix a `str` type conditional for py3.
Mon, Dec 2, 4:55 PM
mharbison72 committed rHG66210a20f727: win32mbcs: fix a `str` type conditional for py3.
win32mbcs: fix a `str` type conditional for py3
Mon, Dec 2, 4:55 PM
mharbison72 committed rHG6ff1a0d109c9: hgweb: fix a few `str` type conditional for py3.
hgweb: fix a few `str` type conditional for py3
Mon, Dec 2, 4:55 PM
mharbison72 committed rHG8accf5fa9930: repair: fix an `isinstance(nodelist, str)` check for py3.
repair: fix an `isinstance(nodelist, str)` check for py3
Mon, Dec 2, 4:55 PM
mharbison72 closed D7533: repair: fix an `isinstance(nodelist, str)` check for py3.
Mon, Dec 2, 4:55 PM
mharbison72 accepted D7540: tests: cover revision conversion logic in githelp tests.
Mon, Dec 2, 12:44 PM
D7521: amend: check for file modifications when updating dirstate (issue6233) now requires changes to proceed.
Mon, Dec 2, 9:47 AM

Sun, Dec 1

mharbison72 created D7539: cleanup: fix docstring formatting.
Sun, Dec 1, 7:13 PM
mharbison72 updated the diff for D7465: filemerge: fix a missing attribute usage.
Sun, Dec 1, 4:58 PM
mharbison72 added a comment to D7464: filemerge: drop a default argument to appease pytype.
In D7464#109795, @dlax wrote:

Shouldn't this be also done for all similar functions? (i.e. _xmergeimm and functions registered as a merge tool with @internaltool)

Sun, Dec 1, 1:38 PM

Sat, Nov 30

mharbison72 created D7536: histedit: fix an `isinstance(nodelist, str)` check for py3.
Sat, Nov 30, 12:09 PM
mharbison72 created D7537: githelp: fix a `str` type conditional for py3.
Sat, Nov 30, 12:09 PM
mharbison72 created D7538: pvec: fix a `str` type conditional for py3.
Sat, Nov 30, 12:09 PM
mharbison72 created D7534: hgweb: fix a few `str` type conditional for py3.
Sat, Nov 30, 12:09 PM
mharbison72 created D7535: win32mbcs: fix a `str` type conditional for py3.
Sat, Nov 30, 12:09 PM
mharbison72 created D7533: repair: fix an `isinstance(nodelist, str)` check for py3.
Sat, Nov 30, 12:09 PM
mharbison72 created D7532: windows: fix an issue causing registry config paths to be ignored on py3.
Sat, Nov 30, 2:14 AM

Tue, Nov 26

mharbison72 updated subscribers of D7512: exchange: guard against method invocation on `b2caps=None` args.
In D7512#110589, @yuja wrote:
>>   """add a changegroup part to the requested bundle"""
>>
>> - if not kwargs.get('cg', True):
>>
>> +    if not kwargs.get('cg', True) or not b2caps:
>>
>>   return
>
> Is it valid to call these functions with `b2caps=None`? I suspect it would
> be a bug or a data corruption.
The only caller I can find[1] will indeed pass something, even if it is `{}`.  I can change these to asserts if you want.
[1] https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/exchange.py#l2448

Well, I have no expertise around this module, so I have no idea which is
better. I just don't know if it's valid to return successfully if b2caps
is None.

Tue, Nov 26, 8:21 AM

Mon, Nov 25

mharbison72 added a comment to D7512: exchange: guard against method invocation on `b2caps=None` args.
In D7512#110528, @yuja wrote:
"""add a changegroup part to the requested bundle"""
  • if not kwargs.get('cg', True):

+ if not kwargs.get('cg', True) or not b2caps:

return

Is it valid to call these functions with b2caps=None? I suspect it would
be a bug or a data corruption.

Mon, Nov 25, 12:54 PM

Sun, Nov 24

mharbison72 closed D7516: webutil: add missing argument to join().
Sun, Nov 24, 10:21 AM
mharbison72 committed rHG371765e775a2: webutil: add missing argument to join().
webutil: add missing argument to join()
Sun, Nov 24, 10:21 AM
mharbison72 updated subscribers of D7516: webutil: add missing argument to join().
In D7516#110537, @dlax wrote:

Looks like dead code

Sun, Nov 24, 9:17 AM
mharbison72 added a comment to D7517: filemerge: byteify the open() mode.
In D7517#110547, @dlax wrote:

This is actually pycompat.open(), so it need bytes.

I don't understand why this is needed. The default value for "mode" as bytes comes from a407f9009392, but I don't understand the rationale.

Sun, Nov 24, 9:08 AM
mharbison72 created D7517: filemerge: byteify the open() mode.
Sun, Nov 24, 12:45 AM

Sat, Nov 23

mharbison72 created D7516: webutil: add missing argument to join().
Sat, Nov 23, 11:07 PM
mharbison72 closed D7512: exchange: guard against method invocation on `b2caps=None` args.
Sat, Nov 23, 8:01 PM
mharbison72 closed D7511: exchange: eliminate some bytes.format() calls.
Sat, Nov 23, 8:01 PM
mharbison72 committed rHG0dbea180525c: exchange: guard against method invocation on `b2caps=None` args.
exchange: guard against method invocation on `b2caps=None` args
Sat, Nov 23, 8:01 PM
mharbison72 closed D7510: windows: suppress pytype warnings for Windows imports and functions.
Sat, Nov 23, 8:01 PM
mharbison72 committed rHG76d4bf0a652b: exchange: eliminate some bytes.format() calls.
exchange: eliminate some bytes.format() calls
Sat, Nov 23, 8:01 PM
mharbison72 committed rHGc6060b243163: windows: suppress pytype warnings for Windows imports and functions.
windows: suppress pytype warnings for Windows imports and functions
Sat, Nov 23, 8:01 PM
mharbison72 added a comment to D7515: pytype: [WIP] suppress various warnings inline to get a clean run.

Adjusting this to stay out of the review queue. While most of the files only had a handful of errors (and a few could be removed from the blacklist), the few added had a bunch of errors. I didn't see any obvious fixes, and ran out of time Friday to individually suppress them.

Sat, Nov 23, 7:54 PM
mharbison72 created D7515: pytype: [WIP] suppress various warnings inline to get a clean run.
Sat, Nov 23, 7:52 PM
mharbison72 added a comment to D7507: phabricator: add a "phabstatus" template keyword.

I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?

Sat, Nov 23, 11:23 AM
mharbison72 added a comment to D7506: phabricator: add a "phabstatus" show view.
In D7506#110351, @dlax wrote:

The revisions shown by the "phabstatus" view is just a subset of that of "work" view (subset of revisions with a differential). Do you see more revisions in "phabstatus" than in "work" or am I misunderstanding something?

Sat, Nov 23, 11:12 AM
mharbison72 added a comment to D7510: windows: suppress pytype warnings for Windows imports and functions.

I'm not sure if there are plans to vendor *.pyi files. Maybe that could be used to backfill platform specific modules instead of doing this. But for now is seems better to get the error count and blacklist length reduced.

Sat, Nov 23, 12:17 AM
mharbison72 created D7512: exchange: guard against method invocation on `b2caps=None` args.
Sat, Nov 23, 12:15 AM
mharbison72 created D7511: exchange: eliminate some bytes.format() calls.
Sat, Nov 23, 12:15 AM
mharbison72 created D7510: windows: suppress pytype warnings for Windows imports and functions.
Sat, Nov 23, 12:15 AM

Fri, Nov 22

mharbison72 added a comment to D7506: phabricator: add a "phabstatus" show view.

I'm not sure why, but this version seems to also show obsolete revisions. I've got a bunch of x and * nodes in hg-committed right now. I didn't see that before, although that was on a different clone that I don't have access to now.

Fri, Nov 22, 11:41 PM
mharbison72 added a comment to D7506: phabricator: add a "phabstatus" show view.

I'm not sure why, but this version seems to also show obsolete revisions. I've got a bunch of x and * nodes in hg-committed right now. I didn't see that before, although that was on a different clone that I don't have access to now.

Fri, Nov 22, 10:57 PM
mharbison72 added a comment to D7295: pytype: add a (very slow) test that executes pytype.

Since type checking is slow (but there are state files we can reuse to speed things up), we'll need to figure out how to make this work in CI. But I have no doubt we can figure something out. Out of curiosity, how long does pytype take to run in a clean source directory, without any state files?

Fri, Nov 22, 5:43 PM
mharbison72 added a comment to D7506: phabricator: add a "phabstatus" show view.
In D7506#110249, @dlax wrote:

I'm also interested in coloring the status value, but I can tinker with that after it's landed, unless you already have plans.

You mean having a different color depending on status value, or a fixed one? I have no plan anyways, so if you have good ideas, I'll leave this up to you.

Fri, Nov 22, 5:35 PM
mharbison72 added a comment to D7506: phabricator: add a "phabstatus" show view.

I like it.

Fri, Nov 22, 12:36 PM

Thu, Nov 21

mharbison72 added a comment to D7258: makefile: use Python 3 by default outside of Windows (BC).

I seriously question whether we need a Makefile at all [on Windows]: our Makefile is just a glorified shell script and isn't doing much in terms of dependency management. I'm tempted to move the packaging targets to contrib/packaging and replace the remaining build targets with a build.py script.

Thu, Nov 21, 11:22 PM
mharbison72 added a comment to D7258: makefile: use Python 3 by default outside of Windows (BC).

To continue using Python 2, set the PYTHON variable. e.g.
make install PYTHON=python2.7 or
make install PYTHON=py.exe -2.

Thu, Nov 21, 10:49 PM
mharbison72 closed D7471: tests: byteify a few more things in simplestorerepo.py.
Thu, Nov 21, 9:51 PM
mharbison72 committed rHG8ca92bcb3083: tests: byteify a few more things in simplestorerepo.py.
tests: byteify a few more things in simplestorerepo.py
Thu, Nov 21, 9:51 PM
mharbison72 closed D7468: phases: make `allphases` a list on py3 also.
Thu, Nov 21, 9:51 PM
mharbison72 committed rHG882e633ac92c: profiling: add a missing argument to the ProgrammingError constructor.
profiling: add a missing argument to the ProgrammingError constructor
Thu, Nov 21, 9:51 PM
mharbison72 closed D7470: profiling: add a missing argument to the ProgrammingError constructor.
Thu, Nov 21, 9:51 PM
mharbison72 committed rHG6c8ba31405d9: profiling: disable the import-error warning for the flamegraph module.
profiling: disable the import-error warning for the flamegraph module
Thu, Nov 21, 9:51 PM
mharbison72 closed D7469: profiling: disable the import-error warning for the flamegraph module.
Thu, Nov 21, 9:51 PM