mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (44 w, 2 d)

Recent Activity

Yesterday

mharbison72 committed rHGf44306940c94: tests: stabilize test-patch.t on Windows.
tests: stabilize test-patch.t on Windows
Tue, May 22, 7:41 AM
mharbison72 committed rHG10befe8e8b59: githelp: rewrite a Yoda conditional.
githelp: rewrite a Yoda conditional
Tue, May 22, 7:41 AM
mharbison72 committed rHG26b73fad45d9: githelp: lowercase the start of output messages for consistency.
githelp: lowercase the start of output messages for consistency
Tue, May 22, 7:41 AM
mharbison72 committed rHGee96458afdb6: githelp: cleanly abort if the `svn` command is unknown.
githelp: cleanly abort if the `svn` command is unknown
Tue, May 22, 7:41 AM
mharbison72 committed rHG16463278e7f4: githelp: make several strings localizable.
githelp: make several strings localizable
Tue, May 22, 7:41 AM
mharbison72 committed rHGd8bd6a9c64a5: githelp: fail gracefully in a couple cases where arguments are missing.
githelp: fail gracefully in a couple cases where arguments are missing
Tue, May 22, 7:41 AM
mharbison72 committed rHG1721a2ef74b8: tests: stabilize test-patch.t on Windows.
tests: stabilize test-patch.t on Windows
Tue, May 22, 7:14 AM
mharbison72 committed rHGed103895d9a2: githelp: lowercase the start of output messages for consistency.
githelp: lowercase the start of output messages for consistency
Tue, May 22, 5:21 AM
mharbison72 committed rHG8e4cdc86c55f: githelp: rewrite a Yoda conditional.
githelp: rewrite a Yoda conditional
Tue, May 22, 5:21 AM
mharbison72 committed rHGd00bfbf24df0: githelp: make several strings localizable.
githelp: make several strings localizable
Tue, May 22, 5:21 AM
mharbison72 committed rHGc137053c30e3: githelp: cleanly abort if the `svn` command is unknown.
githelp: cleanly abort if the `svn` command is unknown
Tue, May 22, 5:21 AM
mharbison72 committed rHGa34bed7475cc: githelp: fail gracefully in a couple cases where arguments are missing.
githelp: fail gracefully in a couple cases where arguments are missing
Tue, May 22, 5:21 AM

Fri, May 18

mharbison72 committed rHG5a7cf42ba6ef: phabricator: register config settings.
phabricator: register config settings
Fri, May 18, 7:26 AM

Tue, May 15

mharbison72 committed rHG71cf20d47f25: phabricator: split auth.url into the standard auth.schemes and auth.prefix.
phabricator: split auth.url into the standard auth.schemes and auth.prefix
Tue, May 15, 8:51 AM

Mon, May 14

mharbison72 committed rHG0fa050bc68cb: phabricator: migrate [phabricator.auth] to [auth].
phabricator: migrate [phabricator.auth] to [auth]
Mon, May 14, 8:21 AM

Fri, May 11

mharbison72 committed rHG8ba0344f9fb1: debugextensions: process extensions loaded from the local repository too.
debugextensions: process extensions loaded from the local repository too
Fri, May 11, 10:54 PM
mharbison72 committed rHG20a4543e9a2b: phabricator: drop support for the deprecated `phabricator.token` config.
phabricator: drop support for the deprecated `phabricator.token` config
Fri, May 11, 10:54 PM
mharbison72 committed rHGf81a51d8fedf: util: drop _deprecatedfunc().
util: drop _deprecatedfunc()
Fri, May 11, 3:32 PM
mharbison72 committed rHG70f45f28c04e: util: drop deprecated forwarding to procutil (API).
util: drop deprecated forwarding to procutil (API)
Fri, May 11, 3:32 PM
mharbison72 committed rHG009b424c9cb6: templatekw: drop deprecated showlist() and showdict() (API).
templatekw: drop deprecated showlist() and showdict() (API)
Fri, May 11, 3:32 PM
mharbison72 committed rHG1d0610fdd63b: tests: migrate demandimport.py away from deprecated `util` module symbols.
tests: migrate demandimport.py away from deprecated `util` module symbols
Fri, May 11, 3:32 PM
mharbison72 committed rHG88c4257ae465: util: drop deprecated forwarding to dateutil (API).
util: drop deprecated forwarding to dateutil (API)
Fri, May 11, 3:32 PM
mharbison72 committed rHG8298e55fc9a4: util: drop deprecated forwarding to stringutil (API).
util: drop deprecated forwarding to stringutil (API)
Fri, May 11, 3:32 PM
mharbison72 committed rHGfb0de0bcd297: cmdutil: drop deprecated precursor of registrar.command (API).
cmdutil: drop deprecated precursor of registrar.command (API)
Fri, May 11, 3:32 PM

Fri, May 4

mharbison72 added inline comments to D3433: httppeer: detect redirect to URL without query string (issue5860).
Fri, May 4, 11:33 PM

Thu, May 3

mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

Just to confirm that phabimport brought this in correctly, the only thing you changed is advertisedurl to baseurl? If that's the case, the LFS change will have to be punted.

Thu, May 3, 5:43 PM
mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

I'll probably be at work for another ~2 hours if you need me to test with SCM Manager, but I can stay later if needed.

Thu, May 3, 3:51 PM

Wed, May 2

mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

With these fixes, it works on Windows. I'm not sure if the advertisedbaseurl a couple lines above needs to be adjusted too.

Wed, May 2, 11:10 PM
mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

It looks like the redirect is subtly changing the host. I printed req.get_full_url() in keepalive.do_open(), and got:

Wed, May 2, 10:44 PM
mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

I have no clue how this test would be failing on Windows but not on other platforms :/

Wed, May 2, 1:28 PM

Tue, May 1

mharbison72 added a comment to D3433: httppeer: detect redirect to URL without query string (issue5860).

This fixes the issue, thanks again. The only thing I noticed in practice is that the "real URL is xxx" notice is printed twice. The trace looks sane, (and the test captures this too), so I think it's purely cosmetic. The *.t test fails on Windows though:

Tue, May 1, 10:07 AM

Fri, Apr 27

mharbison72 added a comment to D3432: hgweb: guard against empty Content-Length header.

LGTM. Here's the PEP reference allowing that:

Fri, Apr 27, 11:26 PM

Tue, Apr 24

mharbison72 added a comment to D3427: hgweb: reuse body file object when hgwebdir calls hgweb (issue5851).

A test demonstrating hg clone and hg push via hgwebdir has been
added. Without this patch, the test hangs when doing hg clone.
Surprisingly, this must mean that we have effectively no test coverage
of the wire protocol when run via hgwebdir.

Tue, Apr 24, 9:13 PM
mharbison72 committed rHG91b717e2cafa: tests: drop a useless glob in test-infinite-bundlestore.t.
tests: drop a useless glob in test-infinite-bundlestore.t
Tue, Apr 24, 5:44 AM
mharbison72 committed rHG51dee6fad783: infinitepush: ensure fileindex bookmarks use '/' separators (issue5840).
infinitepush: ensure fileindex bookmarks use '/' separators (issue5840)
Tue, Apr 24, 5:44 AM

Apr 19 2018

mharbison72 committed rHG33d26f7bd6ca: infinitepush: open files in binary mode.
infinitepush: open files in binary mode
Apr 19 2018, 7:24 AM
mharbison72 committed rHG72ccb0716302: tests: stabilize test-fix.t for Windows.
tests: stabilize test-fix.t for Windows
Apr 19 2018, 7:24 AM

Apr 17 2018

mharbison72 committed rHGab04972a33ef: lfs: enable the final download count status message.
lfs: enable the final download count status message
Apr 17 2018, 8:00 AM
mharbison72 committed rHG925707ac2855: lfs: add the 'Authorization' property to the Batch API response, if present.
lfs: add the 'Authorization' property to the Batch API response, if present
Apr 17 2018, 8:00 AM
mharbison72 committed rHG7269b87f817c: scmutil: teach the file prefetch hook to handle multiple commits.
scmutil: teach the file prefetch hook to handle multiple commits
Apr 17 2018, 8:00 AM
mharbison72 committed rHGb54404d66f7e: export: invoke the file prefetch hook.
export: invoke the file prefetch hook
Apr 17 2018, 8:00 AM
mharbison72 committed rHG5e67c20915a7: diff: invoke the file prefetch hook.
diff: invoke the file prefetch hook
Apr 17 2018, 8:00 AM
mharbison72 committed rHGff6b0a20849d: tests: arrange for a server in wireproto-command-capabilities.t to be killed.
tests: arrange for a server in wireproto-command-capabilities.t to be killed
Apr 17 2018, 8:00 AM

Apr 16 2018

mharbison72 added a comment to D2934: forget: add --confirm option.

(Suggestion: diff the output of hg export on your version vs the one that lands to see what I needed to tweak - there were some oversights in tests during development it looks like.)

Apr 16 2018, 11:24 PM
mharbison72 committed rHG0a5fe2a08e82: configitems: register server.zstdlevel.
configitems: register server.zstdlevel
Apr 16 2018, 9:23 AM
mharbison72 added a comment to D2678: help: supporting both help and doc for aliases.

Is there anything that needs to be done to mark this experimental? I toyed with replacing '\n' substrings with LF, but wasn't happy enough with it to submit, and ran out of time. Last time I played with this, I also saw that '.. container:: verbose' is stripped out, but the following text wasn't, so there may be other useful things to tweak here.

Apr 16 2018, 12:23 AM

Apr 15 2018

mharbison72 committed rHG31a0d47d69b3: lfs: update the HTTP status codes in error cases.
lfs: update the HTTP status codes in error cases
Apr 15 2018, 9:52 AM
mharbison72 committed rHG10e5bb9678f4: lfs: gracefully handle aborts on the server when corrupt blobs are detected.
lfs: gracefully handle aborts on the server when corrupt blobs are detected
Apr 15 2018, 9:52 AM
mharbison72 committed rHGd241e6632669: lfs: fix the inferred remote store path when using a --prefix.
lfs: fix the inferred remote store path when using a --prefix
Apr 15 2018, 9:52 AM
mharbison72 committed rHGa7dbda94c86a: test-lfs: add tests to force server error path coverage.
test-lfs: add tests to force server error path coverage
Apr 15 2018, 9:52 AM
mharbison72 committed rHG726c4102db9e: lfs: log information about Internal Server Errors reported in the Batch API.
lfs: log information about Internal Server Errors reported in the Batch API
Apr 15 2018, 9:52 AM

Apr 14 2018

mharbison72 committed rHG64771e553b1a: lfs: update the HTTP status codes in error cases.
lfs: update the HTTP status codes in error cases
Apr 14 2018, 6:26 PM
mharbison72 committed rHG1c3d4542f8c7: lfs: gracefully handle aborts on the server when corrupt blobs are detected.
lfs: gracefully handle aborts on the server when corrupt blobs are detected
Apr 14 2018, 6:26 PM
mharbison72 committed rHGf079267c5fff: lfs: fix the inferred remote store path when using a --prefix.
lfs: fix the inferred remote store path when using a --prefix
Apr 14 2018, 6:26 PM
mharbison72 committed rHG6a893a8c4fc5: test-lfs: add tests to force server error path coverage.
test-lfs: add tests to force server error path coverage
Apr 14 2018, 6:26 PM
mharbison72 committed rHG169b46bdf272: lfs: log information about Internal Server Errors reported in the Batch API.
lfs: log information about Internal Server Errors reported in the Batch API
Apr 14 2018, 6:26 PM

Apr 12 2018

mharbison72 committed rHGb03f2e0fdb88: lfs: teach the blob server to handle --prefix.
lfs: teach the blob server to handle --prefix
Apr 12 2018, 8:25 PM
mharbison72 committed rHG5e81cf9651c1: hgweb: fallback to checking wsgireq.env for REPO_NAME for 3rd party hosting.
hgweb: fallback to checking wsgireq.env for REPO_NAME for 3rd party hosting
Apr 12 2018, 8:25 PM
mharbison72 added a comment to D3247: tests: load showstack in test-pull-http.t so network hangs are easier to find.

It doesn't load on Windows:

Apr 12 2018, 10:56 AM
mharbison72 committed rHG9c7a25ef5b49: lfs: handle paths that don't end with '/' when inferring the blob store.
lfs: handle paths that don't end with '/' when inferring the blob store
Apr 12 2018, 7:54 AM
mharbison72 committed rHG31a4ea773369: lfs: infer the blob store URL from an explicit push dest or default-push.
lfs: infer the blob store URL from an explicit push dest or default-push
Apr 12 2018, 7:54 AM
mharbison72 committed rHGe5cd8d1a094d: lfs: special case the null:// usercache instead of treating it as a url.
lfs: special case the null:// usercache instead of treating it as a url
Apr 12 2018, 7:54 AM
mharbison72 committed rHGbe1cc65bdb1c: lfs: infer the blob store URL from an explicit pull source.
lfs: infer the blob store URL from an explicit pull source
Apr 12 2018, 7:54 AM

Apr 11 2018

mharbison72 added a comment to D3251: tests: glob away fqdn wherever we print it.

Is this something where a substitution pattern would work (so that it is automatic)? I looked at subbing in $LOCALIP$ instead of having to glob $LOCALIP lines manually, but I didn't because all I could tell was that the glob helped FreeBSD jails in some way that I probably wouldn't be able to test. These seem somewhat related, maybe. (And I just started hitting this too on CentOS 7.4 for some reason, so +1.)

I think this only shows up in --debug server output, which we didn't have until recently.

I tried *super hard* to get this to work using a replacement mechanism, and failed. This was my "the heck with it, I want to be done" solution.

Apr 11 2018, 6:50 PM
mharbison72 added a comment to D3251: tests: glob away fqdn wherever we print it.

Is this something where a substitution pattern would work (so that it is automatic)? I looked at subbing in $LOCALIP$ instead of having to glob $LOCALIP lines manually, but I didn't because all I could tell was that the glob helped FreeBSD jails in some way that I probably wouldn't be able to test. These seem somewhat related, maybe. (And I just started hitting this too on CentOS 7.4 for some reason, so +1.)

Apr 11 2018, 6:39 PM
mharbison72 committed rHG092eff6833a7: lfs: infer the blob store URL from paths.default.
lfs: infer the blob store URL from paths.default
Apr 11 2018, 8:31 AM
mharbison72 committed rHG491edf2435a0: lfs: add the ability to disable the usercache.
lfs: add the ability to disable the usercache
Apr 11 2018, 8:31 AM
mharbison72 committed rHG20808ddb4990: tests: stabilize test-pull-bundle.t for Windows.
tests: stabilize test-pull-bundle.t for Windows
Apr 11 2018, 8:31 AM

Apr 10 2018

mharbison72 added a comment to D2988: fix: use a portable python script instead of sed in test.

Any movement on this? There's a lot of test spew on Windows that this would cut out.

Apr 10 2018, 11:24 PM

Apr 9 2018

mharbison72 committed rHGd815b9733ebd: tests: stabilize test-push-http.t for Windows.
tests: stabilize test-push-http.t for Windows
Apr 9 2018, 10:17 AM
mharbison72 committed rHG28e8c5949109: tests: add a substitution pattern for HTTP error log dates.
tests: add a substitution pattern for HTTP error log dates
Apr 9 2018, 10:17 AM

Apr 5 2018

mharbison72 added a comment to D2819: hgweb: refactor repository name URL parsing.

I installed the latest default branch with SCM Manager, and it 404s even simple things like hg id https://.... I bisected back to this. The paths in the access log looks unchanged:

With this commit:

127.0.0.1 - - [04/Apr/2018:12:44:12 -0400] "GET /hook/hg/?ping=true HTTP/1.1" 204 -
10.10.1.36 - - [04/Apr/2018:12:44:12 -0400] "GET /hg/eng/devsetup?cmd=capabilities HTTP/1.1" 404 949

Parent of this commit:

127.0.0.1 - - [04/Apr/2018:12:47:18 -0400] "GET /hook/hg/?ping=true HTTP/1.1" 204 -
10.10.1.36 - - [04/Apr/2018:12:47:19 -0400] "GET /hg/eng/devsetup?cmd=capabilities HTTP/1.1" 200 422
10.10.1.36 - - [04/Apr/2018:12:47:19 -0400] "GET /hg/eng/devsetup?cmd=lookup HTTP/1.1" 200 43
10.10.1.36 - - [04/Apr/2018:12:47:20 -0400] "GET /hg/eng/devsetup?cmd=listkeys HTTP/1.1" 200 30
10.10.1.36 - - [04/Apr/2018:12:47:20 -0400] "GET /hg/eng/devsetup?cmd=listkeys HTTP/1.1" 200 -

I'm going to try to add print statements, but if you have any darts you'd like to throw, I'd be happy to try it.

Apr 5 2018, 2:59 PM

Apr 4 2018

mharbison72 added a comment to D2819: hgweb: refactor repository name URL parsing.

I installed the latest default branch with SCM Manager, and it 404s even simple things like hg id https://.... I bisected back to this. The paths in the access log looks unchanged:

Apr 4 2018, 1:02 PM

Apr 3 2018

mharbison72 committed rHG7de7bd407251: server: ensure the incoming request falls under the prefix value.
server: ensure the incoming request falls under the prefix value
Apr 3 2018, 9:06 AM

Apr 2 2018

mharbison72 updated subscribers of D2988: fix: use a portable python script instead of sed in test.

I'm not sure what the state of this is (hg phabread failed for 3022 and 3023), but this works on Windows. I've got a separate patch to fix the printfs (which doesn't help the {rootpath} issue I mentioned).

Apr 2 2018, 10:09 PM

Apr 1 2018

mharbison72 committed rHG9640ccf44ac0: lfs: ensure the transfer request is for a known URI.
lfs: ensure the transfer request is for a known URI
Apr 1 2018, 6:36 AM
mharbison72 committed rHGfe061e47a2cf: lfs: avoid an improper usage of os.path.basename() to parse a URI.
lfs: avoid an improper usage of os.path.basename() to parse a URI
Apr 1 2018, 6:36 AM
mharbison72 committed rHGdfb38c4850a9: lfs: add an experimental knob to disable blob serving.
lfs: add an experimental knob to disable blob serving
Apr 1 2018, 6:36 AM

Mar 31 2018

mharbison72 committed rHG3e293808e835: lfs: add the 'Content-Type' header called out in the file transfer spec.
lfs: add the 'Content-Type' header called out in the file transfer spec
Mar 31 2018, 9:58 PM
mharbison72 committed rHG67db84842356: lfs: improve the client message when the server signals an object error.
lfs: improve the client message when the server signals an object error
Mar 31 2018, 9:58 PM
mharbison72 committed rHG79af9ae46a78: check-code: tighten the check for `ls -R`.
check-code: tighten the check for `ls -R`
Mar 31 2018, 9:58 PM
mharbison72 committed rHGb00bd974eef5: lfs: drop a duplicate blob verification method.
lfs: drop a duplicate blob verification method
Mar 31 2018, 6:18 AM
mharbison72 committed rHGd2bd29dffc6c: server: minor code cleanup.
server: minor code cleanup
Mar 31 2018, 6:18 AM
mharbison72 committed rHG73a60281a861: server: refactor 'daemon_postexec' instructions into a dictionary.
server: refactor 'daemon_postexec' instructions into a dictionary
Mar 31 2018, 6:18 AM

Mar 30 2018

mharbison72 added a comment to D2988: fix: use a portable python script instead of sed in test.

sys.std* need the procutil.setbinary() treatment, and globbing applied to the delta below to keep Windows happy. Also, test-fix-topology.t probably needs the same fix.

Mar 30 2018, 10:56 PM
mharbison72 committed rHGf09a2eab11cf: server: add an error feedback mechanism for when the daemon fails to launch.
server: add an error feedback mechanism for when the daemon fails to launch
Mar 30 2018, 10:23 PM
mharbison72 committed rHG77f9e95fe3c4: tests: conditionalize test-stream-bundle-v2 for Windows.
tests: conditionalize test-stream-bundle-v2 for Windows
Mar 30 2018, 10:23 PM
mharbison72 added inline comments to D2958: infinitepush: introduce server option to route every push to bundlestore.
Mar 30 2018, 9:10 PM
mharbison72 committed rHGf51c2780db3a: test-lfs-test-server: add a testcase for `hg serve`.
test-lfs-test-server: add a testcase for `hg serve`
Mar 30 2018, 7:48 AM

Mar 29 2018

mharbison72 committed rHGcc0a6ea95d98: lfs: add support for serving blob files.
lfs: add support for serving blob files
Mar 29 2018, 9:29 AM
mharbison72 committed rHGea6fc58524d7: lfs: add server side support for the Batch API.
lfs: add server side support for the Batch API
Mar 29 2018, 9:29 AM
mharbison72 committed rHGef48ad4a61e3: lfs: add support for serving blob files.
lfs: add support for serving blob files
Mar 29 2018, 8:54 AM
mharbison72 committed rHG725b709eb00d: lfs: add server side support for the Batch API.
lfs: add server side support for the Batch API
Mar 29 2018, 8:54 AM
mharbison72 committed rHGa2566597acb5: lfs: add basic routing for the server side wire protocol processing.
lfs: add basic routing for the server side wire protocol processing
Mar 29 2018, 8:54 AM
mharbison72 committed rHGc37c47e47a95: test-lfs: drop trailing ', ' item separators from debug JSON output.
test-lfs: drop trailing ', ' item separators from debug JSON output
Mar 29 2018, 8:54 AM
mharbison72 committed rHG56c7cd067477: lfs: add a blob verification method to the local store.
lfs: add a blob verification method to the local store
Mar 29 2018, 8:54 AM
mharbison72 committed rHG004ecdbe96ec: tests: conditionalize printed environment variable output in test-alias.
tests: conditionalize printed environment variable output in test-alias
Mar 29 2018, 7:48 AM

Mar 28 2018

mharbison72 committed rHG4d63f3bc1e1a: lfs: respect narrowmatcher when testing to add 'lfs' requirement (issue5794).
lfs: respect narrowmatcher when testing to add 'lfs' requirement (issue5794)
Mar 28 2018, 8:10 AM

Mar 27 2018

mharbison72 committed rHGa54113fcc8c9: lfs: move the 'supportedoutgoingversions' handling to changegroup.py.
lfs: move the 'supportedoutgoingversions' handling to changegroup.py
Mar 27 2018, 8:41 AM

Mar 25 2018

mharbison72 committed rHGa8a0cafcef79: test-pathconflicts-merge: stop requiring symlink support.
test-pathconflicts-merge: stop requiring symlink support
Mar 25 2018, 1:43 AM