Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (159 w, 2 d)

Recent Activity

Fri, Jul 17

mharbison72 committed rHGb3b0cd8b9366: phabricator: clarify the multiple heads/roots error message for phabsend.
phabricator: clarify the multiple heads/roots error message for phabsend
Fri, Jul 17, 2:05 PM
mharbison72 closed D8761: phabricator: clarify the multiple heads/roots error message for phabsend.
Fri, Jul 17, 2:05 PM

Thu, Jul 16

mharbison72 created D8761: phabricator: clarify the multiple heads/roots error message for phabsend.
Thu, Jul 16, 2:19 PM
mharbison72 closed D8756: phabupdate: allow resigning from revisions.
Thu, Jul 16, 12:55 PM
mharbison72 closed D8755: phabupdate: allow revisions to be commandeered.
Thu, Jul 16, 12:55 PM
mharbison72 committed rHGc59e7bed8924: phabupdate: allow resigning from revisions.
phabupdate: allow resigning from revisions
Thu, Jul 16, 12:55 PM
mharbison72 closed D8754: phabupdate: allow revisions to be reopened.
Thu, Jul 16, 12:55 PM
mharbison72 committed rHG383b8c77096d: phabupdate: allow revisions to be commandeered.
phabupdate: allow revisions to be commandeered
Thu, Jul 16, 12:55 PM
mharbison72 committed rHG2010f3143062: phabupdate: allow revisions to be reopened.
phabupdate: allow revisions to be reopened
Thu, Jul 16, 12:55 PM
mharbison72 closed D8751: phabupdate: allow revisions to be marked with "plan changes".
Thu, Jul 16, 12:55 PM
mharbison72 closed D8753: phabupdate: allow revisions to be marked "closed".
Thu, Jul 16, 12:55 PM
mharbison72 closed D8752: phabupdate: allows revisions to be marked "request-review".
Thu, Jul 16, 12:55 PM
mharbison72 committed rHG3ad0855cc602: phabupdate: allow revisions to be marked "closed".
phabupdate: allow revisions to be marked "closed"
Thu, Jul 16, 12:54 PM
mharbison72 committed rHG1ff5070c0ab4: phabupdate: allows revisions to be marked "request-review".
phabupdate: allows revisions to be marked "request-review"
Thu, Jul 16, 12:54 PM
mharbison72 committed rHG225588c4c255: phabupdate: allow revisions to be marked with "plan changes".
phabupdate: allow revisions to be marked with "plan changes"
Thu, Jul 16, 12:54 PM
mharbison72 added a comment to rHG5d09a120b4be: extensions: make `hg nonexistent` not crash with PyOxidizer.

I'm fine if other reviewers want to de-queue this patch, but maybe it's good to have it queued for now in case I don't end up with a good solution for the __index__.py-based fix soon.

Thu, Jul 16, 2:17 AM

Wed, Jul 15

mharbison72 added a comment to rHG5d09a120b4be: extensions: make `hg nonexistent` not crash with PyOxidizer.

I just wanted to point out that there's an __index__.py that gets generated in the py2exe case to handle some of this extension stuff when they aren't in the filesystem. I poked at this a bit 6 months ago or so, but was under the impression that PyOxidizer would eventually grow the capability to iterate over *.py resources, so didn't submit anything. Is that also your thinking, and this is a stopgap?

Wed, Jul 15, 11:34 PM
mharbison72 created D8756: phabupdate: allow resigning from revisions.
Wed, Jul 15, 2:23 PM
mharbison72 created D8755: phabupdate: allow revisions to be commandeered.
Wed, Jul 15, 2:23 PM
mharbison72 created D8754: phabupdate: allow revisions to be reopened.
Wed, Jul 15, 2:23 PM
mharbison72 created D8753: phabupdate: allow revisions to be marked "closed".
Wed, Jul 15, 2:23 PM
mharbison72 created D8752: phabupdate: allows revisions to be marked "request-review".
Wed, Jul 15, 2:23 PM
mharbison72 created D8751: phabupdate: allow revisions to be marked with "plan changes".
Wed, Jul 15, 1:32 PM
mharbison72 planned changes to D6876: phabricator: support automatically obsoleting old revisions of pulled commits.
Wed, Jul 15, 1:23 PM

Sat, Jul 11

mharbison72 committed rHG9a062913bab6: tests: stablize test-serve.t on Windows.
tests: stablize test-serve.t on Windows
Sat, Jul 11, 4:47 AM

Fri, Jul 10

mharbison72 committed rHG8c06f479cfc1: tests: stablize test-serve.t on Windows.
tests: stablize test-serve.t on Windows
Fri, Jul 10, 6:47 AM
mharbison72 closed D8720: tests: stablize test-serve.t on Windows.
Fri, Jul 10, 6:47 AM

Thu, Jul 9

mharbison72 created D8720: tests: stablize test-serve.t on Windows.
Thu, Jul 9, 11:13 PM

Jun 29 2020

mharbison72 closed D8671: version: sort extensions by name in verbose mode.
Jun 29 2020, 6:32 AM
mharbison72 committed rHGe1ea913da2ed: version: sort extensions by name in verbose mode.
version: sort extensions by name in verbose mode
Jun 29 2020, 6:31 AM

Jun 28 2020

mharbison72 created D8671: version: sort extensions by name in verbose mode.
Jun 28 2020, 3:29 PM

Jun 5 2020

mharbison72 closed D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
Jun 5 2020, 11:14 PM
mharbison72 committed rHG1f114c797961: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291)
Jun 5 2020, 11:14 PM
mharbison72 closed D8488: tests: show that rebase --dry-run and --confirm wipeout uncommitted changes.
Jun 5 2020, 11:14 PM
mharbison72 committed rHG9f3aa0d3de41: tests: show that rebase --dry-run and --confirm wipeout uncommitted changes.
tests: show that rebase --dry-run and --confirm wipeout uncommitted changes
Jun 5 2020, 11:13 PM

May 16 2020

mharbison72 added a comment to D8524: phabricator: load .arcconfig during reposetup (issue6331).

I'll try to take a closer look at this some time this weekend. In the meantime, can you explain more why it didn't work for you? There are tests that cover this feature, so I'm wondering if some coverage is missing.

May 16 2020, 1:04 PM
mharbison72 added inline comments to D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
May 16 2020, 12:08 PM

May 7 2020

mharbison72 committed rHGa50f33f1ff24: url: fix a bytes vs str crash in processing proxy headers (issue6249).
url: fix a bytes vs str crash in processing proxy headers (issue6249)
May 7 2020, 11:43 AM
mharbison72 closed D8485: url: fix a bytes vs str crash in processing proxy headers (issue6249).
May 7 2020, 11:02 AM
mharbison72 committed rHG8dbaa361ecdb: url: fix a bytes vs str crash in processing proxy headers (issue6249).
url: fix a bytes vs str crash in processing proxy headers (issue6249)
May 7 2020, 11:02 AM

May 2 2020

mharbison72 added a comment to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.

Now that I see it, I think we shoul dinclude all heads because the mssage might be confusing "multiple heads: one-hash"

May 2 2020, 4:34 PM

May 1 2020

mharbison72 closed D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
May 1 2020, 12:05 PM
mharbison72 closed D8455: tests: clarify a comment describing a phabricator test scenario.
May 1 2020, 12:03 PM
mharbison72 committed rHGcf3e07d7648a: tests: clarify a comment describing a phabricator test scenario.
tests: clarify a comment describing a phabricator test scenario
May 1 2020, 12:02 PM
mharbison72 committed rHGc1c922391314: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
phabricator: ensure that `phabsend` is given a contiguous, linear commit range
May 1 2020, 12:02 PM
mharbison72 added a comment to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.

Gentle ping on this. I think I addressed the concerns raised, and didn't want it overlooked for the release if it's still in the changes requested state.

Did not we want to update the message ?

May 1 2020, 10:24 AM
mharbison72 added a comment to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.

Gentle ping on this. I think I addressed the concerns raised, and didn't want it overlooked for the release if it's still in the changes requested state.

May 1 2020, 9:59 AM

Apr 30 2020

mharbison72 added a comment to D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).

I'm not real familiar with how rebase works, and seems like it's pretty intricate code. I'd also feel better if there were tests for the original commit referenced. But it's very unlikely that I'll have any time before the weekend to look at this again, so I thought I'd send it out now. Maybe it's narrow enough or maybe somebody can backfill the tests, and we can avoid a known data shredder in the next release.

Apr 30 2020, 1:25 AM
mharbison72 created D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
Apr 30 2020, 1:22 AM
mharbison72 created D8488: tests: show that rebase --dry-run and --confirm wipeout uncommitted changes.
Apr 30 2020, 1:20 AM

Apr 26 2020

mharbison72 added a comment to D8477: packaging: support building WiX installers with PyOxidizer.

I'm trying to build this with PyOxidizer and get an error after upgrading to v0.7.0. I wonder if some of the references in rust/hgcli/Cargo.lock need to be updated from 0.7.0-pre. Here's the command output:

Apr 26 2020, 11:36 PM
mharbison72 added a comment to D8477: packaging: support building WiX installers with PyOxidizer.

This may not be a big deal, and I'm not sure that this patch is the cause. When I built the py2 installer with py -3 contrib\packaging\packaging.py wix --python C:\Python2717\python.exe, I got a 25K hg.exe in the dist directory with all of the installers that had a mod time 1 minute before the installer. I don't remember seeing this when I was building installers at the end of January. (It also has screwy output, but that's a different issue)

Apr 26 2020, 10:53 PM
mharbison72 created D8485: url: fix a bytes vs str crash in processing proxy headers (issue6249).
Apr 26 2020, 4:13 PM

Apr 24 2020

mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 24 2020, 4:38 PM
mharbison72 updated the diff for D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 24 2020, 3:06 PM
mharbison72 updated the diff for D8455: tests: clarify a comment describing a phabricator test scenario.
Apr 24 2020, 2:58 PM

Apr 23 2020

mharbison72 closed D8459: tests: stabilize test-log.t on Windows.
Apr 23 2020, 2:04 PM
mharbison72 committed rHG46856c2cc4f2: tests: stabilize test-log.t on Windows.
tests: stabilize test-log.t on Windows
Apr 23 2020, 2:04 PM
mharbison72 closed D8458: tests: stabilize test-convert-hg-source.t on Windows.
Apr 23 2020, 2:04 PM
mharbison72 committed rHG78b7eae31488: tests: stabilize test-convert-hg-source.t on Windows.
tests: stabilize test-convert-hg-source.t on Windows
Apr 23 2020, 2:04 PM

Apr 22 2020

mharbison72 added a comment to D8457: [RFC] metadataonlyctx: demonstrate an error reusing manifest nodes.

For demo purpose only → getting it out of review. Put it back in review if I am wrong.

Apr 22 2020, 1:50 PM
mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 22 2020, 1:49 PM

Apr 19 2020

mharbison72 updated the diff for D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 19 2020, 5:45 PM
mharbison72 updated the diff for D8455: tests: clarify a comment describing a phabricator test scenario.
Apr 19 2020, 5:45 PM
mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 19 2020, 5:43 PM

Apr 17 2020

mharbison72 updated the diff for D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 17 2020, 11:28 PM
mharbison72 updated the diff for D8455: tests: clarify a comment describing a phabricator test scenario.
Apr 17 2020, 11:27 PM
mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 17 2020, 11:25 PM
mharbison72 created D8459: tests: stabilize test-log.t on Windows.
Apr 17 2020, 9:07 PM
mharbison72 created D8458: tests: stabilize test-convert-hg-source.t on Windows.
Apr 17 2020, 9:06 PM
mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 17 2020, 3:09 PM
mharbison72 added a comment to D8345: tests: look for CRLF on Windows.

@mharbison72 @indygreg, IIRC Matt is saying this is the wrong fix. What's the status of this?

Apr 17 2020, 2:59 PM
mharbison72 added a comment to D6846: packaging: script the building of a MacOS installer using a custom python.

So as I understand this is not ready to land and should be moved to change-requested (or change planned), right ?

Apr 17 2020, 2:56 PM
mharbison72 created D8457: [RFC] metadataonlyctx: demonstrate an error reusing manifest nodes.
Apr 17 2020, 11:19 AM

Apr 16 2020

mharbison72 created D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 16 2020, 8:02 PM
mharbison72 created D8455: tests: clarify a comment describing a phabricator test scenario.
Apr 16 2020, 8:02 PM
mharbison72 closed D8438: phabricator: restack any new orphans created by phabsend (issue6045).
Apr 16 2020, 12:43 PM
mharbison72 closed D8436: phabricator: avoid creating unstable children within the review stack.
Apr 16 2020, 12:43 PM
mharbison72 closed D8437: phabricator: prevent posting obsolete commits.
Apr 16 2020, 12:43 PM
mharbison72 committed rHGeb9026a84e83: make: drop the `-c` arg to `install` in the documentation makefile.
make: drop the `-c` arg to `install` in the documentation makefile
Apr 16 2020, 12:43 PM
mharbison72 closed D8439: make: drop the `-c` arg to `install` in the documentation makefile.
Apr 16 2020, 12:43 PM
mharbison72 committed rHG601ce5392cb0: phabricator: restack any new orphans created by phabsend (issue6045).
phabricator: restack any new orphans created by phabsend (issue6045)
Apr 16 2020, 12:43 PM
mharbison72 closed D8389: phabricator: add debug logging to show previous node values in `phabsend`.
Apr 16 2020, 12:43 PM
mharbison72 committed rHGc482e2fe444c: phabricator: prevent posting obsolete commits.
phabricator: prevent posting obsolete commits
Apr 16 2020, 12:42 PM
mharbison72 closed D8390: tests: move the phabricator auth token to the global config file.
Apr 16 2020, 12:42 PM
mharbison72 committed rHG0680b8a1992a: phabricator: avoid creating unstable children within the review stack.
phabricator: avoid creating unstable children within the review stack
Apr 16 2020, 12:42 PM
mharbison72 closed D8314: phabricator: add an option to fold several commits into one review (issue6244).
Apr 16 2020, 12:42 PM
mharbison72 committed rHG3dc6a70779f2: phabricator: add an option to fold several commits into one review (issue6244).
phabricator: add an option to fold several commits into one review (issue6244)
Apr 16 2020, 12:42 PM
mharbison72 committed rHGed81fa859426: tests: move the phabricator auth token to the global config file.
tests: move the phabricator auth token to the global config file
Apr 16 2020, 12:42 PM
mharbison72 committed rHG38f7b2f02f6d: phabricator: add debug logging to show previous node values in `phabsend`.
phabricator: add debug logging to show previous node values in `phabsend`
Apr 16 2020, 12:42 PM
mharbison72 added inline comments to D8436: phabricator: avoid creating unstable children within the review stack.
Apr 16 2020, 11:10 AM
mharbison72 added a comment to D8431: upgrade: support upgrade and downgrade from persistent nodemap.

s/requirements is not/requirement is now/ in the summary, but otherwise LGTM

Apr 16 2020, 9:51 AM
mharbison72 accepted D8430: nodemap: teach `hg debugformat` about the persistent nodemap option.
Apr 16 2020, 12:10 AM
mharbison72 added a comment to D8429: upgrade: support the --quiet flag.

I think it might make sense to make some of these messages note() or debug(), but this is still an improvement.

Apr 16 2020, 12:05 AM

Apr 15 2020

mharbison72 accepted D8428: upgrade: clearly list optimisation.
Apr 15 2020, 11:58 PM
mharbison72 added a comment to D8439: make: drop the `-c` arg to `install` in the documentation makefile.

This helps it get further, but then it dies with messages like:

find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/32/
...
install: hg-ssh.8 was not found anywhere!
find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/32/
...
install: hgrc.5 was not found anywhere!
...
Apr 15 2020, 10:50 PM
mharbison72 added a comment to D8439: make: drop the `-c` arg to `install` in the documentation makefile.

This helps it get further, but then it dies with messages like:

Apr 15 2020, 10:37 PM
mharbison72 created D8439: make: drop the `-c` arg to `install` in the documentation makefile.
Apr 15 2020, 10:28 PM
mharbison72 added a comment to D8435: modified A.

This was to generate tests.

Apr 15 2020, 8:30 PM
mharbison72 added a comment to D8434: modified 1.

This was to generate tests.

Apr 15 2020, 8:29 PM