Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (117 w, 6 d)

Recent Activity

Yesterday

mharbison72 added a reviewer for D7130: automation: avoid '~' in the temp directory on Windows: indygreg.
Sat, Oct 19, 1:21 PM

Fri, Oct 18

mharbison72 added a comment to D7132: tests: conditionalize a permission based test in test-hgrc.t.

726bd0b612a2 does the same thing.

Fri, Oct 18, 6:05 PM

Thu, Oct 17

mharbison72 created D7132: tests: conditionalize a permission based test in test-hgrc.t.
Thu, Oct 17, 10:16 PM
mharbison72 created D7130: automation: avoid '~' in the temp directory on Windows.
Thu, Oct 17, 7:31 PM

Wed, Oct 16

mharbison72 committed rHGe88549a02f5e: tests: stabilize test-eol-update on Windows.
tests: stabilize test-eol-update on Windows
Wed, Oct 16, 10:38 PM
mharbison72 committed rHGa324f6a0cfd3: tests: opt into python3 when testing virtualenv installation.
tests: opt into python3 when testing virtualenv installation
Wed, Oct 16, 10:38 PM
mharbison72 committed rHG44db020fe4ba: tests: stabilize test-eol-update on Windows.
tests: stabilize test-eol-update on Windows
Wed, Oct 16, 5:05 PM
mharbison72 closed D7112: tests: stabilize test-eol-update on Windows.
Wed, Oct 16, 5:05 PM
mharbison72 closed D7111: tests: opt into python3 when testing virtualenv installation.
Wed, Oct 16, 5:05 PM
mharbison72 committed rHG97988ce08f0c: tests: opt into python3 when testing virtualenv installation.
tests: opt into python3 when testing virtualenv installation
Wed, Oct 16, 5:04 PM

Tue, Oct 15

mharbison72 created D7112: tests: stabilize test-eol-update on Windows.
Tue, Oct 15, 10:08 PM
mharbison72 created D7111: tests: opt into python3 when testing virtualenv installation.
Tue, Oct 15, 10:08 PM
mharbison72 added a comment to D7101: fix: match patterns relative to root.

I can’t tell from my phone, but should the matcher in getworkqueue and the status call in pathstofix also be adjusted? (Not sure if there are others.)

No, that matcher (it's the same instance that's passed between them) is created based on pats and opts, i.e. command line arguments.

Tue, Oct 15, 12:10 AM

Mon, Oct 14

mharbison72 added a comment to D7065: examples: allow the fix configuration to work from any directory.

I talked to @hooper about this and they agreed that using repo-relative paths is almost always what the user wants. I've sent D7101 for that.

Mon, Oct 14, 9:19 PM
D7101: fix: match patterns relative to root now requires changes to proceed.

The part of the help text that documents :pattern and points to hg help patterns should probably explicitly state that they are all relative to repo root, regardless of what the latter says.

Mon, Oct 14, 9:18 PM

Sun, Oct 13

mharbison72 closed D7081: tests: open file in binary mode in test-upgrade-repo.t.
Sun, Oct 13, 2:11 AM
mharbison72 closed D7080: hghave: use a native string to invoke the `black` command.
Sun, Oct 13, 2:11 AM
mharbison72 committed rHG86b26f20146d: tests: open file in binary mode in test-upgrade-repo.t.
tests: open file in binary mode in test-upgrade-repo.t
Sun, Oct 13, 2:11 AM
mharbison72 committed rHG138ac8cbce60: hghave: use a native string to invoke the `black` command.
hghave: use a native string to invoke the `black` command
Sun, Oct 13, 2:10 AM
mharbison72 closed D7079: py3: convert cwd to native string when running `fix`.
Sun, Oct 13, 2:10 AM
mharbison72 committed rHG2d1f9880af1b: py3: convert cwd to native string when running `fix`.
py3: convert cwd to native string when running `fix`
Sun, Oct 13, 2:10 AM
mharbison72 added a comment to D6993: black: add a pyproject.toml that contains our black settings.

I'm baffled, but this causes test-install.t to fail on Windows:

Sun, Oct 13, 1:03 AM
mharbison72 created D7081: tests: open file in binary mode in test-upgrade-repo.t.
Sun, Oct 13, 12:17 AM

Sat, Oct 12

mharbison72 created D7080: hghave: use a native string to invoke the `black` command.
Sat, Oct 12, 10:31 PM
mharbison72 created D7079: py3: convert cwd to native string when running `fix`.
Sat, Oct 12, 10:31 PM
mharbison72 added a comment to D7065: examples: allow the fix configuration to work from any directory.

It's unfortunate that this is necessary. I'll see if I can fix fix.py to always interpret patterns relative to the repo root.

Sat, Oct 12, 1:41 PM
mharbison72 created D7065: examples: allow the fix configuration to work from any directory.
Sat, Oct 12, 12:55 AM

Tue, Oct 8

mharbison72 added a comment to rHGe5d535621ee1: infinitepush: mark extension as likely to be deleted.

Should this print a warning when it's loaded? I suspect the number of people reading the source or extension help once they start using it is significantly less than the number that read the output.

Tue, Oct 8, 6:50 PM
mharbison72 added inline comments to D6876: phabricator: support automatically obsoleting old revisions of pulled commits.
Tue, Oct 8, 8:12 AM
mharbison72 added a comment to D6876: phabricator: support automatically obsoleting old revisions of pulled commits.

The feature seens pretty usful, but is also a potential foot-gun/data-loss engine. I think it is useful to take the feature, but maybe with proper documentaiton warning and turned of by efaut. I made a couple of comment about the implementation.

Tue, Oct 8, 12:20 AM

Mon, Oct 7

mharbison72 added a comment to D6989: push: support config option to require revs be specified when running push.

Question: should this checking be performed in exchange.push or at the command layer?
(I'm not sure of the answer.)

Mon, Oct 7, 11:18 AM

Fri, Oct 4

mharbison72 added inline comments to D6958: hg: move hg script to be a template that gets filled in via make.
Fri, Oct 4, 3:29 PM

Wed, Sep 25

mharbison72 closed D6874: uncommit: fix typo in help text.
Wed, Sep 25, 11:57 AM
mharbison72 committed rHG576fd1c8b20b: uncommit: fix typo in help text.
uncommit: fix typo in help text
Wed, Sep 25, 11:57 AM
mharbison72 closed D6875: phabricator: use exthelper to register commands, config, and templates.
Wed, Sep 25, 11:57 AM
mharbison72 committed rHG24bf7a3d3c30: phabricator: use exthelper to register commands, config, and templates.
phabricator: use exthelper to register commands, config, and templates
Wed, Sep 25, 11:57 AM
mharbison72 created D6876: phabricator: support automatically obsoleting old revisions of pulled commits.
Wed, Sep 25, 1:17 AM
mharbison72 created D6875: phabricator: use exthelper to register commands, config, and templates.
Wed, Sep 25, 1:17 AM

Tue, Sep 24

mharbison72 created D6874: uncommit: fix typo in help text.
Tue, Sep 24, 10:27 PM

Sep 16 2019

mharbison72 closed D6852: tests: stabilize test-fix.t on Windows.
Sep 16 2019, 1:56 PM
mharbison72 committed rHGa2dffe68b4ea: tests: stabilize test-fix.t on Windows.
tests: stabilize test-fix.t on Windows
Sep 16 2019, 1:56 PM
mharbison72 closed D6854: amend: prevent '\n' in the note string.
Sep 16 2019, 1:56 PM
mharbison72 closed D6853: amend: add option to update to the current user.
Sep 16 2019, 1:56 PM
mharbison72 closed D6857: uncommit: enable support for adding a note.
Sep 16 2019, 1:56 PM
mharbison72 committed rHG2da754532dd3: uncommit: enable support for adding a note.
uncommit: enable support for adding a note
Sep 16 2019, 1:56 PM
mharbison72 closed D6856: amend: enable support for using the secret phase.
Sep 16 2019, 1:56 PM
mharbison72 committed rHGf10a0f5eedae: amend: enable support for using the secret phase.
amend: enable support for using the secret phase
Sep 16 2019, 1:55 PM
mharbison72 closed D6855: amend: enable support for closing the branch.
Sep 16 2019, 1:55 PM
mharbison72 committed rHG09d46b90f6f9: amend: enable support for closing the branch.
amend: enable support for closing the branch
Sep 16 2019, 1:55 PM
mharbison72 committed rHG7e9997041781: amend: prevent '\n' in the note string.
amend: prevent '\n' in the note string
Sep 16 2019, 1:55 PM
mharbison72 committed rHGe4803231f538: amend: add option to update to the current user.
amend: add option to update to the current user
Sep 16 2019, 1:55 PM

Sep 15 2019

mharbison72 added a comment to D6735: update: added support for --abort flag(issue4404).

Here's a case I stumbled upon that is a problem. It looks like it thinks it isn't in the middle of an update, but .hgsubstate isn't put back to the pre-update state.

Sep 15 2019, 11:14 PM
mharbison72 added a comment to D6709: config: add --registered flag to show all known configs.
In D6709#99199, @av6 wrote:

I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years and didn't care (enough to file a bug) about getting all config options, or their default values, or the experimental status (they could and still can read it in hg help config). --registered is needed for things like shell completions, and the output needs to be clear and parseable (and consistent with what regular showconfig shows).

I disagree that the primary use is script only. As a suer I have wanted this for a long time and I am happy to finally have a way to get this data without grepping the source.

Even adding "(default: x)" to values already complicates the parsing process to get multiple config options in a script. Yeah, a script can get individual values one by one, but it can take ages because of the start-up time (again, this is important for interactive scripts like shell completions).

May we should drop the (default: x) part unless --verbose is specified. That would make sense to me. Since experimental/devel/debug(/deprecated?) only appears with --verbose that might work just fine for you ?

Sep 15 2019, 9:33 AM
mharbison72 created D6854: amend: prevent '\n' in the note string.
Sep 15 2019, 12:57 AM
mharbison72 created D6857: uncommit: enable support for adding a note.
Sep 15 2019, 12:57 AM
mharbison72 created D6856: amend: enable support for using the secret phase.
Sep 15 2019, 12:57 AM
mharbison72 created D6855: amend: enable support for closing the branch.
Sep 15 2019, 12:57 AM

Sep 14 2019

mharbison72 created D6853: amend: add option to update to the current user.
Sep 14 2019, 6:23 PM
mharbison72 created D6852: tests: stabilize test-fix.t on Windows.
Sep 14 2019, 2:00 PM

Sep 13 2019

mharbison72 added a comment to D6846: packaging: script the building of a MacOS installer using a custom python.

This seems to work (though the shebang line hack is painful)- until the original python build directory is deleted. Then a lot of things complain about unsupported hash type for md5 and sha{1,224,256,384,512}. Other modules like json can be imported with the installed python executable. I grepped around for the build directory, and it is in a bunch of *.so files (though this could be __FILE__ for all I know). Any ideas?

Sep 13 2019, 6:37 PM

Sep 12 2019

mharbison72 added a comment to D6846: packaging: script the building of a MacOS installer using a custom python.

This seems to work (though the shebang line hack is painful)- until the original python build directory is deleted. Then a lot of things complain about unsupported hash type for md5 and sha{1,224,256,384,512}. Other modules like json can be imported with the installed python executable. I grepped around for the build directory, and it is in a bunch of *.so files (though this could be __FILE__ for all I know). Any ideas?

Sep 12 2019, 6:28 PM
mharbison72 created D6846: packaging: script the building of a MacOS installer using a custom python.
Sep 12 2019, 6:21 PM
D6735: update: added support for --abort flag(issue4404) now requires changes to proceed.

Oops, meant to flag changes needed too.

Sep 12 2019, 1:34 AM
mharbison72 added a comment to D6735: update: added support for --abort flag(issue4404).

This looks good to me. Does anyone else have comments? @mharbison72 are you happy with the subrepo test coverage?

Sep 12 2019, 1:33 AM

Sep 11 2019

mharbison72 closed D6842: uncommit: make -D/--date and -U/--user mutually exclusive.
Sep 11 2019, 3:01 AM
mharbison72 closed D6841: uncommit: drop the hyphen from --current-user and --current-date.
Sep 11 2019, 3:01 AM
mharbison72 committed rHG4690902850df: uncommit: make -D/--date and -U/--user mutually exclusive.
uncommit: make -D/--date and -U/--user mutually exclusive
Sep 11 2019, 3:01 AM
mharbison72 committed rHGa50661567f83: uncommit: drop the hyphen from --current-user and --current-date.
uncommit: drop the hyphen from --current-user and --current-date
Sep 11 2019, 3:00 AM

Sep 10 2019

mharbison72 created D6842: uncommit: make -D/--date and -U/--user mutually exclusive.
Sep 10 2019, 11:24 PM
mharbison72 created D6841: uncommit: drop the hyphen from --current-user and --current-date.
Sep 10 2019, 11:24 PM
mharbison72 added a comment to D6837: cleanup: fix leakage of dirstate._map to client code.
  1. In lfs, where we deal with standins and mutating status.
Sep 10 2019, 12:23 PM

Sep 9 2019

mharbison72 added a comment to D6754: contrib: proof of concept script to build Mac packages without system python.

This is a start, but I suspect where we should end up with this is downloading and compiling the whole Python distribution, rather than relying on a virtualenv to be portable?

Sep 9 2019, 9:01 PM
mharbison72 added a comment to D6828: uncommit: add options to update to the current user or current date.

I'd like to port --interactive.

That will be great. https://phab.mercurial-scm.org/D6005 should help :)

Sep 9 2019, 2:31 PM
mharbison72 added a comment to D6828: uncommit: add options to update to the current user or current date.

I guess --interactive is the only flag left which is extra in evolve version, right?

Sep 9 2019, 12:49 PM
mharbison72 closed D6828: uncommit: add options to update to the current user or current date.
Sep 9 2019, 11:31 AM
mharbison72 closed D6827: uncommit: add support to modify the commit message and date.
Sep 9 2019, 11:30 AM
mharbison72 committed rHG66048f6b5d0d: uncommit: add options to update to the current user or current date.
uncommit: add options to update to the current user or current date
Sep 9 2019, 11:30 AM
mharbison72 committed rHGff1ff2aae132: uncommit: add support to modify the commit message and date.
uncommit: add support to modify the commit message and date
Sep 9 2019, 11:30 AM

Sep 7 2019

mharbison72 created D6828: uncommit: add options to update to the current user or current date.
Sep 7 2019, 11:32 PM
mharbison72 created D6827: uncommit: add support to modify the commit message and date.
Sep 7 2019, 11:31 PM

Aug 25 2019

mharbison72 updated subscribers of D6754: contrib: proof of concept script to build Mac packages without system python.

This looks promising.
I don't want to tell you not to work on this, but my bold plan is to get Mercurial using PyOxidizer and leaning on PyOxidizer for packaging. This will require shipping a Python 3 Mercurial, however.

Aug 25 2019, 5:11 PM
mharbison72 closed D6753: contrib: simplify the genosxversion.py command to find the hg libraries.
Aug 25 2019, 12:09 PM
mharbison72 committed rHG197e7326b8b8: contrib: simplify the genosxversion.py command to find the hg libraries.
contrib: simplify the genosxversion.py command to find the hg libraries
Aug 25 2019, 12:09 PM

Aug 20 2019

mharbison72 created D6754: contrib: proof of concept script to build Mac packages without system python.
Aug 20 2019, 6:34 PM
mharbison72 created D6753: contrib: simplify the genosxversion.py command to find the hg libraries.
Aug 20 2019, 6:34 PM

Aug 19 2019

mharbison72 added inline comments to D6735: update: added support for --abort flag(issue4404).
Aug 19 2019, 12:32 PM

Aug 11 2019

mharbison72 added a comment to D6709: config: add --registered flag to show all known configs.

I missed the debug one too, sorry. (Although I’m not sure why that also isn’t devel., so maybe it isn’t a big deal. Curious what others think.)

Aug 11 2019, 3:38 PM
mharbison72 added a comment to D6709: config: add --registered flag to show all known configs.

Should we hide devel.* like we do experimental when verbose isn’t applied? Presumably we don’t want regular users to know about them.

Aug 11 2019, 1:57 PM

Jul 24 2019

mharbison72 added a comment to D6676: unshelve: add help text on --interactive in verbose mode.

Maybe I’m looking at something wrong, but it looks like a couple references to “the shelve” snuck in after the last edit in diff 16017.

Jul 24 2019, 7:53 AM

Jul 23 2019

mharbison72 added inline comments to D6676: unshelve: add help text on --interactive in verbose mode.
Jul 23 2019, 12:50 PM

Jul 21 2019

mharbison72 closed D6663: tests: glob over some timing numbers in test-shelve.t.
Jul 21 2019, 10:34 AM
mharbison72 committed rHG944604118c0f: tests: glob over some timing numbers in test-shelve.t.
tests: glob over some timing numbers in test-shelve.t
Jul 21 2019, 10:34 AM

Jul 20 2019

mharbison72 created D6663: tests: glob over some timing numbers in test-shelve.t.
Jul 20 2019, 10:18 PM

Jul 19 2019

mharbison72 added inline comments to D6655: continue: added support for graft.
Jul 19 2019, 12:19 PM

Jul 17 2019

mharbison72 closed D6648: inno: correct the path display in a literal block of the readme.
Jul 17 2019, 2:27 AM
mharbison72 committed rHG8f7c3f43e3ac: inno: correct the path display in a literal block of the readme.
inno: correct the path display in a literal block of the readme
Jul 17 2019, 2:27 AM
mharbison72 added a comment to D6643: convert: add a config option to help doing identity hg->hg conversion.

I ran this on the repo that was giving me fits last summer, and it stayed consistent up until just after the point where there was an octopus fixup merge. I suspect the logic in that part of convert is too loose (i.e. it should be dropping files in the fixup merge that were already in the first merge if there weren't changes in the 3rd branch), but wasn't able to write a simple test. (The original repo was in bzr, converted to hg, and then I had to reconvert to lfs.) I've been swamped at work, so I don't have time to dig into it. But no sense in holding this up, as there doesn't seem to be a regression here.

I didn't quite understand. Are you saying your convert call cause hashes to change after this octopus merge, but it's not caused by my change, i.e. hg behaves this way even before?

Jul 17 2019, 12:17 AM

Jul 16 2019

mharbison72 added a comment to D6613: commit: improve the files field of changelog for merges.

@mharbison72 I dealt with the problem of convert in the previous commit. I didn't add a config option to disable the new code path, because it's really awkward to document, and I think it would be annoying to use if I made more fixes (the other case where files are spuriously listed, involving exec bits, probably has little impact on repo size/pull performance but it may be worth fixing anyway because it causes confusion). But if there are downsides to what I did, the config option is still on the table.

Jul 16 2019, 9:46 PM
mharbison72 added a comment to D6643: convert: add a config option to help doing identity hg->hg conversion.

The update worked for me, thanks.

Jul 16 2019, 9:33 PM
mharbison72 created D6648: inno: correct the path display in a literal block of the readme.
Jul 16 2019, 12:02 AM