mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (30 w, 6 d)

Recent Activity

Thu, Feb 15

mharbison72 added inline comments to D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5.
Thu, Feb 15, 10:37 PM

Tue, Feb 13

mharbison72 added a comment to D2066: lfs: add a test showing bundle application could be broken.

This series worked for me in practice. I assume there's no chance that this lands on stable to help people that are pushing to a repo converted to LFS, but that didn't reclone after converting?

Tue, Feb 13, 5:04 PM
mharbison72 committed rHG60dd840a7fdb: merge: invoke scmutil.fileprefetchhooks() prior to applying updates.
merge: invoke scmutil.fileprefetchhooks() prior to applying updates
Tue, Feb 13, 6:37 AM
mharbison72 committed rHG3a90159c2c2e: cat: migrate to the fileprefetch callback mechanism.
cat: migrate to the fileprefetch callback mechanism
Tue, Feb 13, 6:37 AM
mharbison72 committed rHG62719115875d: revert: drop the remnant of the prefetchfiles hook.
revert: drop the remnant of the prefetchfiles hook
Tue, Feb 13, 6:37 AM
mharbison72 committed rHGb72c6ff4e4c0: archive: migrate to the fileprefetch callback mechanism.
archive: migrate to the fileprefetch callback mechanism
Tue, Feb 13, 6:37 AM
mharbison72 committed rHGa991fcc48222: lfs: migrate to the fileprefetch callback mechanism.
lfs: migrate to the fileprefetch callback mechanism
Tue, Feb 13, 6:37 AM
mharbison72 committed rHGf52a9336ac5f: cmdutil: convert the prefetchfiles() hook to a callback mechanism (API).
cmdutil: convert the prefetchfiles() hook to a callback mechanism (API)
Tue, Feb 13, 6:37 AM
mharbison72 committed rHG6767e7ce2c31: test-narrow: partially stabilize on Windows.
test-narrow: partially stabilize on Windows
Tue, Feb 13, 6:37 AM

Mon, Feb 12

mharbison72 committed rHGfe5c4b795999: test-merge-tools: stabilize for Windows.
test-merge-tools: stabilize for Windows
Mon, Feb 12, 9:35 AM

Sat, Feb 10

mharbison72 committed rHG91aac8e6604d: lfs: teach the 'lfs()' fileset to handle removed files.
lfs: teach the 'lfs()' fileset to handle removed files
Sat, Feb 10, 10:48 PM
mharbison72 committed rHG8c7d5e90e6bd: lfs: teach '{lfs_files}' to handle removed files.
lfs: teach '{lfs_files}' to handle removed files
Sat, Feb 10, 10:48 PM
mharbison72 committed rHGdce43aaaf209: lfs: allow a pointer to be extracted from a context that removes the file.
lfs: allow a pointer to be extracted from a context that removes the file
Sat, Feb 10, 10:48 PM

Fri, Feb 9

mharbison72 committed rHGeefb5d603482: lfs: add a fileset for detecting lfs files.
lfs: add a fileset for detecting lfs files
Fri, Feb 9, 8:19 AM

Thu, Feb 8

mharbison72 committed rHGc64b9adfb371: tests: stabilize ssh tests on Windows.
tests: stabilize ssh tests on Windows
Thu, Feb 8, 7:04 AM

Wed, Feb 7

mharbison72 committed rHG7b2b82f891bf: fileset: don't abort when running copied() on a revision with a removed file.
fileset: don't abort when running copied() on a revision with a removed file
Wed, Feb 7, 6:32 AM

Tue, Feb 6

mharbison72 committed rHG9b413478f261: lfs: deduplicate oids in the transfer.
lfs: deduplicate oids in the transfer
Tue, Feb 6, 8:24 AM
mharbison72 committed rHG264b90a060b7: cat: call the storage prefetch hook.
cat: call the storage prefetch hook
Tue, Feb 6, 8:24 AM
mharbison72 committed rHG533f04d4cb6d: archive: call the storage prefetch hook.
archive: call the storage prefetch hook
Tue, Feb 6, 8:24 AM
mharbison72 committed rHGefbd04238029: cmdutil: convert _revertprefetch() to a generic stored file hook (API).
cmdutil: convert _revertprefetch() to a generic stored file hook (API)
Tue, Feb 6, 8:24 AM
mharbison72 committed rHGd857cad588e4: lfs: prefetch lfs blobs during revert.
lfs: prefetch lfs blobs during revert
Tue, Feb 6, 8:24 AM
mharbison72 committed rHG0b79f99fd7b0: lfs: prefetch lfs blobs when applying merge updates.
lfs: prefetch lfs blobs when applying merge updates
Tue, Feb 6, 8:24 AM
mharbison72 committed rHG47e737d27e01: lfs: factor out a method for extracting the pointer of a single file.
lfs: factor out a method for extracting the pointer of a single file
Tue, Feb 6, 8:24 AM

Sat, Feb 3

mharbison72 committed rHGcd2342302928: bookmarks: drop deprecated methods (API).
bookmarks: drop deprecated methods (API)
Sat, Feb 3, 9:49 PM
mharbison72 committed rHG265e91da56fd: dirstate: drop deprecated methods (API).
dirstate: drop deprecated methods (API)
Sat, Feb 3, 3:35 AM
mharbison72 committed rHGed3a7300b7b5: localrepo: drop the deprecated walk() method (API).
localrepo: drop the deprecated walk() method (API)
Sat, Feb 3, 3:35 AM
mharbison72 committed rHG78f33dedadd0: obsutil: drop deprecated methods (API).
obsutil: drop deprecated methods (API)
Sat, Feb 3, 3:35 AM
mharbison72 committed rHG6289482f6ab5: templatekw: drop the deprecated '{troubles}' keyword.
templatekw: drop the deprecated '{troubles}' keyword
Sat, Feb 3, 3:35 AM
mharbison72 committed rHG00a56c83ab64: revset: drop deprecated evolution predicates.
revset: drop deprecated evolution predicates
Sat, Feb 3, 3:35 AM
mharbison72 committed rHG75d9dcb64e7d: obsolete: drop deprecated methods (API).
obsolete: drop deprecated methods (API)
Sat, Feb 3, 3:35 AM
mharbison72 committed rHG44bc37d20271: context: drop deprecated methods (API).
context: drop deprecated methods (API)
Sat, Feb 3, 3:35 AM

Fri, Feb 2

mharbison72 added a comment to D2003: util: extract all date-related utils in utils/dateutil module.

Should dateutil.py be created with ‘hg cp’ to make annotate easier?

Fri, Feb 2, 7:56 AM
mharbison72 committed rHG6bd2846a82e8: lfs: drop an unused function parameter.
lfs: drop an unused function parameter
Fri, Feb 2, 7:31 AM
mharbison72 committed rHGfa993c3c8462: lfs: emit a status message to indicate how many blobs were uploaded.
lfs: emit a status message to indicate how many blobs were uploaded
Fri, Feb 2, 7:31 AM
mharbison72 committed rHGfe731c4b62ea: lfs: emit a status message to indicate how many blobs were uploaded.
lfs: emit a status message to indicate how many blobs were uploaded
Fri, Feb 2, 6:18 AM
mharbison72 committed rHG95a19e7c5a52: lfs: drop an unused function parameter.
lfs: drop an unused function parameter
Fri, Feb 2, 6:18 AM

Thu, Feb 1

mharbison72 committed rHGf6ca1e11d8b4: revset: evaluate filesets against each revision for 'file()' (issue5778).
revset: evaluate filesets against each revision for 'file()' (issue5778)
Thu, Feb 1, 7:46 AM
mharbison72 committed rHGb5df7fcf5d80: test-bookmarks-pushpull: stabilize for Windows.
test-bookmarks-pushpull: stabilize for Windows
Thu, Feb 1, 7:46 AM

Tue, Jan 30

mharbison72 committed rHG4425790f2373: lfs: don't require the .hglfs file to be tracked to control the policy.
lfs: don't require the .hglfs file to be tracked to control the policy
Tue, Jan 30, 7:09 AM

Sun, Jan 28

mharbison72 added inline comments to D1944: wireproto: provide accessors for client capabilities.
Sun, Jan 28, 1:36 AM

Thu, Jan 25

mharbison72 committed rHGd5288b966e2f: minifileset: note the unsupported file pattern when raising a parse error.
minifileset: note the unsupported file pattern when raising a parse error
Thu, Jan 25, 7:02 AM

Wed, Jan 24

mharbison72 committed rHGb91bca85ba73: lfs: don't automatically exclude '.hg*' files from external tracking.
lfs: don't automatically exclude '.hg*' files from external tracking
Wed, Jan 24, 6:56 AM
mharbison72 committed rHG97bdbcb43ebf: lfs: rename {oid} to {lfsoid}.
lfs: rename {oid} to {lfsoid}
Wed, Jan 24, 6:56 AM
mharbison72 committed rHG76cb752af07a: lfs: rename {pointer} to {lfspointer}.
lfs: rename {pointer} to {lfspointer}
Wed, Jan 24, 6:56 AM

Mon, Jan 22

mharbison72 committed rHG0c0689a7565e: subrepo: handle 'C:' style paths on the command line (issue5770).
subrepo: handle 'C:' style paths on the command line (issue5770)
Mon, Jan 22, 7:31 AM
mharbison72 committed rHG75bae69747f0: dummysmtpd: don't die on client connection errors.
dummysmtpd: don't die on client connection errors
Mon, Jan 22, 7:31 AM

Sun, Jan 21

mharbison72 added a comment to D1933: repair: invalidate volatile sets after stripping.

That worked for me, thanks.

Sun, Jan 21, 5:07 PM

Sat, Jan 20

mharbison72 committed rHG7764ff13318e: test-sshserver: stabilize for Windows.
test-sshserver: stabilize for Windows
Sat, Jan 20, 9:53 PM
mharbison72 committed rHGebb75443969a: test-branch-change: stabilize for Windows.
test-branch-change: stabilize for Windows
Sat, Jan 20, 9:53 PM
mharbison72 committed rHG0aafeded7957: test-sparse: make the '.hg' exclusion filter Windows compatible.
test-sparse: make the '.hg' exclusion filter Windows compatible
Sat, Jan 20, 9:53 PM
mharbison72 added a comment to D1867: evolution: report new unstable changesets.

Any idea why this introduced failures on Windows? The missing orphan line I assumed was a #if conditional, but there's not one in any of the files.

Sat, Jan 20, 3:05 PM
mharbison72 committed rHGf00edef84c3b: lfs: rename {lfsattrs} to {pointer}.
lfs: rename {lfsattrs} to {pointer}
Sat, Jan 20, 3:08 AM
mharbison72 committed rHG60a6ab7bcda7: lfs: expand the user facing documentation.
lfs: expand the user facing documentation
Sat, Jan 20, 2:41 AM

Fri, Jan 19

mharbison72 committed rHG069df0b952e8: lfs: separate a debug message from the subsequent abort message.
lfs: separate a debug message from the subsequent abort message
Fri, Jan 19, 9:22 PM
mharbison72 committed rHG693e3bcae19e: lfs: defer registering the pre-push hook until blobs are committed.
lfs: defer registering the pre-push hook until blobs are committed
Fri, Jan 19, 10:47 AM
mharbison72 committed rHGb4e1d0654736: lfs: dump the full response on httperror in debug mode.
lfs: dump the full response on httperror in debug mode
Fri, Jan 19, 10:47 AM
mharbison72 committed rHG3d48ae1aaa5e: lfs: default the User-Agent header for blob transfers to 'git-lfs'.
lfs: default the User-Agent header for blob transfers to 'git-lfs'
Fri, Jan 19, 10:47 AM
mharbison72 committed rHG10e62d5efa73: lfs: default to not using workers for upload/download.
lfs: default to not using workers for upload/download
Fri, Jan 19, 10:47 AM
mharbison72 committed rHGf58245b9e3ea: lfs: add the '{lfsattrs}' template keyword to '{lfs_files}'.
lfs: add the '{lfsattrs}' template keyword to '{lfs_files}'
Fri, Jan 19, 7:43 AM
mharbison72 committed rHG7415cc923613: test-blackbox: stabilize for Windows.
test-blackbox: stabilize for Windows
Fri, Jan 19, 7:43 AM

Jan 18 2018

mharbison72 committed rHGdd672e3d059f: lfs: raise an error if the server sends an unsolicited oid.
lfs: raise an error if the server sends an unsolicited oid
Jan 18 2018, 7:15 AM
mharbison72 committed rHG8a23082f4d93: lfs: correct documentation typo.
lfs: correct documentation typo
Jan 18 2018, 7:15 AM

Jan 17 2018

mharbison72 committed rHG1ad1e59b405e: lfs: control tracked file selection via a tracked file.
lfs: control tracked file selection via a tracked file
Jan 17 2018, 5:00 PM
mharbison72 committed rHG3c838bdc57b6: lfs: move the tracked file function creation to a method.
lfs: move the tracked file function creation to a method
Jan 17 2018, 5:00 PM
mharbison72 committed rHGa985834961f7: lfs: allow the pointer file to be viewed with `hg cat -T '{rawdata}'`.
lfs: allow the pointer file to be viewed with `hg cat -T '{rawdata}'`
Jan 17 2018, 5:00 PM
mharbison72 committed rHG91f0979f16c0: cat: factor out a function that populates the formatter.
cat: factor out a function that populates the formatter
Jan 17 2018, 5:00 PM
mharbison72 committed rHG185f20cffbf7: lfs: control tracked file selection via a tracked file.
lfs: control tracked file selection via a tracked file
Jan 17 2018, 9:15 AM
mharbison72 committed rHGe08f11883db3: lfs: move the tracked file function creation to a method.
lfs: move the tracked file function creation to a method
Jan 17 2018, 9:15 AM
mharbison72 committed rHG391bf2eeca3b: lfs: allow the pointer file to be viewed with `hg cat -T '{rawdata}'`.
lfs: allow the pointer file to be viewed with `hg cat -T '{rawdata}'`
Jan 17 2018, 9:15 AM
mharbison72 committed rHGb3e067caa53b: cat: factor out a function that populates the formatter.
cat: factor out a function that populates the formatter
Jan 17 2018, 9:15 AM

Jan 16 2018

mharbison72 added a comment to D1568: lfs: using workers in lfs prefetch.

Thanks @wlis . That makes sense, and aligns with what I saw (a couple of downloads worked with workers, though I still wasn't sure if that was safe or I was getting lucky). If you don't get the chance to follow up, I've got a patch that puts lfs workers behind an experimental knob. But there's no reason to disable for downloads if you're thinking that isn't buggy.

Jan 16 2018, 10:09 PM
mharbison72 added a comment to D1849: lfs: remove internal url in test.

Any thoughts on what we should do if 'p' does come up None? It's a clear server error (sending back an oid we didn't ask for).

Jan 16 2018, 10:01 PM
mharbison72 committed rHGa1222a8cc93b: lfs: add the '{oid}' template keyword to '{lfs_files}'.
lfs: add the '{oid}' template keyword to '{lfs_files}'
Jan 16 2018, 3:16 PM
mharbison72 committed rHG8580e5898cb7: lfs: convert '{lfs_files}' keyword to a hybrid list.
lfs: convert '{lfs_files}' keyword to a hybrid list
Jan 16 2018, 3:16 PM

Jan 15 2018

mharbison72 committed rHG4568e98b5f45: test-lfs: add tests to show that hashes remain unchanged by conversions.
test-lfs: add tests to show that hashes remain unchanged by conversions
Jan 15 2018, 8:25 AM
mharbison72 committed rHG1f0690bfc683: test-lfs: drop an unresolved issue note, now that lfs.track=none() is a thing.
test-lfs: drop an unresolved issue note, now that lfs.track=none() is a thing
Jan 15 2018, 8:25 AM
mharbison72 committed rHG588d02d9208a: lfs: always exclude '.hg*' text files.
lfs: always exclude '.hg*' text files
Jan 15 2018, 8:25 AM

Jan 14 2018

mharbison72 added a comment to D1858: tests: make hg frame optional.

I haven't been paying attention to the rust threads, but is there an hghave test for it? I don't see one locally. If so, then all that should be needed is appending ' (no-rust !)'. (Note the spaces.) I think this works for #test-cases too.

Jan 14 2018, 6:30 PM

Jan 13 2018

mharbison72 committed rHGc780e0649e41: lfs: migrate most file filtering from threshold to custom filter.
lfs: migrate most file filtering from threshold to custom filter
Jan 13 2018, 9:24 PM
mharbison72 committed rHGb75ea116603d: test-lfs: bump the number on test repo11 and higher.
test-lfs: bump the number on test repo11 and higher
Jan 13 2018, 9:24 PM
mharbison72 committed rHG706aa203b396: fileset: add a lightweight file filtering language.
fileset: add a lightweight file filtering language
Jan 13 2018, 12:59 AM
mharbison72 committed rHG0e369eca888f: fileset: split the logic for matching a size expression to a separate method.
fileset: split the logic for matching a size expression to a separate method
Jan 13 2018, 12:59 AM
mharbison72 committed rHG6d6d20658cce: lfs: drop deprecated remote store config options.
lfs: drop deprecated remote store config options
Jan 13 2018, 12:59 AM

Jan 11 2018

mharbison72 added a comment to D1849: lfs: remove internal url in test.

Yeah, I’ve been ignoring this failure. I thought I mentioned it back when this was first brought over. I’m assuming that FB will start using the built in extension and tests soon, and I didn’t want to drop test coverage on you like that. Thanks for fixing it.

Jan 11 2018, 1:04 AM

Jan 9 2018

mharbison72 committed rHGebf14075a5c1: lfs: improve the error message for a missing remote blob.
lfs: improve the error message for a missing remote blob
Jan 9 2018, 8:29 AM
mharbison72 committed rHG07769a04bc66: filelog: add the ability to report the user facing name.
filelog: add the ability to report the user facing name
Jan 9 2018, 8:29 AM

Jan 7 2018

mharbison72 added a reverting commit for rHGbb6a80fc969a: lfs: only hardlink between the usercache and local store if the blob verifies: rHGa77418095530: lfs: remove the verification option when writing to the local store.
Jan 7 2018, 3:41 AM
mharbison72 committed rHGa77418095530: lfs: remove the verification option when writing to the local store.
lfs: remove the verification option when writing to the local store
Jan 7 2018, 3:41 AM
mharbison72 added a reverting commit for rHG417e8e040102: lfs: verify lfs object content when transferring to and from the remote store: rHGa77418095530: lfs: remove the verification option when writing to the local store.
Jan 7 2018, 3:41 AM
mharbison72 committed rHGfd610befc37f: lfs: use the localstore download method to transfer from remote stores.
lfs: use the localstore download method to transfer from remote stores
Jan 7 2018, 3:41 AM
mharbison72 committed rHGfa9dd53eb23e: lfs: introduce a localstore method for downloading from remote stores.
lfs: introduce a localstore method for downloading from remote stores
Jan 7 2018, 3:41 AM

Jan 6 2018

mharbison72 committed rHG58fda95a0202: lfs: add a comment to describe subtle local blobstore open() behavior.
lfs: add a comment to describe subtle local blobstore open() behavior
Jan 6 2018, 2:40 AM

Jan 5 2018

mharbison72 committed rHGe8f80529abeb: lfs: use the local store method for opening a blob.
lfs: use the local store method for opening a blob
Jan 5 2018, 9:22 PM
mharbison72 committed rHG83903433c2eb: lfs: add a local store method for opening a blob.
lfs: add a local store method for opening a blob
Jan 5 2018, 9:22 PM

Jan 4 2018

mharbison72 added a comment to D1568: lfs: using workers in lfs prefetch.

It looks like keepalive.safesend() isn't sending everything. I can send this to the mailing list if it gets mangled, but I figured I'd try to keep this thread together if possible.

Jan 4 2018, 3:16 PM

Jan 3 2018

mharbison72 added a comment to D1568: lfs: using workers in lfs prefetch.

I'm seeing some corruption that appears to be related to workers, so maybe we should default the lfs workers to 'disabled'?

Jan 3 2018, 6:29 PM

Dec 31 2017

mharbison72 committed rHG5880318624c9: debugfs: display the tested path and mount point of the filesystem, if known.
debugfs: display the tested path and mount point of the filesystem, if known
Dec 31 2017, 4:10 AM
mharbison72 committed rHGe01549a7bf0a: osutil: implement getfsmountpoint() on BSD systems.
osutil: implement getfsmountpoint() on BSD systems
Dec 31 2017, 4:10 AM
mharbison72 committed rHG5cc1becd0493: win32: split a utility function to obtain the volume out of getfstype().
win32: split a utility function to obtain the volume out of getfstype()
Dec 31 2017, 4:10 AM
mharbison72 committed rHGc4caf530b1c7: util: add a function to show the mount point of the filesystem.
util: add a function to show the mount point of the filesystem
Dec 31 2017, 4:10 AM