Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (108 w, 6 d)

Recent Activity

Sun, Aug 11

mharbison72 added a comment to D6709: config: add --registered flag to show all known configs.

I missed the debug one too, sorry. (Although I’m not sure why that also isn’t devel., so maybe it isn’t a big deal. Curious what others think.)

Sun, Aug 11, 3:38 PM
mharbison72 added a comment to D6709: config: add --registered flag to show all known configs.

Should we hide devel.* like we do experimental when verbose isn’t applied? Presumably we don’t want regular users to know about them.

Sun, Aug 11, 1:57 PM

Wed, Jul 24

mharbison72 added a comment to D6676: unshelve: add help text on --interactive in verbose mode.

Maybe I’m looking at something wrong, but it looks like a couple references to “the shelve” snuck in after the last edit in diff 16017.

Wed, Jul 24, 7:53 AM

Tue, Jul 23

mharbison72 added inline comments to D6676: unshelve: add help text on --interactive in verbose mode.
Tue, Jul 23, 12:50 PM

Sun, Jul 21

mharbison72 closed D6663: tests: glob over some timing numbers in test-shelve.t.
Sun, Jul 21, 10:34 AM
mharbison72 committed rHG944604118c0f: tests: glob over some timing numbers in test-shelve.t.
tests: glob over some timing numbers in test-shelve.t
Sun, Jul 21, 10:34 AM

Sat, Jul 20

mharbison72 created D6663: tests: glob over some timing numbers in test-shelve.t.
Sat, Jul 20, 10:18 PM

Fri, Jul 19

mharbison72 added inline comments to D6655: continue: added support for graft.
Fri, Jul 19, 12:19 PM

Jul 17 2019

mharbison72 closed D6648: inno: correct the path display in a literal block of the readme.
Jul 17 2019, 2:27 AM
mharbison72 committed rHG8f7c3f43e3ac: inno: correct the path display in a literal block of the readme.
inno: correct the path display in a literal block of the readme
Jul 17 2019, 2:27 AM
mharbison72 added a comment to D6643: convert: add a config option to help doing identity hg->hg conversion.

I ran this on the repo that was giving me fits last summer, and it stayed consistent up until just after the point where there was an octopus fixup merge. I suspect the logic in that part of convert is too loose (i.e. it should be dropping files in the fixup merge that were already in the first merge if there weren't changes in the 3rd branch), but wasn't able to write a simple test. (The original repo was in bzr, converted to hg, and then I had to reconvert to lfs.) I've been swamped at work, so I don't have time to dig into it. But no sense in holding this up, as there doesn't seem to be a regression here.

I didn't quite understand. Are you saying your convert call cause hashes to change after this octopus merge, but it's not caused by my change, i.e. hg behaves this way even before?

Jul 17 2019, 12:17 AM

Jul 16 2019

mharbison72 added a comment to D6613: commit: improve the files field of changelog for merges.

@mharbison72 I dealt with the problem of convert in the previous commit. I didn't add a config option to disable the new code path, because it's really awkward to document, and I think it would be annoying to use if I made more fixes (the other case where files are spuriously listed, involving exec bits, probably has little impact on repo size/pull performance but it may be worth fixing anyway because it causes confusion). But if there are downsides to what I did, the config option is still on the table.

Jul 16 2019, 9:46 PM
mharbison72 added a comment to D6643: convert: add a config option to help doing identity hg->hg conversion.

The update worked for me, thanks.

Jul 16 2019, 9:33 PM
mharbison72 created D6648: inno: correct the path display in a literal block of the readme.
Jul 16 2019, 12:02 AM

Jul 15 2019

mharbison72 committed rHG5c36a7e4912a: tests: properly position conditional output on Windows in test-subrepo.t.
tests: properly position conditional output on Windows in test-subrepo.t
Jul 15 2019, 7:45 PM
D6643: convert: add a config option to help doing identity hg->hg conversion now requires changes to proceed.

Don't take this as a complete list, but it looks like repository.py, remotefilelog, eol, and probably keyword need to be taught the new kwarg. Note that the keyword wrapper is called kwcommitctx, so it isn't enough to grep for def commitctx.

Jul 15 2019, 12:20 PM
mharbison72 closed D6640: tests: properly position conditional output on Windows in test-subrepo.t.
Jul 15 2019, 10:14 AM
mharbison72 committed rHG8486675a08e1: tests: properly position conditional output on Windows in test-subrepo.t.
tests: properly position conditional output on Windows in test-subrepo.t
Jul 15 2019, 10:14 AM

Jul 14 2019

mharbison72 committed rHG862f6bddacce: automation: correct the path separator in LIBPATH on Windows.
automation: correct the path separator in LIBPATH on Windows
Jul 14 2019, 2:35 PM
mharbison72 closed D6642: automation: correct the path separator in LIBPATH on Windows.
Jul 14 2019, 2:35 PM
mharbison72 created D6642: automation: correct the path separator in LIBPATH on Windows.
Jul 14 2019, 1:36 AM

Jul 12 2019

mharbison72 created D6640: tests: properly position conditional output on Windows in test-subrepo.t.
Jul 12 2019, 7:39 PM

Jul 10 2019

mharbison72 updated subscribers of D6613: commit: improve the files field of changelog for merges.

Ok. Maybe it would be simpler or more robust to do the direct thing: optionally treat the files list in the input commit as input and reuse them blindly in the resulting commit, when doing a hg->hg conversion without filemap.

Jul 10 2019, 1:09 PM
mharbison72 committed rHGebf353aa4385: tests: update test-commit-interactive.t for no-execbit platforms.
tests: update test-commit-interactive.t for no-execbit platforms
Jul 10 2019, 9:14 AM
mharbison72 closed D6624: tests: update test-commit-interactive.t for no-execbit platforms.
Jul 10 2019, 9:14 AM
mharbison72 added a comment to D6613: commit: improve the files field of changelog for merges.

If this goes forward, can this be gated by a config option (even if it is on by default)? IIUC, this will change the hash for merges, and then cascade. That seems problematic for convert operations.
Most converts will do things that change hashes anyway, but the default options don't change anything. This is a convenient behavior for easily migrating to/from LFS, for example. (In theory, anyway. In practice, I've seen repos where a convert alters the changelog.) If there is a config option, convert should probably disable it by default to maintain the current behavior. I can see a use case for enabling it though, to clean up the repo.

Given the implementation, it's easy to add a knob to disable the change. But that doesn't seem enough: If you have a repository where commits have been created with a mix of hg before and after this change, there is no single value of the knob that would make convert be the identity.

Jul 10 2019, 12:09 AM

Jul 9 2019

mharbison72 created D6624: tests: update test-commit-interactive.t for no-execbit platforms.
Jul 9 2019, 10:14 PM
D6613: commit: improve the files field of changelog for merges now requires changes to proceed.

If this goes forward, can this be gated by a config option (even if it is on by default)? IIUC, this will change the hash for merges, and then cascade. That seems problematic for convert operations.

Jul 9 2019, 12:45 PM

Jul 8 2019

mharbison72 added inline comments to D6579: abort: added support for unshelve.
Jul 8 2019, 1:27 PM
mharbison72 added inline comments to D6579: abort: added support for unshelve.
Jul 8 2019, 1:09 PM

Jun 30 2019

mharbison72 added a reverting change for rHG044045dce23a: bookmarks: actual fix for race condition deleting bookmark: rHG2c27b7fadcd3: bookmarks: backout the attempt to fix the delete race.
Jun 30 2019, 2:23 AM
mharbison72 added a reverted change for rHG2c27b7fadcd3: bookmarks: backout the attempt to fix the delete race: rHG044045dce23a: bookmarks: actual fix for race condition deleting bookmark.
bookmarks: backout the attempt to fix the delete race
Jun 30 2019, 2:22 AM

Jun 23 2019

mharbison72 committed rHGa504aed0a78a: help: add a missing blank line to unhide `revlog-compression`.
help: add a missing blank line to unhide `revlog-compression`
Jun 23 2019, 5:18 AM

Jun 21 2019

mharbison72 added a comment to D6490: commit: add --force-close-branch flag to close a non-head changeset.
In D6490#95305, @pulkit wrote:

I think adding a --force flag to hg commit is not a nice option. force can mean a lot of things and here except in closing the non-head changeset, it is no-op.
For example, I am in middle of a rebase, tried to commit, it says rebase in progress. I see there is a --force flag, I try to use that to force the commit.
We can do one of the following:

  1. maybe a more specific flag name like --allow-close-branch or something like that
  2. a config option instead of a flag name

Fair point. Specific is better.
I'd suggest --force-close-branch as a standalone flag (i.e. you don't need to also use --close-branch; it wasn't clear to me if that's what you meant). --allow-close-branch and --close-branch don't seem different enough to remember the difference.

Just my $0.02.
I think that hg commit already has many options that do not even belong to committing (such as -A, --close-branch). Let's not add an option that is not related to commit. To my opinion closing a branch should be done with hg branch not commit (unfortunately this was never the case). Anyway if you really want to do it with commit, I would suggest that --close-branch takes an optional argument rather than adding a new option. This makes UX a bit more convenient
e.g.

hg commit --close-branch --force-close-branch (not that)
hg commit --close-branch forced (or force or something like that)

I think it's a little hard to make user understand (by providing a hint like "use force arg with --close-branch") that you need to provide an argument as compared to just providing a standalone flag --force-close-branch as @mharbison72 suggested. I do agree with you that it would make +1 in the no. of flags which don't make sense with hg commit. What do you say?

Jun 21 2019, 12:42 PM

Jun 20 2019

mharbison72 added a comment to D6555: vfs: require use of .seek() or .write() before .tell() on append-mode files.

I worked around the same bug in Windows in platform.posixfile [1]. Should this be done in the posix layer (which is currently only an alias to open())? It looks like there are uses of posixfile outside of vfs.

Jun 20 2019, 9:17 PM

Jun 18 2019

mharbison72 added a comment to D6490: commit: add --force-close-branch flag to close a non-head changeset.
In D6490#95305, @pulkit wrote:

I think adding a --force flag to hg commit is not a nice option. force can mean a lot of things and here except in closing the non-head changeset, it is no-op.
For example, I am in middle of a rebase, tried to commit, it says rebase in progress. I see there is a --force flag, I try to use that to force the commit.
We can do one of the following:

  1. maybe a more specific flag name like --allow-close-branch or something like that
  2. a config option instead of a flag name
Jun 18 2019, 9:44 AM

Jun 14 2019

mharbison72 committed rHGed9a99564051: lfs: correct an error in the TODO file.
lfs: correct an error in the TODO file
Jun 14 2019, 8:52 PM
mharbison72 committed rHG561cd02c58ff: cat: don't prefetch files unless the output requires it.
cat: don't prefetch files unless the output requires it
Jun 14 2019, 8:51 PM

Jun 13 2019

mharbison72 added a comment to D6448: help: add help entry for internals.mergestate.

This needs some fixups to keep test-help.t and the Windows installer happy:

Jun 13 2019, 12:32 PM

Jun 12 2019

mharbison72 added a comment to D6512: phabricator: add --blocker argument to phabsend to specify blocking reviewers.

LGTM. Thanks for doing this.

Jun 12 2019, 12:37 PM

Jun 10 2019

mharbison72 accepted D6490: commit: add --force-close-branch flag to close a non-head changeset.

Minor nit that I don't care too much about, but I'm wondering what others think of not-head changeset vs non-head changeset. The latter sounds more natural to me, but I'm not sure if there's another example of this phrasing.

Jun 10 2019, 7:48 PM

Jun 7 2019

mharbison72 requested changes to D6490: commit: add --force-close-branch flag to close a non-head changeset.
Jun 7 2019, 1:26 PM

May 25 2019

mharbison72 committed rHGc3484ddbdb96: manifest: add some documentation to _lazymanifest python code.
manifest: add some documentation to _lazymanifest python code
May 25 2019, 10:09 PM
mharbison72 committed rHG0546ead39a7e: manifest: avoid corruption by dropping removed files with pure (issue5801).
manifest: avoid corruption by dropping removed files with pure (issue5801)
May 25 2019, 10:09 PM
mharbison72 committed rHG89c0c8edc9d4: tests: demonstrate broken manifest generation with the pure module.
tests: demonstrate broken manifest generation with the pure module
May 25 2019, 10:08 PM

May 19 2019

mharbison72 committed rHG832c59d1196e: templater: drop support for old style keywords (API).
templater: drop support for old style keywords (API)
May 19 2019, 7:48 PM
mharbison72 committed rHGfa4b13e81f60: commands: drop support for legacy ^cmd registration (API).
commands: drop support for legacy ^cmd registration (API)
May 19 2019, 7:48 PM
mharbison72 committed rHG38b7b45627a2: extensions: drop support for extsetup() without `ui` argument (API).
extensions: drop support for extsetup() without `ui` argument (API)
May 19 2019, 7:48 PM

May 13 2019

mharbison72 closed D6371: record: avoid modifying the matcher passed as a method parameter.
May 13 2019, 7:56 PM
mharbison72 committed rHG19b95afb0c01: record: avoid modifying the matcher passed as a method parameter.
record: avoid modifying the matcher passed as a method parameter
May 13 2019, 7:56 PM
mharbison72 added a comment to D6355: shelve: add `update --shelve` if shelve extension is loaded.

Should this abort if subrepos are present, since you can't shelve a subrepo? No -S is available on update, but maybe looking for .hgsub with any contents is good enough?

May 13 2019, 2:07 PM
mharbison72 added a comment to D6355: shelve: add `update --shelve` if shelve extension is loaded.

Should this abort if subrepos are present, since you can't shelve a subrepo? No -S is available on update, but maybe looking for .hgsub with any contents is good enough?

May 13 2019, 9:36 AM

May 11 2019

mharbison72 created D6371: record: avoid modifying the matcher passed as a method parameter.
May 11 2019, 10:56 PM

May 9 2019

mharbison72 added a comment to D5981: tests: drop a few unnecessary "(glob)".

I had forgotten about this patch and it's not very important anyway. I don't know how I'm supposed to fix it, so I'll just drop. @mharbison72, let me know if there was something else I should have done.

May 9 2019, 11:06 PM

May 7 2019

mharbison72 committed rHGe45c6b153e51: commit: allow --interactive to work again when naming a directory (issue6131).
commit: allow --interactive to work again when naming a directory (issue6131)
May 7 2019, 9:31 AM

May 6 2019

mharbison72 added a comment to D6255: copies: calculate mergecopies() based on pathcopies().

This might break --pure without --local in the annotate tests. No idea if that's a valid combination, but the buildbots (mostly) use that. In fairness, it seems that this combination had an error where _filecommit() was given too many arguments in the direct ancestors, so maybe the real breakage occurred in there. But there seems to be extra output here.

May 6 2019, 11:41 PM

May 4 2019

mharbison72 committed rHG1756859a65fa: lfs: add a TODO file.
lfs: add a TODO file
May 4 2019, 10:36 AM

Apr 30 2019

mharbison72 committed rHGca762c2bbe6b: obsolete: drop the legacy `_enabled` variable.
obsolete: drop the legacy `_enabled` variable
Apr 30 2019, 12:46 AM

Apr 27 2019

mharbison72 committed rHG723ed4402896: inno: bump keyring to 18.0.1 to avoid AttributeError (issue6043).
inno: bump keyring to 18.0.1 to avoid AttributeError (issue6043)
Apr 27 2019, 12:24 AM

Apr 9 2019

mharbison72 added a comment to D6196: cext: make revlog.c PY_SSIZE_T_CLEAN.
In D6196#90521, @yuja wrote:
4   org.python.python             	0x00000001000eb761 va_build_value + 737
5   org.python.python             	0x00000001000eb837 _Py_BuildValue_SizeT + 167

Maybe we shouldn't trust the Python doc too much, which says 's#' of
Py_BuildValue() takes an int.
https://docs.python.org/2/c-api/arg.html#c.Py_BuildValue
Can you test if this patch fixes the problem?

diff --git a/mercurial/cext/parsers.c b/mercurial/cext/parsers.c
--- a/mercurial/cext/parsers.c
+++ b/mercurial/cext/parsers.c
@@ -184,7 +184,8 @@ static PyObject *parse_dirstate(PyObject
 		goto quit;
 	}
-	parents = Py_BuildValue(PY23("s#s#", "y#y#"), str, 20, str + 20, 20);
+	parents = Py_BuildValue(PY23("s#s#", "y#y#"), str, (Py_ssize_t)20,
+	                        str + 20, (Py_ssize_t)20);
 	if (!parents) {
 		goto quit;
 	}
diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -366,7 +366,7 @@ static PyObject *index_get(indexObject *
 	entry = Py_BuildValue(tuple_format, offset_flags, comp_len, uncomp_len,
 	                      base_rev, link_rev, parent_1, parent_2, c_node_id,
-	                      20);
+	                      (Py_ssize_t)20);
 	if (entry) {
 		PyObject_GC_UnTrack(entry);
@@ -3017,8 +3017,9 @@ void revlog_module_init(PyObject *mod)
 	PyModule_AddObject(mod, "nodetree", (PyObject *)&nodetreeType);
 	if (!nullentry) {
-		nullentry = Py_BuildValue(PY23("iiiiiiis#", "iiiiiiiy#"), 0, 0,
-		                          0, -1, -1, -1, -1, nullid, 20);
+		nullentry =
+		    Py_BuildValue(PY23("iiiiiiis#", "iiiiiiiy#"), 0, 0, 0, -1,
+		                  -1, -1, -1, nullid, (Py_ssize_t)20);
 	}
 	if (nullentry)
 		PyObject_GC_UnTrack(nullentry);
Apr 9 2019, 12:51 PM

Apr 8 2019

mharbison72 committed rHG57645939df59: packaging: ensure that --python is an absolute path when building on Windows.
packaging: ensure that --python is an absolute path when building on Windows
Apr 8 2019, 2:50 PM
mharbison72 committed rHG9c07d345fd6d: packaging: don't crash building wix with python3.6 and earlier.
packaging: don't crash building wix with python3.6 and earlier
Apr 8 2019, 2:50 PM
mharbison72 added a comment to D6196: cext: make revlog.c PY_SSIZE_T_CLEAN.

I don't have time to look into this, but this makes the mac builds very unhappy. (The parent runs fine.) Somehow the bot is still running, but recording various segfaults. When I tried to investigate, the build process fails because python hg version is segfaulting. Here's the output of that, with the initial python frames removed:

Apr 8 2019, 12:32 PM

Apr 6 2019

mharbison72 committed rHG456c37433c43: py3: write out hgextindex as bytes in setup.py.
py3: write out hgextindex as bytes in setup.py
Apr 6 2019, 8:42 PM

Apr 5 2019

mharbison72 committed rHG7cfd20bc0721: py3: write out hgextindex as bytes in setup.py.
py3: write out hgextindex as bytes in setup.py
Apr 5 2019, 9:11 PM

Apr 2 2019

mharbison72 committed rHGf4147ca63d39: uncommit: abort if an explicitly given file cannot be uncommitted (BC).
uncommit: abort if an explicitly given file cannot be uncommitted (BC)
Apr 2 2019, 6:40 PM

Mar 23 2019

mharbison72 committed rHGdb26dbbee74d: diff: support diffing explicit files in subrepos.
diff: support diffing explicit files in subrepos
Mar 23 2019, 9:10 PM

Mar 21 2019

mharbison72 added a comment to D6140: revset: add new contiguous(x) function for "x::x".

Josef 'Jeff' Sipek <jeffpc@josefsipek.net> sent this to mercurial-devel. I'm adding it here for reference.
I read this doc string and the patch intro several times, and every time I
concluded that this function was useless. Only after reading some of the
other replies, did I realize that "x" here can be a set.

The docstring does say "in the set" :) But I agree that it's not very clear. I copied the pattern from other functions. I would probably have said "in the input set" otherwise. Do you think that would have been clearer? We could make that change to all the existing cases of plain "set" referring to the input.

Mar 21 2019, 12:16 AM

Mar 19 2019

mharbison72 added a comment to D6140: revset: add new contiguous(x) function for "x::x".

I've only used X::X where X was trivial, so I'm still trying to get my mind around this. Out of curiosity, what are the scenarios where a nontrivial X is useful?

Mar 19 2019, 11:36 PM

Mar 18 2019

mharbison72 added a comment to D6148: store: error out if fncache does not ends with a newline.

Is there something that can be done to repair this, that should be suggested in the hint? I've seen fncache errors in the context of a corrupt repo, but I'm not sure what an end user would do with this message.

Mar 18 2019, 9:40 PM
mharbison72 committed rHG4ea21df312ec: record: prevent commits that don't pick up dirty subrepo changes (issue6102).
record: prevent commits that don't pick up dirty subrepo changes (issue6102)
Mar 18 2019, 8:18 AM

Mar 16 2019

mharbison72 added inline comments to D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 16 2019, 6:31 PM

Mar 15 2019

mharbison72 added a comment to D6142: automation: perform tasks on remote machines.

I don't know anything about PowerShell or AWS, but this series looks nice for making Windows easier to deal with.

Mar 15 2019, 11:23 PM

Mar 14 2019

mharbison72 requested changes to D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 14 2019, 12:47 PM

Mar 11 2019

mharbison72 added inline comments to D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 11 2019, 12:28 PM

Mar 10 2019

mharbison72 committed rHG35e29a3aa441: tests: stabilize test-bundle.t on Windows.
tests: stabilize test-bundle.t on Windows
Mar 10 2019, 6:28 PM

Mar 9 2019

mharbison72 committed rHG0cbcb3e13fcf: tests: stabilize test-split.t for Windows.
tests: stabilize test-split.t for Windows
Mar 9 2019, 8:50 PM
mharbison72 added a comment to D6082: phabricator: add a `--branch` flag to `hg phabsend`.
In D6082#88981, @Kwan wrote:
In D6082#88851, @pulkit wrote:

@mharbison72 thanks for tips on adding test. Will add tests in next iteration.
I found that Differentials do have a branch field, maybe we can use that? https://secure.phabricator.com/source/phabricator/browse/master/src/applications/differential/customfield/DifferentialBranchField.php

Seems worth a shot. I don’t know anything about it, but presumably this would be rendered specially in the web UI, like the test plan, etc. That sounds better than as a follow up comment. It also seems natural enough that maybe it can be done unconditionally, instead of needing the argument.

Yeah, it shows in the Diff Detail pane, like here. Unfortunately I think it can be only set when using the creatediff endpoint, which is what I had to change my fork to do (though I could be wrong, the conduit docs are too sparse to be sure).

Mar 9 2019, 1:27 PM

Mar 8 2019

mharbison72 committed rHGe82c932c01e3: tests: stabilize test-share.t on Windows.
tests: stabilize test-share.t on Windows
Mar 8 2019, 8:26 PM
mharbison72 added a comment to D6082: phabricator: add a `--branch` flag to `hg phabsend`.
In D6082#88851, @pulkit wrote:

@mharbison72 thanks for tips on adding test. Will add tests in next iteration.
I found that Differentials do have a branch field, maybe we can use that? https://secure.phabricator.com/source/phabricator/browse/master/src/applications/differential/customfield/DifferentialBranchField.php

Mar 8 2019, 6:12 PM

Mar 7 2019

mharbison72 added inline comments to D6069: uncommit: add flag --allow-dirty-working-copy.
Mar 7 2019, 12:38 PM
mharbison72 added a comment to D6082: phabricator: add a `--branch` flag to `hg phabsend`.

To create a test, you need to pip install pytest-vcr, edit auth.hgphab.phabtoken at the top of the test, and use --test-vcr with your hg phabsend command. See a641fd1a1196 for some background, and remember to purge your phabtoken from the changes before posting. FWIW, I used a VirtualBox VM running Phabricator from Bitnami to figure things out before generating the test on phab.m-s.o to avoid extra noise.

Mar 7 2019, 12:35 PM

Mar 4 2019

mharbison72 added a comment to rHG38de3300414f: py3: convert filtername to str if it's None.

There are a handful of other places in branchmap and elsewhere that also log or format repo.filtername.

Mar 4 2019, 11:10 PM

Mar 2 2019

mharbison72 added inline comments to D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 2 2019, 1:01 AM

Feb 27 2019

mharbison72 committed rHGe0a3ee3fdb33: tests: add more wildcards to test-extdiff.t.
tests: add more wildcards to test-extdiff.t
Feb 27 2019, 7:50 PM

Feb 22 2019

mharbison72 added inline comments to D5299: phabricator: fallback reading arcanist config files.
Feb 22 2019, 12:59 PM

Feb 20 2019

mharbison72 committed rHGa62690659d6b: tests: add a missing abort exit code on Windows in test-audit-subrepo.t.
tests: add a missing abort exit code on Windows in test-audit-subrepo.t
Feb 20 2019, 9:37 PM

Feb 19 2019

mharbison72 committed rHG92055d539e49: tests: conditionalize msys path mangling in test-bundle.t.
tests: conditionalize msys path mangling in test-bundle.t
Feb 19 2019, 11:06 AM
mharbison72 committed rHG19d8d6856338: tests: glob over quoting differences in test-blackbox.t for Windows.
tests: glob over quoting differences in test-blackbox.t for Windows
Feb 19 2019, 11:06 AM
mharbison72 added a comment to D5981: tests: drop a few unnecessary "(glob)".

The tests run clean with this.
But I'm a bit confused. The test harness has been doing '\' -> '/' conversion without (glob) now for a little over a year, and it complains if there's a trailing (glob) and no '\' -> '/' conversion. That's not been happening here, and made me suspicious. These globs predate that functionality slightly, so I'm not sure the meaning of the referenced commit (which seems to say nothing will change because ui.slash is set).

You're right, and even if I go back to bdcaf612e75a (where you added these globs), it seems like it should have been converted to slashes already there (because the test runner set ui.slash back then, too, and the code seemed to respect that). Do you have time to go back and see if the globbing was never needed?

Feb 19 2019, 10:14 AM

Feb 18 2019

mharbison72 added a comment to D5981: tests: drop a few unnecessary "(glob)".

The tests run clean with this.

Feb 18 2019, 12:32 PM
mharbison72 committed rHGeb8a8af4cbd0: tests: correct the remaining fallout from recent path style changes on Windows.
tests: correct the remaining fallout from recent path style changes on Windows
Feb 18 2019, 12:13 AM

Feb 17 2019

mharbison72 added a comment to D5801: files: respect ui.relative-paths.

I noticed another bug and sent D5978. Maybe your test failure is because you're using the eol extension? I don't know what else would cause the \r in contrib.perf. I have no idea how that's related to this patch, though.

The \r is how output normally is on Windows. The test harness accounts for this when matching lines, but displays the actual output (with \r) when there are differences. The eol extension isn’t configured on this machine, but the custom HGRCPATH content from the test harness would override that anyway.

Ah, so the only difference is the extra "import newer module separately in try clause for early Mercurial" in contrib/perf.py then. This patch didn't change that file. Can you check again that it was this patch that caused that and that it's not just flaky?

Feb 17 2019, 5:52 PM
mharbison72 added a comment to D5801: files: respect ui.relative-paths.

I noticed another bug and sent D5978. Maybe your test failure is because you're using the eol extension? I don't know what else would cause the \r in contrib.perf. I have no idea how that's related to this patch, though.

Feb 17 2019, 3:15 PM

Feb 16 2019

mharbison72 added a comment to D5898: debugignore: respect ui.relative-paths.

This seems to have converted a test from dos to unix style. I'm not sure if that was intentional, or if this feature is still a WIP. (Sorry, I've been busy lately, and haven't had time to follow this closely)

Feb 16 2019, 10:53 PM
mharbison72 added a comment to D5801: files: respect ui.relative-paths.

For some reason, this breaks test-contrib-perf.t:

Feb 16 2019, 10:45 PM

Feb 7 2019

mharbison72 committed rHG698667eb7523: lfs: disable all authentication except Basic for HTTP(S) connections.
lfs: disable all authentication except Basic for HTTP(S) connections
Feb 7 2019, 11:02 AM
mharbison72 committed rHG67e622ade415: tests: stabilize test-extdiff.t on Windows.
tests: stabilize test-extdiff.t on Windows
Feb 7 2019, 11:02 AM
mharbison72 committed rHGa263b7d71105: tests: stabilize test-extdiff.t on Windows.
tests: stabilize test-extdiff.t on Windows
Feb 7 2019, 7:21 AM
mharbison72 committed rHG98930b0a645a: lfs: disable all authentication except Basic for HTTP(S) connections.
lfs: disable all authentication except Basic for HTTP(S) connections
Feb 7 2019, 7:21 AM