Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (170 w, 2 d)

Recent Activity

Mon, Oct 19

mharbison72 created D9229: rebase: update commit hash references in the new commits.
Mon, Oct 19, 11:38 PM

Thu, Oct 15

mharbison72 closed D9206: posix: avoid a leaked file descriptor in a unix domain socket exception case.
Thu, Oct 15, 8:38 AM
mharbison72 committed rHG87c35b5a14eb: posix: avoid a leaked file descriptor in a unix domain socket exception case.
posix: avoid a leaked file descriptor in a unix domain socket exception case
Thu, Oct 15, 8:38 AM
mharbison72 closed D9205: posix: use context managers in a couple of places.
Thu, Oct 15, 8:38 AM
mharbison72 committed rHG755214a84b9d: posix: use context managers in a couple of places.
posix: use context managers in a couple of places
Thu, Oct 15, 8:38 AM

Wed, Oct 14

mharbison72 created D9206: posix: avoid a leaked file descriptor in a unix domain socket exception case.
Wed, Oct 14, 12:24 PM
mharbison72 created D9205: posix: use context managers in a couple of places.
Wed, Oct 14, 12:24 PM
mharbison72 closed D9183: fix: update commit hash references in the new commits.
Wed, Oct 14, 4:07 AM
mharbison72 closed D9182: absorb: update commit hash references in the new commits.
Wed, Oct 14, 4:07 AM
mharbison72 committed rHG04de8a1ec08f: fix: update commit hash references in the new commits.
fix: update commit hash references in the new commits
Wed, Oct 14, 4:07 AM
mharbison72 committed rHG0a330055340c: absorb: update commit hash references in the new commits.
absorb: update commit hash references in the new commits
Wed, Oct 14, 4:07 AM
mharbison72 committed rHG3d68b47e461b: rewriteutil: handle dropped commits when updating description hashes.
rewriteutil: handle dropped commits when updating description hashes
Wed, Oct 14, 4:07 AM
mharbison72 closed D9181: rewriteutil: handle dropped commits when updating description hashes.
Wed, Oct 14, 4:07 AM

Fri, Oct 9

mharbison72 created D9183: fix: update commit hash references in the new commits.
Fri, Oct 9, 12:22 PM
mharbison72 created D9182: absorb: update commit hash references in the new commits.
Fri, Oct 9, 12:22 PM
mharbison72 created D9181: rewriteutil: handle dropped commits when updating description hashes.
Fri, Oct 9, 12:22 PM

Sep 9 2020

mharbison72 committed rHG78861610ded8: rewriteutil: relax the sha1 hash references to handle future hash types.
rewriteutil: relax the sha1 hash references to handle future hash types
Sep 9 2020, 10:13 PM
mharbison72 committed rHG1a5d3e555c70: phabricator: update the hashes in commit messages as they get submitted.
phabricator: update the hashes in commit messages as they get submitted
Sep 9 2020, 10:13 PM
mharbison72 committed rHGf7e293e0475f: rewriteutil: also consider pending obsoletes when updating hashes in messages.
rewriteutil: also consider pending obsoletes when updating hashes in messages
Sep 9 2020, 10:13 PM
mharbison72 committed rHG0a57ef4b3bdb: rewriteutil: extract evolve code used to replace obsolete hashes in commits.
rewriteutil: extract evolve code used to replace obsolete hashes in commits
Sep 9 2020, 10:13 PM

Sep 8 2020

mharbison72 closed D8950: phabricator: update the hashes in commit messages as they get submitted.
Sep 8 2020, 8:08 AM
mharbison72 closed D8951: rewriteutil: relax the sha1 hash references to handle future hash types.
Sep 8 2020, 8:08 AM
mharbison72 committed rHG0babbc33baec: rewriteutil: relax the sha1 hash references to handle future hash types.
rewriteutil: relax the sha1 hash references to handle future hash types
Sep 8 2020, 8:08 AM
mharbison72 committed rHG68bfd9e415b5: phabricator: update the hashes in commit messages as they get submitted.
phabricator: update the hashes in commit messages as they get submitted
Sep 8 2020, 8:08 AM
mharbison72 committed rHG2b89313a2263: rewriteutil: extract evolve code used to replace obsolete hashes in commits.
rewriteutil: extract evolve code used to replace obsolete hashes in commits
Sep 8 2020, 8:08 AM
mharbison72 committed rHGb65a3d50aa7b: rewriteutil: also consider pending obsoletes when updating hashes in messages.
rewriteutil: also consider pending obsoletes when updating hashes in messages
Sep 8 2020, 8:08 AM
mharbison72 closed D8949: rewriteutil: also consider pending obsoletes when updating hashes in messages.
Sep 8 2020, 8:07 AM
mharbison72 closed D8948: rewriteutil: extract evolve code used to replace obsolete hashes in commits.
Sep 8 2020, 8:07 AM
mharbison72 closed D8980: repoview: pin revisions for `local` and `other` when a merge is active.
Sep 8 2020, 4:33 AM
mharbison72 committed rHGaaeccdb6e654: repoview: pin revisions for `local` and `other` when a merge is active.
repoview: pin revisions for `local` and `other` when a merge is active
Sep 8 2020, 4:33 AM

Sep 5 2020

mharbison72 added a comment to D8457: [RFC] metadataonlyctx: demonstrate an error reusing manifest nodes.

Bug filed here: https://bz.mercurial-scm.org/show_bug.cgi?id=6305

Sep 5 2020, 1:39 PM

Sep 4 2020

mharbison72 added a comment to D8980: repoview: pin revisions for `local` and `other` when a merge is active.

I'm not sure if the other op_state files need similar treatment. The fact that this catches a rebase mid operation makes me think this will cover everything.

Sep 4 2020, 8:42 PM
mharbison72 created D8980: repoview: pin revisions for `local` and `other` when a merge is active.
Sep 4 2020, 5:44 PM
mharbison72 updated the diff for D8950: phabricator: update the hashes in commit messages as they get submitted.
Sep 4 2020, 2:20 PM
mharbison72 updated the diff for D8951: rewriteutil: relax the sha1 hash references to handle future hash types.
Sep 4 2020, 2:19 PM
mharbison72 updated the diff for D8949: rewriteutil: also consider pending obsoletes when updating hashes in messages.
Sep 4 2020, 2:19 PM
mharbison72 updated the diff for D8948: rewriteutil: extract evolve code used to replace obsolete hashes in commits.
Sep 4 2020, 2:19 PM

Sep 2 2020

mharbison72 closed D8976: registrar: fix a documentation typo.
Sep 2 2020, 12:03 PM
mharbison72 committed rHG6a0e7bf73bb2: registrar: fix a documentation typo.
registrar: fix a documentation typo
Sep 2 2020, 12:03 PM

Sep 1 2020

mharbison72 created D8976: registrar: fix a documentation typo.
Sep 1 2020, 10:32 PM
mharbison72 added a comment to D8975: genosxversion: don't give up if we can't find a path to hg libraries.

Yeah, I remember hitting this too.

Sep 1 2020, 11:39 AM

Aug 29 2020

mharbison72 added a comment to D8524: phabricator: add .arcconfig to help messages and comments (issue6331).
In D8524#134326, @sfink wrote:

The documentation updates look good to me, but there are still some code changes that were probably not intentional, and the commit message probably needs an update.

I updated the commit message to "add .arcconfig to help messages and comments", which seems accurate.

Aug 29 2020, 5:46 PM
D8524: phabricator: add .arcconfig to help messages and comments (issue6331) now requires changes to proceed.

The documentation updates look good to me, but there are still some code changes that were probably not intentional, and the commit message probably needs an update.

Aug 29 2020, 1:28 PM

Aug 27 2020

mharbison72 committed rHGc25efc468a49: mercurial: force LF endings for *.py, *.{c,h} and *.t in .editorconfig.
mercurial: force LF endings for *.py, *.{c,h} and *.t in .editorconfig
Aug 27 2020, 10:10 AM
mharbison72 added a comment to D8948: rewriteutil: extract evolve code used to replace obsolete hashes in commits.

There are already a mercurial/rewriteutils.py files I think it should go there

So that causes a cycle:

--- c:/Users/Matt/hg/tests/test-check-module-imports.t
+++ c:/Users/Matt/hg/tests/test-check-module-imports.t.err
@@ -38,3 +38,5 @@
   > -X tests/test-imports-checker.t \
   > -X tests/test-verify-repo-operations.py \
   > | sed 's-\\-/-g' | "$PYTHON" "$import_checker" -
+  Import cycle: mercurial.cmdutil -> mercurial.rewriteutil -> mercurial.localrepo -> mercurial.extensions -> mercurial.cmdutil\r (esc)
+  [1]

That is really only used for type checking, so is that safe to move under if pycompat.TYPE_CHECKING: with the typing related imports, or is there another way to do this? Or should I just drop the type checking?

I am a bit confused about your question. What is "That" ?

Aug 27 2020, 8:24 AM
mharbison72 closed D8947: mercurial: force LF endings for *.py, *.{c,h} and *.t in .editorconfig.
Aug 27 2020, 4:48 AM
mharbison72 committed rHGababd5a7d532: mercurial: force LF endings for *.py, *.{c,h} and *.t in .editorconfig.
mercurial: force LF endings for *.py, *.{c,h} and *.t in .editorconfig
Aug 27 2020, 4:48 AM

Aug 26 2020

mharbison72 added a comment to D8948: rewriteutil: extract evolve code used to replace obsolete hashes in commits.

There are already a mercurial/rewriteutils.py files I think it should go there

Aug 26 2020, 7:34 PM
mharbison72 added a comment to D8948: rewriteutil: extract evolve code used to replace obsolete hashes in commits.

There are already a mercurial/rewriteutils.py files I think it should go there

Aug 26 2020, 3:30 PM

Aug 25 2020

mharbison72 created D8951: rewriteutil: relax the sha1 hash references to handle future hash types.
Aug 25 2020, 11:21 PM

Aug 24 2020

mharbison72 created D8950: phabricator: update the hashes in commit messages as they get submitted.
Aug 24 2020, 7:08 PM
mharbison72 created D8949: rewriteutil: also consider pending obsoletes when updating hashes in messages.
Aug 24 2020, 7:08 PM
mharbison72 created D8947: mercurial: force LF endings for *.py, *.{c,h} and *.t in .editorconfig.
Aug 24 2020, 7:08 PM
mharbison72 created D8948: rewriteutil: extract evolve code used to replace obsolete hashes in commits.
Aug 24 2020, 7:08 PM
mharbison72 added a comment to D8946: 133c1c6c6449 is my parent (generate test for phabsend).

phabsend test generation

Aug 24 2020, 6:46 PM
mharbison72 added a comment to D8945: base review (generate test for phabsend).

phabsend test generation

Aug 24 2020, 6:45 PM
mharbison72 created D8946: 133c1c6c6449 is my parent (generate test for phabsend).
Aug 24 2020, 6:18 PM
mharbison72 created D8945: base review (generate test for phabsend).
Aug 24 2020, 6:18 PM
mharbison72 added a comment to D8944: 133c1c6c6449 is my parent (generate test for phabsend).

phabsend test generation

Aug 24 2020, 4:39 PM
mharbison72 added a comment to D8943: base review (generate test for phabsend).

phabsend test generation

Aug 24 2020, 4:39 PM
mharbison72 created D8944: 133c1c6c6449 is my parent (generate test for phabsend).
Aug 24 2020, 4:30 PM
mharbison72 created D8943: base review (generate test for phabsend).
Aug 24 2020, 4:30 PM

Jul 17 2020

mharbison72 committed rHGb3b0cd8b9366: phabricator: clarify the multiple heads/roots error message for phabsend.
phabricator: clarify the multiple heads/roots error message for phabsend
Jul 17 2020, 2:05 PM
mharbison72 closed D8761: phabricator: clarify the multiple heads/roots error message for phabsend.
Jul 17 2020, 2:05 PM

Jul 16 2020

mharbison72 created D8761: phabricator: clarify the multiple heads/roots error message for phabsend.
Jul 16 2020, 2:19 PM
mharbison72 closed D8756: phabupdate: allow resigning from revisions.
Jul 16 2020, 12:55 PM
mharbison72 closed D8755: phabupdate: allow revisions to be commandeered.
Jul 16 2020, 12:55 PM
mharbison72 committed rHGc59e7bed8924: phabupdate: allow resigning from revisions.
phabupdate: allow resigning from revisions
Jul 16 2020, 12:55 PM
mharbison72 closed D8754: phabupdate: allow revisions to be reopened.
Jul 16 2020, 12:55 PM
mharbison72 committed rHG383b8c77096d: phabupdate: allow revisions to be commandeered.
phabupdate: allow revisions to be commandeered
Jul 16 2020, 12:55 PM
mharbison72 committed rHG2010f3143062: phabupdate: allow revisions to be reopened.
phabupdate: allow revisions to be reopened
Jul 16 2020, 12:55 PM
mharbison72 closed D8751: phabupdate: allow revisions to be marked with "plan changes".
Jul 16 2020, 12:55 PM
mharbison72 closed D8753: phabupdate: allow revisions to be marked "closed".
Jul 16 2020, 12:55 PM
mharbison72 closed D8752: phabupdate: allows revisions to be marked "request-review".
Jul 16 2020, 12:55 PM
mharbison72 committed rHG3ad0855cc602: phabupdate: allow revisions to be marked "closed".
phabupdate: allow revisions to be marked "closed"
Jul 16 2020, 12:54 PM
mharbison72 committed rHG1ff5070c0ab4: phabupdate: allows revisions to be marked "request-review".
phabupdate: allows revisions to be marked "request-review"
Jul 16 2020, 12:54 PM
mharbison72 committed rHG225588c4c255: phabupdate: allow revisions to be marked with "plan changes".
phabupdate: allow revisions to be marked with "plan changes"
Jul 16 2020, 12:54 PM
mharbison72 added a comment to rHG5d09a120b4be: extensions: make `hg nonexistent` not crash with PyOxidizer.

I'm fine if other reviewers want to de-queue this patch, but maybe it's good to have it queued for now in case I don't end up with a good solution for the __index__.py-based fix soon.

Jul 16 2020, 2:17 AM

Jul 15 2020

mharbison72 added a comment to rHG5d09a120b4be: extensions: make `hg nonexistent` not crash with PyOxidizer.

I just wanted to point out that there's an __index__.py that gets generated in the py2exe case to handle some of this extension stuff when they aren't in the filesystem. I poked at this a bit 6 months ago or so, but was under the impression that PyOxidizer would eventually grow the capability to iterate over *.py resources, so didn't submit anything. Is that also your thinking, and this is a stopgap?

Jul 15 2020, 11:34 PM
mharbison72 created D8756: phabupdate: allow resigning from revisions.
Jul 15 2020, 2:23 PM
mharbison72 created D8755: phabupdate: allow revisions to be commandeered.
Jul 15 2020, 2:23 PM
mharbison72 created D8754: phabupdate: allow revisions to be reopened.
Jul 15 2020, 2:23 PM
mharbison72 created D8753: phabupdate: allow revisions to be marked "closed".
Jul 15 2020, 2:23 PM
mharbison72 created D8752: phabupdate: allows revisions to be marked "request-review".
Jul 15 2020, 2:23 PM
mharbison72 created D8751: phabupdate: allow revisions to be marked with "plan changes".
Jul 15 2020, 1:32 PM
mharbison72 planned changes to D6876: phabricator: support automatically obsoleting old revisions of pulled commits.
Jul 15 2020, 1:23 PM

Jul 11 2020

mharbison72 committed rHG9a062913bab6: tests: stablize test-serve.t on Windows.
tests: stablize test-serve.t on Windows
Jul 11 2020, 4:47 AM

Jul 10 2020

mharbison72 committed rHG8c06f479cfc1: tests: stablize test-serve.t on Windows.
tests: stablize test-serve.t on Windows
Jul 10 2020, 6:47 AM
mharbison72 closed D8720: tests: stablize test-serve.t on Windows.
Jul 10 2020, 6:47 AM

Jul 9 2020

mharbison72 created D8720: tests: stablize test-serve.t on Windows.
Jul 9 2020, 11:13 PM

Jun 29 2020

mharbison72 closed D8671: version: sort extensions by name in verbose mode.
Jun 29 2020, 6:32 AM
mharbison72 committed rHGe1ea913da2ed: version: sort extensions by name in verbose mode.
version: sort extensions by name in verbose mode
Jun 29 2020, 6:31 AM

Jun 28 2020

mharbison72 created D8671: version: sort extensions by name in verbose mode.
Jun 28 2020, 3:29 PM

Jun 5 2020

mharbison72 closed D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
Jun 5 2020, 11:14 PM
mharbison72 committed rHG1f114c797961: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291)
Jun 5 2020, 11:14 PM
mharbison72 closed D8488: tests: show that rebase --dry-run and --confirm wipeout uncommitted changes.
Jun 5 2020, 11:14 PM
mharbison72 committed rHG9f3aa0d3de41: tests: show that rebase --dry-run and --confirm wipeout uncommitted changes.
tests: show that rebase --dry-run and --confirm wipeout uncommitted changes
Jun 5 2020, 11:13 PM

May 16 2020

mharbison72 added a comment to D8524: phabricator: add .arcconfig to help messages and comments (issue6331).

I'll try to take a closer look at this some time this weekend. In the meantime, can you explain more why it didn't work for you? There are tests that cover this feature, so I'm wondering if some coverage is missing.

May 16 2020, 1:04 PM
mharbison72 added inline comments to D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
May 16 2020, 12:08 PM

May 7 2020

mharbison72 committed rHGa50f33f1ff24: url: fix a bytes vs str crash in processing proxy headers (issue6249).
url: fix a bytes vs str crash in processing proxy headers (issue6249)
May 7 2020, 11:43 AM