Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (130 w, 6 d)

Recent Activity

Yesterday

mharbison72 created D7950: verify: avoid spurious integrity warnings in verbose mode (issue6172).
Sat, Jan 18, 7:37 PM

Fri, Jan 17

mharbison72 created D7936: help: minor copy editing to the `config.format` section.
Fri, Jan 17, 9:29 PM
mharbison72 added a comment to D7920: tests: restore phabricator tests and regenerate the recordings.

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

Fri, Jan 17, 9:03 PM
mharbison72 added a comment to D7920: tests: restore phabricator tests and regenerate the recordings.

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

--- d:/mercurial/tests/test-phabricator.t
+++ d:/mercurial/tests/test-phabricator.t.err
@@ -56,7 +56,10 @@
   $ echo alpha > alpha
   $ hg ci --addremove -m 'create alpha for phabricator test Ç'
   adding alpha
-
+  transaction abort!
+  rollback completed
+  abort: decoding near 'ator test \x80': 'utf8' codec can't decode byte 0x80 in position 34: invalid start byte! (esc)
+  [255]
 A bad .arcconfig doesn't error out
   $ echo 'garbage' > .arcconfig
   $ hg config phabricator --debug
ERROR: test-phabricator.t output changed

So I'm not sure if there is a phabsend or phabread issue.

Fri, Jan 17, 5:51 PM
mharbison72 created D7935: phabricator: use .arcconfig for `phabricator.url` if not set locally.
Fri, Jan 17, 5:47 PM
mharbison72 created D7934: phabricator: use .arcconfig for the callsign if not set locally (issue6243).
Fri, Jan 17, 5:47 PM
mharbison72 created D7933: config: add a function to insert non-file based, but overridable settings.
Fri, Jan 17, 5:47 PM
mharbison72 added a comment to D7920: tests: restore phabricator tests and regenerate the recordings.

I did hg phabread D7920 | hg import --bypass - on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

Fri, Jan 17, 5:13 PM
mharbison72 closed D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008.
Fri, Jan 17, 7:21 AM
mharbison72 committed rHGb4420cea45e8: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008.
sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008
Fri, Jan 17, 7:21 AM

Thu, Jan 16

mharbison72 created D7920: tests: restore phabricator tests and regenerate the recordings.
Thu, Jan 16, 8:19 PM
mharbison72 added a comment to D7913: cext: fix compiler warning about sign changing.

LGTM

Thu, Jan 16, 8:03 PM
mharbison72 added a comment to D7919: create comment for phabricator test.

Noise from regenerating the phabricator recordings.

Thu, Jan 16, 7:52 PM
mharbison72 added a comment to D7918: create draft change for phabricator testing.

Noise from regenerating the phabricator recordings.

Thu, Jan 16, 7:51 PM
mharbison72 added a comment to D7917: create public change for phabricator testing.

Noise from regenerating the phabricator recordings.

Thu, Jan 16, 7:51 PM
mharbison72 added a comment to D7916: create beta for phabricator test.

Noise from regenerating the phabricator recordings.

Thu, Jan 16, 7:51 PM
mharbison72 added a comment to D7915: create alpha for phabricator test €.

Noise from regenerating the phabricator recordings.

Thu, Jan 16, 7:50 PM
mharbison72 added a comment to D7919: create comment for phabricator test.

Address review comments

Thu, Jan 16, 7:33 PM
mharbison72 created D7919: create comment for phabricator test.

For default branch

Thu, Jan 16, 7:33 PM
mharbison72 created D7918: create draft change for phabricator testing.
Thu, Jan 16, 7:32 PM
mharbison72 created D7917: create public change for phabricator testing.
Thu, Jan 16, 7:32 PM
mharbison72 created D7916: create beta for phabricator test.
Thu, Jan 16, 7:32 PM
mharbison72 updated the diff for D7915: create alpha for phabricator test €.
Thu, Jan 16, 7:32 PM
mharbison72 created D7915: create alpha for phabricator test €.
Thu, Jan 16, 7:32 PM
mharbison72 updated the diff for D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008.
Thu, Jan 16, 7:10 PM
mharbison72 added inline comments to D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Thu, Jan 16, 11:49 AM
mharbison72 closed D7816: tests: stabilize test-subrepo-svn.t on Windows.
Thu, Jan 16, 11:32 AM
mharbison72 added a reverting change for rHG991e4404e910: tests: convert the 'file://\$TESTTMP' rule to an automatic substitution: rHGe598c874b4af: tests: stabilize test-subrepo-svn.t on Windows.
Thu, Jan 16, 11:32 AM
mharbison72 added a reverted change for rHGe598c874b4af: tests: stabilize test-subrepo-svn.t on Windows: rHG991e4404e910: tests: convert the 'file://\$TESTTMP' rule to an automatic substitution.
tests: stabilize test-subrepo-svn.t on Windows
Thu, Jan 16, 11:32 AM
mharbison72 added inline comments to D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008.
Thu, Jan 16, 9:34 AM

Wed, Jan 15

mharbison72 created D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008.
Wed, Jan 15, 11:35 PM
mharbison72 closed D7881: lfs: check content length after downloading content.
Wed, Jan 15, 8:18 AM
mharbison72 closed D7882: lfs: avoid quadratic performance in processing server responses.
Wed, Jan 15, 8:17 AM
mharbison72 committed rHGffac09da7a19: lfs: avoid quadratic performance in processing server responses.
lfs: avoid quadratic performance in processing server responses
Wed, Jan 15, 8:17 AM
mharbison72 closed D7880: lfs: rename a variable to clarify its use.
Wed, Jan 15, 8:17 AM
mharbison72 committed rHG0ee0a3f6a990: lfs: check content length after downloading content.
lfs: check content length after downloading content
Wed, Jan 15, 8:17 AM
mharbison72 committed rHG84f2becbd106: lfs: rename a variable to clarify its use.
lfs: rename a variable to clarify its use
Wed, Jan 15, 8:17 AM

Tue, Jan 14

mharbison72 created D7881: lfs: check content length after downloading content.
Tue, Jan 14, 11:09 PM
mharbison72 created D7882: lfs: avoid quadratic performance in processing server responses.
Tue, Jan 14, 11:09 PM
mharbison72 created D7880: lfs: rename a variable to clarify its use.
Tue, Jan 14, 11:09 PM
mharbison72 closed D7873: doc: fix references to `revset.abstractsmartset`.
Tue, Jan 14, 5:35 PM
mharbison72 closed D7874: phabricator: post revisions in ascending topological order (issue6241).
Tue, Jan 14, 5:34 PM
mharbison72 closed D7872: lfs: add "bytes" as the unit to the upload/download progress bar.
Tue, Jan 14, 5:34 PM
mharbison72 committed rHG05881d002cb2: lfs: add "bytes" as the unit to the upload/download progress bar.
lfs: add "bytes" as the unit to the upload/download progress bar
Tue, Jan 14, 5:34 PM
mharbison72 committed rHGa7c4bcf7018a: phabricator: post revisions in ascending topological order (issue6241).
phabricator: post revisions in ascending topological order (issue6241)
Tue, Jan 14, 5:34 PM
mharbison72 committed rHG2122ffa903ea: doc: fix references to `revset.abstractsmartset`.
doc: fix references to `revset.abstractsmartset`
Tue, Jan 14, 5:34 PM
mharbison72 updated the summary of D7816: tests: stabilize test-subrepo-svn.t on Windows.
Tue, Jan 14, 5:22 PM
mharbison72 added a comment to D7874: phabricator: post revisions in ascending topological order (issue6241).

I don't see any guardrails that prevent mixing unrelated local stuff into the revset and erroneously assigning the last revision processed as a parent, but that's less trivial and can probably wait until someone stumbles on it.

Tue, Jan 14, 4:43 PM
mharbison72 created D7873: doc: fix references to `revset.abstractsmartset`.
Tue, Jan 14, 4:40 PM
mharbison72 created D7874: phabricator: post revisions in ascending topological order (issue6241).
Tue, Jan 14, 4:39 PM
mharbison72 updated the summary of D7816: tests: stabilize test-subrepo-svn.t on Windows.
Tue, Jan 14, 1:17 PM
mharbison72 created D7872: lfs: add "bytes" as the unit to the upload/download progress bar.
Tue, Jan 14, 12:47 PM
mharbison72 committed rHGb9e174d4ed11: verify: allow the storage to signal when renames can be tested on `skipread`.
verify: allow the storage to signal when renames can be tested on `skipread`
Tue, Jan 14, 11:39 AM
mharbison72 committed rHG1a6dd50cd0db: lfs: don't skip locally available blobs when verifying.
lfs: don't skip locally available blobs when verifying
Tue, Jan 14, 11:39 AM
mharbison72 committed rHG34e8305f02bd: lfs: add a switch to `hg verify` to ignore the content of blobs.
lfs: add a switch to `hg verify` to ignore the content of blobs
Tue, Jan 14, 11:39 AM
mharbison72 committed rHG089255b1341e: scmutil: fix an unbound variable with progressbar debug enabled.
scmutil: fix an unbound variable with progressbar debug enabled
Tue, Jan 14, 11:39 AM
mharbison72 committed rHG2efe3d3ec28e: verify: allow the storage to signal when renames can be tested on `skipread`.
verify: allow the storage to signal when renames can be tested on `skipread`
Tue, Jan 14, 11:37 AM
mharbison72 committed rHG09fe0f5c3223: lfs: don't skip locally available blobs when verifying.
lfs: don't skip locally available blobs when verifying
Tue, Jan 14, 11:37 AM
mharbison72 committed rHGedf6ea7db7c5: lfs: add a switch to `hg verify` to ignore the content of blobs.
lfs: add a switch to `hg verify` to ignore the content of blobs
Tue, Jan 14, 11:37 AM
mharbison72 committed rHGedcdd968a7d0: scmutil: fix an unbound variable with progressbar debug enabled.
scmutil: fix an unbound variable with progressbar debug enabled
Tue, Jan 14, 11:37 AM
mharbison72 closed D7713: verify: allow the storage to signal when renames can be tested on `skipread`.
Tue, Jan 14, 11:14 AM
mharbison72 closed D7712: lfs: don't skip locally available blobs when verifying.
Tue, Jan 14, 11:14 AM
mharbison72 committed rHG1dff147554b1: lfs: don't skip locally available blobs when verifying.
lfs: don't skip locally available blobs when verifying
Tue, Jan 14, 11:13 AM
mharbison72 committed rHG8d0974108fcf: verify: allow the storage to signal when renames can be tested on `skipread`.
verify: allow the storage to signal when renames can be tested on `skipread`
Tue, Jan 14, 11:13 AM
mharbison72 closed D7708: lfs: add a switch to `hg verify` to ignore the content of blobs.
Tue, Jan 14, 11:13 AM
mharbison72 committed rHGe540103ce945: lfs: add a switch to `hg verify` to ignore the content of blobs.
lfs: add a switch to `hg verify` to ignore the content of blobs
Tue, Jan 14, 11:13 AM

Mon, Jan 13

mharbison72 closed D7852: scmutil: fix an unbound variable with progressbar debug enabled.
Mon, Jan 13, 11:41 PM
mharbison72 committed rHG733aefddc4aa: scmutil: fix an unbound variable with progressbar debug enabled.
scmutil: fix an unbound variable with progressbar debug enabled
Mon, Jan 13, 11:41 PM
mharbison72 created D7852: scmutil: fix an unbound variable with progressbar debug enabled.
Mon, Jan 13, 5:59 PM

Thu, Jan 9

mharbison72 closed D7818: py3: byteify the opener option to use `rust.index` to allow Rust revlogs.
Thu, Jan 9, 1:13 PM
mharbison72 committed rHGde5d34ca01bd: py3: byteify the opener option to use `rust.index` to allow Rust revlogs.
py3: byteify the opener option to use `rust.index` to allow Rust revlogs
Thu, Jan 9, 1:12 PM
mharbison72 created D7818: py3: byteify the opener option to use `rust.index` to allow Rust revlogs.
Thu, Jan 9, 10:20 AM
mharbison72 closed D7817: py3: byteify some `ui.configbool()` parameters.
Thu, Jan 9, 9:57 AM
mharbison72 committed rHGb958419b6c53: py3: byteify some `ui.configbool()` parameters.
py3: byteify some `ui.configbool()` parameters
Thu, Jan 9, 9:57 AM

Wed, Jan 8

mharbison72 added a comment to D7708: lfs: add a switch to `hg verify` to ignore the content of blobs.

Setting this back to wanting a review because I suspect my response questions were overlooked with vacations, and it won't show up in anybody's dashboard otherwise.

Wed, Jan 8, 11:37 PM
mharbison72 added inline comments to D7660: rust-index: add a `experimental.rust.index` option to use the wrapper.
Wed, Jan 8, 8:30 PM
mharbison72 created D7817: py3: byteify some `ui.configbool()` parameters.
Wed, Jan 8, 8:28 PM
mharbison72 added a reverting change for rHG991e4404e910: tests: convert the 'file://\$TESTTMP' rule to an automatic substitution: D7816: tests: stabilize test-subrepo-svn.t on Windows.
Wed, Jan 8, 8:28 PM
mharbison72 created D7816: tests: stabilize test-subrepo-svn.t on Windows.
Wed, Jan 8, 8:28 PM
mharbison72 closed D7776: ui: add the ability to apply `defaultrc` configs from resources.
Wed, Jan 8, 2:52 PM
mharbison72 closed D7775: ui: refactor `readconfig()` into a form that can consume resources.
Wed, Jan 8, 2:52 PM
mharbison72 closed D7777: rcutil: drop the `defaultrcpath()` method (API).
Wed, Jan 8, 2:51 PM
mharbison72 committed rHG2d4cad94d08a: rcutil: drop the `defaultrcpath()` method (API).
rcutil: drop the `defaultrcpath()` method (API)
Wed, Jan 8, 2:51 PM
mharbison72 closed D7766: cleanup: drop redundant character escapes from `[]` character sets.
Wed, Jan 8, 2:51 PM
mharbison72 committed rHG1864efbe90d9: ui: add the ability to apply `defaultrc` configs from resources.
ui: add the ability to apply `defaultrc` configs from resources
Wed, Jan 8, 2:51 PM
mharbison72 committed rHG5ac0e6f19eb4: ui: refactor `readconfig()` into a form that can consume resources.
ui: refactor `readconfig()` into a form that can consume resources
Wed, Jan 8, 2:51 PM
mharbison72 committed rHGbba9149adc14: resourceutil: implement `contents()` to iterate over resources in a package.
resourceutil: implement `contents()` to iterate over resources in a package
Wed, Jan 8, 2:51 PM
mharbison72 committed rHG42a897bf678c: resourceutil: implement `is_resource()`.
resourceutil: implement `is_resource()`
Wed, Jan 8, 2:51 PM
mharbison72 closed D7768: commit: change default `editor` parameter to None.
Wed, Jan 8, 2:51 PM
mharbison72 closed D7774: resourceutil: implement `contents()` to iterate over resources in a package.
Wed, Jan 8, 2:51 PM
mharbison72 closed D7773: resourceutil: implement `is_resource()`.
Wed, Jan 8, 2:51 PM
mharbison72 committed rHG52f0140c2604: resourceutil: don't limit resources to the `mercurial` package.
resourceutil: don't limit resources to the `mercurial` package
Wed, Jan 8, 2:51 PM
mharbison72 closed D7772: resourceutil: don't limit resources to the `mercurial` package.
Wed, Jan 8, 2:51 PM
mharbison72 closed D7771: setup: include `defaultrc` in the package list.
Wed, Jan 8, 2:51 PM
mharbison72 committed rHG44b03c0313aa: setup: include `defaultrc` in the package list.
setup: include `defaultrc` in the package list
Wed, Jan 8, 2:51 PM
mharbison72 closed D7769: tests: fix a copy/paste name duplication in storage.py.
Wed, Jan 8, 2:51 PM
mharbison72 committed rHGa1ee825fc6c5: tests: fix a copy/paste name duplication in storage.py.
tests: fix a copy/paste name duplication in storage.py
Wed, Jan 8, 2:50 PM
mharbison72 closed D7778: mq: avoid using `__file__` to compare modules.
Wed, Jan 8, 2:50 PM
mharbison72 committed rHG3216cabffd4a: commit: change default `editor` parameter to None.
commit: change default `editor` parameter to None
Wed, Jan 8, 2:50 PM
mharbison72 closed D7767: cleanup: drop redundant character escapes outside of `[]`.
Wed, Jan 8, 2:50 PM