mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (83 w, 1 d)

Recent Activity

Today

mharbison72 added a comment to D5981: tests: drop a few unnecessary "(glob)".

The tests run clean with this.

Mon, Feb 18, 12:32 PM
mharbison72 committed rHGeb8a8af4cbd0: tests: correct the remaining fallout from recent path style changes on Windows.
tests: correct the remaining fallout from recent path style changes on Windows
Mon, Feb 18, 12:13 AM

Yesterday

mharbison72 added a comment to D5801: files: respect ui.relative-paths.

I noticed another bug and sent D5978. Maybe your test failure is because you're using the eol extension? I don't know what else would cause the \r in contrib.perf. I have no idea how that's related to this patch, though.

The \r is how output normally is on Windows. The test harness accounts for this when matching lines, but displays the actual output (with \r) when there are differences. The eol extension isn’t configured on this machine, but the custom HGRCPATH content from the test harness would override that anyway.

Ah, so the only difference is the extra "import newer module separately in try clause for early Mercurial" in contrib/perf.py then. This patch didn't change that file. Can you check again that it was this patch that caused that and that it's not just flaky?

Sun, Feb 17, 5:52 PM
mharbison72 added a comment to D5801: files: respect ui.relative-paths.

I noticed another bug and sent D5978. Maybe your test failure is because you're using the eol extension? I don't know what else would cause the \r in contrib.perf. I have no idea how that's related to this patch, though.

Sun, Feb 17, 3:15 PM

Sat, Feb 16

mharbison72 added a comment to D5898: debugignore: respect ui.relative-paths.

This seems to have converted a test from dos to unix style. I'm not sure if that was intentional, or if this feature is still a WIP. (Sorry, I've been busy lately, and haven't had time to follow this closely)

Sat, Feb 16, 10:53 PM
mharbison72 added a comment to D5801: files: respect ui.relative-paths.

For some reason, this breaks test-contrib-perf.t:

Sat, Feb 16, 10:45 PM

Thu, Feb 7

mharbison72 committed rHG698667eb7523: lfs: disable all authentication except Basic for HTTP(S) connections.
lfs: disable all authentication except Basic for HTTP(S) connections
Thu, Feb 7, 11:02 AM
mharbison72 committed rHG67e622ade415: tests: stabilize test-extdiff.t on Windows.
tests: stabilize test-extdiff.t on Windows
Thu, Feb 7, 11:02 AM
mharbison72 committed rHGa263b7d71105: tests: stabilize test-extdiff.t on Windows.
tests: stabilize test-extdiff.t on Windows
Thu, Feb 7, 7:21 AM
mharbison72 committed rHG98930b0a645a: lfs: disable all authentication except Basic for HTTP(S) connections.
lfs: disable all authentication except Basic for HTTP(S) connections
Thu, Feb 7, 7:21 AM
mharbison72 committed rHG87a6e3c953e0: subrepo: avoid false unsafe path detection on Windows.
subrepo: avoid false unsafe path detection on Windows
Thu, Feb 7, 6:39 AM

Wed, Feb 6

mharbison72 committed rHG46432c04f010: tests: enable HTTP digest testing.
tests: enable HTTP digest testing
Wed, Feb 6, 7:41 AM
mharbison72 committed rHG349c8879becd: py3: ensure the HTTP password manager returns strings, not bytes.
py3: ensure the HTTP password manager returns strings, not bytes
Wed, Feb 6, 7:41 AM
mharbison72 committed rHG765a608c2108: wsgiheaders: make sure __repr__() returns a string.
wsgiheaders: make sure __repr__() returns a string
Wed, Feb 6, 7:41 AM
mharbison72 committed rHGccaa52865fac: tests: add code to handle HTTP digests on the server side.
tests: add code to handle HTTP digests on the server side
Wed, Feb 6, 7:41 AM
mharbison72 committed rHG7855a949b7c2: run-tests: allow spaces in the --view tool.
run-tests: allow spaces in the --view tool
Wed, Feb 6, 7:41 AM
mharbison72 committed rHG549af2fa089f: tests: extract the http server authentication extension to a single module.
tests: extract the http server authentication extension to a single module
Wed, Feb 6, 7:41 AM

Tue, Feb 5

mharbison72 added a comment to D5800: config: introduce a new value for ui.relative-paths getting old behavior.

Maybe a py3 thing?

Tue, Feb 5, 11:50 PM
mharbison72 added inline comments to D5800: config: introduce a new value for ui.relative-paths getting old behavior.
Tue, Feb 5, 10:09 PM

Mon, Feb 4

mharbison72 committed rHGe095a9688a31: tests: quote $PYTHON for py3 support on Windows.
tests: quote $PYTHON for py3 support on Windows
Mon, Feb 4, 4:55 PM
mharbison72 committed rHGef29b6b8768c: py3: byteify the --retest path of run-tests.py.
py3: byteify the --retest path of run-tests.py
Mon, Feb 4, 4:55 PM
mharbison72 committed rHGf9150901267c: run-tests: sort the skip, failure and error lists in the final output.
run-tests: sort the skip, failure and error lists in the final output
Mon, Feb 4, 4:54 PM

Fri, Feb 1

mharbison72 committed rHG92c25572c24c: tests: quote $PYTHON for py3 support on Windows.
tests: quote $PYTHON for py3 support on Windows
Fri, Feb 1, 10:53 PM
mharbison72 committed rHG6e9513fac7a1: py3: byteify the --retest path of run-tests.py.
py3: byteify the --retest path of run-tests.py
Fri, Feb 1, 10:53 PM
mharbison72 added inline comments to D5745: status: extract helper for producing relative or absolute path for UI.
Fri, Feb 1, 10:36 PM
mharbison72 committed rHG44c5506a2572: tests: quote $PYTHON for py3 support on Windows.
tests: quote $PYTHON for py3 support on Windows
Fri, Feb 1, 7:21 AM
mharbison72 committed rHGd3dc4abc547a: py3: byteify the --retest path of run-tests.py.
py3: byteify the --retest path of run-tests.py
Fri, Feb 1, 7:21 AM

Thu, Jan 31

mharbison72 added a comment to D5749: hgweb: log error before attempting I/O.

@durin42 and I were both able to produce intermittent failures with this change. Why, I'm not sure.

Does the Windows regression occur with this patch or with D5751? I ask because the behavior of socket.shutdown() is documented to vary by platform. I wouldn't at all be surprised if D5751 caused the regression seen here.

It was this patch.

Like I said, I’ve seen connection resets in the non-daemonized serve output (don’t recall if it was push, pull, or both). I thought it was weird, but there were no other signs of problems, so I wrote it off as some odd Windows thing. (Not sure that I’ve seen it on Linux or OS X too)

Does D5764 help the situation? It made a big difference for me.

Thu, Jan 31, 4:56 PM
mharbison72 added a comment to D5780: tags: avoid generating commit for an already deleted tag (issue5752).

Since the tag command's code is already looking at repo.tagtype(), I wonder if it would be better to just inline the global tag lookup and nullid comparison right there instead of updating the interface.

Thu, Jan 31, 12:15 PM
mharbison72 committed rHGbb98870ab38d: run-tests: sort the skip, failure and error lists in the final output.
run-tests: sort the skip, failure and error lists in the final output
Thu, Jan 31, 8:03 AM
mharbison72 committed rHG13e9a5eaf321: run-tests: sort the skip, failure and error lists in the final output.
run-tests: sort the skip, failure and error lists in the final output
Thu, Jan 31, 7:41 AM

Wed, Jan 30

mharbison72 added a comment to D5749: hgweb: log error before attempting I/O.

@durin42 and I were both able to produce intermittent failures with this change. Why, I'm not sure.

Does the Windows regression occur with this patch or with D5751? I ask because the behavior of socket.shutdown() is documented to vary by platform. I wouldn't at all be surprised if D5751 caused the regression seen here.

Wed, Jan 30, 8:26 PM
mharbison72 added a comment to D5749: hgweb: log error before attempting I/O.

While this is better, it triggers a few failures on Windows. I've seen these connection resets with hg serve outside of the test harness. Any ideas? It almost seems like the client is closing the socket before all of the data is sent. (This failure occurs on py2)

Wed, Jan 30, 7:03 PM

Tue, Jan 29

mharbison72 committed rHG1bc01490178a: lfs: explicitly add the Content-Length header when uploading blobs, for py3.
lfs: explicitly add the Content-Length header when uploading blobs, for py3
Tue, Jan 29, 6:14 AM

Mon, Jan 28

mharbison72 committed rHG3757a968d63a: py3: stabilize the output of lfs commandserver tests.
py3: stabilize the output of lfs commandserver tests
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG080a5c83914f: py3: conditionalize some LFS test output.
py3: conditionalize some LFS test output
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG52a4a3e7cc6a: py3: force hgweb.server error log to internally write unicode.
py3: force hgweb.server error log to internally write unicode
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG0b636d1720a0: lfs: strip the response headers from the Batch API before printing.
lfs: strip the response headers from the Batch API before printing
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG7df10ea7a5b8: py3: byteify the decoded JSON responses upon receipt in the LFS blobstore.
py3: byteify the decoded JSON responses upon receipt in the LFS blobstore
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG4045ab21945a: hgweb: ensure Content-Length and Content-Type are not promoted to HTTP_ on py3.
hgweb: ensure Content-Length and Content-Type are not promoted to HTTP_ on py3
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG40efcf78f3df: py3: raw stringify various JSON and HTTP headers in the LFS blobstore module.
py3: raw stringify various JSON and HTTP headers in the LFS blobstore module
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG6d7f18cd81d9: py3: raw stringify various things in the LFS server module.
py3: raw stringify various things in the LFS server module
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG02d0a7774882: py3: byteify the LFS blobstore module.
py3: byteify the LFS blobstore module
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG7a11e4e55d5f: py3: add b'' prefixes to the LFS server module.
py3: add b'' prefixes to the LFS server module
Mon, Jan 28, 7:07 AM
mharbison72 committed rHG2a1bb442593b: py3: add b'' and r'' prefixes to LFS tests.
py3: add b'' and r'' prefixes to LFS tests
Mon, Jan 28, 7:07 AM

Sat, Jan 26

mharbison72 committed rHGed99c7b52106: tests: conditionalize Windows difference in test-dispatch.t.
tests: conditionalize Windows difference in test-dispatch.t
Sat, Jan 26, 2:10 AM
mharbison72 committed rHGbaffda74891c: py3: fix a bytes/str mingling in test-install.t.
py3: fix a bytes/str mingling in test-install.t
Sat, Jan 26, 2:10 AM

Fri, Jan 25

mharbison72 committed rHG93c3742cbf5b: tests: conditionalize Windows difference in test-dispatch.t.
tests: conditionalize Windows difference in test-dispatch.t
Fri, Jan 25, 11:20 PM
mharbison72 committed rHGb9389ceefeab: py3: fix a bytes/str mingling in test-install.t.
py3: fix a bytes/str mingling in test-install.t
Fri, Jan 25, 11:20 PM

Tue, Jan 22

mharbison72 added a comment to D5496: revset: add "samebranch" keyword argument to the merge revset.
In D5496#82671, @yuja wrote:

Do you mean that the flag should only indicate whether you want to hide the same branch merges? I guess that is OK too, since the main use case for this flag is to hide the merge from the same branch. However I think we should change the flag name then. Perhaps "hidesame"? Or "includesame" or "includeself", defaulting to True? Any ideas?

Tue, Jan 22, 1:28 PM

Jan 19 2019

mharbison72 committed rHGb5d7413e4009: help: document the minimumhgversion variable for extensions.
help: document the minimumhgversion variable for extensions
Jan 19 2019, 6:30 AM
mharbison72 committed rHG86f6b441adea: help: modernize the example for command registration.
help: modernize the example for command registration
Jan 19 2019, 6:30 AM

Jan 17 2019

mharbison72 committed rHGc9e1104e6272: exthelper: drop the addattr() decorator.
exthelper: drop the addattr() decorator
Jan 17 2019, 7:10 AM
mharbison72 committed rHG878084a495ef: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 4:41 AM
mharbison72 committed rHG8bde55072523: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 4:35 AM
mharbison72 committed rHG6ffe7c15f75d: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 3:34 AM

Jan 16 2019

mharbison72 added a comment to D5495: revset: add "branch" positional arguments to the merge revset.

I've sent an updated set of patches, following your recommendations. There are 2 patches now, since each includes its own tests. This means that the 3rd patch on the original patch set is no longer needed. However I don't know what is the best way to tell that to phabricator...

Jan 16 2019, 12:59 AM

Jan 11 2019

mharbison72 committed rHG69804c040a04: convert: don't drop commits that are empty in the source when using --filemap.
convert: don't drop commits that are empty in the source when using --filemap
Jan 11 2019, 7:53 AM
mharbison72 committed rHG77088fa862df: convert: add missing numcommits() override to hg sources.
convert: add missing numcommits() override to hg sources
Jan 11 2019, 7:53 AM

Jan 10 2019

mharbison72 committed rHG43fd1947301d: phabricator: teach {phabreview} to work without --amend.
phabricator: teach {phabreview} to work without --amend
Jan 10 2019, 6:26 AM
mharbison72 committed rHG0101a35deae2: phabricator: warn if unable to amend, instead of aborting after posting.
phabricator: warn if unable to amend, instead of aborting after posting
Jan 10 2019, 6:26 AM

Jan 9 2019

mharbison72 abandoned D5545: create draft change for phabricator testing.
Jan 9 2019, 11:30 PM
mharbison72 abandoned D5544: create public change for phabricator testing.
Jan 9 2019, 11:30 PM
mharbison72 created D5545: create draft change for phabricator testing.
Jan 9 2019, 11:08 PM
mharbison72 added a dependent revision for D5544: create public change for phabricator testing: D5545: create draft change for phabricator testing.
Jan 9 2019, 11:08 PM
mharbison72 created D5544: create public change for phabricator testing.
Jan 9 2019, 11:08 PM

Jan 6 2019

mharbison72 accepted D5498: server: always close http socket if responding with an error (issue6033).

This works for me on Windows in that narrow window where this was constantly happening, thanks!

Jan 6 2019, 11:16 PM

Jan 5 2019

mharbison72 added inline comments to D5489: histedit: add warning message on editing tagged commits (issue4017).
Jan 5 2019, 9:09 PM
mharbison72 committed rHG70e3e3da24be: templatekw: fix documentation typos.
templatekw: fix documentation typos
Jan 5 2019, 2:06 AM

Jan 3 2019

mharbison72 added inline comments to D5489: histedit: add warning message on editing tagged commits (issue4017).
Jan 3 2019, 11:02 PM
mharbison72 committed rHGf8f61cf246f5: registrar: minor cleanup to the merge function.
registrar: minor cleanup to the merge function
Jan 3 2019, 3:48 AM

Dec 31 2018

mharbison72 committed rHG4d40f6bb4cef: exthelper: switch to using the registrar merging method.
exthelper: switch to using the registrar merging method
Dec 31 2018, 9:21 AM
mharbison72 committed rHG13f50ea8ac3b: registrar: add a method to merge registrar instances.
registrar: add a method to merge registrar instances
Dec 31 2018, 9:21 AM
mharbison72 committed rHG9d35ae3d9999: phabricator: ensure that the return of urlopener.open() is closed.
phabricator: ensure that the return of urlopener.open() is closed
Dec 31 2018, 9:21 AM

Dec 30 2018

mharbison72 committed rHGd0c86a7447a6: help: show advanced, experimental and deprecated extensions with --verbose.
help: show advanced, experimental and deprecated extensions with --verbose
Dec 30 2018, 3:33 AM
mharbison72 committed rHG9afe128f7727: help: remove a duplicate category name entry for TOPIC_CATEGORY_NONE.
help: remove a duplicate category name entry for TOPIC_CATEGORY_NONE
Dec 30 2018, 3:33 AM
mharbison72 committed rHG72d4a1761fbc: largefiles: eliminate an unnecessary import of configitems.
largefiles: eliminate an unnecessary import of configitems
Dec 30 2018, 3:33 AM
mharbison72 committed rHG536beb130f3c: phabricator: assign commands to help categories.
phabricator: assign commands to help categories
Dec 30 2018, 3:33 AM
mharbison72 committed rHGc81bb97b0cac: exthelper: add some examples for using registrar aliases.
exthelper: add some examples for using registrar aliases
Dec 30 2018, 3:33 AM
mharbison72 committed rHG8f40e21ca842: exthelper: reintroduce the ability to register filesets.
exthelper: reintroduce the ability to register filesets
Dec 30 2018, 3:33 AM
mharbison72 committed rHG70ca0e846d25: exthelper: reintroduce the ability to register templates.
exthelper: reintroduce the ability to register templates
Dec 30 2018, 3:33 AM
mharbison72 committed rHGf2601cbce209: largefiles: port revset registration to exthelper.
largefiles: port revset registration to exthelper
Dec 30 2018, 3:33 AM
mharbison72 committed rHG28a4fb793ba1: extensions: deprecate extsetup without a `ui` argument (API).
extensions: deprecate extsetup without a `ui` argument (API)
Dec 30 2018, 3:33 AM
mharbison72 committed rHG0358cca1dccf: exthelper: reintroduce the ability to register revsets.
exthelper: reintroduce the ability to register revsets
Dec 30 2018, 3:33 AM
mharbison72 committed rHG0840862977c8: largefiles: drop the uisetup module.
largefiles: drop the uisetup module
Dec 30 2018, 3:33 AM

Dec 27 2018

mharbison72 committed rHG0a7f582f6f1f: largefiles: port wrapped functions to exthelper.
largefiles: port wrapped functions to exthelper
Dec 27 2018, 7:34 AM
mharbison72 committed rHG98681293c890: largefiles: port commands to exthelper.
largefiles: port commands to exthelper
Dec 27 2018, 7:34 AM
mharbison72 committed rHG7250cbaabde0: exthelper: support the option argument when registering a command.
exthelper: support the option argument when registering a command
Dec 27 2018, 7:34 AM
mharbison72 committed rHG0ecf58f7c2b2: largefiles: port configitems to exthelper.
largefiles: port configitems to exthelper
Dec 27 2018, 7:34 AM
mharbison72 committed rHGf7863606d4ff: exthelper: add a cautionary note about adding attributes to containers.
exthelper: add a cautionary note about adding attributes to containers
Dec 27 2018, 7:34 AM
mharbison72 committed rHGc61b8dfb07c8: remotefilelog: use repo.local() instead of isinstance().
remotefilelog: use repo.local() instead of isinstance()
Dec 27 2018, 7:34 AM
mharbison72 committed rHG41cd64a81dd9: exthelper: drop a compatibility shim with '^command' syntax.
exthelper: drop a compatibility shim with '^command' syntax
Dec 27 2018, 7:33 AM

Dec 23 2018

mharbison72 committed rHG021496277392: exthelper: correct a documentation typo.
exthelper: correct a documentation typo
Dec 23 2018, 8:46 AM
mharbison72 committed rHG84d61fdcefa5: lfs: convert to using exthelper to wrap functions.
lfs: convert to using exthelper to wrap functions
Dec 23 2018, 8:46 AM
mharbison72 committed rHG555215e2b051: tests: convert a test extension to use exthelper.
tests: convert a test extension to use exthelper
Dec 23 2018, 8:46 AM
mharbison72 committed rHGf5ec93f69171: exthelper: drop fileset/revset/template support for now.
exthelper: drop fileset/revset/template support for now
Dec 23 2018, 8:46 AM
mharbison72 committed rHGfe606f2dcae9: extensions: import the exthelper class from evolve 980565468003 (API).
extensions: import the exthelper class from evolve 980565468003 (API)
Dec 23 2018, 8:46 AM
mharbison72 committed rHGc1476d095d57: exthelper: simplify configitem registration.
exthelper: simplify configitem registration
Dec 23 2018, 8:46 AM

Dec 22 2018

mharbison72 committed rHGd7d3164e6a31: phabricator: properly encode boolean types in the request body.
phabricator: properly encode boolean types in the request body
Dec 22 2018, 9:38 PM
mharbison72 committed rHG2eeef8e577ac: py3: byteify one more sys.argv in gendoc.py.
py3: byteify one more sys.argv in gendoc.py
Dec 22 2018, 2:35 AM