Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (150 w, 6 d)

Recent Activity

Yesterday

mharbison72 closed D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
Fri, Jun 5, 11:14 PM
mharbison72 committed rHG1f114c797961: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291)
Fri, Jun 5, 11:14 PM
mharbison72 closed D8488: tests: show that rebase --dry-run and --confirm wipeout uncommitted changes.
Fri, Jun 5, 11:14 PM
mharbison72 committed rHG9f3aa0d3de41: tests: show that rebase --dry-run and --confirm wipeout uncommitted changes.
tests: show that rebase --dry-run and --confirm wipeout uncommitted changes
Fri, Jun 5, 11:13 PM

Sat, May 16

mharbison72 added a comment to D8524: phabricator: load .arcconfig during reposetup (issue6331).

I'll try to take a closer look at this some time this weekend. In the meantime, can you explain more why it didn't work for you? There are tests that cover this feature, so I'm wondering if some coverage is missing.

Sat, May 16, 1:04 PM
mharbison72 added inline comments to D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
Sat, May 16, 12:08 PM

May 7 2020

mharbison72 committed rHGa50f33f1ff24: url: fix a bytes vs str crash in processing proxy headers (issue6249).
url: fix a bytes vs str crash in processing proxy headers (issue6249)
May 7 2020, 11:43 AM
mharbison72 closed D8485: url: fix a bytes vs str crash in processing proxy headers (issue6249).
May 7 2020, 11:02 AM
mharbison72 committed rHG8dbaa361ecdb: url: fix a bytes vs str crash in processing proxy headers (issue6249).
url: fix a bytes vs str crash in processing proxy headers (issue6249)
May 7 2020, 11:02 AM

May 2 2020

mharbison72 added a comment to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.

Now that I see it, I think we shoul dinclude all heads because the mssage might be confusing "multiple heads: one-hash"

May 2 2020, 4:34 PM

May 1 2020

mharbison72 closed D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
May 1 2020, 12:05 PM
mharbison72 closed D8455: tests: clarify a comment describing a phabricator test scenario.
May 1 2020, 12:03 PM
mharbison72 committed rHGcf3e07d7648a: tests: clarify a comment describing a phabricator test scenario.
tests: clarify a comment describing a phabricator test scenario
May 1 2020, 12:02 PM
mharbison72 committed rHGc1c922391314: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
phabricator: ensure that `phabsend` is given a contiguous, linear commit range
May 1 2020, 12:02 PM
mharbison72 added a comment to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.

Gentle ping on this. I think I addressed the concerns raised, and didn't want it overlooked for the release if it's still in the changes requested state.

Did not we want to update the message ?

May 1 2020, 10:24 AM
mharbison72 added a comment to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.

Gentle ping on this. I think I addressed the concerns raised, and didn't want it overlooked for the release if it's still in the changes requested state.

May 1 2020, 9:59 AM

Apr 30 2020

mharbison72 added a comment to D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).

I'm not real familiar with how rebase works, and seems like it's pretty intricate code. I'd also feel better if there were tests for the original commit referenced. But it's very unlikely that I'll have any time before the weekend to look at this again, so I thought I'd send it out now. Maybe it's narrow enough or maybe somebody can backfill the tests, and we can avoid a known data shredder in the next release.

Apr 30 2020, 1:25 AM
mharbison72 created D8489: rebase: avoid clobbering wdir() with --dry-run or --confirm (issue6291).
Apr 30 2020, 1:22 AM
mharbison72 created D8488: tests: show that rebase --dry-run and --confirm wipeout uncommitted changes.
Apr 30 2020, 1:20 AM

Apr 26 2020

mharbison72 added a comment to D8477: packaging: support building WiX installers with PyOxidizer.

I'm trying to build this with PyOxidizer and get an error after upgrading to v0.7.0. I wonder if some of the references in rust/hgcli/Cargo.lock need to be updated from 0.7.0-pre. Here's the command output:

Apr 26 2020, 11:36 PM
mharbison72 added a comment to D8477: packaging: support building WiX installers with PyOxidizer.

This may not be a big deal, and I'm not sure that this patch is the cause. When I built the py2 installer with py -3 contrib\packaging\packaging.py wix --python C:\Python2717\python.exe, I got a 25K hg.exe in the dist directory with all of the installers that had a mod time 1 minute before the installer. I don't remember seeing this when I was building installers at the end of January. (It also has screwy output, but that's a different issue)

Apr 26 2020, 10:53 PM
mharbison72 created D8485: url: fix a bytes vs str crash in processing proxy headers (issue6249).
Apr 26 2020, 4:13 PM

Apr 24 2020

mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 24 2020, 4:38 PM
mharbison72 updated the diff for D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 24 2020, 3:06 PM
mharbison72 updated the diff for D8455: tests: clarify a comment describing a phabricator test scenario.
Apr 24 2020, 2:58 PM

Apr 23 2020

mharbison72 closed D8459: tests: stabilize test-log.t on Windows.
Apr 23 2020, 2:04 PM
mharbison72 committed rHG46856c2cc4f2: tests: stabilize test-log.t on Windows.
tests: stabilize test-log.t on Windows
Apr 23 2020, 2:04 PM
mharbison72 closed D8458: tests: stabilize test-convert-hg-source.t on Windows.
Apr 23 2020, 2:04 PM
mharbison72 committed rHG78b7eae31488: tests: stabilize test-convert-hg-source.t on Windows.
tests: stabilize test-convert-hg-source.t on Windows
Apr 23 2020, 2:04 PM

Apr 22 2020

mharbison72 added a comment to D8457: [RFC] metadataonlyctx: demonstrate an error reusing manifest nodes.

For demo purpose only → getting it out of review. Put it back in review if I am wrong.

Apr 22 2020, 1:50 PM
mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 22 2020, 1:49 PM

Apr 19 2020

mharbison72 updated the diff for D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 19 2020, 5:45 PM
mharbison72 updated the diff for D8455: tests: clarify a comment describing a phabricator test scenario.
Apr 19 2020, 5:45 PM
mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 19 2020, 5:43 PM

Apr 17 2020

mharbison72 updated the diff for D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 17 2020, 11:28 PM
mharbison72 updated the diff for D8455: tests: clarify a comment describing a phabricator test scenario.
Apr 17 2020, 11:27 PM
mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 17 2020, 11:25 PM
mharbison72 created D8459: tests: stabilize test-log.t on Windows.
Apr 17 2020, 9:07 PM
mharbison72 created D8458: tests: stabilize test-convert-hg-source.t on Windows.
Apr 17 2020, 9:06 PM
mharbison72 added inline comments to D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 17 2020, 3:09 PM
mharbison72 added a comment to D8345: tests: look for CRLF on Windows.

@mharbison72 @indygreg, IIRC Matt is saying this is the wrong fix. What's the status of this?

Apr 17 2020, 2:59 PM
mharbison72 added a comment to D6846: packaging: script the building of a MacOS installer using a custom python.

So as I understand this is not ready to land and should be moved to change-requested (or change planned), right ?

Apr 17 2020, 2:56 PM
mharbison72 created D8457: [RFC] metadataonlyctx: demonstrate an error reusing manifest nodes.
Apr 17 2020, 11:19 AM

Apr 16 2020

mharbison72 created D8454: phabricator: ensure that `phabsend` is given a contiguous, linear commit range.
Apr 16 2020, 8:02 PM
mharbison72 created D8455: tests: clarify a comment describing a phabricator test scenario.
Apr 16 2020, 8:02 PM
mharbison72 closed D8438: phabricator: restack any new orphans created by phabsend (issue6045).
Apr 16 2020, 12:43 PM
mharbison72 closed D8436: phabricator: avoid creating unstable children within the review stack.
Apr 16 2020, 12:43 PM
mharbison72 closed D8437: phabricator: prevent posting obsolete commits.
Apr 16 2020, 12:43 PM
mharbison72 committed rHGeb9026a84e83: make: drop the `-c` arg to `install` in the documentation makefile.
make: drop the `-c` arg to `install` in the documentation makefile
Apr 16 2020, 12:43 PM
mharbison72 closed D8439: make: drop the `-c` arg to `install` in the documentation makefile.
Apr 16 2020, 12:43 PM
mharbison72 committed rHG601ce5392cb0: phabricator: restack any new orphans created by phabsend (issue6045).
phabricator: restack any new orphans created by phabsend (issue6045)
Apr 16 2020, 12:43 PM
mharbison72 closed D8389: phabricator: add debug logging to show previous node values in `phabsend`.
Apr 16 2020, 12:43 PM
mharbison72 committed rHGc482e2fe444c: phabricator: prevent posting obsolete commits.
phabricator: prevent posting obsolete commits
Apr 16 2020, 12:42 PM
mharbison72 closed D8390: tests: move the phabricator auth token to the global config file.
Apr 16 2020, 12:42 PM
mharbison72 committed rHG0680b8a1992a: phabricator: avoid creating unstable children within the review stack.
phabricator: avoid creating unstable children within the review stack
Apr 16 2020, 12:42 PM
mharbison72 closed D8314: phabricator: add an option to fold several commits into one review (issue6244).
Apr 16 2020, 12:42 PM
mharbison72 committed rHG3dc6a70779f2: phabricator: add an option to fold several commits into one review (issue6244).
phabricator: add an option to fold several commits into one review (issue6244)
Apr 16 2020, 12:42 PM
mharbison72 committed rHGed81fa859426: tests: move the phabricator auth token to the global config file.
tests: move the phabricator auth token to the global config file
Apr 16 2020, 12:42 PM
mharbison72 committed rHG38f7b2f02f6d: phabricator: add debug logging to show previous node values in `phabsend`.
phabricator: add debug logging to show previous node values in `phabsend`
Apr 16 2020, 12:42 PM
mharbison72 added inline comments to D8436: phabricator: avoid creating unstable children within the review stack.
Apr 16 2020, 11:10 AM
mharbison72 added a comment to D8431: upgrade: support upgrade and downgrade from persistent nodemap.

s/requirements is not/requirement is now/ in the summary, but otherwise LGTM

Apr 16 2020, 9:51 AM
mharbison72 accepted D8430: nodemap: teach `hg debugformat` about the persistent nodemap option.
Apr 16 2020, 12:10 AM
mharbison72 added a comment to D8429: upgrade: support the --quiet flag.

I think it might make sense to make some of these messages note() or debug(), but this is still an improvement.

Apr 16 2020, 12:05 AM

Apr 15 2020

mharbison72 accepted D8428: upgrade: clearly list optimisation.
Apr 15 2020, 11:58 PM
mharbison72 added a comment to D8439: make: drop the `-c` arg to `install` in the documentation makefile.

This helps it get further, but then it dies with messages like:

find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/32/
...
install: hg-ssh.8 was not found anywhere!
find: cycle detected for /lib/secure/32/
find: cycle detected for /lib/crypto/32/
find: cycle detected for /lib/32/
...
install: hgrc.5 was not found anywhere!
...
Apr 15 2020, 10:50 PM
mharbison72 added a comment to D8439: make: drop the `-c` arg to `install` in the documentation makefile.

This helps it get further, but then it dies with messages like:

Apr 15 2020, 10:37 PM
mharbison72 created D8439: make: drop the `-c` arg to `install` in the documentation makefile.
Apr 15 2020, 10:28 PM
mharbison72 added a comment to D8435: modified A.

This was to generate tests.

Apr 15 2020, 8:30 PM
mharbison72 added a comment to D8434: modified 1.

This was to generate tests.

Apr 15 2020, 8:29 PM
mharbison72 added a comment to D8433: modified 2.

This was to generate tests.

Apr 15 2020, 8:29 PM
mharbison72 created D8438: phabricator: restack any new orphans created by phabsend (issue6045).
Apr 15 2020, 7:57 PM
mharbison72 created D8437: phabricator: prevent posting obsolete commits.
Apr 15 2020, 7:57 PM
mharbison72 created D8436: phabricator: avoid creating unstable children within the review stack.
Apr 15 2020, 7:57 PM
mharbison72 created D8435: modified A.
Apr 15 2020, 7:44 PM
mharbison72 created D8434: modified 1.
Apr 15 2020, 7:43 PM
mharbison72 created D8433: modified 2.
Apr 15 2020, 7:43 PM
mharbison72 accepted D8426: wait-on-file: use proper variable in math.
Apr 15 2020, 6:11 PM
mharbison72 added a comment to D8425: wait-on-file: don't quote arithmetic argument.

I couldn't reproduce the problem on 10.14 with or without this. But I can confirm that it appears to fix the issue on MSYS.

Apr 15 2020, 6:10 PM

Apr 14 2020

mharbison72 closed D8407: revset: mark `extinct()` experimental.
Apr 14 2020, 3:18 PM
mharbison72 closed D8406: revset: mark `successors()` experimental.
Apr 14 2020, 3:18 PM
mharbison72 closed D8405: revset: mark `obsolete()` experimental.
Apr 14 2020, 3:18 PM
mharbison72 committed rHG7834da4b00fa: revset: mark `extinct()` experimental.
revset: mark `extinct()` experimental
Apr 14 2020, 3:18 PM
mharbison72 committed rHGbcc1846e0f2b: revset: mark `successors()` experimental.
revset: mark `successors()` experimental
Apr 14 2020, 3:18 PM
mharbison72 committed rHG1ac74f653fa5: revset: mark `obsolete()` experimental.
revset: mark `obsolete()` experimental
Apr 14 2020, 3:18 PM
mharbison72 closed D8404: revset: import `unstable()` from the evolve extension.
Apr 14 2020, 12:42 PM
mharbison72 committed rHG48b99af7b4b3: revset: import `unstable()` from the evolve extension.
revset: import `unstable()` from the evolve extension
Apr 14 2020, 12:41 PM

Apr 13 2020

mharbison72 created D8407: revset: mark `extinct()` experimental.
Apr 13 2020, 12:27 PM
mharbison72 updated the diff for D8404: revset: import `unstable()` from the evolve extension.
Apr 13 2020, 12:27 PM
mharbison72 created D8406: revset: mark `successors()` experimental.
Apr 13 2020, 12:27 PM
mharbison72 created D8405: revset: mark `obsolete()` experimental.
Apr 13 2020, 12:27 PM
mharbison72 added inline comments to D8404: revset: import `unstable()` from the evolve extension.
Apr 13 2020, 12:26 PM
mharbison72 created D8404: revset: import `unstable()` from the evolve extension.
Apr 13 2020, 1:26 AM

Apr 8 2020

mharbison72 added a comment to D8388: added file.

This was only for generating tests

Apr 8 2020, 6:01 PM
mharbison72 added a comment to D8387: one: first commit to review.

This was only for generating tests

Apr 8 2020, 6:01 PM
mharbison72 added a comment to D8386: one: first commit to review.

This was only for generating tests

Apr 8 2020, 6:00 PM
mharbison72 created D8389: phabricator: add debug logging to show previous node values in `phabsend`.
Apr 8 2020, 5:52 PM
mharbison72 updated the summary of D8314: phabricator: add an option to fold several commits into one review (issue6244).
Apr 8 2020, 5:52 PM
mharbison72 created D8390: tests: move the phabricator auth token to the global config file.
Apr 8 2020, 5:52 PM
mharbison72 updated the summary of D8388: added file.
Apr 8 2020, 5:13 PM
mharbison72 updated the summary of D8388: added file.
Apr 8 2020, 5:13 PM