mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (92 w, 4 d)

Recent Activity

Tue, Apr 9

mharbison72 added a comment to D6196: cext: make revlog.c PY_SSIZE_T_CLEAN.
In D6196#90521, @yuja wrote:
4   org.python.python             	0x00000001000eb761 va_build_value + 737
5   org.python.python             	0x00000001000eb837 _Py_BuildValue_SizeT + 167

Maybe we shouldn't trust the Python doc too much, which says 's#' of
Py_BuildValue() takes an int.

https://docs.python.org/2/c-api/arg.html#c.Py_BuildValue

Can you test if this patch fixes the problem?

diff --git a/mercurial/cext/parsers.c b/mercurial/cext/parsers.c
--- a/mercurial/cext/parsers.c
+++ b/mercurial/cext/parsers.c
@@ -184,7 +184,8 @@ static PyObject *parse_dirstate(PyObject
 		goto quit;
 	}
 
-	parents = Py_BuildValue(PY23("s#s#", "y#y#"), str, 20, str + 20, 20);
+	parents = Py_BuildValue(PY23("s#s#", "y#y#"), str, (Py_ssize_t)20,
+	                        str + 20, (Py_ssize_t)20);
 	if (!parents) {
 		goto quit;
 	}
diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -366,7 +366,7 @@ static PyObject *index_get(indexObject *
 
 	entry = Py_BuildValue(tuple_format, offset_flags, comp_len, uncomp_len,
 	                      base_rev, link_rev, parent_1, parent_2, c_node_id,
-	                      20);
+	                      (Py_ssize_t)20);
 
 	if (entry) {
 		PyObject_GC_UnTrack(entry);
@@ -3017,8 +3017,9 @@ void revlog_module_init(PyObject *mod)
 	PyModule_AddObject(mod, "nodetree", (PyObject *)&nodetreeType);
 
 	if (!nullentry) {
-		nullentry = Py_BuildValue(PY23("iiiiiiis#", "iiiiiiiy#"), 0, 0,
-		                          0, -1, -1, -1, -1, nullid, 20);
+		nullentry =
+		    Py_BuildValue(PY23("iiiiiiis#", "iiiiiiiy#"), 0, 0, 0, -1,
+		                  -1, -1, -1, nullid, (Py_ssize_t)20);
 	}
 	if (nullentry)
 		PyObject_GC_UnTrack(nullentry);
Tue, Apr 9, 12:51 PM

Mon, Apr 8

mharbison72 committed rHG57645939df59: packaging: ensure that --python is an absolute path when building on Windows.
packaging: ensure that --python is an absolute path when building on Windows
Mon, Apr 8, 2:50 PM
mharbison72 committed rHG9c07d345fd6d: packaging: don't crash building wix with python3.6 and earlier.
packaging: don't crash building wix with python3.6 and earlier
Mon, Apr 8, 2:50 PM
mharbison72 added a comment to D6196: cext: make revlog.c PY_SSIZE_T_CLEAN.

I don't have time to look into this, but this makes the mac builds very unhappy. (The parent runs fine.) Somehow the bot is still running, but recording various segfaults. When I tried to investigate, the build process fails because python hg version is segfaulting. Here's the output of that, with the initial python frames removed:

Mon, Apr 8, 12:32 PM

Sat, Apr 6

mharbison72 committed rHG456c37433c43: py3: write out hgextindex as bytes in setup.py.
py3: write out hgextindex as bytes in setup.py
Sat, Apr 6, 8:42 PM

Fri, Apr 5

mharbison72 committed rHG7cfd20bc0721: py3: write out hgextindex as bytes in setup.py.
py3: write out hgextindex as bytes in setup.py
Fri, Apr 5, 9:11 PM

Tue, Apr 2

mharbison72 committed rHGf4147ca63d39: uncommit: abort if an explicitly given file cannot be uncommitted (BC).
uncommit: abort if an explicitly given file cannot be uncommitted (BC)
Tue, Apr 2, 6:40 PM

Mar 23 2019

mharbison72 committed rHGdb26dbbee74d: diff: support diffing explicit files in subrepos.
diff: support diffing explicit files in subrepos
Mar 23 2019, 9:10 PM

Mar 21 2019

mharbison72 added a comment to D6140: revset: add new contiguous(x) function for "x::x".

Josef 'Jeff' Sipek <jeffpc@josefsipek.net> sent this to mercurial-devel. I'm adding it here for reference.

I read this doc string and the patch intro several times, and every time I
concluded that this function was useless. Only after reading some of the
other replies, did I realize that "x" here can be a set.

The docstring does say "in the set" :) But I agree that it's not very clear. I copied the pattern from other functions. I would probably have said "in the input set" otherwise. Do you think that would have been clearer? We could make that change to all the existing cases of plain "set" referring to the input.

Mar 21 2019, 12:16 AM

Mar 19 2019

mharbison72 added a comment to D6140: revset: add new contiguous(x) function for "x::x".

I've only used X::X where X was trivial, so I'm still trying to get my mind around this. Out of curiosity, what are the scenarios where a nontrivial X is useful?

Mar 19 2019, 11:36 PM

Mar 18 2019

mharbison72 added a comment to D6148: store: error out if fncache does not ends with a newline.

Is there something that can be done to repair this, that should be suggested in the hint? I've seen fncache errors in the context of a corrupt repo, but I'm not sure what an end user would do with this message.

Mar 18 2019, 9:40 PM
mharbison72 committed rHG4ea21df312ec: record: prevent commits that don't pick up dirty subrepo changes (issue6102).
record: prevent commits that don't pick up dirty subrepo changes (issue6102)
Mar 18 2019, 8:18 AM

Mar 16 2019

mharbison72 added inline comments to D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 16 2019, 6:31 PM

Mar 15 2019

mharbison72 added a comment to D6142: automation: perform tasks on remote machines.

I don't know anything about PowerShell or AWS, but this series looks nice for making Windows easier to deal with.

Mar 15 2019, 11:23 PM

Mar 14 2019

mharbison72 requested changes to D6058: patch: include flag-only file changes in "special" while filtering patch (issue5864).
Mar 14 2019, 12:47 PM

Mar 11 2019

mharbison72 added inline comments to D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 11 2019, 12:28 PM

Mar 10 2019

mharbison72 committed rHG35e29a3aa441: tests: stabilize test-bundle.t on Windows.
tests: stabilize test-bundle.t on Windows
Mar 10 2019, 6:28 PM

Mar 9 2019

mharbison72 committed rHG0cbcb3e13fcf: tests: stabilize test-split.t for Windows.
tests: stabilize test-split.t for Windows
Mar 9 2019, 8:50 PM
mharbison72 added a comment to D6082: phabricator: add a `--branch` flag to `hg phabsend`.
In D6082#88981, @Kwan wrote:
In D6082#88851, @pulkit wrote:

@mharbison72 thanks for tips on adding test. Will add tests in next iteration.

I found that Differentials do have a branch field, maybe we can use that? https://secure.phabricator.com/source/phabricator/browse/master/src/applications/differential/customfield/DifferentialBranchField.php

Seems worth a shot. I don’t know anything about it, but presumably this would be rendered specially in the web UI, like the test plan, etc. That sounds better than as a follow up comment. It also seems natural enough that maybe it can be done unconditionally, instead of needing the argument.

Yeah, it shows in the Diff Detail pane, like here. Unfortunately I think it can be only set when using the creatediff endpoint, which is what I had to change my fork to do (though I could be wrong, the conduit docs are too sparse to be sure).

Mar 9 2019, 1:27 PM

Mar 8 2019

mharbison72 committed rHGe82c932c01e3: tests: stabilize test-share.t on Windows.
tests: stabilize test-share.t on Windows
Mar 8 2019, 8:26 PM
mharbison72 added a comment to D6082: phabricator: add a `--branch` flag to `hg phabsend`.
In D6082#88851, @pulkit wrote:

@mharbison72 thanks for tips on adding test. Will add tests in next iteration.

I found that Differentials do have a branch field, maybe we can use that? https://secure.phabricator.com/source/phabricator/browse/master/src/applications/differential/customfield/DifferentialBranchField.php

Mar 8 2019, 6:12 PM

Mar 7 2019

mharbison72 added inline comments to D6069: uncommit: add flag --allow-dirty-working-copy.
Mar 7 2019, 12:38 PM
mharbison72 added a comment to D6082: phabricator: add a `--branch` flag to `hg phabsend`.

To create a test, you need to pip install pytest-vcr, edit auth.hgphab.phabtoken at the top of the test, and use --test-vcr with your hg phabsend command. See a641fd1a1196 for some background, and remember to purge your phabtoken from the changes before posting. FWIW, I used a VirtualBox VM running Phabricator from Bitnami to figure things out before generating the test on phab.m-s.o to avoid extra noise.

Mar 7 2019, 12:35 PM

Mar 4 2019

mharbison72 added a comment to rHG38de3300414f: py3: convert filtername to str if it's None.

There are a handful of other places in branchmap and elsewhere that also log or format repo.filtername.

Mar 4 2019, 11:10 PM

Mar 2 2019

mharbison72 added inline comments to D6038: push: added clear warning message when pushing closed branches(issue6080).
Mar 2 2019, 1:01 AM

Feb 27 2019

mharbison72 committed rHGe0a3ee3fdb33: tests: add more wildcards to test-extdiff.t.
tests: add more wildcards to test-extdiff.t
Feb 27 2019, 7:50 PM

Feb 22 2019

mharbison72 added inline comments to D5299: phabricator: fallback reading arcanist config files.
Feb 22 2019, 12:59 PM

Feb 20 2019

mharbison72 committed rHGa62690659d6b: tests: add a missing abort exit code on Windows in test-audit-subrepo.t.
tests: add a missing abort exit code on Windows in test-audit-subrepo.t
Feb 20 2019, 9:37 PM

Feb 19 2019

mharbison72 committed rHG92055d539e49: tests: conditionalize msys path mangling in test-bundle.t.
tests: conditionalize msys path mangling in test-bundle.t
Feb 19 2019, 11:06 AM
mharbison72 committed rHG19d8d6856338: tests: glob over quoting differences in test-blackbox.t for Windows.
tests: glob over quoting differences in test-blackbox.t for Windows
Feb 19 2019, 11:06 AM
mharbison72 added a comment to D5981: tests: drop a few unnecessary "(glob)".

The tests run clean with this.

But I'm a bit confused. The test harness has been doing '\' -> '/' conversion without (glob) now for a little over a year, and it complains if there's a trailing (glob) and no '\' -> '/' conversion. That's not been happening here, and made me suspicious. These globs predate that functionality slightly, so I'm not sure the meaning of the referenced commit (which seems to say nothing will change because ui.slash is set).

You're right, and even if I go back to bdcaf612e75a (where you added these globs), it seems like it should have been converted to slashes already there (because the test runner set ui.slash back then, too, and the code seemed to respect that). Do you have time to go back and see if the globbing was never needed?

Feb 19 2019, 10:14 AM

Feb 18 2019

mharbison72 added a comment to D5981: tests: drop a few unnecessary "(glob)".

The tests run clean with this.

Feb 18 2019, 12:32 PM
mharbison72 committed rHGeb8a8af4cbd0: tests: correct the remaining fallout from recent path style changes on Windows.
tests: correct the remaining fallout from recent path style changes on Windows
Feb 18 2019, 12:13 AM

Feb 17 2019

mharbison72 added a comment to D5801: files: respect ui.relative-paths.

I noticed another bug and sent D5978. Maybe your test failure is because you're using the eol extension? I don't know what else would cause the \r in contrib.perf. I have no idea how that's related to this patch, though.

The \r is how output normally is on Windows. The test harness accounts for this when matching lines, but displays the actual output (with \r) when there are differences. The eol extension isn’t configured on this machine, but the custom HGRCPATH content from the test harness would override that anyway.

Ah, so the only difference is the extra "import newer module separately in try clause for early Mercurial" in contrib/perf.py then. This patch didn't change that file. Can you check again that it was this patch that caused that and that it's not just flaky?

Feb 17 2019, 5:52 PM
mharbison72 added a comment to D5801: files: respect ui.relative-paths.

I noticed another bug and sent D5978. Maybe your test failure is because you're using the eol extension? I don't know what else would cause the \r in contrib.perf. I have no idea how that's related to this patch, though.

Feb 17 2019, 3:15 PM

Feb 16 2019

mharbison72 added a comment to D5898: debugignore: respect ui.relative-paths.

This seems to have converted a test from dos to unix style. I'm not sure if that was intentional, or if this feature is still a WIP. (Sorry, I've been busy lately, and haven't had time to follow this closely)

Feb 16 2019, 10:53 PM
mharbison72 added a comment to D5801: files: respect ui.relative-paths.

For some reason, this breaks test-contrib-perf.t:

Feb 16 2019, 10:45 PM

Feb 7 2019

mharbison72 committed rHG698667eb7523: lfs: disable all authentication except Basic for HTTP(S) connections.
lfs: disable all authentication except Basic for HTTP(S) connections
Feb 7 2019, 11:02 AM
mharbison72 committed rHG67e622ade415: tests: stabilize test-extdiff.t on Windows.
tests: stabilize test-extdiff.t on Windows
Feb 7 2019, 11:02 AM
mharbison72 committed rHGa263b7d71105: tests: stabilize test-extdiff.t on Windows.
tests: stabilize test-extdiff.t on Windows
Feb 7 2019, 7:21 AM
mharbison72 committed rHG98930b0a645a: lfs: disable all authentication except Basic for HTTP(S) connections.
lfs: disable all authentication except Basic for HTTP(S) connections
Feb 7 2019, 7:21 AM
mharbison72 committed rHG87a6e3c953e0: subrepo: avoid false unsafe path detection on Windows.
subrepo: avoid false unsafe path detection on Windows
Feb 7 2019, 6:39 AM

Feb 6 2019

mharbison72 committed rHG46432c04f010: tests: enable HTTP digest testing.
tests: enable HTTP digest testing
Feb 6 2019, 7:41 AM
mharbison72 committed rHG349c8879becd: py3: ensure the HTTP password manager returns strings, not bytes.
py3: ensure the HTTP password manager returns strings, not bytes
Feb 6 2019, 7:41 AM
mharbison72 committed rHG765a608c2108: wsgiheaders: make sure __repr__() returns a string.
wsgiheaders: make sure __repr__() returns a string
Feb 6 2019, 7:41 AM
mharbison72 committed rHGccaa52865fac: tests: add code to handle HTTP digests on the server side.
tests: add code to handle HTTP digests on the server side
Feb 6 2019, 7:41 AM
mharbison72 committed rHG7855a949b7c2: run-tests: allow spaces in the --view tool.
run-tests: allow spaces in the --view tool
Feb 6 2019, 7:41 AM
mharbison72 committed rHG549af2fa089f: tests: extract the http server authentication extension to a single module.
tests: extract the http server authentication extension to a single module
Feb 6 2019, 7:41 AM

Feb 5 2019

mharbison72 added a comment to D5800: config: introduce a new value for ui.relative-paths getting old behavior.

Maybe a py3 thing?

Feb 5 2019, 11:50 PM
mharbison72 added inline comments to D5800: config: introduce a new value for ui.relative-paths getting old behavior.
Feb 5 2019, 10:09 PM

Feb 4 2019

mharbison72 committed rHGe095a9688a31: tests: quote $PYTHON for py3 support on Windows.
tests: quote $PYTHON for py3 support on Windows
Feb 4 2019, 4:55 PM
mharbison72 committed rHGef29b6b8768c: py3: byteify the --retest path of run-tests.py.
py3: byteify the --retest path of run-tests.py
Feb 4 2019, 4:55 PM
mharbison72 committed rHGf9150901267c: run-tests: sort the skip, failure and error lists in the final output.
run-tests: sort the skip, failure and error lists in the final output
Feb 4 2019, 4:54 PM

Feb 1 2019

mharbison72 committed rHG92c25572c24c: tests: quote $PYTHON for py3 support on Windows.
tests: quote $PYTHON for py3 support on Windows
Feb 1 2019, 10:53 PM
mharbison72 committed rHG6e9513fac7a1: py3: byteify the --retest path of run-tests.py.
py3: byteify the --retest path of run-tests.py
Feb 1 2019, 10:53 PM
mharbison72 added inline comments to D5745: status: extract helper for producing relative or absolute path for UI.
Feb 1 2019, 10:36 PM
mharbison72 committed rHG44c5506a2572: tests: quote $PYTHON for py3 support on Windows.
tests: quote $PYTHON for py3 support on Windows
Feb 1 2019, 7:21 AM
mharbison72 committed rHGd3dc4abc547a: py3: byteify the --retest path of run-tests.py.
py3: byteify the --retest path of run-tests.py
Feb 1 2019, 7:21 AM

Jan 31 2019

mharbison72 added a comment to D5749: hgweb: log error before attempting I/O.

@durin42 and I were both able to produce intermittent failures with this change. Why, I'm not sure.

Does the Windows regression occur with this patch or with D5751? I ask because the behavior of socket.shutdown() is documented to vary by platform. I wouldn't at all be surprised if D5751 caused the regression seen here.

It was this patch.

Like I said, I’ve seen connection resets in the non-daemonized serve output (don’t recall if it was push, pull, or both). I thought it was weird, but there were no other signs of problems, so I wrote it off as some odd Windows thing. (Not sure that I’ve seen it on Linux or OS X too)

Does D5764 help the situation? It made a big difference for me.

Jan 31 2019, 4:56 PM
mharbison72 added a comment to D5780: tags: avoid generating commit for an already deleted tag (issue5752).

Since the tag command's code is already looking at repo.tagtype(), I wonder if it would be better to just inline the global tag lookup and nullid comparison right there instead of updating the interface.

Jan 31 2019, 12:15 PM
mharbison72 committed rHGbb98870ab38d: run-tests: sort the skip, failure and error lists in the final output.
run-tests: sort the skip, failure and error lists in the final output
Jan 31 2019, 8:03 AM
mharbison72 committed rHG13e9a5eaf321: run-tests: sort the skip, failure and error lists in the final output.
run-tests: sort the skip, failure and error lists in the final output
Jan 31 2019, 7:41 AM

Jan 30 2019

mharbison72 added a comment to D5749: hgweb: log error before attempting I/O.

@durin42 and I were both able to produce intermittent failures with this change. Why, I'm not sure.

Does the Windows regression occur with this patch or with D5751? I ask because the behavior of socket.shutdown() is documented to vary by platform. I wouldn't at all be surprised if D5751 caused the regression seen here.

Jan 30 2019, 8:26 PM
mharbison72 added a comment to D5749: hgweb: log error before attempting I/O.

While this is better, it triggers a few failures on Windows. I've seen these connection resets with hg serve outside of the test harness. Any ideas? It almost seems like the client is closing the socket before all of the data is sent. (This failure occurs on py2)

Jan 30 2019, 7:03 PM

Jan 29 2019

mharbison72 committed rHG1bc01490178a: lfs: explicitly add the Content-Length header when uploading blobs, for py3.
lfs: explicitly add the Content-Length header when uploading blobs, for py3
Jan 29 2019, 6:14 AM

Jan 28 2019

mharbison72 committed rHG3757a968d63a: py3: stabilize the output of lfs commandserver tests.
py3: stabilize the output of lfs commandserver tests
Jan 28 2019, 7:07 AM
mharbison72 committed rHG080a5c83914f: py3: conditionalize some LFS test output.
py3: conditionalize some LFS test output
Jan 28 2019, 7:07 AM
mharbison72 committed rHG52a4a3e7cc6a: py3: force hgweb.server error log to internally write unicode.
py3: force hgweb.server error log to internally write unicode
Jan 28 2019, 7:07 AM
mharbison72 committed rHG0b636d1720a0: lfs: strip the response headers from the Batch API before printing.
lfs: strip the response headers from the Batch API before printing
Jan 28 2019, 7:07 AM
mharbison72 committed rHG7df10ea7a5b8: py3: byteify the decoded JSON responses upon receipt in the LFS blobstore.
py3: byteify the decoded JSON responses upon receipt in the LFS blobstore
Jan 28 2019, 7:07 AM
mharbison72 committed rHG4045ab21945a: hgweb: ensure Content-Length and Content-Type are not promoted to HTTP_ on py3.
hgweb: ensure Content-Length and Content-Type are not promoted to HTTP_ on py3
Jan 28 2019, 7:07 AM
mharbison72 committed rHG40efcf78f3df: py3: raw stringify various JSON and HTTP headers in the LFS blobstore module.
py3: raw stringify various JSON and HTTP headers in the LFS blobstore module
Jan 28 2019, 7:07 AM
mharbison72 committed rHG6d7f18cd81d9: py3: raw stringify various things in the LFS server module.
py3: raw stringify various things in the LFS server module
Jan 28 2019, 7:07 AM
mharbison72 committed rHG02d0a7774882: py3: byteify the LFS blobstore module.
py3: byteify the LFS blobstore module
Jan 28 2019, 7:07 AM
mharbison72 committed rHG7a11e4e55d5f: py3: add b'' prefixes to the LFS server module.
py3: add b'' prefixes to the LFS server module
Jan 28 2019, 7:07 AM
mharbison72 committed rHG2a1bb442593b: py3: add b'' and r'' prefixes to LFS tests.
py3: add b'' and r'' prefixes to LFS tests
Jan 28 2019, 7:07 AM

Jan 26 2019

mharbison72 committed rHGed99c7b52106: tests: conditionalize Windows difference in test-dispatch.t.
tests: conditionalize Windows difference in test-dispatch.t
Jan 26 2019, 2:10 AM
mharbison72 committed rHGbaffda74891c: py3: fix a bytes/str mingling in test-install.t.
py3: fix a bytes/str mingling in test-install.t
Jan 26 2019, 2:10 AM

Jan 25 2019

mharbison72 committed rHG93c3742cbf5b: tests: conditionalize Windows difference in test-dispatch.t.
tests: conditionalize Windows difference in test-dispatch.t
Jan 25 2019, 11:20 PM
mharbison72 committed rHGb9389ceefeab: py3: fix a bytes/str mingling in test-install.t.
py3: fix a bytes/str mingling in test-install.t
Jan 25 2019, 11:20 PM

Jan 22 2019

mharbison72 added a comment to D5496: revset: add "samebranch" keyword argument to the merge revset.
In D5496#82671, @yuja wrote:

Do you mean that the flag should only indicate whether you want to hide the same branch merges? I guess that is OK too, since the main use case for this flag is to hide the merge from the same branch. However I think we should change the flag name then. Perhaps "hidesame"? Or "includesame" or "includeself", defaulting to True? Any ideas?

Jan 22 2019, 1:28 PM

Jan 19 2019

mharbison72 committed rHGb5d7413e4009: help: document the minimumhgversion variable for extensions.
help: document the minimumhgversion variable for extensions
Jan 19 2019, 6:30 AM
mharbison72 committed rHG86f6b441adea: help: modernize the example for command registration.
help: modernize the example for command registration
Jan 19 2019, 6:30 AM

Jan 17 2019

mharbison72 committed rHGc9e1104e6272: exthelper: drop the addattr() decorator.
exthelper: drop the addattr() decorator
Jan 17 2019, 7:10 AM
mharbison72 committed rHG878084a495ef: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 4:41 AM
mharbison72 committed rHG8bde55072523: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 4:35 AM
mharbison72 committed rHG6ffe7c15f75d: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Jan 17 2019, 3:34 AM

Jan 16 2019

mharbison72 added a comment to D5495: revset: add "branch" positional arguments to the merge revset.

I've sent an updated set of patches, following your recommendations. There are 2 patches now, since each includes its own tests. This means that the 3rd patch on the original patch set is no longer needed. However I don't know what is the best way to tell that to phabricator...

Jan 16 2019, 12:59 AM

Jan 11 2019

mharbison72 committed rHG69804c040a04: convert: don't drop commits that are empty in the source when using --filemap.
convert: don't drop commits that are empty in the source when using --filemap
Jan 11 2019, 7:53 AM
mharbison72 committed rHG77088fa862df: convert: add missing numcommits() override to hg sources.
convert: add missing numcommits() override to hg sources
Jan 11 2019, 7:53 AM

Jan 10 2019

mharbison72 committed rHG43fd1947301d: phabricator: teach {phabreview} to work without --amend.
phabricator: teach {phabreview} to work without --amend
Jan 10 2019, 6:26 AM
mharbison72 committed rHG0101a35deae2: phabricator: warn if unable to amend, instead of aborting after posting.
phabricator: warn if unable to amend, instead of aborting after posting
Jan 10 2019, 6:26 AM

Jan 9 2019

mharbison72 abandoned D5545: create draft change for phabricator testing.
Jan 9 2019, 11:30 PM
mharbison72 abandoned D5544: create public change for phabricator testing.
Jan 9 2019, 11:30 PM
mharbison72 created D5545: create draft change for phabricator testing.
Jan 9 2019, 11:08 PM
mharbison72 added a dependent revision for D5544: create public change for phabricator testing: D5545: create draft change for phabricator testing.
Jan 9 2019, 11:08 PM
mharbison72 created D5544: create public change for phabricator testing.
Jan 9 2019, 11:08 PM

Jan 6 2019

mharbison72 accepted D5498: server: always close http socket if responding with an error (issue6033).

This works for me on Windows in that narrow window where this was constantly happening, thanks!

Jan 6 2019, 11:16 PM

Jan 5 2019

mharbison72 added inline comments to D5489: histedit: add warning message on editing tagged commits (issue4017).
Jan 5 2019, 9:09 PM
mharbison72 committed rHG70e3e3da24be: templatekw: fix documentation typos.
templatekw: fix documentation typos
Jan 5 2019, 2:06 AM