Page MenuHomePhabricator

mharbison72 (Matt Harbison)
User

Projects

User Details

User Since
Jul 16 2017, 3:10 PM (210 w, 6 d)

Recent Activity

Fri, Jul 30

mharbison72 added inline comments to D11232: rewriteutil: fix crash when a rewritten message references f{6,64}.
Fri, Jul 30, 2:11 PM
mharbison72 closed D11235: typing: add several assertions to dirstatemap to appease pytype.
Fri, Jul 30, 11:11 AM
mharbison72 committed rHG460e479be66e: typing: add several assertions to dirstatemap to appease pytype.
typing: add several assertions to dirstatemap to appease pytype
Fri, Jul 30, 11:11 AM
mharbison72 created D11235: typing: add several assertions to dirstatemap to appease pytype.
Fri, Jul 30, 1:13 AM

Thu, Jul 29

mharbison72 added inline comments to D11232: rewriteutil: fix crash when a rewritten message references f{6,64}.
Thu, Jul 29, 11:16 PM
mharbison72 added a comment to D11231: tests: add explicit coverage for update_hash_refs from rewriteutil.

I couldn't find any evidence this is covered by tests in core

Thu, Jul 29, 11:07 PM
mharbison72 added inline comments to D11163: largefile: use `set_possibly_dirty` instead of `normallookup`.
Thu, Jul 29, 10:00 PM
mharbison72 added inline comments to D11132: dirstate: factor out the part retrieve "filedata" out of `normal`.
Thu, Jul 29, 9:46 PM
mharbison72 added inline comments to D11088: dirstate-v2: Introduce a docket file.
Thu, Jul 29, 9:32 PM

Thu, Jul 22

mharbison72 closed D11206: typing: convert an annotation to an assertion in commands.py.
Thu, Jul 22, 1:07 PM
mharbison72 closed D11207: upgrade: byteify an i18n message.
Thu, Jul 22, 1:07 PM
mharbison72 committed rHG6b9ad3a0c348: upgrade: byteify an i18n message.
upgrade: byteify an i18n message
Thu, Jul 22, 1:07 PM
mharbison72 committed rHG76dccbbe73fd: typing: convert an annotation to an assertion in commands.py.
typing: convert an annotation to an assertion in commands.py
Thu, Jul 22, 1:07 PM

Wed, Jul 21

mharbison72 added a comment to D11207: upgrade: byteify an i18n message.

file is not bytes, so this will crash, will it not ?

Wed, Jul 21, 5:31 PM
mharbison72 created D11206: typing: convert an annotation to an assertion in commands.py.
Wed, Jul 21, 4:07 PM
mharbison72 created D11207: upgrade: byteify an i18n message.
Wed, Jul 21, 4:07 PM

Sun, Jul 18

mharbison72 committed rHG0caac68a5c3c: doc: wrap the help text for the purge extension.
doc: wrap the help text for the purge extension
Sun, Jul 18, 6:05 AM
mharbison72 closed D11036: doc: wrap the help text for the purge extension.
Sun, Jul 18, 6:05 AM

Sun, Jul 11

mharbison72 added inline comments to D11081: run-test: rework the redirection script for python on windows.
Sun, Jul 11, 7:54 PM
mharbison72 added inline comments to D11049: run-tests: introduce a `HGTEST_REAL_HG` variable for test.
Sun, Jul 11, 7:35 PM
D11046: run-test: clarify the error with a bad --with-hg is passed now requires changes to proceed.
Sun, Jul 11, 7:29 PM
mharbison72 added a comment to D11025: ci-windows: introduce manual windows CI.

I assume the various things that I was installing in before_script are now baked into to the docker image/runner host? (That's good, it was my intention. But the TEMP variable hack made me wonder if maybe it wasn't yet.)

Yes they are.

I'm also a bit surprised you haven't hit any issues by leaving out the make local bits.

I don't know what error you were getting without --local, but the latest run are doing without it. I made a bunch of fixes to run-tests.py that might have helped (and there will be more)

Sun, Jul 11, 2:02 PM

Sat, Jul 10

mharbison72 added a comment to D11025: ci-windows: introduce manual windows CI.

I assume the various things that I was installing in before_script are now baked into to the docker image/runner host? (That's good, it was my intention. But the TEMP variable hack made me wonder if maybe it wasn't yet.)

Sat, Jul 10, 7:18 PM
mharbison72 added inline comments to D11057: compat: enforce upper case drive letter in mercurial too.
Sat, Jul 10, 4:38 PM

Fri, Jul 9

mharbison72 added a comment to D11035: run-tests: enforce the drive letter from `getcwd` to upper case.

Does the issue happen with 3.7? I'm wondering if this is the normalization they started to do in os.path.realpath(). See 3dfebba99ef6

Fri, Jul 9, 1:02 PM
mharbison72 created D11036: doc: wrap the help text for the purge extension.
Fri, Jul 9, 11:45 AM
mharbison72 added a comment to D10693: run-tests: fix whitelist/blacklist with directories on Windows.

This landed as dff19fe2973c, but lacked the Differential URL in the commit comment somehow. It may have gotten pulled off of the Windows CI work on heptapod.

Fri, Jul 9, 11:31 AM
mharbison72 added a comment to D10692: run-tests: ignore PermissionError when checking available ports.

This landed as 6e0af81c43b2, but lacked the Differential URL in the commit comment somehow. It may have gotten pulled off of the Windows CI work on heptapod.

Fri, Jul 9, 11:25 AM
mharbison72 added a comment to D10693: run-tests: fix whitelist/blacklist with directories on Windows.

It looks like this never landed.

Fri, Jul 9, 11:13 AM
mharbison72 added inline comments to D11000: windows: add windows behavior on broken pager.
Fri, Jul 9, 11:08 AM

Thu, Jul 8

mharbison72 added a comment to D11000: windows: add windows behavior on broken pager.

Is there any more context you can/want to supply about the bug, what's better about Windows, the rabbit hole, etc?

Thu, Jul 8, 12:01 PM

Sat, Jul 3

mharbison72 added inline comments to D10936: cmdutil: fix newandmodified file accounting for --interactive commits.
Sat, Jul 3, 12:21 AM

Jun 24 2021

mharbison72 committed rHG75d4e60c7c81: purge: restore the `testedwith` declaration.
purge: restore the `testedwith` declaration
Jun 24 2021, 4:18 AM
mharbison72 closed D10895: purge: restore the `testedwith` declaration.
Jun 24 2021, 4:18 AM

Jun 23 2021

mharbison72 added a comment to D10893: amend: add a useless initial version of `amend -r REV `.

We have talked internally at work about some kind of interactive hg absorb that lets you decide which commit each line should go into. That sounds similar to what you're thinking of.

Jun 23 2021, 1:22 AM

Jun 22 2021

mharbison72 added a comment to D10893: amend: add a useless initial version of `amend -r REV `.
Jun 22 2021, 8:39 PM
mharbison72 added a comment to D10893: amend: add a useless initial version of `amend -r REV `.

This is indeed a very important quality-of-life feature and I'm +1 on adding it to Mercurial.

Jun 22 2021, 6:13 PM
mharbison72 created D10895: purge: restore the `testedwith` declaration.
Jun 22 2021, 1:25 PM

Jun 21 2021

mharbison72 added a comment to D10870: typing: disable warnings for a couple of Windows specific attributes.

Can this get grafted to stable? It goes with 5b3513177f2b. I'm not sure why the stable branch wasn't flagged in phab, because that's where the obsolete commit is in my repo.

Jun 21 2021, 11:13 PM

Jun 17 2021

mharbison72 closed D10870: typing: disable warnings for a couple of Windows specific attributes.
Jun 17 2021, 9:31 AM
mharbison72 committed rHGf77404040776: typing: disable warnings for a couple of Windows specific attributes.
typing: disable warnings for a couple of Windows specific attributes
Jun 17 2021, 9:31 AM
mharbison72 closed D10876: typing: suppress a false error in mercurial/revlogutils/docket.py on py2.
Jun 17 2021, 9:31 AM
mharbison72 committed rHGbe903d043099: typing: suppress a false error in mercurial/revlogutils/docket.py on py2.
typing: suppress a false error in mercurial/revlogutils/docket.py on py2
Jun 17 2021, 9:31 AM

Jun 15 2021

mharbison72 closed D10873: py3: byteify the version string passed to the deprecation warning method.
Jun 15 2021, 2:56 PM
mharbison72 closed D10875: revlog: byteify a few error strings.
Jun 15 2021, 2:56 PM
mharbison72 closed D10874: revlog: fix a typo closing the wrong file.
Jun 15 2021, 2:56 PM
mharbison72 committed rHG5fbac82a8780: revlog: byteify a few error strings.
revlog: byteify a few error strings
Jun 15 2021, 2:56 PM
mharbison72 committed rHG5e44936b82be: revlog: fix a typo closing the wrong file.
revlog: fix a typo closing the wrong file
Jun 15 2021, 2:56 PM
mharbison72 closed D10872: urlutil: byteify several localized messages.
Jun 15 2021, 2:56 PM
mharbison72 committed rHGc887bab2dccf: py3: byteify the version string passed to the deprecation warning method.
py3: byteify the version string passed to the deprecation warning method
Jun 15 2021, 2:56 PM
mharbison72 committed rHG515014d72aa2: urlutil: byteify several localized messages.
urlutil: byteify several localized messages
Jun 15 2021, 2:56 PM
mharbison72 closed D10871: urlutil: use the deprecation warning function on the `ui` object.
Jun 15 2021, 2:56 PM
mharbison72 committed rHG65333ecc8b34: urlutil: use the deprecation warning function on the `ui` object.
urlutil: use the deprecation warning function on the `ui` object
Jun 15 2021, 2:56 PM

Jun 12 2021

mharbison72 created D10876: typing: suppress a false error in mercurial/revlogutils/docket.py on py2.
Jun 12 2021, 2:51 PM
mharbison72 created D10873: py3: byteify the version string passed to the deprecation warning method.
Jun 12 2021, 12:57 AM
mharbison72 created D10875: revlog: byteify a few error strings.
Jun 12 2021, 12:57 AM
mharbison72 created D10874: revlog: fix a typo closing the wrong file.
Jun 12 2021, 12:57 AM
mharbison72 created D10872: urlutil: byteify several localized messages.
Jun 12 2021, 12:57 AM
mharbison72 created D10871: urlutil: use the deprecation warning function on the `ui` object.
Jun 12 2021, 12:56 AM

Jun 11 2021

mharbison72 created D10870: typing: disable warnings for a couple of Windows specific attributes.
Jun 11 2021, 11:45 PM

May 28 2021

mharbison72 committed rHG717a94b423b9: merge with stable.
merge with stable
May 28 2021, 5:39 PM

May 27 2021

mharbison72 closed D10759: tests: monkeypatch `util.get_password()` to avoid deadlocks on Windows.
May 27 2021, 5:37 PM
mharbison72 committed rHG5ac0f2a8ba72: tests: monkeypatch `util.get_password()` to avoid deadlocks on Windows.
tests: monkeypatch `util.get_password()` to avoid deadlocks on Windows
May 27 2021, 5:36 PM

May 25 2021

mharbison72 committed rHG825d5a5907b4: exewrapper: avoid directly linking against python3X.dll.
exewrapper: avoid directly linking against python3X.dll
May 25 2021, 12:34 PM
mharbison72 added a comment to D10756: exewrapper: avoid directly linking against python3X.dll.

Oh wow - I never would have thought that the presence of this symbol would affect linking behavior. But I suppose it makes sense. The functions are probably left as unresolved references but the static variable reference forces early binding or something.

May 25 2021, 12:06 AM

May 24 2021

mharbison72 closed D10756: exewrapper: avoid directly linking against python3X.dll.
May 24 2021, 9:55 PM
mharbison72 committed rHGa30d5cd1c45e: exewrapper: avoid directly linking against python3X.dll.
exewrapper: avoid directly linking against python3X.dll
May 24 2021, 9:55 PM

May 23 2021

mharbison72 closed D10763: tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows.
May 23 2021, 6:07 PM
mharbison72 committed rHG93fc0a13b7e8: tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows.
tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows
May 23 2021, 6:07 PM
mharbison72 closed D10762: tests: fix test-transaction-safety.t on Windows.
May 23 2021, 6:07 PM
mharbison72 committed rHGb1ce93dcdf3c: tests: fix test-transaction-safety.t on Windows.
tests: fix test-transaction-safety.t on Windows
May 23 2021, 6:07 PM
mharbison72 closed D10761: run-tests: disable color in 'auto' mode on Windows if stdout is redirected.
May 23 2021, 6:06 PM
mharbison72 closed D10760: run-tests: enable color on Windows.
May 23 2021, 6:06 PM
mharbison72 committed rHGaf4d1a177548: run-tests: disable color in 'auto' mode on Windows if stdout is redirected.
run-tests: disable color in 'auto' mode on Windows if stdout is redirected
May 23 2021, 6:05 PM
mharbison72 committed rHGbb4606f35d37: run-tests: enable color on Windows.
run-tests: enable color on Windows
May 23 2021, 6:05 PM

May 21 2021

mharbison72 updated subscribers of D10756: exewrapper: avoid directly linking against python3X.dll.

@indygreg - you might be interested in the I/O issue. PyOxidizer doesn't seem to be affected (at least when it's building with 3.9.5), but does seem to set Py_LegacyWindowsStdioFlag. Also not sure if there are other issues with the pager code. I remember you looking at it a little over a year ago and saying there were a lot if iffy things, but IDR seeing a patch series after that.

May 21 2021, 11:46 AM
mharbison72 updated the summary of D10756: exewrapper: avoid directly linking against python3X.dll.
May 21 2021, 10:54 AM
mharbison72 created D10763: tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows.
May 21 2021, 12:38 AM
mharbison72 created D10762: tests: fix test-transaction-safety.t on Windows.
May 21 2021, 12:38 AM

May 20 2021

mharbison72 created D10761: run-tests: disable color in 'auto' mode on Windows if stdout is redirected.
May 20 2021, 4:17 PM
mharbison72 created D10760: run-tests: enable color on Windows.
May 20 2021, 4:16 PM
mharbison72 created D10759: tests: monkeypatch `util.get_password()` to avoid deadlocks on Windows.
May 20 2021, 3:41 PM
mharbison72 created D10756: exewrapper: avoid directly linking against python3X.dll.
May 20 2021, 10:23 AM

May 17 2021

mharbison72 committed rHGdff19fe2973c: run-tests: fix whitelist/blacklist with directories on Windows.
run-tests: fix whitelist/blacklist with directories on Windows
May 17 2021, 4:42 AM
mharbison72 committed rHG6e0af81c43b2: run-tests: ignore PermissionError when checking available ports.
run-tests: ignore PermissionError when checking available ports
May 17 2021, 4:41 AM

May 14 2021

mharbison72 closed D10702: run-tests: use the same python version for shebang lines on Windows.
May 14 2021, 4:07 PM
mharbison72 committed rHG6f976d54946c: run-tests: use the same python version for shebang lines on Windows.
run-tests: use the same python version for shebang lines on Windows
May 14 2021, 4:06 PM
mharbison72 closed D10708: util: avoid echoing the password to the console on Windows py3 (issue6446).
May 14 2021, 3:10 PM
mharbison72 closed D10462: heptapod-ci: enable pytype checking.
May 14 2021, 3:09 PM
mharbison72 closed D10694: hghave: fix the definition of `python3` to work on Windows.
May 14 2021, 3:09 PM
mharbison72 committed rHGe917fa36fb58: heptapod-ci: enable pytype checking.
heptapod-ci: enable pytype checking
May 14 2021, 3:09 PM
mharbison72 committed rHG94c0c36299b1: hghave: fix the definition of `python3` to work on Windows.
hghave: fix the definition of `python3` to work on Windows
May 14 2021, 3:09 PM
mharbison72 committed rHG5b3513177f2b: util: avoid echoing the password to the console on Windows py3 (issue6446).
util: avoid echoing the password to the console on Windows py3 (issue6446)
May 14 2021, 3:09 PM

May 12 2021

mharbison72 created D10708: util: avoid echoing the password to the console on Windows py3 (issue6446).
May 12 2021, 12:44 PM

May 11 2021

D10689: pyoxidizer: use Python 3.9 (BC) is now accepted and ready to land.

Thanks for grinding through this packaging stuff!

May 11 2021, 12:18 AM
D10688: packaging: use PyOxidizer for producing WiX MSI installer is now accepted and ready to land.
May 11 2021, 12:16 AM
D10687: packaging: extract invocation of pyoxidizer to own function is now accepted and ready to land.

This is interesting because the test-gendoc-* tests mostly fail on my Windows machines with py3 (but work with py2). The executable is /mingw/bin/msgfmt.exe, but it's been there forever and IDR where I got it. That's a strange place for executables, so I assume it's not from the mingw installers and that I just stuffed it there as a convenient way to get it on PATH. Installing various MSYS packages on the new CI system didn't install a msgfmt that hghave accepted. So then I installed https://github.com/vslavik/gettext-tools-windows/releases/download/v0.21-1/gettext-tools-windows-0.21-1.zip, and it failed the tests in a different way. The 0.14.4 version from SF doesn't seem to print a version number, so that's likely why hghave won't use it for tests.

May 11 2021, 12:11 AM

May 10 2021

D10686: packaging: rename run_pyoxidizer() is now accepted and ready to land.
May 10 2021, 11:48 PM
D10685: packaging: move documentation HTML building to own function is now accepted and ready to land.
May 10 2021, 11:47 PM
D10684: pyoxidizer: support code signing is now accepted and ready to land.
May 10 2021, 11:46 PM