mharbison72 (Matt Harbison)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2017, 3:10 PM (73 w, 2 d)

Recent Activity

Mon, Dec 10

mharbison72 added inline comments to D5400: tests: use $RUNTESTDIR instead of $TESTDIR in narrow-library.sh.
Mon, Dec 10, 12:18 PM
mharbison72 committed rHG4265bfb53dd3: hgweb: register web.comparisoncontext to the config table.
hgweb: register web.comparisoncontext to the config table
Mon, Dec 10, 7:17 AM
mharbison72 committed rHG348352658e4b: py3: stop subscripting socket.error.
py3: stop subscripting socket.error
Mon, Dec 10, 7:04 AM
mharbison72 committed rHG07e181ed82ef: py3: quote several instances of $PYTHON for Windows.
py3: quote several instances of $PYTHON for Windows
Mon, Dec 10, 7:04 AM
mharbison72 committed rHG1aedbf3ef3d1: py3: adapt test-largefiles-wireproto.t to python3.
py3: adapt test-largefiles-wireproto.t to python3
Mon, Dec 10, 7:04 AM
mharbison72 committed rHGd3d52cc91e83: py3: byteify test-push-race.t.
py3: byteify test-push-race.t
Mon, Dec 10, 7:04 AM
mharbison72 committed rHGf79659e1e50f: py3: convert filename to bytes in test-hardlinks.t.
py3: convert filename to bytes in test-hardlinks.t
Mon, Dec 10, 7:04 AM

Tue, Dec 4

mharbison72 committed rHGf6d37e84d8f9: tests: stabilize for recent wcache changes.
tests: stabilize for recent wcache changes
Tue, Dec 4, 9:54 AM
mharbison72 committed rHGc460b1643eb0: tests: stabilize test-blackbox.t on Windows.
tests: stabilize test-blackbox.t on Windows
Tue, Dec 4, 9:54 AM
mharbison72 committed rHG151aec6494a8: extdiff: avoid double backslashes in the displayed tool path on Windows.
extdiff: avoid double backslashes in the displayed tool path on Windows
Tue, Dec 4, 9:54 AM
mharbison72 committed rHG97190b0bb81a: extdiff: register the configuration generated commands with a help category.
extdiff: register the configuration generated commands with a help category
Tue, Dec 4, 6:40 AM
mharbison72 committed rHGd7d1951b874f: tests: stabilize test-blackbox.t on Windows.
tests: stabilize test-blackbox.t on Windows
Tue, Dec 4, 6:40 AM
mharbison72 committed rHG6ae6a4a43f3d: tests: stabilize for recent wcache changes.
tests: stabilize for recent wcache changes
Tue, Dec 4, 6:40 AM
mharbison72 committed rHG1035e5de53cb: extdiff: avoid double backslashes in the displayed tool path on Windows.
extdiff: avoid double backslashes in the displayed tool path on Windows
Tue, Dec 4, 6:40 AM

Sun, Dec 2

mharbison72 committed rHG0605726179a0: tests: apply binary mode to output in seq.py.
tests: apply binary mode to output in seq.py
Sun, Dec 2, 6:34 AM

Wed, Nov 28

mharbison72 committed rHGfc252cc8b837: remotefilelog: prevent this extension from loading on Windows.
remotefilelog: prevent this extension from loading on Windows
Wed, Nov 28, 7:10 AM
mharbison72 committed rHG5e00457e2bcd: tests: also skip remotefilelog *.py tests on Windows.
tests: also skip remotefilelog *.py tests on Windows
Wed, Nov 28, 7:10 AM

Tue, Nov 27

mharbison72 added a comment to D5064: style: run black on a subset of mercurial.

Does anyone strongly object, or do we want to embrace black and the formatting changes it implies?

Tue, Nov 27, 1:31 PM

Mon, Nov 26

mharbison72 committed rHG0800d9e6e216: tests: disable remotefilelog on Windows.
tests: disable remotefilelog on Windows
Mon, Nov 26, 6:48 AM

Sat, Nov 24

mharbison72 committed rHG246b61bfdc2f: procutil: don't allow the main 'hg' script to be treated as the Windows exe.
procutil: don't allow the main 'hg' script to be treated as the Windows exe
Sat, Nov 24, 10:11 PM
mharbison72 committed rHG72d88a975655: remotefilelog: drop some compatibility cruft for finding the hg exeutable.
remotefilelog: drop some compatibility cruft for finding the hg exeutable
Sat, Nov 24, 10:11 PM
mharbison72 added inline comments to D5299: phabricator: fallback reading arcanist config files.
Sat, Nov 24, 12:31 PM

Wed, Nov 21

mharbison72 committed rHG25b7c4cb5de1: tests: stabilize the recent checkexec changes on Windows.
tests: stabilize the recent checkexec changes on Windows
Wed, Nov 21, 6:41 AM

Sat, Nov 17

mharbison72 committed rHGfb379b78b93e: lfs: ensure that the return of urlopener.open() is closed.
lfs: ensure that the return of urlopener.open() is closed
Sat, Nov 17, 9:32 PM
mharbison72 committed rHGc53f0ead5781: http: allow 'auth.prefix' to have a username consistent with the URI.
http: allow 'auth.prefix' to have a username consistent with the URI
Sat, Nov 17, 1:12 AM

Fri, Nov 16

mharbison72 committed rHG380f5131ee7b: lfs: handle URLErrors to add additional information.
lfs: handle URLErrors to add additional information
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG93e5d18251d6: lfs: make the exception messages consistent.
lfs: make the exception messages consistent
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG9f78d10742af: lfs: improve the hints for common errors in the Batch API.
lfs: improve the hints for common errors in the Batch API
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG4ec8bee15930: scmutil: display the optional hint when handling StorageError in catchall().
scmutil: display the optional hint when handling StorageError in catchall()
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG8863f08c1630: lfs: provide more Batch API error info via a hint in the raised exception.
lfs: provide more Batch API error info via a hint in the raised exception
Fri, Nov 16, 11:48 PM
mharbison72 committed rHG69d4c8c5c25e: subrepo: print the status line before creating the peer for better diagnostics.
subrepo: print the status line before creating the peer for better diagnostics
Fri, Nov 16, 9:18 PM
mharbison72 committed rHG6d0fdeda43f7: tests: stabilize test-commandserver.t on Windows.
tests: stabilize test-commandserver.t on Windows
Fri, Nov 16, 8:58 AM
mharbison72 committed rHG291080871f50: histedit: conditionalize the imports of 'fcntl' and 'termios'.
histedit: conditionalize the imports of 'fcntl' and 'termios'
Fri, Nov 16, 8:58 AM

Wed, Nov 14

mharbison72 committed rHG7c5a922be068: tests: document a known failing interaction between narrow and lfs.
tests: document a known failing interaction between narrow and lfs
Wed, Nov 14, 7:29 AM

Nov 11 2018

mharbison72 committed rHG7e2c58b08e74: phabricator: ensure the command summaries are available in extension help.
phabricator: ensure the command summaries are available in extension help
Nov 11 2018, 8:29 AM

Nov 10 2018

mharbison72 added a reverting commit for rHG1ea6772fb415: phase: handle phase with no command flag: rHGef694e477783: phase: use the `phases.cmdphasenames` constant to walk available command flags.
Nov 10 2018, 7:56 PM
mharbison72 committed rHGef694e477783: phase: use the `phases.cmdphasenames` constant to walk available command flags.
phase: use the `phases.cmdphasenames` constant to walk available command flags
Nov 10 2018, 7:56 PM
mharbison72 committed rHGab893a99b645: phases: add a list of names usable by the phase command.
phases: add a list of names usable by the phase command
Nov 10 2018, 7:56 PM

Nov 9 2018

mharbison72 added a comment to D5251: share: reload repo after adjusting it in postshare().
I also don't know what a "locally referenced subrepo"
Nov 9 2018, 10:30 PM
mharbison72 committed rHG5b530d767e67: help: unjumble the list of default config values for `internals.config`.
help: unjumble the list of default config values for `internals.config`
Nov 9 2018, 6:55 AM

Nov 3 2018

mharbison72 committed rHGff37b1712fa5: tests: conditonalize a difference in test-merge-tools.t on Windows.
tests: conditonalize a difference in test-merge-tools.t on Windows
Nov 3 2018, 10:17 PM

Oct 29 2018

mharbison72 committed rHG909c31805f54: py3: roll up threading.Thread constructor args into **kwargs.
py3: roll up threading.Thread constructor args into **kwargs
Oct 29 2018, 4:47 PM
mharbison72 committed rHGd69cf134bd50: tests: glob over a single quote vs double quote difference on Windows.
tests: glob over a single quote vs double quote difference on Windows
Oct 29 2018, 4:47 PM

Oct 25 2018

mharbison72 committed rHG94c0421d67a0: logexchange: convert paths to unix when detecting the active path.
logexchange: convert paths to unix when detecting the active path
Oct 25 2018, 7:07 AM
mharbison72 committed rHG5e917b224c20: help: update the default value specified for `profiling.time-track`.
help: update the default value specified for `profiling.time-track`
Oct 25 2018, 7:07 AM
mharbison72 committed rHG89703e6151e7: profiling: revert the default mode back to 'cpu' on Windows.
profiling: revert the default mode back to 'cpu' on Windows
Oct 25 2018, 7:07 AM

Oct 22 2018

mharbison72 committed rHG36b134c436b8: setup: build exewrapper with Unicode support on py3.
setup: build exewrapper with Unicode support on py3
Oct 22 2018, 11:49 AM
mharbison72 committed rHG973ff03d9bc0: exewrapper: convert to _tcsxxx functions for Unicode compatability.
exewrapper: convert to _tcsxxx functions for Unicode compatability
Oct 22 2018, 11:49 AM
mharbison72 committed rHGaca727359ec5: exewrapper: drop an unused variable.
exewrapper: drop an unused variable
Oct 22 2018, 11:49 AM
mharbison72 committed rHG4a81d82474e9: lfs: consult the narrow matcher when extracting pointers from ctx (issue5794).
lfs: consult the narrow matcher when extracting pointers from ctx (issue5794)
Oct 22 2018, 8:10 AM

Oct 20 2018

mharbison72 added a comment to D4312: New bookflow extension for bookmark-based branching.

I'm actually kinda looking forward to see if lfs works better with all the new changes.

Oct 20 2018, 9:46 PM
mharbison72 committed rHGa9e303dcd1e1: py3: stringify setupversion on Windows.
py3: stringify setupversion on Windows
Oct 20 2018, 3:13 AM
mharbison72 committed rHGbd1ec1e36bf0: tests: add coverage for some untested areas of hgweb.
tests: add coverage for some untested areas of hgweb
Oct 20 2018, 3:13 AM

Oct 19 2018

mharbison72 committed rHGef6cab7930b3: py3: fix module imports in tests, as flagged by test-check-module-imports.t.
py3: fix module imports in tests, as flagged by test-check-module-imports.t
Oct 19 2018, 8:56 AM
mharbison72 committed rHG5a81c4aa6313: tests: glob over a difference between Windows 7 and Window 10.
tests: glob over a difference between Windows 7 and Window 10
Oct 19 2018, 8:56 AM
mharbison72 committed rHG3b84ef904aea: py3: fix module imports in test-highlight.t.
py3: fix module imports in test-highlight.t
Oct 19 2018, 8:56 AM
mharbison72 committed rHGfad6068249d9: lfs: don't add extension to hgrc after conversion (BC).
lfs: don't add extension to hgrc after conversion (BC)
Oct 19 2018, 8:56 AM
mharbison72 updated subscribers of D5130: lfs: autoload the extension when cloning from repo with lfs enabled.

! In D5130#76736, @mharbison72 wrote:
Also, I need to see if this can be made to work with cloning from a local repo.

I'm really not a fan of local / hardlink clones. They are very brittle. When you start throwing extra repo features like LFS into the mix, it becomes even more dangerous. Especially when we start talking about adding modifying .hg/requires automatically. The fundamental problem is the hardlink clone is strictly separate but it "inherits" some state from its parent. If we start varying behavior of the two repos, interaction between them can be wonky. In general, for advanced features, we should go through the "hg clone --pull" interface to create a clean break and minimize potential for wonkiness.

Oct 19 2018, 12:04 AM

Oct 18 2018

mharbison72 committed rHG633da7139e4a: py3: fix test-import-context.t.
py3: fix test-import-context.t
Oct 18 2018, 9:11 AM
mharbison72 committed rHG1524c305377f: py3: restore perfstartup() prior to b456b2e0ad9f on Windows.
py3: restore perfstartup() prior to b456b2e0ad9f on Windows
Oct 18 2018, 9:11 AM
mharbison72 committed rHG124507a263e5: help: document the server capabilities added by the LFS extension.
help: document the server capabilities added by the LFS extension
Oct 18 2018, 9:11 AM
mharbison72 committed rHGe5d74742d00e: py3: fix test-propertycache.py on Windows.
py3: fix test-propertycache.py on Windows
Oct 18 2018, 9:11 AM

Oct 17 2018

mharbison72 added a comment to D5130: lfs: autoload the extension when cloning from repo with lfs enabled.

One thing I forgot to mention in the commit comment is that hg clone --rev REV, where REV is some commit prior to committing any lfs blobs, will cause the requirement to be added to the clone. That didn't happen previously with the transaction hook. But that's probably enough of a corner case to not really care.

Oct 17 2018, 8:49 PM
mharbison72 added a comment to D5130: lfs: autoload the extension when cloning from repo with lfs enabled.

As a follow-up, it would be nice to have the LFS wire protocol capabilities documented in mercurial/help/internals/wireprotocol.txt, especially since it isn't obvious how the now 2 capabilities are different.

Oct 17 2018, 8:00 AM
mharbison72 closed D5130: lfs: autoload the extension when cloning from repo with lfs enabled.
Oct 17 2018, 3:30 AM
mharbison72 committed rHG6637b079ae45: lfs: autoload the extension when cloning from repo with lfs enabled.
lfs: autoload the extension when cloning from repo with lfs enabled
Oct 17 2018, 3:29 AM
mharbison72 created D5130: lfs: autoload the extension when cloning from repo with lfs enabled.
Oct 17 2018, 12:36 AM

Oct 16 2018

mharbison72 accepted D5121: procutil: port over windows encoding fixes from logtoprocess.

LGTM, thanks.

Oct 16 2018, 10:49 PM
mharbison72 committed rHG43f0a37bd9ed: py3: byteify extension in test-relink.t.
py3: byteify extension in test-relink.t
Oct 16 2018, 3:25 AM
mharbison72 added a comment to D5025: py3: make test-contrib-perf.t work on python 3.
In D5025#75556, @yuja wrote:
def perfstartup(ui, repo, **opts):
    opts = _byteskwargs(opts)
    timer, fm = gettimer(ui, opts)
  • cmd = sys.argv[0] + cmd = fsencode(sys.argv[0])

Applying fsencode() on sys.argv is probably wrong on Windows, but it's perf.py,
I don't care.

Sadly, it doesn't work on Windows. But since os.system() is called with an r-string, bytes wouldn't be right anyway. When I simply formatted in sys.argv[0], I got this:

--- c:/Users/Matt/projects/hg_py3/tests/test-contrib-perf.t
+++ c:/Users/Matt/projects/hg_py3/tests/test-contrib-perf.t.err
@@ -184,6 +184,7 @@
   $ hg perfrevrange
   $ hg perfrevset 'all()'
   $ hg perfstartup
+  (null): can't open file '<unprintable file name>': [Errno 2] $ENOENT$
   $ hg perfstatus
   $ hg perftags
   $ hg perftemplating

This will be good to figure out because there are ~400 other instances of this error, mostly around launching hooks.

Oct 16 2018, 12:11 AM

Oct 15 2018

mharbison72 added a comment to D5025: py3: make test-contrib-perf.t work on python 3.
In D5025#75556, @yuja wrote:
def perfstartup(ui, repo, **opts):
    opts = _byteskwargs(opts)
    timer, fm = gettimer(ui, opts)
  • cmd = sys.argv[0] + cmd = fsencode(sys.argv[0])

Applying fsencode() on sys.argv is probably wrong on Windows, but it's perf.py,
I don't care.

Oct 15 2018, 11:05 PM
mharbison72 committed rHG3570adf20d91: help: fix a missing quote character in ui.tweakdefaults.
help: fix a missing quote character in ui.tweakdefaults
Oct 15 2018, 2:05 AM

Oct 14 2018

mharbison72 committed rHG52b773f5e9a4: tests: replace `cd ..` with an absolute path in a couple ssh tests.
tests: replace `cd ..` with an absolute path in a couple ssh tests
Oct 14 2018, 12:52 AM
mharbison72 committed rHG8783710b1d58: run-tests: restore quoting the python executable for running *.py tests.
run-tests: restore quoting the python executable for running *.py tests
Oct 14 2018, 12:52 AM
mharbison72 committed rHG9c4cbbb0fc51: lfs: register the flag processors per repository.
lfs: register the flag processors per repository
Oct 14 2018, 12:52 AM
mharbison72 committed rHG9d5ddf55415b: revlog: allow flag processors to be applied via store options.
revlog: allow flag processors to be applied via store options
Oct 14 2018, 12:52 AM
mharbison72 committed rHGab04ce6f0674: py3: use str to query registry values on Windows.
py3: use str to query registry values on Windows
Oct 14 2018, 12:52 AM

Oct 12 2018

mharbison72 committed rHG38ac525b44c9: phabricator: drop support for the legacy phabricator.auth.token config (BC).
phabricator: drop support for the legacy phabricator.auth.token config (BC)
Oct 12 2018, 1:42 AM
mharbison72 committed rHG1be1689d9ce9: absorb: print '{rev}:' as a prefix to the hash.
absorb: print '{rev}:' as a prefix to the hash
Oct 12 2018, 1:42 AM
mharbison72 committed rHG535fc8a22365: lfs: avoid a potential variable reference before assignment error in cmdserver.
lfs: avoid a potential variable reference before assignment error in cmdserver
Oct 12 2018, 1:32 AM

Oct 11 2018

mharbison72 added inline comments to D4939: logtoprocess: use new runbgcommand from procutil.
Oct 11 2018, 12:09 PM

Oct 5 2018

mharbison72 added a comment to D4750: filelog: stop proxying rawsize() (API).

Apparently thg uses this to avoid loading the data into memory just to figure out the length like fctx.rawsize(). Any suggestions?

Oct 5 2018, 12:37 AM
mharbison72 added a comment to D4778: wireprotov2: client support for following content redirects.

Windows doesn't like this test, and gets a connection refused. Under the glob is the machine name instead of $LOCALIP that is used above it. Obviously this isn't the right fix, but this makes the test run on Windows to illustrate it's not something else:

Oct 5 2018, 12:12 AM

Oct 4 2018

mharbison72 added a comment to D4713: largefiles: automatically load largefiles extension when required (BC).
In D4713#73260, @yuja wrote:

IIUC, we would have to enable the largefiles extension once to clone the
repo, but that's no longer needed. So you can enable the extension without
hearing its name at all.

Perhaps, a warning can be displayed when the non-core repository requirement
is added?

Oct 4 2018, 12:36 AM

Oct 3 2018

mharbison72 committed rHG138e2d6d3b53: setup: ignore message about disabling 3rd party extensions because of version.
setup: ignore message about disabling 3rd party extensions because of version
Oct 3 2018, 8:29 AM

Oct 2 2018

mharbison72 added a comment to D4713: largefiles: automatically load largefiles extension when required (BC).
In D4713#73077, @yuja wrote:
> Can we add some warnings here? The largefiles is IMHO one of the most buggy
>  extensions, and loading it has a side effect (e.g. fsmonitor is disabled.)
>  It shouldn't be silently loaded into the process.


I get what you’re thinking, but maybe a debug message is better than a warning, even though it’s less visible. I’m concerned about every invocation being unnecessarily noisy now that .hg/hgrc isn’t updated,

I don't think a debug message would work because ordinary users will never
see it. Is that common to work on largefiles repo without enabling the
extension globally?

Oct 2 2018, 11:19 PM
mharbison72 committed rHGa339b5e0d7c6: py3: suppress the output from .write() calls in more tests.
py3: suppress the output from .write() calls in more tests
Oct 2 2018, 8:50 AM
mharbison72 committed rHG8d41097dfe7d: py3: byteify test-lfs.t.
py3: byteify test-lfs.t
Oct 2 2018, 8:50 AM
mharbison72 committed rHGe1f97179a3f5: lfs: explicitly name a key when sorting blob pointers.
lfs: explicitly name a key when sorting blob pointers
Oct 2 2018, 8:50 AM
mharbison72 committed rHG5ee3146c1b20: py3: byteify test-lock.py.
py3: byteify test-lock.py
Oct 2 2018, 8:50 AM
mharbison72 committed rHG1004c8892e63: py3: suppress the output from .write() calls in more tests.
py3: suppress the output from .write() calls in more tests
Oct 2 2018, 7:59 AM
mharbison72 committed rHGcc7ca11488b6: py3: byteify test-lfs.t.
py3: byteify test-lfs.t
Oct 2 2018, 7:59 AM
mharbison72 committed rHG801c625cfaf1: lfs: explicitly name a key when sorting blob pointers.
lfs: explicitly name a key when sorting blob pointers
Oct 2 2018, 7:59 AM
mharbison72 committed rHGcf0aa4ef4c9a: py: byteify test-lock.py.
py: byteify test-lock.py
Oct 2 2018, 7:59 AM
mharbison72 added a comment to D4713: largefiles: automatically load largefiles extension when required (BC).
In D4713#72604, @yuja wrote:
  1. Map of requirements to list of extensions to load automatically when
  2. requirement is present. autoextensions = { + b'largefiles': [b'largefiles'], b'lfs': [b'lfs'], }

Can we add some warnings here? The largefiles is IMHO one of the most buggy
extensions, and loading it has a side effect (e.g. fsmonitor is disabled.)
It shouldn't be silently loaded into the process.

Oct 2 2018, 1:22 AM
mharbison72 committed rHGdb7666f1dea8: py3: suppress the output from .write() calls in more tests.
py3: suppress the output from .write() calls in more tests
Oct 2 2018, 1:21 AM
mharbison72 committed rHG2f58aba48af1: py3: byteify test-lfs.t.
py3: byteify test-lfs.t
Oct 2 2018, 1:21 AM
mharbison72 committed rHG8553d1bac578: lfs: explicitly name a key when sorting blob pointers.
lfs: explicitly name a key when sorting blob pointers
Oct 2 2018, 1:21 AM
mharbison72 committed rHGe986c986713c: py: byteify test-lock.py.
py: byteify test-lock.py
Oct 2 2018, 1:21 AM
mharbison72 committed rHGa063b84ce064: py3: byteify contrib/dumprevlog.
py3: byteify contrib/dumprevlog
Oct 2 2018, 1:19 AM