Page MenuHomePhabricator

mjacob (Manuel Jacob)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2020, 5:14 PM (17 w, 2 d)

Recent Activity

Today

mjacob added a comment to D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.

Could you include in the commit message which commit added the code and which commit made it unnecessary? "the previous patch/commit" is an okay way of saying that , IMO, even though it requires the reviewer to queue the two patches right after each other for the description to make sense.

Fri, Jul 10, 1:15 PM
mjacob created D8724: commit: check branch change on to-be-committed changeset.
Fri, Jul 10, 6:50 AM
mjacob created D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.
Fri, Jul 10, 6:50 AM

Wed, Jul 8

mjacob added a comment to D8714: state: support validated declaration of nested unfinished ops.

Can you give an example of an extension that would benefit from this? It’s not immediately obvious to me, and ideally patches should be written such that it’s obvious for most people. :)

Wed, Jul 8, 8:28 PM
mjacob added a comment to D8713: error: normalize "unresolved conflicts" error messages with a custom class.

Can you separate the change from "unresolved conflicts (see hg resolve, then hg rebase --continue)" to "unresolved conflicts (see 'hg resolve', then 'hg rebase --continue')", to make the diff less noisy?

Wed, Jul 8, 8:20 PM
D8712: black: format some files in preparation for subsequent changes now requires changes to proceed.

Our sources should already be formatted. E.g. if I run black --config=black.toml hgext/rebase.py, it doesn’t change anything. The tests would catch if a file should be reformatted.

Wed, Jul 8, 8:08 PM

Mon, Jul 6

mjacob added a comment to rHGafecc7f76f2d: rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`.

@acezar No problem! Thanks for taking take of the failures. In the meantime, Yuya rebased the other changesets, so that there’s another head now: https://www.mercurial-scm.org/pipermail/mercurial-devel/2020-July/142306.html

Mon, Jul 6, 7:53 AM

Sat, Jul 4

mjacob added a comment to rHGafecc7f76f2d: rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`.

For one failure, I already sent a patch: https://www.mercurial-scm.org/pipermail/mercurial-devel/2020-July/142287.html

Sat, Jul 4, 10:23 AM
mjacob added a comment to rHGafecc7f76f2d: rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`.

I don’t know if it was this or the next changeset, but the tests are currently broken:

Sat, Jul 4, 10:21 AM

Tue, Jun 23

mjacob added a comment to D8654: phases: make phase list dense or dictionaries.

This is probably not the conceptual feedback you were looking for. I hope it’s still helpful.

Tue, Jun 23, 9:23 PM
mjacob added a comment to D8646: update: suggest --merge while `hg up` across topo branches.

I think it would be a good idea to mention both --clean and --merge, but mentioning only --merge is better than mentioning only --clean.

Tue, Jun 23, 9:00 AM

Thu, Jun 18

mjacob accepted D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`.
Thu, Jun 18, 9:43 PM
mjacob added inline comments to D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`.
Thu, Jun 18, 6:15 AM

Jun 6 2020

mjacob added inline comments to D8619: tests: skip pyflakes for mercurial/thirdparty/.
Jun 6 2020, 8:47 AM
mjacob accepted D8618: tests: adjust to the new format in pyflakes output.
Jun 6 2020, 8:43 AM
mjacob added a comment to D8618: tests: adjust to the new format in pyflakes output.

Personally, I would have used REs in the first place, but since they were already using globs, this LGTM.

Jun 6 2020, 8:43 AM
mjacob accepted D8617: tests: consistently use pyflakes as a Python module.
Jun 6 2020, 8:35 AM

Jun 4 2020

mjacob accepted D8606: context: fix creation of ProgrammingError to not use non-existent field.
Jun 4 2020, 1:23 PM
mjacob added a comment to D8606: context: fix creation of ProgrammingError to not use non-existent field.

Otherwise, LGTM.

Jun 4 2020, 2:04 AM

Mar 11 2020

mjacob added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

I like the name --from for the option. It would also make sense in combination with a possible future --into option.

The unfortunate thing about --from is that it implies a range in hg fold, whereas here it seems to be a single(?) commit. It does make a lot of sense within the context of this command though (i.e. taking stuff from this commit). And it took me awhile to get comfortable with the meaning in hg fold, so maybe it can be changed to something else there? In any event, I don't want to hold this up over an experimental name, just thinking out loud.

Mar 11 2020, 6:20 PM

Mar 10 2020

mjacob added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

I like the name --from for the option. It would also make sense in combination with a possible future --into option.

Mar 10 2020, 11:15 PM