- User Since
- Mar 10 2020, 5:14 PM (17 w, 2 d)
Wed, Jul 8
Can you give an example of an extension that would benefit from this? It’s not immediately obvious to me, and ideally patches should be written such that it’s obvious for most people. :)
Can you separate the change from "unresolved conflicts (see hg resolve, then hg rebase --continue)" to "unresolved conflicts (see 'hg resolve', then 'hg rebase --continue')", to make the diff less noisy?
Our sources should already be formatted. E.g. if I run black --config=black.toml hgext/rebase.py, it doesn’t change anything. The tests would catch if a file should be reformatted.
Mon, Jul 6
@acezar No problem! Thanks for taking take of the failures. In the meantime, Yuya rebased the other changesets, so that there’s another head now: https://www.mercurial-scm.org/pipermail/mercurial-devel/2020-July/142306.html
Sat, Jul 4
For one failure, I already sent a patch: https://www.mercurial-scm.org/pipermail/mercurial-devel/2020-July/142287.html
I don’t know if it was this or the next changeset, but the tests are currently broken:
Tue, Jun 23
This is probably not the conceptual feedback you were looking for. I hope it’s still helpful.
I think it would be a good idea to mention both --clean and --merge, but mentioning only --merge is better than mentioning only --clean.
Thu, Jun 18
Jun 6 2020
Personally, I would have used REs in the first place, but since they were already using globs, this LGTM.
Jun 4 2020
Mar 11 2020
Mar 10 2020
I like the name --from for the option. It would also make sense in combination with a possible future --into option.