Page MenuHomePhabricator

mjacob (Manuel Jacob)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2020, 5:14 PM (28 w, 2 d)

Recent Activity

Sat, Sep 19

mjacob added inline comments to D8843: rebase: fix regression in file change detection introduced by 0ecb3b11fcad.
Sat, Sep 19, 1:21 AM
mjacob added inline comments to D9059: procutil: assign stdio objects if they are None.
Sat, Sep 19, 1:12 AM
mjacob added a comment to D9059: procutil: assign stdio objects if they are None.

I think it’s reasonable that Mercurial expects that the stdio streams are initialized properly. Is there a use case for running Mercurial with FDs 0, 1 or 2 set to non-standard streams?

Sat, Sep 19, 12:41 AM

Aug 6 2020

mjacob added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

I agree (with some previous answers) that adding more stuff to --force should be avoided.

Aug 6 2020, 5:00 PM

Jul 29 2020

mjacob updated subscribers of D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 29 2020, 12:30 AM

Jul 28 2020

mjacob created D8843: rebase: fix regression in file change detection introduced by 0ecb3b11fcad.
Jul 28 2020, 2:59 PM
mjacob created D8842: context: re-add `overlayworkingctx._compact()` removed in 6a5dcd754842.
Jul 28 2020, 2:59 PM
mjacob added a reverting change for D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods: D8842: context: re-add `overlayworkingctx._compact()` removed in 6a5dcd754842.
Jul 28 2020, 2:59 PM
mjacob added a reverting change for rHG6a5dcd754842: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods: D8842: context: re-add `overlayworkingctx._compact()` removed in 6a5dcd754842.
Jul 28 2020, 2:59 PM

Jul 27 2020

mjacob added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 27 2020, 8:14 PM
mjacob added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 27 2020, 6:21 PM

Jul 20 2020

mjacob created D8770: relnotes: add release notes for relevant changes I did since the 5.4 release.
Jul 20 2020, 7:23 PM
mjacob created D8769: relnotes: fix indentation.
Jul 20 2020, 5:33 PM
mjacob created D8768: relnotes: make spacing before new section consistent.
Jul 20 2020, 5:33 PM

Jul 17 2020

mjacob closed D8749: absorb: make it explicit if empty changeset was created.
Jul 17 2020, 2:36 PM
mjacob closed D8748: absorb: consider rewrite.empty-successor configuration.
Jul 17 2020, 2:36 PM
mjacob closed D8747: rebase: consider rewrite.empty-successor configuration.
Jul 17 2020, 2:36 PM
mjacob closed D8746: rewriteutil: add utility to check whether empty successors should be skipped.
Jul 17 2020, 2:36 PM
mjacob closed D8745: config: add option to control creation of empty successors during rewrite.
Jul 17 2020, 2:36 PM
mjacob updated subscribers of D8749: absorb: make it explicit if empty changeset was created.

@durin42 suggested "N:deadbeef: N file(s) changed, became M:f005ba11 (empty change)" on the mailing list. That doesn’t quite nail it, as the message should only be shown if there was a change from non-empty to empty.

Jul 17 2020, 2:26 PM
mjacob created D8765: absorb: improve message for the case when changeset became empty.
Jul 17 2020, 2:25 PM
mjacob added a comment to D8745: config: add option to control creation of empty successors during rewrite.

I queued a mailing list version of this series. Should I drop it?

Jul 17 2020, 1:55 PM

Jul 14 2020

mjacob added inline comments to D8746: rewriteutil: add utility to check whether empty successors should be skipped.
Jul 14 2020, 12:26 PM
mjacob added reviewers for D8749: absorb: make it explicit if empty changeset was created: martinvonz, marmoute.
Jul 14 2020, 11:37 AM
mjacob added reviewers for D8748: absorb: consider rewrite.empty-successor configuration: martinvonz, marmoute.
Jul 14 2020, 11:37 AM
mjacob added a reviewer for D8747: rebase: consider rewrite.empty-successor configuration: marmoute.
Jul 14 2020, 11:36 AM
mjacob added reviewers for D8746: rewriteutil: add utility to check whether empty successors should be skipped: martinvonz, marmoute.
Jul 14 2020, 11:36 AM
mjacob added reviewers for D8745: config: add option to control creation of empty successors during rewrite: martinvonz, marmoute.
Jul 14 2020, 11:36 AM
mjacob created D8749: absorb: make it explicit if empty changeset was created.
Jul 14 2020, 11:33 AM
mjacob created D8747: rebase: consider rewrite.empty-successor configuration.
Jul 14 2020, 11:33 AM
mjacob created D8748: absorb: consider rewrite.empty-successor configuration.
Jul 14 2020, 11:33 AM
mjacob created D8745: config: add option to control creation of empty successors during rewrite.
Jul 14 2020, 11:33 AM
mjacob created D8746: rewriteutil: add utility to check whether empty successors should be skipped.
Jul 14 2020, 11:32 AM

Jul 13 2020

mjacob added a comment to D8727: rebase: add test case that shows that inmemory rebase does not preserve merges.

This patch is based on c4e02bd172d57879717f8bc04c4b5bbc9268e36d, but I don't see any such commit. Can you rebase it to a public commit?

Jul 13 2020, 5:12 PM
mjacob added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 13 2020, 11:35 AM
mjacob added inline comments to D8728: overlayworkingctx: rename misleadingly named `isempty()` method.
Jul 13 2020, 11:19 AM
mjacob added inline comments to D8713: error: normalize "unresolved conflicts" error messages with a custom class.
Jul 13 2020, 12:34 AM

Jul 11 2020

mjacob added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 11 2020, 10:35 PM
mjacob retitled D8729: commit: factor out empty commit check to `basectx.isempty()` from commit: factor out empty commit check to `committablectx.isempty()` to commit: factor out empty commit check to `basectx.isempty()`.
Jul 11 2020, 7:12 PM
mjacob updated the diff for D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 11 2020, 7:12 PM
mjacob updated the diff for D8731: memctx: make `parents()` return list of one element if it’s not a merge.
Jul 11 2020, 7:12 PM
mjacob created D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 11 2020, 5:12 PM
mjacob created D8732: rebase: correctly check for empty commit in in-memory mode.
Jul 11 2020, 5:12 PM
mjacob updated the diff for D8729: commit: factor out empty commit check to `basectx.isempty()`.
Jul 11 2020, 5:12 PM
mjacob updated the diff for D8728: overlayworkingctx: rename misleadingly named `isempty()` method.
Jul 11 2020, 5:12 PM
mjacob created D8731: memctx: make `parents()` return list of one element if it’s not a merge.
Jul 11 2020, 5:12 PM

Jul 10 2020

mjacob added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 11:49 PM
mjacob added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 10:14 PM
mjacob added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 9:35 PM
mjacob added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 8:48 PM
mjacob added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 8:10 PM
mjacob created D8729: commit: factor out empty commit check to `basectx.isempty()`.
Jul 10 2020, 7:17 PM
mjacob created D8728: overlayworkingctx: rename misleadingly named `isempty()` method.
Jul 10 2020, 7:16 PM
mjacob created D8727: rebase: add test case that shows that inmemory rebase does not preserve merges.
Jul 10 2020, 6:54 PM
mjacob updated the summary of D8724: commit: check branch change on to-be-committed changeset.
Jul 10 2020, 5:56 PM
mjacob updated the summary of D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.
Jul 10 2020, 5:55 PM
mjacob added a comment to D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.

Could you include in the commit message which commit added the code and which commit made it unnecessary? "the previous patch/commit" is an okay way of saying that , IMO, even though it requires the reviewer to queue the two patches right after each other for the description to make sense.

Jul 10 2020, 1:15 PM
mjacob created D8724: commit: check branch change on to-be-committed changeset.
Jul 10 2020, 6:50 AM
mjacob created D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.
Jul 10 2020, 6:50 AM

Jul 8 2020

mjacob added a comment to D8714: state: support validated declaration of nested unfinished ops.

Can you give an example of an extension that would benefit from this? It’s not immediately obvious to me, and ideally patches should be written such that it’s obvious for most people. :)

Jul 8 2020, 8:28 PM
mjacob added a comment to D8713: error: normalize "unresolved conflicts" error messages with a custom class.

Can you separate the change from "unresolved conflicts (see hg resolve, then hg rebase --continue)" to "unresolved conflicts (see 'hg resolve', then 'hg rebase --continue')", to make the diff less noisy?

Jul 8 2020, 8:20 PM
D8712: black: format some files in preparation for subsequent changes now requires changes to proceed.

Our sources should already be formatted. E.g. if I run black --config=black.toml hgext/rebase.py, it doesn’t change anything. The tests would catch if a file should be reformatted.

Jul 8 2020, 8:08 PM

Jul 6 2020

mjacob added a comment to rHGafecc7f76f2d: rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`.

@acezar No problem! Thanks for taking take of the failures. In the meantime, Yuya rebased the other changesets, so that there’s another head now: https://www.mercurial-scm.org/pipermail/mercurial-devel/2020-July/142306.html

Jul 6 2020, 7:53 AM

Jul 4 2020

mjacob added a comment to rHGafecc7f76f2d: rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`.

For one failure, I already sent a patch: https://www.mercurial-scm.org/pipermail/mercurial-devel/2020-July/142287.html

Jul 4 2020, 10:23 AM
mjacob added a comment to rHGafecc7f76f2d: rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`.

I don’t know if it was this or the next changeset, but the tests are currently broken:

Jul 4 2020, 10:21 AM

Jun 23 2020

mjacob added a comment to D8654: phases: make phase list dense or dictionaries.

This is probably not the conceptual feedback you were looking for. I hope it’s still helpful.

Jun 23 2020, 9:23 PM
mjacob added a comment to D8646: update: suggest --merge while `hg up` across topo branches.

I think it would be a good idea to mention both --clean and --merge, but mentioning only --merge is better than mentioning only --clean.

Jun 23 2020, 9:00 AM

Jun 18 2020

mjacob accepted D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`.
Jun 18 2020, 9:43 PM
mjacob added inline comments to D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`.
Jun 18 2020, 6:15 AM

Jun 6 2020

mjacob added inline comments to D8619: tests: skip pyflakes for mercurial/thirdparty/.
Jun 6 2020, 8:47 AM
mjacob accepted D8618: tests: adjust to the new format in pyflakes output.
Jun 6 2020, 8:43 AM
mjacob added a comment to D8618: tests: adjust to the new format in pyflakes output.

Personally, I would have used REs in the first place, but since they were already using globs, this LGTM.

Jun 6 2020, 8:43 AM
mjacob accepted D8617: tests: consistently use pyflakes as a Python module.
Jun 6 2020, 8:35 AM

Jun 4 2020

mjacob accepted D8606: context: fix creation of ProgrammingError to not use non-existent field.
Jun 4 2020, 1:23 PM
mjacob added a comment to D8606: context: fix creation of ProgrammingError to not use non-existent field.

Otherwise, LGTM.

Jun 4 2020, 2:04 AM

Mar 11 2020

mjacob added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

I like the name --from for the option. It would also make sense in combination with a possible future --into option.

The unfortunate thing about --from is that it implies a range in hg fold, whereas here it seems to be a single(?) commit. It does make a lot of sense within the context of this command though (i.e. taking stuff from this commit). And it took me awhile to get comfortable with the meaning in hg fold, so maybe it can be changed to something else there? In any event, I don't want to hold this up over an experimental name, just thinking out loud.

Mar 11 2020, 6:20 PM

Mar 10 2020

mjacob added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

I like the name --from for the option. It would also make sense in combination with a possible future --into option.

Mar 10 2020, 11:15 PM