Page MenuHomePhabricator

mjacob (Manuel Jacob)
User

Projects

User does not belong to any projects.

User Details

User Since
Tue, Mar 10, 5:14 PM (2 w, 6 d)

Recent Activity

Wed, Mar 11

mjacob added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

I like the name --from for the option. It would also make sense in combination with a possible future --into option.

The unfortunate thing about --from is that it implies a range in hg fold, whereas here it seems to be a single(?) commit. It does make a lot of sense within the context of this command though (i.e. taking stuff from this commit). And it took me awhile to get comfortable with the meaning in hg fold, so maybe it can be changed to something else there? In any event, I don't want to hold this up over an experimental name, just thinking out loud.

Wed, Mar 11, 6:20 PM

Tue, Mar 10

mjacob added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

I like the name --from for the option. It would also make sense in combination with a possible future --into option.

Tue, Mar 10, 11:15 PM