Page MenuHomePhabricator

mjpieters (Martijn Pieters)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2017, 10:41 AM (113 w, 4 d)

Recent Activity

Feb 8 2019

mjpieters closed D5638: branchmap: encapsulate cache updating in the map itself.
Feb 8 2019, 7:45 AM
mjpieters committed rHG328ca3b9e545: branchmap: encapsulate cache updating in the map itself.
branchmap: encapsulate cache updating in the map itself
Feb 8 2019, 7:44 AM

Feb 5 2019

mjpieters closed D5635: branchmap: make branchcache responsible for reading.
Feb 5 2019, 11:45 AM
mjpieters closed D5637: branchmap: add some clarifications and clean up flow.
Feb 5 2019, 11:45 AM
mjpieters committed rHGc795c462b1d6: branchmap: add some clarifications and clean up flow.
branchmap: add some clarifications and clean up flow
Feb 5 2019, 11:45 AM
mjpieters closed D5636: branchmap: updating triggers a write.
Feb 5 2019, 11:45 AM
mjpieters committed rHGeb7ce452e0fb: branchmap: updating triggers a write.
branchmap: updating triggers a write
Feb 5 2019, 11:45 AM
mjpieters committed rHGbf7fb97aecf1: branchmap: make branchcache responsible for reading.
branchmap: make branchcache responsible for reading
Feb 5 2019, 11:45 AM

Jan 28 2019

mjpieters updated the diff for D5638: branchmap: encapsulate cache updating in the map itself.
Jan 28 2019, 1:05 PM
mjpieters updated the diff for D5635: branchmap: make branchcache responsible for reading.
Jan 28 2019, 12:47 PM

Jan 26 2019

mjpieters added inline comments to D5638: branchmap: encapsulate cache updating in the map itself.
Jan 26 2019, 8:46 AM
mjpieters updated the diff for D5638: branchmap: encapsulate cache updating in the map itself.
Jan 26 2019, 8:46 AM
mjpieters updated the diff for D5635: branchmap: make branchcache responsible for reading.
Jan 26 2019, 8:45 AM
mjpieters added inline comments to D5636: branchmap: updating triggers a write.
Jan 26 2019, 8:19 AM
mjpieters updated subscribers of D5635: branchmap: make branchcache responsible for reading.
Jan 26 2019, 8:17 AM
mjpieters closed D5290: branchmap: rename partial -> bcache.
Jan 26 2019, 2:17 AM
mjpieters committed rHG3461814417f3: branchmap: rename partial -> bcache.
branchmap: rename partial -> bcache
Jan 26 2019, 2:17 AM

Jan 21 2019

mjpieters added a comment to D5290: branchmap: rename partial -> bcache.

@yuja: you wanted separate commits, you got separate commits. :-)

Jan 21 2019, 1:13 PM
mjpieters abandoned D5292: branchmap: make it easier for extensions not to break branchcache.

This would need more thought then; the evolve/topic/topicmap codebase wraps the whole branchmap.branchcache class and mucks about with a context manager to re-instate the right name in the branchmap globals so super() doesn't break, which is what led to this patch.

Jan 21 2019, 1:12 PM
mjpieters created D5638: branchmap: encapsulate cache updating in the map itself.
Jan 21 2019, 1:09 PM
mjpieters created D5637: branchmap: add some clarifications and clean up flow.
Jan 21 2019, 1:08 PM
mjpieters created D5635: branchmap: make branchcache responsible for reading.
Jan 21 2019, 1:08 PM
mjpieters created D5636: branchmap: updating triggers a write.
Jan 21 2019, 1:08 PM
mjpieters updated the diff for D5290: branchmap: rename partial -> bcache.
Jan 21 2019, 1:08 PM

Nov 22 2018

mjpieters added a comment to D5290: branchmap: rename partial -> bcache.

The goal of this refactor is to bring clarity to the branchmap cache behaviour, and to make it easier to add performance improvements (in an upcoming additional series of patches).

Nov 22 2018, 6:38 AM

Nov 21 2018

mjpieters created D5292: branchmap: make it easier for extensions not to break branchcache.
Nov 21 2018, 9:56 AM

Nov 20 2018

mjpieters added a comment to D5064: style: run black on a subset of mercurial.
In D5064#78545, @av6 wrote:

I look at the changes and see nitpicks at best. On the one hand, black proved better than any linter that we can already write consistent code. On the other, if black were a linter... I'd switch to flake8, which at least is configurable.

Nov 20 2018, 8:47 AM
mjpieters created D5290: branchmap: rename partial -> bcache.
Nov 20 2018, 8:46 AM

Oct 16 2018

mjpieters abandoned D1508: sparse: clean up path handling, making it platform agnostic.
Oct 16 2018, 10:52 AM
mjpieters abandoned D1509: sparse: make use of treemanifest for far faster path listing.
Oct 16 2018, 10:51 AM
mjpieters closed D5111: branchmap: remove redundant sort.
Oct 16 2018, 6:45 AM
mjpieters committed rHG5644f7c8982e: branchmap: remove redundant sort.
branchmap: remove redundant sort
Oct 16 2018, 6:45 AM
mjpieters created D5111: branchmap: remove redundant sort.
Oct 16 2018, 6:22 AM
mjpieters committed rHG47084b5ffd80: style: drop requirement to only use single lines between top-level objects.
style: drop requirement to only use single lines between top-level objects
Oct 16 2018, 3:56 AM
mjpieters closed D5105: style: drop requirement to only use single lines between top-level objects.
Oct 16 2018, 3:56 AM

Oct 14 2018

mjpieters updated subscribers of D5105: style: drop requirement to only use single lines between top-level objects.

This was split out from D5064 (cc @indygreg )

Oct 14 2018, 9:43 AM
mjpieters updated the diff for D5064: style: run black on a subset of mercurial.
Oct 14 2018, 9:42 AM
mjpieters created D5105: style: drop requirement to only use single lines between top-level objects.
Oct 14 2018, 9:41 AM

Oct 13 2018

mjpieters closed D5079: py3: use py3 as the test tag, dropping the k.
Oct 13 2018, 10:32 AM
mjpieters added a comment to D5079: py3: use py3 as the test tag, dropping the k.

Note: I undid the change to mercurial/thirdparty/zope/interface/_compat.py as it should not have been changed to begin with.

Oct 13 2018, 10:32 AM
mjpieters committed rHG8cf459d8b111: py3: use py3 as the test tag, dropping the k.
py3: use py3 as the test tag, dropping the k
Oct 13 2018, 10:31 AM
mjpieters updated the diff for D5079: py3: use py3 as the test tag, dropping the k.
Oct 13 2018, 10:27 AM
mjpieters created D5079: py3: use py3 as the test tag, dropping the k.
Oct 13 2018, 8:50 AM
mjpieters updated the diff for D5064: style: run black on a subset of mercurial.
Oct 13 2018, 8:39 AM
mjpieters updated the diff for D5064: style: run black on a subset of mercurial.
Oct 13 2018, 7:56 AM
mjpieters added a comment to D5064: style: run black on a subset of mercurial.

The import parentheses collapsing is described here: https://github.com/ambv/black#parentheses. The behavior is not configurable.

Oct 13 2018, 6:12 AM
mjpieters created D5064: style: run black on a subset of mercurial.
Oct 13 2018, 6:07 AM

Aug 16 2018

mjpieters committed rHG222aba766015: perf: time loading branchmap caches.
perf: time loading branchmap caches
Aug 16 2018, 6:33 AM
mjpieters committed rHG2a4bfbb52111: branchmap: load branchmap as an iterable.
branchmap: load branchmap as an iterable
Aug 16 2018, 6:33 AM

Aug 15 2018

mjpieters closed D4280: perf: time loading branchmap caches.
Aug 15 2018, 11:08 PM
mjpieters closed D4281: branchmap: load branchmap as an iterable.
Aug 15 2018, 11:08 PM
mjpieters committed rHG9a800691f075: branchmap: load branchmap as an iterable.
branchmap: load branchmap as an iterable
Aug 15 2018, 11:08 PM
mjpieters committed rHGf16c3efe35e3: perf: time loading branchmap caches.
perf: time loading branchmap caches
Aug 15 2018, 11:08 PM

Aug 13 2018

mjpieters created D4280: perf: time loading branchmap caches.
Aug 13 2018, 4:26 PM
mjpieters created D4281: branchmap: load branchmap as an iterable.
Aug 13 2018, 4:26 PM

Aug 3 2018

mjpieters committed rHG9d49bb117dde: util: make new timedcmstats class Python 3 compatible.
util: make new timedcmstats class Python 3 compatible
Aug 3 2018, 9:44 AM

Aug 2 2018

mjpieters committed rHGd58958676b3c: extensions: add detailed loading information.
extensions: add detailed loading information
Aug 2 2018, 10:48 AM
mjpieters committed rHG8751d1e2a7ff: util: create a context manager to handle timing.
util: create a context manager to handle timing
Aug 2 2018, 10:48 AM
mjpieters committed rHG13dcf5d3761d: extensions: add detailed loading information.
extensions: add detailed loading information
Aug 2 2018, 8:59 AM
mjpieters committed rHGe06d0cfdcad9: util: create a context manager to handle timing.
util: create a context manager to handle timing
Aug 2 2018, 8:59 AM
mjpieters committed rHG7e8e0c9fa99c: extensions: add detailed loading information.
extensions: add detailed loading information
Aug 2 2018, 8:05 AM
mjpieters committed rHG70ff626406c5: util: create a context manager to handle timing.
util: create a context manager to handle timing
Aug 2 2018, 8:05 AM

Aug 1 2018

mjpieters committed rHG0a57945aaf7f: manifest: persist the manifestfulltext cache.
manifest: persist the manifestfulltext cache
Aug 1 2018, 4:17 PM
mjpieters committed rHGddb15a83ae0b: debug: allow specifying a manifest node rather than a revision.
debug: allow specifying a manifest node rather than a revision
Aug 1 2018, 4:17 PM

Jul 12 2018

mjpieters committed rHG8ac0c9cd4c48: fncache: avoid loading the filename cache when not actually modifying it.
fncache: avoid loading the filename cache when not actually modifying it
Jul 12 2018, 8:34 AM

Nov 24 2017

mjpieters created D1509: sparse: make use of treemanifest for far faster path listing.
Nov 24 2017, 11:35 AM
mjpieters created D1508: sparse: clean up path handling, making it platform agnostic.
Nov 24 2017, 11:35 AM

Nov 10 2017

mjpieters closed D1250: sparse: list available and active profiles.
Nov 10 2017, 2:13 PM
mjpieters committed rFBHGX540cdcbca7d5: sparse: list available and active profiles.
sparse: list available and active profiles
Nov 10 2017, 2:13 PM

Nov 8 2017

mjpieters updated the diff for D1250: sparse: list available and active profiles.
Nov 8 2017, 11:20 AM
mjpieters added inline comments to D1250: sparse: list available and active profiles.
Nov 8 2017, 11:17 AM

Nov 7 2017

mjpieters updated the diff for D1250: sparse: list available and active profiles.
Nov 7 2017, 12:13 PM
mjpieters added a comment to D1250: sparse: list available and active profiles.

Agreed on all points. The following update makes these changes, and in addition:

Nov 7 2017, 12:12 PM

Nov 2 2017

mjpieters accepted D1284: tests: fix test-tweakdefaults-update.t test failures.
Nov 2 2017, 10:04 AM

Oct 26 2017

mjpieters created D1250: sparse: list available and active profiles.
Oct 26 2017, 11:20 AM

Oct 25 2017

mjpieters closed D1202: phabricator: if no cert file has been specified, suppress the urllib3 warning.
Oct 25 2017, 8:28 PM
mjpieters closed D1194: phabricator: pass in the cacerts file if configured.
Oct 25 2017, 8:28 PM
mjpieters committed rFBHGX27f60151e579: phabricator: if no cert file has been specified, suppress the urllib3 warning.
phabricator: if no cert file has been specified, suppress the urllib3 warning
Oct 25 2017, 8:28 PM
mjpieters committed rFBHGXd7414f5b8904: phabricator: pass in the cacerts file if configured.
phabricator: pass in the cacerts file if configured
Oct 25 2017, 8:28 PM
mjpieters committed rFBHGXa796333b84ae: phabricator: use the timeout parameter when connecting.
phabricator: use the timeout parameter when connecting
Oct 25 2017, 8:28 PM
mjpieters closed D1193: phabricator: use the timeout parameter when connecting.
Oct 25 2017, 8:28 PM
mjpieters committed rFBHGXda5e151b1aa5: phabricator: handle exceptions better.
phabricator: handle exceptions better
Oct 25 2017, 8:28 PM
mjpieters closed D1192: phabricator: handle exceptions better.
Oct 25 2017, 8:28 PM

Oct 20 2017

mjpieters created D1202: phabricator: if no cert file has been specified, suppress the urllib3 warning.
Oct 20 2017, 12:09 PM

Oct 19 2017

mjpieters requested changes to D1174: fold: use context manager for locks and transaction.
Oct 19 2017, 9:46 AM
mjpieters abandoned D830: tests: re-order tags and bookmarks in tracking test.

This no longer applies.

Oct 19 2017, 9:03 AM
mjpieters created D1194: phabricator: pass in the cacerts file if configured.
Oct 19 2017, 8:56 AM
mjpieters created D1193: phabricator: use the timeout parameter when connecting.
Oct 19 2017, 8:47 AM
mjpieters added a comment to D1192: phabricator: handle exceptions better.

This doesn't fix the actual SSL error that lead to this issue; that'll be a separate fix where we pass in the web.cacerts config option to the client so we can use the configured certificates.

Oct 19 2017, 8:30 AM
mjpieters retitled D1192: phabricator: handle exceptions better from phabritor: handle exceptions better to phabricator: handle exceptions better.
Oct 19 2017, 8:29 AM
mjpieters created D1192: phabricator: handle exceptions better.
Oct 19 2017, 8:26 AM

Oct 18 2017

mjpieters closed D1026: phabricator: use urllib3 to handle conduit HTTP.
Oct 18 2017, 7:54 PM
mjpieters committed rFBHGX9e01e91c5dd8: phabricator: use urllib3 to handle conduit HTTP.
phabricator: use urllib3 to handle conduit HTTP
Oct 18 2017, 7:54 PM
mjpieters updated the diff for D1026: phabricator: use urllib3 to handle conduit HTTP.
Oct 18 2017, 6:31 AM
mjpieters abandoned D1175: phabricator: drop incorrect content type header.

Folded into D1026

Oct 18 2017, 6:25 AM
mjpieters updated the diff for D1026: phabricator: use urllib3 to handle conduit HTTP.
Oct 18 2017, 6:24 AM
mjpieters added a reviewer for D1175: phabricator: drop incorrect content type header: ikostia.
Oct 18 2017, 6:14 AM
mjpieters created D1175: phabricator: drop incorrect content type header.
Oct 18 2017, 6:14 AM

Oct 17 2017

mjpieters added a comment to D1026: phabricator: use urllib3 to handle conduit HTTP.

Also, just applying this patch and building a Windows version does not work: the build is successful, but ssl output shows "Error" in place of a phabricator status.

Oct 17 2017, 12:50 PM
mjpieters updated the diff for D1026: phabricator: use urllib3 to handle conduit HTTP.
Oct 17 2017, 12:49 PM