- User Since
- Aug 15 2017, 6:03 AM (214 w, 4 d)
Sep 15 2017
Updated variable names and the way to get a path to .hg of the current repo
Sep 14 2017
Sep 12 2017
Sep 11 2017
Replaced if else block with switch block for readability
Sep 8 2017
Fixed bugs. Added exception type checking
Updated tests and got rid of a bug. However, been stuck with anothoer for quite a while now.
Sep 7 2017
There is a test failure. I am not sure that fastdatapacks have to be in the uniondatapackstore.
Addressed issues mentioned above and added test cases. One of the tests is
D631 replaces this diff
Moved py-pythondatastore functions to pythondatastore.cpp where they belong.
Addressed memory management of PythonDataStores and memory management of
DeltaChainLink's when passed from python.
This diff does not include unit tests for PythonDataStore's yet.
Sep 6 2017
Sep 5 2017
DeltaChainLink now also stores size of deltabasefilename
Looks good to me then
What are the unit test failures? And the comment on 322.
Added and edited comments
Sep 4 2017
Removed redundant include
Extended CDeltaChain and PyDeltaChain from base DeltaChain. Updated memory management for PythonDataStores.
Pass filename and delta size directly to DeltaChainLink costructor. Refactored the code.
Sep 1 2017
And testing plan is not exhaustive of course.
Aug 31 2017
Aug 30 2017
DeltaChain costructor no longer accepts a pointer to the delta_chain_t. It accepts delta_chain_t by value and makes
a shallow copy. Therefore, it is responsible for memory management of that delta_chain_t.
Updated testing plan
Edited datastore.h file descriptions to match the standard
Rebased onto stable and added necessary includes so that build is successful on macOS
Removed unnecessary import and removed a line
Aug 29 2017
Thank you for the comment. I will test it a little bit more tomorrow to ensure there are no bugs on both a devserver and mac.
Aug 25 2017
Thanks for the comment. I will break this code into two diffs. But I have some questions that I left below.
Added a test case that ensures that when keepkeys are populated from a diff between two manifests, nothing breaks. Also ensures that when keepkeys are populated
from manifest deltas nothing breaks as well.
Aug 24 2017
Removed some redundant code
This is not a working version. Added PythonDataStore to wrap around python stores. At this point pythondatastore.cpp was not added to the makefile.
Changed native pointers to shared pointers, addressed memory management issues
Aug 23 2017
Fixed bugs. Implemented abstraction around delta chains and delta chain links.
This diff is not for review!
Aug 21 2017
Made keyfn function compulsory
Aug 18 2017
Aug 16 2017
Pushed to @
Corrected a spelling mistake
Added a helper function that updates a revset by adding to it date restriction from prefetchdays config.
Thanks for the comment. I will make some changes now.
Aug 15 2017
Added empty line