Page MenuHomePhabricator

ms2316 (Mikhail Smolin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2017, 6:03 AM (214 w, 4 d)

Recent Activity

Sep 15 2017

ms2316 closed D712: remotefilelog: create delay for background prefetches.
Sep 15 2017, 12:31 PM
ms2316 committed rFBHGXa86155e452e4: remotefilelog: create delay for background prefetches.
remotefilelog: create delay for background prefetches
Sep 15 2017, 12:30 PM
ms2316 updated the diff for D712: remotefilelog: create delay for background prefetches.

Updated variable names and the way to get a path to .hg of the current repo

Sep 15 2017, 9:12 AM
ms2316 added inline comments to D712: remotefilelog: create delay for background prefetches.
Sep 15 2017, 9:08 AM

Sep 14 2017

ms2316 created D712: remotefilelog: create delay for background prefetches.
Sep 14 2017, 12:40 PM

Sep 12 2017

ms2316 closed D631: cstore: uniondatapackstore support for python stores by committing rFBHGX2e4f9ab6b9a0: cstore: uniondatapackstore support for python stores.
Sep 12 2017, 11:09 AM
ms2316 closed D681: cstore: py-datapackstore build bug fix by committing rFBHGX3cec84f1cbab: cstore: py-datapackstore build bug fix.
Sep 12 2017, 11:09 AM
ms2316 committed rFBHGX3cec84f1cbab: cstore: py-datapackstore build bug fix.
cstore: py-datapackstore build bug fix
Sep 12 2017, 11:09 AM
ms2316 closed D630: cstore: extend and refactor deltachain class by committing rFBHGX558fcd49a428: cstore: extend and refactor deltachain class.
Sep 12 2017, 11:09 AM
ms2316 committed rFBHGX2e4f9ab6b9a0: cstore: uniondatapackstore support for python stores.
cstore: uniondatapackstore support for python stores
Sep 12 2017, 11:08 AM
ms2316 committed rFBHGX558fcd49a428: cstore: extend and refactor deltachain class.
cstore: extend and refactor deltachain class
Sep 12 2017, 11:08 AM

Sep 11 2017

ms2316 created D681: cstore: py-datapackstore build bug fix.
Sep 11 2017, 2:12 PM
ms2316 updated the diff for D631: cstore: uniondatapackstore support for python stores.

Replaced if else block with switch block for readability

Sep 11 2017, 10:28 AM

Sep 8 2017

ms2316 updated the diff for D631: cstore: uniondatapackstore support for python stores.

Fixed bugs. Added exception type checking

Sep 8 2017, 8:36 PM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 8 2017, 6:59 PM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 8 2017, 6:58 PM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 8 2017, 6:40 PM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 8 2017, 6:34 PM
ms2316 updated the diff for D631: cstore: uniondatapackstore support for python stores.

Updated tests and got rid of a bug. However, been stuck with anothoer for quite a while now.

Sep 8 2017, 6:28 PM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 8 2017, 1:34 PM

Sep 7 2017

ms2316 added a comment to D631: cstore: uniondatapackstore support for python stores.

There is a test failure. I am not sure that fastdatapacks have to be in the uniondatapackstore.

Sep 7 2017, 2:57 PM
ms2316 updated the diff for D631: cstore: uniondatapackstore support for python stores.

Addressed issues mentioned above and added test cases. One of the tests is
failing.

Sep 7 2017, 2:53 PM
ms2316 abandoned D489: RFC cstore: gerenic uniondatapackstore.

D631 replaces this diff

Sep 7 2017, 11:48 AM
ms2316 updated the diff for D631: cstore: uniondatapackstore support for python stores.

Moved py-pythondatastore functions to pythondatastore.cpp where they belong.
Addressed memory management of PythonDataStores and memory management of
DeltaChainLink's when passed from python.
This diff does not include unit tests for PythonDataStore's yet.

Sep 7 2017, 8:40 AM

Sep 6 2017

ms2316 closed D629: cstore: pythonkeyiterator refactor by committing rFBHGX0763bbfdb666: cstore: pythonkeyiterator refactor.
Sep 6 2017, 9:54 PM
ms2316 committed rFBHGX0763bbfdb666: cstore: pythonkeyiterator refactor.
cstore: pythonkeyiterator refactor
Sep 6 2017, 9:54 PM

Sep 5 2017

ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 5 2017, 6:30 PM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 5 2017, 4:41 PM
ms2316 updated the diff for D630: cstore: extend and refactor deltachain class.

DeltaChainLink now also stores size of deltabasefilename

Sep 5 2017, 3:15 PM
ms2316 added a comment to D586: remotefilelog: make pack cleanup more robust.

Looks good to me then

Sep 5 2017, 2:29 PM
ms2316 accepted D586: remotefilelog: make pack cleanup more robust.

What are the unit test failures? And the comment on 322.

Sep 5 2017, 2:15 PM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 5 2017, 1:25 PM
ms2316 added inline comments to D586: remotefilelog: make pack cleanup more robust.
Sep 5 2017, 1:21 PM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 5 2017, 1:20 PM
ms2316 added a comment to D586: remotefilelog: make pack cleanup more robust.
Sep 5 2017, 1:05 PM
ms2316 updated the diff for D630: cstore: extend and refactor deltachain class.

Added and edited comments

Sep 5 2017, 11:26 AM
ms2316 abandoned D606: cstore: uniondatapackstore support for python stores.

D629 D630 D631 replace this diff

Sep 5 2017, 10:54 AM
ms2316 added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 5 2017, 10:51 AM
ms2316 created D631: cstore: uniondatapackstore support for python stores.
Sep 5 2017, 10:49 AM
ms2316 created D630: cstore: extend and refactor deltachain class.
Sep 5 2017, 10:41 AM
ms2316 created D629: cstore: pythonkeyiterator refactor.
Sep 5 2017, 10:30 AM
ms2316 added inline comments to D606: cstore: uniondatapackstore support for python stores.
Sep 5 2017, 9:54 AM

Sep 4 2017

ms2316 added inline comments to D606: cstore: uniondatapackstore support for python stores.
Sep 4 2017, 1:35 PM
ms2316 updated the diff for D606: cstore: uniondatapackstore support for python stores.

Removed redundant include

Sep 4 2017, 12:34 PM
ms2316 updated the diff for D606: cstore: uniondatapackstore support for python stores.

Extended CDeltaChain and PyDeltaChain from base DeltaChain. Updated memory management for PythonDataStores.
Pass filename and delta size directly to DeltaChainLink costructor. Refactored the code.

Sep 4 2017, 12:27 PM

Sep 1 2017

ms2316 added a comment to D606: cstore: uniondatapackstore support for python stores.

And testing plan is not exhaustive of course.

Sep 1 2017, 4:12 PM
ms2316 created D606: cstore: uniondatapackstore support for python stores.
Sep 1 2017, 3:59 PM

Aug 31 2017

ms2316 closed D560: cstore: generic uniondatapackstore by committing rFBHGX8cacf9669a0a: cstore: generic uniondatapackstore.
Aug 31 2017, 2:32 PM
ms2316 committed rFBHGX8cacf9669a0a: cstore: generic uniondatapackstore.
cstore: generic uniondatapackstore
Aug 31 2017, 2:30 PM

Aug 30 2017

ms2316 updated the diff for D560: cstore: generic uniondatapackstore.

DeltaChain costructor no longer accepts a pointer to the delta_chain_t. It accepts delta_chain_t by value and makes
a shallow copy. Therefore, it is responsible for memory management of that delta_chain_t.

Aug 30 2017, 2:26 PM
ms2316 updated the diff for D560: cstore: generic uniondatapackstore.

Updated testing plan

Aug 30 2017, 10:59 AM
ms2316 updated the diff for D560: cstore: generic uniondatapackstore.

Edited datastore.h file descriptions to match the standard

Aug 30 2017, 10:56 AM
ms2316 updated the diff for D560: cstore: generic uniondatapackstore.

Rebased onto stable and added necessary includes so that build is successful on macOS

Aug 30 2017, 10:37 AM
ms2316 updated the diff for D560: cstore: generic uniondatapackstore.

Removed unnecessary import and removed a line

Aug 30 2017, 7:08 AM

Aug 29 2017

ms2316 added a comment to D560: cstore: generic uniondatapackstore.

Thank you for the comment. I will test it a little bit more tomorrow to ensure there are no bugs on both a devserver and mac.

Aug 29 2017, 8:53 PM
ms2316 closed D519: remotefilelog: keepset tuple bug fix by committing rFBHGX72fc021bb146: remotefilelog: keepset tuple bug fix.
Aug 29 2017, 12:01 PM
ms2316 committed rFBHGX72fc021bb146: remotefilelog: keepset tuple bug fix.
remotefilelog: keepset tuple bug fix
Aug 29 2017, 12:00 PM
ms2316 created D560: cstore: generic uniondatapackstore.
Aug 29 2017, 9:52 AM

Aug 25 2017

ms2316 added a comment to D489: RFC cstore: gerenic uniondatapackstore.

Thanks for the comment. I will break this code into two diffs. But I have some questions that I left below.

Aug 25 2017, 3:12 PM
ms2316 updated the diff for D519: remotefilelog: keepset tuple bug fix.

Added a test case that ensures that when keepkeys are populated from a diff between two manifests, nothing breaks. Also ensures that when keepkeys are populated
from manifest deltas nothing breaks as well.

Aug 25 2017, 12:45 PM
ms2316 created D519: remotefilelog: keepset tuple bug fix.
Aug 25 2017, 11:02 AM

Aug 24 2017

ms2316 updated the diff for D489: RFC cstore: gerenic uniondatapackstore.

Removed some redundant code

Aug 24 2017, 5:51 PM
ms2316 updated the diff for D489: RFC cstore: gerenic uniondatapackstore.

This is not a working version. Added PythonDataStore to wrap around python stores. At this point pythondatastore.cpp was not added to the makefile.

Aug 24 2017, 5:43 PM
ms2316 updated the diff for D489: RFC cstore: gerenic uniondatapackstore.

Changed native pointers to shared pointers, addressed memory management issues

Aug 24 2017, 9:32 AM

Aug 23 2017

ms2316 added inline comments to D489: RFC cstore: gerenic uniondatapackstore.
Aug 23 2017, 5:35 PM
ms2316 updated the diff for D489: RFC cstore: gerenic uniondatapackstore.

Fixed bugs. Implemented abstraction around delta chains and delta chain links.

Aug 23 2017, 10:39 AM
ms2316 added a comment to D489: RFC cstore: gerenic uniondatapackstore.

This diff is not for review!

Aug 23 2017, 9:19 AM
ms2316 created D489: RFC cstore: gerenic uniondatapackstore.
Aug 23 2017, 9:19 AM

Aug 21 2017

ms2316 closed D442: remotefilelog: efficient keepset computation by committing rFBHGX6dd1f0c039cb: remotefilelog: efficient keepset computation.
Aug 21 2017, 8:18 PM
ms2316 committed rFBHGX6dd1f0c039cb: remotefilelog: efficient keepset computation.
remotefilelog: efficient keepset computation
Aug 21 2017, 8:17 PM
ms2316 updated the diff for D442: remotefilelog: efficient keepset computation.

Made keyfn function compulsory

Aug 21 2017, 12:07 PM

Aug 18 2017

ms2316 added inline comments to D442: remotefilelog: efficient keepset computation.
Aug 18 2017, 7:03 AM
ms2316 created D442: remotefilelog: efficient keepset computation.
Aug 18 2017, 6:53 AM

Aug 16 2017

ms2316 closed D420: remotefilelog: limit number of changesets to be prefetched by committing rFBHGX8e71109eeda8: remotefilelog: limit number of changesets to be prefetched.
Aug 16 2017, 4:42 PM
ms2316 committed rFBHGX8e71109eeda8: remotefilelog: limit number of changesets to be prefetched.
remotefilelog: limit number of changesets to be prefetched
Aug 16 2017, 4:41 PM
ms2316 closed D417: remotefilelog: flaky bgprefetch test fix by committing rFBHGX5ca093c4ddcf: remotefilelog: flaky bgprefetch test fix.
Aug 16 2017, 4:41 PM
ms2316 committed rFBHGX5ca093c4ddcf: remotefilelog: flaky bgprefetch test fix.
remotefilelog: flaky bgprefetch test fix
Aug 16 2017, 4:41 PM
ms2316 added a comment to D420: remotefilelog: limit number of changesets to be prefetched.

Pushed to @

Aug 16 2017, 4:23 PM
ms2316 updated the diff for D420: remotefilelog: limit number of changesets to be prefetched.

Corrected a spelling mistake

Aug 16 2017, 4:21 PM
ms2316 updated the diff for D420: remotefilelog: limit number of changesets to be prefetched.

Added a helper function that updates a revset by adding to it date restriction from prefetchdays config.

Aug 16 2017, 4:07 PM
ms2316 added a comment to D420: remotefilelog: limit number of changesets to be prefetched.

Thanks for the comment. I will make some changes now.

Aug 16 2017, 2:22 PM
ms2316 created D420: remotefilelog: limit number of changesets to be prefetched.
Aug 16 2017, 1:56 PM
ms2316 created D417: remotefilelog: flaky bgprefetch test fix.
Aug 16 2017, 12:08 PM
ms2316 closed D407: remotefilelog: fix flaky bgprefetch test by committing rFBHGXab8836fee021: remotefilelog: fix flaky bgprefetch test.
Aug 16 2017, 11:18 AM
ms2316 closed D408: remotefilelog: gc option for repacker class by committing rFBHGX2d9aa19287c9: remotefilelog: gc option for repacker class.
Aug 16 2017, 11:18 AM
ms2316 committed rFBHGX2d9aa19287c9: remotefilelog: gc option for repacker class.
remotefilelog: gc option for repacker class
Aug 16 2017, 11:17 AM
ms2316 committed rFBHGXab8836fee021: remotefilelog: fix flaky bgprefetch test.
remotefilelog: fix flaky bgprefetch test
Aug 16 2017, 11:17 AM

Aug 15 2017

ms2316 updated the diff for D408: remotefilelog: gc option for repacker class.

Updated summary

Aug 15 2017, 7:30 AM
ms2316 created D408: remotefilelog: gc option for repacker class.
Aug 15 2017, 7:02 AM
ms2316 updated the diff for D407: remotefilelog: fix flaky bgprefetch test.

Added empty line

Aug 15 2017, 6:11 AM
ms2316 created D407: remotefilelog: fix flaky bgprefetch test.
Aug 15 2017, 6:05 AM