Page MenuHomePhabricator

msuozzo (Matthew Suozzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 18 2020, 2:26 PM (11 w, 8 h)

Recent Activity

Oct 22 2020

msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

Okay the implementation itself looks better to me.

Oct 22 2020, 5:27 PM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Oct 22 2020, 5:21 PM

Oct 19 2020

msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

I'm definitely sympathetic to your position.

Oct 19 2020, 10:21 PM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Oct 19 2020, 10:07 PM

Sep 29 2020

msuozzo added inline comments to D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 29 2020, 6:45 PM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 29 2020, 6:43 PM

Sep 22 2020

msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

Alright so as discussed, this is now a per-fixer config option which I called "adjacentblanks" (not married to it). There's also the new issue of having to plumb the flag down through the necessary layers of abstraction. I figured doing so with a fixer instance would be the least complex way but I'm not sure how idiomatic that is in hg's codebase.

Sep 22 2020, 11:51 PM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 22 2020, 11:48 PM

Sep 18 2020

msuozzo created D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 18 2020, 3:31 PM