Page MenuHomePhabricator

msuozzo (Matthew Suozzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 18 2020, 2:26 PM (33 w, 1 d)

Recent Activity

Jan 26 2021

msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

What's the next step here? Is there still disagreement on the value of the feature or does there need to be additional review(s)?

Jan 26 2021, 5:35 PM

Jan 13 2021

msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

The patch looks fine now.

Jan 13 2021, 4:21 PM

Jan 11 2021

msuozzo committed rHG36c05ab02232: beautifygraph: change the current commit symbol.
beautifygraph: change the current commit symbol
Jan 11 2021, 2:12 PM
msuozzo closed D9678: beautifygraph: change the current commit symbol.
Jan 11 2021, 12:37 PM
msuozzo committed rHGc0b9ea5d8552: beautifygraph: change the current commit symbol.
beautifygraph: change the current commit symbol
Jan 11 2021, 12:37 PM
msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

Bump

Jan 11 2021, 11:47 AM

Jan 2 2021

msuozzo created D9678: beautifygraph: change the current commit symbol.
Jan 2 2021, 1:56 AM
msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

Expanded the doctests a bit and factored out some of the index arithmetic.

Jan 2 2021, 1:15 AM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Jan 2 2021, 1:14 AM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Jan 2 2021, 1:09 AM

Oct 22 2020

msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

Okay the implementation itself looks better to me.

Oct 22 2020, 5:27 PM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Oct 22 2020, 5:21 PM

Oct 19 2020

msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

I'm definitely sympathetic to your position.

Oct 19 2020, 10:21 PM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Oct 19 2020, 10:07 PM

Sep 29 2020

msuozzo added inline comments to D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 29 2020, 6:45 PM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 29 2020, 6:43 PM

Sep 22 2020

msuozzo added a comment to D9056: fix: include adjacent blank lines in ranges to be fixed.

Alright so as discussed, this is now a per-fixer config option which I called "adjacentblanks" (not married to it). There's also the new issue of having to plumb the flag down through the necessary layers of abstraction. I figured doing so with a fixer instance would be the least complex way but I'm not sure how idiomatic that is in hg's codebase.

Sep 22 2020, 11:51 PM
msuozzo updated the diff for D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 22 2020, 11:48 PM

Sep 18 2020

msuozzo created D9056: fix: include adjacent blank lines in ranges to be fixed.
Sep 18 2020, 3:31 PM