Page MenuHomePhabricator

navaneeth.suresh (Navaneeth Suresh)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2018, 6:12 AM (49 w, 3 d)

Recent Activity

Sun, Aug 25

navaneeth.suresh closed D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Sun, Aug 25, 12:26 PM
navaneeth.suresh closed D6740: tests: add test to demonstrate issue6159.
Sun, Aug 25, 12:26 PM
navaneeth.suresh committed rHG3332bde53714: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)
Sun, Aug 25, 12:26 PM
navaneeth.suresh committed rHGcf9dbc7377de: tests: add test to demonstrate issue6159.
tests: add test to demonstrate issue6159
Sun, Aug 25, 12:26 PM

Sat, Aug 24

navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

@av6 I have updated the tests. @marmoute can we just get rid of (EXPERIMENTAL) in the output? If we want to do that, changes have to be made in ui.walkregisteredconfig(). But, that's a hack which appends to either name or value and as @av6 mentioned, the user will see it on using with -T which they might not wanted.

Sat, Aug 24, 3:37 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Sat, Aug 24, 3:36 AM

Fri, Aug 23

navaneeth.suresh added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
In D6731#99192, @pulkit wrote:

Looks like you forgot to update tests.

Fri, Aug 23, 10:23 PM
navaneeth.suresh updated the diff for D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Fri, Aug 23, 10:22 PM
navaneeth.suresh added a comment to D6740: tests: add test to demonstrate issue6159.

I'm able to reproduce the tests now. The case b2-binary can reproduce the test results.

Fri, Aug 23, 3:06 PM
navaneeth.suresh updated the diff for D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Fri, Aug 23, 3:05 PM
navaneeth.suresh updated the diff for D6740: tests: add test to demonstrate issue6159.
Fri, Aug 23, 3:04 PM
navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.
In D6709#99166, @av6 wrote:

@marmoute did you want this flag marked as experimental or am I misremembering?

Fri, Aug 23, 3:01 PM

Aug 22 2019

navaneeth.suresh added inline comments to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 22 2019, 8:26 AM
navaneeth.suresh updated the diff for D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 22 2019, 8:25 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 22 2019, 8:17 AM

Aug 20 2019

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 20 2019, 12:34 PM
navaneeth.suresh abandoned D6746: perf: don't pass experimental argument in config for older Mercurial versions.
Aug 20 2019, 12:04 PM
navaneeth.suresh committed rHG5c285c8e4f98: unshelve: abort on using --keep and --interactive together.
unshelve: abort on using --keep and --interactive together
Aug 20 2019, 12:00 PM
navaneeth.suresh committed rHG9f2189b6bf2a: config: add experimental argument to the config registrar.
config: add experimental argument to the config registrar
Aug 20 2019, 12:00 PM
navaneeth.suresh updated the diff for D6746: perf: don't pass experimental argument in config for older Mercurial versions.
Aug 20 2019, 11:19 AM
navaneeth.suresh created D6746: perf: don't pass experimental argument in config for older Mercurial versions.
Aug 20 2019, 10:30 AM
navaneeth.suresh added inline comments to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 20 2019, 9:57 AM
navaneeth.suresh added inline comments to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 20 2019, 9:30 AM
navaneeth.suresh added inline comments to D6736: shelve: add method for storing mergestate in changeset extras.
Aug 20 2019, 9:23 AM
navaneeth.suresh added inline comments to D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files.
Aug 20 2019, 9:20 AM
navaneeth.suresh added inline comments to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 20 2019, 8:27 AM
navaneeth.suresh updated the diff for D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 20 2019, 8:24 AM
navaneeth.suresh added a comment to D6740: tests: add test to demonstrate issue6159.

@pulkit Now I'm unable to reproduce the test result given in the bug report. It seems like the remote repo recognizes the secret changeset cf489fd8a374.

Aug 20 2019, 8:23 AM
navaneeth.suresh updated the diff for D6740: tests: add test to demonstrate issue6159.
Aug 20 2019, 7:53 AM

Aug 18 2019

navaneeth.suresh added inline comments to D6728: config: add experimental argument to the config registrar.
Aug 18 2019, 7:56 AM

Aug 17 2019

navaneeth.suresh added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
In D6731#98871, @pulkit wrote:

In such cases, I like the idea of having fix as two patches, first which demonstrates the bug and the second which fixes the bug. What do you think?

Aug 17 2019, 5:30 PM
navaneeth.suresh updated the diff for D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 17 2019, 5:29 PM
navaneeth.suresh created D6740: tests: add test to demonstrate issue6159.
Aug 17 2019, 5:28 PM
navaneeth.suresh created D6739: unshelve: add abort on using --interactive and --unresolved together.
Aug 17 2019, 4:41 PM
navaneeth.suresh created D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files.
Aug 17 2019, 4:40 PM
navaneeth.suresh created D6737: shelve: add --unresolved flag to shelve mergestate with unresolved files.
Aug 17 2019, 4:39 PM
navaneeth.suresh created D6736: shelve: add method for storing mergestate in changeset extras.
Aug 17 2019, 4:38 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 17 2019, 11:10 AM
navaneeth.suresh added a comment to D6730: config: handle default values of type list.
In D6730#98852, @av6 wrote:

The changes in tests that this patch causes are actually already present in the D6709, so let's fold this patch into it as well.

Aug 17 2019, 10:56 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 17 2019, 10:55 AM
navaneeth.suresh committed rHG7b33ff9c5565: unshelve: abort on using --keep and --interactive together.
unshelve: abort on using --keep and --interactive together
Aug 17 2019, 2:50 AM
navaneeth.suresh committed rHGa11fd395e83f: config: add experimental argument to the config registrar.
config: add experimental argument to the config registrar
Aug 17 2019, 2:50 AM

Aug 16 2019

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 16 2019, 5:23 PM
navaneeth.suresh created D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 16 2019, 4:26 PM
navaneeth.suresh closed D6699: unshelve: abort on using --keep and --interactive together.
Aug 16 2019, 6:56 AM
navaneeth.suresh committed rHG4b0c9d47f714: unshelve: abort on using --keep and --interactive together.
unshelve: abort on using --keep and --interactive together
Aug 16 2019, 6:55 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 16 2019, 5:13 AM
navaneeth.suresh updated the diff for D6730: config: handle default values of type list.
Aug 16 2019, 5:08 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 16 2019, 5:08 AM
navaneeth.suresh created D6730: config: handle default values of type list.
Aug 16 2019, 5:03 AM

Aug 15 2019

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 15 2019, 3:44 PM
navaneeth.suresh added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

The only thing I'm curious about really is why we have extrastorage and usualstorge. Can we get away with only one of those choices instead of having more options?

Aug 15 2019, 11:37 AM
navaneeth.suresh closed D6728: config: add experimental argument to the config registrar.
Aug 15 2019, 11:25 AM
navaneeth.suresh committed rHGe67d9b6bad4d: config: add experimental argument to the config registrar.
config: add experimental argument to the config registrar
Aug 15 2019, 11:24 AM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Aug 15 2019, 11:16 AM
navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

I get 28 of them.
I think we need to add an experimental or status argument ot the config registration.

Aug 15 2019, 10:32 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 15 2019, 10:31 AM
navaneeth.suresh created D6728: config: add experimental argument to the config registrar.
Aug 15 2019, 10:22 AM

Aug 13 2019

navaneeth.suresh closed D6724: unshelve: forget unknown files after a partial unshelve.
Aug 13 2019, 4:49 PM
navaneeth.suresh committed rHGd684449eef67: unshelve: forget unknown files after a partial unshelve.
unshelve: forget unknown files after a partial unshelve
Aug 13 2019, 4:49 PM
navaneeth.suresh created D6724: unshelve: forget unknown files after a partial unshelve.
Aug 13 2019, 1:21 PM

Aug 11 2019

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 11 2019, 3:46 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 11 2019, 2:13 PM
navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

Should we hide devel.* like we do experimental when verbose isn’t applied? Presumably we don’t want regular users to know about them.

Aug 11 2019, 2:13 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 11 2019, 9:28 AM
navaneeth.suresh added inline comments to D6709: config: add --registered flag to show all known configs.
Aug 11 2019, 9:06 AM

Aug 10 2019

navaneeth.suresh updated subscribers of D6709: config: add --registered flag to show all known configs.
Aug 10 2019, 3:02 PM

Aug 9 2019

navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 9 2019, 3:10 PM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Aug 9 2019, 3:09 PM
navaneeth.suresh retitled D6699: unshelve: abort on using --keep and --interactive together from tests: add test for unshelve --interactive --keep to unshelve: abort on using --keep and --interactive together.
Aug 9 2019, 2:42 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 9 2019, 1:01 AM
navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

@pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for the following
items in configitems.py. IIUC, it should be visible when we are trying to read a config item which is
not in the registered items. But, we are iterating over registered items only.

There are "generic" config option. So it does not hold the option "name", but a regexp to match valid entry.

Aug 9 2019, 12:54 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 9 2019, 12:53 AM

Aug 8 2019

navaneeth.suresh added a comment to D6709: config: add --registered flag to show all known configs.

@pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for the following
items in configitems.py. IIUC, it should be visible when we are trying to read a config item which is
not in the registered items. But, we are iterating over registered items only.

Aug 8 2019, 12:08 PM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 8 2019, 11:55 AM
navaneeth.suresh updated the diff for D6709: config: add --registered flag to show all known configs.
Aug 8 2019, 11:52 AM

Aug 7 2019

navaneeth.suresh closed D6712: config: remove pycompat.bytestr() for defaultvalue.
Aug 7 2019, 5:32 PM
navaneeth.suresh closed D6720: config: fix fm.data() handling of defaultvalue.
Aug 7 2019, 5:32 PM
navaneeth.suresh committed rHG60789444acd6: config: fix fm.data() handling of defaultvalue.
config: fix fm.data() handling of defaultvalue
Aug 7 2019, 5:31 PM
navaneeth.suresh committed rHG049b2ac3252e: config: remove pycompat.bytestr() for defaultvalue.
config: remove pycompat.bytestr() for defaultvalue
Aug 7 2019, 5:31 PM
navaneeth.suresh added a comment to D6712: config: remove pycompat.bytestr() for defaultvalue.
In D6712#98424, @pulkit wrote:

The pycompat.bytestr() was there for py3 compatibility, however removing it should be fine in this case. Can you make sure test-config.t passes with this patch on Python 3?

Aug 7 2019, 11:20 AM
navaneeth.suresh updated the diff for D6720: config: fix fm.data() handling of defaultvalue.
Aug 7 2019, 11:18 AM
navaneeth.suresh added inline comments to D6720: config: fix fm.data() handling of defaultvalue.
Aug 7 2019, 10:41 AM
navaneeth.suresh retitled D6720: config: fix fm.data() handling of defaultvalue from config: fix defaultvalue template keyword (patch 2 of 2) to config: fix fm.data() handling of defaultvalue.
Aug 7 2019, 10:39 AM
navaneeth.suresh retitled D6712: config: remove pycompat.bytestr() for defaultvalue from config: fix defaultvalue template keyword (patch 1 of 2) to config: remove pycompat.bytestr() for defaultvalue.
Aug 7 2019, 10:32 AM
navaneeth.suresh created D6720: config: fix fm.data() handling of defaultvalue.
Aug 7 2019, 9:51 AM
navaneeth.suresh updated the summary of D6712: config: remove pycompat.bytestr() for defaultvalue.
Aug 7 2019, 9:45 AM

Aug 6 2019

navaneeth.suresh closed D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Aug 6 2019, 1:22 PM
navaneeth.suresh committed rHG6957f7b93e03: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
unshelve: clear shelvedstate and _finishunshelve() on partial unshelve
Aug 6 2019, 1:22 PM
navaneeth.suresh updated the diff for D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Aug 6 2019, 1:10 PM
navaneeth.suresh updated the diff for D6699: unshelve: abort on using --keep and --interactive together.
Aug 6 2019, 1:07 PM
navaneeth.suresh updated the diff for D6712: config: remove pycompat.bytestr() for defaultvalue.
Aug 6 2019, 1:04 PM
navaneeth.suresh closed D6694: unshelve: delete shelvedstate after a successful unshelve --continue.
Aug 6 2019, 12:43 PM
navaneeth.suresh committed rHG073cfff9aaef: unshelve: delete shelvedstate after a successful unshelve --continue.
unshelve: delete shelvedstate after a successful unshelve --continue
Aug 6 2019, 12:43 PM
navaneeth.suresh updated the diff for D6694: unshelve: delete shelvedstate after a successful unshelve --continue.
Aug 6 2019, 12:06 PM
navaneeth.suresh added inline comments to D6694: unshelve: delete shelvedstate after a successful unshelve --continue.
Aug 6 2019, 12:04 PM
navaneeth.suresh added inline comments to D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Aug 6 2019, 12:00 PM
navaneeth.suresh updated the diff for D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve.
Aug 6 2019, 12:00 PM
navaneeth.suresh closed D6686: unshelve: handle stripping changesets on interactive mode.
Aug 6 2019, 11:48 AM
navaneeth.suresh committed rHG4814d993fe21: unshelve: handle stripping changesets on interactive mode.
unshelve: handle stripping changesets on interactive mode
Aug 6 2019, 11:48 AM