Page MenuHomePhabricator

navaneeth.suresh (Navaneeth Suresh)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2018, 6:12 AM (40 w, 2 d)

Recent Activity

Yesterday

navaneeth.suresh closed D6654: shelve: modify help text on --interactive.
Thu, Jul 18, 2:01 PM
navaneeth.suresh closed D6653: unshelve: mark unshelve interactive as experimental.
Thu, Jul 18, 2:00 PM
navaneeth.suresh committed rHG9eace8d6d537: shelve: modify help text on --interactive.
shelve: modify help text on --interactive
Thu, Jul 18, 1:59 PM
navaneeth.suresh committed rHG74ba82abbf29: unshelve: mark unshelve interactive as experimental.
unshelve: mark unshelve interactive as experimental
Thu, Jul 18, 1:59 PM
navaneeth.suresh created D6654: shelve: modify help text on --interactive.
Thu, Jul 18, 11:45 AM
navaneeth.suresh updated the summary of D6653: unshelve: mark unshelve interactive as experimental.
Thu, Jul 18, 11:35 AM
navaneeth.suresh created D6653: unshelve: mark unshelve interactive as experimental.
Thu, Jul 18, 11:28 AM
navaneeth.suresh added inline comments to D6596: unshelve: add interactive mode.
Thu, Jul 18, 11:22 AM
navaneeth.suresh committed rHG5162753c4c14: unshelve: add interactive mode.
unshelve: add interactive mode
Thu, Jul 18, 9:39 AM

Wed, Jul 17

navaneeth.suresh closed D6596: unshelve: add interactive mode.
Wed, Jul 17, 7:07 PM
navaneeth.suresh committed rHG62953fd58404: unshelve: add interactive mode.
unshelve: add interactive mode
Wed, Jul 17, 7:06 PM

Tue, Jul 16

navaneeth.suresh updated the diff for D6596: unshelve: add interactive mode.
Tue, Jul 16, 2:11 PM

Mon, Jul 15

navaneeth.suresh updated the diff for D6596: unshelve: add interactive mode.
Mon, Jul 15, 10:06 AM
navaneeth.suresh updated the diff for D6596: unshelve: add interactive mode.
Mon, Jul 15, 9:49 AM

Fri, Jul 12

navaneeth.suresh updated the diff for D6596: unshelve: add interactive mode.
Fri, Jul 12, 3:53 AM
navaneeth.suresh updated the summary of D6596: unshelve: add interactive mode.
Fri, Jul 12, 3:47 AM

Thu, Jul 11

navaneeth.suresh retitled D6596: unshelve: add interactive mode from unshelve: make unshelve accept files (issue6162) to unshelve: add interactive mode.
Thu, Jul 11, 2:56 PM
navaneeth.suresh updated the summary of D6596: unshelve: add interactive mode.
Thu, Jul 11, 9:33 AM
navaneeth.suresh added inline comments to D6596: unshelve: add interactive mode.
Thu, Jul 11, 9:24 AM
navaneeth.suresh updated the diff for D6596: unshelve: add interactive mode.
Thu, Jul 11, 9:06 AM

Sun, Jul 7

navaneeth.suresh closed D6605: unshelve: rename _dounshelve() to dounshelve().
Sun, Jul 7, 9:15 AM
navaneeth.suresh committed rHG70f1a84d0794: unshelve: rename _dounshelve() to dounshelve().
unshelve: rename _dounshelve() to dounshelve()
Sun, Jul 7, 9:14 AM

Thu, Jul 4

navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Thu, Jul 4, 3:26 PM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Thu, Jul 4, 3:22 PM
navaneeth.suresh created D6605: unshelve: rename _dounshelve() to dounshelve().
Thu, Jul 4, 1:48 PM
navaneeth.suresh added inline comments to D6553: shelve: move shelve extension to core.
Thu, Jul 4, 11:07 AM
navaneeth.suresh added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.
In D6479#96318, @pulkit wrote:

Since you did the nice work of moving shelve to core, how about rebasing this patch on tip of default with shelve in core?

Thu, Jul 4, 11:04 AM
navaneeth.suresh retitled D6596: unshelve: add interactive mode from unshelve: add interactive mode (issue6162) to unshelve: make unshelve accept files (issue6162).
Thu, Jul 4, 11:01 AM
navaneeth.suresh added inline comments to D6596: unshelve: add interactive mode.
Thu, Jul 4, 11:00 AM
navaneeth.suresh updated the diff for D6596: unshelve: add interactive mode.
Thu, Jul 4, 10:54 AM
navaneeth.suresh created D6596: unshelve: add interactive mode.
Thu, Jul 4, 10:54 AM
navaneeth.suresh updated the diff for D6596: unshelve: add interactive mode.
Thu, Jul 4, 10:53 AM
navaneeth.suresh added inline comments to D6596: unshelve: add interactive mode.
Thu, Jul 4, 10:53 AM

Sun, Jun 30

navaneeth.suresh closed D6589: extensions: add shelve to _builtin.
Sun, Jun 30, 6:57 AM
navaneeth.suresh committed rHG6a3872e34503: extensions: add shelve to _builtin.
extensions: add shelve to _builtin
Sun, Jun 30, 6:57 AM
navaneeth.suresh created D6589: extensions: add shelve to _builtin.
Sun, Jun 30, 3:43 AM
navaneeth.suresh added a comment to D6553: shelve: move shelve extension to core.
In D6553#96119, @yuja wrote:

Need to update extensions._builtin so the shelve "extension" is silently
ignored.
Please send a follow up.

Sun, Jun 30, 3:39 AM
navaneeth.suresh committed rHG3de4f17f4824: shelve: move shelve extension to core.
shelve: move shelve extension to core
Sun, Jun 30, 12:14 AM
navaneeth.suresh committed rHG80e0ea08b55c: shelve: remove rebase.clearstatus().
shelve: remove rebase.clearstatus()
Sun, Jun 30, 12:14 AM

Sat, Jun 29

navaneeth.suresh closed D6553: shelve: move shelve extension to core.
Sat, Jun 29, 7:07 PM
navaneeth.suresh committed rHG46087aeb8ae2: shelve: move shelve extension to core.
shelve: move shelve extension to core
Sat, Jun 29, 7:03 PM

Fri, Jun 28

navaneeth.suresh closed D6584: shelve: remove rebase.clearstatus().
Fri, Jun 28, 4:05 PM
navaneeth.suresh committed rHGead3a723bcef: shelve: remove rebase.clearstatus().
shelve: remove rebase.clearstatus()
Fri, Jun 28, 4:05 PM
navaneeth.suresh updated the diff for D6553: shelve: move shelve extension to core.
Fri, Jun 28, 2:20 PM
navaneeth.suresh added a comment to D6553: shelve: move shelve extension to core.

@pulkit Changes have been made.

Fri, Jun 28, 2:18 PM
navaneeth.suresh updated the summary of D6553: shelve: move shelve extension to core.
Fri, Jun 28, 2:15 PM
navaneeth.suresh updated the diff for D6584: shelve: remove rebase.clearstatus().
Fri, Jun 28, 2:01 PM
navaneeth.suresh created D6584: shelve: remove rebase.clearstatus().
Fri, Jun 28, 1:37 PM
navaneeth.suresh added inline comments to D6553: shelve: move shelve extension to core.
Fri, Jun 28, 1:25 PM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Fri, Jun 28, 8:16 AM
navaneeth.suresh added inline comments to D6553: shelve: move shelve extension to core.
Fri, Jun 28, 4:05 AM
navaneeth.suresh updated the diff for D6553: shelve: move shelve extension to core.
Fri, Jun 28, 4:04 AM

Sun, Jun 23

navaneeth.suresh updated the diff for D6553: shelve: move shelve extension to core.
Sun, Jun 23, 7:33 AM
navaneeth.suresh added a comment to D6553: shelve: move shelve extension to core.

@Kwan Thanks for the review. I have updated the patch as you suggested.

Sun, Jun 23, 7:32 AM

Thu, Jun 20

navaneeth.suresh updated the diff for D6553: shelve: move shelve extension to core.
Thu, Jun 20, 3:09 PM
navaneeth.suresh created D6553: shelve: move shelve extension to core.
Thu, Jun 20, 2:03 PM

Jun 19 2019

navaneeth.suresh added a comment to D6528: tests: fix internals.mergestate entry.

Abandoning since changes are reflected by the commit 9d31581cc44e.

Jun 19 2019, 12:57 PM

Jun 16 2019

navaneeth.suresh added inline comments to D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 16 2019, 11:15 AM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 16 2019, 11:13 AM

Jun 14 2019

navaneeth.suresh added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

Now, we have mergestate information storage in changeset level too with the help of extra mapping.

Jun 14 2019, 4:19 PM
navaneeth.suresh updated the summary of D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 14 2019, 3:57 PM

Jun 13 2019

navaneeth.suresh updated subscribers of rHG9d31581cc44e: help: add help entry for internals.mergestate.
help: add help entry for internals.mergestate
Jun 13 2019, 4:39 PM
navaneeth.suresh updated the summary of D6528: tests: fix internals.mergestate entry.
Jun 13 2019, 1:39 PM
navaneeth.suresh added a comment to D6448: help: add help entry for internals.mergestate.

This needs some fixups to keep test-help.t and the Windows installer happy:
https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/1468/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio
See 876f08f30ade for an example of how to fix the installer.

Jun 13 2019, 1:23 PM
navaneeth.suresh created D6528: tests: fix internals.mergestate entry.
Jun 13 2019, 1:22 PM

Jun 12 2019

navaneeth.suresh closed D6448: help: add help entry for internals.mergestate.
Jun 12 2019, 12:58 PM
navaneeth.suresh updated subscribers of rHG2ae1e2ad4969: help: add help entry for internals.mergestate.
help: add help entry for internals.mergestate
Jun 12 2019, 12:58 PM

Jun 11 2019

navaneeth.suresh abandoned D6478: shelve: first prototype of storing unresolved changes.
Jun 11 2019, 3:50 PM
navaneeth.suresh added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.
In D6479#94711, @pulkit wrote:

Can you fold both the commits, it will be better to see code for both storing and restoring mergestates in one patch.

Jun 11 2019, 3:49 PM
navaneeth.suresh added a comment to D6478: shelve: first prototype of storing unresolved changes.

Adding changes to D6479 and abandoning.

Jun 11 2019, 3:49 PM
navaneeth.suresh retitled D6479: shelve: first prototype of storing/restoring unresolved changes from unshelve: first prototype of restoring unresolved changes to shelve: first prototype of storing/restoring unresolved changes.
Jun 11 2019, 3:45 PM
navaneeth.suresh updated the diff for D6478: shelve: first prototype of storing unresolved changes.
Jun 11 2019, 3:30 PM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 11 2019, 3:21 PM
navaneeth.suresh added inline comments to D6478: shelve: first prototype of storing unresolved changes.
Jun 11 2019, 2:29 PM
navaneeth.suresh updated the diff for D6478: shelve: first prototype of storing unresolved changes.
Jun 11 2019, 8:09 AM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 11 2019, 7:30 AM

Jun 10 2019

navaneeth.suresh added inline comments to D6478: shelve: first prototype of storing unresolved changes.
Jun 10 2019, 3:50 PM
navaneeth.suresh updated the diff for D6478: shelve: first prototype of storing unresolved changes.
Jun 10 2019, 3:41 PM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 10 2019, 2:42 PM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 10 2019, 1:11 PM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 10 2019, 12:51 PM
navaneeth.suresh updated the diff for D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 10 2019, 12:30 PM
navaneeth.suresh added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.
In D6479#94556, @pulkit wrote:

Can we prevent merging again? Since we are getting content from old unresolved commit, copying mergestate from previously stored one, what purpose does this merging serves?

The usual unshelve mechanism restores the content of the files in the mergestate. However, we'll be still in a state with only one parent. This merge will help to recreate the exact same state with two parents.

There are other ways to set the second parent, like dirstate.setparents() I think. It is worth investigating to find a way to do it without merging again.

Jun 10 2019, 12:00 PM
navaneeth.suresh added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

Can we prevent merging again? Since we are getting content from old unresolved commit, copying mergestate from previously stored one, what purpose does this merging serves?

Jun 10 2019, 11:48 AM

Jun 5 2019

navaneeth.suresh created D6478: shelve: first prototype of storing unresolved changes.
Jun 5 2019, 3:05 PM
navaneeth.suresh created D6479: shelve: first prototype of storing/restoring unresolved changes.
Jun 5 2019, 3:05 PM

May 27 2019

navaneeth.suresh created D6448: help: add help entry for internals.mergestate.
May 27 2019, 9:24 AM

Apr 9 2019

navaneeth.suresh added inline comments to D5628: diffstat: make --git work properly on renames (issue6025).
Apr 9 2019, 11:55 AM

Apr 2 2019

navaneeth.suresh added a comment to D6169: unshelve: disable unshelve during merge (issue5123).

Thanks for queuing Yuya.

Apr 2 2019, 11:48 PM
navaneeth.suresh closed D6169: unshelve: disable unshelve during merge (issue5123).
Apr 2 2019, 6:40 PM
navaneeth.suresh committed rHG03f6480bfdda: unshelve: disable unshelve during merge (issue5123).
unshelve: disable unshelve during merge (issue5123)
Apr 2 2019, 6:40 PM
navaneeth.suresh updated the diff for D6169: unshelve: disable unshelve during merge (issue5123).
Apr 2 2019, 9:06 AM

Apr 1 2019

navaneeth.suresh added a comment to D6169: unshelve: disable unshelve during merge (issue5123).

I saw some patches[0][1][2] trying to fix this issue. It seems like it's difficult to preserve the second parent.

Apr 1 2019, 4:12 AM

Mar 26 2019

navaneeth.suresh added a comment to D6027: mq: make unshelve to apply on modified mq patch (issue4318).

It doesn't make sense to check the existence of 'shelvedstate' in a static
table.
Can't we somehow get around the mq in a similar way to shelve.getcommitfunc()?
I don't think it's good idea to rely on state files saved on disk.

Mar 26 2019, 2:21 PM
navaneeth.suresh added a comment to D6169: unshelve: disable unshelve during merge (issue5123).

Is it difficult to fix unshelve to not lose merge parents?
https://bz.mercurial-scm.org/show_bug.cgi?id=5123#c2

Mar 26 2019, 2:11 PM

Mar 25 2019

navaneeth.suresh created D6169: unshelve: disable unshelve during merge (issue5123).
Mar 25 2019, 3:17 AM

Mar 24 2019

navaneeth.suresh added a comment to D6027: mq: make unshelve to apply on modified mq patch (issue4318).

Gentle ping for review.

Mar 24 2019, 2:09 PM
navaneeth.suresh added a comment to D6056: patch: stop aborting when add/rename/copy files on --interactive (issue5727).

Gentle ping for review.

Mar 24 2019, 2:08 PM

Mar 17 2019

navaneeth.suresh added inline comments to D6056: patch: stop aborting when add/rename/copy files on --interactive (issue5727).
Mar 17 2019, 12:59 AM

Mar 16 2019

navaneeth.suresh added inline comments to D6056: patch: stop aborting when add/rename/copy files on --interactive (issue5727).
Mar 16 2019, 4:57 AM