- User Since
- Oct 10 2018, 6:12 AM (14 w, 2 d)
Thu, Jan 17
Sun, Jan 13
_performrevert() would be in the same boat, but it was explicitly flagged on
at f37a69ec3f47. This implies that the diff.ignorews option would be used
in practice to exclude whitespace changes while interactive commit/revert.
So disabling any whitespace options would break someone's workflow.
Sat, Jan 12
Fri, Jan 11
Sorry for late, but doesn't it break hg record --ignore-all-space, etc.?
Thu, Jan 10
@durin42 I've added test for the current revision. Unfortunately, I'm unable to write a test for the wrong behaviour. I'll try writing it again. Any hints from your side?
Could you add a test?
(Bonus points if you add a test that shows the wrong behavior and then fix it in this change.)
Wed, Jan 9
Mon, Jan 7
This is logically incorrect. The problem is that we're doing variable
expansion at too lower layer. vfs(expand(user_specified_path)) makes
some sense, but vfs(expand(getcwd())) is clearly wrong. And the vfs class
can't know where the base comes from.
Sat, Jan 5
Fri, Jan 4
Thu, Jan 3
Thanks for queuing!
Thanks for queuing Yuya!
Wed, Jan 2
@yuja Can this be closed?
@yuja Requested changes have been made in the current revision.
Sun, Dec 30
IIUC, the problem is that the width parameter is incorrect because of
Fri, Dec 28
Thu, Dec 27
Wed, Dec 26
Tue, Dec 25
@yuja Thank you so much for the information. I've updated the revision. Please review when you're free.
Mon, Dec 24
Sun, Dec 23
Thanks for the info @yuja. I'm thinking to move --rev/-r to branches command and replacing --show/-s that I've made to --rev/-r in the branch command itself. How's that sound to you guys, @pulkit @yuja ?