_performrevert() would be in the same boat, but it was explicitly flagged on
at f37a69ec3f47. This implies that the diff.ignorews option would be used
in practice to exclude whitespace changes while interactive commit/revert.
So disabling any whitespace options would break someone's workflow.

Sorry for late, but doesn't it break hg record --ignore-all-space, etc.?

@durin42 I've added test for the current revision. Unfortunately, I'm unable to write a test for the wrong behaviour. I'll try writing it again. Any hints from your side?

Could you add a test?

(Bonus points if you add a test that shows the wrong behavior and then fix it in this change.)

In D5494#81855, @pulkit wrote:

Sorry for bumping on this now, can you add tests for this as follow-up?

This is logically incorrect. The problem is that we're doing variable
expansion at too lower layer. vfs(expand(user_specified_path)) makes
some sense, but vfs(expand(getcwd())) is clearly wrong. And the vfs class
can't know where the base comes from.

@mharbison72 @yuja Thank you for the suggestions. I've created a follow-up patch making the suggested changes. Please see D5494.

In D5490#81294, @pulkit wrote:

I am not sure whether this change is correct or not, but please add more description to your commit message explaining what this patch is doing, what the issue is about and how it fixes that.

Thanks for queuing!

Thanks for queuing Yuya!

@yuja Can this be closed?

@yuja Requested changes have been made in the current revision.

IIUC, the problem is that the width parameter is incorrect because of
graph lines.

In D5477#81186, @yuja wrote:

I tried to queue this, but the patch doesn't include any metadata (e.g. author
and date.) Please check your configuration.

https://www.mercurial-scm.org/wiki/Phabricator

In D5477#81155, @yuja wrote:

Looks mostly good.

Can you update the commit message to conform to our style?
https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

@yuja Thank you so much for the information. I've updated the revision. Please review when you're free.

In D5477#81095, @yuja wrote:

fm.startitem()

+ rev = ctx.rev()
+ if opts.get('rev') and rev not in revs:
+ continue

ctx points to the tipmost branch head. so rev not in revs doesn't mean any
of the revs do not belong to the branch.

In D5475#81071, @yuja wrote:

Thanks for the info @yuja. I'm thinking to move --rev/-r to branches command and replacing --show/-s that I've made to --rev/-r in the branch command itself.

I'm not sure if I get it, but my idea is to add hg branches -r/--rev
that selects branches to be listed by revisions. So, hg branch -srREV in
your original patch will be equivalent to hg branches -qrREV (-q to
suppress detailed output.)

Thanks for the info @yuja. I'm thinking to move --rev/-r to branches command and replacing --show/-s that I've made to --rev/-r in the branch command itself. How's that sound to you guys, @pulkit @yuja ?