navaneeth.suresh (Navaneeth Suresh)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2018, 6:12 AM (14 w, 2 d)

Recent Activity

Thu, Jan 17

navaneeth.suresh created D5628: diffstat: make --git work properly on renames (issue6025).
Thu, Jan 17, 7:46 AM

Sun, Jan 13

navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

_performrevert() would be in the same boat, but it was explicitly flagged on
at f37a69ec3f47. This implies that the diff.ignorews option would be used
in practice to exclude whitespace changes while interactive commit/revert.
So disabling any whitespace options would break someone's workflow.

Sun, Jan 13, 9:31 AM

Sat, Jan 12

navaneeth.suresh closed D5552: tests: add test for warning on histedit with tagged commits.
Sat, Jan 12, 9:08 PM
navaneeth.suresh committed rHG172296c6db91: tests: add test for warning on histedit with tagged commits.
tests: add test for warning on histedit with tagged commits
Sat, Jan 12, 9:08 PM

Fri, Jan 11

navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

Sorry for late, but doesn't it break hg record --ignore-all-space, etc.?

Fri, Jan 11, 10:13 AM
navaneeth.suresh updated the diff for D5490: commit: remove ignore whitespace option on --interactive (issue6042).
Fri, Jan 11, 10:12 AM

Thu, Jan 10

navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

@durin42 I've added test for the current revision. Unfortunately, I'm unable to write a test for the wrong behaviour. I'll try writing it again. Any hints from your side?

Thu, Jan 10, 11:29 PM
navaneeth.suresh updated the diff for D5490: commit: remove ignore whitespace option on --interactive (issue6042).
Thu, Jan 10, 11:26 PM
navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).

Could you add a test?

(Bonus points if you add a test that shows the wrong behavior and then fix it in this change.)

Thu, Jan 10, 8:13 AM
navaneeth.suresh created D5552: tests: add test for warning on histedit with tagged commits.
Thu, Jan 10, 8:10 AM
navaneeth.suresh added a comment to D5494: histedit: add user input to warning message on editing tagged commits.
In D5494#81855, @pulkit wrote:

Sorry for bumping on this now, can you add tests for this as follow-up?

Thu, Jan 10, 3:25 AM

Wed, Jan 9

navaneeth.suresh committed rHG7b7e081f8954: histedit: add user input to warning message on editing tagged commits.
histedit: add user input to warning message on editing tagged commits
Wed, Jan 9, 3:00 PM
navaneeth.suresh closed D5494: histedit: add user input to warning message on editing tagged commits.
Wed, Jan 9, 3:00 PM

Mon, Jan 7

navaneeth.suresh added a comment to D5503: vfs: add support for repo names with `$` when using with env vars (issue5739).

This is logically incorrect. The problem is that we're doing variable
expansion at too lower layer. vfs(expand(user_specified_path)) makes
some sense, but vfs(expand(getcwd())) is clearly wrong. And the vfs class
can't know where the base comes from.

Mon, Jan 7, 11:08 PM
navaneeth.suresh updated the diff for D5503: vfs: add support for repo names with `$` when using with env vars (issue5739).
Mon, Jan 7, 7:08 AM
navaneeth.suresh created D5503: vfs: add support for repo names with `$` when using with env vars (issue5739).
Mon, Jan 7, 3:38 AM

Sat, Jan 5

navaneeth.suresh added a comment to D5489: histedit: add warning message on editing tagged commits (issue4017).

@mharbison72 @yuja Thank you for the suggestions. I've created a follow-up patch making the suggested changes. Please see D5494.

Sat, Jan 5, 11:15 PM
navaneeth.suresh updated the summary of D5494: histedit: add user input to warning message on editing tagged commits.
Sat, Jan 5, 11:11 PM
navaneeth.suresh created D5494: histedit: add user input to warning message on editing tagged commits.
Sat, Jan 5, 11:07 PM
navaneeth.suresh added a comment to D5490: commit: remove ignore whitespace option on --interactive (issue6042).
In D5490#81294, @pulkit wrote:

I am not sure whether this change is correct or not, but please add more description to your commit message explaining what this patch is doing, what the issue is about and how it fixes that.

Sat, Jan 5, 4:45 AM
navaneeth.suresh updated the summary of D5490: commit: remove ignore whitespace option on --interactive (issue6042).
Sat, Jan 5, 4:43 AM

Fri, Jan 4

navaneeth.suresh created D5490: commit: remove ignore whitespace option on --interactive (issue6042).
Fri, Jan 4, 5:23 AM
navaneeth.suresh added inline comments to D5489: histedit: add warning message on editing tagged commits (issue4017).
Fri, Jan 4, 3:28 AM

Thu, Jan 3

navaneeth.suresh added a comment to D5489: histedit: add warning message on editing tagged commits (issue4017).

Thanks for queuing!

Thu, Jan 3, 10:50 PM
navaneeth.suresh closed D5489: histedit: add warning message on editing tagged commits (issue4017).
Thu, Jan 3, 5:54 PM
navaneeth.suresh committed rHG86f0ed7ac688: histedit: add warning message on editing tagged commits (issue4017).
histedit: add warning message on editing tagged commits (issue4017)
Thu, Jan 3, 5:53 PM
navaneeth.suresh created D5489: histedit: add warning message on editing tagged commits (issue4017).
Thu, Jan 3, 1:33 PM
navaneeth.suresh added a comment to D5485: log: fixes line wrap on diffstat (issue5800).

Thanks for queuing Yuya!

Thu, Jan 3, 5:11 AM
navaneeth.suresh closed D5485: log: fixes line wrap on diffstat (issue5800).
Thu, Jan 3, 4:39 AM
navaneeth.suresh committed rHG6a63ba61e71f: log: fix line wrap on diffstat with -G/--graph (issue5800).
log: fix line wrap on diffstat with -G/--graph (issue5800)
Thu, Jan 3, 4:39 AM

Wed, Jan 2

navaneeth.suresh abandoned D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Wed, Jan 2, 7:23 AM
navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).

@yuja Can this be closed?

Wed, Jan 2, 7:07 AM
navaneeth.suresh added a comment to D5485: log: fixes line wrap on diffstat (issue5800).

@yuja Requested changes have been made in the current revision.

Wed, Jan 2, 6:36 AM
navaneeth.suresh updated the diff for D5485: log: fixes line wrap on diffstat (issue5800).
Wed, Jan 2, 6:32 AM

Sun, Dec 30

navaneeth.suresh added a comment to D5485: log: fixes line wrap on diffstat (issue5800).

IIUC, the problem is that the width parameter is incorrect because of
graph lines.

Sun, Dec 30, 8:34 AM
navaneeth.suresh updated the diff for D5485: log: fixes line wrap on diffstat (issue5800).
Sun, Dec 30, 8:27 AM

Fri, Dec 28

navaneeth.suresh closed D5486: branches: add -r option to show branch name(s) of a given rev (issue5948).
Fri, Dec 28, 12:06 AM
navaneeth.suresh committed rHG4506f801e492: branches: add -r option to show branch name(s) of a given rev (issue5948).
branches: add -r option to show branch name(s) of a given rev (issue5948)
Fri, Dec 28, 12:05 AM

Thu, Dec 27

navaneeth.suresh abandoned D5475: branch:Added option to show branch name of a given rev (Issue5948).
Thu, Dec 27, 1:34 PM
navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
In D5477#81186, @yuja wrote:

I tried to queue this, but the patch doesn't include any metadata (e.g. author
and date.) Please check your configuration.

https://www.mercurial-scm.org/wiki/Phabricator

Thu, Dec 27, 11:06 AM
navaneeth.suresh created D5486: branches: add -r option to show branch name(s) of a given rev (issue5948).
Thu, Dec 27, 11:02 AM
navaneeth.suresh updated the diff for D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Thu, Dec 27, 8:55 AM
navaneeth.suresh created D5485: log: fixes line wrap on diffstat (issue5800).
Thu, Dec 27, 6:48 AM

Wed, Dec 26

navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
In D5477#81155, @yuja wrote:

Looks mostly good.

Can you update the commit message to conform to our style?
https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

Wed, Dec 26, 9:43 AM
navaneeth.suresh updated the diff for D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Wed, Dec 26, 9:39 AM

Tue, Dec 25

navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).

@yuja Thank you so much for the information. I've updated the revision. Please review when you're free.

Tue, Dec 25, 8:51 AM
navaneeth.suresh updated the diff for D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Tue, Dec 25, 8:49 AM

Mon, Dec 24

navaneeth.suresh added a comment to D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
In D5477#81095, @yuja wrote:
fm.startitem()

+ rev = ctx.rev()
+ if opts.get('rev') and rev not in revs:
+ continue

ctx points to the tipmost branch head. so rev not in revs doesn't mean any
of the revs do not belong to the branch.

Mon, Dec 24, 9:05 AM
navaneeth.suresh added a comment to D5475: branch:Added option to show branch name of a given rev (Issue5948).
In D5475#81071, @yuja wrote:
Thanks for the info @yuja. I'm thinking to move --rev/-r to branches command and replacing --show/-s that I've made to --rev/-r in the branch command itself.

I'm not sure if I get it, but my idea is to add hg branches -r/--rev
that selects branches to be listed by revisions. So, hg branch -srREV in
your original patch will be equivalent to hg branches -qrREV (-q to
suppress detailed output.)

Mon, Dec 24, 6:37 AM
navaneeth.suresh created D5477: branches: add -r option to show branch name(s) of a given rev (issue5948).
Mon, Dec 24, 6:35 AM

Sun, Dec 23

navaneeth.suresh added a comment to D5475: branch:Added option to show branch name of a given rev (Issue5948).

Thanks for the info @yuja. I'm thinking to move --rev/-r to branches command and replacing --show/-s that I've made to --rev/-r in the branch command itself. How's that sound to you guys, @pulkit @yuja ?

Sun, Dec 23, 10:04 AM
navaneeth.suresh created D5475: branch:Added option to show branch name of a given rev (Issue5948).
Sun, Dec 23, 5:22 AM