- User Since
- Jun 23 2017, 6:41 PM (220 w, 5 d)
Aug 15 2018
Mar 21 2018
What _is_ the difference between "conclude" and "commit"?
Mar 15 2018
Mar 5 2018
Jan 21 2018
Jan 18 2018
Jan 5 2018
Jan 4 2018
I added a comment and also filed T24918295 for the wider task around allowing lazy filectx writes (but as Durham mentioned that's a strict improvement on the status quo).
Should we even be calling _makebackup in the case of an inmemory merge? Like, maybe the makebackup should be conditional based on if the source file context is actually a workingctx?
I'll add a comment.
Dec 28 2017
Dec 27 2017
Dec 22 2017
Dec 21 2017
Dec 20 2017
Dec 17 2017
Dec 15 2017
Based on Messenger discussion, this version just skips the manifest verification and future steps which require it, but keeps changeset verification. Can probably get by without upstream refactor.
Dec 14 2017
@yuja is that just because of the _manifest property cache, or are there others as well?
Dec 13 2017
(Need to look at https://phabricator.intern.facebook.com/D6558110 too which is touching verify)
OK, extracting just the manifest verification will take a bit of upstream refactoring. I'll send an upstream change to do that + a followup to scope this to just changesets. But people are still running verifies that take 4 days and make tons of packfiles, so I'm still +1 on landing this while that's happening.
I can do that, we just wanted to get a MVP out ASAP since people are hurtin'.
Added a test, description and moved to config.
A better way might just be to use None for self.wtcx when rebasing on disk, which will cause fresh wctxs to be used every time and feel less icky. We could use self.inmemory instead of self.wctx.isinmemory().