- User Since
- Jun 28 2017, 8:54 PM (107 w, 1 d)
Wed, Jul 17
I tested this series on our repository and found the following speedup in a case when there are 6k heads and 15k csets missing:
Mon, Jul 15
Thu, Jul 11
However when merge is aborted there is no unresolved merge in progress and hence
It will be nice to add information to commit message about how thing unshelving of a subset works.
Wed, Jul 10
The commit message is outdated.
This is fone so as to avoid the return statement
Tue, Jul 9
This logic is registered to the statesetection API as abortfunc.
hg abort currently supports --dry-run/-n flag only.
It is used to dry run hg abort
Mon, Jul 8
Also, can you add an entry about this to relnotes/next?
Maybe this deserves and entry in relnotes/next as a followup.
Looking closely, the backup value comes from reading ui.configbool('rewrite', 'backup-bundle') instead of a --no-backup flag. It means we can get rid of the --backup flag to hg abort as there exists no such flag for histedit.
It will be nice to mention about our motivation to move code in the commit message.
Sun, Jul 7
Sat, Jul 6
Fri, Jul 5
Tests have been shown as test-abort.t
Thu, Jul 4
Since you did the nice work of moving shelve to core, how about rebasing this patch on tip of default with shelve in core?
Can you add link of mailing list thread in your commit message? Link from markmail or https://www.mercurial-scm.org/pipermail/mercurial-devel/.
Since we both are discussing and working on this, we can understand why this patch does what it does. It will be nice to have more explained commit descriptions which explain why we need to have an function independent of rebase-runtime-state object. This applies to all the patches in the series. In the hg abort patch, explaining how it works will be good.
Didn't look at the actual implementation yet.
Sun, Jun 30
This patch needs to be rebased on tip of hg-committed as shelve is in core now.
Sat, Jun 29
Review ping for this stack.
Fri, Jun 28
Thanks a lot for working on this. This needs to be rebased on tip of default branch. Also, can you add an entry about shelve extension being moved to core in relnotes/next file.