Page MenuHomePhabricator

pulkit (Pulkit Goyal)
Spy

Projects

User Details

User Since
Jun 28 2017, 8:54 PM (134 w, 6 d)

Recent Activity

Yesterday

pulkit added a comment to D8021: chg: switch to using global `environ` instead of envp from main.

I don't know about the code which this series touch, but since D7550 already made to 5.3rc, should this series be targeted for stable branch?

Tue, Jan 28, 6:57 AM

Mon, Jan 27

pulkit added inline comments to D7906: rebase: define base in only place in defineparents().
Mon, Jan 27, 9:40 AM

Sat, Jan 25

D8001: pathauditor: drop a redundant call to bytes.lower() is now accepted and ready to land.
Sat, Jan 25, 7:01 PM
pulkit added a comment to D8010: phabricator: fix a crash when submitting binaries (issue6260).

Converted line endings in tests/phabricator/phabsend-binary.json to unix ones in flight.

Sat, Jan 25, 6:25 PM
D8005: wix: use original version string for MSI filename is now accepted and ready to land.
Sat, Jan 25, 6:16 PM
D8004: wix: always normalize version string is now accepted and ready to land.
Sat, Jan 25, 6:15 PM
D8003: wix: more robust normalization of RC version components is now accepted and ready to land.
Sat, Jan 25, 6:15 PM
D8006: copyright: update to 2020 is now accepted and ready to land.
Sat, Jan 25, 6:12 PM
D7996: merge: don't auto-pick destination with `hg merge 'wdir()'` is now accepted and ready to land.
Sat, Jan 25, 6:12 PM
D8010: phabricator: fix a crash when submitting binaries (issue6260) is now accepted and ready to land.
Sat, Jan 25, 6:11 PM

Fri, Jan 24

D7998: merge: replace a repo.lookup('.') by more typical repo['.'].node() is now accepted and ready to land.
Fri, Jan 24, 8:32 PM
D7997: merge: drop now-unused "abort" argument from hg.merge() is now accepted and ready to land.
Fri, Jan 24, 8:28 PM
pulkit added a comment to D7996: merge: don't auto-pick destination with `hg merge 'wdir()'`.

Looks like we don't have tests for hg merge 'wdir()'. Also I am not sure what should be the correct behavior in that case.

Fri, Jan 24, 8:27 PM
D7994: merge: check that there are no conflicts after --abort is now accepted and ready to land.
Fri, Jan 24, 8:24 PM
D7993: merge: use check_incompatible_arguments() for --abort is now accepted and ready to land.
Fri, Jan 24, 8:24 PM
D7995: merge: call hg.abortmerge() directly and return early is now accepted and ready to land.
Fri, Jan 24, 8:23 PM
D7991: progress: delete deprecated ui.progress() is now accepted and ready to land.
Fri, Jan 24, 5:34 PM
D7977: copies: extract function for finding directory renames is now accepted and ready to land.
Fri, Jan 24, 5:23 PM
D7976: copies: avoid calculating debug-only stuff without --debug is now accepted and ready to land.
Fri, Jan 24, 5:22 PM
D7975: copies: move early return in mergecopies() earlier is now accepted and ready to land.
Fri, Jan 24, 5:21 PM
D7985: tests: test merge of renames of different sources to same target is now accepted and ready to land.
Fri, Jan 24, 5:17 PM
D7984: clean: check that there are no conflicts after is now accepted and ready to land.
Fri, Jan 24, 5:10 PM
D7905: rebase: move some variables after an error cases where they're not needed is now accepted and ready to land.
Fri, Jan 24, 5:07 PM
D7904: rebase: clarify a little by calculating a set in Python instead of in revset is now accepted and ready to land.
Fri, Jan 24, 5:05 PM
D7900: merge: avoid a negation in the definition of updatedirstate is now accepted and ready to land.
Fri, Jan 24, 12:01 PM
D7983: merge: move definition of `partial` closer to where it's used is now accepted and ready to land.
Fri, Jan 24, 11:59 AM
pulkit updated subscribers of D7733: hgext: initial version of fastexport extension.

The logic looks fine, the code needs to be polished a bit and need some documentation. I left inline comments/nits. It will be nice to have the next version of this patch py3 compatible.

Fri, Jan 24, 8:52 AM
pulkit added inline comments to D7900: merge: avoid a negation in the definition of updatedirstate.
Fri, Jan 24, 7:57 AM
D7899: merge: define updatedirstate a little earlier and reuse it is now accepted and ready to land.
Fri, Jan 24, 7:55 AM
D7898: merge: don't call update hook when using in-memory context is now accepted and ready to land.
Fri, Jan 24, 7:54 AM

Thu, Jan 23

D7970: crecord: fix a concatenation of bytes and str on py3 is now accepted and ready to land.
Thu, Jan 23, 7:12 AM
D7973: packaging: add configparser to inno requirements file is now accepted and ready to land.
Thu, Jan 23, 7:12 AM
pulkit accepted D7937: python-zstandard: blacken at 80 characters.
Thu, Jan 23, 7:09 AM
D7968: tests: move non-collapse test out of test-rebase-collapse is now accepted and ready to land.
Thu, Jan 23, 7:05 AM
D7971: recover: fix typos is now accepted and ready to land.
Thu, Jan 23, 7:02 AM
D7979: debugcommands: add Python implementation to debuginstall is now accepted and ready to land.
Thu, Jan 23, 7:02 AM
D7978: run-tests: remove --py3-warnings is now accepted and ready to land.
Thu, Jan 23, 7:01 AM

Wed, Jan 22

pulkit added a comment to D7972: recover: don't verify by default.

I also have experience with C-c thing. Will a config option which enables --no-verify by default will work for you?

Wed, Jan 22, 3:13 PM
pulkit added a comment to D7898: merge: don't call update hook when using in-memory context.

Do we have user-facing documentation for these behavior? I tried to find documentation related to hooks but was unable to find any.

Wed, Jan 22, 10:31 AM
D7959: lfs: move the initialization of the upload request into the try block is now accepted and ready to land.
Wed, Jan 22, 10:21 AM
D7958: lfs: drop an unnecessary r'' prefix is now accepted and ready to land.
Wed, Jan 22, 10:17 AM
D7957: lfs: explicitly close the file handle for the blob being uploaded is now accepted and ready to land.
Wed, Jan 22, 10:17 AM
D7956: lfs: drop the unused progressbar code in the `filewithprogress` class is now accepted and ready to land.
Wed, Jan 22, 10:16 AM
pulkit updated subscribers of D7964: cext: change two more vars to Py_ssize_t in manifest.c.

This should go to stable branch right?
cc: @martinvonz @durin42

Wed, Jan 22, 10:14 AM
D7955: relnotes: copy "next" to "5.3" and clear "next" is now accepted and ready to land.
Wed, Jan 22, 10:13 AM
pulkit updated subscribers of D7967: exchange: recognize changegroup3 bundles in `getbundlespec()`.
Wed, Jan 22, 7:47 AM

Tue, Jan 21

pulkit created D7966: remotefilelog: only prefetch history in linkrevfixup.
Tue, Jan 21, 4:59 PM
pulkit created D7965: py3: catch AttributeError too with ImportError.
Tue, Jan 21, 4:47 PM
D7807: hgrc: introduce HGRCSKIPREPO to skip reading the repository's hgrc is now accepted and ready to land.
Tue, Jan 21, 11:05 AM
D7952: rust: add a README is now accepted and ready to land.
Tue, Jan 21, 11:02 AM
D7954: hgdemandimport: apply lazy module loading to sys.meta_path finders is now accepted and ready to land.
Tue, Jan 21, 11:02 AM
D7949: py3: suppress unraisable exceptions in test-worker.t is now accepted and ready to land.
Tue, Jan 21, 11:02 AM
D7948: debugcommands: move away from line buffered output on binary stream is now accepted and ready to land.
Tue, Jan 21, 7:25 AM
D7947: py3: conditionalize test-lfs-serve-access.t for Python 3.8 is now accepted and ready to land.
Tue, Jan 21, 7:25 AM
D7946: py3: add extra traceback line present on Python 3.8 is now accepted and ready to land.
Tue, Jan 21, 7:24 AM
D7945: py3: conditionalize test-flagprocessor.t on Python 3.8 is now accepted and ready to land.
Tue, Jan 21, 7:23 AM
D7953: hgdemandimport: disable on Python 3.5 is now accepted and ready to land.
Tue, Jan 21, 7:16 AM
pulkit updated subscribers of D7952: rust: add a README.
Tue, Jan 21, 7:14 AM
D7868: rust-filepatterns: remove bridge code for filepatterns-related functions is now accepted and ready to land.
Tue, Jan 21, 7:09 AM
D7867: rust-hg-path: add useful methods to `HgPath` is now accepted and ready to land.
Tue, Jan 21, 7:08 AM
D7950: verify: avoid spurious integrity warnings in verbose mode (issue6172) is now accepted and ready to land.
Tue, Jan 21, 7:03 AM

Mon, Jan 20

pulkit added a comment to D7950: verify: avoid spurious integrity warnings in verbose mode (issue6172).

TBH it feels not correct that some code path of hg verify needs unfiltered repository and that too around renames. Reading tests, I first thought it's some bug in unamend and then checked the issue to realize it's a general problem.

Mon, Jan 20, 11:36 AM
pulkit added inline comments to D7940: py3: make flush() line optional.
Mon, Jan 20, 9:03 AM
D7942: py3: make test-http-bad-server.t conditional on Python 3.6+ is now accepted and ready to land.
Mon, Jan 20, 9:02 AM
D7941: py3: wallpaper over demand importer differences on Python 3.5 is now accepted and ready to land.

I added a || false to normalize the exit code.

s/false/true in flight

Mon, Jan 20, 9:01 AM
D7940: py3: make flush() line optional is now accepted and ready to land.
Mon, Jan 20, 8:58 AM
D7943: tests: conditionalize test-hightlight.t on pygments version is now accepted and ready to land.
Mon, Jan 20, 7:39 AM
D7939: py3: glob over exception in test-check-py3-compat.t is now accepted and ready to land.
Mon, Jan 20, 7:38 AM
D7938: py3: string normalization and I/O tweaks in test-lfs.t is now accepted and ready to land.
Mon, Jan 20, 7:37 AM
D7936: help: minor copy editing to the `config.format` section is now accepted and ready to land.
Mon, Jan 20, 7:35 AM

Fri, Jan 17

pulkit created D7932: [RFC]debugbackups: introduce command to interact with strip backups.
Fri, Jan 17, 1:25 PM
pulkit added a comment to D7732: convert: refactor authormap into separate function for outside use.

Amending the following in flight to make test-check-format.t (or black) happy:

Fri, Jan 17, 10:08 AM
D7502: changectx: mark parent of changesets as non filtered is now accepted and ready to land.
Fri, Jan 17, 10:00 AM
D7501: changectx: use unfiltered changelog to walk ancestors in annotate is now accepted and ready to land.
Fri, Jan 17, 9:59 AM
D7498: localrepo: also fast past the parents of working copies parents is now accepted and ready to land.

There are a descent odds that their will be needed too.

There are descent odds that they will be needed too.

Fri, Jan 17, 9:59 AM
D7495: localrepo: recognize trivial request for '.' is now accepted and ready to land.
Fri, Jan 17, 9:58 AM
D7494: localrepo: fastpath access to "." is now accepted and ready to land.
Fri, Jan 17, 9:58 AM
pulkit added a comment to D7494: localrepo: fastpath access to ".".

"." is just an aliast for p1(wdir(),

"." is just an alias for p1(wdir()),

Fri, Jan 17, 9:58 AM
D7492: localrepo: also fastpath access to working copy parents when possible is now accepted and ready to land.

Amending the perf numbers in commit message and fixed some spellings.

Fri, Jan 17, 9:57 AM
D7911: examples: refer to nightly rustfmt in Windows-compatible way is now accepted and ready to land.
Fri, Jan 17, 9:43 AM
D7732: convert: refactor authormap into separate function for outside use is now accepted and ready to land.
Fri, Jan 17, 9:42 AM

Thu, Jan 16

pulkit accepted D7816: tests: stabilize test-subrepo-svn.t on Windows.
Thu, Jan 16, 11:10 AM
D7865: rust-fmt: run cargo fmt now requires changes to proceed.
Thu, Jan 16, 10:57 AM
pulkit added a comment to D7865: rust-fmt: run cargo fmt.

This one fails to apply. Please rebase and resend.

Thu, Jan 16, 10:54 AM
D7897: rebase: fix bug where `--collapse` would apply diff on missing file is now accepted and ready to land.
Thu, Jan 16, 10:43 AM
D7896: rebase: extract a variable for a repeated `repo[p1]` is now accepted and ready to land.
Thu, Jan 16, 10:40 AM
D7861: graftcopies: document why the function is useful at all is now accepted and ready to land.
Thu, Jan 16, 10:39 AM
D7860: graftcopies: remove `skip` and `repo` arguments is now accepted and ready to land.
Thu, Jan 16, 10:37 AM
D7859: graftcopies: use _filter() for filtering out invalid copies is now accepted and ready to land.
Thu, Jan 16, 10:35 AM
D7858: copies: replace duplicatecopies() by function that takes contexts is now accepted and ready to land.
Thu, Jan 16, 10:34 AM
D7895: rust-core: fix typo in comment is now accepted and ready to land.
Thu, Jan 16, 10:33 AM
D7864: rust-utils: add Rust implementation of Python's "os.path.splitdrive" is now accepted and ready to land.
Thu, Jan 16, 10:31 AM

Wed, Jan 15

pulkit added a comment to D7862: dirstate: move rust fast-path calling code to its own method.

Absorbing the following diff to make test-check-format.t happy:

Wed, Jan 15, 8:11 AM
D7875: packaging: leverage os.path.relpath() in setup.py is now accepted and ready to land.
Wed, Jan 15, 7:16 AM
D7882: lfs: avoid quadratic performance in processing server responses is now accepted and ready to land.
Wed, Jan 15, 7:15 AM
D7881: lfs: check content length after downloading content is now accepted and ready to land.
Wed, Jan 15, 7:13 AM
D7880: lfs: rename a variable to clarify its use is now accepted and ready to land.
Wed, Jan 15, 7:11 AM
D7878: sha1dc: use proper string functions on Python 2/3 is now accepted and ready to land.
Wed, Jan 15, 7:09 AM
D7877: sha1dc: declare all variables at begininng of block is now accepted and ready to land.
Wed, Jan 15, 7:09 AM
D7876: sha1dc: manually define integer types on msvc 2008 is now accepted and ready to land.
Wed, Jan 15, 7:09 AM