Page MenuHomePhabricator

pulkit (Pulkit Goyal)
Spy

Projects

User Details

User Since
Jun 28 2017, 8:54 PM (225 w, 1 d)

Recent Activity

Mon, Oct 18

D11683: fix: appease pyflakes and make unused variables more obvious is now accepted and ready to land.
Mon, Oct 18, 10:41 AM

Sat, Oct 16

pulkit added a comment to D11680: push: add option to abort on dirty working copy if parent is pushed.

I am big +1 on this and will personally use it. Thanks!

Sat, Oct 16, 2:40 PM

Fri, Oct 15

pulkit added inline comments to D11665: formatting: format with newer black version.
Fri, Oct 15, 9:08 AM
pulkit updated subscribers of D11563: WIP working on making rust components compile on windows systems.

@Alphare @SimonSapin @mharbison72 this might be of interest to you.

Fri, Oct 15, 9:05 AM
pulkit added a comment to D11550: dirstate: remove a update_file's special case for tracked file with p2 data.

This series can be abandoned.

Fri, Oct 15, 8:58 AM
pulkit abandoned D11588: dirstate: drop some duplicated code.
Fri, Oct 15, 8:57 AM
pulkit added a reviewer for D11588: dirstate: drop some duplicated code: marmoute.
Fri, Oct 15, 8:57 AM
pulkit added a comment to D11675: bookmarks: move the `mirror` option to the `paths` section.

Can we add about this in relnotes?

Fri, Oct 15, 8:56 AM
D11674: path: keep the path instance in the `pulloperation` is now accepted and ready to land.
Fri, Oct 15, 8:53 AM
D11673: path: return path instance directly from get_pull_paths is now accepted and ready to land.
Fri, Oct 15, 8:52 AM
D11672: path: unify path creation in `get_pull_paths` is now accepted and ready to land.
Fri, Oct 15, 8:51 AM
D11671: path: add a new argument to control path validation is now accepted and ready to land.
Fri, Oct 15, 8:51 AM
pulkit added a comment to D11678: rust: reformat Rust code.

Queueing D11670 as that was sent earlier.

Fri, Oct 15, 8:49 AM
D11668: dirstate-v2: add an option to prevent unintentional slow dirstate-v2 is now accepted and ready to land.
Fri, Oct 15, 8:48 AM
pulkit added a comment to D11664: rhg: fix `hg cat` interaction with null revision.

This fails to apply on current tip of default branch, can you rebase and resend?

Fri, Oct 15, 8:46 AM
D11669: chistedit: add option to show order of commits in opposite order is now accepted and ready to land.
Fri, Oct 15, 8:43 AM
D11670: rhg: fix formatting error reported by test-check-format-rust.t is now accepted and ready to land.
Fri, Oct 15, 8:42 AM
D11665: formatting: format with newer black version is now accepted and ready to land.
Fri, Oct 15, 8:42 AM

Thu, Oct 14

D11662: dirstate-v2: Separate HAS_FILE_MTIME and HAS_DIRECTORY_MTIME flags is now accepted and ready to land.
Thu, Oct 14, 2:46 PM
D11663: narrow: raise StateError when working copy is stale (for detailed exit code) is now accepted and ready to land.
Thu, Oct 14, 2:44 PM
D11661: dirstate-v2: Extend node flags to 16 bits is now accepted and ready to land.
Thu, Oct 14, 2:43 PM
D11664: rhg: fix `hg cat` interaction with null revision is now accepted and ready to land.
Thu, Oct 14, 2:42 PM
D11660: dirstate-v2: Use attributes as intended instead of properties in v2_data() is now accepted and ready to land.
Thu, Oct 14, 2:41 PM
D11658: dirstate: Remove unused variable is now accepted and ready to land.
Thu, Oct 14, 2:40 PM
D11659: rhg: do not try to open a nodemap for an inline index is now accepted and ready to land.
Thu, Oct 14, 2:40 PM
D11657: rust: Reformat source code is now accepted and ready to land.
Thu, Oct 14, 2:39 PM

Wed, Oct 13

pulkit accepted D11520: dirstate-v2: Add support when Rust is not enabled.
Wed, Oct 13, 3:20 PM
pulkit accepted D11518: dirstate-v2: initial Python parser.
Wed, Oct 13, 3:17 PM
pulkit accepted D11518: dirstate-v2: initial Python parser.
Wed, Oct 13, 3:16 PM
D11519: dirstate-v2: Initial Python serializer is now accepted and ready to land.
Wed, Oct 13, 3:15 PM
D11621: dirstate: Move more methods to the _dirstatemapcommon base class is now accepted and ready to land.
Wed, Oct 13, 3:13 PM
D11655: dirstate-v2: Add storage space for nanoseconds precision in file mtimes is now accepted and ready to land.
Wed, Oct 13, 3:12 PM
D11654: status: Extract TruncatedTimestamp from fs::Metadata without SystemTime is now accepted and ready to land.
Wed, Oct 13, 3:12 PM
D11653: chistedit: rename a confusingly named variable is now accepted and ready to land.
Wed, Oct 13, 3:11 PM
D11652: chistedit: remove some local variable and access state on self instead is now accepted and ready to land.
Wed, Oct 13, 3:10 PM
D11649: chistedit: move changeview() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:09 PM
D11648: chistedit: move cycleaction() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:09 PM
D11647: chistedit: move changeaction() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:09 PM
D11646: chistedit: move swap() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:08 PM
D11645: chistedit: move makeselection() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:08 PM
D11644: chistedit: move changemode() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:01 PM
D11643: chistedit: move movecursor() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:01 PM
D11642: chistedit: move patchcontents() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:01 PM
D11641: chistedit: move event() onto state class is now accepted and ready to land.
Wed, Oct 13, 3:01 PM
D11640: chistedit: move renderpatch() and dependencies onto state class is now accepted and ready to land.
Wed, Oct 13, 3:00 PM
D11639: chistedit: move renderrules() onto state class is now accepted and ready to land.
Wed, Oct 13, 2:56 PM
D11638: chistedit: move layout() and dependencies onto state class is now accepted and ready to land.
Wed, Oct 13, 2:49 PM
D11637: chistedit: move rendercommit() onto state class is now accepted and ready to land.
Wed, Oct 13, 2:48 PM
D11636: chistedit: move view state from a dict to a custom class is now accepted and ready to land.
Wed, Oct 13, 2:47 PM
D11656: rhg: fix the test is now accepted and ready to land.
Wed, Oct 13, 2:30 PM
D11452: pyoxidizer: add the user site to `sys.path` on macOS is now accepted and ready to land.
Wed, Oct 13, 2:30 PM
D11451: pyoxidizer: don't use in-memory for resources on macOS is now accepted and ready to land.
Wed, Oct 13, 2:29 PM
pulkit added a comment to D11341: rust: update the minimum version of Rust.

This should not be taken until the start of the new cycle, because we don't want to break stable in case there is a 5.9.2, and I do not want to deal with a CI desync between stable and default.

Wed, Oct 13, 2:28 PM

Tue, Oct 12

D11630: rust: update the rust-cpython crate to 0.7.0 is now accepted and ready to land.
Tue, Oct 12, 1:23 PM
D11455: setup: stop packaging python3.dll and python3X.dll in the wheel distribution is now accepted and ready to land.
Tue, Oct 12, 9:35 AM
pulkit accepted D11280: fix: reduce number of tool executions.
Tue, Oct 12, 9:33 AM
pulkit accepted D11279: fix: add test to demonstrate how many times tools are executed.
Tue, Oct 12, 9:33 AM
D11454: exewrapper: find the proper python3X.dll in the registry is now accepted and ready to land.
Tue, Oct 12, 9:31 AM
pulkit accepted D11556: dirstate: push back the future a bit in the test.
Tue, Oct 12, 9:29 AM
pulkit accepted D11555: dirstate-item: point out that `merged` is set only with p1_tracked.
Tue, Oct 12, 9:29 AM
pulkit accepted D11554: dirstate-item: update the attribute documentation.
Tue, Oct 12, 9:28 AM
pulkit accepted D11553: dirstate-item: use `any_tracked` more.
Tue, Oct 12, 9:27 AM
pulkit accepted D11552: dirstate-item: drop an outdated comments.
Tue, Oct 12, 9:25 AM
pulkit accepted D11551: dirstate: remove a update_file's special case for `merged` file.
Tue, Oct 12, 9:25 AM
pulkit accepted D11550: dirstate: remove a update_file's special case for tracked file with p2 data.
Tue, Oct 12, 9:24 AM
D11609: packaging: update the certifi dependency is now accepted and ready to land.
Tue, Oct 12, 9:24 AM
D11618: rust: Make the hg-cpython crate default to Python 3 is now accepted and ready to land.
Tue, Oct 12, 9:23 AM
D11623: dirstate-v2: Use "byte sequence" in docs is now accepted and ready to land.
Tue, Oct 12, 9:22 AM
D11628: dispatch: use detailed exit code 250 for keyboard interrupt is now accepted and ready to land.
Tue, Oct 12, 9:22 AM
D11627: dispatch: ignore failure to flush ui is now accepted and ready to land.
Tue, Oct 12, 9:21 AM
D11626: dispatch: don't change error status if flushing stdio fails is now accepted and ready to land.
Tue, Oct 12, 9:20 AM

Mon, Oct 11

pulkit closed D10912: rhg: add ui.plain() and check it before showing relative paths in status.
Mon, Oct 11, 2:32 PM
pulkit closed D11613: rhg: refactor function to relativize paths in utils.
Mon, Oct 11, 2:32 PM
pulkit closed D11614: rhg: add relative paths support in `rhg status`.
Mon, Oct 11, 2:32 PM
pulkit committed rHG38deb65d4441: rhg: add ui.plain() and check it before showing relative paths in status.
rhg: add ui.plain() and check it before showing relative paths in status
Mon, Oct 11, 2:31 PM
pulkit committed rHG707c58880cd0: rhg: add relative paths support in `rhg status`.
rhg: add relative paths support in `rhg status`
Mon, Oct 11, 2:31 PM
pulkit committed rHG9ecf802b06e0: rhg: refactor function to relativize paths in utils.
rhg: refactor function to relativize paths in utils
Mon, Oct 11, 2:31 PM

Fri, Oct 8

pulkit closed D11610: largefiles: pass current transaction to `lfdirstate.write()`.
Fri, Oct 8, 7:02 PM
pulkit closed D11612: largefiles: partially undo 61e526585b20e2ff15f19497d0451d18fea02db8 and child.
Fri, Oct 8, 7:02 PM
pulkit closed D10906: rhg: fallback if tweakdefaults or statuscopies is enabled with status.
Fri, Oct 8, 7:02 PM
pulkit committed rHG64b8676f11bb: rhg: fallback if tweakdefaults or statuscopies is enabled with status.
rhg: fallback if tweakdefaults or statuscopies is enabled with status
Fri, Oct 8, 7:02 PM
pulkit closed D11611: largefiles: add tr backup for largefilesdirstate.
Fri, Oct 8, 7:02 PM
pulkit added a reverting change for rHG61e526585b20: largefiles: restore R status of removed largefiles correctly at "hg rollback": rHG941fbaab5aff: largefiles: partially undo 61e526585b20e2ff15f19497d0451d18fea02db8 and child.
Fri, Oct 8, 7:02 PM
pulkit added a reverted change for rHG941fbaab5aff: largefiles: partially undo 61e526585b20e2ff15f19497d0451d18fea02db8 and child: rHG61e526585b20: largefiles: restore R status of removed largefiles correctly at "hg rollback".
largefiles: partially undo 61e526585b20e2ff15f19497d0451d18fea02db8 and child
Fri, Oct 8, 7:02 PM
pulkit committed rHG1e98f9b5bc71: largefiles: add tr backup for largefilesdirstate.
largefiles: add tr backup for largefilesdirstate
Fri, Oct 8, 7:02 PM
pulkit committed rHGdf3021c1f093: largefiles: pass current transaction to `lfdirstate.write()`.
largefiles: pass current transaction to `lfdirstate.write()`
Fri, Oct 8, 7:02 PM

Tue, Oct 5

pulkit committed rHG690dbe1f07bf: Added signature for changeset 750920b18aaa.
Added signature for changeset 750920b18aaa
Tue, Oct 5, 12:05 PM
pulkit committed rHG3195324cacd5: Added tag 5.9.2 for changeset 750920b18aaa.
Added tag 5.9.2 for changeset 750920b18aaa
Tue, Oct 5, 12:05 PM
pulkit added a comment to D10913: rhg: refactor relative path resolution in utility fn.

Superseeded by D11613.

Tue, Oct 5, 8:49 AM
pulkit abandoned D10911: rhg: add relative path output functionality in status command.
Tue, Oct 5, 8:48 AM
pulkit abandoned D10910: rhg: refactor code a little around printing of relative paths.
Tue, Oct 5, 8:47 AM
pulkit updated the diff for D10912: rhg: add ui.plain() and check it before showing relative paths in status.
Tue, Oct 5, 8:46 AM
pulkit created D11613: rhg: refactor function to relativize paths in utils.
Tue, Oct 5, 8:45 AM
pulkit created D11614: rhg: add relative paths support in `rhg status`.
Tue, Oct 5, 8:45 AM
pulkit planned changes to D10913: rhg: refactor relative path resolution in utility fn.
Tue, Oct 5, 7:51 AM
pulkit updated the diff for D10906: rhg: fallback if tweakdefaults or statuscopies is enabled with status.
Tue, Oct 5, 7:49 AM
pulkit planned changes to D10911: rhg: add relative path output functionality in status command.
Tue, Oct 5, 7:49 AM
pulkit planned changes to D10910: rhg: refactor code a little around printing of relative paths.
Tue, Oct 5, 7:49 AM
pulkit created D11610: largefiles: pass current transaction to `lfdirstate.write()`.
Tue, Oct 5, 7:44 AM
pulkit created D11612: largefiles: partially undo 61e526585b20e2ff15f19497d0451d18fea02db8 and child.
Tue, Oct 5, 7:44 AM