Page MenuHomePhabricator

pulkit (Pulkit Goyal)
Spy

Projects

User Details

User Since
Jun 28 2017, 8:54 PM (145 w, 13 h)

Recent Activity

Today

pulkit added a comment to D8378: rust-chg: add helper to parse instructions sent from server.

Queued the whole series based on @Alphare review. Many thanks to both of you.

Thu, Apr 9, 6:38 AM
D8378: rust-chg: add helper to parse instructions sent from server is now accepted and ready to land.
Thu, Apr 9, 6:36 AM

Tue, Apr 7

pulkit added a comment to D8376: tests: collect all branch creation in one place in test-copies-chain-merge.t.

I would prefer you wait for planned change to land before you do further change to the file. The coming changes fixes bug and I rather not have to fix too many conflict while doing so.

Tue, Apr 7, 9:07 AM
D8377: tests: move verification closer to setup in test-copies-chain-merge.t is now accepted and ready to land.
Tue, Apr 7, 8:51 AM
D8376: tests: collect all branch creation in one place in test-copies-chain-merge.t is now accepted and ready to land.

I was trying to understand what's going on the test modified here and this patch helped me. Thanks!

Tue, Apr 7, 8:29 AM
D8367: manifest: remove a 20-byte-hash assumption from pure manifest parsing is now accepted and ready to land.
Tue, Apr 7, 5:22 AM
D8385: hgk: remove a "b" used on a kwargs expansion, the keys are strs is now accepted and ready to land.
Tue, Apr 7, 5:18 AM

Fri, Apr 3

pulkit added a comment to D8178: heptapod-ci: also run tests for chg on python 2.

Can we get the fix grafted on the stable branches. There are people using chg in production that would need them.

Fri, Apr 3, 5:23 AM
pulkit added inline comments to D8365: manifest: introduce new exception to signal unavailability of fastdelta().
Fri, Apr 3, 5:21 AM
D8366: manifest: also declare treemanifest as implementing imanifestdict is now accepted and ready to land.
Fri, Apr 3, 5:20 AM
D8365: manifest: introduce new exception to signal unavailability of fastdelta() is now accepted and ready to land.
Fri, Apr 3, 5:20 AM

Thu, Apr 2

pulkit committed rHGe147748f750b: merge with stable.
merge with stable
Thu, Apr 2, 12:32 PM
pulkit added a comment to D8178: heptapod-ci: also run tests for chg on python 2.

Is this targetted for stable or default ? having it on stable would be nice.

Thu, Apr 2, 12:26 PM
pulkit retitled D8178: heptapod-ci: also run tests for chg on python 2 from heptapod-ci: also run some test for chg to heptapod-ci: also run tests for chg on python 2.
Thu, Apr 2, 11:57 AM

Wed, Apr 1

pulkit committed rHGd37975386798: chgserver: update the umask cache before each run.
chgserver: update the umask cache before each run
Wed, Apr 1, 9:02 AM

Tue, Mar 31

pulkit added a comment to D8189: testlib: add a small scrip to help process to synchronise using file.

I wanted to help with things here but unfortunately I have ~0 experience with shell scripts and the kind of process testing going in next few patches.

Tue, Mar 31, 9:21 AM
D8335: url: pass str to pathname2url is now accepted and ready to land.
Tue, Mar 31, 6:17 AM
D8334: tests: pass str to matchoutput() is now accepted and ready to land.
Tue, Mar 31, 6:16 AM
D8333: tests: handle new error string from FreeBSD for dns entry not resolving is now accepted and ready to land.
Tue, Mar 31, 5:53 AM

Mon, Mar 30

D8172: notify: optional mail threading based on obsmarker is now accepted and ready to land.
Mon, Mar 30, 6:50 AM

Thu, Mar 26

pulkit committed rHG1bc345d488fd: tests: don't run test-update-atomic.t on chg.
tests: don't run test-update-atomic.t on chg
Thu, Mar 26, 7:44 AM
pulkit committed rHG8cab8db59b6c: tests: don't run couple of tests related to extensions loading with chg.
tests: don't run couple of tests related to extensions loading with chg
Thu, Mar 26, 7:44 AM
pulkit committed rHG1e459ac4cb48: chg: be stricter about checking invocation of `serve` command.
chg: be stricter about checking invocation of `serve` command
Thu, Mar 26, 7:44 AM
pulkit committed rHG97265a0c0a42: tests: conditionalize test-phases.t output for chg.
tests: conditionalize test-phases.t output for chg
Thu, Mar 26, 7:44 AM
pulkit committed rHGbdc8a5944d44: chgserver: add merge-tools to sensitive config items.
chgserver: add merge-tools to sensitive config items
Thu, Mar 26, 7:44 AM
pulkit committed rHG78a8f65eacc8: run-tests: add --chg-debug flag to show chg debug output.
run-tests: add --chg-debug flag to show chg debug output
Thu, Mar 26, 7:44 AM
pulkit committed rHG7f9538a3b29e: tests: update test-ssh.t output with --chg.
tests: update test-ssh.t output with --chg
Thu, Mar 26, 7:44 AM
pulkit committed rHG54d5424da623: tests: update test-devel-warnings.t output with chg.
tests: update test-devel-warnings.t output with chg
Thu, Mar 26, 7:44 AM
pulkit committed rHGbc592059d04f: chgserver: add fastannotate config section to sensitive list.
chgserver: add fastannotate config section to sensitive list
Thu, Mar 26, 7:44 AM
D8329: tests: update test-debugcommands.t stack trace checks for python3.9 is now accepted and ready to land.
Thu, Mar 26, 4:53 AM
D8328: tests: update test-archive.t expectations for python3.9 changes is now accepted and ready to land.
Thu, Mar 26, 4:53 AM
D8327: setup: relax -Werror for declaration-after-statement on Python 3.9 is now accepted and ready to land.
Thu, Mar 26, 4:52 AM
D8307: phabricator: account for `basectx != ctx` when calculating renames is now accepted and ready to land.
Thu, Mar 26, 4:51 AM
D8306: phabricator: add basectx arguments to file related `phabsend` utilities is now accepted and ready to land.
Thu, Mar 26, 4:51 AM
D8305: phabricator: eliminate a couple of duplicate filectx lookups is now accepted and ready to land.
Thu, Mar 26, 4:50 AM
D8332: py3: require values in changelog extras to be bytes is now accepted and ready to land.
Thu, Mar 26, 4:45 AM
D8331: py3: make setup.py's hgcommand() consistently return bytes is now accepted and ready to land.
Thu, Mar 26, 4:43 AM

Fri, Mar 20

D8233: phabricator: allow multiple DREVSPEC args to phabread|phabimport|phabupdate now requires changes to proceed.

This one fails to apply on current tip of default. Can you rebase and resend?

Fri, Mar 20, 3:53 AM
D8233: phabricator: allow multiple DREVSPEC args to phabread|phabimport|phabupdate is now accepted and ready to land.
Fri, Mar 20, 3:44 AM
D8232: phabricator: add a helper function to convert DREVSPECs to a DREV dict list is now accepted and ready to land.
Fri, Mar 20, 3:44 AM

Thu, Mar 19

pulkit added a comment to D8289: resolve: add a --clear option for clearing the merge state.

I like the idea. IIRC, Ryan from FB hit similar issues in a sprint some years ago and came up with hg up --finish or something like that.

Thu, Mar 19, 4:30 AM
pulkit accepted D8288: fix: mark -r as advanced.
Thu, Mar 19, 4:15 AM
D8287: fix: add a -s option to format a revision and its descendants is now accepted and ready to land.
Thu, Mar 19, 4:14 AM
pulkit accepted D8286: fix: move handling of --all into getrevstofix() for consistency.
Thu, Mar 19, 4:09 AM
D8300: rust-status: add trace-level logging for Rust status fallback for debugging is now accepted and ready to land.
Thu, Mar 19, 4:07 AM
D8302: hg: make _local() behave consistently on Python 3.8 (issue6287) is now accepted and ready to land.
Thu, Mar 19, 4:06 AM
D8298: tests: add test for remotefilelog interactions with hgweb is now accepted and ready to land.
Thu, Mar 19, 4:04 AM
D8299: remotefilelog: add fake heads() method that allows viewing a file in hgweb is now accepted and ready to land.
Thu, Mar 19, 4:04 AM
D8301: phabricator: remove duplicated byteskwargs conversion is now accepted and ready to land.
Thu, Mar 19, 4:03 AM
pulkit added a comment to D8172: notify: optional mail threading based on obsmarker.

@pulkit You still wanted to explain what you mean with --in-reply-to interaction here.

Thu, Mar 19, 4:02 AM

Sat, Mar 14

D8283: tests: simplify test-fix-topology.t slightly by using a `(case !)` is now accepted and ready to land.
Sat, Mar 14, 5:05 AM
D8293: rebase: accept multiple --base arguments (BC) is now accepted and ready to land.
Sat, Mar 14, 5:04 AM
D8292: rebase: accept multiple --source arguments (BC) is now accepted and ready to land.
Sat, Mar 14, 5:02 AM
D8295: rebase: mention -r argument in synopsis is now accepted and ready to land.
Sat, Mar 14, 5:01 AM
D8291: rebase: remove unused defaults argument values from _definedestmap() is now accepted and ready to land.
Sat, Mar 14, 4:56 AM
D8277: tests: fix rebase test broken by earlier cleanup is now accepted and ready to land.
Sat, Mar 14, 4:54 AM

Wed, Mar 11

pulkit committed rHGbd7b2c8d06cc: pull: add `--confirm` flag to confirm before writing changes.
pull: add `--confirm` flag to confirm before writing changes
Wed, Mar 11, 4:10 PM
pulkit committed rHG13da36d77a3f: scmutil: add option to register summary callbacks as transaction validators.
scmutil: add option to register summary callbacks as transaction validators
Wed, Mar 11, 4:10 PM
pulkit committed rHG36f08ae87ef6: transaction: add functionality to have multiple validators.
transaction: add functionality to have multiple validators
Wed, Mar 11, 4:10 PM
pulkit committed rHG9386b71a1f98: pull: add `--confirm` flag to confirm before writing changes.
pull: add `--confirm` flag to confirm before writing changes
Wed, Mar 11, 3:16 PM
pulkit closed D8200: pull: add `--confirm` flag to confirm before writing changes.
Wed, Mar 11, 12:51 PM
pulkit closed D8199: scmutil: add option to register summary callbacks as transaction validators.
Wed, Mar 11, 12:49 PM
pulkit committed rHG476c8e427975: pull: add `--confirm` flag to confirm before writing changes.
pull: add `--confirm` flag to confirm before writing changes
Wed, Mar 11, 12:49 PM
pulkit committed rHGf4c01f43132a: scmutil: add option to register summary callbacks as transaction validators.
scmutil: add option to register summary callbacks as transaction validators
Wed, Mar 11, 12:49 PM
pulkit committed rHG14e956b8acef: transaction: add functionality to have multiple validators.
transaction: add functionality to have multiple validators
Wed, Mar 11, 12:49 PM
pulkit closed D8198: transaction: add functionality to have multiple validators.
Wed, Mar 11, 12:49 PM
pulkit committed rHGa2b49606a837: hgit: make sure repository is local before checking for store type.
hgit: make sure repository is local before checking for store type
Wed, Mar 11, 12:36 PM
pulkit closed D8217: hgit: make sure repository is local before checking for store type.
Wed, Mar 11, 12:36 PM

Tue, Mar 10

pulkit added inline comments to D8265: git: key off `git` in .hg/requires rather than separate file.
Tue, Mar 10, 1:03 PM
pulkit added a comment to D8246: hg-core: add a compilation error if trying to compile outside of Linux.

Forgot to mention, I tried to apply this patch on default and it failed. Now I see it's targeted for stable. Since most of the rust code is experimental/not much used, it should be fine to have this on default branch. Any reason why this is targeted for stable?

Tue, Mar 10, 12:42 PM
pulkit added a comment to D7922: rust-matchers: add function to generate a regex matcher function.

@martinvonz this (and next few patches) seems accepted by you and Augie. Should I go ahead and push it or I missed some discussion on IRC about it?

You can push it. I wanted to finish the cleanup to the regex grouping that I mentioned earlier, but that can be done separately. But that's the only reason I haven't queued this patch anyway.

Tue, Mar 10, 12:36 PM
pulkit added inline comments to D8270: run-tests: restrict Rust thread pool to 3 threads during tests.
Tue, Mar 10, 12:33 PM

Mar 9 2020

pulkit added a comment to D8248: debuginstall: print if Rust extensions are installed.

and the following too to make test-check-format.t happy.

Mar 9 2020, 5:54 AM
pulkit added a comment to D8248: debuginstall: print if Rust extensions are installed.

Amended the following to make test-check-module-imports.t happy.

Mar 9 2020, 5:46 AM
D8260: git: hide pygit2 imports from gendoc and other scripts not using demandimport now requires changes to proceed.

test-duplicateoptions.py is failing with this patch. I dropped this from my push list, stripping the patch was resulting in complex state for me, so I used prune, kindly use touch locally.

Mar 9 2020, 5:45 AM
D8162: hghave: add a `rust` keyword to detect the use of compiled rust code is now accepted and ready to land.
Mar 9 2020, 5:25 AM
D8180: nodemap: check that a simple lookup works fine is now accepted and ready to land.
Mar 9 2020, 5:24 AM
D8266: localrepo: add git extension to autoextensions list is now accepted and ready to land.
Mar 9 2020, 5:22 AM
D8259: discovery: avoid wrong detection of multiple branch heads (issue6256) is now accepted and ready to land.
Mar 9 2020, 5:18 AM
pulkit added a comment to D8172: notify: optional mail threading based on obsmarker.

The code looks good. Since the whole obsmarker thing is experimental, the config option here should be made experimental too.
Also, can you add tests when the config is set and --in-reply-to flag is used; and add info about that behavior in commit message?

Mar 9 2020, 5:13 AM
pulkit added a comment to D7922: rust-matchers: add function to generate a regex matcher function.

@martinvonz this (and next few patches) seems accepted by you and Augie. Should I go ahead and push it or I missed some discussion on IRC about it?

Mar 9 2020, 5:06 AM
D8264: gitlog: implement __iter__ on changelog is now accepted and ready to land.
Mar 9 2020, 5:02 AM
D8263: gitlog: fix embarassing bug that prevented log from showing correct parents is now accepted and ready to land.
Mar 9 2020, 5:02 AM
D8262: git: add readfast() method to manifest is now accepted and ready to land.

Looks like we should test the interfaces.

Mar 9 2020, 4:59 AM
pulkit added inline comments to D8261: git: hack around import checker being confused about the provenance of pygit2.
Mar 9 2020, 4:54 AM
D8260: git: hide pygit2 imports from gendoc and other scripts not using demandimport is now accepted and ready to land.
Mar 9 2020, 4:53 AM
D8246: hg-core: add a compilation error if trying to compile outside of Linux is now accepted and ready to land.
Mar 9 2020, 4:53 AM
D8248: debuginstall: print if Rust extensions are installed is now accepted and ready to land.
Mar 9 2020, 4:51 AM
D8254: nodemap: fix missing r-prefix on regular expression is now accepted and ready to land.
Mar 9 2020, 4:50 AM
D8256: git: make {shortest()} return shortest *unique* prefix is now accepted and ready to land.
Mar 9 2020, 4:50 AM

Mar 6 2020

D8173: nodemap: warm the persistent nodemap on disk with debugupdatecache is now accepted and ready to land.
Mar 6 2020, 3:03 AM
pulkit accepted D8236: copies-tests: update to null after setup for output stability.
Mar 6 2020, 2:59 AM
pulkit accepted D8235: copies-tests: remove extra log call at the end of the chain-merge test file.
Mar 6 2020, 2:59 AM
pulkit added inline comments to D8136: phabricator: add a `phabimport` command.
Mar 6 2020, 2:58 AM

Mar 5 2020

D8230: histedit: fix formatting after D8150 is now accepted and ready to land.
Mar 5 2020, 12:23 PM
D8231: commit: print debug message when clearing dirstate and wdir clean is now accepted and ready to land.
Mar 5 2020, 12:22 PM
pulkit added a comment to D8227: hgit: use type_str instead of type for checking type of git objects.

I should add some tests.

Mar 5 2020, 10:03 AM
pulkit updated the diff for D8227: hgit: use type_str instead of type for checking type of git objects.
Mar 5 2020, 9:44 AM
pulkit created D8227: hgit: use type_str instead of type for checking type of git objects.
Mar 5 2020, 9:39 AM
pulkit updated the diff for D8200: pull: add `--confirm` flag to confirm before writing changes.
Mar 5 2020, 4:12 AM