Page MenuHomePhabricator

pulkit (Pulkit Goyal)
Spy

Projects

User Details

User Since
Jun 28 2017, 8:54 PM (128 w, 1 d)

Recent Activity

Yesterday

pulkit added a comment to D7606: fuzz: fix mpatch_corpus to not have an overridden __repr__ on py3.

Amended following diff to make test-check-format.t happy:

Thu, Dec 12, 7:49 AM
pulkit added a comment to D7595: status: outputting structured unfinished-operation information.

Applying this on top of D7605 failed. So unfortunately you have to rebase again and resend. Also, I think you are pip install black away from preventing such conflicts.

Thu, Dec 12, 7:27 AM
D7595: status: outputting structured unfinished-operation information is now accepted and ready to land.
Thu, Dec 12, 7:24 AM
D7592: fuzz: add support for fuzzing under either Python 2 or 3 is now accepted and ready to land.
Thu, Dec 12, 7:22 AM
D7608: phabricator: color the status in the "phabstatus" view is now accepted and ready to land.
Thu, Dec 12, 7:20 AM
D7607: phabricator: add the "Changes Planned" status name is now accepted and ready to land.
Thu, Dec 12, 7:20 AM
D7606: fuzz: fix mpatch_corpus to not have an overridden __repr__ on py3 is now accepted and ready to land.
Thu, Dec 12, 7:19 AM
D7605: formatting: fix some recent formatting regressions is now accepted and ready to land.

Thanks for this. I installed black now, so I hope I will catch these next time before pushing changes.

Thu, Dec 12, 7:18 AM

Wed, Dec 11

pulkit added inline comments to D7601: fuzz: fix test-fuzz-targets.t to run with python3.
Wed, Dec 11, 10:33 AM
D7600: fuzz: add a seed corpus for the dirs fuzzer is now accepted and ready to land.
Wed, Dec 11, 6:07 AM
D7599: fuzz: clean up production of seed corpora is now accepted and ready to land.
Wed, Dec 11, 6:06 AM
D7506: phabricator: add a "phabstatus" show view is now accepted and ready to land.
Wed, Dec 11, 5:52 AM
D7597: dirs: fix out-of-bounds access in Py3 is now accepted and ready to land.
Wed, Dec 11, 5:51 AM
D7602: manifestcache: add some test involving shares is now accepted and ready to land.
Wed, Dec 11, 5:51 AM
D7601: fuzz: fix test-fuzz-targets.t to run with python3 is now accepted and ready to land.
Wed, Dec 11, 5:47 AM
D7598: py3: fix a bytes vs str issue in remotefilelog extension is now accepted and ready to land.
Wed, Dec 11, 5:46 AM

Tue, Dec 10

D7506: phabricator: add a "phabstatus" show view now requires changes to proceed.

test-check-module-imports.t says hi!

Tue, Dec 10, 10:57 AM
pulkit updated subscribers of D7593: status: split morestatus data loading from display.

I pushed @martinvonz D7591, so these need to be rebased. Thanks!

Tue, Dec 10, 10:55 AM
D7507: phabricator: add a "phabstatus" template keyword is now accepted and ready to land.
Tue, Dec 10, 10:48 AM
D7506: phabricator: add a "phabstatus" show view is now accepted and ready to land.
Tue, Dec 10, 10:46 AM
D7505: logcmdutil: call _exthook() in changesettemplater is now accepted and ready to land.
Tue, Dec 10, 10:45 AM
D7513: phabricator: fix processing of tags/desc in getoldnodedrevmap() is now accepted and ready to land.
Tue, Dec 10, 10:43 AM
D7596: tests: replace [[]] bashism with portable [] invocation is now accepted and ready to land.
Tue, Dec 10, 10:32 AM
pulkit added a comment to D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible.

This one fails to apply on default. Skipping pushing this and it's accepted children.

Tue, Dec 10, 10:16 AM
D7525: rust-matchers: improve `Matcher` trait ergonomics is now accepted and ready to land.
Tue, Dec 10, 10:13 AM
D7527: rust-matchers: add doctests for `AlwaysMatcher` is now accepted and ready to land.
Tue, Dec 10, 10:13 AM
D7526: rust-hg-path: add method to get part of a path relative to a prefix is now accepted and ready to land.
Tue, Dec 10, 10:12 AM
D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible is now accepted and ready to land.
Tue, Dec 10, 10:11 AM
D7523: rust-hg-path: implement `Display` for `HgPath` and `HgPathBuf` is now accepted and ready to land.
Tue, Dec 10, 10:09 AM
pulkit accepted D7116: rust-performance: introduce FastHashMap type alias for HashMap.
Tue, Dec 10, 10:08 AM
D7541: mail: use procutil.shellsplit instead of bytes.split to parse command is now accepted and ready to land.
Tue, Dec 10, 10:07 AM
D7557: annotate: describe --skip as taking a revset is now accepted and ready to land.
Tue, Dec 10, 10:06 AM
D7571: automation: use latest Windows AMI as base is now accepted and ready to land.
Tue, Dec 10, 10:05 AM
D7572: tests: stabilize test-extdiff.t on Windows is now accepted and ready to land.
Tue, Dec 10, 10:04 AM
D7583: exchange: fix an attempt to format a list into bytes is now accepted and ready to land.
Tue, Dec 10, 10:02 AM
D7591: status: remove pointless filtering by alwaysmatcher in morestatus is now accepted and ready to land.
Tue, Dec 10, 10:01 AM
D7579: tests: add test for Rust formatting is now accepted and ready to land.
Tue, Dec 10, 9:57 AM
D7578: rust: run rustfmt is now accepted and ready to land.
Tue, Dec 10, 9:56 AM
pulkit updated subscribers of D7595: status: outputting structured unfinished-operation information.
Tue, Dec 10, 8:19 AM
D7594: status: add template/json data about whether a file has unresolved conflicts is now accepted and ready to land.
Tue, Dec 10, 8:15 AM
D7593: status: split morestatus data loading from display is now accepted and ready to land.
Tue, Dec 10, 8:15 AM

Fri, Dec 6

pulkit added a comment to D7557: annotate: describe --skip as taking a revset.

Isn't it that where ever we says revisions we imply revsets?

Fri, Dec 6, 1:10 PM
pulkit added a comment to D7521: amend: check for file modifications when updating dirstate (issue6233).

Looks like I forgot to drop this from my queue and pushed it. :(

Fri, Dec 6, 1:05 PM
pulkit added a comment to D7556: tests: remove hardcoded errno values.

This is for stable branch or default?

Fri, Dec 6, 9:58 AM
D7556: tests: remove hardcoded errno values is now accepted and ready to land.
Fri, Dec 6, 9:57 AM
pulkit added a comment to D7521: amend: check for file modifications when updating dirstate (issue6233).

I get the following test failure:

Fri, Dec 6, 9:55 AM
D7554: tests: expect return status 255 on exception for test-blackbox.t with chg is now accepted and ready to land.
Fri, Dec 6, 9:02 AM
D7553: tests: fix command name in test-blackbox.t to be bytes is now accepted and ready to land.
Fri, Dec 6, 9:02 AM
D7552: tests: fix deprecation warning about regex flags not at beginning of expr is now accepted and ready to land.
Fri, Dec 6, 9:01 AM
D7551: tests: fix test-chg.t to work with py3 (no setprocname) is now accepted and ready to land.
Fri, Dec 6, 9:01 AM
D7521: amend: check for file modifications when updating dirstate (issue6233) is now accepted and ready to land.
Fri, Dec 6, 9:00 AM
D7549: graft: never set both parents equal in the dirstate (issue6098) is now accepted and ready to land.
Fri, Dec 6, 8:59 AM
D7548: graft: extract `repo['.']` to local variable is now accepted and ready to land.
Fri, Dec 6, 8:58 AM
D7547: graft: rename `pctx` argument to `base` since that's what it is is now accepted and ready to land.
Fri, Dec 6, 8:57 AM
D7546: exchange: replace a "not x in ys" by more Pythonic "x not in ys" is now accepted and ready to land.
Fri, Dec 6, 8:56 AM

Mon, Dec 2

D7532: windows: fix an issue causing registry config paths to be ignored on py3 is now accepted and ready to land.
Mon, Dec 2, 10:10 AM
D7539: cleanup: fix docstring formatting is now accepted and ready to land.
Mon, Dec 2, 10:10 AM
D7538: pvec: fix a `str` type conditional for py3 is now accepted and ready to land.
Mon, Dec 2, 10:07 AM
D7540: tests: cover revision conversion logic in githelp tests is now accepted and ready to land.
Mon, Dec 2, 10:07 AM
D7537: githelp: fix a `str` type conditional for py3 is now accepted and ready to land.
Mon, Dec 2, 10:07 AM
D7536: histedit: fix an `isinstance(nodelist, str)` check for py3 is now accepted and ready to land.
Mon, Dec 2, 10:06 AM
D7535: win32mbcs: fix a `str` type conditional for py3 is now accepted and ready to land.
Mon, Dec 2, 10:06 AM
D7534: hgweb: fix a few `str` type conditional for py3 is now accepted and ready to land.
Mon, Dec 2, 10:06 AM
D7533: repair: fix an `isinstance(nodelist, str)` check for py3 is now accepted and ready to land.
Mon, Dec 2, 10:05 AM

Tue, Nov 26

D7459: lock: pass "success" boolean to _afterlock callbacks is now accepted and ready to land.
Tue, Nov 26, 9:21 AM
D7520: dateutil: correct default for Ymd in parsedate is now accepted and ready to land.
Tue, Nov 26, 9:18 AM
D7519: test-doctest: include dateutil is now accepted and ready to land.
Tue, Nov 26, 9:17 AM
D7518: revlog: fix revset in reachableroots docstring is now accepted and ready to land.
Tue, Nov 26, 9:17 AM

Mon, Nov 25

D7508: relnotes: add note about changes to match.{explicit,reverse}dir is now accepted and ready to land.
Mon, Nov 25, 10:29 AM

Thu, Nov 21

pulkit added a comment to D7462: py3: make doc strings containing the deprected '\.' escape sequence raw strings.

Applied the following diff to commit message as test-check-commit.t was complaining:

Thu, Nov 21, 8:37 AM
D7463: wireprotov1server: capture Abort type before accessing the `hint` attribute is now accepted and ready to land.
Thu, Nov 21, 7:39 AM
D7461: py3: wrap a __func__ in sysbytes() before logging as bytes is now accepted and ready to land.
Thu, Nov 21, 7:38 AM
D7462: py3: make doc strings containing the deprected '\.' escape sequence raw strings is now accepted and ready to land.
Thu, Nov 21, 7:38 AM
D7460: tests: add more tests for "hg shelve --delete" is now accepted and ready to land.
Thu, Nov 21, 7:36 AM
D7458: shelve: add the missing `create` parameter to the bundlerepo constructor is now accepted and ready to land.
Thu, Nov 21, 7:30 AM
D7457: shelve: fix a missing variable in the exception handler for delete is now accepted and ready to land.
Thu, Nov 21, 7:29 AM
pulkit accepted D7456: scmutil: add assertions to help pytype.
Thu, Nov 21, 7:29 AM
pulkit accepted D7455: revset: add an assertion to help pytype.
Thu, Nov 21, 7:29 AM

Tue, Nov 19

D7441: match: remove explicitdir attribute is now accepted and ready to land.

Queued the series, many thanks! Thanks @Alphare for reviewing :)

Tue, Nov 19, 7:43 AM
D7440: dirstate: stop caring about match.explicitdir is now accepted and ready to land.
Tue, Nov 19, 7:42 AM
D7439: dirstate: include explicit matches in match.traversedir calls is now accepted and ready to land.
Tue, Nov 19, 7:42 AM
D7438: commit: drop unused "vdirs" argument from repo.checkcommitpatterns() is now accepted and ready to land.
Tue, Nov 19, 7:41 AM
D7437: commit: rewrite check for `hg ci <path>` being a directory is now accepted and ready to land.
Tue, Nov 19, 7:41 AM

Mon, Nov 18

D7432: templates: make {indent("", " ")} be empty is now accepted and ready to land.
Mon, Nov 18, 11:15 AM
D7446: black: blacken scripts is now accepted and ready to land.
Mon, Nov 18, 11:14 AM
D7447: tests: verify that Python scripts are blackened is now accepted and ready to land.
Mon, Nov 18, 11:14 AM
D7448: tests: check for Windows line endings is now accepted and ready to land.
Mon, Nov 18, 11:13 AM
D7445: doc: don't use mutable default arguments is now accepted and ready to land.
Mon, Nov 18, 11:12 AM

Fri, Nov 15

D7431: tests: document behavior of indent() with empty first line is now accepted and ready to land.
Fri, Nov 15, 6:23 PM
D7429: py3: use '%d' for formatting a revnum in `hg co --date` code is now accepted and ready to land.
Fri, Nov 15, 6:23 PM
D7428: tags: don't check for clean files when checking for dirty working copy is now accepted and ready to land.
Fri, Nov 15, 6:22 PM
D7427: branchmap: make "closed" a set from beginning instead of converting from list is now accepted and ready to land.
Fri, Nov 15, 6:22 PM

Thu, Nov 14

D7379: encoding: fix bad type annotation is now accepted and ready to land.
Thu, Nov 14, 10:28 AM
D7378: debugcommands: don't shadow the error module is now accepted and ready to land.
Thu, Nov 14, 10:27 AM

Wed, Nov 13

D7371: tests: add optional output when wheel is missing is now accepted and ready to land.
Wed, Nov 13, 8:17 AM
pulkit updated subscribers of D7198: lock: refactor in preparation for next commit.

@marmoute can you have a look at these two patches?

Wed, Nov 13, 8:17 AM
D7150: dirstate: respect request to not list unknown/ignored/clean files (API) is now accepted and ready to land.
Wed, Nov 13, 8:16 AM
D7373: py3: pass a bytes value for "msg" to nouideprecwarn() is now accepted and ready to land.
Wed, Nov 13, 8:11 AM
D7372: remotefilelog: handle **kwargs correctly when overriding changelog.add() is now accepted and ready to land.
Wed, Nov 13, 8:10 AM

Nov 11 2019

pulkit abandoned D2259: py3: use pycompat.bytestr to convert int/bytes to bytes.
Nov 11 2019, 7:49 AM