Page MenuHomePhabricator

pulkit (Pulkit Goyal)
Spy

Projects

User Details

User Since
Jun 28 2017, 8:54 PM (192 w, 4 d)

Recent Activity

Today

pulkit closed D9994: error: remove shortening of node in error message.
Mon, Mar 8, 3:28 PM
pulkit closed D10015: debugtagscache: verify that filenode is correct.
Mon, Mar 8, 3:28 PM
pulkit closed D10014: debugcommands: prevent using `is False`.
Mon, Mar 8, 3:27 PM
pulkit committed rHG39be29fafd91: commit: reorder if-else conditional to give mergestate info priority.
commit: reorder if-else conditional to give mergestate info priority
Mon, Mar 8, 3:27 PM
pulkit closed D10116: commit: reorder if-else conditional to give mergestate info priority.
Mon, Mar 8, 3:27 PM
pulkit committed rHG9a31f65381ae: tags: validate nodes in _getfnodes() and update cache in case of unknown nodes.
tags: validate nodes in _getfnodes() and update cache in case of unknown nodes
Mon, Mar 8, 3:26 PM
pulkit closed D10083: tags: validate nodes in _getfnodes() and update cache in case of unknown nodes.
Mon, Mar 8, 3:26 PM
pulkit committed rHGe4e971abb6a3: debugtagscache: verify that filenode is correct.
debugtagscache: verify that filenode is correct
Mon, Mar 8, 3:26 PM
pulkit committed rHG9306a16ca964: debugcommands: prevent using `is False`.
debugcommands: prevent using `is False`
Mon, Mar 8, 3:26 PM
pulkit closed D10013: hgtagsfnodes: refactor code to compute fnode into separate fn.
Mon, Mar 8, 3:26 PM
pulkit committed rHG75832107ec07: hgtagsfnodes: refactor code to compute fnode into separate fn.
hgtagsfnodes: refactor code to compute fnode into separate fn
Mon, Mar 8, 3:25 PM
pulkit committed rHG6fc57680cfd6: error: remove shortening of node in error message.
error: remove shortening of node in error message
Mon, Mar 8, 3:25 PM

Sat, Mar 6

D10121: releasenotes: use the right API to access the 'sections' is now accepted and ready to land.
Sat, Mar 6, 9:56 AM

Fri, Mar 5

pulkit created D10116: commit: reorder if-else conditional to give mergestate info priority.
Fri, Mar 5, 12:30 PM
D10107: requirements: also add a dotencode constant is now accepted and ready to land.
Fri, Mar 5, 3:52 AM
pulkit accepted D10104: pure-parsers: document index class constants.
Fri, Mar 5, 3:37 AM
D10115: copies: choose target directory based on longest match is now accepted and ready to land.
Fri, Mar 5, 3:34 AM

Thu, Mar 4

D9927: config: use level to properly deal with value priority is now accepted and ready to land.
Thu, Mar 4, 6:27 AM
D9926: config: track the "level" of a value is now accepted and ready to land.
Thu, Mar 4, 6:27 AM
D9925: config: track "source" along side value is now accepted and ready to land.
Thu, Mar 4, 6:26 AM
D9924: config: use a new `alter` method in `fixconfig` is now accepted and ready to land.
Thu, Mar 4, 6:25 AM
pulkit added a comment to D10092: rhg: Change default `rhg.on-unsupported` configuration to `abort`.

This one can be folded in the previous patch.

Thu, Mar 4, 4:09 AM
D10103: relnotes: document a number of node->revision type changes is now accepted and ready to land.
Thu, Mar 4, 4:04 AM
D10109: requirements: also add a fncache constant is now accepted and ready to land.
Thu, Mar 4, 4:02 AM
D10108: requirements: also add a store constant is now accepted and ready to land.
Thu, Mar 4, 4:02 AM
D10107: requirements: also add a dotencode constant now requires changes to proceed.
Thu, Mar 4, 4:01 AM
D10106: requirements: also add a generaldelta constant is now accepted and ready to land.
Thu, Mar 4, 4:00 AM
D10105: requirements: add constant for revlog v1 requirement is now accepted and ready to land.
Thu, Mar 4, 3:59 AM
D10024: error: add `hint` attribute to `SidedataHashError` is now accepted and ready to land.
Thu, Mar 4, 3:58 AM
D10023: changegroup: use the local variable instead of reaching through self is now accepted and ready to land.
Thu, Mar 4, 3:58 AM
D10104: pure-parsers: document index class constants is now accepted and ready to land.
Thu, Mar 4, 3:57 AM

Tue, Mar 2

pulkit updated the diff for D10083: tags: validate nodes in _getfnodes() and update cache in case of unknown nodes.
Tue, Mar 2, 9:25 AM
D10079: patch: fix a formatting issue is now accepted and ready to land.
Tue, Mar 2, 8:03 AM
D10085: copies-rust: remove an unnecessary format!() inside assert!() is now accepted and ready to land.
Tue, Mar 2, 4:02 AM
D10086: dispatch: use detailed exit code 250 for keyboard interrupt is now accepted and ready to land.
Tue, Mar 2, 4:02 AM
D10084: copies: tests and fix parallel computation of changed file information is now accepted and ready to land.
Tue, Mar 2, 4:01 AM

Mon, Mar 1

pulkit added a comment to D10017: tags: return set of invalid nodes from _tagsfromfnodes().

I am looking at this more, and I don't think we are addressing the issue at the right location.
Here you deal with error while trying to process the data pointed by the tags fnodes and you don't have the necessary information to react well when that fnode is bad.
We should treat this error earlier (maybe in _filterfnodes, or right before it?). At that point I think we could validate that all the fnode we have are correct / or corrected before starting to process them. In such context maybe we could even write down the fnode cache before proceeding further (if it make sense transactionwise).

Mon, Mar 1, 1:56 PM
pulkit planned changes to D10018: tags: update the hgtagsfnodes cache if invalid file nodes are found.
Mon, Mar 1, 1:55 PM
pulkit added a comment to D10018: tags: update the hgtagsfnodes cache if invalid file nodes are found.

Superseeded by D10083.

Mon, Mar 1, 1:54 PM
pulkit added a comment to D10017: tags: return set of invalid nodes from _tagsfromfnodes().

Superseeded by D10083.

Mon, Mar 1, 1:54 PM
pulkit added a comment to D10016: tags: return tag cache source from _readtagcache().

Superseeded by D10083.

Mon, Mar 1, 1:53 PM
pulkit updated the summary of D10015: debugtagscache: verify that filenode is correct.
Mon, Mar 1, 1:47 PM
pulkit created D10083: tags: validate nodes in _getfnodes() and update cache in case of unknown nodes.
Mon, Mar 1, 1:47 PM

Sat, Feb 27

D9920: config: test priority involving alias and cli is now accepted and ready to land.
Sat, Feb 27, 12:29 PM
D9919: config: test priority involving alias and include is now accepted and ready to land.
Sat, Feb 27, 12:29 PM
pulkit added a comment to D9918: config: test priority involving alias.

Thanks for adding detailed comments.

Sat, Feb 27, 12:28 PM
D10066: fuzz: if the caller of our makefile sets CC and CXX, trust them is now accepted and ready to land.
Sat, Feb 27, 12:19 PM
D10065: tests: correct a commit description in test-copies-chain-merge.t is now accepted and ready to land.
Sat, Feb 27, 12:19 PM
D10070: copies-rust: pass closures and iterators instead of `&ChangedFiles` is now accepted and ready to land.
Sat, Feb 27, 12:18 PM
D10069: copies-rust: pass `PathToken` around by value is now accepted and ready to land.
Sat, Feb 27, 12:17 PM
pulkit added inline comments to D10077: rhg: Don’t attempt to read persistent nodemap without .hg/requires opt-in.
Sat, Feb 27, 12:11 PM
D10076: rhg: Check .hg/requires for absence of required features is now accepted and ready to land.
Sat, Feb 27, 12:10 PM
D10078: rhg: Bug fix: with share-safe, always read store requirements is now accepted and ready to land.
Sat, Feb 27, 12:09 PM

Wed, Feb 24

pulkit closed D9992: upgrade: speed up when we have only nodemap to downgrade.
Wed, Feb 24, 10:54 AM
pulkit committed rHG67b5fafd3a46: upgrade: speed up when we have only nodemap to downgrade.
upgrade: speed up when we have only nodemap to downgrade
Wed, Feb 24, 10:54 AM
pulkit closed D9991: upgrade: write nodemap for manifests too.
Wed, Feb 24, 10:54 AM
pulkit committed rHG636853347e14: upgrade: write nodemap for manifests too.
upgrade: write nodemap for manifests too
Wed, Feb 24, 10:54 AM

Mon, Feb 22

pulkit added a comment to D9994: error: remove shortening of node in error message.

Ping for review on the series.

Mon, Feb 22, 5:24 AM
pulkit added a comment to D9991: upgrade: write nodemap for manifests too.

Ping for review.

Mon, Feb 22, 5:23 AM

Thu, Feb 18

pulkit added a comment to D10019: configitems: register an experimental evolve config.

IIUC, this affects the behavior of evolve command right? If yes, then it should go to evolve extension.

Thu, Feb 18, 2:52 PM

Wed, Feb 17

pulkit added a comment to D9812: tests: demonstrate a case where a corrupt tag cache causes an abort.

Hm, we should probably rebuild the cache or try use the slow path without the cache.
The previous and this patch are of interest to me since I am trying to fix a similar error message related to tags.

@joerg.sonnenberger mentioned that he was going to rewrite the tag cache stuff, and I'm swamped in the short term with other things. So if you want to take this over and do what you need, feel free so that you aren't waiting for me to find the time to get back to this.

Wed, Feb 17, 3:02 PM
pulkit created D10015: debugtagscache: verify that filenode is correct.
Wed, Feb 17, 2:44 PM
pulkit created D10018: tags: update the hgtagsfnodes cache if invalid file nodes are found.
Wed, Feb 17, 2:44 PM
pulkit created D10014: debugcommands: prevent using `is False`.
Wed, Feb 17, 2:44 PM
pulkit created D10017: tags: return set of invalid nodes from _tagsfromfnodes().
Wed, Feb 17, 2:44 PM
pulkit created D10016: tags: return tag cache source from _readtagcache().
Wed, Feb 17, 2:44 PM
pulkit updated the diff for D9812: tests: demonstrate a case where a corrupt tag cache causes an abort.
Wed, Feb 17, 2:44 PM
pulkit created D10013: hgtagsfnodes: refactor code to compute fnode into separate fn.
Wed, Feb 17, 2:43 PM

Tue, Feb 16

pulkit added a comment to D10000: tests: add a test to demonstrate a bug in `hg diff --git` (issue6486).

I just phabsend after rebasing to stable but here in Phabricator UI, I still see the default branch. What's wrong? Is it just the UI issue?

Tue, Feb 16, 7:02 AM
pulkit added a comment to D10000: tests: add a test to demonstrate a bug in `hg diff --git` (issue6486).

Nice differential number. Can you rebase these and send for stable branch instead?

Tue, Feb 16, 6:42 AM
pulkit updated the summary of D9994: error: remove shortening of node in error message.
Tue, Feb 16, 2:52 AM

Mon, Feb 15

pulkit created D9994: error: remove shortening of node in error message.
Mon, Feb 15, 7:20 AM
pulkit created D9992: upgrade: speed up when we have only nodemap to downgrade.
Mon, Feb 15, 5:29 AM
pulkit created D9991: upgrade: write nodemap for manifests too.
Mon, Feb 15, 5:28 AM

Sun, Feb 14

D9983: packaging: add Provides: python3-mercurial and Homepage to debian package is now accepted and ready to land.
Sun, Feb 14, 10:19 AM
D9986: bundle2: pass the operation source down to the changegroup is now accepted and ready to land.
Sun, Feb 14, 10:17 AM
D9990: gendoc: use an empty comment so aliases are separated from previous elements is now accepted and ready to land.
Sun, Feb 14, 10:17 AM
D9989: gendoc: add support for loading extensions from config settings is now accepted and ready to land.
Sun, Feb 14, 10:16 AM
D9988: gendoc: support defaults on customopts a bit better is now accepted and ready to land.
Sun, Feb 14, 10:15 AM
D9985: softstrip: fix a reference to an undefined variable is now accepted and ready to land.
Sun, Feb 14, 10:14 AM
D9984: softstrip: move _bookmarkmovements() call to where it's needed is now accepted and ready to land.
Sun, Feb 14, 10:12 AM

Wed, Feb 10

D9958: log: respect diff.merge in -p output is now accepted and ready to land.
Wed, Feb 10, 7:22 AM
D9957: diff: extract function for getting possibly re-merged parent to diff against is now accepted and ready to land.
Wed, Feb 10, 7:21 AM
pulkit accepted D9956: diff: replace --merge option by config option.
Wed, Feb 10, 7:21 AM
D9945: debugdiscovery: add flags to run discovery on subsets of the local repo is now accepted and ready to land.
Wed, Feb 10, 7:20 AM
D9966: rust: Use the DisplayBytes trait in config printing is now accepted and ready to land.
Wed, Feb 10, 7:16 AM
D9964: rhg: Parse per-repository configuration is now accepted and ready to land.
Wed, Feb 10, 7:14 AM
D9963: rhg: Abort based on config on share-safe mismatch is now accepted and ready to land.
Wed, Feb 10, 7:13 AM
D9962: rhg: Parse system and user configuration at program start is now accepted and ready to land.
Wed, Feb 10, 7:12 AM
D9961: rust: Parse system and user configuration is now accepted and ready to land.
Wed, Feb 10, 7:11 AM
pulkit added inline comments to D9951: narrow: add --no-backup option for narrowing.
Wed, Feb 10, 7:09 AM
D9951: narrow: add --no-backup option for narrowing is now accepted and ready to land.
Wed, Feb 10, 7:08 AM
D9954: bundle2: print "error:abort" message to stderr instead of stdout is now accepted and ready to land.
Wed, Feb 10, 7:06 AM
D9946: copy-tracing: add a --compute flag to debugchangedfiles is now accepted and ready to land.
Wed, Feb 10, 7:06 AM
D9960: rust: Remove unnecessary check for absolute path before joining is now accepted and ready to land.
Wed, Feb 10, 7:05 AM
D9959: rust: replace read_whole_file with std::fs::read is now accepted and ready to land.
Wed, Feb 10, 7:04 AM
D9973: wireprotopeer: clarify some variable names now that we allow snake_case is now accepted and ready to land.
Wed, Feb 10, 7:04 AM
pulkit added a comment to D9812: tests: demonstrate a case where a corrupt tag cache causes an abort.

Hm, we should probably rebuild the cache or try use the slow path without the cache.

Wed, Feb 10, 7:02 AM

Feb 6 2021

pulkit added inline comments to D9770: upgrade: don't create store backup if `--no-backup` is passed.
Feb 6 2021, 2:26 PM

Feb 3 2021

pulkit added a comment to D9725: ci: generate and report XML test results.

I am happy to push this and next one but they needs to be rebased on current tip of default branch.

Feb 3 2021, 4:01 AM