Page MenuHomePhabricator

pulkit (Pulkit Goyal)
Spy

Projects

User Details

User Since
Jun 28 2017, 8:54 PM (116 w, 2 d)

Recent Activity

Thu, Sep 19

D6871: wireprototypes: clarify documentation of getbundle argument types is now accepted and ready to land.
Thu, Sep 19, 7:20 AM

Wed, Sep 18

D6864: py3: don't double-convert "opts" to bytes is now accepted and ready to land.
Wed, Sep 18, 7:48 AM

Tue, Sep 17

D6862: tests: clean up built binaries after running test-fuzz-targets.t is now accepted and ready to land.
Tue, Sep 17, 3:34 PM
D6861: fastannotate: remove support for flock() locking is now accepted and ready to land.
Tue, Sep 17, 3:34 PM
D6860: remotefilelog: remove dead code for using flock() for locking is now accepted and ready to land.
Tue, Sep 17, 3:33 PM
D6848: narrow: add option for automatically removing unused includes is now accepted and ready to land.
Tue, Sep 17, 3:33 PM
pulkit added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 2:14 PM
pulkit added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:50 PM
D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC) is now accepted and ready to land.

Just tracked --add-include. A workaround to simplify the upgrade would be to change wireprototypes.SUPPORTED_ELLIPSESCAP to be (ELLIPSESCAP1, ) on the server from now until all clients have upgraded. But that may still be annoying and error-prone for you to deal with. @pulkit, I suppose we should just add a exp-narrow-2 capability to deal with this? It doesn't seem fair to make @idlsoft deal with it.

Sounds like a good idea!

If it's just tracked --add-include then it's not a big deal, it won't disrupt regular flow.
If backward compatibility doesn't complicate the code - great, if not - don't worry about it.

Tue, Sep 17, 1:45 PM
pulkit added inline comments to D6848: narrow: add option for automatically removing unused includes.
Tue, Sep 17, 1:44 PM
pulkit added a comment to D6709: config: add --registered flag to show all known configs.
In D6709#100698, @av6 wrote:

And to make the review process easier, I propose doing this in 3 or 4 patches:

  • adding --registered: will simply show all registered options in key=value format
  • adding defaults and experimental/devel/debug statuses to showconfig --debug output (this one can be split into two)
  • showing config options in a human-friendly format
Tue, Sep 17, 7:54 AM

Mon, Sep 16

pulkit added a comment to D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

@idlsoft and their company does use narrow extension. @idlsoft can you upgrade server and client at the same time?

I did that a little while ago to move to 5.0. It was not fun. It's server, teamcity, clients, docker images.
What operations does this affect? Regular push/pull/clone or only tracked --add-include?

Just tracked --add-include. A workaround to simplify the upgrade would be to change wireprototypes.SUPPORTED_ELLIPSESCAP to be (ELLIPSESCAP1, ) on the server from now until all clients have upgraded. But that may still be annoying and error-prone for you to deal with. @pulkit, I suppose we should just add a exp-narrow-2 capability to deal with this? It doesn't seem fair to make @idlsoft deal with it.

Mon, Sep 16, 1:47 PM
D6852: tests: stabilize test-fix.t on Windows is now accepted and ready to land.
Mon, Sep 16, 1:11 PM
D6858: zstandard: vendor python-zstandard 0.12 is now accepted and ready to land.
Mon, Sep 16, 1:09 PM
pulkit updated subscribers of D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC).

This is clearly a breaking change, but the feature is experimental and
we're not aware of anyone running a server using this command yet.

Mon, Sep 16, 1:05 PM
D6857: uncommit: enable support for adding a note is now accepted and ready to land.

Should these note options (including on amend) be marked advanced to keep the
help text clutter level down?

Mon, Sep 16, 1:02 PM
D6856: amend: enable support for using the secret phase is now accepted and ready to land.
Mon, Sep 16, 1:01 PM
D6855: amend: enable support for closing the branch is now accepted and ready to land.
Mon, Sep 16, 1:00 PM
D6854: amend: prevent '\n' in the note string is now accepted and ready to land.
Mon, Sep 16, 1:00 PM
D6853: amend: add option to update to the current user is now accepted and ready to land.
Mon, Sep 16, 12:59 PM

Sat, Sep 14

D6849: tests: move a config write to top of file since it applies to all tests is now accepted and ready to land.
Sat, Sep 14, 11:12 AM
pulkit accepted D6839: idirstate: group private methods and attrs that are in the interface.
Sat, Sep 14, 11:11 AM
pulkit accepted D6838: idirstate: remove now non-public _map attribute.
Sat, Sep 14, 11:11 AM
pulkit accepted D6836: interfaces: introduce an interface for dirstate implementations.
Sat, Sep 14, 11:11 AM

Thu, Sep 12

pulkit added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

I agree with @valentin.gatienbaron that --force is quite generic :(. It may create new heads on the server even if I don't want to.

Thu, Sep 12, 2:06 AM
pulkit added a comment to D4664: mergecommit: add a new extension to merge in-memory and create a commit.

Neat. I assume you normally check these out later?

Thu, Sep 12, 1:56 AM
pulkit accepted D6837: cleanup: fix leakage of dirstate._map to client code.
Thu, Sep 12, 1:55 AM
pulkit added inline comments to D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files.
Thu, Sep 12, 1:47 AM
pulkit added inline comments to D6736: shelve: add method for storing mergestate in changeset extras.
Thu, Sep 12, 1:46 AM

Wed, Sep 11

D6832: highlight: fix encoding issues to enable Py3 compatibility is now accepted and ready to land.
Wed, Sep 11, 2:28 AM
D6840: hgweb: add a `message` attribute to `hgweb.common.ErrorResponse` is now accepted and ready to land.
Wed, Sep 11, 2:26 AM
D6842: uncommit: make -D/--date and -U/--user mutually exclusive is now accepted and ready to land.
Wed, Sep 11, 2:25 AM
D6841: uncommit: drop the hyphen from --current-user and --current-date is now accepted and ready to land.
Wed, Sep 11, 2:24 AM

Mon, Sep 9

pulkit added a comment to D6828: uncommit: add options to update to the current user or current date.

I guess --interactive is the only flag left which is extra in evolve version, right?

No:

-a --all                 uncommit all changes when no arguments given
-i --interactive         interactive mode to uncommit (EXPERIMENTAL)
-r --rev REV             revert commit content to REV instead
   --revert              discard working directory changes after uncommit
-n --note TEXT           store a note on uncommit

I'd like to port --interactive.

Mon, Sep 9, 1:05 PM
D6829: doc: fix up confusing doc comment is now accepted and ready to land.
Mon, Sep 9, 11:24 AM
D6827: uncommit: add support to modify the commit message and date is now accepted and ready to land.
Mon, Sep 9, 11:23 AM
D6828: uncommit: add options to update to the current user or current date is now accepted and ready to land.

I guess --interactive is the only flag left which is extra in evolve version, right?

Mon, Sep 9, 11:23 AM
D6795: strip: fix bug with treemanifests and unordered linkrevs is now accepted and ready to land.
Mon, Sep 9, 11:20 AM
D6794: repair: extract a helper for generating all manifest revlogs is now accepted and ready to land.
Mon, Sep 9, 11:20 AM
D6793: tests: show broken strip with treemanifests and unordered linkrevs is now accepted and ready to land.
Mon, Sep 9, 11:18 AM
D6792: tests: split out manifest case from test-strip-cross.t is now accepted and ready to land.
Mon, Sep 9, 11:18 AM
D6791: tests: don't log manifest-file in test-strip-cross.t is now accepted and ready to land.
Mon, Sep 9, 11:17 AM
D6786: automation: implement "publish-windows-artifacts" command is now accepted and ready to land.
Mon, Sep 9, 11:16 AM
D6785: automation: upgrade to latest packages in requirements.txt is now accepted and ready to land.
Mon, Sep 9, 11:16 AM
pulkit accepted D6732: localrepo: push manifestlog and changelog construction code into store.
Mon, Sep 9, 11:15 AM

Sat, Sep 7

D6790: tests: use positive revision numbers in test-strip-cross.t is now accepted and ready to land.
Sat, Sep 7, 12:22 PM
pulkit added a comment to D6825: contrib: start building a library for simple hooks.

Thanks a lot for putting efforts here. I am +1 on this. I haven't looked at the code though, will try to review if no one else beats me to it.

Sat, Sep 7, 12:21 PM

Thu, Sep 5

pulkit closed D6757: bdiff-torture: fix pyflakes warning reporting undefined name 'inst'.
Thu, Sep 5, 2:57 PM
pulkit committed rHG3316e59b0105: bdiff-torture: fix pyflakes warning reporting undefined name 'inst'.
bdiff-torture: fix pyflakes warning reporting undefined name 'inst'
Thu, Sep 5, 2:57 PM

Sat, Aug 31

D6777: py3: make statprof's chrome output work is now accepted and ready to land.
Sat, Aug 31, 2:00 PM
D6781: py3: for statprof's Chrome output, write json to string, then encode to bytes is now accepted and ready to land.
Sat, Aug 31, 1:59 PM
D6780: statprof: use context manager for file when writing flame graph is now accepted and ready to land.
Sat, Aug 31, 1:58 PM
D6779: statprof: use context manager when reading source from file is now accepted and ready to land.
Sat, Aug 31, 1:57 PM
D6778: statprof: clarify by naming tuple members while enumerate()'ing is now accepted and ready to land.
Sat, Aug 31, 1:56 PM
D6775: py3: convert hg executable path to bytes in missing case in procutil is now accepted and ready to land.
Sat, Aug 31, 1:55 PM

Thu, Aug 29

D6771: py3: use pycompat.maplist() in chgserver is now accepted and ready to land.
Thu, Aug 29, 3:32 AM

Tue, Aug 27

D6760: run-tests: handle --local before --with-hg is now accepted and ready to land.
Tue, Aug 27, 3:57 PM
D6759: run-tests: error out on `--local --with-[c]hg` is now accepted and ready to land.
Tue, Aug 27, 3:57 PM

Sun, Aug 25

pulkit closed D6741: interfaces: create a new folder for interfaces and move repository.py in it.
Sun, Aug 25, 12:12 PM
pulkit closed D6742: interfaceutil: move to interfaces/.
Sun, Aug 25, 12:10 PM
pulkit committed rHG268662aac075: interfaces: create a new folder for interfaces and move repository.py in it.
interfaces: create a new folder for interfaces and move repository.py in it
Sun, Aug 25, 12:09 PM
pulkit committed rHG2c4f656c8e9f: interfaceutil: move to interfaces/.
interfaceutil: move to interfaces/
Sun, Aug 25, 12:09 PM
pulkit added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).

Queued the patches for stable, many thanks!

Sun, Aug 25, 11:02 AM
D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159) is now accepted and ready to land.
Sun, Aug 25, 10:57 AM
pulkit added inline comments to D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files.
Sun, Aug 25, 10:25 AM

Fri, Aug 23

pulkit added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).

Looks like you forgot to update tests.

Fri, Aug 23, 7:09 PM
D6740: tests: add test to demonstrate issue6159 is now accepted and ready to land.
Fri, Aug 23, 7:08 PM
D6758: narrow: fix typo "respositories" is now accepted and ready to land.
Fri, Aug 23, 6:14 PM

Aug 22 2019

pulkit created D6757: bdiff-torture: fix pyflakes warning reporting undefined name 'inst'.
Aug 22 2019, 1:55 PM
D6755: merge: hint about using `hg resolve` for resolving conflicts is now accepted and ready to land.
Aug 22 2019, 1:21 PM

Aug 20 2019

pulkit added a comment to D6718: repository: suppress typing errors on functions without arguments.

I tried to queue but test-check-code.t and test-check-commit.t fails.

Aug 20 2019, 12:19 PM
pulkit added a comment to D6746: perf: don't pass experimental argument in config for older Mercurial versions.

Folded https://www.mercurial-scm.org/repo/hg-committed/rev/9f2189b6bf2a. This can be closed now. Thanks for the quick fix.

Aug 20 2019, 12:03 PM
D6746: perf: don't pass experimental argument in config for older Mercurial versions is now accepted and ready to land.
Aug 20 2019, 11:38 AM
pulkit added a comment to D6746: perf: don't pass experimental argument in config for older Mercurial versions.

When this patch is ready, could we fold this into a11fd395e83f? I have extensions.perf=contrib/perf.py in my config and it's pretty annoying to have any commit in the broken range checked out.

Aug 20 2019, 11:38 AM
D6745: perf: don't depend on pycompat for older Mercurial versions is now accepted and ready to land.
Aug 20 2019, 11:08 AM
D6744: perf: don't try to call `util.queue` on Mercurial version before it existed is now accepted and ready to land.
Aug 20 2019, 11:07 AM
D6743: perf: handle NameError for `pycompat.foo` when pycompat wasn't imported is now accepted and ready to land.
Aug 20 2019, 11:06 AM
pulkit added a comment to D6741: interfaces: create a new folder for interfaces and move repository.py in it.

I was trying to understand current interfaces and write new ones and I realized
we need to improve how current interfaces are organised.

And what was the reason we need to improve it? I assume we don't really "need" to change it. Will it somehow help with future patches? Or you just like this structure better?

Aug 20 2019, 11:04 AM
pulkit created D6748: hgit: define invalidatecaches for gitstore().
Aug 20 2019, 11:01 AM
pulkit created D6747: hgit: fix some pyflakes and check-code warning.
Aug 20 2019, 11:01 AM
pulkit added inline comments to D6746: perf: don't pass experimental argument in config for older Mercurial versions.
Aug 20 2019, 10:34 AM
pulkit added inline comments to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 20 2019, 9:42 AM
pulkit added inline comments to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).
Aug 20 2019, 8:45 AM

Aug 19 2019

pulkit added a comment to D6735: update: added support for --abort flag(issue4404).

Nice start! If I remember correctly, the mergestate stores the local version of the file. We can use that directly instead.

Aug 19 2019, 11:27 AM
pulkit added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).

Can you also add a test where we are pushing multiple heads/bookmarks and one of the bookmark is problematic?

Aug 19 2019, 11:23 AM
pulkit added inline comments to D6740: tests: add test to demonstrate issue6159.
Aug 19 2019, 11:16 AM
pulkit added inline comments to D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files.
Aug 19 2019, 11:10 AM
pulkit added inline comments to D6736: shelve: add method for storing mergestate in changeset extras.
Aug 19 2019, 11:06 AM

Aug 17 2019

pulkit created D6741: interfaces: create a new folder for interfaces and move repository.py in it.
Aug 17 2019, 7:45 PM
pulkit created D6742: interfaceutil: move to interfaces/.
Aug 17 2019, 7:44 PM
D6733: setup: fix a sorting issue I noticed in package names is now accepted and ready to land.
Aug 17 2019, 3:32 PM
pulkit added a comment to D6479: shelve: first prototype of storing/restoring unresolved changes.

The only thing I'm curious about really is why we have extrastorage and usualstorge. Can we get away with only one of those choices instead of having more options?

The ultimate goal is to store the mergestate info in the changeset extras only. But, now , it has no support to store the local version of the files which are stored in the mergestate. This lacks info when the user gets conflicts other than a usual hg merge.

Aug 17 2019, 3:30 PM
pulkit added inline comments to D6735: update: added support for --abort flag(issue4404).
Aug 17 2019, 3:29 PM
pulkit added a comment to D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159).

In such cases, I like the idea of having fix as two patches, first which demonstrates the bug and the second which fixes the bug. What do you think?

Aug 17 2019, 3:26 PM
pulkit added inline comments to D6728: config: add experimental argument to the config registrar.
Aug 17 2019, 3:25 PM

Aug 16 2019

D6695: transplant: added support for --stop flag is now accepted and ready to land.
Aug 16 2019, 5:54 AM
pulkit accepted D6729: tests: use `tr -d` and not `tr --delete` since the latter is absent on BSD tr(1).
Aug 16 2019, 5:45 AM

Aug 15 2019

pulkit added a comment to D6695: transplant: added support for --stop flag.

Let's rename this to transplant --stop instead.

Aug 15 2019, 11:32 AM
D6699: unshelve: abort on using --keep and --interactive together is now accepted and ready to land.
Aug 15 2019, 10:48 AM
D6725: tests: split joint repo/changelog fake into one for each type is now accepted and ready to land.
Aug 15 2019, 10:45 AM