Page MenuHomePhabricator

pulkit (Pulkit Goyal)
Spy

Projects

User Details

User Since
Jun 28 2017, 8:54 PM (213 w, 6 d)

Recent Activity

Today

D11247: tests: drop hgrc bits that have become the default is now accepted and ready to land.
Wed, Aug 4, 4:40 PM
D11245: tests: rely on dummyssh being the default is now accepted and ready to land.
Wed, Aug 4, 4:40 PM
D11246: tests: manual cleanup now that dummyssh usage is implied is now accepted and ready to land.
Wed, Aug 4, 4:40 PM
D11244: tests: setup dummyssh as the default ssh is now accepted and ready to land.
Wed, Aug 4, 4:40 PM
D11249: check-module-imports: ignore non-stdlib module installed by distribution is now accepted and ready to land.
Wed, Aug 4, 4:40 PM
D11243: remotefilelog: fix what looks like a wrong refactoring is now accepted and ready to land.
Wed, Aug 4, 4:40 PM
D11238: rust-nodemap: falling back to C impl as mitigation is now accepted and ready to land.
Wed, Aug 4, 4:40 PM

Sun, Aug 1

D11237: tests: rename test-clone-uncompressed.t is now accepted and ready to land.
Sun, Aug 1, 3:02 PM
D11236: streamclone: ensure the server sends the right amount of data is now accepted and ready to land.
Sun, Aug 1, 3:02 PM

Tue, Jul 27

D11214: help: indicate how to run downgrade a repository using persistent nodemap is now accepted and ready to land.
Tue, Jul 27, 4:42 AM
D11213: help: use the correct spelling for `slow-path` in persistent nodemap help is now accepted and ready to land.
Tue, Jul 27, 4:40 AM

Sat, Jul 24

D11210: fix: use scmutil.movedirstate() instead of reimplementing is now accepted and ready to land.
Sat, Jul 24, 5:19 AM
D11209: fix: rewrite writeworkingdir() to explicitly not work with merges is now accepted and ready to land.
Sat, Jul 24, 5:19 AM
D11208: tests: demonstrate bug in `hg fix` with incorrectly dirty working copy is now accepted and ready to land.
Sat, Jul 24, 5:18 AM

Wed, Jul 21

pulkit committed rHG9b21731ae1e5: Added signature for changeset d7515d29761d.
Added signature for changeset d7515d29761d
Wed, Jul 21, 5:49 PM
pulkit committed rHG9e6978463c6e: Added tag 5.9rc0 for changeset d7515d29761d.
Added tag 5.9rc0 for changeset d7515d29761d
Wed, Jul 21, 5:49 PM
pulkit accepted D11204: hgwebdir: avoid systematic full garbage collection.
Wed, Jul 21, 4:55 PM

Tue, Jul 20

pulkit added a comment to D10893: amend: add a useless initial version of `amend -r REV `.

I am also big +1 on adding the feature. I think we can split this into multiple smaller features to split out discussion and ease review.

Tue, Jul 20, 4:31 PM
pulkit added a comment to D10272: rebase: drop support for rebaseskipobsolete config.

I am +1 on this. I remember there was a discussion on IRC around it but not sure what the end result of that was. @marmoute does having experimental.rebaseskipobsolete serves any purpose?

Ha yes, thanks for the ping. The short version of my opinion is that experience has shown over and over that having a way to says "select exactly what I requested without tempering with it" are useful. Therefore, we should not drop the flag currently allowing to do that without at least introducing another one.
Neither hg rebase is quite powerfull tool and neither rebase --keep, hg graft or hg touch (?) can really do the same thing. So they don't seem like proper alternative to a simple "do-what-I-said" config/flag.

Tue, Jul 20, 4:23 PM
pulkit accepted D11174: revert: use `set_possibly_dirty` instead of `normal_lookup`.
Tue, Jul 20, 3:48 PM
pulkit accepted D11173: dirstate: enforce `possibly_dirty` in `set_tracked`.
Tue, Jul 20, 3:48 PM
pulkit accepted D11172: record: use `update_file` instead of `normallookup`.
Tue, Jul 20, 3:47 PM
pulkit accepted D11171: copy: use `set_tracked` instead of `normallookup` in `dirstatecopy`.
Tue, Jul 20, 3:47 PM
pulkit accepted D11170: amend: use `update_file` instead of `normallookup`.
Tue, Jul 20, 3:44 PM
pulkit accepted D11169: mergestate: use `update_file` to handle `for ACTION_EXEC`.
Tue, Jul 20, 3:44 PM
pulkit accepted D11168: mergestate: use `update_file` to handle `for ACTION_ADD_MODIFIED`.
Tue, Jul 20, 3:44 PM
pulkit accepted D11167: largefile: use `update_file` for `synclfdirstate` "m" case.
Tue, Jul 20, 3:44 PM
pulkit accepted D11166: largefile: use `update_file` for `synclfdirstate` "n" case.
Tue, Jul 20, 3:44 PM
pulkit accepted D11165: largefile: replace the `normallookup` call when creating a new lfdirstate.
Tue, Jul 20, 3:44 PM
pulkit accepted D11165: largefile: replace the `normallookup` call when creating a new lfdirstate.
Tue, Jul 20, 3:41 PM
pulkit accepted D11164: largefile: use `update_file` instead of `normallookup` in `updatelfiles`.
Tue, Jul 20, 3:40 PM
pulkit accepted D11163: largefile: use `set_possibly_dirty` instead of `normallookup`.
Tue, Jul 20, 3:39 PM
pulkit accepted D11162: dirstate: add a `set_possibly_dirty` method.
Tue, Jul 20, 3:39 PM
pulkit added inline comments to D11161: dirstate: deprecate the `normal` method in all cases.
Tue, Jul 20, 3:38 PM
pulkit accepted D11161: dirstate: deprecate the `normal` method in all cases.
Tue, Jul 20, 3:38 PM
pulkit accepted D11160: test: use `set_traced` in `test-context`.
Tue, Jul 20, 3:37 PM
pulkit accepted D11159: mq: replace usage of `normal` with newer API.
Tue, Jul 20, 3:37 PM
pulkit accepted D11158: largefile: use `update_file` instead of `normal` in `synclfdirstate`.
Tue, Jul 20, 3:37 PM
pulkit accepted D11157: largefile: use `set_clean` instead of `normal` in `repo.status`.
Tue, Jul 20, 3:36 PM
pulkit accepted D11156: largefile: use `set_clean` instead of `normal` in `lfdirstatestatus`.
Tue, Jul 20, 3:36 PM
pulkit accepted D11155: largefile: use `update_file` instead of `normal` in `updatelfiles`.
Tue, Jul 20, 3:36 PM
pulkit accepted D11154: largefile: respect the `normal` signature.
Tue, Jul 20, 3:35 PM
pulkit accepted D11153: keywork: use `set_clean` instead of `normal`.
Tue, Jul 20, 3:35 PM
pulkit accepted D11152: sparse: use `update_file` instead of `normal` in `refreshwdir`.
Tue, Jul 20, 3:35 PM
pulkit accepted D11151: sparse: use `update_file` instead of `normal` during `applyupdates`.
Tue, Jul 20, 3:35 PM
pulkit accepted D11150: sparse: apply update with in a `parentchange` context.
Tue, Jul 20, 3:34 PM
pulkit accepted D11149: revert: use `set_clean` instead of `normal`.
Tue, Jul 20, 3:34 PM
pulkit accepted D11148: context: use `update_file` instead of `normal` in `markcommitted`.
Tue, Jul 20, 3:33 PM
pulkit accepted D11147: context: use new API instead of `normal` during fixup post status.
Tue, Jul 20, 3:33 PM
pulkit accepted D11146: dirstate: introduce a `set_clean` method.
Tue, Jul 20, 3:32 PM
pulkit accepted D11145: largefile: use `update_file` instead of `normal`.
Tue, Jul 20, 3:32 PM
pulkit accepted D11144: largefile: adjust the dirstate post update within a `parentchange` context.
Tue, Jul 20, 3:32 PM
pulkit accepted D11143: dirstate: deprecate `dirstate.remove` in all cases.
Tue, Jul 20, 3:32 PM
pulkit accepted D11142: largefile: use `update_file` instead of `remove` in `synclfdirstate`.
Tue, Jul 20, 3:31 PM
pulkit accepted D11141: largefile: rearrange conditionnal in `synclfdirstate`.
Tue, Jul 20, 3:31 PM
pulkit accepted D11140: largefile: use `update_file` instead of `remove` in `mergerecordupdates`.
Tue, Jul 20, 3:31 PM
pulkit accepted D11139: mq: use `update_file_p1` instead of `remove` when adjusting dirstate.
Tue, Jul 20, 3:31 PM
pulkit accepted D11138: dirstate: properly update `_lastnormaltime` in `update_file_p1`.
Tue, Jul 20, 3:30 PM
pulkit accepted D11137: dirstate: properly update `_lastnormaltime` in `update_file`.
Tue, Jul 20, 3:30 PM
pulkit accepted D11136: dirstate: use `reset_state` in `update_file_p1`.
Tue, Jul 20, 3:30 PM
pulkit accepted D11135: dirstate: rename `update_file_reference` to `update_file_p1`.
Tue, Jul 20, 3:29 PM
pulkit accepted D11134: dirstate-map: move most of `dirstate.update_file` logic in the dsmap.
Tue, Jul 20, 3:29 PM
pulkit added a comment to D11082: dummyssh: use subprocess instead of os.call.

2021 it is but yeah ;)

Tue, Jul 20, 3:25 PM
D11204: hgwebdir: avoid systematic full garbage collection is now accepted and ready to land.
Tue, Jul 20, 3:19 PM
pulkit accepted D11124: dirstate-item: introduce a `dm_otherparent` property.
Tue, Jul 20, 3:18 PM
pulkit accepted D11123: dirstate-item: introduce a `dm_nonnormal` property.
Tue, Jul 20, 3:18 PM
pulkit accepted D11128: dirstate: replace a dead conditional branch with an assert in `update_file`.
Tue, Jul 20, 6:41 AM
pulkit accepted D11133: dirstate: replace `update_parent_file_data` with simpler `update_parent` call.
Tue, Jul 20, 6:37 AM
pulkit accepted D11132: dirstate: factor out the part retrieve "filedata" out of `normal`.
Tue, Jul 20, 6:36 AM
D11202: upgrade: avoid a traceback in case of unrecognized revlog is now accepted and ready to land.
Tue, Jul 20, 6:35 AM
D11201: walk: no longer ignore revlogs of files starting with `undo.` (issue6542) is now accepted and ready to land.
Tue, Jul 20, 6:34 AM
pulkit accepted D11131: dirstate-map: factor out the change to _dirs and _alldirs on removing.
Tue, Jul 20, 6:32 AM

Mon, Jul 19

pulkit accepted D11130: dirstate-map: factor out the change to _dirs and _alldirs on dropping.
Mon, Jul 19, 8:07 PM
pulkit accepted D11129: dirstate-map: factor out the change to _dirs and _alldirs on adding.
Mon, Jul 19, 8:07 PM
pulkit accepted D11127: dirstate-map: do not use `size` to gate copy dropping during remove_file.
Mon, Jul 19, 8:06 PM
pulkit accepted D11126: dirstate: drop a duplicated assert.
Mon, Jul 19, 8:05 PM
pulkit accepted D11125: dirstate: drop duplicated check.
Mon, Jul 19, 8:05 PM
pulkit accepted D11122: dirstate: add a `set_possibly_dirty` in `fakedirstatewritetime`.
Mon, Jul 19, 8:04 PM
pulkit accepted D11121: dirstatemap: use `set_possibly_dirty` in `clearambiguoustimes`.
Mon, Jul 19, 8:04 PM
pulkit accepted D11120: dirstate-item: use `set_possibly_dirty` in `pure.pack_dirstate`.
Mon, Jul 19, 8:04 PM
pulkit accepted D11119: dirstate-item: add a `set_possibly_dirty` method.
Mon, Jul 19, 8:03 PM
pulkit accepted D11118: dirstate-item: add a `from_v1_data` constructor.
Mon, Jul 19, 8:03 PM
pulkit accepted D11117: dirstate-item: use an explicit __init__ function instead of the attrs one.
Mon, Jul 19, 8:03 PM
pulkit accepted D11116: dirstate: deprecated `drop` outside of `update/merge`.
Mon, Jul 19, 8:02 PM
pulkit accepted D11115: dirstate: deprecated `remove` outside of `update/merge`.
Mon, Jul 19, 8:02 PM
pulkit closed D11113: largefiles: replace use of synclfdirstate with drop.
Mon, Jul 19, 2:26 PM
pulkit committed rHGf0cf560475a3: largefiles: replace use of synclfdirstate with drop.
largefiles: replace use of synclfdirstate with drop
Mon, Jul 19, 2:26 PM
pulkit accepted D11114: dirstate: deprecate the `add` method outside of update/merge context.
Mon, Jul 19, 1:18 PM
pulkit added inline comments to D11141: largefile: rearrange conditionnal in `synclfdirstate`.
Mon, Jul 19, 10:51 AM
pulkit added a comment to D11161: dirstate: deprecate the `normal` method in all cases.

Can you add a patch that adds release notes about all these API changes?

Mon, Jul 19, 8:38 AM
pulkit added inline comments to D11013: dirstate: add a `set_tracked` method for "hg add"-like usage.
Mon, Jul 19, 8:33 AM
pulkit added inline comments to D11012: dirstate: add a function to update tracking status while "moving" parents.
Mon, Jul 19, 8:32 AM

Sun, Jul 18

pulkit added a comment to D11113: largefiles: replace use of synclfdirstate with drop.

This one is authored by me, so skipping review.

Sun, Jul 18, 6:37 PM
D11112: largefile: use `parentchange` markcommitted is now accepted and ready to land.
Sun, Jul 18, 6:36 PM
D11111: largefile: use `set_untracked` in the override of copy/rename is now accepted and ready to land.
Sun, Jul 18, 6:36 PM
D11110: largefile: use `set_untracked` in the `forget` override is now accepted and ready to land.
Sun, Jul 18, 6:36 PM
D11109: largefile: directly use set_untracked() for removing files is now accepted and ready to land.
Sun, Jul 18, 6:35 PM
D11108: largefile: use `parentchange` during rollback is now accepted and ready to land.
Sun, Jul 18, 6:26 PM
D11107: largefile: consider `updatelfiles` as a `parentchange` is now accepted and ready to land.
Sun, Jul 18, 6:26 PM
D11106: largefile: use `set_tracker` in the `hg copy` overwrite is now accepted and ready to land.

s/set_tracker/set_tracked in commit title

Sun, Jul 18, 6:22 PM