- User Since
- Jun 28 2017, 8:54 PM (158 w, 2 d)
Gentle ping for review.
Thu, Jul 9
Tue, Jul 7
I will go ahead and push it before upcoming rc if I hear no objections.
I looked up the the mail thread which introduced this change, unable to understand why this limitation is there. @durin42 any chance you remember?
There are couple of other mentions of 40 in this file, looks like in future we should introduce a constant for this.
Seems like I know why this patch is required but some additional description in commit message as why this is required will be helpful.
This one looks good as independent patch. Will be happy to push if you rebase it on default and send.
It's bit hard to review the patch since it seems that it consists multiple changes. I can see following ones:
Folding this too into a097299ed2a0.
Folding it into a097299ed2a0.
Mon, Jul 6
Fri, Jul 3
Thu, Jul 2
Wed, Jul 1
Mon, Jun 29
Reworded the first line of commit message to test: redirect stderr so warning messages don't change output (issue6237) to make test-check-commit.t which was complaining that summary line too long.