pulkit (Pulkit Goyal)
Spy

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 8:54 PM (64 w, 2 d)

Recent Activity

Yesterday

pulkit accepted D4692: narrow: remove hack to read narowspec from shared .hg directory.
Fri, Sep 21, 12:49 PM

Thu, Sep 20

pulkit closed D4688: py3: use '%d' instead of '%s' for integers.
Thu, Sep 20, 6:34 PM
pulkit closed D4687: py3: use print as a function in tests/test-revert.t.
Thu, Sep 20, 6:33 PM
pulkit committed rHG7303ab86431a: py3: use '%d' instead of '%s' for integers.
py3: use '%d' instead of '%s' for integers
Thu, Sep 20, 6:33 PM
pulkit committed rHGe0a7cfa9323f: py3: use print as a function in tests/test-revert.t.
py3: use print as a function in tests/test-revert.t
Thu, Sep 20, 6:33 PM
pulkit created D4688: py3: use '%d' instead of '%s' for integers.
Thu, Sep 20, 6:00 PM
pulkit added a dependent revision for D4687: py3: use print as a function in tests/test-revert.t: D4688: py3: use '%d' instead of '%s' for integers.
Thu, Sep 20, 6:00 PM
pulkit created D4687: py3: use print as a function in tests/test-revert.t.
Thu, Sep 20, 6:00 PM
pulkit accepted D4312: New bookflow extension for bookmark-based branching.

The code looks mostly good. Since this is something which changes existing bookmark behavior, I will let one more pair of eyes to look before getting pushed.

Thu, Sep 20, 5:32 PM
pulkit closed D4677: py3: encode the name to bytes before using in revsetpredicate().
Thu, Sep 20, 3:42 PM
pulkit closed D4676: py3: suppress the output on .write() calls in tests/test-hgweb-commands.t.
Thu, Sep 20, 3:42 PM
pulkit committed rHG65b39c556c6d: py3: encode the name to bytes before using in revsetpredicate().
py3: encode the name to bytes before using in revsetpredicate()
Thu, Sep 20, 3:42 PM
pulkit committed rHG56cb053a71ed: py3: suppress the output on .write() calls in tests/test-hgweb-commands.t.
py3: suppress the output on .write() calls in tests/test-hgweb-commands.t
Thu, Sep 20, 3:42 PM
pulkit closed D4675: py3: use stringutil.pprint() to print boolean values.
Thu, Sep 20, 3:42 PM
pulkit committed rHGce4c29705983: py3: use stringutil.pprint() to print boolean values.
py3: use stringutil.pprint() to print boolean values
Thu, Sep 20, 3:42 PM
pulkit closed D4674: py3: add a missing b'' in tests/test-newercgi.t.
Thu, Sep 20, 3:42 PM
pulkit closed D4672: py3: add some b'' prefixes in tests/test-extension.t.
Thu, Sep 20, 3:42 PM
pulkit committed rHGa2bb0ec3b4d4: py3: add a missing b'' in tests/test-newercgi.t.
py3: add a missing b'' in tests/test-newercgi.t
Thu, Sep 20, 3:42 PM
pulkit committed rHGbe396c86f98e: py3: add some b'' prefixes in tests/test-extension.t.
py3: add some b'' prefixes in tests/test-extension.t
Thu, Sep 20, 3:42 PM
pulkit committed rHG7e3ce2131882: py3: use pycompat.maplist instead of map.
py3: use pycompat.maplist instead of map
Thu, Sep 20, 3:42 PM
pulkit closed D4673: py3: use pycompat.maplist instead of map.
Thu, Sep 20, 3:42 PM
pulkit committed rHGe1e10cbb5568: py3: make tests/svn-safe-append.py compatible with python 3.
py3: make tests/svn-safe-append.py compatible with python 3
Thu, Sep 20, 3:42 PM
pulkit closed D4670: py3: use print as a function in tests/test-subrepo-svn.t.
Thu, Sep 20, 3:42 PM
pulkit closed D4671: py3: make tests/svn-safe-append.py compatible with python 3.
Thu, Sep 20, 3:42 PM
pulkit committed rHG5495ceab5637: py3: use print as a function in tests/test-subrepo-svn.t.
py3: use print as a function in tests/test-subrepo-svn.t
Thu, Sep 20, 3:42 PM
pulkit created D4677: py3: encode the name to bytes before using in revsetpredicate().
Thu, Sep 20, 11:50 AM
pulkit added a dependent revision for D4676: py3: suppress the output on .write() calls in tests/test-hgweb-commands.t: D4677: py3: encode the name to bytes before using in revsetpredicate().
Thu, Sep 20, 11:50 AM
pulkit created D4676: py3: suppress the output on .write() calls in tests/test-hgweb-commands.t.
Thu, Sep 20, 11:50 AM
pulkit created D4675: py3: use stringutil.pprint() to print boolean values.
Thu, Sep 20, 11:50 AM
pulkit added a dependent revision for D4674: py3: add a missing b'' in tests/test-newercgi.t: D4675: py3: use stringutil.pprint() to print boolean values.
Thu, Sep 20, 11:50 AM
pulkit created D4674: py3: add a missing b'' in tests/test-newercgi.t.
Thu, Sep 20, 11:50 AM
pulkit created D4673: py3: use pycompat.maplist instead of map.
Thu, Sep 20, 11:50 AM
pulkit added a dependent revision for D4672: py3: add some b'' prefixes in tests/test-extension.t: D4673: py3: use pycompat.maplist instead of map.
Thu, Sep 20, 11:50 AM
pulkit created D4672: py3: add some b'' prefixes in tests/test-extension.t.
Thu, Sep 20, 11:49 AM
pulkit added a dependent revision for D4671: py3: make tests/svn-safe-append.py compatible with python 3: D4672: py3: add some b'' prefixes in tests/test-extension.t.
Thu, Sep 20, 11:49 AM
pulkit created D4671: py3: make tests/svn-safe-append.py compatible with python 3.
Thu, Sep 20, 11:49 AM
pulkit added a dependent revision for D4670: py3: use print as a function in tests/test-subrepo-svn.t: D4671: py3: make tests/svn-safe-append.py compatible with python 3.
Thu, Sep 20, 11:49 AM
pulkit created D4670: py3: use print as a function in tests/test-subrepo-svn.t.
Thu, Sep 20, 11:49 AM

Wed, Sep 19

pulkit created D4664: mergecommit: add a new extension to merge in-memory and create a commit.
Wed, Sep 19, 8:52 AM

Tue, Sep 18

pulkit added a comment to D4638: changegroup: add functionality to skip adding changelog data to changegroup.

I think the code as written makes sense: I'd rather have 1 loop over deltas than 2.

Regarding the other potential improvement, the reality of changegroups is that both they and bundle2 are container formats. In the context of bundle2, I think it makes more sense to send "delta groups" as individual bundle2 parts and to do away with changegroups completely. My guess is we haven't done this because the changegroup code has always existed, is non-trivial, and "just works." In other words, there hasn't been a pressing need to split up the changegroup code, so nobody has done it.

Tue, Sep 18, 2:02 PM
pulkit closed D4639: narrow: don't send the changelog information when widening without ellipses.
Tue, Sep 18, 1:55 PM
pulkit closed D4638: changegroup: add functionality to skip adding changelog data to changegroup.
Tue, Sep 18, 1:55 PM
pulkit committed rHGf1844a10ee19: narrow: don't send the changelog information when widening without ellipses.
narrow: don't send the changelog information when widening without ellipses
Tue, Sep 18, 1:55 PM
pulkit committed rHGa1942015c10e: changegroup: add functionality to skip adding changelog data to changegroup.
changegroup: add functionality to skip adding changelog data to changegroup
Tue, Sep 18, 1:55 PM
pulkit committed rHGdee887072f27: tests: add debug output in test-narrow-widen-no-ellipsis.t.
tests: add debug output in test-narrow-widen-no-ellipsis.t
Tue, Sep 18, 1:48 PM
pulkit closed D4637: tests: add debug output in test-narrow-widen-no-ellipsis.t.
Tue, Sep 18, 1:48 PM
pulkit committed rHG9b07ee0a1054: changegroup: improve the devel-warn to specify changelog was empty.
changegroup: improve the devel-warn to specify changelog was empty
Tue, Sep 18, 1:48 PM
pulkit closed D4636: changegroup: improve the devel-warn to specify changelog was empty.
Tue, Sep 18, 1:48 PM
pulkit accepted D4612: zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly.
Tue, Sep 18, 11:52 AM
pulkit committed rHGb77f2ea51da5: py3: fix kwargs handling in hgext/fastannotate.py.
py3: fix kwargs handling in hgext/fastannotate.py
Tue, Sep 18, 9:47 AM
pulkit closed D4588: py3: fix kwargs handling in hgext/fastannotate.py.
Tue, Sep 18, 9:47 AM
pulkit added a comment to D4638: changegroup: add functionality to skip adding changelog data to changegroup.

I agree this is dirty and I will be very happy to improve this. I can think of folllowing improvements

Tue, Sep 18, 7:01 AM
pulkit created D4639: narrow: don't send the changelog information when widening without ellipses.
Tue, Sep 18, 6:44 AM
pulkit added a dependent revision for D4638: changegroup: add functionality to skip adding changelog data to changegroup: D4639: narrow: don't send the changelog information when widening without ellipses.
Tue, Sep 18, 6:43 AM
pulkit created D4638: changegroup: add functionality to skip adding changelog data to changegroup.
Tue, Sep 18, 6:43 AM
pulkit added a dependent revision for D4637: tests: add debug output in test-narrow-widen-no-ellipsis.t: D4638: changegroup: add functionality to skip adding changelog data to changegroup.
Tue, Sep 18, 6:43 AM
pulkit created D4637: tests: add debug output in test-narrow-widen-no-ellipsis.t.
Tue, Sep 18, 6:43 AM
pulkit added a dependent revision for D4636: changegroup: improve the devel-warn to specify changelog was empty: D4637: tests: add debug output in test-narrow-widen-no-ellipsis.t.
Tue, Sep 18, 6:43 AM
pulkit created D4636: changegroup: improve the devel-warn to specify changelog was empty.
Tue, Sep 18, 6:43 AM

Mon, Sep 17

pulkit added a comment to D4614: narrow: use diffmatcher to send only new filelogs in non-ellipses widening.

I expected some changes would be needed on the client to prevent it from stripping the existing file nodes, but I suppose is still does that and it still works because it re-applies that stripped bundle afterwards.

Mon, Sep 17, 1:19 PM
pulkit closed D4614: narrow: use diffmatcher to send only new filelogs in non-ellipses widening.
Mon, Sep 17, 1:14 PM
pulkit committed rHGc73c7653dfb9: narrow: use diffmatcher to send only new filelogs in non-ellipses widening.
narrow: use diffmatcher to send only new filelogs in non-ellipses widening
Mon, Sep 17, 1:14 PM
pulkit closed D4613: py3: add missing b'' prefixes in couple of test files.
Mon, Sep 17, 10:15 AM
pulkit committed rHG322aaf80acf3: py3: add missing b'' prefixes in couple of test files.
py3: add missing b'' prefixes in couple of test files
Mon, Sep 17, 10:15 AM
pulkit created D4614: narrow: use diffmatcher to send only new filelogs in non-ellipses widening.
Mon, Sep 17, 9:32 AM
pulkit created D4613: py3: add missing b'' prefixes in couple of test files.
Mon, Sep 17, 8:28 AM

Sun, Sep 16

pulkit closed D4610: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t.
Sun, Sep 16, 5:21 PM
pulkit closed D4611: py3: add b'' prefixes in tests/test-hgweb-no-request-uri.t.
Sun, Sep 16, 5:21 PM
pulkit committed rHG19f701387ed5: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t.
py3: add b'' prefixes in tests/test-hgweb-no-path-info.t
Sun, Sep 16, 5:21 PM
pulkit committed rHGa12916cfef9e: py3: add b'' prefixes in tests/test-hgweb-no-request-uri.t.
py3: add b'' prefixes in tests/test-hgweb-no-request-uri.t
Sun, Sep 16, 5:21 PM
pulkit closed D4609: py3: add b'' prefixes in tests/test-hgweb-non-interactive.t.
Sun, Sep 16, 5:21 PM
pulkit committed rHGc20861b65688: py3: add b'' prefixes in tests/test-hgweb-non-interactive.t.
py3: add b'' prefixes in tests/test-hgweb-non-interactive.t
Sun, Sep 16, 5:21 PM
pulkit closed D4608: py3: use codecs.encode() to encode in rot-13 encoding.
Sun, Sep 16, 5:21 PM
pulkit committed rHGe3768bd48e26: py3: add two passing tests to whitelist found by buildbot.
py3: add two passing tests to whitelist found by buildbot
Sun, Sep 16, 5:21 PM
pulkit committed rHG2b9f315a4217: py3: use codecs.encode() to encode in rot-13 encoding.
py3: use codecs.encode() to encode in rot-13 encoding
Sun, Sep 16, 5:21 PM
pulkit closed D4607: py3: add two passing tests to whitelist found by buildbot.
Sun, Sep 16, 5:21 PM
pulkit updated the diff for D4588: py3: fix kwargs handling in hgext/fastannotate.py.
Sun, Sep 16, 11:54 AM
pulkit created D4611: py3: add b'' prefixes in tests/test-hgweb-no-request-uri.t.
Sun, Sep 16, 11:54 AM
pulkit created D4610: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t.
Sun, Sep 16, 11:53 AM
pulkit added a dependent revision for D4609: py3: add b'' prefixes in tests/test-hgweb-non-interactive.t: D4610: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t.
Sun, Sep 16, 11:53 AM
pulkit created D4609: py3: add b'' prefixes in tests/test-hgweb-non-interactive.t.
Sun, Sep 16, 11:53 AM
pulkit added a dependent revision for D4608: py3: use codecs.encode() to encode in rot-13 encoding: D4609: py3: add b'' prefixes in tests/test-hgweb-non-interactive.t.
Sun, Sep 16, 11:53 AM
pulkit created D4608: py3: use codecs.encode() to encode in rot-13 encoding.
Sun, Sep 16, 11:53 AM
pulkit added inline comments to D4588: py3: fix kwargs handling in hgext/fastannotate.py.
Sun, Sep 16, 11:49 AM
pulkit created D4607: py3: add two passing tests to whitelist found by buildbot.
Sun, Sep 16, 9:56 AM

Fri, Sep 14

pulkit closed D4594: py3: call hgweb.hgweb() with bytes values.
Fri, Sep 14, 6:16 PM
pulkit closed D4591: py3: suppress the return value from .write() call.
Fri, Sep 14, 6:16 PM
pulkit committed rHG23b749b84b8a: py3: call hgweb.hgweb() with bytes values.
py3: call hgweb.hgweb() with bytes values
Fri, Sep 14, 6:16 PM
pulkit committed rHGb220851999b5: py3: use '%d' for integers instead of '%s'.
py3: use '%d' for integers instead of '%s'
Fri, Sep 14, 6:16 PM
pulkit closed D4593: py3: use '%d' for integers instead of '%s'.
Fri, Sep 14, 6:16 PM
pulkit committed rHG2aa12d7fcb4f: py3: use "%f" for floats instead of "%s".
py3: use "%f" for floats instead of "%s"
Fri, Sep 14, 6:16 PM
pulkit committed rHG2f40bcebad30: py3: suppress the return value from .write() call.
py3: suppress the return value from .write() call
Fri, Sep 14, 6:16 PM
pulkit closed D4589: py3: slice through bytes to prevent getting ascii value.
Fri, Sep 14, 6:16 PM
pulkit closed D4592: py3: use "%f" for floats instead of "%s".
Fri, Sep 14, 6:16 PM
pulkit closed D4590: py3: add b'' prefixes in tests/test-diff-color.t.
Fri, Sep 14, 6:16 PM
pulkit committed rHGc8e371ee65a4: py3: add b'' prefixes in tests/test-diff-color.t.
py3: add b'' prefixes in tests/test-diff-color.t
Fri, Sep 14, 6:16 PM
pulkit committed rHG5a2bf7f941fa: py3: slice through bytes to prevent getting ascii value.
py3: slice through bytes to prevent getting ascii value
Fri, Sep 14, 6:15 PM
pulkit created D4594: py3: call hgweb.hgweb() with bytes values.
Fri, Sep 14, 5:43 PM
pulkit added a dependent revision for D4593: py3: use '%d' for integers instead of '%s': D4594: py3: call hgweb.hgweb() with bytes values.
Fri, Sep 14, 5:42 PM
pulkit created D4593: py3: use '%d' for integers instead of '%s'.
Fri, Sep 14, 5:42 PM