- User Since
- Jun 28 2017, 8:54 PM (81 w, 3 d)
Thu, Jan 17
Nice! Let's install docutils on Python 3 on buildbot too.
This one does not apply anymore on tip of default branch.
Wed, Jan 16
It's weird that print works as a function too in Python 2.
Let's use pycompat.queue() for consistency.
Fri, Jan 11
Thu, Jan 10
This one removes clearbackup() while restorebackup() and savebackup() are still there. Does that means that we are sure that we won't need to manually clear the backup from store?
Wed, Jan 9
Sorry for bumping on this now, can you add tests for this as follow-up?
Tue, Jan 8
If you couldn't follow those steps, you can simply check the diffs here:
Mon, Jan 7
Thanks for the quick follow-up. Yuya did it better and I pushed his patches which can be found at https://www.mercurial-scm.org/repo/hg-committed/rev/b153a4aa06f8 and https://www.mercurial-scm.org/repo/hg-committed/rev/cffa8e0ba77a. This one can be abandoned.
Ping for review!
Queueing this, many thanks!
Is this meant for stable?
Sat, Jan 5
Nice work! Can you update description of this patch with details in commit message about behavior of the new config option and how it solves the given issue?
Fri, Jan 4
I am not sure whether this change is correct or not, but please add more description to your commit message explaining what this patch is doing, what the issue is about and how it fixes that.
Nice! I left an inline comment.
The patch is going in a good direction. We now need to make sure that we don't amend if date is the only thing which has changed.
Wed, Jan 2
Hi, thanks for the patch.
Thu, Dec 27
Wed, Dec 26
It turned out to be important optimization for us. Since it's holiday in US, I updated this with Yuya's comment.
Mon, Dec 24
Didn't looked at the code in detail yet, but this patch needs tests.