pulkit (Pulkit Goyal)
Spy

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 8:54 PM (72 w, 4 d)

Recent Activity

Fri, Nov 16

pulkit accepted D5281: wireprotov2server: let repo.narrowmatch(match) do matcher intersection.
Fri, Nov 16, 5:51 AM

Wed, Nov 14

pulkit accepted D5271: tests: fix bytes/str issue I introduced when adding this test.
Wed, Nov 14, 10:20 AM
pulkit closed D5264: store: raise ProgrammingError if unable to decode a storage path.
Wed, Nov 14, 7:29 AM
pulkit committed rHG66adfd58cb77: store: raise ProgrammingError if unable to decode a storage path.
store: raise ProgrammingError if unable to decode a storage path
Wed, Nov 14, 7:29 AM
pulkit abandoned D5170: branchmap: pass changelog into revbranchcache.branchinfo().

I think this patch can be abandoned because of other work late in the 4.8 cycle?

Wed, Nov 14, 5:40 AM

Tue, Nov 13

pulkit closed D5263: py3: add b suffix to make sure file is opened in bytes mode.
Tue, Nov 13, 1:50 PM
pulkit closed D5262: py3: don't use dict.iterkeys().
Tue, Nov 13, 1:50 PM
pulkit closed D5259: py3: fix keyword arguments handling in hgext/remotefilelog/.
Tue, Nov 13, 1:49 PM
pulkit committed rHGaa588bf40a08: py3: add b suffix to make sure file is opened in bytes mode.
py3: add b suffix to make sure file is opened in bytes mode
Tue, Nov 13, 1:49 PM
pulkit closed D5261: py3: use node.hex(h.digest()) instead of h.hexdigest().
Tue, Nov 13, 1:49 PM
pulkit committed rHG9769e0f6ffe0: py3: don't use dict.iterkeys().
py3: don't use dict.iterkeys()
Tue, Nov 13, 1:49 PM
pulkit committed rHG3fa4183e7803: py3: use node.hex(h.digest()) instead of h.hexdigest().
py3: use node.hex(h.digest()) instead of h.hexdigest()
Tue, Nov 13, 1:49 PM
pulkit committed rHG5e3b3f88c2e4: py3: make second argument of fdopen() a str.
py3: make second argument of fdopen() a str
Tue, Nov 13, 1:49 PM
pulkit closed D5260: py3: make second argument of fdopen() a str.
Tue, Nov 13, 1:49 PM
pulkit committed rHG13d4ad8d7801: py3: fix keyword arguments handling in hgext/remotefilelog/.
py3: fix keyword arguments handling in hgext/remotefilelog/
Tue, Nov 13, 1:49 PM
pulkit created D5264: store: raise ProgrammingError if unable to decode a storage path.
Tue, Nov 13, 10:49 AM
pulkit created D5263: py3: add b suffix to make sure file is opened in bytes mode.
Tue, Nov 13, 10:28 AM
pulkit added a dependent revision for D5262: py3: don't use dict.iterkeys(): D5263: py3: add b suffix to make sure file is opened in bytes mode.
Tue, Nov 13, 10:27 AM
pulkit created D5262: py3: don't use dict.iterkeys().
Tue, Nov 13, 10:27 AM
pulkit added a dependent revision for D5261: py3: use node.hex(h.digest()) instead of h.hexdigest(): D5262: py3: don't use dict.iterkeys().
Tue, Nov 13, 10:27 AM
pulkit created D5261: py3: use node.hex(h.digest()) instead of h.hexdigest().
Tue, Nov 13, 10:27 AM
pulkit created D5259: py3: fix keyword arguments handling in hgext/remotefilelog/.
Tue, Nov 13, 10:27 AM
pulkit added a dependent revision for D5260: py3: make second argument of fdopen() a str: D5261: py3: use node.hex(h.digest()) instead of h.hexdigest().
Tue, Nov 13, 10:27 AM
pulkit created D5260: py3: make second argument of fdopen() a str.
Tue, Nov 13, 10:27 AM
pulkit added a dependent revision for D5259: py3: fix keyword arguments handling in hgext/remotefilelog/: D5260: py3: make second argument of fdopen() a str.
Tue, Nov 13, 10:27 AM
pulkit closed D5039: py3: add __pycache__ to .hgignore.
Tue, Nov 13, 9:20 AM
pulkit committed rHGee9981bc8b44: py3: add __pycache__ to .hgignore.
py3: add __pycache__ to .hgignore
Tue, Nov 13, 9:20 AM
pulkit abandoned D3771: py3: make contrib/perf.py compatible to Python 3.

Not applicable anymore.

Tue, Nov 13, 9:08 AM
pulkit abandoned D4886: changegroup: add a parts argument to cgpacker.generate().
Tue, Nov 13, 9:06 AM
pulkit abandoned D4887: narrow: don't include the manifests while widening a narrow clone.

Abandoing this one and D4886 as @martinvonz's better fix landed as D4895.

Tue, Nov 13, 9:06 AM
pulkit abandoned D4849: store: introduce a function to get tracked path from a fncache entry.

This was an incorrect implementation. A better implementation has been pushed as part of D5139.

Tue, Nov 13, 9:04 AM
pulkit abandoned D5173: py3: make debugindexstats output printing compatible.

I remember reading @yuja patches which took care of it.

Tue, Nov 13, 9:02 AM
pulkit updated the diff for D5039: py3: add __pycache__ to .hgignore.
Tue, Nov 13, 8:15 AM
pulkit accepted D5146: histedit: import chistedit curses UI from hg-experimental.

Queueing this, many thanks for importing this in core.

Tue, Nov 13, 7:12 AM

Mon, Nov 12

pulkit added inline comments to D5138: narrow: only send includepats and excludepats if they are not empty.
Mon, Nov 12, 1:52 PM
pulkit accepted D5254: packaging: add Fedora 29 target.
Mon, Nov 12, 1:35 PM

Fri, Nov 9

pulkit accepted D5250: tests: don't load strip extension via mq extension for remotefilelog tests.
Fri, Nov 9, 2:44 PM
pulkit accepted D5249: remotefilelog: remove unused configs for {data,history}pack version.
Fri, Nov 9, 2:44 PM
pulkit accepted D5248: tests: remove obsolete PYTHONPATH override from remotefilelog tests.
Fri, Nov 9, 2:43 PM
pulkit accepted D5247: tests: drop obsolete "hginit" alias in remotefilelog tests.
Fri, Nov 9, 2:41 PM

Tue, Nov 6

pulkit abandoned D5147: config: make 'experimental' the section instead of 'experimental.server'.
Tue, Nov 6, 11:12 AM
pulkit accepted D5231: tests: fix config knob in test-narrow-clone-stream.t.
Tue, Nov 6, 11:08 AM
pulkit accepted D5230: remotefilelog: fix various whitespace issues in docstring.
Tue, Nov 6, 11:07 AM

Mon, Nov 5

pulkit committed rHG2dd3a0201307: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command.
remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command
Mon, Nov 5, 2:57 PM
pulkit closed D5190: shallowutil: introduce a helper function isenabled().
Mon, Nov 5, 2:57 PM
pulkit closed D5192: tests: remove lz4 as dependency while running tests.
Mon, Nov 5, 2:57 PM
pulkit closed D5193: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command.
Mon, Nov 5, 2:57 PM
pulkit committed rHG67e35dceab9b: tests: remove lz4 as dependency while running tests.
tests: remove lz4 as dependency while running tests
Mon, Nov 5, 2:57 PM
pulkit committed rHG1c34b31a6c9c: remotefilelogserver: add a matcher argument to _walkstreamfiles().
remotefilelogserver: add a matcher argument to _walkstreamfiles()
Mon, Nov 5, 2:57 PM
pulkit closed D5191: remotefilelogserver: add a matcher argument to _walkstreamfiles().
Mon, Nov 5, 2:57 PM
pulkit committed rHG6f0b6905ef6f: shallowutil: introduce a helper function isenabled().
shallowutil: introduce a helper function isenabled()
Mon, Nov 5, 2:57 PM
pulkit closed D5189: remotefilelog: remove some BC code related to streamclone.
Mon, Nov 5, 2:57 PM
pulkit committed rHG525dcf5c1d41: remotefilelog: remove some BC code related to streamclone.
remotefilelog: remove some BC code related to streamclone
Mon, Nov 5, 2:56 PM
pulkit closed D5119: exchange: pass includepats and excludepats as arguments to getbundle().
Mon, Nov 5, 11:15 AM
pulkit closed D5139: store: introduce _matchtrackedpath() and use it to filter store files.
Mon, Nov 5, 11:15 AM
pulkit committed rHG9aeb9e2d28a7: store: introduce _matchtrackedpath() and use it to filter store files.
store: introduce _matchtrackedpath() and use it to filter store files
Mon, Nov 5, 11:15 AM
pulkit committed rHG440f5b65be57: exchange: pass includepats and excludepats as arguments to getbundle().
exchange: pass includepats and excludepats as arguments to getbundle()
Mon, Nov 5, 11:15 AM
pulkit committed rHGa2c4502e409b: narrow: only send includepats and excludepats if they are not empty.
narrow: only send includepats and excludepats if they are not empty
Mon, Nov 5, 11:15 AM
pulkit closed D5138: narrow: only send includepats and excludepats if they are not empty.
Mon, Nov 5, 11:15 AM

Wed, Oct 31

pulkit closed D5198: configitems: rename the config to prevent adding an alias in future.
Wed, Oct 31, 8:44 AM
pulkit committed rHG14b6afc6cb28: configitems: rename the config to prevent adding an alias in future.
configitems: rename the config to prevent adding an alias in future
Wed, Oct 31, 8:44 AM
pulkit created D5198: configitems: rename the config to prevent adding an alias in future.
Wed, Oct 31, 8:31 AM

Wed, Oct 24

pulkit added a dependency for D5193: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command: D5192: tests: remove lz4 as dependency while running tests.
Wed, Oct 24, 11:49 AM
pulkit added a dependent revision for D5192: tests: remove lz4 as dependency while running tests: D5193: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command.
Wed, Oct 24, 11:49 AM
pulkit created D5193: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command.
Wed, Oct 24, 11:49 AM
pulkit updated the diff for D5191: remotefilelogserver: add a matcher argument to _walkstreamfiles().
Wed, Oct 24, 11:21 AM
pulkit added a dependent revision for D5131: remotefilelog: add some docstring: D5189: remotefilelog: remove some BC code related to streamclone.
Wed, Oct 24, 10:55 AM
pulkit added a dependency for D5189: remotefilelog: remove some BC code related to streamclone: D5131: remotefilelog: add some docstring.
Wed, Oct 24, 10:55 AM
pulkit created D5192: tests: remove lz4 as dependency while running tests.
Wed, Oct 24, 10:55 AM
pulkit added a dependent revision for D5191: remotefilelogserver: add a matcher argument to _walkstreamfiles(): D5192: tests: remove lz4 as dependency while running tests.
Wed, Oct 24, 10:55 AM
pulkit created D5190: shallowutil: introduce a helper function isenabled().
Wed, Oct 24, 10:55 AM
pulkit created D5191: remotefilelogserver: add a matcher argument to _walkstreamfiles().
Wed, Oct 24, 10:55 AM
pulkit added a dependent revision for D5190: shallowutil: introduce a helper function isenabled(): D5191: remotefilelogserver: add a matcher argument to _walkstreamfiles().
Wed, Oct 24, 10:55 AM
pulkit added a dependent revision for D5189: remotefilelog: remove some BC code related to streamclone: D5190: shallowutil: introduce a helper function isenabled().
Wed, Oct 24, 10:55 AM
pulkit created D5189: remotefilelog: remove some BC code related to streamclone.
Wed, Oct 24, 10:55 AM
pulkit accepted D5188: narrow: replace filtering in list comprehension by set operations.
Wed, Oct 24, 6:52 AM

Tue, Oct 23

pulkit closed D5183: narrow: rework logic to check whether we need to widen and narrow.
Tue, Oct 23, 12:23 PM
pulkit committed rHG30a7d3b6b281: narrow: rework logic to check whether we need to widen and narrow.
narrow: rework logic to check whether we need to widen and narrow
Tue, Oct 23, 12:23 PM
pulkit closed D5182: tests: show that adding an already included path still calls narrow_widen().
Tue, Oct 23, 12:23 PM
pulkit committed rHGd362a41ee5dd: tests: show that adding an already included path still calls narrow_widen().
tests: show that adding an already included path still calls narrow_widen()
Tue, Oct 23, 12:23 PM
pulkit updated the diff for D5183: narrow: rework logic to check whether we need to widen and narrow.
Tue, Oct 23, 12:07 PM
pulkit added a comment to D5146: histedit: import chistedit curses UI from hg-experimental.
In D5146#77492, @pulkit wrote:

I remember using chistedit and finding that the .hg/chisedit file is not deleted after chistedit is completed. Looking at code, I am unable to find code which deletes that file. Can you please have a look and delete that file after a successfull or aborted chistedit?

That file is an implementation detail, so that histedit can pass rules to itself. It's a little gross, but not harmful.

Could I persuade you to let us clean that up later as a follow-up?

Tue, Oct 23, 11:46 AM
pulkit added a comment to D5146: histedit: import chistedit curses UI from hg-experimental.

I remember using chistedit and finding that the .hg/chisedit file is not deleted after chistedit is completed. Looking at code, I am unable to find code which deletes that file. Can you please have a look and delete that file after a successfull or aborted chistedit?

Tue, Oct 23, 11:38 AM
pulkit added inline comments to D5183: narrow: rework logic to check whether we need to widen and narrow.
Tue, Oct 23, 11:34 AM
pulkit created D5183: narrow: rework logic to check whether we need to widen and narrow.
Tue, Oct 23, 9:52 AM
pulkit created D5182: tests: show that adding an already included path still calls narrow_widen().
Tue, Oct 23, 9:52 AM
pulkit closed D5174: py3: make sure we pass sysstr in sqlite3.connect().
Tue, Oct 23, 7:39 AM
pulkit committed rHGbad46c934c31: py3: add one more passing test to whitelist.
py3: add one more passing test to whitelist
Tue, Oct 23, 7:39 AM
pulkit committed rHG3b782669561d: py3: make sure we pass sysstr in sqlite3.connect().
py3: make sure we pass sysstr in sqlite3.connect()
Tue, Oct 23, 7:39 AM
pulkit closed D5175: py3: add one more passing test to whitelist.
Tue, Oct 23, 7:39 AM

Sun, Oct 21

pulkit updated the diff for D5174: py3: make sure we pass sysstr in sqlite3.connect().
Sun, Oct 21, 11:28 AM

Oct 20 2018

pulkit closed D5172: statprof: update the name as the i increases (issue6003).
Oct 20 2018, 3:14 AM
pulkit committed rHG4613f9274fc0: statprof: update the name as the i increases (issue6003).
statprof: update the name as the i increases (issue6003)
Oct 20 2018, 3:13 AM
pulkit committed rHG1ce4fe0603a6: test: show more profile lines in test-profile.t.
test: show more profile lines in test-profile.t
Oct 20 2018, 3:13 AM
pulkit closed D5171: test: show more profile lines in test-profile.t.
Oct 20 2018, 3:13 AM

Oct 19 2018

pulkit added a dependent revision for D5174: py3: make sure we pass sysstr in sqlite3.connect(): D5175: py3: add one more passing test to whitelist.
Oct 19 2018, 5:26 PM
pulkit created D5173: py3: make debugindexstats output printing compatible.
Oct 19 2018, 5:26 PM
pulkit created D5175: py3: add one more passing test to whitelist.
Oct 19 2018, 5:26 PM
pulkit created D5174: py3: make sure we pass sysstr in sqlite3.connect().
Oct 19 2018, 5:26 PM
pulkit added a dependent revision for D5173: py3: make debugindexstats output printing compatible: D5174: py3: make sure we pass sysstr in sqlite3.connect().
Oct 19 2018, 5:26 PM