Page MenuHomePhabricator

pulkit (Pulkit Goyal)
Spy

Projects

User Details

User Since
Jun 28 2017, 8:54 PM (158 w, 2 d)

Recent Activity

Today

pulkit committed rHG196ba4d4eb86: tests: update test-devel-warnings.t output with chg.
tests: update test-devel-warnings.t output with chg
Sat, Jul 11, 4:48 AM
pulkit added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Sat, Jul 11, 4:44 AM
D8726: test-clone-uncompressed: use config to silence the lock warning is now accepted and ready to land.
Sat, Jul 11, 4:21 AM
D8575: hooklib: fix detection of successors for changeset_obsoleted is now accepted and ready to land.
Sat, Jul 11, 4:18 AM

Yesterday

pulkit committed rHGc49e8aadd06e: tests: update test-devel-warnings.t output with chg.
tests: update test-devel-warnings.t output with chg
Fri, Jul 10, 10:55 PM
pulkit added inline comments to D8697: phases: sparsify phase lists.
Fri, Jul 10, 3:51 PM
D8723: fix: prefetch file contents is now accepted and ready to land.
Fri, Jul 10, 6:16 AM
D8722: fix: obtain base paths before starting workers is now accepted and ready to land.
Fri, Jul 10, 6:15 AM
D8720: tests: stablize test-serve.t on Windows is now accepted and ready to land.
Fri, Jul 10, 6:08 AM
D8645: clonebundles: optional memory-requirement attribution is now accepted and ready to land.
Fri, Jul 10, 6:03 AM
D8644: util: provide a helper function to estimate RAM size is now accepted and ready to land.
Fri, Jul 10, 6:02 AM
D8676: tests: allow timing difference in output is now accepted and ready to land.
Fri, Jul 10, 6:00 AM
pulkit added inline comments to D8575: hooklib: fix detection of successors for changeset_obsoleted.
Fri, Jul 10, 5:59 AM
D8711: documentation: add some internals documentation about bid merge is now accepted and ready to land.
Fri, Jul 10, 5:58 AM
D8721: scmutil: allowing different files to be prefetched per revision is now accepted and ready to land.
Fri, Jul 10, 5:56 AM
pulkit added a comment to D8631: scmutil: add writereporequirements() and route requires writing through it.

Gentle ping for review.

Fri, Jul 10, 4:30 AM

Thu, Jul 9

pulkit created D8719: mergestate: document mergestate records in an organized way.
Thu, Jul 9, 8:37 AM
pulkit created D8718: mergestate: remove unused unsupported related mergestate records.
Thu, Jul 9, 8:37 AM
pulkit created D8717: mergestate: add comments about couple of record types and minor reorder.
Thu, Jul 9, 8:37 AM
pulkit created D8716: mergestate: remove unrequired RECORD_RESOLVED_OTHER record.
Thu, Jul 9, 8:37 AM
pulkit created D8715: mergestate: rename addpath() -> addpathonflict() to prevent confusion.
Thu, Jul 9, 8:37 AM
pulkit added inline comments to D8709: commitctx: extract the function in a dedicated module.
Thu, Jul 9, 4:42 AM
D8708: commitctx: move a tiny else clause above the very long one is now accepted and ready to land.
Thu, Jul 9, 4:40 AM
D8707: commitctx: consider removed as touched is now accepted and ready to land.
Thu, Jul 9, 4:38 AM
D8706: commitctx: rename "changed" to touched is now accepted and ready to land.
Thu, Jul 9, 4:37 AM
D8705: commitctx: document the manifest writing function is now accepted and ready to land.
Thu, Jul 9, 4:36 AM
D8701: commitctx: reorder some conditional for efficiency in _filecommit is now accepted and ready to land.
Thu, Jul 9, 4:32 AM
pulkit added inline comments to D8700: commitctx: document a fast path in _filecommit.
Thu, Jul 9, 4:32 AM
D8699: commitctx: document _filecommit input and output is now accepted and ready to land.
Thu, Jul 9, 4:29 AM
pulkit added inline comments to D8699: commitctx: document _filecommit input and output.
Thu, Jul 9, 4:28 AM
D8695: phases: replace magic number by constant is now accepted and ready to land.
Thu, Jul 9, 4:12 AM

Tue, Jul 7

pulkit added inline comments to D8575: hooklib: fix detection of successors for changeset_obsoleted.
Tue, Jul 7, 2:25 PM
pulkit added a comment to D8353: debugcommands: create new debugantivirusrunning command.

I will go ahead and push it before upcoming rc if I hear no objections.

Tue, Jul 7, 2:20 PM
pulkit updated subscribers of D8691: hg: allow usage of XDG_CONFIG_HOME/hg/hgrc on OSX.

I looked up the the mail thread which introduced this change, unable to understand why this limitation is there. @durin42 any chance you remember?

Tue, Jul 7, 2:20 PM
D8692: hgignore: add mypy cache files is now accepted and ready to land.
Tue, Jul 7, 2:16 PM
D8683: revlog: avoid hard-coded hash sizes is now accepted and ready to land.

There are couple of other mentions of 40 in this file, looks like in future we should introduce a constant for this.

Tue, Jul 7, 2:15 PM
pulkit added a comment to D8676: tests: allow timing difference in output.

Seems like I know why this patch is required but some additional description in commit message as why this is required will be helpful.

Tue, Jul 7, 2:11 PM
pulkit added inline comments to D8645: clonebundles: optional memory-requirement attribution.
Tue, Jul 7, 2:11 PM
pulkit added inline comments to D8644: util: provide a helper function to estimate RAM size.
Tue, Jul 7, 2:08 PM
pulkit added a comment to D8670: repoview: use the phasecache directly to determine mutable revisions.

This one looks good as independent patch. Will be happy to push if you rebase it on default and send.

Tue, Jul 7, 2:02 PM
pulkit added a comment to D8654: phases: make phase list dense or dictionaries.

It's bit hard to review the patch since it seems that it consists multiple changes. I can see following ones:

Tue, Jul 7, 2:00 PM
D8678: test: restore expected output in test-persistent-nodemap.t is now accepted and ready to land.
Tue, Jul 7, 5:35 AM
pulkit created D8690: extdiff: add some comments in diffrevs().
Tue, Jul 7, 5:28 AM
pulkit created D8689: extdiff: add comments and minor variable renames diffpatch().
Tue, Jul 7, 5:28 AM
pulkit created D8688: extdiff: remove unrequired do3way argument to diffpatch().
Tue, Jul 7, 5:27 AM
pulkit created D8687: extdiff: refactor logic to diff revs of versions of files.
Tue, Jul 7, 5:27 AM
pulkit created D8685: patch: refactor content diffing part in separate fn so extensions can wrap.
Tue, Jul 7, 5:27 AM
pulkit created D8686: extdiff: refactor logic which does diff of patches.
Tue, Jul 7, 5:27 AM
pulkit accepted D8682: heptapod-ci: build rhg before tests run.
Tue, Jul 7, 4:35 AM
D8681: rhg: use a function in test-rhg.t instead of global alias is now accepted and ready to land.

Folding this too into a097299ed2a0.

Tue, Jul 7, 4:34 AM
D8680: rhg: fix test-rhg.t code style is now accepted and ready to land.

Folding it into a097299ed2a0.

Tue, Jul 7, 4:33 AM

Mon, Jul 6

pulkit committed rHG3862de62d5cf: chg: suppress OSError in _restoreio() and add some logging (issue6330).
chg: suppress OSError in _restoreio() and add some logging (issue6330)
Mon, Jul 6, 7:37 AM

Fri, Jul 3

pulkit committed rHG6118408bc3cc: chg: suppress OSError in _restoreio() and add some logging (issue6330).
chg: suppress OSError in _restoreio() and add some logging (issue6330)
Fri, Jul 3, 6:50 AM
pulkit planned changes to D8677: heptapod: use basename of tests in skiplist in CI (issue6351).
Fri, Jul 3, 6:26 AM
pulkit created D8677: heptapod: use basename of tests in skiplist in CI (issue6351).
Fri, Jul 3, 6:25 AM
D8675: ui: fix Python 2.7 support for ui.timestamp-output is now accepted and ready to land.
Fri, Jul 3, 3:58 AM

Thu, Jul 2

pulkit updated the diff for D8659: config: add `--share` flag to edit config file of shared source.
Thu, Jul 2, 7:18 AM
pulkit updated the diff for D8673: config: add a .hg/nonsharedrc which won't be shared in share-safe mode.
Thu, Jul 2, 7:18 AM
pulkit updated the diff for D8660: upgrade: support running upgrade if repository has share-safe requirement.
Thu, Jul 2, 7:17 AM
pulkit updated the summary of D8656: localrepo: load the share source .hg/hgrc also in share-safe mode.
Thu, Jul 2, 7:17 AM

Wed, Jul 1

pulkit committed rHG1fdc8cbd5fb8: Added signature for changeset 0ea9c86fac89.
Added signature for changeset 0ea9c86fac89
Wed, Jul 1, 2:17 PM
pulkit committed rHG99f818777f45: Added tag 5.4.2 for changeset 0ea9c86fac89.
Added tag 5.4.2 for changeset 0ea9c86fac89
Wed, Jul 1, 2:17 PM
pulkit updated the diff for D8659: config: add `--share` flag to edit config file of shared source.
Wed, Jul 1, 6:02 AM
pulkit created D8673: config: add a .hg/nonsharedrc which won't be shared in share-safe mode.
Wed, Jul 1, 6:02 AM
pulkit updated the diff for D8658: commands: use any() instead of `if a or b or c`.
Wed, Jul 1, 6:02 AM
pulkit updated the diff for D8633: share: introduce config option to store requires in .hg/store.
Wed, Jul 1, 6:02 AM
pulkit updated the diff for D8631: scmutil: add writereporequirements() and route requires writing through it.
Wed, Jul 1, 6:02 AM
pulkit updated the diff for D8656: localrepo: load the share source .hg/hgrc also in share-safe mode.
Wed, Jul 1, 6:01 AM
pulkit updated the diff for D8655: localrepo: unify share checking and related code.
Wed, Jul 1, 6:01 AM
pulkit updated the diff for D8647: run-tests: replace '#' with '-' in temp path of repos created for tests.
Wed, Jul 1, 6:00 AM

Mon, Jun 29

D8640: ui: add option to timestamp status and diagnostic messages is now accepted and ready to land.
Mon, Jun 29, 2:20 PM
pulkit added a comment to D8664: test: redirect stderr so warning messages don't cause changed output (issue6237).

Reworded the first line of commit message to test: redirect stderr so warning messages don't change output (issue6237) to make test-check-commit.t which was complaining that summary line too long.

Mon, Jun 29, 5:45 AM
pulkit added a comment to D8353: debugcommands: create new debugantivirusrunning command.

Sadly I have no idea on that.

Do we have a poor windows user that could serve an a guinea pig here ?

Mon, Jun 29, 4:48 AM
pulkit added inline comments to D8640: ui: add option to timestamp status and diagnostic messages.
Mon, Jun 29, 4:46 AM
D8671: version: sort extensions by name in verbose mode is now accepted and ready to land.
Mon, Jun 29, 4:44 AM
D8669: graft: leverage cmdutil.check_incompatible_arguments() for --abort/--stop is now accepted and ready to land.
Mon, Jun 29, 4:43 AM
D8668: graft: leverage cmdutil.check_incompatible_arguments() for --no-commit is now accepted and ready to land.
Mon, Jun 29, 4:43 AM
D8667: graft: leverage cmdutil.check_at_most_one_arg() for --abort/--stop/--continue is now accepted and ready to land.
Mon, Jun 29, 4:42 AM
D8666: locks: expect repo lock, not wlock, when writing to .hg/strip-backup/ is now accepted and ready to land.
Mon, Jun 29, 4:40 AM

Thu, Jun 25

pulkit added inline comments to D8640: ui: add option to timestamp status and diagnostic messages.
Thu, Jun 25, 10:56 AM
D8657: procutil: make recent fix for zombies compatible with py2 is now accepted and ready to land.
Thu, Jun 25, 10:52 AM
D8651: share: provide a more useful text for hg help is now accepted and ready to land.
Thu, Jun 25, 10:51 AM
D8665: merge: don't grab wlock when merging in memory is now accepted and ready to land.
Thu, Jun 25, 10:49 AM
D8664: test: redirect stderr so warning messages don't cause changed output (issue6237) is now accepted and ready to land.
Thu, Jun 25, 10:48 AM
pulkit created D8659: config: add `--share` flag to edit config file of shared source.
Thu, Jun 25, 4:55 AM
pulkit created D8658: commands: use any() instead of `if a or b or c`.
Thu, Jun 25, 4:54 AM
pulkit updated the summary of D8633: share: introduce config option to store requires in .hg/store.
Thu, Jun 25, 4:54 AM
pulkit created D8660: upgrade: support running upgrade if repository has share-safe requirement.
Thu, Jun 25, 4:54 AM
pulkit updated the diff for D8656: localrepo: load the share source .hg/hgrc also in share-safe mode.
Thu, Jun 25, 4:53 AM
pulkit updated the diff for D8655: localrepo: unify share checking and related code.
Thu, Jun 25, 4:53 AM

Wed, Jun 24

pulkit created D8656: localrepo: load the share source .hg/hgrc also in share-safe mode.
Wed, Jun 24, 10:31 AM
pulkit retitled D8631: scmutil: add writereporequirements() and route requires writing through it from localrepo: add writerequirements() and route requires writing through it to scmutil: add writereporequirements() and route requires writing through it.
Wed, Jun 24, 8:57 AM
pulkit updated the diff for D8633: share: introduce config option to store requires in .hg/store.
Wed, Jun 24, 8:57 AM
pulkit created D8655: localrepo: unify share checking and related code.
Wed, Jun 24, 8:56 AM

Tue, Jun 23

D8650: copies: implement __repr__ on branch_copies for debugging is now accepted and ready to land.
Tue, Jun 23, 5:01 AM
D8649: help: document meaning of '%' in graphlog output is now accepted and ready to land.
Tue, Jun 23, 4:57 AM

Mon, Jun 22

pulkit committed rHG62bdb288c449: tests: add hghave rule 'setprocname' to check if osutil.setprocname and use it.
tests: add hghave rule 'setprocname' to check if osutil.setprocname and use it
Mon, Jun 22, 6:21 AM
pulkit committed rHG7af5c1f5b3a0: util: flush stderr explicitly after using warnings.warn().
util: flush stderr explicitly after using warnings.warn()
Mon, Jun 22, 6:21 AM
pulkit committed rHGa28d1eca6507: tests: use proctutil.stdout.write() instead of print() in test-extension.t.
tests: use proctutil.stdout.write() instead of print() in test-extension.t
Mon, Jun 22, 6:21 AM
pulkit added a comment to D8648: [rhg] format code.

Folding this into D8611.

Mon, Jun 22, 5:49 AM