- User Since
- Jun 28 2017, 8:54 PM (134 w, 6 d)
I don't know about the code which this series touch, but since D7550 already made to 5.3rc, should this series be targeted for stable branch?
Mon, Jan 27
Sat, Jan 25
Converted line endings in tests/phabricator/phabsend-binary.json to unix ones in flight.
Fri, Jan 24
Looks like we don't have tests for hg merge 'wdir()'. Also I am not sure what should be the correct behavior in that case.
The logic looks fine, the code needs to be polished a bit and need some documentation. I left inline comments/nits. It will be nice to have the next version of this patch py3 compatible.
Thu, Jan 23
Wed, Jan 22
I also have experience with C-c thing. Will a config option which enables --no-verify by default will work for you?
Do we have user-facing documentation for these behavior? I tried to find documentation related to hooks but was unable to find any.
Tue, Jan 21
Mon, Jan 20
TBH it feels not correct that some code path of hg verify needs unfiltered repository and that too around renames. Reading tests, I first thought it's some bug in unamend and then checked the issue to realize it's a general problem.
I added a || false to normalize the exit code.
s/false/true in flight
Fri, Jan 17
Amending the following in flight to make test-check-format.t (or black) happy:
There are a descent odds that their will be needed too.
There are descent odds that they will be needed too.
"." is just an aliast for p1(wdir(),
"." is just an alias for p1(wdir()),
Amending the perf numbers in commit message and fixed some spellings.
Thu, Jan 16
This one fails to apply. Please rebase and resend.
Wed, Jan 15
Absorbing the following diff to make test-check-format.t happy: