- User Since
- Jun 28 2017, 3:19 PM (46 w, 6 d)
Thu, May 17
Tue, May 15
I think there is still some differences. Namely the integration with simplecache, which is helpful for performance. Is the core version has something similar?
Mon, May 14
I like this change. Didn't realize it's this simple. Marking as accetped.
Sun, May 13
Duplicated with D3538.
Apr 18 2018
Apr 16 2018
Apr 13 2018
Apr 12 2018
I think one alternative is just to use green_background like git/contrib/diff-highlight/diff-highlight.perl. It satisfies all properties I'd like to have, and is supported by weird terminals including cmd.exe and less.exe. And is different from diff.file_a, diff.file_b colors. I'll probably just use this.
Apr 11 2018
I thought it was for line in mdiff.splitnewlines(...). If we have both rawline and line variables, then it is easier.
Apr 10 2018
That's ideal. But a lot of code in this area expects "line" to not contain "\n". So the change won't be as easy as it looks.
Git first had a contrib/diff-highlight/diff-highlight script which inverts foreground/background for hunks with len(deleted_lines) = len(inserted_lines).
Apr 9 2018
I think it depends on what scripts want to do. I guess mpm's original point is, suppose you have a build script, or something that should do nothing if nothing changed, then hg amend && build_script just works as expected. If amend returns 0, then it'd be more complex to detect "nothing changed" case.
Returning 1 is actually more consistent with other core commands like pull, push, commit. See https://www.mercurial-scm.org/pipermail/mercurial-devel/2012-January/037711.html. Scripts should be updated to use $? explicitly.
This is the before and after comparison:
Apr 6 2018
It was revlog.revlog.size, and got changed to rawsize before committed.
Apr 5 2018
Thanks. I was not too happy about the old code using rev as nodes. But I didn't spend much time changing them.
Nice catch. I guess my initial consideration was oldrev was not always a valid node. But it seems no longer a concern.
Hmm... maybe just remove it.
Mar 20 2018
https://crates.io/crates/local-encoding seems to be the right choice.
Mar 17 2018
Mar 13 2018
Mar 10 2018
Mar 9 2018
I don't think the Python ".so"s should be consumed by non-Python "dlopen". So "version" doesn't change since Python API remains the same.
Mar 8 2018
Mar 7 2018
The patch sent to the git list was completely different from this one, because git has another layer xdiff-interface.c and trimming happens there. git also has some more complexity like context line handling, which is the hard part.
Mar 6 2018
I'll do the rebase (probably tomorrow). It will make the xdl_do_diff2 change unnecessary, and maybe rename prefix_lines etc to be more like the original code. But the main feature (xdl_trim_files) will probably stay unchanged and is worth a look now.