- User Since
- Jun 28 2017, 3:19 PM (59 w, 22 h)
Tue, Aug 14
Thu, Aug 9
To clarify, I do like stateless API is better. It can be done by keeping _lastannotate as a private cache inaccessible from other APIs, move annotateresult to the return value of annotate, then add arev to replacelines to verify the cache. The C code use brev instead of rev as the parameter name for a reason.
Tue, Aug 7
Mon, Aug 6
Fri, Aug 3
--stack should work as expected if dependency is set manually.
Thu, Aug 2
I'd also like to see C linelog benchmark data mentioned. The current commit message implies diff algorithm is the bottleneck. That's misleading.
Wed, Aug 1
I would mention in the commit message that building cache is much faster with linkrevcache prebuilt.
I think a most flexible solution is to not do the check if there is nothing to rebase.
Tue, Jul 31
FB has users reporting they need to split commits in the middle of a histedit. So this might be too restrictive.
Wed, Jul 25
Yeah, if only there is a json.loadb function. That could replace json.loads at line 211. I guess it could be done by using a function that recursively convert strings.
Tue, Jul 24
Jul 10 2018
Jun 21 2018
Not directly related to this patch. On API complexity: One of the unimplemented ideas is to require a transaction and make operation optional - default to the transaction name.
Jun 19 2018
Jun 16 2018
Since you mentioned Linux... Here is what your extension renders on my Linux terminal:
To be clear, I have no interest in +1 or -1 this feature, and I'm not interested in spending more time testing it. I think I have made it very clear that Windows (at least WSL) is going to be a headache. Not to say, Linux (as my primary OS) font rendering is another story that might surprise you.
Maybe I should change cmd.exe font. But here's what I got pasting the text into the console:
Jun 15 2018
Pushed. Thanks for keeping obsshelve up-to-date!
Jun 14 2018
Jun 13 2018
Jun 12 2018
Jun 6 2018
May 31 2018
May 17 2018
May 15 2018
I think there are still some differences. Namely the integration with simplecache, which is helpful for performance. Does the core version have something similar?
May 14 2018
I like this change. Didn't realize it's this simple. Marking as accetped.
May 13 2018
Duplicated with D3538.