quark (Jun Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 3:19 PM (46 w, 6 d)

Recent Activity

Thu, May 17

quark requested changes to D3565: sparse: delete now that it's in the core repo.
Thu, May 17, 6:46 PM

Tue, May 15

quark accepted D3566: commitextras: delete now that it's in the core repo.

Pushed. Thanks!

Tue, May 15, 8:12 PM
quark added a comment to D3565: sparse: delete now that it's in the core repo.

I think there is still some differences. Namely the integration with simplecache, which is helpful for performance. Is the core version has something similar?

Tue, May 15, 8:09 PM

Mon, May 14

quark accepted D3556: run-tests: update the test case name format.

I like this change. Didn't realize it's this simple. Marking as accetped.

Mon, May 14, 7:24 PM
quark accepted D3555: run-tests: add support for running specific test cases.
Mon, May 14, 7:24 PM

Sun, May 13

quark abandoned D3554: xdiff: fix Py_BuildValue types (issue5885).

Duplicated with D3538.

Sun, May 13, 2:52 PM
quark accepted D3538: bdiff: fix yet more fallout from xdiff long/int64 conversion (issue5885).
Sun, May 13, 2:52 PM
quark created D3554: xdiff: fix Py_BuildValue types (issue5885).
Sun, May 13, 2:48 PM

Apr 18 2018

quark accepted D3413: compat: add support for hg >= 33a6eee0.

Pushed. Thanks!

Apr 18 2018, 10:43 PM
quark accepted D3411: compat: add support for hg >= a81d02ea.
Apr 18 2018, 10:43 PM
quark accepted D3412: compat: add support for hg >= f3dc8239.
Apr 18 2018, 10:43 PM
quark accepted D3410: compat: add support for hg >= daef13da.
Apr 18 2018, 10:43 PM
quark accepted D3409: compat: add support for hg >= f99d64e8.
Apr 18 2018, 10:43 PM
quark accepted D3408: compat: add support for hg >= b235bde3.
Apr 18 2018, 10:43 PM
quark accepted D3407: fastannotate: drop unused "prefetchskip" argument.
Apr 18 2018, 10:43 PM

Apr 16 2018

quark closed D3212: patch: implement a new worddiff algorithm.
Apr 16 2018, 7:12 PM
quark closed D3211: patch: buffer lines for a same hunk.
Apr 16 2018, 7:12 PM
quark closed D3210: patch: move yielding "\n" to the end of loop.
Apr 16 2018, 7:12 PM
quark committed rHG35632d392279: patch: implement a new worddiff algorithm.
patch: implement a new worddiff algorithm
Apr 16 2018, 7:11 PM
quark committed rHG5471348921c1: patch: buffer lines for a same hunk.
patch: buffer lines for a same hunk
Apr 16 2018, 7:11 PM
quark committed rHG8d730f96e792: patch: move yielding "\n" to the end of loop.
patch: move yielding "\n" to the end of loop
Apr 16 2018, 7:11 PM

Apr 13 2018

quark accepted D3339: compatibility: add support for hg >= 5be286db.
Apr 13 2018, 8:23 PM
quark accepted D3340: compatibility: add support for hg >= 0596d274.

Pushed. Thanks!

Apr 13 2018, 8:23 PM

Apr 12 2018

quark added a comment to D3212: patch: implement a new worddiff algorithm.

I think one alternative is just to use green_background like git/contrib/diff-highlight/diff-highlight.perl. It satisfies all properties I'd like to have, and is supported by weird terminals including cmd.exe and less.exe. And is different from diff.file_a, diff.file_b colors. I'll probably just use this.

Apr 12 2018, 10:37 PM

Apr 11 2018

quark added a comment to D3210: patch: move yielding "\n" to the end of loop.

I thought it was for line in mdiff.splitnewlines(...). If we have both rawline and line variables, then it is easier.

Apr 11 2018, 6:08 PM
quark added a comment to D3212: patch: implement a new worddiff algorithm.
In D3212#51917, @yuja wrote:

Can you split a patch changing the color scheme so we can easily
back it out as needed?

Apr 11 2018, 5:07 PM

Apr 10 2018

quark added inline comments to D3212: patch: implement a new worddiff algorithm.
Apr 10 2018, 5:11 PM
quark added a comment to D3210: patch: move yielding "\n" to the end of loop.

That's ideal. But a lot of code in this area expects "line" to not contain "\n". So the change won't be as easy as it looks.

Apr 10 2018, 3:09 PM
quark added a comment to D3212: patch: implement a new worddiff algorithm.

Git first had a contrib/diff-highlight/diff-highlight script which inverts foreground/background for hunks with len(deleted_lines) = len(inserted_lines).

Apr 10 2018, 2:46 PM

Apr 9 2018

quark added inline comments to D3212: patch: implement a new worddiff algorithm.
Apr 9 2018, 9:57 PM
quark added a comment to D3209: amend: exit 0 if there are no changes.

I think it depends on what scripts want to do. I guess mpm's original point is, suppose you have a build script, or something that should do nothing if nothing changed, then hg amend && build_script just works as expected. If amend returns 0, then it'd be more complex to detect "nothing changed" case.

Apr 9 2018, 9:51 PM
quark added a comment to D3209: amend: exit 0 if there are no changes.

Returning 1 is actually more consistent with other core commands like pull, push, commit. See https://www.mercurial-scm.org/pipermail/mercurial-devel/2012-January/037711.html. Scripts should be updated to use $? explicitly.

Apr 9 2018, 7:37 PM
quark updated subscribers of D2668: rebase: introduce support for automatically rebasing orphan changes.

I like the way --auto (or some other name) is discoverable in hg help rebase. Losing that inside the long-form prose of the help text (which is the only place I can think of to document a magic rebase-specific revset?) seems like a bummer to me...

Apr 9 2018, 7:29 PM
quark added a comment to D3212: patch: implement a new worddiff algorithm.

This is the before and after comparison:

Apr 9 2018, 7:11 PM
quark added a reviewer for D3212: patch: implement a new worddiff algorithm: durin42.
Apr 9 2018, 7:00 PM
quark created D3212: patch: implement a new worddiff algorithm.
Apr 9 2018, 6:59 PM
quark created D3211: patch: buffer lines for a same hunk.
Apr 9 2018, 6:59 PM
quark created D3210: patch: move yielding "\n" to the end of loop.
Apr 9 2018, 6:59 PM
quark added a dependent revision for D3211: patch: buffer lines for a same hunk: D3212: patch: implement a new worddiff algorithm.
Apr 9 2018, 6:59 PM
quark added a dependent revision for D3210: patch: move yielding "\n" to the end of loop: D3211: patch: buffer lines for a same hunk.
Apr 9 2018, 6:59 PM

Apr 6 2018

quark added a comment to D3153: tests: call rawsize() directly.

It was revlog.revlog.size, and got changed to rawsize before committed.

Apr 6 2018, 4:01 PM

Apr 5 2018

quark accepted D3138: rebase: make "destnode" consistently a revnum and rename it to "destrev".

Thanks. I was not too happy about the old code using rev as nodes. But I didn't spend much time changing them.

Apr 5 2018, 1:59 PM
quark accepted D3139: rebase: convert "oldrev" to revnum earlier.

Nice catch. I guess my initial consideration was oldrev was not always a valid node. But it seems no longer a concern.

Apr 5 2018, 1:57 PM
quark accepted D3140: rebase: remove unnecessary and incorrect handling of nullid.

Hmm... maybe just remove it.

Apr 5 2018, 1:55 PM

Mar 20 2018

quark added a comment to D2057: rust implementation of hg status.

https://crates.io/crates/local-encoding seems to be the right choice.

Mar 20 2018, 3:23 PM

Mar 17 2018

quark committed rHGa2baa61bbb14: xdiff: move stdint.h to xdiff.h.
xdiff: move stdint.h to xdiff.h
Mar 17 2018, 1:52 PM

Mar 13 2018

quark closed D2848: xdiff: move stdint.h to xdiff.h.
Mar 13 2018, 8:05 PM
quark committed rHGafebb7588e95: xdiff: move stdint.h to xdiff.h.
xdiff: move stdint.h to xdiff.h
Mar 13 2018, 8:05 PM
quark created D2848: xdiff: move stdint.h to xdiff.h.
Mar 13 2018, 7:56 PM

Mar 10 2018

quark committed rHGe5b14f5b8b94: xdiff: resolve signed unsigned comparison warning.
xdiff: resolve signed unsigned comparison warning
Mar 10 2018, 1:21 PM
quark committed rHG49fe6249937a: xdiff: remove unused flags parameter.
xdiff: remove unused flags parameter
Mar 10 2018, 1:21 PM
quark committed rHGf0d9811dda8e: xdiff: remove unused xpp and xecfg parameters.
xdiff: remove unused xpp and xecfg parameters
Mar 10 2018, 1:21 PM
quark committed rHGf1ef0e53e628: xdiff: use int64 for hash table size.
xdiff: use int64 for hash table size
Mar 10 2018, 1:21 PM
quark committed rHG882657a9f768: xdiff: replace {unsigned ,}long with {u,}int64_t.
xdiff: replace {unsigned ,}long with {u,}int64_t
Mar 10 2018, 1:21 PM
quark committed rHGf33a87cf60cc: xdiff: add a preprocessing step that trims files.
xdiff: add a preprocessing step that trims files
Mar 10 2018, 1:21 PM
quark committed rHG0c7350656f93: xdiff: add comments for fields in xdfile_t.
xdiff: add comments for fields in xdfile_t
Mar 10 2018, 1:21 PM

Mar 9 2018

quark added a comment to D2763: xdiff: remove unused flags parameter.

I don't think the Python ".so"s should be consumed by non-Python "dlopen". So "version" doesn't change since Python API remains the same.

Mar 9 2018, 6:31 PM
quark closed D2762: xdiff: replace {unsigned ,}long with {u,}int64_t.
Mar 9 2018, 6:25 PM
quark closed D2766: xdiff: resolve signed unsigned comparison warning.
Mar 9 2018, 6:25 PM
quark committed rHG9ddc9aa26801: xdiff: resolve signed unsigned comparison warning.
xdiff: resolve signed unsigned comparison warning
Mar 9 2018, 6:25 PM
quark closed D2765: xdiff: use int64 for hash table size.
Mar 9 2018, 6:24 PM
quark closed D2763: xdiff: remove unused flags parameter.
Mar 9 2018, 6:24 PM
quark committed rHG71fbceb58746: xdiff: use int64 for hash table size.
xdiff: use int64 for hash table size
Mar 9 2018, 6:24 PM
quark closed D2764: xdiff: remove unused xpp and xecfg parameters.
Mar 9 2018, 6:24 PM
quark committed rHG4c8ffc67bac2: xdiff: remove unused flags parameter.
xdiff: remove unused flags parameter
Mar 9 2018, 6:24 PM
quark committed rHG2e2b48cca761: xdiff: remove unused xpp and xecfg parameters.
xdiff: remove unused xpp and xecfg parameters
Mar 9 2018, 6:24 PM
quark committed rHGe882437cc082: xdiff: replace {unsigned ,}long with {u,}int64_t.
xdiff: replace {unsigned ,}long with {u,}int64_t
Mar 9 2018, 6:24 PM
quark committed rHG58028f6d1fb8: xdiff: add comments for fields in xdfile_t.
xdiff: add comments for fields in xdfile_t
Mar 9 2018, 6:24 PM
quark closed D2685: xdiff: add comments for fields in xdfile_t.
Mar 9 2018, 6:24 PM
quark closed D2686: xdiff: add a preprocessing step that trims files.
Mar 9 2018, 6:24 PM
quark committed rHG665958f30789: xdiff: add a preprocessing step that trims files.
xdiff: add a preprocessing step that trims files
Mar 9 2018, 6:24 PM
quark edited dependencies for D2685: xdiff: add comments for fields in xdfile_t, added: 1; removed: 1.
Mar 9 2018, 5:56 PM
quark removed a dependent revision for D2684: xdiff: remove unused structure, functions, and constants: D2685: xdiff: add comments for fields in xdfile_t.
Mar 9 2018, 5:56 PM
quark added a dependent revision for D2686: xdiff: add a preprocessing step that trims files: D2685: xdiff: add comments for fields in xdfile_t.
Mar 9 2018, 5:56 PM
quark created D2762: xdiff: replace {unsigned ,}long with {u,}int64_t.
Mar 9 2018, 5:54 PM
quark created D2766: xdiff: resolve signed unsigned comparison warning.
Mar 9 2018, 5:54 PM
quark created D2763: xdiff: remove unused flags parameter.
Mar 9 2018, 5:54 PM
quark created D2765: xdiff: use int64 for hash table size.
Mar 9 2018, 5:54 PM
quark added a dependent revision for D2765: xdiff: use int64 for hash table size: D2766: xdiff: resolve signed unsigned comparison warning.
Mar 9 2018, 5:54 PM
quark created D2764: xdiff: remove unused xpp and xecfg parameters.
Mar 9 2018, 5:54 PM
quark updated the diff for D2686: xdiff: add a preprocessing step that trims files.
Mar 9 2018, 5:54 PM
quark added a dependent revision for D2763: xdiff: remove unused flags parameter: D2764: xdiff: remove unused xpp and xecfg parameters.
Mar 9 2018, 5:54 PM
quark added a dependent revision for D2762: xdiff: replace {unsigned ,}long with {u,}int64_t: D2763: xdiff: remove unused flags parameter.
Mar 9 2018, 5:54 PM
quark added a dependent revision for D2685: xdiff: add comments for fields in xdfile_t: D2762: xdiff: replace {unsigned ,}long with {u,}int64_t.
Mar 9 2018, 5:54 PM
quark updated the diff for D2685: xdiff: add comments for fields in xdfile_t.
Mar 9 2018, 5:54 PM
quark added inline comments to D2686: xdiff: add a preprocessing step that trims files.
Mar 9 2018, 3:40 PM

Mar 8 2018

quark accepted D2728: rebase: also include commit of collapsed commits in single transaction.
Mar 8 2018, 5:15 PM

Mar 7 2018

quark accepted D2715: backups: make compatible with hg core >= c8e2d6ed1f9e.
Mar 7 2018, 7:26 PM
quark updated the summary of D2686: xdiff: add a preprocessing step that trims files.
Mar 7 2018, 5:45 PM
quark updated the diff for D2686: xdiff: add a preprocessing step that trims files.
Mar 7 2018, 5:41 PM
quark added a comment to D2686: xdiff: add a preprocessing step that trims files.

The patch sent to the git list was completely different from this one, because git has another layer xdiff-interface.c and trimming happens there. git also has some more complexity like context line handling, which is the hard part.

Mar 7 2018, 1:06 AM

Mar 6 2018

quark added a comment to D2686: xdiff: add a preprocessing step that trims files.

I'll do the rebase (probably tomorrow). It will make the xdl_do_diff2 change unnecessary, and maybe rename prefix_lines etc to be more like the original code. But the main feature (xdl_trim_files) will probably stay unchanged and is worth a look now.

Mar 6 2018, 11:04 PM
quark committed rHG04d64163039a: fuzz: fix xdiff build.
fuzz: fix xdiff build
Mar 6 2018, 10:33 PM
quark closed D2707: fuzz: fix xdiff build.
Mar 6 2018, 10:33 PM
quark created D2707: fuzz: fix xdiff build.
Mar 6 2018, 10:31 PM
quark closed D2705: xdiff: remove xemit related logic.
Mar 6 2018, 10:12 PM
quark closed D2706: xdiff: remove xmerge related logic.
Mar 6 2018, 10:12 PM
quark closed D2684: xdiff: remove unused structure, functions, and constants.
Mar 6 2018, 10:12 PM
quark committed rHG3cf40112efb7: xdiff: remove xmerge related logic.
xdiff: remove xmerge related logic
Mar 6 2018, 10:12 PM
quark committed rHG90f8fe72446c: xdiff: remove xemit related logic.
xdiff: remove xemit related logic
Mar 6 2018, 10:12 PM