Page MenuHomePhabricator

quark (Jun Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 3:19 PM (143 w, 6 d)

Recent Activity

Feb 16 2020

quark abandoned D1594: prune: only prompt uncommit when revs = ['.'].
Feb 16 2020, 8:36 PM
quark abandoned D1714: distutils_rust: use atomic replace to install the .so file.
Feb 16 2020, 8:35 PM

Jan 31 2020

quark added a comment to D7295: pytype: add a (very slow) test that executes pytype.

No, initially because I'd never heard of it, but now because I don't want to deal with ocaml. :)

Jan 31 2020, 2:58 PM
quark added a comment to D7295: pytype: add a (very slow) test that executes pytype.

Have pyre been considered? It seems pyre only takes 10 seconds to check all the .py files.

Jan 31 2020, 12:15 AM

Jan 30 2020

quark added a comment to D8039: chg: force-set LC_CTYPE on server start to actual value from the environment.

What do you think about this approach:

Jan 30 2020, 10:50 AM

Jan 9 2020

quark added a comment to D7812: examples: specify rustfmt nightly using a $() construct.

You can use rustfmt +nightly if it's installed by rustup. It also runs on Windows.

Jan 9 2020, 1:52 AM

Dec 13 2019

quark added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

--rev seems ambiguous since there might be different kinds of revisions to specify - target and revisions to edit. Maybe something like --source, --from, --target?

Dec 13 2019, 1:21 PM

Dec 7 2019

quark added a comment to D7582: hg-core: run rustfmt on configparser.

We actually ran rustfmt, but it's an older version (rustfmt 1.3.0-stable (d334502 2019-06-09)) and I verified the code still formats under that particular version of rustfmt with empty rustfmt.toml. In other words, rustfmt itself seems to change over time.

Dec 7 2019, 6:32 PM
quark added inline comments to D7575: hg-core: vendor Facebook's configparser crate.
Dec 7 2019, 6:06 PM
quark added a comment to D1518: nodemap: move some methods to changelog utils.

No longer use this approach.

Dec 7 2019, 2:14 AM
quark abandoned D1519: childmap: add a map for efficient children query.
Dec 7 2019, 2:13 AM
quark added a comment to D1520: clindex: integrate Rust childmap.

No longer use this approach.

Dec 7 2019, 2:13 AM
quark added a comment to D1521: clindex: use childmap to calculate phases.

Took another approach.

Dec 7 2019, 2:13 AM
quark added a comment to D1665: perftweaks: pass a correct revgen to branchcache.update.

No longer needed.

Dec 7 2019, 2:12 AM

Dec 3 2019

quark committed rHGaef7b043a36f: test-doctest: include dateutil.
test-doctest: include dateutil
Dec 3 2019, 10:59 AM
quark committed rHGb65bd4b61d78: dateutil: correct default for Ymd in parsedate.
dateutil: correct default for Ymd in parsedate
Dec 3 2019, 10:59 AM
quark committed rHG2e30d7df4809: revlog: fix revset in reachableroots docstring.
revlog: fix revset in reachableroots docstring
Dec 3 2019, 10:59 AM

Nov 26 2019

quark closed D7518: revlog: fix revset in reachableroots docstring.
Nov 26 2019, 9:48 AM
quark closed D7520: dateutil: correct default for Ymd in parsedate.
Nov 26 2019, 9:48 AM
quark committed rHGaef7b91dba51: dateutil: correct default for Ymd in parsedate.
dateutil: correct default for Ymd in parsedate
Nov 26 2019, 9:48 AM
quark committed rHG92518ca66c76: test-doctest: include dateutil.
test-doctest: include dateutil
Nov 26 2019, 9:48 AM
quark closed D7519: test-doctest: include dateutil.
Nov 26 2019, 9:48 AM
quark committed rHG1a42f8451a92: revlog: fix revset in reachableroots docstring.
revlog: fix revset in reachableroots docstring
Nov 26 2019, 9:48 AM

Nov 25 2019

quark created D7520: dateutil: correct default for Ymd in parsedate.
Nov 25 2019, 3:50 PM
quark created D7519: test-doctest: include dateutil.
Nov 25 2019, 3:50 PM
quark created D7518: revlog: fix revset in reachableroots docstring.
Nov 25 2019, 3:08 PM

Oct 3 2018

quark accepted D4871: remotefilelog: fix subtle bug I introduced in emitrevisions.

Pushed. Thanks!

Oct 3 2018, 9:52 PM

Sep 13 2018

quark accepted D4583: shallowbundle: dump this revision prefetching logic.

Pushed. Thanks!

Sep 13 2018, 6:12 PM
quark accepted D4581: remotefilelog: update for core changegroup packing changes.
Sep 13 2018, 6:12 PM
quark added inline comments to D4579: basestore: stop looking at the Nth item of an N-length revlog.
Sep 13 2018, 3:40 PM
quark added a comment to D4561: tests: accept new hg output about local changesets being published.

If backward compatibility is a concern, then there are way too many places that need change.

Sep 13 2018, 3:38 PM
quark added a comment to D4560: remotefilelogserver: use modern pattern for registering commands.

No, hg-experimental didn't care about compatibility with older Mercurial. Otherwise the code would be a mess.

Sep 13 2018, 3:36 PM
quark accepted D4580: shallowrepo: use correct api to get manifestlog storage if available.

Pushed these. Thanks!

Sep 13 2018, 3:32 PM
quark accepted D4579: basestore: stop looking at the Nth item of an N-length revlog.
Sep 13 2018, 3:32 PM
quark accepted D4578: remotefilelogserver: allow signature of generatefiles() to change.
Sep 13 2018, 3:32 PM
quark accepted D4577: remotefilelogserver: adapt for there being only one cgpacker.
Sep 13 2018, 3:32 PM
quark accepted D4561: tests: accept new hg output about local changesets being published.
Sep 13 2018, 3:32 PM
quark accepted D4559: cleanup: only look for the capabilities we care about in tests.
Sep 13 2018, 3:32 PM
quark accepted D4560: remotefilelogserver: use modern pattern for registering commands.
Sep 13 2018, 3:32 PM
quark accepted D4558: tests: update remotefilelog http test to require two fetches.
Sep 13 2018, 3:32 PM
quark requested changes to D4581: remotefilelog: update for core changegroup packing changes.
Sep 13 2018, 3:30 PM

Sep 4 2018

quark accepted D4464: drawdag: correctly pass repo to super constructor.

LGTM

Sep 4 2018, 10:05 PM

Aug 29 2018

quark accepted D4415: smartlog: use logcmdutil when hg >= 4.6.

Pushed. Thanks!

Aug 29 2018, 6:55 PM
quark added a comment to D4415: smartlog: use logcmdutil when hg >= 4.6.

Thanks for the change! A more common way to handle this is to catch ImportError to detect old versions, and try to deal with the divergence at import time:

Aug 29 2018, 3:09 PM

Aug 14 2018

quark accepted D4260: shallowbundle: work with hg 4c99c6d1 which consolidated cg#packer -> cgpacker.

Pushed. Thanks!

Aug 14 2018, 8:39 PM

Aug 9 2018

quark added a comment to D4150: linelog: optimize replacelines.

To clarify, I do think stateless API is better. It can be done by keeping _lastannotate as a private cache inaccessible from other APIs, move annotateresult to the return value of annotate, then add arev to replacelines to verify the cache. The C code use brev instead of rev as the parameter name for a reason.

Aug 9 2018, 6:12 PM
quark closed D4148: perf: add a command to benchmark linelog edits.
Aug 9 2018, 2:07 PM
quark closed D4150: linelog: optimize replacelines.
Aug 9 2018, 2:06 PM
quark committed rHGee97f7a677f3: linelog: optimize replacelines.
linelog: optimize replacelines
Aug 9 2018, 2:06 PM
quark committed rHG32b1967b8734: linelog: extract `len(self._program)` to a local function.
linelog: extract `len(self._program)` to a local function
Aug 9 2018, 2:06 PM
quark closed D4149: linelog: extract `len(self._program)` to a local function.
Aug 9 2018, 2:06 PM
quark committed rHG1601afbb573c: perf: add a command to benchmark linelog edits.
perf: add a command to benchmark linelog edits
Aug 9 2018, 2:06 PM
quark committed rHGc10be3fc200b: linelog: update internal help text.
linelog: update internal help text
Aug 9 2018, 2:06 PM
quark closed D4147: linelog: update internal help text.
Aug 9 2018, 2:06 PM

Aug 7 2018

quark updated the diff for D4148: perf: add a command to benchmark linelog edits.
Aug 7 2018, 8:23 PM
quark updated the diff for D4150: linelog: optimize replacelines.
Aug 7 2018, 8:22 PM
quark updated the diff for D4149: linelog: extract `len(self._program)` to a local function.
Aug 7 2018, 8:22 PM
quark updated the diff for D4147: linelog: update internal help text.
Aug 7 2018, 8:22 PM
quark added inline comments to D4148: perf: add a command to benchmark linelog edits.
Aug 7 2018, 8:15 PM
quark updated the diff for D4148: perf: add a command to benchmark linelog edits.
Aug 7 2018, 12:01 PM
quark committed rHG27a54096c92e: linelog: fix infinite loop vulnerability.
linelog: fix infinite loop vulnerability
Aug 7 2018, 8:52 AM
quark closed D4151: linelog: fix infinite loop vulnerability.
Aug 7 2018, 8:52 AM
quark updated the summary of D4151: linelog: fix infinite loop vulnerability.
Aug 7 2018, 1:31 AM
quark updated the diff for D4151: linelog: fix infinite loop vulnerability.
Aug 7 2018, 1:29 AM
quark created D4151: linelog: fix infinite loop vulnerability.
Aug 7 2018, 1:25 AM

Aug 6 2018

quark updated the summary of D4150: linelog: optimize replacelines.
Aug 6 2018, 11:05 PM
quark accepted D4030: unionstores: optionally retry *all* stores before raising KeyError.

Pushed. Thanks!

Aug 6 2018, 10:46 PM
quark accepted D4029: unionstores: use a shared base class for content and metadata union stores.
Aug 6 2018, 10:46 PM
quark updated the summary of D4150: linelog: optimize replacelines.
Aug 6 2018, 10:35 PM
quark updated the diff for D4147: linelog: update internal help text.
Aug 6 2018, 10:04 PM
quark updated the diff for D4149: linelog: extract `len(self._program)` to a local function.
Aug 6 2018, 10:04 PM
quark created D4150: linelog: optimize replacelines.
Aug 6 2018, 10:00 PM
quark created D4148: perf: add a command to benchmark linelog edits.
Aug 6 2018, 10:00 PM
quark created D4149: linelog: extract `len(self._program)` to a local function.
Aug 6 2018, 10:00 PM
quark created D4147: linelog: update internal help text.
Aug 6 2018, 9:59 PM

Aug 3 2018

quark added a comment to D4049: testrunner: allow multiple #testcases.

--stack should work as expected if dependency is set manually.

Aug 3 2018, 2:16 AM
quark added a comment to D4049: testrunner: allow multiple #testcases.

Sorry, I was just misremembering that D4052 had been queued. I don't know why phabricator doesn't understand that this patch is on top of D4052. Anyway, try applying D4052 first, then this one.

Aug 3 2018, 2:01 AM

Aug 2 2018

quark updated the summary of D3994: fastannotate: initial import from Facebook's hg-experimental.
Aug 2 2018, 8:52 PM
quark updated the summary of D3994: fastannotate: initial import from Facebook's hg-experimental.
Aug 2 2018, 6:56 PM
quark updated the summary of D3994: fastannotate: initial import from Facebook's hg-experimental.
Aug 2 2018, 6:43 PM
quark added a comment to D3994: fastannotate: initial import from Facebook's hg-experimental.

I'd also like to see C linelog benchmark data mentioned. The current commit message implies diff algorithm is the bottleneck. That's misleading.

Aug 2 2018, 4:17 PM

Aug 1 2018

quark added a comment to D3994: fastannotate: initial import from Facebook's hg-experimental.

I would mention in the commit message that building cache is much faster with linkrevcache prebuilt.

Aug 1 2018, 11:45 AM
quark added a comment to D3986: split: abort if there's an unfinished operation.

I think a most flexible solution is to not do the check if there is nothing to rebase.

Aug 1 2018, 11:35 AM

Jul 31 2018

quark added a comment to D3986: split: abort if there's an unfinished operation.

FB has users reporting they need to split commits in the middle of a histedit. So this might be too restrictive.

Jul 31 2018, 1:16 AM

Jul 25 2018

quark added a comment to D3980: contrib/phabricator: Convert description into local.

Yeah, if only there is a json.loadb function. That could replace json.loads at line 211. I guess it could be done by using a function that recursively convert strings.

Jul 25 2018, 9:20 PM

Jul 24 2018

quark accepted D3973: githelp: stop passing partial nodeid to repo.__contains__.

Pushed. Thanks!

Jul 24 2018, 2:26 AM
quark accepted D3971: chistedit: adapt to moved cmdutil.show_changeset().
Jul 24 2018, 2:26 AM
quark accepted D3972: backups: stop passing partial nodeid to repo.__contains__.
Jul 24 2018, 2:26 AM

Jul 10 2018

quark committed rFBHGX6d4d0eb3b82d: absorb: use fctx.isbinary() instead of isbinary(fctx.data()).
absorb: use fctx.isbinary() instead of isbinary(fctx.data())
Jul 10 2018, 6:46 PM
quark accepted D3914: lfs: delete now that it's in upstream.
Jul 10 2018, 5:55 PM
quark accepted D3913: infinitepush: delete now that it's in upstream.
Jul 10 2018, 5:55 PM
quark accepted D3902: prefetch: do not attempt to prefetch treemanifests as files.
Jul 10 2018, 5:53 PM
quark added inline comments to D3906: absorb: adapt for moved util.binary().
Jul 10 2018, 5:53 PM
quark accepted D3912: chistedit: adapt for moved util.shortuser().
Jul 10 2018, 5:53 PM
quark accepted D3911: remotefilelog: adapt for moved util.shellquote().
Jul 10 2018, 5:53 PM
quark accepted D3910: remotefilelog: adapt for moved util.p4open().
Jul 10 2018, 5:53 PM
quark accepted D3909: treemanifest: adapt to Mercurial without wireproto module.
Jul 10 2018, 5:53 PM
quark accepted D3907: treemanifest: add a _narrowmatch attribute on treemanifestlog.
Jul 10 2018, 5:53 PM
quark accepted D3908: remotefilelog: use new commandexecutor API even if we don't need batching.
Jul 10 2018, 5:53 PM
quark accepted D3905: remotefilelog: adapt for removed filelog.ancestors().
Jul 10 2018, 5:53 PM