quark (Jun Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 3:19 PM (68 w, 4 d)

Recent Activity

Wed, Oct 3

quark accepted D4871: remotefilelog: fix subtle bug I introduced in emitrevisions.

Pushed. Thanks!

Wed, Oct 3, 9:52 PM

Sep 13 2018

quark accepted D4583: shallowbundle: dump this revision prefetching logic.

Pushed. Thanks!

Sep 13 2018, 6:12 PM
quark accepted D4581: remotefilelog: update for core changegroup packing changes.
Sep 13 2018, 6:12 PM
quark added inline comments to D4579: basestore: stop looking at the Nth item of an N-length revlog.
Sep 13 2018, 3:40 PM
quark added a comment to D4561: tests: accept new hg output about local changesets being published.

If backward compatibility is a concern, then there are way too many places that need change.

Sep 13 2018, 3:38 PM
quark added a comment to D4560: remotefilelogserver: use modern pattern for registering commands.

No, hg-experimental didn't care about compatibility with older Mercurial. Otherwise the code would be a mess.

Sep 13 2018, 3:36 PM
quark accepted D4580: shallowrepo: use correct api to get manifestlog storage if available.

Pushed these. Thanks!

Sep 13 2018, 3:32 PM
quark accepted D4579: basestore: stop looking at the Nth item of an N-length revlog.
Sep 13 2018, 3:32 PM
quark accepted D4578: remotefilelogserver: allow signature of generatefiles() to change.
Sep 13 2018, 3:32 PM
quark accepted D4577: remotefilelogserver: adapt for there being only one cgpacker.
Sep 13 2018, 3:32 PM
quark accepted D4561: tests: accept new hg output about local changesets being published.
Sep 13 2018, 3:32 PM
quark accepted D4559: cleanup: only look for the capabilities we care about in tests.
Sep 13 2018, 3:32 PM
quark accepted D4560: remotefilelogserver: use modern pattern for registering commands.
Sep 13 2018, 3:32 PM
quark accepted D4558: tests: update remotefilelog http test to require two fetches.
Sep 13 2018, 3:32 PM
quark requested changes to D4581: remotefilelog: update for core changegroup packing changes.
Sep 13 2018, 3:30 PM

Sep 4 2018

quark accepted D4464: drawdag: correctly pass repo to super constructor.

LGTM

Sep 4 2018, 10:05 PM

Aug 29 2018

quark accepted D4415: smartlog: use logcmdutil when hg >= 4.6.

Pushed. Thanks!

Aug 29 2018, 6:55 PM
quark added a comment to D4415: smartlog: use logcmdutil when hg >= 4.6.

Thanks for the change! A more common way to handle this is to catch ImportError to detect old versions, and try to deal with the divergence at import time:

Aug 29 2018, 3:09 PM

Aug 14 2018

quark accepted D4260: shallowbundle: work with hg 4c99c6d1 which consolidated cg#packer -> cgpacker.

Pushed. Thanks!

Aug 14 2018, 8:39 PM

Aug 9 2018

quark added a comment to D4150: linelog: optimize replacelines.

To clarify, I do think stateless API is better. It can be done by keeping _lastannotate as a private cache inaccessible from other APIs, move annotateresult to the return value of annotate, then add arev to replacelines to verify the cache. The C code use brev instead of rev as the parameter name for a reason.

Aug 9 2018, 6:12 PM
quark closed D4148: perf: add a command to benchmark linelog edits.
Aug 9 2018, 2:07 PM
quark closed D4150: linelog: optimize replacelines.
Aug 9 2018, 2:06 PM
quark committed rHGee97f7a677f3: linelog: optimize replacelines.
linelog: optimize replacelines
Aug 9 2018, 2:06 PM
quark committed rHG32b1967b8734: linelog: extract `len(self._program)` to a local function.
linelog: extract `len(self._program)` to a local function
Aug 9 2018, 2:06 PM
quark closed D4149: linelog: extract `len(self._program)` to a local function.
Aug 9 2018, 2:06 PM
quark committed rHG1601afbb573c: perf: add a command to benchmark linelog edits.
perf: add a command to benchmark linelog edits
Aug 9 2018, 2:06 PM
quark committed rHGc10be3fc200b: linelog: update internal help text.
linelog: update internal help text
Aug 9 2018, 2:06 PM
quark closed D4147: linelog: update internal help text.
Aug 9 2018, 2:06 PM

Aug 7 2018

quark updated the diff for D4148: perf: add a command to benchmark linelog edits.
Aug 7 2018, 8:23 PM
quark updated the diff for D4150: linelog: optimize replacelines.
Aug 7 2018, 8:22 PM
quark updated the diff for D4149: linelog: extract `len(self._program)` to a local function.
Aug 7 2018, 8:22 PM
quark updated the diff for D4147: linelog: update internal help text.
Aug 7 2018, 8:22 PM
quark added inline comments to D4148: perf: add a command to benchmark linelog edits.
Aug 7 2018, 8:15 PM
quark updated the diff for D4148: perf: add a command to benchmark linelog edits.
Aug 7 2018, 12:01 PM
quark committed rHG27a54096c92e: linelog: fix infinite loop vulnerability.
linelog: fix infinite loop vulnerability
Aug 7 2018, 8:52 AM
quark closed D4151: linelog: fix infinite loop vulnerability.
Aug 7 2018, 8:52 AM
quark updated the summary of D4151: linelog: fix infinite loop vulnerability.
Aug 7 2018, 1:31 AM
quark updated the diff for D4151: linelog: fix infinite loop vulnerability.
Aug 7 2018, 1:29 AM
quark created D4151: linelog: fix infinite loop vulnerability.
Aug 7 2018, 1:25 AM

Aug 6 2018

quark updated the summary of D4150: linelog: optimize replacelines.
Aug 6 2018, 11:05 PM
quark accepted D4030: unionstores: optionally retry *all* stores before raising KeyError.

Pushed. Thanks!

Aug 6 2018, 10:46 PM
quark accepted D4029: unionstores: use a shared base class for content and metadata union stores.
Aug 6 2018, 10:46 PM
quark updated the summary of D4150: linelog: optimize replacelines.
Aug 6 2018, 10:35 PM
quark updated the diff for D4147: linelog: update internal help text.
Aug 6 2018, 10:04 PM
quark updated the diff for D4149: linelog: extract `len(self._program)` to a local function.
Aug 6 2018, 10:04 PM
quark created D4150: linelog: optimize replacelines.
Aug 6 2018, 10:00 PM
quark created D4148: perf: add a command to benchmark linelog edits.
Aug 6 2018, 10:00 PM
quark added a dependent revision for D4149: linelog: extract `len(self._program)` to a local function: D4150: linelog: optimize replacelines.
Aug 6 2018, 10:00 PM
quark created D4149: linelog: extract `len(self._program)` to a local function.
Aug 6 2018, 10:00 PM
quark added a dependent revision for D4148: perf: add a command to benchmark linelog edits: D4149: linelog: extract `len(self._program)` to a local function.
Aug 6 2018, 10:00 PM
quark added a dependent revision for D4147: linelog: update internal help text: D4148: perf: add a command to benchmark linelog edits.
Aug 6 2018, 9:59 PM
quark created D4147: linelog: update internal help text.
Aug 6 2018, 9:59 PM

Aug 3 2018

quark added a comment to D4049: testrunner: allow multiple #testcases.

--stack should work as expected if dependency is set manually.

Aug 3 2018, 2:16 AM
quark added a comment to D4049: testrunner: allow multiple #testcases.

Sorry, I was just misremembering that D4052 had been queued. I don't know why phabricator doesn't understand that this patch is on top of D4052. Anyway, try applying D4052 first, then this one.

Aug 3 2018, 2:01 AM

Aug 2 2018

quark updated the summary of D3994: fastannotate: initial import from Facebook's hg-experimental.
Aug 2 2018, 8:52 PM
quark updated the summary of D3994: fastannotate: initial import from Facebook's hg-experimental.
Aug 2 2018, 6:56 PM
quark updated the summary of D3994: fastannotate: initial import from Facebook's hg-experimental.
Aug 2 2018, 6:43 PM
quark added a comment to D3994: fastannotate: initial import from Facebook's hg-experimental.

I'd also like to see C linelog benchmark data mentioned. The current commit message implies diff algorithm is the bottleneck. That's misleading.

Aug 2 2018, 4:17 PM

Aug 1 2018

quark added a comment to D3994: fastannotate: initial import from Facebook's hg-experimental.

I would mention in the commit message that building cache is much faster with linkrevcache prebuilt.

Aug 1 2018, 11:45 AM
quark added a comment to D3986: split: abort if there's an unfinished operation.

I think a most flexible solution is to not do the check if there is nothing to rebase.

Aug 1 2018, 11:35 AM

Jul 31 2018

quark added a comment to D3986: split: abort if there's an unfinished operation.

FB has users reporting they need to split commits in the middle of a histedit. So this might be too restrictive.

Jul 31 2018, 1:16 AM

Jul 25 2018

quark added a comment to D3980: contrib/phabricator: Convert description into local.

Yeah, if only there is a json.loadb function. That could replace json.loads at line 211. I guess it could be done by using a function that recursively convert strings.

Jul 25 2018, 9:20 PM

Jul 24 2018

quark accepted D3973: githelp: stop passing partial nodeid to repo.__contains__.

Pushed. Thanks!

Jul 24 2018, 2:26 AM
quark accepted D3971: chistedit: adapt to moved cmdutil.show_changeset().
Jul 24 2018, 2:26 AM
quark accepted D3972: backups: stop passing partial nodeid to repo.__contains__.
Jul 24 2018, 2:26 AM

Jul 10 2018

quark committed rFBHGX6d4d0eb3b82d: absorb: use fctx.isbinary() instead of isbinary(fctx.data()).
absorb: use fctx.isbinary() instead of isbinary(fctx.data())
Jul 10 2018, 6:46 PM
quark accepted D3914: lfs: delete now that it's in upstream.
Jul 10 2018, 5:55 PM
quark accepted D3913: infinitepush: delete now that it's in upstream.
Jul 10 2018, 5:55 PM
quark accepted D3902: prefetch: do not attempt to prefetch treemanifests as files.
Jul 10 2018, 5:53 PM
quark added inline comments to D3906: absorb: adapt for moved util.binary().
Jul 10 2018, 5:53 PM
quark accepted D3912: chistedit: adapt for moved util.shortuser().
Jul 10 2018, 5:53 PM
quark accepted D3911: remotefilelog: adapt for moved util.shellquote().
Jul 10 2018, 5:53 PM
quark accepted D3910: remotefilelog: adapt for moved util.p4open().
Jul 10 2018, 5:53 PM
quark accepted D3909: treemanifest: adapt to Mercurial without wireproto module.
Jul 10 2018, 5:53 PM
quark accepted D3907: treemanifest: add a _narrowmatch attribute on treemanifestlog.
Jul 10 2018, 5:53 PM
quark accepted D3908: remotefilelog: use new commandexecutor API even if we don't need batching.
Jul 10 2018, 5:53 PM
quark accepted D3905: remotefilelog: adapt for removed filelog.ancestors().
Jul 10 2018, 5:53 PM
quark accepted D3906: absorb: adapt for moved util.binary().
Jul 10 2018, 5:53 PM
quark accepted D3904: remotefilelog: adapt for new peer._sendrequest().
Jul 10 2018, 5:53 PM
quark accepted D3903: sparse: adjust for moved cmdutil._logrevs().
Jul 10 2018, 5:53 PM

Jun 21 2018

quark added a comment to D3818: scmutil: make cleanupnodes optionally also fix the phase.

Not directly related to this patch. On API complexity: One of the unimplemented ideas is to require a transaction and make operation optional - default to the transaction name.

Jun 21 2018, 2:40 AM

Jun 19 2018

quark accepted D3813: absorb: make --dry-run imply --print-changes.

Pushed. Thanks!

Jun 19 2018, 1:42 AM

Jun 16 2018

quark added a comment to D3665: graph: improve graph output by using Unicode characters.

Looks like your font is missing the dashed vertical line, and has an oddly small regular-circle glyph. I don't recognize the font at all so I can't really speak much more to that. Fortunately though...

(a) it's an extension which isn't on by default
(b) your font choices are your own. That doesn't look like any default font I've ever seen, so this is unlikely to affect many others

Jun 16 2018, 4:17 PM
quark added a comment to D3665: graph: improve graph output by using Unicode characters.

Since you mentioned Linux... Here is what your extension renders on my Linux terminal:

Jun 16 2018, 3:42 PM
quark added a comment to D3665: graph: improve graph output by using Unicode characters.

To be clear, I have no interest in +1 or -1 this feature, and I'm not interested in spending more time testing it. I think I have made it very clear that Windows (at least WSL) is going to be a headache. Not to say, Linux (as my primary OS) font rendering is another story that might surprise you.

Jun 16 2018, 3:08 PM
quark added a comment to D3665: graph: improve graph output by using Unicode characters.

Are you capable of running the extension?

The output of type is irrelevant to me. The behavior of python.exe when outputting to the Windows shell is all that really matters here. If encoding.encoding reports UTF8, it should work or there's an Hg issue. If it reports something else, the extension will disable itself anyway.

Jun 16 2018, 2:10 PM
quark added a comment to D3665: graph: improve graph output by using Unicode characters.

Without more context I have no idea what you are trying to show. Windows is
certainly capable of rendering Unicode characters in the console. It is
also very possible to get ? characters if you're running a
non-Unicode-aware tool or if there are encoding mix-up issues. "type con"
and pasting in text from a text editor doesn't really prove anything one
way or the other. (What editor? What encoding did it think the data was?
How does "type con" handle Unicode text? etc.)

Run the actual hgext and take a screenshot of what it generates if you want
to give a more useful data point for us.

Jun 16 2018, 3:38 AM
quark added a comment to D3665: graph: improve graph output by using Unicode characters.

What are you trying to demonstrate here? I'm lost.

Jun 16 2018, 3:00 AM
quark added a comment to D3665: graph: improve graph output by using Unicode characters.

Maybe I should change cmd.exe font. But here's what I got pasting the text into the console:

Jun 16 2018, 2:21 AM

Jun 15 2018

quark accepted D3683: obsshelve: adapt to introduction of cmdutil.exportfile in hg 678d760c71ff.

Pushed. Thanks for keeping obsshelve up-to-date!

Jun 15 2018, 10:43 PM
quark accepted D3681: obsshelve: adapt to rename of util.makedate.
Jun 15 2018, 10:43 PM
quark accepted D3682: obsshelve: pass '.' rather than '' for node id of current node.
Jun 15 2018, 10:43 PM
quark accepted D3680: obsshelve: accept new orphan changesets output from core.
Jun 15 2018, 10:43 PM
quark accepted D3755: remotefilectx: when looking for linknodes, use unfiltered repo.

Pushed. Thanks!

Jun 15 2018, 10:42 PM

Jun 14 2018

quark closed D3737: crecord: fix line number in hunk header (issue5917).
Jun 14 2018, 6:27 PM
quark committed rHG03350f5234a4: crecord: fix line number in hunk header (issue5917).
crecord: fix line number in hunk header (issue5917)
Jun 14 2018, 6:27 PM
quark created D3737: crecord: fix line number in hunk header (issue5917).
Jun 14 2018, 5:37 PM

Jun 13 2018

quark committed rHGc07424ec633c: commandserver: close server's fds explicitly from a worker.
commandserver: close server's fds explicitly from a worker
Jun 13 2018, 8:37 AM
quark closed D3720: commandserver: close server's fds explicitly from a worker.
Jun 13 2018, 8:37 AM

Jun 12 2018

quark created D3720: commandserver: close server's fds explicitly from a worker.
Jun 12 2018, 3:42 PM