Page MenuHomePhabricator

rdamazio (Rodrigo Damazio Bovendorp)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 17 2017, 9:53 PM (170 w, 2 d)

Recent Activity

Jul 17 2020

rdamazio closed D8763: diff: move no-eol text constant to a common location.
Jul 17 2020, 2:07 PM
rdamazio committed rHG10f48720ef95: diff: move no-eol text constant to a common location.
diff: move no-eol text constant to a common location
Jul 17 2020, 2:06 PM
rdamazio closed D8762: revert: fix interactive reverting of end-of-file newline changes.
Jul 17 2020, 2:06 PM
rdamazio committed rHG8b6a446508c2: revert: fix interactive reverting of end-of-file newline changes.
revert: fix interactive reverting of end-of-file newline changes
Jul 17 2020, 2:05 PM
rdamazio created D8763: diff: move no-eol text constant to a common location.
Jul 17 2020, 6:54 AM
rdamazio created D8762: revert: fix interactive reverting of end-of-file newline changes.
Jul 17 2020, 6:25 AM

Jul 15 2020

rdamazio accepted D8757: purge: classify as a "working directory management" command in help.
Jul 15 2020, 4:23 PM

Jul 11 2020

rdamazio committed rHG797ef6f8295e: fix: prefetch file contents.
fix: prefetch file contents
Jul 11 2020, 4:48 AM
rdamazio committed rHG54009f8c3e25: fix: obtain base paths before starting workers.
fix: obtain base paths before starting workers
Jul 11 2020, 4:48 AM
rdamazio committed rHGa56ba57c837d: scmutil: allowing different files to be prefetched per revision.
scmutil: allowing different files to be prefetched per revision
Jul 11 2020, 4:48 AM

Jul 10 2020

rdamazio added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 10:37 PM
rdamazio updated the diff for D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 10:11 PM
rdamazio added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 10:08 PM
rdamazio added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 9:55 PM
rdamazio updated the diff for D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 9:22 PM
rdamazio added a comment to D8721: scmutil: allowing different files to be prefetched per revision.

(also notice the formatting changed D8721, D8722 and D8723)

Jul 10 2020, 9:22 PM
rdamazio added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 9:20 PM
rdamazio updated the diff for D8723: fix: prefetch file contents.
Jul 10 2020, 9:20 PM
rdamazio updated the diff for D8722: fix: obtain base paths before starting workers.
Jul 10 2020, 9:20 PM
rdamazio added inline comments to D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 8:38 PM
rdamazio added a comment to D8721: scmutil: allowing different files to be prefetched per revision.

Should we have an entry in the release notes about this or have we given up on documenting API changes? I'm fine with either, as long as we have some policy.

Jul 10 2020, 8:27 PM
rdamazio closed D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 6:48 AM
rdamazio closed D8723: fix: prefetch file contents.
Jul 10 2020, 6:48 AM
rdamazio committed rHG263cf0f60b70: fix: prefetch file contents.
fix: prefetch file contents
Jul 10 2020, 6:47 AM
rdamazio closed D8722: fix: obtain base paths before starting workers.
Jul 10 2020, 6:47 AM
rdamazio committed rHGf204ba74004b: fix: obtain base paths before starting workers.
fix: obtain base paths before starting workers
Jul 10 2020, 6:47 AM
rdamazio committed rHG2fac78d5ae87: scmutil: allowing different files to be prefetched per revision.
scmutil: allowing different files to be prefetched per revision
Jul 10 2020, 6:45 AM
rdamazio created D8721: scmutil: allowing different files to be prefetched per revision.
Jul 10 2020, 2:47 AM
rdamazio created D8723: fix: prefetch file contents.
Jul 10 2020, 2:45 AM
rdamazio created D8722: fix: obtain base paths before starting workers.
Jul 10 2020, 2:45 AM

May 12 2020

rdamazio closed D8521: pyoxidizer: formatting bazel definitions.
May 12 2020, 8:19 PM
rdamazio committed rHG118f067f6bd1: pyoxidizer: formatting bazel definitions.
pyoxidizer: formatting bazel definitions
May 12 2020, 8:19 PM
rdamazio created D8521: pyoxidizer: formatting bazel definitions.
May 12 2020, 4:09 PM

May 7 2020

rdamazio committed rHGed684a82e29b: procutil: always waiting on child processes to prevent zombies with 'hg serve'.
procutil: always waiting on child processes to prevent zombies with 'hg serve'
May 7 2020, 11:43 AM
rdamazio closed D8497: procutil: always waiting on child processes to prevent zombies with 'hg serve'.
May 7 2020, 11:02 AM
rdamazio committed rHG38e0c006b0ae: procutil: always waiting on child processes to prevent zombies with 'hg serve'.
procutil: always waiting on child processes to prevent zombies with 'hg serve'
May 7 2020, 11:02 AM
rdamazio created D8497: procutil: always waiting on child processes to prevent zombies with 'hg serve'.
May 7 2020, 6:18 AM

Feb 6 2020

rdamazio updated the diff for D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Feb 6 2020, 10:11 PM
rdamazio updated the diff for D7630: absorb: make the absorbed changeset be automatically "evolved".
Feb 6 2020, 10:11 PM
rdamazio updated the diff for D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Feb 6 2020, 9:56 PM
rdamazio updated the diff for D7630: absorb: make the absorbed changeset be automatically "evolved".
Feb 6 2020, 9:56 PM

Feb 1 2020

rdamazio created D8064: split: add a --single flag to only ask for one split.
Feb 1 2020, 2:28 AM
rdamazio added a comment to D7630: absorb: make the absorbed changeset be automatically "evolved".

This results in an empty commit which is not similar to what rebase or evolve will generally result in after D7631 unless ui.allowemptycommit=True is set. I think good behavior is to obsolete the absorbed changeset in favour of either it's parent or one of the revs in which it was absorbed.

I made a related comment on the parent patch before I realized that this patch adds obsmarker handling. My suggestion there was to mark all the commits that got absorbed into as successors, and if there's anything left in the absorbed commit, that would be yet another successor. Would that work?

Yep, that sounds good.

I'm fine with doing this, but is there an efficient way to detect that it became empty?

Feb 1 2020, 2:12 AM
rdamazio updated the diff for D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Feb 1 2020, 2:11 AM
rdamazio updated the diff for D7630: absorb: make the absorbed changeset be automatically "evolved".
Feb 1 2020, 2:10 AM
rdamazio added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

Sorry for the delay in replying here.

Feb 1 2020, 2:10 AM
rdamazio added a comment to D7630: absorb: make the absorbed changeset be automatically "evolved".

This results in an empty commit which is not similar to what rebase or evolve will generally result in after D7631 unless ui.allowemptycommit=True is set. I think good behavior is to obsolete the absorbed changeset in favour of either it's parent or one of the revs in which it was absorbed.

Feb 1 2020, 2:10 AM

Jan 14 2020

rdamazio committed rHG8eb3c52337a6: phases: reduce code duplication in phasecache.getrevset.
phases: reduce code duplication in phasecache.getrevset
Jan 14 2020, 11:39 AM
rdamazio committed rHGab41dad7345e: phases: make phasecache._phasesets immutable.
phases: make phasecache._phasesets immutable
Jan 14 2020, 11:39 AM
rdamazio committed rHGa30a59582c15: phases: make phasecache._phasesets immutable.
phases: make phasecache._phasesets immutable
Jan 14 2020, 11:37 AM
rdamazio committed rHG23c399e39b27: phases: reduce code duplication in phasecache.getrevset.
phases: reduce code duplication in phasecache.getrevset
Jan 14 2020, 11:37 AM
rdamazio closed D7854: phases: make phasecache._phasesets immutable.
Jan 14 2020, 9:22 AM
rdamazio committed rHGc31ec768d70a: phases: make phasecache._phasesets immutable.
phases: make phasecache._phasesets immutable
Jan 14 2020, 9:22 AM
rdamazio closed D7853: phases: reduce code duplication in phasecache.getrevset.
Jan 14 2020, 9:21 AM
rdamazio committed rHG90eedaa80503: phases: reduce code duplication in phasecache.getrevset.
phases: reduce code duplication in phasecache.getrevset
Jan 14 2020, 9:21 AM

Jan 13 2020

rdamazio created D7854: phases: make phasecache._phasesets immutable.
Jan 13 2020, 10:18 PM
rdamazio created D7853: phases: reduce code duplication in phasecache.getrevset.
Jan 13 2020, 10:18 PM
rdamazio added a comment to D7705: phases: make the working directory consistently a draft.

x

Jan 13 2020, 9:55 PM
rdamazio added a comment to D7705: phases: make the working directory consistently a draft.
In D7705#114943, @yuja wrote:

@@ -252,25 +254,44 @@

    revs = set.union(*[self._phasesets[p] for p in phases])
if repo.changelog.filteredrevs:
    revs = revs - repo.changelog.filteredrevs

+

if subset is None:
    return smartset.baseset(revs)
else:

+ if wdirrev in subset and repo[None].phase() in phases:
+ # The working dir would never be in the cache, but it was
+ # in the subset being filtered for its phase, so add it to
+ # the output.
+ revs.add(wdirrev)

Suppose self._phasesets[] is a read-only object in this method,
I think revs shouldn't be mutated if revs is self._phasesets[p].

+ if wdirrev in subset and repo[None].phase() in phases:
+ # The working dir is in the subset being filtered, and its
+ # phase is in the phases *not* being returned, so add it to the
+ # set of revisions to filter out.
+ revs.add(wdirrev)

Same here.

Jan 13 2020, 9:55 PM

Jan 8 2020

rdamazio committed rHG9c1fd975e9ac: phases: make the working directory consistently a draft.
phases: make the working directory consistently a draft
Jan 8 2020, 1:10 PM
rdamazio closed D7705: phases: make the working directory consistently a draft.
Jan 8 2020, 11:50 AM
rdamazio committed rHG2ab225377c27: phases: make the working directory consistently a draft.
phases: make the working directory consistently a draft
Jan 8 2020, 11:50 AM

Jan 6 2020

rdamazio added a comment to D7705: phases: make the working directory consistently a draft.

I don't understand what you're asking me to do here, can you clarify?

In short we should have a test matching

$ hg log -r 'wdir() and secret()' -T '{phase}\n' --config phases.new-commit=secret
secret
Jan 6 2020, 7:56 PM
rdamazio updated the diff for D7705: phases: make the working directory consistently a draft.
Jan 6 2020, 7:56 PM
rdamazio added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.
In D7631#112414, @quark wrote:

--rev seems ambiguous since there might be different kinds of revisions to specify - target and revisions to edit. Maybe something like --source, --from, --target?

Done. Used --source to match rebase.

Is --exact from hg fold a better model? I don't feel strongly; I only mention it because hg rebase -s will take that revision and its descendants, so it's more like "stack" in my mind. I'm not sure how many other commands have -s off the top of my head, but @martinvonz
mentioned adding that to hg fix (probably in IRC), and I think mentioned the word "stack" in that context. So I might not be the only one to get slightly tripped up by that.

Jan 6 2020, 7:46 PM
rdamazio updated the diff for D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Jan 6 2020, 7:46 PM
rdamazio updated the diff for D7630: absorb: make the absorbed changeset be automatically "evolved".
Jan 6 2020, 7:46 PM

Dec 27 2019

rdamazio added a comment to D7705: phases: make the working directory consistently a draft.

I simply sent this. If am I following your changeset right, we should have wdir() match draft() or secret() according to the projected phase (config + parent)

Dec 27 2019, 6:21 PM
rdamazio added a comment to D7705: phases: make the working directory consistently a draft.

commitablectx code seems wrong here. I am sending a patch.

Dec 27 2019, 3:42 PM

Dec 23 2019

rdamazio added a comment to D7705: phases: make the working directory consistently a draft.

The working copy is not necessarly draft phase. For example, it will be secret is the working copy parent is secret. One can also control it using the phases.new-commit config.
The mercurial.phases.newcommitphase(ui) function can help you there.

Dec 23 2019, 9:05 PM
rdamazio updated the diff for D7705: phases: make the working directory consistently a draft.
Dec 23 2019, 9:04 PM

Dec 19 2019

rdamazio closed D7668: status: make unresolved files always be in the morestatus structured output.
Dec 19 2019, 12:56 PM
rdamazio closed D7704: status: make morestatus call out unresolved conflicts after update.
Dec 19 2019, 12:56 PM
rdamazio closed D7667: status: extract active-merge state for reuse.
Dec 19 2019, 12:56 PM
rdamazio committed rHG07ebb567e8bb: status: make unresolved files always be in the morestatus structured output.
status: make unresolved files always be in the morestatus structured output
Dec 19 2019, 12:55 PM
rdamazio committed rHG489fdf27769c: status: make morestatus call out unresolved conflicts after update.
status: make morestatus call out unresolved conflicts after update
Dec 19 2019, 12:55 PM
rdamazio committed rHG4ca89cc20d02: status: extract active-merge state for reuse.
status: extract active-merge state for reuse
Dec 19 2019, 12:55 PM
rdamazio created D7705: phases: make the working directory consistently a draft.
Dec 19 2019, 3:34 AM
rdamazio updated the diff for D7668: status: make unresolved files always be in the morestatus structured output.
Dec 19 2019, 2:48 AM
rdamazio created D7704: status: make morestatus call out unresolved conflicts after update.
Dec 19 2019, 2:48 AM
rdamazio retitled D7667: status: extract active-merge state for reuse from status: make morestatus call out unresolved conflicts after update to status: extract active-merge state for reuse.
Dec 19 2019, 2:48 AM
rdamazio added a comment to D7667: status: extract active-merge state for reuse.

Can we split them up?

Dec 19 2019, 2:47 AM
rdamazio added inline comments to D7668: status: make unresolved files always be in the morestatus structured output.
Dec 19 2019, 2:47 AM
rdamazio updated the diff for D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Dec 19 2019, 2:37 AM
rdamazio updated the diff for D7630: absorb: make the absorbed changeset be automatically "evolved".
Dec 19 2019, 2:37 AM

Dec 18 2019

rdamazio updated the diff for D7668: status: make unresolved files always be in the morestatus structured output.
Dec 18 2019, 12:18 AM
rdamazio updated the diff for D7667: status: extract active-merge state for reuse.
Dec 18 2019, 12:18 AM

Dec 17 2019

rdamazio updated the diff for D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Dec 17 2019, 11:47 PM
rdamazio updated the diff for D7630: absorb: make the absorbed changeset be automatically "evolved".
Dec 17 2019, 11:47 PM
rdamazio added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.

Can you describe the feature a bit in the commit message. Specific things which I feel are missing:

Dec 17 2019, 11:42 PM
rdamazio updated the summary of D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Dec 17 2019, 11:42 PM
rdamazio updated the diff for D7630: absorb: make the absorbed changeset be automatically "evolved".
Dec 17 2019, 11:42 PM

Dec 16 2019

rdamazio closed D7666: update: add some tests for the status quo of morestatus on update conflicts.
Dec 16 2019, 1:32 AM
rdamazio committed rHG5709a9992c2a: update: add some tests for the status quo of morestatus on update conflicts.
update: add some tests for the status quo of morestatus on update conflicts
Dec 16 2019, 1:32 AM

Dec 14 2019

rdamazio updated the diff for D7631: absorb: allowing committed changes to be absorbed into their ancestors.
Dec 14 2019, 1:25 AM
rdamazio updated the diff for D7630: absorb: make the absorbed changeset be automatically "evolved".
Dec 14 2019, 1:25 AM
rdamazio retitled D7631: absorb: allowing committed changes to be absorbed into their ancestors from RFC: absorb: allowing committed changes to be absorbed into their ancestors to absorb: allowing committed changes to be absorbed into their ancestors.
Dec 14 2019, 1:02 AM
rdamazio retitled D7630: absorb: make the absorbed changeset be automatically "evolved" from RFC: absorb: make the absorbed changeset be automatically "evolved" to absorb: make the absorbed changeset be automatically "evolved".
Dec 14 2019, 1:02 AM
rdamazio added a comment to D7631: absorb: allowing committed changes to be absorbed into their ancestors.
In D7631#112414, @quark wrote:

--rev seems ambiguous since there might be different kinds of revisions to specify - target and revisions to edit. Maybe something like --source, --from, --target?

Dec 14 2019, 1:02 AM
rdamazio added a comment to D7630: absorb: make the absorbed changeset be automatically "evolved".

Sorry for the upload mess (though it's arguably a phabsend bug :) ). Tried uploading the "right" way now.

Dec 14 2019, 1:02 AM