rdamazio (Rodrigo Damazio Bovendorp)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 17 2017, 9:53 PM (83 w, 2 d)

Recent Activity

Sun, Feb 17

rdamazio closed D5959: templates: adding a config() function for template customization.
Sun, Feb 17, 8:52 AM
rdamazio committed rHG6704696141b8: templates: adding a config() function for template customization.
templates: adding a config() function for template customization
Sun, Feb 17, 8:52 AM

Wed, Feb 13

rdamazio retitled D5959: templates: adding a config() function for template customization from templates: adding a config() function for template customization. to templates: adding a config() function for template customization.
Wed, Feb 13, 9:36 PM
rdamazio created D5959: templates: adding a config() function for template customization.
Wed, Feb 13, 9:35 PM

Jan 10 2019

rdamazio closed D5543: histedit: crashing with a more useful error message on empty defaultrev.
Jan 10 2019, 6:30 AM
rdamazio committed rHGfbd168455b26: histedit: crashing with a more useful error message on empty defaultrev.
histedit: crashing with a more useful error message on empty defaultrev
Jan 10 2019, 6:30 AM

Jan 9 2019

rdamazio added a comment to D5543: histedit: crashing with a more useful error message on empty defaultrev.

(and btw I'd be happier with '' meaning the default, but the original author went through the trouble of checking both cases explicitly, so I kept that)

Jan 9 2019, 11:10 PM
rdamazio created D5543: histedit: crashing with a more useful error message on empty defaultrev.
Jan 9 2019, 11:05 PM

Dec 13 2018

rdamazio committed rHGeed9a62e1f10: remotefilelog: accepting a None node to cmp.
remotefilelog: accepting a None node to cmp
Dec 13 2018, 3:07 PM

Dec 12 2018

rdamazio added a comment to D5409: remotefilelog: accepting a None node to cmp.

Oops, my oversight - what's passed to cmp is not the same that's compared to None in that if :) I have even less confidence on this now.

Dec 12 2018, 6:28 PM
rdamazio added a comment to D5409: remotefilelog: accepting a None node to cmp.
In D5409#80203, @yuja wrote:
In context.py, basefilectx.cmp explicitly calls it with None, so it has to be
supported. Specifically, this breaks "hg absorb -i" currently.

IIUC, self._filenode should never be None if the given fctx._filenode
is None. If None were passed down to the filelog layer, exception would
be raised.

returns True if text is different than what is stored.
"""
  • if node == nullid: + if not node or node == nullid: return True

Are we sure that the working-directory data is different from the given text?

Dec 12 2018, 6:17 PM

Dec 10 2018

rdamazio committed rHG4e17679c336b: remotefilelog: accepting a None node to cmp.
remotefilelog: accepting a None node to cmp
Dec 10 2018, 9:09 PM
rdamazio closed D5409: remotefilelog: accepting a None node to cmp.
Dec 10 2018, 9:09 PM
rdamazio created D5409: remotefilelog: accepting a None node to cmp.
Dec 10 2018, 8:51 PM

Nov 6 2018

rdamazio committed rHG1b49b84d5ed5: pycompat: adding Linux detection and fixing Mac.
pycompat: adding Linux detection and fixing Mac
Nov 6 2018, 4:44 AM
rdamazio closed D5227: pycompat: adding Linux detection and fixing Mac.
Nov 6 2018, 4:44 AM

Nov 5 2018

rdamazio created D5227: pycompat: adding Linux detection and fixing Mac.
Nov 5 2018, 10:54 PM

Oct 23 2018

rdamazio closed D5087: help: displaying documented aliases by default.
Oct 23 2018, 7:40 AM
rdamazio committed rHG444861dc1e55: help: displaying documented aliases by default.
help: displaying documented aliases by default
Oct 23 2018, 7:40 AM
rdamazio committed rHGdce0e0f78f0f: help: displaying extension commands by default.
help: displaying extension commands by default
Oct 23 2018, 7:40 AM
rdamazio closed D5156: help: displaying extension commands by default.
Oct 23 2018, 7:40 AM
rdamazio closed D5077: help: allow hiding of help topics.
Oct 23 2018, 7:40 AM
rdamazio closed D5076: help: allow commands to be hidden.
Oct 23 2018, 7:40 AM
rdamazio committed rHG1ddd202c47d9: help: allow hiding of help topics.
help: allow hiding of help topics
Oct 23 2018, 7:39 AM
rdamazio committed rHGab09e797fbed: help: allow commands to be hidden.
help: allow commands to be hidden
Oct 23 2018, 7:39 AM

Oct 18 2018

rdamazio added a reviewer for D5156: help: displaying extension commands by default: yuja.
Oct 18 2018, 11:26 PM
rdamazio added a reviewer for D5076: help: allow commands to be hidden: yuja.
Oct 18 2018, 11:26 PM
rdamazio updated the diff for D5087: help: displaying documented aliases by default.
Oct 18 2018, 11:26 PM
rdamazio added a reviewer for D5077: help: allow hiding of help topics: yuja.
Oct 18 2018, 11:26 PM
rdamazio created D5156: help: displaying extension commands by default.
Oct 18 2018, 11:26 PM
rdamazio added a reviewer for D5087: help: displaying documented aliases by default: yuja.
Oct 18 2018, 11:26 PM
rdamazio updated the diff for D5077: help: allow hiding of help topics.
Oct 18 2018, 11:26 PM
rdamazio added a comment to D5087: help: displaying documented aliases by default.
In D5087#76401, @yuja wrote:

@@ -507,16 +522,11 @@

f = fs[0]
syns[f] = ', '.join(fs)
func = e[0]

+ alias = getattr(func, 'alias', False)

if select and not select(f):
    continue
  • if (not select and name != 'shortlist' and
  • func.module != commands.name):
  • continue
  • if name == "shortlist":
  • if not getattr(func, 'helpbasic', False):
  • continue doc = pycompat.getdoc(func)
  • if filtercmd(ui, f, name, doc): + if filtercmd(ui, f, func, name, doc):

This makes extension commands get listed in "hg help". I think that's fine,
but can you split patches so we can backout if that causes problem?

Oct 18 2018, 11:25 PM
rdamazio added a comment to D5076: help: allow commands to be hidden.
In D5076#76405, @yuja wrote:

+ if ui.configbool('help', 'hide.%s' % cmd):
+ return True

Nit: "hidden" or "hidden-command" seems better.

Oct 18 2018, 11:25 PM
rdamazio added a comment to D5077: help: allow hiding of help topics.
In D5077#76403, @yuja wrote:

+def filtertopic(ui, topic):
+ return ui.configbool('help', 'hide.%s' % topic, False)

Maybe we need a separate namespace (e.g. help.hidden-topic.%s)?

Oct 18 2018, 11:25 PM
rdamazio updated the diff for D5076: help: allow commands to be hidden.
Oct 18 2018, 11:25 PM
rdamazio added a dependent revision for D5087: help: displaying documented aliases by default: D5156: help: displaying extension commands by default.
Oct 18 2018, 11:25 PM

Oct 14 2018

rdamazio closed D5067: help: assigning categories to existing commands.
Oct 14 2018, 11:20 AM
rdamazio closed D5069: help: adding a proper declaration for shortlist/basic commands.
Oct 14 2018, 11:19 AM
rdamazio closed D5068: help: assigning topic categories.
Oct 14 2018, 11:17 AM
rdamazio committed rHGc303d65d2e34: help: assigning categories to existing commands.
help: assigning categories to existing commands
Oct 14 2018, 11:17 AM
rdamazio committed rHGfa88170c10bb: help: adding a proper declaration for shortlist/basic commands (API).
help: adding a proper declaration for shortlist/basic commands (API)
Oct 14 2018, 11:17 AM
rdamazio committed rHGfabbf9310025: help: assigning topic categories.
help: assigning topic categories
Oct 14 2018, 11:17 AM
rdamazio closed D5066: help: splitting the topics by category.
Oct 14 2018, 11:17 AM
rdamazio committed rHG9c6473d2038b: help: splitting the topics by category.
help: splitting the topics by category
Oct 14 2018, 11:16 AM
rdamazio closed D5065: help: adding support for command categories.
Oct 14 2018, 11:16 AM
rdamazio committed rHG170926caf44c: help: adding support for command categories.
help: adding support for command categories
Oct 14 2018, 11:16 AM
rdamazio updated the diff for D5067: help: assigning categories to existing commands.
Oct 14 2018, 6:37 AM
rdamazio updated the diff for D5069: help: adding a proper declaration for shortlist/basic commands.
Oct 14 2018, 6:35 AM
rdamazio updated the diff for D5087: help: displaying documented aliases by default.
Oct 14 2018, 6:34 AM
rdamazio added a comment to D5067: help: assigning categories to existing commands.
In D5067#76195, @yuja wrote:

Can you make these constants untranslated (e.g. 'help' instead of _('Help'))
and map them to corresponding translation later?

And, perhaps they can be moved to registrar.command so we can avoid
importing help.py everywhere.

Oct 14 2018, 6:33 AM
rdamazio updated the diff for D5077: help: allow hiding of help topics.
Oct 14 2018, 6:33 AM
rdamazio updated the diff for D5076: help: allow commands to be hidden.
Oct 14 2018, 6:33 AM
rdamazio updated the diff for D5068: help: assigning topic categories.
Oct 14 2018, 6:32 AM
rdamazio updated the diff for D5066: help: splitting the topics by category.
Oct 14 2018, 6:32 AM
rdamazio updated the diff for D5065: help: adding support for command categories.
Oct 14 2018, 6:32 AM

Oct 13 2018

rdamazio created D5087: help: displaying documented aliases by default.
Oct 13 2018, 10:26 AM
rdamazio added a reviewer for D5087: help: displaying documented aliases by default: durin42.
Oct 13 2018, 10:26 AM
rdamazio added a dependent revision for D5077: help: allow hiding of help topics: D5087: help: displaying documented aliases by default.
Oct 13 2018, 10:26 AM
rdamazio updated the diff for D5067: help: assigning categories to existing commands.
Oct 13 2018, 8:48 AM
rdamazio updated the diff for D5069: help: adding a proper declaration for shortlist/basic commands.
Oct 13 2018, 8:47 AM
rdamazio created D5077: help: allow hiding of help topics.
Oct 13 2018, 8:45 AM
rdamazio created D5076: help: allow commands to be hidden.
Oct 13 2018, 8:45 AM
rdamazio added a dependent revision for D5076: help: allow commands to be hidden: D5077: help: allow hiding of help topics.
Oct 13 2018, 8:45 AM
rdamazio updated the diff for D5068: help: assigning topic categories.
Oct 13 2018, 8:45 AM
rdamazio added a dependent revision for D5069: help: adding a proper declaration for shortlist/basic commands: D5076: help: allow commands to be hidden.
Oct 13 2018, 8:44 AM
rdamazio updated the diff for D5066: help: splitting the topics by category.
Oct 13 2018, 8:44 AM
rdamazio updated the diff for D5065: help: adding support for command categories.
Oct 13 2018, 8:44 AM
rdamazio updated the diff for D5067: help: assigning categories to existing commands.
Oct 13 2018, 6:49 AM
rdamazio updated the diff for D5069: help: adding a proper declaration for shortlist/basic commands.
Oct 13 2018, 6:48 AM
rdamazio updated the diff for D5068: help: assigning topic categories.
Oct 13 2018, 6:45 AM
rdamazio added a comment to D5069: help: adding a proper declaration for shortlist/basic commands.

Done now.

Oct 13 2018, 6:45 AM
rdamazio updated the diff for D5066: help: splitting the topics by category.
Oct 13 2018, 6:45 AM
rdamazio updated the diff for D5065: help: adding support for command categories.
Oct 13 2018, 6:44 AM
rdamazio added a comment to D5069: help: adding a proper declaration for shortlist/basic commands.

Hold on this one, I forgot to amend before uploading :)

Oct 13 2018, 6:30 AM
rdamazio created D5067: help: assigning categories to existing commands.
Oct 13 2018, 6:23 AM
rdamazio created D5069: help: adding a proper declaration for shortlist/basic commands.
Oct 13 2018, 6:22 AM
rdamazio created D5068: help: assigning topic categories.
Oct 13 2018, 6:20 AM
rdamazio created D5066: help: splitting the topics by category.
Oct 13 2018, 6:19 AM
rdamazio added a dependent revision for D5068: help: assigning topic categories: D5069: help: adding a proper declaration for shortlist/basic commands.
Oct 13 2018, 6:19 AM
rdamazio created D5065: help: adding support for command categories.
Oct 13 2018, 6:19 AM
rdamazio added a dependent revision for D5067: help: assigning categories to existing commands: D5068: help: assigning topic categories.
Oct 13 2018, 6:19 AM
rdamazio added a dependent revision for D5066: help: splitting the topics by category: D5067: help: assigning categories to existing commands.
Oct 13 2018, 6:19 AM
rdamazio added a dependent revision for D5065: help: adding support for command categories: D5066: help: splitting the topics by category.
Oct 13 2018, 6:19 AM

Aug 1 2018

rdamazio closed D3967: dispatch: making all hg abortions be output with a specific label.
Aug 1 2018, 12:42 PM
rdamazio committed rHGafc4ad706f9c: dispatch: making all hg abortions be output with a specific label.
dispatch: making all hg abortions be output with a specific label
Aug 1 2018, 12:41 PM

Jul 20 2018

rdamazio updated the diff for D3967: dispatch: making all hg abortions be output with a specific label.
Jul 20 2018, 4:26 PM
rdamazio added a comment to D3967: dispatch: making all hg abortions be output with a specific label.

PTAL

Jul 20 2018, 4:26 PM
rdamazio created D3967: dispatch: making all hg abortions be output with a specific label.
Jul 20 2018, 2:22 AM

Jul 19 2018

rdamazio committed rHG25880ddf9a86: macosx: fixing macOS version generation after db9d1dd01bf0.
macosx: fixing macOS version generation after db9d1dd01bf0
Jul 19 2018, 8:28 AM
rdamazio closed D3964: macosx: fixing macOS version generation after db9d1dd01bf0.
Jul 19 2018, 8:28 AM

Jul 18 2018

rdamazio added a comment to D3964: macosx: fixing macOS version generation after db9d1dd01bf0.

This is python code, why is it parsing the version file instead of importing it?

Jul 18 2018, 10:31 PM
rdamazio added a comment to D3964: macosx: fixing macOS version generation after db9d1dd01bf0.

Hmm and nevermind, the weird package name doesn't reproduce on a vanilla hg build, you can go ahead and review.

Jul 18 2018, 10:30 PM
rdamazio added a comment to D3964: macosx: fixing macOS version generation after db9d1dd01bf0.

Er, actually, let me fix this again - this unbreaks the build but generates packages like 'Mercurial-"4.6.2+674-f83600efa1ca-macosx10.13.dmg'.

Jul 18 2018, 10:02 PM
rdamazio retitled D3964: macosx: fixing macOS version generation after db9d1dd01bf0 from macosx: fixing macOS version generation after dbbe45ae5ad1 to macosx: fixing macOS version generation after db9d1dd01bf0.
Jul 18 2018, 9:48 PM
rdamazio created D3964: macosx: fixing macOS version generation after db9d1dd01bf0.
Jul 18 2018, 9:45 PM

May 9 2018

rdamazio committed rFBHGX311e6c53c3cf: absorb: fix invalidation of the working directory parent.
absorb: fix invalidation of the working directory parent
May 9 2018, 12:58 PM

Mar 28 2018

rdamazio closed D2678: help: supporting both help and doc for aliases.
Mar 28 2018, 6:07 AM
rdamazio committed rHG6890b7e991a4: help: supporting both help and doc for aliases.
help: supporting both help and doc for aliases
Mar 28 2018, 6:06 AM

Mar 27 2018

rdamazio updated the diff for D2678: help: supporting both help and doc for aliases.
Mar 27 2018, 3:55 PM