Page MenuHomePhabricator

rom1dep (Romain DEP.)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2017, 6:21 AM (178 w, 3 d)

Recent Activity

May 25 2020

rom1dep added a comment to D8579: context: avoid computing status twice when comparing among revisions.

No real justification for, only found it weird, and since we have to do that test anyway I didn't think it would make perfs worse,
Didn't run tests on it, though.

May 25 2020, 2:51 AM
rom1dep created D8579: context: avoid computing status twice when comparing among revisions.
May 25 2020, 2:48 AM

May 18 2020

rom1dep committed rHG3e09d22a0bf5: git: implement some changelog methods.
git: implement some changelog methods
May 18 2020, 12:47 PM
rom1dep closed D8540: git: implement some changelog methods.
May 18 2020, 12:47 PM
rom1dep added a comment to D8540: git: implement some changelog methods.

hi @durin42 , yes indeed, that fixes tortoisehg's loading of a hgit repo (now the DAG is fully visible, selection of commits work, I have other patches there too to work around things for status),
I didn't think much of these changes because the added methods are rip-offs of the ones in /mercurial/revlog.py,
maybe there is an abstraction which could be used there so not to duplicate this code/these tests?

May 18 2020, 2:46 AM

May 17 2020

rom1dep closed D8541: git: avoid looking-up parents for the null commit.
May 17 2020, 9:27 PM
rom1dep committed rHG8bfc6cc8e480: git: avoid looking-up parents for the null commit.
git: avoid looking-up parents for the null commit
May 17 2020, 9:27 PM
rom1dep closed D8539: git: fix probable missing return.
May 17 2020, 5:18 PM
rom1dep committed rHG288328c6711b: git: fix probable missing return.
git: fix probable missing return
May 17 2020, 5:18 PM
rom1dep created D8541: git: avoid looking-up parents for the null commit.
May 17 2020, 1:41 PM
rom1dep created D8540: git: implement some changelog methods.
May 17 2020, 1:41 PM
rom1dep created D8539: git: fix probable missing return.
May 17 2020, 1:39 PM