- User Since
- Jun 29 2017, 11:14 AM (120 w, 2 d)
Mar 4 2018
Mar 3 2018
This existing directory is called thirdparty not third-party, unfortunately.
To be clear, this patch series was created by @quark, but phabricator did not keep the author information from the patches.
Mar 2 2018
Dec 15 2017
I've been convinced by all the text above that is is okay!
Dec 13 2017
Why not disable only manifest verification, which is the slow thing here? changelog verification since that can't be re-downloaded on-demand seems reasonable to me. This, of course, is probably effective enough but just kicsk the can down the road if there's an actual corruption issue in a revlog.
Can you add a test that demonstrates what this fixes?
Nov 26 2017
I understand that fixing the crash is a good first step, but ideally, wouldn't this be supported? Is there a reason it's particularly hard to support?
Nov 9 2017
Nov 7 2017
Oct 20 2017
Sweet! Thanks for the quick fix.
Oct 19 2017
Oct 18 2017
Oct 17 2017
I think this series overall cleans up the namespaces. I don't really love that evolution is still "hiding" under experimental but currently we don't have a way of marking non-"experimental" configs as experimental still so I guess this will have to suffice for now. I'll take a closer look tomorrow if nobody else gets to this first.
Yeah, I was running the wrong run-tests.py. Thanks for the help @durin42.
I get skipped: unknown feature: clang-format when running test-check-clang-format.t now. What am I doing wrong?
I'll queue this series except this patch so we can have more discussion on what we should do here.
I'm not a python 3 expert by any means, but I'm not sold on this change.
I agree with @lothiraldan that there's no pressing need to remove aliases, and we should have a mechanism to work before we do this for sure.
I'm dropping this from hg-committed for now. Please re-submit with the check-code issues fixed.
Hm, check-code is failing here.
I think I request revision because the series needed to change, and I wanted to take it out of other people's queues. Will look again at the whole series now.
D953 is abandoned- should this be as well?
Oct 16 2017
Oct 15 2017
I think the tests still fail with this change (I tried the same change myself). Please ensure you've run the tests. D1054 in the fix I came up with after trying this.