Page MenuHomePhabricator

ryanmce (Ryan McElroy)
User

Projects

User Details

User Since
Jun 29 2017, 11:14 AM (111 w, 2 d)

Recent Activity

Mar 4 2018

ryanmce closed D2619: revsetlang: add a hint for more useful parse errors.
Mar 4 2018, 7:55 AM
ryanmce closed D2589: setup: ignore extension load failures when finding working hg.
Mar 4 2018, 7:55 AM
ryanmce committed rHG2a258985ffeb: revsetlang: add a hint for more useful parse errors.
revsetlang: add a hint for more useful parse errors
Mar 4 2018, 7:55 AM
ryanmce committed rHG5f41e3418407: setup: ignore extension load failures when finding working hg.
setup: ignore extension load failures when finding working hg
Mar 4 2018, 7:55 AM
ryanmce committed rHG44048f1bcee5: templater: provide hint for multi-line templates with parse errors.
templater: provide hint for multi-line templates with parse errors
Mar 4 2018, 7:55 AM
ryanmce committed rHG80d7fb6c2dec: templater: add hint to template parse errors to help locate issues.
templater: add hint to template parse errors to help locate issues
Mar 4 2018, 7:55 AM

Mar 3 2018

ryanmce closed D2608: templater: add hint to template parse errors to help locate issues.
Mar 3 2018, 6:40 PM
ryanmce closed D2609: templater: provide hint for multi-line templates with parse errors.
Mar 3 2018, 6:40 PM
ryanmce committed rHG5d1bae328b7d: templater: provide hint for multi-line templates with parse errors.
templater: provide hint for multi-line templates with parse errors
Mar 3 2018, 6:39 PM
ryanmce committed rHG8df20b7a39d2: templater: add hint to template parse errors to help locate issues.
templater: add hint to template parse errors to help locate issues
Mar 3 2018, 6:39 PM
ryanmce created D2619: revsetlang: add a hint for more useful parse errors.
Mar 3 2018, 6:32 PM
ryanmce updated the diff for D2609: templater: provide hint for multi-line templates with parse errors.
Mar 3 2018, 5:30 PM
ryanmce updated the diff for D2608: templater: add hint to template parse errors to help locate issues.
Mar 3 2018, 5:26 PM
ryanmce created D2609: templater: provide hint for multi-line templates with parse errors.
Mar 3 2018, 5:26 PM
ryanmce updated the diff for D2608: templater: add hint to template parse errors to help locate issues.
Mar 3 2018, 5:11 PM
ryanmce created D2608: templater: add hint to template parse errors to help locate issues.
Mar 3 2018, 4:49 PM
ryanmce planned changes to D2572: xdiff: vendor xdiff library from git.

This existing directory is called thirdparty not third-party, unfortunately.

Mar 3 2018, 3:25 PM
ryanmce added inline comments to D2068: revlog: do not use delta for lfs revisions.
Mar 3 2018, 3:21 PM
ryanmce added inline comments to D2067: changegroup: do not delta lfs revisions.
Mar 3 2018, 2:51 PM
ryanmce added inline comments to D2068: revlog: do not use delta for lfs revisions.
Mar 3 2018, 2:48 PM
ryanmce accepted D2069: revlog: resolve lfs rawtext to vanilla rawtext before applying delta.
Mar 3 2018, 2:37 PM
ryanmce accepted D2068: revlog: do not use delta for lfs revisions.
Mar 3 2018, 2:36 PM
ryanmce accepted D2067: changegroup: do not delta lfs revisions.
Mar 3 2018, 2:36 PM
ryanmce added inline comments to D2577: mdiff: prefer xdiff for diff calculation.
Mar 3 2018, 2:14 PM
ryanmce created D2589: setup: ignore extension load failures when finding working hg.
Mar 3 2018, 2:10 PM
ryanmce updated subscribers of D2572: xdiff: vendor xdiff library from git.

To be clear, this patch series was created by @quark, but phabricator did not keep the author information from the patches.

Mar 3 2018, 9:22 AM

Mar 2 2018

ryanmce created D2572: xdiff: vendor xdiff library from git.
Mar 2 2018, 7:26 PM
ryanmce created D2577: mdiff: prefer xdiff for diff calculation.
Mar 2 2018, 7:25 PM
ryanmce created D2578: xdiff: enable indent heuristic unconditionally.
Mar 2 2018, 7:25 PM
ryanmce created D2576: xdiff: add a python wrapper.
Mar 2 2018, 7:25 PM
ryanmce created D2575: xdiff: add a bdiff hunk mode.
Mar 2 2018, 7:25 PM
ryanmce created D2573: xdiff: remove patience and histogram diff algorithms.
Mar 2 2018, 7:25 PM
ryanmce created D2574: xdiff: add a binary utility that runs xdiff.
Mar 2 2018, 7:25 PM

Dec 15 2017

ryanmce accepted D1680: treedirstate: dirstatemap.identity should be a property.

I've been convinced by all the text above that is is okay!

Dec 15 2017, 11:45 AM

Dec 13 2017

ryanmce added a comment to D1614: noverify: add extension to skip repo verification.

Why not disable only manifest verification, which is the slow thing here? changelog verification since that can't be re-downloaded on-demand seems reasonable to me. This, of course, is probably effective enough but just kicsk the can down the road if there's an actual corruption issue in a revlog.

Dec 13 2017, 5:44 PM
ryanmce requested changes to D1680: treedirstate: dirstatemap.identity should be a property.

Can you add a test that demonstrates what this fixes?

Dec 13 2017, 12:52 PM

Nov 26 2017

ryanmce added a comment to D1506: dagop: handle IndexError when using wdir() in dag range.

I understand that fixing the crash is a good first step, but ideally, wouldn't this be supported? Is there a reason it's particularly hard to support?

Nov 26 2017, 4:42 AM

Nov 9 2017

ryanmce closed D1332: cmdutil: create dirs for templated cat file output.
Nov 9 2017, 9:03 AM
ryanmce committed rHG407ec7f3ff02: cmdutil: create dirs for templated cat file output.
cmdutil: create dirs for templated cat file output
Nov 9 2017, 9:03 AM
ryanmce committed rHG8154119ed236: cat: test output path behvaior when target path does not exist.
cat: test output path behvaior when target path does not exist
Nov 9 2017, 9:02 AM
ryanmce closed D1331: cat: test output path behvaior when target path does not exist.
Nov 9 2017, 9:02 AM

Nov 7 2017

ryanmce created D1332: cmdutil: create dirs for templated cat file output.
Nov 7 2017, 4:49 PM
ryanmce created D1331: cat: test output path behvaior when target path does not exist.
Nov 7 2017, 4:49 PM

Oct 20 2017

ryanmce accepted D1199: pushrebase: check sources of renames when looking for conflicts.

Sweet! Thanks for the quick fix.

Oct 20 2017, 3:07 PM

Oct 19 2017

ryanmce added inline comments to D932: filemerge: introduce functions to halt merge flow.
Oct 19 2017, 4:32 PM
ryanmce committed rHG05535d0dea68: merge: additional test cases to show merge-halting behavior.
merge: additional test cases to show merge-halting behavior
Oct 19 2017, 1:01 PM

Oct 18 2017

ryanmce closed D952: merge: additional test cases to show merge-halting behavior.
Oct 18 2017, 4:27 PM
ryanmce committed rHGe10bac797852: merge: additional test cases to show merge-halting behavior.
merge: additional test cases to show merge-halting behavior
Oct 18 2017, 4:27 PM

Oct 17 2017

ryanmce added a comment to D1155: config: gather allowdivergence under the evolution namespace.

I think this series overall cleans up the namespaces. I don't really love that evolution is still "hiding" under experimental but currently we don't have a way of marking non-"experimental" configs as experimental still so I guess this will have to suffice for now. I'll take a closer look tomorrow if nobody else gets to this first.

Oct 17 2017, 6:01 PM
ryanmce requested changes to D1150: config: use 'experimental.evolution.allowunstable'.
Oct 17 2017, 6:00 PM
ryanmce accepted D1165: arbitraryfilecontext: skip the cmp fast path if any side is a symlink.

queued

Oct 17 2017, 5:57 PM
ryanmce added inline comments to D1150: config: use 'experimental.evolution.allowunstable'.
Oct 17 2017, 5:41 PM
ryanmce accepted D1133: test-clang-format: new test to verify that files stay clang-formatted.

Yeah, I was running the wrong run-tests.py. Thanks for the help @durin42.

Oct 17 2017, 5:31 PM
ryanmce added a comment to D1133: test-clang-format: new test to verify that files stay clang-formatted.

I get skipped: unknown feature: clang-format when running test-check-clang-format.t now. What am I doing wrong?

Oct 17 2017, 5:18 PM
ryanmce accepted D1156: tests: add test demonstrating regression in path audit.
Oct 17 2017, 5:10 PM
ryanmce accepted D1157: context: audit paths before clearing unknown files and dirs.

queued

Oct 17 2017, 5:10 PM
ryanmce requested changes to D1074: branch: add a --rev flag to change branch name of given revisions.
Oct 17 2017, 8:54 AM
ryanmce accepted D1138: webcommands: replace str(ctx) etc with pycompat.bytestr(ctx) etc.

queued

Oct 17 2017, 8:39 AM
ryanmce accepted D1137: templater: don't blow up when trying to build an abort message.

queued

Oct 17 2017, 8:39 AM
ryanmce accepted D1135: webutil: use pycompat.bytestr() instead of str().

queued

Oct 17 2017, 8:39 AM
ryanmce accepted D1134: hgweb: correct an earlier error of mine - `start` should be bytes.

queued

Oct 17 2017, 8:39 AM
ryanmce added a comment to D1136: templatefilters: defend against evil unicode strs in json filter.

I'll queue this series except this patch so we can have more discussion on what we should do here.

Oct 17 2017, 8:39 AM
ryanmce added a comment to D1136: templatefilters: defend against evil unicode strs in json filter.

I'm not a python 3 expert by any means, but I'm not sold on this change.

Oct 17 2017, 8:23 AM
ryanmce added inline comments to D1135: webutil: use pycompat.bytestr() instead of str().
Oct 17 2017, 8:20 AM
ryanmce updated the summary of D1134: hgweb: correct an earlier error of mine - `start` should be bytes.
Oct 17 2017, 8:19 AM
ryanmce updated the summary of D1134: hgweb: correct an earlier error of mine - `start` should be bytes.
Oct 17 2017, 8:19 AM
ryanmce added a comment to D1117: config: simplify aliasing commands.update.check.

queued

Oct 17 2017, 8:17 AM
ryanmce accepted D1117: config: simplify aliasing commands.update.check.

I agree with @lothiraldan that there's no pressing need to remove aliases, and we should have a mechanism to work before we do this for sure.

Oct 17 2017, 8:13 AM
ryanmce added a comment to D949: run-tests: set HGPLAIN=1 when bisecting.

queued

Oct 17 2017, 8:10 AM
ryanmce accepted D947: run-tests: move bisect logic to a separate method.
Oct 17 2017, 8:09 AM
ryanmce accepted D948: run-tests: extract Popen logic to a single method.

queued

Oct 17 2017, 8:09 AM
ryanmce added a comment to D1122: arbitraryfilecontext: skip the cmp fast path if any side is a symlink.

I'm dropping this from hg-committed for now. Please re-submit with the check-code issues fixed.

Oct 17 2017, 7:47 AM
ryanmce accepted D1132: mpatch: switch alignment of wrapped line from tab to spaces with clang-format.

queued

Oct 17 2017, 7:45 AM
ryanmce accepted D1131: mpatch: reformat function prototypes with clang-format.
Oct 17 2017, 7:44 AM
ryanmce accepted D1130: contrib: remove check-code rule about indentation.
Oct 17 2017, 7:44 AM
ryanmce accepted D1129: clang-format: configuration for the clang-format source formatter.
Oct 17 2017, 7:44 AM
ryanmce requested changes to D1133: test-clang-format: new test to verify that files stay clang-formatted.
Oct 17 2017, 7:36 AM
ryanmce added a comment to D1122: arbitraryfilecontext: skip the cmp fast path if any side is a symlink.

Hm, check-code is failing here.

Oct 17 2017, 6:29 AM
ryanmce added a comment to D947: run-tests: move bisect logic to a separate method.

I think I request revision because the series needed to change, and I wanted to take it out of other people's queues. Will look again at the whole series now.

Oct 17 2017, 6:20 AM
ryanmce retitled D952: merge: additional test cases to show merge-halting behavior from merge: additional test cases to show changing behavior to merge: additional test cases to show merge-halting behavior.
Oct 17 2017, 6:17 AM
ryanmce added a comment to D952: merge: additional test cases to show merge-halting behavior.

D953 is abandoned- should this be as well?

Oct 17 2017, 6:15 AM

Oct 16 2017

ryanmce committed rHG284fa44f7f39: merge: allow user to halt merge on merge-tool failures.
merge: allow user to halt merge on merge-tool failures
Oct 16 2017, 9:50 PM
ryanmce committed rHGed91846c29cf: filemerge: introduce functions to halt merge flow.
filemerge: introduce functions to halt merge flow
Oct 16 2017, 9:50 PM
ryanmce closed D932: filemerge: introduce functions to halt merge flow.
Oct 16 2017, 9:47 PM
ryanmce committed rHGf583cef55995: merge: allow user to halt merge on merge-tool failures.
merge: allow user to halt merge on merge-tool failures
Oct 16 2017, 9:47 PM
ryanmce committed rHGa1625035db16: filemerge: introduce functions to halt merge flow.
filemerge: introduce functions to halt merge flow
Oct 16 2017, 9:47 PM
ryanmce closed D951: merge: allow user to halt merge on merge-tool failures.
Oct 16 2017, 9:47 PM
ryanmce added a comment to D1056: context: add a fast-comparision path between arbitraryfilectx and workingfilectx.

ruh-roh

Oct 16 2017, 6:57 AM
ryanmce accepted D1103: httppeer: always produce native str header keys and values.

queued

Oct 16 2017, 5:15 AM
ryanmce accepted D1104: peer: ensure command names are always ascii bytestrs.

queued

Oct 16 2017, 5:15 AM
ryanmce accepted D1102: wireproto: use %d to encode int, not %s.

queued

Oct 16 2017, 5:15 AM
ryanmce accepted D1101: wireproto: use a proper exception instead of `assert False`.

queued

Oct 16 2017, 5:15 AM
ryanmce accepted D1100: wireproto: use listcomp instead of map().

queued

Oct 16 2017, 5:15 AM
ryanmce accepted D1099: dagutil: use a listcomp instead of a map().

queued

Oct 16 2017, 5:15 AM
ryanmce closed D1054: obsshelve: register maxbackups config.
Oct 16 2017, 5:01 AM
ryanmce committed rFBHGXaf81d6e6710d: obsshelve: register maxbackups config.
obsshelve: register maxbackups config
Oct 16 2017, 5:01 AM

Oct 15 2017

ryanmce requested changes to D1045: obsshelve: register the default of shelve.maxbackups.

I think the tests still fail with this change (I tried the same change myself). Please ensure you've run the tests. D1054 in the fix I came up with after trying this.

Oct 15 2017, 4:16 PM

Oct 14 2017

ryanmce closed D931: merge: ensure that we always commit the mergestate.
Oct 14 2017, 12:55 AM
ryanmce committed rHGc0a524f77e8a: merge: ensure that we always commit the mergestate.
merge: ensure that we always commit the mergestate
Oct 14 2017, 12:55 AM
ryanmce committed rHG143337bcec9b: merge: add tests to show current behavior on failed filemerges.
merge: add tests to show current behavior on failed filemerges
Oct 14 2017, 12:55 AM