Page MenuHomePhabricator

sangeet259 (Sangeet Kumar Mishra)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 8 2018, 2:14 AM (96 w, 1 d)

Recent Activity

Jun 10 2019

sangeet259 added a comment to D6359: test: change test's diff generation to use mdiff for nicer output.

The commit message has diff which confuses hg import. You need to indent those diffs.

Also, remove the pastebin links as they are not required since we have diffs.

Download this bundle : http://bit.ly/2DuJjsS

This link asks me to login. So definitely not a good link to put in commit message.

Jun 10 2019, 5:01 PM
sangeet259 updated the diff for D6359: test: change test's diff generation to use mdiff for nicer output.
Jun 10 2019, 4:56 PM
sangeet259 added a comment to D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff.

@pulkit

My understanding is that the 1st patch should be present in the mercurial installed in the system, which is what you said right? If that's correct, we can go ahead and have this whole as one patch as I don't think people usually do install system hg on patch to patch basis.

Jun 10 2019, 4:44 PM

May 15 2019

sangeet259 updated subscribers of D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff.
In D6356#92644, @pulkit wrote:

Why do I need to split the patches into two ?
The reason to split what would have been a single patch into two is because
for the next patch to be able to use the mdiff during tests,
this revision has to be there in the system's mercurial installation.

I didn't get the last line. Can you explain more?
I think both can be folded in one and should be good.

May 15 2019, 4:00 AM

May 10 2019

sangeet259 created D6359: test: change test's diff generation to use mdiff for nicer output.
May 10 2019, 5:17 PM
sangeet259 added a comment to D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff.

Oh, nice! I sometimes use run-tests.py -i and just accept an unreadable diff because I know that hg diff might make it easier to read. I had not understood why :)

Glad to know you will be helped :)

May 10 2019, 2:16 PM
sangeet259 updated the summary of D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff.
May 10 2019, 2:15 PM
sangeet259 added a comment to D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff.

The future changes to run-tests.py will enable one to use mdiif
to diff rather than unidiff whenever the mercurial is installed in the system.

Perhaps a naive question, but why is that desirable? How will I (as someone running tests) notice?

May 10 2019, 1:40 PM
sangeet259 created D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff.
May 10 2019, 1:28 PM

Feb 19 2019

sangeet259 added a comment to D5514: test: change test's diff generation to use mdiff for nicer output.

Apologies, I didn't run the tests after the latest addition. 😔

Feb 19 2019, 10:41 AM
sangeet259 added a comment to D5514: test: change test's diff generation to use mdiff for nicer output.

Hey @durin42 , take a look at the changes when you get time.

Feb 19 2019, 4:19 AM

Feb 13 2019

sangeet259 added a comment to D5514: test: change test's diff generation to use mdiff for nicer output.
Feb 13 2019, 11:17 PM

Feb 9 2019

sangeet259 updated the diff for D5514: test: change test's diff generation to use mdiff for nicer output.
Feb 9 2019, 11:49 PM

Jan 10 2019

sangeet259 updated the diff for D5514: test: change test's diff generation to use mdiff for nicer output.
Jan 10 2019, 3:55 AM

Jan 9 2019

sangeet259 added a comment to D5514: test: change test's diff generation to use mdiff for nicer output.

@durin42 So the try/except will fall back to unified diff?
Is there a way we can enforce this on system's that don't have mercurial installed globally and not have to fall back on the earlier practice.

Jan 9 2019, 3:05 AM

Jan 7 2019

sangeet259 added a comment to D5514: test: change test's diff generation to use mdiff for nicer output.

Note: To see this in action, one needs to add the changes from this mdiff.py to the mdiff.py of their installed mercurial.
This is because unless you do that, you cannot import mdiff.new_patch as that function won't be there in your installed version, and hence it will keep falling back to the unified_diff.

Jan 7 2019, 10:06 AM
sangeet259 updated the diff for D5514: test: change test's diff generation to use mdiff for nicer output.
Jan 7 2019, 9:59 AM
sangeet259 created D5514: test: change test's diff generation to use mdiff for nicer output.
Jan 7 2019, 9:54 AM

Nov 3 2018

sangeet259 closed D5199: test: fix self._testdir to use ues the right mercurial library during testing.
Nov 3 2018, 10:18 PM
sangeet259 committed rHG78e5b9d815fa: test: fix self._testdir to use the right mercurial library during testing.
test: fix self._testdir to use the right mercurial library during testing
Nov 3 2018, 10:18 PM
sangeet259 added a comment to D5199: test: fix self._testdir to use ues the right mercurial library during testing.

@yuja
This passes the tests now. I had missed the subsequent code that was dependent on the earlier initialisation of self._testdir.
Fixed it.

Nov 3 2018, 3:52 PM
sangeet259 updated the diff for D5199: test: fix self._testdir to use ues the right mercurial library during testing.
Nov 3 2018, 3:27 PM
sangeet259 abandoned D5219: test: remove changes preparing the drop of `HGMERGE`.

I passed the wrong revision number in the -r flag.

Nov 3 2018, 3:24 PM
sangeet259 updated the diff for D5199: test: fix self._testdir to use ues the right mercurial library during testing.
Nov 3 2018, 3:24 PM
sangeet259 added a comment to D5219: test: remove changes preparing the drop of `HGMERGE`.

This was an error. Ignore, something went wrong.

Nov 3 2018, 3:22 PM
sangeet259 created D5219: test: remove changes preparing the drop of `HGMERGE`.
Nov 3 2018, 3:20 PM

Oct 31 2018

sangeet259 created D5199: test: fix self._testdir to use ues the right mercurial library during testing.
Oct 31 2018, 12:32 PM

Aug 9 2018

sangeet259 closed D4157: grep: search all commits in allfiles mode.
Aug 9 2018, 9:01 AM
sangeet259 committed rHGd99468d2b09a: grep: search all commits in allfiles mode.
grep: search all commits in allfiles mode
Aug 9 2018, 9:00 AM

Aug 8 2018

sangeet259 created D4157: grep: search all commits in allfiles mode.
Aug 8 2018, 12:12 PM

Aug 7 2018

sangeet259 closed D3976: grep: add MULTIREV support to --allfiles flag.
Aug 7 2018, 10:52 AM
sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.
In D3976#64274, @yuja wrote:

Queued with minor cleanup, thanks.
As a follow up, can you fix hg grep --all-files -rREVS FILE to scan
unchanged revisions?

Aug 7 2018, 10:51 AM
sangeet259 committed rHGf3f109971359: grep: add MULTIREV support to --allfiles flag.
grep: add MULTIREV support to --allfiles flag
Aug 7 2018, 10:51 AM
sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Aug 7 2018, 10:42 AM
sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Aug 7 2018, 10:33 AM
sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Aug 7 2018, 10:25 AM

Aug 5 2018

sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Aug 5 2018, 5:10 PM

Aug 4 2018

sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.

@yuja Cool, sending the option C now, will try out option D and send a patch if something comes up.

Aug 4 2018, 7:10 AM

Aug 3 2018

sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.

I also expect hg grep --all-files -r0+1 foo will show matches from both rev 0 and 1.

Suppose there are ten hits in 0 and the same 10 hits in 1, do you mean we print out all the 20 results, What purpose that would serve?

Aug 3 2018, 6:29 PM
sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.

Keeping all ctx objects might use too much memory.

True I will change it to files[f] = True

Aug 3 2018, 6:26 PM
sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.

I don't think we should omit files that were seen in earlier revisions

If I don't skip that would mean the same file in the same state being searched across all the revisions, and getting repetitive and redundant hits.

Aug 3 2018, 6:25 PM

Jul 30 2018

sangeet259 updated subscribers of D3976: grep: add MULTIREV support to --allfiles flag.

@yuja can you review this one

Jul 30 2018, 4:35 PM

Jul 25 2018

sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Jul 25 2018, 8:10 AM
sangeet259 abandoned D3981: grep: add MULTIREV support to --all-files flag.

I created a new revision instead of updating the D3976, ignore this one.

Jul 25 2018, 7:58 AM
sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Jul 25 2018, 7:56 AM
sangeet259 created D3981: grep: add MULTIREV support to --all-files flag.
Jul 25 2018, 7:45 AM
sangeet259 created D3976: grep: add MULTIREV support to --allfiles flag.
Jul 25 2018, 3:44 AM

Jul 13 2018

sangeet259 added a comment to D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults.

So what's the next step should be ?

Jul 13 2018, 2:02 PM

Jul 11 2018

sangeet259 added a comment to D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults.

So what is the way around this, does this mean grep can't be changed at all
?
Also can't we update hglib to work accordingly.

Jul 11 2018, 1:44 PM

Jul 10 2018

sangeet259 closed D3826: grep: change default behaviour of grep.
Jul 10 2018, 9:42 AM
sangeet259 committed rHG9ef10437bb88: grep: change default behaviour to search working directory files (BC).
grep: change default behaviour to search working directory files (BC)
Jul 10 2018, 9:41 AM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 10 2018, 5:29 AM

Jul 9 2018

sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 12:52 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 12:46 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 12:39 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 6:04 AM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 6:02 AM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 5:50 AM

Jul 7 2018

sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 7 2018, 11:45 PM

Jul 5 2018

sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 5 2018, 3:30 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 5 2018, 3:13 PM

Jul 3 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

Yeah

Jul 3 2018, 2:17 PM

Jul 2 2018

sangeet259 added a comment to D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use.

I am sorry I accidentally pushed here :/

Jul 2 2018, 8:06 AM
sangeet259 updated the diff for D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use.
Jul 2 2018, 8:04 AM

Jun 28 2018

sangeet259 closed D3825: grep: deprecates `--all` flag.
Jun 28 2018, 2:15 PM
sangeet259 committed rHG8d9d0d30cfcc: grep: deprecates `--all` flag.
grep: deprecates `--all` flag
Jun 28 2018, 2:15 PM
sangeet259 updated the diff for D3825: grep: deprecates `--all` flag.
Jun 28 2018, 1:56 PM
sangeet259 updated the diff for D3825: grep: deprecates `--all` flag.
Jun 28 2018, 1:53 PM

Jun 21 2018

sangeet259 added a comment to D3826: grep: change default behaviour of grep.

I need some help with the tests failing here.

Jun 21 2018, 2:49 PM
sangeet259 retitled D3826: grep: change default behaviour of grep from grep : change default behaviour of grep to grep: change default behaviour of grep.
Jun 21 2018, 2:48 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jun 21 2018, 2:45 PM
sangeet259 created D3826: grep: change default behaviour of grep.
Jun 21 2018, 2:42 PM
sangeet259 created D3825: grep: deprecates `--all` flag.
Jun 21 2018, 12:02 PM
sangeet259 closed D3763: grep: add `--diff` flag.
Jun 21 2018, 8:45 AM
sangeet259 committed rHG7fbb5d76c555: grep: add --diff flag.
grep: add --diff flag
Jun 21 2018, 8:44 AM

Jun 19 2018

sangeet259 updated the diff for D3763: grep: add `--diff` flag.
Jun 19 2018, 4:43 AM

Jun 17 2018

sangeet259 created D3763: grep: add `--diff` flag.
Jun 17 2018, 6:31 AM
sangeet259 closed D3728: grep: adds allfiles mode.
Jun 17 2018, 4:52 AM
sangeet259 committed rHGb8f45fc27370: grep: adds allfiles mode.
grep: adds allfiles mode
Jun 17 2018, 4:51 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 17 2018, 1:51 AM
sangeet259 added a comment to D3728: grep: adds allfiles mode.

@yuja Sorry I didn't run the tests after this edit .

Jun 17 2018, 1:42 AM

Jun 16 2018

sangeet259 updated the summary of D3728: grep: adds allfiles mode.
Jun 16 2018, 10:46 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 16 2018, 9:46 AM

Jun 15 2018

sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 15 2018, 10:13 AM

Jun 13 2018

sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 13 2018, 9:21 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 13 2018, 9:01 AM
sangeet259 added a comment to D3728: grep: adds allfiles mode.

I am updating the tests

Jun 13 2018, 8:44 AM
sangeet259 created D3728: grep: adds allfiles mode.
Jun 13 2018, 8:09 AM

Jun 12 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@martinvonz, thanks for the reviews, but @yuja has asked me to break this patch into three patches. So I guess this is not going to be merged anyway.

Jun 12 2018, 3:34 AM

Jun 11 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja I am adding an --unmodified flag to change to change the mode to grep on the unmodified files as well.
What I am trying to do is ::

def fns_generator():
    if --unmodified:
        for f in ctx:
            for f in ctx:
                if match(f):
                    yield f
    else :
        for f in ctx.files():
            for f in ctx:
                if match(f):
                    yield f
Jun 11 2018, 11:43 AM

Jun 5 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

Hey @yuja
Can you explain why you did this ?

Jun 5 2018, 2:45 PM

Jun 2 2018

sangeet259 closed D3673: grep: enables passing wdir as a revision in grep.
Jun 2 2018, 11:12 PM
sangeet259 committed rHG16f93a3b8b05: grep: enable passing wdir as a revision.
grep: enable passing wdir as a revision
Jun 2 2018, 11:11 PM
sangeet259 updated the diff for D3673: grep: enables passing wdir as a revision in grep.
Jun 2 2018, 2:30 AM

May 30 2018

sangeet259 created D3673: grep: enables passing wdir as a revision in grep.
May 30 2018, 9:31 AM

May 26 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

Perhaps, we'll have to catch WdirUnsupported error to fall back to the filectx API.

May 26 2018, 10:23 AM

May 24 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja
So I was working on it, but the way I tried to correct "wdir()" is by handling it as a special case, so introducing an "if" block again similar to this.
But you were asking to eliminate the if/else block altogether, I wonder if there is way ?

May 24 2018, 5:14 PM

Apr 17 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja

fix grep -r 'wdir()'

Apr 17 2018, 11:05 AM

Apr 3 2018

sangeet259 committed rHGa53b87e20132: histedit: make errror message translatable.
histedit: make errror message translatable
Apr 3 2018, 7:53 AM
sangeet259 closed D3031: histedit: make errror message translatable.
Apr 3 2018, 6:50 AM