sangeet259 (Sangeet Kumar Mishra)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 8 2018, 2:14 AM (19 w, 2 d)

Recent Activity

Thu, Jun 21

sangeet259 added a comment to D3826: grep: change default behaviour of grep.

I need some help with the tests failing here.

Thu, Jun 21, 2:49 PM
sangeet259 retitled D3826: grep: change default behaviour of grep from grep : change default behaviour of grep to grep: change default behaviour of grep.
Thu, Jun 21, 2:48 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Thu, Jun 21, 2:45 PM
sangeet259 created D3826: grep: change default behaviour of grep.
Thu, Jun 21, 2:42 PM
sangeet259 created D3825: grep: deprecates `--all` flag.
Thu, Jun 21, 12:02 PM
sangeet259 closed D3763: grep: add `--diff` flag.
Thu, Jun 21, 8:45 AM
sangeet259 committed rHG7fbb5d76c555: grep: add --diff flag.
grep: add --diff flag
Thu, Jun 21, 8:44 AM

Tue, Jun 19

sangeet259 updated the diff for D3763: grep: add `--diff` flag.
Tue, Jun 19, 4:43 AM

Sun, Jun 17

sangeet259 created D3763: grep: add `--diff` flag.
Sun, Jun 17, 6:31 AM
sangeet259 closed D3728: grep: adds allfiles mode.
Sun, Jun 17, 4:52 AM
sangeet259 committed rHGb8f45fc27370: grep: adds allfiles mode.
grep: adds allfiles mode
Sun, Jun 17, 4:51 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Sun, Jun 17, 1:51 AM
sangeet259 added a comment to D3728: grep: adds allfiles mode.

@yuja Sorry I didn't run the tests after this edit .

Sun, Jun 17, 1:42 AM

Sat, Jun 16

sangeet259 updated the summary of D3728: grep: adds allfiles mode.
Sat, Jun 16, 10:46 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Sat, Jun 16, 9:46 AM

Fri, Jun 15

sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Fri, Jun 15, 10:13 AM

Wed, Jun 13

sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Wed, Jun 13, 9:21 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Wed, Jun 13, 9:01 AM
sangeet259 added a comment to D3728: grep: adds allfiles mode.

I am updating the tests

Wed, Jun 13, 8:44 AM
sangeet259 created D3728: grep: adds allfiles mode.
Wed, Jun 13, 8:09 AM

Tue, Jun 12

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@martinvonz, thanks for the reviews, but @yuja has asked me to break this patch into three patches. So I guess this is not going to be merged anyway.

Tue, Jun 12, 3:34 AM

Mon, Jun 11

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja I am adding an --unmodified flag to change to change the mode to grep on the unmodified files as well.
What I am trying to do is ::

def fns_generator():
    if --unmodified:
        for f in ctx:
            for f in ctx:
                if match(f):
                    yield f
    else :
        for f in ctx.files():
            for f in ctx:
                if match(f):
                    yield f
Mon, Jun 11, 11:43 AM

Tue, Jun 5

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

Hey @yuja
Can you explain why you did this ?

Tue, Jun 5, 2:45 PM

Sat, Jun 2

sangeet259 closed D3673: grep: enables passing wdir as a revision in grep.
Sat, Jun 2, 11:12 PM
sangeet259 committed rHG16f93a3b8b05: grep: enable passing wdir as a revision.
grep: enable passing wdir as a revision
Sat, Jun 2, 11:11 PM
sangeet259 updated the diff for D3673: grep: enables passing wdir as a revision in grep.
Sat, Jun 2, 2:30 AM

Wed, May 30

sangeet259 created D3673: grep: enables passing wdir as a revision in grep.
Wed, May 30, 9:31 AM

Sat, May 26

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

Perhaps, we'll have to catch WdirUnsupported error to fall back to the filectx API.

Sat, May 26, 10:23 AM

Thu, May 24

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja
So I was working on it, but the way I tried to correct "wdir()" is by handling it as a special case, so introducing an "if" block again similar to this.
But you were asking to eliminate the if/else block altogether, I wonder if there is way ?

Thu, May 24, 5:14 PM

Apr 17 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja

fix grep -r 'wdir()'

Apr 17 2018, 11:05 AM

Apr 3 2018

sangeet259 committed rHGa53b87e20132: histedit: make errror message translatable.
histedit: make errror message translatable
Apr 3 2018, 7:53 AM
sangeet259 closed D3031: histedit: make errror message translatable.
Apr 3 2018, 6:50 AM
sangeet259 committed rHGffa79073e4ca: histedit: make errror message translatable.
histedit: make errror message translatable
Apr 3 2018, 6:50 AM
sangeet259 created D3031: histedit: make errror message translatable.
Apr 3 2018, 2:53 AM

Mar 27 2018

sangeet259 committed rHGa2a6755a3def: grep: fixes erroneous output of grep in forward order (issue3885).
grep: fixes erroneous output of grep in forward order (issue3885)
Mar 27 2018, 11:23 AM
sangeet259 updated the diff for D2943: grep: fixes errorneous output of grep in forward order.
Mar 27 2018, 10:55 AM
sangeet259 added a comment to D2943: grep: fixes errorneous output of grep in forward order.

@yuja Yeah, doing it right away, my bad. I should have based it on some revision which is already in the stable.

Mar 27 2018, 9:43 AM

Mar 26 2018

sangeet259 updated the diff for D2943: grep: fixes errorneous output of grep in forward order.
Mar 26 2018, 3:51 PM
sangeet259 added a comment to D2943: grep: fixes errorneous output of grep in forward order.
Mar 26 2018, 10:24 AM
sangeet259 added a comment to D2943: grep: fixes errorneous output of grep in forward order.

Since it required some explanation I have written a post on it.
http://sangeetmishra.me/2018/03/26/demonstrating-the-problem-with-forward-ordered-grep-all-in-mercurial.html

Mar 26 2018, 10:22 AM
sangeet259 created D2943: grep: fixes errorneous output of grep in forward order.
Mar 26 2018, 10:22 AM
sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 26 2018, 9:01 AM

Mar 25 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja Can you please clarify this a bit more?

Mar 25 2018, 3:28 AM
sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 25 2018, 3:17 AM

Mar 24 2018

sangeet259 closed D2394: histedit: make histedit's commands accept revsets (issue5746).
Mar 24 2018, 5:22 PM
sangeet259 committed rHG3d3cff1f6bde: histedit: make histedit's commands accept revsets (issue5746).
histedit: make histedit's commands accept revsets (issue5746)
Mar 24 2018, 5:21 PM
sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 24 2018, 6:09 AM
sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 24 2018, 3:22 AM

Mar 23 2018

sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 23 2018, 4:15 PM
sangeet259 created D2938: grep: make grep search on working directory by default.
Mar 23 2018, 4:05 PM

Mar 10 2018

sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

@pulkit It is not failing as of now. It's failing on the changes proposed by @durin42, which he assumed wont fail, but that's not the case!

Mar 10 2018, 6:40 AM

Mar 9 2018

sangeet259 added a comment to D2588: commit: adds multiline commit message support(issue5616).

Since the current code just overwrites message each time with the newer. What can be done to avoid losing the earlier message values?

Mar 9 2018, 11:25 PM
sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

@durin42 Should I make any changes?

Mar 9 2018, 12:43 PM

Mar 7 2018

sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

@durin42 Here is the output! https://bpaste.net/show/7ccf4a9fea50

Mar 7 2018, 10:51 AM
sangeet259 added a comment to D2588: commit: adds multiline commit message support(issue5616).

@pulkit Yeah, this rather a not so elegant hack. How can it be parsed in hg commit?
As the first message passed is overwritten by the second one at this step only. :/

Mar 7 2018, 10:45 AM
sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

@durin42 Even I thought of this construct before as it appears more elegant. But it is failing some tests!
Specifically, the error messages are changed in this one.

Mar 7 2018, 10:33 AM

Mar 4 2018

sangeet259 updated the diff for D2588: commit: adds multiline commit message support(issue5616).
Mar 4 2018, 2:42 AM
sangeet259 added a comment to D2588: commit: adds multiline commit message support(issue5616).

@jeffpc That means two new lines. Shall I edit this patch to effect that?

Mar 4 2018, 12:56 AM
sangeet259 updated the diff for D2588: commit: adds multiline commit message support(issue5616).
Mar 4 2018, 12:04 AM

Mar 3 2018

sangeet259 added a comment to D2588: commit: adds multiline commit message support(issue5616).
Mar 3 2018, 12:41 PM
sangeet259 created D2588: commit: adds multiline commit message support(issue5616).
Mar 3 2018, 12:27 PM
sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

added the tests @krbullock

Mar 3 2018, 11:19 AM

Mar 2 2018

sangeet259 closed D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.
Mar 2 2018, 6:49 PM
sangeet259 committed rHG4de15c54e59f: clone: updates the help text for hg clone -{r,b} (issue5654).
clone: updates the help text for hg clone -{r,b} (issue5654)
Mar 2 2018, 6:48 PM
sangeet259 updated the summary of D2394: histedit: make histedit's commands accept revsets (issue5746).
Mar 2 2018, 2:46 AM
sangeet259 updated the diff for D2394: histedit: make histedit's commands accept revsets (issue5746).
Mar 2 2018, 2:07 AM

Feb 23 2018

sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

Oh, I forgot adding tests as @durin42 told. Doing that right away!

Feb 23 2018, 2:04 AM
sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

What I did: @durin42 suggested in the issue page that the error was in the verify function of the histedit.py file. But when I ran through debugger using a revision number, the code was throwing the error before it reaches the verify function. Specifically in the fromrules function of the histedit.py file.
It was earlier only accepting rulehashes, I changed that to accept any revset using the scmutil.revsingle function suggested by @timeless on the IRC channel.

Feb 23 2018, 2:01 AM
sangeet259 updated the diff for D2394: histedit: make histedit's commands accept revsets (issue5746).
Feb 23 2018, 1:43 AM
sangeet259 created D2394: histedit: make histedit's commands accept revsets (issue5746).
Feb 23 2018, 1:20 AM

Feb 18 2018

sangeet259 added a comment to D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.

Oh! Thanks for letting me know!
I will keep that in mind.

Feb 18 2018, 9:21 AM

Feb 13 2018

sangeet259 added a comment to D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.

There was a longish discussion on IRC about this. The problem is that the flags by themselves do not document the interaction of -r and -b or multiple instances of either at all. The change was a compromise trying to address that.

Feb 13 2018, 11:03 AM

Feb 9 2018

sangeet259 added a comment to D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.

@dlax Yes, but the short summary didn't say what it does! It just says "include the specified changeset".

Feb 9 2018, 4:27 PM
sangeet259 updated the diff for D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.
Feb 9 2018, 9:36 AM
sangeet259 updated the diff for D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.
Feb 9 2018, 9:29 AM

Feb 8 2018

sangeet259 created D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b.
Feb 8 2018, 1:05 PM