sangeet259 (Sangeet Kumar Mishra)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 8 2018, 2:14 AM (27 w, 18 h)

Recent Activity

Thu, Aug 9

sangeet259 closed D4157: grep: search all commits in allfiles mode.
Thu, Aug 9, 9:01 AM
sangeet259 committed rHGd99468d2b09a: grep: search all commits in allfiles mode.
grep: search all commits in allfiles mode
Thu, Aug 9, 9:00 AM

Wed, Aug 8

sangeet259 created D4157: grep: search all commits in allfiles mode.
Wed, Aug 8, 12:12 PM

Tue, Aug 7

sangeet259 closed D3976: grep: add MULTIREV support to --allfiles flag.
Tue, Aug 7, 10:52 AM
sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.
In D3976#64274, @yuja wrote:

Queued with minor cleanup, thanks.

As a follow up, can you fix hg grep --all-files -rREVS FILE to scan
unchanged revisions?

Tue, Aug 7, 10:51 AM
sangeet259 committed rHGf3f109971359: grep: add MULTIREV support to --allfiles flag.
grep: add MULTIREV support to --allfiles flag
Tue, Aug 7, 10:51 AM
sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Tue, Aug 7, 10:42 AM
sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Tue, Aug 7, 10:33 AM
sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Tue, Aug 7, 10:25 AM

Sun, Aug 5

sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Sun, Aug 5, 5:10 PM

Sat, Aug 4

sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.

@yuja Cool, sending the option C now, will try out option D and send a patch if something comes up.

Sat, Aug 4, 7:10 AM

Fri, Aug 3

sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.
I also expect hg grep --all-files -r0+1 foo will show matches from both rev 0 and 1.

Suppose there are ten hits in 0 and the same 10 hits in 1, do you mean we print out all the 20 results, What purpose that would serve?

Fri, Aug 3, 6:29 PM
sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.

Keeping all ctx objects might use too much memory.

True I will change it to files[f] = True

Fri, Aug 3, 6:26 PM
sangeet259 added a comment to D3976: grep: add MULTIREV support to --allfiles flag.

I don't think we should omit files that were seen in earlier revisions

If I don't skip that would mean the same file in the same state being searched across all the revisions, and getting repetitive and redundant hits.

Fri, Aug 3, 6:25 PM

Mon, Jul 30

sangeet259 updated subscribers of D3976: grep: add MULTIREV support to --allfiles flag.

@yuja can you review this one

Mon, Jul 30, 4:35 PM

Wed, Jul 25

sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Wed, Jul 25, 8:10 AM
sangeet259 abandoned D3981: grep: add MULTIREV support to --all-files flag.

I created a new revision instead of updating the D3976, ignore this one.

Wed, Jul 25, 7:58 AM
sangeet259 updated the diff for D3976: grep: add MULTIREV support to --allfiles flag.
Wed, Jul 25, 7:56 AM
sangeet259 created D3981: grep: add MULTIREV support to --all-files flag.
Wed, Jul 25, 7:45 AM
sangeet259 created D3976: grep: add MULTIREV support to --allfiles flag.
Wed, Jul 25, 3:44 AM

Jul 13 2018

sangeet259 added a comment to D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults.

So what's the next step should be ?

Jul 13 2018, 2:02 PM

Jul 11 2018

sangeet259 added a comment to D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults.

So what is the way around this, does this mean grep can't be changed at all
?
Also can't we update hglib to work accordingly.

Jul 11 2018, 1:44 PM

Jul 10 2018

sangeet259 closed D3826: grep: change default behaviour of grep.
Jul 10 2018, 9:42 AM
sangeet259 committed rHG9ef10437bb88: grep: change default behaviour to search working directory files (BC).
grep: change default behaviour to search working directory files (BC)
Jul 10 2018, 9:41 AM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 10 2018, 5:29 AM

Jul 9 2018

sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 12:52 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 12:46 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 12:39 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 6:04 AM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 6:02 AM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 9 2018, 5:50 AM

Jul 7 2018

sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 7 2018, 11:45 PM

Jul 5 2018

sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 5 2018, 3:30 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jul 5 2018, 3:13 PM

Jul 3 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

Yeah

Jul 3 2018, 2:17 PM

Jul 2 2018

sangeet259 added a comment to D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use.

I am sorry I accidentally pushed here :/

Jul 2 2018, 8:06 AM
sangeet259 updated the diff for D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use.
Jul 2 2018, 8:04 AM

Jun 28 2018

sangeet259 closed D3825: grep: deprecates `--all` flag.
Jun 28 2018, 2:15 PM
sangeet259 committed rHG8d9d0d30cfcc: grep: deprecates `--all` flag.
grep: deprecates `--all` flag
Jun 28 2018, 2:15 PM
sangeet259 updated the diff for D3825: grep: deprecates `--all` flag.
Jun 28 2018, 1:56 PM
sangeet259 updated the diff for D3825: grep: deprecates `--all` flag.
Jun 28 2018, 1:53 PM

Jun 21 2018

sangeet259 added a comment to D3826: grep: change default behaviour of grep.

I need some help with the tests failing here.

Jun 21 2018, 2:49 PM
sangeet259 retitled D3826: grep: change default behaviour of grep from grep : change default behaviour of grep to grep: change default behaviour of grep.
Jun 21 2018, 2:48 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Jun 21 2018, 2:45 PM
sangeet259 created D3826: grep: change default behaviour of grep.
Jun 21 2018, 2:42 PM
sangeet259 created D3825: grep: deprecates `--all` flag.
Jun 21 2018, 12:02 PM
sangeet259 closed D3763: grep: add `--diff` flag.
Jun 21 2018, 8:45 AM
sangeet259 committed rHG7fbb5d76c555: grep: add --diff flag.
grep: add --diff flag
Jun 21 2018, 8:44 AM

Jun 19 2018

sangeet259 updated the diff for D3763: grep: add `--diff` flag.
Jun 19 2018, 4:43 AM

Jun 17 2018

sangeet259 created D3763: grep: add `--diff` flag.
Jun 17 2018, 6:31 AM
sangeet259 closed D3728: grep: adds allfiles mode.
Jun 17 2018, 4:52 AM
sangeet259 committed rHGb8f45fc27370: grep: adds allfiles mode.
grep: adds allfiles mode
Jun 17 2018, 4:51 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 17 2018, 1:51 AM
sangeet259 added a comment to D3728: grep: adds allfiles mode.

@yuja Sorry I didn't run the tests after this edit .

Jun 17 2018, 1:42 AM

Jun 16 2018

sangeet259 updated the summary of D3728: grep: adds allfiles mode.
Jun 16 2018, 10:46 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 16 2018, 9:46 AM

Jun 15 2018

sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 15 2018, 10:13 AM

Jun 13 2018

sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 13 2018, 9:21 AM
sangeet259 updated the diff for D3728: grep: adds allfiles mode.
Jun 13 2018, 9:01 AM
sangeet259 added a comment to D3728: grep: adds allfiles mode.

I am updating the tests

Jun 13 2018, 8:44 AM
sangeet259 created D3728: grep: adds allfiles mode.
Jun 13 2018, 8:09 AM

Jun 12 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@martinvonz, thanks for the reviews, but @yuja has asked me to break this patch into three patches. So I guess this is not going to be merged anyway.

Jun 12 2018, 3:34 AM

Jun 11 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja I am adding an --unmodified flag to change to change the mode to grep on the unmodified files as well.
What I am trying to do is ::

def fns_generator():
    if --unmodified:
        for f in ctx:
            for f in ctx:
                if match(f):
                    yield f
    else :
        for f in ctx.files():
            for f in ctx:
                if match(f):
                    yield f
Jun 11 2018, 11:43 AM

Jun 5 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

Hey @yuja
Can you explain why you did this ?

Jun 5 2018, 2:45 PM

Jun 2 2018

sangeet259 closed D3673: grep: enables passing wdir as a revision in grep.
Jun 2 2018, 11:12 PM
sangeet259 committed rHG16f93a3b8b05: grep: enable passing wdir as a revision.
grep: enable passing wdir as a revision
Jun 2 2018, 11:11 PM
sangeet259 updated the diff for D3673: grep: enables passing wdir as a revision in grep.
Jun 2 2018, 2:30 AM

May 30 2018

sangeet259 created D3673: grep: enables passing wdir as a revision in grep.
May 30 2018, 9:31 AM

May 26 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

Perhaps, we'll have to catch WdirUnsupported error to fall back to the filectx API.

May 26 2018, 10:23 AM

May 24 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja
So I was working on it, but the way I tried to correct "wdir()" is by handling it as a special case, so introducing an "if" block again similar to this.
But you were asking to eliminate the if/else block altogether, I wonder if there is way ?

May 24 2018, 5:14 PM

Apr 17 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja

fix grep -r 'wdir()'

Apr 17 2018, 11:05 AM

Apr 3 2018

sangeet259 committed rHGa53b87e20132: histedit: make errror message translatable.
histedit: make errror message translatable
Apr 3 2018, 7:53 AM
sangeet259 closed D3031: histedit: make errror message translatable.
Apr 3 2018, 6:50 AM
sangeet259 committed rHGffa79073e4ca: histedit: make errror message translatable.
histedit: make errror message translatable
Apr 3 2018, 6:50 AM
sangeet259 created D3031: histedit: make errror message translatable.
Apr 3 2018, 2:53 AM

Mar 27 2018

sangeet259 committed rHGa2a6755a3def: grep: fixes erroneous output of grep in forward order (issue3885).
grep: fixes erroneous output of grep in forward order (issue3885)
Mar 27 2018, 11:23 AM
sangeet259 updated the diff for D2943: grep: fixes errorneous output of grep in forward order.
Mar 27 2018, 10:55 AM
sangeet259 added a comment to D2943: grep: fixes errorneous output of grep in forward order.

@yuja Yeah, doing it right away, my bad. I should have based it on some revision which is already in the stable.

Mar 27 2018, 9:43 AM

Mar 26 2018

sangeet259 updated the diff for D2943: grep: fixes errorneous output of grep in forward order.
Mar 26 2018, 3:51 PM
sangeet259 added a comment to D2943: grep: fixes errorneous output of grep in forward order.
Mar 26 2018, 10:24 AM
sangeet259 added a comment to D2943: grep: fixes errorneous output of grep in forward order.

Since it required some explanation I have written a post on it.
http://sangeetmishra.me/2018/03/26/demonstrating-the-problem-with-forward-ordered-grep-all-in-mercurial.html

Mar 26 2018, 10:22 AM
sangeet259 created D2943: grep: fixes errorneous output of grep in forward order.
Mar 26 2018, 10:22 AM
sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 26 2018, 9:01 AM

Mar 25 2018

sangeet259 added a comment to D2938: grep: make grep search on working directory by default.

@yuja Can you please clarify this a bit more?

Mar 25 2018, 3:28 AM
sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 25 2018, 3:17 AM

Mar 24 2018

sangeet259 closed D2394: histedit: make histedit's commands accept revsets (issue5746).
Mar 24 2018, 5:22 PM
sangeet259 committed rHG3d3cff1f6bde: histedit: make histedit's commands accept revsets (issue5746).
histedit: make histedit's commands accept revsets (issue5746)
Mar 24 2018, 5:21 PM
sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 24 2018, 6:09 AM
sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 24 2018, 3:22 AM

Mar 23 2018

sangeet259 updated the diff for D2938: grep: make grep search on working directory by default.
Mar 23 2018, 4:15 PM
sangeet259 created D2938: grep: make grep search on working directory by default.
Mar 23 2018, 4:05 PM

Mar 10 2018

sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

@pulkit It is not failing as of now. It's failing on the changes proposed by @durin42, which he assumed wont fail, but that's not the case!

Mar 10 2018, 6:40 AM

Mar 9 2018

sangeet259 added a comment to D2588: commit: adds multiline commit message support(issue5616).

Since the current code just overwrites message each time with the newer. What can be done to avoid losing the earlier message values?

Mar 9 2018, 11:25 PM
sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

@durin42 Should I make any changes?

Mar 9 2018, 12:43 PM

Mar 7 2018

sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

@durin42 Here is the output! https://bpaste.net/show/7ccf4a9fea50

Mar 7 2018, 10:51 AM
sangeet259 added a comment to D2588: commit: adds multiline commit message support(issue5616).

@pulkit Yeah, this rather a not so elegant hack. How can it be parsed in hg commit?
As the first message passed is overwritten by the second one at this step only. :/

Mar 7 2018, 10:45 AM
sangeet259 added a comment to D2394: histedit: make histedit's commands accept revsets (issue5746).

@durin42 Even I thought of this construct before as it appears more elegant. But it is failing some tests!
Specifically, the error messages are changed in this one.

Mar 7 2018, 10:33 AM

Mar 4 2018

sangeet259 updated the diff for D2588: commit: adds multiline commit message support(issue5616).
Mar 4 2018, 2:42 AM
sangeet259 added a comment to D2588: commit: adds multiline commit message support(issue5616).

@jeffpc That means two new lines. Shall I edit this patch to effect that?

Mar 4 2018, 12:56 AM
sangeet259 updated the diff for D2588: commit: adds multiline commit message support(issue5616).
Mar 4 2018, 12:04 AM