- User Since
- Aug 30 2020, 9:52 PM (21 w, 23 h)
Nov 23 2020
The test failure has a diff. I still think that's just noise that will confuse much more than it helps. Okay if I drop the test plan from the commit message in flight?
That's what I meant: you need to indent diffs that you include in the commit message, otherwise tools can't figure out where the commit message ends and the diff starts. But I still think you can just remove that whole thing from the commit message; it's implied that the test plan is to run the test suite, so you only need to describe your test plan if you did some other testing and/or did not run the test suite.
Also, including diff output (such as from failing tests) without indentation makes the patch fail to apply:
unable to find 'tank/home/sebhtml/projects/mercurial/sebhtml-hg-log-bookmark/hg-committed/tests/test-lfs-serve.t' for patching
Nov 18 2020
Nov 12 2020
Nov 11 2020
As I said before, hg export, hg email, hg strip all rely on scmutil.bookmarkrevs(). I don't see how you get the same semantics with the current revset.
This patch was queued and then dropped. I don't think Phabricator has a way of indicating that. I think you'll have to send a new patch (with a new D-number) if you want to pursue this.
Nov 8 2020
Oct 3 2020
Sep 26 2020
Sep 24 2020
Sep 19 2020
I also ran all the tests.
It seems to work as expected:
I added a test here https://phab.mercurial-scm.org/D9060