Page MenuHomePhabricator

sebhtml (Sébastien Boisvert)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2020, 9:52 PM (8 w, 2 d)

Recent Activity

Sat, Oct 3

sebhtml added a comment to D8973: log: add support for bookmarks.

For the record, I'm -1 on this, for the following reasons:

Comparing with hg push/pull doesn't seem right. Those command *have to* exchange ancestors (e.g. hg push -r abc123 doesn't exchange just abc123). Let's look for other examples. Oh, hg export has a -B flag (I had no idea). Interestingly, it turns out to use semantics similar to what my guess about your hg log -B was :) It apparently relies no scmutil.bookmarkrevs(). Looking at other callers of that function, I found that hg email and hg strip also have -B options with the same semantics. I'd be much more comfortable taking a patch that used the same semantics for hg log -B. It's a little unfortunate that that won't match the bookmark() revset, but that's still much better than adding a third way of matching revisions (I count hg push/pull -B as matching the revset semantics of giving you only the commits pointed to).

Sat, Oct 3, 10:09 AM
sebhtml added a comment to D8973: log: add support for bookmarks.

Folded next couple of patches in this one and queued. Thank you!

Sat, Oct 3, 10:06 AM

Sep 26 2020

sebhtml added a comment to D8973: log: add support for bookmarks.

For the record, I'm -1 on this, for the following reasons:

Sep 26 2020, 11:47 AM

Sep 24 2020

sebhtml closed D8973: log: add support for bookmarks.
Sep 24 2020, 3:36 AM
sebhtml committed rHG2517df770648: log: add support for bookmarks.
log: add support for bookmarks
Sep 24 2020, 3:35 AM

Sep 19 2020

sebhtml created D9061: test: add bookmark for 'log' in test-completion.
Sep 19 2020, 11:35 AM
sebhtml added a comment to D9060: test: test 'hg log' using a bookmark.

I also ran all the tests.

Sep 19 2020, 10:08 AM
sebhtml added a comment to D9060: test: test 'hg log' using a bookmark.

It seems to work as expected:

Sep 19 2020, 9:20 AM
sebhtml added a comment to D8973: log: add support for bookmarks.

I added a test here https://phab.mercurial-scm.org/D9060

Sep 19 2020, 9:19 AM
sebhtml created D9060: test: test 'hg log' using a bookmark.
Sep 19 2020, 9:17 AM

Sep 3 2020

sebhtml added a comment to D8973: log: add support for bookmarks.

Thanks for the patch. Can you add some test case for this?

Sep 3 2020, 9:01 PM

Aug 30 2020

sebhtml created D8973: log: add support for bookmarks.
Aug 30 2020, 10:07 PM