sheehan (Connor Sheehan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 3 2018, 9:56 AM (41 w, 1 d)

Recent Activity

Nov 2 2018

sheehan abandoned D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3.

Either way, we'll be deploying this to Mozilla's hg servers in the next few months and testing it out. Perhaps after it's been in production for some time we will have a stronger case for inclusion in core. :)

Nov 2 2018, 11:00 AM

Oct 30 2018

sheehan added a comment to D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3.

Is this useful enough to others that it should live in the hg core repo? It doesn't seem like it to me, but maybe I'm wrong.

Oct 30 2018, 9:57 AM

Oct 26 2018

sheehan updated subscribers of D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3.

Throwing this up for review now, but there are a few things that could be done to improve this. A cache expiration policy might be useful, but is difficult to test with the S3 bucket expiration rules. It may also be desirable to be able to specify more than one S3 bucket/region/account in the future.

Oct 26 2018, 5:20 PM
sheehan created D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3.
Oct 26 2018, 5:16 PM

Oct 14 2018

sheehan committed rHG4821affc154f: wireproto: fix incorrect function name in docstring.
wireproto: fix incorrect function name in docstring
Oct 14 2018, 5:28 AM
sheehan closed D5090: wireproto: fix incorrect function name in docstring.
Oct 14 2018, 5:28 AM
sheehan created D5090: wireproto: fix incorrect function name in docstring.
Oct 14 2018, 3:43 AM

Aug 20 2018

sheehan planned changes to D4283: webcommands: fix `@webcommand` decorator.

This seems like a strict improvement.

But the proper way to register web commands from extensions would be to go through the registrar API and have the extension loader look for a well-named symbol in each extension module that is loaded and hgweb would consult the registrar for active commands. In theory, this will only activate web commands on repositories that have an extension loaded.

Search for templatefilter in mercurial/extensions.py for an example of how all this works.

Would you be willing to try that approach? It doesn't have to be perfect. But we are moving to the registrar for extensions wishing to install well-defined things. And web commands fit that bill.

Aug 20 2018, 9:46 AM

Aug 15 2018

sheehan created D4283: webcommands: fix `@webcommand` decorator.
Aug 15 2018, 3:00 PM

Mar 31 2018

sheehan committed rHG0e7550b0964c: stringutil: improve check for failed mailmap line parsing.
stringutil: improve check for failed mailmap line parsing
Mar 31 2018, 9:59 PM
sheehan committed rHG2ed180117f76: stringutil: edit comment to reflect actual data type name.
stringutil: edit comment to reflect actual data type name
Mar 31 2018, 9:59 PM
sheehan closed D3003: stringutil: improve check for failed mailmap line parsing.
Mar 31 2018, 9:59 PM
sheehan closed D3004: stringutil: edit comment to reflect actual data type name.
Mar 31 2018, 9:59 PM
sheehan committed rHG54b896f195d1: stringutil: rename local email/names variables to their plural forms.
stringutil: rename local email/names variables to their plural forms
Mar 31 2018, 9:59 PM
sheehan committed rHG3685a79ea51b: templatefuncs: remove redundant "or author" from mailmap return statement.
templatefuncs: remove redundant "or author" from mailmap return statement
Mar 31 2018, 9:59 PM
sheehan closed D3001: templatefuncs: remove redundant "or author" from mailmap return statement.
Mar 31 2018, 9:59 PM
sheehan closed D3002: stringutil: rename local email/names variables to their plural forms.
Mar 31 2018, 9:59 PM
sheehan created D3004: stringutil: edit comment to reflect actual data type name.
Mar 31 2018, 4:37 PM
sheehan added a dependent revision for D3003: stringutil: improve check for failed mailmap line parsing: D3004: stringutil: edit comment to reflect actual data type name.
Mar 31 2018, 4:37 PM
sheehan created D3003: stringutil: improve check for failed mailmap line parsing.
Mar 31 2018, 4:37 PM
sheehan created D3002: stringutil: rename local email/names variables to their plural forms.
Mar 31 2018, 4:37 PM
sheehan added a dependent revision for D3002: stringutil: rename local email/names variables to their plural forms: D3003: stringutil: improve check for failed mailmap line parsing.
Mar 31 2018, 4:37 PM
sheehan created D3001: templatefuncs: remove redundant "or author" from mailmap return statement.
Mar 31 2018, 4:37 PM
sheehan added a dependent revision for D3001: templatefuncs: remove redundant "or author" from mailmap return statement: D3002: stringutil: rename local email/names variables to their plural forms.
Mar 31 2018, 4:37 PM
sheehan added a comment to D2904: templatefuncs: add mailmap template function.
In D2904#48406, @yuja wrote:

Queued, thanks. Can you send a followup?

Mar 31 2018, 10:11 AM
sheehan abandoned D2903: utils: add isauthorwellformed function.

Abandoning, this was landed as another differential.

Mar 31 2018, 10:03 AM

Mar 30 2018

sheehan closed D2904: templatefuncs: add mailmap template function.
Mar 30 2018, 9:22 PM
sheehan committed rHG2a2ce93e12f4: templatefuncs: add mailmap template function.
templatefuncs: add mailmap template function
Mar 30 2018, 9:22 PM
sheehan updated the diff for D2904: templatefuncs: add mailmap template function.
Mar 30 2018, 11:11 AM
sheehan closed D2960: stringutil: move person function from templatefilters.
Mar 30 2018, 8:56 AM
sheehan committed rHGfb7140f1d09d: stringutil: move person function from templatefilters.
stringutil: move person function from templatefilters
Mar 30 2018, 8:56 AM
sheehan committed rHGf8e1f48de118: stringutil: add isauthorwellformed function.
stringutil: add isauthorwellformed function
Mar 30 2018, 8:56 AM
sheehan closed D2959: stringutil: add isauthorwellformed function.
Mar 30 2018, 8:56 AM

Mar 29 2018

sheehan updated the diff for D2904: templatefuncs: add mailmap template function.
Mar 29 2018, 10:10 AM
sheehan updated the diff for D2960: stringutil: move person function from templatefilters.
Mar 29 2018, 10:10 AM
sheehan updated the diff for D2959: stringutil: add isauthorwellformed function.
Mar 29 2018, 10:10 AM

Mar 27 2018

sheehan updated the diff for D2904: templatefuncs: add mailmap template function.
Mar 27 2018, 12:04 PM
sheehan created D2960: stringutil: move person function from templatefilters.
Mar 27 2018, 12:04 PM
sheehan created D2959: stringutil: add isauthorwellformed function.
Mar 27 2018, 12:04 PM

Mar 20 2018

sheehan created D2903: utils: add isauthorwellformed function.
Mar 20 2018, 1:56 PM
sheehan created D2904: templatefuncs: add mailmap template function.
Mar 20 2018, 1:56 PM
sheehan added a dependent revision for D2903: utils: add isauthorwellformed function: D2904: templatefuncs: add mailmap template function.
Mar 20 2018, 1:56 PM