Page MenuHomePhabricator

sid0 (Siddharth Agarwal)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:31 PM (163 w, 1 d)
Roles
Administrator

Recent Activity

Jan 19 2018

sid0 committed rHG047581ddb6ce: sshserver: add a couple of tests for argument parsing.
sshserver: add a couple of tests for argument parsing
Jan 19 2018, 5:41 PM

Nov 30 2017

sid0 committed rFBHGX623cb2d57f7e: remotefilelog: fix wirepack spec.
remotefilelog: fix wirepack spec
Nov 30 2017, 8:23 PM
sid0 closed D1443: remotefilelog: fix wirepack spec.
Nov 30 2017, 8:23 PM

Nov 16 2017

sid0 created D1443: remotefilelog: fix wirepack spec.
Nov 16 2017, 8:19 PM

Oct 30 2017

sid0 closed D1223: merge: disable path conflict checking by default (issue5716).
Oct 30 2017, 5:31 PM
sid0 closed D1222: merge: add a config option to disable path conflict checking.
Oct 30 2017, 5:31 PM
sid0 committed rHG2a774cae3a03: merge: disable path conflict checking by default (issue5716).
merge: disable path conflict checking by default (issue5716)
Oct 30 2017, 5:30 PM
sid0 committed rHG37450a122128: merge: add a config option to disable path conflict checking.
merge: add a config option to disable path conflict checking
Oct 30 2017, 5:30 PM

Oct 24 2017

sid0 added a comment to D1222: merge: add a config option to disable path conflict checking.

The debug section doesn't seem to exists, could we use 'experimental' instead while we fix the performance regression?

Oct 24 2017, 3:08 PM
sid0 updated the diff for D1223: merge: disable path conflict checking by default (issue5716).
Oct 24 2017, 3:08 PM
sid0 updated the diff for D1222: merge: add a config option to disable path conflict checking.
Oct 24 2017, 3:08 PM
sid0 added a comment to D1224: merge: cache unknown dir checks (issue5716).

Could you make this a class with unknowndircache and missingdircache being private fields?

Oct 24 2017, 2:04 PM
sid0 updated the diff for D1223: merge: disable path conflict checking by default (issue5716).
Oct 24 2017, 12:25 AM

Oct 23 2017

sid0 updated the diff for D1223: merge: disable path conflict checking by default (issue5716).
Oct 23 2017, 10:17 PM
sid0 created D1223: merge: disable path conflict checking by default (issue5716).
Oct 23 2017, 7:45 PM
sid0 created D1222: merge: add a config option to disable path conflict checking.
Oct 23 2017, 7:45 PM

Oct 2 2017

sid0 closed D898: annotate: introduce attr for storing per-line annotate data.
Oct 2 2017, 1:23 PM
sid0 closed D900: annotate: mark lines affected by skip-annotate with *.
Oct 2 2017, 1:23 PM
sid0 closed D899: annotate: track whether a particular annotation was the result of a skip.
Oct 2 2017, 1:23 PM
sid0 committed rHG884b595f5195: annotate: mark lines affected by skip-annotate with *.
annotate: mark lines affected by skip-annotate with *
Oct 2 2017, 1:23 PM
sid0 committed rHG2f5a135b2b04: annotate: track whether a particular annotation was the result of a skip.
annotate: track whether a particular annotation was the result of a skip
Oct 2 2017, 1:23 PM
sid0 closed D896: annotate: move annotatepair unit tests to a separate file.
Oct 2 2017, 1:23 PM
sid0 closed D897: context: rename local 'attr' to 'attr_'.
Oct 2 2017, 1:23 PM
sid0 committed rHG2e32c6a31cc7: annotate: introduce attr for storing per-line annotate data.
annotate: introduce attr for storing per-line annotate data
Oct 2 2017, 1:23 PM
sid0 committed rHG52e9310626a8: context: rename local 'attr' to 'attr_'.
context: rename local 'attr' to 'attr_'
Oct 2 2017, 1:23 PM
sid0 committed rHG80215865d154: annotate: move annotatepair unit tests to a separate file.
annotate: move annotatepair unit tests to a separate file
Oct 2 2017, 1:23 PM
sid0 committed rHGb332c01247d8: check-code: allow an exception for camelcase where required.
check-code: allow an exception for camelcase where required
Oct 2 2017, 1:23 PM
sid0 closed D895: check-code: allow an exception for camelcase where required.
Oct 2 2017, 1:23 PM
sid0 added a comment to D899: annotate: track whether a particular annotation was the result of a skip.

Turns out it actually was buggy. Thanks for catching it!

Oct 2 2017, 11:09 AM
sid0 updated the diff for D899: annotate: track whether a particular annotation was the result of a skip.
Oct 2 2017, 11:08 AM
sid0 updated the diff for D898: annotate: introduce attr for storing per-line annotate data.
Oct 2 2017, 11:05 AM
sid0 updated the diff for D900: annotate: mark lines affected by skip-annotate with *.
Oct 2 2017, 11:05 AM
sid0 updated the diff for D899: annotate: track whether a particular annotation was the result of a skip.
Oct 2 2017, 11:05 AM
sid0 added inline comments to D899: annotate: track whether a particular annotation was the result of a skip.
Oct 2 2017, 10:59 AM
sid0 added a comment to D899: annotate: track whether a particular annotation was the result of a skip.

I'll add a comment explaining that.

Oct 2 2017, 10:57 AM
sid0 added inline comments to D899: annotate: track whether a particular annotation was the result of a skip.
Oct 2 2017, 10:56 AM
sid0 added a comment to D900: annotate: mark lines affected by skip-annotate with *.

Yeah, I plan to do all of those before marking the option un-experimental.

Oct 2 2017, 10:51 AM
sid0 created D898: annotate: introduce attr for storing per-line annotate data.
Oct 2 2017, 5:35 AM
sid0 created D900: annotate: mark lines affected by skip-annotate with *.
Oct 2 2017, 5:35 AM
sid0 created D899: annotate: track whether a particular annotation was the result of a skip.
Oct 2 2017, 5:35 AM
sid0 created D897: context: rename local 'attr' to 'attr_'.
Oct 2 2017, 5:35 AM
sid0 created D896: annotate: move annotatepair unit tests to a separate file.
Oct 2 2017, 5:35 AM
sid0 created D895: check-code: allow an exception for camelcase where required.
Oct 2 2017, 5:35 AM

Oct 1 2017

sid0 closed D867: thirdparty: vendor attrs.
Oct 1 2017, 7:34 AM
sid0 closed D866: tests: disable lints on mercurial/thirdparty.
Oct 1 2017, 7:34 AM
sid0 committed rHG765eb17a7eb8: thirdparty: vendor attrs.
thirdparty: vendor attrs
Oct 1 2017, 7:34 AM
sid0 closed D868: changelog: use attrs instead of namedtuple.
Oct 1 2017, 7:34 AM
sid0 committed rHGe51c8ffa1ffa: changelog: use attrs instead of namedtuple.
changelog: use attrs instead of namedtuple
Oct 1 2017, 7:34 AM
sid0 committed rHG9fb9f8440b71: python3: don't byte mangle third-party packages.
python3: don't byte mangle third-party packages
Oct 1 2017, 7:34 AM
sid0 committed rHG41401f502c83: tests: disable lints on mercurial/thirdparty.
tests: disable lints on mercurial/thirdparty
Oct 1 2017, 7:34 AM
sid0 closed D871: python3: don't byte mangle third-party packages.
Oct 1 2017, 7:34 AM
sid0 updated the diff for D871: python3: don't byte mangle third-party packages.
Oct 1 2017, 7:14 AM
sid0 updated the diff for D867: thirdparty: vendor attrs.
Oct 1 2017, 7:11 AM
sid0 created D871: python3: don't byte mangle third-party packages.
Oct 1 2017, 7:11 AM
sid0 created D866: tests: disable lints on mercurial/thirdparty.
Oct 1 2017, 6:36 AM
sid0 created D868: changelog: use attrs instead of namedtuple.
Oct 1 2017, 6:36 AM
sid0 created D867: thirdparty: vendor attrs.
Oct 1 2017, 6:36 AM

Sep 18 2017

sid0 added a comment to D698: examplerust: add an example extension written in Rust.

And if the concern is about deb packages that we provide -- Rust links its runtime statically I believe.

Sep 18 2017, 8:11 PM
sid0 added a comment to D698: examplerust: add an example extension written in Rust.

I can't see that keeping Debian releases possible. In my view if "no more than 2 or 3 stable releases" is a hard requirement for rust, we may as well stop having the discussion now.
(Alternatively: convince me with documented success cases that binaries built by a newer Rust than is in a given Debian release are somehow plausible and acceptable.)

Sep 18 2017, 8:03 PM

Aug 17 2017

sid0 accepted D437: pager: migrate to modern pager API.
Aug 17 2017, 4:22 PM

Aug 15 2017

sid0 added a comment to D351: demandimport: disable if chg is being used.

I tried that approach. If we only set HGDEMANDIMPORT for the forked process to execute hg server, it will be an infinite loop - environment config hash will mismatch. Setting HGDEMANDIMPORT for both the forked and non-forked chg client processes seems less cleaner.

Aug 15 2017, 2:05 PM

Jul 21 2017

sid0 committed rHG34a8ef358c93: test-dirstate-race: hide irrelevant hg status output.
test-dirstate-race: hide irrelevant hg status output
Jul 21 2017, 12:55 AM
sid0 closed D153: test-dirstate-race: hide irrelevant hg status output by committing rHG34a8ef358c93: test-dirstate-race: hide irrelevant hg status output.
Jul 21 2017, 12:55 AM

Jul 20 2017

sid0 accepted D162: upgradegeneraldelta: update to work with upstream revlog changes.

Honestly, I'd just delete this extension -- it is no longer useful and I'm not aware of any non-FB users of it.

Jul 20 2017, 10:36 PM
sid0 retitled D153: test-dirstate-race: hide irrelevant hg status output from test-dirstate-race: replace BROKEN line with explanation of changed output to test-dirstate-race: hide irrelevant hg status output.
Jul 20 2017, 9:05 PM
sid0 updated the diff for D153: test-dirstate-race: hide irrelevant hg status output.
Jul 20 2017, 9:04 PM
sid0 added inline comments to D153: test-dirstate-race: hide irrelevant hg status output.
Jul 20 2017, 12:04 PM
sid0 added inline comments to D153: test-dirstate-race: hide irrelevant hg status output.
Jul 20 2017, 12:43 AM
sid0 added inline comments to D153: test-dirstate-race: hide irrelevant hg status output.
Jul 20 2017, 12:42 AM

Jul 19 2017

sid0 added a comment to D153: test-dirstate-race: hide irrelevant hg status output.

(I think this should go into stable as a "test fix")

Jul 19 2017, 11:38 PM
sid0 created D153: test-dirstate-race: hide irrelevant hg status output.
Jul 19 2017, 11:33 PM

Jun 30 2017

sid0 committed rHG126eae7dae74: bundle2: add debug info about the number of stream params.
bundle2: add debug info about the number of stream params
Jun 30 2017, 8:32 PM
sid0 committed rHG0aae80d14fed: bundle2: add some debugging information to the not-a-bundle error.
bundle2: add some debugging information to the not-a-bundle error
Jun 30 2017, 8:32 PM