Page MenuHomePhabricator

simonfar (Simon Farnsworth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 2:42 PM (221 w, 2 d)

Recent Activity

Nov 28 2017

simonfar accepted D1530: perftweaks: access inner map for dirstate types other than treedirstate.
Nov 28 2017, 12:05 PM

Nov 27 2017

simonfar accepted D1485: treemanifest: automatically backfill missing manifests during hg pull.
Nov 27 2017, 11:50 AM

Nov 19 2017

simonfar added inline comments to D1400: treedirstate: add Dirstate.
Nov 19 2017, 3:44 PM

Sep 25 2017

simonfar updated subscribers of D813: builddeb: remove leading "hg_" to make the Debian pkg version number valid.

Internally, we don't have versioned releases - we build frequently (automation), and tend to take @ of upstream hg and our extensions when we build. There has been discussion internally (@quark should recall it) about doing a "release" whenever there's a matching Mercurial release coming out, so that people trying to use upstream Mercurial releases can use the nearest tested extensions from us.

Sep 25 2017, 3:44 PM

Sep 15 2017

simonfar accepted D712: remotefilelog: create delay for background prefetches.

Accepting because Mihails is near end of internship - I can do follow-up diffs if there's something missing.

Sep 15 2017, 9:14 AM

Sep 12 2017

simonfar accepted D689: fbconduit: properly pass through params on local hit.
Sep 12 2017, 10:46 AM

Sep 11 2017

simonfar accepted D681: cstore: py-datapackstore build bug fix.

Confirmed verbally that this was compiled on both macOS and CentOS.

Sep 11 2017, 2:13 PM
simonfar accepted D631: cstore: uniondatapackstore support for python stores.
Sep 11 2017, 11:25 AM
simonfar accepted D676: infinitepush: don't use only() to compute not-backed-up revs.
Sep 11 2017, 9:21 AM
simonfar added inline comments to D631: cstore: uniondatapackstore support for python stores.
Sep 11 2017, 8:39 AM

Sep 6 2017

simonfar closed D619: tests: use python instead of echo -e by committing rFBHGX3216f5c73f0c: tests: use python instead of echo -e.
Sep 6 2017, 9:54 PM
simonfar committed rFBHGX3216f5c73f0c: tests: use python instead of echo -e.
tests: use python instead of echo -e
Sep 6 2017, 9:54 PM

Sep 4 2017

simonfar created D619: tests: use python instead of echo -e.
Sep 4 2017, 8:22 AM

Aug 31 2017

simonfar accepted D568: treemanifest: fix non-tree repos when treemanifest is loaded.
Aug 31 2017, 1:22 PM
simonfar accepted D575: tree: don't download flat manifests when cloning in tree only mode.
Aug 31 2017, 7:33 AM
simonfar accepted D571: tree: adds test for pushing a treeonly manifest to a hybrid server.
Aug 31 2017, 7:33 AM
simonfar accepted D570: tests: remove orig file from a commit.
Aug 31 2017, 7:31 AM
simonfar added inline comments to D568: treemanifest: fix non-tree repos when treemanifest is loaded.
Aug 31 2017, 7:27 AM

Aug 24 2017

simonfar added inline comments to D477: revlog: add option to mmap revlog index.
Aug 24 2017, 10:26 AM

Aug 23 2017

simonfar requested changes to D489: RFC cstore: gerenic uniondatapackstore.

To push it back into your queue

Aug 23 2017, 9:21 AM
simonfar added inline comments to D476: util: add an mmapread method.
Aug 23 2017, 9:07 AM
simonfar added inline comments to D477: revlog: add option to mmap revlog index.
Aug 23 2017, 9:06 AM

Aug 18 2017

simonfar accepted D428: fbamend: precnode -> prednode.

LGTM

Aug 18 2017, 5:40 AM

Aug 17 2017

simonfar accepted D427: undo: precnode -> prednode.
Aug 17 2017, 3:20 PM
simonfar accepted D432: undo: allprecursors -> allpredecessors.
Aug 17 2017, 3:20 PM
simonfar accepted D428: fbamend: precnode -> prednode.
Aug 17 2017, 3:19 PM
simonfar accepted D429: fbamend: precursor -> predecessor.

Just nits, some of them probably old.

Aug 17 2017, 3:19 PM
simonfar accepted D431: phabstatus: allprecursors -> allpredecessors.

I've just noticed the typo in the title - can you fix all the titles before landing?

Aug 17 2017, 3:16 PM
simonfar accepted D430: fbamend: allprecursors -> allpredecessors.
Aug 17 2017, 3:15 PM
simonfar accepted D433: dirsync: update tests for upstream behavior change.
Aug 17 2017, 3:15 PM
simonfar accepted D436: perftweaks: don't crash if the rebase dest is None.
Aug 17 2017, 3:14 PM

Aug 16 2017

simonfar closed D349: tweakdefaults: do not change the date when using amend --to by committing rFBHGX59a820ec5f7d: tweakdefaults: do not change the date when using amend --to.
Aug 16 2017, 11:18 AM
simonfar committed rFBHGX59a820ec5f7d: tweakdefaults: do not change the date when using amend --to.
tweakdefaults: do not change the date when using amend --to
Aug 16 2017, 11:18 AM

Aug 15 2017

simonfar accepted D387: test: do not ignore test-check sanity check.
Aug 15 2017, 10:24 AM

Aug 11 2017

simonfar created D349: tweakdefaults: do not change the date when using amend --to.
Aug 11 2017, 12:32 PM

Jul 30 2017

simonfar accepted D197: sparse: also apply relative-path logic to --delete.
Jul 30 2017, 7:26 AM

Jul 28 2017

simonfar closed D183: githelp: don't crash when user does githelp -- git by committing rFBHGX93252c90e7d7: githelp: don't crash when user does githelp -- git.
Jul 28 2017, 9:29 AM
simonfar closed D180: contrib: add git-sl emulation of hg smartlog by committing rFBHGXba70497b5340: contrib: add git-sl emulation of hg smartlog.
Jul 28 2017, 9:29 AM
simonfar committed rFBHGXba70497b5340: contrib: add git-sl emulation of hg smartlog.
contrib: add git-sl emulation of hg smartlog
Jul 28 2017, 9:29 AM
simonfar committed rFBHGX93252c90e7d7: githelp: don't crash when user does githelp -- git.
githelp: don't crash when user does githelp -- git
Jul 28 2017, 9:29 AM
simonfar accepted D194: sparse: make path absoluteness checks cross-platform.
Jul 28 2017, 9:18 AM
simonfar requested changes to D194: sparse: make path absoluteness checks cross-platform.
Jul 28 2017, 8:19 AM
simonfar accepted D193: fastlog: show all hg log output even if fastlog request failed.

Nice fix and comment!

Jul 28 2017, 6:51 AM

Jul 27 2017

simonfar added a comment to D180: contrib: add git-sl emulation of hg smartlog.

I fixed the complaints from test-check-code - they looked like good complaints to fix (readability issues). It's just test-check-commit that fails, for not being hg coding style.

Jul 27 2017, 5:33 AM

Jul 26 2017

simonfar created D183: githelp: don't crash when user does githelp -- git.
Jul 26 2017, 11:18 AM

Jul 24 2017

simonfar added a comment to D180: contrib: add git-sl emulation of hg smartlog.

It complains about the code style not matching Mercurial code style. As this is never going to be part of Mercurial, I'm not keen on spending time fixing coding style.

Jul 24 2017, 10:52 AM
simonfar requested changes to D154: configwarn: new extension to warn about unsupported configs.

Back to you for a reply

Jul 24 2017, 10:46 AM
simonfar created D180: contrib: add git-sl emulation of hg smartlog.
Jul 24 2017, 9:02 AM

Jul 21 2017

simonfar accepted D170: remotefilelog: handle truncated server cache files.
Jul 21 2017, 10:33 AM

Jul 19 2017

simonfar committed rFBHGX999b5e2147d9: contrib: add git-sl emulation of hg smartlog.
contrib: add git-sl emulation of hg smartlog
Jul 19 2017, 10:09 AM
simonfar accepted D144: git-sl: back out changeset 999b5e2147d9.

I'll need to redo this with a blacklist entry for the test.

Jul 19 2017, 10:02 AM
simonfar accepted D145: drop: fix check-code failures.
Jul 19 2017, 10:01 AM

Jul 18 2017

simonfar added a comment to D119: color: add autoterminfo option to prefer terminfo over ansi for non-windows.

Looks good to me, though.

Jul 18 2017, 11:56 AM

Jul 17 2017

simonfar accepted D103: tweakdefaults: take wlock when changing bookmarks.

The change has now appeared. Accepting.

Jul 17 2017, 6:36 AM
simonfar added inline comments to D104: infinitepush: put metadata fill in wlock.
Jul 17 2017, 6:34 AM
simonfar requested changes to D103: tweakdefaults: take wlock when changing bookmarks.

Something weird here - Phabricator says you've not changed anything.

Jul 17 2017, 6:32 AM
simonfar accepted D100: mergedriver: move state writing into wlock.
Jul 17 2017, 6:31 AM
simonfar accepted D102: cleanobsstore: fix devel-warning.
Jul 17 2017, 6:30 AM
simonfar accepted D101: tests: fix test devel-warning.
Jul 17 2017, 6:27 AM