Page MenuHomePhabricator

simpkins (Adam Simpkins)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 9:12 PM (123 w, 6 d)

Recent Activity

Nov 29 2017

simpkins closed D1541: treemanifest: fail gracefully in prefetch if no remote is configured.
Nov 29 2017, 10:09 PM
simpkins closed D1421: treemanifest: expose prefetchtrees() publicly.
Nov 29 2017, 10:09 PM
simpkins closed D1496: pushrebase: report details about public commits being pushed.
Nov 29 2017, 10:09 PM
simpkins committed rFBHGXc270ea1bc98f: treemanifest: fail gracefully in prefetch if no remote is configured.
treemanifest: fail gracefully in prefetch if no remote is configured
Nov 29 2017, 10:09 PM
simpkins committed rFBHGX6f34fada90d4: treemanifest: expose prefetchtrees() publicly.
treemanifest: expose prefetchtrees() publicly
Nov 29 2017, 10:09 PM
simpkins committed rFBHGX7a3b2b673eda: pushrebase: report details about public commits being pushed.
pushrebase: report details about public commits being pushed
Nov 29 2017, 10:09 PM

Nov 28 2017

simpkins created D1541: treemanifest: fail gracefully in prefetch if no remote is configured.
Nov 28 2017, 11:34 PM
simpkins updated the diff for D1421: treemanifest: expose prefetchtrees() publicly.

Rebase and resolve conflicts with @singhsrb's changes

Nov 28 2017, 11:07 PM

Nov 27 2017

simpkins accepted D1522: githelp: update suggestion for apply.

Thanks!

Nov 27 2017, 2:35 PM
simpkins committed rFBHGX0bfd5874c806: perftweaks: unbreak the branchcache code.
perftweaks: unbreak the branchcache code
Nov 27 2017, 7:02 AM
simpkins closed D1495: perftweaks: unbreak the branchcache code.
Nov 27 2017, 7:02 AM

Nov 23 2017

simpkins created D1496: pushrebase: report details about public commits being pushed.
Nov 23 2017, 3:39 AM
simpkins added a comment to D1495: perftweaks: unbreak the branchcache code.

No, I don't think this is related to the pushrebase failure. However, it causes pretty much any hg command in my repository to fail after running "hg pull" or "hg rebase" (maybe any command that creates a new tip?)

Nov 23 2017, 1:29 AM
simpkins created D1495: perftweaks: unbreak the branchcache code.
Nov 23 2017, 12:56 AM

Nov 14 2017

simpkins created D1421: treemanifest: expose prefetchtrees() publicly.
Nov 14 2017, 10:27 PM

Oct 16 2017

simpkins committed rFBHGX420517cb58ca: phrevset: fix code that was returning commit strings.
phrevset: fix code that was returning commit strings
Oct 16 2017, 6:26 PM
simpkins closed D684: phrevset: fix code that was returning commit strings.
Oct 16 2017, 6:26 PM

Oct 13 2017

simpkins closed D1023: sparse: don't crash in non-sparse repositories.
Oct 13 2017, 2:49 AM
simpkins committed rFBHGX01acc01a2120: sparse: don't crash in non-sparse repositories.
sparse: don't crash in non-sparse repositories
Oct 13 2017, 2:49 AM
simpkins closed D1022: sparse: add a test where sparse gets loaded in an non-sparse repository.
Oct 13 2017, 2:49 AM
simpkins committed rFBHGX60a9c2d3456f: sparse: add a test where sparse gets loaded in an non-sparse repository.
sparse: add a test where sparse gets loaded in an non-sparse repository
Oct 13 2017, 2:49 AM

Oct 11 2017

simpkins created D1023: sparse: don't crash in non-sparse repositories.
Oct 11 2017, 9:21 PM
simpkins created D1022: sparse: add a test where sparse gets loaded in an non-sparse repository.
Oct 11 2017, 9:21 PM

Oct 6 2017

simpkins added inline comments to D943: chg: move only first time relevant if condition out of loop.
Oct 6 2017, 2:20 PM

Oct 1 2017

simpkins accepted D883: deb: build and install chg.
Oct 1 2017, 9:59 AM
simpkins accepted D882: deb: install zsh completions to /usr/share/zsh/vendor-completions.
Oct 1 2017, 9:58 AM
simpkins accepted D874: hghave: check for debuild being installed as well.
Oct 1 2017, 7:55 AM
simpkins accepted D875: hgweb: use parsebool for parsing diff query string options.
Oct 1 2017, 7:51 AM
simpkins accepted D864: commands: rename clone --uncompressed to --stream and document.

The code and test changes seem fine to me. I don't have context around the argument naming discussion, but it seems reasonable.

Oct 1 2017, 6:49 AM
simpkins accepted D863: commands: remove suggestion to clone via `cp -al`.

killitwithfire

Oct 1 2017, 6:42 AM
simpkins accepted D850: hgweb: add HTML elements to control whitespace settings for annotate.

Looks fine to me, but I'm no HTML/JS expert.
dogscience

Oct 1 2017, 6:40 AM
simpkins created Image Macro "dogscience".
Oct 1 2017, 6:39 AM
simpkins accepted D848: tests: add tests for hgweb annotate output.
Oct 1 2017, 6:25 AM
simpkins accepted D849: hgweb: query string arguments to control whitespace for annotate.

Looks good to me apart from one minor question.

Oct 1 2017, 6:22 AM

Sep 11 2017

simpkins created D684: phrevset: fix code that was returning commit strings.
Sep 11 2017, 6:16 PM

Aug 29 2017

simpkins added inline comments to D559: cdatapack: move feature macros before including cdatapack.h.
Aug 29 2017, 3:49 PM
simpkins closed D507: clib: update C/C++ copyright statements to pass lint checks by committing rFBHGXee475be30487: clib: update C/C++ copyright statements to pass lint checks.
Aug 29 2017, 12:05 PM
simpkins closed D505: clib: simplify include paths in C extensions by committing rFBHGXcd6a0869efe8: clib: simplify include paths in C extensions.
Aug 29 2017, 12:04 PM
simpkins closed D508: clib: clean up include guards in the C/C++ header files by committing rFBHGX959ee56f6b6f: clib: clean up include guards in the C/C++ header files.
Aug 29 2017, 12:04 PM
simpkins committed rFBHGX1212fe1b468a: clib: apply clang-tidy fixes to C/C++ code.
clib: apply clang-tidy fixes to C/C++ code
Aug 29 2017, 12:03 PM
simpkins closed D509: clib: apply clang-tidy fixes to C/C++ code by committing rFBHGX1212fe1b468a: clib: apply clang-tidy fixes to C/C++ code.
Aug 29 2017, 12:03 PM
simpkins committed rFBHGX959ee56f6b6f: clib: clean up include guards in the C/C++ header files.
clib: clean up include guards in the C/C++ header files
Aug 29 2017, 12:02 PM
simpkins closed D506: ctreemanifest: move ManifestPtr to its own header file by committing rFBHGX99ee66aae19b: ctreemanifest: move ManifestPtr to its own header file.
Aug 29 2017, 12:02 PM
simpkins committed rFBHGXee475be30487: clib: update C/C++ copyright statements to pass lint checks.
clib: update C/C++ copyright statements to pass lint checks
Aug 29 2017, 12:01 PM
simpkins committed rFBHGX99ee66aae19b: ctreemanifest: move ManifestPtr to its own header file.
ctreemanifest: move ManifestPtr to its own header file
Aug 29 2017, 12:01 PM
simpkins committed rFBHGXcd6a0869efe8: clib: simplify include paths in C extensions.
clib: simplify include paths in C extensions
Aug 29 2017, 12:00 PM

Aug 24 2017

simpkins created D507: clib: update C/C++ copyright statements to pass lint checks.
Aug 24 2017, 4:43 PM
simpkins created D505: clib: simplify include paths in C extensions.
Aug 24 2017, 4:42 PM
simpkins created D508: clib: clean up include guards in the C/C++ header files.
Aug 24 2017, 4:42 PM
simpkins created D509: clib: apply clang-tidy fixes to C/C++ code.
Aug 24 2017, 4:41 PM
simpkins created D506: ctreemanifest: move ManifestPtr to its own header file.
Aug 24 2017, 4:40 PM

Aug 23 2017

simpkins abandoned D72: httpclient: honor the timeout when setting up the connection.
Aug 23 2017, 5:38 PM

Aug 22 2017

simpkins closed D282: sha1: provide wrapper functions around the SHA-1 implementation by committing rFBHGXaac32a02272f: sha1: provide wrapper functions around the SHA-1 implementation.
Aug 22 2017, 10:21 PM
simpkins closed D283: sha1: update to the stable-v1.0.3 release of sha1collisiondetection by committing rFBHGXd4620a00a087: sha1: update to the stable-v1.0.3 release of sha1collisiondetection.
Aug 22 2017, 10:21 PM
simpkins closed D285: sha1: allow selecting SHA-1 library at build time by committing rFBHGX5eca64d9cba7: sha1: allow selecting SHA-1 library at build time.
Aug 22 2017, 10:21 PM
simpkins committed rFBHGX5eca64d9cba7: sha1: allow selecting SHA-1 library at build time.
sha1: allow selecting SHA-1 library at build time
Aug 22 2017, 10:21 PM
simpkins committed rFBHGX2122226e17b4: sha1: use the real SHA-1 algorithm.
sha1: use the real SHA-1 algorithm
Aug 22 2017, 10:21 PM
simpkins closed D281: sha1: move the sha1collisiondetection code to third-party by committing rFBHGX55ca6f654b07: sha1: move the sha1collisiondetection code to third-party.
Aug 22 2017, 10:21 PM
simpkins closed D284: sha1: use the real SHA-1 algorithm by committing rFBHGX2122226e17b4: sha1: use the real SHA-1 algorithm.
Aug 22 2017, 10:21 PM
simpkins committed rFBHGXd4620a00a087: sha1: update to the stable-v1.0.3 release of sha1collisiondetection.
sha1: update to the stable-v1.0.3 release of sha1collisiondetection
Aug 22 2017, 10:21 PM
simpkins committed rFBHGXaac32a02272f: sha1: provide wrapper functions around the SHA-1 implementation.
sha1: provide wrapper functions around the SHA-1 implementation
Aug 22 2017, 10:21 PM
simpkins committed rFBHGX6a145b3543e6: build: check in a clang-format file.
build: check in a clang-format file
Aug 22 2017, 10:21 PM
simpkins committed rFBHGX55ca6f654b07: sha1: move the sha1collisiondetection code to third-party.
sha1: move the sha1collisiondetection code to third-party
Aug 22 2017, 10:21 PM
simpkins closed D280: build: check in a clang-format file by committing rFBHGX6a145b3543e6: build: check in a clang-format file.
Aug 22 2017, 10:21 PM

Aug 17 2017

simpkins accepted D429: fbamend: precursor -> predecessor.
Aug 17 2017, 6:46 PM

Aug 16 2017

simpkins accepted D420: remotefilelog: limit number of changesets to be prefetched.

_like_

Aug 16 2017, 4:17 PM
simpkins accepted D418: absorb: preserve phase.
Aug 16 2017, 4:15 PM
simpkins added a comment to D420: remotefilelog: limit number of changesets to be prefetched.

The main change looks good, but I have some comments about the test updates.

Aug 16 2017, 2:15 PM
simpkins closed D398: remotefilelog: open pack files with O_CLOEXEC by committing rFBHGX6ee35c7861c0: remotefilelog: open pack files with O_CLOEXEC.
Aug 16 2017, 11:18 AM
simpkins committed rFBHGX6ee35c7861c0: remotefilelog: open pack files with O_CLOEXEC.
remotefilelog: open pack files with O_CLOEXEC
Aug 16 2017, 11:18 AM
simpkins committed rFBHGX6816754eb0f8: arc: fix performance of "arc unit" with vanilla arcanist.
arc: fix performance of "arc unit" with vanilla arcanist
Aug 16 2017, 11:18 AM
simpkins closed D397: arc: fix performance of "arc unit" with vanilla arcanist by committing rFBHGX6816754eb0f8: arc: fix performance of "arc unit" with vanilla arcanist.
Aug 16 2017, 11:18 AM
simpkins closed D386: traceprof: report profile data even on error by committing rFBHGX9aca0dbdbdfc: traceprof: report profile data even on error.
Aug 16 2017, 11:17 AM
simpkins committed rFBHGX9aca0dbdbdfc: traceprof: report profile data even on error.
traceprof: report profile data even on error
Aug 16 2017, 11:17 AM

Aug 14 2017

simpkins created D398: remotefilelog: open pack files with O_CLOEXEC.
Aug 14 2017, 10:55 PM
simpkins created D397: arc: fix performance of "arc unit" with vanilla arcanist.
Aug 14 2017, 10:48 PM
simpkins created D386: traceprof: report profile data even on error.
Aug 14 2017, 2:57 PM

Aug 8 2017

simpkins created D282: sha1: provide wrapper functions around the SHA-1 implementation.
Aug 8 2017, 4:21 PM
simpkins created D283: sha1: update to the stable-v1.0.3 release of sha1collisiondetection.
Aug 8 2017, 4:21 PM
simpkins created D281: sha1: move the sha1collisiondetection code to third-party.
Aug 8 2017, 4:21 PM
simpkins created D285: sha1: allow selecting SHA-1 library at build time.
Aug 8 2017, 4:21 PM
simpkins created D284: sha1: use the real SHA-1 algorithm.
Aug 8 2017, 4:20 PM
simpkins created D280: build: check in a clang-format file.
Aug 8 2017, 4:17 PM

Jul 24 2017

simpkins accepted D171: phabricator: include the suggested arc config in the repo.

This looks good to me too.

Jul 24 2017, 9:42 PM

Jul 21 2017

simpkins closed D162: upgradegeneraldelta: update to work with upstream revlog changes by committing rFBHGX407c83f671b2: upgradegeneraldelta: update to work with upstream revlog changes.
Jul 21 2017, 11:10 AM
simpkins committed rFBHGX407c83f671b2: upgradegeneraldelta: update to work with upstream revlog changes.
upgradegeneraldelta: update to work with upstream revlog changes
Jul 21 2017, 11:10 AM

Jul 20 2017

simpkins created D162: upgradegeneraldelta: update to work with upstream revlog changes.
Jul 20 2017, 10:15 PM
simpkins accepted D161: split: check unfinished first.
Jul 20 2017, 9:19 PM

Jul 19 2017

simpkins closed D80: phabstatus: query conduit more efficiently for "hg log" by committing rFBHGX9c846cbfe7d5: phabstatus: query conduit more efficiently for "hg log".
Jul 19 2017, 10:23 PM
simpkins committed rFBHGX9c846cbfe7d5: phabstatus: query conduit more efficiently for "hg log".
phabstatus: query conduit more efficiently for "hg log"
Jul 19 2017, 10:22 PM
simpkins committed rFBHGXb2de23e301d2: phabstatus: clean up showsyncstatus().
phabstatus: clean up showsyncstatus()
Jul 19 2017, 10:22 PM
simpkins closed D79: phabstatus: clean up showsyncstatus() by committing rFBHGXb2de23e301d2: phabstatus: clean up showsyncstatus().
Jul 19 2017, 10:22 PM

Jul 14 2017

simpkins closed D68: dirstate: update backup functions to take full backup filename by committing rHGec306bc6915b: dirstate: update backup functions to take full backup filename.
Jul 14 2017, 1:25 PM
simpkins committed rHGec306bc6915b: dirstate: update backup functions to take full backup filename.
dirstate: update backup functions to take full backup filename
Jul 14 2017, 1:24 PM

Jul 13 2017

simpkins abandoned D69: tests: put temporary files in $TESTTMP.

D67 has landed in hgcommitted, so this isn't really necessary any more.

Jul 13 2017, 10:40 PM
simpkins created D80: phabstatus: query conduit more efficiently for "hg log".
Jul 13 2017, 10:32 PM
simpkins created D79: phabstatus: clean up showsyncstatus().
Jul 13 2017, 10:29 PM
simpkins accepted D75: treemanifest: allow using manifest nodes as base nodes during pack fetch.
Jul 13 2017, 6:58 PM
simpkins closed D71: tests: fix 'if False' statements flagged by check-code by committing rFBHGX6e4a284f4755: tests: fix 'if False' statements flagged by check-code.
Jul 13 2017, 3:56 PM
simpkins committed rFBHGX6e4a284f4755: tests: fix 'if False' statements flagged by check-code.
tests: fix 'if False' statements flagged by check-code
Jul 13 2017, 3:56 PM