smf (Sean Farley)
User

Projects

User Details

User Since
Jun 28 2017, 8:00 PM (59 w, 1 d)

Recent Activity

Jul 10 2018

smf committed rHG5957fdd1d5f0: contrib: add heads(commonancestors(_)) to all-revsets.
contrib: add heads(commonancestors(_)) to all-revsets
Jul 10 2018, 9:07 AM
smf committed rHG52f19a840543: revset: add optimization for heads(commonancestors()).
revset: add optimization for heads(commonancestors())
Jul 10 2018, 9:07 AM
smf committed rHG5460926352ee: revsets: add commonancestors revset.
revsets: add commonancestors revset
Jul 10 2018, 9:07 AM
smf committed rHGa2ce6e1c87f7: contrib: add heads(commonancestors(_)) to all-revsets.
contrib: add heads(commonancestors(_)) to all-revsets
Jul 10 2018, 8:42 AM
smf committed rHG4dd0edecbcf1: revsets: add commonancestors revset.
revsets: add commonancestors revset
Jul 10 2018, 8:42 AM
smf committed rHG0a9af5ab051d: revset: add optimization for heads(commonancestors()).
revset: add optimization for heads(commonancestors())
Jul 10 2018, 8:42 AM

Jun 16 2018

smf added a comment to D3665: graph: improve graph output by using Unicode characters.
In D3665#58976, @smf wrote:

Thanks for the assist, @smf ! I appreciate it.

Sure, no problem :-)

By the way, here's the diff of what I changed:

diff --git a/hgext/beautifygraph.py b/hgext/beautifygraph.py
index 7ff3c08..254d2cc 100644
--- a/hgext/beautifygraph.py
+++ b/hgext/beautifygraph.py
@@ -4,23 +4,23 @@
 # Copyright 2018 John Stiles <johnstiles@gmail.com>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
-'''This extension beautifies log -G output by using Unicode characters.
+'''beautify log -G output by using Unicode characters (EXPERIMENTAL)
Jun 16 2018, 9:18 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

Thanks for the assist, @smf ! I appreciate it.

Jun 16 2018, 9:07 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

Greg and Jun,

Jun 16 2018, 7:31 PM

Jun 15 2018

smf added a comment to D3665: graph: improve graph output by using Unicode characters.

Could you send me the output of hg export REV | head or do you just want me to add your name and not worry about the date/time, etc.?

Jun 15 2018, 6:33 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

johnstiles (John Stiles) <phabricator@mercurial-scm.org> writes:

Jun 15 2018, 6:12 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

I've looked this over today and have queued this up :-) Unfortunately, though, the metadata doesn't seem right? I'm not getting your name or email (nor timestamp) for the patch. Do you want me to use the same name from 24e517600b29 (John Stiles <johnstiles@gmail.com>)?

Jun 15 2018, 5:50 PM
smf added a comment to D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API).

martinvonz (Martin von Zweigbergk) <phabricator@mercurial-scm.org> writes:

Jun 15 2018, 3:19 AM
smf added a comment to D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API).

martinvonz (Martin von Zweigbergk) <phabricator@mercurial-scm.org> writes:

Jun 15 2018, 2:16 AM
smf added a comment to D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API).

It seems I'm having email sending trouble ... going to attempt to send again

Jun 15 2018, 2:16 AM

Jun 14 2018

smf added a comment to D3665: graph: improve graph output by using Unicode characters.

johnstiles (John Stiles) <phabricator@mercurial-scm.org> writes:

Jun 14 2018, 8:58 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

johnstiles (John Stiles) <phabricator@mercurial-scm.org> writes:

Jun 14 2018, 8:49 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

johnstiles (John Stiles) <phabricator@mercurial-scm.org> writes:

Jun 14 2018, 8:48 PM
smf added a comment to D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API).

Sean Farley <sean@farley.io> writes:

Jun 14 2018, 8:34 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

spectral (Kyle Lippincott) <phabricator@mercurial-scm.org> writes:

Jun 14 2018, 7:23 PM
smf added a comment to D3684: shelve: merge in obsshelve changes implemented at facebook.

durin42 (Augie Fackler) <phabricator@mercurial-scm.org> writes:

Jun 14 2018, 7:03 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

johnstiles (John Stiles) <phabricator@mercurial-scm.org> writes:

Jun 14 2018, 7:02 PM

Jun 12 2018

smf added a comment to D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API).

durin42 (Augie Fackler) <phabricator@mercurial-scm.org> writes:

Jun 12 2018, 8:48 PM

May 29 2018

smf added a comment to D3665: graph: improve graph output by using Unicode characters.

johnstiles (John Stiles) <phabricator@mercurial-scm.org> writes:

May 29 2018, 10:47 PM
smf added a comment to D3665: graph: improve graph output by using Unicode characters.

johnstiles (John Stiles) <phabricator@mercurial-scm.org> writes:

May 29 2018, 10:17 PM

Apr 11 2018

smf added a comment to D2873: remotenames: add functionality to override -B flag of push.
In D2873#52025, @smf wrote:

Looks good!

I'm very heavily against this direction. Changing the behavior of push (even in this extension) is something I've always considered outside the scope of remotenames. Having another extension that changes push behavior (e.g. bookmark-push) is where I think this should go so that remotenames is just that: keeping track of remote names.

I think there's room for this feature to live outside of remotenames. But currently I think it is the best place for it, since remotenames is the closest thing we have to... tracking remote names. We can always alias the old config option in the future if we move this functionality elsewhere.

Apr 11 2018, 5:39 PM
smf added a comment to D2873: remotenames: add functionality to override -B flag of push.

Looks good!

Apr 11 2018, 1:32 PM

Feb 20 2018

smf added a comment to D2277: remotenames: don't use the default value of logfmt for namespaces.

pulkit (Pulkit Goyal) <phabricator@mercurial-scm.org> writes:

Feb 20 2018, 6:45 PM
smf added a comment to D1756: remotenames: introduce class to encapsulate remotenames info in an extension.

martinvonz (Martin von Zweigbergk) <phabricator@mercurial-scm.org> writes:

Feb 20 2018, 5:45 PM

Dec 11 2017

smf added a comment to D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase.

durin42 (Augie Fackler) <phabricator@mercurial-scm.org> writes:

Dec 11 2017, 7:24 PM
smf added a comment to D1232: rebase: add the --inmemory option flag; assign a wctx object for the rebase.

dlax (Denis Laxalde) <phabricator@mercurial-scm.org> writes:

Dec 11 2017, 6:59 PM

Dec 8 2017

smf added a comment to D1607: remotenames: rename related file and storage dir to logexchange.

pulkit (Pulkit Goyal) <phabricator@mercurial-scm.org> writes:

Dec 8 2017, 3:08 AM
smf added a comment to D1551: remotenames: consider existing data while storing newer data.

durin42 (Augie Fackler) <phabricator@mercurial-scm.org> writes:

Dec 8 2017, 3:02 AM

Dec 6 2017

smf added a comment to D1551: remotenames: consider existing data while storing newer data.

durin42 (Augie Fackler) <phabricator@mercurial-scm.org> writes:

Dec 6 2017, 1:36 PM

Nov 16 2017

smf added a comment to D1358: remotenames: store journal entry for bookmarks if journal is loaded.

pulkit (Pulkit Goyal) <phabricator@mercurial-scm.org> writes:

Nov 16 2017, 7:57 PM
smf added a comment to D1358: remotenames: store journal entry for bookmarks if journal is loaded.

pulkit (Pulkit Goyal) <phabricator@mercurial-scm.org> writes:

Nov 16 2017, 2:30 PM

Nov 14 2017

smf added a comment to D1358: remotenames: store journal entry for bookmarks if journal is loaded.

durin42 (Augie Fackler) <phabricator@mercurial-scm.org> writes:

Nov 14 2017, 6:20 PM

Nov 13 2017

smf added a comment to D1358: remotenames: store journal entry for bookmarks if journal is loaded.

pulkit (Pulkit Goyal) <phabricator@mercurial-scm.org> writes:

Nov 13 2017, 2:18 PM

Nov 1 2017

smf added a comment to D937: remotenames: move function to pull remotenames from the remoterepo to core.

pulkit (Pulkit Goyal) <phabricator@mercurial-scm.org> writes:

Nov 1 2017, 3:29 PM

Sep 12 2017

smf added a comment to D612: command: add a cmdtype argument to registrar.command.

Has there been discussion around extensions using this? Should there be discussion now? Specifically, I'm trying to figure out how external things will use this feature. Should it be a try/except? Or should modules set the access level before looking for a (potentially) hidden commit?

Sep 12 2017, 5:33 PM

Aug 28 2017

smf added inline comments to D464: editor: use an unambiguous path suffix for editor files.
Aug 28 2017, 6:00 PM

Aug 23 2017

smf added a comment to D464: editor: use an unambiguous path suffix for editor files.

Everything I was talking about in D468 was meant to be posted here. (I am not doing well with phabricator it seems)

Aug 23 2017, 5:07 PM
smf added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
In D468#7920, @mbolin wrote:

@smf so are you OK with this patch as-is?

Aug 23 2017, 4:59 PM
smf added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
In D468#7915, @mbolin wrote:

@smf Personally, I think that D464 is a better place to have that discussion.

Aug 23 2017, 4:54 PM
smf added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
In D468#7916, @durin42 wrote:
In D468#7914, @smf wrote:

Basically, I was pondering aloud if '~' would be enough to future-proof us and if we shouldn't just rename all temp files to something unique (HG_EDITOR for commits, HG_HISTEDIT for histedit, etc). What I was hoping for was a discussion on that.

This sounds like a good idea. However, if I'm understanding @mbolin correctly, we /also/ want a ~ suffix (or similar) so that devtools don't need to grow hg-specific logic for tempfiles (since, in the case of a ~ suffix, we'll be enough like vim that they will already correctly ignore things). Do I have a reasonable handle on this, or is there more nuance that I'm missing?

Aug 23 2017, 4:54 PM
smf added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
In D468#7912, @mbolin wrote:

@smf As I put in the summary, I think this use of tempfile.mkstemp() is different than the others in the codebase because it uses the dir= argument to create a file in the working copy. As such, I'd argue that it's reasonable to consider it separately from the others.

In particular, I think it's independent of how temp files are created for things like commit messages as those are paths that are intended to be exposed to the user insofar as they are opened in the user's editor. As it stands, I have D464 out for review as a first step to impose some order on path names for those types of files.

As far as this change is concerned, the focus is to preserve the existing behavior of mktempcopy() while minimizing its impact on other developer tools.

Aug 23 2017, 4:52 PM
smf added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
In D468#7910, @smf wrote:

That seems a bit over complicated to me. Why not just just use the
random tmp as a directory instead of a file while renaming the file at
the same time:

/tmp/XYZ123/hg-editor (or HG_EDITOR or whatever)

This would allow 'editortmpinhg'[1] to just be .hg/hg-editor (or
HG_EDITOR etc). The '~' seems a bit like a quick hack and I think I'd
prefer to do this cleanly. My logic here is:

  1. if we can append a character to the suffix, then we should be able to change the directory
  2. we might want different 'file types' for different tmp files and '~' seems that it might not get us far enough. For instance: a) editor, b) conflicts c) histedit etc

    For (a) and (c), I hacked something together for my fork of magit (called mahgic) so that I can have different modes for commit (to show the diff) and for histedit (so that 'tab' and 'enter' will show the commit at the point).

    [1] I planned on making editortmpinhg a more thorough thing so that everything would be in the .hg directory so that programs (like emacs) would be able to find the correct repo given only the tmp file.
Aug 23 2017, 4:49 PM
smf added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
In D468#7909, @durin42 wrote:
In D468#7908, @smf wrote:
In D468#7836, @quark wrote:
In D468#7833, @smf wrote:

Basically, I'd like a more unified approach for all types of temp files (commit message, histedit, conflicts, etc).

I think this patch is about low-level util function that shouldn't be coupled with ui or config. It has value on its own and I don't think such "unified approach" should block this patch - we can always add configs and make callers of util.mktempcopy pass suffix down here AFTER this patch.

Um, what? That's the whole point of review. Yes, I know you think you can do this AFTER (why are we yelling?). I don't like this patch as-is and am frankly tired of trying to jam stuff through review and promise to clean up later. I am against this patch.

As a bystander here, I'm not even sure what the proposals are. Can one of you summarize what the competing ideas are?

(In general I agree with smf that a more unified error-resistant API should be a goal, and I'm -0 on adding complexity to hg in the name of buck performance if there's a better proposal on the table (but if there is I've missed it.))

Aug 23 2017, 4:45 PM
smf added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
In D468#7836, @quark wrote:
In D468#7833, @smf wrote:

Basically, I'd like a more unified approach for all types of temp files (commit message, histedit, conflicts, etc).

I think this patch is about low-level util function that shouldn't be coupled with ui or config. It has value on its own and I don't think such "unified approach" should block this patch - we can always add configs and make callers of util.mktempcopy pass suffix down here AFTER this patch.

Aug 23 2017, 4:37 PM
smf added a comment to D468: util: use ~ as a suffix for a temp file in the same directory as a source file.
In D468#7748, @durin42 wrote:

I don't object to this, but maybe others do. Reviewers not on vacation, please feel encouraged to push this.

Aug 23 2017, 2:33 PM

Aug 22 2017

smf committed rHGaf20468eb0a4: merge with stable.
merge with stable
Aug 22 2017, 1:24 AM

Aug 10 2017

smf committed rHGdb83a1df03fe: subrepo: add tests for git rogue ssh urls (SEC).
subrepo: add tests for git rogue ssh urls (SEC)
Aug 10 2017, 6:56 PM
smf committed rHG60ee7af2a2ba: subrepo: add tests for svn rogue ssh urls (SEC).
subrepo: add tests for svn rogue ssh urls (SEC)
Aug 10 2017, 6:56 PM
smf committed rHG475af2f89636: subrepo: add tests for hg rogue ssh urls (SEC).
subrepo: add tests for hg rogue ssh urls (SEC)
Aug 10 2017, 6:56 PM
smf committed rHG48d520fdf880: push: add tests for unsafe ssh url (SEC).
push: add tests for unsafe ssh url (SEC)
Aug 10 2017, 6:56 PM
smf committed rHG0ee42a0df5be: pull: add tests for unsafe ssh url (SEC).
pull: add tests for unsafe ssh url (SEC)
Aug 10 2017, 6:56 PM
smf committed rHG0bcceb58b036: clone: add tests for unsafe ssh url (SEC).
clone: add tests for unsafe ssh url (SEC)
Aug 10 2017, 6:56 PM
smf committed rHGd7a1c4c1181d: sshpeer: check for safe ssh url (SEC).
sshpeer: check for safe ssh url (SEC)
Aug 10 2017, 6:56 PM
smf committed rHG0b3fe3910ef5: util: add utility method to check for bad ssh urls (SEC).
util: add utility method to check for bad ssh urls (SEC)
Aug 10 2017, 6:56 PM
smf committed rHGca398a50ca00: subrepo: add tests for git rogue ssh urls (SEC).
subrepo: add tests for git rogue ssh urls (SEC)
Aug 10 2017, 2:25 PM
smf committed rHG173ecccb9ee7: subrepo: add tests for svn rogue ssh urls (SEC).
subrepo: add tests for svn rogue ssh urls (SEC)
Aug 10 2017, 2:25 PM
smf committed rHG55681baf4cf9: subrepo: add tests for hg rogue ssh urls (SEC).
subrepo: add tests for hg rogue ssh urls (SEC)
Aug 10 2017, 2:25 PM
smf committed rHG08cfc4baf3ba: push: add tests for unsafe ssh url (SEC).
push: add tests for unsafe ssh url (SEC)
Aug 10 2017, 2:25 PM
smf committed rHG92b583e3e522: pull: add tests for unsafe ssh url (SEC).
pull: add tests for unsafe ssh url (SEC)
Aug 10 2017, 2:25 PM
smf committed rHGf93975a5ebe8: sshpeer: check for safe ssh url (SEC).
sshpeer: check for safe ssh url (SEC)
Aug 10 2017, 2:25 PM
smf committed rHGf9134e96ed0f: clone: add tests for unsafe ssh url (SEC).
clone: add tests for unsafe ssh url (SEC)
Aug 10 2017, 2:25 PM
smf committed rHG53224b1ffbc2: util: add utility method to check for bad ssh urls (SEC).
util: add utility method to check for bad ssh urls (SEC)
Aug 10 2017, 2:25 PM

Jul 30 2017

smf committed rHG92f7dcf9a40b: make: add new directory 'hgdemandimport' to cleanbutpackages rule.
make: add new directory 'hgdemandimport' to cleanbutpackages rule
Jul 30 2017, 1:01 AM