Page MenuHomePhabricator

spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (128 w, 1 d)

Recent Activity

Today

spectral updated the diff for D7620: merge: add commands.merge.require-rev to require an argument to hg merge.
Fri, Dec 13, 8:39 PM
spectral added a comment to D7620: merge: add commands.merge.require-rev to require an argument to hg merge.
In D7620#112376, @dlax wrote:

This should be documented in mercurial/helptext/config.txt I think.

Fri, Dec 13, 8:38 PM
spectral added inline comments to D7665: dirstate: when calling rebuild(), avoid some N^2 codepaths.
Fri, Dec 13, 8:27 PM
spectral created D7664: rebase: make rebase not crash if p1 == p2 != nullid.
Fri, Dec 13, 6:58 PM
spectral created D7665: dirstate: when calling rebuild(), avoid some N^2 codepaths.
Fri, Dec 13, 6:58 PM

Yesterday

spectral updated the diff for D7617: fix: make example fix hgrc work in subdirs.
Thu, Dec 12, 7:38 PM
spectral updated the diff for D7618: fix: correct the clang-format example hgrc so that it actually works.
Thu, Dec 12, 7:34 PM
spectral added a comment to D7617: fix: make example fix hgrc work in subdirs.

See D7065 and D7570. I didn't realize you could stack set: and the other patterns like this.

Thu, Dec 12, 7:31 PM
spectral created D7620: merge: add commands.merge.require-rev to require an argument to hg merge.
Thu, Dec 12, 5:50 PM
spectral created D7618: fix: correct the clang-format example hgrc so that it actually works.
Thu, Dec 12, 5:42 PM
spectral created D7619: fix: convert clang-format-ignorelist to use wildcards.
Thu, Dec 12, 5:42 PM
spectral created D7617: fix: make example fix hgrc work in subdirs.
Thu, Dec 12, 5:42 PM
spectral added a comment to D7506: phabricator: add a "phabstatus" show view.
In D7506#111966, @dlax wrote:

I don't think from . import show works generally.

I did that because test-check-module-imports.t complained otherwise when using from hgext import show:

hgext/phabricator.py:89: import should be relative: hgext

Also, there's already a similar from . import rebase in hgext/split.py so I thought that relative import was fine.
I'm happy to change if there's a solution, though.

Thu, Dec 12, 1:19 PM
spectral closed D7550: chg: fix chg to work with py3.7+ "coercing" the locale.
Thu, Dec 12, 9:15 AM
spectral committed rHG5e0f6451e2d2: chg: fix chg to work with py3.7+ "coercing" the locale.
chg: fix chg to work with py3.7+ "coercing" the locale
Thu, Dec 12, 9:15 AM
spectral committed rHG229215fc1c1c: fuzz: fix mpatch_corpus to not have an overridden __repr__ on py3.
fuzz: fix mpatch_corpus to not have an overridden __repr__ on py3
Thu, Dec 12, 7:52 AM
spectral closed D7606: fuzz: fix mpatch_corpus to not have an overridden __repr__ on py3.
Thu, Dec 12, 7:52 AM

Wed, Dec 11

spectral added a comment to D7506: phabricator: add a "phabstatus" show view.

I don't think from . import show works generally. I received errors because I imported phabricator via a path (pointing directly at the .py file, something like [extensions] phabricator = /home/spectral/src/hg/hgext/phabricator.py), not by doing something like extensions.phabricator=. I received the following errors:

Wed, Dec 11, 6:37 PM
spectral created D7606: fuzz: fix mpatch_corpus to not have an overridden __repr__ on py3.
Wed, Dec 11, 6:27 PM
spectral added a comment to D7550: chg: fix chg to work with py3.7+ "coercing" the locale.
In D7550#111235, @yuja wrote:
When the environment is empty (specifically: it doesn't contain LC_ALL,
LC_CTYPE, or LANG), Python will "coerce" the locale environment variables to be
a UTF-8 capable one. It sets LC_CTYPE in the environment, and this breaks chg,
since chg operates by:
- start hg, using whatever environment the user has when chg starts
- hg stores a hash of this "original" environment, but python has already set LC_CTYPE even though the user doesn't have it in their environment
- chg calls setenv over the commandserver. This clears the environment inside of hg and sets it to be exactly what the environment in chg is (without LC_CTYPE).
- chg calls validate to ensure that the environment hg is using (after the setenv call) is the one that the chg process has - if not, it is assumed the user changed their environment and we should use a different server. This will *never* be true in this situation because LC_CTYPE was removed.

Sigh. Can we work around this weird behavior by making chg do
putenv("PYTHONCOERCECLOCALE=0")? I think it's simple and more desired
behavior than the default of Python 3.

Wed, Dec 11, 6:14 PM
spectral closed D7601: fuzz: fix test-fuzz-targets.t to run with python3.
Wed, Dec 11, 6:54 AM
spectral committed rHGba84a1ae4ae5: fuzz: fix test-fuzz-targets.t to run with python3.
fuzz: fix test-fuzz-targets.t to run with python3
Wed, Dec 11, 6:54 AM
spectral closed D7598: py3: fix a bytes vs str issue in remotefilelog extension.
Wed, Dec 11, 6:54 AM
spectral committed rHG94670e124d29: py3: fix a bytes vs str issue in remotefilelog extension.
py3: fix a bytes vs str issue in remotefilelog extension
Wed, Dec 11, 6:54 AM

Tue, Dec 10

spectral created D7601: fuzz: fix test-fuzz-targets.t to run with python3.
Tue, Dec 10, 7:23 PM
spectral created D7598: py3: fix a bytes vs str issue in remotefilelog extension.
Tue, Dec 10, 6:49 PM
spectral accepted D7597: dirs: fix out-of-bounds access in Py3.
Tue, Dec 10, 5:56 PM

Fri, Dec 6

spectral closed D7521: amend: check for file modifications when updating dirstate (issue6233).
Fri, Dec 6, 10:38 AM
spectral closed D7552: tests: fix deprecation warning about regex flags not at beginning of expr.
Fri, Dec 6, 10:38 AM
spectral committed rHGe6cda6efb12a: tests: expect return status 255 on exception for test-blackbox.t with chg.
tests: expect return status 255 on exception for test-blackbox.t with chg
Fri, Dec 6, 10:38 AM
spectral closed D7554: tests: expect return status 255 on exception for test-blackbox.t with chg.
Fri, Dec 6, 10:38 AM
spectral closed D7553: tests: fix command name in test-blackbox.t to be bytes.
Fri, Dec 6, 10:38 AM
spectral committed rHGc6b4c348360e: tests: fix command name in test-blackbox.t to be bytes.
tests: fix command name in test-blackbox.t to be bytes
Fri, Dec 6, 10:37 AM
spectral committed rHG3fe91bcd5199: tests: fix deprecation warning about regex flags not at beginning of expr.
tests: fix deprecation warning about regex flags not at beginning of expr
Fri, Dec 6, 10:37 AM
spectral closed D7551: tests: fix test-chg.t to work with py3 (no setprocname).
Fri, Dec 6, 10:37 AM
spectral committed rHG5558e3437872: amend: check for file modifications when updating dirstate (issue6233).
amend: check for file modifications when updating dirstate (issue6233)
Fri, Dec 6, 10:37 AM
spectral committed rHGfe94af4e3dc9: tests: fix test-chg.t to work with py3 (no setprocname).
tests: fix test-chg.t to work with py3 (no setprocname)
Fri, Dec 6, 10:37 AM
spectral closed D7555: packaging: include defaultrc/*.rc instead of default.d/*.rc.
Fri, Dec 6, 12:14 AM
spectral committed rHGd3f7bdc905fb: packaging: include defaultrc/*.rc instead of default.d/*.rc.
packaging: include defaultrc/*.rc instead of default.d/*.rc
Fri, Dec 6, 12:14 AM

Thu, Dec 5

spectral created D7555: packaging: include defaultrc/*.rc instead of default.d/*.rc.
Thu, Dec 5, 11:07 PM
spectral created D7552: tests: fix deprecation warning about regex flags not at beginning of expr.
Thu, Dec 5, 7:09 PM
spectral created D7554: tests: expect return status 255 on exception for test-blackbox.t with chg.
Thu, Dec 5, 7:09 PM
spectral created D7553: tests: fix command name in test-blackbox.t to be bytes.
Thu, Dec 5, 7:09 PM
spectral created D7551: tests: fix test-chg.t to work with py3 (no setprocname).
Thu, Dec 5, 7:09 PM
spectral created D7550: chg: fix chg to work with py3.7+ "coercing" the locale.
Thu, Dec 5, 6:46 PM

Wed, Dec 4

spectral closed D7545: py3: make a pycompat.osdevnull, use it in extdiff.
Wed, Dec 4, 2:09 PM
spectral closed D7544: subrepo: use pycompat.open directly instead of importing open from pycompat.
Wed, Dec 4, 2:09 PM
spectral committed rHG765a9c299c44: py3: make a pycompat.osdevnull, use it in extdiff.
py3: make a pycompat.osdevnull, use it in extdiff
Wed, Dec 4, 2:09 PM
spectral committed rHGaea70ca7dd85: subrepo: use pycompat.open directly instead of importing open from pycompat.
subrepo: use pycompat.open directly instead of importing open from pycompat
Wed, Dec 4, 2:09 PM
spectral added a comment to D7544: subrepo: use pycompat.open directly instead of importing open from pycompat.

I don't think this is correct, because open is imported from pycompat at the top of the file, and that will sysstr() the mode. But this does seem confusing- see D7517.

Wed, Dec 4, 1:21 AM
spectral retitled D7544: subrepo: use pycompat.open directly instead of importing open from pycompat from py3: remove incorrect b prefix on second argument to open in subrepo.py to subrepo: use pycompat.open directly instead of importing open from pycompat.
Wed, Dec 4, 1:16 AM

Tue, Dec 3

spectral created D7545: py3: make a pycompat.osdevnull, use it in extdiff.
Tue, Dec 3, 8:36 PM
spectral created D7544: subrepo: use pycompat.open directly instead of importing open from pycompat.
Tue, Dec 3, 8:36 PM
spectral committed rHG888bd39ed555: lock: pass "success" boolean to _afterlock callbacks.
lock: pass "success" boolean to _afterlock callbacks
Tue, Dec 3, 10:59 AM

Mon, Dec 2

spectral added inline comments to D7521: amend: check for file modifications when updating dirstate (issue6233).
Mon, Dec 2, 1:43 PM
spectral updated the diff for D7521: amend: check for file modifications when updating dirstate (issue6233).
Mon, Dec 2, 1:41 PM

Tue, Nov 26

spectral created D7521: amend: check for file modifications when updating dirstate (issue6233).
Tue, Nov 26, 7:30 PM
spectral closed D7459: lock: pass "success" boolean to _afterlock callbacks.
Tue, Nov 26, 9:49 AM
spectral committed rHG4b065b019b4e: lock: pass "success" boolean to _afterlock callbacks.
lock: pass "success" boolean to _afterlock callbacks
Tue, Nov 26, 9:48 AM

Tue, Nov 19

spectral created D7459: lock: pass "success" boolean to _afterlock callbacks.
Tue, Nov 19, 10:16 PM

Nov 11 2019

spectral closed D7298: rebase: check for unfinished ops even when inmemory (issue6214).
Nov 11 2019, 7:35 AM
spectral committed rHGb56c6647f65e: rebase: check for unfinished ops even when inmemory (issue6214).
rebase: check for unfinished ops even when inmemory (issue6214)
Nov 11 2019, 7:34 AM

Nov 10 2019

spectral committed rHG8e175a3d64bd: unshelve: correct help string; unshelve does not accept file list.
unshelve: correct help string; unshelve does not accept file list
Nov 10 2019, 10:37 AM

Nov 8 2019

spectral closed D7365: unshelve: correct help string; unshelve does not accept file list.
Nov 8 2019, 5:35 PM
spectral committed rHGe0dcfdd1731b: unshelve: correct help string; unshelve does not accept file list.
unshelve: correct help string; unshelve does not accept file list
Nov 8 2019, 5:34 PM
spectral created D7365: unshelve: correct help string; unshelve does not accept file list.
Nov 8 2019, 5:29 PM

Nov 6 2019

spectral created D7298: rebase: check for unfinished ops even when inmemory (issue6214).
Nov 6 2019, 9:35 PM

Oct 10 2019

spectral closed D6989: push: support config option to require revs be specified when running push.
Oct 10 2019, 10:12 AM
spectral committed rHG5617b748aad8: push: support config option to require revs be specified when running push.
push: support config option to require revs be specified when running push
Oct 10 2019, 10:10 AM

Oct 9 2019

spectral updated the diff for D6989: push: support config option to require revs be specified when running push.
Oct 9 2019, 5:40 PM

Oct 8 2019

spectral committed rHG8197b395710e: destutil: provide hint on rebase+merge for how to specify destination/rev.
destutil: provide hint on rebase+merge for how to specify destination/rev
Oct 8 2019, 10:37 PM
spectral added a comment to D7028: cleanup: join string literals that are already on one line.

Some slightly disappointing loss of clarity where we had originally had something like:

Oct 8 2019, 6:49 PM
spectral accepted D7027: debugcommands: add a few more writenoi18n().
Oct 8 2019, 6:32 PM
spectral committed rHGbff942299ca9: destutil: provide hint on rebase+merge for how to specify destination/rev.
destutil: provide hint on rebase+merge for how to specify destination/rev
Oct 8 2019, 5:15 PM
spectral closed D7024: destutil: provide hint on rebase+merge for how to specify destination/rev.
Oct 8 2019, 5:15 PM
spectral added a comment to D7024: destutil: provide hint on rebase+merge for how to specify destination/rev.

IIUC, you mean unambiguous instead of ambiguous in the commit message? Re-reading I am confused.

Oct 8 2019, 4:50 PM
spectral retitled D7024: destutil: provide hint on rebase+merge for how to specify destination/rev from destutil: add mechanism to specify ambiguous destination on rebase and merge to destutil: provide hint on rebase+merge for how to specify destination/rev.
Oct 8 2019, 4:49 PM
spectral closed D7023: hghave: document format for version feature checks as <name><vers>, no dots.
Oct 8 2019, 4:14 PM
spectral committed rHG37af48031d6f: hghave: document format for version feature checks as <name><vers>, no dots.
hghave: document format for version feature checks as <name><vers>, no dots
Oct 8 2019, 4:14 PM
spectral retitled D7023: hghave: document format for version feature checks as <name><vers>, no dots from tests: fix test-archive to specify feature as py38, not py-38 to hghave: document format for version feature checks as <name><vers>, no dots.
Oct 8 2019, 3:59 PM
spectral created D7024: destutil: provide hint on rebase+merge for how to specify destination/rev.
Oct 8 2019, 2:17 PM
spectral created D7023: hghave: document format for version feature checks as <name><vers>, no dots.
Oct 8 2019, 2:17 PM

Oct 6 2019

spectral added a comment to D6989: push: support config option to require revs be specified when running push.

Question: should this checking be performed in exchange.push or at the command layer?
(I'm not sure of the answer.)

Oct 6 2019, 9:50 AM

Oct 5 2019

spectral created D6989: push: support config option to require revs be specified when running push.
Oct 5 2019, 4:52 PM

Oct 4 2019

spectral added inline comments to D6956: unfinishedstate: suggested `hg update .` (including `.`) to complete update.
Oct 4 2019, 11:06 AM

Sep 23 2019

spectral closed D6866: osutil: tolerate Py_GetArgcArgv not being set up properly.
Sep 23 2019, 1:15 PM
spectral closed D6867: transaction: detect an attempt to truncate-to-extend on playback, raise error.
Sep 23 2019, 1:15 PM
spectral committed rHG8502f76dbfd7: transaction: detect an attempt to truncate-to-extend on playback, raise error.
transaction: detect an attempt to truncate-to-extend on playback, raise error
Sep 23 2019, 1:15 PM
spectral closed D6865: osutil: allow disabling setprocname via a define passed to the compiler.
Sep 23 2019, 1:15 PM
spectral committed rHGd6227c6c0814: osutil: tolerate Py_GetArgcArgv not being set up properly.
osutil: tolerate Py_GetArgcArgv not being set up properly
Sep 23 2019, 1:15 PM
spectral committed rHG460f8bf58020: osutil: allow disabling setprocname via a define passed to the compiler.
osutil: allow disabling setprocname via a define passed to the compiler
Sep 23 2019, 1:15 PM

Sep 17 2019

spectral created D6867: transaction: detect an attempt to truncate-to-extend on playback, raise error.
Sep 17 2019, 6:58 PM
spectral created D6866: osutil: tolerate Py_GetArgcArgv not being set up properly.
Sep 17 2019, 6:58 PM
spectral created D6865: osutil: allow disabling setprocname via a define passed to the compiler.
Sep 17 2019, 6:58 PM

Sep 9 2019

spectral added a comment to D6789: check-code: allow command substitution with $(command).

This shouldn't be about the user's chosen shell, though, right? This is about the /bin/sh implementation, which you wouldn't/can't replace with fish, so I think it won't bother users that use fish, just distros with really old implementations of /bin/sh.

Sep 9 2019, 3:19 PM

Sep 5 2019

spectral added a comment to D6711: branchheads: store wdir-dependent caches in wcache (issue6181).

I'm not sure what the current state of this is, but I don't want it lingering in the review queue while I'm not actively working on it.

Sep 5 2019, 3:06 PM
spectral closed D6768: split: handle partial commit of renames when doing split or record (issue5723).
Sep 5 2019, 2:58 PM
spectral closed D6767: split: handle partial commit of copies when doing split or record.
Sep 5 2019, 2:58 PM
spectral committed rHG3cf091843b4f: split: handle partial commit of renames when doing split or record (issue5723).
split: handle partial commit of renames when doing split or record (issue5723)
Sep 5 2019, 2:58 PM
spectral committed rHG1fd530b1e1cf: split: handle partial commit of copies when doing split or record.
split: handle partial commit of copies when doing split or record
Sep 5 2019, 2:57 PM