Page MenuHomePhabricator

spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (197 w, 4 d)

Recent Activity

Thu, Apr 8

spectral committed rHG8bca353b1ebc: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset.
match: convert O(n) to O(log n) in exactmatcher.visitchildrenset
Thu, Apr 8, 7:01 PM
spectral closed D10294: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset.
Thu, Apr 8, 2:17 PM
spectral committed rHG67414b0aadbb: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset.
match: convert O(n) to O(log n) in exactmatcher.visitchildrenset
Thu, Apr 8, 2:17 PM
spectral closed D10295: exthelper: improve docs to indicate what module vars are needed.
Thu, Apr 8, 2:17 PM
spectral committed rHG887f89b100ac: exthelper: improve docs to indicate what module vars are needed.
exthelper: improve docs to indicate what module vars are needed
Thu, Apr 8, 2:17 PM
spectral closed D10320: remotefilelog: include file contents in bundles produced during strip.
Thu, Apr 8, 6:56 AM
spectral committed rHG47a9527731c3: remotefilelog: include file contents in bundles produced during strip.
remotefilelog: include file contents in bundles produced during strip
Thu, Apr 8, 6:55 AM
spectral closed D10319: tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes.
Thu, Apr 8, 6:55 AM
spectral committed rHG2819df466cae: tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes.
tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes
Thu, Apr 8, 6:55 AM

Tue, Apr 6

spectral created D10320: remotefilelog: include file contents in bundles produced during strip.
Tue, Apr 6, 8:22 PM
spectral created D10319: tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes.
Tue, Apr 6, 8:21 PM

Thu, Apr 1

spectral created D10295: exthelper: improve docs to indicate what module vars are needed.
Thu, Apr 1, 3:24 PM
spectral created D10294: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset.
Thu, Apr 1, 3:21 PM

Tue, Mar 30

spectral closed D10292: deb: avoid use of [[ in 'rules' file.
Tue, Mar 30, 11:41 PM
spectral committed rHG2fd5e0054dd9: deb: avoid use of [[ in 'rules' file.
deb: avoid use of [[ in 'rules' file
Tue, Mar 30, 11:41 PM
spectral created D10292: deb: avoid use of [[ in 'rules' file.
Tue, Mar 30, 7:13 PM

Mar 4 2021

spectral committed rHG90481550467c: debian: support a "chg-first" installation mechanism (hg is actually chg).
debian: support a "chg-first" installation mechanism (hg is actually chg)
Mar 4 2021, 7:39 AM
spectral closed D10020: debian: support a "chg-first" installation mechanism (hg is actually chg).
Mar 4 2021, 7:39 AM

Feb 24 2021

spectral committed rHGe9901d01d135: revlog: add a mechanism to verify expected file position before appending.
revlog: add a mechanism to verify expected file position before appending
Feb 24 2021, 12:53 PM
spectral committed rHG51f6c4fd4dd9: revlog: add a mechanism to verify expected file position before appending.
revlog: add a mechanism to verify expected file position before appending
Feb 24 2021, 12:12 PM
spectral closed D9952: revlog: add a mechanism to verify expected file position before appending.
Feb 24 2021, 11:20 AM
spectral committed rHGa909d4e327ac: revlog: add a mechanism to verify expected file position before appending.
revlog: add a mechanism to verify expected file position before appending
Feb 24 2021, 11:19 AM

Feb 22 2021

spectral added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

Sorry, I'm not super familiar with the phabricator workflow, should I be doing something more here?

Feb 22 2021, 3:31 PM
spectral added a reviewer for D10020: debian: support a "chg-first" installation mechanism (hg is actually chg): yuja.

Adding yuja as an explicit reviewer.

Feb 22 2021, 3:30 PM

Feb 18 2021

spectral created D10020: debian: support a "chg-first" installation mechanism (hg is actually chg).
Feb 18 2021, 6:36 PM

Feb 14 2021

spectral closed D9983: packaging: add Provides: python3-mercurial and Homepage to debian package.
Feb 14 2021, 11:05 AM
spectral committed rHGc82d6363bc9e: packaging: add Provides: python3-mercurial and Homepage to debian package.
packaging: add Provides: python3-mercurial and Homepage to debian package
Feb 14 2021, 11:05 AM
spectral closed D9990: gendoc: use an empty comment so aliases are separated from previous elements.
Feb 14 2021, 11:05 AM
spectral closed D9989: gendoc: add support for loading extensions from config settings.
Feb 14 2021, 11:05 AM
spectral committed rHG85ec89c47a04: gendoc: use an empty comment so aliases are separated from previous elements.
gendoc: use an empty comment so aliases are separated from previous elements
Feb 14 2021, 11:05 AM
spectral committed rHGeb36f7a71291: gendoc: add support for loading extensions from config settings.
gendoc: add support for loading extensions from config settings
Feb 14 2021, 11:05 AM
spectral committed rHG921e1253c8ba: gendoc: support defaults on customopts a bit better.
gendoc: support defaults on customopts a bit better
Feb 14 2021, 11:05 AM
spectral closed D9988: gendoc: support defaults on customopts a bit better.
Feb 14 2021, 11:05 AM

Feb 12 2021

spectral created D9990: gendoc: use an empty comment so aliases are separated from previous elements.
Feb 12 2021, 4:31 PM
spectral created D9989: gendoc: add support for loading extensions from config settings.
Feb 12 2021, 3:05 PM
spectral created D9988: gendoc: support defaults on customopts a bit better.
Feb 12 2021, 3:05 PM
spectral committed rHG02d91167cfc3: tests: add a comment in a test that will hopefully save someone some time.
tests: add a comment in a test that will hopefully save someone some time
Feb 12 2021, 12:04 AM

Feb 11 2021

spectral created D9983: packaging: add Provides: python3-mercurial and Homepage to debian package.
Feb 11 2021, 2:59 PM
spectral closed D9953: tests: add a comment in a test that will hopefully save someone some time.
Feb 11 2021, 11:47 AM
spectral committed rHG0fd0a940cde2: tests: add a comment in a test that will hopefully save someone some time.
tests: add a comment in a test that will hopefully save someone some time
Feb 11 2021, 11:47 AM

Feb 4 2021

spectral updated the diff for D9952: revlog: add a mechanism to verify expected file position before appending.
Feb 4 2021, 2:47 PM
spectral added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

This still adds all of the function call overhead even when the feature is not used. I also don't like that this check is done repeatedly e.g. during an unbundle. I don't think I would mind checking the size once per revlog on the first write, but not repeatedly.

Feb 4 2021, 2:46 PM

Feb 3 2021

spectral created D9952: revlog: add a mechanism to verify expected file position before appending.
Feb 3 2021, 8:17 PM
spectral created D9953: tests: add a comment in a test that will hopefully save someone some time.
Feb 3 2021, 8:16 PM

Jan 31 2021

spectral closed D9891: wix: tell ComponentSearch that it is finding a directory (not a file).
Jan 31 2021, 8:11 PM
spectral committed rHG8deab876fb59: wix: tell ComponentSearch that it is finding a directory (not a file).
wix: tell ComponentSearch that it is finding a directory (not a file)
Jan 31 2021, 8:11 PM

Jan 27 2021

spectral created D9891: wix: tell ComponentSearch that it is finding a directory (not a file).
Jan 27 2021, 2:34 PM

Jan 19 2021

spectral accepted D9835: resolve: also detect new :mergediff conflict markers.
Jan 19 2021, 6:57 PM
spectral added inline comments to D9835: resolve: also detect new :mergediff conflict markers.
Jan 19 2021, 6:37 PM

Jan 13 2021

spectral closed D9729: patch: handle filenames with trailing spaces.
Jan 13 2021, 2:41 PM
spectral committed rHG416ecdaa12df: patch: handle filenames with trailing spaces.
patch: handle filenames with trailing spaces
Jan 13 2021, 2:41 PM

Jan 12 2021

spectral created D9729: patch: handle filenames with trailing spaces.
Jan 12 2021, 1:34 PM

Dec 12 2020

spectral closed D9567: copies: make calculating lazy for dir move detection's "addedfiles".
Dec 12 2020, 2:56 AM
spectral committed rHG2f357d053df2: copies: make calculating lazy for dir move detection's "addedfiles".
copies: make calculating lazy for dir move detection's "addedfiles"
Dec 12 2020, 2:56 AM

Dec 11 2020

spectral created D9567: copies: make calculating lazy for dir move detection's "addedfiles".
Dec 11 2020, 5:04 PM

Dec 10 2020

spectral closed D9553: treemanifest: stop storing full path for each item in manifest._lazydirs.
Dec 10 2020, 4:42 AM
spectral committed rHG93e09d370003: treemanifest: stop storing full path for each item in manifest._lazydirs.
treemanifest: stop storing full path for each item in manifest._lazydirs
Dec 10 2020, 4:42 AM

Dec 9 2020

spectral added a comment to D9547: hghave: update the check for virtualenv.

Seems fine. ACTIVATE_SH is still in there on the version I have on my Debian Testing machine (15.1.0+ds-3 according to the dpkg system, 15.1.0 according to virtualenv.version). Not sure when it was removed, but it's not really relevant. :)

Dec 9 2020, 5:19 PM
spectral created D9553: treemanifest: stop storing full path for each item in manifest._lazydirs.
Dec 9 2020, 4:42 PM

Dec 3 2020

spectral closed D9511: statprof: separate functions and "line", assume 4 digit line numbers.
Dec 3 2020, 4:38 AM
spectral committed rHG8b0a3ff5ed12: statprof: separate functions and "line", assume 4 digit line numbers.
statprof: separate functions and "line", assume 4 digit line numbers
Dec 3 2020, 4:38 AM
spectral closed D9510: statprof: fix off-by-one-line error in output.
Dec 3 2020, 4:38 AM
spectral committed rHG068307b638f4: statprof: fix off-by-one-line error in output.
statprof: fix off-by-one-line error in output
Dec 3 2020, 4:38 AM
spectral closed D9503: copies: avoid materializing a full directory map during copy tracing.
Dec 3 2020, 4:37 AM
spectral committed rHGb9588ff9b66a: copies: avoid materializing a full directory map during copy tracing.
copies: avoid materializing a full directory map during copy tracing
Dec 3 2020, 4:37 AM

Dec 2 2020

spectral created D9511: statprof: separate functions and "line", assume 4 digit line numbers.
Dec 2 2020, 10:20 PM
spectral created D9510: statprof: fix off-by-one-line error in output.
Dec 2 2020, 10:20 PM
spectral updated the diff for D9503: copies: avoid materializing a full directory map during copy tracing.
Dec 2 2020, 2:49 PM
spectral created D9503: copies: avoid materializing a full directory map during copy tracing.
Dec 2 2020, 2:43 PM
spectral closed D9488: match: skip walking up the directory hierarchy if the number of pats are small.
Dec 2 2020, 3:04 AM
spectral committed rHGc4c7a6b61146: match: skip walking up the directory hierarchy if the number of pats are small.
match: skip walking up the directory hierarchy if the number of pats are small
Dec 2 2020, 3:04 AM

Dec 1 2020

spectral created D9488: match: skip walking up the directory hierarchy if the number of pats are small.
Dec 1 2020, 6:06 PM

Oct 15 2020

spectral closed D9207: record: when backing up, avoid generating very long filenames.
Oct 15 2020, 8:38 AM
spectral committed rHG9628d3cd9d13: record: when backing up, avoid generating very long filenames.
record: when backing up, avoid generating very long filenames
Oct 15 2020, 8:38 AM

Oct 14 2020

spectral created D9207: record: when backing up, avoid generating very long filenames.
Oct 14 2020, 6:12 PM

Sep 21 2020

spectral closed D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use.
Sep 21 2020, 4:27 PM
spectral committed rHG89f0d9f87701: branchmap: add a cache validation cache, avoid expensive re-hash on every use.
branchmap: add a cache validation cache, avoid expensive re-hash on every use
Sep 21 2020, 4:26 PM

Sep 16 2020

spectral updated the diff for D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use.
Sep 16 2020, 3:14 PM
spectral added a comment to D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use.

Did you measure the performance impact on other operation than your target operation ? I am curious about the impact of the @property here.

Sep 16 2020, 3:14 PM
spectral closed D9022: repo: avoid copying/updating a dict on every `repo.__getitem__`.
Sep 16 2020, 4:50 AM
spectral committed rHG4a0ccbecbaa6: repo: avoid copying/updating a dict on every `repo.__getitem__`.
repo: avoid copying/updating a dict on every `repo.__getitem__`
Sep 16 2020, 4:50 AM

Sep 15 2020

spectral created D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use.
Sep 15 2020, 6:49 PM
spectral created D9022: repo: avoid copying/updating a dict on every `repo.__getitem__`.
Sep 15 2020, 6:49 PM

Aug 8 2020

spectral closed D8813: tests: make test-install.t work on debian systems.
Aug 8 2020, 5:01 PM
spectral committed rHGd71693f799a0: tests: make test-install.t work on debian systems.
tests: make test-install.t work on debian systems
Aug 8 2020, 5:01 PM

Jul 29 2020

spectral added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 29 2020, 8:17 PM

Jul 25 2020

spectral closed D8814: tests: make check-py3-compat.py actually load the specified files correctly.
Jul 25 2020, 6:03 AM
spectral committed rHG4e5da64d5549: tests: make check-py3-compat.py actually load the specified files correctly.
tests: make check-py3-compat.py actually load the specified files correctly
Jul 25 2020, 6:03 AM
spectral committed rHG357d8415aa27: tests: virtualenv is only used on py2, rename and conditionalize.
tests: virtualenv is only used on py2, rename and conditionalize
Jul 25 2020, 6:03 AM
spectral committed rHGa253ded5b03d: morestatus: mention --stop even if not using --verbose.
morestatus: mention --stop even if not using --verbose
Jul 25 2020, 6:03 AM
spectral closed D8811: morestatus: mention --stop even if not using --verbose.
Jul 25 2020, 6:03 AM
spectral closed D8812: tests: virtualenv is only used on py2, rename and conditionalize.
Jul 25 2020, 6:02 AM

Jul 24 2020

spectral created D8814: tests: make check-py3-compat.py actually load the specified files correctly.
Jul 24 2020, 8:02 PM
spectral created D8813: tests: make test-install.t work on debian systems.
Jul 24 2020, 6:25 PM
spectral created D8812: tests: virtualenv is only used on py2, rename and conditionalize.
Jul 24 2020, 6:24 PM
spectral created D8811: morestatus: mention --stop even if not using --verbose.
Jul 24 2020, 6:22 PM

Jun 26 2020

spectral closed D8642: debian: support building a single deb for multiple py3 versions.
Jun 26 2020, 11:43 AM
spectral committed rHG36178b5c9aeb: debian: support building a single deb for multiple py3 versions.
debian: support building a single deb for multiple py3 versions
Jun 26 2020, 11:43 AM

Jun 19 2020

spectral created D8642: debian: support building a single deb for multiple py3 versions.
Jun 19 2020, 9:02 PM
spectral committed rHG1a4b9b602e54: py3: fix broken man page generation, it was generating `(default: NUL*)`.
py3: fix broken man page generation, it was generating `(default: NUL*)`
Jun 19 2020, 4:51 AM