Page MenuHomePhabricator

spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (207 w, 2 d)

Recent Activity

May 17 2021

spectral added a comment to D10537: tests: fix chg tests missed in D10470.

Looks like these changes were absorbed into 8fcc0a82, so this is unnecessary now.

May 17 2021, 3:24 PM

May 6 2021

spectral closed D10539: black: make codebase compatible with black v21.4b2 and v20.8b1.
May 6 2021, 5:13 AM
spectral committed rHGf38bf44e077f: black: make codebase compatible with black v21.4b2 and v20.8b1.
black: make codebase compatible with black v21.4b2 and v20.8b1
May 6 2021, 5:07 AM

May 2 2021

spectral committed rHG8fcc0a829f3d: chg: pass --no-profile to disable profiling when starting hg serve.
chg: pass --no-profile to disable profiling when starting hg serve
May 2 2021, 10:14 PM

May 1 2021

spectral added a comment to D10538: tests: allow trunk versions of clang-format to be used.

I'm not sure that this is an improvement. We discussed whether we want to hard-wire the version even stricter ("exactly version 11"), especially because it is hard to predict when the output is going to change again.

May 1 2021, 3:23 PM

Apr 30 2021

spectral created D10539: black: make codebase compatible with black v21.4b2 and v20.8b1.
Apr 30 2021, 7:26 PM
spectral added a comment to D10470: chg: pass --no-profile to disable profiling when starting hg serve.

This breaks the CI https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/21383.
Could you send a followup please?

Apr 30 2021, 7:24 PM
spectral created D10537: tests: fix chg tests missed in D10470.
Apr 30 2021, 7:20 PM
spectral created D10538: tests: allow trunk versions of clang-format to be used.
Apr 30 2021, 7:20 PM
spectral closed D10469: profiling: add --no-profile to disable profiling enabled via config.
Apr 30 2021, 10:08 AM
spectral closed D10470: chg: pass --no-profile to disable profiling when starting hg serve.
Apr 30 2021, 10:08 AM
spectral committed rHG8138092f8790: chg: pass --no-profile to disable profiling when starting hg serve.
chg: pass --no-profile to disable profiling when starting hg serve
Apr 30 2021, 10:07 AM
spectral committed rHGa2bf93ab3014: profiling: add --no-profile to disable profiling enabled via config.
profiling: add --no-profile to disable profiling enabled via config
Apr 30 2021, 10:07 AM
spectral committed rHGec081d7f0009: tests: fix test-chg to ignore a warning about being unable to set locale.
tests: fix test-chg to ignore a warning about being unable to set locale
Apr 30 2021, 10:07 AM
spectral closed D10468: tests: fix test-chg to ignore a warning about being unable to set locale.
Apr 30 2021, 10:07 AM

Apr 29 2021

spectral committed rHG222a42ac5b2d: dirstateguard: use mktemp-like functionality to generate the backup filenames.
dirstateguard: use mktemp-like functionality to generate the backup filenames
Apr 29 2021, 10:57 AM
spectral closed D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.
Apr 29 2021, 10:57 AM

Apr 28 2021

spectral added a comment to D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.

I thought I'd run the entire test suite and it passed before sending. Sorry about that! Fixed fncache and inherit-mode by not writing out the narrowspec backup in the mkstemp call. I'm not getting any failures in test-check-code.t, can you share what ones you're seeing?

Apr 28 2021, 11:02 AM
spectral updated the diff for D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.
Apr 28 2021, 11:02 AM
spectral added inline comments to D10468: tests: fix test-chg to ignore a warning about being unable to set locale.
Apr 28 2021, 10:59 AM
spectral updated the summary of D10468: tests: fix test-chg to ignore a warning about being unable to set locale.
Apr 28 2021, 10:59 AM
spectral added a comment to D10469: profiling: add --no-profile to disable profiling enabled via config.

(marking comment as resolved, not sure what the exact policy is here :))

Apr 28 2021, 10:59 AM

Apr 20 2021

spectral added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

@spectral, What is the range of code you want to ensure a race with ? and how is the synchronization happening to reach it ?

Apr 20 2021, 4:09 PM
spectral created D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.
Apr 20 2021, 4:08 PM
spectral added inline comments to D10469: profiling: add --no-profile to disable profiling enabled via config.
Apr 20 2021, 1:22 PM

Apr 19 2021

spectral added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

I'm unable to reproduce. I've run the test over 10,000 times (I added a #testcases a b c d e f g h i j k l m n o p q r s t u v w x y z so it ran 26 times each run, and I've run over 300 instances of that like run-tests.py -j26 -l --chg test-racy-mutations.t, over 100 with -j108, and other combinations (with and without the added testcases, with and without --chg, etc.)

Apr 19 2021, 10:42 PM
spectral created D10470: chg: pass --no-profile to disable profiling when starting hg serve.
Apr 19 2021, 6:32 PM
spectral created D10469: profiling: add --no-profile to disable profiling enabled via config.
Apr 19 2021, 6:32 PM
spectral created D10468: tests: fix test-chg to ignore a warning about being unable to set locale.
Apr 19 2021, 6:32 PM
spectral abandoned D6711: branchheads: store wdir-dependent caches in wcache (issue6181).
Apr 19 2021, 3:04 PM
spectral added a comment to D6719: branchmap: refresh all "heads" of the branchmap subsets.

I'm apparently not going to resolve the comments, sorry for leaving this open so long.

Apr 19 2021, 3:01 PM

Apr 14 2021

spectral closed D10389: split: avoid strip if split is a no-op (identical to original).
Apr 14 2021, 8:41 PM
spectral closed D10388: split: fix issue with empty splits adjusting phases.
Apr 14 2021, 8:41 PM
spectral committed rHGca0049946e9a: split: avoid strip if split is a no-op (identical to original).
split: avoid strip if split is a no-op (identical to original)
Apr 14 2021, 8:41 PM
spectral committed rHG8ee1ac083ee7: split: fix issue with empty splits adjusting phases.
split: fix issue with empty splits adjusting phases
Apr 14 2021, 8:41 PM
spectral closed D10387: split: add test demonstrating issue with empty splits adjusting phases.
Apr 14 2021, 8:41 PM
spectral committed rHG17368844f786: split: add test demonstrating issue with empty splits adjusting phases.
split: add test demonstrating issue with empty splits adjusting phases
Apr 14 2021, 8:41 PM
spectral added a comment to D10386: tests: avoid use of "python", which may not even be installed.

Fails to apply cleanly on current tip of default branch. Kindly rebase and resend.

Apr 14 2021, 8:11 PM

Apr 13 2021

spectral created D10389: split: avoid strip if split is a no-op (identical to original).
Apr 13 2021, 2:53 PM
spectral created D10388: split: fix issue with empty splits adjusting phases.
Apr 13 2021, 2:53 PM
spectral created D10387: split: add test demonstrating issue with empty splits adjusting phases.
Apr 13 2021, 2:53 PM
spectral created D10386: tests: avoid use of "python", which may not even be installed.
Apr 13 2021, 2:51 PM

Apr 8 2021

spectral committed rHG8bca353b1ebc: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset.
match: convert O(n) to O(log n) in exactmatcher.visitchildrenset
Apr 8 2021, 7:01 PM
spectral closed D10294: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset.
Apr 8 2021, 2:17 PM
spectral committed rHG67414b0aadbb: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset.
match: convert O(n) to O(log n) in exactmatcher.visitchildrenset
Apr 8 2021, 2:17 PM
spectral closed D10295: exthelper: improve docs to indicate what module vars are needed.
Apr 8 2021, 2:17 PM
spectral committed rHG887f89b100ac: exthelper: improve docs to indicate what module vars are needed.
exthelper: improve docs to indicate what module vars are needed
Apr 8 2021, 2:17 PM
spectral closed D10320: remotefilelog: include file contents in bundles produced during strip.
Apr 8 2021, 6:56 AM
spectral committed rHG47a9527731c3: remotefilelog: include file contents in bundles produced during strip.
remotefilelog: include file contents in bundles produced during strip
Apr 8 2021, 6:55 AM
spectral closed D10319: tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes.
Apr 8 2021, 6:55 AM
spectral committed rHG2819df466cae: tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes.
tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes
Apr 8 2021, 6:55 AM

Apr 6 2021

spectral created D10320: remotefilelog: include file contents in bundles produced during strip.
Apr 6 2021, 8:22 PM
spectral created D10319: tests: add test-remotefilelog-strip.t to demonstrate an issue with linknodes.
Apr 6 2021, 8:21 PM

Apr 1 2021

spectral created D10295: exthelper: improve docs to indicate what module vars are needed.
Apr 1 2021, 3:24 PM
spectral created D10294: match: convert O(n) to O(log n) in exactmatcher.visitchildrenset.
Apr 1 2021, 3:21 PM

Mar 30 2021

spectral closed D10292: deb: avoid use of [[ in 'rules' file.
Mar 30 2021, 11:41 PM
spectral committed rHG2fd5e0054dd9: deb: avoid use of [[ in 'rules' file.
deb: avoid use of [[ in 'rules' file
Mar 30 2021, 11:41 PM
spectral created D10292: deb: avoid use of [[ in 'rules' file.
Mar 30 2021, 7:13 PM

Mar 4 2021

spectral committed rHG90481550467c: debian: support a "chg-first" installation mechanism (hg is actually chg).
debian: support a "chg-first" installation mechanism (hg is actually chg)
Mar 4 2021, 7:39 AM
spectral closed D10020: debian: support a "chg-first" installation mechanism (hg is actually chg).
Mar 4 2021, 7:39 AM

Feb 24 2021

spectral committed rHGe9901d01d135: revlog: add a mechanism to verify expected file position before appending.
revlog: add a mechanism to verify expected file position before appending
Feb 24 2021, 12:53 PM
spectral committed rHG51f6c4fd4dd9: revlog: add a mechanism to verify expected file position before appending.
revlog: add a mechanism to verify expected file position before appending
Feb 24 2021, 12:12 PM
spectral closed D9952: revlog: add a mechanism to verify expected file position before appending.
Feb 24 2021, 11:20 AM
spectral committed rHGa909d4e327ac: revlog: add a mechanism to verify expected file position before appending.
revlog: add a mechanism to verify expected file position before appending
Feb 24 2021, 11:19 AM

Feb 22 2021

spectral added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

Sorry, I'm not super familiar with the phabricator workflow, should I be doing something more here?

Feb 22 2021, 3:31 PM
spectral added a reviewer for D10020: debian: support a "chg-first" installation mechanism (hg is actually chg): yuja.

Adding yuja as an explicit reviewer.

Feb 22 2021, 3:30 PM

Feb 18 2021

spectral created D10020: debian: support a "chg-first" installation mechanism (hg is actually chg).
Feb 18 2021, 6:36 PM

Feb 14 2021

spectral closed D9983: packaging: add Provides: python3-mercurial and Homepage to debian package.
Feb 14 2021, 11:05 AM
spectral committed rHGc82d6363bc9e: packaging: add Provides: python3-mercurial and Homepage to debian package.
packaging: add Provides: python3-mercurial and Homepage to debian package
Feb 14 2021, 11:05 AM
spectral closed D9990: gendoc: use an empty comment so aliases are separated from previous elements.
Feb 14 2021, 11:05 AM
spectral closed D9989: gendoc: add support for loading extensions from config settings.
Feb 14 2021, 11:05 AM
spectral committed rHG85ec89c47a04: gendoc: use an empty comment so aliases are separated from previous elements.
gendoc: use an empty comment so aliases are separated from previous elements
Feb 14 2021, 11:05 AM
spectral committed rHGeb36f7a71291: gendoc: add support for loading extensions from config settings.
gendoc: add support for loading extensions from config settings
Feb 14 2021, 11:05 AM
spectral committed rHG921e1253c8ba: gendoc: support defaults on customopts a bit better.
gendoc: support defaults on customopts a bit better
Feb 14 2021, 11:05 AM
spectral closed D9988: gendoc: support defaults on customopts a bit better.
Feb 14 2021, 11:05 AM

Feb 12 2021

spectral created D9990: gendoc: use an empty comment so aliases are separated from previous elements.
Feb 12 2021, 4:31 PM
spectral created D9989: gendoc: add support for loading extensions from config settings.
Feb 12 2021, 3:05 PM
spectral created D9988: gendoc: support defaults on customopts a bit better.
Feb 12 2021, 3:05 PM
spectral committed rHG02d91167cfc3: tests: add a comment in a test that will hopefully save someone some time.
tests: add a comment in a test that will hopefully save someone some time
Feb 12 2021, 12:04 AM

Feb 11 2021

spectral created D9983: packaging: add Provides: python3-mercurial and Homepage to debian package.
Feb 11 2021, 2:59 PM
spectral closed D9953: tests: add a comment in a test that will hopefully save someone some time.
Feb 11 2021, 11:47 AM
spectral committed rHG0fd0a940cde2: tests: add a comment in a test that will hopefully save someone some time.
tests: add a comment in a test that will hopefully save someone some time
Feb 11 2021, 11:47 AM

Feb 4 2021

spectral updated the diff for D9952: revlog: add a mechanism to verify expected file position before appending.
Feb 4 2021, 2:47 PM
spectral added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

This still adds all of the function call overhead even when the feature is not used. I also don't like that this check is done repeatedly e.g. during an unbundle. I don't think I would mind checking the size once per revlog on the first write, but not repeatedly.

Feb 4 2021, 2:46 PM

Feb 3 2021

spectral created D9952: revlog: add a mechanism to verify expected file position before appending.
Feb 3 2021, 8:17 PM
spectral created D9953: tests: add a comment in a test that will hopefully save someone some time.
Feb 3 2021, 8:16 PM

Jan 31 2021

spectral closed D9891: wix: tell ComponentSearch that it is finding a directory (not a file).
Jan 31 2021, 8:11 PM
spectral committed rHG8deab876fb59: wix: tell ComponentSearch that it is finding a directory (not a file).
wix: tell ComponentSearch that it is finding a directory (not a file)
Jan 31 2021, 8:11 PM

Jan 27 2021

spectral created D9891: wix: tell ComponentSearch that it is finding a directory (not a file).
Jan 27 2021, 2:34 PM

Jan 19 2021

spectral accepted D9835: resolve: also detect new :mergediff conflict markers.
Jan 19 2021, 6:57 PM
spectral added inline comments to D9835: resolve: also detect new :mergediff conflict markers.
Jan 19 2021, 6:37 PM

Jan 13 2021

spectral closed D9729: patch: handle filenames with trailing spaces.
Jan 13 2021, 2:41 PM
spectral committed rHG416ecdaa12df: patch: handle filenames with trailing spaces.
patch: handle filenames with trailing spaces
Jan 13 2021, 2:41 PM

Jan 12 2021

spectral created D9729: patch: handle filenames with trailing spaces.
Jan 12 2021, 1:34 PM

Dec 12 2020

spectral closed D9567: copies: make calculating lazy for dir move detection's "addedfiles".
Dec 12 2020, 2:56 AM
spectral committed rHG2f357d053df2: copies: make calculating lazy for dir move detection's "addedfiles".
copies: make calculating lazy for dir move detection's "addedfiles"
Dec 12 2020, 2:56 AM

Dec 11 2020

spectral created D9567: copies: make calculating lazy for dir move detection's "addedfiles".
Dec 11 2020, 5:04 PM

Dec 10 2020

spectral closed D9553: treemanifest: stop storing full path for each item in manifest._lazydirs.
Dec 10 2020, 4:42 AM
spectral committed rHG93e09d370003: treemanifest: stop storing full path for each item in manifest._lazydirs.
treemanifest: stop storing full path for each item in manifest._lazydirs
Dec 10 2020, 4:42 AM

Dec 9 2020

spectral added a comment to D9547: hghave: update the check for virtualenv.

Seems fine. ACTIVATE_SH is still in there on the version I have on my Debian Testing machine (15.1.0+ds-3 according to the dpkg system, 15.1.0 according to virtualenv.version). Not sure when it was removed, but it's not really relevant. :)

Dec 9 2020, 5:19 PM