Page MenuHomePhabricator

spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (231 w, 2 d)

Recent Activity

Nov 4 2021

spectral closed D11734: pyoxidizer: use in-memory resources on non-Windows platforms.
Nov 4 2021, 10:42 AM
spectral committed rHG1a420a13eeea: pyoxidizer: use in-memory resources on non-Windows platforms.
pyoxidizer: use in-memory resources on non-Windows platforms
Nov 4 2021, 10:42 AM

Nov 3 2021

spectral created D11734: pyoxidizer: use in-memory resources on non-Windows platforms.
Nov 3 2021, 5:17 PM

Oct 29 2021

spectral abandoned D5019: pager: disable auto pager if we think it doesn't support F, R, X.
Oct 29 2021, 5:44 PM
spectral abandoned D8281: narrow: escape includepats/excludepats when sending over the wire.
Oct 29 2021, 5:44 PM
spectral added a reviewer for D11727: backout: backed out changeset 67d14d4e036c: mharbison72.
Oct 29 2021, 4:33 PM
spectral added a reviewer for D11726: backout: backed out changeset f78d8b8c46d7: mharbison72.
Oct 29 2021, 4:32 PM
spectral accepted D11725: windows: use raw string in test log paths.
Oct 29 2021, 4:30 PM
spectral accepted D11723: rhg: make it possible to opt out of `rhg cat`.
Oct 29 2021, 4:29 PM
spectral added a comment to D11680: push: add option to abort on dirty working copy if parent is pushed.

The ability to use --no- variants is fairly new (a couple of year maybe ?), but I (and others) have been trying to put it to good use since then. Since is quite new I don't think they so many of of such flag yet, but a notable example of that approach is --merge that I use daily.

Oct 29 2021, 3:42 PM
spectral added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

The test near silently skipping is another issue we should tackle. What do you think of the way forward I suggested (flag + env-variable) ?

Oct 29 2021, 2:50 PM

Oct 28 2021

spectral closed D10538: tests: allow Google's internal builds of clang-format to be used.
Oct 28 2021, 5:16 AM
spectral committed rHG1ff06ceb070f: tests: allow Google's internal builds of clang-format to be used.
tests: allow Google's internal builds of clang-format to be used
Oct 28 2021, 5:16 AM

Oct 26 2021

spectral added inline comments to D11680: push: add option to abort on dirty working copy if parent is pushed.
Oct 26 2021, 1:12 PM

Oct 24 2021

spectral added a comment to D11715: dirstate: group return logic and clarify each function in flagfunc.

Now that the fallback function is always being built

Oct 24 2021, 2:20 AM

Oct 22 2021

spectral closed D11714: tests: fix test-convert-git to work w/ "git pull" requiring strategy.
Oct 22 2021, 3:35 AM
spectral committed rHGfd3d4b7f8e62: tests: fix test-convert-git to work w/ "git pull" requiring strategy.
tests: fix test-convert-git to work w/ "git pull" requiring strategy
Oct 22 2021, 3:35 AM

Oct 21 2021

spectral accepted D11715: dirstate: group return logic and clarify each function in flagfunc.
Oct 21 2021, 7:50 PM
spectral committed rHG5228a6dc212b: merge-halt: fix issue with merge.on-failure=halt breaking unshelve.
merge-halt: fix issue with merge.on-failure=halt breaking unshelve
Oct 21 2021, 3:27 AM
spectral committed rHG3e66e4517744: merge-halt: demonstrate unshelve issue with merge.on-failure=halt.
merge-halt: demonstrate unshelve issue with merge.on-failure=halt
Oct 21 2021, 3:27 AM

Oct 20 2021

spectral added inline comments to D11713: dirstate: add missing return on platforms without exec or symlink.
Oct 20 2021, 9:11 PM
spectral retitled D10538: tests: allow Google's internal builds of clang-format to be used from tests: allow trunk versions of clang-format to be used to tests: allow Google's internal builds of clang-format to be used.
Oct 20 2021, 5:48 PM
spectral added a comment to D11713: dirstate: add missing return on platforms without exec or symlink.

I'm not sure the etiquette here; I'm accepting the revision since it obviously fixes a bug, but still would like the comments to be considered/responded to?

Oct 20 2021, 2:27 PM
spectral accepted D11712: parsers: don't ask about symlinks on platforms that don't support them.
Oct 20 2021, 2:13 PM
spectral accepted D11711: parsers: don't ask about the exec bit on platforms that don't have it.
Oct 20 2021, 2:13 PM
spectral created D11714: tests: fix test-convert-git to work w/ "git pull" requiring strategy.
Oct 20 2021, 1:55 PM
spectral closed D11698: pyoxidizer: update README.md with several small fixes.
Oct 20 2021, 5:35 AM
spectral committed rHG16c3fe46929a: pyoxidizer: update README.md with several small fixes.
pyoxidizer: update README.md with several small fixes
Oct 20 2021, 5:35 AM
spectral closed D11697: pyoxidizer: disable using in-memory resources.
Oct 20 2021, 5:35 AM
spectral committed rHGc900d962e38b: pyoxidizer: disable using in-memory resources.
pyoxidizer: disable using in-memory resources
Oct 20 2021, 5:35 AM
spectral closed D11706: merge-halt: fix issue with merge.on-failure=halt breaking unshelve.
Oct 20 2021, 5:21 AM
spectral closed D11705: merge-halt: demonstrate unshelve issue with merge.on-failure=halt.
Oct 20 2021, 5:20 AM
spectral committed rHGcae221e8e4c5: merge-halt: fix issue with merge.on-failure=halt breaking unshelve.
merge-halt: fix issue with merge.on-failure=halt breaking unshelve
Oct 20 2021, 5:20 AM
spectral committed rHG7b0b417cd960: merge-halt: demonstrate unshelve issue with merge.on-failure=halt.
merge-halt: demonstrate unshelve issue with merge.on-failure=halt
Oct 20 2021, 5:20 AM

Oct 19 2021

spectral planned changes to D10538: tests: allow Google's internal builds of clang-format to be used.
Oct 19 2021, 9:30 PM
spectral created D11706: merge-halt: fix issue with merge.on-failure=halt breaking unshelve.
Oct 19 2021, 9:28 PM
spectral created D11705: merge-halt: demonstrate unshelve issue with merge.on-failure=halt.
Oct 19 2021, 9:27 PM
spectral accepted D11695: dirstate-v2: read the fallback value in Rust.
Oct 19 2021, 5:09 PM
spectral accepted D11694: dirstate-v2: adjust the meaning of directory flags.
Oct 19 2021, 5:08 PM
spectral accepted D11696: rust: remove now-unused DirstateEntry::clear_ambiguous_mtime method.
Oct 19 2021, 5:02 PM
spectral accepted D11691: dirstate: rename a `very_likely_equal` method to `likely_equal`.
Oct 19 2021, 5:01 PM
spectral accepted D11690: python: compatibility for python 3.11 (issue6604).
Oct 19 2021, 5:01 PM
spectral created D11698: pyoxidizer: update README.md with several small fixes.
Oct 19 2021, 5:00 PM
spectral created D11697: pyoxidizer: disable using in-memory resources.
Oct 19 2021, 5:00 PM

Oct 18 2021

spectral added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

I feel like the proposal is going in the wrong direction because it make a more diverse set of version passe the version checks while I feel like we need to more toward a narrower check. Different formater version tends to produce different results and it seems saner to pin the project to specific versions (that we update from time to time).

Oct 18 2021, 9:40 PM
spectral added inline comments to D11679: rhg: internally, return a structured representation from hg cat.
Oct 18 2021, 7:06 PM

Oct 17 2021

spectral accepted D11675: bookmarks: move the `mirror` option to the `paths` section.
Oct 17 2021, 7:37 PM
spectral accepted D11676: bookmarks: add support for `mirror` mode to `incoming`.
Oct 17 2021, 7:34 PM

Oct 15 2021

spectral accepted D11677: bookmarks: add a `ignore` variant of the bookmark mode.
Oct 15 2021, 9:23 PM
spectral added inline comments to D11676: bookmarks: add support for `mirror` mode to `incoming`.
Oct 15 2021, 9:18 PM
spectral added a comment to D11675: bookmarks: move the `mirror` option to the `paths` section.

Looks good to me aside from the nit and the pulkit's comment. Not sure on etiquette here (whether I should mark as accepted or not), defaulting to not marking as accepted until all outstanding comments are addressed.

Oct 15 2021, 9:02 PM
spectral added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

The CI running on Heptapod is available to any developer who pushs draft to it, and it uses the "correct" black version, pinned in the docker image what we uses for the CI.
Something we have been entertaining for a while is to a manually trigger a CI "job" that would run the black formatter one current stack and push back the result to heptapod. This would give a simple option to format with the right version when the CI complains about it. It looks like it could fit the @spectral usecase here.
(The docker image can be easily updated to newer version when appropriate by anyone creating a Merge request here: https://foss.heptapod.net/octobus/ci-dockerfiles/)

While this is/would be very useful, it requires manual action, I think?

Yes, it would be an optional way for people who don't want (or can't easily) install the required tools at the required version.

My goal is to prevent that. I want/need there to be a single command I can run that ensures a commit is ready to land: correctly formatted, tests pass, etc.; there's a reason these check-format tests exist as tests. :/

I am not challenging that, but whatever we do with these tests need to be viable at the project level and it don't seems like using too many, incompatible, version of the formatter would fly well.
I think the baseline for the project should be "the CI shoul stay green" which implies "new changesets should keep the CI green". Running tests locally is a good way to quickly catch errors, but eventually, the only way to validate this is to run the CI on submitted changeset. Something that is now easy to do for a couple of years.
However this implies to make sure the version of formatter used by developers is aligned with the one used by the CI. Which should not be to complicated.

Oct 15 2021, 8:10 PM

Sep 27 2021

spectral added a comment to D11495: narrow: make hg manifest only print things inside the narrowspec.

I think that's a buggy test? @martinvonz and @spectral might have an opinion.

I think I did it that way because I felt that hg manifest is a debug command so it might be useful to have the information about excluded trees there.

Sep 27 2021, 8:46 PM

Sep 9 2021

spectral closed D11391: filemerge: be more strict when detecting conflict markers, add `|` markers.
Sep 9 2021, 5:13 AM
spectral committed rHG053dd53a0b59: filemerge: be more strict when detecting conflict markers, add `|` markers.
filemerge: be more strict when detecting conflict markers, add `|` markers
Sep 9 2021, 5:13 AM

Sep 7 2021

spectral created D11391: filemerge: be more strict when detecting conflict markers, add `|` markers.
Sep 7 2021, 3:12 PM
spectral added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

I think that the worst that can happen with this change is:
a. clang-format makes a backwards-incompatible change

This has happened (in the past, anyway) pretty regularly. When I asked djasper about it, his answer was "you should check in the clang-format binary you want to test against" which we obviously can't do. :/

Sep 7 2021, 3:12 PM

Jul 30 2021

spectral closed D11217: help: correct config.profiling.freq name (frequency->freq).
Jul 30 2021, 11:12 AM
spectral committed rHG1a174f122814: help: correct config.profiling.freq name (frequency->freq).
help: correct config.profiling.freq name (frequency->freq)
Jul 30 2021, 11:12 AM

Jul 27 2021

spectral created D11217: help: correct config.profiling.freq name (frequency->freq).
Jul 27 2021, 2:26 PM

May 17 2021

spectral added a comment to D10537: tests: fix chg tests missed in D10470.

Looks like these changes were absorbed into 8fcc0a82, so this is unnecessary now.

May 17 2021, 3:24 PM

May 6 2021

spectral closed D10539: black: make codebase compatible with black v21.4b2 and v20.8b1.
May 6 2021, 5:13 AM
spectral committed rHGf38bf44e077f: black: make codebase compatible with black v21.4b2 and v20.8b1.
black: make codebase compatible with black v21.4b2 and v20.8b1
May 6 2021, 5:07 AM

May 2 2021

spectral committed rHG8fcc0a829f3d: chg: pass --no-profile to disable profiling when starting hg serve.
chg: pass --no-profile to disable profiling when starting hg serve
May 2 2021, 10:14 PM

May 1 2021

spectral added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

I'm not sure that this is an improvement. We discussed whether we want to hard-wire the version even stricter ("exactly version 11"), especially because it is hard to predict when the output is going to change again.

May 1 2021, 3:23 PM

Apr 30 2021

spectral created D10539: black: make codebase compatible with black v21.4b2 and v20.8b1.
Apr 30 2021, 7:26 PM
spectral added a comment to D10470: chg: pass --no-profile to disable profiling when starting hg serve.

This breaks the CI https://foss.heptapod.net/octobus/mercurial-devel/-/pipelines/21383.
Could you send a followup please?

Apr 30 2021, 7:24 PM
spectral created D10537: tests: fix chg tests missed in D10470.
Apr 30 2021, 7:20 PM
spectral created D10538: tests: allow Google's internal builds of clang-format to be used.
Apr 30 2021, 7:20 PM
spectral closed D10469: profiling: add --no-profile to disable profiling enabled via config.
Apr 30 2021, 10:08 AM
spectral closed D10470: chg: pass --no-profile to disable profiling when starting hg serve.
Apr 30 2021, 10:08 AM
spectral committed rHG8138092f8790: chg: pass --no-profile to disable profiling when starting hg serve.
chg: pass --no-profile to disable profiling when starting hg serve
Apr 30 2021, 10:07 AM
spectral committed rHGa2bf93ab3014: profiling: add --no-profile to disable profiling enabled via config.
profiling: add --no-profile to disable profiling enabled via config
Apr 30 2021, 10:07 AM
spectral committed rHGec081d7f0009: tests: fix test-chg to ignore a warning about being unable to set locale.
tests: fix test-chg to ignore a warning about being unable to set locale
Apr 30 2021, 10:07 AM
spectral closed D10468: tests: fix test-chg to ignore a warning about being unable to set locale.
Apr 30 2021, 10:07 AM

Apr 29 2021

spectral committed rHG222a42ac5b2d: dirstateguard: use mktemp-like functionality to generate the backup filenames.
dirstateguard: use mktemp-like functionality to generate the backup filenames
Apr 29 2021, 10:57 AM
spectral closed D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.
Apr 29 2021, 10:57 AM

Apr 28 2021

spectral added a comment to D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.

I thought I'd run the entire test suite and it passed before sending. Sorry about that! Fixed fncache and inherit-mode by not writing out the narrowspec backup in the mkstemp call. I'm not getting any failures in test-check-code.t, can you share what ones you're seeing?

Apr 28 2021, 11:02 AM
spectral updated the diff for D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.
Apr 28 2021, 11:02 AM
spectral added inline comments to D10468: tests: fix test-chg to ignore a warning about being unable to set locale.
Apr 28 2021, 10:59 AM
spectral updated the summary of D10468: tests: fix test-chg to ignore a warning about being unable to set locale.
Apr 28 2021, 10:59 AM
spectral added a comment to D10469: profiling: add --no-profile to disable profiling enabled via config.

(marking comment as resolved, not sure what the exact policy is here :))

Apr 28 2021, 10:59 AM

Apr 20 2021

spectral added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

@spectral, What is the range of code you want to ensure a race with ? and how is the synchronization happening to reach it ?

Apr 20 2021, 4:09 PM
spectral created D10504: dirstateguard: use mktemp-like functionality to generate the backup filenames.
Apr 20 2021, 4:08 PM
spectral added inline comments to D10469: profiling: add --no-profile to disable profiling enabled via config.
Apr 20 2021, 1:22 PM

Apr 19 2021

spectral added a comment to D9952: revlog: add a mechanism to verify expected file position before appending.

I'm unable to reproduce. I've run the test over 10,000 times (I added a #testcases a b c d e f g h i j k l m n o p q r s t u v w x y z so it ran 26 times each run, and I've run over 300 instances of that like run-tests.py -j26 -l --chg test-racy-mutations.t, over 100 with -j108, and other combinations (with and without the added testcases, with and without --chg, etc.)

Apr 19 2021, 10:42 PM
spectral created D10470: chg: pass --no-profile to disable profiling when starting hg serve.
Apr 19 2021, 6:32 PM
spectral created D10469: profiling: add --no-profile to disable profiling enabled via config.
Apr 19 2021, 6:32 PM
spectral created D10468: tests: fix test-chg to ignore a warning about being unable to set locale.
Apr 19 2021, 6:32 PM
spectral abandoned D6711: branchheads: store wdir-dependent caches in wcache (issue6181).
Apr 19 2021, 3:04 PM
spectral added a comment to D6719: branchmap: refresh all "heads" of the branchmap subsets.

I'm apparently not going to resolve the comments, sorry for leaving this open so long.

Apr 19 2021, 3:01 PM

Apr 14 2021

spectral closed D10389: split: avoid strip if split is a no-op (identical to original).
Apr 14 2021, 8:41 PM
spectral closed D10388: split: fix issue with empty splits adjusting phases.
Apr 14 2021, 8:41 PM
spectral committed rHGca0049946e9a: split: avoid strip if split is a no-op (identical to original).
split: avoid strip if split is a no-op (identical to original)
Apr 14 2021, 8:41 PM
spectral committed rHG8ee1ac083ee7: split: fix issue with empty splits adjusting phases.
split: fix issue with empty splits adjusting phases
Apr 14 2021, 8:41 PM
spectral closed D10387: split: add test demonstrating issue with empty splits adjusting phases.
Apr 14 2021, 8:41 PM
spectral committed rHG17368844f786: split: add test demonstrating issue with empty splits adjusting phases.
split: add test demonstrating issue with empty splits adjusting phases
Apr 14 2021, 8:41 PM
spectral added a comment to D10386: tests: avoid use of "python", which may not even be installed.

Fails to apply cleanly on current tip of default branch. Kindly rebase and resend.

Apr 14 2021, 8:11 PM

Apr 13 2021

spectral created D10389: split: avoid strip if split is a no-op (identical to original).
Apr 13 2021, 2:53 PM
spectral created D10388: split: fix issue with empty splits adjusting phases.
Apr 13 2021, 2:53 PM