This shouldn't be about the user's chosen shell, though, right? This is about the /bin/sh implementation, which you wouldn't/can't replace with fish, so I think it won't bother users that use fish, just distros with really old implementations of /bin/sh.

I'm not sure what the current state of this is, but I don't want it lingering in the review queue while I'm not actively working on it.

https://www.mercurial-scm.org/repo/hg/rev/56132ebd14c6 added blackbox.ignore, which is basically what this was doing.

https://www.mercurial-scm.org/repo/hg/rev/56132ebd14c6 Added blackbox.ignore, which is probably sufficient.

In D6710#98322, @marmoute wrote:

Forcing this write seems like a good idea. Having it in its own
changeset seems like a good idea (and please add a comment about forcing
the write).

Adding marmoute as explicit reviewer.

In D6711#98248, @marmoute wrote:

The change looks good to me, However we probably want to introduce a new filter level 'wdir-independent-visible' to ensure we a good branchcache cache in .hg/cache that most share can use and that will be kept up to date. This also means we need to make sure it is warmed after transaction.

Needs some test updates.

Ah, a question: should this be lowercasing the first character of things? I think I copied this from somewhere where it did have an uppercase letter, but I wasn't consistent in my application of the leading uppercase letter.

In D6562#95775, @durin42 wrote:

I like this, but could I get you to add a patch 3 that introduces a develwarn for this?

Oops. A typo caused me to update this diff, please ignore that.

Oops. A typo caused me to update this diff, please ignore that.

I believe I've incorporated yuja's suggestions. Please take another look.

In D6168#89876, @martinvonz wrote:

Except that test-command-server.t fails like this:

@@ -776,11 +776,9 @@
   message: '\xa3DdataJpassword: Hpassword\xf5DtypeFprompt'
   1234
   *** runcommand debugprompt --config ui.interactive=True
-  message: '\xa3DdataGprompt:GdefaultAyDtypeFprompt'
-   5678
+  prompt: 5678
   *** runcommand debugpromptchoice --config ui.interactive=True
-  message: '\xa4Gchoices\x82\x82AyCYes\x82AnBNoDdataTpromptchoice (y/n)? GdefaultAyDtypeFprompt'
-   1
+  promptchoice (y/n)?  1
 bad message encoding:

@spectral, any idea how to fix?