User Details
- User Since
- Jun 29 2017, 4:34 PM (256 w, 6 h)
Thu, May 12
Wed, May 11
Apr 20 2022
Apr 19 2022
I'm not very tied to this, if someone thinks this makes it worse, feel free to reject.
Apr 14 2022
Apr 13 2022
Apr 8 2022
Apr 7 2022
Apr 6 2022
Apr 5 2022
Mar 15 2022
Mar 14 2022
Mar 10 2022
Feb 9 2022
This really feels like a bug that they're advertising support for xterm-compatible escape codes, and then not setting everything up to handle it properly, but for all I know it's not possible for them to do so (i.e. maybe Windows requires that each Process enable vtmode for every Console it cares about, it can't be done "for us" by these tools)
Dec 13 2021
Dec 7 2021
Should Flag negation be rare ?
I disagree here. We should use clearest available verb for flags, using negation to get the meaning we need. I would draw a similarity with boolean naming in the code, where we don't have a preferred "default" state for the common case, but we phrase the boolean in a way that is easy to read.
In addition, having a mix of negation and non-negation as common case will help make the (negation) feature more discoverable.
What's your rationale for wanting them to be rare ?
Nov 4 2021
Nov 3 2021
Oct 29 2021
Oct 28 2021
Oct 26 2021
Oct 24 2021
Oct 22 2021
Oct 21 2021
Oct 20 2021
I'm not sure the etiquette here; I'm accepting the revision since it obviously fixes a bug, but still would like the comments to be considered/responded to?
Oct 19 2021
Oct 18 2021
Oct 17 2021
Oct 15 2021
Looks good to me aside from the nit and the pulkit's comment. Not sure on etiquette here (whether I should mark as accepted or not), defaulting to not marking as accepted until all outstanding comments are addressed.