spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (46 w, 5 d)

Recent Activity

Today

spectral closed D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed.
Wed, May 23, 8:34 AM
spectral committed rHG2b8cb0ab231c: localrepo: add docstring to _makedirstate to make it less likely to be removed.
localrepo: add docstring to _makedirstate to make it less likely to be removed
Wed, May 23, 8:34 AM

Yesterday

spectral created D3647: prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable.
Tue, May 22, 6:38 PM
spectral created D3645: debian: skip using rust extensions for now since the debian rules aren't correct.
Tue, May 22, 6:38 PM
spectral added a dependent revision for D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list: D3647: prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable.
Tue, May 22, 6:38 PM
spectral created D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list.
Tue, May 22, 6:38 PM
spectral added a dependent revision for D3645: debian: skip using rust extensions for now since the debian rules aren't correct: D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list.
Tue, May 22, 6:38 PM
spectral created D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed.
Tue, May 22, 2:21 PM
spectral closed D3559: narrow: only wrap dirstate functions once, instead of per-reposetup.
Tue, May 22, 8:37 AM
spectral committed rHG1cba497491be: narrow: only wrap dirstate functions once, instead of per-reposetup.
narrow: only wrap dirstate functions once, instead of per-reposetup
Tue, May 22, 8:37 AM

Fri, May 18

spectral updated the diff for D3559: narrow: only wrap dirstate functions once, instead of per-reposetup.
Fri, May 18, 5:53 PM
spectral closed D3577: crecord: fallback to text mode if diffs are too big for curses mode.
Fri, May 18, 2:24 PM
spectral committed rHGdabc2237963c: crecord: fallback to text mode if diffs are too big for curses mode.
crecord: fallback to text mode if diffs are too big for curses mode
Fri, May 18, 2:24 PM
spectral created D3577: crecord: fallback to text mode if diffs are too big for curses mode.
Fri, May 18, 2:12 AM

Thu, May 17

spectral committed rHGca890999d317: tests: test-parseindex.t works just fine with chg.
tests: test-parseindex.t works just fine with chg
Thu, May 17, 8:12 AM
spectral closed D3571: tests: test-parseindex.t works just fine with chg.
Thu, May 17, 8:12 AM

Wed, May 16

spectral created D3571: tests: test-parseindex.t works just fine with chg.
Wed, May 16, 6:48 PM
spectral closed D3562: tests: mark tests that fail when using chg as #require no-chg.
Wed, May 16, 8:09 AM
spectral committed rHG538e850ae737: tests: mark tests that fail when using chg as #require no-chg.
tests: mark tests that fail when using chg as #require no-chg
Wed, May 16, 8:08 AM

Tue, May 15

spectral created D3562: tests: mark tests that fail when using chg as #require no-chg.
Tue, May 15, 2:53 PM

Mon, May 14

spectral created D3559: narrow: only wrap dirstate functions once, instead of per-reposetup.
Mon, May 14, 6:53 PM

Apr 13 2018

spectral accepted D3323: py3: iterate over a copy of dict while changing it.
Apr 13 2018, 4:53 PM

Apr 12 2018

spectral added inline comments to D3212: patch: implement a new worddiff algorithm.
Apr 12 2018, 8:42 PM

Apr 10 2018

spectral updated subscribers of D3212: patch: implement a new worddiff algorithm.
Apr 10 2018, 3:39 PM

Apr 9 2018

spectral added inline comments to D3212: patch: implement a new worddiff algorithm.
Apr 9 2018, 9:03 PM
spectral added a comment to D3209: amend: exit 0 if there are no changes.
In D3209#51512, @quark wrote:

Returning 1 is actually more consistent with other core commands like pull, push, commit. See https://www.mercurial-scm.org/pipermail/mercurial-devel/2012-January/037711.html. Scripts should be updated to use $? explicitly.

Apr 9 2018, 8:20 PM
spectral created D3209: amend: exit 0 if there are no changes.
Apr 9 2018, 6:10 PM

Mar 30 2018

spectral committed rHG2208149c4b8e: extdiff: document that it copies modified files back to working directory.
extdiff: document that it copies modified files back to working directory
Mar 30 2018, 9:22 PM
spectral closed D2976: extdiff: document that it copies modified files back to working directory.
Mar 30 2018, 9:22 PM
spectral created D2976: extdiff: document that it copies modified files back to working directory.
Mar 30 2018, 3:17 PM

Mar 26 2018

spectral added inline comments to D2939: fsmonitor: layer on another hack in bser.c for os.stat() compat (issue5811).
Mar 26 2018, 2:42 PM

Mar 23 2018

spectral committed rHG08890706366e: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
copyfile: preserve stat info (mtime, etc.) when doing copies/renames
Mar 23 2018, 10:31 AM

Mar 22 2018

spectral closed D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
Mar 22 2018, 10:46 AM
spectral committed rHG1e30a26a65d0: filemerge: make the 'local' path match the format that 'base' and 'other' use.
filemerge: make the 'local' path match the format that 'base' and 'other' use
Mar 22 2018, 10:46 AM

Mar 21 2018

spectral abandoned D1721: debug: customizable timestamp when printing ui.debug text.
Mar 21 2018, 5:06 PM
spectral updated the diff for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 21 2018, 5:02 PM
spectral added a reviewer for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames: indygreg.

Greg has some concerns about this patch and it sounds like you will make some changes. The patch was queued by Augie, but I'm dropping it for now, so we don't have a slightly controversial patch written by a Googler queued by two other Googlers.

Mar 21 2018, 5:00 PM
spectral updated the diff for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 21 2018, 4:59 PM
spectral updated the diff for D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
Mar 21 2018, 4:48 PM

Mar 19 2018

spectral requested review of D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.

Ah, there's a "Request Review" that I'd never noticed before, choosing that to hopefully get this out of "Requires Revision"

Mar 19 2018, 2:22 PM
spectral updated the diff for D2888: filemerge: use a single temp dir instead of temp files.
Mar 19 2018, 2:18 PM
spectral added a comment to D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
In D2889#46482, @yuja wrote:

Not reviewed yet, but this can't be applied cleanly. Can you rebase?

Mar 19 2018, 2:18 PM
spectral updated the diff for D2887: filemerge: move temp file unlinks to _maketempfiles.
Mar 19 2018, 2:18 PM
spectral closed D2888: filemerge: use a single temp dir instead of temp files.
Mar 19 2018, 10:37 AM
spectral committed rHGe349ad5cbb71: filemerge: use a single temp dir instead of temp files.
filemerge: use a single temp dir instead of temp files
Mar 19 2018, 10:37 AM
spectral committed rHG3723b42ff953: filemerge: move temp file unlinks to _maketempfiles.
filemerge: move temp file unlinks to _maketempfiles
Mar 19 2018, 10:37 AM
spectral closed D2887: filemerge: move temp file unlinks to _maketempfiles.
Mar 19 2018, 10:37 AM

Mar 17 2018

spectral committed rHGa4a95bd7158d: filemerge: give some variables in _xmerge more descriptive names.
filemerge: give some variables in _xmerge more descriptive names
Mar 17 2018, 3:08 PM
spectral closed D2886: filemerge: give some variables in _xmerge more descriptive names.
Mar 17 2018, 3:08 PM

Mar 16 2018

spectral created D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
Mar 16 2018, 8:01 PM
spectral created D2888: filemerge: use a single temp dir instead of temp files.
Mar 16 2018, 8:01 PM
spectral added a dependent revision for D2888: filemerge: use a single temp dir instead of temp files: D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
Mar 16 2018, 8:01 PM
spectral created D2887: filemerge: move temp file unlinks to _maketempfiles.
Mar 16 2018, 8:01 PM
spectral added a dependent revision for D2887: filemerge: move temp file unlinks to _maketempfiles: D2888: filemerge: use a single temp dir instead of temp files.
Mar 16 2018, 8:00 PM
spectral added a dependent revision for D2886: filemerge: give some variables in _xmerge more descriptive names: D2887: filemerge: move temp file unlinks to _maketempfiles.
Mar 16 2018, 8:00 PM
spectral created D2886: filemerge: give some variables in _xmerge more descriptive names.
Mar 16 2018, 8:00 PM

Mar 13 2018

spectral added a comment to D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.

I'm sorry, but we cannot ship this as is.

The reason is mtime based build systems, like GNU make.

We can't have version control modifying files without bumping their mtime because this invalidates the target freshness checks of mtime-based build systems.

Mar 13 2018, 3:59 PM

Mar 12 2018

spectral added a comment to D2678: help: supporting both help and doc for aliases.

Ugh:

--- /home/augie/hg/tests/test-alias.t
+++ /home/augie/hg/tests/test-alias.t.err
@@ -357,15 +357,8 @@
 properly recursive

   $ hg dln
-  changeset:   -1:0000000000000000000000000000000000000000
-  phase:       public
-  parent:      -1:0000000000000000000000000000000000000000
-  parent:      -1:0000000000000000000000000000000000000000
-  manifest:    -1:0000000000000000000000000000000000000000
-  user:
-  date:        Thu Jan 01 00:00:00 1970 +0000
-  extra:       branch=default
-
+  abort: alias 'dln' resolves to unknown command 'lognull'
+  [255]
Mar 12 2018, 9:30 PM
spectral updated the diff for D2678: help: supporting both help and doc for aliases.
Mar 12 2018, 9:21 PM
spectral closed D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 12 2018, 6:17 PM
spectral committed rHG9e460318ca4b: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
copyfile: preserve stat info (mtime, etc.) when doing copies/renames
Mar 12 2018, 6:16 PM
spectral updated the diff for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 12 2018, 5:58 PM
spectral added a comment to D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.

Neat, didn't know about the inline python stuff. That's much nicer.

Mar 12 2018, 5:53 PM
spectral updated the diff for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 12 2018, 5:52 PM

Mar 8 2018

spectral created D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 8 2018, 6:30 PM

Mar 6 2018

spectral added a comment to D2013: commit: allow --no-secret to override phases.new-commit setting.

@spectral: what's the state of this series? Do you plan to submit a follow-up?

I think he's waiting for me to hopefully do it in a more generic way. I have been working on that. Turned out that in order to create a generic utility for moving phase, bookmarks, obsmarkers, we needed to be able to do that during interrupted rebase/histedit. So I'm first making rebase and histedit incrementally move bookmarks and add obsmarkers. I've been making good progress on that and can hopefully have a series out in a day or two (been blocked by other stuff).

If you get tired of waiting, I'm perfectly fine with getting this series in in some form first. I think it would be good to do that without the --no-secret since I found it a little odd. Perhaps just make it experimental?

Mar 6 2018, 8:18 PM
spectral added a comment to D2678: help: supporting both help and doc for aliases.

(I'm stepping in and responding while rdamazio is out for a few days)

Mar 6 2018, 3:53 PM

Mar 4 2018

spectral abandoned D2662: hghave: do not assign "ex" to a variable (pyflakes).
Mar 4 2018, 2:19 PM
spectral created D2662: hghave: do not assign "ex" to a variable (pyflakes).
Mar 4 2018, 1:24 PM
spectral closed D2641: docs: small fixes for profiling.nested and the overall description.
Mar 4 2018, 11:48 AM
spectral committed rHG0c431d3129c4: docs: small fixes for profiling.nested and the overall description.
docs: small fixes for profiling.nested and the overall description
Mar 4 2018, 11:48 AM
spectral created D2641: docs: small fixes for profiling.nested and the overall description.
Mar 4 2018, 11:41 AM

Feb 16 2018

spectral committed rHG564dec70b50c: debugcommands: print out the editor that was searched for (post shlexsplit).
debugcommands: print out the editor that was searched for (post shlexsplit)
Feb 16 2018, 5:25 PM
spectral closed D1808: debugcommands: print out the editor that was searched for (post shlexsplit).
Feb 16 2018, 4:52 PM
spectral committed rHG04e81ae47066: debugcommands: print out the editor that was searched for (post shlexsplit).
debugcommands: print out the editor that was searched for (post shlexsplit)
Feb 16 2018, 4:52 PM

Feb 6 2018

spectral added a comment to D1808: debugcommands: print out the editor that was searched for (post shlexsplit).

Sorry, I forgot about this, can you take another look? I believe I addressed your most recent comment.

Feb 6 2018, 1:23 PM

Feb 5 2018

spectral added a comment to D2013: commit: allow --no-secret to override phases.new-commit setting.

I wonder if we should instead have a --draft option for this. Reasons:

  • If we ever add a fourth phase (like Jun's proposed "archived" phase), then --no-secret doesn't clearly indicate "draft", it could just as well be "archived".
  • Actually, we of course already do have a third phase. One could imagine a "hg commit --public", although that's probably not useful enough to warrant its own option, but it seems to suggest that "--no-secret" doesn't necessarily mean "draft".
  • I find this tri-state boolean weird. "--secret" kind of defaults to off, but it can be made "more off" with "--no-secret".
Feb 5 2018, 3:59 PM

Feb 3 2018

spectral closed D2011: filemerge: support passing labels to external merge tools.
Feb 3 2018, 9:49 PM
spectral committed rHGa9802c9ecfb5: merge: use operation-provided labels (ex: dest/source) in several merge-tools.
merge: use operation-provided labels (ex: dest/source) in several merge-tools
Feb 3 2018, 9:49 PM
spectral closed D2012: merge: use operation-provided labels (ex: dest/source) in several merge-tools.
Feb 3 2018, 9:49 PM
spectral committed rHG9037c29e9f53: filemerge: support passing labels to external merge tools.
filemerge: support passing labels to external merge tools
Feb 3 2018, 9:49 PM

Feb 2 2018

spectral created D2013: commit: allow --no-secret to override phases.new-commit setting.
Feb 2 2018, 6:40 PM
spectral created D2014: amend: --no-secret overrides phases.new-commit and previous phase.
Feb 2 2018, 6:40 PM
spectral created D2017: split: accept a --secret flag to force phase of new commits.
Feb 2 2018, 6:40 PM
spectral created D2016: split: preserve phase of commit that is being split.
Feb 2 2018, 6:40 PM
spectral added a dependent revision for D2016: split: preserve phase of commit that is being split: D2017: split: accept a --secret flag to force phase of new commits.
Feb 2 2018, 6:40 PM
spectral added a dependent revision for D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use: D2016: split: preserve phase of commit that is being split.
Feb 2 2018, 6:40 PM
spectral created D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use.
Feb 2 2018, 6:40 PM
spectral added a dependent revision for D2014: amend: --no-secret overrides phases.new-commit and previous phase: D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use.
Feb 2 2018, 6:40 PM
spectral added a dependent revision for D2013: commit: allow --no-secret to override phases.new-commit setting: D2014: amend: --no-secret overrides phases.new-commit and previous phase.
Feb 2 2018, 6:40 PM
spectral created D2011: filemerge: support passing labels to external merge tools.
Feb 2 2018, 5:10 PM
spectral created D2012: merge: use operation-provided labels (ex: dest/source) in several merge-tools.
Feb 2 2018, 5:10 PM
spectral added a dependent revision for D2011: filemerge: support passing labels to external merge tools: D2012: merge: use operation-provided labels (ex: dest/source) in several merge-tools.
Feb 2 2018, 5:10 PM

Jan 22 2018

spectral accepted D1935: tests: update test to work with Git 2.16.

I've also been seeing these failures, thanks!

Jan 22 2018, 3:46 PM

Jan 17 2018

spectral created D1878: chistedit: make command's help text match hg style.
Jan 17 2018, 5:22 PM

Jan 10 2018

spectral accepted D1842: tests: update test-rebase expected output.
Jan 10 2018, 7:18 PM

Jan 5 2018

spectral added inline comments to D1808: debugcommands: print out the editor that was searched for (post shlexsplit).
Jan 5 2018, 2:39 PM
spectral updated the diff for D1808: debugcommands: print out the editor that was searched for (post shlexsplit).
Jan 5 2018, 2:38 PM

Jan 4 2018

spectral committed rHG711149d8e676: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo.
tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo
Jan 4 2018, 10:48 PM
spectral closed D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo.
Jan 4 2018, 10:48 PM