spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (81 w, 3 d)

Recent Activity

Thu, Jan 17

spectral closed D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Thu, Jan 17, 8:43 AM
spectral committed rHG183df3df6031: resolve: fix mark-check when a file was deleted on one side (issue6020).
resolve: fix mark-check when a file was deleted on one side (issue6020)
Thu, Jan 17, 8:42 AM

Wed, Jan 16

spectral updated the diff for D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Wed, Jan 16, 3:50 PM
spectral added a comment to D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).

Alright that test seems a bit ridiculous now that I'm looking at it in the diff, but it's at least thorough? :)

Wed, Jan 16, 3:50 PM

Tue, Jan 15

spectral closed D5591: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
Tue, Jan 15, 6:57 PM
spectral committed rHGb129837190f7: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
context: use scmutil.matchfiles instead of matchmod.match(exact=True)
Tue, Jan 15, 6:57 PM
spectral added a comment to D5532: context: schedule file prefetch before comparing for cleanliness.
In D5532#82319, @yuja wrote:

+ scmutil.prefetchfiles(
+ self.repo(), [self.p1().rev()],
+ matchmod.match('', '', patterns=self._cache.keys(), exact=True))

Perhaps scmutil.matchfiles() can be used instead of the low-level constructor.

Tue, Jan 15, 6:47 PM
spectral created D5591: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
Tue, Jan 15, 6:47 PM

Sat, Jan 12

spectral closed D5569: tests: make HGCATAPULTSERVERPIPE imply HGTESTCATAPULTSERVERPIPE.
Sat, Jan 12, 9:08 PM
spectral committed rHG4f0ae5c64c1b: tests: make HGCATAPULTSERVERPIPE imply HGTESTCATAPULTSERVERPIPE.
tests: make HGCATAPULTSERVERPIPE imply HGTESTCATAPULTSERVERPIPE
Sat, Jan 12, 9:08 PM

Fri, Jan 11

spectral closed D5572: histedit: add newline after ui.log "# acttions to histedit" message.
Fri, Jan 11, 3:54 PM
spectral committed rHG99125b7fb93e: histedit: add newline after ui.log "# acttions to histedit" message.
histedit: add newline after ui.log "# acttions to histedit" message
Fri, Jan 11, 3:54 PM
spectral created D5572: histedit: add newline after ui.log "# acttions to histedit" message.
Fri, Jan 11, 3:45 PM

Thu, Jan 10

spectral created D5569: tests: make HGCATAPULTSERVERPIPE imply HGTESTCATAPULTSERVERPIPE.
Thu, Jan 10, 10:29 PM

Wed, Jan 9

spectral closed D5532: context: schedule file prefetch before comparing for cleanliness.
Wed, Jan 9, 3:11 PM
spectral committed rHGf18f665b1424: context: schedule file prefetch before comparing for cleanliness.
context: schedule file prefetch before comparing for cleanliness
Wed, Jan 9, 3:10 PM
spectral committed rHG92a5fb73b3d5: remotefilelog: add newlines to ui.log() invocations.
remotefilelog: add newlines to ui.log() invocations
Wed, Jan 9, 9:08 AM
spectral closed D5533: remotefilelog: add newlines to ui.log() invocations.
Wed, Jan 9, 9:08 AM
spectral closed D5535: tests: support passing testcase after .t paths that have path separators.
Wed, Jan 9, 1:06 AM
spectral committed rHG8ddc5d8bea25: tests: support passing testcase after .t paths that have path separators.
tests: support passing testcase after .t paths that have path separators
Wed, Jan 9, 1:06 AM

Tue, Jan 8

spectral created D5535: tests: support passing testcase after .t paths that have path separators.
Tue, Jan 8, 9:49 PM
spectral created D5533: remotefilelog: add newlines to ui.log() invocations.
Tue, Jan 8, 5:51 PM
spectral created D5532: context: schedule file prefetch before comparing for cleanliness.
Tue, Jan 8, 5:34 PM

Sun, Dec 30

spectral closed D5488: typos: correct spelling of uninterruptable -> uninterruptible.
Sun, Dec 30, 3:34 AM
spectral committed rHG517a51d9cd7f: remotefilelog: fix bug in maybesparsematch returning alwaysmatcher.
remotefilelog: fix bug in maybesparsematch returning alwaysmatcher
Sun, Dec 30, 3:33 AM
spectral closed D5487: remotefilelog: fix bug in maybesparsematch returning alwaysmatcher.
Sun, Dec 30, 3:33 AM
spectral committed rHG8ecb17b7f432: procutil: correct spelling of uninterruptable -> uninterruptible.
procutil: correct spelling of uninterruptable -> uninterruptible
Sun, Dec 30, 3:33 AM

Fri, Dec 28

spectral created D5488: typos: correct spelling of uninterruptable -> uninterruptible.
Fri, Dec 28, 4:22 PM

Thu, Dec 27

spectral created D5487: remotefilelog: fix bug in maybesparsematch returning alwaysmatcher.
Thu, Dec 27, 7:15 PM

Nov 17 2018

spectral closed D5280: changegroup: avoid instantiating storage if we are not using it.
Nov 17 2018, 1:12 AM
spectral committed rHGdba590f27c7a: changegroup: avoid instantiating storage if we are not using it.
changegroup: avoid instantiating storage if we are not using it
Nov 17 2018, 1:12 AM

Nov 16 2018

spectral committed rHGea84c2b286a2: rebase: fix two ui.logs to actually have text when using default blackbox log.
rebase: fix two ui.logs to actually have text when using default blackbox log
Nov 16 2018, 8:58 AM
spectral closed D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.
Nov 16 2018, 7:59 AM
spectral committed rHG7ce3662bf1bc: rebase: fix two ui.logs to actually have text when using default blackbox log.
rebase: fix two ui.logs to actually have text when using default blackbox log
Nov 16 2018, 7:59 AM

Nov 15 2018

spectral created D5280: changegroup: avoid instantiating storage if we are not using it.
Nov 15 2018, 5:40 PM
spectral created D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.
Nov 15 2018, 5:36 PM

Nov 14 2018

spectral closed D5268: shelve: use matcher to restrict prefetch to just the modified files.
Nov 14 2018, 8:02 AM
spectral committed rHG29e4a77b5305: shelve: use matcher to restrict prefetch to just the modified files.
shelve: use matcher to restrict prefetch to just the modified files
Nov 14 2018, 8:02 AM

Nov 13 2018

spectral planned changes to D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).

(not sure when I'll get to the changes, but removing from Needs Review, sorry I delayed so long doing that)

Nov 13 2018, 9:23 PM
spectral created D5268: shelve: use matcher to restrict prefetch to just the modified files.
Nov 13 2018, 9:09 PM

Nov 8 2018

spectral closed D5242: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc.
Nov 8 2018, 6:54 AM
spectral committed rHGb93157f69f46: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc.
tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc
Nov 8 2018, 6:54 AM
spectral closed D5241: tests: fix a couple typos in test-resolve.t comments and add a comment.
Nov 8 2018, 6:54 AM
spectral committed rHG8785d66edd6e: tests: fix a couple typos in test-resolve.t comments and add a comment.
tests: fix a couple typos in test-resolve.t comments and add a comment
Nov 8 2018, 6:54 AM

Nov 7 2018

spectral created D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Nov 7 2018, 6:46 PM
spectral created D5242: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc.
Nov 7 2018, 6:45 PM
spectral added a dependent revision for D5242: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc: D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Nov 7 2018, 6:45 PM
spectral created D5241: tests: fix a couple typos in test-resolve.t comments and add a comment.
Nov 7 2018, 6:45 PM
spectral added a dependent revision for D5241: tests: fix a couple typos in test-resolve.t comments and add a comment: D5242: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc.
Nov 7 2018, 6:45 PM

Nov 5 2018

spectral closed D5225: tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken.
Nov 5 2018, 8:47 PM
spectral committed rHG8239d4e5d05f: tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken.
tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken
Nov 5 2018, 8:47 PM
spectral added a comment to D5225: tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken.

(Please queue this on stable, thanks!)

Nov 5 2018, 6:18 PM
spectral created D5225: tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken.
Nov 5 2018, 6:17 PM
spectral closed D5217: catapult: add a bit more documentation on how to use catapult tracing.
Nov 5 2018, 11:07 AM
spectral closed D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing.
Nov 5 2018, 11:07 AM
spectral closed D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state.
Nov 5 2018, 11:07 AM
spectral committed rHGc311424ea579: catapult: add a bit more documentation on how to use catapult tracing.
catapult: add a bit more documentation on how to use catapult tracing
Nov 5 2018, 11:07 AM
spectral closed D5214: catapult: fix broken run-tests catapult tracing.
Nov 5 2018, 11:07 AM
spectral committed rHG889424be7ad2: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing.
catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing
Nov 5 2018, 11:07 AM
spectral committed rHGa9e00c48c5ef: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state.
catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state
Nov 5 2018, 11:07 AM
spectral committed rHGd95358143ce6: catapult: fix broken run-tests catapult tracing.
catapult: fix broken run-tests catapult tracing
Nov 5 2018, 11:07 AM

Nov 3 2018

spectral closed D5218: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.
Nov 3 2018, 10:18 PM
spectral committed rHGda2e874fe582: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.
resolve: when resolve.mark-check=abort, downgrade to warning if pats specified
Nov 3 2018, 10:18 PM

Nov 2 2018

spectral closed D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
Nov 2 2018, 9:44 PM
spectral committed rHG86dfae98a3a2: merge-tools: when calling external merge tool, describe the resolve inputs.
merge-tools: when calling external merge tool, describe the resolve inputs
Nov 2 2018, 9:44 PM
spectral added a comment to D5218: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.

Note: This is meant for 'stable'

Nov 2 2018, 3:04 PM
spectral created D5218: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.
Nov 2 2018, 3:03 PM

Nov 1 2018

spectral created D5217: catapult: add a bit more documentation on how to use catapult tracing.
Nov 1 2018, 8:26 PM
spectral created D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing.
Nov 1 2018, 8:26 PM
spectral created D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state.
Nov 1 2018, 8:26 PM
spectral created D5214: catapult: fix broken run-tests catapult tracing.
Nov 1 2018, 8:26 PM
spectral added a dependent revision for D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing: D5217: catapult: add a bit more documentation on how to use catapult tracing.
Nov 1 2018, 8:26 PM
spectral added a dependent revision for D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state: D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing.
Nov 1 2018, 8:26 PM
spectral added a dependent revision for D5214: catapult: fix broken run-tests catapult tracing: D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state.
Nov 1 2018, 8:26 PM
spectral added a comment to D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
In D5094#77146, @yuja wrote:
> We might want to structure these variables as `base.node|short` instead of
>  `base_node` for example, but that would require more work.

[...]

Unfortunately, this doesn't work super well, when using the following flags:

There isn't a building block for a mapping dict holding mapping dicts, and
the formatter API doesn't support such structure either.

Fortunately, we don't need a formatter here since we just want to apply
a template to a single item. So if we had a wrapper for a single mapping
dict, the templater can be rendered as follows:

props = {
    'base': templateutil.mappingdict({'ctx': fca.changectx(), 'fctx': fca,
                                      'label': baselabel})
    ...
}
cmdutil.rendertemplate(fcd.changectx(), tmpl, props)

And base.path, base.node, etc. should just work.

Nov 1 2018, 7:02 PM
spectral updated the diff for D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
Nov 1 2018, 7:01 PM
spectral created D5211: templateutil: add mappingdict to handle dicts in template/formatter props.
Nov 1 2018, 7:01 PM

Oct 17 2018

spectral closed D5113: revisions: when using prefixhexnode, ensure we prefix "0".
Oct 17 2018, 7:50 PM
spectral committed rHGd916ed3ca951: revisions: when using prefixhexnode, ensure we prefix "0".
revisions: when using prefixhexnode, ensure we prefix "0"
Oct 17 2018, 7:50 PM
spectral planned changes to D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
In D5094#76457, @yuja wrote:

+def _describemerge(ui, repo, env, toolpath, args):
+ template = ui.config('ui', 'pre-merge-tool-output-template')
+ if not template:
+ return
+
+ # Remove HG_ prefix from entries in env and lowercase them
+ def sanitizeenv(k):
+ if k.startswith('HG_'):
+ return k[3:].lower()
+ return k

Nit: HG_FILE should be called as path per
https://www.mercurial-scm.org/wiki/GenericTemplatingPlan#Dictionary

Oct 17 2018, 11:16 AM

Oct 16 2018

spectral created D5113: revisions: when using prefixhexnode, ensure we prefix "0".
Oct 16 2018, 10:21 AM
spectral added a comment to D5102: beautifygraph: add configs for customizing the characters.

hooper and I talked at the sprint, and they wrote up the following for why they feel we should keep this out of graphmod/templatekw for now:

Oct 16 2018, 8:42 AM
spectral created D5112: graphmod: remove support for graph lines mixing parent/grandparent styles (BC).
Oct 16 2018, 8:42 AM

Oct 14 2018

spectral updated the diff for D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
Oct 14 2018, 5:25 AM
spectral created D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
Oct 14 2018, 5:16 AM

Oct 12 2018

spectral created D5019: pager: disable auto pager if we think it doesn't support F, R, X.
Oct 12 2018, 1:45 PM

Oct 4 2018

spectral closed D4875: treemanifests: remove _loadalllazy when doing copies.
Oct 4 2018, 8:31 AM
spectral closed D4874: treemanifests: store whether a lazydirs entry needs copied after materializing.
Oct 4 2018, 8:31 AM
spectral committed rHG67b93cd847fb: treemanifests: remove _loadalllazy when doing copies.
treemanifests: remove _loadalllazy when doing copies
Oct 4 2018, 8:31 AM
spectral committed rHGa0c18b271ea1: treemanifests: store whether a lazydirs entry needs copied after materializing.
treemanifests: store whether a lazydirs entry needs copied after materializing
Oct 4 2018, 8:31 AM
spectral closed D4873: treemanifests: extract _loaddifflazy from _diff, use in _filesnotin.
Oct 4 2018, 8:31 AM
spectral committed rHG906c95073ff7: treemanifests: extract _loaddifflazy from _diff, use in _filesnotin.
treemanifests: extract _loaddifflazy from _diff, use in _filesnotin
Oct 4 2018, 8:31 AM

Oct 3 2018

spectral created D4875: treemanifests: remove _loadalllazy when doing copies.
Oct 3 2018, 6:22 PM
spectral created D4874: treemanifests: store whether a lazydirs entry needs copied after materializing.
Oct 3 2018, 6:22 PM
spectral added a dependent revision for D4874: treemanifests: store whether a lazydirs entry needs copied after materializing: D4875: treemanifests: remove _loadalllazy when doing copies.
Oct 3 2018, 6:22 PM
spectral created D4873: treemanifests: extract _loaddifflazy from _diff, use in _filesnotin.
Oct 3 2018, 6:22 PM
spectral added a dependent revision for D4873: treemanifests: extract _loaddifflazy from _diff, use in _filesnotin: D4874: treemanifests: store whether a lazydirs entry needs copied after materializing.
Oct 3 2018, 6:22 PM

Oct 2 2018

spectral closed D4845: treemanifests: remove _loadalllazy in _diff().
Oct 2 2018, 7:12 PM
spectral closed D4844: treemanifests: skip extraneous check for item before calling _loadlazy.
Oct 2 2018, 7:12 PM
spectral committed rHG731961d972ba: treemanifests: remove _loadalllazy in _diff().
treemanifests: remove _loadalllazy in _diff()
Oct 2 2018, 7:12 PM