Page MenuHomePhabricator

spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (116 w, 1 d)

Recent Activity

Tue, Sep 17

spectral created D6867: transaction: detect an attempt to truncate-to-extend on playback, raise error.
Tue, Sep 17, 6:58 PM
spectral created D6866: osutil: tolerate Py_GetArgcArgv not being set up properly.
Tue, Sep 17, 6:58 PM
spectral created D6865: osutil: allow disabling setprocname via a define passed to the compiler.
Tue, Sep 17, 6:58 PM

Mon, Sep 9

spectral added a comment to D6789: check-code: allow command substitution with $(command).

This shouldn't be about the user's chosen shell, though, right? This is about the /bin/sh implementation, which you wouldn't/can't replace with fish, so I think it won't bother users that use fish, just distros with really old implementations of /bin/sh.

Mon, Sep 9, 3:19 PM

Thu, Sep 5

spectral added a comment to D6711: branchheads: store wdir-dependent caches in wcache (issue6181).

I'm not sure what the current state of this is, but I don't want it lingering in the review queue while I'm not actively working on it.

Thu, Sep 5, 3:06 PM
spectral closed D6768: split: handle partial commit of renames when doing split or record (issue5723).
Thu, Sep 5, 2:58 PM
spectral closed D6767: split: handle partial commit of copies when doing split or record.
Thu, Sep 5, 2:58 PM
spectral committed rHG3cf091843b4f: split: handle partial commit of renames when doing split or record (issue5723).
split: handle partial commit of renames when doing split or record (issue5723)
Thu, Sep 5, 2:58 PM
spectral committed rHG1fd530b1e1cf: split: handle partial commit of copies when doing split or record.
split: handle partial commit of copies when doing split or record
Thu, Sep 5, 2:57 PM

Tue, Aug 27

spectral created D6768: split: handle partial commit of renames when doing split or record (issue5723).
Tue, Aug 27, 3:46 PM
spectral created D6767: split: handle partial commit of copies when doing split or record.
Tue, Aug 27, 3:45 PM

Mon, Aug 26

spectral added a comment to D5786: blackbox: support blackbox.notrack regex patterns to exclude tracking events.

https://www.mercurial-scm.org/repo/hg/rev/56132ebd14c6 added blackbox.ignore, which is basically what this was doing.

Mon, Aug 26, 1:19 PM
spectral added a comment to D5785: blackbox: take regex patterns for blackbox.track.

https://www.mercurial-scm.org/repo/hg/rev/56132ebd14c6 Added blackbox.ignore, which is probably sufficient.

Mon, Aug 26, 1:19 PM

Aug 8 2019

spectral closed D6710: branchmap: explicitly warm+write all subsets of the branchmap caches.
Aug 8 2019, 6:19 PM
spectral committed rHGcdf0e9523de1: branchmap: explicitly warm+write all subsets of the branchmap caches.
branchmap: explicitly warm+write all subsets of the branchmap caches
Aug 8 2019, 6:18 PM

Aug 6 2019

spectral added a comment to D6710: branchmap: explicitly warm+write all subsets of the branchmap caches.

Forcing this write seems like a good idea. Having it in its own
changeset seems like a good idea (and please add a comment about forcing
the write).

Aug 6 2019, 9:07 PM

Aug 5 2019

spectral added a reviewer for D6719: branchmap: refresh all "heads" of the branchmap subsets: marmoute.

Adding marmoute as explicit reviewer.

Aug 5 2019, 9:13 PM
spectral added inline comments to D6710: branchmap: explicitly warm+write all subsets of the branchmap caches.
Aug 5 2019, 9:12 PM
spectral added a comment to D6711: branchheads: store wdir-dependent caches in wcache (issue6181).

The change looks good to me, However we probably want to introduce a new filter level 'wdir-independent-visible' to ensure we a good branchcache cache in .hg/cache that most share can use and that will be kept up to date. This also means we need to make sure it is warmed after transaction.

Aug 5 2019, 9:11 PM
spectral created D6719: branchmap: refresh all "heads" of the branchmap subsets.
Aug 5 2019, 9:10 PM
spectral retitled D6710: branchmap: explicitly warm+write all subsets of the branchmap caches from branchmap: properly refresh/warm all branchmap caches to branchmap: explicitly warm+write all subsets of the branchmap caches.
Aug 5 2019, 9:08 PM
spectral updated the diff for D6711: branchheads: store wdir-dependent caches in wcache (issue6181).
Aug 5 2019, 9:08 PM

Aug 2 2019

spectral added a comment to D6710: branchmap: explicitly warm+write all subsets of the branchmap caches.

Needs some test updates.

Aug 2 2019, 9:30 PM
spectral created D6710: branchmap: explicitly warm+write all subsets of the branchmap caches.
Aug 2 2019, 9:27 PM
spectral created D6711: branchheads: store wdir-dependent caches in wcache (issue6181).
Aug 2 2019, 9:27 PM

Jul 10 2019

spectral abandoned D6573: prompt: add develwarn about last line of prompt >45 chars (issue6158).
Jul 10 2019, 3:44 PM
spectral closed D6572: subrepos: make last line of prompts <40 english chars (issue6158).
Jul 10 2019, 3:40 PM
spectral closed D6571: largefiles: make last line of prompts <40 english chars (issue6158).
Jul 10 2019, 3:39 PM
spectral committed rHGf6540aba8e3e: subrepos: make last line of prompts <40 english chars (issue6158).
subrepos: make last line of prompts <40 english chars (issue6158)
Jul 10 2019, 3:38 PM
spectral committed rHG421fdf30c37c: largefiles: make last line of prompts <40 english chars (issue6158).
largefiles: make last line of prompts <40 english chars (issue6158)
Jul 10 2019, 3:38 PM

Jul 9 2019

spectral committed rHG9f73620a65fe: relnotes: document new range-select mechanism in crecord.
relnotes: document new range-select mechanism in crecord
Jul 9 2019, 5:44 AM
spectral closed D6622: relnotes: document new range-select mechanism in crecord.
Jul 9 2019, 5:44 AM

Jul 8 2019

spectral closed D6621: crecord: provide 'X' as a range-select mechanism.
Jul 8 2019, 6:04 PM
spectral closed D6620: crecord: make KEY_ENTER usable in tests (by not updating UI).
Jul 8 2019, 6:04 PM
spectral committed rHG9ac1a5a4a64f: crecord: provide 'X' as a range-select mechanism.
crecord: provide 'X' as a range-select mechanism
Jul 8 2019, 6:04 PM
spectral closed D6619: crecord: fix if -> elif when handling key presses.
Jul 8 2019, 6:04 PM
spectral committed rHGcd4f1b7c3192: crecord: make KEY_ENTER usable in tests (by not updating UI).
crecord: make KEY_ENTER usable in tests (by not updating UI)
Jul 8 2019, 6:04 PM
spectral closed D6618: crecord: add "x" alias for space, remove test-only "TOGGLE" alias.
Jul 8 2019, 6:04 PM
spectral committed rHG3be6ff55095b: crecord: fix if -> elif when handling key presses.
crecord: fix if -> elif when handling key presses
Jul 8 2019, 6:04 PM
spectral closed D6617: crecord: stop using test-only "X" as alternative for "c".
Jul 8 2019, 6:04 PM
spectral committed rHG75fd9421440b: crecord: add "x" alias for space, remove test-only "TOGGLE" alias.
crecord: add "x" alias for space, remove test-only "TOGGLE" alias
Jul 8 2019, 6:04 PM
spectral committed rHG756326d54761: crecord: stop using test-only "X" as alternative for "c".
crecord: stop using test-only "X" as alternative for "c"
Jul 8 2019, 6:03 PM
spectral created D6622: relnotes: document new range-select mechanism in crecord.
Jul 8 2019, 6:01 PM
spectral created D6621: crecord: provide 'X' as a range-select mechanism.
Jul 8 2019, 4:29 PM
spectral created D6620: crecord: make KEY_ENTER usable in tests (by not updating UI).
Jul 8 2019, 4:29 PM
spectral created D6618: crecord: add "x" alias for space, remove test-only "TOGGLE" alias.
Jul 8 2019, 4:29 PM
spectral created D6619: crecord: fix if -> elif when handling key presses.
Jul 8 2019, 4:29 PM
spectral created D6617: crecord: stop using test-only "X" as alternative for "c".
Jul 8 2019, 4:28 PM
spectral closed D6562: filemerge: make last line of prompts <40 english chars (issue6158).
Jul 8 2019, 1:08 PM
spectral closed D6563: patch: use a short, fixed-size message for last line of prompt (issue6158).
Jul 8 2019, 1:07 PM
spectral committed rHGf802a75da585: patch: use a short, fixed-size message for last line of prompt (issue6158).
patch: use a short, fixed-size message for last line of prompt (issue6158)
Jul 8 2019, 1:06 PM
spectral committed rHG4764e8436b2a: filemerge: make last line of prompts <40 english chars (issue6158).
filemerge: make last line of prompts <40 english chars (issue6158)
Jul 8 2019, 1:06 PM

Jun 27 2019

spectral committed rHG0c0e54bcea9b: zsh: enable completion support for chg as well.
zsh: enable completion support for chg as well
Jun 27 2019, 12:19 PM
spectral closed D6574: zsh: enable completion support for chg as well.
Jun 27 2019, 12:19 PM

Jun 25 2019

spectral created D6574: zsh: enable completion support for chg as well.
Jun 25 2019, 5:28 PM

Jun 24 2019

spectral added a comment to D6562: filemerge: make last line of prompts <40 english chars (issue6158).

Ah, a question: should this be lowercasing the first character of things? I think I copied this from somewhere where it did have an uppercase letter, but I wasn't consistent in my application of the leading uppercase letter.

Jun 24 2019, 7:31 PM
spectral added a comment to D6562: filemerge: make last line of prompts <40 english chars (issue6158).

I like this, but could I get you to add a patch 3 that introduces a develwarn for this?

Jun 24 2019, 7:30 PM
spectral created D6572: subrepos: make last line of prompts <40 english chars (issue6158).
Jun 24 2019, 7:28 PM
spectral created D6571: largefiles: make last line of prompts <40 english chars (issue6158).
Jun 24 2019, 7:28 PM
spectral created D6573: prompt: add develwarn about last line of prompt >45 chars (issue6158).
Jun 24 2019, 7:28 PM

Jun 20 2019

spectral created D6562: filemerge: make last line of prompts <40 english chars (issue6158).
Jun 20 2019, 6:10 PM
spectral created D6563: patch: use a short, fixed-size message for last line of prompt (issue6158).
Jun 20 2019, 6:10 PM

Jun 12 2019

spectral closed D6507: rebase: tweak description of inmemory working even w/ dirty working dir.
Jun 12 2019, 12:45 PM
spectral committed rHGcda591d2bfe1: rebase: tweak description of inmemory working even w/ dirty working dir.
rebase: tweak description of inmemory working even w/ dirty working dir
Jun 12 2019, 12:45 PM

Jun 10 2019

spectral created D6507: rebase: tweak description of inmemory working even w/ dirty working dir.
Jun 10 2019, 6:37 PM

May 30 2019

spectral closed D6464: commit: respect --no-edit in combination with --amend.
May 30 2019, 6:52 PM
spectral committed rHG64ed405dd342: commit: respect --no-edit in combination with --amend.
commit: respect --no-edit in combination with --amend
May 30 2019, 6:52 PM
spectral closed D6463: commit: add test showing that commit --amend --no-edit still shows editor.
May 30 2019, 6:52 PM
spectral committed rHG060ff3396589: commit: add test showing that commit --amend --no-edit still shows editor.
commit: add test showing that commit --amend --no-edit still shows editor
May 30 2019, 6:52 PM
spectral added a comment to D5772: hg: raise Abort on invalid path.

Oops. A typo caused me to update this diff, please ignore that.

May 30 2019, 5:22 PM
spectral added a comment to D5768: subrepo: bytes/str cleanups on Git support.

Oops. A typo caused me to update this diff, please ignore that.

May 30 2019, 5:20 PM
spectral created D6464: commit: respect --no-edit in combination with --amend.
May 30 2019, 5:17 PM
spectral updated the diff for D5772: hg: raise Abort on invalid path.
May 30 2019, 5:17 PM
spectral created D6463: commit: add test showing that commit --amend --no-edit still shows editor.
May 30 2019, 5:17 PM
spectral updated the diff for D5768: subrepo: bytes/str cleanups on Git support.
May 30 2019, 5:17 PM

May 29 2019

spectral closed D6452: tests: make run-tests exit non-zero if there are "errors".
May 29 2019, 8:55 AM
spectral committed rHG91452f62dd53: verify: use self._err not self.err, it changed in 7eaf4b1ac2a3.
verify: use self._err not self.err, it changed in 7eaf4b1ac2a3
May 29 2019, 8:54 AM
spectral committed rHG15d5a2de44aa: tests: make run-tests exit non-zero if there are "errors".
tests: make run-tests exit non-zero if there are "errors"
May 29 2019, 8:54 AM
spectral closed D6451: verify: use self._err not self.err, it changed in 7eaf4b1ac2a3.
May 29 2019, 8:54 AM
spectral created D6452: tests: make run-tests exit non-zero if there are "errors".
May 29 2019, 2:26 AM

May 28 2019

spectral created D6451: verify: use self._err not self.err, it changed in 7eaf4b1ac2a3.
May 28 2019, 7:27 PM

May 17 2019

spectral accepted D6407: relnotes: mention removed support for mixed log graph lines.
May 17 2019, 3:21 PM

May 16 2019

spectral committed rHG264a2cbb25d0: graphmod: remove support for graph lines mixing parent/grandparent styles (BC).
graphmod: remove support for graph lines mixing parent/grandparent styles (BC)
May 16 2019, 11:39 AM

May 15 2019

spectral closed D5112: graphmod: remove support for graph lines mixing parent/grandparent styles (BC).
May 15 2019, 2:31 PM
spectral committed rHG2e97640c598e: graphmod: remove support for graph lines mixing parent/grandparent styles (BC).
graphmod: remove support for graph lines mixing parent/grandparent styles (BC)
May 15 2019, 2:31 PM

Apr 15 2019

spectral closed D6168: readline: provide styled prompt to readline (issue6070).
Apr 15 2019, 7:41 PM
spectral committed rHG2d428b859282: readline: provide styled prompt to readline (issue6070).
readline: provide styled prompt to readline (issue6070)
Apr 15 2019, 7:41 PM
spectral added a comment to D6168: readline: provide styled prompt to readline (issue6070).

I believe I've incorporated yuja's suggestions. Please take another look.

Apr 15 2019, 5:37 PM
spectral updated the diff for D6168: readline: provide styled prompt to readline (issue6070).
Apr 15 2019, 5:34 PM
spectral updated the diff for D6168: readline: provide styled prompt to readline (issue6070).
Apr 15 2019, 5:33 PM
spectral updated the diff for D6168: readline: provide styled prompt to readline (issue6070).
Apr 15 2019, 5:31 PM

Mar 22 2019

spectral added a comment to D6168: readline: provide styled prompt to readline (issue6070).

Except that test-command-server.t fails like this:

@@ -776,11 +776,9 @@
   message: '\xa3DdataJpassword: Hpassword\xf5DtypeFprompt'
   1234
   *** runcommand debugprompt --config ui.interactive=True
-  message: '\xa3DdataGprompt:GdefaultAyDtypeFprompt'
-   5678
+  prompt: 5678
   *** runcommand debugpromptchoice --config ui.interactive=True
-  message: '\xa4Gchoices\x82\x82AyCYes\x82AnBNoDdataTpromptchoice (y/n)? GdefaultAyDtypeFprompt'
-   1
+  promptchoice (y/n)?  1
 bad message encoding:

@spectral, any idea how to fix?

Mar 22 2019, 3:40 PM

Mar 20 2019

spectral closed D6131: crecord: redraw the screen when starting up chunkselector.
Mar 20 2019, 2:08 PM
spectral closed D6129: crecord: completely redraw screen when coming back from editor.
Mar 20 2019, 2:08 PM
spectral closed D6130: crecord: redraw the screen on ctrl-L.
Mar 20 2019, 2:08 PM
spectral committed rHGcde5827d09a7: crecord: redraw the screen when starting up chunkselector.
crecord: redraw the screen when starting up chunkselector
Mar 20 2019, 2:08 PM
spectral committed rHGfa3b0ca9d74f: crecord: redraw the screen on ctrl-L.
crecord: redraw the screen on ctrl-L
Mar 20 2019, 2:08 PM
spectral committed rHG3f467db023a2: crecord: completely redraw screen when coming back from editor.
crecord: completely redraw screen when coming back from editor
Mar 20 2019, 2:08 PM

Mar 14 2019

spectral added inline comments to D6131: crecord: redraw the screen when starting up chunkselector.
Mar 14 2019, 1:57 AM
spectral updated the diff for D6131: crecord: redraw the screen when starting up chunkselector.
Mar 14 2019, 1:56 AM