Page MenuHomePhabricator

spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (185 w, 6 d)

Recent Activity

Tue, Jan 19

spectral accepted D9835: resolve: also detect new :mergediff conflict markers.
Tue, Jan 19, 6:57 PM
spectral added inline comments to D9835: resolve: also detect new :mergediff conflict markers.
Tue, Jan 19, 6:37 PM

Wed, Jan 13

spectral closed D9729: patch: handle filenames with trailing spaces.
Wed, Jan 13, 2:41 PM
spectral committed rHG416ecdaa12df: patch: handle filenames with trailing spaces.
patch: handle filenames with trailing spaces
Wed, Jan 13, 2:41 PM

Tue, Jan 12

spectral created D9729: patch: handle filenames with trailing spaces.
Tue, Jan 12, 1:34 PM

Dec 12 2020

spectral closed D9567: copies: make calculating lazy for dir move detection's "addedfiles".
Dec 12 2020, 2:56 AM
spectral committed rHG2f357d053df2: copies: make calculating lazy for dir move detection's "addedfiles".
copies: make calculating lazy for dir move detection's "addedfiles"
Dec 12 2020, 2:56 AM

Dec 11 2020

spectral created D9567: copies: make calculating lazy for dir move detection's "addedfiles".
Dec 11 2020, 5:04 PM

Dec 10 2020

spectral closed D9553: treemanifest: stop storing full path for each item in manifest._lazydirs.
Dec 10 2020, 4:42 AM
spectral committed rHG93e09d370003: treemanifest: stop storing full path for each item in manifest._lazydirs.
treemanifest: stop storing full path for each item in manifest._lazydirs
Dec 10 2020, 4:42 AM

Dec 9 2020

spectral added a comment to D9547: hghave: update the check for virtualenv.

Seems fine. ACTIVATE_SH is still in there on the version I have on my Debian Testing machine (15.1.0+ds-3 according to the dpkg system, 15.1.0 according to virtualenv.version). Not sure when it was removed, but it's not really relevant. :)

Dec 9 2020, 5:19 PM
spectral created D9553: treemanifest: stop storing full path for each item in manifest._lazydirs.
Dec 9 2020, 4:42 PM

Dec 3 2020

spectral closed D9511: statprof: separate functions and "line", assume 4 digit line numbers.
Dec 3 2020, 4:38 AM
spectral committed rHG8b0a3ff5ed12: statprof: separate functions and "line", assume 4 digit line numbers.
statprof: separate functions and "line", assume 4 digit line numbers
Dec 3 2020, 4:38 AM
spectral closed D9510: statprof: fix off-by-one-line error in output.
Dec 3 2020, 4:38 AM
spectral committed rHG068307b638f4: statprof: fix off-by-one-line error in output.
statprof: fix off-by-one-line error in output
Dec 3 2020, 4:38 AM
spectral closed D9503: copies: avoid materializing a full directory map during copy tracing.
Dec 3 2020, 4:37 AM
spectral committed rHGb9588ff9b66a: copies: avoid materializing a full directory map during copy tracing.
copies: avoid materializing a full directory map during copy tracing
Dec 3 2020, 4:37 AM

Dec 2 2020

spectral created D9511: statprof: separate functions and "line", assume 4 digit line numbers.
Dec 2 2020, 10:20 PM
spectral created D9510: statprof: fix off-by-one-line error in output.
Dec 2 2020, 10:20 PM
spectral updated the diff for D9503: copies: avoid materializing a full directory map during copy tracing.
Dec 2 2020, 2:49 PM
spectral created D9503: copies: avoid materializing a full directory map during copy tracing.
Dec 2 2020, 2:43 PM
spectral closed D9488: match: skip walking up the directory hierarchy if the number of pats are small.
Dec 2 2020, 3:04 AM
spectral committed rHGc4c7a6b61146: match: skip walking up the directory hierarchy if the number of pats are small.
match: skip walking up the directory hierarchy if the number of pats are small
Dec 2 2020, 3:04 AM

Dec 1 2020

spectral created D9488: match: skip walking up the directory hierarchy if the number of pats are small.
Dec 1 2020, 6:06 PM

Oct 15 2020

spectral closed D9207: record: when backing up, avoid generating very long filenames.
Oct 15 2020, 8:38 AM
spectral committed rHG9628d3cd9d13: record: when backing up, avoid generating very long filenames.
record: when backing up, avoid generating very long filenames
Oct 15 2020, 8:38 AM

Oct 14 2020

spectral created D9207: record: when backing up, avoid generating very long filenames.
Oct 14 2020, 6:12 PM

Sep 21 2020

spectral closed D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use.
Sep 21 2020, 4:27 PM
spectral committed rHG89f0d9f87701: branchmap: add a cache validation cache, avoid expensive re-hash on every use.
branchmap: add a cache validation cache, avoid expensive re-hash on every use
Sep 21 2020, 4:26 PM

Sep 16 2020

spectral updated the diff for D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use.
Sep 16 2020, 3:14 PM
spectral added a comment to D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use.

Did you measure the performance impact on other operation than your target operation ? I am curious about the impact of the @property here.

Sep 16 2020, 3:14 PM
spectral closed D9022: repo: avoid copying/updating a dict on every `repo.__getitem__`.
Sep 16 2020, 4:50 AM
spectral committed rHG4a0ccbecbaa6: repo: avoid copying/updating a dict on every `repo.__getitem__`.
repo: avoid copying/updating a dict on every `repo.__getitem__`
Sep 16 2020, 4:50 AM

Sep 15 2020

spectral created D9023: branchmap: add a cache validation cache, avoid expensive re-hash on every use.
Sep 15 2020, 6:49 PM
spectral created D9022: repo: avoid copying/updating a dict on every `repo.__getitem__`.
Sep 15 2020, 6:49 PM

Aug 8 2020

spectral closed D8813: tests: make test-install.t work on debian systems.
Aug 8 2020, 5:01 PM
spectral committed rHGd71693f799a0: tests: make test-install.t work on debian systems.
tests: make test-install.t work on debian systems
Aug 8 2020, 5:01 PM

Jul 29 2020

spectral added inline comments to D8733: overlayworkingctx: remove unused `nofilechanges()` and `_compact()` methods.
Jul 29 2020, 8:17 PM

Jul 25 2020

spectral closed D8814: tests: make check-py3-compat.py actually load the specified files correctly.
Jul 25 2020, 6:03 AM
spectral committed rHG4e5da64d5549: tests: make check-py3-compat.py actually load the specified files correctly.
tests: make check-py3-compat.py actually load the specified files correctly
Jul 25 2020, 6:03 AM
spectral committed rHG357d8415aa27: tests: virtualenv is only used on py2, rename and conditionalize.
tests: virtualenv is only used on py2, rename and conditionalize
Jul 25 2020, 6:03 AM
spectral committed rHGa253ded5b03d: morestatus: mention --stop even if not using --verbose.
morestatus: mention --stop even if not using --verbose
Jul 25 2020, 6:03 AM
spectral closed D8811: morestatus: mention --stop even if not using --verbose.
Jul 25 2020, 6:03 AM
spectral closed D8812: tests: virtualenv is only used on py2, rename and conditionalize.
Jul 25 2020, 6:02 AM

Jul 24 2020

spectral created D8814: tests: make check-py3-compat.py actually load the specified files correctly.
Jul 24 2020, 8:02 PM
spectral created D8813: tests: make test-install.t work on debian systems.
Jul 24 2020, 6:25 PM
spectral created D8812: tests: virtualenv is only used on py2, rename and conditionalize.
Jul 24 2020, 6:24 PM
spectral created D8811: morestatus: mention --stop even if not using --verbose.
Jul 24 2020, 6:22 PM

Jun 26 2020

spectral closed D8642: debian: support building a single deb for multiple py3 versions.
Jun 26 2020, 11:43 AM
spectral committed rHG36178b5c9aeb: debian: support building a single deb for multiple py3 versions.
debian: support building a single deb for multiple py3 versions
Jun 26 2020, 11:43 AM

Jun 19 2020

spectral created D8642: debian: support building a single deb for multiple py3 versions.
Jun 19 2020, 9:02 PM
spectral committed rHG1a4b9b602e54: py3: fix broken man page generation, it was generating `(default: NUL*)`.
py3: fix broken man page generation, it was generating `(default: NUL*)`
Jun 19 2020, 4:51 AM
spectral closed D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`.
Jun 19 2020, 4:51 AM

Jun 18 2020

spectral added inline comments to D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`.
Jun 18 2020, 1:51 PM
spectral updated the diff for D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`.
Jun 18 2020, 1:50 PM

Jun 17 2020

spectral created D8639: py3: fix broken man page generation, it was generating `(default: NUL*)`.
Jun 17 2020, 8:15 PM

May 7 2020

spectral closed D8464: locking: wait for locks in `hg cp` and `hg mv`.
May 7 2020, 2:21 PM
spectral committed rHGa9ff0742c8ea: locking: wait for locks in `hg cp` and `hg mv`.
locking: wait for locks in `hg cp` and `hg mv`
May 7 2020, 2:20 PM

Apr 21 2020

spectral created D8464: locking: wait for locks in `hg cp` and `hg mv`.
Apr 21 2020, 4:50 PM

Apr 7 2020

spectral committed rHG1756f75873bf: hgk: remove a "b" used on a kwargs expansion, the keys are strs.
hgk: remove a "b" used on a kwargs expansion, the keys are strs
Apr 7 2020, 6:25 AM
spectral closed D8385: hgk: remove a "b" used on a kwargs expansion, the keys are strs.
Apr 7 2020, 6:25 AM

Apr 6 2020

spectral created D8385: hgk: remove a "b" used on a kwargs expansion, the keys are strs.
Apr 6 2020, 6:21 PM

Apr 1 2020

spectral closed D8354: histedit: add missing b prefix to a string.
Apr 1 2020, 5:34 PM
spectral committed rHG8fca7e8449a8: histedit: add missing b prefix to a string.
histedit: add missing b prefix to a string
Apr 1 2020, 5:34 PM
spectral created D8354: histedit: add missing b prefix to a string.
Apr 1 2020, 5:26 PM

Mar 25 2020

spectral closed D8321: darwin: use vim, not vi, to avoid data-loss inducing posix behavior.
Mar 25 2020, 12:53 PM
spectral committed rHGc23877cb25a5: darwin: use vim, not vi, to avoid data-loss inducing posix behavior.
darwin: use vim, not vi, to avoid data-loss inducing posix behavior
Mar 25 2020, 12:53 PM

Mar 23 2020

spectral created D8321: darwin: use vim, not vi, to avoid data-loss inducing posix behavior.
Mar 23 2020, 6:13 PM

Mar 20 2020

spectral added a comment to D8281: narrow: escape includepats/excludepats when sending over the wire.
  • Server emits a new capability narrow-exp-1-escaped (in addition to the current narrow-exp-1, this is not replacing the existing capability)

nit: I *think* the "1" in the name was supposed to be a version number, so the new capability's name would be narrow-exp-2.

Mar 20 2020, 10:26 PM
spectral added a comment to D8281: narrow: escape includepats/excludepats when sending over the wire.

Since narrow is still experimental, I don't think we should try too hard for backward compatibility. We could introduce a new end-point for a new encoding and drop the old one in a couple of version.

+0, honestly. I won't require it, but I'd really rather we shaved this yak _now_ rather than when narrow has even more users.

Mar 20 2020, 7:09 PM

Mar 17 2020

spectral updated the diff for D8281: narrow: escape includepats/excludepats when sending over the wire.
Mar 17 2020, 5:59 PM
spectral updated the diff for D8281: narrow: escape includepats/excludepats when sending over the wire.
Mar 17 2020, 5:50 PM
spectral closed D8296: chistedit: support histedit.summary-template in curses histedit plan.
Mar 17 2020, 5:28 PM
spectral committed rHGad5a10f49dfa: chistedit: support histedit.summary-template in curses histedit plan.
chistedit: support histedit.summary-template in curses histedit plan
Mar 17 2020, 5:28 PM
spectral committed rHG77d48738b8e0: vfs: fix typo in comment (remove extra "l").
vfs: fix typo in comment (remove extra "l")
Mar 17 2020, 5:28 PM
spectral closed D8297: vfs: fix typo in comment (remove extra "l").
Mar 17 2020, 5:28 PM
spectral retitled D8281: narrow: escape includepats/excludepats when sending over the wire from narrow: escape includepats/excludepats when sending over the wire (BC) to narrow: escape includepats/excludepats when sending over the wire.
Mar 17 2020, 5:25 PM
spectral created D8297: vfs: fix typo in comment (remove extra "l").
Mar 17 2020, 4:16 PM
spectral created D8296: chistedit: support histedit.summary-template in curses histedit plan.
Mar 17 2020, 4:08 PM

Mar 16 2020

spectral committed rHG0af56d3ee24c: tests: make test-doctest.t automatically find files to run tests on.
tests: make test-doctest.t automatically find files to run tests on
Mar 16 2020, 11:22 PM
spectral closed D8294: tests: make test-doctest.t automatically find files to run tests on.
Mar 16 2020, 11:22 PM
spectral committed rHG529cb23155bc: tests: make test-doctest.t module list match reality.
tests: make test-doctest.t module list match reality
Mar 16 2020, 11:22 PM
spectral closed D8280: tests: make test-doctest.t module list match reality.
Mar 16 2020, 11:22 PM
spectral closed D8279: tests: remove doctest in narrowspec, it is broken.
Mar 16 2020, 11:22 PM
spectral committed rHG1922694d638f: tests: remove doctest in narrowspec, it is broken.
tests: remove doctest in narrowspec, it is broken
Mar 16 2020, 11:22 PM

Mar 13 2020

spectral added a comment to D8280: tests: make test-doctest.t module list match reality.

Should we try to move to some automatic detection of file with doctest? That would be more reliable.

Mar 13 2020, 10:32 PM
spectral updated the diff for D8281: narrow: escape includepats/excludepats when sending over the wire.
Mar 13 2020, 10:30 PM
spectral created D8294: tests: make test-doctest.t automatically find files to run tests on.
Mar 13 2020, 10:29 PM
spectral added a comment to D8281: narrow: escape includepats/excludepats when sending over the wire.

The Windows path changes seem like a good idea.
Would quoting paths with commas eliminate the need for custom escaping? I don't feel strongly about it, but custom escaping always feels weird to me. (I fact, a coworker did some homebrew escaping for CSV files a few days ago, but I forget how it ultimately ended up.)

Mar 13 2020, 1:29 AM
spectral updated the diff for D8281: narrow: escape includepats/excludepats when sending over the wire.
Mar 13 2020, 1:21 AM
spectral updated the diff for D8280: tests: make test-doctest.t module list match reality.
Mar 13 2020, 1:21 AM
spectral created D8281: narrow: escape includepats/excludepats when sending over the wire.
Mar 13 2020, 12:12 AM
spectral created D8280: tests: make test-doctest.t module list match reality.
Mar 13 2020, 12:12 AM
spectral created D8279: tests: remove doctest in narrowspec, it is broken.
Mar 13 2020, 12:12 AM

Feb 22 2020

spectral closed D8140: shelve: fix ordering of merge labels.
Feb 22 2020, 3:50 AM
spectral committed rHG69b091cdc506: shelve: fix ordering of merge labels.
shelve: fix ordering of merge labels
Feb 22 2020, 3:50 AM
spectral closed D8139: shelve: add test clearly demonstrating that the conflict labels are backwards.
Feb 22 2020, 3:50 AM
spectral committed rHG2527c10a2569: shelve: add test clearly demonstrating that the conflict labels are backwards.
shelve: add test clearly demonstrating that the conflict labels are backwards
Feb 22 2020, 3:50 AM

Feb 21 2020

spectral updated the diff for D8140: shelve: fix ordering of merge labels.
Feb 21 2020, 3:45 PM