spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (72 w, 3 d)

Recent Activity

Sat, Nov 17

spectral closed D5280: changegroup: avoid instantiating storage if we are not using it.
Sat, Nov 17, 1:12 AM
spectral committed rHGdba590f27c7a: changegroup: avoid instantiating storage if we are not using it.
changegroup: avoid instantiating storage if we are not using it
Sat, Nov 17, 1:12 AM

Fri, Nov 16

spectral committed rHGea84c2b286a2: rebase: fix two ui.logs to actually have text when using default blackbox log.
rebase: fix two ui.logs to actually have text when using default blackbox log
Fri, Nov 16, 8:58 AM
spectral closed D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.
Fri, Nov 16, 7:59 AM
spectral committed rHG7ce3662bf1bc: rebase: fix two ui.logs to actually have text when using default blackbox log.
rebase: fix two ui.logs to actually have text when using default blackbox log
Fri, Nov 16, 7:59 AM

Thu, Nov 15

spectral created D5280: changegroup: avoid instantiating storage if we are not using it.
Thu, Nov 15, 5:40 PM
spectral created D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.
Thu, Nov 15, 5:36 PM

Wed, Nov 14

spectral closed D5268: shelve: use matcher to restrict prefetch to just the modified files.
Wed, Nov 14, 8:02 AM
spectral committed rHG29e4a77b5305: shelve: use matcher to restrict prefetch to just the modified files.
shelve: use matcher to restrict prefetch to just the modified files
Wed, Nov 14, 8:02 AM

Tue, Nov 13

spectral planned changes to D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).

(not sure when I'll get to the changes, but removing from Needs Review, sorry I delayed so long doing that)

Tue, Nov 13, 9:23 PM
spectral created D5268: shelve: use matcher to restrict prefetch to just the modified files.
Tue, Nov 13, 9:09 PM

Thu, Nov 8

spectral closed D5242: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc.
Thu, Nov 8, 6:54 AM
spectral committed rHGb93157f69f46: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc.
tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc
Thu, Nov 8, 6:54 AM
spectral closed D5241: tests: fix a couple typos in test-resolve.t comments and add a comment.
Thu, Nov 8, 6:54 AM
spectral committed rHG8785d66edd6e: tests: fix a couple typos in test-resolve.t comments and add a comment.
tests: fix a couple typos in test-resolve.t comments and add a comment
Thu, Nov 8, 6:54 AM

Wed, Nov 7

spectral created D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Wed, Nov 7, 6:46 PM
spectral created D5242: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc.
Wed, Nov 7, 6:45 PM
spectral added a dependent revision for D5242: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc: D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Wed, Nov 7, 6:45 PM
spectral created D5241: tests: fix a couple typos in test-resolve.t comments and add a comment.
Wed, Nov 7, 6:45 PM
spectral added a dependent revision for D5241: tests: fix a couple typos in test-resolve.t comments and add a comment: D5242: tests: make the commands.resolve.confirm tests not pollute the test-wide hgrc.
Wed, Nov 7, 6:45 PM

Mon, Nov 5

spectral closed D5225: tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken.
Mon, Nov 5, 8:47 PM
spectral committed rHG8239d4e5d05f: tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken.
tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken
Mon, Nov 5, 8:47 PM
spectral added a comment to D5225: tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken.

(Please queue this on stable, thanks!)

Mon, Nov 5, 6:18 PM
spectral created D5225: tweakdefaults: remove commands.resolve.mark-check=abort, it is too broken.
Mon, Nov 5, 6:17 PM
spectral closed D5217: catapult: add a bit more documentation on how to use catapult tracing.
Mon, Nov 5, 11:07 AM
spectral closed D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing.
Mon, Nov 5, 11:07 AM
spectral closed D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state.
Mon, Nov 5, 11:07 AM
spectral committed rHGc311424ea579: catapult: add a bit more documentation on how to use catapult tracing.
catapult: add a bit more documentation on how to use catapult tracing
Mon, Nov 5, 11:07 AM
spectral closed D5214: catapult: fix broken run-tests catapult tracing.
Mon, Nov 5, 11:07 AM
spectral committed rHG889424be7ad2: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing.
catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing
Mon, Nov 5, 11:07 AM
spectral committed rHGa9e00c48c5ef: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state.
catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state
Mon, Nov 5, 11:07 AM
spectral committed rHGd95358143ce6: catapult: fix broken run-tests catapult tracing.
catapult: fix broken run-tests catapult tracing
Mon, Nov 5, 11:07 AM

Sat, Nov 3

spectral closed D5218: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.
Sat, Nov 3, 10:18 PM
spectral committed rHGda2e874fe582: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.
resolve: when resolve.mark-check=abort, downgrade to warning if pats specified
Sat, Nov 3, 10:18 PM

Fri, Nov 2

spectral closed D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
Fri, Nov 2, 9:44 PM
spectral committed rHG86dfae98a3a2: merge-tools: when calling external merge tool, describe the resolve inputs.
merge-tools: when calling external merge tool, describe the resolve inputs
Fri, Nov 2, 9:44 PM
spectral added a comment to D5218: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.

Note: This is meant for 'stable'

Fri, Nov 2, 3:04 PM
spectral created D5218: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.
Fri, Nov 2, 3:03 PM

Thu, Nov 1

spectral created D5217: catapult: add a bit more documentation on how to use catapult tracing.
Thu, Nov 1, 8:26 PM
spectral created D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing.
Thu, Nov 1, 8:26 PM
spectral created D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state.
Thu, Nov 1, 8:26 PM
spectral created D5214: catapult: fix broken run-tests catapult tracing.
Thu, Nov 1, 8:26 PM
spectral added a dependent revision for D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing: D5217: catapult: add a bit more documentation on how to use catapult tracing.
Thu, Nov 1, 8:26 PM
spectral added a dependent revision for D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state: D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing.
Thu, Nov 1, 8:26 PM
spectral added a dependent revision for D5214: catapult: fix broken run-tests catapult tracing: D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state.
Thu, Nov 1, 8:26 PM
spectral added a comment to D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
In D5094#77146, @yuja wrote:
> We might want to structure these variables as `base.node|short` instead of
>  `base_node` for example, but that would require more work.

[...]

Unfortunately, this doesn't work super well, when using the following flags:

There isn't a building block for a mapping dict holding mapping dicts, and
the formatter API doesn't support such structure either.

Fortunately, we don't need a formatter here since we just want to apply
a template to a single item. So if we had a wrapper for a single mapping
dict, the templater can be rendered as follows:

props = {
    'base': templateutil.mappingdict({'ctx': fca.changectx(), 'fctx': fca,
                                      'label': baselabel})
    ...
}
cmdutil.rendertemplate(fcd.changectx(), tmpl, props)

And base.path, base.node, etc. should just work.

Thu, Nov 1, 7:02 PM
spectral updated the diff for D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
Thu, Nov 1, 7:01 PM
spectral created D5211: templateutil: add mappingdict to handle dicts in template/formatter props.
Thu, Nov 1, 7:01 PM

Oct 17 2018

spectral closed D5113: revisions: when using prefixhexnode, ensure we prefix "0".
Oct 17 2018, 7:50 PM
spectral committed rHGd916ed3ca951: revisions: when using prefixhexnode, ensure we prefix "0".
revisions: when using prefixhexnode, ensure we prefix "0"
Oct 17 2018, 7:50 PM
spectral planned changes to D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
In D5094#76457, @yuja wrote:

+def _describemerge(ui, repo, env, toolpath, args):
+ template = ui.config('ui', 'pre-merge-tool-output-template')
+ if not template:
+ return
+
+ # Remove HG_ prefix from entries in env and lowercase them
+ def sanitizeenv(k):
+ if k.startswith('HG_'):
+ return k[3:].lower()
+ return k

Nit: HG_FILE should be called as path per
https://www.mercurial-scm.org/wiki/GenericTemplatingPlan#Dictionary

Oct 17 2018, 11:16 AM

Oct 16 2018

spectral created D5113: revisions: when using prefixhexnode, ensure we prefix "0".
Oct 16 2018, 10:21 AM
spectral added a comment to D5102: beautifygraph: add configs for customizing the characters.

hooper and I talked at the sprint, and they wrote up the following for why they feel we should keep this out of graphmod/templatekw for now:

Oct 16 2018, 8:42 AM
spectral created D5112: graphmod: remove support for graph lines mixing parent/grandparent styles (BC).
Oct 16 2018, 8:42 AM

Oct 14 2018

spectral updated the diff for D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
Oct 14 2018, 5:25 AM
spectral created D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
Oct 14 2018, 5:16 AM

Oct 12 2018

spectral created D5019: pager: disable auto pager if we think it doesn't support F, R, X.
Oct 12 2018, 1:45 PM

Oct 4 2018

spectral closed D4875: treemanifests: remove _loadalllazy when doing copies.
Oct 4 2018, 8:31 AM
spectral closed D4874: treemanifests: store whether a lazydirs entry needs copied after materializing.
Oct 4 2018, 8:31 AM
spectral committed rHG67b93cd847fb: treemanifests: remove _loadalllazy when doing copies.
treemanifests: remove _loadalllazy when doing copies
Oct 4 2018, 8:31 AM
spectral committed rHGa0c18b271ea1: treemanifests: store whether a lazydirs entry needs copied after materializing.
treemanifests: store whether a lazydirs entry needs copied after materializing
Oct 4 2018, 8:31 AM
spectral closed D4873: treemanifests: extract _loaddifflazy from _diff, use in _filesnotin.
Oct 4 2018, 8:31 AM
spectral committed rHG906c95073ff7: treemanifests: extract _loaddifflazy from _diff, use in _filesnotin.
treemanifests: extract _loaddifflazy from _diff, use in _filesnotin
Oct 4 2018, 8:31 AM

Oct 3 2018

spectral created D4875: treemanifests: remove _loadalllazy when doing copies.
Oct 3 2018, 6:22 PM
spectral created D4874: treemanifests: store whether a lazydirs entry needs copied after materializing.
Oct 3 2018, 6:22 PM
spectral added a dependent revision for D4874: treemanifests: store whether a lazydirs entry needs copied after materializing: D4875: treemanifests: remove _loadalllazy when doing copies.
Oct 3 2018, 6:22 PM
spectral created D4873: treemanifests: extract _loaddifflazy from _diff, use in _filesnotin.
Oct 3 2018, 6:22 PM
spectral added a dependent revision for D4873: treemanifests: extract _loaddifflazy from _diff, use in _filesnotin: D4874: treemanifests: store whether a lazydirs entry needs copied after materializing.
Oct 3 2018, 6:22 PM

Oct 2 2018

spectral closed D4845: treemanifests: remove _loadalllazy in _diff().
Oct 2 2018, 7:12 PM
spectral closed D4844: treemanifests: skip extraneous check for item before calling _loadlazy.
Oct 2 2018, 7:12 PM
spectral committed rHG731961d972ba: treemanifests: remove _loadalllazy in _diff().
treemanifests: remove _loadalllazy in _diff()
Oct 2 2018, 7:12 PM
spectral committed rHG3cacb74c3a22: treemanifests: skip extraneous check for item before calling _loadlazy.
treemanifests: skip extraneous check for item before calling _loadlazy
Oct 2 2018, 7:12 PM
spectral closed D4843: treemanifests: make _loadchildrensetlazy just call _loadlazy.
Oct 2 2018, 7:12 PM
spectral committed rHG19103e68a698: treemanifests: make _loadchildrensetlazy just call _loadlazy.
treemanifests: make _loadchildrensetlazy just call _loadlazy
Oct 2 2018, 7:12 PM
spectral closed D4842: treemanifests: make _loadlazy tolerate item not on _lazydirs.
Oct 2 2018, 7:12 PM
spectral committed rHGda0319e024c0: treemanifests: make _loadlazy tolerate item not on _lazydirs.
treemanifests: make _loadlazy tolerate item not on _lazydirs
Oct 2 2018, 7:12 PM
spectral created D4845: treemanifests: remove _loadalllazy in _diff().
Oct 2 2018, 6:46 PM
spectral created D4844: treemanifests: skip extraneous check for item before calling _loadlazy.
Oct 2 2018, 6:46 PM
spectral created D4843: treemanifests: make _loadchildrensetlazy just call _loadlazy.
Oct 2 2018, 6:46 PM
spectral added a dependent revision for D4844: treemanifests: skip extraneous check for item before calling _loadlazy: D4845: treemanifests: remove _loadalllazy in _diff().
Oct 2 2018, 6:46 PM
spectral added a dependent revision for D4843: treemanifests: make _loadchildrensetlazy just call _loadlazy: D4844: treemanifests: skip extraneous check for item before calling _loadlazy.
Oct 2 2018, 6:46 PM
spectral created D4842: treemanifests: make _loadlazy tolerate item not on _lazydirs.
Oct 2 2018, 6:46 PM
spectral added a dependent revision for D4842: treemanifests: make _loadlazy tolerate item not on _lazydirs: D4843: treemanifests: make _loadchildrensetlazy just call _loadlazy.
Oct 2 2018, 6:46 PM

Sep 27 2018

spectral added a comment to D4782: remotefilelog: import pruned-down remotefilelog extension from hg-experimental.

My primary concern is migrating from hg-experimental remotefilelog to this. Making one of them compatible with the other at a wire protocol level would assist with the migration immensely, so I think that avoiding complex changes to the wire protocol would make sense. I think we should make changes to hg-experimental's remotefilelog to support any capabilities/command we implement here, so that the migration path is:

Sep 27 2018, 6:50 PM

Sep 20 2018

spectral committed rHG9d5c919b6dc3: narrow: extract wdir cleanup function to make it extensible.
narrow: extract wdir cleanup function to make it extensible
Sep 20 2018, 3:46 PM
spectral closed D4681: narrow: extract wdir cleanup function to make it extensible.
Sep 20 2018, 3:46 PM
spectral created D4681: narrow: extract wdir cleanup function to make it extensible.
Sep 20 2018, 3:20 PM

Sep 18 2018

spectral closed D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow.
Sep 18 2018, 9:47 AM
spectral committed rHG24870f1be088: narrow: when writing treemanifests, skip inspecting directories outside narrow.
narrow: when writing treemanifests, skip inspecting directories outside narrow
Sep 18 2018, 9:47 AM

Sep 17 2018

spectral accepted D4612: zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly.
Sep 17 2018, 5:46 PM
spectral added a comment to D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow.
In D4606#70323, @yuja wrote:

Looks good to me. One nit.

    • a/mercurial/manifest.py +++ b/mercurial/manifest.py @@ -1203,7 +1203,7 @@ s._dirty = False self._loadfunc = _load_for_read
  • def writesubtrees(self, m1, m2, writesubtree): + def writesubtrees(self, m1, m2, writesubtree, match=None):

Can you remove the unsupported default value match=None from inner functions?

Sep 17 2018, 2:55 PM
spectral updated the diff for D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow.
Sep 17 2018, 2:54 PM
spectral updated the diff for D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow.
Sep 17 2018, 2:32 PM

Sep 16 2018

spectral created D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow.
Sep 16 2018, 12:44 AM

Sep 14 2018

spectral closed D4587: narrow: intersect provided matcher with narrowmatcher in `hg diff`.
Sep 14 2018, 10:22 PM
spectral committed rHGee7ee0c516ca: narrow: intersect provided matcher with narrowmatcher in `hg diff`.
narrow: intersect provided matcher with narrowmatcher in `hg diff`
Sep 14 2018, 10:21 PM
spectral updated the summary of D4587: narrow: intersect provided matcher with narrowmatcher in `hg diff`.
Sep 14 2018, 4:26 PM
spectral created D4587: narrow: intersect provided matcher with narrowmatcher in `hg diff`.
Sep 14 2018, 4:04 PM

Sep 11 2018

spectral added a comment to D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher.
In D4370#69050, @yuja wrote:

Queued, thanks.

+ def _loadchildrensetlazy(self, visit):
+ if not visit:
+ return None
+ if visit == 'all' or visit == 'this':
+ self._loadalllazy()
+ return None
+
+ todel = []
+ for k in visit:
+ kslash = k + '/'
+ ld = self._lazydirs.get(kslash)
+ if ld:
+ path, node, readsubtree = ld
+ self._dirs[kslash] = readsubtree(path, node)
+ todel.append(kslash)
+ for kslash in todel:
+ del self._lazydirs[kslash]

Any reason not to use self._loadlazy(kslash)?

Sep 11 2018, 3:34 PM
spectral closed D4371: treemanifest: use visitchildrenset when doing a walk.
Sep 11 2018, 8:36 AM