spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (98 w, 3 d)

Recent Activity

Fri, May 17

spectral accepted D6407: relnotes: mention removed support for mixed log graph lines.
Fri, May 17, 3:21 PM

Thu, May 16

spectral committed rHG264a2cbb25d0: graphmod: remove support for graph lines mixing parent/grandparent styles (BC).
graphmod: remove support for graph lines mixing parent/grandparent styles (BC)
Thu, May 16, 11:39 AM

Wed, May 15

spectral closed D5112: graphmod: remove support for graph lines mixing parent/grandparent styles (BC).
Wed, May 15, 2:31 PM
spectral committed rHG2e97640c598e: graphmod: remove support for graph lines mixing parent/grandparent styles (BC).
graphmod: remove support for graph lines mixing parent/grandparent styles (BC)
Wed, May 15, 2:31 PM

Apr 15 2019

spectral closed D6168: readline: provide styled prompt to readline (issue6070).
Apr 15 2019, 7:41 PM
spectral committed rHG2d428b859282: readline: provide styled prompt to readline (issue6070).
readline: provide styled prompt to readline (issue6070)
Apr 15 2019, 7:41 PM
spectral added a comment to D6168: readline: provide styled prompt to readline (issue6070).

I believe I've incorporated yuja's suggestions. Please take another look.

Apr 15 2019, 5:37 PM
spectral updated the diff for D6168: readline: provide styled prompt to readline (issue6070).
Apr 15 2019, 5:34 PM
spectral updated the diff for D6168: readline: provide styled prompt to readline (issue6070).
Apr 15 2019, 5:33 PM
spectral updated the diff for D6168: readline: provide styled prompt to readline (issue6070).
Apr 15 2019, 5:31 PM

Mar 22 2019

spectral added a comment to D6168: readline: provide styled prompt to readline (issue6070).

Except that test-command-server.t fails like this:

@@ -776,11 +776,9 @@
   message: '\xa3DdataJpassword: Hpassword\xf5DtypeFprompt'
   1234
   *** runcommand debugprompt --config ui.interactive=True
-  message: '\xa3DdataGprompt:GdefaultAyDtypeFprompt'
-   5678
+  prompt: 5678
   *** runcommand debugpromptchoice --config ui.interactive=True
-  message: '\xa4Gchoices\x82\x82AyCYes\x82AnBNoDdataTpromptchoice (y/n)? GdefaultAyDtypeFprompt'
-   1
+  promptchoice (y/n)?  1

 bad message encoding:

@spectral, any idea how to fix?

Mar 22 2019, 3:40 PM

Mar 20 2019

spectral closed D6131: crecord: redraw the screen when starting up chunkselector.
Mar 20 2019, 2:08 PM
spectral closed D6129: crecord: completely redraw screen when coming back from editor.
Mar 20 2019, 2:08 PM
spectral closed D6130: crecord: redraw the screen on ctrl-L.
Mar 20 2019, 2:08 PM
spectral committed rHGcde5827d09a7: crecord: redraw the screen when starting up chunkselector.
crecord: redraw the screen when starting up chunkselector
Mar 20 2019, 2:08 PM
spectral committed rHGfa3b0ca9d74f: crecord: redraw the screen on ctrl-L.
crecord: redraw the screen on ctrl-L
Mar 20 2019, 2:08 PM
spectral committed rHG3f467db023a2: crecord: completely redraw screen when coming back from editor.
crecord: completely redraw screen when coming back from editor
Mar 20 2019, 2:08 PM

Mar 14 2019

spectral added inline comments to D6131: crecord: redraw the screen when starting up chunkselector.
Mar 14 2019, 1:57 AM
spectral updated the diff for D6131: crecord: redraw the screen when starting up chunkselector.
Mar 14 2019, 1:56 AM

Mar 13 2019

spectral created D6131: crecord: redraw the screen when starting up chunkselector.
Mar 13 2019, 11:17 PM
spectral created D6130: crecord: redraw the screen on ctrl-L.
Mar 13 2019, 10:36 PM
spectral created D6129: crecord: completely redraw screen when coming back from editor.
Mar 13 2019, 10:36 PM
spectral added a dependent revision for D6129: crecord: completely redraw screen when coming back from editor: D6130: crecord: redraw the screen on ctrl-L.
Mar 13 2019, 10:36 PM
spectral closed D6121: chunkselector: fix typos in instructions when user reviews patch.
Mar 13 2019, 5:12 AM
spectral committed rHG7e95ade0f369: chunkselector: fix typos in instructions when user reviews patch.
chunkselector: fix typos in instructions when user reviews patch
Mar 13 2019, 5:12 AM

Mar 12 2019

spectral created D6121: chunkselector: fix typos in instructions when user reviews patch.
Mar 12 2019, 1:41 AM

Feb 26 2019

spectral closed D6025: remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)".
Feb 26 2019, 5:12 PM
spectral committed rHG941685500125: remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)".
remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)"
Feb 26 2019, 5:12 PM
spectral added inline comments to D6025: remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)".
Feb 26 2019, 4:46 PM
spectral updated the diff for D6025: remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)".
Feb 26 2019, 4:44 PM
spectral closed D6024: remotefilelog: do not specify an explicit version for repack.
Feb 26 2019, 9:51 AM
spectral committed rHG118c1ec4f31b: remotefilelog: do not specify an explicit version for repack.
remotefilelog: do not specify an explicit version for repack
Feb 26 2019, 9:51 AM

Feb 25 2019

spectral created D6025: remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)".
Feb 25 2019, 6:59 PM
spectral created D6024: remotefilelog: do not specify an explicit version for repack.
Feb 25 2019, 3:29 PM

Feb 22 2019

spectral closed D5999: context: use includematcher when checking dir/file conflicts.
Feb 22 2019, 12:51 AM
spectral committed rHG0b2361c2c493: tests: change the paths slightly in test-rebase-inmemory.t.
tests: change the paths slightly in test-rebase-inmemory.t
Feb 22 2019, 12:51 AM
spectral committed rHGcd7059d17cb2: context: use includematcher when checking dir/file conflicts.
context: use includematcher when checking dir/file conflicts
Feb 22 2019, 12:51 AM
spectral closed D5998: tests: change the paths slightly in test-rebase-inmemory.t.
Feb 22 2019, 12:50 AM

Feb 21 2019

spectral created D5999: context: use includematcher when checking dir/file conflicts.
Feb 21 2019, 10:16 PM
spectral created D5998: tests: change the paths slightly in test-rebase-inmemory.t.
Feb 21 2019, 10:16 PM
spectral added a dependent revision for D5998: tests: change the paths slightly in test-rebase-inmemory.t: D5999: context: use includematcher when checking dir/file conflicts.
Feb 21 2019, 10:16 PM

Feb 12 2019

spectral committed rHG61415361e906: zsh: fix `hg resolve` completion when in a subdirectory (issue6067).
zsh: fix `hg resolve` completion when in a subdirectory (issue6067)
Feb 12 2019, 9:20 AM
spectral closed D5836: zsh: fix `hg resolve` completion when in a subdirectory (issue6067).
Feb 12 2019, 9:20 AM

Feb 9 2019

spectral committed rHG7b1b0415f8e5: blackbox: test that track=* works to log everything.
blackbox: test that track=* works to log everything
Feb 9 2019, 4:46 PM
spectral closed D5784: blackbox: test that track=* works to log everything.
Feb 9 2019, 4:46 PM
spectral committed rHG31dfe7026f8d: blackbox: test that unsetting track disables blackbox logging.
blackbox: test that unsetting track disables blackbox logging
Feb 9 2019, 4:46 PM
spectral closed D5783: blackbox: test that unsetting track disables blackbox logging.
Feb 9 2019, 4:46 PM

Feb 6 2019

spectral abandoned D3209: amend: exit 0 if there are no changes.
Feb 6 2019, 6:19 PM
spectral abandoned D5211: templateutil: add mappingdict to handle dicts in template/formatter props.
Feb 6 2019, 6:19 PM
spectral planned changes to D5786: blackbox: support blackbox.notrack regex patterns to exclude tracking events.
Feb 6 2019, 6:18 PM
spectral abandoned D5788: commit: make `commit -i` respect whitespace CLI args, ignore config.
Feb 6 2019, 6:18 PM
spectral abandoned D5787: diff: support ignoring config settings when parsing optional diffopts.
Feb 6 2019, 6:17 PM

Feb 5 2019

spectral closed D5834: commit/revert: if interactive, look elsewhere for whitespace settings (BC).
Feb 5 2019, 7:12 AM
spectral committed rHG66399f2e92aa: commit: if interactive, look elsewhere for whitespace settings (BC).
commit: if interactive, look elsewhere for whitespace settings (BC)
Feb 5 2019, 7:12 AM
spectral closed D5832: config: extract diff-related coreconfigitem()s to a helper method.
Feb 5 2019, 7:12 AM
spectral committed rHG901ebc81ffb3: config: extract diff-related coreconfigitem()s to a helper method.
config: extract diff-related coreconfigitem()s to a helper method
Feb 5 2019, 7:12 AM
spectral committed rHG78b270a55dc6: diff: when looking for diff configs, support a configurable prefix.
diff: when looking for diff configs, support a configurable prefix
Feb 5 2019, 7:12 AM
spectral closed D5833: diff: when looking for diff configs, support a configurable prefix.
Feb 5 2019, 7:12 AM

Feb 4 2019

spectral committed rHG3a01ce246ece: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
commit: ignore diff whitespace settings when doing `commit -i` (issue5839)
Feb 4 2019, 6:38 PM
spectral created D5836: zsh: fix `hg resolve` completion when in a subdirectory (issue6067).
Feb 4 2019, 5:29 PM
spectral committed rHG35e37315c058: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
commit: ignore diff whitespace settings when doing `commit -i` (issue5839)
Feb 4 2019, 4:55 PM
spectral planned changes to D5785: blackbox: take regex patterns for blackbox.track.
In D5785#84935, @yuja wrote:

Can't we process the pattern as a glob? It's compatible with * and much
easier to write. Or do you need the power of the regexp?

Feb 4 2019, 3:42 PM
spectral added a comment to D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
In D5744#85051, @yuja wrote:

I agree with that we would never set the commands.commit.interactive.{...}
in hgrc, but the feature itself is useful if you have to work on unclean
codebase unlike in Google. For example, I sometimes need to commit changes
ignoring unrelated whitespace cleanups made by editor or code formatter,
because I can't control the development workflow.

That's why I thought there would be users relying on the current behavior.

Feb 4 2019, 3:40 PM
spectral created D5834: commit/revert: if interactive, look elsewhere for whitespace settings (BC).
Feb 4 2019, 3:39 PM
spectral created D5833: diff: when looking for diff configs, support a configurable prefix.
Feb 4 2019, 3:39 PM
spectral added a dependent revision for D5833: diff: when looking for diff configs, support a configurable prefix: D5834: commit/revert: if interactive, look elsewhere for whitespace settings (BC).
Feb 4 2019, 3:39 PM
spectral created D5832: config: extract diff-related coreconfigitem()s to a helper method.
Feb 4 2019, 3:39 PM
spectral added a dependent revision for D5832: config: extract diff-related coreconfigitem()s to a helper method: D5833: diff: when looking for diff configs, support a configurable prefix.
Feb 4 2019, 3:39 PM

Feb 1 2019

spectral added a comment to D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
In D5744#84938, @yuja wrote:

I did not add this to revert --interactive, since that does not currently have any way of getting args specified on the commandline that affect the whitespace settings (so I'm keeping revert --interactive *ignoring* the user's diff settings).

Well, hg revert --interactive does respect the user's diff settings. I don't
know why, but f37a69ec3f47 explicitly added whitespace=True.

Feb 1 2019, 2:20 PM

Jan 31 2019

spectral added a comment to D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).

I've sent D5787 and D5788, implementing support for whitespace='noconfig' to parse them from the commandline args, but ignore the settings from the user's config. I did not add this to revert --interactive, since that does not currently have any way of getting args specified on the commandline that affect the whitespace settings (so I'm keeping revert --interactive *ignoring* the user's diff settings).

Jan 31 2019, 6:52 PM
spectral created D5788: commit: make `commit -i` respect whitespace CLI args, ignore config.
Jan 31 2019, 6:49 PM
spectral added a dependent revision for D5787: diff: support ignoring config settings when parsing optional diffopts: D5788: commit: make `commit -i` respect whitespace CLI args, ignore config.
Jan 31 2019, 6:49 PM
spectral created D5787: diff: support ignoring config settings when parsing optional diffopts.
Jan 31 2019, 6:49 PM
spectral added a comment to D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).

I could see this being something like the following, to make it look at commands.commit.interactive.ignorews (and others):

diffopts = patch.difffeatureopts(repo.ui, section='commands', configprefix='commit.interactive.', whitespace=True)

I think I like that option, I'll send a patch for it.

Jan 31 2019, 5:47 PM
spectral updated the diff for D5786: blackbox: support blackbox.notrack regex patterns to exclude tracking events.
Jan 31 2019, 5:24 PM
spectral updated the diff for D5785: blackbox: take regex patterns for blackbox.track.
Jan 31 2019, 5:24 PM
spectral updated the diff for D5784: blackbox: test that track=* works to log everything.
Jan 31 2019, 5:23 PM
spectral created D5786: blackbox: support blackbox.notrack regex patterns to exclude tracking events.
Jan 31 2019, 5:07 PM
spectral created D5785: blackbox: take regex patterns for blackbox.track.
Jan 31 2019, 5:07 PM
spectral created D5784: blackbox: test that track=* works to log everything.
Jan 31 2019, 5:07 PM
spectral added a dependent revision for D5785: blackbox: take regex patterns for blackbox.track: D5786: blackbox: support blackbox.notrack regex patterns to exclude tracking events.
Jan 31 2019, 5:07 PM
spectral added a dependent revision for D5784: blackbox: test that track=* works to log everything: D5785: blackbox: take regex patterns for blackbox.track.
Jan 31 2019, 5:07 PM
spectral created D5783: blackbox: test that unsetting track disables blackbox logging.
Jan 31 2019, 5:07 PM
spectral added a dependent revision for D5783: blackbox: test that unsetting track disables blackbox logging: D5784: blackbox: test that track=* works to log everything.
Jan 31 2019, 5:07 PM
spectral added a comment to D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).

Sorry for bumping this up. I worked on a similar issue on D5490. My initial revision was similar to this one. @spectral Don't you think it'll affect record extension which was written with zero test coverage? Please don't feel obligated. I am just being curious.

Jan 31 2019, 5:06 PM

Jan 30 2019

spectral closed D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
Jan 30 2019, 2:08 PM
spectral closed D5743: patch: handle 0 context lines (diff.unified=0) when parsing patches.
Jan 30 2019, 2:08 PM
spectral committed rHG19486fc49020: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
commit: ignore diff whitespace settings when doing `commit -i` (issue5839)
Jan 30 2019, 2:08 PM
spectral committed rHGd1d3094b54f9: patch: handle 0 context lines (diff.unified=0) when parsing patches.
patch: handle 0 context lines (diff.unified=0) when parsing patches
Jan 30 2019, 2:08 PM

Jan 29 2019

spectral created D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
Jan 29 2019, 9:32 PM
spectral created D5743: patch: handle 0 context lines (diff.unified=0) when parsing patches.
Jan 29 2019, 9:32 PM
spectral added a dependent revision for D5743: patch: handle 0 context lines (diff.unified=0) when parsing patches: D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839).
Jan 29 2019, 9:32 PM

Jan 17 2019

spectral closed D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Jan 17 2019, 8:43 AM
spectral committed rHG183df3df6031: resolve: fix mark-check when a file was deleted on one side (issue6020).
resolve: fix mark-check when a file was deleted on one side (issue6020)
Jan 17 2019, 8:42 AM

Jan 16 2019

spectral updated the diff for D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
Jan 16 2019, 3:50 PM
spectral added a comment to D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).

Alright that test seems a bit ridiculous now that I'm looking at it in the diff, but it's at least thorough? :)

Jan 16 2019, 3:50 PM

Jan 15 2019

spectral closed D5591: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
Jan 15 2019, 6:57 PM
spectral committed rHGb129837190f7: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
context: use scmutil.matchfiles instead of matchmod.match(exact=True)
Jan 15 2019, 6:57 PM
spectral added a comment to D5532: context: schedule file prefetch before comparing for cleanliness.
In D5532#82319, @yuja wrote:

+ scmutil.prefetchfiles(
+ self.repo(), [self.p1().rev()],
+ matchmod.match('', '', patterns=self._cache.keys(), exact=True))

Perhaps scmutil.matchfiles() can be used instead of the low-level constructor.

Jan 15 2019, 6:47 PM
spectral created D5591: context: use scmutil.matchfiles instead of matchmod.match(exact=True).
Jan 15 2019, 6:47 PM