I believe I've incorporated yuja's suggestions. Please take another look.

In D6168#89876, @martinvonz wrote:

Except that test-command-server.t fails like this:

@@ -776,11 +776,9 @@
   message: '\xa3DdataJpassword: Hpassword\xf5DtypeFprompt'
   1234
   *** runcommand debugprompt --config ui.interactive=True
-  message: '\xa3DdataGprompt:GdefaultAyDtypeFprompt'
-   5678
+  prompt: 5678
   *** runcommand debugpromptchoice --config ui.interactive=True
-  message: '\xa4Gchoices\x82\x82AyCYes\x82AnBNoDdataTpromptchoice (y/n)? GdefaultAyDtypeFprompt'
-   1
+  promptchoice (y/n)?  1

 bad message encoding:

@spectral, any idea how to fix?

In D5785#84935, @yuja wrote:

Can't we process the pattern as a glob? It's compatible with * and much
easier to write. Or do you need the power of the regexp?

In D5744#85051, @yuja wrote:

I agree with that we would never set the commands.commit.interactive.{...}
in hgrc, but the feature itself is useful if you have to work on unclean
codebase unlike in Google. For example, I sometimes need to commit changes
ignoring unrelated whitespace cleanups made by editor or code formatter,
because I can't control the development workflow.

That's why I thought there would be users relying on the current behavior.

In D5744#84938, @yuja wrote:

I did not add this to revert --interactive, since that does not currently have any way of getting args specified on the commandline that affect the whitespace settings (so I'm keeping revert --interactive *ignoring* the user's diff settings).

Well, hg revert --interactive does respect the user's diff settings. I don't
know why, but f37a69ec3f47 explicitly added whitespace=True.

I've sent D5787 and D5788, implementing support for whitespace='noconfig' to parse them from the commandline args, but ignore the settings from the user's config. I did not add this to revert --interactive, since that does not currently have any way of getting args specified on the commandline that affect the whitespace settings (so I'm keeping revert --interactive *ignoring* the user's diff settings).

I could see this being something like the following, to make it look at commands.commit.interactive.ignorews (and others):

diffopts = patch.difffeatureopts(repo.ui, section='commands', configprefix='commit.interactive.', whitespace=True)

I think I like that option, I'll send a patch for it.

In D5744#84781, @navaneeth.suresh wrote:

Sorry for bumping this up. I worked on a similar issue on D5490. My initial revision was similar to this one. @spectral Don't you think it'll affect record extension which was written with zero test coverage? Please don't feel obligated. I am just being curious.

Alright that test seems a bit ridiculous now that I'm looking at it in the diff, but it's at least thorough? :)

In D5532#82319, @yuja wrote:

+ scmutil.prefetchfiles(
+ self.repo(), [self.p1().rev()],
+ matchmod.match('', '', patterns=self._cache.keys(), exact=True))

Perhaps scmutil.matchfiles() can be used instead of the low-level constructor.