Page MenuHomePhabricator

spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (256 w, 6 h)

Recent Activity

Thu, May 12

spectral closed D12625: amend: stop specifying matcher, get all copies in wctx.
Thu, May 12, 1:08 AM
spectral closed D12624: amend: add test showing poor behavior when copies are involved.
Thu, May 12, 1:08 AM
spectral committed rHGdf68d64b0d50: amend: stop specifying matcher, get all copies in wctx.
amend: stop specifying matcher, get all copies in wctx
Thu, May 12, 1:08 AM
spectral committed rHGdc342071297f: amend: add test showing poor behavior when copies are involved.
amend: add test showing poor behavior when copies are involved
Thu, May 12, 1:08 AM

Wed, May 11

spectral created D12625: amend: stop specifying matcher, get all copies in wctx.
Wed, May 11, 9:17 PM
spectral created D12624: amend: add test showing poor behavior when copies are involved.
Wed, May 11, 9:16 PM

Apr 20 2022

spectral abandoned D12577: amend: small refactor of logic for clarity.
Apr 20 2022, 2:16 PM
spectral added a comment to D12577: amend: small refactor of logic for clarity.

I personally find this harder to read since you have to distribute in your head. -0?

Apr 20 2022, 2:16 PM
spectral closed D12576: amend: move "return None for removed files" into block handling filestoamend.
Apr 20 2022, 12:03 PM
spectral committed rHGf45e1618cbf6: amend: move "return None for removed files" into block handling filestoamend.
amend: move "return None for removed files" into block handling filestoamend
Apr 20 2022, 12:03 PM

Apr 19 2022

spectral added a comment to D12577: amend: small refactor of logic for clarity.

I'm not very tied to this, if someone thinks this makes it worse, feel free to reject.

Apr 19 2022, 3:42 PM
spectral created D12577: amend: small refactor of logic for clarity.
Apr 19 2022, 3:21 PM
spectral created D12576: amend: move "return None for removed files" into block handling filestoamend.
Apr 19 2022, 3:21 PM

Apr 14 2022

spectral closed D12552: rebase: while rewriting desc hashes, ignore ambiguous prefix "hashes".
Apr 14 2022, 5:43 AM
spectral committed rHG532b649c1deb: rebase: while rewriting desc hashes, ignore ambiguous prefix "hashes".
rebase: while rewriting desc hashes, ignore ambiguous prefix "hashes"
Apr 14 2022, 5:43 AM
spectral closed D12551: tests: add test demonstrating issue with ambiguous has prefixes during rebase.
Apr 14 2022, 5:43 AM
spectral committed rHG80579e597439: tests: add test demonstrating issue with ambiguous has prefixes during rebase.
tests: add test demonstrating issue with ambiguous has prefixes during rebase
Apr 14 2022, 5:43 AM

Apr 13 2022

spectral updated the diff for D12552: rebase: while rewriting desc hashes, ignore ambiguous prefix "hashes".
Apr 13 2022, 4:48 PM
spectral updated the diff for D12551: tests: add test demonstrating issue with ambiguous has prefixes during rebase.
Apr 13 2022, 4:48 PM
spectral created D12552: rebase: while rewriting desc hashes, ignore ambiguous prefix "hashes".
Apr 13 2022, 4:42 PM
spectral created D12551: tests: add test demonstrating issue with ambiguous has prefixes during rebase.
Apr 13 2022, 4:42 PM

Apr 8 2022

spectral added a comment to D12424: rust: upgrade zstd from 0.5.3 to 0.11.1.

Unfortunately, zstd > 0.5.3 does not support our minimum version of Rust which is 1.48.0. I'd already tried updating, but this'll have to wait until Debian stable updates (or someone adds back backwards compat, which I doubt).

Apr 8 2022, 3:36 PM

Apr 7 2022

spectral committed rHG079197e94b24: crecord: avoid duplicating lines when reverting noeol->eol change.
crecord: avoid duplicating lines when reverting noeol->eol change
Apr 7 2022, 5:28 PM
spectral committed rHG9a5d09d7f108: crecord: add test demonstrating issue when reverting noeol->eol change.
crecord: add test demonstrating issue when reverting noeol->eol change
Apr 7 2022, 5:28 PM
spectral committed rHG1faac8c79bee: crecord: avoid duplicating lines when reverting noeol->eol change.
crecord: avoid duplicating lines when reverting noeol->eol change
Apr 7 2022, 4:31 AM
spectral committed rHGbc7cf68528db: crecord: add test demonstrating issue when reverting noeol->eol change.
crecord: add test demonstrating issue when reverting noeol->eol change
Apr 7 2022, 4:31 AM

Apr 6 2022

spectral closed D12441: crecord: avoid duplicating lines when reverting noeol->eol change.
Apr 6 2022, 8:51 AM
spectral committed rHG327a4022edae: crecord: avoid duplicating lines when reverting noeol->eol change.
crecord: avoid duplicating lines when reverting noeol->eol change
Apr 6 2022, 8:51 AM
spectral closed D12440: crecord: add test demonstrating issue when reverting noeol->eol change.
Apr 6 2022, 8:51 AM
spectral committed rHG74444ac3b041: crecord: add test demonstrating issue when reverting noeol->eol change.
crecord: add test demonstrating issue when reverting noeol->eol change
Apr 6 2022, 8:51 AM

Apr 5 2022

spectral created D12441: crecord: avoid duplicating lines when reverting noeol->eol change.
Apr 5 2022, 2:26 PM
spectral created D12440: crecord: add test demonstrating issue when reverting noeol->eol change.
Apr 5 2022, 2:26 PM

Mar 15 2022

spectral closed D12375: tests: fix formatting issue in run-tests.py after c194e93d1ebc.
Mar 15 2022, 4:33 AM
spectral committed rHG7e18fc0bc46c: tests: fix formatting issue in run-tests.py after c194e93d1ebc.
tests: fix formatting issue in run-tests.py after c194e93d1ebc
Mar 15 2022, 4:33 AM

Mar 14 2022

spectral added a comment to D12371: tests: support another error case when detecting ipv4/ipv6 support.

Looks like this breaks the code formatting tests, and the patch has been published so I can't amend it. Please send a follow-up I can queue

Mar 14 2022, 4:34 PM
spectral created D12375: tests: fix formatting issue in run-tests.py after c194e93d1ebc.
Mar 14 2022, 4:33 PM
spectral closed D12371: tests: support another error case when detecting ipv4/ipv6 support.
Mar 14 2022, 6:48 AM
spectral committed rHGc194e93d1ebc: tests: support another error case when detecting ipv4/ipv6 support.
tests: support another error case when detecting ipv4/ipv6 support
Mar 14 2022, 6:47 AM

Mar 10 2022

spectral created D12371: tests: support another error case when detecting ipv4/ipv6 support.
Mar 10 2022, 12:30 AM

Feb 9 2022

spectral added a comment to D12158: color: don't infer vt status from TERM on Windows.

This really feels like a bug that they're advertising support for xterm-compatible escape codes, and then not setting everything up to handle it properly, but for all I know it's not possible for them to do so (i.e. maybe Windows requires that each Process enable vtmode for every Console it cares about, it can't be done "for us" by these tools)

Feb 9 2022, 2:55 PM

Dec 13 2021

spectral closed D11884: status: when extracting arguments from `opts`, use the same default values.
Dec 13 2021, 9:29 AM
spectral closed D11883: directaccess: fix uses of commands.status() that don't go through flag parsing.
Dec 13 2021, 9:29 AM
spectral committed rHGeaad68294904: status: when extracting arguments from `opts`, use the same default values.
status: when extracting arguments from `opts`, use the same default values
Dec 13 2021, 9:29 AM
spectral committed rHGc51408b92b88: directaccess: fix uses of commands.status() that don't go through flag parsing.
directaccess: fix uses of commands.status() that don't go through flag parsing
Dec 13 2021, 9:29 AM

Dec 7 2021

spectral created D11883: directaccess: fix uses of commands.status() that don't go through flag parsing.
Dec 7 2021, 6:57 PM
spectral created D11884: status: when extracting arguments from `opts`, use the same default values.
Dec 7 2021, 6:57 PM
spectral added a comment to D11680: push: add option to abort on dirty working copy if parent is pushed.

Should Flag negation be rare ?

I disagree here. We should use clearest available verb for flags, using negation to get the meaning we need. I would draw a similarity with boolean naming in the code, where we don't have a preferred "default" state for the common case, but we phrase the boolean in a way that is easy to read.
In addition, having a mix of negation and non-negation as common case will help make the (negation) feature more discoverable.
What's your rationale for wanting them to be rare ?

Dec 7 2021, 3:28 PM

Nov 4 2021

spectral closed D11734: pyoxidizer: use in-memory resources on non-Windows platforms.
Nov 4 2021, 10:42 AM
spectral committed rHG1a420a13eeea: pyoxidizer: use in-memory resources on non-Windows platforms.
pyoxidizer: use in-memory resources on non-Windows platforms
Nov 4 2021, 10:42 AM

Nov 3 2021

spectral created D11734: pyoxidizer: use in-memory resources on non-Windows platforms.
Nov 3 2021, 5:17 PM

Oct 29 2021

spectral abandoned D5019: pager: disable auto pager if we think it doesn't support F, R, X.
Oct 29 2021, 5:44 PM
spectral abandoned D8281: narrow: escape includepats/excludepats when sending over the wire.
Oct 29 2021, 5:44 PM
spectral added a reviewer for D11727: backout: backed out changeset 67d14d4e036c: mharbison72.
Oct 29 2021, 4:33 PM
spectral added a reviewer for D11726: backout: backed out changeset f78d8b8c46d7: mharbison72.
Oct 29 2021, 4:32 PM
spectral accepted D11725: windows: use raw string in test log paths.
Oct 29 2021, 4:30 PM
spectral accepted D11723: rhg: make it possible to opt out of `rhg cat`.
Oct 29 2021, 4:29 PM
spectral added a comment to D11680: push: add option to abort on dirty working copy if parent is pushed.

The ability to use --no- variants is fairly new (a couple of year maybe ?), but I (and others) have been trying to put it to good use since then. Since is quite new I don't think they so many of of such flag yet, but a notable example of that approach is --merge that I use daily.

Oct 29 2021, 3:42 PM
spectral added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

The test near silently skipping is another issue we should tackle. What do you think of the way forward I suggested (flag + env-variable) ?

Oct 29 2021, 2:50 PM

Oct 28 2021

spectral closed D10538: tests: allow Google's internal builds of clang-format to be used.
Oct 28 2021, 5:16 AM
spectral committed rHG1ff06ceb070f: tests: allow Google's internal builds of clang-format to be used.
tests: allow Google's internal builds of clang-format to be used
Oct 28 2021, 5:16 AM

Oct 26 2021

spectral added inline comments to D11680: push: add option to abort on dirty working copy if parent is pushed.
Oct 26 2021, 1:12 PM

Oct 24 2021

spectral added a comment to D11715: dirstate: group return logic and clarify each function in flagfunc.

Now that the fallback function is always being built

Oct 24 2021, 2:20 AM

Oct 22 2021

spectral closed D11714: tests: fix test-convert-git to work w/ "git pull" requiring strategy.
Oct 22 2021, 3:35 AM
spectral committed rHGfd3d4b7f8e62: tests: fix test-convert-git to work w/ "git pull" requiring strategy.
tests: fix test-convert-git to work w/ "git pull" requiring strategy
Oct 22 2021, 3:35 AM

Oct 21 2021

spectral accepted D11715: dirstate: group return logic and clarify each function in flagfunc.
Oct 21 2021, 7:50 PM
spectral committed rHG5228a6dc212b: merge-halt: fix issue with merge.on-failure=halt breaking unshelve.
merge-halt: fix issue with merge.on-failure=halt breaking unshelve
Oct 21 2021, 3:27 AM
spectral committed rHG3e66e4517744: merge-halt: demonstrate unshelve issue with merge.on-failure=halt.
merge-halt: demonstrate unshelve issue with merge.on-failure=halt
Oct 21 2021, 3:27 AM

Oct 20 2021

spectral added inline comments to D11713: dirstate: add missing return on platforms without exec or symlink.
Oct 20 2021, 9:11 PM
spectral retitled D10538: tests: allow Google's internal builds of clang-format to be used from tests: allow trunk versions of clang-format to be used to tests: allow Google's internal builds of clang-format to be used.
Oct 20 2021, 5:48 PM
spectral added a comment to D11713: dirstate: add missing return on platforms without exec or symlink.

I'm not sure the etiquette here; I'm accepting the revision since it obviously fixes a bug, but still would like the comments to be considered/responded to?

Oct 20 2021, 2:27 PM
spectral accepted D11712: parsers: don't ask about symlinks on platforms that don't support them.
Oct 20 2021, 2:13 PM
spectral accepted D11711: parsers: don't ask about the exec bit on platforms that don't have it.
Oct 20 2021, 2:13 PM
spectral created D11714: tests: fix test-convert-git to work w/ "git pull" requiring strategy.
Oct 20 2021, 1:55 PM
spectral closed D11698: pyoxidizer: update README.md with several small fixes.
Oct 20 2021, 5:35 AM
spectral committed rHG16c3fe46929a: pyoxidizer: update README.md with several small fixes.
pyoxidizer: update README.md with several small fixes
Oct 20 2021, 5:35 AM
spectral closed D11697: pyoxidizer: disable using in-memory resources.
Oct 20 2021, 5:35 AM
spectral committed rHGc900d962e38b: pyoxidizer: disable using in-memory resources.
pyoxidizer: disable using in-memory resources
Oct 20 2021, 5:35 AM
spectral closed D11706: merge-halt: fix issue with merge.on-failure=halt breaking unshelve.
Oct 20 2021, 5:21 AM
spectral closed D11705: merge-halt: demonstrate unshelve issue with merge.on-failure=halt.
Oct 20 2021, 5:20 AM
spectral committed rHGcae221e8e4c5: merge-halt: fix issue with merge.on-failure=halt breaking unshelve.
merge-halt: fix issue with merge.on-failure=halt breaking unshelve
Oct 20 2021, 5:20 AM
spectral committed rHG7b0b417cd960: merge-halt: demonstrate unshelve issue with merge.on-failure=halt.
merge-halt: demonstrate unshelve issue with merge.on-failure=halt
Oct 20 2021, 5:20 AM

Oct 19 2021

spectral planned changes to D10538: tests: allow Google's internal builds of clang-format to be used.
Oct 19 2021, 9:30 PM
spectral created D11706: merge-halt: fix issue with merge.on-failure=halt breaking unshelve.
Oct 19 2021, 9:28 PM
spectral created D11705: merge-halt: demonstrate unshelve issue with merge.on-failure=halt.
Oct 19 2021, 9:27 PM
spectral accepted D11695: dirstate-v2: read the fallback value in Rust.
Oct 19 2021, 5:09 PM
spectral accepted D11694: dirstate-v2: adjust the meaning of directory flags.
Oct 19 2021, 5:08 PM
spectral accepted D11696: rust: remove now-unused DirstateEntry::clear_ambiguous_mtime method.
Oct 19 2021, 5:02 PM
spectral accepted D11691: dirstate: rename a `very_likely_equal` method to `likely_equal`.
Oct 19 2021, 5:01 PM
spectral accepted D11690: python: compatibility for python 3.11 (issue6604).
Oct 19 2021, 5:01 PM
spectral created D11698: pyoxidizer: update README.md with several small fixes.
Oct 19 2021, 5:00 PM
spectral created D11697: pyoxidizer: disable using in-memory resources.
Oct 19 2021, 5:00 PM

Oct 18 2021

spectral added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

I feel like the proposal is going in the wrong direction because it make a more diverse set of version passe the version checks while I feel like we need to more toward a narrower check. Different formater version tends to produce different results and it seems saner to pin the project to specific versions (that we update from time to time).

Oct 18 2021, 9:40 PM
spectral added inline comments to D11679: rhg: internally, return a structured representation from hg cat.
Oct 18 2021, 7:06 PM

Oct 17 2021

spectral accepted D11675: bookmarks: move the `mirror` option to the `paths` section.
Oct 17 2021, 7:37 PM
spectral accepted D11676: bookmarks: add support for `mirror` mode to `incoming`.
Oct 17 2021, 7:34 PM

Oct 15 2021

spectral accepted D11677: bookmarks: add a `ignore` variant of the bookmark mode.
Oct 15 2021, 9:23 PM
spectral added inline comments to D11676: bookmarks: add support for `mirror` mode to `incoming`.
Oct 15 2021, 9:18 PM
spectral added a comment to D11675: bookmarks: move the `mirror` option to the `paths` section.

Looks good to me aside from the nit and the pulkit's comment. Not sure on etiquette here (whether I should mark as accepted or not), defaulting to not marking as accepted until all outstanding comments are addressed.

Oct 15 2021, 9:02 PM
spectral added a comment to D10538: tests: allow Google's internal builds of clang-format to be used.

The CI running on Heptapod is available to any developer who pushs draft to it, and it uses the "correct" black version, pinned in the docker image what we uses for the CI.
Something we have been entertaining for a while is to a manually trigger a CI "job" that would run the black formatter one current stack and push back the result to heptapod. This would give a simple option to format with the right version when the CI complains about it. It looks like it could fit the @spectral usecase here.
(The docker image can be easily updated to newer version when appropriate by anyone creating a Merge request here: https://foss.heptapod.net/octobus/ci-dockerfiles/)

While this is/would be very useful, it requires manual action, I think?

Yes, it would be an optional way for people who don't want (or can't easily) install the required tools at the required version.

My goal is to prevent that. I want/need there to be a single command I can run that ensures a commit is ready to land: correctly formatted, tests pass, etc.; there's a reason these check-format tests exist as tests. :/

I am not challenging that, but whatever we do with these tests need to be viable at the project level and it don't seems like using too many, incompatible, version of the formatter would fly well.
I think the baseline for the project should be "the CI shoul stay green" which implies "new changesets should keep the CI green". Running tests locally is a good way to quickly catch errors, but eventually, the only way to validate this is to run the CI on submitted changeset. Something that is now easy to do for a couple of years.
However this implies to make sure the version of formatter used by developers is aligned with the one used by the CI. Which should not be to complicated.

Oct 15 2021, 8:10 PM

Sep 27 2021

spectral added a comment to D11495: narrow: make hg manifest only print things inside the narrowspec.

I think that's a buggy test? @martinvonz and @spectral might have an opinion.

I think I did it that way because I felt that hg manifest is a debug command so it might be useful to have the information about excluded trees there.

Sep 27 2021, 8:46 PM