spectral (Kyle Lippincott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2017, 4:34 PM (55 w, 8 h)

Recent Activity

Tue, Jul 17

spectral closed D3948: curses: use "text" interface if TERM=dumb.
Tue, Jul 17, 9:37 AM
spectral committed rHGd79f3afb079e: curses: use "text" interface if TERM=dumb.
curses: use "text" interface if TERM=dumb
Tue, Jul 17, 9:37 AM

Mon, Jul 16

spectral created D3948: curses: use "text" interface if TERM=dumb.
Mon, Jul 16, 3:04 PM

Thu, Jul 12

spectral committed rHGad2aa4e85047: removeemptydirs: add test for `hg split` inside a disappearing directory.
removeemptydirs: add test for `hg split` inside a disappearing directory
Thu, Jul 12, 9:11 AM
spectral closed D3927: removeemptydirs: add test for `hg split` inside a disappearing directory.
Thu, Jul 12, 9:11 AM

Wed, Jul 11

spectral created D3927: removeemptydirs: add test for `hg split` inside a disappearing directory.
Wed, Jul 11, 4:46 PM

Tue, Jul 10

spectral closed D3902: prefetch: do not attempt to prefetch treemanifests as files.
Tue, Jul 10, 6:45 PM
spectral committed rFBHGXe8f6b8b0388a: prefetch: do not attempt to prefetch treemanifests as files.
prefetch: do not attempt to prefetch treemanifests as files
Tue, Jul 10, 6:45 PM
spectral created D3902: prefetch: do not attempt to prefetch treemanifests as files.
Tue, Jul 10, 2:39 PM

Fri, Jun 29

spectral closed D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826).
Fri, Jun 29, 8:32 AM
spectral committed rHGda2a7d8354b2: unlinkpath: make empty directory removal optional (issue5901) (issue5826).
unlinkpath: make empty directory removal optional (issue5901) (issue5826)
Fri, Jun 29, 8:31 AM

Thu, Jun 28

spectral added a comment to D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826).

(Tests pass on my mac as well)

Thu, Jun 28, 9:54 PM
spectral added inline comments to D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826).
Thu, Jun 28, 9:44 PM
spectral updated the diff for D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826).
Thu, Jun 28, 9:39 PM
spectral abandoned D3858: unlinkpath: make empty directory removal optional (issue5901) (issue5826).

(Sorry for the double send)

Thu, Jun 28, 9:39 PM
spectral created D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826).
Thu, Jun 28, 9:11 PM
spectral created D3858: unlinkpath: make empty directory removal optional (issue5901) (issue5826).
Thu, Jun 28, 9:10 PM

Fri, Jun 22

spectral abandoned D2014: amend: --no-secret overrides phases.new-commit and previous phase.
Fri, Jun 22, 2:31 PM
spectral abandoned D2013: commit: allow --no-secret to override phases.new-commit setting.
Fri, Jun 22, 2:30 PM
spectral abandoned D2017: split: accept a --secret flag to force phase of new commits.
Fri, Jun 22, 2:30 PM
spectral abandoned D2016: split: preserve phase of commit that is being split.
Fri, Jun 22, 2:29 PM

Jun 19 2018

spectral committed rHGa0e185f10454: tests: in test-split.t, save a "clean" copy of pre-split repo for later use.
tests: in test-split.t, save a "clean" copy of pre-split repo for later use
Jun 19 2018, 4:53 PM
spectral closed D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use.
Jun 19 2018, 4:53 PM
spectral added a comment to D3716: ui: add an uninterruptable context manager that can block SIGINT.

I agree with @yuja that we should move this to util.py or one of its siblings and rename it to uninterruptable or some such.

That being said, signal handlers are process global. And we do need to maintain persistent state so things don't get out of whack if we have overlapping calls, potentially from multiple threads (e.g. in the case of hgweb). So maybe ui.py - or even a global variable in that module - is the proper place for such state.

Also, I wonder if we shouldn't delay signal handling instead of ignoring it. e.g. our new signal handler would print that the signal was received and then raise KeyboardInterrupt at context manager exit time. Otherwise, the handling of SIGINT is timing dependent and doesn't consistently result in an aborted process.

Jun 19 2018, 2:37 AM

Jun 15 2018

spectral closed D3755: remotefilectx: when looking for linknodes, use unfiltered repo.
Jun 15 2018, 11:42 PM
spectral committed rFBHGXf20ef49301c4: remotefilectx: when looking for linknodes, use unfiltered repo.
remotefilectx: when looking for linknodes, use unfiltered repo
Jun 15 2018, 11:42 PM
spectral created D3755: remotefilectx: when looking for linknodes, use unfiltered repo.
Jun 15 2018, 5:17 PM

Jun 14 2018

spectral added a comment to D3665: graph: improve graph output by using Unicode characters.
In D3665#58616, @smf wrote:

johnstiles (John Stiles) <phabricator@mercurial-scm.org> writes:

johnstiles added a comment.

Hi there @indygreg and @yuja  -- are you happy with the diff as it currently stands? Do you think this needs any additional work?

Sorry for the late reply; was having email filtering issues (hopefully
fixed now).

Overall, I'm +0 on it because I think the "real" solution to this is to
templatize the graph glpyhs so any user could use whatever unicode they
desire. However, that's a tall order I wouldn't put on you so I'm fine
with putting this in and adding a note along the lines of, "the path to
get this in core is to get the graph log templated."

Jun 14 2018, 7:21 PM

Jun 8 2018

spectral accepted D3665: graph: improve graph output by using Unicode characters.

lgtm, but yuja had asked for sean and others to look, and I don't have push access :)

Jun 8 2018, 3:53 PM

May 31 2018

spectral closed D3647: prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable.
May 31 2018, 6:35 PM
spectral committed rFBHGX1f128373fb39: lz4wrapper: use new mechanism of adding to demandimport ignored list.
lz4wrapper: use new mechanism of adding to demandimport ignored list
May 31 2018, 6:35 PM
spectral committed rFBHGX45d384548b12: prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable.
prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable
May 31 2018, 6:35 PM
spectral closed D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list.
May 31 2018, 6:35 PM
spectral committed rFBHGXfb2c47c81a05: debian: skip using rust extensions for now since the debian rules aren't correct.
debian: skip using rust extensions for now since the debian rules aren't correct
May 31 2018, 6:35 PM
spectral closed D3645: debian: skip using rust extensions for now since the debian rules aren't correct.
May 31 2018, 6:35 PM

May 25 2018

spectral accepted D3655: graph: add outputgraph() function, called by ascii() to print the graph to the ui..

lgtm, and as long as there's no test differences seems fine. (I don't have ability to accept the patch, and this is from another Googler anyway, so this is just first-stage review).

May 25 2018, 3:18 PM

May 23 2018

spectral closed D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed.
May 23 2018, 8:34 AM
spectral committed rHG2b8cb0ab231c: localrepo: add docstring to _makedirstate to make it less likely to be removed.
localrepo: add docstring to _makedirstate to make it less likely to be removed
May 23 2018, 8:34 AM

May 22 2018

spectral created D3647: prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable.
May 22 2018, 6:38 PM
spectral created D3645: debian: skip using rust extensions for now since the debian rules aren't correct.
May 22 2018, 6:38 PM
spectral added a dependent revision for D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list: D3647: prefetch: use scmutil.fileprefetchhooks if cmdutil._revertprefetch unavailable.
May 22 2018, 6:38 PM
spectral created D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list.
May 22 2018, 6:38 PM
spectral added a dependent revision for D3645: debian: skip using rust extensions for now since the debian rules aren't correct: D3646: lz4wrapper: use new mechanism of adding to demandimport ignored list.
May 22 2018, 6:38 PM
spectral created D3643: localrepo: add docstring to _makedirstate to make it less likely to be removed.
May 22 2018, 2:21 PM
spectral closed D3559: narrow: only wrap dirstate functions once, instead of per-reposetup.
May 22 2018, 8:37 AM
spectral committed rHG1cba497491be: narrow: only wrap dirstate functions once, instead of per-reposetup.
narrow: only wrap dirstate functions once, instead of per-reposetup
May 22 2018, 8:37 AM

May 18 2018

spectral updated the diff for D3559: narrow: only wrap dirstate functions once, instead of per-reposetup.
May 18 2018, 5:53 PM
spectral closed D3577: crecord: fallback to text mode if diffs are too big for curses mode.
May 18 2018, 2:24 PM
spectral committed rHGdabc2237963c: crecord: fallback to text mode if diffs are too big for curses mode.
crecord: fallback to text mode if diffs are too big for curses mode
May 18 2018, 2:24 PM
spectral created D3577: crecord: fallback to text mode if diffs are too big for curses mode.
May 18 2018, 2:12 AM

May 17 2018

spectral committed rHGca890999d317: tests: test-parseindex.t works just fine with chg.
tests: test-parseindex.t works just fine with chg
May 17 2018, 8:12 AM
spectral closed D3571: tests: test-parseindex.t works just fine with chg.
May 17 2018, 8:12 AM

May 16 2018

spectral created D3571: tests: test-parseindex.t works just fine with chg.
May 16 2018, 6:48 PM
spectral closed D3562: tests: mark tests that fail when using chg as #require no-chg.
May 16 2018, 8:09 AM
spectral committed rHG538e850ae737: tests: mark tests that fail when using chg as #require no-chg.
tests: mark tests that fail when using chg as #require no-chg
May 16 2018, 8:08 AM

May 15 2018

spectral created D3562: tests: mark tests that fail when using chg as #require no-chg.
May 15 2018, 2:53 PM

May 14 2018

spectral created D3559: narrow: only wrap dirstate functions once, instead of per-reposetup.
May 14 2018, 6:53 PM

Apr 13 2018

spectral accepted D3323: py3: iterate over a copy of dict while changing it.
Apr 13 2018, 4:53 PM

Apr 12 2018

spectral added inline comments to D3212: patch: implement a new worddiff algorithm.
Apr 12 2018, 8:42 PM

Apr 10 2018

spectral updated subscribers of D3212: patch: implement a new worddiff algorithm.
Apr 10 2018, 3:39 PM

Apr 9 2018

spectral added inline comments to D3212: patch: implement a new worddiff algorithm.
Apr 9 2018, 9:03 PM
spectral added a comment to D3209: amend: exit 0 if there are no changes.
In D3209#51512, @quark wrote:

Returning 1 is actually more consistent with other core commands like pull, push, commit. See https://www.mercurial-scm.org/pipermail/mercurial-devel/2012-January/037711.html. Scripts should be updated to use $? explicitly.

Apr 9 2018, 8:20 PM
spectral created D3209: amend: exit 0 if there are no changes.
Apr 9 2018, 6:10 PM

Mar 30 2018

spectral committed rHG2208149c4b8e: extdiff: document that it copies modified files back to working directory.
extdiff: document that it copies modified files back to working directory
Mar 30 2018, 9:22 PM
spectral closed D2976: extdiff: document that it copies modified files back to working directory.
Mar 30 2018, 9:22 PM
spectral created D2976: extdiff: document that it copies modified files back to working directory.
Mar 30 2018, 3:17 PM

Mar 26 2018

spectral added inline comments to D2939: fsmonitor: layer on another hack in bser.c for os.stat() compat (issue5811).
Mar 26 2018, 2:42 PM

Mar 23 2018

spectral committed rHG08890706366e: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
copyfile: preserve stat info (mtime, etc.) when doing copies/renames
Mar 23 2018, 10:31 AM

Mar 22 2018

spectral closed D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
Mar 22 2018, 10:46 AM
spectral committed rHG1e30a26a65d0: filemerge: make the 'local' path match the format that 'base' and 'other' use.
filemerge: make the 'local' path match the format that 'base' and 'other' use
Mar 22 2018, 10:46 AM

Mar 21 2018

spectral abandoned D1721: debug: customizable timestamp when printing ui.debug text.
Mar 21 2018, 5:06 PM
spectral updated the diff for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 21 2018, 5:02 PM
spectral added a reviewer for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames: indygreg.

Greg has some concerns about this patch and it sounds like you will make some changes. The patch was queued by Augie, but I'm dropping it for now, so we don't have a slightly controversial patch written by a Googler queued by two other Googlers.

Mar 21 2018, 5:00 PM
spectral updated the diff for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 21 2018, 4:59 PM
spectral updated the diff for D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
Mar 21 2018, 4:48 PM

Mar 19 2018

spectral requested review of D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.

Ah, there's a "Request Review" that I'd never noticed before, choosing that to hopefully get this out of "Requires Revision"

Mar 19 2018, 2:22 PM
spectral updated the diff for D2888: filemerge: use a single temp dir instead of temp files.
Mar 19 2018, 2:18 PM
spectral added a comment to D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
In D2889#46482, @yuja wrote:

Not reviewed yet, but this can't be applied cleanly. Can you rebase?

Mar 19 2018, 2:18 PM
spectral updated the diff for D2887: filemerge: move temp file unlinks to _maketempfiles.
Mar 19 2018, 2:18 PM
spectral closed D2888: filemerge: use a single temp dir instead of temp files.
Mar 19 2018, 10:37 AM
spectral committed rHGe349ad5cbb71: filemerge: use a single temp dir instead of temp files.
filemerge: use a single temp dir instead of temp files
Mar 19 2018, 10:37 AM
spectral committed rHG3723b42ff953: filemerge: move temp file unlinks to _maketempfiles.
filemerge: move temp file unlinks to _maketempfiles
Mar 19 2018, 10:37 AM
spectral closed D2887: filemerge: move temp file unlinks to _maketempfiles.
Mar 19 2018, 10:37 AM

Mar 17 2018

spectral committed rHGa4a95bd7158d: filemerge: give some variables in _xmerge more descriptive names.
filemerge: give some variables in _xmerge more descriptive names
Mar 17 2018, 3:08 PM
spectral closed D2886: filemerge: give some variables in _xmerge more descriptive names.
Mar 17 2018, 3:08 PM

Mar 16 2018

spectral created D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
Mar 16 2018, 8:01 PM
spectral created D2888: filemerge: use a single temp dir instead of temp files.
Mar 16 2018, 8:01 PM
spectral added a dependent revision for D2888: filemerge: use a single temp dir instead of temp files: D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use.
Mar 16 2018, 8:01 PM
spectral created D2887: filemerge: move temp file unlinks to _maketempfiles.
Mar 16 2018, 8:01 PM
spectral added a dependent revision for D2887: filemerge: move temp file unlinks to _maketempfiles: D2888: filemerge: use a single temp dir instead of temp files.
Mar 16 2018, 8:00 PM
spectral added a dependent revision for D2886: filemerge: give some variables in _xmerge more descriptive names: D2887: filemerge: move temp file unlinks to _maketempfiles.
Mar 16 2018, 8:00 PM
spectral created D2886: filemerge: give some variables in _xmerge more descriptive names.
Mar 16 2018, 8:00 PM

Mar 13 2018

spectral added a comment to D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.

I'm sorry, but we cannot ship this as is.

The reason is mtime based build systems, like GNU make.

We can't have version control modifying files without bumping their mtime because this invalidates the target freshness checks of mtime-based build systems.

Mar 13 2018, 3:59 PM

Mar 12 2018

spectral added a comment to D2678: help: supporting both help and doc for aliases.

Ugh:

--- /home/augie/hg/tests/test-alias.t
+++ /home/augie/hg/tests/test-alias.t.err
@@ -357,15 +357,8 @@
 properly recursive

   $ hg dln
-  changeset:   -1:0000000000000000000000000000000000000000
-  phase:       public
-  parent:      -1:0000000000000000000000000000000000000000
-  parent:      -1:0000000000000000000000000000000000000000
-  manifest:    -1:0000000000000000000000000000000000000000
-  user:
-  date:        Thu Jan 01 00:00:00 1970 +0000
-  extra:       branch=default
-
+  abort: alias 'dln' resolves to unknown command 'lognull'
+  [255]
Mar 12 2018, 9:30 PM
spectral updated the diff for D2678: help: supporting both help and doc for aliases.
Mar 12 2018, 9:21 PM
spectral closed D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 12 2018, 6:17 PM
spectral committed rHG9e460318ca4b: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
copyfile: preserve stat info (mtime, etc.) when doing copies/renames
Mar 12 2018, 6:16 PM
spectral updated the diff for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 12 2018, 5:58 PM
spectral added a comment to D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.

Neat, didn't know about the inline python stuff. That's much nicer.

Mar 12 2018, 5:53 PM
spectral updated the diff for D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames.
Mar 12 2018, 5:52 PM