stash (Stanislau Hlebik)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2017, 7:25 AM (97 w, 3 d)

Recent Activity

Dec 15 2017

stash accepted D1705: infinitepush: don't show backup summary if a backup is in progress.
Dec 15 2017, 12:18 PM
stash accepted D1704: infinitepush: add backingup templatekeyword.
Dec 15 2017, 12:07 PM
stash accepted D1603: infinitepush: extract getsrcrepo to a utility module.
Dec 15 2017, 9:12 AM
stash accepted D1604: rage: look in srcrepo for infinitepushbackupstate.
Dec 15 2017, 9:12 AM

Dec 8 2017

stash accepted D1613: infinitepush: consider hidden revisions when computing backedup state.
Dec 8 2017, 12:02 PM
stash added a reviewer for D1618: infinitepush: write backup state file atomically: mbthomas.
Dec 8 2017, 11:52 AM
stash created D1618: infinitepush: write backup state file atomically.
Dec 8 2017, 11:51 AM

Nov 30 2017

stash closed D1505: infinitepush: skip fastheadsdiscovery heuristic.
Nov 30 2017, 8:23 PM
stash committed rFBHGX23171cd2898a: infinitepush: skip fastheadsdiscovery heuristic.
infinitepush: skip fastheadsdiscovery heuristic
Nov 30 2017, 8:22 PM
stash closed D1507: fastpartialmatch: wrap only changelog.
Nov 30 2017, 8:22 PM
stash committed rFBHGXaa53a87158e8: fastpartialmatch: wrap only changelog.
fastpartialmatch: wrap only changelog
Nov 30 2017, 8:22 PM
stash abandoned D1049: remotefilelog: add logging for prefetch during commit.

It's not that necessary now, and requires more work to get it done. I'm going to abandon the diff.

Nov 30 2017, 5:08 AM
stash added a comment to D1505: infinitepush: skip fastheadsdiscovery heuristic.

When were we seeing cases where there were public commits without a remote bookmark pointing at them?

Nov 30 2017, 4:47 AM

Nov 28 2017

stash accepted D1528: treedirstate: prevent interference with other dirstate implementations.
Nov 28 2017, 7:37 AM
stash requested changes to D1528: treedirstate: prevent interference with other dirstate implementations.

Ideally it would nice to have a test. Or at least can you add a test plan?

Nov 28 2017, 5:48 AM

Nov 27 2017

stash accepted D1510: treedirstate: extract serialization methods to separate module.
Nov 27 2017, 4:58 AM
stash accepted D1490: treedirstate: add integration tests.
Nov 27 2017, 4:53 AM
stash added inline comments to D1401: treedirstate: add Python linkage.
Nov 27 2017, 4:48 AM

Nov 24 2017

stash created D1507: fastpartialmatch: wrap only changelog.
Nov 24 2017, 10:17 AM
stash created D1505: infinitepush: skip fastheadsdiscovery heuristic.
Nov 24 2017, 6:58 AM

Nov 22 2017

stash added inline comments to D1399: treedirstate: add Tree.
Nov 22 2017, 5:58 AM
stash added inline comments to D1398: treedirstate: add FileStore.
Nov 22 2017, 4:49 AM
stash added a comment to D1454: treemanifest: use a connectionpool.

I think infinitepush can benefit from connection pool too, because now it recreates the same connection a few times

Nov 22 2017, 4:16 AM

Nov 21 2017

stash added inline comments to D1398: treedirstate: add FileStore.
Nov 21 2017, 5:21 AM
stash accepted D1396: treedirstate: add vecmap implementation.
Nov 21 2017, 5:12 AM
stash added a comment to D1466: smartlog: do not query branch.

Since branchinfo is fake now, maybe we can completely delete it?

Nov 21 2017, 4:35 AM
stash accepted D1452: perftweaks: micro optimization about branchcache.update.

I maybe missing something, but from your summary it's unclear how much time were saved with these optimizations. Can you include it?

Nov 21 2017, 4:32 AM

Nov 13 2017

stash added a comment to D1291: radixbuf: implement the main radix tree.

I had to spend quite a lot of time understanding the logic. Probably this problem can be solved with just a few comments:

  1. Mention why do we have 16 pointers in RadixNode
  2. Mention how does this radix tree work - that we may have "fat" leafs, that they may need to be split etc.
Nov 13 2017, 5:40 AM

Nov 3 2017

stash committed rFBHGXdd3eb0168d25: infinitepush: add reponame to WHERE clause.
infinitepush: add reponame to WHERE clause
Nov 3 2017, 11:40 AM
stash closed D1256: infinitepush: add reponame to WHERE clause.
Nov 3 2017, 11:40 AM

Nov 2 2017

stash accepted D1264: rage: add info useful for infinitepushbackup debug.
Nov 2 2017, 4:22 PM

Oct 30 2017

stash requested changes to D1264: rage: add info useful for infinitepushbackup debug.

Can you also write the test plan?

Oct 30 2017, 4:48 PM

Oct 27 2017

stash created D1256: infinitepush: add reponame to WHERE clause.
Oct 27 2017, 5:13 AM

Oct 25 2017

stash closed D1225: infinitepush: fix tests.
Oct 25 2017, 8:29 PM
stash committed rFBHGX045a1bd0cbdb: infinitepush: fix tests.
infinitepush: fix tests
Oct 25 2017, 8:29 PM
stash closed D1205: tests: register some config options.
Oct 25 2017, 8:29 PM
stash closed D1204: pushrebase: handle pushing phases through separate bundle2 part.
Oct 25 2017, 8:28 PM
stash committed rFBHGXb11d9934b9ce: pushrebase: handle pushing phases through separate bundle2 part.
pushrebase: handle pushing phases through separate bundle2 part
Oct 25 2017, 8:28 PM
stash committed rFBHGXb82c2a9890e5: tests: register some config options.
tests: register some config options
Oct 25 2017, 8:28 PM

Oct 24 2017

stash created D1225: infinitepush: fix tests.
Oct 24 2017, 12:28 PM

Oct 23 2017

stash updated the diff for D1204: pushrebase: handle pushing phases through separate bundle2 part.
Oct 23 2017, 1:36 PM
stash created D1205: tests: register some config options.
Oct 23 2017, 12:03 PM
stash updated the summary of D1204: pushrebase: handle pushing phases through separate bundle2 part.
Oct 23 2017, 7:09 AM
stash created D1204: pushrebase: handle pushing phases through separate bundle2 part.
Oct 23 2017, 7:08 AM

Oct 16 2017

stash added a comment to D987: copies: add a config to limit the number of candidates to check in heuristics.

@pulkit sorry for being late with the comments.
I agree with @yuja - falling back is not an option, because it's probably going to be slow.
As for these two options

Oct 16 2017, 11:27 AM

Oct 13 2017

stash accepted D1052: infinitepush: always read local backup state from source shared repo.
Oct 13 2017, 9:49 AM
stash created D1049: remotefilelog: add logging for prefetch during commit.
Oct 13 2017, 5:37 AM

Oct 5 2017

stash committed rFBHGXb1210b53a8b9: infinitepush: revert D721.
infinitepush: revert D721
Oct 5 2017, 1:28 PM
stash closed D921: infinitepush: revert D721.

It was landed

Oct 5 2017, 11:22 AM

Oct 3 2017

stash added a reviewer for D921: infinitepush: revert D721: durham.
Oct 3 2017, 8:47 AM
stash created D921: infinitepush: revert D721.
Oct 3 2017, 8:32 AM

Oct 1 2017

stash closed D837: remotefilelog: remove copy-paste in fastlog logging.
Oct 1 2017, 9:05 AM
stash closed D841: remotefilelog: add more logging for prefetching heuristics.
Oct 1 2017, 9:01 AM
stash closed D838: remotefilelog: add linknode fixup logging.
Oct 1 2017, 9:01 AM
stash closed D839: remotefilelog: time fastlog requests.
Oct 1 2017, 9:01 AM
stash closed D840: remotefilelog: move remofilelog prefetching to the separate function.
Oct 1 2017, 9:01 AM
stash committed rFBHGX809c8d8ad269: remotefilelog: add more logging for prefetching heuristics.
remotefilelog: add more logging for prefetching heuristics
Oct 1 2017, 9:01 AM
stash committed rFBHGXdbe3c004d629: remotefilelog: move remofilelog prefetching to the separate function.
remotefilelog: move remofilelog prefetching to the separate function
Oct 1 2017, 9:00 AM
stash committed rFBHGXf629119c6242: remotefilelog: time fastlog requests.
remotefilelog: time fastlog requests
Oct 1 2017, 9:00 AM
stash closed D836: remotefilelog: move fastlog logging inside _linknodeviafastlog.
Oct 1 2017, 9:00 AM
stash closed D837: remotefilelog: remove copy-paste in fastlog logging.
Oct 1 2017, 9:00 AM
stash closed D835: remotefilelog: change the name of logging category.
Oct 1 2017, 9:00 AM
stash committed rFBHGX3971b56b4d5b: remotefilelog: add linknode fixup logging.
remotefilelog: add linknode fixup logging
Oct 1 2017, 9:00 AM
stash committed rFBHGXc8760e5083d2: remotefilelog: remove copy-paste in fastlog logging.
remotefilelog: remove copy-paste in fastlog logging
Oct 1 2017, 9:00 AM
stash committed rFBHGX12a5b29086f8: remotefilelog: change the name of logging category.
remotefilelog: change the name of logging category
Oct 1 2017, 9:00 AM
stash committed rFBHGX6090ff970abe: remotefilelog: move fastlog logging inside _linknodeviafastlog.
remotefilelog: move fastlog logging inside _linknodeviafastlog
Oct 1 2017, 9:00 AM
stash committed rFBHGXb222eed2f5b4: sparse: fix check-commit test.
sparse: fix check-commit test
Oct 1 2017, 9:00 AM

Sep 30 2017

stash updated the diff for D841: remotefilelog: add more logging for prefetching heuristics.

rebase

Sep 30 2017, 3:32 PM
stash updated the diff for D839: remotefilelog: time fastlog requests.

rebase

Sep 30 2017, 3:28 PM
stash updated the diff for D838: remotefilelog: add linknode fixup logging.

add tests

Sep 30 2017, 3:15 PM
stash updated the diff for D838: remotefilelog: add linknode fixup logging.

addressed comments

Sep 30 2017, 2:45 PM
stash added a comment to D835: remotefilelog: change the name of logging category.

@quark , thanks for the pointer!

Sep 30 2017, 2:35 PM

Sep 28 2017

stash updated the summary of D841: remotefilelog: add more logging for prefetching heuristics.
Sep 28 2017, 1:10 PM
stash updated the summary of D840: remotefilelog: move remofilelog prefetching to the separate function.
Sep 28 2017, 1:10 PM
stash updated the summary of D839: remotefilelog: time fastlog requests.
Sep 28 2017, 1:10 PM
stash updated the summary of D838: remotefilelog: add linknode fixup logging.
Sep 28 2017, 1:10 PM
stash updated the summary of D837: remotefilelog: remove copy-paste in fastlog logging.
Sep 28 2017, 1:10 PM
stash updated the summary of D836: remotefilelog: move fastlog logging inside _linknodeviafastlog.
Sep 28 2017, 1:09 PM
stash updated the summary of D835: remotefilelog: change the name of logging category.
Sep 28 2017, 1:09 PM
stash added a dependency for D836: remotefilelog: move fastlog logging inside _linknodeviafastlog: D835: remotefilelog: change the name of logging category.
Sep 28 2017, 1:07 PM
stash added a dependent revision for D835: remotefilelog: change the name of logging category: D836: remotefilelog: move fastlog logging inside _linknodeviafastlog.
Sep 28 2017, 1:07 PM
stash added a dependency for D837: remotefilelog: remove copy-paste in fastlog logging: D836: remotefilelog: move fastlog logging inside _linknodeviafastlog.
Sep 28 2017, 1:07 PM
stash added a dependent revision for D836: remotefilelog: move fastlog logging inside _linknodeviafastlog: D837: remotefilelog: remove copy-paste in fastlog logging.
Sep 28 2017, 1:07 PM
stash added a dependency for D838: remotefilelog: add linknode fixup logging: D837: remotefilelog: remove copy-paste in fastlog logging.
Sep 28 2017, 1:06 PM
stash added a dependent revision for D837: remotefilelog: remove copy-paste in fastlog logging: D838: remotefilelog: add linknode fixup logging.
Sep 28 2017, 1:06 PM
stash added a dependency for D839: remotefilelog: time fastlog requests: D838: remotefilelog: add linknode fixup logging.
Sep 28 2017, 1:06 PM
stash added a dependent revision for D838: remotefilelog: add linknode fixup logging: D839: remotefilelog: time fastlog requests.
Sep 28 2017, 1:06 PM
stash added a dependency for D840: remotefilelog: move remofilelog prefetching to the separate function: D839: remotefilelog: time fastlog requests.
Sep 28 2017, 1:06 PM
stash added a dependent revision for D839: remotefilelog: time fastlog requests: D840: remotefilelog: move remofilelog prefetching to the separate function.
Sep 28 2017, 1:06 PM
stash added a dependency for D841: remotefilelog: add more logging for prefetching heuristics: D840: remotefilelog: move remofilelog prefetching to the separate function.
Sep 28 2017, 1:06 PM
stash added a dependent revision for D840: remotefilelog: move remofilelog prefetching to the separate function: D841: remotefilelog: add more logging for prefetching heuristics.
Sep 28 2017, 1:06 PM
stash created D841: remotefilelog: add more logging for prefetching heuristics.
Sep 28 2017, 1:05 PM
stash created D840: remotefilelog: move remofilelog prefetching to the separate function.
Sep 28 2017, 1:03 PM
stash created D839: remotefilelog: time fastlog requests.
Sep 28 2017, 1:01 PM
stash created D838: remotefilelog: add linknode fixup logging.
Sep 28 2017, 12:58 PM
stash created D837: remotefilelog: remove copy-paste in fastlog logging.
Sep 28 2017, 12:54 PM
stash created D836: remotefilelog: move fastlog logging inside _linknodeviafastlog.
Sep 28 2017, 12:49 PM
stash created D835: remotefilelog: change the name of logging category.
Sep 28 2017, 12:37 PM

Sep 27 2017

stash accepted D822: scm-prompt: update test for changed hg output.
Sep 27 2017, 9:23 AM

Sep 26 2017

stash accepted D801: p4fastimport: do not break other extensions.
Sep 26 2017, 3:28 AM