taapas1128 (Taapas Agrawal)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2018, 7:30 AM (18 w, 5 d)

Recent Activity

Today

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

Thank you for the help @pulkit . I have rebased it to the top.

Mon, Feb 18, 7:30 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Mon, Feb 18, 7:29 AM

Yesterday

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@durin42 I have sent the patch from hg-stable (https://www.mercurial-scm.org/repo/hg-stable) . Maybe it is this reason you are unable to apply the patch. Should I send a patch for hg repo ?

Sun, Feb 17, 11:14 PM
taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@durin42 to which rev should I rebase it to ?

Sun, Feb 17, 2:19 PM

Sat, Feb 16

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@durin42 I have made the change. Please review.

Sat, Feb 16, 2:32 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Sat, Feb 16, 2:31 AM

Fri, Feb 15

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit I have updated the description .

Fri, Feb 15, 10:35 AM
taapas1128 updated the summary of D5792: uncommit: added interactive mode(issue6062).
Fri, Feb 15, 10:34 AM

Tue, Feb 12

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit Can you please review this . I did not send a patch regarding -n flag because tests could be completed without it and also it would mean i would have to import large chunks of code.

Tue, Feb 12, 11:31 PM

Fri, Feb 8

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit Apparently it seems removing -n flag altogether will not interfere with the tests and they can be completed without that flag too . I have added inline comments please review.

Fri, Feb 8, 9:42 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Fri, Feb 8, 9:29 AM

Thu, Feb 7

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit I have added some inline comments . So what do you suggest one way can be merging this and I will send a follow up for integrating -n to hg uncommitand then amending the tests. The other way is I should send a request for -n flag and then make all these changes again as a follow up pr for that request.

Thu, Feb 7, 2:56 PM

Mon, Feb 4

taapas1128 committed rHGd783c937aa53: revert: add prompt before undeleting a file in -i (issue6008).
revert: add prompt before undeleting a file in -i (issue6008)
Mon, Feb 4, 4:55 PM
taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit I was able to import the tests and make them compatible with hg-stable . Some tests which include commands like hg obslog , hg amend --extract , and hg uncommit -n which are not part of hg-stable but evolve are not running else all tests are now running smoothly .

Mon, Feb 4, 9:23 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Mon, Feb 4, 9:19 AM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Mon, Feb 4, 9:12 AM

Sun, Feb 3

taapas1128 committed rHGa241b304129e: revert: add prompt before undeleting a file in -i (issue6008).
revert: add prompt before undeleting a file in -i (issue6008)
Sun, Feb 3, 11:58 PM
taapas1128 closed D5803: revert: added prompt before undeleting a file in -i(issue6008).
Sun, Feb 3, 7:48 AM
taapas1128 committed rHGf3f6719951a3: revert: add prompt before undeleting a file in -i (issue6008).
revert: add prompt before undeleting a file in -i (issue6008)
Sun, Feb 3, 7:48 AM

Sat, Feb 2

taapas1128 added a comment to D5803: revert: added prompt before undeleting a file in -i(issue6008).

@yuja thanks for the review . I have updated the revision please tell if anything else needs to be done.

Sat, Feb 2, 11:18 PM
taapas1128 updated the diff for D5803: revert: added prompt before undeleting a file in -i(issue6008).
Sat, Feb 2, 11:17 PM
taapas1128 updated the diff for D5803: revert: added prompt before undeleting a file in -i(issue6008).
Sat, Feb 2, 3:06 PM
taapas1128 updated the summary of D5803: revert: added prompt before undeleting a file in -i(issue6008).
Sat, Feb 2, 2:58 PM
taapas1128 created D5803: revert: added prompt before undeleting a file in -i(issue6008).
Sat, Feb 2, 2:56 PM
taapas1128 updated the summary of D5792: uncommit: added interactive mode(issue6062).
Sat, Feb 2, 1:16 PM
taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

@pulkit I have made an attempt to import the code please review. @lothiraldan can you please review and help me if I have missed out any portion of interactive from evolve

Sat, Feb 2, 1:14 PM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Sat, Feb 2, 1:11 PM

Fri, Feb 1

taapas1128 added a comment to D5792: uncommit: added interactive mode(issue6062).

Thanks for the review @pulkit . By importing do you suggest importing the code for interactive or someway is there is someway to link evolve to hg-stable ?

Fri, Feb 1, 2:17 PM
taapas1128 updated the diff for D5792: uncommit: added interactive mode(issue6062).
Fri, Feb 1, 2:42 AM
taapas1128 updated the summary of D5792: uncommit: added interactive mode(issue6062).
Fri, Feb 1, 2:40 AM
taapas1128 created D5792: uncommit: added interactive mode(issue6062).
Fri, Feb 1, 2:39 AM

Jan 14 2019

taapas1128 added a comment to D5577: tests: replaced mockmakedate function in test-amend.t.

@lothiraldan I am not sure but my aim is to supply mock values to dateutil.makedate() everytime is it called but I will go through what devel.default-date does .

Jan 14 2019, 7:50 AM
taapas1128 added a comment to D5577: tests: replaced mockmakedate function in test-amend.t.
Jan 14 2019, 7:28 AM

Jan 13 2019

taapas1128 closed D5577: tests: replaced mockmakedate function in test-amend.t.
Jan 13 2019, 9:38 PM
taapas1128 committed rHG8633c716f908: tests: replace mockmakedate function in test-amend.t.
tests: replace mockmakedate function in test-amend.t
Jan 13 2019, 9:38 PM
taapas1128 updated subscribers of D5577: tests: replaced mockmakedate function in test-amend.t.

@yuja please review this.

Jan 13 2019, 10:38 AM
taapas1128 added a comment to D5554: histedit: added rewrite.update-timestamp to fold and mess.

@yuja thanks for the edits and queuing .

Jan 13 2019, 7:39 AM
taapas1128 updated the summary of D5577: tests: replaced mockmakedate function in test-amend.t.
Jan 13 2019, 7:31 AM
taapas1128 created D5577: tests: replaced mockmakedate function in test-amend.t.
Jan 13 2019, 7:29 AM
taapas1128 committed rHG704a3aa3dc0a: histedit: add rewrite.update-timestamp support to fold and mess.
histedit: add rewrite.update-timestamp support to fold and mess
Jan 13 2019, 7:19 AM
taapas1128 closed D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 7:14 AM
taapas1128 committed rHG6459797090ea: histedit: add rewrite.update-timestamp support to fold and mess.
histedit: add rewrite.update-timestamp support to fold and mess
Jan 13 2019, 7:14 AM
taapas1128 updated the summary of D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 2:52 AM
taapas1128 updated the diff for D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 2:49 AM
taapas1128 updated the summary of D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 2:46 AM
taapas1128 updated the summary of D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 2:42 AM
taapas1128 added a comment to D5554: histedit: added rewrite.update-timestamp to fold and mess.

I have extracted mockdate function as tests/mockdate.py and dealt with the commas and spaces.

def commiteditor(self):
    """The editor to be used to edit the commit message."""

@@ -800,6 +804,8 @@

  1. date if self.firstdate(): commitopts['date'] = ctx.date() + elif ui.configbool('rewrite','update-timestamp'): + commitopts['date'] = dateutil.makedate() else: commitopts['date'] = max(ctx.date(), oldctx.date())

Yes this is not right time should be updated everytime update-timestamp is True . I have corrected it. @yuja please review.

Jan 13 2019, 2:38 AM
taapas1128 updated the diff for D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 2:35 AM
taapas1128 updated the diff for D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 2:11 AM
taapas1128 updated the diff for D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 1:51 AM
taapas1128 updated the diff for D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 13 2019, 1:48 AM

Jan 10 2019

taapas1128 updated the diff for D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 10 2019, 11:43 AM
taapas1128 updated subscribers of D5554: histedit: added rewrite.update-timestamp to fold and mess.

@pulkit please review.

Jan 10 2019, 10:44 AM
taapas1128 updated the summary of D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 10 2019, 10:43 AM
taapas1128 created D5554: histedit: added rewrite.update-timestamp to fold and mess.
Jan 10 2019, 10:39 AM

Jan 7 2019

taapas1128 abandoned D5513: amend: concise logic for rewrite.updatetimestamp.
Jan 7 2019, 10:06 AM
taapas1128 updated the summary of D5513: amend: concise logic for rewrite.updatetimestamp.
Jan 7 2019, 8:25 AM
taapas1128 created D5513: amend: concise logic for rewrite.updatetimestamp.
Jan 7 2019, 8:22 AM
taapas1128 committed rHG79f8f032c706: amend: add config option to update time to current in hg amend (issue5828).
amend: add config option to update time to current in hg amend (issue5828)
Jan 7 2019, 7:19 AM
taapas1128 added a comment to D5491: amend: added config option to update time to current in hg amend(issue5828).

Thanks for queueing. I will make the follow up patch for the inline comments that will make it more concise.

Jan 7 2019, 7:05 AM
taapas1128 closed D5491: amend: added config option to update time to current in hg amend(issue5828).
Jan 7 2019, 6:18 AM
taapas1128 committed rHGec51a430ec51: amend: added config option to update time to current in hg amend(issue5828).
amend: added config option to update time to current in hg amend(issue5828)
Jan 7 2019, 6:18 AM

Jan 5 2019

taapas1128 added a comment to D5491: amend: added config option to update time to current in hg amend(issue5828).

@pulkit done . Please review.

Jan 5 2019, 3:47 PM
taapas1128 updated the diff for D5491: amend: added config option to update time to current in hg amend(issue5828).
Jan 5 2019, 3:47 PM
taapas1128 updated the diff for D5491: amend: added config option to update time to current in hg amend(issue5828).
Jan 5 2019, 3:37 PM
taapas1128 updated the summary of D5491: amend: added config option to update time to current in hg amend(issue5828).
Jan 5 2019, 3:30 PM

Jan 4 2019

taapas1128 abandoned D5483: amend:added config option to update time to current in hg amend(issue5828).
Jan 4 2019, 2:58 PM
taapas1128 added a comment to D5491: amend: added config option to update time to current in hg amend(issue5828).

@pulkit dealt with test-check-code.t and test-check-commit.t . And dealt with test-amend.t by making mockmakedate() as in test-journal.t . I have run all the tests. Please review.

Jan 4 2019, 2:57 PM
taapas1128 abandoned D5492: Added signature for changeset 956ec6f1320d.
Jan 4 2019, 2:47 PM
taapas1128 updated the diff for D5491: amend: added config option to update time to current in hg amend(issue5828).
Jan 4 2019, 2:43 PM
taapas1128 created D5492: Added signature for changeset 956ec6f1320d.
Jan 4 2019, 2:41 PM
taapas1128 added a comment to D5491: amend: added config option to update time to current in hg amend(issue5828).

no the date is updated in 2560. So below that it wont work

Jan 4 2019, 10:56 AM
taapas1128 created D5491: amend: added config option to update time to current in hg amend(issue5828).
Jan 4 2019, 10:08 AM
taapas1128 added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

I think that would not be correct because we need to avoid date change update-timestamp is true and when no option is passed and no attribute is changed . Only when there is change in any of the attributes then only date is to be updated which can only be tested this way only.

Jan 4 2019, 9:41 AM
taapas1128 added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

@pulkit I have updated the revision accordingly. Please review

Jan 4 2019, 8:25 AM
taapas1128 updated the diff for D5483: amend:added config option to update time to current in hg amend(issue5828).
Jan 4 2019, 8:23 AM

Jan 3 2019

taapas1128 added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

@pulkit I have updated the revision. Sorry about the tests.Please review when you are free.

Jan 3 2019, 7:53 AM
taapas1128 updated the diff for D5483: amend:added config option to update time to current in hg amend(issue5828).
Jan 3 2019, 7:49 AM

Dec 30 2018

taapas1128 added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

@yuja Please review this

Dec 30 2018, 5:02 AM

Dec 27 2018

taapas1128 added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

@yuja Corrected the tests. Added in config.txt and changed the config option according to the guideline. Please review when you are free.

Dec 27 2018, 8:49 AM
taapas1128 updated the diff for D5483: amend:added config option to update time to current in hg amend(issue5828).
Dec 27 2018, 8:47 AM

Dec 26 2018

taapas1128 retitled D5483: amend:added config option to update time to current in hg amend(issue5828) from amend:Added rewrite.updatetimestamp config option(issue5828) to amend:added rewrite.updatetimestamp config option(issue5828).
Dec 26 2018, 9:06 AM
taapas1128 added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

@yuja I have updated the revision . Please review.

Dec 26 2018, 9:04 AM
taapas1128 updated the diff for D5483: amend:added config option to update time to current in hg amend(issue5828).
Dec 26 2018, 9:02 AM
taapas1128 added a comment to D5483: amend:added config option to update time to current in hg amend(issue5828).

In the tests I added two parts one with config option False and and another with True. I will correct the heading that part is with config turned off.
Okay I will change the config option to

rewrite.updatetimestamp

and will see how to get current timestamp from commands.graft() .

Dec 26 2018, 8:13 AM

Dec 25 2018

taapas1128 created D5483: amend:added config option to update time to current in hg amend(issue5828).
Dec 25 2018, 8:46 AM

Oct 11 2018

taapas1128 committed rHG58ebf5083843: push: add "remote" to 'repository changed while pushing' messages (issue5971).
push: add "remote" to 'repository changed while pushing' messages (issue5971)
Oct 11 2018, 7:45 AM
taapas1128 closed D4933: push:Added keyword remote to 'repository changed while pushing' error(Issue5971)(whitespaces fixed).
Oct 11 2018, 7:41 AM
taapas1128 committed rHG10e628a05725: push:Added keyword remote to 'repository changed while pushing' error….
push:Added keyword remote to 'repository changed while pushing' error…
Oct 11 2018, 7:41 AM

Oct 10 2018

taapas1128 created D4933: push:Added keyword remote to 'repository changed while pushing' error(Issue5971)(whitespaces fixed).
Oct 10 2018, 12:38 PM
taapas1128 created D4932: push:Added keyword remote to 'repository changed while pushing' error(Issue5971).
Oct 10 2018, 11:14 AM