- User Since
- Oct 10 2018, 7:30 AM (18 w, 5 d)
Thank you for the help @pulkit . I have rebased it to the top.
@durin42 to which rev should I rebase it to ?
Sat, Feb 16
@durin42 I have made the change. Please review.
Fri, Feb 15
@pulkit I have updated the description .
Tue, Feb 12
@pulkit Can you please review this . I did not send a patch regarding -n flag because tests could be completed without it and also it would mean i would have to import large chunks of code.
Fri, Feb 8
@pulkit Apparently it seems removing -n flag altogether will not interfere with the tests and they can be completed without that flag too . I have added inline comments please review.
Thu, Feb 7
@pulkit I have added some inline comments . So what do you suggest one way can be merging this and I will send a follow up for integrating -n to hg uncommitand then amending the tests. The other way is I should send a request for -n flag and then make all these changes again as a follow up pr for that request.
Mon, Feb 4
@pulkit I was able to import the tests and make them compatible with hg-stable . Some tests which include commands like hg obslog , hg amend --extract , and hg uncommit -n which are not part of hg-stable but evolve are not running else all tests are now running smoothly .
Sun, Feb 3
Sat, Feb 2
@yuja thanks for the review . I have updated the revision please tell if anything else needs to be done.
Fri, Feb 1
Thanks for the review @pulkit . By importing do you suggest importing the code for interactive or someway is there is someway to link evolve to hg-stable ?
Jan 14 2019
@lothiraldan I am not sure but my aim is to supply mock values to dateutil.makedate() everytime is it called but I will go through what devel.default-date does .
Jan 13 2019
@yuja please review this.
@yuja thanks for the edits and queuing .
I have extracted mockdate function as tests/mockdate.py and dealt with the commas and spaces.
def commiteditor(self): """The editor to be used to edit the commit message."""
@@ -800,6 +804,8 @@
- date if self.firstdate(): commitopts['date'] = ctx.date() + elif ui.configbool('rewrite','update-timestamp'): + commitopts['date'] = dateutil.makedate() else: commitopts['date'] = max(ctx.date(), oldctx.date())
Yes this is not right time should be updated everytime update-timestamp is True . I have corrected it. @yuja please review.
Jan 10 2019
@pulkit please review.
Jan 7 2019
Thanks for queueing. I will make the follow up patch for the inline comments that will make it more concise.
Jan 5 2019
@pulkit done . Please review.
Jan 4 2019
@pulkit dealt with test-check-code.t and test-check-commit.t . And dealt with test-amend.t by making mockmakedate() as in test-journal.t . I have run all the tests. Please review.
no the date is updated in 2560. So below that it wont work
I think that would not be correct because we need to avoid date change update-timestamp is true and when no option is passed and no attribute is changed . Only when there is change in any of the attributes then only date is to be updated which can only be tested this way only.
@pulkit I have updated the revision accordingly. Please review
Jan 3 2019
@pulkit I have updated the revision. Sorry about the tests.Please review when you are free.
Dec 30 2018
@yuja Please review this
Dec 27 2018
@yuja Corrected the tests. Added in config.txt and changed the config option according to the guideline. Please review when you are free.
Dec 26 2018
@yuja I have updated the revision . Please review.
In the tests I added two parts one with config option False and and another with True. I will correct the heading that part is with config turned off.
Okay I will change the config option to
and will see how to get current timestamp from commands.graft() .