- User Since
- Oct 10 2018, 7:30 AM (35 w, 4 d)
Fri, Jun 14
Thu, Jun 13
@martinvonz @pulkit passing merge through checkunfinished() with the correct allowcommit flag has led to change in the tests most of which are positive and the merge in progress which were detected by separate methods earlier can be detected by checkunfinished() alone. The only test that has given negative results in test-strip.t. I will try to improve that too.
Wed, Jun 12
yes, they do . as they did earlier no extra case has been generated.
Tue, Jun 11
@martinvonz I haven't changed anything regarding rebase and update on interrupted states hence not added any tests.
Mon, Jun 10
Sun, Jun 9
@martinvonz At first I didn't seem to realize why the patches need to be split that way but later I realized that I wasn't looking from the perspective of a reviewer but was just getting the job done as an author. Thanks for making me work this out :)
Sat, Jun 8
@martinvonz have a look at this stack now . It is strictly according to your guidelines.
I have squashed them now . Splitting them into exactly those steps would not have been possible that is why is split them this way. Is this alright for your reviewing or should I try splitting them again? :(
@martinvonz: Have a look now.
Regarding the message change that was previously in D6494 :
@martinvonz Is it alright now?
@martinvonz check it out I haveve done that.
@martinvonz Doing that would be kind of difficult because these changes are not due to refactoring but due to statecheck.hint() which is a unified function for generating hint messages. If I change the messages in accordance to cmdutil.unfinishedstates then this problem will be there in the in integration of STATES. If you still want it I can do that by removing statecheck.hint() completely and getting the messages from cmdutil.py. So should I do that ?
Fri, Jun 7
D6487 : A new statecheck class is created with its utility functions.
D6488 : A new list of statecheck objects is created and checkunfinished and clearunfinished are imported and modified in accordance to the class and the new list
D6494 : cmdutil.checkunfinished and cmdutil.clearunfinished is removed . Throughout core and extensions they are replaced by statemod.checkunfinished and statemod.clearunfinished. Also, the previous appends in extensions that were made to cmdutil.unfinishedstates are now made to statemod.unfinishedstates as statecheck objects. Tests results are stated
D6495 : Support for the functionalities is added to`cmdutil.STATES` is added to statemod.unfinishedstates. So cmdutil.STATES is completely removed . Tests results are stated.
@martinvonz I have updated the stack(D6487, D6488, D6494) for review up to incorporation of the checkunfinisheds() and clearunfinished() in the new API. Tests are in 3rd commit D6494. have a look whenever you are free.
@martinvonz okay I will do that then send the whole code divided as patches.