Page MenuHomePhabricator

taapas1128 (Taapas Agrawal)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2018, 7:30 AM (35 w, 4 d)

Recent Activity

Yesterday

taapas1128 updated the summary of D6501: state: created new class statecheck to handle unfinishedstates.
Sat, Jun 15, 6:43 AM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Sat, Jun 15, 6:43 AM
taapas1128 updated the summary of D6503: statecheck: added support for STATES.
Sat, Jun 15, 6:42 AM
taapas1128 updated the summary of D6501: state: created new class statecheck to handle unfinishedstates.
Sat, Jun 15, 6:40 AM
taapas1128 updated the diff for D6502: state: moved cmdutil.STATES and utilities to state.py.
Sat, Jun 15, 6:40 AM

Fri, Jun 14

taapas1128 updated the summary of D6503: statecheck: added support for STATES.
Fri, Jun 14, 3:48 PM
taapas1128 updated the summary of D6501: state: created new class statecheck to handle unfinishedstates.
Fri, Jun 14, 3:47 PM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Fri, Jun 14, 3:35 PM
taapas1128 updated the diff for D6501: state: created new class statecheck to handle unfinishedstates.
Fri, Jun 14, 3:28 PM
taapas1128 updated the diff for D6502: state: moved cmdutil.STATES and utilities to state.py.
Fri, Jun 14, 3:28 PM
taapas1128 closed D6529: strip: during merge allow strip only when -f is used.
Fri, Jun 14, 11:22 AM
taapas1128 committed rHG1acaa9f37377: strip: during merge allow strip only when -f is used.
strip: during merge allow strip only when -f is used
Fri, Jun 14, 11:22 AM
taapas1128 updated the diff for D6529: strip: during merge allow strip only when -f is used.
Fri, Jun 14, 10:15 AM
taapas1128 created D6529: strip: during merge allow strip only when -f is used.
Fri, Jun 14, 8:59 AM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Fri, Jun 14, 4:36 AM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Fri, Jun 14, 4:35 AM

Thu, Jun 13

taapas1128 added a comment to D6503: statecheck: added support for STATES.

@martinvonz @pulkit passing merge through checkunfinished() with the correct allowcommit flag has led to change in the tests most of which are positive and the merge in progress which were detected by separate methods earlier can be detected by checkunfinished() alone. The only test that has given negative results in test-strip.t. I will try to improve that too.

Thu, Jun 13, 5:51 PM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Thu, Jun 13, 5:49 PM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Thu, Jun 13, 5:48 PM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Thu, Jun 13, 5:44 PM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Thu, Jun 13, 5:43 PM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Thu, Jun 13, 4:54 PM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Thu, Jun 13, 4:54 PM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Thu, Jun 13, 4:46 PM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Thu, Jun 13, 4:46 PM
taapas1128 added inline comments to D6503: statecheck: added support for STATES.
Thu, Jun 13, 9:22 AM
taapas1128 updated the summary of D6503: statecheck: added support for STATES.
Thu, Jun 13, 9:21 AM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Thu, Jun 13, 9:21 AM

Wed, Jun 12

taapas1128 added inline comments to D6503: statecheck: added support for STATES.
Wed, Jun 12, 4:10 PM
taapas1128 added a comment to D6503: statecheck: added support for STATES.

yes, they do . as they did earlier no extra case has been generated.

Wed, Jun 12, 2:53 PM

Tue, Jun 11

taapas1128 added a comment to D6503: statecheck: added support for STATES.

@martinvonz I haven't changed anything regarding rebase and update on interrupted states hence not added any tests.

Tue, Jun 11, 1:25 PM
taapas1128 added inline comments to D6503: statecheck: added support for STATES.
Tue, Jun 11, 1:19 PM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Tue, Jun 11, 9:50 AM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Tue, Jun 11, 9:49 AM
taapas1128 updated the diff for D6501: state: created new class statecheck to handle unfinishedstates.
Tue, Jun 11, 9:48 AM
taapas1128 updated the diff for D6502: state: moved cmdutil.STATES and utilities to state.py.
Tue, Jun 11, 9:48 AM
taapas1128 added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Tue, Jun 11, 4:28 AM
taapas1128 added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Tue, Jun 11, 4:25 AM
taapas1128 updated subscribers of D6503: statecheck: added support for STATES.
Tue, Jun 11, 4:21 AM

Mon, Jun 10

taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Mon, Jun 10, 2:35 PM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Mon, Jun 10, 2:33 PM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Mon, Jun 10, 1:57 PM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Mon, Jun 10, 1:55 PM
taapas1128 updated the diff for D6501: state: created new class statecheck to handle unfinishedstates.
Mon, Jun 10, 1:55 PM
taapas1128 updated the diff for D6502: state: moved cmdutil.STATES and utilities to state.py.
Mon, Jun 10, 1:54 PM
taapas1128 added inline comments to D6503: statecheck: added support for STATES.
Mon, Jun 10, 10:58 AM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Mon, Jun 10, 10:56 AM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Mon, Jun 10, 10:54 AM
taapas1128 updated the diff for D6501: state: created new class statecheck to handle unfinishedstates.
Mon, Jun 10, 10:53 AM
taapas1128 updated the diff for D6502: state: moved cmdutil.STATES and utilities to state.py.
Mon, Jun 10, 10:53 AM

Sun, Jun 9

taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Sun, Jun 9, 10:50 AM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Sun, Jun 9, 10:48 AM
taapas1128 updated the diff for D6501: state: created new class statecheck to handle unfinishedstates.
Sun, Jun 9, 10:48 AM
taapas1128 added inline comments to D6502: state: moved cmdutil.STATES and utilities to state.py.
Sun, Jun 9, 8:59 AM
taapas1128 added inline comments to D6502: state: moved cmdutil.STATES and utilities to state.py.
Sun, Jun 9, 8:58 AM
taapas1128 updated the diff for D6504: statecheck: changed hint message format.
Sun, Jun 9, 8:57 AM
taapas1128 updated the diff for D6484: states: moved cmdutil.unfinishedstates to state.py.
Sun, Jun 9, 8:56 AM
taapas1128 updated the diff for D6503: statecheck: added support for STATES.
Sun, Jun 9, 8:54 AM
taapas1128 updated the diff for D6501: state: created new class statecheck to handle unfinishedstates.
Sun, Jun 9, 8:53 AM
taapas1128 updated the diff for D6502: state: moved cmdutil.STATES and utilities to state.py.
Sun, Jun 9, 8:53 AM
taapas1128 updated the diff for D6502: state: moved cmdutil.STATES and utilities to state.py.
Sun, Jun 9, 8:32 AM
taapas1128 added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Sun, Jun 9, 7:11 AM
taapas1128 updated the diff for D6501: state: created new class statecheck to handle unfinishedstates.
Sun, Jun 9, 7:08 AM
taapas1128 added inline comments to D6501: state: created new class statecheck to handle unfinishedstates.
Sun, Jun 9, 6:29 AM
taapas1128 added a comment to D6484: states: moved cmdutil.unfinishedstates to state.py.

@martinvonz At first I didn't seem to realize why the patches need to be split that way but later I realized that I wasn't looking from the perspective of a reviewer but was just getting the job done as an author. Thanks for making me work this out :)

Sun, Jun 9, 6:05 AM

Sat, Jun 8

Herald added a reviewer for D6504: statecheck: changed hint message format: durin42.
Sat, Jun 8, 5:01 PM
taapas1128 updated the diff for D6484: states: moved cmdutil.unfinishedstates to state.py.
Sat, Jun 8, 5:01 PM
taapas1128 abandoned D6495: statecheck: added functionality for cmdutil.STATES.
Sat, Jun 8, 5:01 PM
taapas1128 abandoned D6487: states: created new class to handle multi-step unfinished states.
Sat, Jun 8, 5:00 PM
taapas1128 added a comment to D6484: states: moved cmdutil.unfinishedstates to state.py.

@martinvonz have a look at this stack now . It is strictly according to your guidelines.

Sat, Jun 8, 5:00 PM
taapas1128 created D6503: statecheck: added support for STATES.
Sat, Jun 8, 4:59 PM
Herald added a reviewer for D6501: state: created new class statecheck to handle unfinishedstates: durin42.
Sat, Jun 8, 4:58 PM
taapas1128 created D6502: state: moved cmdutil.STATES and utilities to state.py.
Sat, Jun 8, 4:58 PM
taapas1128 added a comment to D6487: states: created new class to handle multi-step unfinished states.

I have squashed them now . Splitting them into exactly those steps would not have been possible that is why is split them this way. Is this alright for your reviewing or should I try splitting them again? :(

Sat, Jun 8, 1:01 PM
taapas1128 updated the diff for D6487: states: created new class to handle multi-step unfinished states.
Sat, Jun 8, 12:36 PM
taapas1128 added a comment to D6487: states: created new class to handle multi-step unfinished states.

@martinvonz: Have a look now.

Sat, Jun 8, 12:34 PM
taapas1128 abandoned D6488: statecheck: added support for unfinishedstates and utilities.
Sat, Jun 8, 12:32 PM
taapas1128 updated the diff for D6495: statecheck: added functionality for cmdutil.STATES.
Sat, Jun 8, 12:31 PM
taapas1128 added a comment to D6487: states: created new class to handle multi-step unfinished states.

So should I squash the D6487 and D6488 too? That would make this patch really long as the very first patch that I sent?

Sat, Jun 8, 12:21 PM
taapas1128 added a comment to D6487: states: created new class to handle multi-step unfinished states.

Regarding the message change that was previously in D6494 :

Sat, Jun 8, 11:52 AM
taapas1128 requested review of D6487: states: created new class to handle multi-step unfinished states.
Sat, Jun 8, 11:43 AM
taapas1128 added a comment to D6487: states: created new class to handle multi-step unfinished states.

@martinvonz Is it alright now?

Sat, Jun 8, 11:41 AM
taapas1128 abandoned D6494: statecheck: added support for the statecheck.unfinishedstates.
Sat, Jun 8, 11:40 AM
taapas1128 requested review of D6487: states: created new class to handle multi-step unfinished states.

@martinvonz check it out I haveve done that.

Sat, Jun 8, 11:25 AM
taapas1128 requested review of D6494: statecheck: added support for the statecheck.unfinishedstates.

@martinvonz Doing that would be kind of difficult because these changes are not due to refactoring but due to statecheck.hint() which is a unified function for generating hint messages. If I change the messages in accordance to cmdutil.unfinishedstates then this problem will be there in the in integration of STATES. If you still want it I can do that by removing statecheck.hint() completely and getting the messages from cmdutil.py. So should I do that ?

Sat, Jun 8, 11:24 AM
taapas1128 updated the diff for D6488: statecheck: added support for unfinishedstates and utilities.
Sat, Jun 8, 11:19 AM
taapas1128 updated the diff for D6495: statecheck: added functionality for cmdutil.STATES.
Sat, Jun 8, 11:16 AM

Fri, Jun 7

taapas1128 added a comment to D6487: states: created new class to handle multi-step unfinished states.

@martinvonz @pulkit : Have a look now the stack is complete.

Fri, Jun 7, 3:53 PM
taapas1128 requested review of D6487: states: created new class to handle multi-step unfinished states.

D6487 : A new statecheck class is created with its utility functions.
D6488 : A new list of statecheck objects is created and checkunfinished and clearunfinished are imported and modified in accordance to the class and the new list
D6494 : cmdutil.checkunfinished and cmdutil.clearunfinished is removed . Throughout core and extensions they are replaced by statemod.checkunfinished and statemod.clearunfinished. Also, the previous appends in extensions that were made to cmdutil.unfinishedstates are now made to statemod.unfinishedstates as statecheck objects. Tests results are stated
D6495 : Support for the functionalities is added to`cmdutil.STATES` is added to statemod.unfinishedstates. So cmdutil.STATES is completely removed . Tests results are stated.

Fri, Jun 7, 3:52 PM
taapas1128 updated the diff for D6494: statecheck: added support for the statecheck.unfinishedstates.
Fri, Jun 7, 3:45 PM
taapas1128 created D6495: statecheck: added functionality for cmdutil.STATES.
Fri, Jun 7, 3:42 PM
taapas1128 requested review of D6487: states: created new class to handle multi-step unfinished states.

@martinvonz I have updated the stack(D6487, D6488, D6494) for review up to incorporation of the checkunfinisheds() and clearunfinished() in the new API. Tests are in 3rd commit D6494. have a look whenever you are free.

Fri, Jun 7, 12:11 PM
Herald added a reviewer for D6494: statecheck: added support for the statecheck.unfinishedstates: durin42.
Fri, Jun 7, 12:11 PM
taapas1128 updated the diff for D6488: statecheck: added support for unfinishedstates and utilities.
Fri, Jun 7, 12:06 PM
taapas1128 updated the diff for D6488: statecheck: added support for unfinishedstates and utilities.
Fri, Jun 7, 10:26 AM
taapas1128 updated the diff for D6487: states: created new class to handle multi-step unfinished states.
Fri, Jun 7, 10:25 AM
taapas1128 added a comment to D6487: states: created new class to handle multi-step unfinished states.

@martinvonz okay I will do that then send the whole code divided as patches.

Fri, Jun 7, 9:49 AM
taapas1128 updated the diff for D6487: states: created new class to handle multi-step unfinished states.
Fri, Jun 7, 9:42 AM
taapas1128 created D6488: statecheck: added support for unfinishedstates and utilities.
Fri, Jun 7, 3:43 AM
taapas1128 created D6487: states: created new class to handle multi-step unfinished states.
Fri, Jun 7, 3:42 AM