Page MenuHomePhabricator

valentin.gatienbaron (Valentin Gatien-Baron)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2018, 11:42 AM (81 w, 4 d)

Recent Activity

Today

valentin.gatienbaron committed rHGefd73cdcfbac: relnotes: move entry to the right spot.
relnotes: move entry to the right spot
Thu, Feb 27, 3:12 AM
valentin.gatienbaron closed D8151: relnotes: move entry to the right spot.
Thu, Feb 27, 3:11 AM

Yesterday

valentin.gatienbaron committed rHG218feb1a7e00: graft: always allow hg graft --base . (issue6248).
graft: always allow hg graft --base . (issue6248)
Wed, Feb 26, 11:52 AM
valentin.gatienbaron created D8151: relnotes: move entry to the right spot.
Wed, Feb 26, 10:57 AM
valentin.gatienbaron closed D8127: graft: always allow hg graft --base . (issue6248).
Wed, Feb 26, 10:33 AM
valentin.gatienbaron committed rHG2e534a710b15: graft: always allow hg graft --base . (issue6248).
graft: always allow hg graft --base . (issue6248)
Wed, Feb 26, 10:32 AM

Fri, Feb 21

valentin.gatienbaron added a comment to D8116: bookmarks: refactor in preparation for next commit.

Sorry, I had tried installing black, but it was not the right version. After looking some more, pip3 install black is what was needed I think.

Fri, Feb 21, 9:13 AM
valentin.gatienbaron closed D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote).
Fri, Feb 21, 4:56 AM
valentin.gatienbaron committed rHG8407031f195f: bookmarks: prevent pushes of divergent bookmarks (foo@remote).
bookmarks: prevent pushes of divergent bookmarks (foo@remote)
Fri, Feb 21, 4:56 AM
valentin.gatienbaron closed D8116: bookmarks: refactor in preparation for next commit.
Fri, Feb 21, 4:55 AM
valentin.gatienbaron committed rHG0275000564c4: bookmarks: refactor in preparation for next commit.
bookmarks: refactor in preparation for next commit
Fri, Feb 21, 4:55 AM
valentin.gatienbaron closed D8124: bookmarks: avoid traceback when two pushes race to delete the same bookmark.
Fri, Feb 21, 4:55 AM
valentin.gatienbaron committed rHGedaae3616ba3: bookmarks: avoid traceback when two pushes race to delete the same bookmark.
bookmarks: avoid traceback when two pushes race to delete the same bookmark
Fri, Feb 21, 4:55 AM
valentin.gatienbaron committed rHG815c63526d1d: relnotes: add entry about previous `hg recover` change.
relnotes: add entry about previous `hg recover` change
Fri, Feb 21, 4:55 AM
valentin.gatienbaron closed D8123: relnotes: add entry about previous `hg recover` change.
Fri, Feb 21, 4:55 AM

Mon, Feb 17

valentin.gatienbaron created D8127: graft: always allow hg graft --base . (issue6248).
Mon, Feb 17, 9:30 PM

Sat, Feb 15

valentin.gatienbaron created D8124: bookmarks: avoid traceback when two pushes race to delete the same bookmark.
Sat, Feb 15, 4:05 PM
valentin.gatienbaron updated the diff for D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote).
Sat, Feb 15, 3:10 PM
valentin.gatienbaron created D8123: relnotes: add entry about previous `hg recover` change.
Sat, Feb 15, 3:07 PM

Thu, Feb 13

valentin.gatienbaron created D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote).
Thu, Feb 13, 11:32 PM
valentin.gatienbaron created D8116: bookmarks: refactor in preparation for next commit.
Thu, Feb 13, 11:32 PM

Wed, Feb 12

valentin.gatienbaron closed D7972: recover: don't verify by default.
Wed, Feb 12, 2:26 PM
valentin.gatienbaron committed rHG7a4e1d245f19: recover: don't verify by default.
recover: don't verify by default
Wed, Feb 12, 2:25 PM

Tue, Feb 11

valentin.gatienbaron added a comment to D7972: recover: don't verify by default.

I _think_ it's just paranoia. As long as the bundle wasn't woefully corrupt, it shouldn't be a problem. I _think_ if we set some of the [server]-section bundle validation options (which should be cheap enough) we could ditch this completely safely.
As it stands, I'm fine with this patch if someone else has the confidence to push it.

Tue, Feb 11, 9:49 AM

Mon, Feb 10

valentin.gatienbaron closed D8101: help: when possible, indicate flags implied by tweakdefaults.
Mon, Feb 10, 5:03 PM
valentin.gatienbaron closed D8100: help: add a mechanism to change flags' help depending on config.
Mon, Feb 10, 5:02 PM
valentin.gatienbaron committed rHG5830efce522b: help: when possible, indicate flags implied by tweakdefaults.
help: when possible, indicate flags implied by tweakdefaults
Mon, Feb 10, 5:01 PM
valentin.gatienbaron committed rHG142d2a4cb69a: help: add a mechanism to change flags' help depending on config.
help: add a mechanism to change flags' help depending on config
Mon, Feb 10, 5:01 PM
valentin.gatienbaron closed D8093: tags: add a debug command to display .hg/cache/hgtagsfnodes1.
Mon, Feb 10, 1:02 PM
valentin.gatienbaron closed D8096: purge: add -i flag to delete ignored files instead of untracked files.
Mon, Feb 10, 1:02 PM
valentin.gatienbaron closed D8095: tags: behave better if a tags cache entry is partially written.
Mon, Feb 10, 1:02 PM
valentin.gatienbaron committed rHGf5a7cf0adb12: tags: behave better if a tags cache entry is partially written.
tags: behave better if a tags cache entry is partially written
Mon, Feb 10, 1:02 PM
valentin.gatienbaron closed D8094: tags: show how hg behaves if a tags cache entry is truncated.
Mon, Feb 10, 1:02 PM
valentin.gatienbaron committed rHG89d44cfcdeeb: tags: show how hg behaves if a tags cache entry is truncated.
tags: show how hg behaves if a tags cache entry is truncated
Mon, Feb 10, 1:01 PM
valentin.gatienbaron committed rHGd8b53385b1bc: tags: add a debug command to display .hg/cache/hgtagsfnodes1.
tags: add a debug command to display .hg/cache/hgtagsfnodes1
Mon, Feb 10, 1:01 PM
valentin.gatienbaron committed rHG9f8eddd2723f: purge: add -i flag to delete ignored files instead of untracked files.
purge: add -i flag to delete ignored files instead of untracked files
Mon, Feb 10, 1:01 PM
valentin.gatienbaron added a comment to D8096: purge: add -i flag to delete ignored files instead of untracked files.

I thought it was generally preferred to have the False in the code, for extensions that want to call the function?

Mon, Feb 10, 11:59 AM
valentin.gatienbaron updated the diff for D8096: purge: add -i flag to delete ignored files instead of untracked files.
Mon, Feb 10, 11:46 AM

Sun, Feb 9

valentin.gatienbaron created D8101: help: when possible, indicate flags implied by tweakdefaults.
Sun, Feb 9, 7:12 PM
valentin.gatienbaron created D8100: help: add a mechanism to change flags' help depending on config.
Sun, Feb 9, 7:12 PM

Sat, Feb 8

valentin.gatienbaron updated the diff for D8096: purge: add -i flag to delete ignored files instead of untracked files.
Sat, Feb 8, 1:11 PM
valentin.gatienbaron created D8096: purge: add -i flag to delete ignored files instead of untracked files.
Sat, Feb 8, 11:00 AM

Fri, Feb 7

valentin.gatienbaron created D8093: tags: add a debug command to display .hg/cache/hgtagsfnodes1.
Fri, Feb 7, 4:35 PM
valentin.gatienbaron created D8095: tags: behave better if a tags cache entry is partially written.
Fri, Feb 7, 4:35 PM
valentin.gatienbaron created D8094: tags: show how hg behaves if a tags cache entry is truncated.
Fri, Feb 7, 4:35 PM

Jan 23 2020

valentin.gatienbaron closed D7971: recover: fix typos.
Jan 23 2020, 7:46 AM
valentin.gatienbaron committed rHGe96ed3a61899: recover: fix typos.
recover: fix typos
Jan 23 2020, 7:46 AM

Jan 22 2020

valentin.gatienbaron added a comment to D7972: recover: don't verify by default.

It's already possible to control the default, like so:

Jan 22 2020, 9:22 PM
valentin.gatienbaron created D7972: recover: don't verify by default.
Jan 22 2020, 2:50 PM
valentin.gatienbaron created D7971: recover: fix typos.
Jan 22 2020, 2:49 PM

Jan 21 2020

valentin.gatienbaron closed D7952: rust: add a README.
Jan 21 2020, 11:26 AM
valentin.gatienbaron committed rHGe1b8b4e4f496: rust: add a README.
rust: add a README
Jan 21 2020, 11:25 AM
valentin.gatienbaron added inline comments to D7952: rust: add a README.
Jan 21 2020, 9:38 AM
valentin.gatienbaron added a comment to D7952: rust: add a README.

I didn't mention setup.py --rust because the toplevel readme doesn't mention setup.py, so I don't really know if that's really how mercurial is intended to be built or an implementation detail.

Jan 21 2020, 9:35 AM
valentin.gatienbaron updated the diff for D7952: rust: add a README.
Jan 21 2020, 9:33 AM
valentin.gatienbaron closed D7951: rust: move hgcli's README out of the way.
Jan 21 2020, 8:03 AM
valentin.gatienbaron committed rHG8a3b045d9086: rust: move hgcli's README out of the way.
rust: move hgcli's README out of the way
Jan 21 2020, 8:02 AM

Jan 20 2020

valentin.gatienbaron created D7952: rust: add a README.
Jan 20 2020, 6:36 PM
valentin.gatienbaron created D7951: rust: move hgcli's README out of the way.
Jan 20 2020, 6:36 PM

Nov 19 2019

valentin.gatienbaron added a comment to D7199: lock: fix race in lock-breaking code.

Thanks for the review. Did something go wrong in a rebase? I'm confused as to why there's two self.vfs.unlink calls in the diff displayed by phabricator.

Nov 19 2019, 12:06 AM

Nov 18 2019

valentin.gatienbaron committed rHG039fbd14d4e2: lock: fix race in lock-breaking code.
lock: fix race in lock-breaking code
Nov 18 2019, 11:11 PM
valentin.gatienbaron closed D7199: lock: fix race in lock-breaking code.
Nov 18 2019, 11:05 PM
valentin.gatienbaron committed rHG355a6ef12ba9: lock: fix race in lock-breaking code.
lock: fix race in lock-breaking code
Nov 18 2019, 11:05 PM
valentin.gatienbaron closed D7198: lock: refactor in preparation for next commit.
Nov 18 2019, 11:05 PM
valentin.gatienbaron committed rHGcd822413b9aa: lock: refactor in preparation for next commit.
lock: refactor in preparation for next commit
Nov 18 2019, 11:05 PM

Nov 1 2019

valentin.gatienbaron updated the summary of D7199: lock: fix race in lock-breaking code.
Nov 1 2019, 10:04 PM
valentin.gatienbaron updated the summary of D7199: lock: fix race in lock-breaking code.
Nov 1 2019, 10:02 PM
valentin.gatienbaron updated the summary of D7199: lock: fix race in lock-breaking code.
Nov 1 2019, 9:56 PM
valentin.gatienbaron created D7199: lock: fix race in lock-breaking code.
Nov 1 2019, 9:51 PM
valentin.gatienbaron created D7198: lock: refactor in preparation for next commit.
Nov 1 2019, 9:51 PM

Sep 14 2019

valentin.gatienbaron added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

I showed in D6847 the same change but implemented in exchange._processcompared. Tests pass.
I think it'd make for a simpler final state: with the current change, the client sees that the bookmark is going to move sideways, decides this is fine, requests that the server validates that the bookmark is indeed moving sideways (which it does), but in the end the server rejects the move. In the suggested change, the client sees that the bookmark is going sideways and rejects it. This should be consistent with the way new heads or new branches or diverging rewrites are prevented.

Isn't that a client-side change only though, so we still need functionality on the server to reject bad pushes? (I could be missing something.)

Sep 14 2019, 1:56 AM

Sep 13 2019

valentin.gatienbaron added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

I showed in D6847 the same change but implemented in exchange._processcompared. Tests pass.
I think it'd make for a simpler final state: with the current change, the client sees that the bookmark is going to move sideways, decides this is fine, requests that the server validates that the bookmark is indeed moving sideways (which it does), but in the end the server rejects the move. In the suggested change, the client sees that the bookmark is going sideways and rejects it. This should be consistent with the way new heads or new branches or diverging rewrites are prevented.

Sep 13 2019, 12:33 AM
valentin.gatienbaron created D6847: dont-accept-this: this is for reference in D6776.
Sep 13 2019, 12:25 AM

Sep 11 2019

valentin.gatienbaron closed D6831: exchange: convert bookmark nodes from hex to bin ASAP.
Sep 11 2019, 11:34 AM
valentin.gatienbaron closed D6830: exchange: avoid unnecessary conversion of bookmark nodes to hex (API).
Sep 11 2019, 11:34 AM
valentin.gatienbaron committed rHG9fd7710d9ae2: exchange: convert bookmark nodes from hex to bin ASAP.
exchange: convert bookmark nodes from hex to bin ASAP
Sep 11 2019, 11:34 AM
valentin.gatienbaron committed rHGe0bf41b83cef: exchange: avoid unnecessary conversion of bookmark nodes to hex (API).
exchange: avoid unnecessary conversion of bookmark nodes to hex (API)
Sep 11 2019, 11:34 AM

Sep 9 2019

valentin.gatienbaron closed D6829: doc: fix up confusing doc comment.
Sep 9 2019, 12:10 PM
valentin.gatienbaron committed rHG08fce968d00b: doc: fix up confusing doc comment.
doc: fix up confusing doc comment
Sep 9 2019, 12:09 PM

Sep 8 2019

valentin.gatienbaron created D6831: exchange: convert bookmark nodes from hex to bin ASAP.
Sep 8 2019, 8:43 PM
valentin.gatienbaron created D6829: doc: fix up confusing doc comment.
Sep 8 2019, 8:43 PM
valentin.gatienbaron created D6830: exchange: avoid unnecessary conversion of bookmark nodes to hex (API).
Sep 8 2019, 8:42 PM

Sep 6 2019

valentin.gatienbaron committed rHG69195b6f8f97: rustfilepatterns: shorter code for concatenating slices.
rustfilepatterns: shorter code for concatenating slices
Sep 6 2019, 11:28 PM
valentin.gatienbaron committed rHG72890d8f9860: match: simplify the regexps created for glob patterns.
match: simplify the regexps created for glob patterns
Sep 6 2019, 11:28 PM

Sep 5 2019

valentin.gatienbaron closed D6764: match: simplify the regexps created for glob patterns.
Sep 5 2019, 3:16 PM
valentin.gatienbaron closed D6765: rustfilepatterns: shorter code for concatenating slices.
Sep 5 2019, 3:16 PM
valentin.gatienbaron committed rHG406bd21d363b: rustfilepatterns: shorter code for concatenating slices.
rustfilepatterns: shorter code for concatenating slices
Sep 5 2019, 3:16 PM
valentin.gatienbaron closed D6766: rustfilepatterns: refactor the pattern of removing a prefix from a &[u8].
Sep 5 2019, 3:16 PM
valentin.gatienbaron committed rHGcf165e064f1d: match: simplify the regexps created for glob patterns.
match: simplify the regexps created for glob patterns
Sep 5 2019, 3:16 PM
valentin.gatienbaron committed rHG62eabdf91f85: rustfilepatterns: refactor the pattern of removing a prefix from a &[u8].
rustfilepatterns: refactor the pattern of removing a prefix from a &[u8]
Sep 5 2019, 3:16 PM
valentin.gatienbaron closed D6763: tests: show the pattern generated for a relative glob.
Sep 5 2019, 3:15 PM
valentin.gatienbaron committed rHG96ddf83fc267: tests: show the pattern generated for a relative glob.
tests: show the pattern generated for a relative glob
Sep 5 2019, 3:15 PM

Sep 1 2019

valentin.gatienbaron added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

(just interested in this change, I don't have any power to actually accept it)

Sep 1 2019, 5:54 PM

Aug 31 2019

valentin.gatienbaron committed rHGee0f511b7a22: rust: fix warnings about trait objects without dyn being deprecated.
rust: fix warnings about trait objects without dyn being deprecated
Aug 31 2019, 11:10 PM
valentin.gatienbaron closed D6770: rust: fix warnings about trait objects without dyn being deprecated.
Aug 31 2019, 6:59 PM
valentin.gatienbaron committed rHGae2a4ef8af02: rust: fix warnings about trait objects without dyn being deprecated.
rust: fix warnings about trait objects without dyn being deprecated
Aug 31 2019, 6:59 PM

Aug 28 2019

valentin.gatienbaron created D6770: rust: fix warnings about trait objects without dyn being deprecated.
Aug 28 2019, 8:19 AM
valentin.gatienbaron added inline comments to D6765: rustfilepatterns: shorter code for concatenating slices.
Aug 28 2019, 7:59 AM
valentin.gatienbaron updated the diff for D6765: rustfilepatterns: shorter code for concatenating slices.
Aug 28 2019, 7:55 AM
valentin.gatienbaron abandoned D6769: another way of implementing the parent.
Aug 28 2019, 7:54 AM