Page MenuHomePhabricator

valentin.gatienbaron (Valentin Gatien-Baron)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2018, 11:42 AM (129 w, 1 d)

Recent Activity

Today

valentin.gatienbaron added a comment to D9020: sshpeer: avoid having a destructor that can block forks forever.

Closing the peer is what I was describing as solution 3 in D9019. But I think I was wrong in saying that it doesn't help with calls to logtoprocess in the middle of commands. I also just noticed that does that, in fact. I'll try and find some time to do that.

Mon, Jan 25, 11:49 AM
valentin.gatienbaron added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

What's holding this back is lack of py2 compatibility. Although maybe I want to wait it out at this point. Do we expect to drop py3 in a few days, after 5.7 is released for instance?

Mon, Jan 25, 11:38 AM
valentin.gatienbaron abandoned D9284: purge: move extension into core mercurial.
Mon, Jan 25, 11:30 AM

Fri, Jan 22

valentin.gatienbaron closed D9820: purge: move extension into core mercurial.
Fri, Jan 22, 3:41 PM
valentin.gatienbaron committed rHGbb3a5c0df06b: purge: move extension into core mercurial.
purge: move extension into core mercurial
Fri, Jan 22, 3:38 PM

Nov 25 2020

valentin.gatienbaron added a comment to D9285: strip: move into core.

Oops, sorry, I didn't have black installed, so test-check-format.t was getting skipped. Having installed it now (at version 19.10, because 20.8b is broken), there are indeed formatting issues. Thanks for the fix.

Nov 25 2020, 12:52 AM

Nov 19 2020

valentin.gatienbaron committed rHGd7a508a75d72: strip: move into core.
strip: move into core
Nov 19 2020, 6:39 PM

Nov 18 2020

valentin.gatienbaron closed D9285: strip: move into core.
Nov 18 2020, 6:08 PM
valentin.gatienbaron committed rHGa46efd42ae70: strip: move into core.
strip: move into core
Nov 18 2020, 6:06 PM

Nov 12 2020

valentin.gatienbaron added a comment to D9284: purge: move extension into core mercurial.

Failing is what the vast majority of commands do when not given enough arguments:

$ hg clone
hg clone: invalid arguments
...
$ hg backout
abort: please specify a revision to backout
$ hg tag
hg tag: invalid arguments
...
$ hg resolve
abort: no action specified
...
$ hg revert
abort: no files or directories specified
...
Nov 12 2020, 11:16 PM
valentin.gatienbaron added a comment to D9294: packaging: enable rust extensions on centos.

Raphael should probably chime in, but as a data point, for us, all installations use rust. And they will have to, when we enable persistent-nodemap soon.
The likelihood of bug and performance bugs is probably higher than without rust, for conditions not covered by tests. That being said, I remember only two bugs from the past 6 months, and they were fairly obscure (type error on linux on filesystems that don't respect exec bits, occasional spurious failure in hg clean when it races on the filesystem with something).

Nov 12 2020, 10:53 PM

Nov 8 2020

valentin.gatienbaron added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

I rebased, but there's nothing new here (apart from conflict resolution).
The discussion for py2 support was not super conclusive. But even given that D7258 uses py3 by default except on windows, and the fact the code changed here doesn't run on windows, I think I still need to make this change work with py2, so py2 issues from windows users can still be investigated from linux.

Nov 8 2020, 7:53 PM
valentin.gatienbaron added a comment to D9284: purge: move extension into core mercurial.

@joerg.sonnenberger are you stating what was discussed at the sprint merely for comparison, or because you'd prefer for this change to be closer to it?

Nov 8 2020, 7:44 PM
valentin.gatienbaron updated the diff for D9019: procutil: avoid using os.fork() to implement runbgcommand.
Nov 8 2020, 7:30 PM
valentin.gatienbaron added a comment to D9285: strip: move into core.

Was that the conclusion? I think I was taking notes and missed it. I thought turning the strip extension into a debugstrip command was already agreed upon a year ago, In fact, D6987 was started back then (and stalled, but that's unrelated).
There's no disagreement that the command is dangerous, that's why it's debugstrip and not strip. That seems like better pushback to me than an extension.

Nov 8 2020, 7:16 PM
valentin.gatienbaron created D9284: purge: move extension into core mercurial.
Nov 8 2020, 6:32 PM
valentin.gatienbaron created D9285: strip: move into core.
Nov 8 2020, 6:31 PM

Oct 15 2020

valentin.gatienbaron added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

Ok. When I sent this, I thought the py3 switch was further along than it seems to be. I should be able to make this work on py2 (although I think it would merely reduce the chance of deadlock on py2).

Oct 15 2020, 12:33 AM
valentin.gatienbaron added a comment to D9020: sshpeer: avoid having a destructor that can block forks forever.

I meant for this change to be in addition to D9019, rather than an alternative, for robustness as written in a bit more detail in the commit message of D9019.

Oct 15 2020, 12:13 AM

Sep 25 2020

valentin.gatienbaron committed rHG4c8d9b53b1c7: chg: make is possible to call by default an hg binary located next to chg.
chg: make is possible to call by default an hg binary located next to chg
Sep 25 2020, 3:16 AM
valentin.gatienbaron committed rHG50fa4f631ef6: chg: make is possible to call by default an hg binary located next to chg.
chg: make is possible to call by default an hg binary located next to chg
Sep 25 2020, 12:31 AM

Sep 24 2020

valentin.gatienbaron closed D9006: chg: make is possible to call by default an hg binary located next to chg.
Sep 24 2020, 4:39 AM
valentin.gatienbaron committed rHGeb443f7cbc2c: chg: make is possible to call by default an hg binary located next to chg.
chg: make is possible to call by default an hg binary located next to chg
Sep 24 2020, 4:39 AM

Sep 17 2020

valentin.gatienbaron updated the diff for D9006: chg: make is possible to call by default an hg binary located next to chg.
Sep 17 2020, 10:03 AM

Sep 15 2020

valentin.gatienbaron closed D9021: fsmonitor: increase the threshold before we recommend it, when using rust.
Sep 15 2020, 8:50 AM
valentin.gatienbaron committed rHGc1d6e930ac8a: fsmonitor: increase the threshold before we recommend it, when using rust.
fsmonitor: increase the threshold before we recommend it, when using rust
Sep 15 2020, 8:50 AM

Sep 14 2020

valentin.gatienbaron created D9021: fsmonitor: increase the threshold before we recommend it, when using rust.
Sep 14 2020, 12:01 PM
valentin.gatienbaron created D9020: sshpeer: avoid having a destructor that can block forks forever.
Sep 14 2020, 11:07 AM
valentin.gatienbaron created D9019: procutil: avoid using os.fork() to implement runbgcommand.
Sep 14 2020, 11:07 AM

Sep 10 2020

valentin.gatienbaron created D9006: chg: make is possible to call by default an hg binary located next to chg.
Sep 10 2020, 2:12 PM

Jun 1 2020

valentin.gatienbaron closed D8603: rust: add a pointer for profiling to the README.
Jun 1 2020, 11:48 AM
valentin.gatienbaron committed rHGf330d6117a5b: relnotes: advertize the possibility to use rust.
relnotes: advertize the possibility to use rust
Jun 1 2020, 11:48 AM
valentin.gatienbaron committed rHG7ca1d635e4a6: rust: add a pointer for profiling to the README.
rust: add a pointer for profiling to the README
Jun 1 2020, 11:48 AM
valentin.gatienbaron closed D8604: relnotes: advertize the possibility to use rust.
Jun 1 2020, 11:48 AM
valentin.gatienbaron closed D8602: rust: update the mention of hgcli in rust/README.rst.
Jun 1 2020, 11:48 AM
valentin.gatienbaron committed rHG69d3ce00df99: rust: update the mention of hgcli in rust/README.rst.
rust: update the mention of hgcli in rust/README.rst
Jun 1 2020, 11:48 AM

May 30 2020

valentin.gatienbaron created D8603: rust: add a pointer for profiling to the README.
May 30 2020, 12:56 PM
valentin.gatienbaron created D8604: relnotes: advertize the possibility to use rust.
May 30 2020, 12:56 PM
valentin.gatienbaron created D8602: rust: update the mention of hgcli in rust/README.rst.
May 30 2020, 12:56 PM
valentin.gatienbaron closed D8600: scmutil: clarify getuipathfn comment.
May 30 2020, 12:24 PM
valentin.gatienbaron closed D8601: rust: remove one more occurrence of re2.
May 30 2020, 12:24 PM
valentin.gatienbaron committed rHG1537ce87e3ba: rust: remove one more occurrence of re2.
rust: remove one more occurrence of re2
May 30 2020, 12:24 PM
valentin.gatienbaron committed rHGd044b66d8429: scmutil: clarify getuipathfn comment.
scmutil: clarify getuipathfn comment
May 30 2020, 12:24 PM
valentin.gatienbaron created D8601: rust: remove one more occurrence of re2.
May 30 2020, 10:21 AM
valentin.gatienbaron created D8600: scmutil: clarify getuipathfn comment.
May 30 2020, 10:05 AM

May 28 2020

valentin.gatienbaron closed D8582: grep: reduce the cost of pathauditor checks when grepping working copy.
May 28 2020, 12:24 PM
valentin.gatienbaron closed D8581: grep: test that paths get audited.
May 28 2020, 12:23 PM
valentin.gatienbaron committed rHG233ee525dcef: grep: reduce the cost of pathauditor checks when grepping working copy.
grep: reduce the cost of pathauditor checks when grepping working copy
May 28 2020, 12:23 PM
valentin.gatienbaron closed D8580: grep: add test coverage of behavior on symlinks.
May 28 2020, 12:23 PM
valentin.gatienbaron committed rHG06105aa8bc0e: grep: test that paths get audited.
grep: test that paths get audited
May 28 2020, 12:23 PM
valentin.gatienbaron committed rHG3db660b8eba6: grep: add test coverage of behavior on symlinks.
grep: add test coverage of behavior on symlinks
May 28 2020, 12:23 PM
valentin.gatienbaron added a comment to D8581: grep: test that paths get audited.

It would be nice to have some comments in the test to explain what is exactly test here, it is a bit obscure from just reading the test.

May 28 2020, 12:19 PM
valentin.gatienbaron closed D8586: files: speed up `hg files` when no flags change display.
May 28 2020, 11:44 AM
valentin.gatienbaron committed rHG065421e12248: files: speed up `hg files` when no flags change display.
files: speed up `hg files` when no flags change display
May 28 2020, 11:43 AM

May 26 2020

valentin.gatienbaron updated the diff for D8581: grep: test that paths get audited.
May 26 2020, 12:55 PM
valentin.gatienbaron updated the diff for D8580: grep: add test coverage of behavior on symlinks.
May 26 2020, 12:55 PM
valentin.gatienbaron added a comment to D8585: scmutil: speed up relativization of paths when it's a no-op.

I reworded the description/comment slightly while Augie accepted the revision, in case people care enough to want the modified commit queued.

May 26 2020, 12:45 PM
valentin.gatienbaron updated the summary of D8585: scmutil: speed up relativization of paths when it's a no-op.
May 26 2020, 12:40 PM
valentin.gatienbaron closed D8585: scmutil: speed up relativization of paths when it's a no-op.
May 26 2020, 12:38 PM
valentin.gatienbaron closed D8584: sshpeer: make client print (likely) server errors on stderr.
May 26 2020, 12:38 PM
valentin.gatienbaron closed D8583: sshpeer: add test showing that -q silences remote errors.
May 26 2020, 12:37 PM
valentin.gatienbaron committed rHG5d77f571a563: sshpeer: make client print (likely) server errors on stderr (BC).
sshpeer: make client print (likely) server errors on stderr (BC)
May 26 2020, 12:37 PM
valentin.gatienbaron committed rHG15e26cc0e2c6: sshpeer: add test showing that -q silences remote errors.
sshpeer: add test showing that -q silences remote errors
May 26 2020, 12:37 PM
valentin.gatienbaron committed rHG5d8ae9248a70: scmutil: speed up relativization of paths when it's a no-op.
scmutil: speed up relativization of paths when it's a no-op
May 26 2020, 12:37 PM
valentin.gatienbaron added a comment to D8586: files: speed up `hg files` when no flags change display.

Doesn't this break HGPLAIN=1 hg files -T'{path|short}\n' or similar?

May 26 2020, 12:29 PM
valentin.gatienbaron added inline comments to D8586: files: speed up `hg files` when no flags change display.
May 26 2020, 12:24 PM
valentin.gatienbaron updated the diff for D8586: files: speed up `hg files` when no flags change display.
May 26 2020, 12:20 PM
valentin.gatienbaron added a comment to D8582: grep: reduce the cost of pathauditor checks when grepping working copy.

I don't understand. Do you mean have numbers in the code in addition to the commit description? Seems like too much details.

May 26 2020, 11:11 AM
valentin.gatienbaron added a comment to D8585: scmutil: speed up relativization of paths when it's a no-op.

What's confusing about it? For me, the emphasis is that the slow branch defines the expected behavior, and the other branch is merely an optimization of it.

May 26 2020, 8:46 AM
valentin.gatienbaron created D8586: files: speed up `hg files` when no flags change display.
May 26 2020, 8:37 AM
valentin.gatienbaron created D8585: scmutil: speed up relativization of paths when it's a no-op.
May 26 2020, 7:19 AM
valentin.gatienbaron created D8584: sshpeer: make client print (likely) server errors on stderr.
May 26 2020, 6:42 AM
valentin.gatienbaron created D8583: sshpeer: add test showing that -q silences remote errors.
May 26 2020, 6:42 AM

May 25 2020

valentin.gatienbaron created D8582: grep: reduce the cost of pathauditor checks when grepping working copy.
May 25 2020, 7:43 PM
valentin.gatienbaron created D8581: grep: test that paths get audited.
May 25 2020, 7:42 PM
valentin.gatienbaron created D8580: grep: add test coverage of behavior on symlinks.
May 25 2020, 7:42 PM

May 18 2020

valentin.gatienbaron closed D8545: grep: grep the working copy faster.
May 18 2020, 1:12 PM
valentin.gatienbaron closed D8544: grep: stop computing information for --diff when unnecessary.
May 18 2020, 1:11 PM
valentin.gatienbaron closed D8543: grep: don't go in an infinite loop when given empty regex.
May 18 2020, 1:11 PM
valentin.gatienbaron committed rHG708ad5cf5e5a: grep: grep the working copy faster.
grep: grep the working copy faster
May 18 2020, 1:11 PM
valentin.gatienbaron committed rHG8d552701806d: grep: stop computing information for --diff when unnecessary.
grep: stop computing information for --diff when unnecessary
May 18 2020, 1:10 PM
valentin.gatienbaron closed D8542: grep: improve test coverage.
May 18 2020, 1:10 PM
valentin.gatienbaron committed rHGf90957c947f4: grep: don't go in an infinite loop when given empty regex.
grep: don't go in an infinite loop when given empty regex
May 18 2020, 1:10 PM
valentin.gatienbaron committed rHG7e7080ab8ba8: grep: improve test coverage.
grep: improve test coverage
May 18 2020, 1:10 PM
valentin.gatienbaron closed D8537: setup: stop asking cargo to spam.
May 18 2020, 1:10 PM
valentin.gatienbaron committed rHG47787a48f469: setup: stop asking cargo to spam.
setup: stop asking cargo to spam
May 18 2020, 1:10 PM

May 17 2020

valentin.gatienbaron created D8545: grep: grep the working copy faster.
May 17 2020, 8:49 PM
valentin.gatienbaron closed D8538: rust: fix warning about unnecessary mut.
May 17 2020, 5:18 PM
valentin.gatienbaron committed rHG73d6ce2746d2: rust: fix warning about unnecessary mut.
rust: fix warning about unnecessary mut
May 17 2020, 5:18 PM
valentin.gatienbaron created D8544: grep: stop computing information for --diff when unnecessary.
May 17 2020, 1:50 PM
valentin.gatienbaron created D8543: grep: don't go in an infinite loop when given empty regex.
May 17 2020, 1:50 PM
valentin.gatienbaron created D8542: grep: improve test coverage.
May 17 2020, 1:49 PM
valentin.gatienbaron created D8538: rust: fix warning about unnecessary mut.
May 17 2020, 12:33 PM
valentin.gatienbaron created D8537: setup: stop asking cargo to spam.
May 17 2020, 12:33 PM

May 14 2020

valentin.gatienbaron closed D8523: py3: fix exception in pull when several things happen to a bookmark.
May 14 2020, 4:32 PM
valentin.gatienbaron committed rHGf189c5280d48: py3: fix exception in pull when several things happen to a bookmark.
py3: fix exception in pull when several things happen to a bookmark
May 14 2020, 4:31 PM
valentin.gatienbaron created D8523: py3: fix exception in pull when several things happen to a bookmark.
May 14 2020, 11:00 AM

Apr 16 2020

valentin.gatienbaron closed D8423: graft: exit 1 on conflicts, like merge.
Apr 16 2020, 12:56 PM
valentin.gatienbaron committed rHG16c361152133: graft: exit 1 on conflicts, like merge.
graft: exit 1 on conflicts, like merge
Apr 16 2020, 12:54 PM

Apr 14 2020

valentin.gatienbaron created D8423: graft: exit 1 on conflicts, like merge.
Apr 14 2020, 7:30 PM