Oops, clearly I should have run all the tests.
Although even though I didn't realize that wd was filled in by the function, this should have merely caused small differences of output. We see that in the failures, but we also errors with hg -R union:..., so the change is maybe not quite right.

In D12155#186341, @Alphare wrote:

I don't know if we have dropped py2 by now or not.

We're dropping Python 2 right after the 6.1 release due for on or around March 1st. Provided this can wait about a month, we can just take it as is then.

Maybe the server could reject such changes, but I'd rather simply roll clients with the fix.

It seems that this kind of corruption can propagate between clones as well. Sadness.

In D11212#174950, @danchr wrote:

In D11212#174786, @danchr wrote:

In D11212#174524, @Alphare wrote:

Thanks for bringing this up. Does that represent a large amount of work for you?

Well, my main challenge here is that I have absolutely no idea what's going on — I don't have much experience with the very low levels of networking in Mercurial, or the (relatively) new peer API. It seems to me that the point of that code is, essentially, to provide a minimal repository or peer that does nothing. Could something like that be moved to Mercurial core?

Okay, I managed to fix it:
https://foss.heptapod.net/mercurial/hg-git/-/merge_requests/130/diffs
https://foss.heptapod.net/mercurial/hg-git/-/merge_requests/131/diffs
Would one of you perhaps take a look at those changes and see if they make sense? I did it in the form of a decorator that just wraps a regular function returning a value. Something like that might be useful for core as well, and simplify a simple method like branchmap().

I think this should be fixed. If I understand the diff correctly, it was a slash vs backslash change, and the rest is noise.

I am definitely not going to write a test. I know nothing about remotefilelog. I merely happened to see this while grepping around.

I have been assuming that changes can still be submitted during a change freeze, but they are just going to get ignored for a few days. None of my changes are particularly intended to go on 5.9.