Page MenuHomePhabricator

valentin.gatienbaron (Valentin Gatien-Baron)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2018, 11:42 AM (156 w, 2 d)

Recent Activity

Today

valentin.gatienbaron created D11245: tests: rely on dummyssh being the default.
Tue, Aug 3, 12:52 AM
valentin.gatienbaron created D11246: tests: manual cleanup now that dummyssh usage is implied.
Tue, Aug 3, 12:50 AM
valentin.gatienbaron updated the diff for D11244: tests: setup dummyssh as the default ssh.
Tue, Aug 3, 12:49 AM
valentin.gatienbaron created D11247: tests: drop hgrc bits that have become the default.
Tue, Aug 3, 12:48 AM

Yesterday

valentin.gatienbaron updated the diff for D11244: tests: setup dummyssh as the default ssh.
Mon, Aug 2, 11:18 PM
valentin.gatienbaron created D11244: tests: setup dummyssh as the default ssh.
Mon, Aug 2, 10:26 PM
valentin.gatienbaron created D11243: remotefilelog: fix what looks like a wrong refactoring.
Mon, Aug 2, 9:57 PM
valentin.gatienbaron added a comment to D11237: tests: rename test-clone-uncompressed.t.

I have been assuming that changes can still be submitted during a change freeze, but they are just going to get ignored for a few days. None of my changes are particularly intended to go on 5.9.

Mon, Aug 2, 10:40 AM
valentin.gatienbaron closed D11236: streamclone: ensure the server sends the right amount of data.
Mon, Aug 2, 6:44 AM
valentin.gatienbaron committed rHG48f07adbda98: streamclone: ensure the server sends the right amount of data.
streamclone: ensure the server sends the right amount of data
Mon, Aug 2, 6:44 AM

Sun, Aug 1

valentin.gatienbaron created D11236: streamclone: ensure the server sends the right amount of data.
Sun, Aug 1, 10:59 AM
valentin.gatienbaron created D11237: tests: rename test-clone-uncompressed.t.
Sun, Aug 1, 10:59 AM

Sun, Jul 25

valentin.gatienbaron created D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.
Sun, Jul 25, 4:33 PM
valentin.gatienbaron created D11211: wireprotov1peer: simplify the way batchable rpcs are defined.
Sun, Jul 25, 4:32 PM

May 23 2021

valentin.gatienbaron closed D10714: transaction: trivial refactoring.
May 23 2021, 6:05 PM
valentin.gatienbaron committed rHG13dd5bb5492a: transaction: trivial refactoring.
transaction: trivial refactoring
May 23 2021, 6:05 PM
valentin.gatienbaron closed D10757: test: remove some unnecessary dependency on repo format.
May 23 2021, 6:05 PM
valentin.gatienbaron committed rHGaa07bcc4f505: test: remove some unnecessary dependency on repo format.
test: remove some unnecessary dependency on repo format
May 23 2021, 6:05 PM

May 21 2021

valentin.gatienbaron added a comment to D10763: tests: partially fix test-transaction-rollback-on-revlog-split.t on Windows.

Maybe the forward slashes in the extension created at the beginning of the test is the source of the other windows failures?

May 21 2021, 8:12 AM

May 20 2021

valentin.gatienbaron created D10757: test: remove some unnecessary dependency on repo format.
May 20 2021, 10:31 AM
valentin.gatienbaron updated the diff for D10714: transaction: trivial refactoring.
May 20 2021, 10:27 AM
valentin.gatienbaron abandoned D10712: tests: show that hg fails to rollback transaction on revlog split.
May 20 2021, 10:25 AM
valentin.gatienbaron abandoned D10713: revlog: fix the the computation of indexes on revlog split.
May 20 2021, 10:25 AM
valentin.gatienbaron abandoned D10715: revlog: make transaction handle revlog splits better (issue6423).
May 20 2021, 10:24 AM

May 18 2021

valentin.gatienbaron added a comment to D10726: recover: only apply last journal record per file (issue6423).

Also, can you put (issue6423) in the first line of the commit message, so the bugzilla magic closes the issue?

May 18 2021, 11:39 PM
valentin.gatienbaron added a comment to D10726: recover: only apply last journal record per file (issue6423).

Does the order of the truncates actually not matter, for concurrent readers? I don't really see how it could matter (linkrevs should make it possible to ignore everything not committed), but before looking at the rollback code, I imagined it truncated in reverse order of writes (and looking it up, it's what's described in the initial revlog paper).

May 18 2021, 11:14 PM
valentin.gatienbaron accepted D10725: revlog: update data file record before index rename.
May 18 2021, 10:44 PM
valentin.gatienbaron added a comment to D10724: revlog: fix index computation during inline->non-inline transition.

I knew zstd could be turned off, but I didn't knew there was an option to turn off even zlib. Cool.

May 18 2021, 10:38 PM

May 16 2021

valentin.gatienbaron added a comment to D10712: tests: show that hg fails to rollback transaction on revlog split.

This whole stack exposes a real problem and one quite a bit older, but it is not correct in a number of ways as is.
First of all, the check added in 8502f76dbfd7 is broken for the revlog inline to non-inline migration.

May 16 2021, 9:30 PM
valentin.gatienbaron created D10715: revlog: make transaction handle revlog splits better (issue6423).
May 16 2021, 3:32 PM
valentin.gatienbaron created D10713: revlog: fix the the computation of indexes on revlog split.
May 16 2021, 3:32 PM
valentin.gatienbaron created D10714: transaction: trivial refactoring.
May 16 2021, 3:31 PM
valentin.gatienbaron created D10712: tests: show that hg fails to rollback transaction on revlog split.
May 16 2021, 3:31 PM

Apr 11 2021

valentin.gatienbaron closed D10293: blackbox: fix type error on log rotation on read-only filesystem.
Apr 11 2021, 7:23 PM
valentin.gatienbaron committed rHG4a6024b87dfc: blackbox: fix type error on log rotation on read-only filesystem.
blackbox: fix type error on log rotation on read-only filesystem
Apr 11 2021, 7:23 PM
valentin.gatienbaron committed rHG8759e22f1649: procutil: avoid using os.fork() to implement runbgcommand.
procutil: avoid using os.fork() to implement runbgcommand
Apr 11 2021, 7:23 PM
valentin.gatienbaron closed D9019: procutil: avoid using os.fork() to implement runbgcommand.
Apr 11 2021, 7:23 PM

Apr 8 2021

valentin.gatienbaron closed D10318: revlog: fix error about unknown compression format in py3.
Apr 8 2021, 6:56 AM
valentin.gatienbaron committed rHGfbfb1d6d8459: revlog: fix error about unknown compression format in py3.
revlog: fix error about unknown compression format in py3
Apr 8 2021, 6:55 AM

Apr 6 2021

valentin.gatienbaron created D10318: revlog: fix error about unknown compression format in py3.
Apr 6 2021, 1:53 PM

Mar 31 2021

valentin.gatienbaron created D10293: blackbox: fix type error on log rotation on read-only filesystem.
Mar 31 2021, 6:11 PM

Mar 10 2021

valentin.gatienbaron closed D10074: wireprotov1peer: don't raise internal errors in some cases.
Mar 10 2021, 2:24 PM
valentin.gatienbaron closed D10073: sshpeer: don't fail forwarding output from closed connections.
Mar 10 2021, 2:23 PM
valentin.gatienbaron committed rHGaa2e38147e8b: wireprotov1peer: don't raise internal errors in some cases.
wireprotov1peer: don't raise internal errors in some cases
Mar 10 2021, 2:23 PM
valentin.gatienbaron committed rHGfa30292b680b: sshpeer: don't fail forwarding output from closed connections.
sshpeer: don't fail forwarding output from closed connections
Mar 10 2021, 2:23 PM
valentin.gatienbaron committed rHGfe36ce0fbcdd: test: show internal exception with batchable rpcs over ssh.
test: show internal exception with batchable rpcs over ssh
Mar 10 2021, 2:23 PM
valentin.gatienbaron closed D10072: test: show internal exception with batchable rpcs over ssh.
Mar 10 2021, 2:23 PM

Mar 9 2021

valentin.gatienbaron abandoned D9020: sshpeer: avoid having a destructor that can block forks forever.
Mar 9 2021, 8:45 AM
valentin.gatienbaron committed rHGa4c19a162615: sshpeer: enable+fix warning about sshpeers not being closed explicitly.
sshpeer: enable+fix warning about sshpeers not being closed explicitly
Mar 9 2021, 12:39 AM
valentin.gatienbaron committed rHGdb8037e38085: sshpeer: add a develwarning if an sshpeer is not closed explicitly.
sshpeer: add a develwarning if an sshpeer is not closed explicitly
Mar 9 2021, 12:39 AM
valentin.gatienbaron committed rHG0509cee38757: remotefilelog: rework workaround for sshpeer deadlocks.
remotefilelog: rework workaround for sshpeer deadlocks
Mar 9 2021, 12:39 AM
valentin.gatienbaron committed rHG0738bc25d6ac: sshpeer: add a method to check if a doublepipe is closed.
sshpeer: add a method to check if a doublepipe is closed
Mar 9 2021, 12:39 AM
valentin.gatienbaron committed rHG8c4906105f37: sshpeer: make sshpeer.close() close the underlying connection.
sshpeer: make sshpeer.close() close the underlying connection
Mar 9 2021, 12:39 AM

Mar 8 2021

valentin.gatienbaron closed D9999: sshpeer: enable+fix warning about sshpeers not being closed explicitly.
Mar 8 2021, 3:31 PM
valentin.gatienbaron closed D9998: sshpeer: add a develwarning if an sshpeer is not closed explicitly.
Mar 8 2021, 3:28 PM
valentin.gatienbaron committed rHGebfa20e62518: sshpeer: enable+fix warning about sshpeers not being closed explicitly.
sshpeer: enable+fix warning about sshpeers not being closed explicitly
Mar 8 2021, 3:28 PM
valentin.gatienbaron committed rHG06f024043165: sshpeer: add a develwarning if an sshpeer is not closed explicitly.
sshpeer: add a develwarning if an sshpeer is not closed explicitly
Mar 8 2021, 3:28 PM
valentin.gatienbaron closed D9996: sshpeer: add a method to check if a doublepipe is closed.
Mar 8 2021, 3:28 PM
valentin.gatienbaron committed rHG2590032f982e: remotefilelog: rework workaround for sshpeer deadlocks.
remotefilelog: rework workaround for sshpeer deadlocks
Mar 8 2021, 3:28 PM
valentin.gatienbaron closed D9997: remotefilelog: rework workaround for sshpeer deadlocks.
Mar 8 2021, 3:28 PM
valentin.gatienbaron committed rHGc9434fcbc901: sshpeer: add a method to check if a doublepipe is closed.
sshpeer: add a method to check if a doublepipe is closed
Mar 8 2021, 3:28 PM
valentin.gatienbaron committed rHG309e6729e435: sshpeer: make sshpeer.close() close the underlying connection.
sshpeer: make sshpeer.close() close the underlying connection
Mar 8 2021, 3:28 PM
valentin.gatienbaron closed D9995: sshpeer: make sshpeer.close() close the underlying connection.
Mar 8 2021, 3:27 PM

Feb 25 2021

valentin.gatienbaron created D10074: wireprotov1peer: don't raise internal errors in some cases.
Feb 25 2021, 10:37 AM
valentin.gatienbaron created D10073: sshpeer: don't fail forwarding output from closed connections.
Feb 25 2021, 10:37 AM
valentin.gatienbaron created D10072: test: show internal exception with batchable rpcs over ssh.
Feb 25 2021, 10:37 AM

Feb 15 2021

valentin.gatienbaron updated the diff for D9020: sshpeer: avoid having a destructor that can block forks forever.
Feb 15 2021, 4:51 PM
valentin.gatienbaron created D9999: sshpeer: enable+fix warning about sshpeers not being closed explicitly.
Feb 15 2021, 4:46 PM
valentin.gatienbaron added a comment to D9020: sshpeer: avoid having a destructor that can block forks forever.

I submitted changes to close peers explicitly instead of doing this. It's definitely more invasive though.

Feb 15 2021, 4:43 PM
valentin.gatienbaron created D9998: sshpeer: add a develwarning if an sshpeer is not closed explicitly.
Feb 15 2021, 4:42 PM
valentin.gatienbaron created D9996: sshpeer: add a method to check if a doublepipe is closed.
Feb 15 2021, 4:42 PM
valentin.gatienbaron created D9997: remotefilelog: rework workaround for sshpeer deadlocks.
Feb 15 2021, 4:42 PM
valentin.gatienbaron created D9995: sshpeer: make sshpeer.close() close the underlying connection.
Feb 15 2021, 4:42 PM

Feb 14 2021

valentin.gatienbaron added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

I made the command trivially compatible with py2, by keeping both implementations around. It seems ok, under the assumption that the the py2 has a limited lifetime (until py2 support is dropped), and that it doesn't affect the windows code path (so it affects OSes that should only be using py3).

Feb 14 2021, 8:51 PM
valentin.gatienbaron updated the summary of D9019: procutil: avoid using os.fork() to implement runbgcommand.
Feb 14 2021, 8:47 PM

Feb 9 2021

valentin.gatienbaron added a comment to D9817: relnote: remove the reference to `debugstrip`.

No particular opinion, I have not really followed this namespace discussion. I would have thought there's a number of other debugcommands that are admin commands, like debugrebuilddirstate, so one more wouldn't make a difference, but maybe that's incorrect.

Feb 9 2021, 1:03 PM

Jan 25 2021

valentin.gatienbaron added a comment to D9020: sshpeer: avoid having a destructor that can block forks forever.

Closing the peer is what I was describing as solution 3 in D9019. But I think I was wrong in saying that it doesn't help with calls to logtoprocess in the middle of commands. I also just noticed that pull does that, in fact. I'll try and find some time to do that.

Jan 25 2021, 11:49 AM
valentin.gatienbaron added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

What's holding this back is lack of py2 compatibility. Although maybe I want to wait it out at this point. Do we expect to drop py2 in a few days, after 5.7 is released for instance?

Jan 25 2021, 11:38 AM
valentin.gatienbaron abandoned D9284: purge: move extension into core mercurial.
Jan 25 2021, 11:30 AM

Jan 22 2021

valentin.gatienbaron closed D9820: purge: move extension into core mercurial.
Jan 22 2021, 3:41 PM
valentin.gatienbaron committed rHGbb3a5c0df06b: purge: move extension into core mercurial.
purge: move extension into core mercurial
Jan 22 2021, 3:38 PM

Nov 25 2020

valentin.gatienbaron added a comment to D9285: strip: move into core.

Oops, sorry, I didn't have black installed, so test-check-format.t was getting skipped. Having installed it now (at version 19.10, because 20.8b is broken), there are indeed formatting issues. Thanks for the fix.

Nov 25 2020, 12:52 AM

Nov 19 2020

valentin.gatienbaron committed rHGd7a508a75d72: strip: move into core.
strip: move into core
Nov 19 2020, 6:39 PM

Nov 18 2020

valentin.gatienbaron closed D9285: strip: move into core.
Nov 18 2020, 6:08 PM
valentin.gatienbaron committed rHGa46efd42ae70: strip: move into core.
strip: move into core
Nov 18 2020, 6:06 PM

Nov 12 2020

valentin.gatienbaron added a comment to D9284: purge: move extension into core mercurial.

Failing is what the vast majority of commands do when not given enough arguments:

$ hg clone
hg clone: invalid arguments
...
$ hg backout
abort: please specify a revision to backout
$ hg tag
hg tag: invalid arguments
...
$ hg resolve
abort: no action specified
...
$ hg revert
abort: no files or directories specified
...
Nov 12 2020, 11:16 PM
valentin.gatienbaron added a comment to D9294: packaging: enable rust extensions on centos.

Raphael should probably chime in, but as a data point, for us, all installations use rust. And they will have to, when we enable persistent-nodemap soon.
The likelihood of bug and performance bugs is probably higher than without rust, for conditions not covered by tests. That being said, I remember only two bugs from the past 6 months, and they were fairly obscure (type error on linux on filesystems that don't respect exec bits, occasional spurious failure in hg clean when it races on the filesystem with something).

Nov 12 2020, 10:53 PM

Nov 8 2020

valentin.gatienbaron added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

I rebased, but there's nothing new here (apart from conflict resolution).
The discussion for py2 support was not super conclusive. But even given that D7258 uses py3 by default except on windows, and the fact the code changed here doesn't run on windows, I think I still need to make this change work with py2, so py2 issues from windows users can still be investigated from linux.

Nov 8 2020, 7:53 PM
valentin.gatienbaron added a comment to D9284: purge: move extension into core mercurial.

@joerg.sonnenberger are you stating what was discussed at the sprint merely for comparison, or because you'd prefer for this change to be closer to it?

Nov 8 2020, 7:44 PM
valentin.gatienbaron updated the diff for D9019: procutil: avoid using os.fork() to implement runbgcommand.
Nov 8 2020, 7:30 PM
valentin.gatienbaron added a comment to D9285: strip: move into core.

Was that the conclusion? I think I was taking notes and missed it. I thought turning the strip extension into a debugstrip command was already agreed upon a year ago, In fact, D6987 was started back then (and stalled, but that's unrelated).
There's no disagreement that the command is dangerous, that's why it's debugstrip and not strip. That seems like better pushback to me than an extension.

Nov 8 2020, 7:16 PM
valentin.gatienbaron created D9284: purge: move extension into core mercurial.
Nov 8 2020, 6:32 PM
valentin.gatienbaron created D9285: strip: move into core.
Nov 8 2020, 6:31 PM

Oct 15 2020

valentin.gatienbaron added a comment to D9019: procutil: avoid using os.fork() to implement runbgcommand.

Ok. When I sent this, I thought the py3 switch was further along than it seems to be. I should be able to make this work on py2 (although I think it would merely reduce the chance of deadlock on py2).

Oct 15 2020, 12:33 AM
valentin.gatienbaron added a comment to D9020: sshpeer: avoid having a destructor that can block forks forever.

I meant for this change to be in addition to D9019, rather than an alternative, for robustness as written in a bit more detail in the commit message of D9019.

Oct 15 2020, 12:13 AM

Sep 25 2020

valentin.gatienbaron committed rHG4c8d9b53b1c7: chg: make is possible to call by default an hg binary located next to chg.
chg: make is possible to call by default an hg binary located next to chg
Sep 25 2020, 3:16 AM
valentin.gatienbaron committed rHG50fa4f631ef6: chg: make is possible to call by default an hg binary located next to chg.
chg: make is possible to call by default an hg binary located next to chg
Sep 25 2020, 12:31 AM

Sep 24 2020

valentin.gatienbaron closed D9006: chg: make is possible to call by default an hg binary located next to chg.
Sep 24 2020, 4:39 AM
valentin.gatienbaron committed rHGeb443f7cbc2c: chg: make is possible to call by default an hg binary located next to chg.
chg: make is possible to call by default an hg binary located next to chg
Sep 24 2020, 4:39 AM

Sep 17 2020

valentin.gatienbaron updated the diff for D9006: chg: make is possible to call by default an hg binary located next to chg.
Sep 17 2020, 10:03 AM