Page MenuHomePhabricator

valentin.gatienbaron (Valentin Gatien-Baron)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2018, 11:42 AM (197 w, 3 d)

Recent Activity

Thu, Apr 21

valentin.gatienbaron added a comment to D12579: chg: make `chg --cwd $anything -R $relativepath` behave better.

Oops, clearly I should have run all the tests.
Although even though I didn't realize that wd was filled in by the function, this should have merely caused small differences of output. We see that in the failures, but we also errors with hg -R union:..., so the change is maybe not quite right.

Thu, Apr 21, 9:36 AM

Wed, Apr 20

valentin.gatienbaron closed D12579: chg: make `chg --cwd $anything -R $relativepath` behave better.
Wed, Apr 20, 12:07 PM
valentin.gatienbaron committed rHG22fc694572ea: chg: make `chg --cwd $anything -R $relativepath` behave better.
chg: make `chg --cwd $anything -R $relativepath` behave better
Wed, Apr 20, 12:07 PM
valentin.gatienbaron updated the summary of D12579: chg: make `chg --cwd $anything -R $relativepath` behave better.
Wed, Apr 20, 11:35 AM
valentin.gatienbaron created D12579: chg: make `chg --cwd $anything -R $relativepath` behave better.
Wed, Apr 20, 11:34 AM

Apr 4 2022

valentin.gatienbaron closed D12427: dispatch: fix silly blackbox entries when hg is interrupted.
Apr 4 2022, 11:17 AM
valentin.gatienbaron committed rHG91a60031aba2: dispatch: fix silly blackbox entries when hg is interrupted.
dispatch: fix silly blackbox entries when hg is interrupted
Apr 4 2022, 11:17 AM

Apr 1 2022

valentin.gatienbaron retitled D12427: dispatch: fix silly blackbox entries when hg is interrupted from dispatch: stop sometimes generating silly blackbox entries to dispatch: fix silly blackbox entries when hg is interrupted.
Apr 1 2022, 12:48 PM
valentin.gatienbaron created D12427: dispatch: fix silly blackbox entries when hg is interrupted.
Apr 1 2022, 12:47 PM

Mar 29 2022

valentin.gatienbaron closed D12402: streamclone: avoid some obscure error in a corner case.
Mar 29 2022, 8:29 AM
valentin.gatienbaron committed rHGd9ed7c5e915d: streamclone: avoid some obscure error in a corner case.
streamclone: avoid some obscure error in a corner case
Mar 29 2022, 8:29 AM

Mar 26 2022

valentin.gatienbaron updated the diff for D12402: streamclone: avoid some obscure error in a corner case.
Mar 26 2022, 2:43 PM

Mar 24 2022

valentin.gatienbaron created D12402: streamclone: avoid some obscure error in a corner case.
Mar 24 2022, 12:37 PM

Feb 14 2022

valentin.gatienbaron closed D12155: sparse: rework debugsparse's interface.
Feb 14 2022, 5:47 AM
valentin.gatienbaron committed rHGa6efb9180764: sparse: rework debugsparse's interface.
sparse: rework debugsparse's interface
Feb 14 2022, 5:47 AM

Feb 9 2022

valentin.gatienbaron added a comment to D12155: sparse: rework debugsparse's interface.

I don't know if we have dropped py2 by now or not.

We're dropping Python 2 right after the 6.1 release due for on or around March 1st. Provided this can wait about a month, we can just take it as is then.

Feb 9 2022, 6:33 PM
valentin.gatienbaron updated the summary of D12155: sparse: rework debugsparse's interface.
Feb 9 2022, 6:30 PM

Feb 8 2022

valentin.gatienbaron created D12155: sparse: rework debugsparse's interface.
Feb 8 2022, 11:33 PM

Jan 19 2022

valentin.gatienbaron committed rHGabbecb5cd6f3: blackbox: change year in logs to ISO 8601 format.
blackbox: change year in logs to ISO 8601 format
Jan 19 2022, 6:13 AM
valentin.gatienbaron closed D12006: blackbox: change year in logs to ISO 8601 format.
Jan 19 2022, 4:50 AM
valentin.gatienbaron closed D12005: blackbox: add milliseconds to blackbox logs by default.
Jan 19 2022, 4:50 AM
valentin.gatienbaron committed rHGb8ea044f9f2a: blackbox: change year in logs to ISO 8601 format.
blackbox: change year in logs to ISO 8601 format
Jan 19 2022, 4:49 AM
valentin.gatienbaron committed rHG011f5218ff2d: blackbox: add milliseconds to blackbox logs by default.
blackbox: add milliseconds to blackbox logs by default
Jan 19 2022, 4:49 AM
valentin.gatienbaron committed rHGfe4922564661: blackbox: correct date format doc.
blackbox: correct date format doc
Jan 19 2022, 4:49 AM
valentin.gatienbaron closed D12004: blackbox: correct date format doc.
Jan 19 2022, 4:49 AM

Jan 18 2022

valentin.gatienbaron abandoned D11750: commit: prevent possible race that results in bad dirstate.
Jan 18 2022, 9:07 PM
valentin.gatienbaron updated the diff for D12006: blackbox: change year in logs to ISO 8601 format.
Jan 18 2022, 12:53 PM
valentin.gatienbaron created D12006: blackbox: change year in logs to ISO 8601 format.
Jan 18 2022, 12:46 AM
valentin.gatienbaron created D12005: blackbox: add milliseconds to blackbox logs by default.
Jan 18 2022, 12:46 AM
valentin.gatienbaron created D12004: blackbox: correct date format doc.
Jan 18 2022, 12:45 AM

Dec 13 2021

valentin.gatienbaron closed D11749: test: add test for a former race resulting in bad dirstate.
Dec 13 2021, 9:17 AM
valentin.gatienbaron committed rHGbc6547f61310: test: add test for a former race resulting in bad dirstate.
test: add test for a former race resulting in bad dirstate
Dec 13 2021, 9:17 AM

Nov 10 2021

valentin.gatienbaron created D11750: commit: prevent possible race that results in bad dirstate.
Nov 10 2021, 8:25 PM
valentin.gatienbaron created D11749: test: add test for a former race resulting in bad dirstate.
Nov 10 2021, 8:24 PM

Sep 24 2021

valentin.gatienbaron closed D11490: bookmarks: add an option to make pull mirror remote bookmarks.
Sep 24 2021, 9:21 AM
valentin.gatienbaron committed rHG62f325f9b347: bookmarks: add an option to make pull mirror remote bookmarks.
bookmarks: add an option to make pull mirror remote bookmarks
Sep 24 2021, 9:21 AM

Sep 22 2021

valentin.gatienbaron retitled D11490: bookmarks: add an option to make pull mirror remote bookmarks from bookmarks: add an option to make pull mirror local bookmarks to bookmarks: add an option to make pull mirror remote bookmarks.
Sep 22 2021, 6:24 PM
valentin.gatienbaron created D11490: bookmarks: add an option to make pull mirror remote bookmarks.
Sep 22 2021, 6:24 PM

Sep 13 2021

valentin.gatienbaron added a comment to D11399: narrow: show repo corruption when commiting empty files.

Maybe the server could reject such changes, but I'd rather simply roll clients with the fix.

Sep 13 2021, 3:39 PM
valentin.gatienbaron added a comment to D11399: narrow: show repo corruption when commiting empty files.

It seems that this kind of corruption can propagate between clones as well. Sadness.

Sep 13 2021, 11:54 AM
valentin.gatienbaron closed D11400: narrow: fix commits of empty files.
Sep 13 2021, 11:44 AM
valentin.gatienbaron committed rHG5b9de38a0356: narrow: fix commits of empty files.
narrow: fix commits of empty files
Sep 13 2021, 11:44 AM
valentin.gatienbaron closed D11399: narrow: show repo corruption when commiting empty files.
Sep 13 2021, 11:44 AM
valentin.gatienbaron committed rHGcc33deae66a1: narrow: show repo corruption when commiting empty files.
narrow: show repo corruption when commiting empty files
Sep 13 2021, 11:44 AM
valentin.gatienbaron updated the diff for D11400: narrow: fix commits of empty files.
Sep 13 2021, 9:22 AM

Sep 11 2021

valentin.gatienbaron added a comment to D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.

Thanks for bringing this up. Does that represent a large amount of work for you?

Well, my main challenge here is that I have absolutely no idea what's going on — I don't have much experience with the very low levels of networking in Mercurial, or the (relatively) new peer API. It seems to me that the point of that code is, essentially, to provide a minimal repository or peer that does nothing. Could something like that be moved to Mercurial core?

Okay, I managed to fix it:
https://foss.heptapod.net/mercurial/hg-git/-/merge_requests/130/diffs
https://foss.heptapod.net/mercurial/hg-git/-/merge_requests/131/diffs
Would one of you perhaps take a look at those changes and see if they make sense? I did it in the form of a decorator that just wraps a regular function returning a value. Something like that might be useful for core as well, and simplify a simple method like branchmap().

Sep 11 2021, 11:31 AM

Sep 10 2021

valentin.gatienbaron created D11400: narrow: fix commits of empty files.
Sep 10 2021, 3:14 PM
valentin.gatienbaron created D11399: narrow: show repo corruption when commiting empty files.
Sep 10 2021, 3:13 PM

Aug 30 2021

valentin.gatienbaron closed D11245: tests: rely on dummyssh being the default.
Aug 30 2021, 6:30 AM
valentin.gatienbaron closed D11246: tests: manual cleanup now that dummyssh usage is implied.
Aug 30 2021, 6:28 AM
valentin.gatienbaron closed D11244: tests: setup dummyssh as the default ssh.
Aug 30 2021, 6:28 AM
valentin.gatienbaron committed rHGc89ddef6474d: tests: normalize the way some debug output it matched.
tests: normalize the way some debug output it matched
Aug 30 2021, 6:26 AM
valentin.gatienbaron closed D11361: tests: normalize the way some debug output it matched.
Aug 30 2021, 6:26 AM
valentin.gatienbaron committed rHGe5efbb11e185: tests: drop hgrc bits that have become the default.
tests: drop hgrc bits that have become the default
Aug 30 2021, 6:25 AM
valentin.gatienbaron closed D11247: tests: drop hgrc bits that have become the default.
Aug 30 2021, 6:25 AM
valentin.gatienbaron committed rHG0c92cd9286ee: tests: manual cleanup now that dummyssh usage is implied.
tests: manual cleanup now that dummyssh usage is implied
Aug 30 2021, 6:25 AM
valentin.gatienbaron committed rHG9c4204b7f3e4: tests: rely on dummyssh being the default.
tests: rely on dummyssh being the default
Aug 30 2021, 6:25 AM
valentin.gatienbaron committed rHGa28a7dcb9158: tests: setup dummyssh as the default ssh.
tests: setup dummyssh as the default ssh
Aug 30 2021, 6:25 AM

Aug 27 2021

valentin.gatienbaron updated the diff for D11245: tests: rely on dummyssh being the default.
Aug 27 2021, 9:17 AM
valentin.gatienbaron updated the diff for D11246: tests: manual cleanup now that dummyssh usage is implied.
Aug 27 2021, 9:15 AM
valentin.gatienbaron updated the diff for D11244: tests: setup dummyssh as the default ssh.
Aug 27 2021, 9:14 AM
valentin.gatienbaron added a comment to D11245: tests: rely on dummyssh being the default.

I think this should be fixed. If I understand the diff correctly, it was a slash vs backslash change, and the rest is noise.

Aug 27 2021, 9:13 AM
valentin.gatienbaron created D11361: tests: normalize the way some debug output it matched.
Aug 27 2021, 9:12 AM

Aug 25 2021

valentin.gatienbaron committed rHG517a2c1cb788: tests: rename test-clone-uncompressed.t.
tests: rename test-clone-uncompressed.t
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHG2174f54aab18: store: return just one filename in walk functions.
store: return just one filename in walk functions
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHG308e843f24b1: test: reduce noise, so the important bits stand out.
test: reduce noise, so the important bits stand out
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHGc424ff4807e6: wireprotov1peer: update all rpcs to use the new batchable scheme.
wireprotov1peer: update all rpcs to use the new batchable scheme
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHG0fb328bb2459: debugrebuildfncache: add a cheaper option to rebuild the fncache.
debugrebuildfncache: add a cheaper option to rebuild the fncache
Aug 25 2021, 9:15 AM
valentin.gatienbaron committed rHGcdad6560e832: wireprotov1peer: simplify the way batchable rpcs are defined.
wireprotov1peer: simplify the way batchable rpcs are defined
Aug 25 2021, 9:15 AM

Aug 24 2021

valentin.gatienbaron closed D11248: store: return just one filename in walk functions.
Aug 24 2021, 12:34 PM
valentin.gatienbaron closed D11265: debugrebuildfncache: add a cheaper option to rebuild the fncache.
Aug 24 2021, 12:34 PM
valentin.gatienbaron committed rHGf5394669f57c: store: return just one filename in walk functions.
store: return just one filename in walk functions
Aug 24 2021, 12:33 PM
valentin.gatienbaron committed rHG8e4659b5cf41: debugrebuildfncache: add a cheaper option to rebuild the fncache.
debugrebuildfncache: add a cheaper option to rebuild the fncache
Aug 24 2021, 12:33 PM
valentin.gatienbaron committed rHGcd5a2c977741: tests: rename test-clone-uncompressed.t.
tests: rename test-clone-uncompressed.t
Aug 24 2021, 12:33 PM
valentin.gatienbaron closed D11264: test: reduce noise, so the important bits stand out.
Aug 24 2021, 12:33 PM
valentin.gatienbaron closed D11237: tests: rename test-clone-uncompressed.t.
Aug 24 2021, 12:33 PM
valentin.gatienbaron committed rHGc5216695c54a: test: reduce noise, so the important bits stand out.
test: reduce noise, so the important bits stand out
Aug 24 2021, 12:33 PM
valentin.gatienbaron closed D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.
Aug 24 2021, 11:37 AM
valentin.gatienbaron committed rHGf4f9b0e06fb8: wireprotov1peer: update all rpcs to use the new batchable scheme.
wireprotov1peer: update all rpcs to use the new batchable scheme
Aug 24 2021, 11:36 AM
valentin.gatienbaron closed D11211: wireprotov1peer: simplify the way batchable rpcs are defined.
Aug 24 2021, 11:36 AM
valentin.gatienbaron committed rHG1364337a4613: wireprotov1peer: simplify the way batchable rpcs are defined.
wireprotov1peer: simplify the way batchable rpcs are defined
Aug 24 2021, 11:36 AM
valentin.gatienbaron updated the diff for D11248: store: return just one filename in walk functions.
Aug 24 2021, 10:53 AM
valentin.gatienbaron updated the diff for D11248: store: return just one filename in walk functions.
Aug 24 2021, 10:41 AM
valentin.gatienbaron updated the diff for D11212: wireprotov1peer: update all rpcs to use the new batchable scheme.
Aug 24 2021, 10:18 AM
valentin.gatienbaron updated the diff for D11211: wireprotov1peer: simplify the way batchable rpcs are defined.
Aug 24 2021, 10:18 AM

Aug 6 2021

valentin.gatienbaron created D11265: debugrebuildfncache: add a cheaper option to rebuild the fncache.
Aug 6 2021, 4:45 PM
valentin.gatienbaron created D11264: test: reduce noise, so the important bits stand out.
Aug 6 2021, 4:44 PM

Aug 4 2021

valentin.gatienbaron added a comment to D11243: remotefilelog: fix what looks like a wrong refactoring.

I am definitely not going to write a test. I know nothing about remotefilelog. I merely happened to see this while grepping around.

Aug 4 2021, 6:05 PM
valentin.gatienbaron committed rHG6802422a1ae0: remotefilelog: fix what looks like a wrong refactoring.
remotefilelog: fix what looks like a wrong refactoring
Aug 4 2021, 4:43 PM
valentin.gatienbaron closed D11243: remotefilelog: fix what looks like a wrong refactoring.
Aug 4 2021, 4:43 PM
valentin.gatienbaron created D11248: store: return just one filename in walk functions.
Aug 4 2021, 4:42 PM

Aug 3 2021

valentin.gatienbaron created D11245: tests: rely on dummyssh being the default.
Aug 3 2021, 12:52 AM
valentin.gatienbaron created D11246: tests: manual cleanup now that dummyssh usage is implied.
Aug 3 2021, 12:50 AM
valentin.gatienbaron updated the diff for D11244: tests: setup dummyssh as the default ssh.
Aug 3 2021, 12:49 AM
valentin.gatienbaron created D11247: tests: drop hgrc bits that have become the default.
Aug 3 2021, 12:48 AM

Aug 2 2021

valentin.gatienbaron updated the diff for D11244: tests: setup dummyssh as the default ssh.
Aug 2 2021, 11:18 PM
valentin.gatienbaron created D11244: tests: setup dummyssh as the default ssh.
Aug 2 2021, 10:26 PM
valentin.gatienbaron created D11243: remotefilelog: fix what looks like a wrong refactoring.
Aug 2 2021, 9:57 PM
valentin.gatienbaron added a comment to D11237: tests: rename test-clone-uncompressed.t.

I have been assuming that changes can still be submitted during a change freeze, but they are just going to get ignored for a few days. None of my changes are particularly intended to go on 5.9.

Aug 2 2021, 10:40 AM
valentin.gatienbaron closed D11236: streamclone: ensure the server sends the right amount of data.
Aug 2 2021, 6:44 AM