Page MenuHomePhabricator

valentin.gatienbaron (Valentin Gatien-Baron)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2018, 11:42 AM (70 w, 4 d)

Recent Activity

Tue, Nov 19

valentin.gatienbaron added a comment to D7199: lock: fix race in lock-breaking code.

Thanks for the review. Did something go wrong in a rebase? I'm confused as to why there's two self.vfs.unlink calls in the diff displayed by phabricator.

Tue, Nov 19, 12:06 AM

Mon, Nov 18

valentin.gatienbaron committed rHG039fbd14d4e2: lock: fix race in lock-breaking code.
lock: fix race in lock-breaking code
Mon, Nov 18, 11:11 PM
valentin.gatienbaron closed D7199: lock: fix race in lock-breaking code.
Mon, Nov 18, 11:05 PM
valentin.gatienbaron committed rHG355a6ef12ba9: lock: fix race in lock-breaking code.
lock: fix race in lock-breaking code
Mon, Nov 18, 11:05 PM
valentin.gatienbaron closed D7198: lock: refactor in preparation for next commit.
Mon, Nov 18, 11:05 PM
valentin.gatienbaron committed rHGcd822413b9aa: lock: refactor in preparation for next commit.
lock: refactor in preparation for next commit
Mon, Nov 18, 11:05 PM

Nov 1 2019

valentin.gatienbaron updated the summary of D7199: lock: fix race in lock-breaking code.
Nov 1 2019, 10:04 PM
valentin.gatienbaron updated the summary of D7199: lock: fix race in lock-breaking code.
Nov 1 2019, 10:02 PM
valentin.gatienbaron updated the summary of D7199: lock: fix race in lock-breaking code.
Nov 1 2019, 9:56 PM
valentin.gatienbaron created D7199: lock: fix race in lock-breaking code.
Nov 1 2019, 9:51 PM
valentin.gatienbaron created D7198: lock: refactor in preparation for next commit.
Nov 1 2019, 9:51 PM

Sep 14 2019

valentin.gatienbaron added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

I showed in D6847 the same change but implemented in exchange._processcompared. Tests pass.
I think it'd make for a simpler final state: with the current change, the client sees that the bookmark is going to move sideways, decides this is fine, requests that the server validates that the bookmark is indeed moving sideways (which it does), but in the end the server rejects the move. In the suggested change, the client sees that the bookmark is going sideways and rejects it. This should be consistent with the way new heads or new branches or diverging rewrites are prevented.

Isn't that a client-side change only though, so we still need functionality on the server to reject bad pushes? (I could be missing something.)

Sep 14 2019, 1:56 AM

Sep 13 2019

valentin.gatienbaron added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

I showed in D6847 the same change but implemented in exchange._processcompared. Tests pass.
I think it'd make for a simpler final state: with the current change, the client sees that the bookmark is going to move sideways, decides this is fine, requests that the server validates that the bookmark is indeed moving sideways (which it does), but in the end the server rejects the move. In the suggested change, the client sees that the bookmark is going sideways and rejects it. This should be consistent with the way new heads or new branches or diverging rewrites are prevented.

Sep 13 2019, 12:33 AM
valentin.gatienbaron created D6847: dont-accept-this: this is for reference in D6776.
Sep 13 2019, 12:25 AM

Sep 11 2019

valentin.gatienbaron closed D6831: exchange: convert bookmark nodes from hex to bin ASAP.
Sep 11 2019, 11:34 AM
valentin.gatienbaron closed D6830: exchange: avoid unnecessary conversion of bookmark nodes to hex (API).
Sep 11 2019, 11:34 AM
valentin.gatienbaron committed rHG9fd7710d9ae2: exchange: convert bookmark nodes from hex to bin ASAP.
exchange: convert bookmark nodes from hex to bin ASAP
Sep 11 2019, 11:34 AM
valentin.gatienbaron committed rHGe0bf41b83cef: exchange: avoid unnecessary conversion of bookmark nodes to hex (API).
exchange: avoid unnecessary conversion of bookmark nodes to hex (API)
Sep 11 2019, 11:34 AM

Sep 9 2019

valentin.gatienbaron closed D6829: doc: fix up confusing doc comment.
Sep 9 2019, 12:10 PM
valentin.gatienbaron committed rHG08fce968d00b: doc: fix up confusing doc comment.
doc: fix up confusing doc comment
Sep 9 2019, 12:09 PM

Sep 8 2019

valentin.gatienbaron created D6831: exchange: convert bookmark nodes from hex to bin ASAP.
Sep 8 2019, 8:43 PM
valentin.gatienbaron created D6829: doc: fix up confusing doc comment.
Sep 8 2019, 8:43 PM
valentin.gatienbaron created D6830: exchange: avoid unnecessary conversion of bookmark nodes to hex (API).
Sep 8 2019, 8:42 PM

Sep 6 2019

valentin.gatienbaron committed rHG69195b6f8f97: rustfilepatterns: shorter code for concatenating slices.
rustfilepatterns: shorter code for concatenating slices
Sep 6 2019, 11:28 PM
valentin.gatienbaron committed rHG72890d8f9860: match: simplify the regexps created for glob patterns.
match: simplify the regexps created for glob patterns
Sep 6 2019, 11:28 PM

Sep 5 2019

valentin.gatienbaron closed D6764: match: simplify the regexps created for glob patterns.
Sep 5 2019, 3:16 PM
valentin.gatienbaron closed D6765: rustfilepatterns: shorter code for concatenating slices.
Sep 5 2019, 3:16 PM
valentin.gatienbaron committed rHG406bd21d363b: rustfilepatterns: shorter code for concatenating slices.
rustfilepatterns: shorter code for concatenating slices
Sep 5 2019, 3:16 PM
valentin.gatienbaron closed D6766: rustfilepatterns: refactor the pattern of removing a prefix from a &[u8].
Sep 5 2019, 3:16 PM
valentin.gatienbaron committed rHGcf165e064f1d: match: simplify the regexps created for glob patterns.
match: simplify the regexps created for glob patterns
Sep 5 2019, 3:16 PM
valentin.gatienbaron committed rHG62eabdf91f85: rustfilepatterns: refactor the pattern of removing a prefix from a &[u8].
rustfilepatterns: refactor the pattern of removing a prefix from a &[u8]
Sep 5 2019, 3:16 PM
valentin.gatienbaron closed D6763: tests: show the pattern generated for a relative glob.
Sep 5 2019, 3:15 PM
valentin.gatienbaron committed rHG96ddf83fc267: tests: show the pattern generated for a relative glob.
tests: show the pattern generated for a relative glob
Sep 5 2019, 3:15 PM

Sep 1 2019

valentin.gatienbaron added a comment to D6776: bookmarks: validate changes on push (issue6193) (BC).

(just interested in this change, I don't have any power to actually accept it)

Sep 1 2019, 5:54 PM

Aug 31 2019

valentin.gatienbaron committed rHGee0f511b7a22: rust: fix warnings about trait objects without dyn being deprecated.
rust: fix warnings about trait objects without dyn being deprecated
Aug 31 2019, 11:10 PM
valentin.gatienbaron closed D6770: rust: fix warnings about trait objects without dyn being deprecated.
Aug 31 2019, 6:59 PM
valentin.gatienbaron committed rHGae2a4ef8af02: rust: fix warnings about trait objects without dyn being deprecated.
rust: fix warnings about trait objects without dyn being deprecated
Aug 31 2019, 6:59 PM

Aug 28 2019

valentin.gatienbaron created D6770: rust: fix warnings about trait objects without dyn being deprecated.
Aug 28 2019, 8:19 AM
valentin.gatienbaron added inline comments to D6765: rustfilepatterns: shorter code for concatenating slices.
Aug 28 2019, 7:59 AM
valentin.gatienbaron updated the diff for D6765: rustfilepatterns: shorter code for concatenating slices.
Aug 28 2019, 7:55 AM
valentin.gatienbaron abandoned D6769: another way of implementing the parent.
Aug 28 2019, 7:54 AM
valentin.gatienbaron added inline comments to D6765: rustfilepatterns: shorter code for concatenating slices.
Aug 28 2019, 7:44 AM
valentin.gatienbaron updated the diff for D6764: match: simplify the regexps created for glob patterns.
Aug 28 2019, 7:37 AM
valentin.gatienbaron created D6769: another way of implementing the parent.
Aug 28 2019, 7:37 AM
valentin.gatienbaron updated the diff for D6765: rustfilepatterns: shorter code for concatenating slices.
Aug 28 2019, 7:37 AM
valentin.gatienbaron updated the diff for D6766: rustfilepatterns: refactor the pattern of removing a prefix from a &[u8].
Aug 28 2019, 7:37 AM

Aug 26 2019

valentin.gatienbaron updated the diff for D6764: match: simplify the regexps created for glob patterns.
Aug 26 2019, 8:29 AM
valentin.gatienbaron updated the diff for D6765: rustfilepatterns: shorter code for concatenating slices.
Aug 26 2019, 8:29 AM
valentin.gatienbaron created D6766: rustfilepatterns: refactor the pattern of removing a prefix from a &[u8].
Aug 26 2019, 8:29 AM
valentin.gatienbaron created D6764: match: simplify the regexps created for glob patterns.
Aug 26 2019, 12:17 AM
valentin.gatienbaron created D6765: rustfilepatterns: shorter code for concatenating slices.
Aug 26 2019, 12:16 AM
valentin.gatienbaron created D6763: tests: show the pattern generated for a relative glob.
Aug 26 2019, 12:16 AM

Aug 12 2019

valentin.gatienbaron closed D6722: fncache: make debugrebuildfncache not fail on broken fncache.
Aug 12 2019, 5:23 PM
valentin.gatienbaron committed rHGf59f8a5e9096: fncache: make debugrebuildfncache not fail on broken fncache.
fncache: make debugrebuildfncache not fail on broken fncache
Aug 12 2019, 5:23 PM
valentin.gatienbaron closed D6721: fncache: show that debugrebuildfncache is partly broken.
Aug 12 2019, 5:23 PM
valentin.gatienbaron committed rHG6b71334f2540: fncache: show that debugrebuildfncache is partly broken.
fncache: show that debugrebuildfncache is partly broken
Aug 12 2019, 5:23 PM
valentin.gatienbaron created D6722: fncache: make debugrebuildfncache not fail on broken fncache.
Aug 12 2019, 2:13 PM
valentin.gatienbaron created D6721: fncache: show that debugrebuildfncache is partly broken.
Aug 12 2019, 2:13 PM

Jul 22 2019

valentin.gatienbaron closed D6667: amend: stop committing unrequested file reverts (issue6157).
Jul 22 2019, 7:28 PM
valentin.gatienbaron committed rHGce52377102db: amend: stop committing unrequested file reverts (issue6157).
amend: stop committing unrequested file reverts (issue6157)
Jul 22 2019, 7:27 PM
valentin.gatienbaron closed D6666: amend: add a test for a simplified version of issue6157.
Jul 22 2019, 7:27 PM
valentin.gatienbaron committed rHG464aa857c717: amend: add a test for a simplified version of issue6157.
amend: add a test for a simplified version of issue6157
Jul 22 2019, 7:27 PM
valentin.gatienbaron created D6667: amend: stop committing unrequested file reverts (issue6157).
Jul 22 2019, 6:36 AM
valentin.gatienbaron created D6666: amend: add a test for a simplified version of issue6157.
Jul 22 2019, 6:36 AM

Jul 18 2019

valentin.gatienbaron committed rHG99ebde4fec99: commit: improve the files field of changelog for merges.
commit: improve the files field of changelog for merges
Jul 18 2019, 9:40 AM
valentin.gatienbaron committed rHGd98ec36be808: convert: add a config option to help doing identity hg->hg conversion.
convert: add a config option to help doing identity hg->hg conversion
Jul 18 2019, 9:40 AM
valentin.gatienbaron committed rHG20d0e59be79b: tests: show the files fields of changelogs for many merges.
tests: show the files fields of changelogs for many merges
Jul 18 2019, 9:40 AM
valentin.gatienbaron committed rHG56132ebd14c6: blackbox: disable extremely verbose logging (issue6110).
blackbox: disable extremely verbose logging (issue6110)
Jul 18 2019, 9:39 AM
valentin.gatienbaron added a comment to D6612: tests: show the files fields of changelogs for many merges.

Thanks! I didn't expect this would make it for 5.1.

Jul 18 2019, 8:16 AM
valentin.gatienbaron closed D6613: commit: improve the files field of changelog for merges.
Jul 18 2019, 1:03 AM
valentin.gatienbaron closed D6643: convert: add a config option to help doing identity hg->hg conversion.
Jul 18 2019, 1:02 AM
valentin.gatienbaron committed rHGb928b229a9e7: commit: improve the files field of changelog for merges.
commit: improve the files field of changelog for merges
Jul 18 2019, 1:00 AM
valentin.gatienbaron committed rHG7a44de54490a: convert: add a config option to help doing identity hg->hg conversion.
convert: add a config option to help doing identity hg->hg conversion
Jul 18 2019, 12:59 AM
valentin.gatienbaron closed D6612: tests: show the files fields of changelogs for many merges.
Jul 18 2019, 12:59 AM
valentin.gatienbaron committed rHGcd40411bc384: tests: show the files fields of changelogs for many merges.
tests: show the files fields of changelogs for many merges
Jul 18 2019, 12:59 AM

Jul 17 2019

valentin.gatienbaron committed rHG341222d54bea: blackbox: disable extremely verbose logging (issue6110).
blackbox: disable extremely verbose logging (issue6110)
Jul 17 2019, 7:05 PM
valentin.gatienbaron closed D6611: blackbox: disable extremely verbose logging (issue6110).
Jul 17 2019, 7:05 PM

Jul 16 2019

valentin.gatienbaron added a comment to D6643: convert: add a config option to help doing identity hg->hg conversion.

The update worked for me, thanks.

Jul 16 2019, 10:50 PM

Jul 15 2019

valentin.gatienbaron added a comment to D6643: convert: add a config option to help doing identity hg->hg conversion.

Don't take this as a complete list, but it looks like repository.py, remotefilelog, eol, and probably keyword need to be taught the new kwarg. Note that the keyword wrapper is called kwcommitctx, so it isn't enough to grep for def commitctx.

Jul 15 2019, 6:11 PM
valentin.gatienbaron updated the diff for D6643: convert: add a config option to help doing identity hg->hg conversion.
Jul 15 2019, 6:05 PM

Jul 14 2019

valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

@mharbison72 I dealt with the problem of convert in the previous commit. I didn't add a config option to disable the new code path, because it's really awkward to document, and I think it would be annoying to use if I made more fixes (the other case where files are spuriously listed, involving exec bits, probably has little impact on repo size/pull performance but it may be worth fixing anyway because it causes confusion). But if there are downsides to what I did, the config option is still on the table.

Jul 14 2019, 3:31 PM
valentin.gatienbaron retitled D6613: commit: improve the files field of changelog for merges from commit: improve the files field of changelog for merges (RFC) to commit: improve the files field of changelog for merges.
Jul 14 2019, 3:19 PM
valentin.gatienbaron created D6643: convert: add a config option to help doing identity hg->hg conversion.
Jul 14 2019, 3:17 PM
valentin.gatienbaron updated the summary of D6612: tests: show the files fields of changelogs for many merges.
Jul 14 2019, 3:15 PM

Jul 10 2019

valentin.gatienbaron added inline comments to D6613: commit: improve the files field of changelog for merges.
Jul 10 2019, 9:45 PM
valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

Ok. Maybe it would be simpler or more robust to do the direct thing: optionally treat the files list in the input commit as input and reuse them blindly in the resulting commit, when doing a hg->hg conversion without filemap.

Maybe. I've been wondering if it's possible to just pass along the manifest and changelog instead of recalculating it. It seems there have been other issues over the years[1]. @yuja fixed something manifest related around the time of that thread IIRC. Even if a filemap is in use, the map may not modify early commits. And when those are changed unexpectedly, it makes me wonder what got lost/mangled. I looked through the repos I converted last year without any file mapping, and there were manifest node changes, but also differences in files and files+ in the changelog.

Jul 10 2019, 8:52 PM
valentin.gatienbaron added inline comments to D6611: blackbox: disable extremely verbose logging (issue6110).
Jul 10 2019, 6:21 PM
valentin.gatienbaron updated the diff for D6611: blackbox: disable extremely verbose logging (issue6110).
Jul 10 2019, 6:12 PM
valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

Ok. Maybe it would be simpler or more robust to do the direct thing: optionally treat the files list in the input commit as input and reuse them blindly in the resulting commit, when doing a hg->hg conversion without filemap.
(btw, a tweak to test-merge-combinations shows the cases where convert is not the identity: 12-- and -1--, so cases where a file is absent in p1, that p2 added or modified, and the merge redeletes the file. Commit shows such files are modified (rightly) but convert doesn't)

Jul 10 2019, 8:34 AM

Jul 9 2019

valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

If this goes forward, can this be gated by a config option (even if it is on by default)? IIUC, this will change the hash for merges, and then cascade. That seems problematic for convert operations.
Most converts will do things that change hashes anyway, but the default options don't change anything. This is a convenient behavior for easily migrating to/from LFS, for example. (In theory, anyway. In practice, I've seen repos where a convert alters the changelog.) If there is a config option, convert should probably disable it by default to maintain the current behavior. I can see a use case for enabling it though, to clean up the repo.

Jul 9 2019, 8:40 PM
valentin.gatienbaron updated the summary of D6613: commit: improve the files field of changelog for merges.
Jul 9 2019, 6:45 AM

Jul 8 2019

valentin.gatienbaron added a comment to D6613: commit: improve the files field of changelog for merges.

I hadn't seen the bug you linked to, or your recent change, though I saw ctx.filesadded() and friends (when writing this) and suspected they were written the way they are to work nicely on merges.

Jul 8 2019, 11:03 PM
valentin.gatienbaron closed D6610: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
Jul 8 2019, 9:11 AM
valentin.gatienbaron committed rHG44e99811bea7: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
tweakdefaults: make hg resolve require --re-merge flag to re-merge
Jul 8 2019, 9:11 AM

Jul 7 2019

valentin.gatienbaron created D6613: commit: improve the files field of changelog for merges.
Jul 7 2019, 12:20 PM
valentin.gatienbaron abandoned D6609: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
Jul 7 2019, 12:20 PM
valentin.gatienbaron created D6612: tests: show the files fields of changelogs for many merges.
Jul 7 2019, 12:18 PM
valentin.gatienbaron created D6611: blackbox: disable extremely verbose logging (issue6110).
Jul 7 2019, 12:14 PM
valentin.gatienbaron created D6610: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
Jul 7 2019, 12:12 PM
valentin.gatienbaron created D6609: tweakdefaults: make hg resolve require --re-merge flag to re-merge.
Jul 7 2019, 12:09 PM