Page MenuHomePhabricator

valentin.gatienbaron (Valentin Gatien-Baron)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 5 2018, 11:42 AM (45 w, 16 h)

Recent Activity

Fri, Jun 14

valentin.gatienbaron committed rHG9b5fbe5ead89: deltas: skip if projected compressed size is bigger than previous snapshot.
deltas: skip if projected compressed size is bigger than previous snapshot
Fri, Jun 14, 10:56 AM
valentin.gatienbaron committed rHGc1c1872d25d1: deltas: skip if projected compressed size does not match text size constraint.
deltas: skip if projected compressed size does not match text size constraint
Fri, Jun 14, 10:56 AM
valentin.gatienbaron committed rHG465f2d0df9ae: deltas: accept and skip None return for delta info.
deltas: accept and skip None return for delta info
Fri, Jun 14, 10:56 AM
valentin.gatienbaron committed rHG66c27df1be84: deltas: skip if projected delta size is bigger than previous snapshot.
deltas: skip if projected delta size is bigger than previous snapshot
Fri, Jun 14, 10:56 AM
valentin.gatienbaron committed rHG6e9ba867a946: delta: move some delta chain related computation earlier in deltainfo.
delta: move some delta chain related computation earlier in deltainfo
Fri, Jun 14, 10:56 AM

Thu, Jun 13

valentin.gatienbaron committed rHG87a34c767384: merge: fix race that could cause wrong size in dirstate.
merge: fix race that could cause wrong size in dirstate
Thu, Jun 13, 4:40 PM
valentin.gatienbaron committed rHG5ca136bbd3f6: worker: support parallelization of functions with return values.
worker: support parallelization of functions with return values
Thu, Jun 13, 4:39 PM
valentin.gatienbaron committed rHG0eb8c61c306b: tests: show how the dirstate can end up containing wrong information.
tests: show how the dirstate can end up containing wrong information
Thu, Jun 13, 4:39 PM
valentin.gatienbaron closed D6475: merge: fix race that could cause wrong size in dirstate.
Thu, Jun 13, 10:04 AM
valentin.gatienbaron committed rHG773b02226e93: merge: fix race that could cause wrong size in dirstate.
merge: fix race that could cause wrong size in dirstate
Thu, Jun 13, 10:03 AM
valentin.gatienbaron committed rHG55b724df1a64: worker: support parallelization of functions with return values.
worker: support parallelization of functions with return values
Thu, Jun 13, 10:03 AM
valentin.gatienbaron closed D6515: worker: support parallelization of functions with return values.
Thu, Jun 13, 10:03 AM
valentin.gatienbaron closed D6474: tests: show how the dirstate can end up containing wrong information.
Thu, Jun 13, 10:03 AM
valentin.gatienbaron committed rHGd9a50456ea3d: tests: show how the dirstate can end up containing wrong information.
tests: show how the dirstate can end up containing wrong information
Thu, Jun 13, 10:03 AM
valentin.gatienbaron added inline comments to D6475: merge: fix race that could cause wrong size in dirstate.
Thu, Jun 13, 2:38 AM

Wed, Jun 12

valentin.gatienbaron added inline comments to D6475: merge: fix race that could cause wrong size in dirstate.
Wed, Jun 12, 3:55 PM
valentin.gatienbaron updated the summary of D6475: merge: fix race that could cause wrong size in dirstate.
Wed, Jun 12, 1:27 PM
valentin.gatienbaron created D6515: worker: support parallelization of functions with return values.
Wed, Jun 12, 1:25 PM
valentin.gatienbaron updated the diff for D6474: tests: show how the dirstate can end up containing wrong information.
Wed, Jun 12, 1:25 PM
valentin.gatienbaron closed D6506: revlog: speed up isancestor.
Wed, Jun 12, 12:45 PM
valentin.gatienbaron committed rHG055c3e2c44f0: revlog: speed up isancestor.
revlog: speed up isancestor
Wed, Jun 12, 12:45 PM
valentin.gatienbaron closed D6505: dagop: fix documentation of reachableroots.
Wed, Jun 12, 12:44 PM
valentin.gatienbaron committed rHG3e42fc243741: dagop: fix documentation of reachableroots.
dagop: fix documentation of reachableroots
Wed, Jun 12, 12:44 PM

Mon, Jun 10

valentin.gatienbaron created D6506: revlog: speed up isancestor.
Mon, Jun 10, 2:33 PM
valentin.gatienbaron created D6505: dagop: fix documentation of reachableroots.
Mon, Jun 10, 12:46 PM

Thu, Jun 6

valentin.gatienbaron closed D6477: profiling: show actual time spent in hotpath display.
Thu, Jun 6, 8:22 AM
valentin.gatienbaron committed rHG0ae593e791fb: profiling: show actual time spent in hotpath display.
profiling: show actual time spent in hotpath display
Thu, Jun 6, 8:21 AM

Wed, Jun 5

valentin.gatienbaron updated the diff for D6477: profiling: show actual time spent in hotpath display.
Wed, Jun 5, 9:18 PM
valentin.gatienbaron added a comment to D6477: profiling: show actual time spent in hotpath display.

Oh yeah, I didn't really consider the default. I clearly prefer "true", so I'll change it. Maybe it's not even worth having an option. I think the only advantage of not printing this column is to have 5 more columns available for the code excerpt at the end of lines.

Wed, Jun 5, 9:09 PM
valentin.gatienbaron created D6477: profiling: show actual time spent in hotpath display.
Wed, Jun 5, 3:05 PM

Mon, Jun 3

valentin.gatienbaron created D6475: merge: fix race that could cause wrong size in dirstate.
Mon, Jun 3, 9:01 AM
valentin.gatienbaron created D6474: tests: show how the dirstate can end up containing wrong information.
Mon, Jun 3, 9:00 AM

Jan 17 2019

valentin.gatienbaron closed D5493: match: support rooted globs in hgignore.
Jan 17 2019, 8:42 AM
valentin.gatienbaron committed rHG4fab8a7d2d72: match: support rooted globs in hgignore.
match: support rooted globs in hgignore
Jan 17 2019, 8:42 AM

Jan 16 2019

valentin.gatienbaron added a comment to D5493: match: support rooted globs in hgignore.

Alright, I think I did what you asked for.

Jan 16 2019, 11:30 PM
valentin.gatienbaron updated the diff for D5493: match: support rooted globs in hgignore.
Jan 16 2019, 11:28 AM

Jan 15 2019

valentin.gatienbaron added a comment to D5493: match: support rooted globs in hgignore.

Sorry, it took me a while to come back to this. I renamed the syntax to rootglob.

Jan 15 2019, 11:57 PM
valentin.gatienbaron updated the diff for D5493: match: support rooted globs in hgignore.
Jan 15 2019, 7:02 PM

Jan 4 2019

valentin.gatienbaron created D5493: match: support rooted globs in hgignore.
Jan 4 2019, 3:34 PM

Dec 27 2018

valentin.gatienbaron closed D5482: wireproto: in batch queries, support queries with immediate responses.
Dec 27 2018, 7:34 AM
valentin.gatienbaron committed rHG55e8da487b8a: wireproto: in batch queries, support queries with immediate responses.
wireproto: in batch queries, support queries with immediate responses
Dec 27 2018, 7:33 AM

Dec 24 2018

valentin.gatienbaron created D5482: wireproto: in batch queries, support queries with immediate responses.
Dec 24 2018, 2:44 PM

Dec 23 2018

valentin.gatienbaron added a comment to D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).

IIRC, listkeys is a newer command than lookup. If the peer doesn't support listkeys, I suspect this batch query would fail. In that case, maybe listkeys has to be skipped if the peer doesn't support it and if --bookmark is not specified.

Dec 23 2018, 11:00 PM
valentin.gatienbaron closed D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).
Dec 23 2018, 10:11 PM
valentin.gatienbaron committed rHGbad05a6afdc8: pull: fix inconsistent view of bookmarks during pull (issue4700).
pull: fix inconsistent view of bookmarks during pull (issue4700)
Dec 23 2018, 10:10 PM

Dec 21 2018

valentin.gatienbaron committed rHGc236a491ab7b: test-bookmarks-pushpull: add failing test of issue4700.
test-bookmarks-pushpull: add failing test of issue4700
Dec 21 2018, 9:47 PM

Dec 20 2018

valentin.gatienbaron added a comment to D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).

I'd prefer not to have unpredictable aborts where, when they happen, the solution is "try again". A year or two ago, the "remote heads changed during push" errors were like that, and they were annoying.

Dec 20 2018, 11:05 PM
valentin.gatienbaron abandoned D5448: pull: update comment and refactor in preparation for next commit.
Dec 20 2018, 10:51 PM
valentin.gatienbaron updated the diff for D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).
Dec 20 2018, 10:50 PM
valentin.gatienbaron closed D5447: test: adding test of issue4700.
Dec 20 2018, 8:14 AM
valentin.gatienbaron committed rHG357bd3ecf1b2: test-bookmarks-pushpull: add failing test of issue4700.
test-bookmarks-pushpull: add failing test of issue4700
Dec 20 2018, 8:14 AM

Dec 19 2018

valentin.gatienbaron added a comment to D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).

I went this way in part because it's fairly simple change, and might be useful in other circumstances (to interpret pulling a tag as actually pulling the tag itself perhaps, though I don't know concretely how that would work).

Dec 19 2018, 10:34 PM
valentin.gatienbaron added a comment to D5447: test: adding test of issue4700.

Ok. I added the b'', as this change created a small conflict later.

Dec 19 2018, 8:34 AM
valentin.gatienbaron updated the diff for D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).
Dec 19 2018, 8:34 AM
valentin.gatienbaron updated the diff for D5447: test: adding test of issue4700.
Dec 19 2018, 8:31 AM

Dec 18 2018

valentin.gatienbaron created D5449: pull: fix inconsistent view of bookmarks during pull (issue4700).
Dec 18 2018, 9:01 AM
valentin.gatienbaron created D5448: pull: update comment and refactor in preparation for next commit.
Dec 18 2018, 8:58 AM
valentin.gatienbaron created D5447: test: adding test of issue4700.
Dec 18 2018, 8:58 AM

Nov 22 2018

valentin.gatienbaron closed D5294: tests: make test-check-module-imports more robust.
Nov 22 2018, 8:33 AM
valentin.gatienbaron committed rHGdd028bca9221: tests: make test-check-module-imports more robust.
tests: make test-check-module-imports more robust
Nov 22 2018, 8:33 AM

Nov 21 2018

valentin.gatienbaron updated the diff for D5294: tests: make test-check-module-imports more robust.
Nov 21 2018, 2:09 PM
valentin.gatienbaron updated the diff for D5294: tests: make test-check-module-imports more robust.
Nov 21 2018, 1:26 PM
valentin.gatienbaron created D5294: tests: make test-check-module-imports more robust.
Nov 21 2018, 1:13 PM

Nov 20 2018

valentin.gatienbaron added a comment to D5288: tests: make test-alias.t pass with re2.

Thanks. FWIW, re2 options allow to choose an encoding which is latin1 or utf8 (https://github.com/google/re2/blob/master/re2/re2.h#L609). Presumably latin1 means that "." matches a byte, which would seem more compatible with re, but python bindings don't provide the ability to choose this encoding.

Nov 20 2018, 11:42 PM
valentin.gatienbaron closed D5288: tests: make test-alias.t pass with re2.
Nov 20 2018, 7:27 AM
valentin.gatienbaron committed rHG557d3509da55: tests: make test-alias.t pass with re2.
tests: make test-alias.t pass with re2
Nov 20 2018, 7:27 AM

Nov 19 2018

valentin.gatienbaron abandoned D5273: hgignore: conversion glob into regex faster.

will be subsumed by a more thorough change

Nov 19 2018, 2:22 PM
valentin.gatienbaron created D5288: tests: make test-alias.t pass with re2.
Nov 19 2018, 1:40 PM
valentin.gatienbaron updated the diff for D5273: hgignore: conversion glob into regex faster.
Nov 19 2018, 1:33 PM

Nov 14 2018

valentin.gatienbaron created D5273: hgignore: conversion glob into regex faster.
Nov 14 2018, 2:48 PM

Oct 25 2018

valentin.gatienbaron closed D5187: help: describe what ui.tweakdefaults changes, concretely.
Oct 25 2018, 7:41 AM
valentin.gatienbaron committed rHGe928bedf0919: help: describe what ui.tweakdefaults changes, concretely.
help: describe what ui.tweakdefaults changes, concretely
Oct 25 2018, 7:41 AM

Oct 24 2018

valentin.gatienbaron added a comment to D5187: help: describe what ui.tweakdefaults changes, concretely.

I actually ran the tests, but didn't see the style error, because the test in question is among the several ones that never pass for me. Fixed now.

Oct 24 2018, 7:29 PM
valentin.gatienbaron abandoned D5186: help: when replacing placeholders in help files, insert indented text.
Oct 24 2018, 11:05 AM
valentin.gatienbaron updated the diff for D5187: help: describe what ui.tweakdefaults changes, concretely.
Oct 24 2018, 11:01 AM

Oct 23 2018

valentin.gatienbaron created D5187: help: describe what ui.tweakdefaults changes, concretely.
Oct 23 2018, 3:28 PM
valentin.gatienbaron created D5186: help: when replacing placeholders in help files, insert indented text.
Oct 23 2018, 3:28 PM

Oct 4 2018

valentin.gatienbaron closed D4872: identify: show remote bookmarks in `hg id url -Tjson -B`.
Oct 4 2018, 8:31 AM
valentin.gatienbaron committed rHGfcad7fdc6474: identify: show remote bookmarks in `hg id url -Tjson -B`.
identify: show remote bookmarks in `hg id url -Tjson -B`
Oct 4 2018, 8:31 AM

Oct 3 2018

valentin.gatienbaron created D4872: identify: show remote bookmarks in `hg id url -Tjson -B`.
Oct 3 2018, 6:20 PM
valentin.gatienbaron added a comment to D4819: identify: only query remote bookmarks if needed.

In this case, we'll have to load 'bookmarks' if --bookmarks is set. I have
no idea if default and not ui.quiet should be handled in the same way.
Can you send a followup?

Oct 3 2018, 8:56 AM
valentin.gatienbaron closed D4839: identify: when using -T, avoid unnecessary remote bookmarks query.
Oct 3 2018, 8:29 AM
valentin.gatienbaron closed D4819: identify: only query remote bookmarks if needed.
Oct 3 2018, 8:29 AM
valentin.gatienbaron committed rHGa91398dc73ab: identify: when using -T, avoid unnecessary remote bookmarks query.
identify: when using -T, avoid unnecessary remote bookmarks query
Oct 3 2018, 8:29 AM
valentin.gatienbaron committed rHGc9026e9297e3: identify: only query remote bookmarks if needed.
identify: only query remote bookmarks if needed
Oct 3 2018, 8:29 AM

Oct 2 2018

valentin.gatienbaron created D4839: identify: when using -T, avoid unnecessary remote bookmarks query.
Oct 2 2018, 12:19 PM
valentin.gatienbaron updated the diff for D4819: identify: only query remote bookmarks if needed.
Oct 2 2018, 12:19 PM

Oct 1 2018

valentin.gatienbaron committed rHG566cc633e637: logtoprocess: define $HG for children processes.
logtoprocess: define $HG for children processes
Oct 1 2018, 12:28 PM
valentin.gatienbaron created D4819: identify: only query remote bookmarks if needed.
Oct 1 2018, 10:30 AM

Sep 27 2018

valentin.gatienbaron committed rHGff8f4c73d9ad: logtoprocess: define $HG for children processes.
logtoprocess: define $HG for children processes
Sep 27 2018, 7:30 AM
valentin.gatienbaron closed D4768: logtoprocess: define $HG for children processes.
Sep 27 2018, 7:30 AM

Sep 26 2018

valentin.gatienbaron created D4768: logtoprocess: define $HG for children processes.
Sep 26 2018, 6:41 PM
valentin.gatienbaron closed D4742: revset: make heads(commonancestors(x + x^)) be x^, not x.
Sep 26 2018, 7:35 AM
valentin.gatienbaron closed D4738: revset: make commonancestors(x + x^) be ::(x^), not ::x.
Sep 26 2018, 7:35 AM
valentin.gatienbaron closed D4740: revset: reword commonancestor()'s help.
Sep 26 2018, 7:35 AM
valentin.gatienbaron committed rHG823f34acfd46: revset: make heads(commonancestors(x + x^)) be x^, not x.
revset: make heads(commonancestors(x + x^)) be x^, not x
Sep 26 2018, 7:35 AM
valentin.gatienbaron closed D4739: revset: remove part of the commonancestors() comment.
Sep 26 2018, 7:34 AM
valentin.gatienbaron committed rHG0561e69ed9f1: revset: reword commonancestor()'s help.
revset: reword commonancestor()'s help
Sep 26 2018, 7:34 AM
valentin.gatienbaron committed rHG84c61c1593c4: revset: add tests of heads(commonancestors(..)).
revset: add tests of heads(commonancestors(..))
Sep 26 2018, 7:34 AM
valentin.gatienbaron closed D4741: revset: add tests of heads(commonancestors(..)).
Sep 26 2018, 7:34 AM