yuja (Yuya Nishihara)
User

Projects

User Details

User Since
Jun 29 2017, 11:25 AM (72 w, 3 d)

Recent Activity

Sat, Nov 17

yuja added a comment to D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t.

> + $ if [ -x /usr/local/bin/gmake ] ; then
> + > MAKE=gmake

Isn't this assuming that /usr/local/bin is in $PATH? IOW, shouldn't this
assignment be:

	MAKE=/usr/local/bin/gmake
Sat, Nov 17, 9:56 PM
yuja added a comment to D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t.

Missing includes of stdint.h and stddef.h (or stdlib.h).

Sat, Nov 17, 9:30 PM
yuja added a comment to D5278: narrow: detect if narrowspec was changed in a different share.
  1. d1/f, d3/f, d3/g and d5/f should no longer be reported $ hg -R main files + not deleting possibly dirty file d3/f + not deleting possibly dirty file d3/g + not deleting possibly dirty file d5/f
Sat, Nov 17, 2:25 AM

Fri, Nov 16

yuja committed rHG3bc2e550f2bd: graft: do not try to skip rev derived from ancestor more than once (issue6024).
graft: do not try to skip rev derived from ancestor more than once (issue6024)
Fri, Nov 16, 11:04 PM
yuja committed rHGd0895b5f51c9: graft: do not try to skip rev derived from ancestor more than once (issue6024).
graft: do not try to skip rev derived from ancestor more than once (issue6024)
Fri, Nov 16, 5:31 PM
yuja added a comment to D5279: rebase: fix two ui.logs to actually have text when using default blackbox log.

+ self.repo.ui.log("rebase",
+ "using in-memory rebase: %r\n" % self.inmemory,

Fri, Nov 16, 8:58 AM

Thu, Nov 15

yuja committed rHG85372dc0cca3: blackbox: extract function to test if log event is tracked.
blackbox: extract function to test if log event is tracked
Thu, Nov 15, 9:42 AM
yuja committed rHG179c02baaa8c: blackbox: initialize repo attribute properly.
blackbox: initialize repo attribute properly
Thu, Nov 15, 9:42 AM
yuja committed rHG6d9a87fb8c89: blackbox: initialize inlog flag properly.
blackbox: initialize inlog flag properly
Thu, Nov 15, 9:42 AM
yuja committed rHGfff3e213ace9: blackbox: unindent "if True" block.
blackbox: unindent "if True" block
Thu, Nov 15, 9:42 AM
yuja committed rHGa9393d7600f3: blackbox: extract logger class from ui wrapper.
blackbox: extract logger class from ui wrapper
Thu, Nov 15, 9:42 AM
yuja committed rHG56694b4d41b0: blackbox: rename variables to prepare extracting core logic from ui wrapper.
blackbox: rename variables to prepare extracting core logic from ui wrapper
Thu, Nov 15, 9:42 AM
yuja committed rHG437520219e0c: merge with stable.
merge with stable
Thu, Nov 15, 6:34 AM
yuja added a comment to D5273: hgignore: faster conversion from globs to regexp.
I couldn't find documentation on how encoding works for this (user
data interpreted by hg). This function appears to assume the
encoding of the input pattern is an extension of ascii, so I think
my change should be correct for that.
Thu, Nov 15, 6:33 AM

Wed, Nov 14

yuja committed rHGc9876c00d292: blackbox: extract _log() function which is called after lastui is resolved.
blackbox: extract _log() function which is called after lastui is resolved
Wed, Nov 14, 1:02 PM
yuja committed rHGda3bc2f54b02: blackbox: simply update global lastui variable at once.
blackbox: simply update global lastui variable at once
Wed, Nov 14, 1:02 PM
yuja committed rHG4a38a67d0e96: blackbox: inline temporary variables which are referenced only once.
blackbox: inline temporary variables which are referenced only once
Wed, Nov 14, 1:02 PM
yuja committed rHG345cdb93851b: blackbox: consolidate conditions for early return.
blackbox: consolidate conditions for early return
Wed, Nov 14, 1:02 PM
yuja committed rHG5bd3d6b264c1: blackbox: remove redundant check for unassigned repo.
blackbox: remove redundant check for unassigned repo
Wed, Nov 14, 1:02 PM
yuja added a comment to D5268: shelve: use matcher to restrict prefetch to just the modified files.

+ # Create a matcher so that prefetch doesn't attempt to fetch the entire
+ # repository pointlessly.
+ match = scmutil.matchfiles(repo, repo[node].files())

with shelvedfile(repo, name, patchextension).opener('wb') as fp:
  • cmdutil.exportfile(repo, [node], fp, opts=mdiff.diffopts(git=True)) + cmdutil.exportfile(repo, [node], fp, opts=mdiff.diffopts(git=True), + match=match)
Wed, Nov 14, 8:02 AM
yuja added a comment to D5267: revlog: automatically read from opened file handles.

This looked a bit scary, but it should work so long as both reader and writer
sides do seek().

Wed, Nov 14, 7:28 AM

Tue, Nov 13

yuja committed rHGd2c997b8001f: logtoprocess: drop support for ui.log() call with invalid msg arguments (BC).
logtoprocess: drop support for ui.log() call with invalid msg arguments (BC)
Tue, Nov 13, 8:04 PM
yuja committed rHG175b590b1f51: py3: byte-stringify inline extension in test-logtoprocess.t.
py3: byte-stringify inline extension in test-logtoprocess.t
Tue, Nov 13, 8:04 PM
yuja committed rHGb2e5a554bc7b: logtoprocess: rewrite dict building in py3-compatible way.
logtoprocess: rewrite dict building in py3-compatible way
Tue, Nov 13, 8:04 PM
yuja committed rHGfbac323eb625: logtoprocess: leverage procutil.shellenviron() to stringify variables (BC).
logtoprocess: leverage procutil.shellenviron() to stringify variables (BC)
Tue, Nov 13, 8:04 PM
yuja committed rHGff8b2886c492: templater: check invalid use of list expression properly (issue5920).
templater: check invalid use of list expression properly (issue5920)
Tue, Nov 13, 8:04 PM
yuja added a comment to D5257: manifest: also reject obviously-too-short lines when parsing lines.

+ if ((next - data) < 22) {
+ /* We should have at least 22 bytes in a line:
+ 1 byte filename
+ 1 NUL
+ 20 bytes of hash

Tue, Nov 13, 6:38 AM

Mon, Nov 12

yuja committed rHG04d08f17ce7a: help: document weird behavior of uisetup().
help: document weird behavior of uisetup()
Mon, Nov 12, 8:56 PM
yuja committed rHG252396a6a3f2: help: merge section about uisetup() and extsetup().
help: merge section about uisetup() and extsetup()
Mon, Nov 12, 8:56 PM
yuja committed rHG419d703115b0: help: add internals.extensions topic.
help: add internals.extensions topic
Mon, Nov 12, 8:56 PM
yuja committed rHG234c2d8c9e48: commandserver: send raw progress information to message channel.
commandserver: send raw progress information to message channel
Mon, Nov 12, 8:56 PM
yuja committed rHG6f0941f4a184: commandserver: make getpass() request distinct from normal prompt.
commandserver: make getpass() request distinct from normal prompt
Mon, Nov 12, 8:56 PM
yuja committed rHG83e571ea06a9: commandserver: attach prompt default and choices to message.
commandserver: attach prompt default and choices to message
Mon, Nov 12, 8:56 PM
yuja committed rHGc49283e740da: test-commandserver: clean up quoting and location of dbgui extension.
test-commandserver: clean up quoting and location of dbgui extension
Mon, Nov 12, 8:56 PM
yuja committed rHG83dd8c63a0c6: ui: extract helpers to write message with type or label.
ui: extract helpers to write message with type or label
Mon, Nov 12, 8:56 PM
yuja committed rHG9683dfb6f13a: commandserver: fix reference before assignment error in pipeservice cleanup.
commandserver: fix reference before assignment error in pipeservice cleanup
Mon, Nov 12, 8:56 PM
yuja committed rHG054d0fcba2c4: commandserver: add experimental option to use separate message channel.
commandserver: add experimental option to use separate message channel
Mon, Nov 12, 8:56 PM
yuja committed rHG5542bc9125c9: dispatch: pass around ui.fmsg channel.
dispatch: pass around ui.fmsg channel
Mon, Nov 12, 8:55 PM
yuja committed rHG3b0f07cc9626: test-subrepo: document why share magically works even if subrepos are missing.
test-subrepo: document why share magically works even if subrepos are missing
Mon, Nov 12, 8:55 PM
yuja committed rHGa694a7159125: store: pass in decoded filename to narrow matcher.
store: pass in decoded filename to narrow matcher
Mon, Nov 12, 1:35 PM
yuja committed rHG186921bc8e66: test-narrow-clone-stream: include no usefncache case which is broken.
test-narrow-clone-stream: include no usefncache case which is broken
Mon, Nov 12, 1:35 PM
yuja committed rHGa4c2788e8f48: test-narrow-clone-stream: include uppercase letter in filename.
test-narrow-clone-stream: include uppercase letter in filename
Mon, Nov 12, 1:35 PM

Fri, Nov 9

yuja committed rHGdb61a18148a4: merge with stable.
merge with stable
Fri, Nov 9, 10:23 PM

Thu, Nov 8

yuja added a comment to D5139: store: introduce _matchtrackedpath() and use it to filter store files.

Can you add the following tests?

Thu, Nov 8, 7:12 AM
yuja added a comment to D5243: resolve: fix mark-check when a file was deleted on one side (issue6020).
  • with repo.wvfs(f) as fobj:
  • fdata = fobj.read() + try: + with repo.wvfs(f) as fobj: + fdata = fobj.read() + except (IOError, OSError) as inst: + if inst.errno != errno.ENOENT: + raise
Thu, Nov 8, 6:45 AM
yuja added a comment to D5235: revlog: replace PyInt_AS_LONG with a more portable helper function.

I didn't notice it last time, sorry.

Thu, Nov 8, 6:27 AM

Wed, Nov 7

yuja added a comment to D5235: revlog: replace PyInt_AS_LONG with a more portable helper function.

+/* Convert a PyInt or PyLong to a long. Returns false if there is an
+ error, in which case an exception will already have been set. */
+static inline bool pylong_to_long(PyObject *pylong, long *out)

Wed, Nov 7, 7:36 AM
yuja added a comment to D5237: fix: add suboption for configuring execution order of tools.

+ When multiple tools are configured to affect a file, they execute in an order
+ defined by the :priority suboption. The priority suboption has a default value
+ of zero for each tool. Tools are executed in order of ascending priority.

Wed, Nov 7, 7:34 AM

Tue, Nov 6

yuja committed rHG840cd57cde32: ui: add config knob to redirect status messages to stderr (API).
ui: add config knob to redirect status messages to stderr (API)
Tue, Nov 6, 10:21 AM
yuja committed rHGd8997c5ce2ff: ui: label prompt and echo messages.
ui: label prompt and echo messages
Tue, Nov 6, 10:20 AM
yuja committed rHG7bffbbe03e90: ui: hide fin/fout/ferr attributes behind @property functions.
ui: hide fin/fout/ferr attributes behind @property functions
Tue, Nov 6, 10:20 AM
yuja committed rHGc2aea007130b: ui: add inner function to select write destination.
ui: add inner function to select write destination
Tue, Nov 6, 10:20 AM
yuja committed rHG06e841e72523: ui: remove _write() and _write_err() functions.
ui: remove _write() and _write_err() functions
Tue, Nov 6, 10:20 AM
yuja committed rHG04a9dd8da959: ui: move pre/post processes from low-level write()s to _writenobuf().
ui: move pre/post processes from low-level write()s to _writenobuf()
Tue, Nov 6, 10:20 AM
yuja committed rHGc5e964f75bf7: ui: pass in file object to _writenobuf().
ui: pass in file object to _writenobuf()
Tue, Nov 6, 10:20 AM
yuja added a comment to D5224: revlog: check if PyInt_AS_LONG failed before using result.
In this case, I suspect something really weird because `PyInt_AS_LONG()` doesn't exist on Python 3 and the docs for Python 2 say it performs no error checking. So the fact that it is setting an exception on Python 3 causes me to raise an eyebrow.
Tue, Nov 6, 7:38 AM
yuja added a comment to D5220: revsets: make bookmark/named('re:nonexistent') revset not abort (issue6018).

Flagged as (BC) and queued, thanks.

Tue, Nov 6, 6:51 AM
yuja added a comment to D5226: fix: rename :fileset subconfig to :pattern.
This name was always inaccurate, since the config accepts any pattern.
Hopefully so few people use this right now that it won't matter, but there will
now be a warning if the old config name is used.
Tue, Nov 6, 6:51 AM

Mon, Nov 5

yuja committed rHG25732c5678bc: ui: wrap whole _write() block with timeblockedsection.
ui: wrap whole _write() block with timeblockedsection
Mon, Nov 5, 3:08 PM
yuja committed rHG0c7b2035a604: ui: indent _writenobuf() to prepare moving bits from _write() functions.
ui: indent _writenobuf() to prepare moving bits from _write() functions
Mon, Nov 5, 3:08 PM
yuja committed rHG51091816a355: ui: simply concatenate messages before applying color labels.
ui: simply concatenate messages before applying color labels
Mon, Nov 5, 3:08 PM
yuja committed rHG49746e53ac92: ui: simplify interface of low-level write() functions.
ui: simplify interface of low-level write() functions
Mon, Nov 5, 3:08 PM
yuja committed rHG3c4b9dace7de: ui: consolidate places where _progclear() is called.
ui: consolidate places where _progclear() is called
Mon, Nov 5, 3:08 PM
yuja committed rHGfd60c2afb484: ui: factor out function that writes data to fout/ferr with labeling.
ui: factor out function that writes data to fout/ferr with labeling
Mon, Nov 5, 3:08 PM
yuja committed rHGd11e2c5b287e: templater: compute revset lazily.
templater: compute revset lazily
Mon, Nov 5, 3:08 PM

Sat, Nov 3

yuja added a comment to D5218: resolve: when resolve.mark-check=abort, downgrade to warning if pats specified.

Queued for stable, thanks.

Sat, Nov 3, 10:10 PM
yuja added a comment to D5199: test: fix self._testdir to use ues the right mercurial library during testing.

Queued, thanks.

Sat, Nov 3, 9:58 PM

Fri, Nov 2

yuja added a comment to D5199: test: fix self._testdir to use ues the right mercurial library during testing.
  • a/tests/run-tests.py +++ b/tests/run-tests.py @@ -2527,13 +2527,14 @@ os.umask(oldmask)

    def _run(self, testdescs): + testdir = getcwdb()
Fri, Nov 2, 9:44 PM
yuja added a comment to D5207: tests: skip wireproto clientreactor tests on Python 3.6.0-3.6.3 inclusive.
if __name__ == '__main__':

+ if (3, 6, 0) <= sys.version_info <= (3, 6, 3):
+ # Python 3.6.0 through 3.6.3 inclusive shipped with
+ # https://bugs.python.org/issue31825 and we can't run these
+ # tests on those specific versions of Python. Sigh.
+ sys.exit(0)

Fri, Nov 2, 9:32 PM
yuja added a comment to D5200: fix: add a config to abort when a fixer tool fails.

Looks good, but test-check-config.t failed probably because the doc couldn't
be found by the checker.

Fri, Nov 2, 9:32 PM
yuja added a comment to D5210: statprof: clean up unicode/bytes a little.

Maybe missing b'' ?

Fri, Nov 2, 9:32 PM
yuja committed rHG592feb3f88b1: templatekw: deprecate p1rev/p2rev/p1node/p2node in favor of p1/p2.
templatekw: deprecate p1rev/p2rev/p1node/p2node in favor of p1/p2
Fri, Nov 2, 3:03 PM
yuja committed rHG8fa26f3baf30: templater: add wrapper for a single template mapping.
templater: add wrapper for a single template mapping
Fri, Nov 2, 3:03 PM
yuja committed rHG539efc88513b: templatekw: add p1/p2 keywords which switches the current ctx.
templatekw: add p1/p2 keywords which switches the current ctx
Fri, Nov 2, 3:03 PM
yuja committed rHG2891ee3fcb86: templatekw: extract internal "{rev}:{node|formatnode}" template to constant.
templatekw: extract internal "{rev}:{node|formatnode}" template to constant
Fri, Nov 2, 3:03 PM
yuja committed rHGa91a2837150b: rust: fix signature of rustlazyancestors_init() function.
rust: fix signature of rustlazyancestors_init() function
Fri, Nov 2, 1:52 PM
yuja committed rHG1bf3e6041e2c: tests: require SQLite 3.8.3+ as sqlitestore relies on "WITH" clause.
tests: require SQLite 3.8.3+ as sqlitestore relies on "WITH" clause
Fri, Nov 2, 1:52 PM
yuja added a comment to D5094: merge-tools: when calling external merge tool, describe the resolve inputs.
>   class mappingdict(mappable, _mappingsequence):
>       """Wrapper for a single template mapping
>   
>       This isn't a sequence in a way that the underlying dict won't be iterated
>       as a dict, but shares most of the _mappingsequence functions.
>       """
>   
>       def __init__(self, mapping, name=None, tmpl=None):
>           super(mappingdict, self).__init__(name, tmpl)
>           self._mapping = mapping
>   
>       def tomap(self, context):
>           return self._mapping
>   
>       def tobool(self, context, mapping):
>           # no idea when a template mapping should be considered an empty, but
>           # a mapping dict should have at least one item in practice, so always
>           # mark this as non-empty.
>           return True
>   
>       def tovalue(self, context, mapping):
>           return super(mappingdict, self).tovalue(context, mapping)[0]

I copy/pasted this to https://phab.mercurial-scm.org/D5211. :)
Fri, Nov 2, 9:20 AM

Thu, Nov 1

yuja added a comment to D4750: filelog: stop proxying rawsize() (API).
> Apparently thg uses this to avoid loading the data into memory just to figure out the length like fctx.rawsize().  Any suggestions?
>
> https://groups.google.com/d/msg/thg-dev/6ekYID7ho_o/fbdd6rVDAwAJ


Just found this comment when going through mail backlog.

Do we want to do anything about this before the 4.8 release?
Thu, Nov 1, 7:01 AM

Wed, Oct 31

yuja committed rHG8ebb05f747e5: fix: disable use of thread-based worker.
fix: disable use of thread-based worker
Wed, Oct 31, 2:10 PM
yuja added a comment to D5195: changegroup: introduce an explicit linear sorting.
> >   We still need to linearize the revisions in some cases, introduce an explicit
> >   `linear` sorting before changing back the default order.
>
> I'm a little confused about this. We do introduce `nodesorder='linear'`, but
>  there seems no user of that option. Are there unsent patches?


The message should have said `We **may** still need to`. There is no user of that option yet so we can drop it.

I think we should at least keep the option in `storageutil.emitrevision` so we can experiment around doing a DAG sort for various operations, @indygreg seems to have some perf improvements on the firefox repo with it
Wed, Oct 31, 9:51 AM
yuja added a comment to D5195: changegroup: introduce an explicit linear sorting.
We still need to linearize the revisions in some cases, introduce an explicit
`linear` sorting before changing back the default order.
Wed, Oct 31, 7:59 AM

Mon, Oct 29

yuja committed rHG24cb8a6d4c20: py3: do not stringify integers in revlog stats by '%s'.
py3: do not stringify integers in revlog stats by '%s'
Mon, Oct 29, 4:47 PM
yuja committed rHG88702fd208ce: py3: convert revlog stats to a dict of (bytes, int) pairs.
py3: convert revlog stats to a dict of (bytes, int) pairs
Mon, Oct 29, 4:47 PM

Thu, Oct 25

yuja added a comment to D5187: help: describe what ui.tweakdefaults changes, concretely.

Looks good and simple. Queued for stable, thanks.

Thu, Oct 25, 7:35 AM

Wed, Oct 24

yuja added a comment to D5187: help: describe what ui.tweakdefaults changes, concretely.

Nit: ui as uimod per test-check-code.t.

Wed, Oct 24, 7:45 AM
yuja added a comment to D5186: help: when replacing placeholders in help files, insert indented text.
  • a/mercurial/help.py +++ b/mercurial/help.py @@ -391,6 +391,12 @@ single documentation block and use it to overwrite the marker in doc. """ entries = [] + markerindent = 0 + markerpos = doc.find(marker) + if markerpos >= 0: + newlinepos = doc.rfind('\n', 0, markerpos) + if newlinepos >= 0: + markerindent = markerpos - newlinepos - 1
Wed, Oct 24, 7:45 AM

Tue, Oct 23

yuja added a reverting commit for rHG236bb604dc39: scmutil: update cached copy when filecached attribute is assigned (issue3263): rHG7caf632e30c3: filecache: unimplement __set__() and __delete__() (API).
Tue, Oct 23, 10:52 AM
yuja committed rHG7caf632e30c3: filecache: unimplement __set__() and __delete__() (API).
filecache: unimplement __set__() and __delete__() (API)
Tue, Oct 23, 10:52 AM
yuja committed rHG5e5c8f2a1eb5: branchmap: do not specify changelog as an argument.
branchmap: do not specify changelog as an argument
Tue, Oct 23, 10:52 AM
yuja committed rHG36ba91e06948: exewrapper: apply clang-format to silence test-check-clang-format.t.
exewrapper: apply clang-format to silence test-check-clang-format.t
Tue, Oct 23, 10:52 AM
yuja committed rHG597bb5a6867f: filecache: use try-except for faster __dict__ lookup.
filecache: use try-except for faster __dict__ lookup
Tue, Oct 23, 10:52 AM
yuja added a comment to D5087: help: displaying documented aliases by default.

Queued the series for 4.9, many thanks.

Tue, Oct 23, 7:35 AM

Mon, Oct 22

yuja committed rHG1feb4b2c8e40: commands: restore compatibility for "^cmd" registration (issue6005).
commands: restore compatibility for "^cmd" registration (issue6005)
Mon, Oct 22, 11:49 AM
yuja added a comment to D4820: logtoprocess: sends the canonical command name to the subprocess.

+ # extract the canonical command from the passed opts.
+ # we need to pop it up from the opts else the msg will try
+ # being formatted using the passed opts.

Mon, Oct 22, 9:28 AM
yuja added a comment to D5179: command: reintroduce support for commands starting with ^ (issue6005).
Do we have performance concerns around the deprecation, how often is called `loadcmdtable`? My gut feeling is telling me it shouldn't matter but I would prefer to be sure.
Mon, Oct 22, 9:28 AM
yuja added a comment to D5179: command: reintroduce support for commands starting with ^ (issue6005).

FYI, I've posted a similar fix a few days ago.

Mon, Oct 22, 7:51 AM

Sun, Oct 21

yuja committed rHGcc4586749c8c: statprof: fix overflow while skipping boilerplate parts.
statprof: fix overflow while skipping boilerplate parts
Sun, Oct 21, 11:21 AM
yuja committed rHGfc4c598dd4a0: statprof: fix indent level of fp.write() (issue6004).
statprof: fix indent level of fp.write() (issue6004)
Sun, Oct 21, 11:21 AM

Sat, Oct 20

yuja added a comment to D5170: branchmap: pass changelog into revbranchcache.branchinfo().

> rbc = self.revbranchcache()
> + cl = self.changelog

Perhaps it has to be self.unfiltered().changelog because revbranchcache is
initialized with the unfiltered repo.

Sat, Oct 20, 3:36 AM