yuja (Yuya Nishihara)
User

Projects

User Details

User Since
Jun 29 2017, 11:25 AM (64 w, 2 d)

Recent Activity

Yesterday

yuja committed rHGc48738923dba: bookmarks: remove --active in favor of --list.
bookmarks: remove --active in favor of --list
Fri, Sep 21, 11:16 AM
yuja committed rHGb05b4b91de3d: bookmarks: add explicit option to list bookmarks of the given names.
bookmarks: add explicit option to list bookmarks of the given names
Fri, Sep 21, 11:16 AM
yuja committed rHG2d478b05fb14: bookmarks: reject --delete with --inactive which makes no sense.
bookmarks: reject --delete with --inactive which makes no sense
Fri, Sep 21, 11:16 AM
yuja committed rHG5dfc0ca02aa0: bookmarks: parse out --inactive to action early.
bookmarks: parse out --inactive to action early
Fri, Sep 21, 11:16 AM
yuja committed rHGec723284d07a: bookmarks: parse out implicit "add" action early.
bookmarks: parse out implicit "add" action early
Fri, Sep 21, 11:16 AM
yuja committed rHG2b91805e34c7: bookmarks: clarify that opts['rename'] points to an old bookmark to be renamed.
bookmarks: clarify that opts['rename'] points to an old bookmark to be renamed
Fri, Sep 21, 11:16 AM
yuja committed rHG78ee63c77bb3: bookmarks: refactor option checking to pick one from --delete/rename/active.
bookmarks: refactor option checking to pick one from --delete/rename/active
Fri, Sep 21, 11:16 AM
yuja committed rHG81d1c963e94a: bookmarks: convert opts to bytes dict early.
bookmarks: convert opts to bytes dict early
Fri, Sep 21, 11:16 AM
yuja committed rHG25cc5616adc9: bookmarks: pass in formatter to printbookmarks() instead of opts (API).
bookmarks: pass in formatter to printbookmarks() instead of opts (API)
Fri, Sep 21, 11:16 AM

Thu, Sep 20

yuja committed rHG7cdd47d9ccf8: chgserver: restore pager fds attached within runcommand session.
chgserver: restore pager fds attached within runcommand session
Thu, Sep 20, 3:54 PM
yuja committed rHGa93fe297dfb3: chgserver: add separate flag to remember if stdio fds are replaced.
chgserver: add separate flag to remember if stdio fds are replaced
Thu, Sep 20, 3:54 PM
yuja committed rHGfd805a44b89d: status: remove "morestatus" message from formatter data (BC).
status: remove "morestatus" message from formatter data (BC)
Thu, Sep 20, 3:54 PM
yuja committed rHGe7ae31199ff9: tests: show that the structure of the more status output looks weird.
tests: show that the structure of the more status output looks weird
Thu, Sep 20, 3:54 PM
yuja committed rHGc0c703861b60: phabricator: add testedwith boilerplate.
phabricator: add testedwith boilerplate
Thu, Sep 20, 3:54 PM
yuja added a comment to D4640: narrow: add test showing that local-to-local narrow clones don't work.

+ $ rm -r narrow-via-localpeer
+ rm: narrow-via-localpeer: $ENOENT$
+ [1]

Thu, Sep 20, 7:58 AM
yuja added a comment to D4666: fastannotate: process files as they arrive.

+ for result in results:
+ r = result.result()

Thu, Sep 20, 7:58 AM

Tue, Sep 18

yuja committed rHGfa681452b249: log: make changesetformatter pass in changectx to formatter.
log: make changesetformatter pass in changectx to formatter
Tue, Sep 18, 6:05 PM
yuja committed rHGaa647457df14: journal: use changesetformatter to properly nest list of commits in JSON.
journal: use changesetformatter to properly nest list of commits in JSON
Tue, Sep 18, 6:05 PM
yuja committed rHG2fb88fa2b337: journal: do not pass in repolookuperror string to template (BC).
journal: do not pass in repolookuperror string to template (BC)
Tue, Sep 18, 6:05 PM
yuja committed rHGa7b91509776d: journal: inline formatted nodes and date into expression.
journal: inline formatted nodes and date into expression
Tue, Sep 18, 6:05 PM
yuja committed rHGdea771e63c3c: journal: unify template name for "nodes" (BC).
journal: unify template name for "nodes" (BC)
Tue, Sep 18, 6:05 PM
yuja added a comment to D4635: tests: fix a couple of drawdag.py references.

No idea which is more correct, but drawdag.py is generally paired with
$TESTDIR. Queued, thanks.

Tue, Sep 18, 9:44 AM

Sun, Sep 16

yuja added a comment to D4606: narrow: when writing treemanifests, skip inspecting directories outside narrow.

Looks good to me. One nit.

Sun, Sep 16, 9:48 PM
yuja added a comment to D4610: py3: add b'' prefixes in tests/test-hgweb-no-path-info.t.

Maybe need b'repo'.

Sun, Sep 16, 9:48 PM
yuja committed rHG8bfbb25859f1: censor: rename loop variable to silence pyflakes warning.
censor: rename loop variable to silence pyflakes warning
Sun, Sep 16, 8:01 PM

Sat, Sep 15

yuja added a comment to D4602: phabricator: move extension from contrib to hgext.

Added workaround for test-check-help. as follows:

Sat, Sep 15, 3:23 AM
yuja added a comment to D4600: phabricator: add support for using the vcr library to mock interactions.

Queued the series, thanks.

Sat, Sep 15, 3:12 AM

Fri, Sep 14

yuja added a comment to D4592: py3: use "%f" for floats instead of "%s".
self.automatestdio = True
  • self.ui.debug("mtn automate version %s - using automate stdio\n" % + self.ui.debug("mtn automate version %f - using automate stdio\n" % version)
Fri, Sep 14, 8:11 PM
yuja committed rHG6ecfd12f09cd: identify: change {parents} to a list of nodes (BC).
identify: change {parents} to a list of nodes (BC)
Fri, Sep 14, 6:19 PM
yuja committed rHG10c5eacd793f: identify: use fm.hexfunc thoroughly.
identify: use fm.hexfunc thoroughly
Fri, Sep 14, 6:19 PM
yuja committed rHG713085b45810: formatter: replace contexthint() with demand loading of ctx object.
formatter: replace contexthint() with demand loading of ctx object
Fri, Sep 14, 6:19 PM
yuja committed rHG34ecc0a09c76: formatter: populate ctx from repo and node value.
formatter: populate ctx from repo and node value
Fri, Sep 14, 6:19 PM
yuja committed rHGa2880ac67ee0: help: add internals.wireprotocolrpc to the table.
help: add internals.wireprotocolrpc to the table
Fri, Sep 14, 10:30 AM
yuja committed rHG96bffce40f5b: setup: exclude vendored futures package on Python 3.
setup: exclude vendored futures package on Python 3
Fri, Sep 14, 10:30 AM

Thu, Sep 13

yuja committed rHG87428152e820: templatekw: add experimental {status} keyword.
templatekw: add experimental {status} keyword
Thu, Sep 13, 11:07 AM
yuja committed rHG42209f55c599: templatekw: keep status tuple in cache dict and rename cache key accordingly.
templatekw: keep status tuple in cache dict and rename cache key accordingly
Thu, Sep 13, 11:07 AM
yuja committed rHGa5da906306c9: templatekw: add option to include ignored/clean/unknown files in cache.
templatekw: add option to include ignored/clean/unknown files in cache
Thu, Sep 13, 11:07 AM
yuja committed rHG164827563426: templatekw: extract function that computes and caches file status.
templatekw: extract function that computes and caches file status
Thu, Sep 13, 11:07 AM
yuja committed rHG409c42d6a570: py3: use sysstr() to convert ProgrammingError bytes with no unicode error risk.
py3: use sysstr() to convert ProgrammingError bytes with no unicode error risk
Thu, Sep 13, 11:07 AM

Wed, Sep 12

yuja committed rHG918944f53aac: templatekw: add {size} keyword as an example of fctx-based keyword.
templatekw: add {size} keyword as an example of fctx-based keyword
Wed, Sep 12, 8:10 PM
yuja committed rHGb1239aeef4d9: formatter: populate fctx from ctx and path value.
formatter: populate fctx from ctx and path value
Wed, Sep 12, 8:10 PM
yuja committed rHG990a0b071ea5: formatter: factor out function that detects node change and document it.
formatter: factor out function that detects node change and document it
Wed, Sep 12, 8:10 PM
yuja committed rHG109b2c2d9942: formatter: inline _gettermap and _knownkeys.
formatter: inline _gettermap and _knownkeys
Wed, Sep 12, 8:10 PM
yuja committed rHGee1e74ee037c: formatter: fill missing resources by formatter, not by resource mapper.
formatter: fill missing resources by formatter, not by resource mapper
Wed, Sep 12, 8:10 PM
yuja committed rHG28f974d83c0a: templater: remove unused context argument from most resourcemapper functions.
templater: remove unused context argument from most resourcemapper functions
Wed, Sep 12, 8:10 PM
yuja committed rHG68ce242c8b4b: ancestor: remove extra generator from lazyancestors.__iter__().
ancestor: remove extra generator from lazyancestors.__iter__()
Wed, Sep 12, 8:10 PM
yuja committed rHG623081f2abc2: narrow: remove hack to write narrowspec to shared .hg directory.
narrow: remove hack to write narrowspec to shared .hg directory
Wed, Sep 12, 9:55 AM
yuja committed rHGc8ea5c7ec99d: narrowspec: remove parseserverpatterns() which isn't used anymore.
narrowspec: remove parseserverpatterns() which isn't used anymore
Wed, Sep 12, 9:55 AM
yuja added a comment to D4541: hg: write narrow patterns after repo creation.

Looks good. Queued the series, thanks.

Wed, Sep 12, 8:57 AM
yuja added a comment to D4535: hg: allow extra arguments to be passed to repo creation.

+def filterknowncreateopts(ui, createopts):
+ """Filters a dict of repo creation options against options that are known.

Wed, Sep 12, 8:43 AM

Tue, Sep 11

yuja committed rHG238a1480d7ad: ancestor: use heapreplace() in place of heappop/heappush().
ancestor: use heapreplace() in place of heappop/heappush()
Tue, Sep 11, 7:33 PM
yuja committed rHGca9983c35d89: ancestor: rename local aliases of heapq functions in _lazyancestorsiter().
ancestor: rename local aliases of heapq functions in _lazyancestorsiter()
Tue, Sep 11, 7:33 PM
yuja committed rHGbdb177923291: ancestor: optimize _lazyancestorsiter() for contiguous chains.
ancestor: optimize _lazyancestorsiter() for contiguous chains
Tue, Sep 11, 7:33 PM
yuja committed rHGb9ee9c2e10dd: ancestor: unroll loop of parents in _lazyancestorsiter().
ancestor: unroll loop of parents in _lazyancestorsiter()
Tue, Sep 11, 7:33 PM
yuja committed rHGfd9029d36c41: ancestor: return early from _lazyancestorsiter() when reached to stoprev.
ancestor: return early from _lazyancestorsiter() when reached to stoprev
Tue, Sep 11, 7:33 PM
yuja committed rHGf6bcb4f9cd3c: ancestor: remove alias of initrevs from _lazyancestorsiter().
ancestor: remove alias of initrevs from _lazyancestorsiter()
Tue, Sep 11, 7:33 PM
yuja added a comment to D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher.
> Any reason not to use `self._loadlazy(kslash)`?

Hmm, I feel like there was a previous version that iterated differently and meant I'd need a copy of the list to do this correctly.. in this version, no I don't think there's a reason to avoid it besides a potential minor speed difference; should I send a patch for that?
Tue, Sep 11, 6:57 PM
yuja added a comment to D4370: treemanifest: use visitchildrenset when filtering a manifest to a matcher.

+ def _loadchildrensetlazy(self, visit):
+ if not visit:
+ return None
+ if visit == 'all' or visit == 'this':
+ self._loadalllazy()
+ return None
+
+ todel = []
+ for k in visit:
+ kslash = k + '/'
+ ld = self._lazydirs.get(kslash)
+ if ld:
+ path, node, readsubtree = ld
+ self._dirs[kslash] = readsubtree(path, node)
+ todel.append(kslash)
+ for kslash in todel:
+ del self._lazydirs[kslash]

Tue, Sep 11, 8:26 AM

Mon, Sep 10

yuja added a comment to D4508: lazyancestors: reuse __iter__ implementation in __contains__.

Queued, thanks.

Mon, Sep 10, 7:54 AM

Sat, Sep 8

yuja added a comment to D4508: lazyancestors: reuse __iter__ implementation in __contains__.

Perhaps iter() needs to be extracted to a free function to avoid
reference cycle.

Sat, Sep 8, 4:33 AM
yuja committed rHG7eadc9407867: ancestor: filter out initial revisions lower than stoprev.
ancestor: filter out initial revisions lower than stoprev
Sat, Sep 8, 2:20 AM
yuja committed rHG431068d7e9db: ancestor: add test showing inconsistency between __iter__ and __contains__.
ancestor: add test showing inconsistency between __iter__ and __contains__
Sat, Sep 8, 2:20 AM

Fri, Sep 7

yuja committed rHG4e4fae1dda5c: doc: use modern import style in runrst.
doc: use modern import style in runrst
Fri, Sep 7, 11:54 AM
yuja committed rHG15e8250a82da: hgweb: do not audit URL path as working-directory path.
hgweb: do not audit URL path as working-directory path
Fri, Sep 7, 11:53 AM
yuja committed rHG17ca967e9fca: hgweb: map Abort to 403 error to report inaccessible path for example.
hgweb: map Abort to 403 error to report inaccessible path for example
Fri, Sep 7, 11:53 AM
yuja committed rHG1a786fe069b8: hgweb: add error template to json so it won't crash.
hgweb: add error template to json so it won't crash
Fri, Sep 7, 11:53 AM
yuja committed rHG6772cf74ff6f: hgweb: show shortlog by default in json output (issue5978).
hgweb: show shortlog by default in json output (issue5978)
Fri, Sep 7, 11:53 AM
yuja added a comment to D4477: merge: move purge logic from extension.

Queued the series, thanks.

Fri, Sep 7, 8:05 AM

Thu, Sep 6

yuja committed rHG7df9ae38c75c: help: add internals.wireprotocolv2 to the table, and remove redundant header.
help: add internals.wireprotocolv2 to the table, and remove redundant header
Thu, Sep 6, 1:04 PM
yuja added a comment to D4477: merge: move purge logic from extension.

+def purge(repo, dirs=None, ignored=False, removeemptydirs=True,
+ removefiles=True, abortonerror=False, include=None, exclude=None,
+ noop=False):

Thu, Sep 6, 8:47 AM
yuja added a comment to D4493: buildrpm: fix embarassing bug in shell variable expansions.

Queued for stable, thanks.

Thu, Sep 6, 8:18 AM
yuja added a comment to D4351: match: improve includematcher.visitchildrenset to be much faster and cached.

Queued, thanks.

Thu, Sep 6, 8:08 AM

Wed, Sep 5

yuja committed rHG094d1f42c484: manifest: fix leak on error return from lazymanifest_filtercopy().
manifest: fix leak on error return from lazymanifest_filtercopy()
Wed, Sep 5, 12:02 PM
yuja committed rHGadacefb0b7ea: dirstate: use tuple interface to fix leak in pack_dirstate().
dirstate: use tuple interface to fix leak in pack_dirstate()
Wed, Sep 5, 12:02 PM
yuja committed rHGca77788c81bc: manifest: incref/decref copy->pydata to clarify 'copy' holds a reference.
manifest: incref/decref copy->pydata to clarify 'copy' holds a reference
Wed, Sep 5, 12:02 PM
yuja committed rHGad76032d27da: xdiff: fix leak in hunk_consumer().
xdiff: fix leak in hunk_consumer()
Wed, Sep 5, 12:02 PM
yuja committed rHG91477b123700: base85: fix leak on error return from b85decode().
base85: fix leak on error return from b85decode()
Wed, Sep 5, 12:02 PM

Tue, Sep 4

yuja committed rHGb69fbdd77c40: revlog: fix size of Python nodetree object.
revlog: fix size of Python nodetree object
Tue, Sep 4, 11:22 AM

Mon, Sep 3

yuja committed rHG1cbe19eb496d: revert: stabilize status message of chunks selected interactively.
revert: stabilize status message of chunks selected interactively
Mon, Sep 3, 3:55 PM
yuja added a comment to D4434: cborutil: add a buffering decoder.

Queued up to this patch, thanks. The decoder looks promising.

Mon, Sep 3, 9:38 AM
yuja added a comment to D4380: revert: fix the inconsistency of status msgs in --interactive mode.

Queued, thanks.

Mon, Sep 3, 7:32 AM
yuja added a reverting commit for rHGcdbc25306696: run-tests: add --with-python3 to define a Python 3 interpreter: rHG66b5ded95185: run-tests: drop support for --with-python3 and $PYTHON3.
Mon, Sep 3, 6:37 AM
yuja committed rHG66b5ded95185: run-tests: drop support for --with-python3 and $PYTHON3.
run-tests: drop support for --with-python3 and $PYTHON3
Mon, Sep 3, 6:37 AM
yuja committed rHGecbab8be7470: test-check-py3-compat: don't run py3 part if not build against python3.
test-check-py3-compat: don't run py3 part if not build against python3
Mon, Sep 3, 6:36 AM
yuja committed rHG0cbcf962847e: test-check-py3-compat: don't run py2 part if $PYTHON is python3.
test-check-py3-compat: don't run py2 part if $PYTHON is python3
Mon, Sep 3, 6:36 AM

Sat, Sep 1

yuja committed rHGda84cca65036: shelve: fix crash on unshelve without .shelve metadata file.
shelve: fix crash on unshelve without .shelve metadata file
Sat, Sep 1, 11:02 AM
yuja committed rHG2df3271ef139: fastannotate: use stringutil.pprint() to dump diffopts to be hashed.
fastannotate: use stringutil.pprint() to dump diffopts to be hashed
Sat, Sep 1, 8:32 AM
yuja committed rHG34ef6a5a7bcd: test-check-py3-compat: update "python3 check-py3-compat.py" output.
test-check-py3-compat: update "python3 check-py3-compat.py" output
Sat, Sep 1, 8:32 AM
yuja committed rHG722eab64f1ed: test-check-py3-compat: exclude thirdparty and cffi which are known to fail.
test-check-py3-compat: exclude thirdparty and cffi which are known to fail
Sat, Sep 1, 8:32 AM
yuja committed rHG875e635c201c: test-check-py3-compat: remove false output from "python3 check-py3-compat.py".
test-check-py3-compat: remove false output from "python3 check-py3-compat.py"
Sat, Sep 1, 8:32 AM

Fri, Aug 31

yuja committed rHGede3bf31fe63: hgweb: load revcount + 1 entries to fill nextentry in log page (issue5972).
hgweb: load revcount + 1 entries to fill nextentry in log page (issue5972)
Fri, Aug 31, 11:05 PM
yuja added a comment to D4432: py3: do .decode(), .encode() dance in runtests.py.
def toggletrace(cmd):
  • quoted = shellquote(cmd.strip()).replace(b'\\', b'\\\\') + cmd = cmd.decode('ascii') + quoted = shellquote(cmd.strip()).encode('ascii') + quoted = quoted.replace(b'\\', b'\\\\')
Fri, Aug 31, 8:29 PM
yuja added a comment to D4380: revert: fix the inconsistency of status msgs in --interactive mode.

@@ -3034,7 +3035,19 @@

prefetch(repo, [ctx.rev()],
         matchfiles(repo,
                    [f for sublist in oplist for f in sublist]))
  • _performrevert(repo, parents, ctx, actions, interactive, tobackup) + # give status messages for actions to be performed + acts = "add drop undelete forget remove revert".split() + if interactive: + # exclude ("forget", "remove", "revert") as status msg for these + # actions will be handled in interactive session. + acts = acts[:3] + for act in acts: + for f in actions[act][0]: + rel, exact = names[f] + if ui.verbose or not exact: + ui.status(actions[act][1] % rel) + _performrevert(repo, parents, ctx, names, actions, interactive, + tobackup)
Fri, Aug 31, 7:53 AM
yuja added a comment to D4380: revert: fix the inconsistency of status msgs in --interactive mode.

> + if ui.verbose or not exact:
> + if not isinstance(msg, bytes):
> + msg = msg(abs)

Does this conditional doing something useful because I don't see any change in the tests if I remove line 3023,3024?

Fri, Aug 31, 7:53 AM

Thu, Aug 30

yuja committed rHG34ba47117164: formatter: rename {abspath}/{file} to {path}, and drop relative {path} (BC).
formatter: rename {abspath}/{file} to {path}, and drop relative {path} (BC)
Thu, Aug 30, 11:53 AM
yuja committed rHG3cd977d5a16b: templatekw: add {path} keyword to host documentation.
templatekw: add {path} keyword to host documentation
Thu, Aug 30, 11:53 AM
yuja committed rHG46f3ff64bea7: status: rename {copy} to {source} for compatibility with {file_copies} (BC).
status: rename {copy} to {source} for compatibility with {file_copies} (BC)
Thu, Aug 30, 11:53 AM
yuja committed rHG5b1d406b39f1: templatekw: alias {name} of file copies dict to {path}.
templatekw: alias {name} of file copies dict to {path}
Thu, Aug 30, 11:53 AM
yuja committed rHG83f8f7b9fa60: templatekw: alias {file} of files list to {path}.
templatekw: alias {file} of files list to {path}
Thu, Aug 30, 11:53 AM
yuja added a comment to D4416: copies: improve logic of deciding copytracing on based of config options.

+ elif boolctrace is False:
+ # stringutil.parsebool() returns None when it is unable to parse the
+ # value, so we should rely on making sure copytracing is on such cases

Thu, Aug 30, 9:33 AM