yuja (Yuya Nishihara)
User

Projects

User Details

User Since
Jun 29 2017, 11:25 AM (28 w, 5 d)

Recent Activity

Today

yuja committed rHG821d8a5ab4ff: match: do not weirdly include explicit files excluded by -X option.
match: do not weirdly include explicit files excluded by -X option
Tue, Jan 16, 3:16 PM

Yesterday

yuja accepted D1860: dispatch: handle IOError when writing to stderr.
Mon, Jan 15, 8:12 AM
yuja accepted D1859: commandserver: restore cwd in case of exception.
Mon, Jan 15, 8:08 AM
yuja accepted D1858: tests: make hg frame optional.
Mon, Jan 15, 8:05 AM
yuja added a comment to D1858: tests: make hg frame optional.

I think the frame details aren't important here, so making some lines optional
should be just fine.

Mon, Jan 15, 8:05 AM

Sun, Jan 14

yuja committed rHGa177c6aa055a: log: rewrite --follow-first -rREV like --follow for consistency (BC).
log: rewrite --follow-first -rREV like --follow for consistency (BC)
Sun, Jan 14, 4:19 PM
yuja committed rHGb6b7855c79aa: log: use revsetlang.formatspec() thoroughly.
log: use revsetlang.formatspec() thoroughly
Sun, Jan 14, 4:19 PM
yuja committed rHG7a0a90d63a8c: log: use revsetlang.formatspec() to concatenate list expression.
log: use revsetlang.formatspec() to concatenate list expression
Sun, Jan 14, 4:19 PM
yuja committed rHG668c5a527eff: log: simplify 'x or ancestors(x)' expression.
log: simplify 'x or ancestors(x)' expression
Sun, Jan 14, 4:19 PM
yuja committed rHGe64baf32782a: log: make opt2revset table a module constant.
log: make opt2revset table a module constant
Sun, Jan 14, 4:19 PM
yuja committed rHGfa9747e7fc86: rust: convert Unix path to CString transparently.
rust: convert Unix path to CString transparently
Sun, Jan 14, 2:52 PM
yuja committed rHGedbe11cfedcf: rust: extract function to convert Path to platform CString.
rust: extract function to convert Path to platform CString
Sun, Jan 14, 2:52 PM
yuja committed rHG390f860228ba: vfs: drop text mode flag (API).
vfs: drop text mode flag (API)
Sun, Jan 14, 2:27 AM
yuja committed rHG188b1371d1ed: lfs: convert EOL of hgrc before appending to bytes IO.
lfs: convert EOL of hgrc before appending to bytes IO
Sun, Jan 14, 2:22 AM
yuja committed rHGe925f33ac088: share: convert EOL of hgrc before writing to bytes IO.
share: convert EOL of hgrc before writing to bytes IO
Sun, Jan 14, 2:22 AM
yuja committed rHGf56f8abbeaf1: largefiles: convert EOL of hgrc before appending to bytes IO.
largefiles: convert EOL of hgrc before appending to bytes IO
Sun, Jan 14, 2:22 AM
yuja committed rHG38649e2fbf6c: subrepo: convert EOL of hgrc before writing to bytes IO.
subrepo: convert EOL of hgrc before writing to bytes IO
Sun, Jan 14, 2:22 AM
yuja committed rHG545967ec33dc: clone: use utility function to write hgrc.
clone: use utility function to write hgrc
Sun, Jan 14, 2:22 AM
yuja committed rHGc751b9fdbc40: share: use context manager or utility function to write file.
share: use context manager or utility function to write file
Sun, Jan 14, 2:22 AM

Fri, Jan 12

yuja added a comment to D1855: explicitly kill server processes.

Just for the record, explicit killdaemon isn't needed unless you want
to do something (e.g. checking server logs) after that. Daemons are
kill by the test runner.

Fri, Jan 12, 9:47 PM
yuja accepted D1854: py3: use bytes instead of pycompat.bytestr.
Fri, Jan 12, 9:44 PM
yuja added inline comments to D1795: py3: use pycompat.bytestr() instead of str().
Fri, Jan 12, 8:41 AM
yuja added a comment to D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set.

Queued, thanks.

Fri, Jan 12, 8:31 AM
yuja accepted D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set.
Fri, Jan 12, 8:27 AM
yuja added a comment to D1852: visibility: make the filtered message translatable.

FWIW, it might be good idea to move context._filterederror() to obsutil.py
because context.py is painfully big.

Fri, Jan 12, 7:34 AM
yuja accepted D1853: visiblity: pass a normal repo to _getfilteredreason.
Fri, Jan 12, 7:30 AM
yuja accepted D1852: visibility: make the filtered message translatable.
Fri, Jan 12, 7:30 AM
yuja accepted D1851: visibilty: fix a comment introduced before which is not up-to-date.
Fri, Jan 12, 7:30 AM
yuja added inline comments to D1795: py3: use pycompat.bytestr() instead of str().
Fri, Jan 12, 7:25 AM
yuja added a comment to D1694: debugcommands: replace opts.get('foo') by opts['foo'].

I think it's probably okay for debug commands, those are pretty rare to use as a function aren't they?

Fri, Jan 12, 7:17 AM

Thu, Jan 11

yuja added inline comments to D1797: py3: make sure we open the file to write in bytes mode.
Thu, Jan 11, 9:40 AM
yuja added a comment to D1795: py3: use pycompat.bytestr() instead of str().

bytes() or "%d" is preferred. Can you send a follow up?

Thu, Jan 11, 9:34 AM
yuja added inline comments to D1591: visibility: improve the message when accessing filtered obsolete rev.
Thu, Jan 11, 9:20 AM
yuja added inline comments to D1591: visibility: improve the message when accessing filtered obsolete rev.
Thu, Jan 11, 9:10 AM
yuja accepted D1845: rust: move import of PathBuf.
Thu, Jan 11, 8:10 AM
yuja accepted D1847: rust: add TODO about lifetime of program_name variable.
Thu, Jan 11, 8:10 AM
yuja added a comment to D1846: rust: avoid redundant 'static lifetime.

I think it's new feature. Which Rust version should we support?

Thu, Jan 11, 8:08 AM
yuja accepted D1848: perf: do not import util.queue.
Thu, Jan 11, 8:03 AM
yuja requested changes to D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set.
Thu, Jan 11, 7:47 AM
yuja added inline comments to D1581: rust: implementation of `hg`.
Thu, Jan 11, 7:31 AM

Wed, Jan 10

yuja committed rHGed0902e8053e: revsetlang: add %p specifier to format list of function arguments.
revsetlang: add %p specifier to format list of function arguments
Wed, Jan 10, 6:13 PM
yuja committed rHG91201737d07a: revsetlang: fix quoting of %ls string.
revsetlang: fix quoting of %ls string
Wed, Jan 10, 6:13 PM
yuja committed rHGa57acea31b3b: revsetlang: unnest inner functions from formatspec().
revsetlang: unnest inner functions from formatspec()
Wed, Jan 10, 6:13 PM
yuja committed rHG468d7a1f6633: revsetlang: catch invalid value passed to formatspec().
revsetlang: catch invalid value passed to formatspec()
Wed, Jan 10, 6:13 PM
yuja committed rHG850cd045b1df: revsetlang: check incomplete revspec format character.
revsetlang: check incomplete revspec format character
Wed, Jan 10, 6:13 PM
yuja committed rHG0fd617afebc0: revsetlang: check number of arguments passed to formatspec().
revsetlang: check number of arguments passed to formatspec()
Wed, Jan 10, 6:13 PM
yuja committed rHG8f1a7adb3225: revsetlang: catch invalid format character with %l prefix.
revsetlang: catch invalid format character with %l prefix
Wed, Jan 10, 6:13 PM
yuja accepted D1830: test-run-tests: stabilize the test (issue5735).

Queued for stable. Thanks for fixing this issue.

Wed, Jan 10, 8:21 AM
yuja added inline comments to D1581: rust: implementation of `hg`.
Wed, Jan 10, 8:06 AM
yuja requested changes to D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set.
Wed, Jan 10, 7:55 AM
yuja requested changes to D1827: scmutil: add warnmessage argument to unhidehashlikerevs function.
Wed, Jan 10, 7:52 AM

Sun, Jan 7

yuja committed rHGd1aae6d4efc5: templatefilters: fix doc of basename().
templatefilters: fix doc of basename()
Sun, Jan 7, 10:51 PM
yuja committed rHGf39cf992216f: identify: document -r. explicitly how to disable wdir scanning (issue5622).
identify: document -r. explicitly how to disable wdir scanning (issue5622)
Sun, Jan 7, 10:51 PM
yuja committed rHG4c3a4bb31c0e: revsetlang: raise ParseError to report invalid format character.
revsetlang: raise ParseError to report invalid format character
Sun, Jan 7, 10:49 PM
yuja committed rHG3a8810c1b9bc: revsetlang: use iterator to track current argument in formatspec().
revsetlang: use iterator to track current argument in formatspec()
Sun, Jan 7, 10:49 PM
yuja committed rHGa480551bd1b4: revsetlang: unnest "if True" in formatrevspec().
revsetlang: unnest "if True" in formatrevspec()
Sun, Jan 7, 10:49 PM
yuja committed rHGdfc628611144: revsetlang: use str.find() to scan expr in formatspec().
revsetlang: use str.find() to scan expr in formatspec()
Sun, Jan 7, 10:49 PM
yuja committed rHG2df8d12f23bc: revsetlang: avoid string concatenation in formatspec().
revsetlang: avoid string concatenation in formatspec()
Sun, Jan 7, 10:49 PM
yuja committed rHGb58964b9b541: test-glog: hook cmdutil.getlogrevs() so -frREV is rewritten accordingly.
test-glog: hook cmdutil.getlogrevs() so -frREV is rewritten accordingly
Sun, Jan 7, 10:43 PM
yuja committed rHGd984d9b3411e: test-glog: dump computed set.
test-glog: dump computed set
Sun, Jan 7, 10:42 PM
yuja committed rHG99a25bde65a3: test-glog: drop uninteresting nodes from AST output.
test-glog: drop uninteresting nodes from AST output
Sun, Jan 7, 10:42 PM

Sat, Jan 6

yuja committed rHG94a127152e25: win32: allocate buffer of maximum length for GetVolumeInformation().
win32: allocate buffer of maximum length for GetVolumeInformation()
Sat, Jan 6, 3:47 PM
yuja committed rHGed30934165c9: win32: do not call GetVolumePathName() with the minimum buffer length.
win32: do not call GetVolumePathName() with the minimum buffer length
Sat, Jan 6, 3:47 PM
yuja committed rHGb14c8bcfbad9: log: drop unused expr from return value of getlogrevs().
log: drop unused expr from return value of getlogrevs()
Sat, Jan 6, 3:47 PM
yuja committed rHGb6dbc860570d: log: don't expand aliases in revset built from command options.
log: don't expand aliases in revset built from command options
Sat, Jan 6, 3:47 PM
yuja committed rHG5e1d4ccab455: graphlog: remove redundant check for empty revs.
graphlog: remove redundant check for empty revs
Sat, Jan 6, 3:47 PM
yuja committed rHG349bcd7fa670: log: remove redundant handling of --limit.
log: remove redundant handling of --limit
Sat, Jan 6, 3:47 PM
yuja committed rHG8494944940e5: log: use smartset.slice() to limit number of revisions to be displayed.
log: use smartset.slice() to limit number of revisions to be displayed
Sat, Jan 6, 3:47 PM
yuja committed rHGa7f7eff4ec08: log: merge getlogrevs() and getgraphlogrevs().
log: merge getlogrevs() and getgraphlogrevs()
Sat, Jan 6, 3:47 PM
yuja committed rHGbeb667c9880f: revset: parse x^:: as (x^):: (issue5764).
revset: parse x^:: as (x^):: (issue5764)
Sat, Jan 6, 3:47 PM
yuja accepted D1816: tests: make #testcase available as env var in test.

Are you thinking that it may be useful if the function in my test case is instead a stand-alone script/binary?

Sat, Jan 6, 2:27 AM

Fri, Jan 5

yuja requested changes to D1816: tests: make #testcase available as env var in test.
Fri, Jan 5, 9:38 PM
yuja requested changes to D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set.

Needs some warning since a hidden revision may be revived?

Fri, Jan 5, 9:36 PM
yuja accepted D1812: archive: add support to specify hidden revs if directaccess config is set.
Fri, Jan 5, 9:31 PM
yuja accepted D1811: annotate: add support to specify hidden revs if directaccess config is set.
Fri, Jan 5, 9:31 PM
yuja accepted D1810: hgdemandimport: use correct hyperlink to python-bug in comments (issue5765).
Fri, Jan 5, 8:32 AM
yuja requested changes to D1810: hgdemandimport: use correct hyperlink to python-bug in comments (issue5765).

I'm drunk, but I'm sure this is good. Queued, thanks.

Fri, Jan 5, 8:31 AM
yuja requested changes to D1581: rust: implementation of `hg`.

Suppose this is a kind of contrib code, I think it's good enough to accept.
Can you drop Cargo.lock file?

Fri, Jan 5, 2:38 AM
yuja accepted D1764: revlog: don't use slicing to return parents.
Fri, Jan 5, 12:48 AM
yuja added a comment to D1773: revlog: use named attributes on revlog index entries.

However, it is quite large and I suspect it will take a bit more effort to finish it.

Fri, Jan 5, 12:43 AM
yuja requested changes to D1769: cext: use dedicated type for index entries.
Fri, Jan 5, 12:22 AM

Thu, Jan 4

yuja requested changes to D1768: cext: obtain reference to index entry type.

We hold off incrementing the version of the "parsers" extension
because nothing in core relies on the new API yet.

Thu, Jan 4, 11:54 PM
yuja requested changes to D1767: cext: make nullentry a member of index types.
Thu, Jan 4, 10:53 PM
yuja requested changes to D1765: parsers: use an attr-derived class for revlog index entries.
Thu, Jan 4, 10:50 PM
yuja accepted D1762: update: support updating to hidden cset if directaccess config is set.
Thu, Jan 4, 3:49 AM
yuja accepted D1760: commands: check for empty rev before passing to scmutil.unhidehashlikerevs.
Thu, Jan 4, 3:49 AM

Thu, Dec 28

yuja added a comment to D1773: revlog: use named attributes on revlog index entries.

Because we're now using a custom type and conforming to
a yet-to-be-formally-defined interface, there's nothing
preventing us from implementing a backed-by-C custom type
for revlog entries.

Thu, Dec 28, 9:04 AM
yuja added inline comments to D1753: streamclone: preserve remote phases (issue5648).
Thu, Dec 28, 8:14 AM
yuja accepted D1780: smartset: split generatorset classes to avoid cycle.

Queued, thanks. I've made asc/desc classes private as their constructor
behavior is weird.

Thu, Dec 28, 7:24 AM

Wed, Dec 27

yuja requested changes to D1762: update: support updating to hidden cset if directaccess config is set.
Wed, Dec 27, 7:29 AM
yuja requested changes to D1760: commands: check for empty rev before passing to scmutil.unhidehashlikerevs.

Can you update the other callers which pass ['']?

Wed, Dec 27, 7:22 AM
yuja accepted D1763: revert: support reverting to hidden cset if directaccess config is set.
Wed, Dec 27, 7:20 AM
yuja accepted D1761: scmutil: use a tuple of possible values instead of using startswith().
Wed, Dec 27, 7:20 AM
yuja committed rHGdfaf9f10e2e5: show: use revlog function to compute length of the longest shortest node.
show: use revlog function to compute length of the longest shortest node
Wed, Dec 27, 12:53 AM

Tue, Dec 26

yuja added inline comments to D1735: commands: use the new API to access hidden changesets in various commands.
Tue, Dec 26, 8:55 AM
yuja added inline comments to D1733: scmutil: add utility fn to return repo object with user passed revs unhidden.
Tue, Dec 26, 8:51 AM
yuja added a comment to D1747: repoview: add visibilityexception argument to filterrevs() and related fns.

FWIW, if the cache don't include "unhidden" revisions, maybe we don't
need new filter names like 'visible-hidden"?

Yep I agree, but I wanted be on the safe side to prevent unknown bugs by using the same filtername.

Tue, Dec 26, 8:47 AM
yuja accepted D1735: commands: use the new API to access hidden changesets in various commands.
Tue, Dec 26, 8:43 AM
yuja accepted D1734: repoview: add a new filtername for accessing hidden commits.
Tue, Dec 26, 8:43 AM
yuja accepted D1733: scmutil: add utility fn to return repo object with user passed revs unhidden.
Tue, Dec 26, 8:43 AM