HomePhabricator

p4fastimport: don't inline data as a workaround for an inline separation issue

Authored by dsp.

Description

p4fastimport: don't inline data as a workaround for an inline separation issue

Summary:
Writing multiple entries to a revlog at the same time can trigger a bug
in revlog caching when a revlog separation of inlined data happend. New
transaction postprocessing callbacks will cause a changelog read which
triggers this bug, therefore we force revlogs to be separated from the
beginning, as a workaround for this bug until it's fixed upstream.

Test Plan:
Run an import of 600 revisions on a test server. Saw failure.
Run import with patch appleid of 600 revisions on test server. Failured
disappeared.

Reviewers: #mercurial, rmcelroy

Reviewed By: rmcelroy

Subscribers: mitrandir, rmcelroy, medson, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D5535509

Signature: t1:5535509:1501613606:97a0a2dca19ae6e915d4777ec6b14d1e9db46242

Details

Committed
dspAug 2 2017, 3:00 AM
Parents
rFBHGX3d1bfe28be54: p4fastimport: append transactions instead of overwriting
Branches
Unknown
Tags
Unknown