HomePhabricator

sigpipe-remote: simply delegate pipe forwarding to subprocess we can kill

Authored by marmoute.

Description

sigpipe-remote: simply delegate pipe forwarding to subprocess we can kill

Instead of using sophisticated logics with thread a non blocking pipes, we
simply spawn two new process in charge of reading the pipe and sending the
result to the client. When it is time to cut the pipe we violently kill them
without any remorse. This close the pipe regardless of any in progress os.read
call.

Ironically this is the very same things as what the initial shell setup was
doing, but in Python.

This makes the test pass run properly on Windows. This also reveal that the
Windows behavior is broken as the transaction is not properly rollback. However
this is an adventure for another time. Making the test behave properly was
enough effort.

Differential Revision: https://phab.mercurial-scm.org/D11087