HomePhabricator

engine: unwrap a hard to understand for loop

Authored by pulkit.

Description

engine: unwrap a hard to understand for loop

The loop was iterating over all the datafiles and maintaining a set to check
whether filelogs have been processed, manifests have been processed or not.

The code was hard to understand and it assumed that alldatafiles are ordered
in a certain way.

This refactors the for loop in separate parts for each manifests, changelog and
filelogs. This will also help in future work where we will like more better
handling on whether we want to upgrade filelogs or not.

Differential Revision: https://phab.mercurial-scm.org/D9580

Details

Committed
pulkitDec 14 2020, 4:08 AM
Differential Revision
D9580: engine: unwrap a hard to understand for loop
Parents
rHG85f7cf314b39: engine: refactor actual cloning code into separate function
Branches
Unknown
Tags
Unknown

Event Timeline

Best 10 Minute At Home Workouts
If you're looking for a 10 minute workout, we've got 10 of them for you right ... on YouTube with our at-home workout series Sweat With SELF.