HomePhabricator

record: prevent commits that don't pick up dirty subrepo changes (issue6102)

Authored by mharbison72.

Description

record: prevent commits that don't pick up dirty subrepo changes (issue6102)

This path covers interactive mode for commit, amend, and shelve, as well as the
deprecated record extension. Since shelf creation uses commit without -S in the
non-interactive case, aborting here should be OK. (I didn't check what happens
to non interactive shelve creation if ui.commitsubrepos=True is set.)

subrepoutil.precommit() will abort on a dirty subrepo if the config option isn't
set, but the hint recommends using --subrepos to commit. Since only the commit
command currently supports that option, the error has to be raised here to omit
the hint.

Doing the check before asking about all of the hunks in the MQ test seems like
an improvement on its own. There's probably an additional check on this path
that can be removed.

Details

Committed
mharbison72Mar 16 2019, 2:40 PM
Parents
rHG406519302520: test-https: add some more known failure messages of client certs (issue6030)
Branches
Unknown
Tags
Unknown