HomePhabricator

commitctx: stop using weakref proxy for transaction

Authored by marmoute.

Description

commitctx: stop using weakref proxy for transaction

This weakref proxy was introduced in 2007 by 30d4d8985dd8.

If I understand it correctly, the logic at that time was relying on the
transaction destructor, triggered at garbage collection time to rollback failed
transaction. passing the object to sub function directly mean it would live in
the function scope and be trapped in the traceback on exception, leading to the
transaction rollback too late in some case.

Modern transaction usage use explicit opening and closing of transaction and no
longer rely on some internal reference counting details. So this weakref proxy
is no longer necessary. Absolutely no test are affected when we drop it.

Details

Committed
marmouteJul 24 2020, 6:52 AM
Parents
rHGd056a131c93f: commitctx: document the None return for "touched" value
Branches
Unknown
Tags
Unknown